Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Fix flaky assertion for "sdk iframe embedding fires ready event after iframe is loaded" (#68336)

Phoomparin Manoa27a3d286b22
diff --git a/e2e/test/scenarios/embedding/sdk-iframe-embedding/sdk-iframe-embedding.cy.spec.ts b/e2e/test/scenarios/embedding/sdk-iframe-embedding/sdk-iframe-embedding.cy.spec.ts
index 89ebf4a962f..7807a51b89e 100644
--- a/e2e/test/scenarios/embedding/sdk-iframe-embedding/sdk-iframe-embedding.cy.spec.ts
+++ b/e2e/test/scenarios/embedding/sdk-iframe-embedding/sdk-iframe-embedding.cy.spec.ts
@@ -208,29 +208,26 @@ describe("scenarios > embedding > sdk iframe embedding", () => {
},
},
],
- onVisitPage: () => {
- cy.window().then((win) => {
- const element = win.document!.querySelector("metabase-question")!;
- element.addEventListener("ready", () => {
- win.document!.body.setAttribute(
- "data-consumer-event-triggered",
- "true",
- );
- });
+ onVisitPage: (win) => {
+ const element = win.document.querySelector("metabase-question")!;
+ element.addEventListener("ready", () => {
+ win.document.body.setAttribute(
+ "data-consumer-event-triggered",
+ "true",
+ );
});
+
+ // assert that the attribute is not set at the start
+ const attrValue = win.document.body.getAttribute(
+ "data-consumer-event-triggered",
+ );
+ expect(attrValue).to.not.equal("true");
},
});
- cy.log("ready event should not be fired before the page loads");
- cy.get("body").should(
- "not.have.attr",
- "data-consumer-event-triggered",
- "true",
- );
-
cy.wait("@getCardQuery");
- cy.log("ready event should be fired after the page loads");
+ cy.log("ready event should be fired after the iframe is loaded");
cy.get("iframe").should("be.visible");
cy.get("body").should("have.attr", "data-consumer-event-triggered", "true");