Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Fix broken eslint tests (#68994)

Nemanja Glumaca2f819bd08b2
diff --git a/frontend/lint/tests/jtag-missing-key.unit.spec.js b/frontend/lint/tests/jtag-missing-key.unit.spec.js
index 68760b02c6b..532ce73c05a 100644
--- a/frontend/lint/tests/jtag-missing-key.unit.spec.js
+++ b/frontend/lint/tests/jtag-missing-key.unit.spec.js
@@ -1,6 +1,6 @@
import { RuleTester } from "eslint";
-import jtagKey from "../eslint-rules/jtag-missing-key";
+import rule from "../eslint-plugin-metabase/rules/jtag-missing-key";
const ruleTester = new RuleTester({
languageOptions: {
@@ -95,7 +95,7 @@ const message = jt\`Fragment \${(<><Icon name="test" /><span>content</span></>)}
},
];
-ruleTester.run("jtag-key", jtagKey, {
+ruleTester.run("jtag-key", rule, {
valid: VALID_CASES,
invalid: INVALID_CASES.map((invalidCase) => {
const errorCount = invalidCase.errorCount || 1;
diff --git a/frontend/lint/tests/no-literal-metabase-strings.unit.spec.js b/frontend/lint/tests/no-literal-metabase-strings.unit.spec.js
index 731e0436118..a543ddb9b38 100644
--- a/frontend/lint/tests/no-literal-metabase-strings.unit.spec.js
+++ b/frontend/lint/tests/no-literal-metabase-strings.unit.spec.js
@@ -1,6 +1,6 @@
import { RuleTester } from "eslint";
-import noLiteralMetabaseString from "../eslint-rules/no-literal-metabase-strings";
+import rule from "../eslint-plugin-metabase/rules/no-literal-metabase-strings";
const ruleTester = new RuleTester({
languageOptions: {
@@ -120,7 +120,7 @@ const INVALID_CASES = [
},
];
-ruleTester.run("no-literal-metabase-strings", noLiteralMetabaseString, {
+ruleTester.run("no-literal-metabase-strings", rule, {
valid: VALID_CASES,
invalid: INVALID_CASES.map((invalidCase) => ({
code: invalidCase.code,
diff --git a/frontend/lint/tests/no-locale-with-intl-functions.unit.spec.js b/frontend/lint/tests/no-locale-with-intl-functions.unit.spec.js
index 3bba29ace47..34901832d92 100644
--- a/frontend/lint/tests/no-locale-with-intl-functions.unit.spec.js
+++ b/frontend/lint/tests/no-locale-with-intl-functions.unit.spec.js
@@ -1,6 +1,6 @@
import { RuleTester } from "eslint";
-import noLocaleWithIntlFunctions from "../eslint-rules/no-locale-with-intl-functions";
+import rule from "../eslint-plugin-metabase/rules/no-locale-with-intl-functions";
const ruleTester = new RuleTester({
languageOptions: {
@@ -79,7 +79,7 @@ const INVALID_CASES = [
},
];
-ruleTester.run("no-locale-with-intl-functions", noLocaleWithIntlFunctions, {
+ruleTester.run("no-locale-with-intl-functions", rule, {
valid: VALID_CASES,
invalid: INVALID_CASES.map((invalidCase) => {
return {
diff --git a/frontend/lint/tests/no-unconditional-metabase-links-render.unit.spec.js b/frontend/lint/tests/no-unconditional-metabase-links-render.unit.spec.js
index f745b738124..b5e1393d0fd 100644
--- a/frontend/lint/tests/no-unconditional-metabase-links-render.unit.spec.js
+++ b/frontend/lint/tests/no-unconditional-metabase-links-render.unit.spec.js
@@ -1,6 +1,6 @@
import { RuleTester } from "eslint";
-import noUnconditionalMetabaseLinksRender from "../eslint-rules/no-unconditional-metabase-links-render";
+import rule from "../eslint-plugin-metabase/rules/no-unconditional-metabase-links-render";
const ruleTester = new RuleTester({
languageOptions: {
@@ -148,14 +148,10 @@ const { url: docsUrl } = useDocsUrl("permissions/data");`,
},
];
-ruleTester.run(
- "no-unconditional-metabase-links-render",
- noUnconditionalMetabaseLinksRender,
- {
- valid: VALID_CASES,
- invalid: INVALID_CASES.map((invalidCase) => ({
- code: invalidCase.code,
- errors: [{ message: invalidCase.error }],
- })),
- },
-);
+ruleTester.run("no-unconditional-metabase-links-render", rule, {
+ valid: VALID_CASES,
+ invalid: INVALID_CASES.map((invalidCase) => ({
+ code: invalidCase.code,
+ errors: [{ message: invalidCase.error }],
+ })),
+});
diff --git a/frontend/lint/tests/no-unordered-test-helpers.unit.spec.js b/frontend/lint/tests/no-unordered-test-helpers.unit.spec.js
index 00b41beec4c..ca412dbbcba 100644
--- a/frontend/lint/tests/no-unordered-test-helpers.unit.spec.js
+++ b/frontend/lint/tests/no-unordered-test-helpers.unit.spec.js
@@ -1,6 +1,6 @@
import { RuleTester } from "eslint";
-import rule from "../eslint-rules/no-unordered-test-helpers";
+import rule from "../eslint-plugin-metabase/rules/no-unordered-test-helpers";
const ruleTester = new RuleTester({ languageOptions: { ecmaVersion: 2015 } });
diff --git a/frontend/lint/tests/no-unsafe-element-filtering.unit.spec.js b/frontend/lint/tests/no-unsafe-element-filtering.unit.spec.js
index 78797989e1f..38aeaed1726 100644
--- a/frontend/lint/tests/no-unsafe-element-filtering.unit.spec.js
+++ b/frontend/lint/tests/no-unsafe-element-filtering.unit.spec.js
@@ -1,6 +1,6 @@
import { RuleTester } from "eslint";
-import rule from "../eslint-rules/no-unsafe-element-filtering";
+import rule from "../eslint-plugin-metabase/rules/no-unsafe-element-filtering";
const ruleTester = new RuleTester({ languageOptions: { ecmaVersion: 2015 } });
diff --git a/frontend/lint/tests/no-unscoped-text-selectors.unit.spec.js b/frontend/lint/tests/no-unscoped-text-selectors.unit.spec.js
index 19ed5e2aa91..d0adbc1a35c 100644
--- a/frontend/lint/tests/no-unscoped-text-selectors.unit.spec.js
+++ b/frontend/lint/tests/no-unscoped-text-selectors.unit.spec.js
@@ -1,6 +1,6 @@
import { RuleTester } from "eslint";
-import rule from "../eslint-rules/no-unscoped-text-selectors";
+import rule from "../eslint-plugin-metabase/rules/no-unscoped-text-selectors";
const ruleTester = new RuleTester({ languageOptions: { ecmaVersion: 2015 } });