Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

GDGT-2516 add snowplow events to the Alerts Management feature. (#75045)

Egor Grushina3992af871db
diff --git a/frontend/src/metabase/admin/tools/notifications/NotificationDetailSidebar/NotificationDetailSidebar.tsx b/frontend/src/metabase/admin/tools/notifications/NotificationDetailSidebar/NotificationDetailSidebar.tsx
index 9d759b8a50c..7fd2f06cd0d 100644
--- a/frontend/src/metabase/admin/tools/notifications/NotificationDetailSidebar/NotificationDetailSidebar.tsx
+++ b/frontend/src/metabase/admin/tools/notifications/NotificationDetailSidebar/NotificationDetailSidebar.tsx
@@ -14,6 +14,8 @@ import { getMetadata } from "metabase/selectors/metadata";
import { Drawer, Stack } from "metabase/ui";
import Question from "metabase-lib/v1/Question";
+import { trackAlertsManagementEditClicked } from "../analytics";
+
import { SidebarBody } from "./SidebarBody";
import { SidebarHeader } from "./SidebarHeader";
import { SIDEBAR_WIDTH } from "./constants";
@@ -86,7 +88,10 @@ export const NotificationDetailSidebar = ({
isQuestionLoading={isCardLoading}
onClose={onClose}
onDelete={onDelete}
- onEdit={() => setIsEditModalOpen(true)}
+ onEdit={() => {
+ trackAlertsManagementEditClicked(notificationId);
+ setIsEditModalOpen(true);
+ }}
/>
{notification ? (
<SidebarBody
diff --git a/frontend/src/metabase/admin/tools/notifications/NotificationDetailSidebar/NotificationRunSummaryLog.tsx b/frontend/src/metabase/admin/tools/notifications/NotificationDetailSidebar/NotificationRunSummaryLog.tsx
index 27311ae0431..905405ffd9c 100644
--- a/frontend/src/metabase/admin/tools/notifications/NotificationDetailSidebar/NotificationRunSummaryLog.tsx
+++ b/frontend/src/metabase/admin/tools/notifications/NotificationDetailSidebar/NotificationRunSummaryLog.tsx
@@ -17,6 +17,7 @@ export const NotificationRunSummaryLog = ({
runs,
isLoading,
cardId,
+ onViewAllClick,
}: NotificationRunSummaryLogProps) => {
const viewAllUrl = Urls.adminToolsTasksRunsFor({
runType: "alert",
@@ -91,6 +92,7 @@ export const NotificationRunSummaryLog = ({
fz="md"
lh="1rem"
fw="bold"
+ onClick={onViewAllClick}
>
{t`View all`}
</Anchor>
diff --git a/frontend/src/metabase/admin/tools/notifications/NotificationDetailSidebar/SidebarBody.tsx b/frontend/src/metabase/admin/tools/notifications/NotificationDetailSidebar/SidebarBody.tsx
index 120b0812577..5542c2b40e3 100644
--- a/frontend/src/metabase/admin/tools/notifications/NotificationDetailSidebar/SidebarBody.tsx
+++ b/frontend/src/metabase/admin/tools/notifications/NotificationDetailSidebar/SidebarBody.tsx
@@ -7,6 +7,8 @@ import type {
NotificationHandlerSlack,
} from "metabase-types/api";
+import { trackAlertsManagementRunHistoryViewAllClicked } from "../analytics";
+
import { DetailsSection } from "./DetailsSection";
import { DetailsTable } from "./DetailsTable";
import { NotificationRunSummaryLog } from "./NotificationRunSummaryLog";
@@ -54,12 +56,18 @@ export const SidebarBody = ({
runs={detail?.check_history}
isLoading={isDetailFetching}
cardId={cardId}
+ onViewAllClick={() =>
+ trackAlertsManagementRunHistoryViewAllClicked(cardId, "check")
+ }
/>
<NotificationRunSummaryLog
title={t`Send history`}
runs={detail?.send_history}
isLoading={isDetailFetching}
cardId={cardId}
+ onViewAllClick={() =>
+ trackAlertsManagementRunHistoryViewAllClicked(cardId, "send")
+ }
/>
{emailHandler && emailRecipientCount > 0 && (
<SidebarSection title={getEmailRecipientLabel(emailRecipientCount)}>
diff --git a/frontend/src/metabase/admin/tools/notifications/NotificationDetailSidebar/SidebarHeader.tsx b/frontend/src/metabase/admin/tools/notifications/NotificationDetailSidebar/SidebarHeader.tsx
index 552503fe1c2..04eabb8bea4 100644
--- a/frontend/src/metabase/admin/tools/notifications/NotificationDetailSidebar/SidebarHeader.tsx
+++ b/frontend/src/metabase/admin/tools/notifications/NotificationDetailSidebar/SidebarHeader.tsx
@@ -17,6 +17,11 @@ import {
import * as Urls from "metabase/urls";
import type { NotificationId } from "metabase-types/api";
+import {
+ trackAlertsManagementAlertOpened,
+ trackAlertsManagementLinkCopied,
+} from "../analytics";
+
import { ChannelAvatarStack } from "./ChannelAvatarStack";
import S from "./NotificationDetailSidebar.module.css";
import type { SidebarHeaderProps } from "./types";
@@ -38,11 +43,13 @@ export const SidebarHeader = ({
const handleCopyLink = async () => {
const url = `${window.location.origin}${Urls.adminToolsNotificationDetail(notificationId)}`;
await navigator.clipboard.writeText(url);
+ trackAlertsManagementLinkCopied(notificationId);
dispatch(addUndo({ message: t`Link copied to clipboard` }));
};
const handleNavigate = (id: NotificationId | undefined) => {
if (id !== undefined) {
+ trackAlertsManagementAlertOpened(id, "sidebar_navigation");
dispatch(push(Urls.adminToolsNotificationDetail(id)));
}
};
diff --git a/frontend/src/metabase/admin/tools/notifications/NotificationDetailSidebar/types.ts b/frontend/src/metabase/admin/tools/notifications/NotificationDetailSidebar/types.ts
index d8d305f62c1..5a476433393 100644
--- a/frontend/src/metabase/admin/tools/notifications/NotificationDetailSidebar/types.ts
+++ b/frontend/src/metabase/admin/tools/notifications/NotificationDetailSidebar/types.ts
@@ -50,6 +50,7 @@ export type NotificationRunSummaryLogProps = {
runs: (NotificationRunSummary | NotificationTickSendEntry)[] | undefined;
isLoading: boolean;
cardId: CardId;
+ onViewAllClick: () => void;
};
export type SidebarSectionProps = {
diff --git a/frontend/src/metabase/admin/tools/notifications/NotificationsAdminPage/NotificationsAdminPage.tsx b/frontend/src/metabase/admin/tools/notifications/NotificationsAdminPage/NotificationsAdminPage.tsx
index 6e805775f88..eb03f8d5701 100644
--- a/frontend/src/metabase/admin/tools/notifications/NotificationsAdminPage/NotificationsAdminPage.tsx
+++ b/frontend/src/metabase/admin/tools/notifications/NotificationsAdminPage/NotificationsAdminPage.tsx
@@ -35,6 +35,12 @@ import { NotificationsFilters } from "../NotificationsFilters";
import { NotificationsSearchInput } from "../NotificationsSearchInput";
import { NotificationsTable } from "../NotificationsTable";
import { NotificationsTabs } from "../NotificationsTabs";
+import {
+ trackAlertsManagementAlertOpened,
+ trackAlertsManagementAlertsDeleted,
+ trackAlertsManagementOwnerChanged,
+ trackAlertsManagementSearchPerformed,
+} from "../analytics";
import {
DEFAULT_SORT_COLUMN,
@@ -180,21 +186,33 @@ export const NotificationsAdminPage = ({
}, [notifications]);
const handleRowClick = (id: NotificationId) => {
+ trackAlertsManagementAlertOpened(id, "table_row");
dispatch(push(Urls.adminToolsNotificationDetail(id)));
};
+ const handleSearchChange = (query: string) => {
+ if (query !== "") {
+ trackAlertsManagementSearchPerformed();
+ }
+ patchUrlState({ query, page: 0 });
+ };
+
const handleSidebarClose = () => {
dispatch(push(Urls.adminToolsNotifications()));
};
const deleteNotifications = useCallback(
- async (notificationIds: NotificationId[]) => {
+ async (
+ notificationIds: NotificationId[],
+ triggeredFrom: "bulk_action_bar" | "detail_sidebar",
+ ) => {
const count = notificationIds.length;
try {
await bulkAction({
notification_ids: notificationIds,
action: "archive",
}).unwrap();
+ trackAlertsManagementAlertsDeleted(triggeredFrom, "success", count);
dispatch(
addUndo({
message:
@@ -209,6 +227,7 @@ export const NotificationsAdminPage = ({
dispatch(push(Urls.adminToolsNotifications()));
}
} catch {
+ trackAlertsManagementAlertsDeleted(triggeredFrom, "failure", count);
dispatch(
addUndo({
icon: "warning",
@@ -229,7 +248,10 @@ export const NotificationsAdminPage = ({
confirmButtonProps: { color: "danger" },
size: "md",
onConfirm: () =>
- deleteNotifications(selectedNotifications.map((n) => n.id)),
+ deleteNotifications(
+ selectedNotifications.map((n) => n.id),
+ "bulk_action_bar",
+ ),
});
}, [deleteNotifications, selectedNotifications, showConfirm]);
@@ -240,7 +262,7 @@ export const NotificationsAdminPage = ({
message: t`Recipients will stop receiving this alert.`,
confirmButtonText: t`Delete`,
confirmButtonProps: { color: "danger" },
- onConfirm: () => deleteNotifications([id]),
+ onConfirm: () => deleteNotifications([id], "detail_sidebar"),
});
},
[deleteNotifications, showConfirm],
@@ -255,6 +277,7 @@ export const NotificationsAdminPage = ({
action: "change-creator",
creator_id: creatorId,
}).unwrap();
+ trackAlertsManagementOwnerChanged("success", count);
dispatch(
addUndo({
message:
@@ -266,6 +289,7 @@ export const NotificationsAdminPage = ({
clearSelected();
setIsChangeOwnerOpened(false);
} catch {
+ trackAlertsManagementOwnerChanged("failure", count);
dispatch(
addUndo({
icon: "warning",
@@ -327,7 +351,7 @@ export const NotificationsAdminPage = ({
<NotificationsSearchInput
value={urlState.query}
isLoading={isFetching}
- onChange={(query) => patchUrlState({ query, page: 0 })}
+ onChange={handleSearchChange}
/>
<NotificationsFilters state={urlState} onChange={patchUrlState} />
</Flex>
diff --git a/frontend/src/metabase/admin/tools/notifications/NotificationsFilters/NotificationsFilters.tsx b/frontend/src/metabase/admin/tools/notifications/NotificationsFilters/NotificationsFilters.tsx
index a29cdf76d3f..097e9b8936b 100644
--- a/frontend/src/metabase/admin/tools/notifications/NotificationsFilters/NotificationsFilters.tsx
+++ b/frontend/src/metabase/admin/tools/notifications/NotificationsFilters/NotificationsFilters.tsx
@@ -29,6 +29,7 @@ import {
getChannelIconName,
getChannelLabel,
} from "../NotificationsAdminPage/utils";
+import { trackAlertsManagementFiltersApplied } from "../analytics";
import { hasActiveFilters, stateToDraft } from "./utils";
@@ -51,6 +52,7 @@ export const NotificationsFilters = ({ state, onChange }: Props) => {
}, [opened, state]);
const handleApply = () => {
+ trackAlertsManagementFiltersApplied();
onChange({
channel: draft.channel,
creator_active: draft.creator_active,
diff --git a/frontend/src/metabase/admin/tools/notifications/NotificationsTabs/NotificationsTabs.tsx b/frontend/src/metabase/admin/tools/notifications/NotificationsTabs/NotificationsTabs.tsx
index b08c6a534c0..e22dd6c265c 100644
--- a/frontend/src/metabase/admin/tools/notifications/NotificationsTabs/NotificationsTabs.tsx
+++ b/frontend/src/metabase/admin/tools/notifications/NotificationsTabs/NotificationsTabs.tsx
@@ -7,6 +7,7 @@ import type {
NotificationsTab,
NotificationsUrlState,
} from "../NotificationsAdminPage/types";
+import { trackAlertsManagementTabClicked } from "../analytics";
import S from "./NotificationsTabs.module.css";
@@ -64,6 +65,7 @@ export const NotificationsTabs = ({
const handleTabChange = (value: string | null) => {
const next = tabs.find((config) => config.value === value);
if (next !== undefined) {
+ trackAlertsManagementTabClicked(next.value);
onChange(next.patch);
}
};
diff --git a/frontend/src/metabase/admin/tools/notifications/analytics.ts b/frontend/src/metabase/admin/tools/notifications/analytics.ts
new file mode 100644
index 00000000000..68a0a8e540f
--- /dev/null
+++ b/frontend/src/metabase/admin/tools/notifications/analytics.ts
@@ -0,0 +1,83 @@
+import { trackSimpleEvent } from "metabase/analytics";
+import type { NotificationId } from "metabase-types/api";
+
+import type { NotificationsTab } from "./NotificationsAdminPage/types";
+
+export const trackAlertsManagementTabClicked = (tab: NotificationsTab) => {
+ trackSimpleEvent({
+ event: "alerts_management_tab_clicked",
+ event_detail: tab,
+ });
+};
+
+export const trackAlertsManagementSearchPerformed = () => {
+ trackSimpleEvent({
+ event: "alerts_management_search_performed",
+ });
+};
+
+export const trackAlertsManagementFiltersApplied = () => {
+ trackSimpleEvent({
+ event: "alerts_management_filters_applied",
+ });
+};
+
+export const trackAlertsManagementAlertOpened = (
+ id: NotificationId,
+ triggeredFrom: "table_row" | "sidebar_navigation",
+) => {
+ trackSimpleEvent({
+ event: "alerts_management_alert_opened",
+ target_id: id,
+ triggered_from: triggeredFrom,
+ });
+};
+
+export const trackAlertsManagementEditClicked = (id: NotificationId) => {
+ trackSimpleEvent({
+ event: "alerts_management_edit_clicked",
+ target_id: id,
+ });
+};
+
+export const trackAlertsManagementLinkCopied = (id: NotificationId) => {
+ trackSimpleEvent({
+ event: "alerts_management_link_copied",
+ target_id: id,
+ });
+};
+
+export const trackAlertsManagementAlertsDeleted = (
+ triggeredFrom: "bulk_action_bar" | "detail_sidebar",
+ result: "success" | "failure",
+ count: number,
+) => {
+ trackSimpleEvent({
+ event: "alerts_management_alerts_deleted",
+ triggered_from: triggeredFrom,
+ result,
+ event_detail: count === 1 ? "single" : "multiple",
+ });
+};
+
+export const trackAlertsManagementOwnerChanged = (
+ result: "success" | "failure",
+ count: number,
+) => {
+ trackSimpleEvent({
+ event: "alerts_management_owner_changed",
+ result,
+ event_detail: count === 1 ? "single" : "multiple",
+ });
+};
+
+export const trackAlertsManagementRunHistoryViewAllClicked = (
+ cardId: number,
+ runType: "check" | "send",
+) => {
+ trackSimpleEvent({
+ event: "alerts_management_run_history_view_all_clicked",
+ target_id: cardId,
+ event_detail: runType,
+ });
+};