The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
[GDGT-2548] chore: use shared constant to set empty cell placeholder values in tables/detail fields (#75223)
YBa451945286c2
diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/components/ConversationsPage/ConversationsTable.tsx b/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/components/ConversationsPage/ConversationsTable.tsxindex dbc7ee2fb94..424ebc0d568 100644--- a/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/components/ConversationsPage/ConversationsTable.tsx+++ b/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/components/ConversationsPage/ConversationsTable.tsx@@ -10,6 +10,7 @@ import CS from "metabase/css/core/index.css";import { renderMetabotProfileLabel } from "metabase/metabot/constants";import { useDispatch } from "metabase/redux";import { Badge, Ellipsified, Flex } from "metabase/ui";+import { EMPTY_CELL_PLACEHOLDER } from "metabase/utils/constants";import { formatNumber } from "metabase/utils/formatting";import { getUserName } from "metabase/utils/user";import type { SortingOptions } from "metabase-types/api";@@ -129,7 +130,7 @@ export function ConversationsTable({<td>{formatNumber(convo.total_tokens)}</td><td>{formatNumber(convo.query_count)}</td><td>{formatNumber(convo.search_count)}</td>- <td>{convo.ip_address ?? "—"}</td>+ <td>{convo.ip_address ?? EMPTY_CELL_PLACEHOLDER}</td></tr>))}</>diff --git a/frontend/src/metabase/admin/tools/components/TaskDetailsPage/TaskDetailsPage.tsx b/frontend/src/metabase/admin/tools/components/TaskDetailsPage/TaskDetailsPage.tsxindex 5c6406f31c2..bfd337cdabb 100644--- a/frontend/src/metabase/admin/tools/components/TaskDetailsPage/TaskDetailsPage.tsx+++ b/frontend/src/metabase/admin/tools/components/TaskDetailsPage/TaskDetailsPage.tsx@@ -21,6 +21,7 @@ import {Tooltip,} from "metabase/ui";import * as Urls from "metabase/urls";+import { EMPTY_CELL_PLACEHOLDER } from "metabase/utils/constants";import { openSaveDialog } from "metabase/utils/dom";import type { Database } from "metabase-types/api";@@ -97,13 +98,25 @@ export const TaskDetailsPage = ({ params }: TaskDetailsPageProps) => {<Flex gap="md"><Text fw="bold" w={120}>{t`DB Name`}</Text><Text>- {isLoadingDatabases ? <Loader size="xs" /> : db ? dbName : "—"}+ {isLoadingDatabases ? (+ <Loader size="xs" />+ ) : db ? (+ dbName+ ) : (+ EMPTY_CELL_PLACEHOLDER+ )}</Text></Flex><Flex gap="md"><Text fw="bold" w={120}>{t`DB Engine`}</Text><Text>- {isLoadingDatabases ? <Loader size="xs" /> : db ? dbEngine : "—"}+ {isLoadingDatabases ? (+ <Loader size="xs" />+ ) : db ? (+ dbEngine+ ) : (+ EMPTY_CELL_PLACEHOLDER+ )}</Text></Flex><Flex gap="md" align="baseline">@@ -128,7 +141,7 @@ export const TaskDetailsPage = ({ params }: TaskDetailsPageProps) => {/></Tooltip>) : (- "—"+ EMPTY_CELL_PLACEHOLDER)}{task.ended_at && <CopyButton value={task.ended_at} />}</Flex>diff --git a/frontend/src/metabase/admin/tools/components/TaskListPage/TasksTable.tsx b/frontend/src/metabase/admin/tools/components/TaskListPage/TasksTable.tsxindex 93c8a88b5b0..a82122a1342 100644--- a/frontend/src/metabase/admin/tools/components/TaskListPage/TasksTable.tsx+++ b/frontend/src/metabase/admin/tools/components/TaskListPage/TasksTable.tsx@@ -12,6 +12,7 @@ import CS from "metabase/css/core/index.css";import { useDispatch } from "metabase/redux";import { Box, Ellipsified, Flex } from "metabase/ui";import * as Urls from "metabase/urls";+import { EMPTY_CELL_PLACEHOLDER } from "metabase/utils/constants";import type {Database,ListTasksSortColumn,@@ -142,7 +143,7 @@ export const TasksTable = ({/></Ellipsified>) : (- "—"+ EMPTY_CELL_PLACEHOLDER)}</td><td>{task.duration}</td>diff --git a/frontend/src/metabase/admin/tools/components/TaskRunDetailsPage/TaskRunDetailsPage.tsx b/frontend/src/metabase/admin/tools/components/TaskRunDetailsPage/TaskRunDetailsPage.tsxindex 69773c24e0e..6b94615343d 100644--- a/frontend/src/metabase/admin/tools/components/TaskRunDetailsPage/TaskRunDetailsPage.tsx+++ b/frontend/src/metabase/admin/tools/components/TaskRunDetailsPage/TaskRunDetailsPage.tsx@@ -23,6 +23,7 @@ import {Tooltip,} from "metabase/ui";import * as Urls from "metabase/urls";+import { EMPTY_CELL_PLACEHOLDER } from "metabase/utils/constants";import type { Task } from "metabase-types/api";import {@@ -119,7 +120,7 @@ export const TaskRunDetailsPage = ({ params }: TaskRunDetailsPageProps) => {<CopyButton value={taskRun.ended_at} /></>) : (- "—"+ EMPTY_CELL_PLACEHOLDER)}</Flex><Flex gap="md">diff --git a/frontend/src/metabase/admin/tools/components/TaskRunsPage/TaskRunsTable.tsx b/frontend/src/metabase/admin/tools/components/TaskRunsPage/TaskRunsTable.tsxindex 77ad133981c..c34e45052c1 100644--- a/frontend/src/metabase/admin/tools/components/TaskRunsPage/TaskRunsTable.tsx+++ b/frontend/src/metabase/admin/tools/components/TaskRunsPage/TaskRunsTable.tsx@@ -9,6 +9,7 @@ import CS from "metabase/css/core/index.css";import { useDispatch } from "metabase/redux";import { Box, Ellipsified, Flex } from "metabase/ui";import * as Urls from "metabase/urls";+import { EMPTY_CELL_PLACEHOLDER } from "metabase/utils/constants";import type { TaskRun } from "metabase-types/api";import { formatTaskRunType, renderTaskRunCounters } from "../../utils";@@ -111,7 +112,7 @@ export const TaskRunsTable = ({/></Ellipsified>) : (- "—"+ EMPTY_CELL_PLACEHOLDER)}</td><td>diff --git a/frontend/src/metabase/admin/tools/notifications/NotificationsTable/NotificationsTable.tsx b/frontend/src/metabase/admin/tools/notifications/NotificationsTable/NotificationsTable.tsxindex b361bc4fcfc..f57358de4f2 100644--- a/frontend/src/metabase/admin/tools/notifications/NotificationsTable/NotificationsTable.tsx+++ b/frontend/src/metabase/admin/tools/notifications/NotificationsTable/NotificationsTable.tsx@@ -15,6 +15,7 @@ import {TreeTable,useTreeTableInstance,} from "metabase/ui";+import { EMPTY_CELL_PLACEHOLDER } from "metabase/utils/constants";import { getUserLabel } from "metabase/utils/user";import type {AdminNotification,@@ -174,7 +175,7 @@ export const NotificationsTable = ({cell: ({ row }) => {const summaries = summarizeChannels(row.original);if (summaries.length === 0) {- return "—";+ return EMPTY_CELL_PLACEHOLDER;}return (<Flex gap="sm" align="center" wrap="wrap">diff --git a/frontend/src/metabase/transforms/pages/RunListPage/RunTable/utils.tsx b/frontend/src/metabase/transforms/pages/RunListPage/RunTable/utils.tsxindex ba68f493033..aef03571eb1 100644--- a/frontend/src/metabase/transforms/pages/RunListPage/RunTable/utils.tsx+++ b/frontend/src/metabase/transforms/pages/RunListPage/RunTable/utils.tsx@@ -18,6 +18,7 @@ import {Text,Tooltip,} from "metabase/ui";+import { EMPTY_CELL_PLACEHOLDER } from "metabase/utils/constants";import { formatDurationLong } from "metabase/utils/formatting/time";import {TRANSFORM_RUN_SORT_COLUMNS,@@ -32,8 +33,6 @@ import type { TransformRunSortOptions } from "../types";import { TagList } from "./TagList";import { TimezoneIndicator } from "./TimezoneIndicator";-const EMPTY_CELL_PLACEHOLDER = "—";-function getTransformColumn(): TreeTableColumnDef<TransformRun> {return {id: "transform-name" satisfies TransformRunSortColumn,diff --git a/frontend/src/metabase/utils/constants.ts b/frontend/src/metabase/utils/constants.tsindex 6bb595d427c..5a9b29ee18c 100644--- a/frontend/src/metabase/utils/constants.ts+++ b/frontend/src/metabase/utils/constants.ts@@ -4,5 +4,7 @@ export const SEARCH_DEBOUNCE_DURATION = 500;export const DEFAULT_SEARCH_LIMIT = 50;+export const EMPTY_CELL_PLACEHOLDER = "—";+// eslint-disable-next-line ttag/no-module-declaration -- see metabase#55045export const NULL_DISPLAY_VALUE = t`(empty)`;