Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Convert PermissionsTabs to TypeScript (#69080)

Frasera46e4da604e4
diff --git a/frontend/src/metabase/admin/permissions/components/PermissionsPageLayout/PermissionsPageLayout.tsx b/frontend/src/metabase/admin/permissions/components/PermissionsPageLayout/PermissionsPageLayout.tsx
index 65b0625761b..9a022fb213d 100644
--- a/frontend/src/metabase/admin/permissions/components/PermissionsPageLayout/PermissionsPageLayout.tsx
+++ b/frontend/src/metabase/admin/permissions/components/PermissionsPageLayout/PermissionsPageLayout.tsx
@@ -40,7 +40,7 @@ import { ToolbarButton } from "../ToolbarButton";
import { PermissionsEditBar } from "./PermissionsEditBar";
import { PermissionsTabs } from "./PermissionsTabs";
-type PermissionsPageTab =
+export type PermissionsPageTab =
| "data"
| "collections"
| "application"
diff --git a/frontend/src/metabase/admin/permissions/components/PermissionsPageLayout/PermissionsTabs.jsx b/frontend/src/metabase/admin/permissions/components/PermissionsPageLayout/PermissionsTabs.tsx
similarity index 72%
rename from frontend/src/metabase/admin/permissions/components/PermissionsPageLayout/PermissionsTabs.jsx
rename to frontend/src/metabase/admin/permissions/components/PermissionsPageLayout/PermissionsTabs.tsx
index 7caab04d861..14af9c2f85d 100644
--- a/frontend/src/metabase/admin/permissions/components/PermissionsPageLayout/PermissionsTabs.jsx
+++ b/frontend/src/metabase/admin/permissions/components/PermissionsPageLayout/PermissionsTabs.tsx
@@ -1,5 +1,4 @@
import cx from "classnames";
-import PropTypes from "prop-types";
import { t } from "ttag";
import { Radio } from "metabase/common/components/Radio";
@@ -10,12 +9,14 @@ import {
PLUGIN_APPLICATION_PERMISSIONS,
} from "metabase/plugins";
-const propTypes = {
- tab: PropTypes.string.isRequired,
- onChangeTab: PropTypes.func.isRequired,
-};
+import type { PermissionsPageTab } from "./PermissionsPageLayout";
+
+interface PermissionsTabsProps {
+ tab: PermissionsPageTab;
+ onChangeTab: (tab: PermissionsPageTab) => void;
+}
-export const PermissionsTabs = ({ tab, onChangeTab }) => {
+export const PermissionsTabs = ({ tab, onChangeTab }: PermissionsTabsProps) => {
const isUsingTenants = useSetting("use-tenants");
const adminPermissionsTabs = isUsingTenants
@@ -32,8 +33,8 @@ export const PermissionsTabs = ({ tab, onChangeTab }) => {
colorScheme="accent7"
value={tab}
options={[
- { name: t`Data`, value: `data` },
- { name: t`Collections`, value: `collections` },
+ { name: t`Data`, value: "data" },
+ { name: t`Collections`, value: "collections" },
...adminPermissionsTabs,
...PLUGIN_APPLICATION_PERMISSIONS.tabs,
]}
@@ -43,5 +44,3 @@ export const PermissionsTabs = ({ tab, onChangeTab }) => {
</div>
);
};
-
-PermissionsTabs.propTypes = propTypes;