The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Disallow editing transforms when remote sync is read-only (#68380)
Andersona51d1179d31c
diff --git a/e2e/support/helpers/e2e-data-studio-helpers.ts b/e2e/support/helpers/e2e-data-studio-helpers.tsindex 5f0f6957e2f..92fa9fbb53e 100644--- a/e2e/support/helpers/e2e-data-studio-helpers.ts+++ b/e2e/support/helpers/e2e-data-studio-helpers.ts@@ -38,6 +38,7 @@ export const DataStudio = {},PythonLibrary: {header: () => cy.findByTestId("python-library-header"),+ editor: () => cy.findByTestId("python-editor"),},Snippets: {newPage: newSnippetPage,diff --git a/e2e/test/scenarios/data-studio/transforms.cy.spec.ts b/e2e/test/scenarios/data-studio/transforms.cy.spec.tsindex 58bd7cd23ff..086eae2fb87 100644--- a/e2e/test/scenarios/data-studio/transforms.cy.spec.ts+++ b/e2e/test/scenarios/data-studio/transforms.cy.spec.ts@@ -2829,6 +2829,85 @@ LIMIT.should("be.visible");});});++ describe("read-only remote sync", () => {+ beforeEach(() => {+ cy.log("create a transform");+ createSqlTransform({+ sourceQuery: `SELECT * FROM "${TARGET_SCHEMA}"."${SOURCE_TABLE}"`,+ });+ cy.log("set up remote sync");+ H.setupGitSync();+ H.configureGit("read-only");+ });++ it("should make the transform list page read-only", () => {+ cy.log("visit transforms page");+ visitTransformListPage();++ cy.log("'Create a transform' menu button is not displayed");+ cy.button("Create a transform").should("not.exist");++ cy.log("clicking Python library navigates to the library editor");+ getTransformsList().findByText("Python library").click();++ cy.log("python library editor is read-only");+ cy.url().should("include", "/data-studio/transforms/library/common.py");+ cy.findByRole("alert")+ .contains(/The Python library is not editable/)+ .should("be.visible");++ H.DataStudio.PythonLibrary.editor().within(() => {+ cy.findByRole("textbox").should(+ "have.attr",+ "contenteditable",+ "false",+ );+ cy.findByRole("textbox").should("have.attr", "aria-readonly", "true");+ });+ });++ it("should not allow editing a transform", () => {+ cy.log("visit transform");+ cy.visit("/data-studio/transforms/1");++ cy.log("'edit definition' button is not displayed");+ H.DataStudio.Transforms.editDefinition().should("not.exist");++ cy.log("visit the Run tab");+ H.DataStudio.Transforms.runTab().click();++ cy.log("schedule tags are not editable");+ cy.findByLabelText("Tags").should("be.visible");+ cy.findByLabelText("Tags").should("be.disabled");++ cy.log("visit the Settings tab");+ H.DataStudio.Transforms.settingsTab().click();++ cy.log("'Change target' button is not displayed");+ cy.findByRole("button", { name: /Change target/ }).should("not.exist");++ cy.log("'Only process new and changed data' switch is not displayed");+ cy.findByRole("switch", {+ name: /Only process new and changed data/,+ }).should("be.disabled");++ cy.log("visiting edit mode url directly redirects to view-only mode");+ cy.visit("/data-studio/transforms/1/edit");+ cy.url().should("not.include", "/edit");++ H.DataStudio.Transforms.header()+ .findByRole("img", { name: "ellipsis icon" })+ .click();++ cy.log("ellipsis menu does not have move or delete options");+ cy.findByRole("menu").within(() => {+ cy.findByRole("menuitem", { name: /History/ }).should("be.visible");+ cy.findByRole("menuitem", { name: /Move/ }).should("not.exist");+ cy.findByRole("menuitem", { name: /Delete/ }).should("not.exist");+ });+ });+ });});describe("scenarios > admin > transforms > databases without :schemas", () => {diff --git a/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonTransformTopBar/PythonTransformTopBar.tsx b/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonTransformTopBar/PythonTransformTopBar.tsxindex 8f4398f6b53..dac483abf14 100644--- a/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonTransformTopBar/PythonTransformTopBar.tsx+++ b/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonTransformTopBar/PythonTransformTopBar.tsx@@ -4,8 +4,10 @@ import {useGetDatabaseQuery,useListDatabasesQuery,} from "metabase/api";+import { useSelector } from "metabase/lib/redux";import { DatabaseDataSelector } from "metabase/query_builder/components/DataSelector";import { Flex } from "metabase/ui";+import { getIsRemoteSyncReadOnly } from "metabase-enterprise/remote_sync/selectors";import { EditDefinitionButton } from "metabase-enterprise/transforms/components/TransformEditor/EditDefinitionButton";import { doesDatabaseSupportTransforms } from "metabase-enterprise/transforms/utils";import type { Database, DatabaseId, TransformId } from "metabase-types/api";@@ -25,7 +27,9 @@ export function PythonTransformTopBar({transformId,onDatabaseChange,}: PythonTransformTopBarProps) {- const showEditDefinitionButton = !isEditMode && transformId;+ const isRemoteSyncReadOnly = useSelector(getIsRemoteSyncReadOnly);+ const showEditDefinitionButton =+ !isEditMode && transformId && !isRemoteSyncReadOnly;const { data: database } = useGetDatabaseQuery(databaseId != null ? { id: databaseId } : skipToken,diff --git a/enterprise/frontend/src/metabase-enterprise/transforms-python/pages/PythonLibraryEditorPage/PythonLibraryEditorPage.module.css b/enterprise/frontend/src/metabase-enterprise/transforms-python/pages/PythonLibraryEditorPage/PythonLibraryEditorPage.module.cssindex c9b86585db4..a7bde9bb4a5 100644--- a/enterprise/frontend/src/metabase-enterprise/transforms-python/pages/PythonLibraryEditorPage/PythonLibraryEditorPage.module.css+++ b/enterprise/frontend/src/metabase-enterprise/transforms-python/pages/PythonLibraryEditorPage/PythonLibraryEditorPage.module.css@@ -4,3 +4,7 @@flex-grow: 1;background-color: var(--mb-color-background-secondary);}++.flexStart {+ align-self: flex-start;+}diff --git a/enterprise/frontend/src/metabase-enterprise/transforms-python/pages/PythonLibraryEditorPage/PythonLibraryEditorPage.tsx b/enterprise/frontend/src/metabase-enterprise/transforms-python/pages/PythonLibraryEditorPage/PythonLibraryEditorPage.tsxindex ea4c65d6f27..25e0f21bacf 100644--- a/enterprise/frontend/src/metabase-enterprise/transforms-python/pages/PythonLibraryEditorPage/PythonLibraryEditorPage.tsx+++ b/enterprise/frontend/src/metabase-enterprise/transforms-python/pages/PythonLibraryEditorPage/PythonLibraryEditorPage.tsx@@ -5,14 +5,16 @@ import { t } from "ttag";import { LeaveRouteConfirmModal } from "metabase/common/components/LeaveConfirmModal";import { LoadingAndErrorWrapper } from "metabase/common/components/LoadingAndErrorWrapper";import { isResourceNotFoundError } from "metabase/lib/errors";+import { useSelector } from "metabase/lib/redux";import type * as Urls from "metabase/lib/urls";import { useMetadataToasts } from "metabase/metadata/hooks";-import { Box, Card } from "metabase/ui";+import { Alert, Box, Card, Stack } from "metabase/ui";import {useGetPythonLibraryQuery,useUpdatePythonLibraryMutation,} from "metabase-enterprise/api/python-transform-library";import { PageContainer } from "metabase-enterprise/data-studio/common/components/PageContainer";+import { getIsRemoteSyncReadOnly } from "metabase-enterprise/remote_sync/selectors";import { PythonEditor } from "../../components/PythonEditor";@@ -36,7 +38,8 @@ export function PythonLibraryEditorPage({route,}: PythonLibraryEditorPageProps) {const { path } = params;- const [source, setSource] = useState("");+ const [source, setSource] = useState(EMPTY_LIBRARY_SOURCE);+ const isRemoteSyncReadOnly = useSelector(getIsRemoteSyncReadOnly);const {data: library,@@ -93,12 +96,25 @@ export function PythonLibraryEditorPage({return (<><PageContainer>- <PythonLibraryEditorHeader- onSave={handleSave}- onRevert={handleRevert}- isDirty={isDirty}- isSaving={isSaving}- />+ <Stack>+ <PythonLibraryEditorHeader+ onSave={handleSave}+ onRevert={handleRevert}+ isDirty={isDirty && !isRemoteSyncReadOnly}+ isSaving={isSaving}+ />++ {isRemoteSyncReadOnly && (+ <Alert+ className={S.flexStart}+ color="warning"+ p="0.75rem"+ title={t`The Python library is not editable because Remote Sync is in read-only mode.`}+ variant="outline"+ w="auto"+ />+ )}+ </Stack><Card withBorder p={0}><PythonEditor@@ -107,6 +123,7 @@ export function PythonLibraryEditorPage({withPandasCompletionsclassName={S.editor}data-testid="python-editor"+ readOnly={isRemoteSyncReadOnly}/></Card></PageContainer>diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/components/IncrementalTransform/IncrementalTransformSettings.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/components/IncrementalTransform/IncrementalTransformSettings.tsxindex 1d35f314380..0e464f597ee 100644--- a/enterprise/frontend/src/metabase-enterprise/transforms/components/IncrementalTransform/IncrementalTransformSettings.tsx+++ b/enterprise/frontend/src/metabase-enterprise/transforms/components/IncrementalTransform/IncrementalTransformSettings.tsx@@ -6,7 +6,17 @@ import { FormSelect } from "metabase/forms";import { useSelector } from "metabase/lib/redux";import { getMetadata } from "metabase/selectors/metadata";import { getShowMetabaseLinks } from "metabase/selectors/whitelabel";-import { Anchor, Box, Divider, Group, Stack, Switch, Text } from "metabase/ui";+import {+ Anchor,+ Box,+ Divider,+ Group,+ Stack,+ Switch,+ Text,+ Tooltip,+} from "metabase/ui";+import { getIsRemoteSyncReadOnly } from "metabase-enterprise/remote_sync/selectors";import { TitleSection } from "metabase-enterprise/transforms/components/TitleSection";import {SOURCE_STRATEGY_OPTIONS,@@ -39,6 +49,7 @@ export const IncrementalTransformSettings = ({const metadata = useSelector(getMetadata);const libQuery = getLibQuery(source, metadata);const showMetabaseLinks = useSelector(getShowMetabaseLinks);+ const isRemoteSyncReadOnly = useSelector(getIsRemoteSyncReadOnly);// Check if this is a Python transform with exactly one source table// Incremental transforms are only supported for single-table Python transforms@@ -54,22 +65,37 @@ export const IncrementalTransformSettings = ({.with({ isPythonTransform: true }, () => "python" as const).otherwise(() => "native" as const);- const renderIncrementalSwitch = () => (- <Switch- disabled={isMultiTablePythonTransform}- checked={incremental}- size="sm"- label={- isMultiTablePythonTransform- ? t`Incremental transforms are only supported for single data source transforms.`- : t`Only process new and changed data`- }- wrapperProps={{- "data-testid": "incremental-switch",- }}- onChange={(e) => onIncrementalChange(e.target.checked)}- />- );+ const renderIncrementalSwitch = () => {+ const switchContent = (+ <Switch+ disabled={isMultiTablePythonTransform || isRemoteSyncReadOnly}+ checked={incremental}+ size="sm"+ label={+ isMultiTablePythonTransform+ ? t`Incremental transforms are only supported for single data source transforms.`+ : t`Only process new and changed data`+ }+ wrapperProps={{+ "data-testid": "incremental-switch",+ }}+ onChange={(e) => onIncrementalChange(e.target.checked)}+ />+ );++ if (isRemoteSyncReadOnly) {+ return (+ <Tooltip+ label={t`You can't edit this setting since Remote Sync is currently in read-only mode.`}+ withArrow={false}+ >+ <span>{switchContent}</span>+ </Tooltip>+ );+ }++ return switchContent;+ };const label = t`Incremental transformation`;const renderDescription = () => {diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/components/TagMultiSelect/TagMultiSelect.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/components/TagMultiSelect/TagMultiSelect.tsxindex c3778ec78ab..20f633aa33f 100644--- a/enterprise/frontend/src/metabase-enterprise/transforms/components/TagMultiSelect/TagMultiSelect.tsx+++ b/enterprise/frontend/src/metabase-enterprise/transforms/components/TagMultiSelect/TagMultiSelect.tsx@@ -29,9 +29,14 @@ type TagModalType = "update" | "delete";type TagMultiSelectProps = {tagIds: TransformTagId[];onChange: (tagIds: TransformTagId[], undoable?: boolean) => void;+ readOnly?: boolean;};-export function TagMultiSelect({ tagIds, onChange }: TagMultiSelectProps) {+export function TagMultiSelect({+ tagIds,+ onChange,+ readOnly,+}: TagMultiSelectProps) {const { data: tags = [], isLoading } = useListTransformTagsQuery();const [createTag, { isLoading: isCreating }] =useCreateTransformTagMutation();@@ -95,7 +100,7 @@ export function TagMultiSelect({ tagIds, onChange }: TagMultiSelectProps) {<MultiSelectvalue={tagIds.map(getValue)}data={getOptions(tags, trimmedSearchValue)}- placeholder={t`Add tags`}+ placeholder={readOnly ? t`Tags are read-only` : t`Add tags`}searchValue={searchValue}searchablerightSection={@@ -125,6 +130,7 @@ export function TagMultiSelect({ tagIds, onChange }: TagMultiSelectProps) {aria-label={t`Tags`}onChange={handleChange}onSearchChange={setSearchValue}+ disabled={readOnly}/>{modalType === "update" && selectedTagId != null && (<UpdateTagModaldiff --git a/enterprise/frontend/src/metabase-enterprise/transforms/components/TagMultiSelect/TagMultiSelect.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/components/TagMultiSelect/TagMultiSelect.unit.spec.tsxindex 5d36bc41a28..a268891cc7a 100644--- a/enterprise/frontend/src/metabase-enterprise/transforms/components/TagMultiSelect/TagMultiSelect.unit.spec.tsx+++ b/enterprise/frontend/src/metabase-enterprise/transforms/components/TagMultiSelect/TagMultiSelect.unit.spec.tsx@@ -14,18 +14,21 @@ type SetupOpts = {tags?: TransformTag[];tagIds?: TransformTagId[];newTag?: TransformTag;+ readOnly?: boolean;};-function setup({ tags = [], tagIds = [], newTag }: SetupOpts) {+function setup({ tags = [], tagIds = [], newTag, readOnly }: SetupOpts) {setupListTransformTagsEndpoint(tags);if (newTag != null) {setupCreateTransformTagEndpoint(newTag);}const onChange = jest.fn();- renderWithProviders(<TagMultiSelect tagIds={tagIds} onChange={onChange} />);+ renderWithProviders(+ <TagMultiSelect tagIds={tagIds} onChange={onChange} readOnly={readOnly} />,+ );- const input = screen.getByPlaceholderText("Add tags");+ const input = screen.getByLabelText("Tags");return { input, onChange };}@@ -73,4 +76,10 @@ describe("TagMultiSelect", () => {await screen.findByText("A tag with that name already exists"),).toBeInTheDocument();});++ it("should disable input when readOnly flag is set to true", () => {+ const { input } = setup({ readOnly: true });+ expect(input).toBeDisabled();+ expect(input).toHaveAttribute("placeholder", "Tags are read-only");+ });});diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformEditor/TransformEditor.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformEditor/TransformEditor.tsxindex 0166c8d0cbe..273111b7ee6 100644--- a/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformEditor/TransformEditor.tsx+++ b/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformEditor/TransformEditor.tsx@@ -6,6 +6,7 @@ import {type QueryEditorUiState,} from "metabase/querying/editor/components/QueryEditor";import { getMetadata } from "metabase/selectors/metadata";+import { getIsRemoteSyncReadOnly } from "metabase-enterprise/remote_sync/selectors";import * as Lib from "metabase-lib";import type {Database,@@ -26,7 +27,7 @@ type TransformEditorProps = {onAcceptProposed: () => void;onRejectProposed: () => void;onBlur?: () => void;- readOnly?: boolean;+ isEditMode: boolean;transformId?: TransformId;};@@ -40,7 +41,7 @@ export function TransformEditor({onAcceptProposed,onRejectProposed,onBlur,- readOnly,+ isEditMode,transformId,}: TransformEditorProps) {const metadata = useSelector(getMetadata);@@ -56,10 +57,14 @@ export function TransformEditor({[proposedSource, metadata],);const uiOptions = useMemo(- () => getEditorOptions(databases, readOnly),- [databases, readOnly],+ () => getEditorOptions(databases, !isEditMode),+ [databases, isEditMode],);+ const isRemoteSyncReadOnly = useSelector(getIsRemoteSyncReadOnly);+ const showEditDefinitionButton =+ !!transformId && !isEditMode && !isRemoteSyncReadOnly;+const handleQueryChange = (query: Lib.Query) => {const newSource: QueryTransformSource = {...source,@@ -82,8 +87,7 @@ export function TransformEditor({onRejectProposed={onRejectProposed}onBlur={onBlur}topBarInnerContent={- readOnly &&- !!transformId && (+ showEditDefinitionButton && (<EditDefinitionButtonbg="transparent"fz="sm"diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformHeader/TransformHeader.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformHeader/TransformHeader.tsxindex ee5f2dd8cec..cbab22fda20 100644--- a/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformHeader/TransformHeader.tsx+++ b/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformHeader/TransformHeader.tsx@@ -2,11 +2,13 @@ import type { ReactNode } from "react";import { t } from "ttag";import Link from "metabase/common/components/Link/Link";+import { useSelector } from "metabase/lib/redux";import * as Urls from "metabase/lib/urls";import type { StackProps } from "metabase/ui";import { DataStudioBreadcrumbs } from "metabase-enterprise/data-studio/common/components/DataStudioBreadcrumbs";import { PaneHeader } from "metabase-enterprise/data-studio/common/components/PaneHeader";import { useCollectionPath } from "metabase-enterprise/data-studio/common/hooks/use-collection-path/useCollectionPath";+import { getIsRemoteSyncReadOnly } from "metabase-enterprise/remote_sync/selectors";import type { Transform } from "metabase-types/api";import { TransformMoreMenu } from "./TransformMoreMenu";@@ -27,6 +29,7 @@ export function TransformHeader({isEditMode = false,...restProps}: TransformHeaderProps) {+ const isRemoteSyncReadOnly = useSelector(getIsRemoteSyncReadOnly);const { path, isLoadingPath } = useCollectionPath({collectionId: transform.collection_id,namespace: "transforms",@@ -36,7 +39,14 @@ export function TransformHeader({<PaneHeadertitle={<TransformNameInput transform={transform} />}icon="transform"- menu={hasMenu && <TransformMoreMenu transform={transform} />}+ menu={+ hasMenu && (+ <TransformMoreMenu+ readOnly={isRemoteSyncReadOnly}+ transform={transform}+ />+ )+ }tabs={!isEditMode && <TransformTabs transform={transform} />}actions={actions}data-testid="transforms-header"diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformHeader/TransformMoreMenu/TransformMoreMenu.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformHeader/TransformMoreMenu/TransformMoreMenu.tsxindex 07209206192..40a4be75689 100644--- a/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformHeader/TransformMoreMenu/TransformMoreMenu.tsx+++ b/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformHeader/TransformMoreMenu/TransformMoreMenu.tsx@@ -15,10 +15,14 @@ import { MoveTransformModal } from "./MoveTransformModal";import type { TransformMoreMenuModalType } from "./types";type TransformMoreMenuProps = {+ readOnly?: boolean;transform: Transform;};-export function TransformMoreMenu({ transform }: TransformMoreMenuProps) {+export function TransformMoreMenu({+ readOnly,+ transform,+}: TransformMoreMenuProps) {const [modalType, setModalType] = useState<TransformMoreMenuModalType>();const [isHistorySidebarOpen, setIsHistorySidebarOpen] = useState(false);@@ -27,6 +31,7 @@ export function TransformMoreMenu({ transform }: TransformMoreMenuProps) {<TransformMenuonOpenModal={setModalType}onShowHistory={() => setIsHistorySidebarOpen(true)}+ readOnly={readOnly}/>{modalType != null && (<TransformModal@@ -48,9 +53,14 @@ export function TransformMoreMenu({ transform }: TransformMoreMenuProps) {type TransformMenuProps = {onOpenModal: (modalType: TransformMoreMenuModalType) => void;onShowHistory: () => void;+ readOnly?: boolean;};-function TransformMenu({ onOpenModal, onShowHistory }: TransformMenuProps) {+function TransformMenu({+ onOpenModal,+ onShowHistory,+ readOnly,+}: TransformMenuProps) {const handleIconClick = (event: MouseEvent) => {event.preventDefault();event.stopPropagation();@@ -70,18 +80,22 @@ function TransformMenu({ onOpenModal, onShowHistory }: TransformMenuProps) {>{t`History`}</Menu.Item>- <Menu.Item- leftSection={<Icon name="move" />}- onClick={() => onOpenModal("move")}- >- {t`Move`}- </Menu.Item>- <Menu.Item- leftSection={<Icon name="trash" />}- onClick={() => onOpenModal("delete")}- >- {t`Delete`}- </Menu.Item>+ {!readOnly && (+ <>+ <Menu.Item+ leftSection={<Icon name="move" />}+ onClick={() => onOpenModal("move")}+ >+ {t`Move`}+ </Menu.Item>+ <Menu.Item+ leftSection={<Icon name="trash" />}+ onClick={() => onOpenModal("delete")}+ >+ {t`Delete`}+ </Menu.Item>+ </>+ )}</Menu.Dropdown></Menu>);diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformHeader/TransformMoreMenu/TransformMoreMenu.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformHeader/TransformMoreMenu/TransformMoreMenu.unit.spec.tsxnew file mode 100644index 00000000000..bc6d8ac2d39--- /dev/null+++ b/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformHeader/TransformMoreMenu/TransformMoreMenu.unit.spec.tsx@@ -0,0 +1,42 @@+import userEvent from "@testing-library/user-event";++import { render, screen, within } from "__support__/ui";+import { createMockTransform } from "metabase-types/api/mocks";++import { TransformMoreMenu } from "./TransformMoreMenu";++type SetupOps = {+ readOnly?: boolean;+};++const setup = ({ readOnly }: SetupOps = {}) => {+ const transform = createMockTransform();++ render(<TransformMoreMenu transform={transform} readOnly={readOnly} />);+};++const getMenuItem = (name: string | RegExp) =>+ within(screen.getByRole("menu")).getByRole("menuitem", { name });++const queryMenuItem = (name: string | RegExp) =>+ within(screen.getByRole("menu")).queryByRole("menuitem", { name });++describe("TransformMoreMenu", () => {+ it("shows transform options when ellipsis icon is clicked", async () => {+ setup();+ await userEvent.click(screen.getByRole("img", { name: "ellipsis icon" }));++ expect(getMenuItem(/History/)).toBeInTheDocument();+ expect(getMenuItem(/Move/)).toBeInTheDocument();+ expect(getMenuItem(/Delete/)).toBeInTheDocument();+ });++ it("does not show move and delete options when readOnly is true", async () => {+ setup({ readOnly: true });+ await userEvent.click(screen.getByRole("img", { name: "ellipsis icon" }));++ expect(getMenuItem(/History/)).toBeInTheDocument();+ expect(queryMenuItem(/Move/)).not.toBeInTheDocument();+ expect(queryMenuItem(/Delete/)).not.toBeInTheDocument();+ });+});diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/pages/NewTransformPage/NewTransformPage.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/pages/NewTransformPage/NewTransformPage.tsxindex e8423c7b840..73222938f1a 100644--- a/enterprise/frontend/src/metabase-enterprise/transforms/pages/NewTransformPage/NewTransformPage.tsx+++ b/enterprise/frontend/src/metabase-enterprise/transforms/pages/NewTransformPage/NewTransformPage.tsx@@ -172,6 +172,7 @@ function NewTransformPageBody({/>) : (<TransformEditor+ isEditModesource={source}proposedSource={proposedSource?.type === "query" ? proposedSource : undefineddiff --git a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformListPage/TransformListPage.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformListPage/TransformListPage.tsxindex 5a166ffd2d9..122e1098469 100644--- a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformListPage/TransformListPage.tsx+++ b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformListPage/TransformListPage.tsx@@ -13,6 +13,7 @@ import { Ellipsified } from "metabase/common/components/Ellipsified";import { LoadingAndErrorWrapper } from "metabase/common/components/LoadingAndErrorWrapper";import CS from "metabase/css/core/index.css";import type { ColorName } from "metabase/lib/colors/types";+import { useSelector } from "metabase/lib/redux";import * as Urls from "metabase/lib/urls";import { type NamedUser, getUserName } from "metabase/lib/user";import { PLUGIN_TRANSFORMS_PYTHON } from "metabase/plugins";@@ -33,6 +34,7 @@ import { useListTransformsQuery } from "metabase-enterprise/api";import { DataStudioBreadcrumbs } from "metabase-enterprise/data-studio/common/components/DataStudioBreadcrumbs";import { PageContainer } from "metabase-enterprise/data-studio/common/components/PageContainer";import { PaneHeader } from "metabase-enterprise/data-studio/common/components/PaneHeader";+import { getIsRemoteSyncReadOnly } from "metabase-enterprise/remote_sync/selectors";import { CreateTransformMenu } from "metabase-enterprise/transforms/components/CreateTransformMenu";import { ListEmptyState } from "metabase-enterprise/transforms/components/ListEmptyState";import { SHARED_LIB_IMPORT_PATH } from "metabase-enterprise/transforms-python/constants";@@ -80,6 +82,7 @@ const globalFilterFn = (};export const TransformListPage = ({ location }: WithRouterProps) => {+ const isRemoteSyncReadOnly = useSelector(getIsRemoteSyncReadOnly);const targetCollectionId =Urls.extractEntityId(location.query?.collectionId) ?? null;const hasScrolledRef = useRef(false);@@ -314,7 +317,7 @@ export const TransformListPage = ({ location }: WithRouterProps) => {value={searchQuery}onChange={(e) => setSearchQuery(e.target.value)}/>- <CreateTransformMenu />+ {!isRemoteSyncReadOnly && <CreateTransformMenu />}</Flex><Card withBorder p={0}>diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformQueryPage/TransformPaneHeaderActions.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformQueryPage/TransformPaneHeaderActions.tsxindex fe4dcc90243..38b8101231f 100644--- a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformQueryPage/TransformPaneHeaderActions.tsx+++ b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformQueryPage/TransformPaneHeaderActions.tsx@@ -4,6 +4,7 @@ import { useSelector } from "metabase/lib/redux";import { PLUGIN_TRANSFORMS_PYTHON } from "metabase/plugins";import { getMetadata } from "metabase/selectors/metadata";import { PaneHeaderActions } from "metabase-enterprise/data-studio/common/components/PaneHeader";+import { getIsRemoteSyncReadOnly } from "metabase-enterprise/remote_sync/selectors";import { EditDefinitionButton } from "metabase-enterprise/transforms/components/TransformEditor/EditDefinitionButton";import { getValidationResult } from "metabase-enterprise/transforms/utils";import * as Lib from "metabase-lib";@@ -30,6 +31,7 @@ export const TransformPaneHeaderActions = (props: Props) => {transformId,} = props;const metadata = useSelector(getMetadata);+ const isRemoteSyncReadOnly = useSelector(getIsRemoteSyncReadOnly);const { validationResult, isNative } = useMemo(() => {if (source.type === "query") {@@ -49,7 +51,7 @@ export const TransformPaneHeaderActions = (props: Props) => {}, [source, metadata]);const isPythonTransform = source.type === "python";- if (!isPythonTransform && !isNative && !isEditMode) {+ if (!isPythonTransform && !isNative && !isEditMode && !isRemoteSyncReadOnly) {return <EditDefinitionButton transformId={transformId} />;}diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformQueryPage/TransformQueryPage.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformQueryPage/TransformQueryPage.tsxindex 18e9217afe3..5aabdac3444 100644--- a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformQueryPage/TransformQueryPage.tsx+++ b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformQueryPage/TransformQueryPage.tsx@@ -7,7 +7,7 @@ import { t } from "ttag";import { skipToken, useListDatabasesQuery } from "metabase/api";import { LeaveRouteConfirmModal } from "metabase/common/components/LeaveConfirmModal";import { LoadingAndErrorWrapper } from "metabase/common/components/LoadingAndErrorWrapper";-import { useDispatch } from "metabase/lib/redux";+import { useDispatch, useSelector } from "metabase/lib/redux";import * as Urls from "metabase/lib/urls";import { useMetadataToasts } from "metabase/metadata/hooks";import {@@ -21,6 +21,7 @@ import {useUpdateTransformMutation,} from "metabase-enterprise/api";import { PageContainer } from "metabase-enterprise/data-studio/common/components/PageContainer";+import { getIsRemoteSyncReadOnly } from "metabase-enterprise/remote_sync/selectors";import type { Database, Transform } from "metabase-types/api";import { useQueryComplexityChecks } from "../../components/QueryComplexityWarning";@@ -97,6 +98,7 @@ function TransformQueryPageBody({initialSource: transform.source,});const dispatch = useDispatch();+ const isRemoteSyncReadOnly = useSelector(getIsRemoteSyncReadOnly);const [uiState, setUiState] = useState(getInitialUiState);const [updateTransform, { isLoading: isSaving }] =useUpdateTransformMutation();@@ -143,6 +145,13 @@ function TransformQueryPageBody({}}, [source.type, isEditMode, setSourceAndRejectProposed, transform.source]);+ useEffect(() => {+ if (isEditMode && isRemoteSyncReadOnly) {+ // If remote sync is set up to read-only mode, user can't edit transforms+ dispatch(push(Urls.transform(transform.id)));+ }+ }, [isRemoteSyncReadOnly, isEditMode, dispatch, transform.id]);+const handleSave = async () => {if (!isCompleteSource(source)) {return;@@ -211,7 +220,7 @@ function TransformQueryPageBody({proposedSource?.type === "query" ? proposedSource : undefined}uiState={uiState}- readOnly={!isEditMode}+ isEditMode={isEditMode}databases={databases}onChangeSource={setSourceAndRejectProposed}onChangeUiState={setUiState}diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformRunPage/RunSection/RunSection.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformRunPage/RunSection/RunSection.tsxindex 055053746c2..adcb340ab2d 100644--- a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformRunPage/RunSection/RunSection.tsx+++ b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformRunPage/RunSection/RunSection.tsx@@ -5,6 +5,7 @@ import { t } from "ttag";import { ConfirmModal } from "metabase/common/components/ConfirmModal";import { isResourceNotFoundError } from "metabase/lib/errors";+import { useSelector } from "metabase/lib/redux";import * as Urls from "metabase/lib/urls";import { useMetadataToasts } from "metabase/metadata/hooks";import { Anchor, Box, Divider, Group, Stack } from "metabase/ui";@@ -13,6 +14,7 @@ import {useRunTransformMutation,useUpdateTransformMutation,} from "metabase-enterprise/api";+import { getIsRemoteSyncReadOnly } from "metabase-enterprise/remote_sync/selectors";import type { Transform, TransformTagId } from "metabase-types/api";import { trackTransformTriggerManualRun } from "../../../analytics";@@ -28,6 +30,8 @@ type RunSectionProps = {};export function RunSection({ transform }: RunSectionProps) {+ const isRemoteSyncReadOnly = useSelector(getIsRemoteSyncReadOnly);+return (<TitleSectionlabel={t`Run this transform`}@@ -46,7 +50,7 @@ export function RunSection({ transform }: RunSectionProps) {<Box fw="bold">{t`Run it on a schedule with tags`}</Box><Box>{t`Jobs will run all transforms with their tags.`}</Box></Stack>- <TagSection transform={transform} />+ <TagSection transform={transform} readOnly={isRemoteSyncReadOnly} /></Group></TitleSection>);@@ -157,10 +161,11 @@ function RunOutputSection({ transform }: RunOutputSectionProps) {}type TagSectionProps = {+ readOnly: boolean;transform: Transform;};-function TagSection({ transform }: TagSectionProps) {+function TagSection({ readOnly, transform }: TagSectionProps) {const [updateTransform] = useUpdateTransformMutation();const { sendErrorToast, sendSuccessToast, sendUndoToast } =useMetadataToasts();@@ -192,8 +197,9 @@ function TagSection({ transform }: TagSectionProps) {return (<Box flex={1}><TagMultiSelect- tagIds={transform.tag_ids ?? []}onChange={handleTagListChange}+ readOnly={readOnly}+ tagIds={transform.tag_ids ?? []}/></Box>);diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformSettingsPage/TransformSettingsSection/TransformSettingsSection.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformSettingsPage/TransformSettingsSection/TransformSettingsSection.tsxindex 62f3c72efb4..f873992efdb 100644--- a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformSettingsPage/TransformSettingsSection/TransformSettingsSection.tsx+++ b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformSettingsPage/TransformSettingsSection/TransformSettingsSection.tsx@@ -8,6 +8,7 @@ import {} from "metabase/api";import Link from "metabase/common/components/Link";import CS from "metabase/css/core/index.css";+import { useSelector } from "metabase/lib/redux";import * as Urls from "metabase/lib/urls";import { UserInput } from "metabase/metadata/components";import { useMetadataToasts } from "metabase/metadata/hooks";@@ -21,9 +22,10 @@ import {Stack,Text,} from "metabase/ui";+import { useUpdateTransformMutation } from "metabase-enterprise/api";+import { getIsRemoteSyncReadOnly } from "metabase-enterprise/remote_sync/selectors";import type { Transform, UserId } from "metabase-types/api";-import { useUpdateTransformMutation } from "../../../../api/transform";import { TitleSection } from "../../../components/TitleSection";import { isTransformRunning, sourceDatabaseId } from "../../../utils";@@ -36,25 +38,29 @@ type TransformSettingsSectionProps = {export const TransformSettingsSection = ({transform,-}: TransformSettingsSectionProps) => (- <Stack gap="2.5rem">- <OwnerSection transform={transform} />- <TitleSection- label={t`Transform target`}- description={t`Change what this transform generates and where.`}- >- <Group p="lg">- <TargetInfo transform={transform} />- </Group>- <Divider />- <Group p="lg">- <EditTargetButton transform={transform} />- <EditMetadataButton transform={transform} />- </Group>- </TitleSection>- <UpdateIncrementalSettings transform={transform} />- </Stack>-);+}: TransformSettingsSectionProps) => {+ const isRemoteSyncReadOnly = useSelector(getIsRemoteSyncReadOnly);++ return (+ <Stack gap="2.5rem">+ <OwnerSection transform={transform} />+ <TitleSection+ label={t`Transform target`}+ description={t`Change what this transform generates and where.`}+ >+ <Group p="lg">+ <TargetInfo transform={transform} />+ </Group>+ <Divider />+ <Group p="lg">+ {!isRemoteSyncReadOnly && <EditTargetButton transform={transform} />}+ <EditMetadataButton transform={transform} />+ </Group>+ </TitleSection>+ <UpdateIncrementalSettings transform={transform} />+ </Stack>+ );+};type TargetInfoProps = {transform: Transform;diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformSettingsPage/TransformSettingsSection/TargetSection.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformSettingsPage/TransformSettingsSection/TransformSettingsSection.unit.spec.tsxsimilarity index 69%rename from enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformSettingsPage/TransformSettingsSection/TargetSection.unit.spec.tsxrename to enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformSettingsPage/TransformSettingsSection/TransformSettingsSection.unit.spec.tsxindex ac57f6983bd..c660ddeb1ff 100644--- a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformSettingsPage/TransformSettingsSection/TargetSection.unit.spec.tsx+++ b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformSettingsPage/TransformSettingsSection/TransformSettingsSection.unit.spec.tsx@@ -4,9 +4,10 @@ import {setupDatabaseEndpoints,setupUsersEndpoints,} from "__support__/server-mocks";+import { mockSettings } from "__support__/settings";import { renderWithProviders, screen } from "__support__/ui";import * as Urls from "metabase/lib/urls";-import type { Transform } from "metabase-types/api";+import type { EnterpriseSettings, Transform } from "metabase-types/api";import {createMockDatabase,createMockTransform,@@ -14,14 +15,19 @@ import {createMockTransformRun,createMockUser,} from "metabase-types/api/mocks";+import { createMockState } from "metabase-types/store/mocks";import { TransformSettingsSection } from "./TransformSettingsSection";type SetupOpts = {+ remoteSyncType?: EnterpriseSettings["remote-sync-type"];transform?: Transform;};-function setup({ transform = createMockTransform() }: SetupOpts) {+function setup({+ transform = createMockTransform(),+ remoteSyncType,+}: SetupOpts) {setupDatabaseEndpoints(createMockDatabase({ id: 1 }));setupUsersEndpoints([createMockUser({@@ -41,11 +47,20 @@ function setup({ transform = createMockTransform() }: SetupOpts) {path={Urls.transform(transform.id)}component={() => <TransformSettingsSection transform={transform} />}/>,- { withRouter: true, initialRoute: Urls.transform(transform.id) },+ {+ withRouter: true,+ initialRoute: Urls.transform(transform.id),+ storeInitialState: createMockState({+ settings: mockSettings({+ "remote-sync-type": remoteSyncType,+ "remote-sync-enabled": !!remoteSyncType,+ }),+ }),+ },);}-describe("TargetSection", () => {+describe("TransformSettingsSection", () => {it("should disable the change target button when the transform is running", () => {setup({transform: createMockTransform({@@ -65,6 +80,26 @@ describe("TargetSection", () => {const button = screen.getByRole("button", { name: "Change target" });expect(button).toBeEnabled();});++ describe("when remote sync is read-only", () => {+ beforeEach(() => {+ setup({ remoteSyncType: "read-only" });+ });++ it("does not show the change target button", () => {+ expect(+ screen.queryByRole("button", { name: "Change target" }),+ ).not.toBeInTheDocument();+ });++ it("makes Incremental transformation switch disabled", () => {+ expect(+ screen.getByRole("switch", {+ name: /Only process new and changed data/,+ }),+ ).toBeDisabled();+ });+ });});describe("OwnerSection", () => {