Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Make info panel headings consistent (color, line-height, margin-bottom) (#63882)

Kamil Mielnika52d58a3e2e6
diff --git a/frontend/src/metabase/common/components/Sidesheet/SidesheetCard.tsx b/frontend/src/metabase/common/components/Sidesheet/SidesheetCard.tsx
index 68a0745c02f..436d54b7a9c 100644
--- a/frontend/src/metabase/common/components/Sidesheet/SidesheetCard.tsx
+++ b/frontend/src/metabase/common/components/Sidesheet/SidesheetCard.tsx
@@ -41,5 +41,5 @@ export const SidesheetCard = ({
};
export const SidesheetCardTitle = (props: TitleProps) => (
- <Title lh={1} mb=".75rem" c="text-medium" order={4} {...props} />
+ <Title mb="sm" c="text-medium" order={4} {...props} />
);
diff --git a/frontend/src/metabase/common/components/Sidesheet/SidesheetCardSection.tsx b/frontend/src/metabase/common/components/Sidesheet/SidesheetCardSection.tsx
index 07eb0bab615..2abbaeefe6b 100644
--- a/frontend/src/metabase/common/components/Sidesheet/SidesheetCardSection.tsx
+++ b/frontend/src/metabase/common/components/Sidesheet/SidesheetCardSection.tsx
@@ -17,7 +17,7 @@ export const SidesheetCardSection = ({
return (
<Box {...styleProps}>
{title && (
- <Title mb="sm" c="text-light" order={4}>
+ <Title mb="sm" c="text-medium" order={4}>
{title}
</Title>
)}
diff --git a/frontend/src/metabase/query_builder/components/view/sidebars/QuestionInfoSidebar/QuestionInfoSidebar.tsx b/frontend/src/metabase/query_builder/components/view/sidebars/QuestionInfoSidebar/QuestionInfoSidebar.tsx
index 7c5e4604492..7c461d2d488 100644
--- a/frontend/src/metabase/query_builder/components/view/sidebars/QuestionInfoSidebar/QuestionInfoSidebar.tsx
+++ b/frontend/src/metabase/query_builder/components/view/sidebars/QuestionInfoSidebar/QuestionInfoSidebar.tsx
@@ -97,16 +97,19 @@ export const QuestionInfoSidebar = ({
<Tabs.Panel value="overview">
<Stack gap="lg">
<SidesheetCard pb="md">
- <Stack gap="sm">
+ <Stack gap={0}>
<SidesheetCardTitle>{t`Description`}</SidesheetCardTitle>
- <SidesheetEditableDescription
- description={description}
- onChange={handleSave}
- canWrite={canWrite}
- />
- <PLUGIN_MODERATION.ModerationReviewTextForQuestion
- question={question}
- />
+
+ <Stack gap="sm">
+ <SidesheetEditableDescription
+ description={description}
+ onChange={handleSave}
+ canWrite={canWrite}
+ />
+ <PLUGIN_MODERATION.ModerationReviewTextForQuestion
+ question={question}
+ />
+ </Stack>
</Stack>
</SidesheetCard>
<SidesheetCard>