Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Rename Data Studio Library +New menu action labels (#68162)

Maz Amelia62aab3f1b10
diff --git a/e2e/test/scenarios/data-studio/data-studio-library.cy.spec.ts b/e2e/test/scenarios/data-studio/data-studio-library.cy.spec.ts
index c1080bb9277..fbe5fc6d843 100644
--- a/e2e/test/scenarios/data-studio/data-studio-library.cy.spec.ts
+++ b/e2e/test/scenarios/data-studio/data-studio-library.cy.spec.ts
@@ -111,7 +111,7 @@ describe("scenarios > data studio > library", () => {
cy.log("Publish a table from the 'New' menu");
H.DataStudio.Library.newButton().click();
- H.popover().findByText("Publish a table").click();
+ H.popover().findByText("Published table").click();
cy.log("Select a table and click 'Publish'");
H.entityPickerModalItem(3, "Orders").click();
@@ -127,7 +127,7 @@ describe("scenarios > data studio > library", () => {
"Verify tables in the entity picker are disabled if already published",
);
H.DataStudio.Library.newButton().click();
- H.popover().findByText("Publish a table").click();
+ H.popover().findByText("Published table").click();
H.entityPickerModalItem(3, "Orders").should("have.attr", "data-disabled");
H.entityPickerModalItem(3, "People").should(
"not.have.attr",
@@ -198,7 +198,7 @@ describe("scenarios > data studio > library", () => {
cy.log("Publish a table via the +New menu");
H.DataStudio.Library.newButton().click();
- H.popover().findByText("Publish a table").click();
+ H.popover().findByText("Published table").click();
H.entityPickerModalItem(3, "Orders").click();
H.entityPickerModal().button("Publish").click();
diff --git a/e2e/test/scenarios/data-studio/snippets.cy.spec.ts b/e2e/test/scenarios/data-studio/snippets.cy.spec.ts
index 192ea3e12ff..f9ef50e1a20 100644
--- a/e2e/test/scenarios/data-studio/snippets.cy.spec.ts
+++ b/e2e/test/scenarios/data-studio/snippets.cy.spec.ts
@@ -19,7 +19,7 @@ describe("scenarios > data studio > snippets", () => {
H.DataStudio.Library.visit();
H.DataStudio.Library.newButton().click();
- H.popover().findByText("New snippet").click();
+ H.popover().findByText("Snippet").click();
H.DataStudio.Snippets.newPage().should("be.visible");
H.DataStudio.Snippets.saveButton().should("be.disabled");
@@ -178,7 +178,7 @@ describe("scenarios > data studio > snippets", () => {
H.DataStudio.Library.visit();
H.DataStudio.Library.newButton().click();
- H.popover().findByText("New snippet folder").click();
+ H.popover().findByText("Snippet folder").click();
H.modal().within(() => {
cy.findByLabelText("Give your folder a name").type("Test Folder");
@@ -194,7 +194,7 @@ describe("scenarios > data studio > snippets", () => {
.should("be.visible");
H.DataStudio.Library.newButton().click();
- H.popover().findByText("New snippet").click();
+ H.popover().findByText("Snippet").click();
H.DataStudio.Snippets.nameInput().clear().type("Folder snippet");
H.DataStudio.Snippets.editor.type("SELECT 1");
diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/LibrarySectionLayout/CreateMenu.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/LibrarySectionLayout/CreateMenu.tsx
index 246319a29df..2f0e6ff7402 100644
--- a/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/LibrarySectionLayout/CreateMenu.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/LibrarySectionLayout/CreateMenu.tsx
@@ -44,7 +44,7 @@ export const CreateMenu = ({
leftSection={<FixedSizeIcon name="publish" />}
onClick={() => setModal("publish-table")}
>
- {t`Publish a table`}
+ {t`Published table`}
</Menu.Item>,
canCreateMetric && (
<Menu.Item
@@ -66,7 +66,7 @@ export const CreateMenu = ({
leftSection={<FixedSizeIcon name="snippet" />}
aria-label={t`Create new snippet`}
>
- {t`New snippet`}
+ {t`Snippet`}
</Menu.Item>
),
hasNativeWrite && PLUGIN_SNIPPET_FOLDERS.isEnabled && (
@@ -75,7 +75,7 @@ export const CreateMenu = ({
leftSection={<FixedSizeIcon name="folder" />}
onClick={() => setModal("snippet-folder")}
>
- {t`New snippet folder`}
+ {t`Snippet folder`}
</Menu.Item>
),
].filter(Boolean);
diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/LibrarySectionLayout/CreateMenu.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/LibrarySectionLayout/CreateMenu.unit.spec.tsx
index d76f5383157..97ab40655a1 100644
--- a/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/LibrarySectionLayout/CreateMenu.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/LibrarySectionLayout/CreateMenu.unit.spec.tsx
@@ -62,12 +62,7 @@ describe("CreateMenu", () => {
expect(
screen.getAllByRole("menuitem").map((item) => item.textContent),
- ).toEqual([
- "Publish a table",
- "Metric",
- "New snippet",
- "New snippet folder",
- ]);
+ ).toEqual(["Published table", "Metric", "Snippet", "Snippet folder"]);
});
it("renders publish option for data analysts", async () => {
@@ -77,7 +72,7 @@ describe("CreateMenu", () => {
expect(
screen.getAllByRole("menuitem").map((item) => item.textContent),
- ).toEqual(["Publish a table"]);
+ ).toEqual(["Published table"]);
});
it("renders publish and metric options if user only has query builder access", async () => {
@@ -87,7 +82,7 @@ describe("CreateMenu", () => {
expect(
screen.getAllByRole("menuitem").map((item) => item.textContent),
- ).toEqual(["Publish a table", "Metric"]);
+ ).toEqual(["Published table", "Metric"]);
});
it("does not render Metric option when canWriteToMetricCollection is false", async () => {
@@ -106,7 +101,7 @@ describe("CreateMenu", () => {
expect(
screen.getAllByRole("menuitem").map((item) => item.textContent),
- ).toEqual(["Publish a table", "New snippet", "New snippet folder"]);
+ ).toEqual(["Published table", "Snippet", "Snippet folder"]);
});
it("renders nothing if remote sync is set to read-only", () => {