The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Migrate BulkActionBar component (#83745)
Nick Fitzpatricka699ba891999
diff --git a/frontend/src/metabase/common/components/BulkActionBar/BulkActionBar.module.css b/frontend/src/metabase/common/components/BulkActionBar/BulkActionBar.module.cssnew file mode 100644index 00000000000..ca8ad7ca943--- /dev/null+++ b/frontend/src/metabase/common/components/BulkActionBar/BulkActionBar.module.css@@ -0,0 +1,13 @@+/* The full-width wrapper must not block clicks on the page beneath it */+.clickThrough {+ pointer-events: none;+}++.toastCard {+ display: flex;+ flex-direction: row;+ align-items: center;+ justify-content: space-between;+ gap: 2.5rem;+ pointer-events: auto;+}diff --git a/frontend/src/metabase/common/components/BulkActionBar/BulkActionBar.styled.tsx b/frontend/src/metabase/common/components/BulkActionBar/BulkActionBar.styled.tsxdeleted file mode 100644index f84367f45f2..00000000000--- a/frontend/src/metabase/common/components/BulkActionBar/BulkActionBar.styled.tsx+++ /dev/null@@ -1,28 +0,0 @@-// eslint-disable-next-line eslint-js/no-restricted-imports-import styled from "@emotion/styled";--import { NAV_SIDEBAR_WIDTH } from "metabase/nav/constants";-import { Card } from "metabase/ui";--export const BulkActionsToast = styled.div<{ isNavbarOpen: boolean }>`- position: fixed;- bottom: 0;- left: 50%;- margin-left: ${(props) =>- props.isNavbarOpen ? `${parseInt(NAV_SIDEBAR_WIDTH) / 2}px` : "0"};- margin-bottom: var(--mantine-spacing-lg);- transform: translateX(-50%);- z-index: 150;-`;--// Unjustified type cast. FIXME-export const ToastCard = styled(Card)`- background-color: var(--mb-color-tooltip-background);- color: var(--mb-color-tooltip-text);- padding: 0.75rem var(--mantine-spacing-lg);- display: flex;- flex-direction: row;- align-items: center;- justify-content: space-between;- gap: 2.5rem;-` as unknown as typeof Card;diff --git a/frontend/src/metabase/common/components/BulkActionBar/BulkActionBar.tsx b/frontend/src/metabase/common/components/BulkActionBar/BulkActionBar.tsxindex 4271abf97ce..7dbb441be3c 100644--- a/frontend/src/metabase/common/components/BulkActionBar/BulkActionBar.tsx+++ b/frontend/src/metabase/common/components/BulkActionBar/BulkActionBar.tsx@@ -2,11 +2,12 @@ import cx from "classnames";import type { HTMLAttributes } from "react";import Animation from "metabase/css/core/animation.module.css";+import { NAV_SIDEBAR_WIDTH } from "metabase/nav/constants";import { useSelector } from "metabase/redux";import { getIsNavbarOpen } from "metabase/selectors/app";-import { type BoxProps, Flex, Portal, Text } from "metabase/ui";+import { type BoxProps, Card, Flex, Portal, Text } from "metabase/ui";-import { BulkActionsToast, ToastCard } from "./BulkActionBar.styled";+import S from "./BulkActionBar.module.css";type BulkActionsProps = {opened: boolean;@@ -44,17 +45,31 @@ export const BulkActionBarPortal = ({}return (<Portal>- <BulkActionsToast- isNavbarOpen={isNavbarOpen}- className={cx(className, Animation.popToast)}+ <Flex+ className={cx(S.clickThrough, className, Animation.popToast)}+ pos="fixed"+ left={0}+ right={0}+ bottom={0}+ justify="center"+ mb="lg"+ ml={isNavbarOpen ? NAV_SIDEBAR_WIDTH : 0}>- <ToastCard data-testid="toast-card" {...props}>+ <Card+ className={S.toastCard}+ bg="tooltip-background"+ c="tooltip-text"+ py="md"+ px="lg"+ data-testid="toast-card"+ {...props}+ >{message && <Text c="tooltip-text">{message}</Text>}<Flex gap="sm" align="center">{children}</Flex>- </ToastCard>- </BulkActionsToast>+ </Card>+ </Flex></Portal>);};diff --git a/frontend/src/metabase/common/components/BulkActionBar/index.tsx b/frontend/src/metabase/common/components/BulkActionBar/index.tsxindex 74630f81b56..c9a17ce03bf 100644--- a/frontend/src/metabase/common/components/BulkActionBar/index.tsx+++ b/frontend/src/metabase/common/components/BulkActionBar/index.tsx@@ -1,3 +1,2 @@export * from "./BulkActionBar";export * from "./BulkActionButton";-export * from "./BulkActionBar.styled";diff --git a/frontend/src/metabase/css/core/animation.module.css b/frontend/src/metabase/css/core/animation.module.cssindex ef5b3c83bb2..6611bcc9f77 100644--- a/frontend/src/metabase/css/core/animation.module.css+++ b/frontend/src/metabase/css/core/animation.module.css@@ -56,12 +56,12 @@@keyframes pop-toast {from {opacity: 0;- transform: translate(-50%, 100px);+ transform: translateY(100px);}to {opacity: 1;- transform: translate(-50%, 0);+ transform: translateY(0);}}