The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Fix filters not closing properly on native SQL questions (#68216)
kevinkelleher12a76e880fdda1
diff --git a/frontend/src/metabase/parameters/components/ParameterValueWidget.tsx b/frontend/src/metabase/parameters/components/ParameterValueWidget.tsxindex 6b3d7f84d42..89fbe34b065 100644--- a/frontend/src/metabase/parameters/components/ParameterValueWidget.tsx+++ b/frontend/src/metabase/parameters/components/ParameterValueWidget.tsx@@ -253,6 +253,7 @@ export const ParameterValueWidget = ({position="bottom-start"trapFocusmiddlewares={{ flip: true, shift: true }}+ clickOutsideEvents={["mousedown", "touchstart", "pointerdown"]}{...popoverProps}><Popover.Target>diff --git a/frontend/src/metabase/parameters/components/ParametersList/ParametersList.unit.spec.tsx b/frontend/src/metabase/parameters/components/ParametersList/ParametersList.unit.spec.tsxnew file mode 100644index 00000000000..d75c93f7126--- /dev/null+++ b/frontend/src/metabase/parameters/components/ParametersList/ParametersList.unit.spec.tsx@@ -0,0 +1,46 @@+import userEvent from "@testing-library/user-event";++import { renderWithProviders, screen } from "__support__/ui";+import { createMockParameter } from "metabase-types/api/mocks";++import { ParametersList } from "./ParametersList";+import type { ParametersListProps } from "./types";++function setup(props: Partial<ParametersListProps> = {}) {+ const parameters = [+ createMockParameter({+ id: "1",+ name: "Parameter 1",+ slug: "parameter-1",+ type: "string/contains",+ }),+ createMockParameter({+ id: "2",+ name: "Parameter 2",+ slug: "parameter-2",+ type: "string/does-not-contain",+ }),+ ];+ renderWithProviders(<ParametersList parameters={parameters} {...props} />);+}++describe("ParametersList", () => {+ it("should render parameters", () => {+ setup();+ expect(screen.getByText("Parameter 1")).toBeInTheDocument();+ expect(screen.getByText("Parameter 2")).toBeInTheDocument();+ });++ it("should close the first parameter widget when the second parameter widget is clicked metabase #67672", async () => {+ setup({ isEditing: true });+ await userEvent.click(screen.getByText("Parameter 1"));+ expect(screen.getByText("Contains", { exact: false })).toBeInTheDocument();+ await userEvent.click(screen.getByText("Parameter 2"));+ expect(+ screen.getByText("Does not contain", { exact: false }),+ ).toBeInTheDocument();+ expect(+ screen.queryByText("Contains", { exact: false }),+ ).not.toBeInTheDocument();+ });+});