Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Disable experiments by default and set visibility to internal. (#73700)

technomancya8eb93e0c803
diff --git a/src/metabase/util/experiment.cljc b/src/metabase/util/experiment.cljc
index 76f6a1cd7f0..0f239704485 100644
--- a/src/metabase/util/experiment.cljc
+++ b/src/metabase/util/experiment.cljc
@@ -19,10 +19,10 @@
(defonce ^{:private true
:doc "Atom holding a zero-arg function that returns whether experiments are enabled.
- Defaults to (constantly true). On JVM, wired to the setting getter at startup.
+ On JVM, wired to the setting getter at startup.
On CLJS, wired to read from bootstrap data."}
experiments-enabled-fn
- (atom (constantly true)))
+ (atom (constantly false)))
(defn experiments-enabled?
"Returns true if experiments are globally enabled. Checks the setting on every call."
diff --git a/src/metabase/util/experiment/settings.clj b/src/metabase/util/experiment/settings.clj
index 2b9b4c3f416..4eea2fa059a 100644
--- a/src/metabase/util/experiment/settings.clj
+++ b/src/metabase/util/experiment/settings.clj
@@ -9,6 +9,7 @@
(deferred-tru "Enable or disable all code experiments. When disabled, only the production code path runs.")
:type :boolean
:default false
+ :doc false
:visibility :admin
:export? false
:audit :getter)
diff --git a/test/metabase/util/experiment_test.cljc b/test/metabase/util/experiment_test.cljc
index c3cf1bfa32d..e957e1c537d 100644
--- a/test/metabase/util/experiment_test.cljc
+++ b/test/metabase/util/experiment_test.cljc
@@ -11,10 +11,16 @@
[(fn [result] (swap! results conj result))
results]))
+#_{:clj-kondo/ignore [:metabase/validate-deftest]}
(use-fixtures :each
(fn [t]
+ ;; this is safe because we don't have any parallel deftests in this namespace
+ ;; but the linter rule is over-general and assumes we might. could be a problem
+ ;; if a parallel test gets added, maybe.
(binding [experiment/*sync?* true]
- (t))))
+ (experiment/set-experiments-enabled-fn! (constantly true))
+ (t)
+ (experiment/set-experiments-enabled-fn! (constantly false)))))
;;; ------------------------------------------------ Core behavior ------------------------------------------------