Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Visualizer: Preserve the `results_timezone` if the source has one (#76446)

Braden Shepherdsona926f047be28
diff --git a/frontend/src/metabase/visualizer/utils/merge-data.ts b/frontend/src/metabase/visualizer/utils/merge-data.ts
index 4928076ef96..f4cd9507a5a 100644
--- a/frontend/src/metabase/visualizer/utils/merge-data.ts
+++ b/frontend/src/metabase/visualizer/utils/merge-data.ts
@@ -90,10 +90,21 @@ export function mergeVisualizerData({
.flat(),
);
+ // Carry the timezone from the source dataset(s) so time-series charts format datetimes in the query's
+ // report timezone. Without it the cartesian axis falls back to UTC (#73972).
+ const sourceData = referencedColumns
+ .map((ref) => datasets[ref.sourceId])
+ .find(
+ (dataset) =>
+ dataset?.error == null && dataset?.data?.results_timezone != null,
+ )?.data;
+
return {
cols: columns,
rows: _.zip(...unzippedRows),
insights,
+ results_timezone: sourceData?.results_timezone,
+ requested_timezone: sourceData?.requested_timezone,
// this is incorrect - `data.cols` are not the same as `data.results_metadata.columns`
results_metadata: { columns: columns as unknown as Field[] },
};
diff --git a/frontend/src/metabase/visualizer/utils/merge-data.unit.spec.ts b/frontend/src/metabase/visualizer/utils/merge-data.unit.spec.ts
index 7ad4003fd29..b6e4c544953 100644
--- a/frontend/src/metabase/visualizer/utils/merge-data.unit.spec.ts
+++ b/frontend/src/metabase/visualizer/utils/merge-data.unit.spec.ts
@@ -156,4 +156,38 @@ describe("mergeVisualizerData", () => {
expect(result.insights).toEqual([]);
},
);
+
+ it("should carry the results timezone from the source dataset so charts render in the report timezone (#73972)", () => {
+ const result = mergeVisualizerData({
+ columns: [
+ createMockColumn(StringColumn({ name: "COLUMN_1" })),
+ createMockColumn(NumberColumn({ name: "COLUMN_2" })),
+ ],
+ columnValuesMapping: {
+ COLUMN_1: [
+ { sourceId: "card:1", originalName: "CREATED_AT", name: "COLUMN_1" },
+ ],
+ COLUMN_2: [
+ { sourceId: "card:1", originalName: "count", name: "COLUMN_2" },
+ ],
+ },
+ datasets: {
+ "card:1": createMockDataset({
+ data: {
+ cols: [
+ createMockColumn(StringColumn({ name: "CREATED_AT" })),
+ createMockColumn(NumberColumn({ name: "count" })),
+ ],
+ rows: [["2025-01-01T00:00:00-08:00", 1]],
+ results_timezone: "America/Los_Angeles",
+ },
+ }),
+ },
+ dataSources: [
+ { id: "card:1", sourceId: 1, type: "card", name: "Chart 1" },
+ ],
+ });
+
+ expect(result.results_timezone).toBe("America/Los_Angeles");
+ });
});