The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
[Metabot] Hide Metabot copy action for textless responses (#79727)
Sloan Spargerab6756d28ff4
diff --git a/frontend/src/metabase/metabot/components/MetabotChat/MetabotChatMessage.tsx b/frontend/src/metabase/metabot/components/MetabotChat/MetabotChatMessage.tsxindex b4f7d967219..7a070c66034 100644--- a/frontend/src/metabase/metabot/components/MetabotChat/MetabotChatMessage.tsx+++ b/frontend/src/metabase/metabot/components/MetabotChat/MetabotChatMessage.tsx@@ -237,6 +237,8 @@ export const AgentMessage = ({const canGiveFeedback = canActOnMessage && !!setFeedbackMessage;const canFork = canActOnMessage && !isFailedTurn && !!onFork;const clipboard = useClipboard({ timeout: 2000 });+ const copyText = getCopyText();+ const canCopy = !isInProgress && copyText.length > 0;return (<MessageContainer chatRole={message.role} {...props}>@@ -295,12 +297,12 @@ export const AgentMessage = ({.exhaustive()}{!hideActions && (<Flex className={Styles.messageActions} align="center">- {!isInProgress && (+ {canCopy && (<Tooltip label={clipboard.copied ? t`Copied!` : t`Copy`}><ActionIconh="sm"data-testid="metabot-chat-message-copy"- onClick={() => clipboard.copy(getCopyText())}+ onClick={() => clipboard.copy(copyText)}><Icon name="copy" size="1rem" /></ActionIcon>diff --git a/frontend/src/metabase/metabot/tests/chat-message-rendering.unit.spec.tsx b/frontend/src/metabase/metabot/tests/chat-message-rendering.unit.spec.tsxindex f88c6b3ebae..85837ee2e4e 100644--- a/frontend/src/metabase/metabot/tests/chat-message-rendering.unit.spec.tsx+++ b/frontend/src/metabase/metabot/tests/chat-message-rendering.unit.spec.tsx@@ -94,6 +94,30 @@ describe("AgentMessage", () => {).not.toBeInTheDocument();});+ it("hides the copy action when the agent response has no text", () => {+ renderWithProviders(+ <Messages+ messages={[+ { id: "u1", role: "user", type: "text", message: "hi" },+ {+ id: "a1",+ role: "agent",+ type: "data_part",+ part: { type: "data-todo_list", data: [] },+ },+ ]}+ isDoingScience={false}+ debug={false}+ conversationId="convo-1"+ />,+ );++ const [, agentMessage] = screen.getAllByTestId("metabot-chat-message");+ expect(+ within(agentMessage).queryByTestId("metabot-chat-message-copy"),+ ).not.toBeInTheDocument();+ });+describe("feedback controls", () => {const conversation: MetabotChatMessage[] = [{ id: "u1", role: "user", type: "text", message: "hi" },