The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
GDGT-3090: preserve display type when opening a transform inspector card as a question (#82260)
Will Fryabebe75424ac
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms-inspector/pages/TransformInspectPage/components/LensSections/DefaultLensSections/components/VisualizationCard.tsx b/enterprise/frontend/src/metabase-enterprise/transforms-inspector/pages/TransformInspectPage/components/LensSections/DefaultLensSections/components/VisualizationCard.tsxindex 1c9e8b28e4a..fe0504699f9 100644--- a/enterprise/frontend/src/metabase-enterprise/transforms-inspector/pages/TransformInspectPage/components/LensSections/DefaultLensSections/components/VisualizationCard.tsx+++ b/enterprise/frontend/src/metabase-enterprise/transforms-inspector/pages/TransformInspectPage/components/LensSections/DefaultLensSections/components/VisualizationCard.tsx@@ -61,7 +61,9 @@ export const VisualizationCard = memo(const isLoading = isMetadataLoading || isDataLoading;const questionUrl = rawSeries?.[0]?.card- ? Urls.serializedQuestion(rawSeries[0].card)+ ? Urls.serializedQuestion(rawSeries[0].card, {+ includeDisplayIsLocked: true,+ }): undefined;const getHref = questionUrl ? () => questionUrl : undefined;diff --git a/enterprise/frontend/src/metabase-enterprise/transforms-inspector/pages/TransformInspectPage/components/LensSections/DefaultLensSections/components/VisualizationCard.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/transforms-inspector/pages/TransformInspectPage/components/LensSections/DefaultLensSections/components/VisualizationCard.unit.spec.tsxnew file mode 100644index 00000000000..ba2762bbf34--- /dev/null+++ b/enterprise/frontend/src/metabase-enterprise/transforms-inspector/pages/TransformInspectPage/components/LensSections/DefaultLensSections/components/VisualizationCard.unit.spec.tsx@@ -0,0 +1,107 @@+import userEvent from "@testing-library/user-event";+import fetchMock from "fetch-mock";++import { setupRunInspectorQueryEndpoint } from "__support__/server-mocks/transform";+import {+ mockGetBoundingClientRect,+ renderWithProviders,+ screen,+} from "__support__/ui";+import { deserializeCardFromUrl } from "metabase/common/utils/card";+import { registerVisualizations } from "metabase/visualizations/register";+import type { InspectorCard } from "metabase-types/api";+import {+ createMockCardQueryMetadata,+ createMockColumn,+ createMockDataset,+ createMockInspectorCard,+ createMockTransform,+} from "metabase-types/api/mocks";++import { LensContentProvider } from "../../../LensContent/LensContentContext";++import { VisualizationCard } from "./VisualizationCard";++registerVisualizations();++function setup({ card }: { card: InspectorCard }) {+ const lensId = "lens-1";+ // Chart titles only render as links when the card is large enough to show them.+ mockGetBoundingClientRect({ width: 800, height: 400 });+ fetchMock.post(+ "path:/api/dataset/query_metadata",+ createMockCardQueryMetadata(),+ );+ setupRunInspectorQueryEndpoint(+ 1,+ lensId,+ createMockDataset({+ data: {+ rows: [+ ["shipped", 42],+ ["pending", 7],+ ],+ cols: [+ createMockColumn({+ name: "status",+ display_name: "Status",+ base_type: "type/Text",+ source: "breakout",+ }),+ createMockColumn({+ name: "count",+ display_name: "Count",+ base_type: "type/Integer",+ source: "aggregation",+ }),+ ],+ },+ }),+ );++ renderWithProviders(+ <LensContentProvider+ transform={createMockTransform()}+ lens={{+ id: lensId,+ display_name: "Test Lens",+ sections: [],+ cards: [],+ }}+ lensHandle={{ id: lensId }}+ alertsByCardId={{}}+ drillLensesByCardId={{}}+ collectedCardStats={{}}+ navigateToLens={jest.fn()}+ pushNewStats={jest.fn()}+ markCardStartedLoading={jest.fn()}+ markCardLoaded={jest.fn()}+ subscribeToCardLoaded={jest.fn(() => jest.fn())}+ >+ <VisualizationCard card={card} />+ </LensContentProvider>,+ );+}++describe("VisualizationCard", () => {+ it("opens the card as a question that keeps the card's visualization", async () => {+ setup({+ card: createMockInspectorCard({+ title: "Status distribution",+ display: "pie",+ }),+ });++ const titleLink = await screen.findByRole("link", {+ name: "Status distribution",+ });+ // The title only resolves its real href once it's hovered or focused.+ await userEvent.hover(titleLink);+ const serializedCard = titleLink.getAttribute("href")?.split("#")[1] ?? "";++ expect(deserializeCardFromUrl(serializedCard)).toMatchObject({+ display: "pie",+ displayIsLocked: true,+ });+ });+});diff --git a/frontend/src/metabase/common/components/ExplicitSize/__mocks__/ExplicitSize.tsx b/frontend/src/metabase/common/components/ExplicitSize/__mocks__/ExplicitSize.tsxindex 7dab004e7d5..f645a5b8b31 100644--- a/frontend/src/metabase/common/components/ExplicitSize/__mocks__/ExplicitSize.tsx+++ b/frontend/src/metabase/common/components/ExplicitSize/__mocks__/ExplicitSize.tsx@@ -1,7 +1,10 @@-export const ExplicitSize = () => (ComposedComponent: any) => {- const WrappedComponent = (props: any) => (- <ComposedComponent width={1000} height={1000} {...props} />- );+import { type ComponentType, forwardRef } from "react";- return WrappedComponent;-};+export const ExplicitSize =+ () =>+ <P extends object>(ComposedComponent: ComponentType<P>) =>+ forwardRef<unknown, P>(function WrappedComponent(props, ref) {+ return (+ <ComposedComponent ref={ref} width={1000} height={1000} {...props} />+ );+ });diff --git a/frontend/src/metabase/urls/questions.ts b/frontend/src/metabase/urls/questions.tsindex 3fc63858dee..38bb0d9169b 100644--- a/frontend/src/metabase/urls/questions.ts+++ b/frontend/src/metabase/urls/questions.ts@@ -11,7 +11,7 @@ import type {} from "metabase-types/api";import type { EntityToken } from "metabase-types/api/entity";-import { card as urlForCard } from "./cards";+import { type CardUrlBuilderParams, card as urlForCard } from "./cards";import { appendSlug } from "./utils";type QuestionUrlBuilderOpts = {@@ -37,7 +37,10 @@ export function question(});}-export function serializedQuestion(card: SavedCard | UnsavedCard, opts = {}) {+export function serializedQuestion(+ card: SavedCard | UnsavedCard,+ opts: Omit<CardUrlBuilderParams, "forceUnsaved"> = {},+) {return urlForCard(card, { ...opts, forceUnsaved: true });}