The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
When deleting DB, hide cards from search (#64112)
John Swansonac2003368e3e
diff --git a/src/metabase/warehouses/models/database.clj b/src/metabase/warehouses/models/database.cljindex 4603a42c746..b13491ae766 100644--- a/src/metabase/warehouses/models/database.clj+++ b/src/metabase/warehouses/models/database.clj@@ -336,6 +336,9 @@(unschedule-tasks! database)(secret/delete-orphaned-secrets! database)(delete-database-fields! id)+ ;; This is a temporary hack to hide these cards from most searches.+ ;; Once search supports deletion, we should revisit this.+ (t2/update! :model/Card :database_id id {:archived true})(try(driver/notify-database-updated driver database)(catch Throwable ediff --git a/test/metabase/search/api_test.clj b/test/metabase/search/api_test.cljindex b947988e8a1..96dc6b0b5b0 100644--- a/test/metabase/search/api_test.clj+++ b/test/metabase/search/api_test.clj@@ -1853,3 +1853,27 @@:data count)](is (>= total-count result-count))(is (= 1 result-count)))))++(deftest ^:synchronized delete-database-hides-cards-from-search-test+ (testing "When deleting a database, cards referring to that database should be hidden from search"+ (let [card-name (str (random-uuid))]+ (mt/with-temp [:model/Database {db-id :id} {:name "Test Database"}+ :model/Table {table-id :id} {:db_id db-id :name "Test Table"}+ :model/Card {card-id :id} {:name card-name+ :database_id db-id+ :table_id table-id+ :dataset_query {:database db-id+ :type :query+ :query {:source-table table-id}}}]+ (search/reindex! {:async? false :in-place? true})+ (testing "Card should be visible in search before database deletion"+ (let [search-results (mt/user-http-request :crowberto :get 200 "search" :q card-name)]+ (is (some #(= (:id %) card-id) (:data search-results))+ "Card should be found in search results before database deletion")))++ (testing "Card should be hidden from search after database deletion"+ (t2/delete! :model/Database :id db-id)+ (is (not (t2/exists? :model/Card :id card-id)))+ (let [search-results (mt/user-http-request :crowberto :get 200 "search" :q card-name)]+ (is (not (some #(= (:id %) card-id) (:data search-results)))+ "Card should not be found in search results after database deletion")))))))