The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Start utilizing the Trunk Quarantine for E2E tests (#64873)
Nemanja Glumacac8285254b6c
diff --git a/.github/actions/upload-test-results/action.yml b/.github/actions/upload-test-results/action.ymlindex dbc63e72f7a..7d9e23feb4a 100644--- a/.github/actions/upload-test-results/action.yml+++ b/.github/actions/upload-test-results/action.yml@@ -55,4 +55,3 @@ runs:variant: ${{ inputs.variant || inputs.output-name }}org-slug: metabasetoken: ${{ inputs.trunk-api-token }}- continue-on-error: truediff --git a/.github/workflows/e2e-test.yml b/.github/workflows/e2e-test.ymlindex 9fb211c44e3..b03a616d1e3 100644--- a/.github/workflows/e2e-test.yml+++ b/.github/workflows/e2e-test.yml@@ -143,6 +143,11 @@ jobs:--env grepTags="-@mongo+-@python+-@flaky+-@OSS+-@skip",grepOmitFiltered=true \--spec "$SPEC_PATH" \--browser ${{ steps.cypress-prep.outputs.chrome-path }}+ # Trunk Quarantine controls the final state of the run in the CI!+ # Even if this step fails, we let it pass and then `trunk-io/analytics-uploader` determines whether to fail or to+ # pass the whole job, based on the quarantine list.+ # We only want to "continue on error" (ignore failures) when the Trunk upload is active - i.e. not on drafts!+ continue-on-error: ${{ !(github.event_name == 'pull_request' && github.event.pull_request.draft == true) }}- name: Run Tagged EE Cypress tests on ${{ inputs.name }}if: ${{ inputs.specs }}@@ -155,18 +160,25 @@ jobs:--env grepTags="${{inputs.tags && format('{0}+-@skip', inputs.tags) || '-@skip'}}",grepOmitFiltered=true \--spec "$SPEC_PATH" \--browser ${{ steps.cypress-prep.outputs.chrome-path }}+ # Trunk Quarantine controls the final state of the run in the CI!+ # Even if this step fails, we let it pass and then `trunk-io/analytics-uploader` determines whether to fail or to+ # pass the whole job, based on the quarantine list.+ # We only want to "continue on error" (ignore failures) when the Trunk upload is active - i.e. not on drafts!+ continue-on-error: ${{ !(github.event_name == 'pull_request' && github.event.pull_request.draft == true) }}- name: Upload Test Resultsuses: ./.github/actions/upload-test-resultsif: always()with:input-path: ./target/junit+ # Related to our custom upload to S3output-name: e2e-${{ inputs.name }}- variant: e2e-testsbucket: ${{ vars.AWS_S3_TEST_RESULTS_BUCKET }}aws-access-key-id: ${{ secrets.AWS_TEST_RESULTS_ACCESS_KEY_ID }}aws-secret-access-key: ${{ secrets.AWS_TEST_RESULTS_SECRET_ACCESS_KEY }}aws-region: ${{ vars.AWS_REGION }}+ # Related to Trunk uploader+ variant: e2e-teststrunk-api-token: ${{ secrets.TRUNK_API_TOKEN }}- name: Upload Cypress Artifacts upon failure