The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Closes EMB-970 move some callbacks to MetabaseGlobalPluginsConfig (#65590)
Sébastienacadfded3e90
diff --git a/enterprise/frontend/src/embedding-sdk-bundle/types/plugins.ts b/enterprise/frontend/src/embedding-sdk-bundle/types/plugins.tsindex 5e004f4b853..b9b003cc613 100644--- a/enterprise/frontend/src/embedding-sdk-bundle/types/plugins.ts+++ b/enterprise/frontend/src/embedding-sdk-bundle/types/plugins.ts@@ -38,6 +38,10 @@ export type MetabaseDashboardPluginsConfig = {export type MetabasePluginsConfig = {mapQuestionClickActions?: MetabaseClickActionPluginsConfig;dashboard?: MetabaseDashboardPluginsConfig;+};++export type MetabaseGlobalPluginsConfig = MetabasePluginsConfig & {+ handleLink?: (url: string) => { handled: boolean };/*** Provides a custom illustration to display when there is no data.*@@ -52,7 +56,3 @@ export type MetabasePluginsConfig = {*/getNoObjectIllustration?: () => string | null | undefined;};--export type MetabaseGlobalPluginsConfig = MetabasePluginsConfig & {- handleLink?: (url: string) => { handled: boolean };-};diff --git a/enterprise/frontend/src/metabase-enterprise/whitelabel/sdk-overrides.ts b/enterprise/frontend/src/metabase-enterprise/whitelabel/sdk-overrides.tsindex d42332f25b6..e06f710a27c 100644--- a/enterprise/frontend/src/metabase-enterprise/whitelabel/sdk-overrides.ts+++ b/enterprise/frontend/src/metabase-enterprise/whitelabel/sdk-overrides.ts@@ -1,4 +1,5 @@import type { SdkStoreState } from "embedding-sdk-bundle/store/types";+import type { MetabaseGlobalPluginsConfig } from "embedding-sdk-package";import { PLUGIN_SELECTORS } from "metabase/plugins";import type { State } from "metabase-types/store";@@ -26,8 +27,9 @@ export const initializeSdkPlugins = () => {PLUGIN_SELECTORS.getNoDataIllustration = (state: State) => {try {// Check if we're in an SDK context with plugins- const sdkState = (state as SdkStoreState).sdk;- const sdkResult = sdkState?.plugins?.getNoDataIllustration?.();+ const plugins = (state as SdkStoreState).sdk+ ?.plugins as MetabaseGlobalPluginsConfig;+ const sdkResult = plugins?.getNoDataIllustration?.();if (sdkResult !== null && sdkResult !== undefined) {return sdkResult;}@@ -43,8 +45,9 @@ export const initializeSdkPlugins = () => {PLUGIN_SELECTORS.getNoObjectIllustration = (state: State) => {try {// Check if we're in an SDK context with plugins- const sdkState = (state as SdkStoreState).sdk;- const sdkResult = sdkState?.plugins?.getNoObjectIllustration?.();+ const plugins = (state as SdkStoreState).sdk+ ?.plugins as MetabaseGlobalPluginsConfig;+ const sdkResult = plugins?.getNoObjectIllustration?.();if (sdkResult !== null && sdkResult !== undefined) {return sdkResult;}