Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Delete dead ai-sql-fixer types, move revision diff guards into querying (#79865)

Fraseracaeecd50645
diff --git a/frontend/src/metabase-types/api/ai-sql-fixer.ts b/frontend/src/metabase-types/api/ai-sql-fixer.ts
deleted file mode 100644
index 36c81840c46..00000000000
--- a/frontend/src/metabase-types/api/ai-sql-fixer.ts
+++ /dev/null
@@ -1,15 +0,0 @@
-import type { DatasetQuery } from "metabase-types/api/query";
-
-export type FixSqlQueryRequest = {
- query: DatasetQuery;
- error_message: string;
-};
-
-export type FixSqlQueryResponse = {
- fixes: SqlQueryFix[];
-};
-
-export type SqlQueryFix = {
- line_number: number;
- fixed_sql: string;
-};
diff --git a/frontend/src/metabase-types/guards/index.ts b/frontend/src/metabase-types/guards/index.ts
index 6a9af3fac0a..fd5dc4159a5 100644
--- a/frontend/src/metabase-types/guards/index.ts
+++ b/frontend/src/metabase-types/guards/index.ts
@@ -3,6 +3,5 @@ export * from "./click-behavior";
export * from "./common";
export * from "./dom";
export * from "./parameters";
-export * from "./revision";
export * from "./settings";
export * from "./visualization";
diff --git a/frontend/src/metabase/querying/segments/components/revisions/Revision.tsx b/frontend/src/metabase/querying/segments/components/revisions/Revision.tsx
index fa48d42cba8..e94cb72e159 100644
--- a/frontend/src/metabase/querying/segments/components/revisions/Revision.tsx
+++ b/frontend/src/metabase/querying/segments/components/revisions/Revision.tsx
@@ -10,15 +10,15 @@ import type {
TableId,
User,
} from "metabase-types/api";
+
+import { RevisionDiff } from "./RevisionDiff";
import {
isCardOrDashboardRevisionDiff,
isCardOrDashboardRevisionDiffKey,
isDiffKey,
isSegmentRevisionDiff,
isSegmentRevisionDiffKey,
-} from "metabase-types/guards";
-
-import { RevisionDiff } from "./RevisionDiff";
+} from "./guards";
interface Props {
currentUser: User;
diff --git a/frontend/src/metabase/querying/segments/components/revisions/RevisionDiff.tsx b/frontend/src/metabase/querying/segments/components/revisions/RevisionDiff.tsx
index 38fb99c1cbf..77f09025d69 100644
--- a/frontend/src/metabase/querying/segments/components/revisions/RevisionDiff.tsx
+++ b/frontend/src/metabase/querying/segments/components/revisions/RevisionDiff.tsx
@@ -2,11 +2,11 @@ import cx from "classnames";
import CS from "metabase/css/core/index.css";
import type { FieldDiff, RevisionDiffKey, TableId } from "metabase-types/api";
-import { isQueryDiff } from "metabase-types/guards";
import { QueryDiff } from "./QueryDiff";
import { RevisionDiffIcon } from "./RevisionDiffIcon";
import { TextDiff } from "./TextDiff";
+import { isQueryDiff } from "./guards";
interface Props {
diff: FieldDiff;
diff --git a/frontend/src/metabase-types/guards/revision.ts b/frontend/src/metabase/querying/segments/components/revisions/guards.ts
similarity index 96%
rename from frontend/src/metabase-types/guards/revision.ts
rename to frontend/src/metabase/querying/segments/components/revisions/guards.ts
index fe2445f2ac3..f45d397c5f4 100644
--- a/frontend/src/metabase-types/guards/revision.ts
+++ b/frontend/src/metabase/querying/segments/components/revisions/guards.ts
@@ -5,8 +5,7 @@ import type {
RevisionDiffKey,
SegmentRevisionDiff,
} from "metabase-types/api";
-
-import { isObject } from "./common";
+import { isObject } from "metabase-types/guards";
export function isFieldDiff(value: unknown): value is FieldDiff {
return isObject(value);