Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

fix(sdk,embed-js): Fix wrong `join on` dropdown items styles (#71993)

Timofey Kachalovacfdee530b45
diff --git a/frontend/src/metabase/common/components/BucketPickerPopover/BucketPickerPopover.module.css b/frontend/src/metabase/common/components/BucketPickerPopover/BucketPickerPopover.module.css
index fd50c0d1adb..313d3bcf226 100644
--- a/frontend/src/metabase/common/components/BucketPickerPopover/BucketPickerPopover.module.css
+++ b/frontend/src/metabase/common/components/BucketPickerPopover/BucketPickerPopover.module.css
@@ -9,15 +9,19 @@
visibility: visible;
}
+.triggerButton:hover {
+ color: var(--mb-color-text-primary-inverse);
+}
+
/* No hover on touch devices, so always show the button with readable text */
@media (hover: none) and (pointer: coarse) {
.triggerButton {
visibility: visible;
- color: var(--mb-color-brand);
+ color: var(--select-list-item-text-color, var(--mb-color-brand));
}
.chevronIcon {
- color: var(--mb-color-brand);
+ color: var(--select-list-item-text-color, var(--mb-color-brand));
}
}
diff --git a/frontend/src/metabase/common/components/BucketPickerPopover/BucketPickerPopover.tsx b/frontend/src/metabase/common/components/BucketPickerPopover/BucketPickerPopover.tsx
index b3298a46fd5..128e4284e6b 100644
--- a/frontend/src/metabase/common/components/BucketPickerPopover/BucketPickerPopover.tsx
+++ b/frontend/src/metabase/common/components/BucketPickerPopover/BucketPickerPopover.tsx
@@ -116,8 +116,8 @@ export function BucketPickerPopover({
</Button>
</Popover.Target>
<Popover.Dropdown
- // Prevent touch events from bubbling to the parent dropdown,
- // which causes it to scroll/select items on mobile (metabase#EMB-1471)
+ // Prevent scroll from leaking to the parent on touch devices
+ style={{ overscrollBehavior: "contain", touchAction: "pan-y" }}
onTouchStart={(e: TouchEvent) => e.stopPropagation()}
onTouchMove={(e: TouchEvent) => e.stopPropagation()}
>
diff --git a/frontend/src/metabase/css/components/list.module.css b/frontend/src/metabase/css/components/list.module.css
index ae1f4223c5d..4217726e6bd 100644
--- a/frontend/src/metabase/css/components/list.module.css
+++ b/frontend/src/metabase/css/components/list.module.css
@@ -57,6 +57,8 @@
.ListItem:not(.ListItemDisabled):hover,
.ListItemSelected:not(.ListItemDisabled) {
background-color: currentColor;
+ /* Used in BucketPickerPopover.module.css to properly use */
+ --select-list-item-text-color: var(--mb-color-text-primary-inverse);
}
/* LIST ITEM TITLE */