Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Remove superfluous flaky e2e test (#79026)

Nemanja Glumacad16b000c8e8
diff --git a/e2e/test/scenarios/permissions/admin-permissions.cy.spec.js b/e2e/test/scenarios/permissions/admin-permissions.cy.spec.js
index 9f9bb397677..88e8264d21c 100644
--- a/e2e/test/scenarios/permissions/admin-permissions.cy.spec.js
+++ b/e2e/test/scenarios/permissions/admin-permissions.cy.spec.js
@@ -310,41 +310,6 @@ describe("scenarios > admin > permissions", { tags: "@OSS" }, () => {
});
context("group focused view", () => {
- it("shows filterable list of groups", () => {
- cy.visit("/admin/permissions");
-
- // no groups selected initially and it shows an empty state
- // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage
- cy.findByText("Select a group to see its data permissions");
-
- const groups = [
- "Administrators",
- "All Users",
- "collection",
- "data",
- "nosql",
- "readonly",
- ];
-
- H.assertSidebarItems(groups);
-
- // filter groups
- cy.findByPlaceholderText("Search for a group").type("a");
-
- const filteredGroups = [
- "Administrators",
- "All Users",
- "data",
- "readonly",
- ];
-
- cy.findAllByRole("menuitem").should(
- "have.length",
- filteredGroups.length,
- );
- H.assertSidebarItems(filteredGroups);
- });
-
it("allows to only view Administrators permissions", () => {
cy.visit("/admin/permissions");
diff --git a/frontend/src/metabase/admin/permissions/test/GroupsPermissionsPage/GroupsPermissionsPage.unit.spec.tsx b/frontend/src/metabase/admin/permissions/test/GroupsPermissionsPage/GroupsPermissionsPage.unit.spec.tsx
index fafa4fcedd0..c2d288f9acf 100644
--- a/frontend/src/metabase/admin/permissions/test/GroupsPermissionsPage/GroupsPermissionsPage.unit.spec.tsx
+++ b/frontend/src/metabase/admin/permissions/test/GroupsPermissionsPage/GroupsPermissionsPage.unit.spec.tsx
@@ -101,6 +101,14 @@ describe("GroupsPermissionsPage", () => {
});
describe("rendering", () => {
+ it("should prompt to pick a group when none is selected", async () => {
+ await setup({ initialRoute: "/admin/permissions/data/group" });
+
+ expect(
+ await screen.findByText("Select a group to see its data permissions"),
+ ).toBeVisible();
+ });
+
it("should show 'Cancel' and 'Save Changes' when user makes changes to permissions", async () => {
await setup();