Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Remove the direct reselect usage and dependency (#81034)

Andrei Chernykhad48fed046b0
diff --git a/bun.lock b/bun.lock
index 8957ca2bc69..afd29b7975f 100644
--- a/bun.lock
+++ b/bun.lock
@@ -144,7 +144,6 @@
"rehype-external-links": "^3.0.0",
"remark-gfm": "^4.0.0",
"remend": "1.3.0",
- "reselect": "^5.1.0",
"resize-observer-polyfill": "^1.5.1",
"server-text-width": "^1.0.2",
"simple-statistics": "^3.0.0",
diff --git a/eslint.config.mjs b/eslint.config.mjs
index f762cbba74b..a0f099d0a5e 100644
--- a/eslint.config.mjs
+++ b/eslint.config.mjs
@@ -125,6 +125,11 @@ const baseMetabaseRestrictedConfig = {
message:
"Please use `testing-library/react` or `@testing-library/user-event`",
},
+ {
+ name: "reselect",
+ message:
+ "Please import from `@reduxjs/toolkit` instead, which re-exports reselect.",
+ },
],
};
diff --git a/frontend/lint/eslint-plugin-metabase/rules/no-module-side-effects.js b/frontend/lint/eslint-plugin-metabase/rules/no-module-side-effects.js
index 71cf8ea8618..954ce4bae08 100644
--- a/frontend/lint/eslint-plugin-metabase/rules/no-module-side-effects.js
+++ b/frontend/lint/eslint-plugin-metabase/rules/no-module-side-effects.js
@@ -60,7 +60,6 @@ const DEFAULT_PURE_CALLEES = [
"createEntityAdapter",
],
},
- { module: "reselect", names: ["createSelector", "createStructuredSelector"] },
{
module: "redux-actions",
names: [
diff --git a/frontend/src/metabase/embedding/selectors.ts b/frontend/src/metabase/embedding/selectors.ts
index c5d3bfc2628..7e4f783f11e 100644
--- a/frontend/src/metabase/embedding/selectors.ts
+++ b/frontend/src/metabase/embedding/selectors.ts
@@ -1,4 +1,4 @@
-import { createSelector } from "reselect";
+import { createSelector } from "@reduxjs/toolkit";
import { isEmbeddingSdk } from "metabase/embedding-sdk/config";
import type { State } from "metabase/redux/store";
diff --git a/package.json b/package.json
index 5a166d0bc9f..f90d1250638 100644
--- a/package.json
+++ b/package.json
@@ -153,7 +153,6 @@
"rehype-external-links": "^3.0.0",
"remark-gfm": "^4.0.0",
"remend": "1.3.0",
- "reselect": "^5.1.0",
"resize-observer-polyfill": "^1.5.1",
"server-text-width": "^1.0.2",
"simple-statistics": "^3.0.0",