Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Fix typo in transform database validation messages (#71596)

Alexander Polyankinad4dfb41b158
diff --git a/frontend/src/metabase/transforms/utils.ts b/frontend/src/metabase/transforms/utils.ts
index ec2e5a181d4..5dba8c57d02 100644
--- a/frontend/src/metabase/transforms/utils.ts
+++ b/frontend/src/metabase/transforms/utils.ts
@@ -71,13 +71,13 @@ export function validateDatabase(database: Database): DatabaseValidationResult {
if (database.is_sample) {
return {
isValid: false,
- message: t`Transforms can't be enabled on a Sample Database.`,
+ message: t`Transforms can't be enabled on the Sample Database.`,
};
}
if (database.is_audit) {
return {
isValid: false,
- message: t`Transforms can't be enabled on a Usage Analytics database.`,
+ message: t`Transforms can't be enabled on the Usage Analytics database.`,
};
}
if (database.router_user_attribute || database.router_database_id) {
diff --git a/frontend/src/metabase/transforms/utils.unit.spec.ts b/frontend/src/metabase/transforms/utils.unit.spec.ts
index ba2b7d15f18..5acf3aff54b 100644
--- a/frontend/src/metabase/transforms/utils.unit.spec.ts
+++ b/frontend/src/metabase/transforms/utils.unit.spec.ts
@@ -1,4 +1,7 @@
-import { parseTimestampWithTimezone } from "./utils";
+import type { Database } from "metabase-types/api";
+import { createMockDatabase } from "metabase-types/api/mocks";
+
+import { parseTimestampWithTimezone, validateDatabase } from "./utils";
describe("parseTimestamp", () => {
const value = "2025-09-04T16:25:03.000Z";
@@ -17,3 +20,64 @@ describe("parseTimestamp", () => {
},
);
});
+
+describe("validateDatabase", () => {
+ it.each<{
+ label: string;
+ database: Database;
+ isValid: boolean;
+ message?: string;
+ }>([
+ {
+ label: "valid database",
+ database: createMockDatabase({ features: ["transforms/table"] }),
+ isValid: true,
+ },
+ {
+ label: "sample database",
+ database: createMockDatabase({
+ is_sample: true,
+ features: ["transforms/table"],
+ }),
+ isValid: false,
+ message: "Transforms can't be enabled on the Sample Database.",
+ },
+ {
+ label: "audit database",
+ database: createMockDatabase({
+ is_audit: true,
+ features: ["transforms/table"],
+ }),
+ isValid: false,
+ message: "Transforms can't be enabled on the Usage Analytics database.",
+ },
+ {
+ label: "database with router_user_attribute",
+ database: createMockDatabase({
+ router_user_attribute: "attr",
+ features: ["transforms/table"],
+ }),
+ isValid: false,
+ message: "Transforms can't be enabled when database routing is enabled.",
+ },
+ {
+ label: "database with router_database_id",
+ database: createMockDatabase({
+ router_database_id: 2,
+ features: ["transforms/table"],
+ }),
+ isValid: false,
+ message: "Transforms can't be enabled when database routing is enabled.",
+ },
+ {
+ label: "database without transforms/table feature",
+ database: createMockDatabase({ features: [] }),
+ isValid: false,
+ message: "Transforms can't be enabled on this database.",
+ },
+ ])("should validate $label", ({ database, isValid, message }) => {
+ const result = validateDatabase(database);
+ expect(result.isValid).toBe(isValid);
+ expect(result.message).toBe(message);
+ });
+});