Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

GDGT-1782 Timezone detail is missing when Setting up Subscriptions (#79171)

Kamil Mielnikadecad50c1bc
diff --git a/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/tests/common.unit.spec.ts b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/tests/common.unit.spec.ts
index 61119e079f8..5f474f0a0ae 100644
--- a/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/tests/common.unit.spec.ts
+++ b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/tests/common.unit.spec.ts
@@ -254,6 +254,23 @@ describe("DashboardSubscriptionsSidebar", () => {
expect(hasBasicFilterOptions(screen)).toBe(true);
});
+ it("should show the report timezone in the schedule description (metabase#69496)", async () => {
+ setup({ isAdmin: false, email: false, slack: true });
+
+ await screen.findByText("Send this dashboard to Slack");
+
+ await userEvent.click(screen.getByTestId("select-frequency"));
+ await userEvent.click(
+ within(await screen.findByRole("listbox")).getByText("daily"),
+ );
+
+ expect(
+ await screen.findByText(
+ "Slack messages will be sent at 8:00 AM UTC, your Metabase timezone.",
+ ),
+ ).toBeInTheDocument();
+ });
+
it("should send the include_pdf channel detail to the backend when the PDF switch is on", async () => {
setup({ isAdmin: false, email: false, slack: true });
@@ -290,6 +307,23 @@ describe("DashboardSubscriptionsSidebar", () => {
expect(hasBasicFilterOptions(screen)).toBe(true);
});
+ it("should show the report timezone in the schedule description (metabase#69496)", async () => {
+ setup({ isAdmin: false, email: true, slack: false });
+
+ await screen.findByText("Email this dashboard");
+
+ await userEvent.click(screen.getByTestId("select-frequency"));
+ await userEvent.click(
+ within(await screen.findByRole("listbox")).getByText("daily"),
+ );
+
+ expect(
+ await screen.findByText(
+ "Emails will be sent at 8:00 AM UTC, your Metabase timezone.",
+ ),
+ ).toBeInTheDocument();
+ });
+
it("should filter out actions and links when sending a test subscription", async () => {
setup();
diff --git a/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/tests/setup.tsx b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/tests/setup.tsx
index acc84991cd4..e87a3fa5d42 100644
--- a/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/tests/setup.tsx
+++ b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/tests/setup.tsx
@@ -141,7 +141,7 @@ export function setup({
name: "Email",
allows_recipients: true,
recipients: ["user", "email"],
- schedules: ["hourly"],
+ schedules: ["hourly", "daily", "weekly", "monthly"],
configured: true,
};
}
@@ -151,7 +151,7 @@ export function setup({
type: "slack",
name: "Slack",
allows_recipients: false,
- schedules: ["hourly"],
+ schedules: ["hourly", "daily", "weekly", "monthly"],
configured: true,
fields: [
{