The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
flake fix: displays object details, breadcrumbs, relationships, email links, and 404 error state (#83762)
Chris Vandoodewaardae0dbb421a56
diff --git a/e2e/test/scenarios/detail-view/detail-view.cy.spec.ts b/e2e/test/scenarios/detail-view/detail-view.cy.spec.tsindex c01c7aed48c..2a7b137969d 100644--- a/e2e/test/scenarios/detail-view/detail-view.cy.spec.ts+++ b/e2e/test/scenarios/detail-view/detail-view.cy.spec.ts@@ -4,7 +4,6 @@ import {FIRST_COLLECTION_ID,SECOND_COLLECTION_ID,} from "e2e/support/cypress_sample_instance_data";-import { defer } from "metabase/utils/promise";const { H } = cy;const { DetailView } = H;@@ -21,18 +20,8 @@ describe("detail view", () => {describe("table", () => {it("displays object details, breadcrumbs, relationships, email links, and 404 error state", () => {- const { promise: queryPromise, resolve: releaseQuery } = defer<void>();- cy.intercept(- { method: "POST", url: "/api/dataset", times: 1 },- () => queryPromise,- ).as("missingTableRow");-DetailView.visitTable(PRODUCTS_ID, 9999);-- cy.findByTestId("loading-indicator")- .should("be.visible")- .then(() => releaseQuery());- cy.wait("@missingTableRow");+ cy.findByTestId("loading-indicator").should("be.visible");cy.findByTestId("loading-indicator").should("not.exist");cy.findByRole("heading", { name: "Row not found" }).should("be.visible");