Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

QUE2-862: [Flaky Test]: health-check-database-test (#83284)

Eric Normandaee940ec0dfe
diff --git a/test/metabase/warehouses/models/database_test.clj b/test/metabase/warehouses/models/database_test.clj
index 45f132addec..55085c0966f 100644
--- a/test/metabase/warehouses/models/database_test.clj
+++ b/test/metabase/warehouses/models/database_test.clj
@@ -190,8 +190,9 @@
(is (== 0 (mt/metric-value system :metabase-database/status {:driver driver/*driver* :healthy false :reason "exception" :connection-type "default"})) "unhealthy exception")))
(testing "failures for timeout"
(mt/with-prometheus-system! [_ system]
- (mt/with-temporary-setting-values [db-connection-timeout-ms -1]
- (database/health-check-database! (mt/db))
+ (mt/with-temporary-setting-values [db-connection-timeout-ms 1]
+ (with-redefs [driver/can-connect? (fn [& _args] (Thread/sleep 500) true)]
+ (database/health-check-database! (mt/db)))
(is (== 0 (mt/metric-value system :metabase-database/status {:driver driver/*driver* :healthy true :connection-type "default"})) "healthy")
(is (== 0 (mt/metric-value system :metabase-database/status {:driver driver/*driver* :healthy false :reason "user-input" :connection-type "default"})) "unhealthy user-input")
(is (== 1 (mt/metric-value system :metabase-database/status {:driver driver/*driver* :healthy false :reason "exception" :connection-type "default"})) "unhealthy exception"))))