Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

fix(sdk): Fix missing SDK CSS custom properties (#65084)

Mahatthana (Kelvin) Nomsawadiafaee50a4c7b
diff --git a/frontend/src/metabase/styled-components/theme/css-variables.ts b/frontend/src/metabase/styled-components/theme/css-variables.ts
index b0090f0959f..c1933b45155 100644
--- a/frontend/src/metabase/styled-components/theme/css-variables.ts
+++ b/frontend/src/metabase/styled-components/theme/css-variables.ts
@@ -41,6 +41,7 @@ export function getMetabaseSdkCssVariables(theme: MantineTheme, font: string) {
return css`
:root {
--mb-default-font-family: ${font};
+ ${createColorVars("light")}
${getSdkDesignSystemCssVariables(theme)}
${getDynamicCssVariables(theme)}
${getThemeSpecificCssVariables(theme)}
@@ -53,8 +54,8 @@ export function getMetabaseSdkCssVariables(theme: MantineTheme, font: string) {
* These CSS variables are part of the core design system colors.
*
* Only keep colors that depend on the theme and are not specified anywhere else here.
- * You don't need to add new colors from `colors.module.css` here since they'll already
- * be available globally at :root
+ * You don't need to add new colors from `frontend/src/metabase/lib/colors/colors.ts` here since
+ * they're already included in `getMetabaseSdkCssVariables`
**/
function getSdkDesignSystemCssVariables(theme: MantineTheme) {
const createSdkColorVars = (colorName: ColorName) => {