Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Remove redundant static-viz files changed condition (#66138)

Nemanja Glumacb1fb103a3f89
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
index c526f9c28d3..8c776e212f3 100644
--- a/.github/workflows/run-tests.yml
+++ b/.github/workflows/run-tests.yml
@@ -36,49 +36,19 @@ jobs:
list-files: csv
filters: .github/file-paths.yaml
- static-viz-files-changed:
- name: Check whether static-viz files changed
- if: ${{ !contains(github.event.pull_request.labels.*.name,'ci skip') && !contains(github.event.pull_request.labels.*.name,'minimal-tests') }}
- runs-on: ubuntu-22.04
- timeout-minutes: 10
- outputs:
- static_viz: ${{ steps.static_viz.outputs.static_viz }}
- steps:
- - uses: actions/checkout@v4
- - name: Prepare front-end environment
- uses: ./.github/actions/prepare-frontend
- - name: Prepare back-end environment
- uses: ./.github/actions/prepare-backend
- - name: Build static-viz frontend
- run: yarn build-static-viz
- env:
- MB_EDITION: ee
- - name: Upload Static Viz Bundle Artifact
- uses: actions/upload-artifact@v4
- with:
- name: static-viz-bundle-${{ github.sha }}
- path: resources/frontend_client/app/dist
-
- - name: Check for static viz changes
- uses: dorny/[email protected]
- id: static_viz
- with:
- token: ${{ github.token }}
- filters: .github/static-viz-sources.yaml
-
uberjar:
- needs: [files-changed, static-viz-files-changed]
+ needs: [files-changed]
if: ${{ !cancelled() && !(needs.files-changed.outputs.documentation == 'true' && needs.files-changed.outputs.backend_all == 'false' && needs.files-changed.outputs.frontend_all == 'false' && needs.files-changed.outputs.e2e_all == 'false') }}
uses: ./.github/workflows/uberjar.yml
secrets: inherit
backend-tests:
if: ${{ !cancelled() && needs.files-changed.result == 'success' }}
- needs: [files-changed, static-viz-files-changed]
+ needs: [files-changed]
uses: ./.github/workflows/backend.yml
secrets: inherit
with:
- skip: ${{ needs.files-changed.outputs.backend_all != 'true' && needs.static-viz-files-changed.outputs.static_viz != 'true' }}
+ skip: ${{ needs.files-changed.outputs.backend_all != 'true' }}
semantic-search-tests:
needs: files-changed