Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Missing space + log4j capitalization (#70271)

Rodrigo López Datob2c736e4ca7c
diff --git a/docs/configuring-metabase/environment-variables.md b/docs/configuring-metabase/environment-variables.md
index 47a5737186b..b81b0e667c3 100644
--- a/docs/configuring-metabase/environment-variables.md
+++ b/docs/configuring-metabase/environment-variables.md
@@ -2301,7 +2301,7 @@ Since: v51.3
If `true`, log a stack trace for any connections killed due to exceeding the timeout specified in [MB_DB_QUERY_TIMEOUT_MINUTES](#mb_db_query_timeout_minutes).
-In order to see the stack traces in the logs, you'll also need to update the com.mchange log level to "INFO" or higher via a custom log4j configuration. For configuring log levels, see [Metabase log configuration](./log-configuration.md).
+In order to see the stack traces in the logs, you'll also need to update the com.mchange log level to "INFO" or higher via a custom Log4j configuration. For configuring log levels, see [Metabase log configuration](./log-configuration.md).
### `MB_JETTY_ASYNC_RESPONSE_TIMEOUT`
@@ -2534,4 +2534,3 @@ Type: string<br>
Default: `null`
Base-64 encoded public key for this sites SSL certificate. Specify this to enable HTTP Public Key Pinning. Using HPKP is no longer recommended. See http://mzl.la/1EnfqBf for more information.
-
diff --git a/docs/configuring-metabase/log-configuration.md b/docs/configuring-metabase/log-configuration.md
index 60627a6e577..452c092463d 100644
--- a/docs/configuring-metabase/log-configuration.md
+++ b/docs/configuring-metabase/log-configuration.md
@@ -21,7 +21,7 @@ See [How to read logs](../troubleshooting-guide/server-logs.md).
## Configuring logging Level
-Metabase uses [log4j](https://logging.apache.org/log4j/2.x/)for logging configuration. Here is Metabase's [default logging configuration](https://github.com/metabase/metabase/blob/master/resources/log4j2.xml). Some troubleshooting tasks might require you to override this logging configuration (for example, to see more details about errors). See Log4j's docs for info on [log levels](https://logging.apache.org/log4j/2.x/manual/customloglevels.html).
+Metabase uses [Log4j](https://logging.apache.org/log4j/2.x/) for logging configuration. Here is Metabase's [default logging configuration](https://github.com/metabase/metabase/blob/master/resources/log4j2.xml). Some troubleshooting tasks might require you to override this logging configuration (for example, to see more details about errors). See Log4j's docs for info on [log levels](https://logging.apache.org/log4j/2.x/manual/customloglevels.html).
### Temporary override logging configuration
diff --git a/src/metabase/driver/settings.clj b/src/metabase/driver/settings.clj
index 25b16fc9938..6d2540550e4 100644
--- a/src/metabase/driver/settings.clj
+++ b/src/metabase/driver/settings.clj
@@ -160,7 +160,7 @@
"Tell c3p0 to log a stack trace for any connections killed due to exceeding the timeout specified in
[[jdbc-data-warehouse-unreturned-connection-timeout-seconds]].
- Note: You also need to update the com.mchange log level to INFO or higher in the log4j configs in order to see the
+ Note: You also need to update the com.mchange log level to INFO or higher in the Log4j configs in order to see the
stack traces in the logs."
:visibility :internal
:type :boolean
diff --git a/src/metabase/driver/sql_jdbc/connection.clj b/src/metabase/driver/sql_jdbc/connection.clj
index 119c4e772b7..1ad4c58b269 100644
--- a/src/metabase/driver/sql_jdbc/connection.clj
+++ b/src/metabase/driver/sql_jdbc/connection.clj
@@ -157,7 +157,7 @@
(log/warn "jdbc-data-warehouse-debug-unreturned-connection-stack-traces"
"is enabled, but INFO logging is not enabled for the"
"com.mchange namespace. You must raise the log level for"
- "com.mchange to INFO via a custom log4j config in order to"
+ "com.mchange to INFO via a custom Log4j config in order to"
"see stacktraces in the logs.")))
;; Set the data source name so that the c3p0 JMX bean has a useful identifier, which incorporates the DB ID, driver,
;; and name from the details