Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Fix flaky sync-materialized-views-test with auto-retry (#70750)

bryanb2f981e96777
diff --git a/modules/drivers/redshift/test/metabase/driver/redshift_test.clj b/modules/drivers/redshift/test/metabase/driver/redshift_test.clj
index c8433388193..56cbb8ee9b7 100644
--- a/modules/drivers/redshift/test/metabase/driver/redshift_test.clj
+++ b/modules/drivers/redshift/test/metabase/driver/redshift_test.clj
@@ -354,9 +354,13 @@
qual-tbl-nm
qual-mview-nm)
(binding [redshift.tx/*override-describe-database-to-filter-by-db-name?* false]
- (is (contains?
- (set (map :name (:tables (driver/describe-database :redshift database))))
- mview-nm)))))))))
+ (u/auto-retry 3
+ (let [table-names (set (map :name (:tables (driver/describe-database :redshift database))))]
+ (when-not (contains? table-names mview-nm)
+ (Thread/sleep 1000)
+ (throw (ex-info "Materialized view not yet visible in describe-database results"
+ {:expected mview-nm :actual table-names})))
+ (is (contains? table-names mview-nm)))))))))))
(mt/defdataset unix-timestamps
[["timestamps"