The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Move the card copy form next to the other copy forms (#82549)
Romeo Van Snickb4513dcdcabc
diff --git a/frontend/lint/side-effect-files.json b/frontend/lint/side-effect-files.jsonindex c9d42a31703..5a39a89cb71 100644--- a/frontend/lint/side-effect-files.json+++ b/frontend/lint/side-effect-files.json@@ -109,6 +109,7 @@"frontend/src/metabase/common/collections/schemas.ts": "self","frontend/src/metabase/common/components/CodeMirror/highlights.ts": "self","frontend/src/metabase/common/components/ColorPicker/ColorPickerControls.tsx": "self",+ "frontend/src/metabase/common/components/CopyCardForm/CopyCardForm.tsx": "self","frontend/src/metabase/common/components/CopyDashboardForm/CopyDashboardForm.tsx": "self","frontend/src/metabase/common/components/DocumentCopyForm/DocumentCopyForm.tsx": "self","frontend/src/metabase/common/components/Pickers/EntityPicker/components/NewCollectionDialog/NewCollectionDialog.tsx": "self",@@ -157,7 +158,6 @@"frontend/src/metabase/querying/components/CodeMirrorEditor/language.ts": "self","frontend/src/metabase/querying/components/NativeQueryEditor/SnippetForm/SnippetForm.tsx": "self","frontend/src/metabase/querying/expressions/pratt/syntax.ts": "self",- "frontend/src/metabase/questions/components/CopyCardForm/CopyCardForm.tsx": "self","frontend/src/metabase/redux/embed/embed.ts": "self","frontend/src/metabase/redux/hooks.ts": "self","frontend/src/metabase/redux/utils.ts": "self",diff --git a/frontend/src/metabase/questions/components/CopyCardForm/CopyCardForm.tsx b/frontend/src/metabase/common/components/CopyCardForm/CopyCardForm.tsxsimilarity index 98%rename from frontend/src/metabase/questions/components/CopyCardForm/CopyCardForm.tsxrename to frontend/src/metabase/common/components/CopyCardForm/CopyCardForm.tsxindex 00f36785055..e5ceaed637b 100644--- a/frontend/src/metabase/questions/components/CopyCardForm/CopyCardForm.tsx+++ b/frontend/src/metabase/common/components/CopyCardForm/CopyCardForm.tsx@@ -8,6 +8,7 @@ import { getEntityTypeFromCardType } from "metabase/common/collections/utils";import { FormDashboardTabSelect } from "metabase/common/components/FormDashboardTabSelect";import { FormFooter } from "metabase/common/components/FormFooter";import type { OmniPickerItem } from "metabase/common/components/Pickers";+import { QUESTION_NAME_MAX_LENGTH } from "metabase/common/utils/card";import {Form,FormErrorMessage,@@ -16,7 +17,6 @@ import {FormTextInput,FormTextarea,} from "metabase/forms";-import { QUESTION_NAME_MAX_LENGTH } from "metabase/questions/constants";import { Button, Stack } from "metabase/ui";import * as Errors from "metabase/utils/errors";import type {diff --git a/frontend/src/metabase/questions/components/CopyCardForm/CopyCardForm.unit.spec.tsx b/frontend/src/metabase/common/components/CopyCardForm/CopyCardForm.unit.spec.tsxsimilarity index 100%rename from frontend/src/metabase/questions/components/CopyCardForm/CopyCardForm.unit.spec.tsxrename to frontend/src/metabase/common/components/CopyCardForm/CopyCardForm.unit.spec.tsxdiff --git a/frontend/src/metabase/questions/components/CopyCardForm/index.ts b/frontend/src/metabase/common/components/CopyCardForm/index.tssimilarity index 100%rename from frontend/src/metabase/questions/components/CopyCardForm/index.tsrename to frontend/src/metabase/common/components/CopyCardForm/index.tsdiff --git a/frontend/src/metabase/common/components/CopyModal/CopyModal.tsx b/frontend/src/metabase/common/components/CopyModal/CopyModal.tsxindex a887a2c5e18..6f355a09244 100644--- a/frontend/src/metabase/common/components/CopyModal/CopyModal.tsx+++ b/frontend/src/metabase/common/components/CopyModal/CopyModal.tsx@@ -2,9 +2,9 @@ import { dissoc } from "icepick";import { t } from "ttag";import { useGetDefaultCollectionId } from "metabase/common/collections/hooks";+import { CopyCardForm } from "metabase/common/components/CopyCardForm/CopyCardForm";import { CopyDashboardFormConnected } from "metabase/common/components/CopyDashboardForm";import { DocumentCopyForm } from "metabase/common/components/DocumentCopyForm/DocumentCopyForm";-import { CopyCardForm } from "metabase/questions/components/CopyCardForm/CopyCardForm";import { Modal } from "metabase/ui";import type { CopyModalProps } from "./types";diff --git a/frontend/src/metabase/common/components/SaveQuestionForm/schema.ts b/frontend/src/metabase/common/components/SaveQuestionForm/schema.tsindex e75276437d7..2e4affcd124 100644--- a/frontend/src/metabase/common/components/SaveQuestionForm/schema.ts+++ b/frontend/src/metabase/common/components/SaveQuestionForm/schema.ts@@ -1,6 +1,6 @@import * as Yup from "yup";-import { QUESTION_NAME_MAX_LENGTH } from "metabase/questions/constants";+import { QUESTION_NAME_MAX_LENGTH } from "metabase/common/utils/card";import * as Errors from "metabase/utils/errors";export const SAVE_QUESTION_SCHEMA = Yup.object({diff --git a/frontend/src/metabase/common/components/SaveQuestionModal/SaveQuestionModal.unit.spec.tsx b/frontend/src/metabase/common/components/SaveQuestionModal/SaveQuestionModal.unit.spec.tsxindex cd78f48b45b..ff72358215f 100644--- a/frontend/src/metabase/common/components/SaveQuestionModal/SaveQuestionModal.unit.spec.tsx+++ b/frontend/src/metabase/common/components/SaveQuestionModal/SaveQuestionModal.unit.spec.tsx@@ -27,7 +27,7 @@ import {} from "__support__/ui";import { ROOT_COLLECTION } from "metabase/common/collections/constants";import { SaveQuestionModal } from "metabase/common/components/SaveQuestionModal";-import { QUESTION_NAME_MAX_LENGTH } from "metabase/questions/constants";+import { QUESTION_NAME_MAX_LENGTH } from "metabase/common/utils/card";import * as Lib from "metabase-lib";import Question from "metabase-lib/v1/Question";import type {diff --git a/frontend/src/metabase/common/utils/card.ts b/frontend/src/metabase/common/utils/card.tsindex 85aa89d4f4a..b73ed7412a0 100644--- a/frontend/src/metabase/common/utils/card.ts+++ b/frontend/src/metabase/common/utils/card.ts@@ -30,6 +30,8 @@ import type {} from "metabase-types/api";import { isDashCardDataSeries } from "metabase-types/guards/dashboard";+export const QUESTION_NAME_MAX_LENGTH = 254;+export type SerializeCardOptions = {includeDatasetQuery?: boolean;includeOriginalCardId?: boolean;diff --git a/frontend/src/metabase/query_builder/components/SavedQuestionHeaderButton/SavedQuestionHeaderButton.tsx b/frontend/src/metabase/query_builder/components/SavedQuestionHeaderButton/SavedQuestionHeaderButton.tsxindex f494c3a3906..6fc1a3b571a 100644--- a/frontend/src/metabase/query_builder/components/SavedQuestionHeaderButton/SavedQuestionHeaderButton.tsx+++ b/frontend/src/metabase/query_builder/components/SavedQuestionHeaderButton/SavedQuestionHeaderButton.tsx@@ -1,7 +1,7 @@import { t } from "ttag";import { EditableText } from "metabase/common/components/EditableText";-import { QUESTION_NAME_MAX_LENGTH } from "metabase/questions/constants";+import { QUESTION_NAME_MAX_LENGTH } from "metabase/common/utils/card";import { Flex } from "metabase/ui";import type Question from "metabase-lib/v1/Question";diff --git a/frontend/src/metabase/questions/components/CardCopyModal/CardCopyModal.tsx b/frontend/src/metabase/questions/components/CardCopyModal/CardCopyModal.tsxindex 76acecbf0ae..a5cca5d3212 100644--- a/frontend/src/metabase/questions/components/CardCopyModal/CardCopyModal.tsx+++ b/frontend/src/metabase/questions/components/CardCopyModal/CardCopyModal.tsx@@ -3,8 +3,8 @@ import { useLatest } from "react-use";import { useCreateCardMutation } from "metabase/api";import { useGetDefaultCollectionId } from "metabase/common/collections/hooks";+import type { CopyCardProperties } from "metabase/common/components/CopyCardForm";import { CopyModal } from "metabase/common/components/CopyModal";-import type { CopyCardProperties } from "metabase/questions/components/CopyCardForm";import type { Card } from "metabase-types/api";type CardCopyModalProps = {diff --git a/frontend/src/metabase/questions/constants.ts b/frontend/src/metabase/questions/constants.tsdeleted file mode 100644index 5554ddac06e..00000000000--- a/frontend/src/metabase/questions/constants.ts+++ /dev/null@@ -1 +0,0 @@-export const QUESTION_NAME_MAX_LENGTH = 254;