Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

[perf] Add a unit test for #66955 as a follow-up (#66958)

Braden Shepherdsonb496e05834b6
diff --git a/test/metabase/query_processor/middleware/annotate_test.clj b/test/metabase/query_processor/middleware/annotate_test.clj
index a6a5ceb8195..7d98df66753 100644
--- a/test/metabase/query_processor/middleware/annotate_test.clj
+++ b/test/metabase/query_processor/middleware/annotate_test.clj
@@ -2,6 +2,7 @@
(:require
[clojure.test :refer :all]
[medley.core :as m]
+ [metabase.config.core :as config]
[metabase.driver :as driver]
[metabase.lib.core :as lib]
[metabase.lib.test-metadata :as meta]
@@ -345,3 +346,17 @@
{:cols [{:name "sleep", :base_type :type/*, :database_type "void"}]}
[[""]])
:cols))))))
+
+(deftest ^:sequential expected-cols-no-infinite-loop-test
+ (testing "In case of a lib vs. driver column count mismatch, don't loop infinitely (#66955)"
+ (let [query (lib/query meta/metadata-provider
+ (meta/table-metadata :orders))
+ all-cols (mapv #(select-keys % [:name :base-type]) (lib/returned-columns query))
+ missing-one (butlast all-cols)]
+ (is (= 9 (count (annotate/expected-cols query all-cols))))
+ (testing "in dev and test modes, we throw an error when the counts differ"
+ (is (thrown-with-msg? Exception #"column number mismatch"
+ (annotate/expected-cols query missing-one))))
+ (testing "in prod, we log and append nils to make the counts line up - this looped forever before #66955!"
+ (with-redefs [config/is-prod? true]
+ (is (= 8 (count (annotate/expected-cols query missing-one)))))))))