Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Move utils/pulse to metabase/pulse since it contains only domain-related code (#73082)

Romeo Van Snickb50dbf8a65ae
diff --git a/enterprise/frontend/src/metabase-enterprise/sharing/components/MutableParametersSection.tsx b/enterprise/frontend/src/metabase-enterprise/sharing/components/MutableParametersSection.tsx
index 8e34aac7bee..ce9698290f5 100644
--- a/enterprise/frontend/src/metabase-enterprise/sharing/components/MutableParametersSection.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/sharing/components/MutableParametersSection.tsx
@@ -7,8 +7,8 @@ import { CollapseSection } from "metabase/common/components/CollapseSection";
import CS from "metabase/css/core/index.css";
import { ParametersList } from "metabase/parameters/components/ParametersList";
import { getVisibleParameters } from "metabase/parameters/utils/ui";
+import { getPulseParameters } from "metabase/pulse";
import type { DraftDashboardSubscription } from "metabase/redux/store";
-import { getPulseParameters } from "metabase/utils/pulse";
import type { UiParameter } from "metabase-lib/v1/parameters/types";
import { deriveFieldOperatorFromParameter } from "metabase-lib/v1/parameters/utils/operators";
import {
diff --git a/frontend/src/metabase/account/notifications/components/ArchiveModal/ArchiveModal.tsx b/frontend/src/metabase/account/notifications/components/ArchiveModal/ArchiveModal.tsx
index 4028886e5ea..f53ff0d4621 100644
--- a/frontend/src/metabase/account/notifications/components/ArchiveModal/ArchiveModal.tsx
+++ b/frontend/src/metabase/account/notifications/components/ArchiveModal/ArchiveModal.tsx
@@ -4,8 +4,8 @@ import { t } from "ttag";
import { Button } from "metabase/common/components/Button";
import { ModalContent } from "metabase/common/components/ModalContent";
import { FormMessage } from "metabase/forms";
+import { formatChannelRecipients } from "metabase/pulse";
import { formatDateTimeWithUnit } from "metabase/utils/formatting";
-import { formatChannelRecipients } from "metabase/utils/pulse";
import Settings from "metabase/utils/settings";
import type { Alert, DashboardSubscription, User } from "metabase-types/api";
diff --git a/frontend/src/metabase/account/notifications/components/NotificationCard/DashboardNotificationCard.tsx b/frontend/src/metabase/account/notifications/components/NotificationCard/DashboardNotificationCard.tsx
index f1aac3ea73b..86f4cc19b17 100644
--- a/frontend/src/metabase/account/notifications/components/NotificationCard/DashboardNotificationCard.tsx
+++ b/frontend/src/metabase/account/notifications/components/NotificationCard/DashboardNotificationCard.tsx
@@ -6,7 +6,7 @@ import { formatCreatorMessage } from "metabase/account/notifications/components/
import type { DashboardSubscriptionListItem } from "metabase/account/notifications/types";
import { Link } from "metabase/common/components/Link";
import { formatTitle } from "metabase/notifications/utils";
-import { canArchiveLegacyAlert, formatChannel } from "metabase/utils/pulse";
+import { canArchiveLegacyAlert, formatChannel } from "metabase/pulse";
import * as Urls from "metabase/utils/urls";
import type { Channel, User } from "metabase-types/api";
diff --git a/frontend/src/metabase/common/components/SendTestPulse/SendTestPulse.tsx b/frontend/src/metabase/common/components/SendTestPulse/SendTestPulse.tsx
index afc7cdb0fe8..236affa8de1 100644
--- a/frontend/src/metabase/common/components/SendTestPulse/SendTestPulse.tsx
+++ b/frontend/src/metabase/common/components/SendTestPulse/SendTestPulse.tsx
@@ -2,8 +2,8 @@ import { useCallback } from "react";
import { t } from "ttag";
import { ActionButton } from "metabase/common/components/ActionButton";
+import { cleanPulse } from "metabase/pulse";
import type { DashboardSubscriptionData } from "metabase/redux/store";
-import { cleanPulse } from "metabase/utils/pulse";
import type { Channel, ChannelSpecs } from "metabase-types/api";
type SendTestPulseProps<T extends DashboardSubscriptionData> = {
diff --git a/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/AddEditEmailSidebar.tsx b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/AddEditEmailSidebar.tsx
index efb937a0f25..40d6307f628 100644
--- a/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/AddEditEmailSidebar.tsx
+++ b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/AddEditEmailSidebar.tsx
@@ -16,10 +16,10 @@ import { isEmbeddingSdk } from "metabase/embedding-sdk/config";
import { EmailAttachmentPicker } from "metabase/notifications/EmailAttachmentPicker";
import { RecipientPicker } from "metabase/notifications/channels/RecipientPicker";
import { PLUGIN_DASHBOARD_SUBSCRIPTION_PARAMETERS_SECTION_OVERRIDE } from "metabase/plugins";
+import { dashboardPulseIsValid } from "metabase/pulse";
import type { DraftDashboardSubscription } from "metabase/redux/store";
import { canAccessSettings, getUser } from "metabase/selectors/user";
import { Icon, Title } from "metabase/ui";
-import { dashboardPulseIsValid } from "metabase/utils/pulse";
import { useSelector } from "metabase/utils/redux";
import type { UiParameter } from "metabase-lib/v1/parameters/types";
import type {
diff --git a/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/AddEditSlackSidebar.tsx b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/AddEditSlackSidebar.tsx
index 6a328184b62..3114b70384a 100644
--- a/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/AddEditSlackSidebar.tsx
+++ b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/AddEditSlackSidebar.tsx
@@ -12,9 +12,9 @@ import { Toggle } from "metabase/common/components/Toggle";
import CS from "metabase/css/core/index.css";
import { SlackChannelField } from "metabase/notifications/channels/SlackChannelField";
import { PLUGIN_DASHBOARD_SUBSCRIPTION_PARAMETERS_SECTION_OVERRIDE } from "metabase/plugins";
+import { dashboardPulseIsValid } from "metabase/pulse";
import type { DraftDashboardSubscription } from "metabase/redux/store";
import { Icon, Title } from "metabase/ui";
-import { dashboardPulseIsValid } from "metabase/utils/pulse";
import type { UiParameter } from "metabase-lib/v1/parameters/types";
import type {
Channel,
diff --git a/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/DashboardSubscriptionsSidebar.tsx b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/DashboardSubscriptionsSidebar.tsx
index 3cab6494c65..5877edcd177 100644
--- a/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/DashboardSubscriptionsSidebar.tsx
+++ b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/DashboardSubscriptionsSidebar.tsx
@@ -17,14 +17,10 @@ import {
getEditingPulse,
getPulseFormInput,
} from "metabase/notifications/pulse/selectors";
+import { NEW_PULSE_TEMPLATE, cleanPulse, createChannel } from "metabase/pulse";
import type { DraftDashboardSubscription, State } from "metabase/redux/store";
import { getUser, getUserIsAdmin } from "metabase/selectors/user";
import { UserApi } from "metabase/services";
-import {
- NEW_PULSE_TEMPLATE,
- cleanPulse,
- createChannel,
-} from "metabase/utils/pulse";
import { connect } from "metabase/utils/redux";
import type { UiParameter } from "metabase-lib/v1/parameters/types";
import type {
diff --git a/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/PulsesListSidebar.tsx b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/PulsesListSidebar.tsx
index 80862ec8245..aa0d16f1768 100644
--- a/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/PulsesListSidebar.tsx
+++ b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/PulsesListSidebar.tsx
@@ -7,6 +7,7 @@ import { Label } from "metabase/common/components/type/Label";
import { Subhead } from "metabase/common/components/type/Subhead";
import CS from "metabase/css/core/index.css";
import { formatDateValue } from "metabase/parameters/utils/date-formatting";
+import { getActivePulseParameters } from "metabase/pulse";
import type { State } from "metabase/redux/store";
import { Button, Icon, Tooltip } from "metabase/ui";
import {
@@ -14,7 +15,6 @@ import {
formatDateTimeWithUnit,
formatTimeWithUnit,
} from "metabase/utils/formatting";
-import { getActivePulseParameters } from "metabase/utils/pulse";
import { connect } from "metabase/utils/redux";
import { formatFrame } from "metabase/utils/time-dayjs";
import type { UiParameter } from "metabase-lib/v1/parameters/types";
diff --git a/frontend/src/metabase/notifications/channels/EmailChannelEdit.tsx b/frontend/src/metabase/notifications/channels/EmailChannelEdit.tsx
index ae28a89c426..92300d3cd27 100644
--- a/frontend/src/metabase/notifications/channels/EmailChannelEdit.tsx
+++ b/frontend/src/metabase/notifications/channels/EmailChannelEdit.tsx
@@ -1,4 +1,4 @@
-import type { RecipientPickerValue } from "metabase/utils/pulse";
+import type { RecipientPickerValue } from "metabase/pulse";
import { isNotNull } from "metabase/utils/types";
import type {
NotificationHandlerEmail,
diff --git a/frontend/src/metabase/notifications/channels/RecipientPicker.tsx b/frontend/src/metabase/notifications/channels/RecipientPicker.tsx
index beaa9561eeb..b2cc84cd2f2 100644
--- a/frontend/src/metabase/notifications/channels/RecipientPicker.tsx
+++ b/frontend/src/metabase/notifications/channels/RecipientPicker.tsx
@@ -5,12 +5,9 @@ import { TokenField } from "metabase/common/components/TokenField";
import { UserAvatar } from "metabase/common/components/UserAvatar";
import { useSetting } from "metabase/common/hooks";
import CS from "metabase/css/core/index.css";
+import { type RecipientPickerValue, recipientIsValid } from "metabase/pulse";
import { Text } from "metabase/ui";
import { isEmail } from "metabase/utils/email";
-import {
- type RecipientPickerValue,
- recipientIsValid,
-} from "metabase/utils/pulse";
import type { User } from "metabase-types/api";
import S from "./RecipientPicker.module.css";
diff --git a/frontend/src/metabase/notifications/modals/CreateOrEditQuestionAlertModal/CreateOrEditQuestionAlertModal.tsx b/frontend/src/metabase/notifications/modals/CreateOrEditQuestionAlertModal/CreateOrEditQuestionAlertModal.tsx
index d26ff8d8ab1..3e6f5d1057e 100644
--- a/frontend/src/metabase/notifications/modals/CreateOrEditQuestionAlertModal/CreateOrEditQuestionAlertModal.tsx
+++ b/frontend/src/metabase/notifications/modals/CreateOrEditQuestionAlertModal/CreateOrEditQuestionAlertModal.tsx
@@ -17,6 +17,10 @@ import {
getAlertTriggerOptions,
getDefaultQuestionAlertRequest,
} from "metabase/notifications/utils";
+import {
+ getHasConfiguredAnyChannel,
+ getHasConfiguredEmailOrSlackChannel,
+} from "metabase/pulse";
import { updateUrl } from "metabase/query_builder/actions/url";
import {
getQuestion,
@@ -36,10 +40,6 @@ import {
rem,
} from "metabase/ui";
import { getResponseErrorMessage } from "metabase/utils/errors";
-import {
- getHasConfiguredAnyChannel,
- getHasConfiguredEmailOrSlackChannel,
-} from "metabase/utils/pulse";
import { useDispatch, useSelector } from "metabase/utils/redux";
import type Question from "metabase-lib/v1/Question";
import type {
diff --git a/frontend/src/metabase/pulse/index.ts b/frontend/src/metabase/pulse/index.ts
new file mode 100644
index 00000000000..9b394d182ac
--- /dev/null
+++ b/frontend/src/metabase/pulse/index.ts
@@ -0,0 +1 @@
+export * from "./pulse";
diff --git a/frontend/src/metabase/utils/pulse.ts b/frontend/src/metabase/pulse/pulse.ts
similarity index 100%
rename from frontend/src/metabase/utils/pulse.ts
rename to frontend/src/metabase/pulse/pulse.ts
diff --git a/frontend/src/metabase/utils/pulse.unit.spec.ts b/frontend/src/metabase/pulse/pulse.unit.spec.ts
similarity index 99%
rename from frontend/src/metabase/utils/pulse.unit.spec.ts
rename to frontend/src/metabase/pulse/pulse.unit.spec.ts
index 630b51c7058..f0bf1b44ecd 100644
--- a/frontend/src/metabase/utils/pulse.unit.spec.ts
+++ b/frontend/src/metabase/pulse/pulse.unit.spec.ts
@@ -1,12 +1,13 @@
import type { DashboardSubscriptionData } from "metabase/redux/store";
+import MetabaseSettings from "metabase/utils/settings";
+import type { Parameter } from "metabase-types/api";
+
import {
type RecipientPickerValue,
getActivePulseParameters,
getPulseParameters,
recipientIsValid,
-} from "metabase/utils/pulse";
-import MetabaseSettings from "metabase/utils/settings";
-import type { Parameter } from "metabase-types/api";
+} from "./pulse";
describe("recipientIsValid", () => {
let originalDomains: string | null | undefined;