Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Show "No results" empty state in Metric Viewer (#73705)

Andrei Chernykhb5e18f8ff255
diff --git a/e2e/test/scenarios/metrics/metrics-explorer.cy.spec.ts b/e2e/test/scenarios/metrics/metrics-explorer.cy.spec.ts
index 3665c23d5c5..434d332fbdb 100644
--- a/e2e/test/scenarios/metrics/metrics-explorer.cy.spec.ts
+++ b/e2e/test/scenarios/metrics/metrics-explorer.cy.spec.ts
@@ -363,9 +363,7 @@ describe("scenarios > metrics > explorer", () => {
H.MetricsViewer.goToViewer();
addMetric("Empty Metric");
- H.MetricsViewer.getMetricVisualization()
- .findByText(/No dice/)
- .should("exist");
+ cy.findByRole("heading", { name: "No results!" }).should("exist");
});
});
diff --git a/frontend/src/metabase/metrics-viewer/components/MetricsViewerVisualization/MetricsViewerVisualization.tsx b/frontend/src/metabase/metrics-viewer/components/MetricsViewerVisualization/MetricsViewerVisualization.tsx
index 7523cb61bce..f45df7989d4 100644
--- a/frontend/src/metabase/metrics-viewer/components/MetricsViewerVisualization/MetricsViewerVisualization.tsx
+++ b/frontend/src/metabase/metrics-viewer/components/MetricsViewerVisualization/MetricsViewerVisualization.tsx
@@ -1,7 +1,9 @@
import { useMemo } from "react";
+import { t } from "ttag";
import { noop } from "underscore";
import { DebouncedFrame } from "metabase/common/components/DebouncedFrame";
+import { ErrorMessage } from "metabase/common/components/ErrorMessage";
import { LoadingAndErrorWrapper } from "metabase/common/components/LoadingAndErrorWrapper";
import { DISPLAY_TYPE_REGISTRY } from "metabase/metrics-viewer/utils";
import { MetricsViewerClickActionsMode } from "metabase/metrics-viewer/utils/MetricsViewerClickActionsMode";
@@ -9,6 +11,7 @@ import { getGridColumns } from "metabase/metrics-viewer/utils/grid-columns";
import type { MetricSlot } from "metabase/metrics-viewer/utils/metric-slots";
import { Center, Flex, SimpleGrid, Stack, useElementSize } from "metabase/ui";
import Visualization from "metabase/visualizations/components/Visualization";
+import { datasetContainsNoResults } from "metabase-lib/v1/queries/utils/dataset";
import type { CardId, SingleSeries } from "metabase-types/api";
import type {
@@ -90,6 +93,23 @@ export function MetricsViewerVisualization({
return null;
}
+ const hasNoResults = rawSeries.every((series) =>
+ datasetContainsNoResults(series.data),
+ );
+
+ if (hasNoResults) {
+ return (
+ <Center h="100%">
+ <ErrorMessage
+ type="noRows"
+ title={t`No results!`}
+ message={t`This may be the answer you're looking for. If not, try removing or changing your filters to make them less specific.`}
+ action={null}
+ />
+ </Center>
+ );
+ }
+
return (
<Flex
ref={ref}
diff --git a/frontend/src/metabase/visualizations/components/Visualization/Visualization.tsx b/frontend/src/metabase/visualizations/components/Visualization/Visualization.tsx
index e1bdb082ea4..61f0eba6ae3 100644
--- a/frontend/src/metabase/visualizations/components/Visualization/Visualization.tsx
+++ b/frontend/src/metabase/visualizations/components/Visualization/Visualization.tsx
@@ -877,7 +877,7 @@ class Visualization extends PureComponent<
)}
{replacementContent ? (
replacementContent
- ) : isDashboard && noResults ? (
+ ) : (isDashboard || isMetricsViewer) && noResults ? (
<NoResultsView isSmall={small} />
) : error && !isRunning ? (
<ErrorView