The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
E2E workflows env vars cleanup (#66592)
Nemanja Glumacb5f483d951d4
diff --git a/.github/workflows/e2e-stress-test-flake-fix.yml b/.github/workflows/e2e-stress-test-flake-fix.ymlindex 94f2f37ab09..520481802a6 100644--- a/.github/workflows/e2e-stress-test-flake-fix.yml+++ b/.github/workflows/e2e-stress-test-flake-fix.yml@@ -76,19 +76,15 @@ jobs:timeout-minutes: 60name: Stress test E2E flake fixenv:- DISPLAY: ""- MB_RUN_MODE: e2e- METASTORE_DEV_SERVER_URL: ${{ secrets.METASTORE_DEV_SERVER_URL }}+ DISPLAY: "" # https://github.com/cypress-io/cypress/issues/4034+ TERM: xterm+ TZ: US/Pacific # to make Node match the instance tzCYPRESS_MB_ALL_FEATURES_TOKEN: ${{ secrets.STAGING_MB_ALL_FEATURES_TOKEN }}CYPRESS_MB_STARTER_CLOUD_TOKEN: ${{ secrets.STAGING_MB_STARTER_CLOUD_TOKEN }}CYPRESS_MB_PRO_CLOUD_TOKEN: ${{ secrets.STAGING_MB_PRO_CLOUD_TOKEN }}CYPRESS_MB_PRO_SELF_HOSTED_TOKEN: ${{ secrets.STAGING_MB_PRO_SELF_HOSTED_TOKEN }}- MB_SNOWPLOW_AVAILABLE: true- MB_SNOWPLOW_URL: "http://localhost:9090" # Snowplow microMB_EDITION: ${{ inputs.mb_edition }}CYPRESS_ENABLE_NETWORK_THROTTLING: ${{ inputs.enable_network_throttling }}- TERM: xterm- TZ: US/Pacific # to make node match the instance tzsteps:- uses: actions/checkout@v4with:@@ -114,7 +110,6 @@ jobs:- name: Prepare front-end environmentuses: ./.github/actions/prepare-frontend-- name: Prepare back-end environmentuses: ./.github/actions/prepare-backenddiff --git a/.github/workflows/e2e-test.yml b/.github/workflows/e2e-test.ymlindex f023ae4bd97..677b46607ce 100644--- a/.github/workflows/e2e-test.yml+++ b/.github/workflows/e2e-test.yml@@ -29,6 +29,15 @@ on:required: falsetype: number+env:+ DISPLAY: "" # https://github.com/cypress-io/cypress/issues/4034+ TERM: xterm+ TZ: US/Pacific # to make Node match the instance tz+ GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}+ HASH: ${{ github.event.pull_request.head.sha || github.sha }}-${{ github.run_attempt }}+ PR_NUMBER: ${{ github.event.pull_request.number || '' }}+ JOB_NAME: ${{ inputs.name }}+jobs:e2e-tests:runs-on: ${{ inputs.runner }}@@ -36,21 +45,12 @@ jobs:name: e2e-tests-${{ inputs.name }}-${{ inputs.edition }}env:MB_EDITION: ${{ inputs.edition }}- DISPLAY: ""- PR_NUMBER: ${{ github.event.pull_request.number || '' }}- GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}- HASH: ${{ github.event.pull_request.head.sha || github.sha }}-${{ github.run_attempt }}- JOB_NAME: ${{ inputs.name }}# Any env starting with `CYPRESS_` will be available to all Cypress tests via `Cypress.env()`# Example: you can get `CYPRESS_FOO` with `Cypress.env("FOO")`CYPRESS_MB_ALL_FEATURES_TOKEN: ${{ secrets.STAGING_MB_ALL_FEATURES_TOKEN }}CYPRESS_MB_STARTER_CLOUD_TOKEN: ${{ secrets.STAGING_MB_STARTER_CLOUD_TOKEN }}CYPRESS_MB_PRO_CLOUD_TOKEN: ${{ secrets.STAGING_MB_PRO_CLOUD_TOKEN }}CYPRESS_MB_PRO_SELF_HOSTED_TOKEN: ${{ secrets.STAGING_MB_PRO_SELF_HOSTED_TOKEN }}- CYPRESS_PULL_REQUEST_ID: ${{ github.event.pull_request.number || '' }}- COMMIT_INFO_MESSAGE: ${{ github.event.pull_request.title || github.event.head_commit.message || github.event.head.sha }}- TZ: US/Pacific # to make node match the instance tz- CYPRESS_CI: truesteps:- uses: actions/checkout@v4with:diff --git a/.github/workflows/embedding-sdk-component-tests.yml b/.github/workflows/embedding-sdk-component-tests.ymlindex 44b117b7288..3d755dd72e7 100644--- a/.github/workflows/embedding-sdk-component-tests.yml+++ b/.github/workflows/embedding-sdk-component-tests.yml@@ -3,6 +3,12 @@ name: Embedding SDK Component Testson:workflow_call:+env:+ DISPLAY: "" # https://github.com/cypress-io/cypress/issues/4034+ TERM: xterm+ TZ: US/Pacific # to make Node match the instance tz+ MB_EDITION: "ee"+jobs:sdk-component-tests:name: "SDK component tests (React ${{ matrix.react-version }})"@@ -13,17 +19,12 @@ jobs:react-version: [18, 19]fail-fast: falseenv:- MB_EDITION: ee- DISPLAY: ""# Any env starting with `CYPRESS_` will be available to all Cypress tests via `Cypress.env()`# Example: you can get `CYPRESS_FOO` with `Cypress.env("FOO")`CYPRESS_MB_ALL_FEATURES_TOKEN: ${{ secrets.STAGING_MB_ALL_FEATURES_TOKEN }}CYPRESS_MB_STARTER_CLOUD_TOKEN: ${{ secrets.STAGING_MB_STARTER_CLOUD_TOKEN }}CYPRESS_MB_PRO_CLOUD_TOKEN: ${{ secrets.STAGING_MB_PRO_CLOUD_TOKEN }}CYPRESS_MB_PRO_SELF_HOSTED_TOKEN: ${{ secrets.STAGING_MB_PRO_SELF_HOSTED_TOKEN }}- COMMIT_INFO_MESSAGE: ${{ github.event.pull_request.title || github.event.head_commit.message || github.event.head.sha }}- TZ: US/Pacific # to make node match the instance tz- CYPRESS_CI: truesteps:- uses: actions/checkout@v4@@ -149,8 +150,6 @@ jobs:runs-on: ubuntu-22.04timeout-minutes: 45env:- MB_EDITION: ee- DISPLAY: ""MB_RUN_MODE: "e2e"METASTORE_DEV_SERVER_URL: ${{ secrets.METASTORE_DEV_SERVER_URL }}# Any env starting with `CYPRESS_` will be available to all Cypress tests via `Cypress.env()`@@ -159,9 +158,6 @@ jobs:CYPRESS_MB_STARTER_CLOUD_TOKEN: ${{ secrets.STAGING_MB_STARTER_CLOUD_TOKEN }}CYPRESS_MB_PRO_CLOUD_TOKEN: ${{ secrets.STAGING_MB_PRO_CLOUD_TOKEN }}CYPRESS_MB_PRO_SELF_HOSTED_TOKEN: ${{ secrets.STAGING_MB_PRO_SELF_HOSTED_TOKEN }}- COMMIT_INFO_MESSAGE: ${{ github.event.pull_request.title || github.event.head_commit.message || github.event.head.sha }}- TZ: US/Pacific # to make node match the instance tz- CYPRESS_CI: truesteps:- name: Check out the code from the previous commitdiff --git a/.github/workflows/embedding-sdk-host-sample-apps-tests.yml b/.github/workflows/embedding-sdk-host-sample-apps-tests.ymlindex 9d5a3f03786..235c5b98352 100644--- a/.github/workflows/embedding-sdk-host-sample-apps-tests.yml+++ b/.github/workflows/embedding-sdk-host-sample-apps-tests.yml@@ -3,6 +3,14 @@ name: "[NOT REQUIRED] SDK Compatibility tests"on:workflow_call:+env:+ DISPLAY: "" # https://github.com/cypress-io/cypress/issues/4034+ TERM: xterm+ TZ: US/Pacific # to make Node match the instance tz+ GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}+ HASH: ${{ github.event.pull_request.head.sha || github.sha }}-${{ github.run_attempt }}+ PR_NUMBER: ${{ github.event.pull_request.number || '' }}+ MB_EDITION: eejobs:get-sample-apps-data:runs-on: ubuntu-22.04@@ -100,15 +108,9 @@ jobs:name: e2e-sample-app-${{ matrix.test_suite }}-tests-${{ matrix.environment }}-bundleenv:MB_EDITION: ee- DISPLAY: ""- GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}- PR_NUMBER: ${{ github.event.pull_request.number || '' }}- HASH: ${{ github.event.pull_request.head.sha || github.sha }}-${{ github.run_attempt }}MB_RUN_MODE: e2eMETASTORE_DEV_SERVER_URL: ${{ secrets.METASTORE_DEV_SERVER_URL }}CYPRESS_MB_ALL_FEATURES_TOKEN: ${{ secrets.STAGING_MB_ALL_FEATURES_TOKEN }}- TZ: US/Pacific # to make node match the instance tz- CYPRESS_CI: trueSAMPLE_APP_BRANCH_NAME: ${{ needs.get-sample-apps-data.outputs.branch_name }}SAMPLE_APP_ENVIRONMENT: ${{ matrix.environment }}permissions:@@ -237,14 +239,7 @@ jobs:timeout-minutes: 45name: e2e-host-app-${{ matrix.test_suite }}-tests-${{ matrix.environment }}-bundleenv:- MB_EDITION: ee- DISPLAY: ""- GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}- PR_NUMBER: ${{ github.event.pull_request.number || '' }}- HASH: ${{ github.event.pull_request.head.sha || github.sha }}-${{ github.run_attempt }}CYPRESS_MB_ALL_FEATURES_TOKEN: ${{ secrets.STAGING_MB_ALL_FEATURES_TOKEN }}- TZ: US/Pacific # to make node match the instance tz- CYPRESS_CI: trueHOST_APP_ENVIRONMENT: ${{ matrix.environment }}permissions:id-token: writediff --git a/e2e/support/config.js b/e2e/support/config.jsindex c5f655ced34..649fc856459 100644--- a/e2e/support/config.js+++ b/e2e/support/config.js@@ -25,7 +25,7 @@ const {const cypressSplit = require("cypress-split");const isEnterprise = process.env["MB_EDITION"] === "ee";-const isCI = process.env["CYPRESS_CI"] === "true";+const isCI = !!process.env.CI;const snowplowMicroUrl = process.env["MB_SNOWPLOW_URL"];