The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Remove unused `mb_user_defaults` env var (#65725)
Nemanja Glumacb82cf6fdeeb4
diff --git a/e2e/runner/cypress-runner-backend.js b/e2e/runner/cypress-runner-backend.jsindex cf9650cf032..7298a98aea5 100755--- a/e2e/runner/cypress-runner-backend.js+++ b/e2e/runner/cypress-runner-backend.js@@ -52,25 +52,6 @@ const CypressBackend = {MB_IS_CYPRESS: "true", // custom flag so we can detect we're running in Cypress, used in tests.};- /**- * This ENV is used for Cloud instances only, and is subject to change.- * As such, it is not documented anywhere in the code base!- *- * WARNING:- * Changing values here will break the related E2E test.- */- const userDefaults = {- MB_USER_DEFAULTS: JSON.stringify({- token: "123456",- user: {- first_name: "Testy",- last_name: "McTestface",- email: "[email protected]",- site_name: "Epic Team",- },- }),- };-this.server.process = spawn("java",[...javaFlags, "-jar", "target/uberjar/metabase.jar"],@@ -78,7 +59,6 @@ const CypressBackend = {env: {...process.env,...metabaseConfig,- ...userDefaults,},stdio:process.env["DISABLE_LOGGING"] ||diff --git a/e2e/test/scenarios/onboarding/setup/setup.cy.spec.ts b/e2e/test/scenarios/onboarding/setup/setup.cy.spec.tsindex 434b229e592..aead4da0760 100644--- a/e2e/test/scenarios/onboarding/setup/setup.cy.spec.ts+++ b/e2e/test/scenarios/onboarding/setup/setup.cy.spec.ts@@ -201,24 +201,6 @@ describe("scenarios > setup", () => {});});- // Values in this test are set through MB_USER_DEFAULTS environment variable!- // Please see https://github.com/metabase/metabase/pull/18763 for details- it("should allow pre-filling user details", () => {- cy.visit("/setup#123456");-- skipWelcomePage();-- cy.findByTestId("setup-forms").within(() => {- cy.findByLabelText("First name").should("have.value", "Testy");- cy.findByLabelText("Last name").should("have.value", "McTestface");- cy.findByLabelText("Email").should("have.value", "[email protected]");- cy.findByLabelText("Company or team name").should(- "have.value",- "Epic Team",- );- });- });-it("should pre-fill user info for hosted instances (infra-frontend#1109)", () => {H.mockSessionProperty("is-hosted?", true);@@ -437,35 +419,7 @@ describe("scenarios > setup", () => {cy.intercept("GET", "api/collection/root").as("getRootCollection");cy.intercept("GET", "api/database").as("getDatabases");- cy.visit("/setup#123456");-- skipWelcomePage();-- cy.findByLabelText(/What should we call you/);-- cy.findByTestId("setup-forms").within(() => {- const strongPassword = "QJbHYJN3tPW[";- cy.findByLabelText(/^Create a password/)- .clear()- .type(strongPassword, { delay: 0 });- cy.findByLabelText(/^Confirm your password/)- .clear()- .type(strongPassword, { delay: 0 })- .blur();- });-- cy.findByLabelText(/What should we call you/)- .button("Next")- .click();-- // make sure this bit of the form loads before clicking next- cy.findByLabelText(/What will you use Metabase for/).findByText(- /Let us know your plans/,- );-- cy.findByLabelText(/What will you use Metabase for/)- .button("Next")- .click();+ navigateToDatabaseStep();cy.findByTestId("database-form").within(() => {cy.findByPlaceholderText("Search databases").type("lite").blur();diff --git a/frontend/src/metabase/services.js b/frontend/src/metabase/services.jsindex b6c3a54cd1d..d4c14908746 100644--- a/frontend/src/metabase/services.js+++ b/frontend/src/metabase/services.js@@ -309,7 +309,6 @@ export const PersistedModelsApi = {export const SetupApi = {create: POST("/api/setup"),- user_defaults: GET("/api/setup/user_defaults"),};export const UserApi = {diff --git a/frontend/src/metabase/setup/actions.ts b/frontend/src/metabase/setup/actions.tsindex 7ad98674038..c5aadc33b98 100644--- a/frontend/src/metabase/setup/actions.ts+++ b/frontend/src/metabase/setup/actions.ts@@ -32,7 +32,7 @@ import {getUsageReason,} from "./selectors";import type { SetupStep } from "./types";-import { getDefaultLocale, getLocales, getUserToken } from "./utils";+import { getDefaultLocale, getLocales } from "./utils";interface ThunkConfig {state: State;@@ -50,18 +50,6 @@ export const goToNextStep = createAsyncThunk(},);-export const LOAD_USER_DEFAULTS = "metabase/setup/LOAD_USER_DEFAULTS";-export const loadUserDefaults = createAsyncThunk(- LOAD_USER_DEFAULTS,- async (): Promise<UserInfo | undefined> => {- const token = getUserToken();- if (token) {- const defaults = await SetupApi.user_defaults({ token });- return defaults.user;- }- },-);-export const LOAD_LOCALE_DEFAULTS = "metabase/setup/LOAD_LOCALE_DEFAULTS";export const loadLocaleDefaults = createAsyncThunk<Locale | undefined,@@ -80,7 +68,6 @@ export const LOAD_DEFAULTS = "metabase/setup/LOAD_DEFAULTS";export const loadDefaults = createAsyncThunk<void, void, ThunkConfig>(LOAD_DEFAULTS,(_, { dispatch }) => {- dispatch(loadUserDefaults());dispatch(loadLocaleDefaults());},);diff --git a/frontend/src/metabase/setup/reducers.ts b/frontend/src/metabase/setup/reducers.tsindex c2547cfc2b4..f5c0e194b6e 100644--- a/frontend/src/metabase/setup/reducers.ts+++ b/frontend/src/metabase/setup/reducers.ts@@ -4,7 +4,6 @@ import type { SetupState } from "metabase-types/store";import {loadLocaleDefaults,- loadUserDefaults,selectStep,skipDatabase,submitDatabase,@@ -51,11 +50,6 @@ const initialState: SetupState = {};export const reducer = createReducer(initialState, (builder) => {- builder.addCase(loadUserDefaults.fulfilled, (state, { payload: user }) => {- if (user) {- state.user = user;- }- });builder.addCase(loadLocaleDefaults.fulfilled,(state, { payload: locale }) => {diff --git a/src/metabase/cmd/resources/env-vars-to-avoid.edn b/src/metabase/cmd/resources/env-vars-to-avoid.ednindex 4231c5ed012..feb3d301e2e 100644--- a/src/metabase/cmd/resources/env-vars-to-avoid.edn+++ b/src/metabase/cmd/resources/env-vars-to-avoid.edn@@ -22,5 +22,4 @@"MB_TO_SMTP_SETTINGS""MB_TRACE_STR""MB_TYPES"- "MB_USER_DEFAULTS""MB_VERSION_STRING"]diff --git a/src/metabase/config/core.clj b/src/metabase/config/core.cljindex 6a4434c6591..04e52c60f5b 100644--- a/src/metabase/config/core.clj+++ b/src/metabase/config/core.clj@@ -1,7 +1,6 @@(ns metabase.config.core(:require^{:clj-kondo/ignore [:discouraged-namespace]}- [cheshire.core :as json][clojure.java.io :as io][clojure.string :as str][environ.core :as env]@@ -174,12 +173,6 @@mb-version-and-process-identifier(format "%s [%s]" mb-app-id-string local-process-uuid))-(defn mb-user-defaults- "Default user details provided as a JSON string at launch time for first-user setup flow."- []- (when-let [user-json (env/env :mb-user-defaults)]- (json/parse-string user-json true)))-(def ^:const internal-mb-user-id"The user-id of the internal metabase user.This is needed in the OSS edition to filter out users for setup/has-user-setup."diff --git a/src/metabase/setup/api.clj b/src/metabase/setup/api.cljindex 68159d8e80c..369d3a0dfc5 100644--- a/src/metabase/setup/api.clj+++ b/src/metabase/setup/api.clj@@ -2,10 +2,8 @@(:require[java-time.api :as t][metabase.analytics.core :as analytics]- [metabase.api.common :as api][metabase.api.macros :as api.macros][metabase.appearance.core :as appearance]- [metabase.config.core :as config][metabase.events.core :as events][metabase.request.core :as request][metabase.session.models.session :as session]@@ -109,15 +107,3 @@(events/publish-event! :event/user-joined {:user-id user-id}));; return response with session ID and set the cookie as well(request/set-session-cookies request {:id session-key} session (t/zoned-date-time (t/zone-id "GMT"))))))--;; TODO (Cam 10/28/25) -- fix this endpoint route to use kebab-case for consistency with the rest of our REST API-#_{:clj-kondo/ignore [:metabase/validate-defendpoint-route-uses-kebab-case]}-(api.macros/defendpoint :get "/user_defaults"- "Returns object containing default user details for initial setup, if configured,- and if the provided token value matches the token in the configuration value."- [_route-params- {:keys [token]}]- (let [{config-token :token :as defaults} (config/mb-user-defaults)]- (api/check-404 config-token)- (api/check-403 (= token config-token))- (dissoc defaults :token)))diff --git a/test/metabase/setup/api_test.clj b/test/metabase/setup/api_test.cljindex 5682a69c60f..de953d72f0c 100644--- a/test/metabase/setup/api_test.clj+++ b/test/metabase/setup/api_test.clj@@ -295,19 +295,3 @@(testing "Setup token should still be set"(is (= setup-token(setup/setup-token))))))))))--(deftest user-defaults-test- (testing "with no user defaults configured"- (mt/with-temp-env-var-value! [mb-user-defaults nil]- (is (= "Not found." (client/client :get "setup/user_defaults")))))-- (testing "with defaults containing no token"- (mt/with-temp-env-var-value! [mb-user-defaults "{}"]- (is (= "Not found." (client/client :get "setup/user_defaults")))))-- (testing "with valid configuration"- (mt/with-temp-env-var-value! [mb-user-defaults "{\"token\":\"123456\",\"email\":\"[email protected]\"}"]- (testing "with mismatched token"- (is (= "You don't have permissions to do that." (client/client :get "setup/user_defaults?token=987654"))))- (testing "with valid token"- (is (= {:email "[email protected]"} (client/client :get "setup/user_defaults?token=123456")))))))