Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Fix embedding types casing (#67071)

Timofey Kachalovb87cab77edb9
diff --git a/docs/cloud/how-billing-works.md b/docs/cloud/how-billing-works.md
index 3f31ca32e99..3b228ef526d 100644
--- a/docs/cloud/how-billing-works.md
+++ b/docs/cloud/how-billing-works.md
@@ -60,9 +60,9 @@ A user account is any account which has been added to your Metabase instance (ma
## How billing works with embedding
-Full app embedding and modular embedding (unless using Guest embeds) requires viewers to sign in to your Metabase, which means they will count as users for billing purposes.
+Full app embedding and modular embedding (unless using guest embeds) requires viewers to sign in to your Metabase, which means they will count as users for billing purposes.
-Guest Embedding doesn’t require viewers to sign in to your Metabase, which means they won’t count as additional users for billing purposes.
+Guest embedding doesn’t require viewers to sign in to your Metabase, which means they won’t count as additional users for billing purposes.
## How we count active user accounts each day
diff --git a/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/embed-flow-enable-embed-js.cy.spec.ts b/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/embed-flow-enable-embed-js.cy.spec.ts
index ad8b2f42800..0c86915a8cb 100644
--- a/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/embed-flow-enable-embed-js.cy.spec.ts
+++ b/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/embed-flow-enable-embed-js.cy.spec.ts
@@ -12,14 +12,14 @@ const DATA_BY_MB_EDITION = {
oss: {
cardTestId: "guest-embeds-setting-card",
cardText:
- "To continue, enable Guest embeds and agree to the usage conditions.",
+ "To continue, enable guest embeds and agree to the usage conditions.",
embeddingSettingName: "enable-embedding-static",
showTermsSettingName: "show-static-embed-terms",
},
ee: {
cardTestId: "sdk-setting-card",
cardText:
- "To continue, enable Modular embedding and agree to the usage conditions.",
+ "To continue, enable modular embedding and agree to the usage conditions.",
embeddingSettingName: "enable-embedding-simple",
showTermsSettingName: "show-simple-embed-terms",
},
diff --git a/e2e/test/scenarios/sharing/public-sharing-embed-button-behavior.cy.spec.js b/e2e/test/scenarios/sharing/public-sharing-embed-button-behavior.cy.spec.js
index b41e8a3d696..575ff67e346 100644
--- a/e2e/test/scenarios/sharing/public-sharing-embed-button-behavior.cy.spec.js
+++ b/e2e/test/scenarios/sharing/public-sharing-embed-button-behavior.cy.spec.js
@@ -182,7 +182,7 @@ describe("Embed JS modal display", () => {
H.openSharingMenu("Embed");
H.embedModalEnableEmbeddingCard().within(() => {
- cy.findByText(/Modular embedding/).should("be.visible");
+ cy.findByText(/modular embedding/).should("be.visible");
});
});
});
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/EnableEmbeddedAnalyticsCard.tsx b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/EnableEmbeddedAnalyticsCard.tsx
index a36163c75a7..cdc19ea4134 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/EnableEmbeddedAnalyticsCard.tsx
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/EnableEmbeddedAnalyticsCard.tsx
@@ -15,7 +15,7 @@ export const EnableEmbeddedAnalyticsCard = () => {
return (
<EnableEmbeddingCard
- embeddingType="Modular embedding"
+ embeddingType="modular embedding"
isEnabled={isSimpleEmbeddingEnabled}
termsAccepted={isSimpleEmbeddingTermsAccepted}
settingsToUpdate={{
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/EnableGuestEmbedsCard.tsx b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/EnableGuestEmbedsCard.tsx
index aa0f60efd5e..da1a7feff4f 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/EnableGuestEmbedsCard.tsx
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/EnableGuestEmbedsCard.tsx
@@ -22,7 +22,7 @@ export const EnableGuestEmbedsCard = () => {
return (
<EnableEmbeddingCard
- embeddingType="Guest embeds"
+ embeddingType="guest embeds"
isEnabled={isGuestEmbedsEnabled}
termsAccepted={isGuestEmbedsTermsAccepted}
settingsToUpdate={{
@@ -35,7 +35,7 @@ export const EnableGuestEmbedsCard = () => {
"show-static-embed-terms": false,
}),
}}
- errorMessage={t`Failed to enable Guest embeds`}
+ errorMessage={t`Failed to enable guest embeds`}
/>
);
};
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/GetCode/PublishQuestionEmptyState.tsx b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/GetCode/PublishQuestionEmptyState.tsx
index 7ad77023842..1dcfd9b7fdf 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/GetCode/PublishQuestionEmptyState.tsx
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/GetCode/PublishQuestionEmptyState.tsx
@@ -26,7 +26,7 @@ export const PublishQuestionEmptyState = () => {
<Loader size="xs" />
) : (
c(
- "{0} is a link that publishes an entity to be embeddable via Guest Embedding",
+ "{0} is a link that publishes an entity to be embeddable via guest embedding",
).jt`To get the embedding code, ${(
<Anchor
key="publish-guest-embed-question"