The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
fix: update misleading copy on transforms upsell page (#74938)
github-automation-metabaseb8bfd206e795
diff --git a/e2e/test/scenarios/data-studio/transforms/transforms.cy.spec.ts b/e2e/test/scenarios/data-studio/transforms/transforms.cy.spec.tsindex 3ee1edc45db..f93c255c6c0 100644--- a/e2e/test/scenarios/data-studio/transforms/transforms.cy.spec.ts+++ b/e2e/test/scenarios/data-studio/transforms/transforms.cy.spec.ts@@ -3800,7 +3800,7 @@ describe("scenarios > admin > transforms", () => {cy.log("create a new transform");visitTransformListPage();cy.findByRole("heading", {- name: "To use transforms, you need a writable database connection",+ name: "No compatible database connection",}).should("exist");cy.findByRole("link", { name: "View your database connections" }).should("exist",diff --git a/frontend/src/metabase/data-studio/app/pages/TransformsSectionLayout/TransformsSectionLayout.unit.spec.tsx b/frontend/src/metabase/data-studio/app/pages/TransformsSectionLayout/TransformsSectionLayout.unit.spec.tsxindex c835a42fca3..54aded03920 100644--- a/frontend/src/metabase/data-studio/app/pages/TransformsSectionLayout/TransformsSectionLayout.unit.spec.tsx+++ b/frontend/src/metabase/data-studio/app/pages/TransformsSectionLayout/TransformsSectionLayout.unit.spec.tsx@@ -273,9 +273,7 @@ describe("TransformSectionLayout", () => {expect(await screen.findByText(/error/i)).toBeInTheDocument();expect(- screen.queryByText(- "To use transforms, you need a writable database connection",- ),+ screen.queryByText("No compatible database connection"),).not.toBeInTheDocument();});});@@ -290,7 +288,5 @@ const assertEnableScreen = async () =>const assertNoWritableDatabasesEmptyState = async () =>expect(- await screen.findByText(- "To use transforms, you need a writable database connection",- ),+ await screen.findByText("No compatible database connection"),).toBeInTheDocument();diff --git a/frontend/src/metabase/transforms/pages/EnableTransformsPage/EnableTransformsCard.tsx b/frontend/src/metabase/transforms/pages/EnableTransformsPage/EnableTransformsCard.tsxindex 5850c03f129..76eac757fb6 100644--- a/frontend/src/metabase/transforms/pages/EnableTransformsPage/EnableTransformsCard.tsx+++ b/frontend/src/metabase/transforms/pages/EnableTransformsPage/EnableTransformsCard.tsx@@ -2,7 +2,7 @@ import { jt, t } from "ttag";import { useListDatabasesQuery } from "metabase/api/database";import { Link } from "metabase/common/components/Link";-import { getPlan } from "metabase/common/utils/plan";+import { getPlan, isProPlan } from "metabase/common/utils/plan";import { useSelector } from "metabase/redux";import { getSetting } from "metabase/selectors/settings";import { doesDatabaseSupportTransforms } from "metabase/transforms/utils";@@ -37,10 +37,9 @@ export function EnableTransformsCard({const plan = useSelector((state) =>getPlan(getSetting(state, "token-features")),);- const permissionsDescription =- plan === "pro-self-hosted"- ? t`Only Analysts and Admins can create and run transforms`- : t`Only Admins can create and run transforms`;+ const permissionsDescription = isProPlan(plan)+ ? t`Only Analysts and Admins can create and run transforms`+ : t`Only Admins can create and run transforms`;return (<Card withBorder maw="60rem" p={0} w="100%" style={{ overflow: "auto" }}>@@ -77,16 +76,15 @@ export function EnableTransformsCard({color="warning"variant="light"icon={<Icon name="warning" size={16} />}- title={t`No writable database connection`}+ title={t`No compatible database connection`}>- {/* eslint-disable-next-line metabase/no-literal-metabase-strings -- Only admins can see this */}- {jt`Transforms create tables in your database, so Metabase needs write access. ${(+ {jt`None of your connected databases can be used with transforms. ${(<Linkkey="link"to="/admin/databases"style={{ textDecoration: "underline" }}- >{t`Reconnect or add a connection`}</Link>- )} with a user that has the right privileges.`}+ >{t`Connect a compatible database`}</Link>+ )} to get started.`}</Alert>)}</Stack>diff --git a/frontend/src/metabase/transforms/pages/NoWritableDatabasesEmptyState/NoWritableDatabasesEmptyState.tsx b/frontend/src/metabase/transforms/pages/NoWritableDatabasesEmptyState/NoWritableDatabasesEmptyState.tsxindex f16f6cae34b..d47b2392c21 100644--- a/frontend/src/metabase/transforms/pages/NoWritableDatabasesEmptyState/NoWritableDatabasesEmptyState.tsx+++ b/frontend/src/metabase/transforms/pages/NoWritableDatabasesEmptyState/NoWritableDatabasesEmptyState.tsx@@ -28,9 +28,9 @@ export function NoWritableDatabasesEmptyState() {<Titleorder={3}ta="center"- >{t`To use transforms, you need a writable database connection`}</Title>+ >{t`No compatible database connection`}</Title><Text ta="center" c="text-secondary">- {t`None of your connected databases have a writable connection. Either edit the connection on the database you want to enable transforms on, or connect to a different database.`}+ {t`None of your connected databases can be used with transforms. Connect a compatible database or check that your existing databases meet the requirements.`}</Text>{canAccessDatabases && (<Button