The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Add test for #68701 (already fixed) (#75291)
Cam Saulb9fd9c4f3d03
diff --git a/test/metabase/driver/sql/query_processor_test.clj b/test/metabase/driver/sql/query_processor_test.cljindex d1b558747c6..a5e3e4cd39f 100644--- a/test/metabase/driver/sql/query_processor_test.clj+++ b/test/metabase/driver/sql/query_processor_test.clj@@ -1690,3 +1690,75 @@(->> (qp/process-query query)(mt/formatted-rows [identity int])(map second)))))))++(deftest ^:parallel multiple-aggregations-on-the-same-column-test+ (testing "Multiple breakouts against the same column with different bucketing should produce correct SQL (#68701, QUE2-72)"+ (let [mp meta/metadata-provider+ query (-> (lib/query mp (meta/table-metadata :orders))+ (lib/aggregate (lib/count))+ (lib/breakout (-> (meta/field-metadata :orders :created-at)+ (lib/with-temporal-bucket :day)))+ lib/append-stage+ (as-> $query (lib/aggregate $query (lib/avg (lib.tu.notebook/find-col-with-spec+ $query+ (lib/aggregable-columns $query nil)+ {}+ {:display-name "Count"}))))+ (as-> $query (let [created-at (lib.tu.notebook/find-col-with-spec+ $query+ (lib/breakoutable-columns $query)+ {}+ {:display-name "Created At: Day"})]+ (-> $query+ (lib/breakout (lib/with-temporal-bucket created-at :day-of-month))+ (lib/breakout (lib/with-temporal-bucket created-at :month)))))+ lib/append-stage+ (as-> $query (lib/aggregate $query (lib/avg (lib.tu.notebook/find-col-with-spec+ $query+ (lib/aggregable-columns $query nil)+ {}+ {:display-name "Average of Count"})))))]+ (is (= ["SELECT"+ " AVG(__mb_source.avg) AS avg"+ "FROM"+ " ("+ " SELECT"+ " extract("+ " day"+ " from"+ " __mb_source.CREATED_AT"+ " ) AS CREATED_AT,"+ " DATE_TRUNC('month', __mb_source.CREATED_AT) AS CREATED_AT_2," ; <= this should be `CREATED_AT_2`, not a repeat of `CREATED_AT`+ " AVG(__mb_source.count) AS avg"+ " FROM"+ " ("+ " SELECT"+ " CAST(PUBLIC.ORDERS.CREATED_AT AS date) AS CREATED_AT,"+ " COUNT(*) AS count"+ " FROM"+ " PUBLIC.ORDERS"+ " GROUP BY"+ " CAST(PUBLIC.ORDERS.CREATED_AT AS date)"+ " ORDER BY"+ " CAST(PUBLIC.ORDERS.CREATED_AT AS date) ASC"+ " ) AS __mb_source"+ " GROUP BY"+ " extract("+ " day"+ " from"+ " __mb_source.CREATED_AT"+ " ),"+ " DATE_TRUNC('month', __mb_source.CREATED_AT)"+ " ORDER BY"+ " extract("+ " day"+ " from"+ " __mb_source.CREATED_AT"+ " ) ASC,"+ " DATE_TRUNC('month', __mb_source.CREATED_AT) ASC"+ " ) AS __mb_source"]+ (-> (qp.compile/compile query)+ :query+ (->> (driver/prettify-native-form :h2))+ (str/replace #"\"" "")+ str/split-lines))))))