Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Fix MCP embed bundle loading async chunks from wrong origin (#76411)

Romeo Van Snickbb27b7a1c54b
diff --git a/frontend/lint/module-boundaries.mjs b/frontend/lint/module-boundaries.mjs
index 4639edbb531..725d8f36cd1 100644
--- a/frontend/lint/module-boundaries.mjs
+++ b/frontend/lint/module-boundaries.mjs
@@ -175,6 +175,8 @@ const elements = [
"frontend/src/metabase/app-main.js",
"frontend/src/metabase/app-embed.ts",
"frontend/src/metabase/app-embed-mcp.tsx",
+ "frontend/src/metabase/app-embed-mcp-public-path.ts",
+ "frontend/src/metabase/app-embed-mcp-public-path.unit.spec.ts",
"frontend/src/metabase/app-public.ts",
"frontend/src/metabase/AppComponent.tsx",
"frontend/src/metabase/App.styled.tsx",
diff --git a/frontend/src/metabase/app-embed-mcp-public-path.ts b/frontend/src/metabase/app-embed-mcp-public-path.ts
new file mode 100644
index 00000000000..f3b17238ddc
--- /dev/null
+++ b/frontend/src/metabase/app-embed-mcp-public-path.ts
@@ -0,0 +1,37 @@
+/**
+ * Sets webpack's runtime `publicPath` (`__webpack_require__.p`) so on-demand
+ * chunks (loaded via dynamic `import()` — e.g. the leaflet map renderer and the
+ * echarts renderer) are fetched from the Metabase instance.
+ *
+ * The MCP app runs inside a sandboxed `about:srcdoc` iframe. The initial bundle
+ * scripts load fine because HtmlWebpackPlugin writes them with an absolute,
+ * instance-templated URL. On-demand chunks instead use the runtime `publicPath`,
+ * which is the relative `output.publicPath` ("app/dist/"); that does not resolve
+ * to the instance inside the srcdoc iframe and 404s.
+ *
+ * Unlike the Embedding SDK (which derives its base from `document.currentScript`),
+ * the instance URL is injected synchronously via `window.metabaseConfig`, so we
+ * use it directly — `document.currentScript` is null here because the entry runs
+ * deferred, after the document is parsed.
+ *
+ * This must be imported before any dynamic `import()` can run, so it is the first
+ * import of the bundle entry.
+ */
+
+// Provided by webpack/rspack at build time; the `declare` emits no runtime code,
+// so the assignment below is rewritten to set the runtime's `publicPath`.
+declare let __webpack_public_path__: string;
+
+const instanceUrl: string = window.metabaseConfig?.instanceUrl ?? "";
+
+// In hot/dev mode `output.publicPath` is already an absolute localhost URL served
+// by the dev server, so leave it alone — only the relative production path needs
+// to be rewritten to the instance.
+const runtimePathIsAbsolute = /^https?:\/\//.test(__webpack_public_path__);
+
+if (instanceUrl && !runtimePathIsAbsolute) {
+ const base = instanceUrl.endsWith("/") ? instanceUrl : `${instanceUrl}/`;
+ __webpack_public_path__ = `${base}app/dist/`;
+}
+
+export {};
diff --git a/frontend/src/metabase/app-embed-mcp-public-path.unit.spec.ts b/frontend/src/metabase/app-embed-mcp-public-path.unit.spec.ts
new file mode 100644
index 00000000000..d3cdf7a63c6
--- /dev/null
+++ b/frontend/src/metabase/app-embed-mcp-public-path.unit.spec.ts
@@ -0,0 +1,60 @@
+describe("app-embed-mcp-public-path", () => {
+ const setRuntimePublicPath = (value: string) => {
+ (globalThis as any).__webpack_public_path__ = value;
+ };
+
+ const getRuntimePublicPath = () =>
+ (globalThis as any).__webpack_public_path__;
+
+ const setInstanceUrl = (instanceUrl: string | undefined) => {
+ (window as any).metabaseConfig =
+ instanceUrl === undefined ? undefined : { instanceUrl };
+ };
+
+ const loadModule = () => import("./app-embed-mcp-public-path");
+
+ beforeEach(() => {
+ jest.resetModules();
+ });
+
+ afterEach(() => {
+ delete (window as any).metabaseConfig;
+ delete (globalThis as any).__webpack_public_path__;
+ });
+
+ it("rewrites the relative production publicPath to an absolute instance URL", async () => {
+ setRuntimePublicPath("app/dist/");
+ setInstanceUrl("https://mb.example.com");
+
+ await loadModule();
+
+ expect(getRuntimePublicPath()).toBe("https://mb.example.com/app/dist/");
+ });
+
+ it("does not double the slash when the instance URL already ends with one", async () => {
+ setRuntimePublicPath("app/dist/");
+ setInstanceUrl("https://mb.example.com/");
+
+ await loadModule();
+
+ expect(getRuntimePublicPath()).toBe("https://mb.example.com/app/dist/");
+ });
+
+ it("leaves an already-absolute (hot/dev) publicPath untouched", async () => {
+ setRuntimePublicPath("http://localhost:8080/app/dist/");
+ setInstanceUrl("https://mb.example.com");
+
+ await loadModule();
+
+ expect(getRuntimePublicPath()).toBe("http://localhost:8080/app/dist/");
+ });
+
+ it("does nothing when no instance URL is available", async () => {
+ setRuntimePublicPath("app/dist/");
+ setInstanceUrl(undefined);
+
+ await loadModule();
+
+ expect(getRuntimePublicPath()).toBe("app/dist/");
+ });
+});
diff --git a/frontend/src/metabase/app-embed-mcp.tsx b/frontend/src/metabase/app-embed-mcp.tsx
index adc44abdb11..1083fa53491 100644
--- a/frontend/src/metabase/app-embed-mcp.tsx
+++ b/frontend/src/metabase/app-embed-mcp.tsx
@@ -1,3 +1,7 @@
+// Must run before any dynamic import(): sets webpack's runtime publicPath so
+// on-demand chunks (leaflet, echarts) resolve to the Metabase instance.
+import "./app-embed-mcp-public-path";
+
import { createRoot } from "react-dom/client";
// Import the embedding SDK vendors side-effects (sets up global CSS vars, etc.)