The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Don't fail on unknown settings when calling set-many (#70282)
Nathan Voxlandbbc00a8677a6
diff --git a/src/metabase/settings/models/setting.clj b/src/metabase/settings/models/setting.cljindex 3e3e5f5ea71..12ac043e11b 100644--- a/src/metabase/settings/models/setting.clj+++ b/src/metabase/settings/models/setting.clj@@ -1402,7 +1402,9 @@(try(t2/with-transaction [_conn](doseq [[k v] settings]- (metabase.settings.models.setting/set! k v)))+ (if (registered? k)+ (metabase.settings.models.setting/set! k v)+ (log/infof "Skipping unregistered setting: %s" (name k)))))settings(catch Throwable e(setting.cache/restore-cache!)diff --git a/test/metabase/settings/models/setting_test.clj b/test/metabase/settings/models/setting_test.cljindex c6dbdc83d2a..a76c7ad4c0d 100644--- a/test/metabase/settings/models/setting_test.clj+++ b/test/metabase/settings/models/setting_test.clj@@ -302,6 +302,13 @@(is (= "For realz"(db-fetch-setting :test-setting-2))))+ (testing "unregistered settings should be silently skipped"+ (setting/set-many! {:test-setting-1 "known value"+ :totally-fake-setting "unknown value"})+ (is (= "known value"+ (db-fetch-setting :test-setting-1)))+ (is (not (setting/registered? :totally-fake-setting))))+(testing "if one change fails, the entire set of changes should be reverted"(mt/with-temporary-setting-values [test-setting-1 "123"test-setting-2 "123"]