Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

GDGT-2770 RFC 147. Require justification for type casts (#77168)

Kamil Mielnikbd2df5059be0
diff --git a/e2e/runner/embedding-sdk/host-apps/start-ci.ts b/e2e/runner/embedding-sdk/host-apps/start-ci.ts
index 2395b243f0c..1df4c65bfc8 100644
--- a/e2e/runner/embedding-sdk/host-apps/start-ci.ts
+++ b/e2e/runner/embedding-sdk/host-apps/start-ci.ts
@@ -1,6 +1,7 @@
import { startHostAppContainers } from "./start-host-app-containers";
import type { HostAppTestSuiteName } from "./types";
+// Unjustified type cast. FIXME
const testSuite = process.argv?.[2]?.trim() as HostAppTestSuiteName;
if (!testSuite) {
diff --git a/e2e/runner/embedding-sdk/sample-apps/start-ci.ts b/e2e/runner/embedding-sdk/sample-apps/start-ci.ts
index a6ffb5d4e33..f51efbbd184 100644
--- a/e2e/runner/embedding-sdk/sample-apps/start-ci.ts
+++ b/e2e/runner/embedding-sdk/sample-apps/start-ci.ts
@@ -1,6 +1,7 @@
import { startSampleAppContainers } from "./start-sample-app-containers";
import type { SampleAppTestSuiteName } from "./types";
+// Unjustified type cast. FIXME
const testSuite = process.argv?.[2]?.trim() as SampleAppTestSuiteName;
if (!testSuite) {
diff --git a/e2e/runner/embedding-sdk/sample-apps/start-sample-app-containers.ts b/e2e/runner/embedding-sdk/sample-apps/start-sample-app-containers.ts
index ad06105d503..279786a9c17 100644
--- a/e2e/runner/embedding-sdk/sample-apps/start-sample-app-containers.ts
+++ b/e2e/runner/embedding-sdk/sample-apps/start-sample-app-containers.ts
@@ -28,6 +28,7 @@ export async function startSampleAppContainers(
testSuite: SampleAppTestSuiteName,
) {
const embeddingSdkVersion =
+ // Unjustified type cast. FIXME
userOptions.EMBEDDING_SDK_VERSION as EmbeddingSdkVersion;
const setupConfig = SAMPLE_APP_SETUP_CONFIGS[testSuite];
diff --git a/e2e/support/ci_conductor.unit.spec.ts b/e2e/support/ci_conductor.unit.spec.ts
index f0add6a63f7..07e24a18dfc 100644
--- a/e2e/support/ci_conductor.unit.spec.ts
+++ b/e2e/support/ci_conductor.unit.spec.ts
@@ -51,6 +51,7 @@ const spec = {
const makeResults = (
overrides: Partial<CypressCommandLine.RunResult>,
): CypressCommandLine.RunResult =>
+ // Unjustified type cast. FIXME
({
error: null,
tests: [],
@@ -76,6 +77,7 @@ const test = (
// Build a `results.screenshots`-shaped array from bare paths (the only field we
// read). Cypress leaves `name` null for automatic failure shots.
const screenshotsFromPaths = (...paths: string[]) =>
+ // Unjustified type cast. FIXME
paths.map((path) => ({
path,
})) as unknown as CypressCommandLine.RunResult["screenshots"];
@@ -534,6 +536,7 @@ describe("reportFailedTestsToConductor", () => {
reportFailedTestsToConductor(oneTest),
).resolves.toBeUndefined();
expect(console.error).toHaveBeenCalled();
+ // Unjustified type cast. FIXME
(console.error as jest.Mock).mockRestore();
});
@@ -585,6 +588,7 @@ describe("reportFailedTestsToConductor", () => {
await reportFailedTestsToConductor(oneTest);
expect(console.error).toHaveBeenCalledWith(expect.stringContaining("500"));
+ // Unjustified type cast. FIXME
(console.error as jest.Mock).mockRestore();
});
@@ -648,6 +652,7 @@ describe("reportFailedTestsToConductor", () => {
reportFailedTestsToConductor(oneTest),
).resolves.toBeUndefined();
expect(console.error).toHaveBeenCalled();
+ // Unjustified type cast. FIXME
(console.error as jest.Mock).mockRestore();
});
});
@@ -738,6 +743,7 @@ describe("recordFailedTestsForQuarantine", () => {
jest.spyOn(console, "error").mockImplementation(() => {});
expect(() =>
+ // Unjustified type cast. FIXME
recordFailedTestsForQuarantine([
{
name: "n",
@@ -749,6 +755,7 @@ describe("recordFailedTestsForQuarantine", () => {
] as Parameters<typeof recordFailedTestsForQuarantine>[0]),
).not.toThrow();
+ // Unjustified type cast. FIXME
(console.error as jest.Mock).mockRestore();
});
});
diff --git a/e2e/support/commands/ui/paste.ts b/e2e/support/commands/ui/paste.ts
index 6a4fc5b8ca0..d46b5cee257 100644
--- a/e2e/support/commands/ui/paste.ts
+++ b/e2e/support/commands/ui/paste.ts
@@ -6,6 +6,7 @@ const nodes = {
function getPrototype(
node: string,
): (typeof nodes)[keyof typeof nodes] | undefined {
+ // Unjustified type cast. FIXME
return nodes[node as keyof typeof nodes];
}
diff --git a/e2e/support/fix-junit-hooks.ts b/e2e/support/fix-junit-hooks.ts
index 0818947ce30..688688b1c4e 100755
--- a/e2e/support/fix-junit-hooks.ts
+++ b/e2e/support/fix-junit-hooks.ts
@@ -67,10 +67,12 @@ program
"--include <substring>",
"only rewrite when the Root Suite's spec file path contains this substring (repeatable)",
(value: string, previous: string[]) => previous.concat([value]),
+ // Unjustified type cast. FIXME
[] as string[],
)
.parse();
+// Unjustified type cast. FIXME
const [inDir, outDir = inDir] = program.processedArgs as [string, string?];
const { dryRun = false, include: includes } = program.opts<Options>();
@@ -138,6 +140,7 @@ function findSpecFile(node: unknown): string | null {
if (!node || typeof node !== "object") {
return null;
}
+ // Unjustified type cast. FIXME
const file = (node as Record<string, unknown>)["@_file"];
if (typeof file === "string") {
return file;
diff --git a/e2e/support/helpers/api/customVizPlugin.ts b/e2e/support/helpers/api/customVizPlugin.ts
index 91a115bd428..fe7c1c61d1e 100644
--- a/e2e/support/helpers/api/customVizPlugin.ts
+++ b/e2e/support/helpers/api/customVizPlugin.ts
@@ -42,6 +42,7 @@ export function addCustomVizPlugin(
);
throw new Error(`upload failed (${status}): ${text}`);
}
+ // Unjustified type cast. FIXME
return JSON.parse(text) as CustomVizPlugin;
});
}
diff --git a/e2e/support/helpers/e2e-dashboard-helpers.ts b/e2e/support/helpers/e2e-dashboard-helpers.ts
index ae429581ead..62a9ead12e6 100644
--- a/e2e/support/helpers/e2e-dashboard-helpers.ts
+++ b/e2e/support/helpers/e2e-dashboard-helpers.ts
@@ -509,6 +509,7 @@ export function dashboardParametersDoneButton() {
}
export function dashboardParametersPopover() {
+ // Unjustified type cast. FIXME
return popover({ testId: "parameter-value-dropdown" } as any);
}
diff --git a/e2e/support/helpers/e2e-embedding-iframe-interactive-helpers.ts b/e2e/support/helpers/e2e-embedding-iframe-interactive-helpers.ts
index f99c7b982cd..aa5fbb12d8f 100644
--- a/e2e/support/helpers/e2e-embedding-iframe-interactive-helpers.ts
+++ b/e2e/support/helpers/e2e-embedding-iframe-interactive-helpers.ts
@@ -51,6 +51,7 @@ export function postMessageToIframe(options: PostMessageOptions) {
cy.get(iframeSelector)
.should("be.visible")
.then(($iframe) => {
+ // Unjustified type cast. FIXME
const iframeEl = $iframe[0] as HTMLIFrameElement;
// Get the actual parent window from the iframe's perspective
const actualParent = iframeEl.ownerDocument.defaultView;
diff --git a/e2e/support/helpers/e2e-remote-sync-helpers.ts b/e2e/support/helpers/e2e-remote-sync-helpers.ts
index 2bc4d443353..4c43cda3eb1 100644
--- a/e2e/support/helpers/e2e-remote-sync-helpers.ts
+++ b/e2e/support/helpers/e2e-remote-sync-helpers.ts
@@ -127,6 +127,7 @@ export const wrapSyncedCollectionFiles = (alias = "syncedCollectionFiles") => {
stashChanges();
cy.task("readDirectory", LOCAL_GIT_PATH).then((files) => {
cy.wrap(
+ // Unjustified type cast. FIXME
(files as string[]).filter(
(file: string) => !file.includes(".git") && file.includes(".yaml"),
),
@@ -164,6 +165,7 @@ export const updateRemoteQuestion = (
) => {
wrapSyncedCollectionFiles();
cy.get("@syncedCollectionFiles").then((syncedCollectionFiles) => {
+ // Unjustified type cast. FIXME
const questionFilePath = (
syncedCollectionFiles as unknown as string[]
).find((file) => file.includes("remote_sync_test_question.yaml"));
@@ -171,6 +173,7 @@ export const updateRemoteQuestion = (
const fullPath = `${LOCAL_GIT_PATH}/${questionFilePath}`;
cy.readFile(fullPath).then((str) => {
+ // Unjustified type cast. FIXME
const doc = yaml.load(str) as Record<string, unknown>;
assertionsFn?.(doc);
diff --git a/e2e/test-component/scenarios/embedding-sdk/analytics-component-events.cy.spec.tsx b/e2e/test-component/scenarios/embedding-sdk/analytics-component-events.cy.spec.tsx
index bbb5587432b..361afe409b5 100644
--- a/e2e/test-component/scenarios/embedding-sdk/analytics-component-events.cy.spec.tsx
+++ b/e2e/test-component/scenarios/embedding-sdk/analytics-component-events.cy.spec.tsx
@@ -29,22 +29,29 @@ type SdkEventData = {
const sdkEventsFromProxyBody = (body: unknown): SdkEventData[] => {
const rows =
+ // Unjustified type cast. FIXME
body && Array.isArray((body as { data?: unknown[] }).data)
- ? (body as { data: Array<{ ue_pr?: string }> }).data
+ ? // Unjustified type cast. FIXME
+ (body as { data: Array<{ ue_pr?: string }> }).data
: [];
- return rows
- .map((row) => {
- try {
- return JSON.parse(row.ue_pr ?? "");
- } catch {
- return null;
- }
- })
- .filter(Boolean)
- .map((unstruct) => unstruct.data) // unstruct_event -> { schema, data }
- .filter((selfDescribing) => selfDescribing?.schema === SIMPLE_EVENT_SCHEMA)
- .map((selfDescribing) => selfDescribing.data as SdkEventData);
+ return (
+ rows
+ .map((row) => {
+ try {
+ return JSON.parse(row.ue_pr ?? "");
+ } catch {
+ return null;
+ }
+ })
+ .filter(Boolean)
+ .map((unstruct) => unstruct.data) // unstruct_event -> { schema, data }
+ .filter(
+ (selfDescribing) => selfDescribing?.schema === SIMPLE_EVENT_SCHEMA,
+ )
+ // Unjustified type cast. FIXME
+ .map((selfDescribing) => selfDescribing.data as SdkEventData)
+ );
};
const parseEventDetail = (event: SdkEventData) => {
diff --git a/e2e/test-component/scenarios/embedding-sdk/content-translations.cy.spec.tsx b/e2e/test-component/scenarios/embedding-sdk/content-translations.cy.spec.tsx
index f54fd0c7c1d..275b0790dac 100644
--- a/e2e/test-component/scenarios/embedding-sdk/content-translations.cy.spec.tsx
+++ b/e2e/test-component/scenarios/embedding-sdk/content-translations.cy.spec.tsx
@@ -856,6 +856,7 @@ describe("scenarios > embedding-sdk > content-translations", () => {
mountSdkContent(
<div style={{ display: "flex", padding: "20px" }}>
<CollectionBrowser
+ // Unjustified type cast. FIXME
collectionId={collectionId as unknown as number}
visibleColumns={["type", "name", "description"]}
/>
diff --git a/e2e/test-component/scenarios/embedding-sdk/dashboard-click-behavior.cy.spec.tsx b/e2e/test-component/scenarios/embedding-sdk/dashboard-click-behavior.cy.spec.tsx
index 08634e28e99..7d250372124 100644
--- a/e2e/test-component/scenarios/embedding-sdk/dashboard-click-behavior.cy.spec.tsx
+++ b/e2e/test-component/scenarios/embedding-sdk/dashboard-click-behavior.cy.spec.tsx
@@ -424,6 +424,7 @@ const expectClickBehaviorForUrl = (url: string) => {
expect(spy.callCount).to.be.greaterThan(0);
const last = spy.getCalls().at(-1);
expect(last?.thisValue.target).to.eq("_blank");
+ // Unjustified type cast. FIXME
const href = (last?.thisValue as HTMLAnchorElement).href;
const u = new URL(href);
expect(`${u.origin}${u.pathname}`).to.eq(url);
diff --git a/e2e/test-component/scenarios/embedding-sdk/guest-embed-content-translations.cy.spec.tsx b/e2e/test-component/scenarios/embedding-sdk/guest-embed-content-translations.cy.spec.tsx
index 4ab17721b75..03e6eb46106 100644
--- a/e2e/test-component/scenarios/embedding-sdk/guest-embed-content-translations.cy.spec.tsx
+++ b/e2e/test-component/scenarios/embedding-sdk/guest-embed-content-translations.cy.spec.tsx
@@ -56,6 +56,7 @@ describe("scenarios > embedding-sdk > guest-embed-content-translations", () => {
cy.get("@questionId").then(async (questionId) => {
const token = await getSignedJwtForResource({
+ // Unjustified type cast. FIXME
resourceId: questionId as unknown as number,
resourceType: "question",
});
diff --git a/e2e/test-component/scenarios/embedding-sdk/guest-embed-error-handling.cy.spec.tsx b/e2e/test-component/scenarios/embedding-sdk/guest-embed-error-handling.cy.spec.tsx
index cf8e33569a1..d5e7d9dc9c6 100644
--- a/e2e/test-component/scenarios/embedding-sdk/guest-embed-error-handling.cy.spec.tsx
+++ b/e2e/test-component/scenarios/embedding-sdk/guest-embed-error-handling.cy.spec.tsx
@@ -58,6 +58,7 @@ describe("scenarios > embedding-sdk > guest-embed-error-handling", () => {
cy.signOut();
const token = await getSignedJwtForResource({
+ // Unjustified type cast. FIXME
resourceId: questionId as unknown as number,
resourceType: "question",
});
diff --git a/e2e/test-component/scenarios/embedding-sdk/guest-embed-happy-path.cy.spec.tsx b/e2e/test-component/scenarios/embedding-sdk/guest-embed-happy-path.cy.spec.tsx
index 867d48a5d7c..51e7de8b57d 100644
--- a/e2e/test-component/scenarios/embedding-sdk/guest-embed-happy-path.cy.spec.tsx
+++ b/e2e/test-component/scenarios/embedding-sdk/guest-embed-happy-path.cy.spec.tsx
@@ -63,6 +63,7 @@ describe("scenarios > embedding-sdk > guest-embed-happy-path", () => {
cy.get("@questionId").then(async (questionId) => {
const token = await getSignedJwtForResource({
+ // Unjustified type cast. FIXME
resourceId: questionId as unknown as number,
resourceType: "question",
});
@@ -87,6 +88,7 @@ describe("scenarios > embedding-sdk > guest-embed-happy-path", () => {
cy.get("@questionId").then(async (questionId) => {
const token = await getSignedJwtForResource({
+ // Unjustified type cast. FIXME
resourceId: questionId as unknown as number,
resourceType: "question",
});
@@ -115,6 +117,7 @@ describe("scenarios > embedding-sdk > guest-embed-happy-path", () => {
setup({
createQuestionOverride: () => {
createNativeQuestion(
+ // Unjustified type cast. FIXME
questionAsPinMapWithTiles as NativeQuestionDetails,
{
wrapId: true,
@@ -127,6 +130,7 @@ describe("scenarios > embedding-sdk > guest-embed-happy-path", () => {
cy.get("@questionId").then(async (questionId) => {
const token = await getSignedJwtForResource({
+ // Unjustified type cast. FIXME
resourceId: questionId as unknown as number,
resourceType: "question",
});
@@ -192,6 +196,7 @@ describe("scenarios > embedding-sdk > guest-embed-happy-path", () => {
cy.get("@dashboardId").then(async (dashboardId) => {
const token = await getSignedJwtForResource({
+ // Unjustified type cast. FIXME
resourceId: dashboardId as unknown as number,
resourceType: "dashboard",
});
@@ -220,6 +225,7 @@ describe("scenarios > embedding-sdk > guest-embed-happy-path", () => {
cy.get("@dashboardId").then(async (dashboardId) => {
const token = await getSignedJwtForResource({
+ // Unjustified type cast. FIXME
resourceId: dashboardId as unknown as number,
resourceType: "dashboard",
});
@@ -241,6 +247,7 @@ describe("scenarios > embedding-sdk > guest-embed-happy-path", () => {
it("should show content of a question with `map` type with tiles for unauthorized user", () => {
setup({
+ // Unjustified type cast. FIXME
questionDetails: {
...questionAsPinMapWithTiles,
query: {
@@ -255,6 +262,7 @@ describe("scenarios > embedding-sdk > guest-embed-happy-path", () => {
cy.get("@dashboardId").then(async (dashboardId) => {
const token = await getSignedJwtForResource({
+ // Unjustified type cast. FIXME
resourceId: dashboardId as unknown as number,
resourceType: "dashboard",
});
diff --git a/e2e/test-component/scenarios/embedding-sdk/guest-embed-parameters.cy.spec.tsx b/e2e/test-component/scenarios/embedding-sdk/guest-embed-parameters.cy.spec.tsx
index b37c03abbcf..4e3c4edbff4 100644
--- a/e2e/test-component/scenarios/embedding-sdk/guest-embed-parameters.cy.spec.tsx
+++ b/e2e/test-component/scenarios/embedding-sdk/guest-embed-parameters.cy.spec.tsx
@@ -106,6 +106,7 @@ describe("scenarios > embedding-sdk > guest-embed-parameters", () => {
cy.get("@questionId").then(async (questionId) => {
const token = await getSignedJwtForResource({
+ // Unjustified type cast. FIXME
resourceId: questionId as unknown as number,
resourceType: "question",
params: {
@@ -215,6 +216,7 @@ describe("scenarios > embedding-sdk > guest-embed-parameters", () => {
cy.get("@questionId").then(async (questionId) => {
const token = await getSignedJwtForResource({
+ // Unjustified type cast. FIXME
resourceId: questionId as unknown as number,
resourceType: "question",
});
@@ -357,6 +359,7 @@ describe("scenarios > embedding-sdk > guest-embed-parameters", () => {
cy.get("@questionId").then(async (questionId) => {
const token = await getSignedJwtForResource({
+ // Unjustified type cast. FIXME
resourceId: questionId as unknown as number,
resourceType: "question",
});
@@ -450,6 +453,7 @@ describe("scenarios > embedding-sdk > guest-embed-parameters", () => {
cy.get("@questionId").then(async (questionId) => {
const token = await getSignedJwtForResource({
+ // Unjustified type cast. FIXME
resourceId: questionId as unknown as number,
resourceType: "question",
params: {
@@ -551,6 +555,7 @@ describe("scenarios > embedding-sdk > guest-embed-parameters", () => {
cy.get("@dashboardId").then(async (dashboardId) => {
const token = await getSignedJwtForResource({
+ // Unjustified type cast. FIXME
resourceId: dashboardId as unknown as number,
resourceType: "dashboard",
params: {
@@ -677,6 +682,7 @@ describe("scenarios > embedding-sdk > guest-embed-parameters", () => {
cy.get("@dashboardId").then(async (dashboardId) => {
const token = await getSignedJwtForResource({
+ // Unjustified type cast. FIXME
resourceId: dashboardId as unknown as number,
resourceType: "dashboard",
});
@@ -845,6 +851,7 @@ describe("scenarios > embedding-sdk > guest-embed-parameters", () => {
cy.get("@dashboardId").then(async (dashboardId) => {
const token = await getSignedJwtForResource({
+ // Unjustified type cast. FIXME
resourceId: dashboardId as unknown as number,
resourceType: "dashboard",
});
@@ -966,6 +973,7 @@ describe("scenarios > embedding-sdk > guest-embed-parameters", () => {
cy.get("@dashboardId").then(async (dashboardId) => {
const token = await getSignedJwtForResource({
+ // Unjustified type cast. FIXME
resourceId: dashboardId as unknown as number,
resourceType: "dashboard",
params: {
diff --git a/e2e/test-component/scenarios/embedding-sdk/guest-embed-reproductions.cy.spec.tsx b/e2e/test-component/scenarios/embedding-sdk/guest-embed-reproductions.cy.spec.tsx
index 3a390ebea66..c919ac95e20 100644
--- a/e2e/test-component/scenarios/embedding-sdk/guest-embed-reproductions.cy.spec.tsx
+++ b/e2e/test-component/scenarios/embedding-sdk/guest-embed-reproductions.cy.spec.tsx
@@ -47,6 +47,7 @@ describe("scenarios > embedding-sdk > guest-embed reproductions", () => {
cy.get("@questionId").then(async (questionId) => {
const token = await getSignedJwtForResource({
+ // Unjustified type cast. FIXME
resourceId: questionId as unknown as number,
resourceType: "question",
});
@@ -80,6 +81,7 @@ describe("scenarios > embedding-sdk > guest-embed reproductions", () => {
cy.get("@questionEntityId").then(async (questionEntityId) => {
const token = await getSignedJwtForResource({
+ // Unjustified type cast. FIXME
resourceId: questionEntityId as unknown as number,
resourceType: "question",
});
@@ -137,6 +139,7 @@ describe("scenarios > embedding-sdk > guest-embed reproductions", () => {
cy.get("@questionId").then(async (questionId) => {
const token = await getSignedJwtForResource({
+ // Unjustified type cast. FIXME
resourceId: questionId as unknown as number,
resourceType: "question",
});
diff --git a/e2e/test-component/scenarios/embedding-sdk/guest-embed-theming.cy.spec.tsx b/e2e/test-component/scenarios/embedding-sdk/guest-embed-theming.cy.spec.tsx
index 2dfe68cfe8b..e46459c19e4 100644
--- a/e2e/test-component/scenarios/embedding-sdk/guest-embed-theming.cy.spec.tsx
+++ b/e2e/test-component/scenarios/embedding-sdk/guest-embed-theming.cy.spec.tsx
@@ -45,6 +45,7 @@ describe("scenarios > embedding-sdk > guest-embed-theming", () => {
cy.get("@questionId").then(async (questionId) => {
const token = await getSignedJwtForResource({
+ // Unjustified type cast. FIXME
resourceId: questionId as unknown as number,
resourceType: "question",
});
diff --git a/e2e/test-component/scenarios/embedding-sdk/loading-performance.cy.spec.tsx b/e2e/test-component/scenarios/embedding-sdk/loading-performance.cy.spec.tsx
index 5aa367ffd73..9b09dd6be55 100644
--- a/e2e/test-component/scenarios/embedding-sdk/loading-performance.cy.spec.tsx
+++ b/e2e/test-component/scenarios/embedding-sdk/loading-performance.cy.spec.tsx
@@ -21,12 +21,16 @@ const { H } = cy;
const sdkBundleCleanup = () => {
getSdkBundleScriptElement()?.remove();
+ // Unjustified type cast. FIXME
delete (window as any).METABASE_EMBEDDING_SDK_BUNDLE;
+ // Unjustified type cast. FIXME
delete (window as any).METABASE_PROVIDER_PROPS_STORE;
+ // Unjustified type cast. FIXME
delete (window as any).METABASE_EMBEDDING_SDK_AUTH_STATE;
// Clean up webpack chunk registries so stale runtimes from a previous test
// don't interfere with chunks loaded by the next test.
delete (window as any).webpackChunkembedding_sdk_bundle;
+ // Unjustified type cast. FIXME
delete (window as any).webpackChunkembedding_sdk_legacy;
deleteConflictingCljsGlobals();
};
@@ -286,6 +290,7 @@ describe(
// `window`, but its state should be back to initial (no props, no
// redux store).
cy.window().should((win) => {
+ // Unjustified type cast. FIXME
const store = (win as any).METABASE_PROVIDER_PROPS_STORE;
expect(store, "store singleton persists").to.exist;
const state = store.getState();
diff --git a/e2e/test-component/scenarios/embedding-sdk/sdk-bundle.cy.spec.tsx b/e2e/test-component/scenarios/embedding-sdk/sdk-bundle.cy.spec.tsx
index d61fee8dc23..df90c97a2fe 100644
--- a/e2e/test-component/scenarios/embedding-sdk/sdk-bundle.cy.spec.tsx
+++ b/e2e/test-component/scenarios/embedding-sdk/sdk-bundle.cy.spec.tsx
@@ -27,6 +27,7 @@ const sdkBundleCleanup = () => {
// helper to assert the post-unmount shape.
const assertPropsStoreReset = () => {
cy.window().should((win) => {
+ // Unjustified type cast. FIXME
const store = (win as any).METABASE_PROVIDER_PROPS_STORE;
expect(store, "store singleton persists").to.exist;
const state = store.getState();
diff --git a/e2e/test-component/scenarios/embedding-sdk/touch-chart-drill.cy.spec.tsx b/e2e/test-component/scenarios/embedding-sdk/touch-chart-drill.cy.spec.tsx
index 060550035ac..09c5ff76000 100644
--- a/e2e/test-component/scenarios/embedding-sdk/touch-chart-drill.cy.spec.tsx
+++ b/e2e/test-component/scenarios/embedding-sdk/touch-chart-drill.cy.spec.tsx
@@ -98,6 +98,7 @@ describe("scenarios > embedding-sdk > touch chart drill popover", () => {
cy.window().then((win) => {
if (!("ontouchstart" in win)) {
+ // Unjustified type cast. FIXME
(win as any).ontouchstart = null;
}
});
diff --git a/e2e/test/scenarios/admin/database-routing/database-routing-usage.cy.spec.ts b/e2e/test/scenarios/admin/database-routing/database-routing-usage.cy.spec.ts
index 72b934bfafb..b6fd6130dfb 100644
--- a/e2e/test/scenarios/admin/database-routing/database-routing-usage.cy.spec.ts
+++ b/e2e/test/scenarios/admin/database-routing/database-routing-usage.cy.spec.ts
@@ -98,6 +98,7 @@ describe("admin > database > database routing", { tags: ["@external"] }, () => {
});
beforeEach(() => {
+ // Unjustified type cast. FIXME
H.restore("db-routing-3-dbs" as any);
cy.signInAsAdmin();
});
diff --git a/e2e/test/scenarios/admin/i18n/content-translation/dashboards.cy.spec.ts b/e2e/test/scenarios/admin/i18n/content-translation/dashboards.cy.spec.ts
index bd26c869c6d..a9fa9deb2f1 100644
--- a/e2e/test/scenarios/admin/i18n/content-translation/dashboards.cy.spec.ts
+++ b/e2e/test/scenarios/admin/i18n/content-translation/dashboards.cy.spec.ts
@@ -93,6 +93,7 @@ describe("scenarios > content translation > static embeds > dashboards", () => {
H.visitEmbeddedPage(
{
+ // Unjustified type cast. FIXME
resource: { dashboard: dashboardId as number },
params: {},
},
@@ -176,6 +177,7 @@ describe("scenarios > content translation > static embeds > dashboards", () => {
H.visitEmbeddedPage(
{
+ // Unjustified type cast. FIXME
resource: { dashboard: dashboardId as number },
params: {},
},
@@ -273,6 +275,7 @@ describe("scenarios > content translation > static embeds > dashboards", () => {
H.visitEmbeddedPage(
{
+ // Unjustified type cast. FIXME
resource: { dashboard: dashboardId as number },
params: {},
},
@@ -391,6 +394,7 @@ describe("scenarios > content translation > static embeds > dashboards", () => {
cy.intercept("GET", "/api/embed/dashboard/*").as("dashboard");
cy.intercept("GET", "/api/embed/dashboard/**/card/*").as("cardQuery");
cy.intercept("GET", "/api/embed/dashboard/**/search/*").as("searchQuery");
+ // Unjustified type cast. FIXME
H.restore("with-translations" as any);
});
@@ -408,6 +412,7 @@ describe("scenarios > content translation > static embeds > dashboards", () => {
display: "pivot",
visualization_settings: {
"pivot_table.column_split": {
+ // Unjustified type cast. FIXME
rows: [ORDERS.CREATED_AT, ORDERS.QUANTITY] as any,
columns: [],
values: ["count"],
@@ -430,6 +435,7 @@ describe("scenarios > content translation > static embeds > dashboards", () => {
}).then(({ body: { dashboard_id } }) => {
H.visitEmbeddedPage(
{
+ // Unjustified type cast. FIXME
resource: { dashboard: dashboard_id as number },
params: {},
},
@@ -476,6 +482,7 @@ describe("scenarios > content translation > static embeds > dashboards", () => {
cy.intercept("GET", "/api/embed/dashboard/**/search/*").as(
"searchQuery",
);
+ // Unjustified type cast. FIXME
H.restore("with-translations" as any);
});
@@ -531,6 +538,7 @@ describe("scenarios > content translation > static embeds > dashboards", () => {
});
H.visitEmbeddedPage(
{
+ // Unjustified type cast. FIXME
resource: { dashboard: dashboard_id as number },
params: {},
},
@@ -669,6 +677,7 @@ describe("scenarios > content translation > static embeds > dashboards", () => {
});
H.visitEmbeddedPage(
{
+ // Unjustified type cast. FIXME
resource: { dashboard: dashboard_id as number },
params: {},
},
@@ -748,6 +757,7 @@ describe("scenarios > content translation > static embeds > dashboards", () => {
});
H.visitEmbeddedPage(
{
+ // Unjustified type cast. FIXME
resource: { dashboard: dashboard_id as number },
params: {},
},
@@ -831,6 +841,7 @@ describe("scenarios > content translation > static embeds > dashboards", () => {
},
},
dashboardDetails: {
+ // Unjustified type cast. FIXME
parameters: [staticListFilter as any], // current API isn't set to accept string[][] as values
enable_embedding: true,
embedding_params: {
@@ -867,6 +878,7 @@ describe("scenarios > content translation > static embeds > dashboards", () => {
H.visitEmbeddedPage(
{
+ // Unjustified type cast. FIXME
resource: { dashboard: dashboard_id as number },
params: {},
},
@@ -904,6 +916,7 @@ describe("scenarios > content translation > static embeds > dashboards", () => {
},
},
dashboardDetails: {
+ // Unjustified type cast. FIXME
parameters: [staticListFilter as any], // current API isn't set to accept string[][] as values
enable_embedding: true,
embedding_params: {
@@ -940,6 +953,7 @@ describe("scenarios > content translation > static embeds > dashboards", () => {
H.visitEmbeddedPage(
{
+ // Unjustified type cast. FIXME
resource: { dashboard: dashboard_id as number },
params: {},
},
@@ -965,7 +979,9 @@ describe("scenarios > content translation > static embeds > dashboards", () => {
{ locale: "de", msgid: "Sample Text", msgstr: "Beispieltext" },
];
type VisitWithLocale = (options?: { locale?: string }) => void;
+ // Unjustified type cast. FIXME
let visitEmbeddedDashboard = null as unknown as VisitWithLocale,
+ // Unjustified type cast. FIXME
visitNormalDashboard = null as unknown as VisitWithLocale;
before(() => {
@@ -1005,6 +1021,7 @@ describe("scenarios > content translation > static embeds > dashboards", () => {
cy.intercept("POST", "api/ee/content-translation/upload-dictionary").as(
"uploadDictionary",
);
+ // Unjustified type cast. FIXME
H.restore("tab-names-and-text-cards" as any);
cy.signInAsAdmin();
visitEmbeddedDashboard = ({ locale = "de" } = {}) => {
@@ -1112,6 +1129,7 @@ describe("scenarios > content translation > static embeds > dashboards", () => {
H.publishChanges("dashboard", () => {});
H.visitEmbeddedPage(
{
+ // Unjustified type cast. FIXME
resource: { dashboard: dashboardId as number },
params: {},
},
diff --git a/e2e/test/scenarios/admin/i18n/content-translation/questions.cy.spec.ts b/e2e/test/scenarios/admin/i18n/content-translation/questions.cy.spec.ts
index eb8ae17df9e..27611430d64 100644
--- a/e2e/test/scenarios/admin/i18n/content-translation/questions.cy.spec.ts
+++ b/e2e/test/scenarios/admin/i18n/content-translation/questions.cy.spec.ts
@@ -16,6 +16,7 @@ describe("scenarios > content translation > guest embeds > questions", () => {
);
});
+ // Unjustified type cast. FIXME
let productsQuestionId = null as unknown as number;
before(() => {
@@ -41,6 +42,7 @@ describe("scenarios > content translation > guest embeds > questions", () => {
});
});
+ // Unjustified type cast. FIXME
let visitEmbeddedQuestion = null as unknown as ({
locale,
}: {
@@ -48,6 +50,7 @@ describe("scenarios > content translation > guest embeds > questions", () => {
}) => void;
beforeEach(() => {
+ // Unjustified type cast. FIXME
H.restore("snapshot-for-questions" as any);
visitEmbeddedQuestion = ({ locale }) => {
H.visitEmbeddedPage(
diff --git a/e2e/test/scenarios/admin/i18n/content-translation/upload-and-download.cy.spec.ts b/e2e/test/scenarios/admin/i18n/content-translation/upload-and-download.cy.spec.ts
index 8bd624fc449..2502a367bc2 100644
--- a/e2e/test/scenarios/admin/i18n/content-translation/upload-and-download.cy.spec.ts
+++ b/e2e/test/scenarios/admin/i18n/content-translation/upload-and-download.cy.spec.ts
@@ -48,6 +48,7 @@ describe("scenarios > admin > embedding > guest embeds> content translation", ()
"api/ee/content-translation/upload-dictionary",
cy.spy().as("uploadDictionarySpy"),
).as("uploadDictionary");
+ // Unjustified type cast. FIXME
H.restore("snapshot-for-upload-and-download" as any);
cy.signInAsAdmin();
});
diff --git a/e2e/test/scenarios/admin/oauth-authorizations.cy.spec.ts b/e2e/test/scenarios/admin/oauth-authorizations.cy.spec.ts
index 3fdf351935d..ffdb4e3edd3 100644
--- a/e2e/test/scenarios/admin/oauth-authorizations.cy.spec.ts
+++ b/e2e/test/scenarios/admin/oauth-authorizations.cy.spec.ts
@@ -88,13 +88,16 @@ function registerClient(
clientName: string,
extra: Record<string, unknown> = {},
) {
- return cy
- .request("POST", "/oauth/register", {
- client_name: clientName,
- redirect_uris: [REDIRECT_URI],
- ...extra,
- })
- .then(({ body }) => body as RegisteredClient);
+ return (
+ cy
+ .request("POST", "/oauth/register", {
+ client_name: clientName,
+ redirect_uris: [REDIRECT_URI],
+ ...extra,
+ })
+ // Unjustified type cast. FIXME
+ .then(({ body }) => body as RegisteredClient)
+ );
}
function approveClient(client: RegisteredClient) {
diff --git a/e2e/test/scenarios/admin/remote-sync.cy.spec.ts b/e2e/test/scenarios/admin/remote-sync.cy.spec.ts
index f0355725f82..0ab2a25acbe 100644
--- a/e2e/test/scenarios/admin/remote-sync.cy.spec.ts
+++ b/e2e/test/scenarios/admin/remote-sync.cy.spec.ts
@@ -39,6 +39,7 @@ describe("Remote Sync", () => {
query: {
"source-table": PRODUCTS_ID,
},
+ // Unjustified type cast. FIXME
collection_id: (syncedCollection as unknown as Collection).id,
});
});
diff --git a/e2e/test/scenarios/admin/tools/tools.cy.spec.ts b/e2e/test/scenarios/admin/tools/tools.cy.spec.ts
index 22d5db89d99..f7a41122dee 100644
--- a/e2e/test/scenarios/admin/tools/tools.cy.spec.ts
+++ b/e2e/test/scenarios/admin/tools/tools.cy.spec.ts
@@ -441,6 +441,7 @@ describe("admin > tools > erroring questions ", () => {
describe("with the existing broken questions", () => {
beforeEach(() => {
+ // Unjustified type cast. FIXME
H.createNativeQuestion(brokenQuestionDetails as NativeQuestionDetails, {
loadMetadata: true,
});
diff --git a/e2e/test/scenarios/custom-column/cc-fields.cy.spec.ts b/e2e/test/scenarios/custom-column/cc-fields.cy.spec.ts
index f5836f4a0c7..470b6df8a4b 100644
--- a/e2e/test/scenarios/custom-column/cc-fields.cy.spec.ts
+++ b/e2e/test/scenarios/custom-column/cc-fields.cy.spec.ts
@@ -32,6 +32,7 @@ describe("scenarios > custom column > field resolution", () => {
Object.entries(QUESTION.query.expressions ?? []).forEach(
([name, expression]) => {
+ // Unjustified type cast. FIXME
const str = (expression as ["value", string])[1];
H.getNotebookStep("expression").icon("add").click();
diff --git a/e2e/test/scenarios/dashboard-filters-2/shared/dashboard-filters-query-stages.ts b/e2e/test/scenarios/dashboard-filters-2/shared/dashboard-filters-query-stages.ts
index 7775e8c1d57..182f46c4a96 100644
--- a/e2e/test/scenarios/dashboard-filters-2/shared/dashboard-filters-query-stages.ts
+++ b/e2e/test/scenarios/dashboard-filters-2/shared/dashboard-filters-query-stages.ts
@@ -3,6 +3,7 @@ import { SAMPLE_DATABASE } from "e2e/support/cypress_sample_database";
import type {
Card,
ConcreteFieldReference,
+ DashboardId,
StructuredQuery,
} from "metabase-types/api";
@@ -724,10 +725,8 @@ export function goBackToDashboard() {
cy.findByTestId("dashboard-grid").should("be.visible");
}
-export function getDashboardId(): Cypress.Chainable<number> {
- return cy
- .get("@dashboardId")
- .then((dashboardId) => dashboardId as unknown as number);
+export function getDashboardId(): Cypress.Chainable<DashboardId> {
+ return cy.get<DashboardId>("@dashboardId").then((dashboardId) => dashboardId);
}
export function waitForPublicDashboardData(requestCount: number) {
diff --git a/e2e/test/scenarios/dashboard/visualizer/basics.cy.spec.ts b/e2e/test/scenarios/dashboard/visualizer/basics.cy.spec.ts
index a0e4eef47fe..88873fc7782 100644
--- a/e2e/test/scenarios/dashboard/visualizer/basics.cy.spec.ts
+++ b/e2e/test/scenarios/dashboard/visualizer/basics.cy.spec.ts
@@ -143,6 +143,7 @@ describe("scenarios > dashboard > visualizer > basics", () => {
(ordersCountByCreatedAtQuestionId) => {
H.addQuestionToDashboard({
dashboardId: ORDERS_DASHBOARD_ID,
+ // Unjustified type cast. FIXME
cardId: ordersCountByCreatedAtQuestionId as any,
});
H.visitDashboard(ORDERS_DASHBOARD_ID);
@@ -390,6 +391,7 @@ describe("scenarios > dashboard > visualizer > basics", () => {
cy.get("@questionId").then((questionId) => {
H.addQuestionToDashboard({
dashboardId,
+ // Unjustified type cast. FIXME
cardId: questionId as any,
});
H.visitDashboard(dashboardId);
@@ -430,6 +432,7 @@ describe("scenarios > dashboard > visualizer > basics", () => {
cy.get("@questionWithDescriptionId").then((questionId) => {
H.addQuestionToDashboard({
dashboardId,
+ // Unjustified type cast. FIXME
cardId: questionId as any,
});
H.visitDashboard(dashboardId);
diff --git a/e2e/test/scenarios/dashboard/visualizer/reproductions.cy.spec.ts b/e2e/test/scenarios/dashboard/visualizer/reproductions.cy.spec.ts
index 32ece424c86..5b25af75a4f 100644
--- a/e2e/test/scenarios/dashboard/visualizer/reproductions.cy.spec.ts
+++ b/e2e/test/scenarios/dashboard/visualizer/reproductions.cy.spec.ts
@@ -131,10 +131,12 @@ describe("issue 61521", () => {
},
};
+ // Unjustified type cast. FIXME
H.createQuestion(questionBDetails as unknown as StructuredQuestionDetails);
H.createDashboard().then(({ body: { id: dashboardId } }) => {
H.createQuestionAndAddToDashboard(
+ // Unjustified type cast. FIXME
questionADetails as unknown as StructuredQuestionDetails,
dashboardId,
);
diff --git a/e2e/test/scenarios/data-studio/data-model/model-to-transform.cy.spec.ts b/e2e/test/scenarios/data-studio/data-model/model-to-transform.cy.spec.ts
index cf6a3cdb7b3..f4d9702034f 100644
--- a/e2e/test/scenarios/data-studio/data-model/model-to-transform.cy.spec.ts
+++ b/e2e/test/scenarios/data-studio/data-model/model-to-transform.cy.spec.ts
@@ -338,6 +338,7 @@ function openReplaceWithTransformModal() {
H.modal()
.findByLabelText("Table name")
.should(($input) => {
+ // Unjustified type cast. FIXME
expect(($input.val() as string).length).to.be.greaterThan(0);
});
}
diff --git a/e2e/test/scenarios/data-studio/data-studio-library.cy.spec.ts b/e2e/test/scenarios/data-studio/data-studio-library.cy.spec.ts
index bf7ed52a377..732638e4dd0 100644
--- a/e2e/test/scenarios/data-studio/data-studio-library.cy.spec.ts
+++ b/e2e/test/scenarios/data-studio/data-studio-library.cy.spec.ts
@@ -494,7 +494,9 @@ function getLibraryRootCollections(): Cypress.Chainable<LibraryRootCollections>
expect(metricCollection, "Metrics collection").to.exist;
return {
+ // Unjustified type cast. FIXME
dataCollection: dataCollection as Collection,
+ // Unjustified type cast. FIXME
metricCollection: metricCollection as Collection,
};
});
diff --git a/e2e/test/scenarios/data-studio/measures/measures-queries.cy.spec.ts b/e2e/test/scenarios/data-studio/measures/measures-queries.cy.spec.ts
index a9d0189c9fc..99dcf945f6d 100644
--- a/e2e/test/scenarios/data-studio/measures/measures-queries.cy.spec.ts
+++ b/e2e/test/scenarios/data-studio/measures/measures-queries.cy.spec.ts
@@ -853,6 +853,7 @@ function saveMeasure(): Cypress.Chainable<Measure> {
return cy.wait("@measureCreate").then(({ response }) => {
H.undoToast().should("contain.text", "Measure created");
+ // Unjustified type cast. FIXME
return cy.wrap(response?.body as Measure);
});
}
diff --git a/e2e/test/scenarios/dependencies/dependency-graph.cy.spec.ts b/e2e/test/scenarios/dependencies/dependency-graph.cy.spec.ts
index 09271329c34..1d4ec56bb36 100644
--- a/e2e/test/scenarios/dependencies/dependency-graph.cy.spec.ts
+++ b/e2e/test/scenarios/dependencies/dependency-graph.cy.spec.ts
@@ -135,6 +135,7 @@ describe("scenarios > dependencies > dependency graph", () => {
H.DependencyGraph.entrySearchInput().click();
H.popover().findByText("Browse all").click();
H.entityPickerModal().within(() => {
+ // Unjustified type cast. FIXME
cy.findByPlaceholderText(/Search/).type(itemName as string);
cy.findByText(/results for/).should("be.visible");
cy.findByTestId("search-scope-selector")
diff --git a/e2e/test/scenarios/documents/card-embed-node.cy.spec.ts b/e2e/test/scenarios/documents/card-embed-node.cy.spec.ts
index 92a5076ea07..b5de313a60c 100644
--- a/e2e/test/scenarios/documents/card-embed-node.cy.spec.ts
+++ b/e2e/test/scenarios/documents/card-embed-node.cy.spec.ts
@@ -152,7 +152,9 @@ describe("documents card embed node custom logic", () => {
cy.get("@ogWidth1").then((_first) => {
cy.get("@ogWidth2").then((_second) => {
cy.log("compare that changes are close to the drag distance");
+ // Unjustified type cast. FIXME
expect((_first as unknown as number) + 100).to.be.closeTo(first, 3);
+ // Unjustified type cast. FIXME
expect((_second as unknown as number) - 100).to.be.closeTo(
second,
3,
@@ -260,6 +262,7 @@ describe("documents card embed node custom logic", () => {
cy.wrap(second).as("_second");
cy.wrap(third).as("_third");
expect(first).to.be.closeTo(second, 10);
+ // Unjustified type cast. FIXME
expect(first).to.be.closeTo(third as unknown as number, 10);
});
@@ -273,8 +276,11 @@ describe("documents card embed node custom logic", () => {
cy.get("@_first").then((_first) => {
cy.get("@_second").then((_second) => {
cy.get("@_third").then((_third) => {
+ // Unjustified type cast. FIXME
expect(first).to.be.closeTo(_first as unknown as number, 3);
+ // Unjustified type cast. FIXME
expect(second).to.be.greaterThan(_second as unknown as number);
+ // Unjustified type cast. FIXME
expect(third).to.be.lessThan(_third as unknown as number);
});
});
@@ -791,12 +797,15 @@ function getCardWidths(
if (thirdCardName) {
H.getDocumentCard(thirdCardName).then((thirdCard) => {
cb(
+ // Unjustified type cast. FIXME
firstCard.width() as number,
+ // Unjustified type cast. FIXME
secondCard.width() as number,
thirdCard.width(),
);
});
} else {
+ // Unjustified type cast. FIXME
cb(firstCard.width() as number, secondCard.width() as number);
}
});
diff --git a/e2e/test/scenarios/documents/documents.cy.spec.ts b/e2e/test/scenarios/documents/documents.cy.spec.ts
index 43fa402eb12..bae8305dc1d 100644
--- a/e2e/test/scenarios/documents/documents.cy.spec.ts
+++ b/e2e/test/scenarios/documents/documents.cy.spec.ts
@@ -1005,6 +1005,7 @@ describe("documents", () => {
cy.log(`${ogHeight}, ${newHeight}`);
+ // Unjustified type cast. FIXME
expect(newHeight).to.be.lessThan(ogHeight as number);
});
});
diff --git a/e2e/test/scenarios/documents/supporting-text.cy.spec.ts b/e2e/test/scenarios/documents/supporting-text.cy.spec.ts
index 5ffa853f048..5cf0f1f94ac 100644
--- a/e2e/test/scenarios/documents/supporting-text.cy.spec.ts
+++ b/e2e/test/scenarios/documents/supporting-text.cy.spec.ts
@@ -323,10 +323,12 @@ describe("documents supporting text", () => {
H.documentContent()
.findByTestId("document-card-supporting-text")
.then(($supportingText) => {
+ // Unjustified type cast. FIXME
const initialSupportingTextWidth = $supportingText.width() as number;
cy.wrap(initialSupportingTextWidth).as("initialSupportingTextWidth");
H.getDocumentCard("Orders").then(($card) => {
+ // Unjustified type cast. FIXME
const initialCardWidth = $card.width() as number;
cy.wrap(initialCardWidth).as("initialCardWidth");
});
@@ -345,10 +347,12 @@ describe("documents supporting text", () => {
H.documentContent()
.findByTestId("document-card-supporting-text")
.then(($supportingText) => {
+ // Unjustified type cast. FIXME
const newSupportingTextWidth = $supportingText.width() as number;
cy.wrap(newSupportingTextWidth).as("newSupportingTextWidth");
H.getDocumentCard("Orders").then(($card) => {
+ // Unjustified type cast. FIXME
const newCardWidth = $card.width() as number;
cy.wrap(newCardWidth).as("newCardWidth");
@@ -413,9 +417,11 @@ describe("documents supporting text", () => {
H.documentContent()
.findByTestId("document-card-supporting-text")
.then(($supportingText) => {
+ // Unjustified type cast. FIXME
const reloadedSupportingTextWidth = $supportingText.width() as number;
H.getDocumentCard("Orders").then(($card) => {
+ // Unjustified type cast. FIXME
const reloadedCardWidth = $card.width() as number;
cy.get<number>("@newSupportingTextWidth").then((savedWidth) => {
diff --git a/e2e/test/scenarios/embedding/sdk-iframe-embedding/authentication.cy.spec.ts b/e2e/test/scenarios/embedding/sdk-iframe-embedding/authentication.cy.spec.ts
index 2d874dff15f..ab004897c11 100644
--- a/e2e/test/scenarios/embedding/sdk-iframe-embedding/authentication.cy.spec.ts
+++ b/e2e/test/scenarios/embedding/sdk-iframe-embedding/authentication.cy.spec.ts
@@ -217,7 +217,9 @@ describe("scenarios > embedding > sdk iframe embedding > authentication", () =>
const frame = H.loadSdkIframeEmbedTestPage({
onVisitPage: (win) => {
+ // Unjustified type cast. FIXME
(win as any).metabaseConfig = {
+ // Unjustified type cast. FIXME
...(win as any).metabaseConfig,
fetchRequestToken: async () => {
const jwt = await getSignedJwtForUser({ user: USERS.admin });
@@ -244,7 +246,9 @@ describe("scenarios > embedding > sdk iframe embedding > authentication", () =>
const frame = H.loadSdkIframeEmbedTestPage({
onVisitPage: (win) => {
+ // Unjustified type cast. FIXME
(win as any).metabaseConfig = {
+ // Unjustified type cast. FIXME
...(win as any).metabaseConfig,
fetchRequestToken: async () => {
return { jwt: "" };
diff --git a/e2e/test/scenarios/embedding/sdk-iframe-embedding/content-translations.cy.spec.ts b/e2e/test/scenarios/embedding/sdk-iframe-embedding/content-translations.cy.spec.ts
index 3846842722f..4c60ed9ef2d 100644
--- a/e2e/test/scenarios/embedding/sdk-iframe-embedding/content-translations.cy.spec.ts
+++ b/e2e/test/scenarios/embedding/sdk-iframe-embedding/content-translations.cy.spec.ts
@@ -182,6 +182,7 @@ describe("scenarios > embedding > sdk iframe embedding > content-translations",
cy.get("@questionId").then(async (questionId) => {
const token = await getSignedJwtForResource({
+ // Unjustified type cast. FIXME
resourceId: questionId as unknown as number,
resourceType: "question",
});
diff --git a/e2e/test/scenarios/embedding/sdk-iframe-embedding/eajs-internal-navigation.cy.spec.ts b/e2e/test/scenarios/embedding/sdk-iframe-embedding/eajs-internal-navigation.cy.spec.ts
index c12f40bb8a6..36fab324ce1 100644
--- a/e2e/test/scenarios/embedding/sdk-iframe-embedding/eajs-internal-navigation.cy.spec.ts
+++ b/e2e/test/scenarios/embedding/sdk-iframe-embedding/eajs-internal-navigation.cy.spec.ts
@@ -266,6 +266,7 @@ describe("scenarios > embedding > sdk iframe embedding > internal-navigation", (
cy.get("@startingDashboardId").then(async (dashboardId) => {
const token = await getSignedJwtForResource({
+ // Unjustified type cast. FIXME
resourceId: dashboardId as unknown as number,
resourceType: "dashboard",
});
diff --git a/e2e/test/scenarios/embedding/sdk-iframe-embedding/guest-embed.cy.spec.ts b/e2e/test/scenarios/embedding/sdk-iframe-embedding/guest-embed.cy.spec.ts
index ce79813cee6..f93bd369f07 100644
--- a/e2e/test/scenarios/embedding/sdk-iframe-embedding/guest-embed.cy.spec.ts
+++ b/e2e/test/scenarios/embedding/sdk-iframe-embedding/guest-embed.cy.spec.ts
@@ -35,6 +35,7 @@ describe(
it("shows a static question", () => {
cy.get("@questionId").then(async (questionId) => {
const token = await getSignedJwtForResource({
+ // Unjustified type cast. FIXME
resourceId: questionId as unknown as number,
resourceType: "question",
});
@@ -63,6 +64,7 @@ describe(
it("allows to download a static question as CSV", () => {
cy.get("@questionId").then(async (questionId) => {
const token = await getSignedJwtForResource({
+ // Unjustified type cast. FIXME
resourceId: questionId as unknown as number,
resourceType: "question",
});
diff --git a/e2e/test/scenarios/metabot/ai-controls.cy.spec.ts b/e2e/test/scenarios/metabot/ai-controls.cy.spec.ts
index e9ff464ca9a..d5bd69b4a37 100644
--- a/e2e/test/scenarios/metabot/ai-controls.cy.spec.ts
+++ b/e2e/test/scenarios/metabot/ai-controls.cy.spec.ts
@@ -469,6 +469,7 @@ describe("AI controls > AI usage limits", () => {
// Note: the membership API is keyed by user_id, with each entry
// containing a group_id property.
cy.request("GET", "/api/permissions/membership").then(({ body }) => {
+ // Unjustified type cast. FIXME
const memberships = body[String(NORMAL_USER_ID)] as
| Array<{ group_id: number }>
| undefined;
diff --git a/e2e/test/scenarios/metabot/mcp-apps-settings.cy.spec.ts b/e2e/test/scenarios/metabot/mcp-apps-settings.cy.spec.ts
index fc92930fe22..0b97467152a 100644
--- a/e2e/test/scenarios/metabot/mcp-apps-settings.cy.spec.ts
+++ b/e2e/test/scenarios/metabot/mcp-apps-settings.cy.spec.ts
@@ -30,6 +30,7 @@ describe("admin > MCP apps settings > Cursor install link", () => {
/^cursor:\/\/anysphere\.cursor-deeplink\/mcp\/install\?/,
);
+ // Unjustified type cast. FIXME
const query = (href as string).split("?", 2)[1];
const params = new URLSearchParams(query);
@@ -38,6 +39,7 @@ describe("admin > MCP apps settings > Cursor install link", () => {
expect(config).to.be.a("string");
+ // Unjustified type cast. FIXME
const decoded = JSON.parse(atob(config as string));
expect(decoded.url).to.eq(
diff --git a/e2e/test/scenarios/metrics/metrics-explorer.cy.spec.ts b/e2e/test/scenarios/metrics/metrics-explorer.cy.spec.ts
index 4012a82d407..0dbad7e3287 100644
--- a/e2e/test/scenarios/metrics/metrics-explorer.cy.spec.ts
+++ b/e2e/test/scenarios/metrics/metrics-explorer.cy.spec.ts
@@ -341,6 +341,7 @@ const decodeMetricsViewerUrlHash = (
char.charCodeAt(0),
);
+ // Unjustified type cast. FIXME
return JSON.parse(
new TextDecoder().decode(bytes),
) as CompactMetricsViewerUrlState;
@@ -490,6 +491,7 @@ describe("scenarios > metrics > explorer", () => {
});
beforeEach(() => {
+ // Unjustified type cast. FIXME
H.restore(SNAPSHOT_NAME as any);
cy.signInAsAdmin();
diff --git a/e2e/test/scenarios/organization/entity-picker.cy.spec.ts b/e2e/test/scenarios/organization/entity-picker.cy.spec.ts
index b532394e68b..69057d5251e 100644
--- a/e2e/test/scenarios/organization/entity-picker.cy.spec.ts
+++ b/e2e/test/scenarios/organization/entity-picker.cy.spec.ts
@@ -974,6 +974,7 @@ describe("scenarios > organization > entity picker", () => {
expect(lastColumn).to.not.be.null;
expect(container.scrollLeft).to.equal(
+ // Unjustified type cast. FIXME
(lastColumn as HTMLElement).offsetLeft,
);
});
diff --git a/e2e/test/scenarios/permissions/permissions-reproductions.cy.spec.ts b/e2e/test/scenarios/permissions/permissions-reproductions.cy.spec.ts
index 4d1aac04204..bc83e62c87b 100644
--- a/e2e/test/scenarios/permissions/permissions-reproductions.cy.spec.ts
+++ b/e2e/test/scenarios/permissions/permissions-reproductions.cy.spec.ts
@@ -101,6 +101,7 @@ describe("issue 39221", () => {
["admin", "normal"].forEach((user) => {
it(`${user.toUpperCase()}: updating user-specific setting should not result in fetching all site settings (metabase#39221)`, () => {
cy.signOut();
+ // Unjustified type cast. FIXME
cy.signIn(user as "admin" | "normal");
H.openReviewsTable({ mode: "notebook" });
// Opening a SQL preview sidebar will trigger a user-local setting update
diff --git a/e2e/test/scenarios/permissions/sandboxing/helpers/e2e-sandboxing-helpers.ts b/e2e/test/scenarios/permissions/sandboxing/helpers/e2e-sandboxing-helpers.ts
index 0ced5f38a7f..0a870810999 100644
--- a/e2e/test/scenarios/permissions/sandboxing/helpers/e2e-sandboxing-helpers.ts
+++ b/e2e/test/scenarios/permissions/sandboxing/helpers/e2e-sandboxing-helpers.ts
@@ -43,6 +43,7 @@ type SandboxPolicy = {
const customColumnTypeToFormula: Record<CustomColumnType, string> =
customColumnTypeToFormulaUntyped;
+// Unjustified type cast. FIXME
const customColumnTypes = Object.keys(
customColumnTypeToFormula,
) as CustomColumnType[];
@@ -422,6 +423,7 @@ const getQuestionDescription = (
) => {
// Extract the card ID from the response URL
const cardId = Number(response?.url?.match(/\/card\/(\d+)/)?.[1]);
+ // Unjustified type cast. FIXME
const questionName = (questions.find((q) => q.id === cardId) as any)?.name as
| string
| undefined;
@@ -538,6 +540,7 @@ export const getDashcardResponses = (
.wait(new Array(questions.length).fill("@dashcardQuery"))
.then((interceptions) => {
const responses = interceptions.map(
+ // Unjustified type cast. FIXME
(i) => i.response as unknown as DashcardQueryResponse,
);
return { questions, responses };
@@ -546,6 +549,7 @@ export const getDashcardResponses = (
export const getCardResponses = (questions: SimpleCollectionItem[]) => {
expect(questions.length).to.be.greaterThan(0);
+ // Unjustified type cast. FIXME
return H.cypressWaitAll(
questions.map((question) =>
cy.request<DatasetResponse>({
@@ -595,6 +599,7 @@ export const assertNoResultsOrValuesAreSandboxed = (
H.visitQuestionAdhoc(adhocQuestionData).then(({ response }) =>
rowsShouldContainGizmosAndWidgets({
responses: [response],
+ // Unjustified type cast. FIXME
questions: [adhocQuestionData as unknown as SimpleCollectionItem],
}),
);
@@ -624,6 +629,7 @@ export const assertAllResultsAndValuesAreSandboxed = (
H.visitQuestionAdhoc(adhocQuestionData).then(({ response }) =>
rowsShouldContainOnlyOneCategory({
responses: [response],
+ // Unjustified type cast. FIXME
questions: [adhocQuestionData as unknown as SimpleCollectionItem],
productCategory,
}),
diff --git a/e2e/test/scenarios/permissions/sandboxing/sandboxing-misconfiguration.cy.spec.ts b/e2e/test/scenarios/permissions/sandboxing/sandboxing-misconfiguration.cy.spec.ts
index fbcb1af2337..d9d20cc3df9 100644
--- a/e2e/test/scenarios/permissions/sandboxing/sandboxing-misconfiguration.cy.spec.ts
+++ b/e2e/test/scenarios/permissions/sandboxing/sandboxing-misconfiguration.cy.spec.ts
@@ -41,6 +41,7 @@ describe("admin > permissions > sandboxing > misconfiguration", () => {
beforeEach(() => {
cy.signInAsAdmin();
+ // Unjustified type cast. FIXME
H.restore("sandboxing-misconfiguration-snapshot" as any);
});
diff --git a/e2e/test/scenarios/permissions/sandboxing/sandboxing-via-ui.cy.spec.ts b/e2e/test/scenarios/permissions/sandboxing/sandboxing-via-ui.cy.spec.ts
index 484dd67a0b4..899e29eab18 100644
--- a/e2e/test/scenarios/permissions/sandboxing/sandboxing-via-ui.cy.spec.ts
+++ b/e2e/test/scenarios/permissions/sandboxing/sandboxing-via-ui.cy.spec.ts
@@ -49,6 +49,7 @@ describe(
const { data } = result.body;
for (const item of data) {
if (/Dashboard/i.test(item.name)) {
+ // Unjustified type cast. FIXME
dashboard = item as unknown as Dashboard;
} else if (/Question|Model/i.test(item.name)) {
sandboxableQuestions.push(item);
@@ -75,6 +76,7 @@ describe(
"dashcardQuery",
);
cy.intercept("POST", "/api/dataset").as("datasetQuery");
+ // Unjustified type cast. FIXME
H.restore("sandboxing-snapshot" as any);
});
diff --git a/e2e/test/scenarios/sharing/public-resource-downloads.cy.spec.ts b/e2e/test/scenarios/sharing/public-resource-downloads.cy.spec.ts
index b55229f40a7..e798553fb1a 100644
--- a/e2e/test/scenarios/sharing/public-resource-downloads.cy.spec.ts
+++ b/e2e/test/scenarios/sharing/public-resource-downloads.cy.spec.ts
@@ -32,6 +32,7 @@ describe("Public dashboards/questions downloads (results and pdf)", () => {
.should("contain.value", "/public/")
.invoke("val")
.then((url) => {
+ // Unjustified type cast. FIXME
publicLink = url as string;
});
@@ -172,6 +173,7 @@ describe("Public dashboards/questions downloads (results and pdf)", () => {
.should("contain.value", "/public/")
.invoke("val")
.then((url) => {
+ // Unjustified type cast. FIXME
publicLink = url as string;
});
diff --git a/enterprise/frontend/src/embedding-sdk-ee/auth/auth.ts b/enterprise/frontend/src/embedding-sdk-ee/auth/auth.ts
index bc27ea18c4e..0c0008068cc 100644
--- a/enterprise/frontend/src/embedding-sdk-ee/auth/auth.ts
+++ b/enterprise/frontend/src/embedding-sdk-ee/auth/auth.ts
@@ -104,7 +104,9 @@ PLUGIN_EMBEDDING_SDK_AUTH.initAuth = async (
}),
);
dispatch(refreshCurrentUser.fulfilled(authState.user, "", undefined));
+ // Unjustified type cast. FIXME
dispatch(loadSettings(authState.siteSettings as Settings));
+ // Unjustified type cast. FIXME
MetabaseSettings.setAll(authState.siteSettings as Settings);
// The session handler emits the X-Metabase-Session header on every API
@@ -152,6 +154,7 @@ PLUGIN_EMBEDDING_SDK_AUTH.initAuth = async (
if ((e as Error).name === "MetabaseError") {
throw e;
}
+ // Unjustified type cast. FIXME
throw MetabaseError.REFRESH_TOKEN_BACKEND_ERROR(e as Error);
}
}
@@ -178,6 +181,7 @@ const refreshTokenImpl = async (
config: MetabaseAuthConfig,
{ getState }: { getState: () => unknown },
): Promise<MetabaseEmbeddingSessionToken | null> => {
+ // Unjustified type cast. FIXME
const state = getState() as SdkStoreState;
if (isEmbeddingEajs()) {
@@ -210,6 +214,7 @@ export const getOrRefreshSession = createAsyncThunk(
// necessary to ensure that we don't use a popup every time the user
// refreshes the page
const storedAuthToken = samlTokenStorage.get();
+ // Unjustified type cast. FIXME
const state = getSessionTokenState(getState() as SdkStoreState);
/**
* @see {@link https://github.com/metabase/metabase/pull/64238#discussion_r2394229266}
@@ -307,6 +312,7 @@ async function waitForAuthCompletion(
): Promise<SdkAuthState> {
// early return if already completed
if (getAuthState()?.status !== "in-progress") {
+ // Unjustified type cast. FIXME
return getAuthState() as SdkAuthState;
}
const startTime = Date.now();
diff --git a/enterprise/frontend/src/embedding-sdk-ee/custom-viz/initialize.unit.spec.ts b/enterprise/frontend/src/embedding-sdk-ee/custom-viz/initialize.unit.spec.ts
index 0a439b88bcc..5211184e5b7 100644
--- a/enterprise/frontend/src/embedding-sdk-ee/custom-viz/initialize.unit.spec.ts
+++ b/enterprise/frontend/src/embedding-sdk-ee/custom-viz/initialize.unit.spec.ts
@@ -4,6 +4,7 @@ import { getPluginAssetUrl } from "metabase/visualizations/custom-visualizations
import { sdkCustomVizAssetManager } from "./initialize";
const okResponse = () =>
+ // Unjustified type cast. FIXME
({
ok: true,
blob: async () => new Blob(["<svg/>"], { type: "image/svg+xml" }),
diff --git a/enterprise/frontend/src/embedding-sdk-ee/metabot/MetabotChatInput.tsx b/enterprise/frontend/src/embedding-sdk-ee/metabot/MetabotChatInput.tsx
index 1cb1f757ed0..9dbe0b114e8 100644
--- a/enterprise/frontend/src/embedding-sdk-ee/metabot/MetabotChatInput.tsx
+++ b/enterprise/frontend/src/embedding-sdk-ee/metabot/MetabotChatInput.tsx
@@ -47,6 +47,7 @@ export function MetabotChatInput() {
autosize
minRows={1}
maxRows={4}
+ // Unjustified type cast. FIXME
ref={metabot.promptInputRef as LegacyRef<HTMLTextAreaElement>}
autoFocus
value={metabot.prompt}
diff --git a/enterprise/frontend/src/embedding-sdk-ee/metabot/hooks/use-metabot.unit.spec.tsx b/enterprise/frontend/src/embedding-sdk-ee/metabot/hooks/use-metabot.unit.spec.tsx
index 32c87943bc4..3ffdf818be7 100644
--- a/enterprise/frontend/src/embedding-sdk-ee/metabot/hooks/use-metabot.unit.spec.tsx
+++ b/enterprise/frontend/src/embedding-sdk-ee/metabot/hooks/use-metabot.unit.spec.tsx
@@ -247,6 +247,7 @@ describe("useMetabot", () => {
act(() => {
store.dispatch(
+ // Unjustified type cast. FIXME
metabotActions.addAgentMessage({
agentId: "omnibot",
type: "data_part",
@@ -277,6 +278,7 @@ describe("useMetabot", () => {
act(() => {
store.dispatch(metabotActions.setDebugMode(true));
store.dispatch(
+ // Unjustified type cast. FIXME
metabotActions.addAgentMessage({
agentId: "omnibot",
type: "tool_call",
@@ -285,6 +287,7 @@ describe("useMetabot", () => {
} as any),
);
store.dispatch(
+ // Unjustified type cast. FIXME
metabotActions.addAgentMessage({
agentId: "omnibot",
type: "edit_suggestion",
@@ -303,6 +306,7 @@ describe("useMetabot", () => {
} as any),
);
store.dispatch(
+ // Unjustified type cast. FIXME
metabotActions.addAgentMessage({
agentId: "omnibot",
type: "todo_list",
@@ -317,6 +321,7 @@ describe("useMetabot", () => {
} as any),
);
store.dispatch(
+ // Unjustified type cast. FIXME
metabotActions.addAgentMessage({
agentId: "omnibot",
type: "text",
@@ -348,6 +353,7 @@ describe("useMetabot", () => {
}),
);
store.dispatch(
+ // Unjustified type cast. FIXME
metabotActions.addAgentMessage({
agentId: "omnibot",
type: "data_part",
@@ -355,6 +361,7 @@ describe("useMetabot", () => {
} as any),
);
store.dispatch(
+ // Unjustified type cast. FIXME
metabotActions.addAgentMessage({
agentId: "omnibot",
type: "data_part",
@@ -370,6 +377,7 @@ describe("useMetabot", () => {
}),
);
store.dispatch(
+ // Unjustified type cast. FIXME
metabotActions.addAgentMessage({
agentId: "omnibot",
type: "data_part",
@@ -473,6 +481,7 @@ describe("useMetabot", () => {
act(() => {
store.dispatch(
+ // Unjustified type cast. FIXME
metabotActions.addAgentMessage({
agentId: "omnibot",
type: "data_part",
@@ -492,6 +501,7 @@ describe("useMetabot", () => {
act(() => {
store.dispatch(
+ // Unjustified type cast. FIXME
metabotActions.addAgentMessage({
agentId: "omnibot",
type: "data_part",
@@ -534,6 +544,7 @@ describe("useMetabot", () => {
}),
);
store.dispatch(
+ // Unjustified type cast. FIXME
metabotActions.addAgentMessage({
agentId: "omnibot",
type: "data_part",
@@ -559,6 +570,7 @@ describe("useMetabot", () => {
}),
);
store.dispatch(
+ // Unjustified type cast. FIXME
metabotActions.addAgentMessage({
agentId: "omnibot",
type: "data_part",
diff --git a/enterprise/frontend/src/embedding-sdk-ee/tests/auth-flow/jwt.unit.spec.tsx b/enterprise/frontend/src/embedding-sdk-ee/tests/auth-flow/jwt.unit.spec.tsx
index e8b1a74dd58..15e363eda5a 100644
--- a/enterprise/frontend/src/embedding-sdk-ee/tests/auth-flow/jwt.unit.spec.tsx
+++ b/enterprise/frontend/src/embedding-sdk-ee/tests/auth-flow/jwt.unit.spec.tsx
@@ -110,6 +110,7 @@ describe("Auth Flow - JWT", () => {
expect(ssoExchange!.options.headers).toMatchObject({
"content-type": "application/json",
});
+ // Unjustified type cast. FIXME
expect(JSON.parse(ssoExchange!.options.body as string)).toEqual({
jwt: MOCK_VALID_JWT_RESPONSE,
});
diff --git a/enterprise/frontend/src/embedding-sdk-ee/tests/sdk-config-errors/sdk-config-errors.unit.spec.tsx b/enterprise/frontend/src/embedding-sdk-ee/tests/sdk-config-errors/sdk-config-errors.unit.spec.tsx
index 9a577a95996..a642904766c 100644
--- a/enterprise/frontend/src/embedding-sdk-ee/tests/sdk-config-errors/sdk-config-errors.unit.spec.tsx
+++ b/enterprise/frontend/src/embedding-sdk-ee/tests/sdk-config-errors/sdk-config-errors.unit.spec.tsx
@@ -39,6 +39,7 @@ const setup = async (
setupSdkState();
setupCardEndpoints(MOCK_CARD);
+ // Unjustified type cast. FIXME
setupCardQueryEndpoints(MOCK_CARD, {} as any);
consoleErrorSpy = jest
@@ -79,6 +80,7 @@ const expectErrorMessage = async (message: string) => {
).toBeInTheDocument();
});
} catch (error) {
+ // Unjustified type cast. FIXME
Error.captureStackTrace(error as Error, expectErrorMessage);
throw error;
}
diff --git a/enterprise/frontend/src/embedding-sdk-ee/tests/use-init-data/setup.tsx b/enterprise/frontend/src/embedding-sdk-ee/tests/use-init-data/setup.tsx
index 67d499d6e70..073eefaaa9a 100644
--- a/enterprise/frontend/src/embedding-sdk-ee/tests/use-init-data/setup.tsx
+++ b/enterprise/frontend/src/embedding-sdk-ee/tests/use-init-data/setup.tsx
@@ -74,6 +74,7 @@ export const TestComponent = ({ config }: { config: MetabaseConfigProps }) => {
data-testid="test-component"
data-is-logged-in={isLoggedIn}
data-login-status={loginStatus.status}
+ // Unjustified type cast. FIXME
data-error-message={(loginStatus as LoginStatusError).error?.message}
>
Test Component
diff --git a/enterprise/frontend/src/embedding-sdk-package/bin/get-public-components.ts b/enterprise/frontend/src/embedding-sdk-package/bin/get-public-components.ts
index 803f11f0dc2..99912d482b8 100644
--- a/enterprise/frontend/src/embedding-sdk-package/bin/get-public-components.ts
+++ b/enterprise/frontend/src/embedding-sdk-package/bin/get-public-components.ts
@@ -18,6 +18,7 @@ export function getPublicComponents() {
sdkPublicIndexSourceFile.forEachDescendant((node) => {
switch (node.getKind()) {
case SyntaxKind.ExportSpecifier: {
+ // Unjustified type cast. FIXME
if (!isType(node as ExportSpecifier) && isReactComponent(node)) {
const componentForNextJsCompat: ComponentDefinition = {
mainComponent: node.getText(),
diff --git a/enterprise/frontend/src/embedding-sdk-package/cli/steps/create-api-key.ts b/enterprise/frontend/src/embedding-sdk-package/cli/steps/create-api-key.ts
index 9f74f2410f9..9dfed6371c0 100644
--- a/enterprise/frontend/src/embedding-sdk-package/cli/steps/create-api-key.ts
+++ b/enterprise/frontend/src/embedding-sdk-package/cli/steps/create-api-key.ts
@@ -38,6 +38,7 @@ export const createApiKey: CliStepMethod = async (state) => {
];
}
+ // Unjustified type cast. FIXME
const { unmasked_key } = (await res.json()) as { unmasked_key: string };
spinner.succeed();
diff --git a/enterprise/frontend/src/embedding-sdk-package/cli/steps/pick-database-tables.ts b/enterprise/frontend/src/embedding-sdk-package/cli/steps/pick-database-tables.ts
index 5b142129ef5..8c042b499e6 100644
--- a/enterprise/frontend/src/embedding-sdk-package/cli/steps/pick-database-tables.ts
+++ b/enterprise/frontend/src/embedding-sdk-package/cli/steps/pick-database-tables.ts
@@ -127,6 +127,7 @@ export const pickDatabaseTables: CliStepMethod = async (state) => {
await propagateErrorResponse(res);
+ // Unjustified type cast. FIXME
const metadataResult = (await res.json()) as { tables: Table[] };
const table = metadataResult.tables.find((t) => t.id === tableId);
diff --git a/enterprise/frontend/src/embedding-sdk-package/cli/steps/setup-metabase-instance.ts b/enterprise/frontend/src/embedding-sdk-package/cli/steps/setup-metabase-instance.ts
index 7c70298ea87..847b3e8d39c 100644
--- a/enterprise/frontend/src/embedding-sdk-package/cli/steps/setup-metabase-instance.ts
+++ b/enterprise/frontend/src/embedding-sdk-package/cli/steps/setup-metabase-instance.ts
@@ -58,6 +58,7 @@ export const setupMetabaseInstance: CliStepMethod = async (state) => {
}
try {
+ // Unjustified type cast. FIXME
const { errors } = JSON.parse(errorMessage) as {
errors: Record<string, string>;
};
diff --git a/enterprise/frontend/src/embedding-sdk-package/cli/steps/setup-permission/setup-permission.ts b/enterprise/frontend/src/embedding-sdk-package/cli/steps/setup-permission/setup-permission.ts
index 55fb04390ca..f51c64af23e 100644
--- a/enterprise/frontend/src/embedding-sdk-package/cli/steps/setup-permission/setup-permission.ts
+++ b/enterprise/frontend/src/embedding-sdk-package/cli/steps/setup-permission/setup-permission.ts
@@ -53,6 +53,7 @@ export const setupPermissions: CliStepMethod = async (state) => {
await propagateErrorResponse(res);
+ // Unjustified type cast. FIXME
const { id: groupId } = (await res.json()) as { id: number };
jwtGroupMappings[groupName] = [groupId];
diff --git a/enterprise/frontend/src/embedding-sdk-package/cli/steps/setup-permission/setup-permission.unit.spec.ts b/enterprise/frontend/src/embedding-sdk-package/cli/steps/setup-permission/setup-permission.unit.spec.ts
index c6c9cfbaa86..c31bdf3e8c4 100644
--- a/enterprise/frontend/src/embedding-sdk-package/cli/steps/setup-permission/setup-permission.unit.spec.ts
+++ b/enterprise/frontend/src/embedding-sdk-package/cli/steps/setup-permission/setup-permission.unit.spec.ts
@@ -45,6 +45,7 @@ describe("grantAccessToModelCollection", () => {
>
).mockResolvedValue(undefined);
+ // Unjustified type cast. FIXME
(
getSandboxedCollectionPermissions as jest.MockedFunction<
typeof getSandboxedCollectionPermissions
@@ -71,6 +72,7 @@ describe("grantAccessToModelCollection", () => {
expect(collectionUpdateCalls).toHaveLength(1);
const requestBody = JSON.parse(
+ // Unjustified type cast. FIXME
collectionUpdateCalls[0].options?.body as string,
);
expect(requestBody.revision).toBe(42); // This is the key assertion
@@ -99,6 +101,7 @@ describe("grantAccessToModelCollection", () => {
>
).mockResolvedValue(undefined);
+ // Unjustified type cast. FIXME
(
getSandboxedCollectionPermissions as jest.MockedFunction<
typeof getSandboxedCollectionPermissions
@@ -118,6 +121,7 @@ describe("grantAccessToModelCollection", () => {
expect(collectionUpdateCalls).toHaveLength(1);
const requestBody = JSON.parse(
+ // Unjustified type cast. FIXME
collectionUpdateCalls[0].options?.body as string,
);
expect(requestBody.revision).toBe(0); // Should default to 0 when revision is missing
@@ -133,6 +137,7 @@ describe("grantAccessToModelCollection", () => {
.get("http://localhost:3000/api/collection/graph", mockCurrentGraph)
.put("http://localhost:3000/api/collection/graph?skip-graph=true", {});
+ // Unjustified type cast. FIXME
(
propagateErrorResponse as jest.MockedFunction<
typeof propagateErrorResponse
@@ -156,6 +161,7 @@ describe("grantAccessToModelCollection", () => {
{ method: "PUT" },
);
const requestBody = JSON.parse(
+ // Unjustified type cast. FIXME
collectionUpdateCalls[0].options?.body as string,
);
diff --git a/enterprise/frontend/src/embedding-sdk-package/cli/utils/create-collection.ts b/enterprise/frontend/src/embedding-sdk-package/cli/utils/create-collection.ts
index abd99ea6bce..29d62383123 100644
--- a/enterprise/frontend/src/embedding-sdk-package/cli/utils/create-collection.ts
+++ b/enterprise/frontend/src/embedding-sdk-package/cli/utils/create-collection.ts
@@ -24,6 +24,7 @@ export async function createCollection(options: Options) {
await propagateErrorResponse(res);
+ // Unjustified type cast. FIXME
const { id: collectionId } = (await res.json()) as { id: number };
return collectionId;
diff --git a/enterprise/frontend/src/embedding-sdk-package/cli/utils/create-model-from-table.ts b/enterprise/frontend/src/embedding-sdk-package/cli/utils/create-model-from-table.ts
index 96dba536872..55d6b0e4048 100644
--- a/enterprise/frontend/src/embedding-sdk-package/cli/utils/create-model-from-table.ts
+++ b/enterprise/frontend/src/embedding-sdk-package/cli/utils/create-model-from-table.ts
@@ -39,6 +39,7 @@ export async function createModelFromTable(options: Options) {
await propagateErrorResponse(res);
+ // Unjustified type cast. FIXME
const { id: modelId } = (await res.json()) as { id: number };
return {
diff --git a/enterprise/frontend/src/embedding-sdk-package/cli/utils/get-local-metabase-container.ts b/enterprise/frontend/src/embedding-sdk-package/cli/utils/get-local-metabase-container.ts
index 1af311353bc..2d6b29cff0e 100644
--- a/enterprise/frontend/src/embedding-sdk-package/cli/utils/get-local-metabase-container.ts
+++ b/enterprise/frontend/src/embedding-sdk-package/cli/utils/get-local-metabase-container.ts
@@ -35,6 +35,7 @@ export async function getLocalMetabaseContainer(): Promise<ContainerInfo | null>
return null;
}
+ // Unjustified type cast. FIXME
const info = safeJsonParse(stdout) as ContainerInfo;
if (!info) {
diff --git a/enterprise/frontend/src/embedding-sdk-package/cli/utils/sample-tenancy-column-values.ts b/enterprise/frontend/src/embedding-sdk-package/cli/utils/sample-tenancy-column-values.ts
index ce30a1ed5d6..e509ccef64f 100644
--- a/enterprise/frontend/src/embedding-sdk-package/cli/utils/sample-tenancy-column-values.ts
+++ b/enterprise/frontend/src/embedding-sdk-package/cli/utils/sample-tenancy-column-values.ts
@@ -103,8 +103,10 @@ export async function sampleTenantIds(
await propagateErrorResponse(res);
+ // Unjustified type cast. FIXME
const dataset = (await res.json()) as Dataset;
+ // Unjustified type cast. FIXME
return dataset.data.rows
.flat()
.filter((value) => value !== null) as TenantId[];
diff --git a/enterprise/frontend/src/embedding-sdk-package/components/private/ComponentWrapper/ComponentWrapper.tsx b/enterprise/frontend/src/embedding-sdk-package/components/private/ComponentWrapper/ComponentWrapper.tsx
index 0196164d8d7..5362200f758 100644
--- a/enterprise/frontend/src/embedding-sdk-package/components/private/ComponentWrapper/ComponentWrapper.tsx
+++ b/enterprise/frontend/src/embedding-sdk-package/components/private/ComponentWrapper/ComponentWrapper.tsx
@@ -183,6 +183,7 @@ const ComponentWrapperInner = <TComponentProps,>({
const adjustedTheme = useMemo(() => applyThemePreset(theme), [theme]);
const { height, width } =
+ // Unjustified type cast. FIXME
(componentProps as {
height?: CSSProperties["height"];
width?: CSSProperties["width"];
@@ -245,6 +246,7 @@ const ComponentWrapperInner = <TComponentProps,>({
reduxStore={metabaseProviderInternalProps.reduxStore}
>
<RenderComponentWithValidation
+ // Unjustified type cast. FIXME
$component={Component as InternalComponent<JSXElementConstructor<any>>}
{...componentProps}
/>
@@ -266,6 +268,7 @@ export const createComponent = <
| null
| undefined,
): ComponentWrapperFunction<TComponentProps> => {
+ // Unjustified type cast. FIXME
return function ComponentWrapper(props: TComponentProps) {
const ensureSingleInstanceId = useId();
diff --git a/enterprise/frontend/src/embedding-sdk-package/components/public/CollectionBrowser/CollectionBrowser.stories.tsx b/enterprise/frontend/src/embedding-sdk-package/components/public/CollectionBrowser/CollectionBrowser.stories.tsx
index 6ef9499e250..92120c2a375 100644
--- a/enterprise/frontend/src/embedding-sdk-package/components/public/CollectionBrowser/CollectionBrowser.stories.tsx
+++ b/enterprise/frontend/src/embedding-sdk-package/components/public/CollectionBrowser/CollectionBrowser.stories.tsx
@@ -9,6 +9,7 @@ import { CollectionBrowser } from "./CollectionBrowser";
const COLLECTION_ID = "root";
const config = getStorybookSdkAuthConfigForUser("admin");
+// Unjustified type cast. FIXME
(window as any).onCollectionClick = (collection: MetabaseCollectionItem) => {
// eslint-disable-next-line no-console
console.log(collection);
diff --git a/enterprise/frontend/src/embedding-sdk-package/components/public/InteractiveQuestion/InteractiveQuestion.stories.tsx b/enterprise/frontend/src/embedding-sdk-package/components/public/InteractiveQuestion/InteractiveQuestion.stories.tsx
index 710e5b34b87..50f5fc23fb1 100644
--- a/enterprise/frontend/src/embedding-sdk-package/components/public/InteractiveQuestion/InteractiveQuestion.stories.tsx
+++ b/enterprise/frontend/src/embedding-sdk-package/components/public/InteractiveQuestion/InteractiveQuestion.stories.tsx
@@ -5,6 +5,7 @@ import { MetabaseProvider } from "../MetabaseProvider";
import { InteractiveQuestion } from "./InteractiveQuestion";
+// Unjustified type cast. FIXME
const QUESTION_ID = (window as any).QUESTION_ID || 12;
const config = getStorybookSdkAuthConfigForUser("admin");
diff --git a/enterprise/frontend/src/embedding-sdk-package/components/public/MetabaseProvider/MetabaseProvider.stories.tsx b/enterprise/frontend/src/embedding-sdk-package/components/public/MetabaseProvider/MetabaseProvider.stories.tsx
index f170d72e377..f61f85ae705 100644
--- a/enterprise/frontend/src/embedding-sdk-package/components/public/MetabaseProvider/MetabaseProvider.stories.tsx
+++ b/enterprise/frontend/src/embedding-sdk-package/components/public/MetabaseProvider/MetabaseProvider.stories.tsx
@@ -6,6 +6,7 @@ import { getHostedBundleStoryDecorator } from "embedding-sdk-package/test/getHos
import { MetabaseProvider } from "./MetabaseProvider";
+// Unjustified type cast. FIXME
const QUESTION_ID = (window as any).QUESTION_ID || 12;
const config = getStorybookSdkAuthConfigForUser("admin");
diff --git a/enterprise/frontend/src/embedding-sdk-package/components/public/StaticQuestion/StaticQuestion.stories.tsx b/enterprise/frontend/src/embedding-sdk-package/components/public/StaticQuestion/StaticQuestion.stories.tsx
index 04729c40040..b951fa87715 100644
--- a/enterprise/frontend/src/embedding-sdk-package/components/public/StaticQuestion/StaticQuestion.stories.tsx
+++ b/enterprise/frontend/src/embedding-sdk-package/components/public/StaticQuestion/StaticQuestion.stories.tsx
@@ -5,6 +5,7 @@ import { MetabaseProvider } from "../MetabaseProvider";
import { StaticQuestion } from "./StaticQuestion";
+// Unjustified type cast. FIXME
const QUESTION_ID = (window as any).QUESTION_ID || 12;
const config = getStorybookSdkAuthConfigForUser("admin");
diff --git a/enterprise/frontend/src/embedding-sdk-package/components/public/dashboard/EditableDashboard/EditableDashboard.stories.tsx b/enterprise/frontend/src/embedding-sdk-package/components/public/dashboard/EditableDashboard/EditableDashboard.stories.tsx
index 6f93b1d82a8..5946abf11ab 100644
--- a/enterprise/frontend/src/embedding-sdk-package/components/public/dashboard/EditableDashboard/EditableDashboard.stories.tsx
+++ b/enterprise/frontend/src/embedding-sdk-package/components/public/dashboard/EditableDashboard/EditableDashboard.stories.tsx
@@ -5,6 +5,7 @@ import { MetabaseProvider } from "../../MetabaseProvider";
import { EditableDashboard } from "./EditableDashboard";
+// Unjustified type cast. FIXME
const DASHBOARD_ID = (window as any).DASHBOARD_ID || 1;
const config = getStorybookSdkAuthConfigForUser("admin");
diff --git a/enterprise/frontend/src/embedding-sdk-package/components/public/dashboard/InteractiveDashboard/InteractiveDashboard.stories.tsx b/enterprise/frontend/src/embedding-sdk-package/components/public/dashboard/InteractiveDashboard/InteractiveDashboard.stories.tsx
index 16ef0bef88b..4a3542b3f67 100644
--- a/enterprise/frontend/src/embedding-sdk-package/components/public/dashboard/InteractiveDashboard/InteractiveDashboard.stories.tsx
+++ b/enterprise/frontend/src/embedding-sdk-package/components/public/dashboard/InteractiveDashboard/InteractiveDashboard.stories.tsx
@@ -5,6 +5,7 @@ import { MetabaseProvider } from "../../MetabaseProvider";
import { InteractiveDashboard } from "./InteractiveDashboard";
+// Unjustified type cast. FIXME
const DASHBOARD_ID = (window as any).DASHBOARD_ID || 1;
const config = getStorybookSdkAuthConfigForUser("admin");
diff --git a/enterprise/frontend/src/embedding-sdk-package/components/public/dashboard/StaticDashboard/StaticDashboard.stories.tsx b/enterprise/frontend/src/embedding-sdk-package/components/public/dashboard/StaticDashboard/StaticDashboard.stories.tsx
index fe0b4810ca4..00349d26418 100644
--- a/enterprise/frontend/src/embedding-sdk-package/components/public/dashboard/StaticDashboard/StaticDashboard.stories.tsx
+++ b/enterprise/frontend/src/embedding-sdk-package/components/public/dashboard/StaticDashboard/StaticDashboard.stories.tsx
@@ -5,6 +5,7 @@ import { MetabaseProvider } from "../../MetabaseProvider";
import { StaticDashboard } from "./StaticDashboard";
+// Unjustified type cast. FIXME
const DASHBOARD_ID = (window as any).DASHBOARD_ID || 1;
const config = getStorybookSdkAuthConfigForUser("admin");
diff --git a/enterprise/frontend/src/embedding-sdk-package/components/public/plugins/HandleLinkPlugin.stories.tsx b/enterprise/frontend/src/embedding-sdk-package/components/public/plugins/HandleLinkPlugin.stories.tsx
index fda6896276c..e9315e06409 100644
--- a/enterprise/frontend/src/embedding-sdk-package/components/public/plugins/HandleLinkPlugin.stories.tsx
+++ b/enterprise/frontend/src/embedding-sdk-package/components/public/plugins/HandleLinkPlugin.stories.tsx
@@ -21,6 +21,7 @@ export default {
description: "Question ID with links to test handleLink plugin",
},
},
+ // Unjustified type cast. FIXME
args: {
questionId: null,
} as { questionId: number | null },
@@ -57,6 +58,7 @@ const QuestionNotice = () => {
const AdminUserCheck = () => {
const user = useCurrentUser();
+ // Unjustified type cast. FIXME
if (!(user as any)?.is_superuser) {
return (
<div
diff --git a/enterprise/frontend/src/embedding-sdk-package/hooks/private/use-lazy-selector.unit.spec.tsx b/enterprise/frontend/src/embedding-sdk-package/hooks/private/use-lazy-selector.unit.spec.tsx
index a72a19ffbf5..120a51d05fc 100644
--- a/enterprise/frontend/src/embedding-sdk-package/hooks/private/use-lazy-selector.unit.spec.tsx
+++ b/enterprise/frontend/src/embedding-sdk-package/hooks/private/use-lazy-selector.unit.spec.tsx
@@ -69,6 +69,7 @@ const makeStore = (initialStatus: string) => {
* "store with a real status".
*/
const getStatus = (state: SdkStoreState) =>
+ // Unjustified type cast. FIXME
(state as unknown as FakeState).sdk?.initStatus?.status ?? null;
/**
@@ -100,6 +101,7 @@ const Provider = ({ status }: { status: string }) => {
useEffect(() => {
const store = makeStore(status);
ensureMetabaseProviderPropsStore().updateInternalProps({
+ // Unjustified type cast. FIXME
reduxStore: store as any,
});
return () => {
@@ -112,9 +114,11 @@ const Provider = ({ status }: { status: string }) => {
describe("useLazySelector — provider remount with stale consumer", () => {
// Clear the window-scoped singleton so each test starts from scratch.
beforeEach(() => {
+ // Unjustified type cast. FIXME
delete (window as any)[PROPS_STORE_KEY];
});
afterEach(() => {
+ // Unjustified type cast. FIXME
delete (window as any)[PROPS_STORE_KEY];
});
diff --git a/enterprise/frontend/src/embedding-sdk-package/hooks/public/use-action/lib/to-action-execute-error.ts b/enterprise/frontend/src/embedding-sdk-package/hooks/public/use-action/lib/to-action-execute-error.ts
index e22d516a4df..e27b1f02aec 100644
--- a/enterprise/frontend/src/embedding-sdk-package/hooks/public/use-action/lib/to-action-execute-error.ts
+++ b/enterprise/frontend/src/embedding-sdk-package/hooks/public/use-action/lib/to-action-execute-error.ts
@@ -21,6 +21,7 @@ export const toActionExecuteError = (error: unknown): ActionExecuteError => {
const status = getErrorStatus(error);
if (status !== undefined) {
+ // Unjustified type cast. FIXME
const { data, isCancelled } = error as {
data?: unknown;
isCancelled?: unknown;
@@ -31,8 +32,10 @@ export const toActionExecuteError = (error: unknown): ActionExecuteError => {
const message =
typeof data === "string"
? data
- : typeof (data as { message?: unknown })?.message === "string"
- ? (data as { message: string }).message
+ : // Unjustified type cast. FIXME
+ typeof (data as { message?: unknown })?.message === "string"
+ ? // Unjustified type cast. FIXME
+ (data as { message: string }).message
: undefined;
// The execute endpoint may also include an `errors` map keyed by
// parameter slug (`{ <slug>: <message> }`), or an empty `{}` for
@@ -42,7 +45,8 @@ export const toActionExecuteError = (error: unknown): ActionExecuteError => {
rawErrors != null &&
typeof rawErrors === "object" &&
!Array.isArray(rawErrors)
- ? (rawErrors as Record<string, string>)
+ ? // Unjustified type cast. FIXME
+ (rawErrors as Record<string, string>)
: undefined;
return {
diff --git a/enterprise/frontend/src/embedding-sdk-package/hooks/public/use-action/use-action.ts b/enterprise/frontend/src/embedding-sdk-package/hooks/public/use-action/use-action.ts
index a4f6f538fb1..181a7167d2f 100644
--- a/enterprise/frontend/src/embedding-sdk-package/hooks/public/use-action/use-action.ts
+++ b/enterprise/frontend/src/embedding-sdk-package/hooks/public/use-action/use-action.ts
@@ -105,6 +105,7 @@ export const useAction = <
actionId,
parameters,
});
+ // Unjustified type cast. FIXME
const next = raw as ActionResultForKind<TKind>;
setResult(next);
return next;
diff --git a/enterprise/frontend/src/embedding-sdk-package/hooks/public/use-create-dashboard-api/use-create-dashboard-api.unit.spec.tsx b/enterprise/frontend/src/embedding-sdk-package/hooks/public/use-create-dashboard-api/use-create-dashboard-api.unit.spec.tsx
index bc40e7c54fa..7ba25e84818 100644
--- a/enterprise/frontend/src/embedding-sdk-package/hooks/public/use-create-dashboard-api/use-create-dashboard-api.unit.spec.tsx
+++ b/enterprise/frontend/src/embedding-sdk-package/hooks/public/use-create-dashboard-api/use-create-dashboard-api.unit.spec.tsx
@@ -58,6 +58,7 @@ describe("useCreateDashboardApi", () => {
const call = calls[0];
+ // Unjustified type cast. FIXME
const requestBody = call.options?.body as string;
expect(JSON.parse(requestBody)).toMatchObject({
collection_id: TEST_PERSONAL_COLLECTION_ID,
diff --git a/enterprise/frontend/src/embedding/auth-common/connect-to-instance-auth-sso.ts b/enterprise/frontend/src/embedding/auth-common/connect-to-instance-auth-sso.ts
index bd1df82a9f7..aa81d2a546c 100644
--- a/enterprise/frontend/src/embedding/auth-common/connect-to-instance-auth-sso.ts
+++ b/enterprise/frontend/src/embedding/auth-common/connect-to-instance-auth-sso.ts
@@ -51,6 +51,7 @@ export async function connectToInstanceAuthSso(
}
throw MetabaseError.CANNOT_CONNECT_TO_INSTANCE({
instanceUrl: url,
+ // Unjustified type cast. FIXME
status: (e as any)?.status,
});
}
diff --git a/enterprise/frontend/src/embedding/data-picker/DataSelector/tests/DataSourceSelector.unit.spec.tsx b/enterprise/frontend/src/embedding/data-picker/DataSelector/tests/DataSourceSelector.unit.spec.tsx
index 90c7c5c1784..d5a97639954 100644
--- a/enterprise/frontend/src/embedding/data-picker/DataSelector/tests/DataSourceSelector.unit.spec.tsx
+++ b/enterprise/frontend/src/embedding/data-picker/DataSelector/tests/DataSourceSelector.unit.spec.tsx
@@ -206,6 +206,7 @@ describe("DataSourceSelector", () => {
isJoinStep: true,
databases: [sampleDatabase, manyTablesDatabase],
selectedTable: {
+ // Unjustified type cast. FIXME
id: (manyTablesDatabase.tables as Table[])[0].id as number,
databaseId: manyTablesDatabase.id,
},
diff --git a/enterprise/frontend/src/metabase-enterprise/advanced_permissions/components/ImpersonationModal/ImpersonationModal.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/advanced_permissions/components/ImpersonationModal/ImpersonationModal.unit.spec.tsx
index d7cd5edf475..4b50c2b8389 100644
--- a/enterprise/frontend/src/metabase-enterprise/advanced_permissions/components/ImpersonationModal/ImpersonationModal.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/advanced_permissions/components/ImpersonationModal/ImpersonationModal.unit.spec.tsx
@@ -138,6 +138,7 @@ describe("impersonation modal", () => {
await userEvent.click(screen.getByText(/save/i));
expect(
+ // Unjustified type cast. FIXME
getImpersonations(store.getState() as AdvancedPermissionsStoreState),
).toHaveLength(0);
});
@@ -155,6 +156,7 @@ describe("impersonation modal", () => {
await waitFor(() => {
expect(
+ // Unjustified type cast. FIXME
getImpersonations(store.getState() as AdvancedPermissionsStoreState),
).toStrictEqual([
{
@@ -179,6 +181,7 @@ describe("impersonation modal", () => {
await waitFor(() => {
expect(
+ // Unjustified type cast. FIXME
getImpersonations(store.getState() as AdvancedPermissionsStoreState),
).toStrictEqual([
{
diff --git a/enterprise/frontend/src/metabase-enterprise/ai-controls/hooks/useAdminSettingWithDebouncedInput.ts b/enterprise/frontend/src/metabase-enterprise/ai-controls/hooks/useAdminSettingWithDebouncedInput.ts
index 7665f5ed694..c29c2adf2ec 100644
--- a/enterprise/frontend/src/metabase-enterprise/ai-controls/hooks/useAdminSettingWithDebouncedInput.ts
+++ b/enterprise/frontend/src/metabase-enterprise/ai-controls/hooks/useAdminSettingWithDebouncedInput.ts
@@ -16,6 +16,7 @@ export function useAdminSettingWithDebouncedInput<T>(
defaultValue: T | null = null,
) {
const { value: settingValue, updateSetting } = useAdminSetting(settingName);
+ // Unjustified type cast. FIXME
const [inputValue, setInputValue] = useState<T>(settingValue as T);
const { sendErrorToast } = useMetadataToasts();
@@ -25,6 +26,7 @@ export function useAdminSettingWithDebouncedInput<T>(
inputValue === undefined && // Input has not been initialized
settingValue !== undefined // and setting has been fetched
) {
+ // Unjustified type cast. FIXME
setInputValue((settingValue || defaultValue) as T);
}
}, [defaultValue, inputValue, settingValue]);
@@ -32,6 +34,7 @@ export function useAdminSettingWithDebouncedInput<T>(
const debouncedSaveSetting = useDebouncedCallback(async (value: T) => {
const response = await updateSetting({
key: settingName,
+ // Unjustified type cast. FIXME
value: value as EnterpriseSettingValue<typeof settingName>,
toast: false,
});
diff --git a/enterprise/frontend/src/metabase-enterprise/ai-controls/pages/MetabotCustomizationPage/MetabotIconField.tsx b/enterprise/frontend/src/metabase-enterprise/ai-controls/pages/MetabotCustomizationPage/MetabotIconField.tsx
index 926b010d7da..b10f08da614 100644
--- a/enterprise/frontend/src/metabase-enterprise/ai-controls/pages/MetabotCustomizationPage/MetabotIconField.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/ai-controls/pages/MetabotCustomizationPage/MetabotIconField.tsx
@@ -51,6 +51,7 @@ export function MetabotIconField() {
}
const reader = new FileReader();
reader.onload = async (readerEvent) => {
+ // Unjustified type cast. FIXME
const dataUri = readerEvent.target?.result as string;
if (!(await isFileIntact(dataUri))) {
setIconError(
diff --git a/enterprise/frontend/src/metabase-enterprise/ai-controls/pages/MetabotUsageLimitsPage/GeneralLimitsSettingsSection.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/ai-controls/pages/MetabotUsageLimitsPage/GeneralLimitsSettingsSection.unit.spec.tsx
index 6b8fb953630..20bc264f110 100644
--- a/enterprise/frontend/src/metabase-enterprise/ai-controls/pages/MetabotUsageLimitsPage/GeneralLimitsSettingsSection.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/ai-controls/pages/MetabotUsageLimitsPage/GeneralLimitsSettingsSection.unit.spec.tsx
@@ -26,6 +26,7 @@ function setup({
limitType = "tokens",
limitPeriod = "monthly",
quotaMessage = "",
+ // Unjustified type cast. FIXME
instanceMaxUsage = null as number | null,
}: SetupOpts = {}) {
setupPropertiesEndpoints(
diff --git a/enterprise/frontend/src/metabase-enterprise/ai-controls/pages/MetabotUsageLimitsPage/GroupLimitsSettingsSection/GroupLimitsSettingsSection.tsx b/enterprise/frontend/src/metabase-enterprise/ai-controls/pages/MetabotUsageLimitsPage/GroupLimitsSettingsSection/GroupLimitsSettingsSection.tsx
index 6f1df523a6e..22d401b6343 100644
--- a/enterprise/frontend/src/metabase-enterprise/ai-controls/pages/MetabotUsageLimitsPage/GroupLimitsSettingsSection/GroupLimitsSettingsSection.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/ai-controls/pages/MetabotUsageLimitsPage/GroupLimitsSettingsSection/GroupLimitsSettingsSection.tsx
@@ -121,6 +121,7 @@ export function GroupLimitsSettingsSection() {
<SettingsSection title={t`Group and tenant limits`}>
<Tabs
value={activeTab}
+ // Unjustified type cast. FIXME
onChange={(value) => setActiveTab(value as GroupLimitsTabValue)}
>
<Tabs.List mb="md">
diff --git a/enterprise/frontend/src/metabase-enterprise/ai-controls/pages/MetabotUsageLimitsPage/GroupLimitsSettingsSection/GroupLimitsSettingsSection.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/ai-controls/pages/MetabotUsageLimitsPage/GroupLimitsSettingsSection/GroupLimitsSettingsSection.unit.spec.tsx
index 6673816d3c8..1948f83622c 100644
--- a/enterprise/frontend/src/metabase-enterprise/ai-controls/pages/MetabotUsageLimitsPage/GroupLimitsSettingsSection/GroupLimitsSettingsSection.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/ai-controls/pages/MetabotUsageLimitsPage/GroupLimitsSettingsSection/GroupLimitsSettingsSection.unit.spec.tsx
@@ -31,7 +31,9 @@ const defaultGroups = [adminGroup, allUsersGroup];
function setup({
useTenants = false,
groups = defaultGroups,
+ // Unjustified type cast. FIXME
groupLimits = [] as MetabotGroupLimit[],
+ // Unjustified type cast. FIXME
instanceMaxUsage = null as number | null,
} = {}) {
setupGroupsEndpoint(groups);
diff --git a/enterprise/frontend/src/metabase-enterprise/ai-controls/pages/MetabotUsageLimitsPage/GroupLimitsSettingsSection/GroupLimitsTab/GroupLimitsTab.tsx b/enterprise/frontend/src/metabase-enterprise/ai-controls/pages/MetabotUsageLimitsPage/GroupLimitsSettingsSection/GroupLimitsTab/GroupLimitsTab.tsx
index aea9c08d7a0..323fc7a7e38 100644
--- a/enterprise/frontend/src/metabase-enterprise/ai-controls/pages/MetabotUsageLimitsPage/GroupLimitsSettingsSection/GroupLimitsTab/GroupLimitsTab.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/ai-controls/pages/MetabotUsageLimitsPage/GroupLimitsSettingsSection/GroupLimitsTab/GroupLimitsTab.tsx
@@ -47,6 +47,7 @@ export function GroupLimitsTab(props: GroupLimitsTabProps) {
...map,
[limitObj.group_id]: limitObj.max_usage,
}),
+ // Unjustified type cast. FIXME
{} as GroupLimitsMap,
),
[groupLimits],
diff --git a/enterprise/frontend/src/metabase-enterprise/ai-controls/pages/MetabotUsageLimitsPage/GroupLimitsSettingsSection/TenantLimitsTab/TenantLimitsTab.tsx b/enterprise/frontend/src/metabase-enterprise/ai-controls/pages/MetabotUsageLimitsPage/GroupLimitsSettingsSection/TenantLimitsTab/TenantLimitsTab.tsx
index 658e6daa5d8..791d3bbf43f 100644
--- a/enterprise/frontend/src/metabase-enterprise/ai-controls/pages/MetabotUsageLimitsPage/GroupLimitsSettingsSection/TenantLimitsTab/TenantLimitsTab.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/ai-controls/pages/MetabotUsageLimitsPage/GroupLimitsSettingsSection/TenantLimitsTab/TenantLimitsTab.tsx
@@ -50,6 +50,7 @@ export function TenantLimitsTab(props: SpecificTenantsTabProps) {
...map,
[limitObj.tenant_id]: limitObj.max_usage,
}),
+ // Unjustified type cast. FIXME
{} as TenantLimitsMap,
),
[tenantLimits],
diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/components/InsightsLink.tsx b/enterprise/frontend/src/metabase-enterprise/audit_app/components/InsightsLink.tsx
index a3605d7ac1b..c1e84a97df3 100644
--- a/enterprise/frontend/src/metabase-enterprise/audit_app/components/InsightsLink.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/audit_app/components/InsightsLink.tsx
@@ -19,7 +19,8 @@ export const InsightsLink = ({
const collection = dashboard
? dashboard.collection
- : (question.collection() as Collection);
+ : // Unjustified type cast. FIXME
+ (question.collection() as Collection);
if (isLoading) {
return <div data-testid="loading-indicator" />;
diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/mcp-analytics/components/McpAnalyticsPage.tsx b/enterprise/frontend/src/metabase-enterprise/audit_app/mcp-analytics/components/McpAnalyticsPage.tsx
index 95244ce6890..ef8092c9325 100644
--- a/enterprise/frontend/src/metabase-enterprise/audit_app/mcp-analytics/components/McpAnalyticsPage.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/audit_app/mcp-analytics/components/McpAnalyticsPage.tsx
@@ -129,6 +129,7 @@ export function McpAnalyticsPage({ location, router }: WithRouterProps) {
.otherwise(() => (
<Tabs
value={tab}
+ // Unjustified type cast. FIXME
onChange={(val) => patchUrlState({ tab: val as McpTab })}
keepMounted={false}
>
diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/mcp-analytics/components/McpEventsTable.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/audit_app/mcp-analytics/components/McpEventsTable.unit.spec.tsx
index c64843de764..d48ea27e784 100644
--- a/enterprise/frontend/src/metabase-enterprise/audit_app/mcp-analytics/components/McpEventsTable.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/audit_app/mcp-analytics/components/McpEventsTable.unit.spec.tsx
@@ -32,9 +32,11 @@ const ALL_COLS = [
col("USER_AGENT", "User Agent"),
];
+// Unjustified type cast. FIXME
const jsQuery = { database: 1, type: "query", query: {} } as DatasetQuery;
function build(cols = ALL_COLS, hasTenants = true, hasPii = true) {
+ // Unjustified type cast. FIXME
const data = { data: { cols, rows: [[]] } } as unknown as EventsData;
const series = buildEventsRawSeries(data, jsQuery, hasTenants, hasPii);
if (!series) {
@@ -53,6 +55,7 @@ function surfacedTableColumns(
if (!("visualization_settings" in card)) {
throw new Error("expected table.columns to be set");
}
+ // Unjustified type cast. FIXME
return card.visualization_settings["table.columns"] as {
name: string;
enabled: boolean;
@@ -67,6 +70,7 @@ describe("buildEventsRawSeries", () => {
expect(buildEventsRawSeries(undefined, jsQuery, true, true)).toBeNull();
expect(
buildEventsRawSeries(
+ // Unjustified type cast. FIXME
{ data: { cols: [], rows: [] } } as unknown as EventsData,
null,
true,
@@ -80,6 +84,7 @@ describe("buildEventsRawSeries", () => {
col("WEIRD_A", "Weird A"),
col("USER_AGENT", "User Agent"),
];
+ // Unjustified type cast. FIXME
const data = {
data: { cols: foreign, rows: [[]] },
} as unknown as EventsData;
diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/components/ConversationStatsPage/BreakoutChartCard.tsx b/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/components/ConversationStatsPage/BreakoutChartCard.tsx
index f476b8ba776..51092373c34 100644
--- a/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/components/ConversationStatsPage/BreakoutChartCard.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/components/ConversationStatsPage/BreakoutChartCard.tsx
@@ -11,6 +11,7 @@ import type { DimensionClickHandler } from "./types";
// needed for visualizationIsClickable to return true when a custom handler is
// attached; handleVisualizationClick short-circuits before this action runs
const CLICKABLE_MODE: ClickActionsMode = {
+ // Unjustified type cast. FIXME
actionsForClick: () => [{ name: "custom-click" } as any],
};
diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/components/ConversationStatsPage/ConversationStatsPage.tsx b/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/components/ConversationStatsPage/ConversationStatsPage.tsx
index 9b2710e7382..d1d484b2a05 100644
--- a/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/components/ConversationStatsPage/ConversationStatsPage.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/components/ConversationStatsPage/ConversationStatsPage.tsx
@@ -294,6 +294,7 @@ export function ConversationStatsPage({ location }: WithRouterProps) {
<Tabs
variant="pills"
value={metric}
+ // Unjustified type cast. FIXME
onChange={(val) => patchUrlState({ metric: val as UsageStatsMetric })}
>
<Tabs.List className={S.metricTabs}>
diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/components/ConversationStatsPage/DataComplexityCards.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/components/ConversationStatsPage/DataComplexityCards.unit.spec.tsx
index 284289b8128..eb5ba8f77f9 100644
--- a/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/components/ConversationStatsPage/DataComplexityCards.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/components/ConversationStatsPage/DataComplexityCards.unit.spec.tsx
@@ -21,6 +21,7 @@ const mockScore = (
/* eslint-disable testing-library/no-node-access -- Snapshot cleanup is applied to a cloned DOM tree. */
const cleanForSnapshot = (element: Element) => {
+ // Unjustified type cast. FIXME
const clone = element.cloneNode(true) as Element;
clone.querySelectorAll("style").forEach((style) => style.remove());
[clone, ...Array.from(clone.querySelectorAll("*"))].forEach((node) => {
diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/components/ConversationStatsPage/breakout-raw-series.unit.spec.ts b/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/components/ConversationStatsPage/breakout-raw-series.unit.spec.ts
index 7b56f21bc32..5237a5874ee 100644
--- a/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/components/ConversationStatsPage/breakout-raw-series.unit.spec.ts
+++ b/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/components/ConversationStatsPage/breakout-raw-series.unit.spec.ts
@@ -5,6 +5,7 @@ import {
toBreakoutRawSeries,
} from "./breakout-raw-series";
+// Unjustified type cast. FIXME
const jsQuery = { database: 1, type: "query", query: {} } as DatasetQuery;
const response = (rows: unknown[][]) => ({
diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/hooks/useAdhocBreakoutQuery.ts b/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/hooks/useAdhocBreakoutQuery.ts
index 7d98b07407a..f6e39e2ad10 100644
--- a/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/hooks/useAdhocBreakoutQuery.ts
+++ b/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/hooks/useAdhocBreakoutQuery.ts
@@ -13,11 +13,13 @@ type AdhocQueryResult = {
export function useAdhocBreakoutQuery(query: Query | null): AdhocQueryResult {
const jsQuery = useMemo(
+ // Unjustified type cast. FIXME
() => (query ? (Lib.toJsQuery(query) as DatasetQuery) : null),
[query],
);
const { data, isFetching } = useGetAdhocQueryQuery(
+ // Unjustified type cast. FIXME
jsQuery ?? ({} as DatasetQuery),
{ skip: !jsQuery },
);
diff --git a/enterprise/frontend/src/metabase-enterprise/auth/components/SettingsOIDCForm/SettingsOIDCForm.tsx b/enterprise/frontend/src/metabase-enterprise/auth/components/SettingsOIDCForm/SettingsOIDCForm.tsx
index 469352b3d22..92e751c1b25 100644
--- a/enterprise/frontend/src/metabase-enterprise/auth/components/SettingsOIDCForm/SettingsOIDCForm.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/auth/components/SettingsOIDCForm/SettingsOIDCForm.tsx
@@ -246,6 +246,7 @@ export function SettingsOIDCForm() {
provider: updateData,
}).unwrap();
} else {
+ // Unjustified type cast. FIXME
await createProvider(providerData as CustomOidcConfig).unwrap();
}
},
@@ -260,6 +261,7 @@ export function SettingsOIDCForm() {
);
const { data: allGroupsData } = useListPermissionsGroupsQuery(undefined);
+ // Unjustified type cast. FIXME
const allGroups = (allGroupsData ?? []) as Group[];
const [deleteGroupMutation] = useDeletePermissionsGroupMutation();
const [clearGroupMembershipMutation] = useClearGroupMembershipMutation();
diff --git a/enterprise/frontend/src/metabase-enterprise/auth/components/SettingsSAMLForm/SettingsSAMLForm.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/auth/components/SettingsSAMLForm/SettingsSAMLForm.unit.spec.tsx
index e4c1570067f..593722d26f4 100644
--- a/enterprise/frontend/src/metabase-enterprise/auth/components/SettingsSAMLForm/SettingsSAMLForm.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/auth/components/SettingsSAMLForm/SettingsSAMLForm.unit.spec.tsx
@@ -42,6 +42,7 @@ const setup = async (
});
};
+// Unjustified type cast. FIXME
const fields = [
{ label: /SAML Identity Provider URL/i, value: "https://example.test" },
{ label: /SAML Identity Provider Certificate/i, value: "abc-123" },
diff --git a/enterprise/frontend/src/metabase-enterprise/browse/models/BrowseModels.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/browse/models/BrowseModels.unit.spec.tsx
index b01492028b5..20bca191855 100644
--- a/enterprise/frontend/src/metabase-enterprise/browse/models/BrowseModels.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/browse/models/BrowseModels.unit.spec.tsx
@@ -27,11 +27,10 @@ const setup = (modelCount: number, recentModelCount = 5) => {
// Add some instance analytics models to ensure they don't affect the page
models.push(...mockInstanceAnalyticsModels);
- const mockRecentModels = mockModels
- .slice(0, recentModelCount)
- .map((model) =>
- createMockRecentModel(model as unknown as RecentCollectionItem),
- );
+ const mockRecentModels = mockModels.slice(0, recentModelCount).map((model) =>
+ // Unjustified type cast. FIXME
+ createMockRecentModel(model as unknown as RecentCollectionItem),
+ );
setupRecentViewsEndpoints(mockRecentModels);
setupDatabasesEndpoints(databases);
setupSearchEndpoints(models);
diff --git a/enterprise/frontend/src/metabase-enterprise/caching/components/StrategyEditorForQuestionsAndDashboards/StrategyEditorForQuestionsAndDashboards.tsx b/enterprise/frontend/src/metabase-enterprise/caching/components/StrategyEditorForQuestionsAndDashboards/StrategyEditorForQuestionsAndDashboards.tsx
index 26ff58f7435..757c2644146 100644
--- a/enterprise/frontend/src/metabase-enterprise/caching/components/StrategyEditorForQuestionsAndDashboards/StrategyEditorForQuestionsAndDashboards.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/caching/components/StrategyEditorForQuestionsAndDashboards/StrategyEditorForQuestionsAndDashboards.tsx
@@ -52,6 +52,7 @@ export const StrategyEditorForQuestionsAndDashboards = () => {
// Handle sort column click
const handleSort = useCallback(
(columnName: string, direction: SortDirection) => {
+ // Unjustified type cast. FIXME
setSortColumn(columnName as CacheSortColumn);
setSortDirection(direction);
resetPage();
diff --git a/enterprise/frontend/src/metabase-enterprise/caching/components/StrategyEditorForQuestionsAndDashboards/TableRowForCacheableItem.tsx b/enterprise/frontend/src/metabase-enterprise/caching/components/StrategyEditorForQuestionsAndDashboards/TableRowForCacheableItem.tsx
index 2f2304537bb..55934c1bd1a 100644
--- a/enterprise/frontend/src/metabase-enterprise/caching/components/StrategyEditorForQuestionsAndDashboards/TableRowForCacheableItem.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/caching/components/StrategyEditorForQuestionsAndDashboards/TableRowForCacheableItem.tsx
@@ -37,6 +37,7 @@ export const TableRowForCacheableItem = ({
: null;
const url = useMemo(
+ // Unjustified type cast. FIXME
() => getItemUrl(model, item as { id: number; name: string }) || undefined,
[model, item],
);
diff --git a/enterprise/frontend/src/metabase-enterprise/caching/components/StrategyEditorForQuestionsAndDashboards/utils.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/caching/components/StrategyEditorForQuestionsAndDashboards/utils.unit.spec.tsx
index 9d6fb992e89..102651dc29f 100644
--- a/enterprise/frontend/src/metabase-enterprise/caching/components/StrategyEditorForQuestionsAndDashboards/utils.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/caching/components/StrategyEditorForQuestionsAndDashboards/utils.unit.spec.tsx
@@ -149,7 +149,9 @@ describe("StrategyEditorForQuestionsAndDashboards utilities", () => {
it("sorts by policy correctly", () => {
const sorted = unsortedRows.sort((rowA, rowB) => {
+ // Unjustified type cast. FIXME
const a = formatValueForSorting(rowA, "policy") as string;
+ // Unjustified type cast. FIXME
const b = formatValueForSorting(rowB, "policy") as string;
return a.localeCompare(b);
});
@@ -170,7 +172,9 @@ describe("StrategyEditorForQuestionsAndDashboards utilities", () => {
it("sorts by collection correctly", () => {
const sorted = unsortedRows.sort((rowA, rowB) => {
+ // Unjustified type cast. FIXME
const a = formatValueForSorting(rowA, "collection") as string;
+ // Unjustified type cast. FIXME
const b = formatValueForSorting(rowB, "collection") as string;
return a.localeCompare(b);
});
diff --git a/enterprise/frontend/src/metabase-enterprise/caching/components/utils.tsx b/enterprise/frontend/src/metabase-enterprise/caching/components/utils.tsx
index 17322e8cf3e..3cd89c42922 100644
--- a/enterprise/frontend/src/metabase-enterprise/caching/components/utils.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/caching/components/utils.tsx
@@ -10,16 +10,20 @@ export const getItemId = (
item: CacheableDashboard | Question,
) =>
model === "dashboard"
- ? (item as CacheableDashboard).id
- : (item as Question).id();
+ ? // Unjustified type cast. FIXME
+ (item as CacheableDashboard).id
+ : // Unjustified type cast. FIXME
+ (item as Question).id();
export const getItemName = (
model: CacheableModel,
item: CacheableDashboard | Question,
) =>
model === "dashboard"
- ? (item as CacheableDashboard).name
- : ((item as Question).displayName() ?? t`Untitled question`);
+ ? // Unjustified type cast. FIXME
+ (item as CacheableDashboard).name
+ : // Unjustified type cast. FIXME
+ ((item as Question).displayName() ?? t`Untitled question`);
export const getItemUrl = (
model: CacheableModel,
diff --git a/enterprise/frontend/src/metabase-enterprise/clean_up/CleanupCollectionModal/CleanupCollectionBulkActions.tsx b/enterprise/frontend/src/metabase-enterprise/clean_up/CleanupCollectionModal/CleanupCollectionBulkActions.tsx
index fd874e62eb2..025897db9af 100644
--- a/enterprise/frontend/src/metabase-enterprise/clean_up/CleanupCollectionModal/CleanupCollectionBulkActions.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/clean_up/CleanupCollectionModal/CleanupCollectionBulkActions.tsx
@@ -33,6 +33,7 @@ export const CleanupCollectionBulkActions = ({
const handleUndo = async (items: StaleCollectionItem[]) => {
return Promise.all(
items.map((item) =>
+ // Unjustified type cast. FIXME
archive(item as ArchivableItem, false, { notify: false }),
),
)
@@ -44,6 +45,7 @@ export const CleanupCollectionBulkActions = ({
const actions = selected.map((item) => {
return archiveAndTrack({
archive: async () => {
+ // Unjustified type cast. FIXME
await archive(item as ArchivableItem, true, { notify: false });
},
model: item.model,
@@ -66,6 +68,7 @@ export const CleanupCollectionBulkActions = ({
onArchive({ totalArchivedItems });
const id = Date.now();
+ // Unjustified type cast. FIXME
const timeoutId = setTimeout(() => {
setUndo((undo) => (undo?.id === id ? undefined : undo));
}, 5000) as unknown as number;
diff --git a/enterprise/frontend/src/metabase-enterprise/collections/components/CollectionAuthorityLevelDisplay.tsx b/enterprise/frontend/src/metabase-enterprise/collections/components/CollectionAuthorityLevelDisplay.tsx
index 3fd9a3fdfc2..09da7cb167a 100644
--- a/enterprise/frontend/src/metabase-enterprise/collections/components/CollectionAuthorityLevelDisplay.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/collections/components/CollectionAuthorityLevelDisplay.tsx
@@ -14,6 +14,7 @@ export const CollectionAuthorityLevelDisplay = ({
const getIcon = PLUGIN_COLLECTIONS.useGetIcon();
const iconProps = useMemo(
() =>
+ // Unjustified type cast. FIXME
getIcon({
...collection,
model: "collection",
diff --git a/enterprise/frontend/src/metabase-enterprise/collections/constants.ts b/enterprise/frontend/src/metabase-enterprise/collections/constants.ts
index 47bf2100f04..d4ba4bb7419 100644
--- a/enterprise/frontend/src/metabase-enterprise/collections/constants.ts
+++ b/enterprise/frontend/src/metabase-enterprise/collections/constants.ts
@@ -56,4 +56,5 @@ export const COLLECTION_TYPES: Record<
};
export const CUSTOM_INSTANCE_ANALYTICS_COLLECTION_ENTITY_ID =
+ // Unjustified type cast. FIXME
"okNLSZKdSxaoG58JSQY54" as BaseEntityId;
diff --git a/enterprise/frontend/src/metabase-enterprise/collections/utils.ts b/enterprise/frontend/src/metabase-enterprise/collections/utils.ts
index b1751c76ca8..7640a397e85 100644
--- a/enterprise/frontend/src/metabase-enterprise/collections/utils.ts
+++ b/enterprise/frontend/src/metabase-enterprise/collections/utils.ts
@@ -67,6 +67,7 @@ export const useGetIcon = () => {
{ isTenantUser = false }: { isTenantUser?: boolean } = {},
): IconData => {
const collectionType = getCollectionType({
+ // Unjustified type cast. FIXME
type: (item.type as CollectionType) || item.collection_type,
}).type;
if (collectionType === "instance-analytics") {
diff --git a/enterprise/frontend/src/metabase-enterprise/content_translation/tests/utils.unit.spec.ts b/enterprise/frontend/src/metabase-enterprise/content_translation/tests/utils.unit.spec.ts
index 8a578225184..a35e47decb7 100644
--- a/enterprise/frontend/src/metabase-enterprise/content_translation/tests/utils.unit.spec.ts
+++ b/enterprise/frontend/src/metabase-enterprise/content_translation/tests/utils.unit.spec.ts
@@ -47,12 +47,15 @@ describe("content translation utils", () => {
});
it("should return msgid when msgid is not a string", () => {
+ // Unjustified type cast. FIXME
expect(translateContentString(mockDictionary, "es", 123 as any)).toBe(
123,
);
+ // Unjustified type cast. FIXME
expect(translateContentString(mockDictionary, "es", {} as any)).toEqual(
{},
);
+ // Unjustified type cast. FIXME
expect(translateContentString(mockDictionary, "es", [] as any)).toEqual(
[],
);
diff --git a/enterprise/frontend/src/metabase-enterprise/content_translation/utils.ts b/enterprise/frontend/src/metabase-enterprise/content_translation/utils.ts
index 5de413f41c0..6bfd6081baa 100644
--- a/enterprise/frontend/src/metabase-enterprise/content_translation/utils.ts
+++ b/enterprise/frontend/src/metabase-enterprise/content_translation/utils.ts
@@ -42,6 +42,7 @@ export function translateContentString<T>(
}
if (Array.isArray(rawMsgid)) {
+ // Unjustified type cast. FIXME
return rawMsgid.map((msgid) =>
translateContentString(dictionary, locale, msgid),
) as T;
@@ -147,6 +148,7 @@ export const translateDisplayNames = <T>({
const traverse = (element: T): T => {
if (Array.isArray(element)) {
+ // Unjustified type cast. FIXME
return element.map((item) => traverse(item)) as T;
}
@@ -166,7 +168,8 @@ export const translateDisplayNames = <T>({
tc,
locale,
})
- : traverse(value as T);
+ : // Unjustified type cast. FIXME
+ traverse(value as T);
return I.assoc(acc, key, newValue);
}, element);
diff --git a/enterprise/frontend/src/metabase-enterprise/content_translation/utils.unit.spec.ts b/enterprise/frontend/src/metabase-enterprise/content_translation/utils.unit.spec.ts
index 916e4f8d46d..e3f3611047b 100644
--- a/enterprise/frontend/src/metabase-enterprise/content_translation/utils.unit.spec.ts
+++ b/enterprise/frontend/src/metabase-enterprise/content_translation/utils.unit.spec.ts
@@ -33,6 +33,7 @@ const mockTranslateWithoutTranslations: ContentTranslationFunction =
describe("translateFieldValuesInSeries", () => {
it("should return original series when translation function has no translations", () => {
const series: Series = [
+ // Unjustified type cast. FIXME
{
data: {
rows: [
@@ -52,6 +53,7 @@ describe("translateFieldValuesInSeries", () => {
it("should return original series item when it has no data", () => {
const series: Series = [
+ // Unjustified type cast. FIXME
{
card: { name: "Test Chart" },
} as SingleSeries,
@@ -70,6 +72,7 @@ describe("translateFieldValuesInSeries", () => {
it("should translate field values in regular series data", () => {
const series: Series = [
+ // Unjustified type cast. FIXME
{
data: {
rows: [
@@ -99,6 +102,7 @@ describe("translateFieldValuesInSeries", () => {
it("should handle mixed data types in rows", () => {
const series: Series = [
+ // Unjustified type cast. FIXME
{
data: {
rows: [
@@ -122,6 +126,7 @@ describe("translateFieldValuesInSeries", () => {
describe("for pies", () => {
it("should handle pie.rows visualization settings", () => {
const series: Series = [
+ // Unjustified type cast. FIXME
{
card: {
display: "pie",
@@ -158,6 +163,7 @@ describe("translateFieldValuesInSeries", () => {
it("should handle NO pie.rows visualization settings", () => {
const series: Series = [
+ // Unjustified type cast. FIXME
{
card: {
display: "pie",
@@ -198,6 +204,7 @@ describe("translateFieldValuesInSeries", () => {
};
const series: Series = [
+ // Unjustified type cast. FIXME
{
card: {
display: displayType,
@@ -228,6 +235,7 @@ describe("translateFieldValuesInSeries", () => {
it("should handle NO series_settings visualization settings", () => {
const series: Series = [
+ // Unjustified type cast. FIXME
{
card: {
display: displayType,
@@ -257,11 +265,13 @@ describe("translateFieldValuesInSeries", () => {
it("should handle multiple series", () => {
const series: Series = [
+ // Unjustified type cast. FIXME
{
data: {
rows: [["apple", 10]],
},
} as SingleSeries,
+ // Unjustified type cast. FIXME
{
data: {
rows: [["banana", 20]],
@@ -280,6 +290,7 @@ describe("translateFieldValuesInSeries", () => {
it("should handle empty rows", () => {
const series: Series = [
+ // Unjustified type cast. FIXME
{
data: createMockDatasetData({
rows: [],
diff --git a/enterprise/frontend/src/metabase-enterprise/custom_viz/custom-viz-plugins.tsx b/enterprise/frontend/src/metabase-enterprise/custom_viz/custom-viz-plugins.tsx
index acf77e064c1..edb8d1cc64e 100644
--- a/enterprise/frontend/src/metabase-enterprise/custom_viz/custom-viz-plugins.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/custom_viz/custom-viz-plugins.tsx
@@ -376,6 +376,7 @@ export async function loadCustomVizPlugin(
const props: CreateCustomVisualizationProps<Record<string, unknown>> = {
defineSetting(definition) {
+ // Unjustified type cast. FIXME
return definition as unknown as CustomVisualizationSettingDefinition<
Record<string, unknown>
>;
@@ -515,12 +516,15 @@ function createCustomVizWrapper(
const pluginProps: GenericVizPluginProps = {
width,
height,
+ // Unjustified type cast. FIXME
series: series as unknown as GenericVizPluginProps["series"],
settings,
colorScheme: resolvedColorScheme,
+ // Unjustified type cast. FIXME
onClick: onVisualizationClick as unknown as (
clickObject: CustomVizClickObject<Record<string, unknown>> | null,
) => void,
+ // Unjustified type cast. FIXME
onHover: onHoverChange as unknown as (
hoverObject?: CustomVizHoverObject | null,
) => void,
diff --git a/enterprise/frontend/src/metabase-enterprise/custom_viz/custom-viz-settings.ts b/enterprise/frontend/src/metabase-enterprise/custom_viz/custom-viz-settings.ts
index e625f01351e..caca56d7e42 100644
--- a/enterprise/frontend/src/metabase-enterprise/custom_viz/custom-viz-settings.ts
+++ b/enterprise/frontend/src/metabase-enterprise/custom_viz/custom-viz-settings.ts
@@ -42,7 +42,9 @@ export function sanitizePluginSettings(
}
if ("widget" in value && typeof value.widget === "function") {
+ // Unjustified type cast. FIXME
const Widget = value.widget as ComponentType<Record<string, unknown>>;
+ // Unjustified type cast. FIXME
sanitizedSettings[settingId] = {
...value,
widget: wrapPluginWidget(
@@ -79,6 +81,7 @@ function assertValidSettingWidgets(
return;
}
for (const [settingId, def] of Object.entries(settings)) {
+ // Unjustified type cast. FIXME
const widget = (def as { widget?: unknown }).widget;
if (
typeof widget === "string" &&
diff --git a/enterprise/frontend/src/metabase-enterprise/custom_viz/sandbox/distortions-blocked-apis.ts b/enterprise/frontend/src/metabase-enterprise/custom_viz/sandbox/distortions-blocked-apis.ts
index cc687a62552..95ca5c26854 100644
--- a/enterprise/frontend/src/metabase-enterprise/custom_viz/sandbox/distortions-blocked-apis.ts
+++ b/enterprise/frontend/src/metabase-enterprise/custom_viz/sandbox/distortions-blocked-apis.ts
@@ -1,6 +1,7 @@
export const BLOCKED_NATIVE_REFS = new Map<object, string>();
const method = (proto: object, key: string): object | undefined =>
+ // Unjustified type cast. FIXME
Object.getOwnPropertyDescriptor(proto, key)?.value as object | undefined;
const getter = (proto: object, key: string): object | undefined =>
diff --git a/enterprise/frontend/src/metabase-enterprise/custom_viz/sandbox/distortions-dom-mutate.ts b/enterprise/frontend/src/metabase-enterprise/custom_viz/sandbox/distortions-dom-mutate.ts
index 9ce7922aacb..ad3bfb47e9b 100644
--- a/enterprise/frontend/src/metabase-enterprise/custom_viz/sandbox/distortions-dom-mutate.ts
+++ b/enterprise/frontend/src/metabase-enterprise/custom_viz/sandbox/distortions-dom-mutate.ts
@@ -154,6 +154,7 @@ export function createElementNSDistortion(pluginId: CustomVizPluginId) {
this,
namespaceURI,
qualifiedName,
+ // Unjustified type cast. FIXME
options as ElementCreationOptions,
);
};
diff --git a/enterprise/frontend/src/metabase-enterprise/custom_viz/sandbox/distortions-dom-read.ts b/enterprise/frontend/src/metabase-enterprise/custom_viz/sandbox/distortions-dom-read.ts
index 659c71cc2b7..03bf56154be 100644
--- a/enterprise/frontend/src/metabase-enterprise/custom_viz/sandbox/distortions-dom-read.ts
+++ b/enterprise/frontend/src/metabase-enterprise/custom_viz/sandbox/distortions-dom-read.ts
@@ -48,6 +48,7 @@ export function getSafeSandboxDomNode(
function getOwnerElement(node: Node): Element | null {
if (node.nodeType === Node.ELEMENT_NODE) {
+ // Unjustified type cast. FIXME
return node as Element;
}
@@ -66,6 +67,7 @@ function getOwnerElement(node: Node): Element | null {
// "nothing focused inside my React tree" rather than a fake element.
export function activeElementDistortion(pluginId: CustomVizPluginId) {
return function activeElement(this: Document): Element | null {
+ // Unjustified type cast. FIXME
const el = ACTIVE_ELEMENT_GETTER!.call(this) as Element | null;
if (!el) {
return null;
diff --git a/enterprise/frontend/src/metabase-enterprise/custom_viz/sandbox/index.ts b/enterprise/frontend/src/metabase-enterprise/custom_viz/sandbox/index.ts
index 2e8d2637296..04a84431758 100644
--- a/enterprise/frontend/src/metabase-enterprise/custom_viz/sandbox/index.ts
+++ b/enterprise/frontend/src/metabase-enterprise/custom_viz/sandbox/index.ts
@@ -50,6 +50,7 @@ export async function createPluginSandbox(
// unwrap membrane-proxied Error
let message: string;
try {
+ // Unjustified type cast. FIXME
message = String((e as { message?: unknown })?.message ?? e);
} catch {
message = "Unknown error inside plugin sandbox";
diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/library/LibraryPage/components/PublishTableModal.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/library/LibraryPage/components/PublishTableModal.unit.spec.tsx
index d877fd5c496..3bcca8075aa 100644
--- a/enterprise/frontend/src/metabase-enterprise/data-studio/library/LibraryPage/components/PublishTableModal.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/library/LibraryPage/components/PublishTableModal.unit.spec.tsx
@@ -86,6 +86,7 @@ function setup({
collection: { id: 6464 },
collectionItems: [
createMockCollectionItem({
+ // Unjustified type cast. FIXME
id: dataCollection.id as number,
name: dataCollection.name,
model: "collection",
diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/library/LibraryPage/hooks/useLibraryCollectionTree.ts b/enterprise/frontend/src/metabase-enterprise/data-studio/library/LibraryPage/hooks/useLibraryCollectionTree.ts
index cf5b4b30ee9..752db6495e6 100644
--- a/enterprise/frontend/src/metabase-enterprise/data-studio/library/LibraryPage/hooks/useLibraryCollectionTree.ts
+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/library/LibraryPage/hooks/useLibraryCollectionTree.ts
@@ -149,6 +149,7 @@ export function useLibraryCollectionTree(
!isEmptyStateData(original.data) &&
"id" in original.data
) {
+ // Unjustified type cast. FIXME
loadCollectionItems(original.data.id as number);
}
}
diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/library/LibraryPage/hooks/useLibraryTreeTableInstance.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/library/LibraryPage/hooks/useLibraryTreeTableInstance.tsx
index 5b69b9386ab..7b682ad93c7 100644
--- a/enterprise/frontend/src/metabase-enterprise/data-studio/library/LibraryPage/hooks/useLibraryTreeTableInstance.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/library/LibraryPage/hooks/useLibraryTreeTableInstance.tsx
@@ -52,6 +52,7 @@ export function useLibraryTreeTableInstance({
}
const ids = Array.isArray(rawIds) ? rawIds : [rawIds];
+ // Unjustified type cast. FIXME
return _.object(
ids.map((id) => [`collection:${id}`, true]),
) as ExpandedState;
@@ -181,6 +182,7 @@ export function useLibraryTreeTableInstance({
if (row.original.model === "empty-state") {
return null;
}
+ // Unjustified type cast. FIXME
const dateValue = getValue() as string | undefined;
return dateValue ? <DateTime value={dateValue} /> : null;
},
@@ -276,6 +278,7 @@ export function useLibraryTreeTableInstance({
}
// Not loaded yet — check here/below from the API to know if expandable
if (!isEmptyStateData(data) && "here" in data) {
+ // Unjustified type cast. FIXME
const item = data as { here?: string[]; below?: string[] };
return (
(item.here != null && item.here.length > 0) ||
diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/library/LibraryPage/utils.ts b/enterprise/frontend/src/metabase-enterprise/data-studio/library/LibraryPage/utils.ts
index 9004ad5e73b..dbb44418355 100644
--- a/enterprise/frontend/src/metabase-enterprise/data-studio/library/LibraryPage/utils.ts
+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/library/LibraryPage/utils.ts
@@ -26,6 +26,7 @@ export const getTreeRowHref = (row: { original: TreeItem }): string | null => {
if (treeItem.model === "empty-state" || isEmptyStateData(treeItem.data)) {
return null;
}
+ // Unjustified type cast. FIXME
const entityId = treeItem.data.id as number;
if (treeItem.model === "metric") {
return Urls.dataStudioMetric(entityId);
diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/library/components/PublishTablesModal/PublishTablesModal.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/library/components/PublishTablesModal/PublishTablesModal.unit.spec.tsx
index 2b59b607098..7dd01043bb1 100644
--- a/enterprise/frontend/src/metabase-enterprise/data-studio/library/components/PublishTablesModal/PublishTablesModal.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/library/components/PublishTablesModal/PublishTablesModal.unit.spec.tsx
@@ -63,6 +63,7 @@ function setup({
collection: { id: 6464 },
collectionItems: [
createMockCollectionItem({
+ // Unjustified type cast. FIXME
id: dataCollection.id as number,
name: dataCollection.name,
model: "collection",
@@ -82,6 +83,7 @@ function setup({
setupRootCollectionItemsEndpoint({
rootCollectionItems: [
createMockCollectionItem({
+ // Unjustified type cast. FIXME
id: dataCollection.id as number,
name: dataCollection.name,
model: "collection",
diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/library/tables/components/TableHeader/TableMoreMenu/TableMoreMenu.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/library/tables/components/TableHeader/TableMoreMenu/TableMoreMenu.unit.spec.tsx
index a22c7c3639b..8c15b1030d4 100644
--- a/enterprise/frontend/src/metabase-enterprise/data-studio/library/tables/components/TableHeader/TableMoreMenu/TableMoreMenu.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/library/tables/components/TableHeader/TableMoreMenu/TableMoreMenu.unit.spec.tsx
@@ -73,6 +73,7 @@ const setup = ({ table, remoteSyncType, onMoved }: SetupOpts = {}) => {
id: 1,
db_id: 1,
schema: "PUBLIC",
+ // Unjustified type cast. FIXME
collection_id: dataCollection.id as number,
});
@@ -117,6 +118,7 @@ const setup = ({ table, remoteSyncType, onMoved }: SetupOpts = {}) => {
collection: { id: 6464 },
collectionItems: [
createMockCollectionItem({
+ // Unjustified type cast. FIXME
id: dataCollection.id as number,
name: dataCollection.name,
model: "collection",
@@ -134,11 +136,13 @@ const setup = ({ table, remoteSyncType, onMoved }: SetupOpts = {}) => {
collection: dataCollection,
collectionItems: [
createMockCollectionItem({
+ // Unjustified type cast. FIXME
id: destinationCollection.id as number,
name: destinationCollection.name,
model: "collection",
type: destinationCollection.type,
can_write: destinationCollection.can_write,
+ // Unjustified type cast. FIXME
collection_id: dataCollection.id as number,
location: "/6464/10/",
here: ["table"],
@@ -240,6 +244,7 @@ describe("TableMoreMenu", () => {
model: "table",
name: "Orders",
database_id: 1,
+ // Unjustified type cast. FIXME
collection_id: dataCollection.id as number,
});
diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/library/tables/pages/TableMeasuresPage/TableMeasures.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/library/tables/pages/TableMeasuresPage/TableMeasures.tsx
index f96032a2e6e..28f2d7a0d3e 100644
--- a/enterprise/frontend/src/metabase-enterprise/data-studio/library/tables/pages/TableMeasuresPage/TableMeasures.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/library/tables/pages/TableMeasuresPage/TableMeasures.tsx
@@ -36,6 +36,7 @@ export function TableMeasures({ table }: TableMeasuresProps) {
? {
label: t`New measure`,
trackClickEvent: () =>
+ // Unjustified type cast. FIXME
trackMeasureCreateStarted(table.id as ConcreteTableId),
url: Urls.dataStudioPublishedTableMeasureNew(table.id),
}
diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/library/tables/pages/TableSegmentsPage/TableSegments.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/library/tables/pages/TableSegmentsPage/TableSegments.tsx
index 399429c4829..7c328f81974 100644
--- a/enterprise/frontend/src/metabase-enterprise/data-studio/library/tables/pages/TableSegmentsPage/TableSegments.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/library/tables/pages/TableSegmentsPage/TableSegments.tsx
@@ -39,6 +39,7 @@ export function TableSegments({ table }: TableSegmentsProps) {
trackClickEvent: () =>
trackSegmentCreateStarted(
"data_studio_segments",
+ // Unjustified type cast. FIXME
table.id as ConcreteTableId,
),
}
diff --git a/enterprise/frontend/src/metabase-enterprise/database_replication/DatabaseReplicationForm.tsx b/enterprise/frontend/src/metabase-enterprise/database_replication/DatabaseReplicationForm.tsx
index f394ad4fb59..5187d722d77 100644
--- a/enterprise/frontend/src/metabase-enterprise/database_replication/DatabaseReplicationForm.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/database_replication/DatabaseReplicationForm.tsx
@@ -168,6 +168,7 @@ export const DatabaseReplicationForm = ({
label={t`Select schemas to replicate`}
onChange={(value) =>
setSchemaFiltersType(
+ // Unjustified type cast. FIXME
value as typeof initialValues.schemaFiltersType,
)
}
diff --git a/enterprise/frontend/src/metabase-enterprise/database_routing/DestinationDatabasesList/DestinationDatabasesList.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/database_routing/DestinationDatabasesList/DestinationDatabasesList.unit.spec.tsx
index 2ac9ebd48be..e90b991026b 100644
--- a/enterprise/frontend/src/metabase-enterprise/database_routing/DestinationDatabasesList/DestinationDatabasesList.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/database_routing/DestinationDatabasesList/DestinationDatabasesList.unit.spec.tsx
@@ -37,6 +37,7 @@ function setup({
.map((_, i) => createMockDatabase({ id: i + 2 }));
mockDbs.forEach((db) => setupDatabaseEndpoints(db));
+ // Unjustified type cast. FIXME
(useListDatabasesQuery as jest.Mock).mockReturnValue(
// eslint-disable-next-line react-hooks/rules-of-hooks
useListDatabasesQueryMockValue?.(mockDbs) ?? {
diff --git a/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyGraph/GraphEntryInput/EntryPickerModal/utils.ts b/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyGraph/GraphEntryInput/EntryPickerModal/utils.ts
index f3ea7bc2f1c..83f40ceff56 100644
--- a/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyGraph/GraphEntryInput/EntryPickerModal/utils.ts
+++ b/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyGraph/GraphEntryInput/EntryPickerModal/utils.ts
@@ -123,6 +123,7 @@ export function getEntryPickerValue(
return;
}
+ // Unjustified type cast. FIXME
const groupType = SEARCH_MODEL_TO_GROUP_TYPE[item.model as SearchModel];
if (groupType != null) {
return { id: item.id, type: getDependencyType(groupType) };
diff --git a/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyGraph/GraphEntryInput/EntrySearchInput/SearchModelPicker/SearchModelPicker.tsx b/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyGraph/GraphEntryInput/EntrySearchInput/SearchModelPicker/SearchModelPicker.tsx
index fc11a50817c..d9ad7a10c60 100644
--- a/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyGraph/GraphEntryInput/EntrySearchInput/SearchModelPicker/SearchModelPicker.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyGraph/GraphEntryInput/EntrySearchInput/SearchModelPicker/SearchModelPicker.tsx
@@ -67,6 +67,7 @@ function SearchModelPopover({
const items = data ? getSearchModelItems(data) : [];
const handleChange = (value: string[]) => {
+ // Unjustified type cast. FIXME
onSearchModelsChange(value as SearchModel[]);
};
diff --git a/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/data-model-permission.ts b/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/data-model-permission.ts
index 8d0a51bb00f..f593706ea88 100644
--- a/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/data-model-permission.ts
+++ b/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/data-model-permission.ts
@@ -70,6 +70,7 @@ const getPermissionValue = (
return getFieldsPermission(
permissions,
groupId,
+ // Unjustified type cast. FIXME
entityId as TableEntityId,
DataPermission.DATA_MODEL,
);
@@ -77,6 +78,7 @@ const getPermissionValue = (
return getTablesPermission(
permissions,
groupId,
+ // Unjustified type cast. FIXME
entityId as SchemaEntityId,
DataPermission.DATA_MODEL,
);
diff --git a/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/data-model-permission.unit.spec.ts b/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/data-model-permission.unit.spec.ts
index 222e7bcde0e..35b02391988 100644
--- a/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/data-model-permission.unit.spec.ts
+++ b/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/data-model-permission.unit.spec.ts
@@ -16,6 +16,7 @@ const groupId = 2;
const databaseId = 1;
const getPermissionGraph = (value = "all"): GroupsPermissions =>
+ // Unjustified type cast. FIXME
({
[defaultGroupId]: {
[databaseId]: {
@@ -37,6 +38,7 @@ const adminGroupType: SpecialGroupType = "admin";
const regularGroupType: SpecialGroupType = null;
const analystGroupType: SpecialGroupType = "analyst";
+// Unjustified type cast. FIXME
const defaultGroup: Group = {
id: defaultGroupId,
name: "All Users",
diff --git a/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/details-permission.unit.spec.ts b/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/details-permission.unit.spec.ts
index 1b8c7813e05..f2f9af29bbb 100644
--- a/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/details-permission.unit.spec.ts
+++ b/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/details-permission.unit.spec.ts
@@ -15,6 +15,7 @@ const groupId = 2;
const databaseId = 1;
const getPermissionGraph = (value = "yes"): GroupsPermissions =>
+ // Unjustified type cast. FIXME
({
[defaultGroupId]: {
[databaseId]: {
@@ -32,6 +33,7 @@ const isAdmin = true;
const isNotAdmin = false;
const isNotExternal = false;
+// Unjustified type cast. FIXME
const defaultGroup: Group = {
id: defaultGroupId,
name: "All Users",
diff --git a/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/download-permission.ts b/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/download-permission.ts
index af3a01e764e..64cf74925b1 100644
--- a/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/download-permission.ts
+++ b/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/download-permission.ts
@@ -90,6 +90,7 @@ const getPermissionValue = (
return getFieldsPermission(
permissions,
groupId,
+ // Unjustified type cast. FIXME
entityId as TableEntityId,
permission,
);
@@ -97,6 +98,7 @@ const getPermissionValue = (
return getTablesPermission(
permissions,
groupId,
+ // Unjustified type cast. FIXME
entityId as SchemaEntityId,
permission,
);
diff --git a/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/index.unit.spec.ts b/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/index.unit.spec.ts
index a7e5d7edea2..df0df6cf24d 100644
--- a/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/index.unit.spec.ts
+++ b/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/index.unit.spec.ts
@@ -13,6 +13,7 @@ const groupType = null;
const databaseId = 1;
const getPermissionGraph = (): GroupsPermissions =>
+ // Unjustified type cast. FIXME
({
[defaultGroupId]: {
[databaseId]: {
@@ -36,6 +37,7 @@ const getPermissionGraph = (): GroupsPermissions =>
},
}) as any;
+// Unjustified type cast. FIXME
const defaultGroup: Group = {
id: defaultGroupId,
name: "All Users",
diff --git a/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/transforms-permission.unit.spec.ts b/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/transforms-permission.unit.spec.ts
index e1f1c6d8166..98a420d1ba6 100644
--- a/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/transforms-permission.unit.spec.ts
+++ b/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/transforms-permission.unit.spec.ts
@@ -22,6 +22,7 @@ const getPermissionGraph = ({
viewDataValue?: string;
createQueriesValue?: string;
} = {}): GroupsPermissions =>
+ // Unjustified type cast. FIXME
({
[defaultGroupId]: {
[databaseId]: {
@@ -42,6 +43,7 @@ const getPermissionGraph = ({
const isAdmin = true;
const isNotAdmin = false;
+// Unjustified type cast. FIXME
const defaultGroup: Group = {
id: defaultGroupId,
name: "All Users",
@@ -108,6 +110,7 @@ describe("buildTransformsPermission", () => {
});
it("returns 'no' value when transforms permission is not set in graph", () => {
+ // Unjustified type cast. FIXME
const permissions = {
[defaultGroupId]: {
[databaseId]: {
@@ -285,6 +288,7 @@ describe("buildTransformsPermission", () => {
});
it("does not show warning when group has same or higher permission than default group", () => {
+ // Unjustified type cast. FIXME
const permissions = {
[defaultGroupId]: {
[databaseId]: {
diff --git a/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveConnectionModal.tsx b/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveConnectionModal.tsx
index e5758fb7e85..cdc48f42f4d 100644
--- a/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveConnectionModal.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveConnectionModal.tsx
@@ -145,6 +145,7 @@ function GoogleSheetsConnectModal({
value={linkType}
onChange={setLinkType}
data={
+ // Unjustified type cast. FIXME
[
{ value: "folder", label: t`Entire folder` },
{ value: "file", label: t`Single Sheet` },
diff --git a/enterprise/frontend/src/metabase-enterprise/model_persistence/components/ModelCacheControl/ModelCacheControl.tsx b/enterprise/frontend/src/metabase-enterprise/model_persistence/components/ModelCacheControl/ModelCacheControl.tsx
index fc3f8f1117d..10739c9d3ef 100644
--- a/enterprise/frontend/src/metabase-enterprise/model_persistence/components/ModelCacheControl/ModelCacheControl.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/model_persistence/components/ModelCacheControl/ModelCacheControl.tsx
@@ -50,6 +50,7 @@ export function ModelCacheToggle({
isLoading: isLoadingDb,
error: dbError,
} = useGetDatabaseQuery(
+ // Unjustified type cast. FIXME
model.databaseId() ? { id: model.databaseId() as number } : skipToken,
);
diff --git a/enterprise/frontend/src/metabase-enterprise/moderation/hooks/useMenuItems.tsx b/enterprise/frontend/src/metabase-enterprise/moderation/hooks/useMenuItems.tsx
index 53d1c2414ae..b79d9bdcfe1 100644
--- a/enterprise/frontend/src/metabase-enterprise/moderation/hooks/useMenuItems.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/moderation/hooks/useMenuItems.tsx
@@ -38,6 +38,7 @@ export const useDashboardMenuItems = (
return useMenuItems({
reload,
+ // Unjustified type cast. FIXME
moderated_item_id: dashboard.id as number,
moderated_item_type: "dashboard",
latestModerationReview,
diff --git a/enterprise/frontend/src/metabase-enterprise/moderation/service.ts b/enterprise/frontend/src/metabase-enterprise/moderation/service.ts
index ed665c795fe..c3273cd9fec 100644
--- a/enterprise/frontend/src/metabase-enterprise/moderation/service.ts
+++ b/enterprise/frontend/src/metabase-enterprise/moderation/service.ts
@@ -156,6 +156,7 @@ export function getModerationTimelineEvents(
export const getQuestionIcon = (card: any) => {
return (card.model === "dataset" || card.type === "model") &&
card.moderated_status === "verified"
- ? { icon: "model_with_badge" as IconName, tooltip: "Verified model" }
+ ? // Unjustified type cast. FIXME
+ { icon: "model_with_badge" as IconName, tooltip: "Verified model" }
: null;
};
diff --git a/enterprise/frontend/src/metabase-enterprise/moderation/service.unit.spec.ts b/enterprise/frontend/src/metabase-enterprise/moderation/service.unit.spec.ts
index 272be94eef6..3021e008db0 100644
--- a/enterprise/frontend/src/metabase-enterprise/moderation/service.unit.spec.ts
+++ b/enterprise/frontend/src/metabase-enterprise/moderation/service.unit.spec.ts
@@ -182,6 +182,7 @@ describe("moderation/service", () => {
describe("getStatusIconForQuestion", () => {
it('should return the status icon for the most recent "real" review', () => {
+ // Unjustified type cast. FIXME
const questionWithReviews = {
getModerationReviews: () => [
{ id: 1, status: "verified" },
@@ -199,6 +200,7 @@ describe("moderation/service", () => {
});
it("should return undefined vals for no review", () => {
+ // Unjustified type cast. FIXME
const questionWithNoMostRecentReview = {
getModerationReviews: () => [
{ moderator_id: 0, created_at: "", status: "verified" },
@@ -207,10 +209,12 @@ describe("moderation/service", () => {
],
} as unknown as Question;
+ // Unjustified type cast. FIXME
const questionWithNoReviews = {
getModerationReviews: () => [],
} as unknown as Question;
+ // Unjustified type cast. FIXME
const questionWithUndefinedReviews = {
getModerationReviews: () => undefined,
} as unknown as Question;
diff --git a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/ChangesLists/EntityLink.tsx b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/ChangesLists/EntityLink.tsx
index dad5b247c8b..ffd3826647f 100644
--- a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/ChangesLists/EntityLink.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/ChangesLists/EntityLink.tsx
@@ -22,6 +22,7 @@ export const EntityLink = ({ entity }: EntityLinkProps) => {
}
return getIcon({
+ // Unjustified type cast. FIXME
model: entity.model as IconModel,
id: entity.id,
display: entity.display,
diff --git a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/CollectionSyncList/CollectionSyncList.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/CollectionSyncList/CollectionSyncList.unit.spec.tsx
index 98d5d17ae8a..719dfce2be2 100644
--- a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/CollectionSyncList/CollectionSyncList.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/CollectionSyncList/CollectionSyncList.unit.spec.tsx
@@ -388,6 +388,7 @@ describe("CollectionSyncList", () => {
// Simulate server update by changing initial values to match submitted values
setCurrentInitialValues({
...currentInitialValues,
+ // Unjustified type cast. FIXME
[COLLECTIONS_KEY]: values[
COLLECTIONS_KEY
] as CollectionSyncPreferences,
diff --git a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/CollectionsNavTree/CollectionsNavTree.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/CollectionsNavTree/CollectionsNavTree.unit.spec.tsx
index 473905a8e6f..b1c306ec55b 100644
--- a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/CollectionsNavTree/CollectionsNavTree.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/CollectionsNavTree/CollectionsNavTree.unit.spec.tsx
@@ -41,6 +41,7 @@ const setupEndpoints = ({
const setup = ({
collections = [createMockCollectionTreeItem()],
collectionsList = [createMockCollectionTreeItem()],
+ // Unjustified type cast. FIXME
dirtyCollectionIds = [] as number[],
}: {
collections?: Collection[];
@@ -60,6 +61,7 @@ const setup = ({
path="/"
component={() => (
<CollectionsNavTree
+ // Unjustified type cast. FIXME
collections={collections as any}
selectedId={undefined}
onSelect={jest.fn()}
diff --git a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/GitSyncControls/GitSyncControls.tsx b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/GitSyncControls/GitSyncControls.tsx
index ce2d57a1415..548f0017faa 100644
--- a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/GitSyncControls/GitSyncControls.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/GitSyncControls/GitSyncControls.tsx
@@ -107,6 +107,7 @@ export const GitSyncControls = () => {
hasBranchMismatch,
errorMessage,
currentBranch: serverBranch,
+ // Unjustified type cast. FIXME
} = parseSyncError(error as SyncError);
if (hasBranchMismatch) {
setBranchMismatch({
@@ -205,6 +206,7 @@ export const GitSyncControls = () => {
return;
}
+ // Unjustified type cast. FIXME
const { hasConflict, errorMessage } = parseSyncError(error as SyncError);
if (hasConflict) {
diff --git a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/PushChangesModal/PushChangesModal.tsx b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/PushChangesModal/PushChangesModal.tsx
index 4822b816f24..55132d9a5de 100644
--- a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/PushChangesModal/PushChangesModal.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/PushChangesModal/PushChangesModal.tsx
@@ -41,6 +41,7 @@ export const PushChangesModal = ({
] = useExportChangesMutation();
const { errorMessage } = useMemo(
+ // Unjustified type cast. FIXME
() => parseSyncError(exportError as SyncError),
[exportError],
);
diff --git a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/RemoteSyncAdminSettings/BranchSwitcher.tsx b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/RemoteSyncAdminSettings/BranchSwitcher.tsx
index bf51a4c3e6a..a7d2d32f5ab 100644
--- a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/RemoteSyncAdminSettings/BranchSwitcher.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/RemoteSyncAdminSettings/BranchSwitcher.tsx
@@ -81,6 +81,7 @@ export const BranchSwitcher = ({
trackBranchSwitched({ triggeredFrom: "admin-settings" });
} catch (error) {
const { hasBranchMismatch, errorMessage } = parseSyncError(
+ // Unjustified type cast. FIXME
error as SyncError,
);
if (hasBranchMismatch) {
diff --git a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/RemoteSyncAdminSettings/RemoteSyncSettingsForm.setup.spec.tsx b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/RemoteSyncAdminSettings/RemoteSyncSettingsForm.setup.spec.tsx
index 5f2f9316586..2a01d8369b4 100644
--- a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/RemoteSyncAdminSettings/RemoteSyncSettingsForm.setup.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/RemoteSyncAdminSettings/RemoteSyncSettingsForm.setup.spec.tsx
@@ -46,8 +46,11 @@ const setupEndpoints = ({
remoteSyncBranch = "main",
remoteSyncAutoImport = false,
remoteSyncTransforms = false,
+ // Unjustified type cast. FIXME
libraryCollection = null as Collection | null,
+ // Unjustified type cast. FIXME
dirty = [] as any[],
+ // Unjustified type cast. FIXME
rootCollectionItems = [] as CollectionItem[],
settingsError,
testConnectionError,
diff --git a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncConflictModal/OutOfSyncOptions.tsx b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncConflictModal/OutOfSyncOptions.tsx
index 9b004e8804a..42e412e2c87 100644
--- a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncConflictModal/OutOfSyncOptions.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncConflictModal/OutOfSyncOptions.tsx
@@ -98,6 +98,7 @@ export const OutOfSyncOptions = (props: BranchSwitchOptionsProps) => {
<Box mt="xl">
<Text fw="bold" mb="sm" pb="xs">{t`Choose how to proceed:`}</Text>
<Radio.Group
+ // Unjustified type cast. FIXME
onChange={(value) => handleOptionChange(value as OptionValue)}
value={optionValue}
>
diff --git a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncConflictModal/SyncConflictModal.tsx b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncConflictModal/SyncConflictModal.tsx
index c9465bdd5d7..c960d0f366a 100644
--- a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncConflictModal/SyncConflictModal.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncConflictModal/SyncConflictModal.tsx
@@ -100,6 +100,7 @@ export const SyncConflictModal = (props: UnsyncedWarningModalProps) => {
const markLibraryAndTransformsAsSynced = useCallback(async () => {
try {
const remoteSyncSettings: RemoteSyncConfigurationSettings = {
+ // Unjustified type cast. FIXME
[COLLECTIONS_KEY]: (settingValues as RemoteSyncConfigurationSettings)[
COLLECTIONS_KEY
],
diff --git a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncConflictModal/hooks.ts b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncConflictModal/hooks.ts
index 6e27f8bdca4..b8ab6d4dd39 100644
--- a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncConflictModal/hooks.ts
+++ b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncConflictModal/hooks.ts
@@ -45,6 +45,7 @@ export const usePushChangesAction = () => {
});
closeModal();
} catch (error) {
+ // Unjustified type cast. FIXME
const { errorMessage } = parseSyncError(error as SyncError);
sendToast({
message: errorMessage || t`Failed to push changes`,
@@ -84,6 +85,7 @@ export const useMergeChangesAction = () => {
});
closeModal();
} catch (error) {
+ // Unjustified type cast. FIXME
const { errorMessage } = parseSyncError(error as SyncError);
sendToast({
message: errorMessage || t`Failed to merge changes`,
@@ -120,6 +122,7 @@ export const useMergeImportAction = () => {
});
closeModal();
} catch (error) {
+ // Unjustified type cast. FIXME
const { errorMessage } = parseSyncError(error as SyncError);
sendToast({
message: errorMessage || t`Failed to merge changes`,
@@ -218,6 +221,7 @@ export const useDiscardChangesAndImportAction = () => {
}).unwrap();
closeModal();
} catch (error) {
+ // Unjustified type cast. FIXME
const { errorMessage } = parseSyncError(error as SyncError);
sendToast({
message:
diff --git a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncProgressModal.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncProgressModal.unit.spec.tsx
index e58550a6314..1b31a203c57 100644
--- a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncProgressModal.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncProgressModal.unit.spec.tsx
@@ -191,6 +191,7 @@ describe("SyncProgressModal", () => {
setup({
taskType: "export",
isSuccess: true,
+ // Unjustified type cast. FIXME
outcome: { kind: "teleported" } as unknown as RemoteSyncOutcome,
});
@@ -203,6 +204,7 @@ describe("SyncProgressModal", () => {
setup({
taskType: "import",
isSuccess: true,
+ // Unjustified type cast. FIXME
outcome: { kind: "pulled" } as unknown as RemoteSyncOutcome,
});
@@ -215,6 +217,7 @@ describe("SyncProgressModal", () => {
setup({
taskType: "export",
isSuccess: true,
+ // Unjustified type cast. FIXME
outcome: { kind: "pushed", count: 3 } as unknown as RemoteSyncOutcome,
});
@@ -227,6 +230,7 @@ describe("SyncProgressModal", () => {
setup({
taskType: "export",
isSuccess: true,
+ // Unjustified type cast. FIXME
outcome: { kind: "merged", pulled: 1 } as unknown as RemoteSyncOutcome,
});
diff --git a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/TopLevelCollectionsList/TopLevelCollectionsList.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/TopLevelCollectionsList/TopLevelCollectionsList.unit.spec.tsx
index b084a6e349b..f8c78c9c2e4 100644
--- a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/TopLevelCollectionsList/TopLevelCollectionsList.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/TopLevelCollectionsList/TopLevelCollectionsList.unit.spec.tsx
@@ -43,6 +43,7 @@ const createMockLibraryCollection = (
const setupEndpoints = ({
collections = [createMockTopLevelCollectionItem()],
+ // Unjustified type cast. FIXME
libraryCollection = null as ReturnType<
typeof createMockCollectionItem
> | null,
diff --git a/enterprise/frontend/src/metabase-enterprise/remote_sync/middleware/model-configs.ts b/enterprise/frontend/src/metabase-enterprise/remote_sync/middleware/model-configs.ts
index 278b3952c43..9bf4164f9a2 100644
--- a/enterprise/frontend/src/metabase-enterprise/remote_sync/middleware/model-configs.ts
+++ b/enterprise/frontend/src/metabase-enterprise/remote_sync/middleware/model-configs.ts
@@ -29,7 +29,9 @@ import {
* RTK Query stores the original arguments in action.meta.arg.originalArgs
*/
function getOriginalArgs<T>(action: UnknownAction): T | undefined {
+ // Unjustified type cast. FIXME
const meta = (action as { meta?: { arg?: { originalArgs?: unknown } } }).meta;
+ // Unjustified type cast. FIXME
return meta?.arg?.originalArgs as T | undefined;
}
diff --git a/enterprise/frontend/src/metabase-enterprise/remote_sync/middleware/register-listeners.ts b/enterprise/frontend/src/metabase-enterprise/remote_sync/middleware/register-listeners.ts
index cdc5d50c1f1..ad0d1d096f4 100644
--- a/enterprise/frontend/src/metabase-enterprise/remote_sync/middleware/register-listeners.ts
+++ b/enterprise/frontend/src/metabase-enterprise/remote_sync/middleware/register-listeners.ts
@@ -92,6 +92,7 @@ function shouldInvalidateForCollection(
*/
function getActionPayload<T>(action: UnknownAction): T | undefined {
if (action && typeof action === "object" && "payload" in action) {
+ // Unjustified type cast. FIXME
return action.payload as T;
}
return undefined;
@@ -181,6 +182,7 @@ function registerUpdateListeners(
}
const oldModel = invalidation.getOriginal(
getOriginalState(),
+ // Unjustified type cast. FIXME
newModel.id as number,
);
if (shouldInvalidateForRemoteSyncedModel(oldModel, newModel)) {
@@ -243,6 +245,7 @@ function registerDeleteListeners(
}
const model = invalidation.getOriginal(
getOriginalState(),
+ // Unjustified type cast. FIXME
id as number,
);
if (model?.is_remote_synced) {
diff --git a/enterprise/frontend/src/metabase-enterprise/remote_sync/middleware/remote-sync-listener-middleware.unit.spec.ts b/enterprise/frontend/src/metabase-enterprise/remote_sync/middleware/remote-sync-listener-middleware.unit.spec.ts
index 4d0f52a75ff..1a393d4b86e 100644
--- a/enterprise/frontend/src/metabase-enterprise/remote_sync/middleware/remote-sync-listener-middleware.unit.spec.ts
+++ b/enterprise/frontend/src/metabase-enterprise/remote_sync/middleware/remote-sync-listener-middleware.unit.spec.ts
@@ -94,10 +94,12 @@ describe("remote-sync-listener-middleware", () => {
// Wait for the request to complete and middleware to process
await waitForCondition(() => {
+ // Unjustified type cast. FIXME
const state = store.getState() as TestState;
return state.remoteSyncPlugin?.showModal === true;
});
+ // Unjustified type cast. FIXME
const state = store.getState() as TestState;
expect(state.remoteSyncPlugin?.showModal).toBe(true);
expect(state.remoteSyncPlugin?.currentTask?.sync_task_type).toBe(
@@ -128,6 +130,7 @@ describe("remote-sync-listener-middleware", () => {
// Give middleware time to process
await new Promise((resolve) => setTimeout(resolve, 100));
+ // Unjustified type cast. FIXME
const state = store.getState() as TestState;
expect(state.remoteSyncPlugin?.showModal).toBe(false);
expect(state.remoteSyncPlugin?.currentTask).toBeNull();
@@ -157,6 +160,7 @@ describe("remote-sync-listener-middleware", () => {
// Give middleware time to process
await new Promise((resolve) => setTimeout(resolve, 100));
+ // Unjustified type cast. FIXME
const state = store.getState() as TestState;
expect(state.remoteSyncPlugin?.showModal).toBe(false);
expect(state.remoteSyncPlugin?.currentTask).toBeNull();
@@ -185,6 +189,7 @@ describe("remote-sync-listener-middleware", () => {
// Give middleware time to process
await new Promise((resolve) => setTimeout(resolve, 100));
+ // Unjustified type cast. FIXME
const state = store.getState() as TestState;
expect(state.remoteSyncPlugin?.showModal).toBe(false);
expect(state.remoteSyncPlugin?.currentTask).toBeNull();
@@ -210,10 +215,12 @@ describe("remote-sync-listener-middleware", () => {
// The import listener triggers on matchPending, so modal should show immediately
await waitForCondition(() => {
+ // Unjustified type cast. FIXME
const state = store.getState() as TestState;
return state.remoteSyncPlugin?.showModal === true;
});
+ // Unjustified type cast. FIXME
const state = store.getState() as TestState;
expect(state.remoteSyncPlugin?.showModal).toBe(true);
expect(state.remoteSyncPlugin?.currentTask?.sync_task_type).toBe(
@@ -245,6 +252,7 @@ describe("remote-sync-listener-middleware", () => {
// Give middleware time to process the rejection
await new Promise((resolve) => setTimeout(resolve, 100));
+ // Unjustified type cast. FIXME
const state = store.getState() as TestState;
expect(state.remoteSyncPlugin?.showModal).toBe(false);
expect(state.remoteSyncPlugin?.currentTask).toBeNull();
diff --git a/enterprise/frontend/src/metabase-enterprise/sandboxes/components/AttributeMappingEditor/DataAttributeMappingEditor.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/sandboxes/components/AttributeMappingEditor/DataAttributeMappingEditor.unit.spec.tsx
index 16ce1c93bee..879c6f617cc 100644
--- a/enterprise/frontend/src/metabase-enterprise/sandboxes/components/AttributeMappingEditor/DataAttributeMappingEditor.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/sandboxes/components/AttributeMappingEditor/DataAttributeMappingEditor.unit.spec.tsx
@@ -84,6 +84,7 @@ const setup = async ({
}: {
shouldUseSavedQuestion: boolean;
}) => {
+ // Unjustified type cast. FIXME
const card = createMockCard({ id: cardPolicy.card_id as number });
const cardQueryMetadata = createMockCardQueryMetadata({});
setupTableQueryMetadataEndpoint(createMockTable());
diff --git a/enterprise/frontend/src/metabase-enterprise/sandboxes/components/EditSandboxingModal/EditSandboxingModal.tsx b/enterprise/frontend/src/metabase-enterprise/sandboxes/components/EditSandboxingModal/EditSandboxingModal.tsx
index 7faa9182965..83b307a6e03 100644
--- a/enterprise/frontend/src/metabase-enterprise/sandboxes/components/EditSandboxingModal/EditSandboxingModal.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/sandboxes/components/EditSandboxingModal/EditSandboxingModal.tsx
@@ -49,6 +49,7 @@ const getNormalizedPolicy = (
policy: GroupTableAccessPolicy | GroupTableAccessPolicyDraft,
shouldUseSavedQuestion: boolean,
): GroupTableAccessPolicy => {
+ // Unjustified type cast. FIXME
return {
...policy,
card_id: shouldUseSavedQuestion ? policy.card_id : null,
diff --git a/enterprise/frontend/src/metabase-enterprise/sandboxes/components/ParameterTargetWidget.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/sandboxes/components/ParameterTargetWidget.unit.spec.tsx
index 11f197bdd9f..a815b707109 100644
--- a/enterprise/frontend/src/metabase-enterprise/sandboxes/components/ParameterTargetWidget.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/sandboxes/components/ParameterTargetWidget.unit.spec.tsx
@@ -4,8 +4,10 @@ import type { ParameterTarget } from "metabase-types/api";
import { ParameterTargetWidget } from "./ParameterTargetWidget";
+// Unjustified type cast. FIXME
const TARGET = ["variable", ["template-tag", "foo"]] as ParameterTarget;
+// Unjustified type cast. FIXME
const OPTION = {
name: "Foo column",
target: TARGET,
diff --git a/enterprise/frontend/src/metabase-enterprise/sandboxes/containers/EditSandboxingModal.tsx b/enterprise/frontend/src/metabase-enterprise/sandboxes/containers/EditSandboxingModal.tsx
index a31044979ab..960cf1e3535 100644
--- a/enterprise/frontend/src/metabase-enterprise/sandboxes/containers/EditSandboxingModal.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/sandboxes/containers/EditSandboxingModal.tsx
@@ -56,6 +56,7 @@ const EditSandboxingModalContainer = ({
// The plugins state is added dynamically by the enterprise plugin system,
// so we need to cast to SandboxesState (same approach as the old connect-based mapStateToProps).
const draftPolicy = useSelector((state) =>
+ // Unjustified type cast. FIXME
getGroupTableAccessPolicy(state as unknown as SandboxesState, { params }),
);
diff --git a/enterprise/frontend/src/metabase-enterprise/security_center/components/NotificationChannelConfigModal/EmailChannelCard/EmailChannelCard.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/security_center/components/NotificationChannelConfigModal/EmailChannelCard/EmailChannelCard.unit.spec.tsx
index d88e83f3f3b..afcfde92ab5 100644
--- a/enterprise/frontend/src/metabase-enterprise/security_center/components/NotificationChannelConfigModal/EmailChannelCard/EmailChannelCard.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/security_center/components/NotificationChannelConfigModal/EmailChannelCard/EmailChannelCard.unit.spec.tsx
@@ -14,6 +14,7 @@ jest.mock("../../../hooks/use-notification-config", () => ({
}));
const mockedUseNotificationConfig =
+ // Unjustified type cast. FIXME
useNotificationConfig as any as jest.MockedFn<typeof useNotificationConfig>;
const DEFAULT_CONFIG: NotificationConfig = {
diff --git a/enterprise/frontend/src/metabase-enterprise/security_center/components/NotificationChannelConfigModal/NotificationChannelConfigModal.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/security_center/components/NotificationChannelConfigModal/NotificationChannelConfigModal.unit.spec.tsx
index 97bfd3bb250..ffb40743efe 100644
--- a/enterprise/frontend/src/metabase-enterprise/security_center/components/NotificationChannelConfigModal/NotificationChannelConfigModal.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/security_center/components/NotificationChannelConfigModal/NotificationChannelConfigModal.unit.spec.tsx
@@ -35,6 +35,7 @@ jest.mock("../../hooks/use-notification-config", () => {
});
const mockedUseNotificationConfig =
+ // Unjustified type cast. FIXME
useNotificationConfig as any as jest.MockedFn<typeof useNotificationConfig>;
const DEFAULT_CONFIG: NotificationConfig = {
@@ -263,7 +264,9 @@ const ADMIN_GROUP_RECIPIENT = {
function setupWithRealHook({
emailConfigured = true,
slackConfigured = true,
+ // Unjustified type cast. FIXME
slackChannel = null as string | null,
+ // Unjustified type cast. FIXME
emailRecipients = null as any[] | null,
} = {}) {
// Restore the real implementation for save-payload tests
diff --git a/enterprise/frontend/src/metabase-enterprise/security_center/components/NotificationChannelConfigModal/SlackChannelCard/SlackChannelCard.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/security_center/components/NotificationChannelConfigModal/SlackChannelCard/SlackChannelCard.unit.spec.tsx
index db2c5ce23eb..a6b3d132922 100644
--- a/enterprise/frontend/src/metabase-enterprise/security_center/components/NotificationChannelConfigModal/SlackChannelCard/SlackChannelCard.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/security_center/components/NotificationChannelConfigModal/SlackChannelCard/SlackChannelCard.unit.spec.tsx
@@ -15,6 +15,7 @@ jest.mock("../../../hooks/use-notification-config", () => ({
}));
const mockedUseNotificationConfig =
+ // Unjustified type cast. FIXME
useNotificationConfig as any as jest.MockedFn<typeof useNotificationConfig>;
const DEFAULT_CONFIG: NotificationConfig = {
diff --git a/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterPage/SecurityCenterPage.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterPage/SecurityCenterPage.unit.spec.tsx
index a1a806fcbad..343b989b7ca 100644
--- a/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterPage/SecurityCenterPage.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterPage/SecurityCenterPage.unit.spec.tsx
@@ -357,6 +357,7 @@ describe("SecurityCenterPage", () => {
describe("notification settings modal", () => {
it("opens the modal when the 'open=notifications' query param is set", async () => {
setup([], {
+ // Unjustified type cast. FIXME
location: {
query: { open: "notifications" },
} as Location<{ open?: string }>,
diff --git a/enterprise/frontend/src/metabase-enterprise/settings/hooks/use-license.ts b/enterprise/frontend/src/metabase-enterprise/settings/hooks/use-license.ts
index beab4b31a89..89c0ba254ff 100644
--- a/enterprise/frontend/src/metabase-enterprise/settings/hooks/use-license.ts
+++ b/enterprise/frontend/src/metabase-enterprise/settings/hooks/use-license.ts
@@ -46,6 +46,7 @@ export const useLicense = (onActivated?: () => void) => {
}
reload();
} catch (e) {
+ // Unjustified type cast. FIXME
if ((e as any).status === 503) {
setError(UNABLE_TO_VALIDATE_TOKEN);
} else {
@@ -69,6 +70,7 @@ export const useLicense = (onActivated?: () => void) => {
),
);
} catch (e) {
+ // Unjustified type cast. FIXME
if ((e as any).status !== 404) {
setError(UNABLE_TO_VALIDATE_TOKEN);
}
diff --git a/enterprise/frontend/src/metabase-enterprise/settings/selectors.ts b/enterprise/frontend/src/metabase-enterprise/settings/selectors.ts
index 9d3cdd7443b..28d3675b048 100644
--- a/enterprise/frontend/src/metabase-enterprise/settings/selectors.ts
+++ b/enterprise/frontend/src/metabase-enterprise/settings/selectors.ts
@@ -49,6 +49,7 @@ export function getShowMetabaseLinks(state: EnterpriseState) {
export function getLoginPageIllustration(
state: EnterpriseState,
): IllustrationValue {
+ // Unjustified type cast. FIXME
const illustrationOption = getSetting(
state,
"login-page-illustration",
@@ -66,6 +67,7 @@ export function getLoginPageIllustration(
case "custom":
return {
+ // Unjustified type cast. FIXME
src: getSetting(state, "login-page-illustration-custom") as string,
isDefault: false,
};
@@ -75,6 +77,7 @@ export function getLoginPageIllustration(
export function getLandingPageIllustration(
state: EnterpriseState,
): IllustrationValue {
+ // Unjustified type cast. FIXME
const illustrationOption = getSetting(
state,
"landing-page-illustration",
@@ -92,6 +95,7 @@ export function getLandingPageIllustration(
case "custom":
return {
+ // Unjustified type cast. FIXME
src: getSetting(state, "landing-page-illustration-custom") as string,
isDefault: false,
};
@@ -99,6 +103,7 @@ export function getLandingPageIllustration(
}
export function getNoDataIllustration(state: EnterpriseState): string | null {
+ // Unjustified type cast. FIXME
const illustrationOption = getSetting(
state,
"no-data-illustration",
@@ -112,11 +117,13 @@ export function getNoDataIllustration(state: EnterpriseState): string | null {
return null;
case "custom":
+ // Unjustified type cast. FIXME
return getSetting(state, "no-data-illustration-custom") as string;
}
}
export function getNoObjectIllustration(state: EnterpriseState): string | null {
+ // Unjustified type cast. FIXME
const illustrationOption = getSetting(
state,
"no-object-illustration",
@@ -130,6 +137,7 @@ export function getNoObjectIllustration(state: EnterpriseState): string | null {
return null;
case "custom":
+ // Unjustified type cast. FIXME
return getSetting(state, "no-object-illustration-custom") as string;
}
}
diff --git a/enterprise/frontend/src/metabase-enterprise/settings/selectors.unit.spec.ts b/enterprise/frontend/src/metabase-enterprise/settings/selectors.unit.spec.ts
index 412e93803c9..d31ef0ee883 100644
--- a/enterprise/frontend/src/metabase-enterprise/settings/selectors.unit.spec.ts
+++ b/enterprise/frontend/src/metabase-enterprise/settings/selectors.unit.spec.ts
@@ -80,6 +80,7 @@ describe("getLoadingMessage", () => {
it('should show no loading message when "loading-message" is set to an invalid enum value', () => {
const states = createMockState({
settings: createMockSettingsState({
+ // Unjustified type cast. FIXME
"loading-message": "bad-enum-bad" as any,
}),
});
diff --git a/enterprise/frontend/src/metabase-enterprise/table-editing/table-edit/data-grid/use-table-editing-cell.tsx b/enterprise/frontend/src/metabase-enterprise/table-editing/table-edit/data-grid/use-table-editing-cell.tsx
index 2a8a6dd4659..49dd21ea400 100644
--- a/enterprise/frontend/src/metabase-enterprise/table-editing/table-edit/data-grid/use-table-editing-cell.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/table-editing/table-edit/data-grid/use-table-editing-cell.tsx
@@ -46,6 +46,7 @@ export function useTableEditingCell({
}
return acc;
+ // Unjustified type cast. FIXME
}, {} as RowCellsWithPkValue);
const columnIndex = cols.findIndex((col) => col.name === columnId);
diff --git a/enterprise/frontend/src/metabase-enterprise/table-editing/table-edit/toasts/getUpdateErrorMessage.tsx b/enterprise/frontend/src/metabase-enterprise/table-editing/table-edit/toasts/getUpdateErrorMessage.tsx
index c498b2ee122..8de7f614043 100644
--- a/enterprise/frontend/src/metabase-enterprise/table-editing/table-edit/toasts/getUpdateErrorMessage.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/table-editing/table-edit/toasts/getUpdateErrorMessage.tsx
@@ -5,6 +5,7 @@ import type { GenericErrorResponse } from "metabase/utils/errors";
export const getUpdateApiErrorMessage = (
error: GenericErrorResponse | unknown,
): string => {
+ // Unjustified type cast. FIXME
const maybeError = error as GenericErrorResponse;
if (typeof maybeError.data === "string") {
diff --git a/enterprise/frontend/src/metabase-enterprise/tenants/components/TenantCollectionPermissionsPage/selectors.tsx b/enterprise/frontend/src/metabase-enterprise/tenants/components/TenantCollectionPermissionsPage/selectors.tsx
index 73bf6e2931f..815d33bf9bf 100644
--- a/enterprise/frontend/src/metabase-enterprise/tenants/components/TenantCollectionPermissionsPage/selectors.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/tenants/components/TenantCollectionPermissionsPage/selectors.tsx
@@ -137,6 +137,7 @@ const getTenantCollection = createSelector(
}
if (collectionId === ROOT_COLLECTION.id) {
+ // Unjustified type cast. FIXME
return {
...ROOT_COLLECTION,
name: t`Root shared collection`,
@@ -238,6 +239,7 @@ export const getTenantCollectionsPermissionEditor = createSelector(
),
warning: getTenantCollectionWarning(
group.id,
+ // Unjustified type cast. FIXME
collection as ExpandedCollection,
permissions,
),
diff --git a/enterprise/frontend/src/metabase-enterprise/tenants/components/TenantCollectionPermissionsPage/selectors.unit.spec.ts b/enterprise/frontend/src/metabase-enterprise/tenants/components/TenantCollectionPermissionsPage/selectors.unit.spec.ts
index 266a67b84d4..97ddbb85216 100644
--- a/enterprise/frontend/src/metabase-enterprise/tenants/components/TenantCollectionPermissionsPage/selectors.unit.spec.ts
+++ b/enterprise/frontend/src/metabase-enterprise/tenants/components/TenantCollectionPermissionsPage/selectors.unit.spec.ts
@@ -116,6 +116,7 @@ describe("TenantCollectionPermissionsPage selectors", () => {
describe("getCurrentTenantCollectionId", () => {
it("should return undefined when collectionId is null", () => {
const state = createMockStateWithPermissions();
+ // Unjustified type cast. FIXME
const props = { params: { collectionId: null as any } };
expect(getCurrentTenantCollectionId(state, props)).toBeUndefined();
@@ -123,6 +124,7 @@ describe("TenantCollectionPermissionsPage selectors", () => {
it("should return undefined when collectionId is undefined", () => {
const state = createMockStateWithPermissions();
+ // Unjustified type cast. FIXME
const props = { params: { collectionId: undefined as any } };
expect(getCurrentTenantCollectionId(state, props)).toBeUndefined();
@@ -144,6 +146,7 @@ describe("TenantCollectionPermissionsPage selectors", () => {
it("should handle numeric collection id", () => {
const state = createMockStateWithPermissions();
+ // Unjustified type cast. FIXME
const props = { params: { collectionId: 100 as any } };
expect(getCurrentTenantCollectionId(state, props)).toBe(100);
diff --git a/enterprise/frontend/src/metabase-enterprise/tenants/components/TenantSpecificCollectionPermissionsPage/TenantSpecificCollectionPermissionsPage.tsx b/enterprise/frontend/src/metabase-enterprise/tenants/components/TenantSpecificCollectionPermissionsPage/TenantSpecificCollectionPermissionsPage.tsx
index 842bc93afea..7cf74556854 100644
--- a/enterprise/frontend/src/metabase-enterprise/tenants/components/TenantSpecificCollectionPermissionsPage/TenantSpecificCollectionPermissionsPage.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/tenants/components/TenantSpecificCollectionPermissionsPage/TenantSpecificCollectionPermissionsPage.tsx
@@ -112,6 +112,7 @@ function TenantSpecificCollectionPermissionsPageView({
// Always propagate to sub-collections for tenant-specific collections
updateCollectionPermission({
groupId: assertNumericId(item.id),
+ // Unjustified type cast. FIXME
collection: collection as Collection,
value,
shouldPropagateToChildren: true,
diff --git a/enterprise/frontend/src/metabase-enterprise/tenants/components/TenantSpecificCollectionPermissionsPage/selectors.tsx b/enterprise/frontend/src/metabase-enterprise/tenants/components/TenantSpecificCollectionPermissionsPage/selectors.tsx
index cadc1d47f2b..b1e01ed3d98 100644
--- a/enterprise/frontend/src/metabase-enterprise/tenants/components/TenantSpecificCollectionPermissionsPage/selectors.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/tenants/components/TenantSpecificCollectionPermissionsPage/selectors.tsx
@@ -208,6 +208,7 @@ export const getTenantSpecificCollectionsPermissionEditor = createSelector(
),
warning: getTenantSpecificCollectionWarning(
group.id,
+ // Unjustified type cast. FIXME
collection as ExpandedCollection,
permissions,
),
diff --git a/enterprise/frontend/src/metabase-enterprise/tenants/containers/TenantsListingApp.tsx b/enterprise/frontend/src/metabase-enterprise/tenants/containers/TenantsListingApp.tsx
index e5349bc4ef3..156b7e00149 100644
--- a/enterprise/frontend/src/metabase-enterprise/tenants/containers/TenantsListingApp.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/tenants/containers/TenantsListingApp.tsx
@@ -43,6 +43,7 @@ export const TenantsListingApp = ({
const handleTabChange = (tab: string | null) => {
if (tab) {
+ // Unjustified type cast. FIXME
setStatus(tab as ActiveStatus);
}
};
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonEditorResults/PythonEditorResults.tsx b/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonEditorResults/PythonEditorResults.tsx
index 6f950576003..e948ca87e52 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonEditorResults/PythonEditorResults.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonEditorResults/PythonEditorResults.tsx
@@ -83,6 +83,7 @@ function ExecutionResultTabs({
value={tab}
onChange={(value) => {
if (value) {
+ // Unjustified type cast. FIXME
onTabChange(value as ResultsTab);
}
}}
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonEditorResults/utils.ts b/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonEditorResults/utils.ts
index fb578e81853..b39b7e54e35 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonEditorResults/utils.ts
+++ b/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonEditorResults/utils.ts
@@ -21,6 +21,7 @@ export function parseOutput(output: string): {
for (const line of lines) {
try {
+ // Unjustified type cast. FIXME
const data = JSON.parse(line) as Row;
for (const key in data) {
headers.add(key);
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonTransformEditor.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonTransformEditor.unit.spec.tsx
index 712540d4ffa..16ec848c7a5 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonTransformEditor.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonTransformEditor.unit.spec.tsx
@@ -20,6 +20,7 @@ jest.mock("metabase-enterprise/settings", () => ({
hasPremiumFeature: jest.fn(),
}));
+// Unjustified type cast. FIXME
const mockHasPremiumFeature = hasPremiumFeature as jest.MockedFunction<
typeof hasPremiumFeature
>;
diff --git a/enterprise/frontend/src/metabase-enterprise/upload_management/UploadManagementTable.tsx b/enterprise/frontend/src/metabase-enterprise/upload_management/UploadManagementTable.tsx
index 42ca973e8e0..de65ba685dc 100644
--- a/enterprise/frontend/src/metabase-enterprise/upload_management/UploadManagementTable.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/upload_management/UploadManagementTable.tsx
@@ -196,6 +196,7 @@ const UploadTableRow = ({
<Link
to={
Urls.modelToUrl({
+ // Unjustified type cast. FIXME
id: item.id as number,
name: item.name,
model: "table",
diff --git a/enterprise/frontend/src/metabase-enterprise/user_provisioning/components/ScimInputs.tsx b/enterprise/frontend/src/metabase-enterprise/user_provisioning/components/ScimInputs.tsx
index cf0f6415cbb..4a6bc207bbb 100644
--- a/enterprise/frontend/src/metabase-enterprise/user_provisioning/components/ScimInputs.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/user_provisioning/components/ScimInputs.tsx
@@ -4,6 +4,7 @@ import { CopyTextInput } from "metabase/common/components/CopyTextInput";
import type { TextInputProps } from "metabase/ui";
import { getThemeOverrides } from "metabase/ui/theme";
+// Unjustified type cast. FIXME
const fontFamilyMonospace = getThemeOverrides().fontFamilyMonospace as string;
// why are we overriding the default styles?
diff --git a/enterprise/frontend/src/metabase-enterprise/user_provisioning/components/UserProvisioning.tsx b/enterprise/frontend/src/metabase-enterprise/user_provisioning/components/UserProvisioning.tsx
index d409441fa62..a13e07d0352 100644
--- a/enterprise/frontend/src/metabase-enterprise/user_provisioning/components/UserProvisioning.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/user_provisioning/components/UserProvisioning.tsx
@@ -96,6 +96,7 @@ export const UserProvisioning = () => {
);
const samlUserProvisioningEnabled = useSetting(
+ // Unjustified type cast. FIXME
"saml-user-provisioning-enabled?" as any,
);
const showSamlWarning = samlUserProvisioningEnabled && !isScimInitialized;
diff --git a/enterprise/frontend/src/metabase-enterprise/whitelabel/components/ColorSettingsWidget/ColorSettingsWidget.tsx b/enterprise/frontend/src/metabase-enterprise/whitelabel/components/ColorSettingsWidget/ColorSettingsWidget.tsx
index b6c372b9d86..466d23b20ad 100644
--- a/enterprise/frontend/src/metabase-enterprise/whitelabel/components/ColorSettingsWidget/ColorSettingsWidget.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/whitelabel/components/ColorSettingsWidget/ColorSettingsWidget.tsx
@@ -18,6 +18,7 @@ export const ColorSettingsWidget = () => {
const themeColors = Object.fromEntries(
Object.entries(theme.colors).map(([colorName, color]) => [
colorName,
+ // Unjustified type cast. FIXME
color[theme.primaryShade as number],
]),
);
diff --git a/enterprise/frontend/src/metabase-enterprise/whitelabel/components/ColorSettingsWidget/ColorSettingsWidget.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/whitelabel/components/ColorSettingsWidget/ColorSettingsWidget.unit.spec.tsx
index c64f4a59058..28bb9b529d2 100644
--- a/enterprise/frontend/src/metabase-enterprise/whitelabel/components/ColorSettingsWidget/ColorSettingsWidget.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/whitelabel/components/ColorSettingsWidget/ColorSettingsWidget.unit.spec.tsx
@@ -11,6 +11,7 @@ import type { SettingKey } from "metabase-types/api";
import { ColorSettingsWidget } from "./ColorSettingsWidget";
function setup(colors: Record<string, string>) {
+ // Unjustified type cast. FIXME
MetabaseSettings.set("application-colors" as SettingKey, colors);
fetchMock.get("path:/api/session/properties", {
"application-colors": colors,
diff --git a/enterprise/frontend/src/metabase-enterprise/whitelabel/components/FontWidget/FontWidget.tsx b/enterprise/frontend/src/metabase-enterprise/whitelabel/components/FontWidget/FontWidget.tsx
index 6012f75c5c1..de75af4d662 100644
--- a/enterprise/frontend/src/metabase-enterprise/whitelabel/components/FontWidget/FontWidget.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/whitelabel/components/FontWidget/FontWidget.tsx
@@ -56,6 +56,7 @@ export const FontWidget = () => {
name="application-font"
inputType="select"
searchable
+ // Unjustified type cast. FIXME
onChange={(newValue) => handleChange(newValue as string)}
options={fontOptions}
/>
diff --git a/enterprise/frontend/src/metabase-enterprise/whitelabel/components/FontWidget/FontWidget.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/whitelabel/components/FontWidget/FontWidget.unit.spec.tsx
index ac6cf321324..b8412154461 100644
--- a/enterprise/frontend/src/metabase-enterprise/whitelabel/components/FontWidget/FontWidget.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/whitelabel/components/FontWidget/FontWidget.unit.spec.tsx
@@ -179,6 +179,7 @@ describe("FontWidget", () => {
});
it("should remove a font file", async () => {
+ // Unjustified type cast. FIXME
const customFonts = [
{
src: "https://myfonts.com/abc.png",
diff --git a/enterprise/frontend/src/metabase-enterprise/whitelabel/components/HelpLinkSettings/HelpLinkSettings.tsx b/enterprise/frontend/src/metabase-enterprise/whitelabel/components/HelpLinkSettings/HelpLinkSettings.tsx
index 763efd77090..1bf65766db9 100644
--- a/enterprise/frontend/src/metabase-enterprise/whitelabel/components/HelpLinkSettings/HelpLinkSettings.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/whitelabel/components/HelpLinkSettings/HelpLinkSettings.tsx
@@ -93,6 +93,7 @@ export const HelpLinkSettings = () => {
{ label: t`Go to a custom destination...`, value: "custom" },
]}
onChange={(newValue) =>
+ // Unjustified type cast. FIXME
handleRadioChange(newValue as HelpLinkSetting)
}
/>
diff --git a/enterprise/frontend/src/metabase-enterprise/whitelabel/components/IllustrationWidget/IllustrationWidget.tsx b/enterprise/frontend/src/metabase-enterprise/whitelabel/components/IllustrationWidget/IllustrationWidget.tsx
index 59480353734..3890c6ba001 100644
--- a/enterprise/frontend/src/metabase-enterprise/whitelabel/components/IllustrationWidget/IllustrationWidget.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/whitelabel/components/IllustrationWidget/IllustrationWidget.tsx
@@ -90,6 +90,7 @@ export function IllustrationWidget({
const type = getIllustrationType(name);
const options = SELECT_OPTIONS[type];
const customIllustrationSettingName =
+ // Unjustified type cast. FIXME
`${name}-custom` as EnterpriseSettingKey;
const {
value: settingValue,
@@ -138,6 +139,7 @@ export function IllustrationWidget({
const reader = new FileReader();
reader.onload = async (readerEvent) => {
+ // Unjustified type cast. FIXME
const dataUri = readerEvent.target?.result as string;
if (!(await isFileIntact(dataUri))) {
setErrorMessage(
@@ -198,6 +200,7 @@ export function IllustrationWidget({
>
{getPreviewImage({
value: localValue,
+ // Unjustified type cast. FIXME
customSource: customIllustrationSource as string,
defaultPreviewType: type,
})}
@@ -212,6 +215,7 @@ export function IllustrationWidget({
value={settingValue}
options={options}
onChange={(newValue) =>
+ // Unjustified type cast. FIXME
handleChange(newValue as IllustrationSettingValue)
}
/>
diff --git a/enterprise/frontend/src/metabase-enterprise/whitelabel/components/IllustrationWidget/ImageUploadWidget.tsx b/enterprise/frontend/src/metabase-enterprise/whitelabel/components/IllustrationWidget/ImageUploadWidget.tsx
index 2a75043cf2b..76a6b871fd3 100644
--- a/enterprise/frontend/src/metabase-enterprise/whitelabel/components/IllustrationWidget/ImageUploadWidget.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/whitelabel/components/IllustrationWidget/ImageUploadWidget.tsx
@@ -47,6 +47,7 @@ export function ImageUploadWidget({
const reader = new FileReader();
reader.onload = async (readerEvent) => {
+ // Unjustified type cast. FIXME
const dataUri = readerEvent.target?.result as string;
if (!(await isFileIntact(dataUri))) {
setErrorMessage(
diff --git a/enterprise/frontend/src/metabase-enterprise/whitelabel/components/LandingPageUrlField/LandingPageUrlField.tsx b/enterprise/frontend/src/metabase-enterprise/whitelabel/components/LandingPageUrlField/LandingPageUrlField.tsx
index ea363ff2d84..3418ee87b35 100644
--- a/enterprise/frontend/src/metabase-enterprise/whitelabel/components/LandingPageUrlField/LandingPageUrlField.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/whitelabel/components/LandingPageUrlField/LandingPageUrlField.tsx
@@ -34,6 +34,7 @@ export function LandingPageUrlField() {
if (result.error) {
const message =
+ // Unjustified type cast. FIXME
(result.error as { data: GenericErrorResponse })?.data?.message ||
t`Something went wrong`;
setError(message);
diff --git a/enterprise/frontend/src/metabase-enterprise/whitelabel/components/LogoIcon.tsx b/enterprise/frontend/src/metabase-enterprise/whitelabel/components/LogoIcon.tsx
index f90db96263b..b1d819a3f47 100644
--- a/enterprise/frontend/src/metabase-enterprise/whitelabel/components/LogoIcon.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/whitelabel/components/LogoIcon.tsx
@@ -113,6 +113,7 @@ export function LogoIcon({
renderImgFallback();
}
} catch (error) {
+ // Unjustified type cast. FIXME
if ((error as Error).name !== "AbortError") {
renderImgFallback();
}
diff --git a/enterprise/frontend/src/metabase-enterprise/whitelabel/sdk-overrides.unit.spec.ts b/enterprise/frontend/src/metabase-enterprise/whitelabel/sdk-overrides.unit.spec.ts
index 730142f679b..33f54dc5356 100644
--- a/enterprise/frontend/src/metabase-enterprise/whitelabel/sdk-overrides.unit.spec.ts
+++ b/enterprise/frontend/src/metabase-enterprise/whitelabel/sdk-overrides.unit.spec.ts
@@ -7,6 +7,7 @@ jest.mock("metabase-enterprise/settings", () => ({
hasPremiumFeature: jest.fn(),
}));
+// Unjustified type cast. FIXME
const mockHasPremiumFeature = hasPremiumFeature as jest.MockedFunction<
typeof hasPremiumFeature
>;
@@ -81,6 +82,7 @@ describe("SDK Plugin Initialization", () => {
getNoDataIllustration: jest.fn().mockReturnValue(mockSdkIllustration),
};
+ // Unjustified type cast. FIXME
const mockState = {
sdk: {
plugins: mockSdkPlugins,
@@ -100,6 +102,7 @@ describe("SDK Plugin Initialization", () => {
getNoDataIllustration: jest.fn().mockReturnValue(pluginReturnValue),
};
+ // Unjustified type cast. FIXME
const mockState = {
sdk: {
plugins: mockSdkPlugins,
@@ -120,6 +123,7 @@ describe("SDK Plugin Initialization", () => {
);
it("should handle missing SDK plugins gracefully", () => {
+ // Unjustified type cast. FIXME
const mockState = {
sdk: {
plugins: null,
@@ -139,6 +143,7 @@ describe("SDK Plugin Initialization", () => {
}),
};
+ // Unjustified type cast. FIXME
const mockState = {
sdk: {
plugins: mockSdkPlugins,
@@ -170,6 +175,7 @@ describe("SDK Plugin Initialization", () => {
getNoObjectIllustration: jest.fn().mockReturnValue(mockSdkIllustration),
};
+ // Unjustified type cast. FIXME
const mockState = {
sdk: {
plugins: mockSdkPlugins,
@@ -187,6 +193,7 @@ describe("SDK Plugin Initialization", () => {
getNoObjectIllustration: jest.fn().mockReturnValue(null),
};
+ // Unjustified type cast. FIXME
const mockState = {
sdk: {
plugins: mockSdkPlugins,
@@ -208,6 +215,7 @@ describe("SDK Plugin Initialization", () => {
getNoObjectIllustration: jest.fn().mockReturnValue(undefined),
};
+ // Unjustified type cast. FIXME
const mockState = {
sdk: {
plugins: mockSdkPlugins,
@@ -221,6 +229,7 @@ describe("SDK Plugin Initialization", () => {
});
it("should handle missing SDK getNoObjectIllustration plugin gracefully", () => {
+ // Unjustified type cast. FIXME
const mockState = {
sdk: {
plugins: null,
@@ -240,6 +249,7 @@ describe("SDK Plugin Initialization", () => {
}),
};
+ // Unjustified type cast. FIXME
const mockState = {
sdk: {
plugins: mockSdkPlugins,
diff --git a/enterprise/frontend/src/metabase-enterprise/workspaces/pages/AdminConnectionInfoPage/AdminConnectionInfoPage.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/workspaces/pages/AdminConnectionInfoPage/AdminConnectionInfoPage.unit.spec.tsx
index d4fd969a2f2..47d47d66986 100644
--- a/enterprise/frontend/src/metabase-enterprise/workspaces/pages/AdminConnectionInfoPage/AdminConnectionInfoPage.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/workspaces/pages/AdminConnectionInfoPage/AdminConnectionInfoPage.unit.spec.tsx
@@ -19,6 +19,7 @@ function setup({ database }: { database: Database }) {
component={() => (
<AdminConnectionInfoPage
params={{ databaseId: String(database.id) }}
+ // Unjustified type cast. FIXME
route={{ path: "/" } as unknown as Route}
/>
)}
diff --git a/enterprise/frontend/src/metabase-enterprise/workspaces/pages/CurrentWorkspacePage/CurrentWorkspacePage.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/workspaces/pages/CurrentWorkspacePage/CurrentWorkspacePage.unit.spec.tsx
index 9be0718d358..91e988c7b66 100644
--- a/enterprise/frontend/src/metabase-enterprise/workspaces/pages/CurrentWorkspacePage/CurrentWorkspacePage.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/workspaces/pages/CurrentWorkspacePage/CurrentWorkspacePage.unit.spec.tsx
@@ -18,6 +18,7 @@ import { CurrentWorkspacePage } from "./CurrentWorkspacePage";
const POSTGRES = createMockDatabase({ id: 10, name: "Postgres" });
function setup({
+ // Unjustified type cast. FIXME
remappings = [] as TableRemapping[],
workspace = createMockCurrentWorkspace({
name: "Dev workspace",
diff --git a/enterprise/frontend/src/metabase-enterprise/workspaces/pages/WorkspaceListPage/WorkspaceListPage.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/workspaces/pages/WorkspaceListPage/WorkspaceListPage.unit.spec.tsx
index 1ba92077e2b..4795bf16c8d 100644
--- a/enterprise/frontend/src/metabase-enterprise/workspaces/pages/WorkspaceListPage/WorkspaceListPage.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/workspaces/pages/WorkspaceListPage/WorkspaceListPage.unit.spec.tsx
@@ -20,6 +20,7 @@ const ELIGIBLE_DATABASE = createMockDatabase({
settings: { "database-enable-workspaces": true },
});
+// Unjustified type cast. FIXME
function setup({ workspaces = [] as Workspace[] } = {}) {
setupListWorkspacesEndpoint(workspaces);
setupDatabasesEndpoints([ELIGIBLE_DATABASE]);
diff --git a/eslint.config.mjs b/eslint.config.mjs
index 2546e5fa548..a8af3ef3802 100644
--- a/eslint.config.mjs
+++ b/eslint.config.mjs
@@ -379,6 +379,7 @@ const configs = [
parser: tseslint.parser,
},
rules: {
+ "metabase/no-unjustified-type-casts": "error",
"prefer-rest-params": "off",
"react/prop-types": "off",
"@typescript-eslint/explicit-module-boundary-types": "off",
diff --git a/frontend/build/shared/rspack/plugins/CssVarsDeclarationPlugin/css-vars-declaration-plugin.unit.spec.ts b/frontend/build/shared/rspack/plugins/CssVarsDeclarationPlugin/css-vars-declaration-plugin.unit.spec.ts
index 63db76be432..7ee8a7c57ec 100644
--- a/frontend/build/shared/rspack/plugins/CssVarsDeclarationPlugin/css-vars-declaration-plugin.unit.spec.ts
+++ b/frontend/build/shared/rspack/plugins/CssVarsDeclarationPlugin/css-vars-declaration-plugin.unit.spec.ts
@@ -64,6 +64,7 @@ function runPlugin({
},
};
+ // Unjustified type cast. FIXME
plugin.apply(mockCompiler as any);
tapCallback();
@@ -495,6 +496,7 @@ describe("CssVarsDeclarationPlugin", () => {
hooks: { environment: { tap: tapFn } },
};
+ // Unjustified type cast. FIXME
plugin.apply(mockCompiler as any);
expect(tapFn).toHaveBeenCalledWith(
"CssVarsDeclarationPlugin",
diff --git a/frontend/lint/eslint-plugin-metabase/index.js b/frontend/lint/eslint-plugin-metabase/index.js
index 1cc5ea98c35..57daa3c533c 100644
--- a/frontend/lint/eslint-plugin-metabase/index.js
+++ b/frontend/lint/eslint-plugin-metabase/index.js
@@ -20,5 +20,6 @@ module.exports = {
"no-unsafe-element-filtering": require("./rules/no-unsafe-element-filtering"),
"no-unscoped-text-selectors": require("./rules/no-unscoped-text-selectors"),
"no-analytics-import-outside-analytics-files": require("./rules/no-analytics-import-outside-analytics-files"),
+ "no-unjustified-type-casts": require("./rules/no-unjustified-type-casts"),
},
};
diff --git a/frontend/lint/eslint-plugin-metabase/rules/no-unjustified-type-casts.js b/frontend/lint/eslint-plugin-metabase/rules/no-unjustified-type-casts.js
new file mode 100644
index 00000000000..eec8ea11e6c
--- /dev/null
+++ b/frontend/lint/eslint-plugin-metabase/rules/no-unjustified-type-casts.js
@@ -0,0 +1,264 @@
+/**
+ * @fileoverview Require every TypeScript type cast (`expr as T` or `<T>expr`)
+ * to be preceded by a comment explaining why the cast is necessary.
+ *
+ * See https://app.notion.com/p/metabase/147-Require-justification-for-type-casts-36c69354c90180bd91ebee21b4566d0c
+ */
+
+const ERROR_MESSAGE =
+ "Type casts (`expr as T`, `<T>expr`) must be preceded by a comment explaining why the cast is necessary.";
+
+const CAST_NODE_TYPES = new Set(["TSAsExpression", "TSTypeAssertion"]);
+
+module.exports = {
+ meta: {
+ type: "problem",
+ docs: {
+ description:
+ "require a comment justifying every TypeScript type cast (`expr as T`, `<T>expr`)",
+ category: "Best Practices",
+ recommended: true,
+ },
+ schema: [],
+ fixable: null,
+ },
+
+ create(context) {
+ const sourceCode = context.sourceCode || context.getSourceCode();
+
+ function checkCast(node) {
+ if (isConstAssertion(node)) {
+ return;
+ }
+
+ if (!isOutermostCast(node)) {
+ return;
+ }
+
+ if (isJustified(sourceCode, node)) {
+ return;
+ }
+
+ context.report({ node, message: ERROR_MESSAGE });
+ }
+
+ return {
+ TSAsExpression: checkCast,
+ TSTypeAssertion: checkCast,
+ };
+ },
+};
+
+function isConstAssertion(node) {
+ const type = node.typeAnnotation;
+
+ return (
+ type != null &&
+ type.type === "TSTypeReference" &&
+ type.typeName != null &&
+ type.typeName.type === "Identifier" &&
+ type.typeName.name === "const"
+ );
+}
+
+function isOutermostCast(node) {
+ return !node.parent || !CAST_NODE_TYPES.has(node.parent.type);
+}
+
+function isJustified(sourceCode, node) {
+ if (hasSameLineCommentBefore(sourceCode, node)) {
+ return true;
+ }
+
+ const lineStartToken = getLineStartToken(
+ sourceCode,
+ sourceCode.getFirstToken(node),
+ );
+
+ if (
+ hasSameLineCommentBefore(sourceCode, lineStartToken) ||
+ isJustificationLine(sourceCode, lineStartToken.loc.start.line - 1)
+ ) {
+ return true;
+ }
+
+ const groupingStartToken = getGroupingStartToken(sourceCode, node);
+
+ return (
+ hasSameLineCommentBefore(sourceCode, groupingStartToken) ||
+ isJustificationLine(sourceCode, groupingStartToken.loc.start.line - 1)
+ );
+}
+
+function hasSameLineCommentBefore(sourceCode, anchor) {
+ const comments = sourceCode.getCommentsBefore(anchor);
+
+ if (comments.length === 0) {
+ return false;
+ }
+
+ const closest = comments[comments.length - 1];
+ return closest.loc.end.line === anchor.loc.start.line;
+}
+
+function isJustificationLine(sourceCode, line) {
+ if (line < 1) {
+ return false;
+ }
+
+ const comment = getCommentEndingOnLine(sourceCode, line);
+
+ if (comment == null) {
+ return false;
+ }
+
+ const spansLine = (token) =>
+ token.loc.end.line >= comment.loc.start.line &&
+ token.loc.start.line <= comment.loc.end.line;
+
+ let before = getCodeTokenBefore(sourceCode, comment);
+ let after = getCodeTokenAfter(sourceCode, comment);
+
+ if (
+ before != null &&
+ after != null &&
+ isEmptyJsxContainerBrace(sourceCode, before, after)
+ ) {
+ before = getCodeTokenBefore(sourceCode, before);
+ after = getCodeTokenAfter(sourceCode, after);
+ }
+
+ if (before != null && spansLine(before)) {
+ // oxfmt hoists a ternary branch's leading comment onto the operator line
+ // (`? // reason`), so a lone `?`/`:` before the comment is allowed.
+ if (!isTernaryBranchStart(before)) {
+ return false;
+ }
+
+ const beforeTernary = getCodeTokenBefore(sourceCode, before);
+
+ if (beforeTernary != null && spansLine(beforeTernary)) {
+ return false;
+ }
+ }
+
+ if (after != null && spansLine(after)) {
+ return false;
+ }
+
+ return true;
+}
+
+function isTernaryBranchStart(token) {
+ return (
+ token.type === "Punctuator" && (token.value === "?" || token.value === ":")
+ );
+}
+
+function getCommentEndingOnLine(sourceCode, line) {
+ const comments = sourceCode
+ .getAllComments()
+ .filter((comment) => comment.loc.end.line === line);
+
+ return comments.length > 0 ? comments[comments.length - 1] : null;
+}
+
+function getCodeTokenBefore(sourceCode, tokenOrComment) {
+ let token = sourceCode.getTokenBefore(tokenOrComment);
+
+ while (token != null && isBlankJsxText(token)) {
+ token = sourceCode.getTokenBefore(token);
+ }
+
+ return token;
+}
+
+function getCodeTokenAfter(sourceCode, tokenOrComment) {
+ let token = sourceCode.getTokenAfter(tokenOrComment);
+
+ while (token != null && isBlankJsxText(token)) {
+ token = sourceCode.getTokenAfter(token);
+ }
+
+ return token;
+}
+
+function isEmptyJsxContainerBrace(sourceCode, openBrace, closeBrace) {
+ if (
+ openBrace.type !== "Punctuator" ||
+ openBrace.value !== "{" ||
+ closeBrace.type !== "Punctuator" ||
+ closeBrace.value !== "}"
+ ) {
+ return false;
+ }
+
+ const container = sourceCode.getNodeByRangeIndex(openBrace.range[0]);
+
+ return (
+ container != null &&
+ container.type === "JSXExpressionContainer" &&
+ container.expression.type === "JSXEmptyExpression" &&
+ container.range[0] === openBrace.range[0] &&
+ container.range[1] === closeBrace.range[1]
+ );
+}
+
+function getGroupingStartToken(sourceCode, node) {
+ let token = getLineStartToken(sourceCode, sourceCode.getFirstToken(node));
+ let previous = sourceCode.getTokenBefore(token);
+
+ while (previous != null && isGroupingParen(sourceCode, previous)) {
+ token = getLineStartToken(sourceCode, previous);
+ previous = sourceCode.getTokenBefore(token);
+ }
+
+ return token;
+}
+
+function getLineStartToken(sourceCode, startToken) {
+ let token = startToken;
+ let previous = sourceCode.getTokenBefore(token);
+
+ while (
+ previous != null &&
+ previous.loc.end.line === token.loc.start.line &&
+ !isMultilineJsxText(previous)
+ ) {
+ token = previous;
+ previous = sourceCode.getTokenBefore(token);
+ }
+
+ return token;
+}
+
+function isMultilineJsxText(token) {
+ return (
+ token.type === "JSXText" && token.loc.start.line !== token.loc.end.line
+ );
+}
+
+function isBlankJsxText(token) {
+ return token.type === "JSXText" && token.value.trim() === "";
+}
+
+function isGroupingParen(sourceCode, token) {
+ if (token.type !== "Punctuator" || token.value !== "(") {
+ return false;
+ }
+
+ const before = sourceCode.getTokenBefore(token);
+
+ if (before == null) {
+ return true;
+ }
+
+ if (before.type === "Identifier" || before.type === "PrivateIdentifier") {
+ return false;
+ }
+
+ return !(
+ before.type === "Punctuator" &&
+ (before.value === ")" || before.value === "]" || before.value === "?.")
+ );
+}
diff --git a/frontend/lint/tests/no-unjustified-type-casts.unit.spec.js b/frontend/lint/tests/no-unjustified-type-casts.unit.spec.js
new file mode 100644
index 00000000000..abf74f4934b
--- /dev/null
+++ b/frontend/lint/tests/no-unjustified-type-casts.unit.spec.js
@@ -0,0 +1,333 @@
+import { RuleTester } from "eslint";
+import tseslint from "typescript-eslint";
+
+import rule from "../eslint-plugin-metabase/rules/no-unjustified-type-casts";
+
+const TS_FILENAME = "spec.ts"; // Angle-bracket casts only parse with JSX off
+const TSX_FILENAME = "spec.tsx";
+
+const ruleTester = new RuleTester({
+ languageOptions: {
+ parser: tseslint.parser,
+ sourceType: "module",
+ },
+});
+
+const message = /Type casts .* must be preceded by a comment/;
+
+const VALID_CASES = [
+ {
+ name: "line comment above statement",
+ code: `
+ // value comes from an untyped source
+ const x = value as Foo;
+ `,
+ },
+ {
+ name: "block comment above statement",
+ code: `
+ /* value comes from an untyped source */
+ const x = value as Foo;
+ `,
+ },
+ {
+ name: "inline block comment before cast",
+ code: `const x = /* safe */ value as Foo;`,
+ },
+ {
+ name: "inline comment before nested cast",
+ code: `doThing(/* safe */ value as Foo);`,
+ },
+ {
+ name: "comment above statement wrapping same-line cast",
+ code: `
+ // reason
+ return callback(value as Foo);
+ `,
+ },
+ {
+ name: "comment above a nested cast on its own line",
+ code: `
+ const obj = {
+ // reason
+ a: value as Foo,
+ };
+ `,
+ },
+ {
+ name: "comment above an arrow-returned cast",
+ code: `
+ const getGraph = () =>
+ // reason
+ ({ a: value }) as Foo;
+ `,
+ },
+ {
+ name: "comment above a cast in a call argument property",
+ code: `
+ foo({
+ // reason
+ id: value as unknown as number,
+ });
+ `,
+ },
+ {
+ name: "comment above the grouping paren of a parenthesized cast",
+ code: `
+ // reason
+ (
+ value as Foo
+ ).doThing();
+ `,
+ },
+ {
+ name: "as const literal",
+ code: `const x = { a: 1 } as const;`,
+ },
+ {
+ name: "as const on array",
+ code: `const x = [1, 2, 3] as const;`,
+ },
+ {
+ name: "chained cast with single comment",
+ code: `
+ // definitely safe
+ const x = value as unknown as Foo;
+ `,
+ },
+ {
+ name: "no cast",
+ code: `const x = value;`,
+ },
+ {
+ name: "satisfies is not a cast",
+ code: `const x = value satisfies Foo;`,
+ },
+ {
+ name: "angle-bracket cast with comment above",
+ code: `
+ // response comes from an untyped source
+ const user = <User>response;
+ `,
+ },
+ {
+ name: "angle-bracket const assertion",
+ code: `const x = <const>[1, 2, 3];`,
+ },
+ {
+ name: "mixed angle-bracket and as chain with single comment",
+ code: `
+ // definitely safe
+ const x = (<unknown>value) as Foo;
+ `,
+ },
+ {
+ name: "JSX comment on the line above a cast in JSX children",
+ filename: TSX_FILENAME,
+ code: `
+ function C() {
+ return (
+ <ul>
+ {/* reason */}
+ <Icon name={value as Foo} />
+ </ul>
+ );
+ }
+ `,
+ },
+ {
+ name: "inline comment inside a JSX expression container",
+ filename: TSX_FILENAME,
+ code: `
+ function C() {
+ return (
+ <ul>
+ <Icon name={/* reason */ value as Foo} />
+ </ul>
+ );
+ }
+ `,
+ },
+ {
+ name: "comment above a JSX element on the statement line",
+ filename: TSX_FILENAME,
+ code: `
+ function C() {
+ // reason
+ return <Icon name={value as Foo} />;
+ }
+ `,
+ },
+ {
+ name: "ternary branch comments after the ?/: operators",
+ code: `
+ const id = isDashboard
+ ? // reason
+ (item as Dashboard).id
+ : // reason
+ (item as Question).id();
+ `,
+ },
+];
+
+const INVALID_CASES = [
+ {
+ name: "simple cast without comment",
+ code: `const x = value as Foo;`,
+ errors: [{ message }],
+ },
+ {
+ name: "cast in call argument without comment",
+ code: `doThing(value as Foo);`,
+ errors: [{ message }],
+ },
+ {
+ name: "return cast without comment",
+ code: `function f() { return value as Foo; }`,
+ errors: [{ message }],
+ },
+ {
+ name: "chained cast reported once",
+ code: `const x = value as unknown as Foo;`,
+ errors: [{ message }],
+ },
+ {
+ name: "trailing comment does not justify the cast",
+ code: `const x = value as Foo; // this comment is after the cast`,
+ errors: [{ message }],
+ },
+ {
+ name: "comment separated by a blank line does not justify",
+ code: `
+ // far away comment
+
+ const x = value as Foo;
+ `,
+ errors: [{ message }],
+ },
+ {
+ name: "two independent casts each need a comment",
+ code: `
+ const a = one as Foo;
+ const b = two as Bar;
+ `,
+ errors: [{ message }, { message }],
+ },
+ {
+ name: "comment above statement but not above the nested cast line",
+ code: `
+ // reason
+ const obj = {
+ a: value as Foo,
+ };
+ `,
+ errors: [{ message }],
+ },
+ {
+ name: "comment above the arrow declaration but not above the returned cast",
+ code: `
+ // reason
+ const getGraph = () =>
+ ({ a: value }) as Foo;
+ `,
+ errors: [{ message }],
+ },
+ {
+ name: "comment above the call but not above the cast argument",
+ code: `
+ // reason
+ foo({
+ id: value as unknown as number,
+ });
+ `,
+ errors: [{ message }],
+ },
+ {
+ name: "parenthesized cast without a comment",
+ code: `
+ (
+ value as Foo
+ ).doThing();
+ `,
+ errors: [{ message }],
+ },
+ {
+ name: "angle-bracket cast without comment",
+ code: `const user = <User>response;`,
+ errors: [{ message }],
+ },
+ {
+ name: "angle-bracket chained cast reported once",
+ code: `const x = <Foo>(<unknown>value);`,
+ errors: [{ message }],
+ },
+ {
+ name: "trailing comment on the previous code line does not justify",
+ code: `
+ let x; // asd
+ const y = value as Foo;
+ `,
+ errors: [{ message }],
+ },
+ {
+ name: "trailing comment on a previous argument line does not justify",
+ code: `
+ foo(bar, // context
+ value as Foo);
+ `,
+ errors: [{ message }],
+ },
+ {
+ name: "comment after a single-line condition and ? does not justify",
+ code: `
+ const id = isDashboard ? // reason
+ (item as Dashboard).id : other;
+ `,
+ errors: [{ message }],
+ },
+ {
+ name: "comment above the statement does not justify a cast deeper in JSX",
+ filename: TSX_FILENAME,
+ code: `
+ function C() {
+ // too far from the cast
+ return (
+ <ul>
+ <li>
+ <Icon name={value as Foo} />
+ </li>
+ </ul>
+ );
+ }
+ `,
+ errors: [{ message }],
+ },
+ {
+ name: "JSX comment two lines above the cast does not justify",
+ filename: TSX_FILENAME,
+ code: `
+ function C() {
+ return (
+ <ul>
+ {/* too far */}
+ <li>filler</li>
+ <Icon name={value as Foo} />
+ </ul>
+ );
+ }
+ `,
+ errors: [{ message }],
+ },
+];
+
+ruleTester.run("no-unjustified-type-casts", rule, {
+ valid: VALID_CASES.map(({ code, filename }) => ({
+ code,
+ filename: filename ?? TS_FILENAME,
+ })),
+ invalid: INVALID_CASES.map(({ code, errors, filename }) => ({
+ code,
+ errors,
+ filename: filename ?? TS_FILENAME,
+ })),
+});
diff --git a/frontend/src/embedding-sdk-bundle/analytics/component-events.ts b/frontend/src/embedding-sdk-bundle/analytics/component-events.ts
index 0c5d3250d91..c6c2b6f53d0 100644
--- a/frontend/src/embedding-sdk-bundle/analytics/component-events.ts
+++ b/frontend/src/embedding-sdk-bundle/analytics/component-events.ts
@@ -161,10 +161,12 @@ export function useTrackSdkComponentMount<C extends SdkComponentName>(
const sdkVersion = getSdkPackageVersion();
const definedProperties = Object.fromEntries(
+ // Unjustified type cast. FIXME
Object.entries(properties as Record<string, unknown>).filter(
([, value]) => value !== undefined,
),
);
+ // Unjustified type cast. FIXME
const mergedProperties = {
...SDK_COMPONENT_DEFAULT_PROPERTIES[componentName],
...definedProperties,
@@ -172,6 +174,7 @@ export function useTrackSdkComponentMount<C extends SdkComponentName>(
const serializedProperties = Object.fromEntries(
Object.entries(
+ // Unjustified type cast. FIXME
mergedProperties as Record<string, boolean | string | null | undefined>,
).map(([key, value]) => [key, value == null ? null : String(value)]),
);
diff --git a/frontend/src/embedding-sdk-bundle/analytics/tracker.unit.spec.tsx b/frontend/src/embedding-sdk-bundle/analytics/tracker.unit.spec.tsx
index c31591852e7..6f8fa82e2a1 100644
--- a/frontend/src/embedding-sdk-bundle/analytics/tracker.unit.spec.tsx
+++ b/frontend/src/embedding-sdk-bundle/analytics/tracker.unit.spec.tsx
@@ -32,6 +32,7 @@ const mockInitSdkTracker = jest.mocked(initSdkTracker);
const mockTrackSdkSimpleEvent = jest.mocked(trackSdkSimpleEvent);
function makeStore() {
+ // Unjustified type cast. FIXME
return { dispatch: jest.fn(), getState: jest.fn() } as any;
}
diff --git a/frontend/src/embedding-sdk-bundle/bootstrap-auth.ts b/frontend/src/embedding-sdk-bundle/bootstrap-auth.ts
index e47d5f4fc92..15b807567b5 100644
--- a/frontend/src/embedding-sdk-bundle/bootstrap-auth.ts
+++ b/frontend/src/embedding-sdk-bundle/bootstrap-auth.ts
@@ -162,6 +162,7 @@ async function performFullAuthFlow(config: {
? { method: "jwt" as const, url: config.jwtProviderUri }
: await connectToInstanceAuthSso(config.metabaseInstanceUrl, {
headers,
+ // Unjustified type cast. FIXME
preferredAuthMethod: config.preferredAuthMethod as
| "jwt"
| "saml"
diff --git a/frontend/src/embedding-sdk-bundle/components/private/PublicComponentWrapper/SdkError.stories.tsx b/frontend/src/embedding-sdk-bundle/components/private/PublicComponentWrapper/SdkError.stories.tsx
index 69a29408d4e..4342ddbdb9c 100644
--- a/frontend/src/embedding-sdk-bundle/components/private/PublicComponentWrapper/SdkError.stories.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/private/PublicComponentWrapper/SdkError.stories.tsx
@@ -48,6 +48,7 @@ export const WithDocLink = {
};
export const Fixed = {
+ // Unjustified type cast. FIXME
render: ((args) => {
return (
<>
diff --git a/frontend/src/embedding-sdk-bundle/components/private/PublicComponentWrapper/SdkError.tsx b/frontend/src/embedding-sdk-bundle/components/private/PublicComponentWrapper/SdkError.tsx
index 7d8e08320fa..4eb35509498 100644
--- a/frontend/src/embedding-sdk-bundle/components/private/PublicComponentWrapper/SdkError.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/private/PublicComponentWrapper/SdkError.tsx
@@ -23,6 +23,7 @@ export const SdkError = ({
const errorMessage = useMemo(() => {
if (error && "code" in error && typeof error.code === "string") {
+ // Unjustified type cast. FIXME
const docsLink = ERROR_DOC_LINKS[error.code as MetabaseErrorCode];
if (docsLink) {
diff --git a/frontend/src/embedding-sdk-bundle/components/private/PublicComponentWrapper/withPublicComponentWrapper.tsx b/frontend/src/embedding-sdk-bundle/components/private/PublicComponentWrapper/withPublicComponentWrapper.tsx
index dd2cc49adb2..9f7deb79da1 100644
--- a/frontend/src/embedding-sdk-bundle/components/private/PublicComponentWrapper/withPublicComponentWrapper.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/private/PublicComponentWrapper/withPublicComponentWrapper.tsx
@@ -13,6 +13,7 @@ export function withPublicComponentWrapper<P extends object>(
WrappedComponent.displayName || WrappedComponent.name || "Component";
const WithPublicComponentWrapper: React.FC<P> = (props) => {
+ // Unjustified type cast. FIXME
const { height, width } = props as Partial<FlexibleSizeProps>;
return (
<GuestEmbedGuard
diff --git a/frontend/src/embedding-sdk-bundle/components/private/RenderIfHasContent/RenderIfHasContent.tsx b/frontend/src/embedding-sdk-bundle/components/private/RenderIfHasContent/RenderIfHasContent.tsx
index e916450b276..59f4d57463d 100644
--- a/frontend/src/embedding-sdk-bundle/components/private/RenderIfHasContent/RenderIfHasContent.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/private/RenderIfHasContent/RenderIfHasContent.tsx
@@ -83,6 +83,7 @@ function hasVisibleContent(element: HTMLElement): boolean {
}
return children.some((child) => {
+ // Unjustified type cast. FIXME
const el = child as HTMLElement;
if (el.hidden || el.style?.display === "none") {
diff --git a/frontend/src/embedding-sdk-bundle/components/private/SdkAdHocQuestion/SdkAdHocQuestion.tsx b/frontend/src/embedding-sdk-bundle/components/private/SdkAdHocQuestion/SdkAdHocQuestion.tsx
index 0eb4f95a264..4177a11ae5b 100644
--- a/frontend/src/embedding-sdk-bundle/components/private/SdkAdHocQuestion/SdkAdHocQuestion.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/private/SdkAdHocQuestion/SdkAdHocQuestion.tsx
@@ -72,6 +72,7 @@ export const SdkAdHocQuestion = ({
const questionId = resolveQuestionId(
params.slug,
+ // Unjustified type cast. FIXME
deserializedCard as { dataset_query?: { type?: string } } | undefined,
);
diff --git a/frontend/src/embedding-sdk-bundle/components/private/SdkBreadcrumbs/SdkBreadcrumbs.stories.tsx b/frontend/src/embedding-sdk-bundle/components/private/SdkBreadcrumbs/SdkBreadcrumbs.stories.tsx
index 627912a8f0b..9058c35555d 100644
--- a/frontend/src/embedding-sdk-bundle/components/private/SdkBreadcrumbs/SdkBreadcrumbs.stories.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/private/SdkBreadcrumbs/SdkBreadcrumbs.stories.tsx
@@ -47,6 +47,7 @@ const SdkBreadcrumbStory = () => {
const type = match<string, SdkBreadcrumbItemType>(item.model)
.with("card", () => "question")
.with("dataset", () => "model")
+ // Unjustified type cast. FIXME
.otherwise((model) => model as SdkBreadcrumbItemType);
setView({ type, id: item.id });
diff --git a/frontend/src/embedding-sdk-bundle/components/private/SdkBreadcrumbs/setup.spec.tsx b/frontend/src/embedding-sdk-bundle/components/private/SdkBreadcrumbs/setup.spec.tsx
index 1851e2e8232..3add8d5c2ca 100644
--- a/frontend/src/embedding-sdk-bundle/components/private/SdkBreadcrumbs/setup.spec.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/private/SdkBreadcrumbs/setup.spec.tsx
@@ -48,6 +48,7 @@ jest.mock("metabase/common/hooks/use-locale", () => ({
useLocale: jest.fn(),
}));
+// Unjustified type cast. FIXME
const useLocaleMock = useLocale as jest.Mock;
type View =
@@ -72,6 +73,7 @@ export const BreadcrumbsTestComponent = () => {
const type = match<string, SdkBreadcrumbItemType>(item.model)
.with("card", () => "question")
.with("dataset", () => "model")
+ // Unjustified type cast. FIXME
.otherwise((model) => model as SdkBreadcrumbItemType);
setView({ type, id: item.id });
diff --git a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Breakout/Breakout.stories.tsx b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Breakout/Breakout.stories.tsx
index 32f5d191a17..0a18366f825 100644
--- a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Breakout/Breakout.stories.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Breakout/Breakout.stories.tsx
@@ -4,6 +4,7 @@ import { Box, Flex } from "metabase/ui";
import { Breakout } from "./Breakout";
+// Unjustified type cast. FIXME
const QUESTION_ID = (window as any).QUESTION_ID || 12;
export default {
diff --git a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Breakout/BreakoutDropdown/BreakoutDropdown.stories.tsx b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Breakout/BreakoutDropdown/BreakoutDropdown.stories.tsx
index 1065afa8c82..0cbc779f33a 100644
--- a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Breakout/BreakoutDropdown/BreakoutDropdown.stories.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Breakout/BreakoutDropdown/BreakoutDropdown.stories.tsx
@@ -4,6 +4,7 @@ import { Box, Flex } from "metabase/ui";
import { BreakoutDropdown } from "./BreakoutDropdown";
+// Unjustified type cast. FIXME
const QUESTION_ID = (window as any).QUESTION_ID || 12;
export default {
diff --git a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Breakout/BreakoutPicker/BreakoutPicker.stories.tsx b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Breakout/BreakoutPicker/BreakoutPicker.stories.tsx
index e055ca73e82..57c30e1879b 100644
--- a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Breakout/BreakoutPicker/BreakoutPicker.stories.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Breakout/BreakoutPicker/BreakoutPicker.stories.tsx
@@ -4,6 +4,7 @@ import { Box } from "metabase/ui";
import { BreakoutPicker } from ".";
+// Unjustified type cast. FIXME
const QUESTION_ID = (window as any).QUESTION_ID || 12;
export default {
diff --git a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Breakout/use-breakout-data.ts b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Breakout/use-breakout-data.ts
index 24e0c38b24a..0dd9e3ad500 100644
--- a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Breakout/use-breakout-data.ts
+++ b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Breakout/use-breakout-data.ts
@@ -22,6 +22,7 @@ export const useBreakoutData = (): SDKBreakoutItem[] => {
lastVisibleStageIndex: stageIndex,
...interactiveQuestionContext
} = useSdkQuestionContext();
+ // Unjustified type cast. FIXME
const question = interactiveQuestionContext.question as Question;
const query = question?.query();
diff --git a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/ChartTypeDropdown/ChartTypeDropdown.stories.tsx b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/ChartTypeDropdown/ChartTypeDropdown.stories.tsx
index 1dca0aeceda..36899c8b0f5 100644
--- a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/ChartTypeDropdown/ChartTypeDropdown.stories.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/ChartTypeDropdown/ChartTypeDropdown.stories.tsx
@@ -4,6 +4,7 @@ import { Box, Flex } from "metabase/ui";
import { ChartTypeDropdown } from "./ChartTypeDropdown";
+// Unjustified type cast. FIXME
const QUESTION_ID = (window as any).QUESTION_ID || 12;
export default {
diff --git a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/ChartTypeDropdown/ChartTypeDropdown.tsx b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/ChartTypeDropdown/ChartTypeDropdown.tsx
index 6e9163f3c4d..8869fc3515b 100644
--- a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/ChartTypeDropdown/ChartTypeDropdown.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/ChartTypeDropdown/ChartTypeDropdown.tsx
@@ -128,6 +128,7 @@ export const ChartTypeDropdownInner = (props: ChartTypeDropdownInnerProps) => {
store={combobox}
position="bottom-start"
onOptionSubmit={(value) => {
+ // Unjustified type cast. FIXME
updateQuestionVisualization(value as CardDisplayType);
combobox.closeDropdown();
}}
diff --git a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/DownloadWidget/DownloadWidget.stories.tsx b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/DownloadWidget/DownloadWidget.stories.tsx
index 7726dfd2366..bcf413952bb 100644
--- a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/DownloadWidget/DownloadWidget.stories.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/DownloadWidget/DownloadWidget.stories.tsx
@@ -4,6 +4,7 @@ import { Box, type PopoverProps } from "metabase/ui";
import { DownloadWidget, type DownloadWidgetProps } from "./DownloadWidget";
+// Unjustified type cast. FIXME
const QUESTION_ID = (window as any).QUESTION_ID || 12;
export default {
diff --git a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/EditorButton/EditorButton.stories.tsx b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/EditorButton/EditorButton.stories.tsx
index 58300bf9f56..6b3779f1e81 100644
--- a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/EditorButton/EditorButton.stories.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/EditorButton/EditorButton.stories.tsx
@@ -7,6 +7,7 @@ import {
type EditorButtonProps as EditorButtonProps,
} from "./EditorButton";
+// Unjustified type cast. FIXME
const QUESTION_ID = (window as any).QUESTION_ID || 12;
export default {
diff --git a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Filter/Filter.stories.tsx b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Filter/Filter.stories.tsx
index c05a02575fb..d1e4208ced5 100644
--- a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Filter/Filter.stories.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Filter/Filter.stories.tsx
@@ -4,6 +4,7 @@ import { Box, Flex } from "metabase/ui";
import { Filter } from "./Filter";
+// Unjustified type cast. FIXME
const QUESTION_ID = (window as any).QUESTION_ID || 12;
export default {
diff --git a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Filter/FilterDropdown/FilterDropdown.stories.tsx b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Filter/FilterDropdown/FilterDropdown.stories.tsx
index 635e4fe66f8..20308f546ec 100644
--- a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Filter/FilterDropdown/FilterDropdown.stories.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Filter/FilterDropdown/FilterDropdown.stories.tsx
@@ -4,6 +4,7 @@ import { Box, Flex } from "metabase/ui";
import { FilterDropdown } from "./FilterDropdown";
+// Unjustified type cast. FIXME
const QUESTION_ID = (window as any).QUESTION_ID || 12;
export default {
diff --git a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/QuestionSettings/QuestionSettings.stories.tsx b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/QuestionSettings/QuestionSettings.stories.tsx
index ce02443b99b..834b5518688 100644
--- a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/QuestionSettings/QuestionSettings.stories.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/QuestionSettings/QuestionSettings.stories.tsx
@@ -4,6 +4,7 @@ import { Box, Stack } from "metabase/ui";
import { QuestionSettings } from "./QuestionSettings";
+// Unjustified type cast. FIXME
const QUESTION_ID = (window as any).QUESTION_ID || 11;
export default {
diff --git a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/QuestionSettings/QuestionSettingsDropdown/QuestionSettingsDropdown.stories.tsx b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/QuestionSettings/QuestionSettingsDropdown/QuestionSettingsDropdown.stories.tsx
index ea8e88f1d9a..ae539b007fd 100644
--- a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/QuestionSettings/QuestionSettingsDropdown/QuestionSettingsDropdown.stories.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/QuestionSettings/QuestionSettingsDropdown/QuestionSettingsDropdown.stories.tsx
@@ -4,6 +4,7 @@ import { Box, Stack } from "metabase/ui";
import { QuestionSettingsDropdown } from "./QuestionSettingsDropdown";
+// Unjustified type cast. FIXME
const QUESTION_ID = (window as any).QUESTION_ID || 11;
export default {
diff --git a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/SdkSaveQuestionForm.stories.tsx b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/SdkSaveQuestionForm.stories.tsx
index cb44159f264..85b87fd070a 100644
--- a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/SdkSaveQuestionForm.stories.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/SdkSaveQuestionForm.stories.tsx
@@ -8,6 +8,7 @@ import {
import { CommonSdkStoryWrapper } from "embedding-sdk-bundle/test/CommonSdkStoryWrapper";
import { Box, Button, Modal, Stack } from "metabase/ui";
+// Unjustified type cast. FIXME
const QUESTION_ID = (window as any).QUESTION_ID || 12;
export default {
diff --git a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Summarize/Summarize.stories.tsx b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Summarize/Summarize.stories.tsx
index 2d71df814d4..c40a735c7f7 100644
--- a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Summarize/Summarize.stories.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Summarize/Summarize.stories.tsx
@@ -4,6 +4,7 @@ import { Box, Group } from "metabase/ui";
import { Summarize } from "./Summarize";
+// Unjustified type cast. FIXME
const QUESTION_ID = (window as any).QUESTION_ID || 12;
export default {
diff --git a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Summarize/SummarizeDropdown/SummarizeDropdown.stories.tsx b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Summarize/SummarizeDropdown/SummarizeDropdown.stories.tsx
index e73c303b43c..a1a5a0cf7c6 100644
--- a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Summarize/SummarizeDropdown/SummarizeDropdown.stories.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Summarize/SummarizeDropdown/SummarizeDropdown.stories.tsx
@@ -4,6 +4,7 @@ import { Box, Stack } from "metabase/ui";
import { SummarizeDropdown } from "./SummarizeDropdown";
+// Unjustified type cast. FIXME
const QUESTION_ID = (window as any).QUESTION_ID || 12;
export default {
diff --git a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Summarize/SummarizePicker/SummarizePicker.stories.tsx b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Summarize/SummarizePicker/SummarizePicker.stories.tsx
index 696612e5fb7..e30f067c5e8 100644
--- a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Summarize/SummarizePicker/SummarizePicker.stories.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/Summarize/SummarizePicker/SummarizePicker.stories.tsx
@@ -4,6 +4,7 @@ import { Center, Popover } from "metabase/ui";
import { SummarizePicker } from "../SummarizePicker";
+// Unjustified type cast. FIXME
const QUESTION_ID = (window as any).QUESTION_ID || 12;
export default {
diff --git a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/VisualizationButton/VisualizationButton.stories.tsx b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/VisualizationButton/VisualizationButton.stories.tsx
index 531f3e2048a..f5fe8637503 100644
--- a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/VisualizationButton/VisualizationButton.stories.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/components/VisualizationButton/VisualizationButton.stories.tsx
@@ -8,6 +8,7 @@ import { useRunVisualization } from "../../hooks/use-run-visualization";
import { VisualizationButton } from "./VisualizationButton";
+// Unjustified type cast. FIXME
const QUESTION_ID = (window as any).QUESTION_ID || 12;
export default {
diff --git a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/context/SdkQuestionProvider.tsx b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/context/SdkQuestionProvider.tsx
index f1f7d5d7dc9..11c162f2b54 100644
--- a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/context/SdkQuestionProvider.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/context/SdkQuestionProvider.tsx
@@ -225,6 +225,7 @@ export const SdkQuestionProvider = ({
getEmbeddingMode({
question,
queryMode: EmbeddingSdkMode,
+ // Unjustified type cast. FIXME
plugins: plugins as InternalMetabasePluginsConfig,
})
);
diff --git a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/hooks/use-sensible-visualizations.ts b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/hooks/use-sensible-visualizations.ts
index 9293b52d22a..882340ca406 100644
--- a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/hooks/use-sensible-visualizations.ts
+++ b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/hooks/use-sensible-visualizations.ts
@@ -49,7 +49,9 @@ export const useSensibleVisualizations = () => {
);
return {
+ // Unjustified type cast. FIXME
sensibleVisualizations: sensibleVisualizations as CardDisplayType[],
+ // Unjustified type cast. FIXME
nonSensibleVisualizations: nonSensibleVisualizations as CardDisplayType[],
};
};
diff --git a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/hooks/use-stage-change-tooltip.unit.spec.ts b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/hooks/use-stage-change-tooltip.unit.spec.ts
index e99722f0266..c8856afd7ec 100644
--- a/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/hooks/use-stage-change-tooltip.unit.spec.ts
+++ b/frontend/src/embedding-sdk-bundle/components/private/SdkQuestion/hooks/use-stage-change-tooltip.unit.spec.ts
@@ -8,6 +8,7 @@ jest.mock("../context", () => ({
useSdkQuestionContext: jest.fn(() => ({ lastVisibleStageIndex: 1 })),
}));
+// Unjustified type cast. FIXME
const mockContext = useSdkQuestionContext as jest.MockedFunction<
typeof useSdkQuestionContext
>;
@@ -17,6 +18,7 @@ const setup = ({
}: {
lastVisibleStageIndex: number;
}) => {
+ // Unjustified type cast. FIXME
mockContext.mockReturnValue({
lastVisibleStageIndex,
} as ReturnType<typeof useSdkQuestionContext>);
diff --git a/frontend/src/embedding-sdk-bundle/components/public/CollectionBrowser/CollectionBrowser.unit.spec.tsx b/frontend/src/embedding-sdk-bundle/components/public/CollectionBrowser/CollectionBrowser.unit.spec.tsx
index 9ee7c3ff503..26981e09c01 100644
--- a/frontend/src/embedding-sdk-bundle/components/public/CollectionBrowser/CollectionBrowser.unit.spec.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/public/CollectionBrowser/CollectionBrowser.unit.spec.tsx
@@ -26,6 +26,7 @@ jest.mock("metabase/common/hooks/use-locale", () => ({
useLocale: jest.fn(),
}));
+// Unjustified type cast. FIXME
const useLocaleMock = useLocale as jest.Mock;
const BOBBY_TEST_COLLECTION = createMockCollection({
diff --git a/frontend/src/embedding-sdk-bundle/components/public/CreateDashboardModal/CreateDashboardModal.unit.spec.tsx b/frontend/src/embedding-sdk-bundle/components/public/CreateDashboardModal/CreateDashboardModal.unit.spec.tsx
index ad1c336a859..a9c49636f29 100644
--- a/frontend/src/embedding-sdk-bundle/components/public/CreateDashboardModal/CreateDashboardModal.unit.spec.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/public/CreateDashboardModal/CreateDashboardModal.unit.spec.tsx
@@ -27,6 +27,7 @@ jest.mock("metabase/common/hooks/use-locale", () => ({
useLocale: jest.fn(),
}));
+// Unjustified type cast. FIXME
const useLocaleMock = useLocale as jest.Mock;
const CURRENT_USER = createMockUser({
diff --git a/frontend/src/embedding-sdk-bundle/components/public/CreateQuestion/CreateQuestion.tsx b/frontend/src/embedding-sdk-bundle/components/public/CreateQuestion/CreateQuestion.tsx
index 2e865095d88..2ed56c6c3e1 100644
--- a/frontend/src/embedding-sdk-bundle/components/public/CreateQuestion/CreateQuestion.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/public/CreateQuestion/CreateQuestion.tsx
@@ -19,6 +19,7 @@ const CreateQuestionInner = (props: CreateQuestionProps = {}) => (
<InteractiveQuestion {...props} questionId="new" />
);
+// Unjustified type cast. FIXME
export const CreateQuestion = withPublicComponentWrapper(CreateQuestionInner, {
supportsGuestEmbed: false,
}) as typeof CreateQuestionInner;
diff --git a/frontend/src/embedding-sdk-bundle/components/public/InteractiveQuestion/InteractiveQuestion.stories.tsx b/frontend/src/embedding-sdk-bundle/components/public/InteractiveQuestion/InteractiveQuestion.stories.tsx
index e2c82d453c4..ff593ae7f25 100644
--- a/frontend/src/embedding-sdk-bundle/components/public/InteractiveQuestion/InteractiveQuestion.stories.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/public/InteractiveQuestion/InteractiveQuestion.stories.tsx
@@ -10,6 +10,7 @@ import { Box } from "metabase/ui";
import { InteractiveQuestion } from "./InteractiveQuestion";
+// Unjustified type cast. FIXME
const QUESTION_ID = (window as any).QUESTION_ID || questionIds.numberId;
type InteractiveQuestionComponentProps = ComponentProps<
diff --git a/frontend/src/embedding-sdk-bundle/components/public/InteractiveQuestion/InteractiveQuestion.tsx b/frontend/src/embedding-sdk-bundle/components/public/InteractiveQuestion/InteractiveQuestion.tsx
index 5d3aec58c5b..b8bdb5ab985 100644
--- a/frontend/src/embedding-sdk-bundle/components/public/InteractiveQuestion/InteractiveQuestion.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/public/InteractiveQuestion/InteractiveQuestion.tsx
@@ -125,6 +125,7 @@ function InteractiveQuestionInner(props: InteractiveQuestionInternalProps) {
const resolvedQuestionId = query
? resolveQuestionId(
undefined,
+ // Unjustified type cast. FIXME
deserializedCard as { dataset_query?: { type?: string } } | undefined,
)
: questionId;
@@ -204,6 +205,7 @@ const _InteractiveQuestionWrapped = withPublicComponentWrapper(
);
export const InteractiveQuestion = Object.assign(
+ // Unjustified type cast. FIXME
_InteractiveQuestionWrapped as FC<InteractiveQuestionProps>,
subComponents,
{ schema: interactiveQuestionSchema },
@@ -214,6 +216,7 @@ export const InteractiveQuestion = Object.assign(
* internal `query` prop. This component is intended for internal use only.
*/
export const InteractiveQuestionInternal = Object.assign(
+ // Unjustified type cast. FIXME
_InteractiveQuestionWrapped as FC<InteractiveQuestionInternalProps>,
subComponents,
{ schema: interactiveQuestionSchema },
diff --git a/frontend/src/embedding-sdk-bundle/components/public/SdkQuestion/SdkQuestion-themed.stories.tsx b/frontend/src/embedding-sdk-bundle/components/public/SdkQuestion/SdkQuestion-themed.stories.tsx
index 25fd702026a..cefcd98b387 100644
--- a/frontend/src/embedding-sdk-bundle/components/public/SdkQuestion/SdkQuestion-themed.stories.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/public/SdkQuestion/SdkQuestion-themed.stories.tsx
@@ -13,6 +13,7 @@ import { ComponentProvider } from "../ComponentProvider";
import { SdkQuestion } from "./SdkQuestion";
+// Unjustified type cast. FIXME
const QUESTION_ID = (window as any).QUESTION_ID || questionIds.numberId;
export default {
diff --git a/frontend/src/embedding-sdk-bundle/components/public/SdkQuestion/SdkQuestion.stories.tsx b/frontend/src/embedding-sdk-bundle/components/public/SdkQuestion/SdkQuestion.stories.tsx
index e4ba532a22c..8cf16c128b0 100644
--- a/frontend/src/embedding-sdk-bundle/components/public/SdkQuestion/SdkQuestion.stories.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/public/SdkQuestion/SdkQuestion.stories.tsx
@@ -23,6 +23,7 @@ import { SAMPLE_DB_ID } from "metabase-types/api/mocks/presets";
import { SdkQuestion } from "./SdkQuestion";
import { nativeQuestionWithParametersData } from "./data/data";
+// Unjustified type cast. FIXME
const QUESTION_ID = (window as any).QUESTION_ID || questionIds.numberId;
type SdkQuestionComponentProps = ComponentProps<typeof SdkQuestion>;
@@ -348,6 +349,7 @@ export const ControlledSqlParameters = {
// Smart query handler: filters rows by the pushed state / city /
// source params so the visualization reacts visibly to every push.
http.post(`*/api/card/${QUESTION_ID}/query`, async ({ request }) => {
+ // Unjustified type cast. FIXME
const body = (await request.json()) as {
parameters?: Array<{ id: string; value: unknown }>;
};
diff --git a/frontend/src/embedding-sdk-bundle/components/public/StaticQuestion/StaticQuestion.stories.tsx b/frontend/src/embedding-sdk-bundle/components/public/StaticQuestion/StaticQuestion.stories.tsx
index fbeb0a2e34a..6f948c8edd6 100644
--- a/frontend/src/embedding-sdk-bundle/components/public/StaticQuestion/StaticQuestion.stories.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/public/StaticQuestion/StaticQuestion.stories.tsx
@@ -10,6 +10,7 @@ import { Box } from "metabase/ui";
import { StaticQuestion } from "./StaticQuestion";
+// Unjustified type cast. FIXME
const QUESTION_ID = (window as any).QUESTION_ID || questionIds.numberId;
type StaticQuestionComponentProps = ComponentProps<typeof StaticQuestion>;
diff --git a/frontend/src/embedding-sdk-bundle/components/public/StaticQuestion/StaticQuestion.tsx b/frontend/src/embedding-sdk-bundle/components/public/StaticQuestion/StaticQuestion.tsx
index 7627ae5c1e9..3aa4a8b7980 100644
--- a/frontend/src/embedding-sdk-bundle/components/public/StaticQuestion/StaticQuestion.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/public/StaticQuestion/StaticQuestion.tsx
@@ -111,6 +111,7 @@ const StaticQuestionInner = (
// Normalize props for Guest Embed usage (e.g. enforce withDownloads in OSS).
const normalizedProps =
useNormalizeGuestEmbedQuestionOrDashboardComponentProps(
+ // Unjustified type cast. FIXME
props as StaticQuestionProps,
);
@@ -271,6 +272,7 @@ const _StaticQuestionWrapped = withPublicComponentWrapper(StaticQuestionInner, {
});
export const StaticQuestion = Object.assign(
+ // Unjustified type cast. FIXME
_StaticQuestionWrapped as FC<StaticQuestionProps>,
subComponents,
{ schema: staticQuestionSchema },
@@ -281,6 +283,7 @@ export const StaticQuestion = Object.assign(
* internal `query` prop. This component is intended for internal use only.
*/
export const StaticQuestionInternal = Object.assign(
+ // Unjustified type cast. FIXME
_StaticQuestionWrapped as FC<StaticQuestionInternalProps>,
subComponents,
{ schema: staticQuestionSchema },
diff --git a/frontend/src/embedding-sdk-bundle/components/public/dashboard/EditableDashboard/EditableDashboard.stories.tsx b/frontend/src/embedding-sdk-bundle/components/public/dashboard/EditableDashboard/EditableDashboard.stories.tsx
index bf41c98c1e8..5f96b8de127 100644
--- a/frontend/src/embedding-sdk-bundle/components/public/dashboard/EditableDashboard/EditableDashboard.stories.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/public/dashboard/EditableDashboard/EditableDashboard.stories.tsx
@@ -13,6 +13,7 @@ import {
type EditableDashboardProps,
} from "./EditableDashboard";
+// Unjustified type cast. FIXME
const DASHBOARD_ID = (window as any).DASHBOARD_ID || dashboardIds.numberId;
type CustomArgs = {
diff --git a/frontend/src/embedding-sdk-bundle/components/public/dashboard/EditableDashboard/EditableDashboard.tsx b/frontend/src/embedding-sdk-bundle/components/public/dashboard/EditableDashboard/EditableDashboard.tsx
index 36fffcf8e6d..b509c5c166e 100644
--- a/frontend/src/embedding-sdk-bundle/components/public/dashboard/EditableDashboard/EditableDashboard.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/public/dashboard/EditableDashboard/EditableDashboard.tsx
@@ -69,6 +69,7 @@ const EditableDashboardContent = (props: EditableDashboardProps) => {
getEmbeddingMode({
question,
queryMode: createEmbeddingSdkMode({ pushNavigation }),
+ // Unjustified type cast. FIXME
plugins: props.drillThroughQuestionProps
?.plugins as InternalMetabasePluginsConfig,
}),
diff --git a/frontend/src/embedding-sdk-bundle/components/public/dashboard/InteractiveDashboard/InteractiveDashboard.stories.tsx b/frontend/src/embedding-sdk-bundle/components/public/dashboard/InteractiveDashboard/InteractiveDashboard.stories.tsx
index 330239912e0..77e27849c1a 100644
--- a/frontend/src/embedding-sdk-bundle/components/public/dashboard/InteractiveDashboard/InteractiveDashboard.stories.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/public/dashboard/InteractiveDashboard/InteractiveDashboard.stories.tsx
@@ -11,6 +11,7 @@ import {
type InteractiveDashboardProps,
} from "./InteractiveDashboard";
+// Unjustified type cast. FIXME
const DASHBOARD_ID = (window as any).DASHBOARD_ID || dashboardIds.numberId;
export default {
diff --git a/frontend/src/embedding-sdk-bundle/components/public/dashboard/InteractiveDashboard/InteractiveDashboard.tsx b/frontend/src/embedding-sdk-bundle/components/public/dashboard/InteractiveDashboard/InteractiveDashboard.tsx
index 45a54f12472..57574253445 100644
--- a/frontend/src/embedding-sdk-bundle/components/public/dashboard/InteractiveDashboard/InteractiveDashboard.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/public/dashboard/InteractiveDashboard/InteractiveDashboard.tsx
@@ -62,6 +62,7 @@ export const InteractiveDashboardContent = (
getEmbeddingMode({
question,
queryMode: createEmbeddingSdkMode({ pushNavigation }),
+ // Unjustified type cast. FIXME
plugins: plugins as InternalMetabasePluginsConfig,
}),
[plugins, pushNavigation],
diff --git a/frontend/src/embedding-sdk-bundle/components/public/dashboard/SdkDashboard.stories.tsx b/frontend/src/embedding-sdk-bundle/components/public/dashboard/SdkDashboard.stories.tsx
index 4750588b510..69384527104 100644
--- a/frontend/src/embedding-sdk-bundle/components/public/dashboard/SdkDashboard.stories.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/public/dashboard/SdkDashboard.stories.tsx
@@ -25,6 +25,7 @@ import { SdkQuestion } from "../SdkQuestion";
import { SdkDashboard, type SdkDashboardProps } from "./SdkDashboard";
+// Unjustified type cast. FIXME
const DASHBOARD_ID = (window as any).DASHBOARD_ID || dashboardIds.numberId;
const darkTheme = storybookThemes.dark;
diff --git a/frontend/src/embedding-sdk-bundle/components/public/dashboard/SdkDashboard.tsx b/frontend/src/embedding-sdk-bundle/components/public/dashboard/SdkDashboard.tsx
index 2b3ec538260..96915016648 100644
--- a/frontend/src/embedding-sdk-bundle/components/public/dashboard/SdkDashboard.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/public/dashboard/SdkDashboard.tsx
@@ -669,6 +669,7 @@ const SdkDashboardInner = ({
);
};
+// Unjustified type cast. FIXME
export const SdkDashboard = withPublicComponentWrapper(SdkDashboardInner, {
supportsGuestEmbed: true,
}) as typeof SdkDashboardInner &
diff --git a/frontend/src/embedding-sdk-bundle/components/public/dashboard/StaticDashboard/CypressStaticDashboardWithCors.stories.tsx b/frontend/src/embedding-sdk-bundle/components/public/dashboard/StaticDashboard/CypressStaticDashboardWithCors.stories.tsx
index ce8a2b0bef5..303c3aa24aa 100644
--- a/frontend/src/embedding-sdk-bundle/components/public/dashboard/StaticDashboard/CypressStaticDashboardWithCors.stories.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/public/dashboard/StaticDashboard/CypressStaticDashboardWithCors.stories.tsx
@@ -3,6 +3,7 @@ import type { StoryFn } from "@storybook/react";
import { StaticDashboard } from "embedding-sdk-bundle/components/public/dashboard";
import { CommonSdkStoryCorsWrapper } from "embedding-sdk-bundle/test/CommonSdkCorsStoryWrapper";
+// Unjustified type cast. FIXME
const DASHBOARD_ID = (window as any).DASHBOARD_ID || 1;
export default {
diff --git a/frontend/src/embedding-sdk-bundle/components/public/dashboard/StaticDashboard/StaticDashboard.stories.tsx b/frontend/src/embedding-sdk-bundle/components/public/dashboard/StaticDashboard/StaticDashboard.stories.tsx
index b0afbbb8553..0301add4268 100644
--- a/frontend/src/embedding-sdk-bundle/components/public/dashboard/StaticDashboard/StaticDashboard.stories.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/public/dashboard/StaticDashboard/StaticDashboard.stories.tsx
@@ -9,6 +9,7 @@ import {
import type { StaticDashboardProps } from "./StaticDashboard";
+// Unjustified type cast. FIXME
const DASHBOARD_ID = (window as any).DASHBOARD_ID || dashboardIds.numberId;
export default {
diff --git a/frontend/src/embedding-sdk-bundle/components/public/dashboard/StaticDashboard/StaticDashboard.tsx b/frontend/src/embedding-sdk-bundle/components/public/dashboard/StaticDashboard/StaticDashboard.tsx
index d8e09e9b2c1..e7e778ac29b 100644
--- a/frontend/src/embedding-sdk-bundle/components/public/dashboard/StaticDashboard/StaticDashboard.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/public/dashboard/StaticDashboard/StaticDashboard.tsx
@@ -58,6 +58,7 @@ const StaticDashboardInner = (props: StaticDashboardProps) => {
return (
<SdkDashboard
+ // Unjustified type cast. FIXME
{...(normalizedProps as SdkDashboardProps)}
getClickActionMode={getClickActionMode}
dashboardActions={[
diff --git a/frontend/src/embedding-sdk-bundle/components/public/dashboard/StaticDashboard/tests/enterprise.unit.spec.tsx b/frontend/src/embedding-sdk-bundle/components/public/dashboard/StaticDashboard/tests/enterprise.unit.spec.tsx
index 466b4953f13..77fc69076cd 100644
--- a/frontend/src/embedding-sdk-bundle/components/public/dashboard/StaticDashboard/tests/enterprise.unit.spec.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/public/dashboard/StaticDashboard/tests/enterprise.unit.spec.tsx
@@ -22,6 +22,7 @@ const setupEnterprise = async (
return setupSdkDashboard({
...options,
enterprisePlugins: ["sdk_notifications"],
+ // Unjustified type cast. FIXME
component: StaticDashboard as ComponentType<SdkDashboardProps>,
});
};
diff --git a/frontend/src/embedding-sdk-bundle/components/public/dashboard/StaticDashboard/tests/premium.unit.spec.tsx b/frontend/src/embedding-sdk-bundle/components/public/dashboard/StaticDashboard/tests/premium.unit.spec.tsx
index a581f1b798c..a9a931a20e8 100644
--- a/frontend/src/embedding-sdk-bundle/components/public/dashboard/StaticDashboard/tests/premium.unit.spec.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/public/dashboard/StaticDashboard/tests/premium.unit.spec.tsx
@@ -23,6 +23,7 @@ const setupPremium = async (
embedding_sdk: true,
},
enterprisePlugins: ["sdk_notifications"],
+ // Unjustified type cast. FIXME
component: StaticDashboard as ComponentType<SdkDashboardProps>,
});
};
diff --git a/frontend/src/embedding-sdk-bundle/components/public/dashboard/tests/setup.tsx b/frontend/src/embedding-sdk-bundle/components/public/dashboard/tests/setup.tsx
index 63f14f68c0d..4c01226fc84 100644
--- a/frontend/src/embedding-sdk-bundle/components/public/dashboard/tests/setup.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/public/dashboard/tests/setup.tsx
@@ -148,6 +148,7 @@ export const setupSdkDashboard = async ({
isEmailConfigured = false,
isSlackConfigured = false,
}: SetupSdkDashboardOptions) => {
+ // Unjustified type cast. FIXME
const useLocaleMock = useLocale as jest.Mock;
useLocaleMock.mockReturnValue({ isLocaleLoading });
diff --git a/frontend/src/embedding-sdk-bundle/components/public/dashboard/use-common-dashboard-params.tsx b/frontend/src/embedding-sdk-bundle/components/public/dashboard/use-common-dashboard-params.tsx
index 5e28ac78da2..1b181aa439d 100644
--- a/frontend/src/embedding-sdk-bundle/components/public/dashboard/use-common-dashboard-params.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/public/dashboard/use-common-dashboard-params.tsx
@@ -68,6 +68,7 @@ export const useCommonDashboardParams = ({
parameterValues,
nextCard,
previousCard,
+ // Unjustified type cast. FIXME
dashcard: dashcard as QuestionDashboardCard,
objectId,
});
diff --git a/frontend/src/embedding-sdk-bundle/embedding-sdk-bootstrap.ts b/frontend/src/embedding-sdk-bundle/embedding-sdk-bootstrap.ts
index 2891f2061b4..9fb88915ce3 100644
--- a/frontend/src/embedding-sdk-bundle/embedding-sdk-bootstrap.ts
+++ b/frontend/src/embedding-sdk-bundle/embedding-sdk-bootstrap.ts
@@ -21,6 +21,7 @@ waitForAuthConfigAndStartEarlyAuthFlow();
const manifest: { chunks: string[] } = "__SDK_CHUNK_MANIFEST__" as any;
const scriptUrl =
+ // Unjustified type cast. FIXME
(document.currentScript as HTMLScriptElement | null)?.src || "";
const baseUrl = new URL("./", scriptUrl).href;
diff --git a/frontend/src/embedding-sdk-bundle/hooks/private/use-log-version-info/use-log-version-info.unit.spec.tsx b/frontend/src/embedding-sdk-bundle/hooks/private/use-log-version-info/use-log-version-info.unit.spec.tsx
index 03d0db6f233..2a230be0bfd 100644
--- a/frontend/src/embedding-sdk-bundle/hooks/private/use-log-version-info/use-log-version-info.unit.spec.tsx
+++ b/frontend/src/embedding-sdk-bundle/hooks/private/use-log-version-info/use-log-version-info.unit.spec.tsx
@@ -16,9 +16,11 @@ const setup = async ({
sdkPackageVersion: string;
sdkBundleVersion: string;
}) => {
+ // Unjustified type cast. FIXME
(getBuildInfo as jest.Mock).mockReturnValueOnce({
version: sdkPackageVersion,
});
+ // Unjustified type cast. FIXME
(getBuildInfo as jest.Mock).mockReturnValueOnce({
version: sdkBundleVersion,
});
diff --git a/frontend/src/embedding-sdk-bundle/hooks/private/use-normalize-component-provider-props.unit.spec.ts b/frontend/src/embedding-sdk-bundle/hooks/private/use-normalize-component-provider-props.unit.spec.ts
index 16c087376bd..8952666de6c 100644
--- a/frontend/src/embedding-sdk-bundle/hooks/private/use-normalize-component-provider-props.unit.spec.ts
+++ b/frontend/src/embedding-sdk-bundle/hooks/private/use-normalize-component-provider-props.unit.spec.ts
@@ -7,8 +7,10 @@ jest.mock("embedding-sdk-bundle/store", () => ({
useSdkSelector: jest.fn(),
}));
+// Unjustified type cast. FIXME
const mockUseSdkSelector = useSdkSelector as jest.Mock;
+// Unjustified type cast. FIXME
const BASE_PROPS = {
authConfig: { uri: "http://localhost" },
} as unknown as ComponentProviderInternalProps;
diff --git a/frontend/src/embedding-sdk-bundle/hooks/private/use-sdk-controlled-parameters.unit.spec.ts b/frontend/src/embedding-sdk-bundle/hooks/private/use-sdk-controlled-parameters.unit.spec.ts
index 5d3120c6e38..c2eb99144fc 100644
--- a/frontend/src/embedding-sdk-bundle/hooks/private/use-sdk-controlled-parameters.unit.spec.ts
+++ b/frontend/src/embedding-sdk-bundle/hooks/private/use-sdk-controlled-parameters.unit.spec.ts
@@ -27,13 +27,20 @@ jest.mock("metabase/dashboard/selectors", () => ({
getParameters: jest.fn(),
}));
+// Unjustified type cast. FIXME
const useSdkDispatchMock = useSdkDispatch as unknown as jest.Mock;
+// Unjustified type cast. FIXME
const useSdkSelectorMock = useSdkSelector as unknown as jest.Mock;
+// Unjustified type cast. FIXME
const startSdkListeningMock = startSdkListening as unknown as jest.Mock;
+// Unjustified type cast. FIXME
const getDashboardCompleteMock = getDashboardComplete as unknown as jest.Mock;
+// Unjustified type cast. FIXME
const getParameterValuesMock = getParameterValues as unknown as jest.Mock;
+// Unjustified type cast. FIXME
const getParametersMock = getParameters as unknown as jest.Mock;
+// Unjustified type cast. FIXME
const STATE_PARAM = {
id: "p1",
slug: "state",
@@ -42,6 +49,7 @@ const STATE_PARAM = {
target: ["variable", ["template-tag", "state"]],
} as unknown as UiParameter;
+// Unjustified type cast. FIXME
const CATEGORY_PARAM = {
id: "p2",
slug: "category",
diff --git a/frontend/src/embedding-sdk-bundle/hooks/private/use-sdk-controlled-sql-parameters.unit.spec.tsx b/frontend/src/embedding-sdk-bundle/hooks/private/use-sdk-controlled-sql-parameters.unit.spec.tsx
index 6f893220596..d6a3207f102 100644
--- a/frontend/src/embedding-sdk-bundle/hooks/private/use-sdk-controlled-sql-parameters.unit.spec.tsx
+++ b/frontend/src/embedding-sdk-bundle/hooks/private/use-sdk-controlled-sql-parameters.unit.spec.tsx
@@ -20,9 +20,12 @@ jest.mock("metabase-lib/v1/parameters/utils/cards", () => ({
getCardUiParameters: jest.fn(),
}));
+// Unjustified type cast. FIXME
const useSelectorMock = useSelector as unknown as jest.Mock;
+// Unjustified type cast. FIXME
const getCardUiParametersMock = getCardUiParameters as unknown as jest.Mock;
+// Unjustified type cast. FIXME
const STATE_PARAM = {
id: "p1",
slug: "state",
@@ -31,6 +34,7 @@ const STATE_PARAM = {
target: ["variable", ["template-tag", "state"]],
} as unknown as UiParameter;
+// Unjustified type cast. FIXME
const CITY_PARAM = {
id: "p2",
slug: "city",
@@ -42,8 +46,10 @@ const CITY_PARAM = {
const DEFAULT_DEFINITIONS: UiParameter[] = [STATE_PARAM, CITY_PARAM];
const makeQuestion = (id: number): Question =>
+ // Unjustified type cast. FIXME
({
id: () => id,
+ // Unjustified type cast. FIXME
card: () => ({}) as unknown,
parameters: () => undefined,
}) as unknown as Question;
diff --git a/frontend/src/embedding-sdk-bundle/hooks/private/use-sdk-custom-loader/use-sdk-custom-loader.unit.spec.tsx b/frontend/src/embedding-sdk-bundle/hooks/private/use-sdk-custom-loader/use-sdk-custom-loader.unit.spec.tsx
index b761820fb46..115ef5ded22 100644
--- a/frontend/src/embedding-sdk-bundle/hooks/private/use-sdk-custom-loader/use-sdk-custom-loader.unit.spec.tsx
+++ b/frontend/src/embedding-sdk-bundle/hooks/private/use-sdk-custom-loader/use-sdk-custom-loader.unit.spec.tsx
@@ -12,7 +12,9 @@ jest.mock("metabase/ui/components/feedback/Loader/Loader", () => ({
}));
const mockUseMetabaseProviderPropsStore =
+ // Unjustified type cast. FIXME
useMetabaseProviderPropsStore as jest.Mock;
+// Unjustified type cast. FIXME
const mockSetCustomLoader = setCustomLoader as jest.Mock;
const MockLoaderComponent = () => <div>Custom Loader</div>;
diff --git a/frontend/src/embedding-sdk-bundle/hooks/private/use-setup-content-translations.unit.spec.tsx b/frontend/src/embedding-sdk-bundle/hooks/private/use-setup-content-translations.unit.spec.tsx
index 317e2bac620..841597c96fc 100644
--- a/frontend/src/embedding-sdk-bundle/hooks/private/use-setup-content-translations.unit.spec.tsx
+++ b/frontend/src/embedding-sdk-bundle/hooks/private/use-setup-content-translations.unit.spec.tsx
@@ -19,10 +19,13 @@ jest.mock("metabase/plugins", () => ({
},
}));
+// Unjustified type cast. FIXME
const mockUseSdkSelector = useSdkSelector as unknown as jest.Mock;
const mockSetEndpointsForAuthEmbedding =
+ // Unjustified type cast. FIXME
PLUGIN_CONTENT_TRANSLATION.setEndpointsForAuthEmbedding as jest.Mock;
const mockSetEndpointsForStaticEmbedding =
+ // Unjustified type cast. FIXME
PLUGIN_CONTENT_TRANSLATION.setEndpointsForStaticEmbedding as jest.Mock;
describe("useSetupAuthContentTranslations", () => {
diff --git a/frontend/src/embedding-sdk-bundle/lib/controlled-parameters.unit.spec.ts b/frontend/src/embedding-sdk-bundle/lib/controlled-parameters.unit.spec.ts
index 7c5cad11876..79b35e32859 100644
--- a/frontend/src/embedding-sdk-bundle/lib/controlled-parameters.unit.spec.ts
+++ b/frontend/src/embedding-sdk-bundle/lib/controlled-parameters.unit.spec.ts
@@ -7,6 +7,7 @@ import {
mapExplicitNullToEmpty,
} from "./controlled-parameters";
+// Unjustified type cast. FIXME
const STATE_PARAM = {
id: "p1",
slug: "state",
@@ -16,6 +17,7 @@ const STATE_PARAM = {
target: ["variable", ["template-tag", "state"]],
} as unknown as UiParameter;
+// Unjustified type cast. FIXME
const CATEGORY_PARAM = {
id: "p2",
slug: "category",
diff --git a/frontend/src/embedding-sdk-bundle/lib/sdk-public-path.ts b/frontend/src/embedding-sdk-bundle/lib/sdk-public-path.ts
index 391b65ff507..54f67dbbcc7 100644
--- a/frontend/src/embedding-sdk-bundle/lib/sdk-public-path.ts
+++ b/frontend/src/embedding-sdk-bundle/lib/sdk-public-path.ts
@@ -45,6 +45,7 @@ const resolveAssetBaseUrl = (): string | undefined => {
return undefined;
}
+ // Unjustified type cast. FIXME
const scriptUrl = (document.currentScript as HTMLScriptElement | null)?.src;
if (!scriptUrl) {
diff --git a/frontend/src/embedding-sdk-bundle/lib/theme/color-tuple.ts b/frontend/src/embedding-sdk-bundle/lib/theme/color-tuple.ts
index 847b66ada3b..19a61dff3f1 100644
--- a/frontend/src/embedding-sdk-bundle/lib/theme/color-tuple.ts
+++ b/frontend/src/embedding-sdk-bundle/lib/theme/color-tuple.ts
@@ -12,4 +12,5 @@ type ColorTuple = [
];
export const colorTuple = (value: string): ColorTuple =>
+ // Unjustified type cast. FIXME
[...Array(10)].fill(value) as ColorTuple;
diff --git a/frontend/src/embedding-sdk-bundle/lib/theme/embedding-color-palette.unit.spec.ts b/frontend/src/embedding-sdk-bundle/lib/theme/embedding-color-palette.unit.spec.ts
index 2e281b07607..a612bd87314 100644
--- a/frontend/src/embedding-sdk-bundle/lib/theme/embedding-color-palette.unit.spec.ts
+++ b/frontend/src/embedding-sdk-bundle/lib/theme/embedding-color-palette.unit.spec.ts
@@ -11,6 +11,7 @@ describe("Embedding Color Palette", () => {
"accent3-dark": "#666",
};
+ // Unjustified type cast. FIXME
const palette = getEmbeddingColorPalette({
charts: [
expected.accent0,
diff --git a/frontend/src/embedding-sdk-bundle/lib/theme/get-embedding-theme.ts b/frontend/src/embedding-sdk-bundle/lib/theme/get-embedding-theme.ts
index 81d013948de..133c2eb62ae 100644
--- a/frontend/src/embedding-sdk-bundle/lib/theme/get-embedding-theme.ts
+++ b/frontend/src/embedding-sdk-bundle/lib/theme/get-embedding-theme.ts
@@ -72,6 +72,7 @@ export function getEmbeddingThemeOverride(
override.colors = {};
}
+ // Unjustified type cast. FIXME
override.colors[key as MetabaseColorKey] = colorTuple(
whitelabeledColors[key],
);
@@ -105,6 +106,7 @@ export function getEmbeddingThemeOverride(
// For example, if they forgot to define `background-secondary` but have
// defined `background`, we use it as a fallback.
for (const key in SDK_MISSING_COLORS_FALLBACK) {
+ // Unjustified type cast. FIXME
const targetColor = key as MappableSdkColor;
const fallbackColor = SDK_MISSING_COLORS_FALLBACK[targetColor];
@@ -119,10 +121,12 @@ export function getEmbeddingThemeOverride(
// Apply color palette overrides
for (const name in userColors) {
+ // Unjustified type cast. FIXME
const color = userColors[name as MetabaseColor];
if (color && typeof color === "string") {
const themeColorNames =
+ // Unjustified type cast. FIXME
SDK_TO_MAIN_APP_COLORS_MAPPING[name as MappableSdkColor];
// If the sdk color does not exist in the mapping, skip it.
@@ -144,6 +148,7 @@ export function getEmbeddingThemeOverride(
const accents = mapChartColorsToAccents(theme.colors.charts);
for (const _accentKey in accents) {
+ // Unjustified type cast. FIXME
const accentKey = _accentKey as MetabaseAccentColorKey;
const accentColor = accents[accentKey];
@@ -163,6 +168,7 @@ export function getEmbeddingThemeOverride(
for (const _tooltipKey in SDK_TO_MAIN_APP_TOOLTIP_COLORS_MAPPING) {
type TooltipKey = keyof NonNullable<MetabaseComponentTheme["tooltip"]>;
+ // Unjustified type cast. FIXME
const tooltipKey = _tooltipKey as TooltipKey;
const colorKey = SDK_TO_MAIN_APP_TOOLTIP_COLORS_MAPPING[tooltipKey];
const tooltipColor = theme.components.tooltip[tooltipKey];
diff --git a/frontend/src/embedding-sdk-bundle/lib/validate-function-schema.ts b/frontend/src/embedding-sdk-bundle/lib/validate-function-schema.ts
index 671ce4f83d5..7ec645d4554 100644
--- a/frontend/src/embedding-sdk-bundle/lib/validate-function-schema.ts
+++ b/frontend/src/embedding-sdk-bundle/lib/validate-function-schema.ts
@@ -20,12 +20,14 @@ const getErrorMetadata = <
}): TMetadata | null => {
switch (error.type) {
case "required":
+ // Unjustified type cast. FIXME
return {
errorCode: "missing_required_property",
data: error.params?.path ?? "",
parameterIndex,
} as TMetadata;
case "noUnknown":
+ // Unjustified type cast. FIXME
return {
errorCode: "unrecognized_keys",
data: error.params?.unknown ?? "",
@@ -58,6 +60,7 @@ export const validateFunctionSchema = <
return { success: true };
} catch (_error: unknown) {
+ // Unjustified type cast. FIXME
const error = _error as Yup.ValidationError;
const errorMetadata =
getErrorMetadata<FunctionParametersSchemaValidationErrorMetadata>({
@@ -88,6 +91,7 @@ export const validateFunctionSchema = <
return { success: true };
} catch (_error: unknown) {
+ // Unjustified type cast. FIXME
const error = _error as Yup.ValidationError;
const errorMetadata = getErrorMetadata<SchemaValidationErrorMetadata>({
error,
diff --git a/frontend/src/embedding-sdk-bundle/store/collections.ts b/frontend/src/embedding-sdk-bundle/store/collections.ts
index 40bdf4900d9..141447b8370 100644
--- a/frontend/src/embedding-sdk-bundle/store/collections.ts
+++ b/frontend/src/embedding-sdk-bundle/store/collections.ts
@@ -24,24 +24,27 @@ export const getCollectionIdValueFromReference = createSelector(
tenantCollectionId,
collectionReference,
): CollectionId | null => {
- return match(collectionReference)
- .with("personal", () => personalCollectionId as RegularCollectionId)
- .with("tenant", () => {
- if (!tenantCollectionId) {
+ return (
+ match(collectionReference)
+ // Unjustified type cast. FIXME
+ .with("personal", () => personalCollectionId as RegularCollectionId)
+ .with("tenant", () => {
+ if (!tenantCollectionId) {
+ throw new Error(
+ "You must be a tenant member to access the tenant collection.",
+ );
+ }
+
+ return tenantCollectionId;
+ })
+ .with("root", () => null)
+ .with(P.union(P.number, P.string), (id) => id)
+ .otherwise(() => {
throw new Error(
- "You must be a tenant member to access the tenant collection.",
+ "Invalid collection id, expected `number | string | 'root' | 'personal' | 'tenant'`",
);
- }
-
- return tenantCollectionId;
- })
- .with("root", () => null)
- .with(P.union(P.number, P.string), (id) => id)
- .otherwise(() => {
- throw new Error(
- "Invalid collection id, expected `number | string | 'root' | 'personal' | 'tenant'`",
- );
- });
+ })
+ );
},
);
@@ -62,23 +65,26 @@ export const getCollectionIdSlugFromReference = createSelector(
tenantCollectionId,
collectionReference,
): CollectionId => {
- return match(collectionReference)
- .with("personal", () => personalCollectionId as RegularCollectionId)
- .with("tenant", () => {
- if (!tenantCollectionId) {
+ return (
+ match(collectionReference)
+ // Unjustified type cast. FIXME
+ .with("personal", () => personalCollectionId as RegularCollectionId)
+ .with("tenant", () => {
+ if (!tenantCollectionId) {
+ throw new Error(
+ "You must be a tenant member to access the tenant collection.",
+ );
+ }
+
+ return tenantCollectionId;
+ })
+ .with("root", () => "root" as const)
+ .with(P.union(P.number, P.string), (id) => id)
+ .otherwise(() => {
throw new Error(
- "You must be a tenant member to access the tenant collection.",
+ "Invalid collection id, expected `number | string | 'root' | 'personal' | 'tenant'`",
);
- }
-
- return tenantCollectionId;
- })
- .with("root", () => "root" as const)
- .with(P.union(P.number, P.string), (id) => id)
- .otherwise(() => {
- throw new Error(
- "Invalid collection id, expected `number | string | 'root' | 'personal' | 'tenant'`",
- );
- });
+ })
+ );
},
);
diff --git a/frontend/src/embedding-sdk-bundle/store/guest-embed/auth.ts b/frontend/src/embedding-sdk-bundle/store/guest-embed/auth.ts
index cbe64a84e7f..4657f2ded1f 100644
--- a/frontend/src/embedding-sdk-bundle/store/guest-embed/auth.ts
+++ b/frontend/src/embedding-sdk-bundle/store/guest-embed/auth.ts
@@ -58,6 +58,7 @@ export const refreshGuestSession = createAsyncThunk(
export const getOrRefreshGuestSession = createAsyncThunk(
"sdk/guest-embed/GET_OR_REFRESH_TOKEN",
async (authConfig: MetabaseAuthConfig, { dispatch, getState }) => {
+ // Unjustified type cast. FIXME
const state = getState() as SdkStoreState;
const tokenState = getSessionTokenState(state);
const currentToken = tokenState.rawToken;
diff --git a/frontend/src/embedding-sdk-bundle/store/index.ts b/frontend/src/embedding-sdk-bundle/store/index.ts
index 995e7aab8cb..44db3f3b74c 100644
--- a/frontend/src/embedding-sdk-bundle/store/index.ts
+++ b/frontend/src/embedding-sdk-bundle/store/index.ts
@@ -13,6 +13,7 @@ import { sdkListenerMiddleware } from "./listener-middleware";
import { sdk } from "./reducer";
import type { SdkDispatch, SdkStore } from "./types";
+// Unjustified type cast. FIXME
export const sdkReducers = {
...commonReducers,
pulse: combineReducers(pulse),
@@ -22,6 +23,7 @@ export const sdkReducers = {
} as unknown as Record<string, Reducer>;
export const getSdkStore = () =>
+ // Unjustified type cast. FIXME
getStore(
sdkReducers,
null,
@@ -41,12 +43,14 @@ export const getSdkStore = () =>
export const useSdkDispatch = () => {
useCheckSdkReduxContext();
+ // Unjustified type cast. FIXME
return useDispatch() as SdkDispatch;
};
export const useSdkStore = () => {
useCheckSdkReduxContext();
+ // Unjustified type cast. FIXME
return useStore() as SdkStore;
};
diff --git a/frontend/src/embedding-sdk-bundle/store/listener-middleware.ts b/frontend/src/embedding-sdk-bundle/store/listener-middleware.ts
index d6a5a978c6f..34dae905ed4 100644
--- a/frontend/src/embedding-sdk-bundle/store/listener-middleware.ts
+++ b/frontend/src/embedding-sdk-bundle/store/listener-middleware.ts
@@ -26,4 +26,5 @@ export type SdkListenerPredicate = NonNullable<
export const sdkListenerMiddleware = createListenerMiddleware();
export const startSdkListening =
+ // Unjustified type cast. FIXME
sdkListenerMiddleware.startListening as SdkStartListening;
diff --git a/frontend/src/embedding-sdk-bundle/store/reducer.ts b/frontend/src/embedding-sdk-bundle/store/reducer.ts
index eadfacff5b7..896227939d0 100644
--- a/frontend/src/embedding-sdk-bundle/store/reducer.ts
+++ b/frontend/src/embedding-sdk-bundle/store/reducer.ts
@@ -102,6 +102,7 @@ export const sdk = createReducer(initialState, (builder) => {
});
builder.addCase(refreshTokenAsync.rejected, (state, action) => {
+ // Unjustified type cast. FIXME
const error = action.error as Error;
state.initStatus = { status: "error", error };
});
@@ -115,6 +116,7 @@ export const sdk = createReducer(initialState, (builder) => {
});
builder.addCase(initAuth.rejected, (state, action) => {
+ // Unjustified type cast. FIXME
const error = action.error as Error;
state.initStatus = { status: "error", error };
});
@@ -128,6 +130,7 @@ export const sdk = createReducer(initialState, (builder) => {
});
builder.addCase(initGuestEmbed.rejected, (state, action) => {
+ // Unjustified type cast. FIXME
const error = action.error as Error;
state.initStatus = { status: "error", error };
});
diff --git a/frontend/src/embedding-sdk-bundle/stories/sdk-locale-support.stories.tsx b/frontend/src/embedding-sdk-bundle/stories/sdk-locale-support.stories.tsx
index ac496c97eda..f7c9b014a34 100644
--- a/frontend/src/embedding-sdk-bundle/stories/sdk-locale-support.stories.tsx
+++ b/frontend/src/embedding-sdk-bundle/stories/sdk-locale-support.stories.tsx
@@ -9,6 +9,7 @@ export default {
export const DeLocale = () => (
<ComponentProvider authConfig={storybookSdkAuthDefaultConfig} locale="de">
<StaticDashboard
+ // Unjustified type cast. FIXME
dashboardId={(window as any).DASHBOARD_ID || 1}
withDownloads
/>
diff --git a/frontend/src/embedding-sdk-bundle/stories/styling-sdk-tests.stories.tsx b/frontend/src/embedding-sdk-bundle/stories/styling-sdk-tests.stories.tsx
index f77bc1aaee8..0b8f5d6d45f 100644
--- a/frontend/src/embedding-sdk-bundle/stories/styling-sdk-tests.stories.tsx
+++ b/frontend/src/embedding-sdk-bundle/stories/styling-sdk-tests.stories.tsx
@@ -28,6 +28,7 @@ export const NoStylesError = () => (
<h1>This is inside of the provider</h1>
</div>
+ {/* Unjustified type cast. FIXME */}
<StaticQuestion questionId={(window as any).QUESTION_ID || 1} />
</ComponentProvider>
</div>
@@ -45,6 +46,7 @@ export const NoStylesSuccess = () => (
<h1>This is inside of the provider</h1>
</div>
+ {/* Unjustified type cast. FIXME */}
<StaticQuestion questionId={(window as any).QUESTION_ID || 1} />
</ComponentProvider>
</div>
@@ -56,6 +58,7 @@ export const FontFromConfig = () => (
authConfig={storybookSdkAuthDefaultConfig}
theme={{ fontFamily: "Impact" }}
>
+ {/* Unjustified type cast. FIXME */}
<StaticQuestion questionId={(window as any).QUESTION_ID || 1} />
</ComponentProvider>
</div>
diff --git a/frontend/src/embedding-sdk-bundle/test/CommonSdkCorsStoryWrapper.tsx b/frontend/src/embedding-sdk-bundle/test/CommonSdkCorsStoryWrapper.tsx
index ef4e0961845..adc8f88ed51 100644
--- a/frontend/src/embedding-sdk-bundle/test/CommonSdkCorsStoryWrapper.tsx
+++ b/frontend/src/embedding-sdk-bundle/test/CommonSdkCorsStoryWrapper.tsx
@@ -7,6 +7,7 @@ import { ComponentProvider } from "embedding-sdk-bundle/components/public/Compon
import type { MetabaseAuthConfig } from "embedding-sdk-bundle/types";
const METABASE_INSTANCE_URL =
+ // Unjustified type cast. FIXME
(window as any).METABASE_INSTANCE_URL || "http://localhost:3000";
const DEFAULT_AUTH_CONFIG: MetabaseAuthConfig = {
diff --git a/frontend/src/embedding-sdk-bundle/test/CommonSdkStoryWrapper.tsx b/frontend/src/embedding-sdk-bundle/test/CommonSdkStoryWrapper.tsx
index b20b8d57814..73989fd2c47 100644
--- a/frontend/src/embedding-sdk-bundle/test/CommonSdkStoryWrapper.tsx
+++ b/frontend/src/embedding-sdk-bundle/test/CommonSdkStoryWrapper.tsx
@@ -13,8 +13,10 @@ import { USERS } from "../../../../e2e/support/cypress_data";
import { storybookThemes } from "./storybook-themes";
const METABASE_INSTANCE_URL =
+ // Unjustified type cast. FIXME
(window as any).METABASE_INSTANCE_URL || "http://localhost:3000";
const METABASE_JWT_SHARED_SECRET =
+ // Unjustified type cast. FIXME
(window as any).JWT_SHARED_SECRET || "0".repeat(64);
const secret = new TextEncoder().encode(METABASE_JWT_SHARED_SECRET);
diff --git a/frontend/src/embedding-sdk-bundle/test/__support__/ui.tsx b/frontend/src/embedding-sdk-bundle/test/__support__/ui.tsx
index 66110dd6b4d..1dba3533b14 100644
--- a/frontend/src/embedding-sdk-bundle/test/__support__/ui.tsx
+++ b/frontend/src/embedding-sdk-bundle/test/__support__/ui.tsx
@@ -53,6 +53,7 @@ export function renderWithSDKProviders(
const storeMiddleware = _.compact([Api.middleware]);
+ // Unjustified type cast. FIXME
const store = getStore(
sdkReducers,
initialState,
@@ -66,6 +67,7 @@ export function renderWithSDKProviders(
if (metabaseEmbeddingSdkBundleExports) {
window.METABASE_EMBEDDING_SDK_BUNDLE =
+ // Unjustified type cast. FIXME
metabaseEmbeddingSdkBundleExports as typeof window.METABASE_EMBEDDING_SDK_BUNDLE;
ensureMetabaseProviderPropsStore().updateInternalProps({
diff --git a/frontend/src/embedding-sdk-bundle/test/mocks/sso.ts b/frontend/src/embedding-sdk-bundle/test/mocks/sso.ts
index c20b3674882..8017fdb8da7 100644
--- a/frontend/src/embedding-sdk-bundle/test/mocks/sso.ts
+++ b/frontend/src/embedding-sdk-bundle/test/mocks/sso.ts
@@ -124,6 +124,7 @@ export const setupSamlPopup = () => {
jest
.spyOn(window, "open")
+ // Unjustified type cast. FIXME
.mockImplementation(() => popupMock as unknown as Window);
// Wait until the next tick to simulate popup message
diff --git a/frontend/src/embedding-sdk-shared/.storybook/main.ts b/frontend/src/embedding-sdk-shared/.storybook/main.ts
index 2bda603c1e8..fb6d874ce3e 100644
--- a/frontend/src/embedding-sdk-shared/.storybook/main.ts
+++ b/frontend/src/embedding-sdk-shared/.storybook/main.ts
@@ -52,6 +52,7 @@ function resolveEmbeddingSdkPackage(): ResolvedSdkPackage {
"utf-8",
);
embeddingSdkPackageVersion = JSON.stringify(
+ // Unjustified type cast. FIXME
(JSON.parse(packageJsonContent) as { version: string }).version,
);
} catch {
@@ -61,6 +62,7 @@ function resolveEmbeddingSdkPackage(): ResolvedSdkPackage {
),
"utf-8",
);
+ // Unjustified type cast. FIXME
const sdkPackageTemplateJsonContent = JSON.parse(
sdkPackageTemplateJson,
) as { version: string };
diff --git a/frontend/src/embedding-sdk-shared/hooks/use-metabase-provider-props-store.unit.spec.tsx b/frontend/src/embedding-sdk-shared/hooks/use-metabase-provider-props-store.unit.spec.tsx
index 0f34abab5a2..d020d667b6c 100644
--- a/frontend/src/embedding-sdk-shared/hooks/use-metabase-provider-props-store.unit.spec.tsx
+++ b/frontend/src/embedding-sdk-shared/hooks/use-metabase-provider-props-store.unit.spec.tsx
@@ -8,6 +8,7 @@ import { useMetabaseProviderPropsStore } from "./use-metabase-provider-props-sto
const PROPS_STORE_KEY = "METABASE_PROVIDER_PROPS_STORE" as const;
const resetWindow = () => {
+ // Unjustified type cast. FIXME
delete (window as any)[PROPS_STORE_KEY];
};
diff --git a/frontend/src/embedding-sdk-shared/lib/apply-theme-preset.unit.spec.ts b/frontend/src/embedding-sdk-shared/lib/apply-theme-preset.unit.spec.ts
index 09d48b61fe6..708efa17496 100644
--- a/frontend/src/embedding-sdk-shared/lib/apply-theme-preset.unit.spec.ts
+++ b/frontend/src/embedding-sdk-shared/lib/apply-theme-preset.unit.spec.ts
@@ -68,6 +68,7 @@ describe("applyThemePreset", () => {
describe("invalid preset", () => {
it("returns empty colors for unknown preset", () => {
const theme = {
+ // Unjustified type cast. FIXME
preset: "invalid-preset" as any,
colors: { brand: "#custom" },
};
diff --git a/frontend/src/embedding-sdk-shared/lib/ensure-metabase-provider-props-store.ts b/frontend/src/embedding-sdk-shared/lib/ensure-metabase-provider-props-store.ts
index 3dcb63875cc..1b4266f3b5c 100644
--- a/frontend/src/embedding-sdk-shared/lib/ensure-metabase-provider-props-store.ts
+++ b/frontend/src/embedding-sdk-shared/lib/ensure-metabase-provider-props-store.ts
@@ -88,6 +88,7 @@ export function ensureMetabaseProviderPropsStore(): MetabaseProviderPropsStore {
listeners.forEach((callback) => callback());
},
setProps(props) {
+ // Unjustified type cast. FIXME
state = {
...state,
props: {
diff --git a/frontend/src/metabase-lib/metric/core.ts b/frontend/src/metabase-lib/metric/core.ts
index d59670dee72..77c17bda66b 100644
--- a/frontend/src/metabase-lib/metric/core.ts
+++ b/frontend/src/metabase-lib/metric/core.ts
@@ -1,3 +1,4 @@
+/* eslint-disable metabase/no-unjustified-type-casts */
import dayjs, { type Dayjs } from "dayjs";
import * as LibMetric from "cljs/metabase.lib_metric.js";
diff --git a/frontend/src/metabase-lib/metric/core.unit.spec.ts b/frontend/src/metabase-lib/metric/core.unit.spec.ts
index 7314bf032b4..9c12b315211 100644
--- a/frontend/src/metabase-lib/metric/core.unit.spec.ts
+++ b/frontend/src/metabase-lib/metric/core.unit.spec.ts
@@ -536,6 +536,7 @@ describe("metabase-lib/metric/core", () => {
// New format uses expression instead of source-metric
const jsObj = jsDefinition as Record<string, unknown>;
expect(jsObj["expression"]).toBeDefined();
+ // Unjustified type cast. FIXME
const expression = jsObj["expression"] as unknown[];
expect(expression[0]).toBe("metric");
expect(expression[2]).toBe(SAMPLE_METRIC.id);
@@ -1606,6 +1607,7 @@ describe("metabase-lib/metric/core", () => {
expect(parts).not.toBeNull();
// StringFilterParts has an options property
expect(parts).toHaveProperty("options");
+ // Unjustified type cast. FIXME
expect((parts as { operator: string }).operator).toBe("=");
});
@@ -1622,6 +1624,7 @@ describe("metabase-lib/metric/core", () => {
const parts = LibMetric.filterParts(updatedDef, clause);
expect(parts).not.toBeNull();
+ // Unjustified type cast. FIXME
expect((parts as { operator: string }).operator).toBe("is-null");
});
@@ -1645,7 +1648,9 @@ describe("metabase-lib/metric/core", () => {
// RelativeDateFilterParts has unit and value properties
expect(parts).toHaveProperty("unit");
expect(parts).toHaveProperty("value");
+ // Unjustified type cast. FIXME
expect((parts as { unit: string }).unit).toBe("day");
+ // Unjustified type cast. FIXME
expect((parts as { value: number }).value).toBe(-30);
});
@@ -1663,7 +1668,9 @@ describe("metabase-lib/metric/core", () => {
const parts = LibMetric.filterParts(updatedDef, clause);
expect(parts).not.toBeNull();
+ // Unjustified type cast. FIXME
expect((parts as { operator: string }).operator).toBe("between");
+ // Unjustified type cast. FIXME
expect((parts as { values: number[] }).values).toEqual([10, 100]);
});
@@ -1681,7 +1688,9 @@ describe("metabase-lib/metric/core", () => {
const parts = LibMetric.filterParts(updatedDef, clause);
expect(parts).not.toBeNull();
+ // Unjustified type cast. FIXME
expect((parts as { operator: string }).operator).toBe("=");
+ // Unjustified type cast. FIXME
expect((parts as { values: boolean[] }).values).toEqual([true]);
});
@@ -1700,6 +1709,7 @@ describe("metabase-lib/metric/core", () => {
const parts = LibMetric.filterParts(updatedDef, clause);
expect(parts).not.toBeNull();
+ // Unjustified type cast. FIXME
expect((parts as { operator: string }).operator).toBe("=");
// CoordinateFilterParts has longitudeDimension property
expect(parts).toHaveProperty("longitudeDimension");
@@ -1720,9 +1730,11 @@ describe("metabase-lib/metric/core", () => {
const parts = LibMetric.filterParts(updatedDef, clause);
expect(parts).not.toBeNull();
+ // Unjustified type cast. FIXME
expect((parts as { operator: string }).operator).toBe("=");
// SpecificDateFilterParts has hasTime property
expect(parts).toHaveProperty("hasTime");
+ // Unjustified type cast. FIXME
expect((parts as { hasTime: boolean }).hasTime).toBe(false);
});
@@ -1740,6 +1752,7 @@ describe("metabase-lib/metric/core", () => {
const parts = LibMetric.filterParts(updatedDef, clause);
expect(parts).not.toBeNull();
+ // Unjustified type cast. FIXME
expect((parts as { operator: string }).operator).toBe(">");
});
@@ -1758,9 +1771,11 @@ describe("metabase-lib/metric/core", () => {
const parts = LibMetric.filterParts(updatedDef, clause);
expect(parts).not.toBeNull();
+ // Unjustified type cast. FIXME
expect((parts as { operator: string }).operator).toBe("!=");
// ExcludeDateFilterParts has unit property
expect(parts).toHaveProperty("unit");
+ // Unjustified type cast. FIXME
expect((parts as { unit: string }).unit).toBe("day-of-week");
});
});
diff --git a/frontend/src/metabase-lib/query/clauses/define.ts b/frontend/src/metabase-lib/query/clauses/define.ts
index 4d6b9363891..8e5614d8293 100644
--- a/frontend/src/metabase-lib/query/clauses/define.ts
+++ b/frontend/src/metabase-lib/query/clauses/define.ts
@@ -8,6 +8,7 @@ export function defineClauses<
options: Partial<MBQLClauseDefinition>,
clauses: T,
): Record<keyof T, MBQLClauseDefinition> {
+ // Unjustified type cast. FIXME
const result = {} as Record<keyof T, MBQLClauseDefinition>;
for (const name in clauses) {
if (names.has(name)) {
diff --git a/frontend/src/metabase-lib/query/order_by.unit.spec.ts b/frontend/src/metabase-lib/query/order_by.unit.spec.ts
index f04a327cba6..373a4c0c76e 100644
--- a/frontend/src/metabase-lib/query/order_by.unit.spec.ts
+++ b/frontend/src/metabase-lib/query/order_by.unit.spec.ts
@@ -124,6 +124,7 @@ describe("order by", () => {
);
expect(
+ // Unjustified type cast. FIXME
Lib.displayInfo(query, 0, productsTitle as Lib.ColumnMetadata),
).toEqual(
expect.objectContaining({
diff --git a/frontend/src/metabase-lib/v1/metadata/Database.unit.spec.ts b/frontend/src/metabase-lib/v1/metadata/Database.unit.spec.ts
index c9502a1790c..deb43e39911 100644
--- a/frontend/src/metabase-lib/v1/metadata/Database.unit.spec.ts
+++ b/frontend/src/metabase-lib/v1/metadata/Database.unit.spec.ts
@@ -186,6 +186,7 @@ describe("Database", () => {
const database = setup();
const question = database.nativeQuestion({ query: "SELECT 1" });
+ // Unjustified type cast. FIXME
const query = question.legacyNativeQuery() as NativeQuery;
expect(query.queryText()).toBe("SELECT 1");
});
diff --git a/frontend/src/metabase-lib/v1/metadata/Table.ts b/frontend/src/metabase-lib/v1/metadata/Table.ts
index b4ccbabc3fe..7a884fc4670 100644
--- a/frontend/src/metabase-lib/v1/metadata/Table.ts
+++ b/frontend/src/metabase-lib/v1/metadata/Table.ts
@@ -117,6 +117,7 @@ class Table {
if (!fields) {
return [];
}
+ // Unjustified type cast. FIXME
return fields
.filter((field) => field.isFK() && field.fk_target_field_id)
.map((field) => this.metadata?.field(field.fk_target_field_id)?.table)
diff --git a/frontend/src/metabase-lib/v1/metadata/utils/models.ts b/frontend/src/metabase-lib/v1/metadata/utils/models.ts
index 9951df7de3e..0ebb296e248 100644
--- a/frontend/src/metabase-lib/v1/metadata/utils/models.ts
+++ b/frontend/src/metabase-lib/v1/metadata/utils/models.ts
@@ -90,6 +90,7 @@ export function checkCanBeModel(question: Question) {
return true;
}
+ // Unjustified type cast. FIXME
return (question.legacyNativeQuery() as NativeQuery)
.templateTags()
.every(isSupportedTemplateTagForModel);
diff --git a/frontend/src/metabase-lib/v1/parameters/utils/cards.ts b/frontend/src/metabase-lib/v1/parameters/utils/cards.ts
index 11780236d93..15a53d08a33 100644
--- a/frontend/src/metabase-lib/v1/parameters/utils/cards.ts
+++ b/frontend/src/metabase-lib/v1/parameters/utils/cards.ts
@@ -30,6 +30,7 @@ export function getCardUiParameters(
const question = new Question(card, metadata);
return valuePopulatedParameters.map((parameter) => {
+ // Unjustified type cast. FIXME
const target: ParameterTarget | undefined = (
parameter as ParameterWithTarget
).target;
diff --git a/frontend/src/metabase-lib/v1/parameters/utils/filters.unit.spec.ts b/frontend/src/metabase-lib/v1/parameters/utils/filters.unit.spec.ts
index cf86461020c..225e2bb25ff 100644
--- a/frontend/src/metabase-lib/v1/parameters/utils/filters.unit.spec.ts
+++ b/frontend/src/metabase-lib/v1/parameters/utils/filters.unit.spec.ts
@@ -176,6 +176,7 @@ function createMockDimension(
const dimension = new TemplateTagDimension(
"tag",
metadata,
+ // Unjustified type cast. FIXME
question.legacyNativeQuery() as NativeQuery,
);
return Object.assign(dimension, mocks);
diff --git a/frontend/src/metabase-lib/v1/parameters/utils/parameter-fields.unit.spec.ts b/frontend/src/metabase-lib/v1/parameters/utils/parameter-fields.unit.spec.ts
index 7fc01eba521..c883adf329e 100644
--- a/frontend/src/metabase-lib/v1/parameters/utils/parameter-fields.unit.spec.ts
+++ b/frontend/src/metabase-lib/v1/parameters/utils/parameter-fields.unit.spec.ts
@@ -14,6 +14,7 @@ describe("parameters/utils/parameter-fields", () => {
}),
],
});
+ // Unjustified type cast. FIXME
const field = metadata.field(1) as Field;
const parameterWithFields = createMockUiParameter({
fields: [field],
diff --git a/frontend/src/metabase-lib/v1/parameters/utils/parameter-source.unit.spec.ts b/frontend/src/metabase-lib/v1/parameters/utils/parameter-source.unit.spec.ts
index cb171796066..499945e01e6 100644
--- a/frontend/src/metabase-lib/v1/parameters/utils/parameter-source.unit.spec.ts
+++ b/frontend/src/metabase-lib/v1/parameters/utils/parameter-source.unit.spec.ts
@@ -26,10 +26,15 @@ const metadata = createMockMetadata({
],
});
+// Unjustified type cast. FIXME
const listField = metadata.field(LIST_FIELD_ID) as Field;
+// Unjustified type cast. FIXME
const listField2 = metadata.field(LIST_FIELD_2_ID) as Field;
+// Unjustified type cast. FIXME
const searchField = metadata.field(SEARCH_FIELD_ID) as Field;
+// Unjustified type cast. FIXME
const searchField2 = metadata.field(SEARCH_FIELD_2_ID) as Field;
+// Unjustified type cast. FIXME
const noValuesField = metadata.field(NO_VALUES_FIELD_ID) as Field;
describe("getQueryType", () => {
diff --git a/frontend/src/metabase-lib/v1/parameters/utils/targets.unit.spec.ts b/frontend/src/metabase-lib/v1/parameters/utils/targets.unit.spec.ts
index 33be427bd4b..8c245282599 100644
--- a/frontend/src/metabase-lib/v1/parameters/utils/targets.unit.spec.ts
+++ b/frontend/src/metabase-lib/v1/parameters/utils/targets.unit.spec.ts
@@ -53,7 +53,9 @@ const metadata = createMockMetadata({
databases: [sampleDb, savedQuestionsDb],
});
+// Unjustified type cast. FIXME
const db = metadata.database(SAMPLE_DB_ID) as Database;
+// Unjustified type cast. FIXME
const productsTable = metadata.table(PRODUCTS_ID) as Table;
const provider = createMetadataProvider({
databaseId: db.id,
diff --git a/frontend/src/metabase-lib/v1/queries/utils/native-query-table.unit.spec.ts b/frontend/src/metabase-lib/v1/queries/utils/native-query-table.unit.spec.ts
index 494aee485ae..fa8d15687da 100644
--- a/frontend/src/metabase-lib/v1/queries/utils/native-query-table.unit.spec.ts
+++ b/frontend/src/metabase-lib/v1/queries/utils/native-query-table.unit.spec.ts
@@ -76,6 +76,7 @@ const metadata = createMockMetadata({
describe("metabase-lib/v1/queries/utils/native-query-table", () => {
describe("native query associated with a model", () => {
+ // Unjustified type cast. FIXME
const virtualTable = metadata.table(MODEL_VIRTUAL_TABLE_ID) as Table;
it("should return a nested card table using the given query's question", () => {
@@ -98,12 +99,15 @@ describe("metabase-lib/v1/queries/utils/native-query-table", () => {
});
describe("native query associated with both a `collection` and a `database`", () => {
+ // Unjustified type cast. FIXME
const productsTable = metadata.table(PRODUCTS_ID) as Table;
+ // Unjustified type cast. FIXME
const nativeQuestionWithCollection = metadata.question(
cardWithCollection.id,
) as Question;
const table = getNativeQueryTable(
+ // Unjustified type cast. FIXME
nativeQuestionWithCollection.legacyNativeQuery() as NativeQuery,
);
@@ -113,8 +117,10 @@ describe("metabase-lib/v1/queries/utils/native-query-table", () => {
});
describe("basic native query question", () => {
+ // Unjustified type cast. FIXME
const nativeQuestion = metadata.question(card.id) as Question;
const table = getNativeQueryTable(
+ // Unjustified type cast. FIXME
nativeQuestion.legacyNativeQuery() as NativeQuery,
);
diff --git a/frontend/src/metabase-lib/v1/queries/utils/pivot.unit.spec.ts b/frontend/src/metabase-lib/v1/queries/utils/pivot.unit.spec.ts
index 96396c93a14..7bbf303cb6d 100644
--- a/frontend/src/metabase-lib/v1/queries/utils/pivot.unit.spec.ts
+++ b/frontend/src/metabase-lib/v1/queries/utils/pivot.unit.spec.ts
@@ -112,6 +112,7 @@ describe("migratePivotColumnSplitSetting", () => {
field_ref: ["field", 1, null],
});
const setting: FieldRefColumnSplitSetting = {
+ // Unjustified type cast. FIXME
rows: [["field", 1, { "base-type": "type/Text" }] as FieldReference],
columns: [],
values: [],
@@ -129,6 +130,7 @@ describe("migratePivotColumnSplitSetting", () => {
field_ref: ["field", 1, {}],
});
const setting: FieldRefColumnSplitSetting = {
+ // Unjustified type cast. FIXME
rows: [["field", 1, { "base-type": "type/Text" }] as FieldReference],
columns: [],
values: [],
diff --git a/frontend/src/metabase-lib/v1/references.ts b/frontend/src/metabase-lib/v1/references.ts
index 9a032aab2ca..632b3b4ae69 100644
--- a/frontend/src/metabase-lib/v1/references.ts
+++ b/frontend/src/metabase-lib/v1/references.ts
@@ -36,6 +36,7 @@ export const isTemplateTagReference = (
export const createFieldReference = (
columnNameOrFieldId: string | FieldId,
+ // Unjustified type cast. FIXME
): FieldReference => ["field", columnNameOrFieldId, null] as FieldReference;
export const isValidDimensionReference = (
@@ -83,6 +84,7 @@ export const getNormalizedDimensionReference = (
isExpressionReference(mbql) ||
isAggregationReference(mbql)
) {
+ // Unjustified type cast. FIXME
const normalizedReference = [...mbql] as DimensionReference;
const normalizedOptions = normalizeReferenceOptions(mbql[2]);
normalizedReference[2] = normalizedOptions;
@@ -97,6 +99,7 @@ const getDimensionReferenceWithoutOptions = (
mbql: DimensionReferenceWithOptions,
optionsKeysToOmit: string[],
): DimensionReferenceWithOptions => {
+ // Unjustified type cast. FIXME
const newReference = mbql.slice() as DimensionReferenceWithOptions;
const options = newReference[2];
diff --git a/frontend/src/metabase-lib/v1/references.unit.spec.ts b/frontend/src/metabase-lib/v1/references.unit.spec.ts
index f09b29b038b..51f3a95b154 100644
--- a/frontend/src/metabase-lib/v1/references.unit.spec.ts
+++ b/frontend/src/metabase-lib/v1/references.unit.spec.ts
@@ -125,6 +125,7 @@ describe("normalizeReferenceOptions", () => {
it("should recursively normalize maps options", () => {
expect(
normalizeReferenceOptions({
+ // Unjustified type cast. FIXME
binning: { strategy: "default", other: null } as any,
}),
).toStrictEqual({
diff --git a/frontend/src/metabase-types/analytics/search.ts b/frontend/src/metabase-types/analytics/search.ts
index b49a535d79c..36dd2ce102c 100644
--- a/frontend/src/metabase-types/analytics/search.ts
+++ b/frontend/src/metabase-types/analytics/search.ts
@@ -105,6 +105,7 @@ const _allContextsHandled: Exclude<
export const toSnowplowContext = (
context: SearchContext,
): SnowplowSearchContext =>
+ // Unjustified type cast. FIXME
(PENDING_CONTEXTS as readonly SearchContext[]).includes(context)
? "other"
: // safe: the guard above proves every non-pending context is in the snowplow enum
diff --git a/frontend/src/metabase-types/analytics/search.unit.spec.ts b/frontend/src/metabase-types/analytics/search.unit.spec.ts
index 8e75db61687..a6c43a565c6 100644
--- a/frontend/src/metabase-types/analytics/search.unit.spec.ts
+++ b/frontend/src/metabase-types/analytics/search.unit.spec.ts
@@ -58,6 +58,7 @@ describe("toSnowplowContext", () => {
"search-bar": true,
"type-filter": true,
};
+ // Unjustified type cast. FIXME
for (const context of Object.keys(allContexts) as SearchContext[]) {
expect(toSnowplowContext(context)).toBe(context);
}
diff --git a/frontend/src/metabase-types/api/activity.ts b/frontend/src/metabase-types/api/activity.ts
index f36e0bd4ea4..623246bcec9 100644
--- a/frontend/src/metabase-types/api/activity.ts
+++ b/frontend/src/metabase-types/api/activity.ts
@@ -17,6 +17,7 @@ export const ACTIVITY_MODELS = [
export type ActivityModel = (typeof ACTIVITY_MODELS)[number];
export const isActivityModel = (model: string): model is ActivityModel =>
+ // Unjustified type cast. FIXME
(ACTIVITY_MODELS as unknown as string[]).includes(model);
export const isLoggableActivityModel = (item: {
diff --git a/frontend/src/metabase-types/api/metric.ts b/frontend/src/metabase-types/api/metric.ts
index 9d702d708d1..97f8548b1d8 100644
--- a/frontend/src/metabase-types/api/metric.ts
+++ b/frontend/src/metabase-types/api/metric.ts
@@ -27,6 +27,7 @@ export const MATH_OPERATORS = ["+", "-", "*", "/"] as const;
export type MathOperator = (typeof MATH_OPERATORS)[number];
export function isMathOperator(key: string): key is MathOperator {
+ // Unjustified type cast. FIXME
return (MATH_OPERATORS as readonly string[]).includes(key);
}
@@ -41,6 +42,7 @@ export type MathExpressionOperator = (typeof MATH_OPERATORS)[number];
export function isMathExpressionOperator(
key: string,
): key is MathExpressionOperator {
+ // Unjustified type cast. FIXME
return (MATH_EXPRESSION_OPERATORS as readonly string[]).includes(key);
}
diff --git a/frontend/src/metabase-types/api/mocks/actions.ts b/frontend/src/metabase-types/api/mocks/actions.ts
index 5b62571d294..d51d6fd4faa 100644
--- a/frontend/src/metabase-types/api/mocks/actions.ts
+++ b/frontend/src/metabase-types/api/mocks/actions.ts
@@ -137,6 +137,7 @@ export const createMockFieldSettings = (
export const createMockImplicitActionFieldSettings = (
opts?: Partial<FieldSettings>,
) =>
+ // Unjustified type cast. FIXME
({
id: "",
hidden: false,
diff --git a/frontend/src/metabase-types/api/mocks/activity.ts b/frontend/src/metabase-types/api/mocks/activity.ts
index 7346b598313..5b55e137dcb 100644
--- a/frontend/src/metabase-types/api/mocks/activity.ts
+++ b/frontend/src/metabase-types/api/mocks/activity.ts
@@ -46,6 +46,7 @@ export const createMockRecentCollectionItem = (
export const createMockRecentModel = (
model: Partial<RecentCollectionItem>,
): RecentModel =>
+ // Unjustified type cast. FIXME
createMockRecentCollectionItem({ ...model, model: "dataset" }) as RecentModel;
export const createMockPopularTableItem = (
diff --git a/frontend/src/metabase-types/api/mocks/add-ons.ts b/frontend/src/metabase-types/api/mocks/add-ons.ts
index a8e196f50e8..db5d30cb9a5 100644
--- a/frontend/src/metabase-types/api/mocks/add-ons.ts
+++ b/frontend/src/metabase-types/api/mocks/add-ons.ts
@@ -141,7 +141,8 @@ export function createMockCloudAddOns(
is_default: true,
},
],
- product_type: "other" as any, // test unexpected product_type
+ // test unexpected product_type
+ product_type: "other" as any,
self_service: true,
},
diff --git a/frontend/src/metabase-types/api/mocks/collection.ts b/frontend/src/metabase-types/api/mocks/collection.ts
index d987b5dff03..3b59b3a1a81 100644
--- a/frontend/src/metabase-types/api/mocks/collection.ts
+++ b/frontend/src/metabase-types/api/mocks/collection.ts
@@ -48,7 +48,9 @@ export const createMockCollectionItemFromCollection = (
): CollectionItem =>
createMockCollectionItem({
...opts,
+ // Unjustified type cast. FIXME
id: opts?.id as number,
+ // Unjustified type cast. FIXME
entity_id: opts?.entity_id as BaseEntityId,
model: "collection",
type: undefined,
diff --git a/frontend/src/metabase-types/api/mocks/dataset.ts b/frontend/src/metabase-types/api/mocks/dataset.ts
index 03e460f3d93..72daa51da97 100644
--- a/frontend/src/metabase-types/api/mocks/dataset.ts
+++ b/frontend/src/metabase-types/api/mocks/dataset.ts
@@ -142,6 +142,7 @@ export const createMockEmbedDataset = (
};
}
+ // Unjustified type cast. FIXME
return opts as ErrorEmbedDataset;
};
diff --git a/frontend/src/metabase-types/api/mocks/dependencies.ts b/frontend/src/metabase-types/api/mocks/dependencies.ts
index 12c080130ef..639ed8b9660 100644
--- a/frontend/src/metabase-types/api/mocks/dependencies.ts
+++ b/frontend/src/metabase-types/api/mocks/dependencies.ts
@@ -202,6 +202,7 @@ export function createMockSegmentDependencyNode(
export function createMockDashboardDependencyNodeData(
opts?: Partial<DashboardDependencyNodeData>,
): DashboardDependencyNodeData {
+ // Unjustified type cast. FIXME
return {
name: "Dashboard",
description: null,
@@ -227,6 +228,7 @@ export function createMockDashboardDependencyNode(
export function createMockDocumentDependencyNodeData(
opts?: Partial<DocumentDependencyNodeData>,
): DocumentDependencyNodeData {
+ // Unjustified type cast. FIXME
return {
name: "Document",
created_at: "2020-01-01T00:00:00Z",
diff --git a/frontend/src/metabase-types/api/mocks/entity-id.ts b/frontend/src/metabase-types/api/mocks/entity-id.ts
index 1414a2a099b..9971966f031 100644
--- a/frontend/src/metabase-types/api/mocks/entity-id.ts
+++ b/frontend/src/metabase-types/api/mocks/entity-id.ts
@@ -3,4 +3,5 @@ import { nanoid } from "@reduxjs/toolkit";
import { type BaseEntityId, NANOID_LENGTH } from "../entity-id";
export const createMockEntityId = (value?: string): BaseEntityId =>
+ // Unjustified type cast. FIXME
(value || nanoid(NANOID_LENGTH)) as BaseEntityId;
diff --git a/frontend/src/metabase-types/api/mocks/metabot.ts b/frontend/src/metabase-types/api/mocks/metabot.ts
index 546db84e877..ae3bf1e219c 100644
--- a/frontend/src/metabase-types/api/mocks/metabot.ts
+++ b/frontend/src/metabase-types/api/mocks/metabot.ts
@@ -55,6 +55,7 @@ export const createMockMetabotGroupPermissions = (
return Object.entries(defaults).map(([permType, permValue]) => ({
group_id: groupId,
+ // Unjustified type cast. FIXME
perm_type: permType as AIToolKey,
perm_value: permValue,
}));
diff --git a/frontend/src/metabase-types/api/mocks/pulse.ts b/frontend/src/metabase-types/api/mocks/pulse.ts
index a8b0947b8f6..a0b5ba0e87f 100644
--- a/frontend/src/metabase-types/api/mocks/pulse.ts
+++ b/frontend/src/metabase-types/api/mocks/pulse.ts
@@ -18,6 +18,7 @@ export const createMockDashboardSubscription = (
creator_id: createMockUser().id,
dashboard_id: 1,
disable_links: false,
+ // Unjustified type cast. FIXME
entity_id: "" as BaseEntityId,
skip_if_empty: false,
id: 1,
diff --git a/frontend/src/metabase-types/api/mocks/search.ts b/frontend/src/metabase-types/api/mocks/search.ts
index 111f10cf8ef..f3a75d5da87 100644
--- a/frontend/src/metabase-types/api/mocks/search.ts
+++ b/frontend/src/metabase-types/api/mocks/search.ts
@@ -55,6 +55,7 @@ export const createMockSearchResult = (
export const createMockModelResult = (
model: Partial<ModelResult> = {},
): ModelResult =>
+ // Unjustified type cast. FIXME
createMockSearchResult({ ...model, model: "dataset" }) as ModelResult;
export const createMockSearchResults = ({
diff --git a/frontend/src/metabase-types/api/sorting.ts b/frontend/src/metabase-types/api/sorting.ts
index 5c98b6f0f78..c919e7c91ee 100644
--- a/frontend/src/metabase-types/api/sorting.ts
+++ b/frontend/src/metabase-types/api/sorting.ts
@@ -8,5 +8,6 @@ export type SortingOptions<SortColumn extends string> = {
export const guardSortDirection = (value: string): value is SortDirection =>
(SORT_DIRECTIONS satisfies readonly SortDirection[]).includes(
+ // Unjustified type cast. FIXME
value as SortDirection,
);
diff --git a/frontend/src/metabase-types/api/visualization.ts b/frontend/src/metabase-types/api/visualization.ts
index fbc7c86d300..0a6107d76ac 100644
--- a/frontend/src/metabase-types/api/visualization.ts
+++ b/frontend/src/metabase-types/api/visualization.ts
@@ -13,6 +13,7 @@ export const isVirtualCardDisplayType = (
value: string,
): value is VirtualCardDisplay =>
typeof value === "string" &&
+ // Unjustified type cast. FIXME
virtualCardDisplayTypes.includes(value as VirtualCardDisplay);
export const cardDisplayTypes = [
@@ -41,6 +42,7 @@ export const cardDisplayTypes = [
export const isCardDisplayType = (value: unknown): value is CardDisplayType =>
typeof value === "string" &&
+ // Unjustified type cast. FIXME
cardDisplayTypes.includes(value as CardDisplayType);
export type CardDisplayType = (typeof cardDisplayTypes)[number];
diff --git a/frontend/src/metabase-types/guards/dashboard.ts b/frontend/src/metabase-types/guards/dashboard.ts
index d3e875be41f..c17199588af 100644
--- a/frontend/src/metabase-types/guards/dashboard.ts
+++ b/frontend/src/metabase-types/guards/dashboard.ts
@@ -6,4 +6,5 @@ import type {
export const isRestrictedLinkEntity = (
value: LinkEntity,
): value is RestrictedLinkEntity =>
+ // Unjustified type cast. FIXME
!!(value as RestrictedLinkEntity)?.restricted;
diff --git a/frontend/src/metabase-types/guards/date-time.ts b/frontend/src/metabase-types/guards/date-time.ts
index 293e6bf9f02..fe7f5607cb1 100644
--- a/frontend/src/metabase-types/guards/date-time.ts
+++ b/frontend/src/metabase-types/guards/date-time.ts
@@ -4,5 +4,6 @@ import { dateTimeAbsoluteUnits } from "metabase-types/api";
export const isAbsoluteDateTimeUnit = (
value: unknown,
): value is DateTimeAbsoluteUnit => {
+ // Unjustified type cast. FIXME
return dateTimeAbsoluteUnits.includes(value as DateTimeAbsoluteUnit);
};
diff --git a/frontend/src/metabase-types/guards/settings.ts b/frontend/src/metabase-types/guards/settings.ts
index 7518d4d7327..24b10ecb975 100644
--- a/frontend/src/metabase-types/guards/settings.ts
+++ b/frontend/src/metabase-types/guards/settings.ts
@@ -15,9 +15,11 @@ export const SCHEDULE_DAY: ScheduleDayType[] = [
];
export function isEngineKey(value: string | undefined): value is EngineKey {
+ // Unjustified type cast. FIXME
return engineKeys.includes(value as EngineKey);
}
export function isScheduleDay(value: string): value is ScheduleDayType {
+ // Unjustified type cast. FIXME
return SCHEDULE_DAY.includes(value as ScheduleDayType);
}
diff --git a/frontend/src/metabase/actions/components/ActionForm/ActionForm.unit.spec.tsx b/frontend/src/metabase/actions/components/ActionForm/ActionForm.unit.spec.tsx
index 15a2079a0a3..7f14d68f25d 100644
--- a/frontend/src/metabase/actions/components/ActionForm/ActionForm.unit.spec.tsx
+++ b/frontend/src/metabase/actions/components/ActionForm/ActionForm.unit.spec.tsx
@@ -589,6 +589,7 @@ describe("Actions > ActionForm", () => {
type: "form",
fields: {
"abc-123": makeFieldSettings({
+ // Unjustified type cast. FIXME
inputType: inputType as FieldSettings["inputType"],
id: "abc-123",
title: "input",
diff --git a/frontend/src/metabase/actions/containers/ActionCreator/ActionContext/QueryActionContextProvider/QueryActionContextProvider.tsx b/frontend/src/metabase/actions/containers/ActionCreator/ActionContext/QueryActionContextProvider/QueryActionContextProvider.tsx
index 12a523e8858..53c9d35f64e 100644
--- a/frontend/src/metabase/actions/containers/ActionCreator/ActionContext/QueryActionContextProvider/QueryActionContextProvider.tsx
+++ b/frontend/src/metabase/actions/containers/ActionCreator/ActionContext/QueryActionContextProvider/QueryActionContextProvider.tsx
@@ -63,6 +63,7 @@ function convertActionToQuestionCard(
dataset_query: action.dataset_query,
display: "action",
visualization_settings:
+ // Unjustified type cast. FIXME
action.visualization_settings as VisualizationSettings,
type: "question",
can_write: true,
@@ -109,10 +110,14 @@ function convertQuestionToAction(
return {
id: question.id(),
+ // Unjustified type cast. FIXME
name: question.displayName() as string,
description: question.description(),
+ // Unjustified type cast. FIXME
dataset_query: cleanQuestion.datasetQuery() as NativeDatasetQuery,
+ // Unjustified type cast. FIXME
database_id: question.databaseId() as DatabaseId,
+ // Unjustified type cast. FIXME
parameters: parameters as WritebackParameter[],
visualization_settings: formSettings,
};
@@ -144,6 +149,7 @@ function QueryActionContextProvider({
const [question, setQuestion] = useState(initialQuestion);
const query = useMemo(
+ // Unjustified type cast. FIXME
() => question.legacyNativeQuery() as NativeQuery,
[question],
);
diff --git a/frontend/src/metabase/actions/containers/ActionCreator/ActionContext/QueryActionContextProvider/utils.ts b/frontend/src/metabase/actions/containers/ActionCreator/ActionContext/QueryActionContextProvider/utils.ts
index a91cec76f04..3ada796dd23 100644
--- a/frontend/src/metabase/actions/containers/ActionCreator/ActionContext/QueryActionContextProvider/utils.ts
+++ b/frontend/src/metabase/actions/containers/ActionCreator/ActionContext/QueryActionContextProvider/utils.ts
@@ -51,10 +51,12 @@ export const setTemplateTagTypesFromFieldSettings = (
settings: ActionFormSettings,
): Question => {
const fields = settings.fields || {};
+ // Unjustified type cast. FIXME
const query = question.legacyNativeQuery() as NativeQuery;
let tempQuestion = question.clone();
query.variableTemplateTags().forEach((tag: TemplateTag) => {
+ // Unjustified type cast. FIXME
const currentQuery = tempQuestion.legacyNativeQuery() as NativeQuery;
const fieldType = fields[tag.id]?.fieldType ?? "string";
const nextTag = {
diff --git a/frontend/src/metabase/actions/containers/ActionCreator/ActionContext/QueryActionContextProvider/utils.unit.spec.ts b/frontend/src/metabase/actions/containers/ActionCreator/ActionContext/QueryActionContextProvider/utils.unit.spec.ts
index d5db3e7f830..597b3d0f370 100644
--- a/frontend/src/metabase/actions/containers/ActionCreator/ActionContext/QueryActionContextProvider/utils.unit.spec.ts
+++ b/frontend/src/metabase/actions/containers/ActionCreator/ActionContext/QueryActionContextProvider/utils.unit.spec.ts
@@ -62,6 +62,7 @@ describe("actions > containers > ActionCreator > QueryActionContextProvider > ut
},
});
+ // Unjustified type cast. FIXME
const parameters = [
{ id: "aaa", name: "foo", type: "number/=" },
{ id: "bbb", name: "foo", type: "number/=" },
@@ -86,6 +87,7 @@ describe("actions > containers > ActionCreator > QueryActionContextProvider > ut
},
});
+ // Unjustified type cast. FIXME
const parameters = [
{ id: "aaa", name: "foo", type: "string/=" },
{ id: "bbb", name: "foo", type: "string/=" },
@@ -110,6 +112,7 @@ describe("actions > containers > ActionCreator > QueryActionContextProvider > ut
},
});
+ // Unjustified type cast. FIXME
const parameters = [
{ id: "aaa", name: "foo", type: "string/=" },
{ id: "bbb", name: "foo", type: "string/=" },
diff --git a/frontend/src/metabase/actions/containers/ActionCreator/CreateActionForm/CreateActionForm.tsx b/frontend/src/metabase/actions/containers/ActionCreator/CreateActionForm/CreateActionForm.tsx
index 0cd81f746b6..c528db01c68 100644
--- a/frontend/src/metabase/actions/containers/ActionCreator/CreateActionForm/CreateActionForm.tsx
+++ b/frontend/src/metabase/actions/containers/ActionCreator/CreateActionForm/CreateActionForm.tsx
@@ -53,6 +53,7 @@ function CreateActionForm({
return (
<FormProvider
+ // Unjustified type cast. FIXME
initialValues={initialValues as FormValues}
validationSchema={ACTION_SCHEMA}
onSubmit={onCreate}
diff --git a/frontend/src/metabase/actions/containers/ActionCreator/FormCreator/FormFieldEditor/DragHandle.tsx b/frontend/src/metabase/actions/containers/ActionCreator/FormCreator/FormFieldEditor/DragHandle.tsx
index 3cbf5c10ca8..14038be7028 100644
--- a/frontend/src/metabase/actions/containers/ActionCreator/FormCreator/FormFieldEditor/DragHandle.tsx
+++ b/frontend/src/metabase/actions/containers/ActionCreator/FormCreator/FormFieldEditor/DragHandle.tsx
@@ -17,6 +17,7 @@ export const DragHandle = forwardRef<HTMLElement, DragHandleProps>(
return (
<div
data-testid="drag-handle"
+ // Unjustified type cast. FIXME
ref={ref as MutableRefObject<HTMLDivElement>}
className={styles.dragHandle}
{...dragHandleListeners}
diff --git a/frontend/src/metabase/actions/containers/ActionCreator/FormCreator/FormFieldEditor/FormFieldEditor.tsx b/frontend/src/metabase/actions/containers/ActionCreator/FormCreator/FormFieldEditor/FormFieldEditor.tsx
index 4c08247cba1..ac07fb0ef89 100644
--- a/frontend/src/metabase/actions/containers/ActionCreator/FormCreator/FormFieldEditor/FormFieldEditor.tsx
+++ b/frontend/src/metabase/actions/containers/ActionCreator/FormCreator/FormFieldEditor/FormFieldEditor.tsx
@@ -127,6 +127,7 @@ function FormFieldEditor({
<Radio.Group
label={<Subtitle>{t`Field type`}</Subtitle>}
value={fieldSettings.fieldType}
+ // Unjustified type cast. FIXME
onChange={(value) => handleChangeFieldType(value as FieldType)}
>
<Group gap="lg">
diff --git a/frontend/src/metabase/actions/containers/ActionCreator/FormCreator/utils.unit.spec.ts b/frontend/src/metabase/actions/containers/ActionCreator/FormCreator/utils.unit.spec.ts
index 5e755cc35cd..b647a7088e8 100644
--- a/frontend/src/metabase/actions/containers/ActionCreator/FormCreator/utils.unit.spec.ts
+++ b/frontend/src/metabase/actions/containers/ActionCreator/FormCreator/utils.unit.spec.ts
@@ -6,6 +6,7 @@ import { reorderFields } from "./utils";
describe("actions > containers > ActionCreator > FormCreator > utils", () => {
describe("reorderFields", () => {
it("should reorder fields", () => {
+ // Unjustified type cast. FIXME
const fields = {
a: getDefaultFieldSettings({ order: 0 }),
b: getDefaultFieldSettings({ order: 1 }),
diff --git a/frontend/src/metabase/actions/utils.ts b/frontend/src/metabase/actions/utils.ts
index 2e27637dfb5..4b820badca4 100644
--- a/frontend/src/metabase/actions/utils.ts
+++ b/frontend/src/metabase/actions/utils.ts
@@ -253,6 +253,7 @@ export const getForm = (
sortActionParams({ fields: fieldSettings }),
);
return {
+ // Unjustified type cast. FIXME
fields: sortedParams
.map((param) => getFormField(param, fieldSettings[param.id] ?? {}))
.filter(Boolean) as ActionFormFieldProps[],
diff --git a/frontend/src/metabase/admin/ai/AIProviderSettingsSection.unit.spec.tsx b/frontend/src/metabase/admin/ai/AIProviderSettingsSection.unit.spec.tsx
index e1bf7a359d4..42b4dd0feb9 100644
--- a/frontend/src/metabase/admin/ai/AIProviderSettingsSection.unit.spec.tsx
+++ b/frontend/src/metabase/admin/ai/AIProviderSettingsSection.unit.spec.tsx
@@ -341,6 +341,7 @@ async function setup({
const settings = mockSettings(sessionProperties);
setupEnterpriseOnlyPlugin("metabot");
+ // Unjustified type cast. FIXME
for (const provider of Object.keys(responseMap) as MetabotProvider[]) {
const response = responseMap[provider];
@@ -370,6 +371,7 @@ async function setup({
});
const handleMetabotSettingsUpdate = (call: { options?: RequestInit }) => {
+ // Unjustified type cast. FIXME
const body = JSON.parse(
String(call.options?.body ?? "{}"),
) as MetabotSettingsUpdateBody;
@@ -456,16 +458,21 @@ async function setup({
return settingUpdateResponse;
}
+ // Unjustified type cast. FIXME
const body = JSON.parse(String(call.options?.body ?? "{}")) as Partial<
Record<MetabotSettingKey, string | null>
>;
Object.entries(body).forEach(([key, nextValue]) => {
if (key in settingsDefinitions) {
+ // Unjustified type cast. FIXME
settingsDefinitions[key as keyof typeof settingsDefinitions] =
createMockSettingDefinition({
+ // Unjustified type cast. FIXME
...settingsDefinitions[key as keyof typeof settingsDefinitions],
+ // Unjustified type cast. FIXME
key: key as keyof typeof settingsDefinitions,
+ // Unjustified type cast. FIXME
value: (nextValue ??
undefined) as MetabotSettingDefinition["value"],
});
diff --git a/frontend/src/metabase/admin/ai/AISettingsPage.unit.spec.tsx b/frontend/src/metabase/admin/ai/AISettingsPage.unit.spec.tsx
index fdee4f861a9..f831fe21410 100644
--- a/frontend/src/metabase/admin/ai/AISettingsPage.unit.spec.tsx
+++ b/frontend/src/metabase/admin/ai/AISettingsPage.unit.spec.tsx
@@ -118,6 +118,7 @@ const setup = async ({
setupCollectionByIdEndpoint({ collections });
setupRootCollectionItemsEndpoint({ rootCollectionItems: [] });
setupCollectionsEndpoints({ collections: [] });
+ // Unjustified type cast. FIXME
setupRecentViewsAndSelectionsEndpoints(defaultSeedCollections as any);
setupMetabotsEndpoints(metabots);
diff --git a/frontend/src/metabase/admin/ai/MetabotAdminSuggestedPrompts.tsx b/frontend/src/metabase/admin/ai/MetabotAdminSuggestedPrompts.tsx
index 1a349a2892e..e78e1c501e5 100644
--- a/frontend/src/metabase/admin/ai/MetabotAdminSuggestedPrompts.tsx
+++ b/frontend/src/metabase/admin/ai/MetabotAdminSuggestedPrompts.tsx
@@ -155,6 +155,7 @@ export const MetabotPromptSuggestionPane = ({
) : (
<SuggestedPromptRow
key={row.id}
+ // Unjustified type cast. FIXME
row={row as SuggestedMetabotPrompt}
onDelete={() => handleDeletePrompt(row.id)}
metabotId={metabot.id}
diff --git a/frontend/src/metabase/admin/ai/MetabotSettingsPanel.tsx b/frontend/src/metabase/admin/ai/MetabotSettingsPanel.tsx
index 1a4cb0852a1..3f052211907 100644
--- a/frontend/src/metabase/admin/ai/MetabotSettingsPanel.tsx
+++ b/frontend/src/metabase/admin/ai/MetabotSettingsPanel.tsx
@@ -212,6 +212,7 @@ function MetabotCollectionConfigurationPane({
model: "collection",
}}
onChange={(item) =>
+ // Unjustified type cast. FIXME
handleUpdateCollectionId(item as Pick<MetabotInfo, "id" | "name">)
}
onClose={close}
diff --git a/frontend/src/metabase/admin/ai/MetabotSettingsPanel.unit.spec.tsx b/frontend/src/metabase/admin/ai/MetabotSettingsPanel.unit.spec.tsx
index aa50b559e97..54eee8a1dc3 100644
--- a/frontend/src/metabase/admin/ai/MetabotSettingsPanel.unit.spec.tsx
+++ b/frontend/src/metabase/admin/ai/MetabotSettingsPanel.unit.spec.tsx
@@ -105,6 +105,7 @@ const setup = async (
setupRootCollectionItemsEndpoint({ rootCollectionItems: [] });
setupCollectionsEndpoints({ collections: [] });
+ // Unjustified type cast. FIXME
setupRecentViewsAndSelectionsEndpoints(seedCollections as RecentItem[]);
setupUpdateSettingEndpoint();
diff --git a/frontend/src/metabase/admin/databases/components/DatabaseDangerZoneSection/DatabaseDangerZoneSection.unit.spec.tsx b/frontend/src/metabase/admin/databases/components/DatabaseDangerZoneSection/DatabaseDangerZoneSection.unit.spec.tsx
index be620858a22..3e6d2933da4 100644
--- a/frontend/src/metabase/admin/databases/components/DatabaseDangerZoneSection/DatabaseDangerZoneSection.unit.spec.tsx
+++ b/frontend/src/metabase/admin/databases/components/DatabaseDangerZoneSection/DatabaseDangerZoneSection.unit.spec.tsx
@@ -16,12 +16,14 @@ import { DatabaseDangerZoneSection } from "./DatabaseDangerZoneSection";
const NOT_SYNCED_DB_STATUSES: InitialSyncStatus[] = ["aborted", "incomplete"];
function getDiscardFieldValuesConfirmModal() {
+ // Unjustified type cast. FIXME
return document.querySelector(
"[data-testid=discard-field-values-confirm-modal]",
) as HTMLElement;
}
function getRemoveDatabaseConfirmModal() {
+ // Unjustified type cast. FIXME
return document.querySelector(
"[data-testid=remove-database-confirm-modal]",
) as HTMLElement;
diff --git a/frontend/src/metabase/admin/databases/components/DatabaseEditConnectionForm.tsx b/frontend/src/metabase/admin/databases/components/DatabaseEditConnectionForm.tsx
index 33f697372be..50945a4de4d 100644
--- a/frontend/src/metabase/admin/databases/components/DatabaseEditConnectionForm.tsx
+++ b/frontend/src/metabase/admin/databases/components/DatabaseEditConnectionForm.tsx
@@ -83,10 +83,12 @@ export const DatabaseEditConnectionForm = withRouter(
onSubmitted(savedDB);
});
} catch (error) {
+ // Unjustified type cast. FIXME
throw getSubmitError(error as DatabaseEditErrorType);
}
};
+ // Unjustified type cast. FIXME
return (
<ErrorBoundary errorComponent={GenericError as ComponentType}>
<LoadingAndErrorWrapper
diff --git a/frontend/src/metabase/admin/databases/components/DatabaseHelpSidePanel/EmbeddedEngineDocContent/markdown-utils.ts b/frontend/src/metabase/admin/databases/components/DatabaseHelpSidePanel/EmbeddedEngineDocContent/markdown-utils.ts
index 6ca7b18da2d..86375dc5603 100644
--- a/frontend/src/metabase/admin/databases/components/DatabaseHelpSidePanel/EmbeddedEngineDocContent/markdown-utils.ts
+++ b/frontend/src/metabase/admin/databases/components/DatabaseHelpSidePanel/EmbeddedEngineDocContent/markdown-utils.ts
@@ -16,6 +16,7 @@ const hideJekyllTemplateIncludes = (element: HTMLElement) => {
element.querySelectorAll("p").forEach((element) => {
// Check if the element's text content contains "{%" and it has no child elements
if (element.textContent?.includes("{%") && element.children.length === 0) {
+ // Unjustified type cast. FIXME
(element as HTMLElement).style.display = "none";
}
});
@@ -33,6 +34,7 @@ const hideIntroductoryElements = (element: HTMLElement) => {
while (prevSibling) {
prevSibling.style.display = "none";
+ // Unjustified type cast. FIXME
prevSibling = prevSibling.previousElementSibling as HTMLElement;
}
@@ -44,6 +46,7 @@ const hideIntroductoryElements = (element: HTMLElement) => {
nextSibling?.tagName === "P"
) {
nextSibling.style.display = "none";
+ // Unjustified type cast. FIXME
nextSibling = nextSibling.nextElementSibling as HTMLElement;
}
}
diff --git a/frontend/src/metabase/admin/databases/components/DatabaseHelpSidePanel/EmbeddedEngineDocContent/useEngineDocMarkdownContent.unit.spec.tsx b/frontend/src/metabase/admin/databases/components/DatabaseHelpSidePanel/EmbeddedEngineDocContent/useEngineDocMarkdownContent.unit.spec.tsx
index 18bdb1ad263..c11547629c4 100644
--- a/frontend/src/metabase/admin/databases/components/DatabaseHelpSidePanel/EmbeddedEngineDocContent/useEngineDocMarkdownContent.unit.spec.tsx
+++ b/frontend/src/metabase/admin/databases/components/DatabaseHelpSidePanel/EmbeddedEngineDocContent/useEngineDocMarkdownContent.unit.spec.tsx
@@ -42,6 +42,7 @@ describe("useEngineDocMarkdownContent", () => {
describe("when markdown content fails to load", () => {
it("should set loadingError and return undefined markdownContent", async () => {
const { result } = renderHook(() =>
+ // Unjustified type cast. FIXME
useEngineDocMarkdownContent("invalid-engine" as EngineKey),
);
await waitFor(() => {
diff --git a/frontend/src/metabase/admin/databases/components/DatabaseModelFeaturesSection/ModelCachingControl/ModelCachingControl.tsx b/frontend/src/metabase/admin/databases/components/DatabaseModelFeaturesSection/ModelCachingControl/ModelCachingControl.tsx
index 31a175ba982..3e5b5d54d2f 100644
--- a/frontend/src/metabase/admin/databases/components/DatabaseModelFeaturesSection/ModelCachingControl/ModelCachingControl.tsx
+++ b/frontend/src/metabase/admin/databases/components/DatabaseModelFeaturesSection/ModelCachingControl/ModelCachingControl.tsx
@@ -50,6 +50,7 @@ export function ModelCachingControl({ database, disabled }: Props) {
await persistDatabase(databaseId).unwrap();
}
} catch (error) {
+ // Unjustified type cast. FIXME
const response = error as ErrorResponse;
if (isLackPermissionsError(response)) {
setError(
diff --git a/frontend/src/metabase/admin/databases/components/DeleteDatabaseModel/DeleteDatabaseModal.unit.spec.tsx b/frontend/src/metabase/admin/databases/components/DeleteDatabaseModel/DeleteDatabaseModal.unit.spec.tsx
index 2804c651334..83b9d8b620b 100644
--- a/frontend/src/metabase/admin/databases/components/DeleteDatabaseModel/DeleteDatabaseModal.unit.spec.tsx
+++ b/frontend/src/metabase/admin/databases/components/DeleteDatabaseModel/DeleteDatabaseModal.unit.spec.tsx
@@ -19,6 +19,7 @@ const getUsageInfo = (hasContent: boolean) => ({
transform: hasContent ? 50 : 0,
});
+// Unjustified type cast. FIXME
const database = { name: "database name", id: 1 } as Database;
const setup = async ({
diff --git a/frontend/src/metabase/admin/databases/containers/DatabaseEditApp.tsx b/frontend/src/metabase/admin/databases/containers/DatabaseEditApp.tsx
index 27121077cf3..7bc5c8facaf 100644
--- a/frontend/src/metabase/admin/databases/containers/DatabaseEditApp.tsx
+++ b/frontend/src/metabase/admin/databases/containers/DatabaseEditApp.tsx
@@ -99,6 +99,7 @@ function DatabaseEditAppInner({
return (
<>
+ {/* Unjustified type cast. FIXME */}
<ErrorBoundary errorComponent={GenericError as ComponentType}>
<Box w="100%" maw="64.25rem" mx="auto" px="2rem">
<Breadcrumbs className={CS.py4} crumbs={crumbs} />
diff --git a/frontend/src/metabase/admin/databases/containers/DatabasePage.tsx b/frontend/src/metabase/admin/databases/containers/DatabasePage.tsx
index eef7222da4d..e4bbece9a40 100644
--- a/frontend/src/metabase/admin/databases/containers/DatabasePage.tsx
+++ b/frontend/src/metabase/admin/databases/containers/DatabasePage.tsx
@@ -38,6 +38,7 @@ export function DatabasePage({ params, route }: DatabasePageProps) {
useDatabaseConnection({ databaseId: params.databaseId, engines });
const [showSidePanel, { open: openSidePanel, close: closeSidePanel }] =
useDisclosure(false);
+ // Unjustified type cast. FIXME
const [selectedEngineKey, setSelectedEngineKey] = useState<EngineKey>(
database?.engine as EngineKey,
);
@@ -45,6 +46,7 @@ export function DatabasePage({ params, route }: DatabasePageProps) {
!!selectedEngineKey && !!ENGINE_DOC_MAP[selectedEngineKey];
const onEngineChange = (engineKey?: string) => {
+ // Unjustified type cast. FIXME
setSelectedEngineKey(engineKey as EngineKey);
};
diff --git a/frontend/src/metabase/admin/databases/database.ts b/frontend/src/metabase/admin/databases/database.ts
index 0353b310ca4..63c06a0afb8 100644
--- a/frontend/src/metabase/admin/databases/database.ts
+++ b/frontend/src/metabase/admin/databases/database.ts
@@ -70,6 +70,7 @@ export const databasesReducer = combineReducers({
(_state, action) => action.payload.error,
);
}),
+ // Unjustified type cast. FIXME
deletes: createReducer([] as DatabaseId[], (builder) => {
builder
.addCase(DELETE_DATABASE_STARTED, (state, action) =>
diff --git a/frontend/src/metabase/admin/datamodel/containers/SegmentApp.tsx b/frontend/src/metabase/admin/datamodel/containers/SegmentApp.tsx
index aa57399ec6f..3d7b2461fb2 100644
--- a/frontend/src/metabase/admin/datamodel/containers/SegmentApp.tsx
+++ b/frontend/src/metabase/admin/datamodel/containers/SegmentApp.tsx
@@ -108,6 +108,7 @@ function CreateSegmentForm({ route }: CreateSegmentFormProps) {
setIsDirty(false);
scheduleCallback(async () => {
+ // Unjustified type cast. FIXME
const result = await createSegment(segment as CreateSegmentRequest);
if (result.error) {
sendErrorToast(t`Failed to create segment`);
diff --git a/frontend/src/metabase/admin/embedding/components/ThemeEditor/EditorPanel.tsx b/frontend/src/metabase/admin/embedding/components/ThemeEditor/EditorPanel.tsx
index e40fe1f087e..fd26f6db9fc 100644
--- a/frontend/src/metabase/admin/embedding/components/ThemeEditor/EditorPanel.tsx
+++ b/frontend/src/metabase/admin/embedding/components/ThemeEditor/EditorPanel.tsx
@@ -122,6 +122,7 @@ export function EditorPanel({
<ColorSwatchCard
key={key}
label={label()}
+ // Unjustified type cast. FIXME
value={(colors[key] as string) ?? ""}
showAlpha
onChange={(color) => editor.setColor(key, color ?? "")}
@@ -174,6 +175,7 @@ export function EditorPanel({
<ColorSwatchCard
key={key}
label={label()}
+ // Unjustified type cast. FIXME
value={(colors[key] as string) ?? ""}
showAlpha
onChange={(color) => editor.setColor(key, color ?? "")}
diff --git a/frontend/src/metabase/admin/embedding/hooks/use-default-embedding-theme-settings.unit.spec.tsx b/frontend/src/metabase/admin/embedding/hooks/use-default-embedding-theme-settings.unit.spec.tsx
index b467a86a2ac..5f2de13489e 100644
--- a/frontend/src/metabase/admin/embedding/hooks/use-default-embedding-theme-settings.unit.spec.tsx
+++ b/frontend/src/metabase/admin/embedding/hooks/use-default-embedding-theme-settings.unit.spec.tsx
@@ -7,6 +7,7 @@ import type { ColorSettings } from "metabase-types/api/settings";
import { useDefaultEmbeddingThemeSettings } from "./use-default-embedding-theme-settings";
const setup = (applicationColors?: ColorSettings) => {
+ // Unjustified type cast. FIXME
const initialState = createMockState({
settings: { values: { "application-colors": applicationColors } },
} as Partial<State>);
diff --git a/frontend/src/metabase/admin/embedding/hooks/use-embedding-theme-editor.ts b/frontend/src/metabase/admin/embedding/hooks/use-embedding-theme-editor.ts
index 148a5afd436..ee6696ea17c 100644
--- a/frontend/src/metabase/admin/embedding/hooks/use-embedding-theme-editor.ts
+++ b/frontend/src/metabase/admin/embedding/hooks/use-embedding-theme-editor.ts
@@ -239,6 +239,7 @@ export function useEmbeddingThemeEditor(themeId: ThemeEditorId) {
const colors = currentTheme.settings.colors ?? {};
const defaultColors = defaultThemeSettings.colors ?? {};
return PRIMARY_COLORS_KEYS.some(
+ // Unjustified type cast. FIXME
(key) => (colors[key] ?? "") !== ((defaultColors[key] as string) ?? ""),
);
}, [currentTheme, defaultThemeSettings]);
diff --git a/frontend/src/metabase/admin/embedding/hooks/use-embedding-theme-editor.unit.spec.tsx b/frontend/src/metabase/admin/embedding/hooks/use-embedding-theme-editor.unit.spec.tsx
index f83206f3a4a..8c1f9c1e5a4 100644
--- a/frontend/src/metabase/admin/embedding/hooks/use-embedding-theme-editor.unit.spec.tsx
+++ b/frontend/src/metabase/admin/embedding/hooks/use-embedding-theme-editor.unit.spec.tsx
@@ -36,7 +36,8 @@ function setup(themeId: ThemeEditorId = 1, applicationColors?: ColorSettings) {
}
const storeInitialState = applicationColors
- ? createMockState({
+ ? // Unjustified type cast. FIXME
+ createMockState({
settings: { values: { "application-colors": applicationColors } },
} as Partial<State>)
: undefined;
diff --git a/frontend/src/metabase/admin/embedding/hooks/use-ensure-default-embedding-themes.unit.spec.tsx b/frontend/src/metabase/admin/embedding/hooks/use-ensure-default-embedding-themes.unit.spec.tsx
index d1a9ecd351b..5454149413e 100644
--- a/frontend/src/metabase/admin/embedding/hooks/use-ensure-default-embedding-themes.unit.spec.tsx
+++ b/frontend/src/metabase/admin/embedding/hooks/use-ensure-default-embedding-themes.unit.spec.tsx
@@ -9,6 +9,7 @@ import { useEnsureDefaultEmbeddingThemes } from "./use-ensure-default-embedding-
function setup({ alreadySeeded }: { alreadySeeded: boolean }) {
fetchMock.post("path:/api/embed-theme/seed-defaults", 204);
+ // Unjustified type cast. FIXME
const initialState = createMockState({
settings: {
values: { "default-embedding-themes-seeded": alreadySeeded },
@@ -39,6 +40,7 @@ describe("useEnsureDefaultEmbeddingThemes", () => {
const [call] = fetchMock.callHistory.calls(
"path:/api/embed-theme/seed-defaults",
);
+ // Unjustified type cast. FIXME
const body = JSON.parse(call?.options?.body as string);
expect(body.themes).toHaveLength(2);
expect(body.themes.map((t: { name: string }) => t.name)).toEqual([
@@ -80,6 +82,7 @@ describe("useEnsureDefaultEmbeddingThemes", () => {
it("does not post while the setting has not hydrated", () => {
fetchMock.post("path:/api/embed-theme/seed-defaults", 204);
+ // Unjustified type cast. FIXME
const initialState = createMockState({
settings: { values: {} },
} as Partial<State>);
diff --git a/frontend/src/metabase/admin/embedding/utils/derive-sdk-theme-settings.ts b/frontend/src/metabase/admin/embedding/utils/derive-sdk-theme-settings.ts
index d6bca8be8bd..9783d388159 100644
--- a/frontend/src/metabase/admin/embedding/utils/derive-sdk-theme-settings.ts
+++ b/frontend/src/metabase/admin/embedding/utils/derive-sdk-theme-settings.ts
@@ -29,6 +29,7 @@ const SDK_COLORS_TO_PERSIST = [
export const WHITELABEL_CHART_COLOR_NAMES = Array.from(
{ length: ACCENT_COUNT },
+ // Unjustified type cast. FIXME
(_, i) => `accent${i}` as ColorName,
);
diff --git a/frontend/src/metabase/admin/people/components/PeopleNav.tsx b/frontend/src/metabase/admin/people/components/PeopleNav.tsx
index 3a9a2a5e800..48785374dab 100644
--- a/frontend/src/metabase/admin/people/components/PeopleNav.tsx
+++ b/frontend/src/metabase/admin/people/components/PeopleNav.tsx
@@ -17,6 +17,7 @@ import { getLocation } from "metabase/selectors/routing";
import { Divider, Stack } from "metabase/ui";
export function PeopleNav() {
+ // Unjustified type cast. FIXME
const shouldNudge = useSelector(shouldNudgeToPro) as boolean;
const isUsingTenants = useSetting("use-tenants");
const showTenantsUpsell = useSelector(shouldShowTenantsUpsell);
diff --git a/frontend/src/metabase/admin/people/containers/AdminPeopleApp/AdminPeopleApp.unit.spec.tsx b/frontend/src/metabase/admin/people/containers/AdminPeopleApp/AdminPeopleApp.unit.spec.tsx
index c369337085b..dec302e6529 100644
--- a/frontend/src/metabase/admin/people/containers/AdminPeopleApp/AdminPeopleApp.unit.spec.tsx
+++ b/frontend/src/metabase/admin/people/containers/AdminPeopleApp/AdminPeopleApp.unit.spec.tsx
@@ -47,6 +47,7 @@ const setup = async (inputSetupOpts?: Partial<SetupOpts>) => {
settings: createMockSettingsState({
"active-users-count": setupOpts.activeUsersCount,
"embedding-homepage":
+ // Unjustified type cast. FIXME
setupOpts.embeddingHomepage as EmbeddingHomepageStatus,
"setup-embedding-autoenabled": setupOpts.setupEmbeddingAutoenabled,
"use-tenants": setupOpts.useTenants,
@@ -198,5 +199,6 @@ async function assertNavLink(linkText: string, linkHref: string) {
expect(link).toBeInTheDocument();
expect(link).toHaveAttribute("href", linkHref);
+ // Unjustified type cast. FIXME
return link as HTMLElement;
}
diff --git a/frontend/src/metabase/admin/people/containers/PeopleListingApp/PeopleListingApp.tsx b/frontend/src/metabase/admin/people/containers/PeopleListingApp/PeopleListingApp.tsx
index 90427c558ea..39adcaca056 100644
--- a/frontend/src/metabase/admin/people/containers/PeopleListingApp/PeopleListingApp.tsx
+++ b/frontend/src/metabase/admin/people/containers/PeopleListingApp/PeopleListingApp.tsx
@@ -76,6 +76,7 @@ export function PeopleListingApp({
const handleTabChange = (tab: string | null) => {
if (tab) {
+ // Unjustified type cast. FIXME
updateStatus(tab as ActiveStatus);
}
};
diff --git a/frontend/src/metabase/admin/performance/components/ModelPersistenceConfiguration.tsx b/frontend/src/metabase/admin/performance/components/ModelPersistenceConfiguration.tsx
index 9a5956ec29d..05cdf072497 100644
--- a/frontend/src/metabase/admin/performance/components/ModelPersistenceConfiguration.tsx
+++ b/frontend/src/metabase/admin/performance/components/ModelPersistenceConfiguration.tsx
@@ -84,6 +84,7 @@ export const ModelPersistenceConfiguration = () => {
icon: "info",
message: t`Loading...`,
});
+ // Unjustified type cast. FIXME
return result?.payload?.id as number;
};
diff --git a/frontend/src/metabase/admin/performance/components/ModelPersistenceConfiguration.unit.spec.tsx b/frontend/src/metabase/admin/performance/components/ModelPersistenceConfiguration.unit.spec.tsx
index 78bfa0ee55b..c5df3468cf0 100644
--- a/frontend/src/metabase/admin/performance/components/ModelPersistenceConfiguration.unit.spec.tsx
+++ b/frontend/src/metabase/admin/performance/components/ModelPersistenceConfiguration.unit.spec.tsx
@@ -126,6 +126,7 @@ describe("ModelPersistenceConfiguration", () => {
expect(fetchMock.callHistory.called(SET_SCHEDULE_URL)).toBe(true);
});
const lastCall = fetchMock.callHistory.lastCall(SET_SCHEDULE_URL);
+ // Unjustified type cast. FIXME
expect(JSON.parse(lastCall?.options?.body as string)).toEqual({
cron: "0 0 0/6 * * ? *",
});
diff --git a/frontend/src/metabase/admin/performance/hooks/useSaveStrategy.tsx b/frontend/src/metabase/admin/performance/hooks/useSaveStrategy.tsx
index 927c01f43bf..fdedcac0d6f 100644
--- a/frontend/src/metabase/admin/performance/hooks/useSaveStrategy.tsx
+++ b/frontend/src/metabase/admin/performance/hooks/useSaveStrategy.tsx
@@ -51,6 +51,7 @@ export const useSaveStrategy = (
// for fields that are not in the new strategy,
// so let's remove these fields
const validFields = getFieldsForStrategyType(values.type);
+ // Unjustified type cast. FIXME
const newStrategy = _.pick(values, validFields) as CacheStrategy;
const strategyData = strategies[values.type];
diff --git a/frontend/src/metabase/admin/performance/utils.tsx b/frontend/src/metabase/admin/performance/utils.tsx
index ee763ee7dd9..248c666d074 100644
--- a/frontend/src/metabase/admin/performance/utils.tsx
+++ b/frontend/src/metabase/admin/performance/utils.tsx
@@ -106,6 +106,7 @@ export const getStrategyValidationSchema = (strategyData: StrategyData) => {
}
};
+// Unjustified type cast. FIXME
export const strategyValidationSchema = Yup.object().test(
"strategy-validation",
"The object must match one of the strategy validation schemas",
@@ -115,6 +116,7 @@ export const strategyValidationSchema = Yup.object().test(
message: "Strategy is falsy",
});
}
+ // Unjustified type cast. FIXME
const { type } = value as unknown as { type: string };
if (!isValidStrategyName(type)) {
return this.createError({
@@ -143,6 +145,7 @@ export const strategyValidationSchema = Yup.object().test(
export const getFieldsForStrategyType = (strategyType: CacheStrategyType) => {
const { strategies } = PLUGIN_CACHING;
const strategyData = strategies[strategyType];
+ // Unjustified type cast. FIXME
const validationSchemaDescription = getStrategyValidationSchema(
strategyData,
).describe() as SchemaObjectDescription;
@@ -155,6 +158,7 @@ export const translateConfig = <T extends CacheConfig>(
config: T,
direction: "fromAPI" | "toAPI",
): T => {
+ // Unjustified type cast. FIXME
const translated = { ...config, strategy: { ...config.strategy } } as T;
// If strategy type is unsupported, use a fallback
diff --git a/frontend/src/metabase/admin/permissions/components/PermissionsPageLayout/PermissionsTabs.tsx b/frontend/src/metabase/admin/permissions/components/PermissionsPageLayout/PermissionsTabs.tsx
index 09a303e564f..1f067068272 100644
--- a/frontend/src/metabase/admin/permissions/components/PermissionsPageLayout/PermissionsTabs.tsx
+++ b/frontend/src/metabase/admin/permissions/components/PermissionsPageLayout/PermissionsTabs.tsx
@@ -37,6 +37,7 @@ export const PermissionsTabs = ({ tab, onChangeTab }: PermissionsTabsProps) => {
<Tabs
listBorder={false}
value={tab}
+ // Unjustified type cast. FIXME
onChange={(value) => value && onChangeTab(value as PermissionsPageTab)}
>
<Tabs.List pl="xl">
diff --git a/frontend/src/metabase/admin/permissions/components/PermissionsSelect/PermissionsSelect.tsx b/frontend/src/metabase/admin/permissions/components/PermissionsSelect/PermissionsSelect.tsx
index 7d98796ee55..ce3761fff9a 100644
--- a/frontend/src/metabase/admin/permissions/components/PermissionsSelect/PermissionsSelect.tsx
+++ b/frontend/src/metabase/admin/permissions/components/PermissionsSelect/PermissionsSelect.tsx
@@ -31,8 +31,11 @@ interface PermissionSelectProps extends PermissionSectionConfig {
// we shouldn't ever show this, but rather than throw an error, let the user pick an option to recover
const defaultOption = {
label: "Missing",
+ // Unjustified type cast. FIXME
value: "missing" as DataPermissionValue,
+ // Unjustified type cast. FIXME
icon: "empty" as IconName,
+ // Unjustified type cast. FIXME
iconColor: "text-disabled" as ColorName,
};
diff --git a/frontend/src/metabase/admin/permissions/selectors/collection-permissions.tsx b/frontend/src/metabase/admin/permissions/selectors/collection-permissions.tsx
index 87f94a49f1a..12c8e44d07b 100644
--- a/frontend/src/metabase/admin/permissions/selectors/collection-permissions.tsx
+++ b/frontend/src/metabase/admin/permissions/selectors/collection-permissions.tsx
@@ -342,6 +342,7 @@ export const getCollectionsPermissionEditor = createSelector(
),
warning: getCollectionWarning(
group.id,
+ // Unjustified type cast. FIXME
collection as ExpandedCollection,
permissions,
),
diff --git a/frontend/src/metabase/admin/permissions/selectors/confirmations.tsx b/frontend/src/metabase/admin/permissions/selectors/confirmations.tsx
index b4a1e69ed14..587475b9a10 100644
--- a/frontend/src/metabase/admin/permissions/selectors/confirmations.tsx
+++ b/frontend/src/metabase/admin/permissions/selectors/confirmations.tsx
@@ -295,6 +295,7 @@ export function getRevokingAccessToAllTablesWarningModal(
const allTableEntityIds = database.getTables().map((table) => ({
databaseId: table.db_id,
schemaName: table.schema_name || "",
+ // Unjustified type cast. FIXME
tableId: table.id as ConcreteTableId,
}));
diff --git a/frontend/src/metabase/admin/permissions/selectors/data-permissions/breadcrumbs.ts b/frontend/src/metabase/admin/permissions/selectors/data-permissions/breadcrumbs.ts
index f37cb316c9a..1ffdd1caedd 100644
--- a/frontend/src/metabase/admin/permissions/selectors/data-permissions/breadcrumbs.ts
+++ b/frontend/src/metabase/admin/permissions/selectors/data-permissions/breadcrumbs.ts
@@ -57,6 +57,7 @@ export const getDatabasesEditorBreadcrumbs = (
return [groupItem, databaseItem];
}
+ // Unjustified type cast. FIXME
const schema = database.schema(schemaName) as Schema;
const schemaItem = {
id: schema.name,
@@ -93,6 +94,7 @@ export const getGroupsDataEditorBreadcrumbs = (
return [databaseItem];
}
+ // Unjustified type cast. FIXME
const schema = database.schema(schemaName) as Schema;
const schemaItem = {
id: schema.id,
@@ -106,6 +108,7 @@ export const getGroupsDataEditorBreadcrumbs = (
return [databaseItem, hasMultipleSchemas && schemaItem].filter(isNotFalsy);
}
+ // Unjustified type cast. FIXME
const table = metadata.table(tableId) as Table;
const tableItem = {
diff --git a/frontend/src/metabase/admin/permissions/selectors/data-permissions/data-sidebar.ts b/frontend/src/metabase/admin/permissions/selectors/data-permissions/data-sidebar.ts
index c3d88a472a5..1e0e13c81d4 100644
--- a/frontend/src/metabase/admin/permissions/selectors/data-permissions/data-sidebar.ts
+++ b/frontend/src/metabase/admin/permissions/selectors/data-permissions/data-sidebar.ts
@@ -56,7 +56,9 @@ const getTableId = (id: string | number) => `table:${id}`;
const getDatabasesSidebar = (metadata: Metadata): DataSidebarProps => {
const entities = metadata
.databasesList({ savedQuestions: false })
+ // Unjustified type cast. FIXME
.filter((db) => !PLUGIN_AUDIT.isAuditDb(db as DatabaseType))
+ // Unjustified type cast. FIXME
.filter((db) => !(db as DatabaseType).router_database_id)
.map((database) => ({
id: database.id,
diff --git a/frontend/src/metabase/admin/permissions/selectors/data-permissions/data-sidebar.unit.spec.ts b/frontend/src/metabase/admin/permissions/selectors/data-permissions/data-sidebar.unit.spec.ts
index bb12cc0bbd9..242857333bd 100644
--- a/frontend/src/metabase/admin/permissions/selectors/data-permissions/data-sidebar.unit.spec.ts
+++ b/frontend/src/metabase/admin/permissions/selectors/data-permissions/data-sidebar.unit.spec.ts
@@ -6,6 +6,7 @@ import { state as mockState } from "./data-permissions.unit.spec.fixtures";
import { getDataFocusSidebar } from ".";
+// Unjustified type cast. FIXME
const state = mockState as unknown as State;
const getRouteProps = ({
diff --git a/frontend/src/metabase/admin/permissions/selectors/data-permissions/group-sidebar.unit.spec.ts b/frontend/src/metabase/admin/permissions/selectors/data-permissions/group-sidebar.unit.spec.ts
index 0af2ac98661..726726a1acd 100644
--- a/frontend/src/metabase/admin/permissions/selectors/data-permissions/group-sidebar.unit.spec.ts
+++ b/frontend/src/metabase/admin/permissions/selectors/data-permissions/group-sidebar.unit.spec.ts
@@ -9,6 +9,7 @@ import { state as mockState } from "./data-permissions.unit.spec.fixtures";
import { getGroupsDataPermissionEditor } from ".";
+// Unjustified type cast. FIXME
const stateWithoutLegacyValues = mockState as unknown as State;
// adding legacy no self-service in the graph will prevent getGroupsDataPermissionEditor
diff --git a/frontend/src/metabase/admin/permissions/selectors/data-permissions/groups.ts b/frontend/src/metabase/admin/permissions/selectors/data-permissions/groups.ts
index 5b2bdc94709..b75b8d339ba 100644
--- a/frontend/src/metabase/admin/permissions/selectors/data-permissions/groups.ts
+++ b/frontend/src/metabase/admin/permissions/selectors/data-permissions/groups.ts
@@ -21,6 +21,7 @@ const EMPTY_GROUP_LIST: Group[] = [];
// typed them as `Group[]`. Downstream code never reads `members` from list
// results, so we cast to preserve the existing call signatures.
export const selectGroupList = (state: State): Group[] =>
+ // Unjustified type cast. FIXME
(permissionApi.endpoints.listPermissionsGroups.select({})(state).data ??
EMPTY_GROUP_LIST) as Group[];
diff --git a/frontend/src/metabase/admin/permissions/selectors/data-permissions/permission-editor.tsx b/frontend/src/metabase/admin/permissions/selectors/data-permissions/permission-editor.tsx
index aeb098c1d5d..8f54d9a0d5f 100644
--- a/frontend/src/metabase/admin/permissions/selectors/data-permissions/permission-editor.tsx
+++ b/frontend/src/metabase/admin/permissions/selectors/data-permissions/permission-editor.tsx
@@ -69,6 +69,7 @@ const getGroupHint = (groupType: SpecialGroupType): string | null => {
// editor/sidebar loading and error UI.
const selectDatabaseTablesMetadata = (state: State, databaseId: string) =>
databaseApi.endpoints.getDatabaseMetadata.select({
+ // Unjustified type cast. FIXME
id: databaseId as unknown as DatabaseId,
include_hidden: true,
remove_inactive: true,
@@ -267,7 +268,8 @@ export const getDatabasesPermissionEditor = createSelector(
if (database && (schemaName != null || hasSingleSchema)) {
const schema: Schema = hasSingleSchema
? database.getSchemas()[0]
- : (database.schema(schemaName) as Schema);
+ : // Unjustified type cast. FIXME
+ (database.schema(schemaName) as Schema);
permissionSubject = "fields";
entities = (schema.tables ?? [])
.sort((a, b) => a.display_name.localeCompare(b.display_name))
@@ -321,7 +323,9 @@ export const getDatabasesPermissionEditor = createSelector(
permissionSubject = "schemas";
entities = metadata
.databasesList({ savedQuestions: false })
+ // Unjustified type cast. FIXME
.filter((db) => !PLUGIN_AUDIT.isAuditDb(db as Database))
+ // Unjustified type cast. FIXME
.filter((db) => !(db as Database).router_database_id)
.map((database) => {
const entityId = getDatabaseEntityId(database);
diff --git a/frontend/src/metabase/admin/permissions/utils/data-entity-id.ts b/frontend/src/metabase/admin/permissions/utils/data-entity-id.ts
index cbb304a56b9..ecc185efd73 100644
--- a/frontend/src/metabase/admin/permissions/utils/data-entity-id.ts
+++ b/frontend/src/metabase/admin/permissions/utils/data-entity-id.ts
@@ -22,6 +22,7 @@ export const getSchemaEntityId = (schemaEntity: Schema) => ({
export const getTableEntityId = (tableEntity: Table) => ({
databaseId: tableEntity.db_id,
schemaName: tableEntity.schema_name,
+ // Unjustified type cast. FIXME
tableId: tableEntity.id as ConcreteTableId,
});
diff --git a/frontend/src/metabase/admin/permissions/utils/graph/data-permissions/get.ts b/frontend/src/metabase/admin/permissions/utils/graph/data-permissions/get.ts
index 1300d12064d..4bd121ae587 100644
--- a/frontend/src/metabase/admin/permissions/utils/graph/data-permissions/get.ts
+++ b/frontend/src/metabase/admin/permissions/utils/graph/data-permissions/get.ts
@@ -179,6 +179,7 @@ export const getEntityPermission = (
return getFieldsPermission(
permissions,
groupId,
+ // Unjustified type cast. FIXME
entityId as TableEntityId,
permission,
);
@@ -186,6 +187,7 @@ export const getEntityPermission = (
return getTablesPermission(
permissions,
groupId,
+ // Unjustified type cast. FIXME
entityId as SchemaEntityId,
permission,
);
diff --git a/frontend/src/metabase/admin/permissions/utils/graph/data-permissions/has.ts b/frontend/src/metabase/admin/permissions/utils/graph/data-permissions/has.ts
index 8da75cf9d76..db6c8981f0f 100644
--- a/frontend/src/metabase/admin/permissions/utils/graph/data-permissions/has.ts
+++ b/frontend/src/metabase/admin/permissions/utils/graph/data-permissions/has.ts
@@ -70,6 +70,7 @@ export function hasPermissionValueInSubgraph(
{
databaseId: entityId.databaseId,
schemaName: schema.name,
+ // Unjustified type cast. FIXME
tableId: table.id as ConcreteTableId,
},
permission,
diff --git a/frontend/src/metabase/admin/permissions/utils/graph/data-permissions/update.ts b/frontend/src/metabase/admin/permissions/utils/graph/data-permissions/update.ts
index de7e58cd7d0..a8c3d92d11b 100644
--- a/frontend/src/metabase/admin/permissions/utils/graph/data-permissions/update.ts
+++ b/frontend/src/metabase/admin/permissions/utils/graph/data-permissions/update.ts
@@ -346,6 +346,7 @@ function inferEntityPermissionValueFromChildTables(
.groupBy(_.identity)
.value();
+ // Unjustified type cast. FIXME
const keys = Object.keys(entityIdsByPermValue) as DataPermissionValue[];
const allTablesHaveSamePermissions = keys.length === 1;
@@ -366,6 +367,7 @@ export function inferAndUpdateEntityPermissions(
permission: DataPermission,
) {
const { databaseId } = entityId;
+ // Unjustified type cast. FIXME
const schemaName = (entityId as SchemaEntityId).schemaName ?? "";
if (schemaName) {
diff --git a/frontend/src/metabase/admin/permissions/utils/graph/permissions-diff.ts b/frontend/src/metabase/admin/permissions/utils/graph/permissions-diff.ts
index 478f4d6e9b9..83597974b32 100644
--- a/frontend/src/metabase/admin/permissions/utils/graph/permissions-diff.ts
+++ b/frontend/src/metabase/admin/permissions/utils/graph/permissions-diff.ts
@@ -62,6 +62,7 @@ function diffDatabasePermissions(
{
databaseId: database.id,
schemaName: table.schema_name || "",
+ // Unjustified type cast. FIXME
tableId: table.id as ConcreteTableId,
},
DataPermission.VIEW_DATA,
@@ -72,6 +73,7 @@ function diffDatabasePermissions(
{
databaseId: database.id,
schemaName: table.schema_name || "",
+ // Unjustified type cast. FIXME
tableId: table.id as ConcreteTableId,
},
DataPermission.VIEW_DATA,
@@ -113,6 +115,7 @@ function diffGroupPermissions(
}
}
deleteIfEmpty(groupDiff, "databases");
+ // Unjustified type cast. FIXME
return groupDiff as Partial<GroupPermissionsDiff>;
}
@@ -139,5 +142,6 @@ export function diffDataPermissions(
}
}
}
+ // Unjustified type cast. FIXME
return permissionsDiff as PermissionsGraphDiff;
}
diff --git a/frontend/src/metabase/admin/permissions/utils/metadata.ts b/frontend/src/metabase/admin/permissions/utils/metadata.ts
index 66084b7e0e7..b9069912a6a 100644
--- a/frontend/src/metabase/admin/permissions/utils/metadata.ts
+++ b/frontend/src/metabase/admin/permissions/utils/metadata.ts
@@ -15,6 +15,7 @@ export const getDatabase = (metadata: Metadata, databaseId: number) => {
export const metadataTableToTableEntityId = (table: Table) => ({
databaseId: table.db_id,
schemaName: table.schema_name || "",
+ // Unjustified type cast. FIXME
tableId: table.id as ConcreteTableId,
});
diff --git a/frontend/src/metabase/admin/settings/auth/containers/GoogleAuthCard/GoogleAuthCard.tsx b/frontend/src/metabase/admin/settings/auth/containers/GoogleAuthCard/GoogleAuthCard.tsx
index 7177287517f..5c82a205a77 100644
--- a/frontend/src/metabase/admin/settings/auth/containers/GoogleAuthCard/GoogleAuthCard.tsx
+++ b/frontend/src/metabase/admin/settings/auth/containers/GoogleAuthCard/GoogleAuthCard.tsx
@@ -19,6 +19,7 @@ export function GoogleAuthCard() {
const handleDeactivate = () => {
return updateSettings(
+ // Unjustified type cast. FIXME
GOOGLE_SCHEMA.getDefault() as Partial<EnterpriseSettings>,
);
};
diff --git a/frontend/src/metabase/admin/settings/auth/containers/LdapAuthCard/LdapAuthCard.tsx b/frontend/src/metabase/admin/settings/auth/containers/LdapAuthCard/LdapAuthCard.tsx
index 52e01db1fda..5f1cebcecfc 100644
--- a/frontend/src/metabase/admin/settings/auth/containers/LdapAuthCard/LdapAuthCard.tsx
+++ b/frontend/src/metabase/admin/settings/auth/containers/LdapAuthCard/LdapAuthCard.tsx
@@ -19,6 +19,7 @@ export function LdapAuthCard() {
const handleDeactivate = () => {
return updateSettings(
+ // Unjustified type cast. FIXME
LDAP_SCHEMA.getDefault() as Partial<EnterpriseSettings>,
);
};
diff --git a/frontend/src/metabase/admin/settings/components/ApiKeys/CreateApiKeyModal.tsx b/frontend/src/metabase/admin/settings/components/ApiKeys/CreateApiKeyModal.tsx
index 71f143d0518..dba7bb9b83b 100644
--- a/frontend/src/metabase/admin/settings/components/ApiKeys/CreateApiKeyModal.tsx
+++ b/frontend/src/metabase/admin/settings/components/ApiKeys/CreateApiKeyModal.tsx
@@ -24,6 +24,7 @@ export const CreateApiKeyModal = ({ onClose }: { onClose: () => void }) => {
const handleSubmit = useCallback(
async (vals: { group_id: number | null; name: string }) => {
if (vals.group_id !== null) {
+ // Unjustified type cast. FIXME
await createApiKey(vals as CreateApiKeyRequest).unwrap();
}
},
diff --git a/frontend/src/metabase/admin/settings/components/ApiKeys/EditApiKeyModal.tsx b/frontend/src/metabase/admin/settings/components/ApiKeys/EditApiKeyModal.tsx
index 6fa983d0143..331ca217cf6 100644
--- a/frontend/src/metabase/admin/settings/components/ApiKeys/EditApiKeyModal.tsx
+++ b/frontend/src/metabase/admin/settings/components/ApiKeys/EditApiKeyModal.tsx
@@ -160,6 +160,7 @@ export const EditApiKeyModal = ({
input: {
// override the disabled-gray so the masked key stays readable in both themes
color: "var(--mb-color-text-primary) !important",
+ // Unjustified type cast. FIXME
fontFamily: fontFamilyMonospace as string,
},
}}
diff --git a/frontend/src/metabase/admin/settings/components/CloudPanel/CloudPanel.unit.spec.tsx b/frontend/src/metabase/admin/settings/components/CloudPanel/CloudPanel.unit.spec.tsx
index cbf5eb20cb4..0bb03afba4c 100644
--- a/frontend/src/metabase/admin/settings/components/CloudPanel/CloudPanel.unit.spec.tsx
+++ b/frontend/src/metabase/admin/settings/components/CloudPanel/CloudPanel.unit.spec.tsx
@@ -92,6 +92,7 @@ describe("CloudPanel", () => {
await userEvent.click(cancelButton);
await expectCancelConfirmationModal();
+ // Unjustified type cast. FIXME
expect((store.getState() as any).undo).toHaveLength(0);
await userEvent.click(
within(
@@ -106,6 +107,7 @@ describe("CloudPanel", () => {
}),
).toBeTruthy();
});
+ // Unjustified type cast. FIXME
expect((store.getState() as any).undo).toHaveLength(1);
fetchMockCloudMigrationGetSequence([CANCELED_RESPONSE]);
diff --git a/frontend/src/metabase/admin/settings/components/Email/BaseSMTPConnectionForm.tsx b/frontend/src/metabase/admin/settings/components/Email/BaseSMTPConnectionForm.tsx
index 4ba402b3326..8862baad135 100644
--- a/frontend/src/metabase/admin/settings/components/Email/BaseSMTPConnectionForm.tsx
+++ b/frontend/src/metabase/admin/settings/components/Email/BaseSMTPConnectionForm.tsx
@@ -169,6 +169,7 @@ export const BaseSMTPConnectionForm = ({
.map((formKey) => getFullFormKey(formKey))
.every(
(field) =>
+ // Unjustified type cast. FIXME
settingsDetails[field as keyof typeof settingsDetails]
?.is_env_setting,
)
diff --git a/frontend/src/metabase/admin/settings/components/Email/SMTPConnectionCard/tests/setup.tsx b/frontend/src/metabase/admin/settings/components/Email/SMTPConnectionCard/tests/setup.tsx
index e9c512b9c60..23c9eb8bbc7 100644
--- a/frontend/src/metabase/admin/settings/components/Email/SMTPConnectionCard/tests/setup.tsx
+++ b/frontend/src/metabase/admin/settings/components/Email/SMTPConnectionCard/tests/setup.tsx
@@ -36,6 +36,7 @@ export function setup({
setupPropertiesEndpoints(createMockSettings(settings));
setupSettingsEndpoints(
Object.entries(settings).map(([key, value]) =>
+ // Unjustified type cast. FIXME
createMockSettingDefinition({ key: key as SettingKey, value }),
),
);
diff --git a/frontend/src/metabase/admin/settings/components/SettingsLdapForm.unit.spec.tsx b/frontend/src/metabase/admin/settings/components/SettingsLdapForm.unit.spec.tsx
index 3fa15efff6b..95944a81892 100644
--- a/frontend/src/metabase/admin/settings/components/SettingsLdapForm.unit.spec.tsx
+++ b/frontend/src/metabase/admin/settings/components/SettingsLdapForm.unit.spec.tsx
@@ -113,6 +113,7 @@ describe("SettingsLdapForm", () => {
});
it("can remove a nullable field", async () => {
+ // Unjustified type cast. FIXME
setup(ATTRS as Partial<LdapSettings>);
await userEvent.clear(await screen.findByLabelText(/First name attribute/));
diff --git a/frontend/src/metabase/admin/settings/components/SettingsNav/SettingsNavItem.tsx b/frontend/src/metabase/admin/settings/components/SettingsNav/SettingsNavItem.tsx
index 72e56eb37a1..0966c15e1cf 100644
--- a/frontend/src/metabase/admin/settings/components/SettingsNav/SettingsNavItem.tsx
+++ b/frontend/src/metabase/admin/settings/components/SettingsNav/SettingsNavItem.tsx
@@ -20,6 +20,7 @@ const findBestMatchingChild = (
let bestLen = 0;
for (const child of children) {
+ // Unjustified type cast. FIXME
const childPath = child?.props?.path as string | undefined;
if (!childPath) {
continue;
@@ -43,6 +44,7 @@ export function SettingsNavItem({
children: childrenProp,
...navItemProps
}: AdminNavItemProps & { active?: boolean }) {
+ // Unjustified type cast. FIXME
const children = React.Children.toArray(childrenProp) as ReactElement[];
const currentPath = useSelector(getLocation)?.pathname ?? "";
const [isOpen, { toggle: toggleOpen }] = useDisclosure(
@@ -70,7 +72,8 @@ export function SettingsNavItem({
{children.length > 0
? children.map((child) =>
child?.props?.path
- ? React.cloneElement(child, {
+ ? // Unjustified type cast. FIXME
+ React.cloneElement(child, {
active: child === bestChild,
} as any)
: child,
diff --git a/frontend/src/metabase/admin/settings/components/SettingsNav/UpdatesNavItem.unit.spec.tsx b/frontend/src/metabase/admin/settings/components/SettingsNav/UpdatesNavItem.unit.spec.tsx
index 91a8e776f36..cde08ca9612 100644
--- a/frontend/src/metabase/admin/settings/components/SettingsNav/UpdatesNavItem.unit.spec.tsx
+++ b/frontend/src/metabase/admin/settings/components/SettingsNav/UpdatesNavItem.unit.spec.tsx
@@ -39,6 +39,7 @@ const setup = async (props: { versionTag: string }) => {
setupSettingsEndpoints(
Object.entries(settings).map(([key, value]) =>
+ // Unjustified type cast. FIXME
createMockSettingDefinition({ key: key as SettingKey, value }),
),
);
diff --git a/frontend/src/metabase/admin/settings/components/SettingsPages/EmailSettingsPage.unit.spec.tsx b/frontend/src/metabase/admin/settings/components/SettingsPages/EmailSettingsPage.unit.spec.tsx
index 0738a4b84c9..b5cebbc781f 100644
--- a/frontend/src/metabase/admin/settings/components/SettingsPages/EmailSettingsPage.unit.spec.tsx
+++ b/frontend/src/metabase/admin/settings/components/SettingsPages/EmailSettingsPage.unit.spec.tsx
@@ -40,6 +40,7 @@ const setup = async (props: {
setupUpdateSettingEndpoint();
setupSettingsEndpoints(
Object.entries(settings).map(([key, value]) =>
+ // Unjustified type cast. FIXME
createMockSettingDefinition({ key: key as SettingKey, value }),
),
);
diff --git a/frontend/src/metabase/admin/settings/components/SettingsPages/GeneralSettingsPage.unit.spec.tsx b/frontend/src/metabase/admin/settings/components/SettingsPages/GeneralSettingsPage.unit.spec.tsx
index cd07191bcb8..f9c0cde055e 100644
--- a/frontend/src/metabase/admin/settings/components/SettingsPages/GeneralSettingsPage.unit.spec.tsx
+++ b/frontend/src/metabase/admin/settings/components/SettingsPages/GeneralSettingsPage.unit.spec.tsx
@@ -77,6 +77,7 @@ const setup = async ({
setupUpdateSettingEndpoint();
setupSettingsEndpoints(
Object.entries(settings).map(([key, value]) =>
+ // Unjustified type cast. FIXME
createMockSettingDefinition({ key: key as SettingKey, value }),
),
);
diff --git a/frontend/src/metabase/admin/settings/components/SettingsPages/LocalizationSettingsPage.unit.spec.tsx b/frontend/src/metabase/admin/settings/components/SettingsPages/LocalizationSettingsPage.unit.spec.tsx
index e06978d8333..0339112e525 100644
--- a/frontend/src/metabase/admin/settings/components/SettingsPages/LocalizationSettingsPage.unit.spec.tsx
+++ b/frontend/src/metabase/admin/settings/components/SettingsPages/LocalizationSettingsPage.unit.spec.tsx
@@ -23,6 +23,7 @@ const setup = async () => {
"site-locale": "En",
"report-timezone": "",
"start-of-week": "monday",
+ // Unjustified type cast. FIXME
"available-timezones": [
"Europe/Paris",
"Pacific/Auckland",
@@ -36,6 +37,7 @@ const setup = async () => {
setupUpdateSettingEndpoint();
setupSettingsEndpoints(
Object.entries(settings).map(([key, value]) =>
+ // Unjustified type cast. FIXME
createMockSettingDefinition({ key: key as SettingKey, value }),
),
);
diff --git a/frontend/src/metabase/admin/settings/components/SettingsPages/PublicSharingSettingsPage.unit.spec.tsx b/frontend/src/metabase/admin/settings/components/SettingsPages/PublicSharingSettingsPage.unit.spec.tsx
index feddd1fd2c1..15ad967f52d 100644
--- a/frontend/src/metabase/admin/settings/components/SettingsPages/PublicSharingSettingsPage.unit.spec.tsx
+++ b/frontend/src/metabase/admin/settings/components/SettingsPages/PublicSharingSettingsPage.unit.spec.tsx
@@ -32,6 +32,7 @@ const setup = async (enablePublicSharing = false) => {
setupUpdateSettingEndpoint();
setupSettingsEndpoints(
Object.entries(settings).map(([key, value]) =>
+ // Unjustified type cast. FIXME
createMockSettingDefinition({ key: key as SettingKey, value }),
),
);
diff --git a/frontend/src/metabase/admin/settings/components/SettingsPages/UpdatesSettingsPage.unit.spec.tsx b/frontend/src/metabase/admin/settings/components/SettingsPages/UpdatesSettingsPage.unit.spec.tsx
index 4312c284b74..d6afb270111 100644
--- a/frontend/src/metabase/admin/settings/components/SettingsPages/UpdatesSettingsPage.unit.spec.tsx
+++ b/frontend/src/metabase/admin/settings/components/SettingsPages/UpdatesSettingsPage.unit.spec.tsx
@@ -56,6 +56,7 @@ const setup = async (props: {
});
setupSettingsEndpoints(
Object.entries(settings).map(([key, value]) =>
+ // Unjustified type cast. FIXME
createMockSettingDefinition({ key: key as SettingKey, value }),
),
);
diff --git a/frontend/src/metabase/admin/settings/components/UploadSettings/UploadSettingsForm.tsx b/frontend/src/metabase/admin/settings/components/UploadSettings/UploadSettingsForm.tsx
index 3d10ad9fff8..9e68da6675f 100644
--- a/frontend/src/metabase/admin/settings/components/UploadSettings/UploadSettingsForm.tsx
+++ b/frontend/src/metabase/admin/settings/components/UploadSettings/UploadSettingsForm.tsx
@@ -206,6 +206,7 @@ export function UploadSettingsFormView({
schemaLength: !!schemas?.length,
})
.with({ schemasError: true }, () =>
+ // Unjustified type cast. FIXME
getErrorMessage((schemasError as any)?.data),
)
.with(
diff --git a/frontend/src/metabase/admin/settings/components/UploadSettings/UploadSettingsForm.unit.spec.tsx b/frontend/src/metabase/admin/settings/components/UploadSettings/UploadSettingsForm.unit.spec.tsx
index fcaaaa37b52..13d5b5215e1 100644
--- a/frontend/src/metabase/admin/settings/components/UploadSettings/UploadSettingsForm.unit.spec.tsx
+++ b/frontend/src/metabase/admin/settings/components/UploadSettings/UploadSettingsForm.unit.spec.tsx
@@ -32,6 +32,7 @@ import {
UploadSettingsFormView,
} from "./UploadSettingsForm";
+// Unjustified type cast. FIXME
const TEST_DATABASES = [
createMockDatabase({
id: 1,
diff --git a/frontend/src/metabase/admin/settings/components/UploadSettings/utils.unit.spec.ts b/frontend/src/metabase/admin/settings/components/UploadSettings/utils.unit.spec.ts
index 0a27c693d89..14d68f78f2d 100644
--- a/frontend/src/metabase/admin/settings/components/UploadSettings/utils.unit.spec.ts
+++ b/frontend/src/metabase/admin/settings/components/UploadSettings/utils.unit.spec.ts
@@ -14,6 +14,7 @@ const setup = ({ databases, schemas }: SetupOpts) => {
const metadata = createMockMetadata({ databases, schemas });
return {
+ // Unjustified type cast. FIXME
databases: databases.map(({ id }) =>
checkNotNull(metadata.database(id)),
) as Database[],
diff --git a/frontend/src/metabase/admin/settings/components/widgets/CustomGeoJSONWidget.unit.spec.tsx b/frontend/src/metabase/admin/settings/components/widgets/CustomGeoJSONWidget.unit.spec.tsx
index 049bbcc2416..36fdc674921 100644
--- a/frontend/src/metabase/admin/settings/components/widgets/CustomGeoJSONWidget.unit.spec.tsx
+++ b/frontend/src/metabase/admin/settings/components/widgets/CustomGeoJSONWidget.unit.spec.tsx
@@ -197,6 +197,7 @@ describe("CustomGeoJSONWIdget", () => {
const puts = await findRequests("PUT");
const { body } = puts[0];
const testMapEntry = Object.values(body.value).find(
+ // Unjustified type cast. FIXME
(item) => (item as CustomGeoJSONMap).name === "Test Two",
);
expect(testMapEntry).toEqual({
@@ -260,6 +261,7 @@ describe("CustomGeoJSONWIdget", () => {
const puts = await findRequests("PUT");
const { body } = puts[0];
const testMapEntry = Object.values(body.value).find(
+ // Unjustified type cast. FIXME
(item) => (item as CustomGeoJSONMap).name === "Test Edit",
);
expect(testMapEntry).toEqual({
diff --git a/frontend/src/metabase/admin/settings/components/widgets/FormattingWidget.tsx b/frontend/src/metabase/admin/settings/components/widgets/FormattingWidget.tsx
index 25ee59bba75..5cd6fdeb89a 100644
--- a/frontend/src/metabase/admin/settings/components/widgets/FormattingWidget.tsx
+++ b/frontend/src/metabase/admin/settings/components/widgets/FormattingWidget.tsx
@@ -68,6 +68,7 @@ export function FormattingWidget() {
localValue?.["type/Currency"] || {};
const [currencyOptions, currencyStyleOptions] = useMemo(() => {
+ // Unjustified type cast. FIXME
const currencyOptions = (
getCurrencyOptions() as { name: string; value: string }[]
).map(mapNameToLabel);
@@ -104,6 +105,7 @@ export function FormattingWidget() {
...localValue,
"type/Temporal": {
...localValue?.["type/Temporal"],
+ // Unjustified type cast. FIXME
date_style: newValue as string,
},
})
@@ -126,6 +128,7 @@ export function FormattingWidget() {
...localValue,
"type/Temporal": {
...localValue?.["type/Temporal"],
+ // Unjustified type cast. FIXME
date_abbreviate: checked as boolean,
},
})
@@ -147,6 +150,7 @@ export function FormattingWidget() {
...localValue,
"type/Temporal": {
...localValue?.["type/Temporal"],
+ // Unjustified type cast. FIXME
time_style: newValue as string,
},
})
@@ -171,6 +175,7 @@ export function FormattingWidget() {
...localValue,
"type/Number": {
...localValue?.["type/Number"],
+ // Unjustified type cast. FIXME
number_separators: newValue as string,
},
})
@@ -190,6 +195,7 @@ export function FormattingWidget() {
...localValue,
"type/Currency": {
...localValue?.["type/Currency"],
+ // Unjustified type cast. FIXME
currency: newValue as string,
},
})
@@ -206,6 +212,7 @@ export function FormattingWidget() {
...localValue,
"type/Currency": {
...localValue?.["type/Currency"],
+ // Unjustified type cast. FIXME
currency_style: newValue as CurrencyStyle,
},
})
diff --git a/frontend/src/metabase/admin/settings/components/widgets/FormattingWidget.unit.spec.tsx b/frontend/src/metabase/admin/settings/components/widgets/FormattingWidget.unit.spec.tsx
index 052c7d2c37e..9e95d8ab927 100644
--- a/frontend/src/metabase/admin/settings/components/widgets/FormattingWidget.unit.spec.tsx
+++ b/frontend/src/metabase/admin/settings/components/widgets/FormattingWidget.unit.spec.tsx
@@ -23,6 +23,7 @@ const setup = async () => {
setupUpdateSettingEndpoint();
setupSettingsEndpoints(
Object.entries(settings).map(([key, value]) =>
+ // Unjustified type cast. FIXME
createMockSettingDefinition({ key: key as SettingKey, value }),
),
);
diff --git a/frontend/src/metabase/admin/settings/components/widgets/GroupMappingsWidget/DeleteGroupMappingModal/DeleteGroupMappingModal.tsx b/frontend/src/metabase/admin/settings/components/widgets/GroupMappingsWidget/DeleteGroupMappingModal/DeleteGroupMappingModal.tsx
index 01392ed6ab9..2bbb65c2b0c 100644
--- a/frontend/src/metabase/admin/settings/components/widgets/GroupMappingsWidget/DeleteGroupMappingModal/DeleteGroupMappingModal.tsx
+++ b/frontend/src/metabase/admin/settings/components/widgets/GroupMappingsWidget/DeleteGroupMappingModal/DeleteGroupMappingModal.tsx
@@ -63,6 +63,7 @@ export const DeleteGroupMappingModal = ({
<Radio.Group
value={value}
onChange={(newValue) =>
+ // Unjustified type cast. FIXME
handleChange(newValue as DeleteMappingModalValueType)
}
>
diff --git a/frontend/src/metabase/admin/settings/components/widgets/GroupMappingsWidget/GroupMappingsWidget.tsx b/frontend/src/metabase/admin/settings/components/widgets/GroupMappingsWidget/GroupMappingsWidget.tsx
index d40624cbfd3..808608ce45e 100644
--- a/frontend/src/metabase/admin/settings/components/widgets/GroupMappingsWidget/GroupMappingsWidget.tsx
+++ b/frontend/src/metabase/admin/settings/components/widgets/GroupMappingsWidget/GroupMappingsWidget.tsx
@@ -26,6 +26,7 @@ export function GroupMappingsWidget(props: GroupMappingsWidgetProps) {
const allGroups = data ?? EMPTY_GROUP_LIST;
const mappings = useSelector(
(state) =>
+ // Unjustified type cast. FIXME
(getSetting(state, props.mappingSetting as keyof Settings) as
| Record<string, GroupId[]>
| undefined) ?? {},
@@ -51,6 +52,7 @@ export function GroupMappingsWidget(props: GroupMappingsWidgetProps) {
return (
<GroupMappingsWidgetView
+ // Unjustified type cast. FIXME
{...(props as unknown as React.ComponentProps<
typeof GroupMappingsWidgetView
>)}
diff --git a/frontend/src/metabase/admin/settings/components/widgets/HomepageSetting.tsx b/frontend/src/metabase/admin/settings/components/widgets/HomepageSetting.tsx
index 6675e9c3c69..61f341cc3df 100644
--- a/frontend/src/metabase/admin/settings/components/widgets/HomepageSetting.tsx
+++ b/frontend/src/metabase/admin/settings/components/widgets/HomepageSetting.tsx
@@ -89,6 +89,7 @@ export function HomepageSetting() {
/>
<Radio.Group
value={mode}
+ // Unjustified type cast. FIXME
onChange={(v) => handleModeChange(v as Mode)}
name="homepage-mode"
aria-label={t`Homepage`}
diff --git a/frontend/src/metabase/admin/settings/components/widgets/HomepageSetting.unit.spec.tsx b/frontend/src/metabase/admin/settings/components/widgets/HomepageSetting.unit.spec.tsx
index be5ad756eaa..c284926619e 100644
--- a/frontend/src/metabase/admin/settings/components/widgets/HomepageSetting.unit.spec.tsx
+++ b/frontend/src/metabase/admin/settings/components/widgets/HomepageSetting.unit.spec.tsx
@@ -126,6 +126,7 @@ const setup = ({
const findBulkPutBody = async () => {
const requests = await findRequests("PUT");
const bulk = requests.find(({ url }) => url.endsWith("/api/setting"));
+ // Unjustified type cast. FIXME
return bulk?.body as Record<string, unknown> | undefined;
};
diff --git a/frontend/src/metabase/admin/settings/components/widgets/Notifications/WebhookForm.unit.spec.tsx b/frontend/src/metabase/admin/settings/components/widgets/Notifications/WebhookForm.unit.spec.tsx
index 4a4cf305f44..dce385a8492 100644
--- a/frontend/src/metabase/admin/settings/components/widgets/Notifications/WebhookForm.unit.spec.tsx
+++ b/frontend/src/metabase/admin/settings/components/widgets/Notifications/WebhookForm.unit.spec.tsx
@@ -175,6 +175,7 @@ describe("WebhookForm", () => {
});
fetchMock.post("path:/api/channel/test", async (call) => {
+ // Unjustified type cast. FIXME
const body = JSON.parse(call.options?.body as string);
return body.details.url?.endsWith("good") ? { ok: true } : 400;
});
diff --git a/frontend/src/metabase/admin/settings/components/widgets/SendTestEmailWidget.unit.spec.tsx b/frontend/src/metabase/admin/settings/components/widgets/SendTestEmailWidget.unit.spec.tsx
index 2f9e4c9c5e2..aec1fb535db 100644
--- a/frontend/src/metabase/admin/settings/components/widgets/SendTestEmailWidget.unit.spec.tsx
+++ b/frontend/src/metabase/admin/settings/components/widgets/SendTestEmailWidget.unit.spec.tsx
@@ -37,6 +37,7 @@ const setup = async (props: {
setupPropertiesEndpoints(settings);
setupSettingsEndpoints(
Object.entries(settings).map(([key, value]) =>
+ // Unjustified type cast. FIXME
createMockSettingDefinition({ key: key as SettingKey, value }),
),
);
diff --git a/frontend/src/metabase/admin/settings/components/widgets/SiteUrlWidget.tsx b/frontend/src/metabase/admin/settings/components/widgets/SiteUrlWidget.tsx
index d62feba70a1..1a8beb9909b 100644
--- a/frontend/src/metabase/admin/settings/components/widgets/SiteUrlWidget.tsx
+++ b/frontend/src/metabase/admin/settings/components/widgets/SiteUrlWidget.tsx
@@ -25,6 +25,7 @@ export function SiteUrlWidget() {
setErrorMessage("");
if (response?.error) {
const message =
+ // Unjustified type cast. FIXME
(response.error as { data: GenericErrorResponse })?.data?.message ||
t`Error saving Site URL`;
setErrorMessage(message);
diff --git a/frontend/src/metabase/admin/settings/components/widgets/SiteUrlWidget.unit.spec.tsx b/frontend/src/metabase/admin/settings/components/widgets/SiteUrlWidget.unit.spec.tsx
index c6b802be970..7c227d15839 100644
--- a/frontend/src/metabase/admin/settings/components/widgets/SiteUrlWidget.unit.spec.tsx
+++ b/frontend/src/metabase/admin/settings/components/widgets/SiteUrlWidget.unit.spec.tsx
@@ -33,6 +33,7 @@ const setup = (props: { isHosted?: boolean; isEnvSetting?: boolean }) => {
setupSettingsEndpoints(
Object.entries(settings).map(([key, value]) =>
createMockSettingDefinition({
+ // Unjustified type cast. FIXME
key: key as SettingKey,
value,
is_env_setting: props.isEnvSetting && key === "site-url",
diff --git a/frontend/src/metabase/admin/settings/components/widgets/VersionUpdateNotice/VersionUpdateNotice.unit.spec.tsx b/frontend/src/metabase/admin/settings/components/widgets/VersionUpdateNotice/VersionUpdateNotice.unit.spec.tsx
index b3378306822..5c382b248ad 100644
--- a/frontend/src/metabase/admin/settings/components/widgets/VersionUpdateNotice/VersionUpdateNotice.unit.spec.tsx
+++ b/frontend/src/metabase/admin/settings/components/widgets/VersionUpdateNotice/VersionUpdateNotice.unit.spec.tsx
@@ -43,6 +43,7 @@ const setup = (props: { isHosted: boolean; versionTag: string }) => {
setupSettingsEndpoints(
Object.entries(settings).map(([key, value]) =>
+ // Unjustified type cast. FIXME
createMockSettingDefinition({ key: key as SettingKey, value }),
),
);
diff --git a/frontend/src/metabase/admin/settings/slack/SlackBugReportChannelInput.tsx b/frontend/src/metabase/admin/settings/slack/SlackBugReportChannelInput.tsx
index 4179f54875a..5ca48e18c14 100644
--- a/frontend/src/metabase/admin/settings/slack/SlackBugReportChannelInput.tsx
+++ b/frontend/src/metabase/admin/settings/slack/SlackBugReportChannelInput.tsx
@@ -8,6 +8,7 @@ import { Box, Text, TextInput } from "metabase/ui";
import { SettingHeader } from "../components/SettingHeader";
const getSlackError = (err: unknown): string =>
+ // Unjustified type cast. FIXME
(err as { data?: { errors?: { "slack-bug-report-channel"?: string } } })?.data
?.errors?.["slack-bug-report-channel"] ?? t`Failed to update channel`;
diff --git a/frontend/src/metabase/admin/settings/tests/setup.tsx b/frontend/src/metabase/admin/settings/tests/setup.tsx
index 48e1a51e9f5..bd77f197ab6 100644
--- a/frontend/src/metabase/admin/settings/tests/setup.tsx
+++ b/frontend/src/metabase/admin/settings/tests/setup.tsx
@@ -127,6 +127,7 @@ export const setup = async ({
if (hasTokenFeatures) {
// all or nothing token features
Object.keys(tokenFeatures).forEach((feature) => {
+ // Unjustified type cast. FIXME
tokenFeatures[feature as TokenFeature] = true;
});
}
diff --git a/frontend/src/metabase/api/activity.ts b/frontend/src/metabase/api/activity.ts
index 6aa47a0d479..3ed6cb8797c 100644
--- a/frontend/src/metabase/api/activity.ts
+++ b/frontend/src/metabase/api/activity.ts
@@ -108,6 +108,7 @@ export function useListRecentsQuery<T extends boolean | undefined = undefined>(
options?: GetRecentsQueryOptions,
) {
type ResultType = T extends true ? RecentItemWithMetadata : RecentItem;
+ // Unjustified type cast. FIXME
return activityApi.endpoints.listRecents.useQuery(
params,
options,
diff --git a/frontend/src/metabase/api/ai-streaming/process-stream.unit.spec.ts b/frontend/src/metabase/api/ai-streaming/process-stream.unit.spec.ts
index da33e96f222..351cd5f15d3 100644
--- a/frontend/src/metabase/api/ai-streaming/process-stream.unit.spec.ts
+++ b/frontend/src/metabase/api/ai-streaming/process-stream.unit.spec.ts
@@ -100,6 +100,7 @@ describe("processChatResponse", () => {
it("should ignore unhandled event types", async () => {
const mockStream = createMockSSEStream([
+ // Unjustified type cast. FIXME
{ type: "reasoning-start", id: "r1" } as unknown as SSEEvent,
]);
const config = getMockedCallbacks();
diff --git a/frontend/src/metabase/api/ai-streaming/requests.unit.spec.ts b/frontend/src/metabase/api/ai-streaming/requests.unit.spec.ts
index dd3c65a2ed4..e39cef6a503 100644
--- a/frontend/src/metabase/api/ai-streaming/requests.unit.spec.ts
+++ b/frontend/src/metabase/api/ai-streaming/requests.unit.spec.ts
@@ -27,6 +27,7 @@ describe("ai requests", () => {
// The client wraps the args in a `Request`, so assert on its URL.
const [request] = fetchSpy.mock.calls[0];
+ // Unjustified type cast. FIXME
expect((request as Request).url).toBe(
"http://example.com/some-streamed-endpoint",
);
diff --git a/frontend/src/metabase/api/ai-streaming/schemas.ts b/frontend/src/metabase/api/ai-streaming/schemas.ts
index 76c29d4d9a8..e7a6d952183 100644
--- a/frontend/src/metabase/api/ai-streaming/schemas.ts
+++ b/frontend/src/metabase/api/ai-streaming/schemas.ts
@@ -84,4 +84,5 @@ export const isKnownDataPart = (part: {
type: string;
data: unknown;
}): part is KnownDataPart =>
+ // Unjustified type cast. FIXME
(knownDataPartTypes as readonly string[]).includes(part.type);
diff --git a/frontend/src/metabase/api/ai-streaming/sse-stream.ts b/frontend/src/metabase/api/ai-streaming/sse-stream.ts
index fc217e5470a..eac6b7e6e93 100644
--- a/frontend/src/metabase/api/ai-streaming/sse-stream.ts
+++ b/frontend/src/metabase/api/ai-streaming/sse-stream.ts
@@ -13,8 +13,8 @@ export async function* parseSSEStream(
stream: ReadableStream<Uint8Array>,
): AsyncGenerator<SSEEvent> {
const eventStream = stream
- // TypeScript v5.9 issue - cast works around TS Uint8Array generic variance issue: https://github.com/microsoft/TypeScript/issues/62240
.pipeThrough(
+ // TypeScript v5.9 issue - cast works around TS Uint8Array generic variance issue: https://github.com/microsoft/TypeScript/issues/62240
new TextDecoderStream() as unknown as ReadableWritablePair<
string,
Uint8Array<ArrayBufferLike>
@@ -33,6 +33,7 @@ export async function* parseSSEStream(
}
try {
+ // Unjustified type cast. FIXME
yield JSON.parse(value.data) as SSEEvent;
} catch {
console.warn("Skipping unparseable SSE event:", value.data);
diff --git a/frontend/src/metabase/api/ai-streaming/test-utils.ts b/frontend/src/metabase/api/ai-streaming/test-utils.ts
index 172aa1ccabb..b1e4941d562 100644
--- a/frontend/src/metabase/api/ai-streaming/test-utils.ts
+++ b/frontend/src/metabase/api/ai-streaming/test-utils.ts
@@ -4,6 +4,7 @@ import type { SSEEvent } from "./sse-types";
export function createPauses<Count extends number>(count: Count) {
const pauses = new Array(count).fill(null).map(() => defer());
+ // Unjustified type cast. FIXME
return pauses as ReturnType<typeof defer>[] & { length: Count };
}
@@ -176,6 +177,7 @@ export function mockStreamedEndpoint(
},
});
+ // Unjustified type cast. FIXME
return { status: 202, ok: true, body, headers: new Headers() } as any;
});
diff --git a/frontend/src/metabase/api/api.unit.spec.ts b/frontend/src/metabase/api/api.unit.spec.ts
index e359b111661..aa9601392fe 100644
--- a/frontend/src/metabase/api/api.unit.spec.ts
+++ b/frontend/src/metabase/api/api.unit.spec.ts
@@ -5,6 +5,7 @@ import { api } from "metabase/api/client";
import { baseQuery } from "./api";
describe("baseQuery (RTK Query adapter)", () => {
+ // Unjustified type cast. FIXME
const ctx = { signal: new AbortController().signal } as BaseQueryApi;
afterEach(() => {
diff --git a/frontend/src/metabase/api/automagic-dashboards.ts b/frontend/src/metabase/api/automagic-dashboards.ts
index c96b7548322..e1fa186cfbe 100644
--- a/frontend/src/metabase/api/automagic-dashboards.ts
+++ b/frontend/src/metabase/api/automagic-dashboards.ts
@@ -47,6 +47,7 @@ export const automagicDashboardsApi = Api.injectEndpoints({
url: `/api/automagic-dashboards/${subPath}`,
params,
});
+ // Unjustified type cast. FIXME
return error ? { error } : { data: data as Dashboard };
},
}),
diff --git a/frontend/src/metabase/api/client/client.ts b/frontend/src/metabase/api/client/client.ts
index 1f7f1ada9c2..59556324143 100644
--- a/frontend/src/metabase/api/client/client.ts
+++ b/frontend/src/metabase/api/client/client.ts
@@ -224,7 +224,8 @@ export class ApiClient extends EventEmitter<EventMap> {
data: options.params ?? {},
body: bodyIsRaw
? undefined
- : (options.body as Record<string, unknown> | undefined),
+ : // Unjustified type cast. FIXME
+ (options.body as Record<string, unknown> | undefined),
});
let body: BodyInit | undefined = undefined;
@@ -239,6 +240,7 @@ export class ApiClient extends EventEmitter<EventMap> {
appendQueryParameters(url, resolvedBody);
}
} else if (bodyIsRaw) {
+ // Unjustified type cast. FIXME
body = options.body as BodyInit;
// Let the browser set Content-Type with the multipart boundary
@@ -268,6 +270,7 @@ export class ApiClient extends EventEmitter<EventMap> {
} & RequestOptions<Raw>,
): Promise<ResponseFor<Raw>> {
const init = await this._prepareRequest(options);
+ // Unjustified type cast. FIXME
return this._send(init, options.retry ?? false) as ResponseFor<Raw>;
}
diff --git a/frontend/src/metabase/api/client/errors.ts b/frontend/src/metabase/api/client/errors.ts
index a097fcd984c..b67a81c1492 100644
--- a/frontend/src/metabase/api/client/errors.ts
+++ b/frontend/src/metabase/api/client/errors.ts
@@ -46,6 +46,7 @@ export function isAbortError(error: unknown): boolean {
return (
typeof error === "object" &&
error !== null &&
+ // Unjustified type cast. FIXME
(error as { name?: unknown }).name === "AbortError"
);
}
diff --git a/frontend/src/metabase/api/client/method.ts b/frontend/src/metabase/api/client/method.ts
index fc17d10b7fe..af01ff9dd3f 100644
--- a/frontend/src/metabase/api/client/method.ts
+++ b/frontend/src/metabase/api/client/method.ts
@@ -8,4 +8,5 @@ const REQUEST_METHODS = new Set<RequestMethod>([
]);
export const isRequestMethod = (method: unknown): method is RequestMethod =>
+ // Unjustified type cast. FIXME
REQUEST_METHODS.has(method as RequestMethod);
diff --git a/frontend/src/metabase/api/client/middleware.unit.spec.ts b/frontend/src/metabase/api/client/middleware.unit.spec.ts
index 60e686ca07a..96a3322694a 100644
--- a/frontend/src/metabase/api/client/middleware.unit.spec.ts
+++ b/frontend/src/metabase/api/client/middleware.unit.spec.ts
@@ -126,6 +126,7 @@ describe("runBeforeRequestHandlers", () => {
return {
...data,
url: data.url + "/step1",
+ // Unjustified type cast. FIXME
data: { ...data.data, value: (data.data.value as number) + 2 },
};
});
@@ -135,6 +136,7 @@ describe("runBeforeRequestHandlers", () => {
return {
...data,
url: data.url + "/step2",
+ // Unjustified type cast. FIXME
data: { ...data.data, value: (data.data.value as number) * 10 },
};
});
@@ -144,6 +146,7 @@ describe("runBeforeRequestHandlers", () => {
return {
...data,
url: data.url + "/step3",
+ // Unjustified type cast. FIXME
data: { ...data.data, value: (data.data.value as number) - 4 },
};
});
diff --git a/frontend/src/metabase/api/client/utils.unit.spec.ts b/frontend/src/metabase/api/client/utils.unit.spec.ts
index e6e22e5a86f..99ce34005f9 100644
--- a/frontend/src/metabase/api/client/utils.unit.spec.ts
+++ b/frontend/src/metabase/api/client/utils.unit.spec.ts
@@ -16,6 +16,7 @@ const mockResponse = ({
json = () => Promise.resolve({}),
text = () => Promise.resolve(""),
}: MockResponseOptions): Response =>
+ // Unjustified type cast. FIXME
({
ok,
status,
diff --git a/frontend/src/metabase/api/geojson.ts b/frontend/src/metabase/api/geojson.ts
index 198b42d5ce3..472a6451544 100644
--- a/frontend/src/metabase/api/geojson.ts
+++ b/frontend/src/metabase/api/geojson.ts
@@ -29,6 +29,7 @@ function assertsValidGeoJson(
throw new Error(t`Invalid custom GeoJSON`);
}
+ // Unjustified type cast. FIXME
const validatedData = rawGeoJsonData as any; // We'll validate the structure step by step
if (!validatedData.type) {
diff --git a/frontend/src/metabase/api/query-endpoints.ts b/frontend/src/metabase/api/query-endpoints.ts
index 955d54704b2..7ea235b6670 100644
--- a/frontend/src/metabase/api/query-endpoints.ts
+++ b/frontend/src/metabase/api/query-endpoints.ts
@@ -81,6 +81,7 @@ export function maybeUsePivotEndpoint<Arg>(
if (!shouldUsePivotEndpoint(card, metadata)) {
return endpoint;
}
+ // Unjustified type cast. FIXME
return (PIVOT_ENDPOINTS.get(endpoint) as QueryEndpoint<Arg>) ?? endpoint;
}
diff --git a/frontend/src/metabase/api/settings.ts b/frontend/src/metabase/api/settings.ts
index c31aa287809..7d4cb88601c 100644
--- a/frontend/src/metabase/api/settings.ts
+++ b/frontend/src/metabase/api/settings.ts
@@ -20,6 +20,7 @@ export const settingsApi = Api.injectEndpoints({
url: "/api/setting",
}),
transformResponse: (response: SettingDefinition[]) =>
+ // Unjustified type cast. FIXME
_.indexBy(response, "key") as SettingDefinitionMap,
providesTags: ["session-properties"],
}),
diff --git a/frontend/src/metabase/api/utils/settings.ts b/frontend/src/metabase/api/utils/settings.ts
index baf8cff5322..07484b3bfba 100644
--- a/frontend/src/metabase/api/utils/settings.ts
+++ b/frontend/src/metabase/api/utils/settings.ts
@@ -90,6 +90,7 @@ export const useAdminSetting = <SettingName extends EnterpriseSettingKey>(
if (response.error) {
const message =
+ // Unjustified type cast. FIXME
(response.error as { data?: { message: string } })?.data?.message ||
t`Error saving settings`;
@@ -106,6 +107,7 @@ export const useAdminSetting = <SettingName extends EnterpriseSettingKey>(
[updateSettings, sendToast],
);
+ // Unjustified type cast. FIXME
const settingValue = settings?.[
settingName
] as EnterpriseSettingValue<SettingName>;
@@ -153,6 +155,7 @@ export const useAdminSettings = <
if (toast) {
if (response.error) {
const message =
+ // Unjustified type cast. FIXME
(response.error as { data?: { message: string } })?.data?.message ||
t`Error saving settings`;
@@ -173,11 +176,13 @@ export const useAdminSettings = <
type Values = { [K in SettingNames[number]]: EnterpriseSettings[K] };
const values = useMemo(() => {
+ // Unjustified type cast. FIXME
return (settings ? _.pick(settings, ...settingNames) : {}) as Values;
}, [settings, settingNames]);
type Details = { [K in SettingNames[number]]: SettingDefinition<K> };
const details = useMemo(() => {
+ // Unjustified type cast. FIXME
return (
settingsDetails ? _.pick(settingsDetails, ...settingNames) : {}
) as Details;
diff --git a/frontend/src/metabase/app-embed-mcp-public-path.unit.spec.ts b/frontend/src/metabase/app-embed-mcp-public-path.unit.spec.ts
index d3cdf7a63c6..ec6aa9ecdf2 100644
--- a/frontend/src/metabase/app-embed-mcp-public-path.unit.spec.ts
+++ b/frontend/src/metabase/app-embed-mcp-public-path.unit.spec.ts
@@ -1,12 +1,15 @@
describe("app-embed-mcp-public-path", () => {
const setRuntimePublicPath = (value: string) => {
+ // Unjustified type cast. FIXME
(globalThis as any).__webpack_public_path__ = value;
};
const getRuntimePublicPath = () =>
+ // Unjustified type cast. FIXME
(globalThis as any).__webpack_public_path__;
const setInstanceUrl = (instanceUrl: string | undefined) => {
+ // Unjustified type cast. FIXME
(window as any).metabaseConfig =
instanceUrl === undefined ? undefined : { instanceUrl };
};
@@ -18,7 +21,9 @@ describe("app-embed-mcp-public-path", () => {
});
afterEach(() => {
+ // Unjustified type cast. FIXME
delete (window as any).metabaseConfig;
+ // Unjustified type cast. FIXME
delete (globalThis as any).__webpack_public_path__;
});
diff --git a/frontend/src/metabase/app/nav/AppBar.tsx b/frontend/src/metabase/app/nav/AppBar.tsx
index afca3036382..824ae919a04 100644
--- a/frontend/src/metabase/app/nav/AppBar.tsx
+++ b/frontend/src/metabase/app/nav/AppBar.tsx
@@ -97,6 +97,7 @@ function AppBarContainerInner(props: AppBarProps & RouterProps) {
dashboardId != null ? { id: dashboardId } : skipToken,
);
+ // Unjustified type cast. FIXME
const locationState = props.location.state as { cardId?: number } | undefined;
const onSearchItemSelect = (result: SearchResult) => {
diff --git a/frontend/src/metabase/app/selectors.unit.spec.ts b/frontend/src/metabase/app/selectors.unit.spec.ts
index 9ae50b0d2f0..86159f13d46 100644
--- a/frontend/src/metabase/app/selectors.unit.spec.ts
+++ b/frontend/src/metabase/app/selectors.unit.spec.ts
@@ -6,6 +6,7 @@ import type { RouterProps } from "metabase/selectors/app";
import { getIsCollectionPathVisible } from "./selectors";
const createLocation = (pathname: string): Location =>
+ // Unjustified type cast. FIXME
({
pathname,
search: "",
diff --git a/frontend/src/metabase/archive/utils.ts b/frontend/src/metabase/archive/utils.ts
index 02dc009408f..9f4c41c511c 100644
--- a/frontend/src/metabase/archive/utils.ts
+++ b/frontend/src/metabase/archive/utils.ts
@@ -39,6 +39,7 @@ function isDashboardQuestion(entity: unknown): entity is {
if (typeof entity !== "object" || entity === null) {
return false;
}
+ // Unjustified type cast. FIXME
const { type, dashboard_id } = entity as {
type?: unknown;
dashboard_id?: unknown;
diff --git a/frontend/src/metabase/browse/metrics/BrowseMetrics.tsx b/frontend/src/metabase/browse/metrics/BrowseMetrics.tsx
index b6ff62ed3dc..c06842da248 100644
--- a/frontend/src/metabase/browse/metrics/BrowseMetrics.tsx
+++ b/frontend/src/metabase/browse/metrics/BrowseMetrics.tsx
@@ -242,6 +242,7 @@ function useFilteredMetrics(metricFilters: MetricFilterSettings) {
const isLoading = hasVerifiedMetrics.isLoading || metricsResult.isLoading;
const error = hasVerifiedMetrics.error || metricsResult.error;
+ // Unjustified type cast. FIXME
const metrics = metricsResult.data?.data as MetricResult[] | undefined;
return {
diff --git a/frontend/src/metabase/browse/metrics/test-utils.ts b/frontend/src/metabase/browse/metrics/test-utils.ts
index a420b268588..859be8e0678 100644
--- a/frontend/src/metabase/browse/metrics/test-utils.ts
+++ b/frontend/src/metabase/browse/metrics/test-utils.ts
@@ -8,11 +8,13 @@ import type { MetricResult, RecentMetric } from "./types";
export const createMockMetricResult = (
metric: Partial<MetricResult> = {},
): MetricResult =>
+ // Unjustified type cast. FIXME
createMockSearchResult({ ...metric, model: "metric" }) as MetricResult;
export const createMockRecentMetric = (
metric: Partial<RecentMetric>,
): RecentMetric =>
+ // Unjustified type cast. FIXME
createMockRecentCollectionItem({
...metric,
model: "metric",
diff --git a/frontend/src/metabase/browse/metrics/tests/setup.tsx b/frontend/src/metabase/browse/metrics/tests/setup.tsx
index cc90862a6b9..7df16d3a713 100644
--- a/frontend/src/metabase/browse/metrics/tests/setup.tsx
+++ b/frontend/src/metabase/browse/metrics/tests/setup.tsx
@@ -242,6 +242,7 @@ export function setup({
const mockMetricResults = mockMetrics.map(createMockMetricResult);
const mockRecentMetrics = mockMetrics.map((metric) =>
+ // Unjustified type cast. FIXME
createMockRecentMetric(metric as RecentMetric),
);
diff --git a/frontend/src/metabase/browse/models/BrowseModels.tsx b/frontend/src/metabase/browse/models/BrowseModels.tsx
index 292a9769629..8a3a055d400 100644
--- a/frontend/src/metabase/browse/models/BrowseModels.tsx
+++ b/frontend/src/metabase/browse/models/BrowseModels.tsx
@@ -218,6 +218,7 @@ function useFilteredModels(modelFilters: ModelFilterSettings) {
},
);
+ // Unjustified type cast. FIXME
const models = modelsResult.data?.data as ModelResult[] | undefined;
const recentsCap = getMaxRecentModelCount(models?.length ?? 0);
diff --git a/frontend/src/metabase/browse/tables/TableBrowser/TableBrowserInner.tsx b/frontend/src/metabase/browse/tables/TableBrowser/TableBrowserInner.tsx
index d963f237d2a..00bcdf3afec 100644
--- a/frontend/src/metabase/browse/tables/TableBrowser/TableBrowserInner.tsx
+++ b/frontend/src/metabase/browse/tables/TableBrowser/TableBrowserInner.tsx
@@ -58,6 +58,7 @@ export const TableBrowserInner = ({
const canEditTables =
!!database &&
isAdmin &&
+ // Unjustified type cast. FIXME
PLUGIN_TABLE_EDITING.isDatabaseTableEditingEnabled(database as Database);
return (
@@ -114,12 +115,14 @@ const TableBrowserItem = ({
to={!isSyncInProgress(table) ? getTableUrl(table, metadata) : ""}
icon="table"
title={table.display_name || table.name}
+ // Unjustified type cast. FIXME
onClick={() => trackTableClick(table.id as ConcreteTableId)}
>
<>
{isLoading && <Loader size="xs" data-testid="loading-indicator" />}
{!isLoading && !isVirtual && (
<TableBrowserItemButtons
+ // Unjustified type cast. FIXME
tableId={table.id as ConcreteTableId}
dbId={dbId}
xraysEnabled={xraysEnabled}
diff --git a/frontend/src/metabase/collections/components/ArchiveCollectionModal/ArchiveCollectionModal.unit.spec.tsx b/frontend/src/metabase/collections/components/ArchiveCollectionModal/ArchiveCollectionModal.unit.spec.tsx
index a4685624e8e..c6e687c5a00 100644
--- a/frontend/src/metabase/collections/components/ArchiveCollectionModal/ArchiveCollectionModal.unit.spec.tsx
+++ b/frontend/src/metabase/collections/components/ArchiveCollectionModal/ArchiveCollectionModal.unit.spec.tsx
@@ -108,6 +108,7 @@ describe("ArchiveCollectionModal", () => {
expect(findArchiveCall()).toBeTruthy();
});
+ // Unjustified type cast. FIXME
expect(JSON.parse(findArchiveCall()?.options?.body as string)).toEqual({
archived: true,
});
diff --git a/frontend/src/metabase/collections/components/CollectionBulkActions/CollectionBulkActions.tsx b/frontend/src/metabase/collections/components/CollectionBulkActions/CollectionBulkActions.tsx
index ac146a56ef0..7b0882720a0 100644
--- a/frontend/src/metabase/collections/components/CollectionBulkActions/CollectionBulkActions.tsx
+++ b/frontend/src/metabase/collections/components/CollectionBulkActions/CollectionBulkActions.tsx
@@ -81,6 +81,7 @@ export const CollectionBulkActions = memo(
Promise.all(
selectedItems
.filter(isMovable)
+ // Unjustified type cast. FIXME
.map((item) => setCollection(item as MovableItem, destination)),
),
);
diff --git a/frontend/src/metabase/collections/components/CollectionHeader/tests/common.unit.spec.tsx b/frontend/src/metabase/collections/components/CollectionHeader/tests/common.unit.spec.tsx
index 417edbee63a..bde608f384a 100644
--- a/frontend/src/metabase/collections/components/CollectionHeader/tests/common.unit.spec.tsx
+++ b/frontend/src/metabase/collections/components/CollectionHeader/tests/common.unit.spec.tsx
@@ -40,6 +40,7 @@ describe("CollectionHeader", () => {
it("should not be able to edit name for the root collection", () => {
const collection = {
+ // Unjustified type cast. FIXME
id: "root" as CollectionId,
name: "Our analytics",
can_write: true,
diff --git a/frontend/src/metabase/collections/components/CollectionHeader/tests/enterprise.unit.spec.tsx b/frontend/src/metabase/collections/components/CollectionHeader/tests/enterprise.unit.spec.tsx
index 62be6be4a94..ef58bdf4cb4 100644
--- a/frontend/src/metabase/collections/components/CollectionHeader/tests/enterprise.unit.spec.tsx
+++ b/frontend/src/metabase/collections/components/CollectionHeader/tests/enterprise.unit.spec.tsx
@@ -10,6 +10,7 @@ describe("Instance Analytics Collection Header", () => {
const defaultOptions = {
collection: {
name: "Usage Analytics",
+ // Unjustified type cast. FIXME
type: "instance-analytics" as CollectionType,
can_write: false,
},
diff --git a/frontend/src/metabase/collections/components/ModelUploadModal.tsx b/frontend/src/metabase/collections/components/ModelUploadModal.tsx
index b2b9d9de398..00404ca3cca 100644
--- a/frontend/src/metabase/collections/components/ModelUploadModal.tsx
+++ b/frontend/src/metabase/collections/components/ModelUploadModal.tsx
@@ -63,6 +63,7 @@ export function ModelUploadModal({
return onUpload({
tableId: Number(tableId),
+ // Unjustified type cast. FIXME
modelId: modelForTableId?.id as number,
uploadMode: uploadMode,
});
@@ -110,6 +111,7 @@ export function ModelUploadModal({
</Text>
<Radio.Group
value={uploadMode}
+ // Unjustified type cast. FIXME
onChange={(val) => setUploadMode(val as UploadMode)}
pl="1px"
>
diff --git a/frontend/src/metabase/collections/containers/CollectionHeader/CollectionHeader.tsx b/frontend/src/metabase/collections/containers/CollectionHeader/CollectionHeader.tsx
index 1c74616016c..acc0bfd9deb 100644
--- a/frontend/src/metabase/collections/containers/CollectionHeader/CollectionHeader.tsx
+++ b/frontend/src/metabase/collections/containers/CollectionHeader/CollectionHeader.tsx
@@ -7,6 +7,7 @@ import CollectionHeader from "../../components/CollectionHeader";
const mapDispatchToProps = {
onUpdateCollection: (collection: Collection, values: Partial<Collection>) =>
+ // Unjustified type cast. FIXME
collectionApi.endpoints.updateCollection.initiate({
id: collection.id,
...values,
diff --git a/frontend/src/metabase/comments/components/CommentEditor/CommentEditor.tsx b/frontend/src/metabase/comments/components/CommentEditor/CommentEditor.tsx
index d31607aa336..bf47ec70886 100644
--- a/frontend/src/metabase/comments/components/CommentEditor/CommentEditor.tsx
+++ b/frontend/src/metabase/comments/components/CommentEditor/CommentEditor.tsx
@@ -121,11 +121,13 @@ export const CommentEditor = ({
const doc = editor.getText();
setContent(doc);
if (onChange) {
+ // Unjustified type cast. FIXME
onChange(editor.getJSON() as DocumentContent);
}
},
onBlur: ({ editor }) => {
if (onBlur) {
+ // Unjustified type cast. FIXME
onBlur(editor.getJSON() as DocumentContent, editor);
}
},
@@ -144,6 +146,7 @@ export const CommentEditor = ({
}
const submitDoc = () => {
+ // Unjustified type cast. FIXME
const content = editor.getJSON() as DocumentContent;
const isEmpty = editor.isEmpty;
diff --git a/frontend/src/metabase/common/collections/components/ActionMenu/ActionMenu.tsx b/frontend/src/metabase/common/collections/components/ActionMenu/ActionMenu.tsx
index 677e503cc2f..f58a8d32e19 100644
--- a/frontend/src/metabase/common/collections/components/ActionMenu/ActionMenu.tsx
+++ b/frontend/src/metabase/common/collections/components/ActionMenu/ActionMenu.tsx
@@ -123,6 +123,7 @@ function ActionMenu({
}, [item, onMove]);
const handleArchive = useCallback(
+ // Unjustified type cast. FIXME
() => archive(item as ArchivableItem, true),
[archive, item],
);
diff --git a/frontend/src/metabase/common/collections/components/ActionMenu/ActionMenu.unit.spec.tsx b/frontend/src/metabase/common/collections/components/ActionMenu/ActionMenu.unit.spec.tsx
index 18c2546e322..a34a46720b2 100644
--- a/frontend/src/metabase/common/collections/components/ActionMenu/ActionMenu.unit.spec.tsx
+++ b/frontend/src/metabase/common/collections/components/ActionMenu/ActionMenu.unit.spec.tsx
@@ -95,6 +95,7 @@ describe("ActionMenu", () => {
`path:/api/card/${item.id}`,
{ method: "PUT" },
);
+ // Unjustified type cast. FIXME
expect(JSON.parse(call?.options.body as string)).toEqual({
collection_preview: false,
});
@@ -155,6 +156,7 @@ describe("ActionMenu", () => {
`path:/api/card/${item.id}`,
{ method: "PUT" },
);
+ // Unjustified type cast. FIXME
expect(JSON.parse(call?.options.body as string)).toEqual({
collection_preview: true,
});
@@ -216,6 +218,7 @@ describe("ActionMenu", () => {
expect(calls).toHaveLength(1);
const [putCall] = calls;
expect(putCall.options.method).toBe("PUT");
+ // Unjustified type cast. FIXME
expect(JSON.parse(putCall.options.body as string)).toMatchObject({
archived: true,
});
@@ -330,6 +333,7 @@ describe("ActionMenu", () => {
const [putCall] = fetchMock.callHistory.calls("path:/api/document/7", {
method: "PUT",
});
+ // Unjustified type cast. FIXME
expect(JSON.parse(putCall.options.body as string)).toMatchObject({
archived: false,
});
diff --git a/frontend/src/metabase/common/collections/components/CollectionRowMenu/EditCollectionModal/EditCollectionModal.unit.spec.tsx b/frontend/src/metabase/common/collections/components/CollectionRowMenu/EditCollectionModal/EditCollectionModal.unit.spec.tsx
index b4e5b370f78..261fc684fb7 100644
--- a/frontend/src/metabase/common/collections/components/CollectionRowMenu/EditCollectionModal/EditCollectionModal.unit.spec.tsx
+++ b/frontend/src/metabase/common/collections/components/CollectionRowMenu/EditCollectionModal/EditCollectionModal.unit.spec.tsx
@@ -32,6 +32,7 @@ function setup(collection: Collection | CollectionItem) {
const onClose = jest.fn();
const onSave = jest.fn();
+ // Unjustified type cast. FIXME
setupUpdateCollectionEndpoint(collection as Collection);
setupCollectionByIdEndpoint({
collections: [parentCollection, itemParentCollection],
@@ -94,6 +95,7 @@ describe("EditCollectionModal", () => {
id: 2,
model: "collection",
name: "Collection item",
+ // Unjustified type cast. FIXME
collection_id: itemParentCollection.id as number,
});
const { onSave } = setup(collectionItem);
diff --git a/frontend/src/metabase/common/collections/components/PinnedItemCard/PinnedItemCard.styled.tsx b/frontend/src/metabase/common/collections/components/PinnedItemCard/PinnedItemCard.styled.tsx
index b5061132846..c71b120b99b 100644
--- a/frontend/src/metabase/common/collections/components/PinnedItemCard/PinnedItemCard.styled.tsx
+++ b/frontend/src/metabase/common/collections/components/PinnedItemCard/PinnedItemCard.styled.tsx
@@ -20,6 +20,7 @@ export const ItemLink = styled(RawMaybeLink)<{ to?: string }>`
`}
`;
+// Unjustified type cast. FIXME
export const ActionsContainer = styled(Box)<BoxProps>`
display: flex;
align-items: center;
diff --git a/frontend/src/metabase/common/collections/components/PinnedItemCard/PinnedItemCard.tsx b/frontend/src/metabase/common/collections/components/PinnedItemCard/PinnedItemCard.tsx
index 5f86f66c866..d2f6d1102ba 100644
--- a/frontend/src/metabase/common/collections/components/PinnedItemCard/PinnedItemCard.tsx
+++ b/frontend/src/metabase/common/collections/components/PinnedItemCard/PinnedItemCard.tsx
@@ -106,6 +106,7 @@ function PinnedItemCard({
event: MouseEvent<HTMLDivElement>,
setterFn: Dispatch<SetStateAction<boolean>>,
) => {
+ // Unjustified type cast. FIXME
const target = event.target as HTMLDivElement;
const isTargetElWiderThanCard = target?.scrollWidth > target?.clientWidth;
if (isTargetElWiderThanCard) {
diff --git a/frontend/src/metabase/common/collections/components/PinnedItemCard/PinnedItemCard.unit.spec.tsx b/frontend/src/metabase/common/collections/components/PinnedItemCard/PinnedItemCard.unit.spec.tsx
index b71057f404f..77b75dc4121 100644
--- a/frontend/src/metabase/common/collections/components/PinnedItemCard/PinnedItemCard.unit.spec.tsx
+++ b/frontend/src/metabase/common/collections/components/PinnedItemCard/PinnedItemCard.unit.spec.tsx
@@ -56,6 +56,7 @@ const getCollectionItem = ({
description?: string;
collection_position?: number;
} = {}): CollectionItem & { description: string } => {
+ // Unjustified type cast. FIXME
return createMockCollectionItem({
...rest,
id,
diff --git a/frontend/src/metabase/common/collections/constants.ts b/frontend/src/metabase/common/collections/constants.ts
index 3ad2902a520..cb50701ba18 100644
--- a/frontend/src/metabase/common/collections/constants.ts
+++ b/frontend/src/metabase/common/collections/constants.ts
@@ -3,6 +3,7 @@ import { t } from "ttag";
import type { CollectionId } from "metabase-types/api";
export const ROOT_COLLECTION = {
+ // Unjustified type cast. FIXME
id: "root" as CollectionId,
get name() {
return t`Our analytics`;
@@ -25,6 +26,7 @@ export const PERSONAL_COLLECTION = {
// fake collection for admins that contains all other user's collections
export const PERSONAL_COLLECTIONS = {
+ // Unjustified type cast. FIXME
id: "personal" as CollectionId,
get name() {
return t`All personal collections`;
diff --git a/frontend/src/metabase/common/collections/dropzone.unit.spec.ts b/frontend/src/metabase/common/collections/dropzone.unit.spec.ts
index 0cf7127ccf9..1d109b4b888 100644
--- a/frontend/src/metabase/common/collections/dropzone.unit.spec.ts
+++ b/frontend/src/metabase/common/collections/dropzone.unit.spec.ts
@@ -4,12 +4,14 @@ import type { DropzoneRootProps } from "react-dropzone";
import { composeFileEventHandler, getComposedDragProps } from "./dropzone";
describe("Collections > containers > utils", () => {
+ // Unjustified type cast. FIXME
const testNonFileEvent = {
dataTransfer: {
types: ["text/plain"],
},
} as unknown as DragEvent<HTMLElement>;
+ // Unjustified type cast. FIXME
const testFileEvent = {
dataTransfer: {
types: ["Files"],
@@ -21,6 +23,7 @@ describe("Collections > containers > utils", () => {
const dragEventSpy = jest.fn();
const nonDragEventSpy = jest.fn();
+ // Unjustified type cast. FIXME
const mockProps = {
onDragEnter: dragEventSpy,
onDragLeave: dragEventSpy,
diff --git a/frontend/src/metabase/common/collections/hooks.ts b/frontend/src/metabase/common/collections/hooks.ts
index 3854fce017c..ec9278e1687 100644
--- a/frontend/src/metabase/common/collections/hooks.ts
+++ b/frontend/src/metabase/common/collections/hooks.ts
@@ -41,6 +41,7 @@ export function useInitialCollectionId({
collectionIdParam(idFromSlug),
);
+ // Unjustified type cast. FIXME
const idFromQuery = location?.query?.collectionId as
| Collection["id"]
| undefined;
diff --git a/frontend/src/metabase/common/collections/utils.ts b/frontend/src/metabase/common/collections/utils.ts
index d09b2e6ff06..d7dec76a60a 100644
--- a/frontend/src/metabase/common/collections/utils.ts
+++ b/frontend/src/metabase/common/collections/utils.ts
@@ -269,6 +269,7 @@ export function canArchiveItem(item: CollectionItem, collection?: Collection) {
isItemCollection(item) &&
(isRootPersonalCollection(item) || isDedicatedTenantCollectionRoot(item))
) &&
+ // Unjustified type cast. FIXME
!isLibraryCollection(item as Pick<Collection, "type">) &&
item.model !== "table" &&
!item.archived
diff --git a/frontend/src/metabase/common/collections/utils.unit.spec.ts b/frontend/src/metabase/common/collections/utils.unit.spec.ts
index ce4e87a6735..c2ae48f8e49 100644
--- a/frontend/src/metabase/common/collections/utils.unit.spec.ts
+++ b/frontend/src/metabase/common/collections/utils.unit.spec.ts
@@ -269,7 +269,9 @@ describe("Collections > utils", () => {
describe("root collection forms", () => {
it.each([
+ // Unjustified type cast. FIXME
["id is null", { id: null as never }],
+ // Unjustified type cast. FIXME
["id is undefined", { id: undefined as never }],
['id is "root"', { id: "root" as const }],
])("returns ROOT_COLLECTION when %s", (_label, override) => {
@@ -328,6 +330,7 @@ describe("Collections > utils", () => {
(model) => {
const collection = createMockCollection({ id: 99, name: "Library" });
const result = createMockSearchResult({ model, collection });
+ // Unjustified type cast. FIXME
expect(normalizedCollection(result.collection as Collection)).toEqual(
collection,
);
@@ -341,6 +344,7 @@ describe("Collections > utils", () => {
model,
collection: createMockCollection({ id: "root" as const }),
});
+ // Unjustified type cast. FIXME
expect(normalizedCollection(result.collection as Collection)).toBe(
ROOT_COLLECTION,
);
diff --git a/frontend/src/metabase/common/components/AccordionList/AccordionList.tsx b/frontend/src/metabase/common/components/AccordionList/AccordionList.tsx
index 91ac9377d57..8ea821233b2 100644
--- a/frontend/src/metabase/common/components/AccordionList/AccordionList.tsx
+++ b/frontend/src/metabase/common/components/AccordionList/AccordionList.tsx
@@ -376,6 +376,7 @@ export class AccordionList<
if (isSearching && isEmpty) {
rows.unshift({
type: "no-results",
+ // Unjustified type cast. FIXME
section: {} as TSection,
sectionIndex: 0,
isLastSection: false,
@@ -384,6 +385,7 @@ export class AccordionList<
rows.unshift({
type: "search",
+ // Unjustified type cast. FIXME
section: {} as TSection,
sectionIndex: 0,
isLastSection: false,
diff --git a/frontend/src/metabase/common/components/AccordionList/utils.ts b/frontend/src/metabase/common/components/AccordionList/utils.ts
index 175d360aac5..9ee4ae3d420 100644
--- a/frontend/src/metabase/common/components/AccordionList/utils.ts
+++ b/frontend/src/metabase/common/components/AccordionList/utils.ts
@@ -160,6 +160,7 @@ export function searchFilter<
>({
sections,
searchText,
+ // Unjustified type cast. FIXME
searchProp = ["name", "displayName"] as unknown as SearchProps<TItem>,
}: FilterOptions<TItem, TSection>) {
const strategy = searchStrategy({
diff --git a/frontend/src/metabase/common/components/AutocompleteInput/AutocompleteInput.tsx b/frontend/src/metabase/common/components/AutocompleteInput/AutocompleteInput.tsx
index 5be48dd6697..f33945204ec 100644
--- a/frontend/src/metabase/common/components/AutocompleteInput/AutocompleteInput.tsx
+++ b/frontend/src/metabase/common/components/AutocompleteInput/AutocompleteInput.tsx
@@ -60,6 +60,7 @@ export const AutocompleteInput = ({
});
const handleListMouseDown = (event: React.MouseEvent<HTMLElement>) => {
+ // Unjustified type cast. FIXME
if (optionsListRef.current?.contains(event.target as Node)) {
event.preventDefault();
// also stops the native event before it reaches document, where the
diff --git a/frontend/src/metabase/common/components/BulkActionBar/BulkActionBar.styled.tsx b/frontend/src/metabase/common/components/BulkActionBar/BulkActionBar.styled.tsx
index f2d62deea9b..d02b36dab37 100644
--- a/frontend/src/metabase/common/components/BulkActionBar/BulkActionBar.styled.tsx
+++ b/frontend/src/metabase/common/components/BulkActionBar/BulkActionBar.styled.tsx
@@ -15,6 +15,7 @@ export const BulkActionsToast = styled.div<{ isNavbarOpen: boolean }>`
z-index: 150;
`;
+// Unjustified type cast. FIXME
export const ToastCard = styled(Card)`
background-color: var(--mb-color-background_page-primary-inverse);
color: var(--mb-color-text-primary-inverse);
diff --git a/frontend/src/metabase/common/components/CollapseSection/CollapseSection.styled.tsx b/frontend/src/metabase/common/components/CollapseSection/CollapseSection.styled.tsx
index 3986fda975c..1cacca29b6a 100644
--- a/frontend/src/metabase/common/components/CollapseSection/CollapseSection.styled.tsx
+++ b/frontend/src/metabase/common/components/CollapseSection/CollapseSection.styled.tsx
@@ -66,6 +66,7 @@ export const ToggleIcon = styled(
}: ToggleIconProps & Omit<IconProps, "name">) => {
const { collapsed, expanded } = ICON_VARIANTS[variant];
const name = isExpanded ? expanded : collapsed;
+ // Unjustified type cast. FIXME
return <Icon name={name as IconName} size={size} {...props} />;
},
)`
diff --git a/frontend/src/metabase/common/components/ColorRangeSelector/ColorRangePopover.tsx b/frontend/src/metabase/common/components/ColorRangeSelector/ColorRangePopover.tsx
index 6630301e7e0..1bbd736489d 100644
--- a/frontend/src/metabase/common/components/ColorRangeSelector/ColorRangePopover.tsx
+++ b/frontend/src/metabase/common/components/ColorRangeSelector/ColorRangePopover.tsx
@@ -144,6 +144,7 @@ const getDefaultColor = (
} else {
return selection;
}
+ // Unjustified type cast. FIXME
}, "" as string);
};
diff --git a/frontend/src/metabase/common/components/CopyTextInput/CopyTextInput.tsx b/frontend/src/metabase/common/components/CopyTextInput/CopyTextInput.tsx
index 0af4af46e59..964389df97c 100644
--- a/frontend/src/metabase/common/components/CopyTextInput/CopyTextInput.tsx
+++ b/frontend/src/metabase/common/components/CopyTextInput/CopyTextInput.tsx
@@ -39,6 +39,7 @@ export const CopyTextInput = forwardRef(function CopyTextInput(
}}
classNames={{
...classNames,
+ // Unjustified type cast. FIXME
input: cx(S.input, (classNames as Record<string, string>)?.input),
}}
rightSectionPointerEvents="all"
diff --git a/frontend/src/metabase/common/components/DatabaseMultiSelect/DatabaseMultiSelect.stories.tsx b/frontend/src/metabase/common/components/DatabaseMultiSelect/DatabaseMultiSelect.stories.tsx
index a548e8fc1ab..442c7bfcde0 100644
--- a/frontend/src/metabase/common/components/DatabaseMultiSelect/DatabaseMultiSelect.stories.tsx
+++ b/frontend/src/metabase/common/components/DatabaseMultiSelect/DatabaseMultiSelect.stories.tsx
@@ -29,6 +29,7 @@ const storeInitialState = createMockState({
entities: createMockEntitiesState({}),
});
+// Unjustified type cast. FIXME
const store = getCommonStore(storeInitialState) as unknown as Store<State>;
const ReduxDecorator = (Story: StoryFn) => {
diff --git a/frontend/src/metabase/common/components/DebouncedFrame/DebouncedFrame.tsx b/frontend/src/metabase/common/components/DebouncedFrame/DebouncedFrame.tsx
index bb1f7db5ca5..b043f7ff05e 100644
--- a/frontend/src/metabase/common/components/DebouncedFrame/DebouncedFrame.tsx
+++ b/frontend/src/metabase/common/components/DebouncedFrame/DebouncedFrame.tsx
@@ -134,6 +134,7 @@ class DebouncedFrameInner extends Component<
if (typeof forwardedRef === "function") {
forwardedRef(r);
} else {
+ // Unjustified type cast. FIXME
(
forwardedRef as React.MutableRefObject<HTMLDivElement | null>
).current = r;
@@ -171,4 +172,5 @@ const DebouncedFrameForwardRef = forwardRef<
export const DebouncedFrame = ExplicitSize<DebouncedFrameInnerProps>({
// Disable ExplicitSize's debounce/throttle since DebouncedFrame has a built-in debounce
refreshMode: "none",
+ // Unjustified type cast. FIXME
})(DebouncedFrameForwardRef as any);
diff --git a/frontend/src/metabase/common/components/EditableText/EditableText.tsx b/frontend/src/metabase/common/components/EditableText/EditableText.tsx
index 5d49037fe0d..250158a254a 100644
--- a/frontend/src/metabase/common/components/EditableText/EditableText.tsx
+++ b/frontend/src/metabase/common/components/EditableText/EditableText.tsx
@@ -146,11 +146,13 @@ const EditableTextInner = forwardRef(function EditableText(
// For a11y, allow typing to activate the textarea
onKeyDown={(e: React.KeyboardEvent) => {
if (shouldPassKeyToTextarea(e.key)) {
+ // Unjustified type cast. FIXME
(e.currentTarget as HTMLTextAreaElement).click();
}
}}
onKeyUp={(e: React.KeyboardEvent) => {
if (!shouldPassKeyToTextarea(e.key)) {
+ // Unjustified type cast. FIXME
(e.currentTarget as HTMLTextAreaElement).click();
}
}}
diff --git a/frontend/src/metabase/common/components/EmojiPicker/EmojiPicker.tsx b/frontend/src/metabase/common/components/EmojiPicker/EmojiPicker.tsx
index 72166ef44a9..af81b5bfa6b 100644
--- a/frontend/src/metabase/common/components/EmojiPicker/EmojiPicker.tsx
+++ b/frontend/src/metabase/common/components/EmojiPicker/EmojiPicker.tsx
@@ -104,6 +104,7 @@ function Emoji({
component="button"
w="2rem"
fz="1.25rem"
+ // Unjustified type cast. FIXME
ref={ref as React.RefObject<HTMLButtonElement>}
data-emoji={emoji.emoji}
styles={{
diff --git a/frontend/src/metabase/common/components/EntityIcon/EntityIcon.tsx b/frontend/src/metabase/common/components/EntityIcon/EntityIcon.tsx
index e224aa1773e..6dd1f1255e3 100644
--- a/frontend/src/metabase/common/components/EntityIcon/EntityIcon.tsx
+++ b/frontend/src/metabase/common/components/EntityIcon/EntityIcon.tsx
@@ -61,6 +61,7 @@ export function EntityIcon({
maskRepeat: "no-repeat",
maskPosition: "center",
}}
+ // Unjustified type cast. FIXME
{...(rest as HTMLAttributes<HTMLSpanElement>)}
/>
);
diff --git a/frontend/src/metabase/common/components/ErrorPages/use-error-info.ts b/frontend/src/metabase/common/components/ErrorPages/use-error-info.ts
index f9a0aeda8ec..e9707a80219 100644
--- a/frontend/src/metabase/common/components/ErrorPages/use-error-info.ts
+++ b/frontend/src/metabase/common/components/ErrorPages/use-error-info.ts
@@ -42,6 +42,7 @@ export const useErrorInfo = (
/(question|model|dashboard|collection|metric)[[\/\#]([\d\w]+)/,
);
+ // Unjustified type cast. FIXME
const entity = (matches?.[1] ?? undefined) as
| ReportableEntityName
| undefined;
diff --git a/frontend/src/metabase/common/components/ExplicitSize/ExplicitSize.tsx b/frontend/src/metabase/common/components/ExplicitSize/ExplicitSize.tsx
index 2eabf4db919..a43ddf0326c 100644
--- a/frontend/src/metabase/common/components/ExplicitSize/ExplicitSize.tsx
+++ b/frontend/src/metabase/common/components/ExplicitSize/ExplicitSize.tsx
@@ -143,6 +143,7 @@ export function ExplicitSize<T>({
_getRefreshMode = () => {
if (this.context) {
+ // Unjustified type cast. FIXME
return this.context as RefreshMode;
}
@@ -302,6 +303,7 @@ export function ExplicitSize<T>({
<ComposedComponent
ref={forwardedRef}
style={{ position: "absolute", top: 0, left: 0, width, height }}
+ // Unjustified type cast. FIXME
{...(rest as unknown as T)}
{...this.state}
/>
@@ -311,6 +313,7 @@ export function ExplicitSize<T>({
return (
<ComposedComponent
ref={this._setElementRef}
+ // Unjustified type cast. FIXME
{...(props as unknown as T)}
{...this.state}
/>
@@ -322,6 +325,7 @@ export function ExplicitSize<T>({
return React.forwardRef<
unknown,
PropsWithoutRef<ExplicitSizeOuterProps<T>>
+ // Unjustified type cast. FIXME
>((props, ref) => (
<WrappedComponent {...(props as T & InnerProps)} forwardedRef={ref} />
));
diff --git a/frontend/src/metabase/common/components/ExplicitSize/ExplicitSize.unit.spec.tsx b/frontend/src/metabase/common/components/ExplicitSize/ExplicitSize.unit.spec.tsx
index 3fc7dd15bc2..d12747183cf 100644
--- a/frontend/src/metabase/common/components/ExplicitSize/ExplicitSize.unit.spec.tsx
+++ b/frontend/src/metabase/common/components/ExplicitSize/ExplicitSize.unit.spec.tsx
@@ -35,6 +35,7 @@ const triggerResize = (
entry: Partial<ResizeObserverEntry>,
) => {
act(() => {
+ // Unjustified type cast. FIXME
(
resizeObserver as unknown as {
_trigger: (
@@ -95,6 +96,7 @@ const createEntry = (
inlineSize: number,
blockSize: number,
): Partial<ResizeObserverEntry> =>
+ // Unjustified type cast. FIXME
({
target,
borderBoxSize: [{ inlineSize, blockSize }],
@@ -175,6 +177,7 @@ describe("ExplicitSize", () => {
// so stub a real size — there is no resize event to supply one.
rerender(<ConditionalSizedComponent hasContent={true} />);
const element = screen.getByTestId("sized");
+ // Unjustified type cast. FIXME
jest.spyOn(element, "getBoundingClientRect").mockReturnValue({
width: 400,
height: 300,
diff --git a/frontend/src/metabase/common/components/Glossary/GlossaryTable.tsx b/frontend/src/metabase/common/components/Glossary/GlossaryTable.tsx
index 2803b7de450..e0218c1055c 100644
--- a/frontend/src/metabase/common/components/Glossary/GlossaryTable.tsx
+++ b/frontend/src/metabase/common/components/Glossary/GlossaryTable.tsx
@@ -134,6 +134,7 @@ export function GlossaryTable({
sortColumnName={sortColumnName}
sortDirection={sortDirection}
onSort={(column, dir) => {
+ // Unjustified type cast. FIXME
setSortColumnName(column as keyof GlossaryItem);
setSortDirection(dir);
}}
@@ -156,6 +157,7 @@ export function GlossaryTable({
);
}
+ // Unjustified type cast. FIXME
const item = row as GlossaryItem;
const isEditing = editingId === item.id;
diff --git a/frontend/src/metabase/common/components/Glossary/GlossaryTable.unit.spec.tsx b/frontend/src/metabase/common/components/Glossary/GlossaryTable.unit.spec.tsx
index 85eb513f819..07cc93133c6 100644
--- a/frontend/src/metabase/common/components/Glossary/GlossaryTable.unit.spec.tsx
+++ b/frontend/src/metabase/common/components/Glossary/GlossaryTable.unit.spec.tsx
@@ -55,6 +55,7 @@ describe("GlossaryTable", () => {
within(r).queryByPlaceholderText(/boat/i),
);
expect(createRow0).toBeTruthy();
+ // Unjustified type cast. FIXME
const saveInCreate = within(createRow0 as HTMLElement).getByRole("button", {
name: /save/i,
});
@@ -197,6 +198,7 @@ describe("GlossaryTable", () => {
const rows = within(table).getAllByRole("row");
const row = rows.find((r) => within(r).queryByText("DeleteMe"));
expect(row).toBeTruthy();
+ // Unjustified type cast. FIXME
await user.hover(row as HTMLElement);
await user.click(screen.getByRole("button", { name: /delete/i }));
@@ -230,6 +232,7 @@ describe("GlossaryTable", () => {
within(r).queryByPlaceholderText(/boat/i),
);
expect(createRow).toBeTruthy();
+ // Unjustified type cast. FIXME
const saveBtn = within(createRow as HTMLElement).getByRole("button", {
name: /save/i,
});
diff --git a/frontend/src/metabase/common/components/ItemsTable/utils.ts b/frontend/src/metabase/common/components/ItemsTable/utils.ts
index 74d8c3aeb29..017d2ff4440 100644
--- a/frontend/src/metabase/common/components/ItemsTable/utils.ts
+++ b/frontend/src/metabase/common/components/ItemsTable/utils.ts
@@ -27,6 +27,7 @@ export const getVisibleColumnsMap = (
visibleColumns.reduce((result, item) => {
result[item] = true;
return result;
+ // Unjustified type cast. FIXME
}, {} as CollectionContentTableColumnsMap);
export const canSelectItems = (
diff --git a/frontend/src/metabase/common/components/MultiContainerDraggableContext/MultiContainerDraggableContext.tsx b/frontend/src/metabase/common/components/MultiContainerDraggableContext/MultiContainerDraggableContext.tsx
index f7f1173b628..13d658dace7 100644
--- a/frontend/src/metabase/common/components/MultiContainerDraggableContext/MultiContainerDraggableContext.tsx
+++ b/frontend/src/metabase/common/components/MultiContainerDraggableContext/MultiContainerDraggableContext.tsx
@@ -24,6 +24,7 @@ export function findContainer<
return (
Object.keys(items).find((key) =>
+ // Unjustified type cast. FIXME
items[key as keyof typeof items].includes(id),
) ?? null
);
diff --git a/frontend/src/metabase/common/components/OnboardingStepper/hooks/use-scroll-step-into-view.ts b/frontend/src/metabase/common/components/OnboardingStepper/hooks/use-scroll-step-into-view.ts
index 4c410157740..a77c1d2ca34 100644
--- a/frontend/src/metabase/common/components/OnboardingStepper/hooks/use-scroll-step-into-view.ts
+++ b/frontend/src/metabase/common/components/OnboardingStepper/hooks/use-scroll-step-into-view.ts
@@ -18,6 +18,7 @@ export function useScrollStepIntoView(
refs[stepId] = createRef<HTMLDivElement>();
return refs;
},
+ // Unjustified type cast. FIXME
{} as Record<string, React.RefObject<HTMLDivElement>>,
);
}, [stepIds]);
diff --git a/frontend/src/metabase/common/components/Pickers/AddToDashSelectDashModal/AddToDashSelectDashModal.unit.spec.tsx b/frontend/src/metabase/common/components/Pickers/AddToDashSelectDashModal/AddToDashSelectDashModal.unit.spec.tsx
index 4c91ef9b795..2907d52362c 100644
--- a/frontend/src/metabase/common/components/Pickers/AddToDashSelectDashModal/AddToDashSelectDashModal.unit.spec.tsx
+++ b/frontend/src/metabase/common/components/Pickers/AddToDashSelectDashModal/AddToDashSelectDashModal.unit.spec.tsx
@@ -125,6 +125,7 @@ const CARD_IN_PUBLIC_SUBCOLLECTION = createMockCard({
id: getNextId(),
name: "Model Uno",
type: "model",
+ // Unjustified type cast. FIXME
collection_id: SUBCOLLECTION.id as number,
collection: SUBCOLLECTION,
});
@@ -134,6 +135,7 @@ const CARD_IN_PERSONAL_COLLECTION = createMockCard({
name: "Card in a personal collection",
type: "model",
collection: PERSONAL_COLLECTION,
+ // Unjustified type cast. FIXME
collection_id: PERSONAL_COLLECTION.id as number,
});
@@ -162,6 +164,7 @@ const dashboardInPublicSubcollection = createMockDashboard({
id: getNextId(),
name: "Dashboard in public subcollection",
collection: SUBCOLLECTION,
+ // Unjustified type cast. FIXME
collection_id: SUBCOLLECTION.id as number,
model: "dashboard",
});
@@ -170,6 +173,7 @@ const dashboardInPersonalSubcollection = createMockDashboard({
id: getNextId(),
name: "Dashboard in personal subcollection",
collection: PERSONAL_SUBCOLLECTION,
+ // Unjustified type cast. FIXME
collection_id: PERSONAL_SUBCOLLECTION.id as number,
model: "dashboard",
});
@@ -177,6 +181,7 @@ const dashboardInPersonalSubcollection = createMockDashboard({
const dashboardInPersonalCollection = createMockDashboard({
id: getNextId(),
name: "Dashboard in personal collection",
+ // Unjustified type cast. FIXME
collection_id: PERSONAL_COLLECTION.id as number,
model: "dashboard",
});
@@ -247,7 +252,9 @@ const setup = async ({
.map((c) =>
createMockCollectionItem({
...c,
+ // Unjustified type cast. FIXME
id: c.id as number,
+ // Unjustified type cast. FIXME
entity_id: c.entity_id as BaseEntityId,
effective_location: c.location || "/",
location: c.location || "/",
@@ -266,6 +273,7 @@ const setup = async ({
.map((d) =>
createMockCollectionItem({
...d,
+ // Unjustified type cast. FIXME
id: d.id as number,
model: "dashboard",
}),
diff --git a/frontend/src/metabase/common/components/Pickers/EntityPicker/components/ItemLists/DbItemList.tsx b/frontend/src/metabase/common/components/Pickers/EntityPicker/components/ItemLists/DbItemList.tsx
index 8c50b21e516..fa8c02099a7 100644
--- a/frontend/src/metabase/common/components/Pickers/EntityPicker/components/ItemLists/DbItemList.tsx
+++ b/frontend/src/metabase/common/components/Pickers/EntityPicker/components/ItemLists/DbItemList.tsx
@@ -55,6 +55,7 @@ const useGetDbItemListData = (
.with({ model: "database" }, () => Number(parentItem.id))
.with(
{ model: "schema" },
+ // Unjustified type cast. FIXME
() => (parentItem as OmniPickerSchemaItem).database_id,
)
.otherwise(() => undefined);
diff --git a/frontend/src/metabase/common/components/Pickers/EntityPicker/components/ItemLists/SearchResults.tsx b/frontend/src/metabase/common/components/Pickers/EntityPicker/components/ItemLists/SearchResults.tsx
index 72495cc1350..7c67893653a 100644
--- a/frontend/src/metabase/common/components/Pickers/EntityPicker/components/ItemLists/SearchResults.tsx
+++ b/frontend/src/metabase/common/components/Pickers/EntityPicker/components/ItemLists/SearchResults.tsx
@@ -253,6 +253,7 @@ export function SearchScopeSelector() {
<Text>{t`Where to search:`}</Text>
<SegmentedControl
value={searchScope ? String(searchScope) : "all"}
+ // Unjustified type cast. FIXME
onChange={(newValue) => setSearchScope(newValue as SearchScope)}
data={options}
/>
diff --git a/frontend/src/metabase/common/components/Pickers/EntityPicker/components/ItemLists/SearchResultsItemList.tsx b/frontend/src/metabase/common/components/Pickers/EntityPicker/components/ItemLists/SearchResultsItemList.tsx
index 4529523d000..ee438b0fc21 100644
--- a/frontend/src/metabase/common/components/Pickers/EntityPicker/components/ItemLists/SearchResultsItemList.tsx
+++ b/frontend/src/metabase/common/components/Pickers/EntityPicker/components/ItemLists/SearchResultsItemList.tsx
@@ -32,10 +32,12 @@ const makeIntoPickerItem = (
...pick(item, ["id", "name", "collection", "database_id"]),
model: "table",
database_name: item.database_name ?? undefined,
+ // Unjustified type cast. FIXME
schema: item.table_schema as SchemaName,
};
}
+ // Unjustified type cast. FIXME
return {
...item,
type: "type" in item ? item.type : item.collection_type,
@@ -65,7 +67,9 @@ const useApiSearch = ({
searchModels: ["table" as const],
};
}
+ // Unjustified type cast. FIXME
const searchModels = models.filter((model) =>
+ // Unjustified type cast. FIXME
SEARCH_MODELS.includes(model as SearchModel),
) as SearchModel[];
if (searchScope === "all") {
diff --git a/frontend/src/metabase/common/components/Pickers/EntityPicker/components/test/EntityPickerModal.unit.spec.tsx b/frontend/src/metabase/common/components/Pickers/EntityPicker/components/test/EntityPickerModal.unit.spec.tsx
index 7aafe706aa4..144c3d3327f 100644
--- a/frontend/src/metabase/common/components/Pickers/EntityPicker/components/test/EntityPickerModal.unit.spec.tsx
+++ b/frontend/src/metabase/common/components/Pickers/EntityPicker/components/test/EntityPickerModal.unit.spec.tsx
@@ -74,11 +74,13 @@ const writableNestedDataCollection = createMockCollection({
const libraryRootItems = [
createMockCollectionItem({
+ // Unjustified type cast. FIXME
id: promotedDataCollection.id as number,
model: "collection",
name: promotedDataCollection.name,
type: "library-data",
can_write: false,
+ // Unjustified type cast. FIXME
collection_id: libraryCollection.id as number,
location: "/9/10/",
effective_location: "/9/",
@@ -91,6 +93,7 @@ const libraryRootItems = [
name: "LibraryCollection5",
type: "library-data",
can_write: true,
+ // Unjustified type cast. FIXME
collection_id: libraryCollection.id as number,
location: "/9/10/",
effective_location: "/9/",
@@ -102,6 +105,7 @@ const libraryRootItems = [
type: "library-metrics",
is_library_root: true,
can_write: false,
+ // Unjustified type cast. FIXME
collection_id: libraryCollection.id as number,
location: "/9/",
effective_location: "/9/",
@@ -112,11 +116,13 @@ const libraryRootItems = [
const promotedDataCollectionItems = [
createMockCollectionItem({
+ // Unjustified type cast. FIXME
id: writableNestedDataCollection.id as number,
model: "collection",
name: writableNestedDataCollection.name,
type: "library-data",
can_write: true,
+ // Unjustified type cast. FIXME
collection_id: promotedDataCollection.id as number,
location: "/9/10/28/",
effective_location: "/9/28/",
@@ -339,12 +345,14 @@ describe("EntityPickerModal", () => {
...libraryPickerSetup,
libraryCollectionItems: [
createMockCollectionItem({
+ // Unjustified type cast. FIXME
id: hiddenDataCollection.id as number,
model: "collection",
name: "Data",
type: "library-data",
can_write: true,
is_library_root: true,
+ // Unjustified type cast. FIXME
collection_id: libraryCollection.id as number,
location: "/9/",
effective_location: "/9/",
@@ -382,6 +390,7 @@ describe("EntityPickerModal", () => {
name: "Promoted Metric Collection",
type: "library-metrics",
can_write: true,
+ // Unjustified type cast. FIXME
collection_id: libraryCollection.id as number,
location: "/9/11/",
effective_location: "/9/",
diff --git a/frontend/src/metabase/common/components/Pickers/EntityPicker/components/test/NewCollectionDialog.unit.spec.tsx b/frontend/src/metabase/common/components/Pickers/EntityPicker/components/test/NewCollectionDialog.unit.spec.tsx
index 706c73dd067..d5593ea96d6 100644
--- a/frontend/src/metabase/common/components/Pickers/EntityPicker/components/test/NewCollectionDialog.unit.spec.tsx
+++ b/frontend/src/metabase/common/components/Pickers/EntityPicker/components/test/NewCollectionDialog.unit.spec.tsx
@@ -101,6 +101,7 @@ describe("NewCollectionDialog", () => {
const apiCalls = fetchMock.callHistory.calls("path:/api/collection");
expect(apiCalls).toHaveLength(1);
const call = apiCalls[0];
+ // Unjustified type cast. FIXME
const body = JSON.parse(call.options?.body as string);
expect(body.name).toBe("My New Collection");
expect(body.parent_id).toBe(33);
@@ -120,6 +121,7 @@ describe("NewCollectionDialog", () => {
const apiCalls = fetchMock.callHistory.calls("path:/api/collection");
expect(apiCalls).toHaveLength(1);
const call = apiCalls[0];
+ // Unjustified type cast. FIXME
const body = JSON.parse(call.options?.body as string);
expect(body.name).toBe("My New Collection");
expect(body.parent_id).toBe(null);
diff --git a/frontend/src/metabase/common/components/Pickers/EntityPicker/components/test/NewDashboardDialog.unit.spec.tsx b/frontend/src/metabase/common/components/Pickers/EntityPicker/components/test/NewDashboardDialog.unit.spec.tsx
index 545a0e6e747..3e09e0e130c 100644
--- a/frontend/src/metabase/common/components/Pickers/EntityPicker/components/test/NewDashboardDialog.unit.spec.tsx
+++ b/frontend/src/metabase/common/components/Pickers/EntityPicker/components/test/NewDashboardDialog.unit.spec.tsx
@@ -99,6 +99,7 @@ describe("NewDashboardDialog", () => {
const apiCalls = fetchMock.callHistory.calls("path:/api/dashboard");
expect(apiCalls).toHaveLength(1);
const call = apiCalls[0];
+ // Unjustified type cast. FIXME
const body = JSON.parse(call.options?.body as string);
expect(body.name).toBe("My New Dashboard");
expect(body.collection_id).toBe(33);
@@ -118,6 +119,7 @@ describe("NewDashboardDialog", () => {
const apiCalls = fetchMock.callHistory.calls("path:/api/dashboard");
expect(apiCalls).toHaveLength(1);
const call = apiCalls[0];
+ // Unjustified type cast. FIXME
const body = JSON.parse(call.options?.body as string);
expect(body.name).toBe("My New Dashboard");
expect(body.collection_id).toBe(null);
diff --git a/frontend/src/metabase/common/components/Pickers/EntityPicker/hooks/use-current-search-scope.ts b/frontend/src/metabase/common/components/Pickers/EntityPicker/hooks/use-current-search-scope.ts
index ab4fa373f09..226b7232d81 100644
--- a/frontend/src/metabase/common/components/Pickers/EntityPicker/hooks/use-current-search-scope.ts
+++ b/frontend/src/metabase/common/components/Pickers/EntityPicker/hooks/use-current-search-scope.ts
@@ -19,7 +19,8 @@ export const useGetLastCollection = ():
(item) => item.model === "collection",
);
return lastCollectionIndex !== -1
- ? (previousPath[lastCollectionIndex] as OmniPickerCollectionItem)
+ ? // Unjustified type cast. FIXME
+ (previousPath[lastCollectionIndex] as OmniPickerCollectionItem)
: null;
}, [previousPath]);
diff --git a/frontend/src/metabase/common/components/Pickers/EntityPicker/hooks/use-get-path-from-value.ts b/frontend/src/metabase/common/components/Pickers/EntityPicker/hooks/use-get-path-from-value.ts
index c93f200f335..0814fe275ee 100644
--- a/frontend/src/metabase/common/components/Pickers/EntityPicker/hooks/use-get-path-from-value.ts
+++ b/frontend/src/metabase/common/components/Pickers/EntityPicker/hooks/use-get-path-from-value.ts
@@ -331,6 +331,7 @@ const getNamespace = (
}
if ("collection_namespace" in item) {
+ // Unjustified type cast. FIXME
return item.collection_namespace as CollectionNamespace;
}
return undefined;
diff --git a/frontend/src/metabase/common/components/Pickers/EntityPicker/hooks/use-get-path-from-value.unit.spec.tsx b/frontend/src/metabase/common/components/Pickers/EntityPicker/hooks/use-get-path-from-value.unit.spec.tsx
index 86014e34d05..f09f881caa6 100644
--- a/frontend/src/metabase/common/components/Pickers/EntityPicker/hooks/use-get-path-from-value.unit.spec.tsx
+++ b/frontend/src/metabase/common/components/Pickers/EntityPicker/hooks/use-get-path-from-value.unit.spec.tsx
@@ -313,6 +313,7 @@ describe("useGetPathFromValue", () => {
setupCollectionItemsEndpoint({
collection: { id: "root" },
collectionItems: [
+ // Unjustified type cast. FIXME
createMockCollectionItem({
...parentCollection,
model: "collection",
@@ -323,6 +324,7 @@ describe("useGetPathFromValue", () => {
setupCollectionItemsEndpoint({
collection: parentCollection,
collectionItems: [
+ // Unjustified type cast. FIXME
createMockCollectionItem({
...childCollection,
model: "collection",
@@ -396,6 +398,7 @@ describe("useGetPathFromValue", () => {
setupCollectionItemsEndpoint({
collection: { id: "root" },
collectionItems: [
+ // Unjustified type cast. FIXME
createMockCollectionItem({
...parentCollection,
model: "collection",
@@ -406,10 +409,12 @@ describe("useGetPathFromValue", () => {
setupCollectionItemsEndpoint({
collection: parentCollection,
collectionItems: [
+ // Unjustified type cast. FIXME
createMockCollectionItem({
...childCollection,
model: "collection",
} as CollectionItem),
+ // Unjustified type cast. FIXME
createMockCollectionItem({
id: grandchildCollection.id,
name: grandchildCollection.name,
@@ -428,6 +433,7 @@ describe("useGetPathFromValue", () => {
name: "Grandchild card",
model: "card",
}),
+ // Unjustified type cast. FIXME
createMockCollectionItem({
id: grandchildCollection.id,
name: grandchildCollection.name,
@@ -599,6 +605,7 @@ describe("useGetPathFromValue", () => {
const table = testDb.tables?.[0];
const value: OmniPickerValue = {
model: "table",
+ // Unjustified type cast. FIXME
id: table?.id as number,
};
@@ -624,6 +631,7 @@ describe("useGetPathFromValue", () => {
const { result } = setup({
value: {
model: "table",
+ // Unjustified type cast. FIXME
id: table?.id as number,
},
databases: [testDb, testDbSingleSchema],
@@ -653,6 +661,7 @@ describe("useGetPathFromValue", () => {
collection: personalCollection,
collectionItems: [
createMockCollectionItem({
+ // Unjustified type cast. FIXME
id: childCollection.id as number,
name: childCollection.name,
model: "collection",
@@ -759,6 +768,7 @@ describe("useGetPathFromValue", () => {
setupCollectionItemsEndpoint({
collection: otherPersonal,
collectionItems: [
+ // Unjustified type cast. FIXME
createMockCollectionItem({
...nestedPersonal,
model: "collection",
@@ -769,6 +779,7 @@ describe("useGetPathFromValue", () => {
setupCollectionItemsEndpoint({
collection: nestedPersonal,
collectionItems: [
+ // Unjustified type cast. FIXME
createMockCollectionItem({
...moreNestedPersonal,
model: "collection",
@@ -827,6 +838,7 @@ describe("useGetPathFromValue", () => {
setupCollectionItemsEndpoint({
collection: { id: "root" },
collectionItems: [
+ // Unjustified type cast. FIXME
createMockCollectionItem({
...parentCollection,
model: "collection",
@@ -840,6 +852,7 @@ describe("useGetPathFromValue", () => {
() => {
return {
data: [
+ // Unjustified type cast. FIXME
createMockCollectionItem({
...childCollection,
model: "collection",
@@ -951,6 +964,7 @@ describe("useGetPathFromValue", () => {
}, 10_000);
it("should return transform path with a provided transform collection", async () => {
+ // Unjustified type cast. FIXME
const parentCollection = createMockCollection({
id: 6262,
name: "My Transforms",
@@ -960,6 +974,7 @@ describe("useGetPathFromValue", () => {
here: ["table", "dataset"],
} as unknown as Collection);
+ // Unjustified type cast. FIXME
const childCollection = createMockCollection({
id: 6363,
name: "More Transforms",
@@ -973,6 +988,7 @@ describe("useGetPathFromValue", () => {
setupCollectionItemsEndpoint({
collection: { id: "root" },
collectionItems: [
+ // Unjustified type cast. FIXME
createMockCollectionItem({
...parentCollection,
model: "collection",
@@ -983,6 +999,7 @@ describe("useGetPathFromValue", () => {
setupCollectionItemsEndpoint({
collection: parentCollection,
collectionItems: [
+ // Unjustified type cast. FIXME
createMockCollectionItem({
...childCollection,
model: "collection",
@@ -1020,6 +1037,7 @@ describe("useGetPathFromValue", () => {
});
it("should return library collection path with no provided value", async () => {
+ // Unjustified type cast. FIXME
const libraryCollection = createMockCollection({
id: 6464,
name: "Library",
@@ -1027,6 +1045,7 @@ describe("useGetPathFromValue", () => {
below: ["collection"],
} as unknown as Collection);
+ // Unjustified type cast. FIXME
const childCollection = createMockCollection({
id: 6565,
name: "Data",
@@ -1037,6 +1056,7 @@ describe("useGetPathFromValue", () => {
setupCollectionItemsEndpoint({
collection: libraryCollection,
collectionItems: [
+ // Unjustified type cast. FIXME
createMockCollectionItem({
...childCollection,
model: "collection",
@@ -1060,6 +1080,7 @@ describe("useGetPathFromValue", () => {
});
it("should return a shared tenant collection path", async () => {
+ // Unjustified type cast. FIXME
const parentCollection = createMockCollection({
id: 6262,
name: "shared stuff",
@@ -1069,6 +1090,7 @@ describe("useGetPathFromValue", () => {
here: ["table", "dataset", "collection"],
} as unknown as Collection);
+ // Unjustified type cast. FIXME
const childCollection = createMockCollection({
id: 6363,
name: "More shared stuff",
@@ -1082,6 +1104,7 @@ describe("useGetPathFromValue", () => {
setupCollectionItemsEndpoint({
collection: { id: "root" },
collectionItems: [
+ // Unjustified type cast. FIXME
createMockCollectionItem({
...parentCollection,
model: "collection",
@@ -1092,6 +1115,7 @@ describe("useGetPathFromValue", () => {
setupCollectionItemsEndpoint({
collection: parentCollection,
collectionItems: [
+ // Unjustified type cast. FIXME
createMockCollectionItem({
...childCollection,
model: "collection",
@@ -1133,6 +1157,7 @@ describe("useGetPathFromValue", () => {
});
it("should return a tenant specific collection path", async () => {
+ // Unjustified type cast. FIXME
const parentCollection = createMockCollection({
id: 6262,
name: "specific stuff",
@@ -1142,6 +1167,7 @@ describe("useGetPathFromValue", () => {
here: ["table", "dataset", "collection"],
} as unknown as Collection);
+ // Unjustified type cast. FIXME
const childCollection = createMockCollection({
id: 6363,
name: "More specific stuff",
@@ -1155,6 +1181,7 @@ describe("useGetPathFromValue", () => {
setupCollectionItemsEndpoint({
collection: { id: "root" },
collectionItems: [
+ // Unjustified type cast. FIXME
createMockCollectionItem({
...parentCollection,
model: "collection",
@@ -1165,6 +1192,7 @@ describe("useGetPathFromValue", () => {
setupCollectionItemsEndpoint({
collection: parentCollection,
collectionItems: [
+ // Unjustified type cast. FIXME
createMockCollectionItem({
...childCollection,
model: "collection",
diff --git a/frontend/src/metabase/common/components/Pickers/EntityPicker/utils.ts b/frontend/src/metabase/common/components/Pickers/EntityPicker/utils.ts
index 7e8fd9c378c..27e7aed8398 100644
--- a/frontend/src/metabase/common/components/Pickers/EntityPicker/utils.ts
+++ b/frontend/src/metabase/common/components/Pickers/EntityPicker/utils.ts
@@ -227,6 +227,7 @@ export const allCollectionModels = Array.from(validCollectionModels);
const isValidModel = (
model: OmniPickerItem["model"],
): model is CollectionItemModel =>
+ // Unjustified type cast. FIXME
validCollectionModels.has(model as CollectionItemModel);
export const getValidCollectionItemModels = (
diff --git a/frontend/src/metabase/common/components/Pickers/EntityPicker/utils.unit.spec.ts b/frontend/src/metabase/common/components/Pickers/EntityPicker/utils.unit.spec.ts
index 902e4b5e070..f4be0881f09 100644
--- a/frontend/src/metabase/common/components/Pickers/EntityPicker/utils.unit.spec.ts
+++ b/frontend/src/metabase/common/components/Pickers/EntityPicker/utils.unit.spec.ts
@@ -40,6 +40,7 @@ describe("EntityPicker utils", () => {
name: "table",
color: "text-dark",
});
+ // Unjustified type cast. FIXME
const item = { id: 1, model: "table" } as OmniPickerItem;
const result = getEntityPickerIcon(item);
expect(result).toEqual({
@@ -54,6 +55,7 @@ describe("EntityPicker utils", () => {
it("should set color to text-primary-inverse if selected and no color present", () => {
const { getEntityPickerIcon } = setupHook({ name: "table" });
+ // Unjustified type cast. FIXME
const item = { id: 1, model: "table" } as OmniPickerItem;
const result = getEntityPickerIcon(item, {
isSelected: true,
@@ -70,6 +72,7 @@ describe("EntityPicker utils", () => {
name: "folder",
color: "text-yellow",
});
+ // Unjustified type cast. FIXME
const item = { id: 1, model: "collection" } as OmniPickerItem;
const result = getEntityPickerIcon(item, {
isSelected: true,
@@ -84,39 +87,49 @@ describe("EntityPicker utils", () => {
describe("isSelectedItem", () => {
it("should return true if items match id and model", () => {
+ // Unjustified type cast. FIXME
const item1 = { id: 1, model: "table" } as OmniPickerItem;
+ // Unjustified type cast. FIXME
const item2 = { id: 1, model: "table" } as OmniPickerItem;
expect(isSelectedItem(item1, item2)).toBe(true);
});
it("should return false if items have different id", () => {
+ // Unjustified type cast. FIXME
const item1 = { id: 1, model: "table" } as OmniPickerItem;
+ // Unjustified type cast. FIXME
const item2 = { id: 2, model: "table" } as OmniPickerItem;
expect(isSelectedItem(item1, item2)).toBe(false);
});
it("should return false if items have different model", () => {
+ // Unjustified type cast. FIXME
const item1 = { id: 1, model: "table" } as OmniPickerItem;
+ // Unjustified type cast. FIXME
const item2 = { id: 1, model: "database" } as OmniPickerItem;
expect(isSelectedItem(item1, item2)).toBe(false);
});
it("should return false if selectedItem is null", () => {
+ // Unjustified type cast. FIXME
const item1 = { id: 1, model: "table" } as OmniPickerItem;
expect(isSelectedItem(item1, null)).toBe(false);
});
it("should check namespace if present", () => {
+ // Unjustified type cast. FIXME
const item1 = {
id: 1,
model: "collection",
namespace: "snippets",
} as OmniPickerItem;
+ // Unjustified type cast. FIXME
const item2 = {
id: 1,
model: "collection",
namespace: "snippets",
} as OmniPickerItem;
+ // Unjustified type cast. FIXME
const item3 = {
id: 1,
model: "collection",
@@ -129,18 +142,21 @@ describe("EntityPicker utils", () => {
});
describe("getItemFunctions", () => {
+ // Unjustified type cast. FIXME
const models = ["table", "card"] as EntityPickerProps["models"];
describe("isFolderItem", () => {
it("should return true for Database and Schema models", () => {
const { isFolderItem } = getItemFunctions({ models });
expect(
+ // Unjustified type cast. FIXME
isFolderItem({
id: 1,
model: OmniPickerFolderModel.Database,
} as OmniPickerItem),
).toBe(true);
expect(
+ // Unjustified type cast. FIXME
isFolderItem({
id: 1,
model: OmniPickerFolderModel.Schema,
@@ -150,7 +166,9 @@ describe("EntityPicker utils", () => {
it("should return false for invalid items", () => {
const { isFolderItem } = getItemFunctions({ models });
+ // Unjustified type cast. FIXME
expect(isFolderItem(null as any)).toBe(false);
+ // Unjustified type cast. FIXME
expect(isFolderItem({} as any)).toBe(false);
});
@@ -158,10 +176,13 @@ describe("EntityPicker utils", () => {
const customIsFolderItem = jest.fn().mockReturnValue(true);
const { isFolderItem } = getItemFunctions({
models,
+ // Unjustified type cast. FIXME
isFolderItem: customIsFolderItem as any,
});
+ // Unjustified type cast. FIXME
const cardItem = { id: 1, model: "card" } as OmniPickerItem;
+ // Unjustified type cast. FIXME
const dbItem = {
id: 1,
model: OmniPickerFolderModel.Database,
@@ -179,6 +200,7 @@ describe("EntityPicker utils", () => {
it("should return true for Collection if it contains allowed models", () => {
const { isFolderItem } = getItemFunctions({ models: ["card"] });
+ // Unjustified type cast. FIXME
const item = {
id: 1,
model: OmniPickerFolderModel.Collection,
@@ -189,6 +211,7 @@ describe("EntityPicker utils", () => {
it("should return false for Collection if it does not contain allowed models", () => {
const { isFolderItem } = getItemFunctions({ models: ["card"] });
+ // Unjustified type cast. FIXME
const item = {
id: 1,
model: OmniPickerFolderModel.Collection,
@@ -199,6 +222,7 @@ describe("EntityPicker utils", () => {
it("should return false for Collection if it has neither 'here' nor 'below'", () => {
const { isFolderItem } = getItemFunctions({ models: ["card"] });
+ // Unjustified type cast. FIXME
const item = {
id: 1,
model: OmniPickerFolderModel.Collection,
@@ -211,6 +235,7 @@ describe("EntityPicker utils", () => {
it("should return true if model is in allowed models", () => {
const { isSelectableItem } = getItemFunctions({ models: ["table"] });
expect(
+ // Unjustified type cast. FIXME
isSelectableItem({ id: 1, model: "table" } as OmniPickerItem),
).toBe(true);
});
@@ -224,6 +249,7 @@ describe("EntityPicker utils", () => {
it("should return false if model is not in allowed models", () => {
const { isSelectableItem } = getItemFunctions({ models: ["table"] });
expect(
+ // Unjustified type cast. FIXME
isSelectableItem({ id: 1, model: "card" } as OmniPickerItem),
).toBe(false);
});
@@ -235,7 +261,9 @@ describe("EntityPicker utils", () => {
isSelectableItem: customIsSelectableItem,
});
+ // Unjustified type cast. FIXME
const dashboardItem = { id: 1, model: "dashboard" } as OmniPickerItem;
+ // Unjustified type cast. FIXME
const tableItem = { id: 1, model: "table" } as OmniPickerItem;
// When the function is permissive, base behavior applies
@@ -252,6 +280,7 @@ describe("EntityPicker utils", () => {
describe("isHiddenItem", () => {
it("should return true for invalid items", () => {
const { isHiddenItem } = getItemFunctions({ models: [] });
+ // Unjustified type cast. FIXME
expect(isHiddenItem(null as any)).toBe(true);
});
@@ -262,7 +291,9 @@ describe("EntityPicker utils", () => {
isHiddenItem: customIsHiddenItem,
});
+ // Unjustified type cast. FIXME
const tableItem = { id: 1, model: "table" } as OmniPickerItem;
+ // Unjustified type cast. FIXME
const cardItem = { id: 1, model: "card" } as OmniPickerItem;
// base behavior not modified by permissive custom function
@@ -284,12 +315,14 @@ describe("EntityPicker utils", () => {
it("should return false if item is selectable", () => {
const { isHiddenItem } = getItemFunctions({ models: ["table"] });
+ // Unjustified type cast. FIXME
const item = { id: 1, model: "table" } as OmniPickerItem;
expect(isHiddenItem(item)).toBe(false);
});
it("should return false if item is a folder", () => {
const { isHiddenItem } = getItemFunctions({ models: ["table"] });
+ // Unjustified type cast. FIXME
const item = {
id: 1,
model: OmniPickerFolderModel.Database,
@@ -307,6 +340,7 @@ describe("EntityPicker utils", () => {
it("should return false for valid items", () => {
const { isDisabledItem } = getItemFunctions({ models: [] });
+ // Unjustified type cast. FIXME
const item = { id: 1, model: "card" } as OmniPickerItem;
expect(isDisabledItem(item)).toBe(false);
});
@@ -321,6 +355,7 @@ describe("EntityPicker utils", () => {
// @ts-expect-error: testing invalid item
const invalidItem = { idx: 1, model: "dashboard" } as OmniPickerItem;
+ // Unjustified type cast. FIXME
const validItem = { id: 1, model: "card" } as OmniPickerItem;
// doesn't validate invalid item
@@ -351,6 +386,7 @@ describe("EntityPicker utils", () => {
"",
];
const result = getValidCollectionItemModels(
+ // Unjustified type cast. FIXME
input as CollectionItemModel[],
);
expect(result).toEqual([
@@ -380,6 +416,7 @@ describe("EntityPicker utils", () => {
});
it("should return null if not present", () => {
+ // Unjustified type cast. FIXME
const item = {} as any;
expect(getCollectionType(item)).toBeNull();
});
diff --git a/frontend/src/metabase/common/components/Pickers/MiniPicker/components/MiniPicker/test/setup.tsx b/frontend/src/metabase/common/components/Pickers/MiniPicker/components/MiniPicker/test/setup.tsx
index f85394dc07b..7bc92df928b 100644
--- a/frontend/src/metabase/common/components/Pickers/MiniPicker/components/MiniPicker/test/setup.tsx
+++ b/frontend/src/metabase/common/components/Pickers/MiniPicker/components/MiniPicker/test/setup.tsx
@@ -25,6 +25,7 @@ import {
import { MiniPicker, type MiniPickerProps } from "..";
+// Unjustified type cast. FIXME
const collectionItemModels = [
"dataset",
"metric",
diff --git a/frontend/src/metabase/common/components/Pickers/MiniPicker/components/MiniPickerItemList.tsx b/frontend/src/metabase/common/components/Pickers/MiniPicker/components/MiniPickerItemList.tsx
index 452118903fe..337c629cae7 100644
--- a/frontend/src/metabase/common/components/Pickers/MiniPicker/components/MiniPickerItemList.tsx
+++ b/frontend/src/metabase/common/components/Pickers/MiniPicker/components/MiniPickerItemList.tsx
@@ -499,6 +499,7 @@ function SearchItemList({ query: externalQuery }: { query: string }) {
): SearchRequest => {
const params: SearchRequest = {
q: query,
+ // Unjustified type cast. FIXME
models: models as SearchModel[],
limit: 50,
context: "data-picker",
diff --git a/frontend/src/metabase/common/components/Pickers/MiniPicker/utils.ts b/frontend/src/metabase/common/components/Pickers/MiniPicker/utils.ts
index 2c5ea3d43d6..c31c298221f 100644
--- a/frontend/src/metabase/common/components/Pickers/MiniPicker/utils.ts
+++ b/frontend/src/metabase/common/components/Pickers/MiniPicker/utils.ts
@@ -293,6 +293,7 @@ export function getFolderAndHiddenFunctions(
return true;
}
+ // Unjustified type cast. FIXME
return (
!modelSet.has(item.model as MiniPickerPickableItem["model"]) &&
!isFolder(item)
@@ -309,6 +310,7 @@ export const focusFirstMiniPickerItem = () => {
'[data-testid="mini-picker"] [role="menuitem"]',
);
if (firstItem) {
+ // Unjustified type cast. FIXME
(firstItem as HTMLElement)?.focus?.();
}
}, 10);
diff --git a/frontend/src/metabase/common/components/Pickers/MoveModal/MoveModal.render.unit.spec.tsx b/frontend/src/metabase/common/components/Pickers/MoveModal/MoveModal.render.unit.spec.tsx
index ef72c5672cc..6e27b06884d 100644
--- a/frontend/src/metabase/common/components/Pickers/MoveModal/MoveModal.render.unit.spec.tsx
+++ b/frontend/src/metabase/common/components/Pickers/MoveModal/MoveModal.render.unit.spec.tsx
@@ -67,6 +67,7 @@ function setupEndpoints() {
fetchMock.get("path:/api/user/recipients", { data: [] });
}
+// Unjustified type cast. FIXME
const movingCard = {
id: 1,
name: "Test Question",
@@ -74,6 +75,7 @@ const movingCard = {
collection: { id: 11, name: "First Collection", authority_level: null },
} as OmniPickerCollectionItem;
+// Unjustified type cast. FIXME
const movingDashboard = {
id: 2,
name: "Test Dashboard",
diff --git a/frontend/src/metabase/common/components/Pickers/MoveModal/MoveModal.tsx b/frontend/src/metabase/common/components/Pickers/MoveModal/MoveModal.tsx
index 898ee411d7b..3352f94f40a 100644
--- a/frontend/src/metabase/common/components/Pickers/MoveModal/MoveModal.tsx
+++ b/frontend/src/metabase/common/components/Pickers/MoveModal/MoveModal.tsx
@@ -330,6 +330,7 @@ export const BulkMoveModal = ({
return !selectedItems.every(
(selectedItem) =>
canMoveCollectionToLibraryDestination(
+ // Unjustified type cast. FIXME
selectedItem as OmniPickerCollectionItem,
item,
) &&
@@ -346,6 +347,7 @@ export const BulkMoveModal = ({
const handleMove = useCallback(
async (destination: OmniPickerItem) => {
+ // Unjustified type cast. FIXME
return onMove({
id: destination.id,
model: destination.model,
diff --git a/frontend/src/metabase/common/components/ReorderableTagsInput/ReorderableTagsInput.stories.tsx b/frontend/src/metabase/common/components/ReorderableTagsInput/ReorderableTagsInput.stories.tsx
index 3199a20d3e8..7039b23e6f2 100644
--- a/frontend/src/metabase/common/components/ReorderableTagsInput/ReorderableTagsInput.stories.tsx
+++ b/frontend/src/metabase/common/components/ReorderableTagsInput/ReorderableTagsInput.stories.tsx
@@ -114,11 +114,13 @@ export const DragBetweenTwoInputs = {
);
const handleDragStart = (event: DragStartEvent) => {
+ // Unjustified type cast. FIXME
setActiveId(event.active.id as string);
};
const handleDragOver = (event: DragOverEvent) => {
const { over } = event;
+ // Unjustified type cast. FIXME
const containerId = over?.data?.current?.containerId as
| "left"
| "right"
@@ -138,6 +140,7 @@ export const DragBetweenTwoInputs = {
}
const activeId = String(active.id);
+ // Unjustified type cast. FIXME
const from = active.data?.current?.containerId as
| "left"
| "right"
@@ -150,6 +153,7 @@ export const DragBetweenTwoInputs = {
let overIndexInTo = -1;
if (over.data?.current?.containerId) {
+ // Unjustified type cast. FIXME
to = over.data.current.containerId as "left" | "right";
const toList = to === "left" ? leftValues : rightValues;
overIndexInTo = toList.indexOf(String(over.id));
diff --git a/frontend/src/metabase/common/components/ReorderableTagsInput/ReorderableTagsInput.tsx b/frontend/src/metabase/common/components/ReorderableTagsInput/ReorderableTagsInput.tsx
index 0f72c3df887..bb0d2f4fd0e 100644
--- a/frontend/src/metabase/common/components/ReorderableTagsInput/ReorderableTagsInput.tsx
+++ b/frontend/src/metabase/common/components/ReorderableTagsInput/ReorderableTagsInput.tsx
@@ -76,6 +76,7 @@ export function SortablePill({
data: { containerId },
strategy: horizontalListSortingStrategy,
});
+ // Unjustified type cast. FIXME
const sortableStyle = {
transform: CSS.Transform.toString(transform),
transition,
@@ -209,6 +210,7 @@ export function ReorderableTagsInput({
}}
styles={styles}
onMouseDownCapture={(e: React.MouseEvent<HTMLDivElement>) => {
+ // Unjustified type cast. FIXME
const target = e.target as HTMLElement;
// Do not open when interacting with a pill (likely starting a drag or clicking remove)
if (
@@ -226,6 +228,7 @@ export function ReorderableTagsInput({
e.stopPropagation();
}}
onDragEnter={(e) => {
+ // Unjustified type cast. FIXME
const related = e.relatedTarget as Node | null;
// Only set drag-over when entering from outside the top-level container
if (related && e.currentTarget.contains(related)) {
@@ -236,6 +239,7 @@ export function ReorderableTagsInput({
setIsDragOver(true);
}}
onDragLeave={(e) => {
+ // Unjustified type cast. FIXME
const related = e.relatedTarget as Node | null;
// Only clear drag-over when leaving to outside the top-level container
if (related && e.currentTarget.contains(related)) {
diff --git a/frontend/src/metabase/common/components/SaveQuestionForm/context.tsx b/frontend/src/metabase/common/components/SaveQuestionForm/context.tsx
index 1883cdd3f88..967ab7420d3 100644
--- a/frontend/src/metabase/common/components/SaveQuestionForm/context.tsx
+++ b/frontend/src/metabase/common/components/SaveQuestionForm/context.tsx
@@ -249,6 +249,7 @@ export const FormValuesPatcher = <T extends object>({
return;
}
const patches: Partial<T> = {};
+ // Unjustified type cast. FIXME
for (const key of Object.keys(nextValues) as (keyof T)[]) {
if (isEqual(formValues[key], prevValues[key])) {
/**
diff --git a/frontend/src/metabase/common/components/SaveQuestionForm/context.unit.spec.tsx b/frontend/src/metabase/common/components/SaveQuestionForm/context.unit.spec.tsx
index 53b43b88c20..ff4c06930b1 100644
--- a/frontend/src/metabase/common/components/SaveQuestionForm/context.unit.spec.tsx
+++ b/frontend/src/metabase/common/components/SaveQuestionForm/context.unit.spec.tsx
@@ -390,6 +390,7 @@ describe("SaveQuestionContext", () => {
describe("FormValuesPatcher", () => {
const setValuesSpy = jest.fn();
const setup = (initialValue: unknown) => {
+ // Unjustified type cast. FIXME
jest.spyOn(formik, "useFormikContext").mockReturnValue({
values: initialValue,
setValues: setValuesSpy,
diff --git a/frontend/src/metabase/common/components/SaveQuestionForm/util.unit.spec.ts b/frontend/src/metabase/common/components/SaveQuestionForm/util.unit.spec.ts
index 3da566e3dc0..bde89f9339c 100644
--- a/frontend/src/metabase/common/components/SaveQuestionForm/util.unit.spec.ts
+++ b/frontend/src/metabase/common/components/SaveQuestionForm/util.unit.spec.ts
@@ -111,6 +111,7 @@ describe("SaveQuestionForm utils", () => {
...baseCreateOptions,
details: {
...baseCreateOptions.details,
+ // Unjustified type cast. FIXME
description: null as unknown as string, // testing invalid type
},
onCreate: onCreateSpy,
diff --git a/frontend/src/metabase/common/components/SaveQuestionModal/SaveQuestionModal.unit.spec.tsx b/frontend/src/metabase/common/components/SaveQuestionModal/SaveQuestionModal.unit.spec.tsx
index 4becf5856bc..8f89c5401b2 100644
--- a/frontend/src/metabase/common/components/SaveQuestionModal/SaveQuestionModal.unit.spec.tsx
+++ b/frontend/src/metabase/common/components/SaveQuestionModal/SaveQuestionModal.unit.spec.tsx
@@ -911,7 +911,9 @@ describe("SaveQuestionModal", () => {
collectionItems: [
createMockCollectionItem({
...COLLECTION.PARENT,
+ // Unjustified type cast. FIXME
id: COLLECTION.PARENT.id as number,
+ // Unjustified type cast. FIXME
entity_id: COLLECTION.PARENT.entity_id as BaseEntityId,
location: COLLECTION.PARENT.location || "/",
type: undefined,
@@ -924,7 +926,9 @@ describe("SaveQuestionModal", () => {
collectionItems: [
createMockCollectionItem({
...COLLECTION.CHILD,
+ // Unjustified type cast. FIXME
id: COLLECTION.CHILD.id as number,
+ // Unjustified type cast. FIXME
entity_id: COLLECTION.CHILD.entity_id as BaseEntityId,
location: COLLECTION.CHILD.location || "/",
type: undefined,
diff --git a/frontend/src/metabase/common/components/Schedule/Schedule.stories.tsx b/frontend/src/metabase/common/components/Schedule/Schedule.stories.tsx
index 3ca804b18d8..342eba6744e 100644
--- a/frontend/src/metabase/common/components/Schedule/Schedule.stories.tsx
+++ b/frontend/src/metabase/common/components/Schedule/Schedule.stories.tsx
@@ -18,6 +18,7 @@ const storeInitialState = createMockState({
settings: mockSettings(),
entities: createMockEntitiesState({}),
});
+// Unjustified type cast. FIXME
const store = getPublicStore(storeInitialState) as unknown as Store<State>;
const ReduxDecorator = (Story: StoryFn) => {
diff --git a/frontend/src/metabase/common/components/Schedule/Schedule.tsx b/frontend/src/metabase/common/components/Schedule/Schedule.tsx
index e7fc330efd4..2f3d8893bbf 100644
--- a/frontend/src/metabase/common/components/Schedule/Schedule.tsx
+++ b/frontend/src/metabase/common/components/Schedule/Schedule.tsx
@@ -88,6 +88,7 @@ export const Schedule = ({
if (updatedField === "schedule_type") {
// When a new schedule type is selected, use the default values for that type
newSchedule = {
+ // Unjustified type cast. FIXME
schedule_type: newValue as ScheduleType,
...defaults,
};
@@ -211,6 +212,7 @@ export const Schedule = ({
c(
"{0} is a verb like 'Check', {1} is an adverb like 'by the minute', {2} is a number of minutes.",
)
+ // Unjustified type cast. FIXME
.jt`${verb} ${selectFrequency} every ${selectEveryMinute} ${ngettext(msgid`Minute`, "Minutes", schedule_minute as number).toLocaleLowerCase()}`,
)
.with("hourly", () => {
diff --git a/frontend/src/metabase/common/components/Schedule/Schedule.unit.spec.tsx b/frontend/src/metabase/common/components/Schedule/Schedule.unit.spec.tsx
index 34bc3bf513e..575e928f0a0 100644
--- a/frontend/src/metabase/common/components/Schedule/Schedule.unit.spec.tsx
+++ b/frontend/src/metabase/common/components/Schedule/Schedule.unit.spec.tsx
@@ -363,6 +363,7 @@ describe("Schedule", () => {
"%s",
async (_label, initialCronString, clicks, expectedCron) => {
const { onScheduleChange } = setupHarness({ initialCronString });
+ // Unjustified type cast. FIXME
for (const entry of Object.entries(clicks) as [
ScheduleComponentType,
string,
diff --git a/frontend/src/metabase/common/components/Schedule/components.tsx b/frontend/src/metabase/common/components/Schedule/components.tsx
index e808cc29d82..99dc515c56d 100644
--- a/frontend/src/metabase/common/components/Schedule/components.tsx
+++ b/frontend/src/metabase/common/components/Schedule/components.tsx
@@ -228,6 +228,7 @@ export const SelectMinute = ({
updateSchedule: UpdateSchedule;
range?: typeof minutes;
}) => {
+ // Unjustified type cast. FIXME
const minuteOfHour = isNaN(schedule_minute as number) ? 0 : schedule_minute;
const label = useMemo(() => getScheduleComponentLabel("minute"), []);
return (
diff --git a/frontend/src/metabase/common/components/Schedule/strings.unit.spec.ts b/frontend/src/metabase/common/components/Schedule/strings.unit.spec.ts
index 307b236c863..50ab4570e14 100644
--- a/frontend/src/metabase/common/components/Schedule/strings.unit.spec.ts
+++ b/frontend/src/metabase/common/components/Schedule/strings.unit.spec.ts
@@ -12,6 +12,7 @@ describe("getHours", () => {
});
const setup = ({ isClock24Hour }: { isClock24Hour: boolean }) => {
+ // Unjustified type cast. FIXME
(has24HourModeSetting as jest.Mock).mockReturnValue(isClock24Hour);
};
diff --git a/frontend/src/metabase/common/components/SchedulePicker/SchedulePicker.tsx b/frontend/src/metabase/common/components/SchedulePicker/SchedulePicker.tsx
index d232aa13371..221bf658483 100644
--- a/frontend/src/metabase/common/components/SchedulePicker/SchedulePicker.tsx
+++ b/frontend/src/metabase/common/components/SchedulePicker/SchedulePicker.tsx
@@ -176,6 +176,7 @@ export class SchedulePicker extends Component<SchedulePickerProps> {
onChange={(value) =>
this.handleChangeProperty(
"schedule_frame",
+ // Unjustified type cast. FIXME
value as ScheduleFrameType,
)
}
@@ -211,6 +212,7 @@ export class SchedulePicker extends Component<SchedulePickerProps> {
minButtonWidth={110}
value={schedule.schedule_day ?? ""}
onChange={(value) =>
+ // Unjustified type cast. FIXME
this.handleChangeProperty("schedule_day", value as ScheduleDayType)
}
data={toMantineData(getDayOfWeekOptions())}
@@ -221,6 +223,7 @@ export class SchedulePicker extends Component<SchedulePickerProps> {
renderMinutePicker() {
const { schedule } = this.props;
+ // Unjustified type cast. FIXME
const minuteOfHour = isNaN(schedule.schedule_minute as number)
? 0
: (schedule.schedule_minute ?? 0);
@@ -247,6 +250,7 @@ export class SchedulePicker extends Component<SchedulePickerProps> {
renderHourPicker() {
const { schedule, timezone, textBeforeSendTime } = this.props;
+ // Unjustified type cast. FIXME
const hourOfDay = isNaN(schedule.schedule_hour as number)
? 8
: schedule.schedule_hour || 0;
diff --git a/frontend/src/metabase/common/components/SearchResult/tests/SearchResult.unit.spec.tsx b/frontend/src/metabase/common/components/SearchResult/tests/SearchResult.unit.spec.tsx
index 1ed28dc2aaf..742689b677c 100644
--- a/frontend/src/metabase/common/components/SearchResult/tests/SearchResult.unit.spec.tsx
+++ b/frontend/src/metabase/common/components/SearchResult/tests/SearchResult.unit.spec.tsx
@@ -77,6 +77,7 @@ describe("SearchResult", () => {
expect(screen.getByText(TEST_RESULT_QUESTION.name)).toBeInTheDocument();
expect(
+ // Unjustified type cast. FIXME
screen.getByText(TEST_RESULT_QUESTION.description as string),
).toBeInTheDocument();
expect(getIcon("table2")).toBeInTheDocument();
diff --git a/frontend/src/metabase/common/components/SelectList/SelectListItem.styled.tsx b/frontend/src/metabase/common/components/SelectList/SelectListItem.styled.tsx
index 8286341dc49..a8eb2dd9269 100644
--- a/frontend/src/metabase/common/components/SelectList/SelectListItem.styled.tsx
+++ b/frontend/src/metabase/common/components/SelectList/SelectListItem.styled.tsx
@@ -7,6 +7,7 @@ import { Text, type TextProps } from "metabase/ui";
import { EntityIcon } from "../EntityIcon";
+// Unjustified type cast. FIXME
export const ItemTitle = styled(Text)<TextProps>`
margin: 0;
word-break: break-word;
diff --git a/frontend/src/metabase/common/components/SelectList/SelectListItem.tsx b/frontend/src/metabase/common/components/SelectList/SelectListItem.tsx
index be4594f2b76..5016f3d772f 100644
--- a/frontend/src/metabase/common/components/SelectList/SelectListItem.tsx
+++ b/frontend/src/metabase/common/components/SelectList/SelectListItem.tsx
@@ -24,6 +24,7 @@ export interface SelectListItemProps extends Omit<
}
const getIconProps = (icon?: string | IconProps): IconProps =>
+ // Unjustified type cast. FIXME
_.isObject(icon) ? icon : ({ name: icon } as IconProps);
export function SelectListItem({
diff --git a/frontend/src/metabase/common/components/TabButton/TabButton.tsx b/frontend/src/metabase/common/components/TabButton/TabButton.tsx
index 40db587376c..110db4acd10 100644
--- a/frontend/src/metabase/common/components/TabButton/TabButton.tsx
+++ b/frontend/src/metabase/common/components/TabButton/TabButton.tsx
@@ -94,8 +94,10 @@ const _TabButton = forwardRef(function TabButton(
(event: React.MouseEvent<HTMLDivElement>) => {
if (
disabled ||
+ // Unjustified type cast. FIXME
menuButtonRef.current?.contains(event.target as Node) ||
(typeof inputRef === "object" &&
+ // Unjustified type cast. FIXME
inputRef?.current?.contains(event.target as Node))
) {
return;
diff --git a/frontend/src/metabase/common/components/TabContent/TabContent.tsx b/frontend/src/metabase/common/components/TabContent/TabContent.tsx
index f0faa2a13de..033497c328c 100644
--- a/frontend/src/metabase/common/components/TabContent/TabContent.tsx
+++ b/frontend/src/metabase/common/components/TabContent/TabContent.tsx
@@ -22,6 +22,7 @@ export const TabContent = function TabContent<T>({
return { value, idPrefix, onChange };
}, [value, idPrefix, onChange]);
+ // Unjustified type cast. FIXME
return (
<TabContext.Provider value={context as TabContextType}>
{children}
diff --git a/frontend/src/metabase/common/components/TabList/TabList.tsx b/frontend/src/metabase/common/components/TabList/TabList.tsx
index 0183766e2ab..f2ef079d837 100644
--- a/frontend/src/metabase/common/components/TabList/TabList.tsx
+++ b/frontend/src/metabase/common/components/TabList/TabList.tsx
@@ -34,6 +34,7 @@ const TabListInner = forwardRef(function TabGroup<T>(
return (
<TabListRoot {...props} role="tablist">
<TabListContent ref={ref} onScroll={onScroll}>
+ {/* Unjustified type cast. FIXME */}
<TabContext.Provider value={activeContext as TabContextType}>
{children}
</TabContext.Provider>
diff --git a/frontend/src/metabase/common/components/TabRow/TabRow.tsx b/frontend/src/metabase/common/components/TabRow/TabRow.tsx
index 4ea6537b3c1..17d235e9555 100644
--- a/frontend/src/metabase/common/components/TabRow/TabRow.tsx
+++ b/frontend/src/metabase/common/components/TabRow/TabRow.tsx
@@ -102,6 +102,7 @@ const TabRowInner = forwardRef<HTMLDivElement, TabRowProps<unknown>>(
return (
<TabList
+ // Unjustified type cast. FIXME
onChange={onChange as (value: unknown) => void}
onScroll={(event) => setScrollPosition(event.currentTarget.scrollLeft)}
ref={mergedRef}
@@ -137,6 +138,7 @@ const TabRowInner = forwardRef<HTMLDivElement, TabRowProps<unknown>>(
},
);
+// Unjustified type cast. FIXME
export const TabRow = ExplicitSize<TabRowProps<unknown>>()(TabRowInner) as <T>(
props: TabRowProps<T>,
) => ReactNode;
diff --git a/frontend/src/metabase/common/components/Table/Table.unit.spec.tsx b/frontend/src/metabase/common/components/Table/Table.unit.spec.tsx
index 2a722774998..e71b9858c06 100644
--- a/frontend/src/metabase/common/components/Table/Table.unit.spec.tsx
+++ b/frontend/src/metabase/common/components/Table/Table.unit.spec.tsx
@@ -185,6 +185,7 @@ describe("common > components > ClientSortableTable", () => {
}
return 1;
}
+ // Unjustified type cast. FIXME
return row[colName as keyof Pokemon];
}}
/>,
diff --git a/frontend/src/metabase/common/components/Table/useTableSorting.tsx b/frontend/src/metabase/common/components/Table/useTableSorting.tsx
index 2e98cbb44b7..1b5100a9a35 100644
--- a/frontend/src/metabase/common/components/Table/useTableSorting.tsx
+++ b/frontend/src/metabase/common/components/Table/useTableSorting.tsx
@@ -40,8 +40,10 @@ export const useTableSorting = <Row extends BaseRow>({
const result =
typeof a === "string"
- ? compareStrings(a, b as string)
- : compareNumbers(a, b as number);
+ ? // Unjustified type cast. FIXME
+ compareStrings(a, b as string)
+ : // Unjustified type cast. FIXME
+ compareNumbers(a, b as number);
return sortDirection === "asc" ? result : -result;
});
}
diff --git a/frontend/src/metabase/common/components/TransformCollectionName.tsx b/frontend/src/metabase/common/components/TransformCollectionName.tsx
index b462082f6e8..656d262cd20 100644
--- a/frontend/src/metabase/common/components/TransformCollectionName.tsx
+++ b/frontend/src/metabase/common/components/TransformCollectionName.tsx
@@ -7,7 +7,8 @@ import type { CollectionId } from "metabase-types/api";
export function TransformCollectionName({ id }: { id: CollectionId }) {
const { data: collection } = useGetCollectionQuery(
!isRootCollection({ id }) && Number.isSafeInteger(id)
- ? { id: id as number, namespace: "transforms" }
+ ? // Unjustified type cast. FIXME
+ { id: id as number, namespace: "transforms" }
: skipToken,
);
diff --git a/frontend/src/metabase/common/components/UndoListing.styled.tsx b/frontend/src/metabase/common/components/UndoListing.styled.tsx
index 6dee7a92af2..4b05d9a10e8 100644
--- a/frontend/src/metabase/common/components/UndoListing.styled.tsx
+++ b/frontend/src/metabase/common/components/UndoListing.styled.tsx
@@ -22,12 +22,14 @@ export const CardContent = styled.div`
justify-content: space-between;
`;
+// Unjustified type cast. FIXME
export const CardContentSide = styled(Box)<BoxProps>`
display: flex;
align-items: center;
overflow: hidden;
` as unknown as typeof Box;
+// Unjustified type cast. FIXME
export const ControlsCardContent = styled(CardContentSide)`
flex-shrink: 0;
` as unknown as typeof Box;
diff --git a/frontend/src/metabase/common/components/UserForm.unit.spec.tsx b/frontend/src/metabase/common/components/UserForm.unit.spec.tsx
index 3fa71c31e06..71e661c941f 100644
--- a/frontend/src/metabase/common/components/UserForm.unit.spec.tsx
+++ b/frontend/src/metabase/common/components/UserForm.unit.spec.tsx
@@ -48,6 +48,7 @@ const setup = ({
enterprisePlugins,
initialValues = USER,
external = false,
+ // Unjustified type cast. FIXME
tenants = [] as Tenant[],
hideNameFields = false,
hideAttributes = false,
@@ -112,6 +113,7 @@ describe("UserForm", () => {
});
it("should not show validation errors before fields are touched (UXW-3719)", async () => {
+ // Unjustified type cast. FIXME
setup({ initialValues: {} as typeof USER });
expect(await screen.findByLabelText(/Email/)).toBeInTheDocument();
diff --git a/frontend/src/metabase/common/components/dnd/CollectionDropTarget.tsx b/frontend/src/metabase/common/components/dnd/CollectionDropTarget.tsx
index 0da2aa0e01e..0d4825ece27 100644
--- a/frontend/src/metabase/common/components/dnd/CollectionDropTarget.tsx
+++ b/frontend/src/metabase/common/components/dnd/CollectionDropTarget.tsx
@@ -23,6 +23,7 @@ export const CollectionDropTarget = DropTarget(
},
canDrop(props: CollectionDropTargetOwnProps, monitor: DropTargetMonitor) {
const { collection } = props;
+ // Unjustified type cast. FIXME
const { item } = monitor.getItem() as { item: CollectionItem };
if (
!isRootTrashCollection(collection) &&
diff --git a/frontend/src/metabase/common/components/dnd/ItemDragSource.tsx b/frontend/src/metabase/common/components/dnd/ItemDragSource.tsx
index e910350071f..25e60306e8b 100644
--- a/frontend/src/metabase/common/components/dnd/ItemDragSource.tsx
+++ b/frontend/src/metabase/common/components/dnd/ItemDragSource.tsx
@@ -102,7 +102,9 @@ const DragSourceComponent = DragSource(
if (!monitor.didDrop()) {
return;
}
+ // Unjustified type cast. FIXME
const { item } = monitor.getItem() as { item: CollectionItem };
+ // Unjustified type cast. FIXME
const { collection, pinIndex } = monitor.getDropResult() as {
collection?: Collection;
pinIndex?: number;
@@ -114,6 +116,7 @@ const DragSourceComponent = DragSource(
await Promise.all(
items
.filter(isMovable)
+ // Unjustified type cast. FIXME
.map((i) => setCollection(i as MovableItem, collection)),
);
} else if (pinIndex !== undefined) {
diff --git a/frontend/src/metabase/common/components/dnd/PinDropTarget.tsx b/frontend/src/metabase/common/components/dnd/PinDropTarget.tsx
index eb3c8668356..6d2a7e8a2b5 100644
--- a/frontend/src/metabase/common/components/dnd/PinDropTarget.tsx
+++ b/frontend/src/metabase/common/components/dnd/PinDropTarget.tsx
@@ -23,6 +23,7 @@ export const PinDropTarget = DropTarget(
}
},
canDrop(props: PinDropTargetOwnProps, monitor: DropTargetMonitor) {
+ // Unjustified type cast. FIXME
const { item } = monitor.getItem() as { item: CollectionItem };
const { variant } = props;
// NOTE: not necessary to check collection permission here since we
diff --git a/frontend/src/metabase/common/components/dnd/PinnedItemSortDropTarget.tsx b/frontend/src/metabase/common/components/dnd/PinnedItemSortDropTarget.tsx
index e68aee206b4..d6c648cc2d7 100644
--- a/frontend/src/metabase/common/components/dnd/PinnedItemSortDropTarget.tsx
+++ b/frontend/src/metabase/common/components/dnd/PinnedItemSortDropTarget.tsx
@@ -28,6 +28,7 @@ export const PinnedItemSortDropTarget = DropTarget(
props: PinnedItemSortDropTargetOwnProps,
monitor: DropTargetMonitor,
) {
+ // Unjustified type cast. FIXME
const { item } = monitor.getItem() as { item: CollectionItem };
const { isFrontTarget, isBackTarget, itemModel, pinIndex } = props;
diff --git a/frontend/src/metabase/common/components/upsells/components/use-upsell-link.unit.spec.tsx b/frontend/src/metabase/common/components/upsells/components/use-upsell-link.unit.spec.tsx
index c464134ca15..098ec973e25 100644
--- a/frontend/src/metabase/common/components/upsells/components/use-upsell-link.unit.spec.tsx
+++ b/frontend/src/metabase/common/components/upsells/components/use-upsell-link.unit.spec.tsx
@@ -25,6 +25,7 @@ const TestComponent = ({ url, campaign, location }: TestComponentProps) => {
};
const OSSFeatures = createMockTokenFeatures();
+// Unjustified type cast. FIXME
const EEFeatures = Object.fromEntries(
Object.entries(createMockTokenFeatures()).map(([key, value]) => [
key,
diff --git a/frontend/src/metabase/common/hooks/is-route-in-sync.unit.spec.ts b/frontend/src/metabase/common/hooks/is-route-in-sync.unit.spec.ts
index 5a35dc884f4..558a16ae0aa 100644
--- a/frontend/src/metabase/common/hooks/is-route-in-sync.unit.spec.ts
+++ b/frontend/src/metabase/common/hooks/is-route-in-sync.unit.spec.ts
@@ -8,15 +8,18 @@ describe("isRouteInSync", () => {
});
beforeEach(() => {
+ // Unjustified type cast. FIXME
delete (window as any).overrideIsWithinIframe;
});
afterAll(() => {
+ // Unjustified type cast. FIXME
MetabaseSettings.set("site-url", undefined as any);
});
describe("in an iframe", () => {
beforeEach(() => {
+ // Unjustified type cast. FIXME
(window as any).overrideIsWithinIframe = true;
});
diff --git a/frontend/src/metabase/common/hooks/use-list-keyboard-navigation/use-list-keyboard-navigation.ts b/frontend/src/metabase/common/hooks/use-list-keyboard-navigation/use-list-keyboard-navigation.ts
index 8cb803f1cb0..c72cfe94b96 100644
--- a/frontend/src/metabase/common/hooks/use-list-keyboard-navigation/use-list-keyboard-navigation.ts
+++ b/frontend/src/metabase/common/hooks/use-list-keyboard-navigation/use-list-keyboard-navigation.ts
@@ -36,6 +36,7 @@ export const useListKeyboardNavigation = <
const handleKeyDown: EventListener = useCallback(
(event) => {
+ // Unjustified type cast. FIXME
const { key } = event as KeyboardEvent;
if (list.length === 0) {
return;
diff --git a/frontend/src/metabase/common/hooks/use-memoized-callback.ts b/frontend/src/metabase/common/hooks/use-memoized-callback.ts
index 40d76442e76..2350de3a296 100644
--- a/frontend/src/metabase/common/hooks/use-memoized-callback.ts
+++ b/frontend/src/metabase/common/hooks/use-memoized-callback.ts
@@ -7,10 +7,13 @@ function getWithFallback<K, V>(
key: K,
fallback: () => V,
): V {
+ // Unjustified type cast. FIXME
if ("has" in map && map.has(key as any)) {
+ // Unjustified type cast. FIXME
return map.get(key as any)!;
} else {
const value = fallback();
+ // Unjustified type cast. FIXME
map.set(key as any, value);
return value;
}
@@ -20,7 +23,7 @@ type CacheValue = unknown;
type CacheMap = Map<unknown, CacheValue | CacheMap>;
const rootCache = new WeakMap<object, CacheMap>();
-const createMap = () => new Map() as CacheMap;
+const createMap = (): CacheMap => new Map();
export function memoize<T extends (...args: any[]) => any>(fn: T): T {
const memoized = (...args: Parameters<T>): ReturnType<T> => {
@@ -40,6 +43,7 @@ export function memoize<T extends (...args: any[]) => any>(fn: T): T {
return getWithFallback(currentMap, lastKey, () => fn(...args));
};
+ // Unjustified type cast. FIXME
return memoized as T;
}
@@ -48,6 +52,7 @@ export function useMemoizedCallback<T extends (...args: any[]) => any>(
deps: React.DependencyList = [],
): T {
return useMemo(() => {
+ // Unjustified type cast. FIXME
return memoize((...args: Parameters<T>): ReturnType<T> => {
return callback(...args);
}) as T;
diff --git a/frontend/src/metabase/common/hooks/use-set-collection.ts b/frontend/src/metabase/common/hooks/use-set-collection.ts
index 4104d683e7f..8c729e67d8c 100644
--- a/frontend/src/metabase/common/hooks/use-set-collection.ts
+++ b/frontend/src/metabase/common/hooks/use-set-collection.ts
@@ -78,6 +78,7 @@ const MOVABLE_MODELS = new Set<MovableModel>([
export function isMovable<T extends { model: string }>(
item: T,
): item is T & { model: MovableModel } {
+ // Unjustified type cast. FIXME
return MOVABLE_MODELS.has(item.model as MovableModel);
}
@@ -368,6 +369,7 @@ export function canMoveItem(item: CollectionItem, collection?: Collection) {
!isReadOnlyCollection(item) &&
isMovable(item) &&
!(isItemCollection(item) && isRootPersonalCollection(item)) &&
+ // Unjustified type cast. FIXME
!isLibraryCollection(item as Pick<Collection, "type">)
);
}
diff --git a/frontend/src/metabase/common/hooks/use-set-pinned.ts b/frontend/src/metabase/common/hooks/use-set-pinned.ts
index 8f87fc63ead..dcd34dd2bd4 100644
--- a/frontend/src/metabase/common/hooks/use-set-pinned.ts
+++ b/frontend/src/metabase/common/hooks/use-set-pinned.ts
@@ -39,6 +39,7 @@ const PINNABLE_MODELS = new Set<PinnableModel>([
export function isPinnable<T extends { model: string }>(
item: T,
): item is T & { model: PinnableModel } {
+ // Unjustified type cast. FIXME
return PINNABLE_MODELS.has(item.model as PinnableModel);
}
diff --git a/frontend/src/metabase/common/metrics-viewer/compact-schema.ts b/frontend/src/metabase/common/metrics-viewer/compact-schema.ts
index eadb98b32ce..2734cb20325 100644
--- a/frontend/src/metabase/common/metrics-viewer/compact-schema.ts
+++ b/frontend/src/metabase/common/metrics-viewer/compact-schema.ts
@@ -102,6 +102,7 @@ export function defineCompactSchema<T>(
const result: Record<string, unknown> = {};
for (const [fullKey, field] of normalized) {
+ // Unjustified type cast. FIXME
const val = (value as Record<string, unknown>)[fullKey];
if (field.optional && val === undefined) {
@@ -132,6 +133,7 @@ export function defineCompactSchema<T>(
return null;
}
+ // Unjustified type cast. FIXME
const obj = raw as Record<string, unknown>;
const result: Record<string, unknown> = {};
@@ -164,6 +166,7 @@ export function defineCompactSchema<T>(
}
}
+ // Unjustified type cast. FIXME
return result as T;
},
};
diff --git a/frontend/src/metabase/common/search/search-location/search-location.unit.spec.ts b/frontend/src/metabase/common/search/search-location/search-location.unit.spec.ts
index a1555c7534f..ee8369f2442 100644
--- a/frontend/src/metabase/common/search/search-location/search-location.unit.spec.ts
+++ b/frontend/src/metabase/common/search/search-location/search-location.unit.spec.ts
@@ -9,24 +9,28 @@ import type { SearchAwareLocation } from "metabase/common/search/types";
describe("isSearchPageLocation", () => {
it("should return true for a search page location", () => {
const location = { pathname: "/search" };
+ // Unjustified type cast. FIXME
const result = isSearchPageLocation(location as SearchAwareLocation);
expect(result).toBe(true);
});
it("should return true for a search page location with query params", () => {
const location = { pathname: "/search", search: "?q=test" };
+ // Unjustified type cast. FIXME
const result = isSearchPageLocation(location as SearchAwareLocation);
expect(result).toBe(true);
});
it('should return false for non-search location that might have "search" in the path', () => {
const location = { pathname: "/collection/1-search" };
+ // Unjustified type cast. FIXME
const result = isSearchPageLocation(location as SearchAwareLocation);
expect(result).toBe(false);
});
it("should return false for non-search location", () => {
const location = { pathname: "/some-page" };
+ // Unjustified type cast. FIXME
const result = isSearchPageLocation(location as SearchAwareLocation);
expect(result).toBe(false);
});
@@ -38,6 +42,7 @@ describe("getSearchTextFromLocation", () => {
pathname: "/search",
query: { q: "test" },
};
+ // Unjustified type cast. FIXME
expect(getSearchTextFromLocation(location as SearchAwareLocation)).toBe(
"test",
);
@@ -50,6 +55,7 @@ describe("getSearchTextFromLocation", () => {
q: "test",
},
};
+ // Unjustified type cast. FIXME
expect(getSearchTextFromLocation(location as SearchAwareLocation)).toBe("");
});
});
@@ -62,6 +68,7 @@ describe("getFiltersFromLocation", () => {
[SearchFilterKeys.Type]: ["app", "database"],
},
};
+ // Unjustified type cast. FIXME
expect(getFiltersFromLocation(location as SearchAwareLocation)).toEqual({
[SearchFilterKeys.Type]: ["app", "database"],
});
@@ -74,6 +81,7 @@ describe("getFiltersFromLocation", () => {
[SearchFilterKeys.Type]: ["app", "database"],
},
};
+ // Unjustified type cast. FIXME
expect(getFiltersFromLocation(location as SearchAwareLocation)).toEqual({});
});
diff --git a/frontend/src/metabase/common/utils/card.ts b/frontend/src/metabase/common/utils/card.ts
index d1b331947c6..136e3d7c01b 100644
--- a/frontend/src/metabase/common/utils/card.ts
+++ b/frontend/src/metabase/common/utils/card.ts
@@ -252,10 +252,12 @@ export function applyParameters(
if (mapping) {
// mapped target, e.x. on a dashboard
queryParameter.target = mapping.target;
+ // Unjustified type cast. FIXME
datasetQuery.parameters.push(queryParameter as UiParameter);
} else if (parameter.target) {
// inline target, e.x. on a card
queryParameter.target = parameter.target;
+ // Unjustified type cast. FIXME
datasetQuery.parameters.push(queryParameter as UiParameter);
}
diff --git a/frontend/src/metabase/common/utils/database.unit.spec.ts b/frontend/src/metabase/common/utils/database.unit.spec.ts
index 8bf3a4fbb63..9d1cd0040cf 100644
--- a/frontend/src/metabase/common/utils/database.unit.spec.ts
+++ b/frontend/src/metabase/common/utils/database.unit.spec.ts
@@ -47,7 +47,9 @@ describe("database routing utility functions", () => {
"with cards using non-routing databases",
{
dashcards: [
+ // Unjustified type cast. FIXME
{
+ // Unjustified type cast. FIXME
card: { database_id: 1 } as Card,
} as any,
],
@@ -57,6 +59,7 @@ describe("database routing utility functions", () => {
[
"with main card using routing-enabled database",
{
+ // Unjustified type cast. FIXME
dashcards: [{ card: { database_id: 2 } as Card }],
},
true,
@@ -65,8 +68,11 @@ describe("database routing utility functions", () => {
"with series card using routing-enabled database",
{
dashcards: [
+ // Unjustified type cast. FIXME
{
+ // Unjustified type cast. FIXME
card: { database_id: 1 } as Card,
+ // Unjustified type cast. FIXME
series: [{ database_id: 2 } as Card],
} as any,
],
@@ -77,7 +83,9 @@ describe("database routing utility functions", () => {
"with mixed cards where some use routing",
{
dashcards: [
+ // Unjustified type cast. FIXME
{ card: { database_id: 1 } as Card },
+ // Unjustified type cast. FIXME
{ card: { database_id: 2 } as Card },
],
},
@@ -86,6 +94,7 @@ describe("database routing utility functions", () => {
])("returns %s for dashboard %s", (_, dashboard, expected) => {
expect(
dashboardUsesRoutingEnabledDatabases(
+ // Unjustified type cast. FIXME
dashboard as Pick<Dashboard, "dashcards">,
mockDatabases,
),
diff --git a/frontend/src/metabase/common/utils/fields.ts b/frontend/src/metabase/common/utils/fields.ts
index 56e3cd71ffe..c3d670a856e 100644
--- a/frontend/src/metabase/common/utils/fields.ts
+++ b/frontend/src/metabase/common/utils/fields.ts
@@ -573,6 +573,7 @@ export const FIELD_SEMANTIC_TYPES: FieldSemanticType[] = [
export const FIELD_SEMANTIC_TYPES_MAP = FIELD_SEMANTIC_TYPES.reduce(
(map, type) => Object.assign({}, map, { [type.id]: type }),
+ // Unjustified type cast. FIXME
{} as Record<FieldSemanticType["id"], FieldSemanticType>,
);
diff --git a/frontend/src/metabase/dashboard/actions/actions.ts b/frontend/src/metabase/dashboard/actions/actions.ts
index 2aecab45410..d519588e6d5 100644
--- a/frontend/src/metabase/dashboard/actions/actions.ts
+++ b/frontend/src/metabase/dashboard/actions/actions.ts
@@ -55,6 +55,7 @@ export const executeRowAction = async ({
);
const message = getActionExecutionMessage(
+ // Unjustified type cast. FIXME
dashcard.action as WritebackAction,
result,
);
diff --git a/frontend/src/metabase/dashboard/actions/cards-typed.ts b/frontend/src/metabase/dashboard/actions/cards-typed.ts
index 3dbc58eecb0..aa3f397c782 100644
--- a/frontend/src/metabase/dashboard/actions/cards-typed.ts
+++ b/frontend/src/metabase/dashboard/actions/cards-typed.ts
@@ -180,6 +180,7 @@ export const addCardToDashboard =
);
const dashcardId = generateTemporaryDashcardId();
+ // Unjustified type cast. FIXME
const dashcard = dispatch(
addDashCardToDashboard({
dashId,
@@ -309,6 +310,7 @@ export const addCardWithVisualization =
const [mainCard, ...secondaryCards] = cards;
const dashcardId = generateTemporaryDashcardId();
+ // Unjustified type cast. FIXME
const dashcard = dispatch(
addDashCardToDashboard({
dashId: getState().dashboard.dashboardId!,
diff --git a/frontend/src/metabase/dashboard/actions/cards.unit.spec.ts b/frontend/src/metabase/dashboard/actions/cards.unit.spec.ts
index bc21a15bf60..e7920c41ef3 100644
--- a/frontend/src/metabase/dashboard/actions/cards.unit.spec.ts
+++ b/frontend/src/metabase/dashboard/actions/cards.unit.spec.ts
@@ -176,6 +176,7 @@ function setup({
dashcards: _.indexBy(dashcards, "id"),
});
+ // Unjustified type cast. FIXME
const store = getMainStore(
createMockState({ dashboard: dashboardState }),
) as Store<State>;
diff --git a/frontend/src/metabase/dashboard/actions/data-fetching.ts b/frontend/src/metabase/dashboard/actions/data-fetching.ts
index 9ed38056a04..f59af67338d 100644
--- a/frontend/src/metabase/dashboard/actions/data-fetching.ts
+++ b/frontend/src/metabase/dashboard/actions/data-fetching.ts
@@ -333,6 +333,7 @@ export const fetchCardDataAction = createAsyncThunk<
const runQuery = makePivotAwareQueryRunner(dispatch, controller.signal);
if (dashboardType === "public") {
+ // Unjustified type cast. FIXME
result = (await fetchDataOrError(
runQuery(publicApi.endpoints.getPublicDashcardQuery, card, metadata, {
// In public dashboards `dashboard_id` holds the public UUID string.
@@ -346,6 +347,7 @@ export const fetchCardDataAction = createAsyncThunk<
}),
)) as Dataset | { error: unknown };
} else if (dashboardType === "embed") {
+ // Unjustified type cast. FIXME
result = (await fetchDataOrError(
runQuery(embedApi.endpoints.getEmbedDashcardQuery, card, metadata, {
// In embedded dashboards `dashboard_id` holds the embed token string.
@@ -359,6 +361,7 @@ export const fetchCardDataAction = createAsyncThunk<
}),
)) as Dataset | { error: unknown };
} else if (dashboardType === "transient" || dashboardType === "inline") {
+ // Unjustified type cast. FIXME
result = (await fetchDataOrError(
runAdhocDatasetQuery(
dispatch,
@@ -386,6 +389,7 @@ export const fetchCardDataAction = createAsyncThunk<
// new dashcards and new additional series cards aren't yet saved to the dashboard, so they need to be run using the card query endpoint
if (shouldUseCardQueryEndpoint) {
+ // Unjustified type cast. FIXME
result = (await fetchDataOrError(
runQuery(cardApi.endpoints.getCardQuery, card, metadata, {
cardId: card.id,
@@ -393,6 +397,7 @@ export const fetchCardDataAction = createAsyncThunk<
}),
)) as Dataset | { error: unknown };
} else {
+ // Unjustified type cast. FIXME
result = (await fetchDataOrError(
runQuery(
dashboardApi.endpoints.getDashboardCardQuery,
@@ -448,6 +453,7 @@ const HTTP1_CONCURRENT_CARD_FETCH_LIMIT = 5;
function getCardsFetchingConcurrencyLimit(): number {
try {
+ // Unjustified type cast. FIXME
const [navigationEntry] = performance.getEntriesByType(
"navigation",
) as PerformanceNavigationTiming[];
diff --git a/frontend/src/metabase/dashboard/actions/data-fetching.unit.spec.ts b/frontend/src/metabase/dashboard/actions/data-fetching.unit.spec.ts
index 0d18fc03f65..0877f7f4217 100644
--- a/frontend/src/metabase/dashboard/actions/data-fetching.unit.spec.ts
+++ b/frontend/src/metabase/dashboard/actions/data-fetching.unit.spec.ts
@@ -279,6 +279,7 @@ describe("fetchDashboard", () => {
// dashboards otherwise fail to load).
const token = "header.payload.signature";
const dashboard = createMockDashboard({
+ // Unjustified type cast. FIXME
id: token as unknown as number,
dashcards: [
createMockVirtualDashCard({
@@ -425,6 +426,7 @@ describe("fetchDashboardCardData", () => {
8,
);
+ // Unjustified type cast. FIXME
await fetchDashboardCardData()(dispatch as never, getState as never);
expect(getMaxConcurrent()).toBe(5);
@@ -506,7 +508,9 @@ describe("fetchDashboardCardData", () => {
// Start loading Tab 1 (slow query)
const tab1Fetch = fetchDashboardCardData()(
+ // Unjustified type cast. FIXME
dispatch as never,
+ // Unjustified type cast. FIXME
getState as never,
);
@@ -516,7 +520,9 @@ describe("fetchDashboardCardData", () => {
// Switch to Tab 2
(state.dashboard as DashboardState).selectedTabId = tab2.id;
const tab2Fetch = fetchDashboardCardData()(
+ // Unjustified type cast. FIXME
dispatch as never,
+ // Unjustified type cast. FIXME
getState as never,
);
@@ -529,7 +535,9 @@ describe("fetchDashboardCardData", () => {
// and reused — no new query execution.
(state.dashboard as DashboardState).selectedTabId = tab1.id;
const backToTab1Fetch = fetchDashboardCardData()(
+ // Unjustified type cast. FIXME
dispatch as never,
+ // Unjustified type cast. FIXME
getState as never,
);
@@ -550,6 +558,7 @@ describe("reloadDashboardCards", () => {
8,
);
+ // Unjustified type cast. FIXME
await reloadDashboardCards()(dispatch as never, getState as never);
expect(getMaxConcurrent()).toBe(5);
diff --git a/frontend/src/metabase/dashboard/actions/getNewCardUrl.ts b/frontend/src/metabase/dashboard/actions/getNewCardUrl.ts
index 16a7c0eb41a..6b6344c4fdb 100644
--- a/frontend/src/metabase/dashboard/actions/getNewCardUrl.ts
+++ b/frontend/src/metabase/dashboard/actions/getNewCardUrl.ts
@@ -74,6 +74,7 @@ export const getNewCardUrl = ({
try {
const { isNative } = Lib.queryDisplayInfo(nextQuestion.query());
if (isNative) {
+ // Unjustified type cast. FIXME
const nativeQuery = nextQuestion.legacyNativeQuery() as NativeQuery;
return Urls.question(nextQuestion, {
query: remapParameterValuesToTemplateTags(
diff --git a/frontend/src/metabase/dashboard/actions/getNewCardUrl.unit.spec.ts b/frontend/src/metabase/dashboard/actions/getNewCardUrl.unit.spec.ts
index 0795ab33600..d2250eead04 100644
--- a/frontend/src/metabase/dashboard/actions/getNewCardUrl.unit.spec.ts
+++ b/frontend/src/metabase/dashboard/actions/getNewCardUrl.unit.spec.ts
@@ -101,6 +101,7 @@ describe("remapParameterValuesToTemplateTags", () => {
"dashboard-parameter-4": "ddd",
};
+ // Unjustified type cast. FIXME
const dashboardParameters = [
{
id: "dashboard-parameter-1",
@@ -123,6 +124,7 @@ describe("remapParameterValuesToTemplateTags", () => {
},
] as any;
+ // Unjustified type cast. FIXME
const templateTags = [
{ name: "template-tag-1" },
{ name: "template-tag-2" },
diff --git a/frontend/src/metabase/dashboard/actions/parameters.tsx b/frontend/src/metabase/dashboard/actions/parameters.tsx
index 63e36840fb9..65b58cef850 100644
--- a/frontend/src/metabase/dashboard/actions/parameters.tsx
+++ b/frontend/src/metabase/dashboard/actions/parameters.tsx
@@ -951,6 +951,7 @@ export const setParameterTemporalUnits = createThunkAction(
temporal_units: temporalUnits,
default:
parameter.default &&
+ // Unjustified type cast. FIXME
temporalUnits.includes(parameter.default as TemporalUnit)
? parameter.default
: undefined,
diff --git a/frontend/src/metabase/dashboard/actions/save.ts b/frontend/src/metabase/dashboard/actions/save.ts
index 809a6cfc8b5..2d0025209d9 100644
--- a/frontend/src/metabase/dashboard/actions/save.ts
+++ b/frontend/src/metabase/dashboard/actions/save.ts
@@ -154,6 +154,7 @@ export const updateDashboardAndCards = createThunkAction(
.map((dc) =>
dispatch(
cardApi.endpoints.updateCard.initiate(
+ // Unjustified type cast. FIXME
dc.card as UpdateCardRequest,
),
).unwrap(),
diff --git a/frontend/src/metabase/dashboard/actions/tabs.ts b/frontend/src/metabase/dashboard/actions/tabs.ts
index 645c3cf7dca..f93efb22a7c 100644
--- a/frontend/src/metabase/dashboard/actions/tabs.ts
+++ b/frontend/src/metabase/dashboard/actions/tabs.ts
@@ -212,6 +212,7 @@ export function getPrevDashAndTabs({
filterRemovedTabs?: boolean;
}) {
const dashId = state.dashboardId;
+ // Unjustified type cast. FIXME
const prevDash = dashId ? (state as DashboardState).dashboards[dashId] : null;
const prevTabs =
prevDash?.tabs?.filter((t) => !filterRemovedTabs || !t.isRemoved) ?? [];
@@ -499,6 +500,7 @@ export const tabsReducer = createReducer<DashboardState>(
builder.addCase(
_moveDashCardToTab,
(state, { payload: { dashCardId, destinationTabId } }) => {
+ // Unjustified type cast. FIXME
const dashboardState = { ...state } as unknown as DashboardState;
const dashCard = dashboardState.dashcards[dashCardId];
const dashboardId = checkNotNull(dashboardState.dashboardId);
diff --git a/frontend/src/metabase/dashboard/components/ActionSidebar/ActionSidebar.tsx b/frontend/src/metabase/dashboard/components/ActionSidebar/ActionSidebar.tsx
index a7b123a737d..b9f8f750c46 100644
--- a/frontend/src/metabase/dashboard/components/ActionSidebar/ActionSidebar.tsx
+++ b/frontend/src/metabase/dashboard/components/ActionSidebar/ActionSidebar.tsx
@@ -45,6 +45,7 @@ export function ActionSidebar() {
if (!dashboard?.dashcards || !dashcardId) {
return null;
}
+ // Unjustified type cast. FIXME
return dashboard.dashcards.find(
(dc) => dc?.id === dashcardId && isActionDashCard(dc),
) as ActionDashboardCard | undefined;
diff --git a/frontend/src/metabase/dashboard/components/ActionSidebar/ActionSidebar.unit.spec.tsx b/frontend/src/metabase/dashboard/components/ActionSidebar/ActionSidebar.unit.spec.tsx
index ff3a7e163f2..4164c7880e5 100644
--- a/frontend/src/metabase/dashboard/components/ActionSidebar/ActionSidebar.unit.spec.tsx
+++ b/frontend/src/metabase/dashboard/components/ActionSidebar/ActionSidebar.unit.spec.tsx
@@ -64,6 +64,7 @@ const setup = ({
sidebar={{
props: { dashcardId },
}}
+ // Unjustified type cast. FIXME
onUpdateDashCardVisualizationSettings={vizUpdateSpy as any}
closeSidebar={closeSpy}
navigateToNewCardFromDashboard={null}
diff --git a/frontend/src/metabase/dashboard/components/ActionViz/Action.tsx b/frontend/src/metabase/dashboard/components/ActionViz/Action.tsx
index 8711934b1ed..bd34313e917 100644
--- a/frontend/src/metabase/dashboard/components/ActionViz/Action.tsx
+++ b/frontend/src/metabase/dashboard/components/ActionViz/Action.tsx
@@ -129,6 +129,7 @@ const ActionComponent = ({
return (
<ActionVizForm
+ // Unjustified type cast. FIXME
action={dashcard.action as WritebackAction}
dashboard={dashboard}
dashcard={dashcard}
diff --git a/frontend/src/metabase/dashboard/components/AddCardSidebar/AddCardSidebar.tsx b/frontend/src/metabase/dashboard/components/AddCardSidebar/AddCardSidebar.tsx
index c8b74e5cf30..aa3c12fd796 100644
--- a/frontend/src/metabase/dashboard/components/AddCardSidebar/AddCardSidebar.tsx
+++ b/frontend/src/metabase/dashboard/components/AddCardSidebar/AddCardSidebar.tsx
@@ -15,6 +15,7 @@ export function AddCardSidebar() {
if (dashboard) {
addCardToDashboard({
dashId: dashboard.id,
+ // Unjustified type cast. FIXME
cardId: cardId as CardId,
tabId: selectedTabId,
});
diff --git a/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/LinkOptions/LinkOptions.tsx b/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/LinkOptions/LinkOptions.tsx
index 9c2d07e6aa9..490f08cb101 100644
--- a/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/LinkOptions/LinkOptions.tsx
+++ b/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/LinkOptions/LinkOptions.tsx
@@ -101,6 +101,7 @@ export function LinkOptions({
<CustomLinkText
updateSettings={updateSettings}
clickBehavior={
+ // Unjustified type cast. FIXME
clickBehavior as unknown as ArbitraryCustomDestinationClickBehavior
}
/>
diff --git a/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/LinkOptions/LinkedEntityPicker/LinkedEntityPicker.tsx b/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/LinkOptions/LinkedEntityPicker/LinkedEntityPicker.tsx
index 2645eeace40..ffb7684e925 100644
--- a/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/LinkOptions/LinkedEntityPicker/LinkedEntityPicker.tsx
+++ b/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/LinkOptions/LinkedEntityPicker/LinkedEntityPicker.tsx
@@ -39,6 +39,7 @@ import S from "../LinkOptions.module.css";
const LINK_TARGETS = {
// TODO: we can probably just have one picker to pick either a question or a dashboard
question: {
+ // Unjustified type cast. FIXME
Name: ({ id }: { id: CardId | DashboardId | undefined }) => (
<QuestionName id={id as CardId | undefined} />
),
@@ -206,6 +207,7 @@ export function LinkedEntityPicker({
tabId: undefined,
});
} else {
+ // Unjustified type cast. FIXME
updateSettings({
...clickBehavior,
targetId,
@@ -307,6 +309,7 @@ export function LinkedEntityPicker({
{isPickerOpen && (
<PickerComponent
title={getModalTitle()}
+ // Unjustified type cast. FIXME
value={initialPickerValue as any} // typescript isn't smart enough to know which picker we're using
onChange={(newTarget) => {
handleSelectLinkTargetEntityId(newTarget.id);
diff --git a/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/LinkOptions/LinkedEntityPicker/LinkedEntityPicker.unit.spec.tsx b/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/LinkOptions/LinkedEntityPicker/LinkedEntityPicker.unit.spec.tsx
index 57c8670f5ba..80a0a68f456 100644
--- a/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/LinkOptions/LinkedEntityPicker/LinkedEntityPicker.unit.spec.tsx
+++ b/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/LinkOptions/LinkedEntityPicker/LinkedEntityPicker.unit.spec.tsx
@@ -58,10 +58,12 @@ const PUBLIC_COLLECTION = createMockCollection({
});
const collectionInRootCollectionItem = createMockCollectionItem({
+ // Unjustified type cast. FIXME
id: PUBLIC_COLLECTION.id as number,
name: PUBLIC_COLLECTION.name,
model: "collection",
here: ["card", "dashboard"],
+ // Unjustified type cast. FIXME
collection_id: PUBLIC_COLLECTION.id as number,
});
@@ -165,6 +167,7 @@ describe("LinkedEntityPicker", () => {
describe("dashboard in a public collection", () => {
const dashboardInPublicCollection = createMockDashboard({
collection: PUBLIC_COLLECTION,
+ // Unjustified type cast. FIXME
collection_id: PUBLIC_COLLECTION.id as number,
});
@@ -227,6 +230,7 @@ describe("LinkedEntityPicker", () => {
describe("dashboard in a personal collection", () => {
const dashboardInPersonalCollection = createMockDashboard({
collection: PERSONAL_COLLECTION,
+ // Unjustified type cast. FIXME
collection_id: PERSONAL_COLLECTION.id as number,
});
@@ -303,6 +307,7 @@ describe("LinkedEntityPicker", () => {
describe("dashboard in a public collection", () => {
const dashboardInPublicCollection = createMockDashboard({
collection: PUBLIC_COLLECTION,
+ // Unjustified type cast. FIXME
collection_id: PUBLIC_COLLECTION.id as number,
});
@@ -373,6 +378,7 @@ describe("LinkedEntityPicker", () => {
describe("dashboard in a personal collection", () => {
const dashboardInPersonalCollection = createMockDashboard({
collection: PERSONAL_COLLECTION,
+ // Unjustified type cast. FIXME
collection_id: PERSONAL_COLLECTION.id as number,
});
diff --git a/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/TableClickBehaviorView/Column.tsx b/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/TableClickBehaviorView/Column.tsx
index 4ecb87f5cd9..b117192b295 100644
--- a/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/TableClickBehaviorView/Column.tsx
+++ b/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/TableClickBehaviorView/Column.tsx
@@ -25,6 +25,7 @@ function Quoted({ children }: { children: React.ReactNode }) {
}
const getLinkTargetName = (clickBehavior: CustomDestinationClickBehavior) => {
+ // Unjustified type cast. FIXME
const { targetId } = clickBehavior as EntityCustomDestinationClickBehavior;
if (clickBehavior.linkType === "url") {
return t`URL`;
@@ -32,6 +33,7 @@ const getLinkTargetName = (clickBehavior: CustomDestinationClickBehavior) => {
if (clickBehavior.linkType === "question") {
return (
<Quoted key="link-question">
+ {/* Unjustified type cast. FIXME */}
<QuestionName id={targetId as CardId} />
</Quoted>
);
@@ -85,6 +87,7 @@ interface ColumnProps {
export const Column = ({ column, clickBehavior, onClick }: ColumnProps) => (
<SidebarItem onClick={onClick}>
<SidebarItem.Icon
+ // Unjustified type cast. FIXME
name={getIconForField(column) as unknown as IconName}
c="core-brand"
size={18}
diff --git a/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/TableClickBehaviorView/TableClickBehaviorView.tsx b/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/TableClickBehaviorView/TableClickBehaviorView.tsx
index 60e7e88e5d3..676a0808492 100644
--- a/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/TableClickBehaviorView/TableClickBehaviorView.tsx
+++ b/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/TableClickBehaviorView/TableClickBehaviorView.tsx
@@ -58,6 +58,7 @@ export function TableClickBehaviorView({
getClickBehaviorForColumn,
onColumnClick,
}: Props) {
+ // Unjustified type cast. FIXME
const groupedColumns = useMemo(() => {
const withClickBehaviors = columns.map((column) => ({
column,
diff --git a/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/TypeSelector/TypeSelector.tsx b/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/TypeSelector/TypeSelector.tsx
index ff0937abd3f..94873b9ac1c 100644
--- a/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/TypeSelector/TypeSelector.tsx
+++ b/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/TypeSelector/TypeSelector.tsx
@@ -87,7 +87,8 @@ export function TypeSelector({
updateSettings(
value === "actionMenu"
? undefined
- : ({ type: value } as ClickBehavior),
+ : // Unjustified type cast. FIXME
+ ({ type: value } as ClickBehavior),
);
} else if (value !== "actionMenu") {
moveToNextPage();
diff --git a/frontend/src/metabase/dashboard/components/DashCard/DashCardMenu/DashCardMenu.unit.spec.tsx b/frontend/src/metabase/dashboard/components/DashCard/DashCardMenu/DashCardMenu.unit.spec.tsx
index 3534a10d7d0..384f3fca76e 100644
--- a/frontend/src/metabase/dashboard/components/DashCard/DashCardMenu/DashCardMenu.unit.spec.tsx
+++ b/frontend/src/metabase/dashboard/components/DashCard/DashCardMenu/DashCardMenu.unit.spec.tsx
@@ -248,6 +248,7 @@ describe("DashCardMenu", () => {
});
it("should not display query export options when query is running", async () => {
+ // Unjustified type cast. FIXME
setup({ result: {} as any });
await userEvent.click(getIcon("ellipsis"));
diff --git a/frontend/src/metabase/dashboard/components/DashCard/DashCardMenu/DashCardMenuItems.tsx b/frontend/src/metabase/dashboard/components/DashCard/DashCardMenu/DashCardMenuItems.tsx
index e4f20ac6b11..1cdfc289a66 100644
--- a/frontend/src/metabase/dashboard/components/DashCard/DashCardMenu/DashCardMenuItems.tsx
+++ b/frontend/src/metabase/dashboard/components/DashCard/DashCardMenu/DashCardMenuItems.tsx
@@ -42,6 +42,7 @@ export const DashCardMenuItems = ({
mode: "query" | "view" | "notebook" = "notebook",
) => dispatch(editQuestion(question, mode)),
} = useDashboardContext();
+ // Unjustified type cast. FIXME
const dashcardMenuItems = dashcardMenu as
| DashboardCardCustomMenuItem
| undefined;
diff --git a/frontend/src/metabase/dashboard/components/DashCard/DashCardVisualization.tsx b/frontend/src/metabase/dashboard/components/DashCard/DashCardVisualization.tsx
index 07e25f3fc87..01efbac3cba 100644
--- a/frontend/src/metabase/dashboard/components/DashCard/DashCardVisualization.tsx
+++ b/frontend/src/metabase/dashboard/components/DashCard/DashCardVisualization.tsx
@@ -257,6 +257,7 @@ export function DashCardVisualization({
dataSources,
);
const card = extendCardWithDashcardSettings(
+ // Unjustified type cast. FIXME
{
// Visualizer click handling code expect visualizer cards not to have card.id
name: dashcard.card.name,
@@ -275,6 +276,7 @@ export function DashCardVisualization({
const series: RawSeries = [
{
card,
+ // Unjustified type cast. FIXME
data: mergeVisualizerData({
columns,
columnValuesMapping,
@@ -325,6 +327,7 @@ export function DashCardVisualization({
const disableClickBehavior =
getVisualizationRaw(series)?.disableClickBehavior;
if (isVirtualDashCard(dashcard) || disableClickBehavior) {
+ // Unjustified type cast. FIXME
const virtualDashcardType = getVirtualCardType(
dashcard,
) as VirtualCardDisplay;
@@ -443,6 +446,7 @@ export function DashCardVisualization({
const actionButtons = useMemo(() => {
const cardId = dashcard.card_id ?? dashcard.card?.id;
const cardResult = cardId ? datasets?.[cardId] : undefined;
+ // Unjustified type cast. FIXME
const result = cardResult ?? (series[0] as unknown as Dataset);
const showMenu =
diff --git a/frontend/src/metabase/dashboard/components/Dashboard/Dashboard.tsx b/frontend/src/metabase/dashboard/components/Dashboard/Dashboard.tsx
index 65d3b2bac6e..abe54b0e999 100644
--- a/frontend/src/metabase/dashboard/components/Dashboard/Dashboard.tsx
+++ b/frontend/src/metabase/dashboard/components/Dashboard/Dashboard.tsx
@@ -145,6 +145,7 @@ type DashboardComponentType = typeof DashboardDefaultView & {
RefreshPeriod: typeof RefreshWidget;
};
+// Unjustified type cast. FIXME
const DashboardComponent = DashboardDefaultView as DashboardComponentType;
DashboardComponent.Header = DashboardHeader;
DashboardComponent.Grid = Grid;
diff --git a/frontend/src/metabase/dashboard/components/DashboardGrid.tsx b/frontend/src/metabase/dashboard/components/DashboardGrid.tsx
index 900bb173f2d..7dca00176d9 100644
--- a/frontend/src/metabase/dashboard/components/DashboardGrid.tsx
+++ b/frontend/src/metabase/dashboard/components/DashboardGrid.tsx
@@ -342,6 +342,7 @@ class DashboardGridInner extends Component<
isEditing = this.props.isEditing,
selectedTabId = this.props.selectedTabId,
) => {
+ // Unjustified type cast. FIXME
return getVisibleCards(
cards,
visibleCardIds,
@@ -364,6 +365,7 @@ class DashboardGridInner extends Component<
getRowHeight() {
const { width } = this.props;
+ // Unjustified type cast. FIXME
const contentViewportElement = this.context as any;
const hasScroll =
contentViewportElement?.clientHeight <
@@ -766,6 +768,7 @@ const DashboardGrid = forwardRef<
);
});
+// Unjustified type cast. FIXME
export const DashboardGridConnected = _.compose(
ExplicitSize(),
connector,
diff --git a/frontend/src/metabase/dashboard/components/DashboardHeader/DashboardHeaderButtonRow/DashboardSharingMenu/DashboardSharingMenu.unit.spec.tsx b/frontend/src/metabase/dashboard/components/DashboardHeader/DashboardHeaderButtonRow/DashboardSharingMenu/DashboardSharingMenu.unit.spec.tsx
index 9585a41bacf..31ea414c7f7 100644
--- a/frontend/src/metabase/dashboard/components/DashboardHeader/DashboardHeaderButtonRow/DashboardSharingMenu/DashboardSharingMenu.unit.spec.tsx
+++ b/frontend/src/metabase/dashboard/components/DashboardHeader/DashboardHeaderButtonRow/DashboardSharingMenu/DashboardSharingMenu.unit.spec.tsx
@@ -327,6 +327,7 @@ describe("DashboardSharingMenu", () => {
method: "POST",
})[0];
return JSON.parse(
+ // Unjustified type cast. FIXME
await (call.options?.body as unknown as Promise<string>),
);
};
diff --git a/frontend/src/metabase/dashboard/components/DashboardHeader/DashboardHeaderView.tsx b/frontend/src/metabase/dashboard/components/DashboardHeader/DashboardHeaderView.tsx
index 8a008a3bbc7..5db05dbcdec 100644
--- a/frontend/src/metabase/dashboard/components/DashboardHeader/DashboardHeaderView.tsx
+++ b/frontend/src/metabase/dashboard/components/DashboardHeader/DashboardHeaderView.tsx
@@ -115,6 +115,7 @@ export function DashboardHeaderView({
isSidebarOpen && !isInfoSidebarOpen && !isSettingsSidebarOpen,
})}
style={
+ // Unjustified type cast. FIXME
{
"--sidebar-width": `${SIDEBAR_WIDTH}px`,
} as React.CSSProperties
diff --git a/frontend/src/metabase/dashboard/components/DashboardInfoSidebar/DashboardEntityIdCard/tests/premium.unit.spec.tsx b/frontend/src/metabase/dashboard/components/DashboardInfoSidebar/DashboardEntityIdCard/tests/premium.unit.spec.tsx
index 59f9c475128..129d526a949 100644
--- a/frontend/src/metabase/dashboard/components/DashboardInfoSidebar/DashboardEntityIdCard/tests/premium.unit.spec.tsx
+++ b/frontend/src/metabase/dashboard/components/DashboardInfoSidebar/DashboardEntityIdCard/tests/premium.unit.spec.tsx
@@ -28,16 +28,19 @@ describe("DashboardEntityIdCard (EE with token)", () => {
createMockDashboardTab({
id: 1,
name: "Tab 1",
+ // Unjustified type cast. FIXME
entity_id: "tab-1-entity-id" as BaseEntityId,
}),
createMockDashboardTab({
id: 2,
name: "Tab 2",
+ // Unjustified type cast. FIXME
entity_id: "tab-2-entity-id" as BaseEntityId,
}),
createMockDashboardTab({
id: 3,
name: "Tab 3",
+ // Unjustified type cast. FIXME
entity_id: "tab-3-entity-id" as BaseEntityId,
}),
];
@@ -57,6 +60,7 @@ describe("DashboardEntityIdCard (EE with token)", () => {
tabs.forEach(async (tab) => {
expect(
await screen.findByRole("listitem", { name: tab.name }),
+ // Unjustified type cast. FIXME
).toHaveTextContent(tab.entity_id as string);
});
});
diff --git a/frontend/src/metabase/dashboard/components/DashboardInfoSidebar/tests/common.unit.spec.ts b/frontend/src/metabase/dashboard/components/DashboardInfoSidebar/tests/common.unit.spec.ts
index ded4a342485..bf793352821 100644
--- a/frontend/src/metabase/dashboard/components/DashboardInfoSidebar/tests/common.unit.spec.ts
+++ b/frontend/src/metabase/dashboard/components/DashboardInfoSidebar/tests/common.unit.spec.ts
@@ -195,6 +195,7 @@ describe("DashboardInfoSidebar", () => {
describe("entity id display", () => {
it("should not show entity ids without serialization feature", async () => {
const dashboard = createMockDashboard({
+ // Unjustified type cast. FIXME
entity_id: "jenny8675309" as Dashboard["entity_id"],
});
await setup({ dashboard });
diff --git a/frontend/src/metabase/dashboard/components/DashboardInfoSidebar/tests/enterprise.unit.spec.ts b/frontend/src/metabase/dashboard/components/DashboardInfoSidebar/tests/enterprise.unit.spec.ts
index cb45062c851..4f73f9fc3c3 100644
--- a/frontend/src/metabase/dashboard/components/DashboardInfoSidebar/tests/enterprise.unit.spec.ts
+++ b/frontend/src/metabase/dashboard/components/DashboardInfoSidebar/tests/enterprise.unit.spec.ts
@@ -15,6 +15,7 @@ describe("DashboardInfoSidebar > enterprise", () => {
describe("entity id display", () => {
it("should not show entity ids without serialization feature", async () => {
const dashboard = createMockDashboard({
+ // Unjustified type cast. FIXME
entity_id: "jenny8675309" as Dashboard["entity_id"],
});
await setupEnterprise({ dashboard });
diff --git a/frontend/src/metabase/dashboard/components/DashboardInfoSidebar/tests/premium.unit.spec.ts b/frontend/src/metabase/dashboard/components/DashboardInfoSidebar/tests/premium.unit.spec.ts
index 1fef1e043fd..69ed13770eb 100644
--- a/frontend/src/metabase/dashboard/components/DashboardInfoSidebar/tests/premium.unit.spec.ts
+++ b/frontend/src/metabase/dashboard/components/DashboardInfoSidebar/tests/premium.unit.spec.ts
@@ -28,6 +28,7 @@ describe("DashboardInfoSidebar > enterprise", () => {
describe("entity id display", () => {
it("should show entity ids only with serialization feature", async () => {
const dashboard = createMockDashboard({
+ // Unjustified type cast. FIXME
entity_id: "jenny8675309" as Dashboard["entity_id"],
});
await setupEnterprise({ dashboard });
diff --git a/frontend/src/metabase/dashboard/components/DashboardInfoSidebar/tests/setup.tsx b/frontend/src/metabase/dashboard/components/DashboardInfoSidebar/tests/setup.tsx
index 0a8a203622b..be669dce28e 100644
--- a/frontend/src/metabase/dashboard/components/DashboardInfoSidebar/tests/setup.tsx
+++ b/frontend/src/metabase/dashboard/components/DashboardInfoSidebar/tests/setup.tsx
@@ -68,6 +68,7 @@ export async function setup({
component={() => (
<MockDashboardContext
dashboard={dashboard}
+ // Unjustified type cast. FIXME
setDashboardAttributes={setDashboardAttribute as any}
closeSidebar={onClose}
>
diff --git a/frontend/src/metabase/dashboard/components/DashboardSettingsSidebar/DashboardSettingsSidebar.tsx b/frontend/src/metabase/dashboard/components/DashboardSettingsSidebar/DashboardSettingsSidebar.tsx
index 0d07934ece9..38548631aa2 100644
--- a/frontend/src/metabase/dashboard/components/DashboardSettingsSidebar/DashboardSettingsSidebar.tsx
+++ b/frontend/src/metabase/dashboard/components/DashboardSettingsSidebar/DashboardSettingsSidebar.tsx
@@ -35,6 +35,7 @@ export function DashboardSettingsSidebar() {
if (currentModal === "caching") {
return (
<PLUGIN_CACHING.SidebarCacheForm
+ // Unjustified type cast. FIXME
item={dashboard as CacheableDashboard}
model="dashboard"
isOpen={state.caching}
diff --git a/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/DashboardSubscriptionsSidebar.tsx b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/DashboardSubscriptionsSidebar.tsx
index ddf756be309..abbdb55daf6 100644
--- a/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/DashboardSubscriptionsSidebar.tsx
+++ b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/DashboardSubscriptionsSidebar.tsx
@@ -116,6 +116,7 @@ const getEditingPulseWithDefaults = (
const mapStateToProps = (state: State, props: { dashboard: Dashboard }) => ({
isAdmin: getUserIsAdmin(state),
pulse: getEditingPulseWithDefaults(state, props),
+ // Unjustified type cast. FIXME
formInput: getPulseFormInput(state) as ChannelApiResponse,
user: getUser(state),
});
@@ -344,6 +345,7 @@ function DashboardSubscriptionsSidebarInner({
return;
}
+ // Unjustified type cast. FIXME
const cleanedPulse = cleanPulse(pulse, formInput.channels as ChannelSpecs);
cleanedPulse.name = dashboard.name;
diff --git a/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/tests/setup.tsx b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/tests/setup.tsx
index 01b90f15b2f..66303eeb5ca 100644
--- a/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/tests/setup.tsx
+++ b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/tests/setup.tsx
@@ -70,6 +70,7 @@ function createDashboardState(
acc[card.id] = card;
return acc;
},
+ // Unjustified type cast. FIXME
{} as Record<number, DashboardCard>,
),
dashboards: {
@@ -159,6 +160,7 @@ export function setup({
};
}
+ // Unjustified type cast. FIXME
(mockIsEmbeddingSdk as jest.Mock).mockReturnValue(isEmbeddingSdk);
setupNotificationChannelsEndpoints(channelData.channels);
@@ -177,7 +179,9 @@ export function setup({
// Mock POST that updates the GET response
fetchMock.post("path:/api/pulse", ({ options }) => {
+ // Unjustified type cast. FIXME
const body = JSON.parse(options.body as string);
+ // Unjustified type cast. FIXME
const newPulse = { ...body, id: getNextId() } as DashboardSubscription;
pulses.push(newPulse);
return newPulse;
diff --git a/frontend/src/metabase/dashboard/components/DashboardTabs/DashboardTabs.unit.spec.tsx b/frontend/src/metabase/dashboard/components/DashboardTabs/DashboardTabs.unit.spec.tsx
index decf998298e..a6a9343ac67 100644
--- a/frontend/src/metabase/dashboard/components/DashboardTabs/DashboardTabs.unit.spec.tsx
+++ b/frontend/src/metabase/dashboard/components/DashboardTabs/DashboardTabs.unit.spec.tsx
@@ -125,6 +125,7 @@ function queryTab(numOrName: number | string) {
}
async function selectTab(num: number) {
+ // Unjustified type cast. FIXME
const selectedTab = queryTab(num) as HTMLElement;
await userEvent.click(selectedTab);
return selectedTab;
diff --git a/frontend/src/metabase/dashboard/components/ParameterLinkedFilters/ParameterLinkedFilters.unit.spec.tsx b/frontend/src/metabase/dashboard/components/ParameterLinkedFilters/ParameterLinkedFilters.unit.spec.tsx
index 1d4dc145533..feea34f7518 100644
--- a/frontend/src/metabase/dashboard/components/ParameterLinkedFilters/ParameterLinkedFilters.unit.spec.tsx
+++ b/frontend/src/metabase/dashboard/components/ParameterLinkedFilters/ParameterLinkedFilters.unit.spec.tsx
@@ -113,6 +113,7 @@ describe("ParameterLinkedFilters", () => {
parameter: createMockUiParameter({
id: "p1",
name: "P1",
+ // Unjustified type cast. FIXME
values_source_type: valuesSourceType as ValuesSourceType,
values_source_config: {
values: ["foo", "bar"],
diff --git a/frontend/src/metabase/dashboard/components/QuestionPicker/QuestionPicker.tsx b/frontend/src/metabase/dashboard/components/QuestionPicker/QuestionPicker.tsx
index d86ed09230c..02c6b9cd5de 100644
--- a/frontend/src/metabase/dashboard/components/QuestionPicker/QuestionPicker.tsx
+++ b/frontend/src/metabase/dashboard/components/QuestionPicker/QuestionPicker.tsx
@@ -44,6 +44,7 @@ export function QuestionPicker({ onSelect }: QuestionPickerProps) {
const userPersonalCollectionId = useSelector(getUserPersonalCollectionId);
const baseCollectionsById = useMemo(
() =>
+ // Unjustified type cast. FIXME
getExpandedCollectionsById(
allCollectionsList,
userPersonalCollectionId,
diff --git a/frontend/src/metabase/dashboard/components/QuestionPicker/hooks/use-collections-with-tenants.ts b/frontend/src/metabase/dashboard/components/QuestionPicker/hooks/use-collections-with-tenants.ts
index 8fbf2cfa3a1..f8911cd146b 100644
--- a/frontend/src/metabase/dashboard/components/QuestionPicker/hooks/use-collections-with-tenants.ts
+++ b/frontend/src/metabase/dashboard/components/QuestionPicker/hooks/use-collections-with-tenants.ts
@@ -20,8 +20,10 @@ export type ExpandedCollectionNode = Collection & {
};
export const SHARED_TENANT_COLLECTIONS_ROOT_ID =
+ // Unjustified type cast. FIXME
"shared-tenant-collections-root" as CollectionId;
+// Unjustified type cast. FIXME
export const COLLECTIONS_TOP_LEVEL_ID = "collections-top-level" as CollectionId;
/**
@@ -56,6 +58,7 @@ export function useCollectionsWithTenants(
return collectionsById;
}
+ // Unjustified type cast. FIXME
const sharedCollectionsById = getExpandedCollectionsById(
sharedTenantCollections,
userPersonalCollectionId,
@@ -90,6 +93,7 @@ export function mergeSharedCollections(
displayName: string,
): Record<CollectionId, Collection> {
const sharedRoot = sharedCollectionsById[ROOT_COLLECTION.id];
+ // Unjustified type cast. FIXME
const rootCollection = baseCollectionsById[
ROOT_COLLECTION.id
] as ExpandedCollectionNode;
@@ -151,6 +155,7 @@ export function mergeSharedCollections(
continue;
}
+ // Unjustified type cast. FIXME
mergedCollectionsById[id as CollectionId] = {
...collection,
@@ -183,12 +188,14 @@ export function mergeSharedCollections(
continue; // already rewritten above
}
+ // Unjustified type cast. FIXME
const collectionNode = collection as ExpandedCollectionNode;
if (!collectionNode.path) {
continue;
}
+ // Unjustified type cast. FIXME
mergedCollectionsById[id as CollectionId] = {
...collectionNode,
// Rewrite path: Collections > Our Analytics > ...
diff --git a/frontend/src/metabase/dashboard/components/QuestionPicker/hooks/use-collections-with-tenants.unit.spec.ts b/frontend/src/metabase/dashboard/components/QuestionPicker/hooks/use-collections-with-tenants.unit.spec.ts
index af97ccf2000..cd5fa367f82 100644
--- a/frontend/src/metabase/dashboard/components/QuestionPicker/hooks/use-collections-with-tenants.unit.spec.ts
+++ b/frontend/src/metabase/dashboard/components/QuestionPicker/hooks/use-collections-with-tenants.unit.spec.ts
@@ -34,6 +34,7 @@ const createMockExpandedCollection = (
function setupHook({
useTenants = false,
+ // Unjustified type cast. FIXME
sharedCollections = [] as Collection[],
} = {}) {
setupCollectionTreeEndpoint(sharedCollections);
@@ -43,6 +44,7 @@ function setupHook({
path: [],
});
+ // Unjustified type cast. FIXME
const collectionsById = {
[ROOT_COLLECTION.id]: baseRoot,
} as Record<CollectionId, Collection>;
@@ -95,6 +97,7 @@ describe("useCollectionsWithTenants", () => {
it("should merge shared collections when tenants are enabled", async () => {
const tenantCollection = createMockCollection({
+ // Unjustified type cast. FIXME
id: 100 as CollectionId,
name: "Tenant A",
location: "/",
@@ -141,9 +144,12 @@ function setup() {
ourAnalyticsSubCollection.children = [ourAnalyticsNestedCollection];
ourAnalyticsNestedCollection.parent = ourAnalyticsSubCollection;
+ // Unjustified type cast. FIXME
const baseCollectionsById = {
[ROOT_COLLECTION.id]: baseRoot,
+ // Unjustified type cast. FIXME
[200 as CollectionId]: ourAnalyticsSubCollection,
+ // Unjustified type cast. FIXME
[201 as CollectionId]: ourAnalyticsNestedCollection,
} as Record<CollectionId, Collection>;
@@ -175,7 +181,9 @@ function setup() {
baseCollectionsById,
{
[ROOT_COLLECTION.id]: sharedRoot,
+ // Unjustified type cast. FIXME
[100 as CollectionId]: tenantA,
+ // Unjustified type cast. FIXME
[300 as CollectionId]: subCollection,
},
"Shared collections",
@@ -193,6 +201,7 @@ function setup() {
describe("mergeSharedCollections", () => {
it("should create a top-level Collections node with Our analytics and Shared collections as siblings", () => {
const { collectionsById } = setup();
+ // Unjustified type cast. FIXME
const expanded = collectionsById as Record<
CollectionId,
ExpandedCollectionNode
@@ -236,6 +245,7 @@ describe("mergeSharedCollections", () => {
it("should re-parent children and rewrite paths through the top-level and synthetic root", () => {
const { collectionsById, tenantA, subCollection } = setup();
+ // Unjustified type cast. FIXME
const expanded = collectionsById as Record<
CollectionId,
ExpandedCollectionNode
diff --git a/frontend/src/metabase/dashboard/components/grid/GridLayout.tsx b/frontend/src/metabase/dashboard/components/grid/GridLayout.tsx
index 75d84442590..17f16fdc3d3 100644
--- a/frontend/src/metabase/dashboard/components/grid/GridLayout.tsx
+++ b/frontend/src/metabase/dashboard/components/grid/GridLayout.tsx
@@ -86,6 +86,7 @@ export function GridLayout<T extends { id: number | null }>(
const theme = useMantineTheme();
const [currentBreakpoint, setCurrentBreakpoint] = useState(
+ // Unjustified type cast. FIXME
(ReactGridLayout as any).utils.getBreakpointFromWidth(
breakpoints,
gridWidth,
diff --git a/frontend/src/metabase/dashboard/components/grid/GridLayout.unit.spec.tsx b/frontend/src/metabase/dashboard/components/grid/GridLayout.unit.spec.tsx
index 7475538317e..ece567bbaa8 100644
--- a/frontend/src/metabase/dashboard/components/grid/GridLayout.unit.spec.tsx
+++ b/frontend/src/metabase/dashboard/components/grid/GridLayout.unit.spec.tsx
@@ -42,7 +42,9 @@ const defaultProps = {
cols: { desktop: 12, mobile: 6 },
width: 1200,
margin: {
+ // Unjustified type cast. FIXME
desktop: [10, 10] as [number, number],
+ // Unjustified type cast. FIXME
mobile: [5, 5] as [number, number],
},
rowHeight: 100,
diff --git a/frontend/src/metabase/dashboard/containers/ArchiveDashboardModal.unit.spec.tsx b/frontend/src/metabase/dashboard/containers/ArchiveDashboardModal.unit.spec.tsx
index 1a0e467c553..73770f3e35f 100644
--- a/frontend/src/metabase/dashboard/containers/ArchiveDashboardModal.unit.spec.tsx
+++ b/frontend/src/metabase/dashboard/containers/ArchiveDashboardModal.unit.spec.tsx
@@ -17,6 +17,7 @@ const setup = ({
slug?: string;
onClose?: () => void;
} = {}) => {
+ // Unjustified type cast. FIXME
const props = {
onClose,
params: { slug },
diff --git a/frontend/src/metabase/dashboard/containers/AutomaticDashboardApp/SuggestionsSidebar.tsx b/frontend/src/metabase/dashboard/containers/AutomaticDashboardApp/SuggestionsSidebar.tsx
index 40c668e4a48..0d0792df5bd 100644
--- a/frontend/src/metabase/dashboard/containers/AutomaticDashboardApp/SuggestionsSidebar.tsx
+++ b/frontend/src/metabase/dashboard/containers/AutomaticDashboardApp/SuggestionsSidebar.tsx
@@ -49,6 +49,7 @@ const SuggestionsList = ({
}) => (
<Box component="ol" my="sm">
{_.keys(suggestions).map((s, index) => {
+ // Unjustified type cast. FIXME
const suggestionKey = s as keyof RelatedDashboardXRays;
const suggestionItem = suggestions[suggestionKey];
return (
diff --git a/frontend/src/metabase/dashboard/containers/DashboardApp/DashboardApp.tsx b/frontend/src/metabase/dashboard/containers/DashboardApp/DashboardApp.tsx
index 3c6e05bf0c7..28186654ee9 100644
--- a/frontend/src/metabase/dashboard/containers/DashboardApp/DashboardApp.tsx
+++ b/frontend/src/metabase/dashboard/containers/DashboardApp/DashboardApp.tsx
@@ -104,6 +104,7 @@ export const DashboardApp = ({
const parameterQueryParams = location.query;
const dashboardId =
+ // Unjustified type cast. FIXME
_dashboardId || (Urls.extractEntityId(params.slug) as DashboardId);
useRegisterDashboardMetabotContext();
@@ -155,6 +156,7 @@ export const DashboardApp = ({
setErrorPage({ ...error, context: "dashboard" });
} else {
console.error(error);
+ // Unjustified type cast. FIXME
setError(error as string);
}
}
diff --git a/frontend/src/metabase/dashboard/context/mock-context.tsx b/frontend/src/metabase/dashboard/context/mock-context.tsx
index e3b0a2214c7..a648334711e 100644
--- a/frontend/src/metabase/dashboard/context/mock-context.tsx
+++ b/frontend/src/metabase/dashboard/context/mock-context.tsx
@@ -45,6 +45,7 @@ const DashboardContextWithReduxProps = (
);
};
+// Unjustified type cast. FIXME
const ConnectedDashboardContextWithReduxProps = connect(
mapStateToProps,
mapDispatchToProps,
diff --git a/frontend/src/metabase/dashboard/hooks/use-dashboard-url-query.unit.spec.tsx b/frontend/src/metabase/dashboard/hooks/use-dashboard-url-query.unit.spec.tsx
index ba2518c660a..df5868b7f8d 100644
--- a/frontend/src/metabase/dashboard/hooks/use-dashboard-url-query.unit.spec.tsx
+++ b/frontend/src/metabase/dashboard/hooks/use-dashboard-url-query.unit.spec.tsx
@@ -65,6 +65,7 @@ function setup({
}),
};
+ // Unjustified type cast. FIXME
const location = {
pathname,
query,
@@ -80,6 +81,7 @@ function setup({
[dashboardId]: createMockStoreDashboard({
id: dashboardId,
parameters,
+ // Unjustified type cast. FIXME
tabs: tabs?.map((tab) => ({ ...tab }) as any),
}),
};
@@ -95,6 +97,7 @@ function setup({
});
const { store, unmount } = renderHookWithProviders(
+ // Unjustified type cast. FIXME
() => useDashboardUrlQuery(router as any, location),
{ storeInitialState },
);
@@ -104,8 +107,11 @@ function setup({
describe("useDashboardUrlQuery", () => {
beforeEach(() => {
+ // Unjustified type cast. FIXME
(push as jest.Mock).mockClear();
+ // Unjustified type cast. FIXME
(replace as jest.Mock).mockClear();
+ // Unjustified type cast. FIXME
(isEmbedPreview as jest.Mock).mockReturnValue(false);
});
@@ -135,6 +141,7 @@ describe("useDashboardUrlQuery", () => {
// The mount sync (previous query params were undefined) uses replace.
(push as jest.Mock).mockClear();
+ // Unjustified type cast. FIXME
(replace as jest.Mock).mockClear();
act(() => {
@@ -151,6 +158,7 @@ describe("useDashboardUrlQuery", () => {
});
it("does not sync when isEmbedPreview() is true", () => {
+ // Unjustified type cast. FIXME
(isEmbedPreview as jest.Mock).mockReturnValue(true);
setup({
diff --git a/frontend/src/metabase/dashboard/hooks/use-is-parameter-panel-sticky.unit.spec.tsx b/frontend/src/metabase/dashboard/hooks/use-is-parameter-panel-sticky.unit.spec.tsx
index 3be22df2e75..53f121ea5c4 100644
--- a/frontend/src/metabase/dashboard/hooks/use-is-parameter-panel-sticky.unit.spec.tsx
+++ b/frontend/src/metabase/dashboard/hooks/use-is-parameter-panel-sticky.unit.spec.tsx
@@ -26,7 +26,9 @@ describe("useIsParameterPanelSticky", () => {
const invokeIntersection = (isIntersecting: boolean) => {
act(() => {
intersectionCallback?.(
+ // Unjustified type cast. FIXME
[{ isIntersecting } as IntersectionObserverEntry],
+ // Unjustified type cast. FIXME
{} as IntersectionObserver,
);
});
diff --git a/frontend/src/metabase/dashboard/hooks/use-location-sync.ts b/frontend/src/metabase/dashboard/hooks/use-location-sync.ts
index 144079fee1f..91f3b57715e 100644
--- a/frontend/src/metabase/dashboard/hooks/use-location-sync.ts
+++ b/frontend/src/metabase/dashboard/hooks/use-location-sync.ts
@@ -20,6 +20,7 @@ const getDefaultDisplayOption = <
Key extends SYNCED_KEY,
>(
key: Key,
+ // Unjustified type cast. FIXME
): Value => DEFAULT_SYNCED_DASHBOARD_OPTIONS[key] as Value;
const isEmptyOrDefault = <
@@ -47,6 +48,7 @@ export const useLocationSync = <
const dispatch = useDispatch();
const previousValue = usePrevious(value) ?? null;
const hashOptions = parseHashOptions(location.hash);
+ // Unjustified type cast. FIXME
const hashValue = (hashOptions[key] ?? null) as Value | null;
const defaultValue = getDefaultDisplayOption<Value, Key>(key);
diff --git a/frontend/src/metabase/dashboard/selectors.ts b/frontend/src/metabase/dashboard/selectors.ts
index 7849d36ece9..2c184f1763e 100644
--- a/frontend/src/metabase/dashboard/selectors.ts
+++ b/frontend/src/metabase/dashboard/selectors.ts
@@ -714,6 +714,7 @@ export const getParameterMappingsBeforeEditing = createSelector(
}
map[parameterId][dashcard.id] =
+ // Unjustified type cast. FIXME
parameterMapping as DashboardParameterMapping;
}
}
diff --git a/frontend/src/metabase/dashboard/utils.ts b/frontend/src/metabase/dashboard/utils.ts
index 11d60e6d178..7c64817cb76 100644
--- a/frontend/src/metabase/dashboard/utils.ts
+++ b/frontend/src/metabase/dashboard/utils.ts
@@ -58,6 +58,7 @@ export function syncParametersAndEmbeddingParams(before: any, after: any) {
}
}
return memo;
+ // Unjustified type cast. FIXME
}, {} as any);
} else {
return before.embedding_params;
@@ -76,6 +77,7 @@ export function expandInlineDashboard(dashboard: Partial<Dashboard>) {
...dashcard,
id: _.uniqueId("dashcard"),
card: expandInlineCard(dashcard?.card),
+ // Unjustified type cast. FIXME
series: ((dashcard as any).series || []).map((card: Card) =>
expandInlineCard(card),
),
@@ -141,6 +143,7 @@ export function findDashCardForInlineParameter(
parameterId: ParameterId,
dashcards: BaseDashboardCard[],
): DashboardCardWithInlineFilters | undefined {
+ // Unjustified type cast. FIXME
return dashcards.find((dashcard) => {
if (hasInlineParameters(dashcard)) {
return dashcard.inline_parameters.some((id) => id === parameterId);
@@ -197,6 +200,7 @@ export function showVirtualDashCardInfoText(
export function getAllDashboardCards(dashboard: Dashboard) {
const results = [];
for (const dashcard of dashboard.dashcards) {
+ // Unjustified type cast. FIXME
const cards = [dashcard.card].concat((dashcard as any).series || []);
results.push(...cards.map((card) => ({ card, dashcard })));
}
@@ -276,6 +280,7 @@ export function getDashcardResultsError(
return permissionError;
}
+ // Unjustified type cast. FIXME
const staticEntityLoadingError = datasets.find((dataset) =>
isStaticEmbeddingEntityLoadingError(dataset.error, {
isGuestEmbed,
@@ -523,6 +528,7 @@ export function getClickBehaviorDescription(dashcard: DashboardCard) {
return noBehaviorMessage;
}
+ // Unjustified type cast. FIXME
const clickBehavior = dashcard.visualization_settings
.click_behavior as ClickBehavior;
diff --git a/frontend/src/metabase/dashboard/utils.unit.spec.ts b/frontend/src/metabase/dashboard/utils.unit.spec.ts
index e90a864e3be..0ad87b0fc12 100644
--- a/frontend/src/metabase/dashboard/utils.unit.spec.ts
+++ b/frontend/src/metabase/dashboard/utils.unit.spec.ts
@@ -57,6 +57,7 @@ describe("Dashboard utils", () => {
const successfulFetch = Promise.resolve(data);
+ // Unjustified type cast. FIXME
const result = (await fetchDataOrError(successfulFetch)) as any;
expect(result.error).toBeUndefined();
@@ -77,6 +78,7 @@ describe("Dashboard utils", () => {
const result = await fetchDataOrError(failedFetch);
expect(result).toBeTruthy();
+ // Unjustified type cast. FIXME
expect((result as { error: unknown }).error).toEqual(error);
});
diff --git a/frontend/src/metabase/dashboard/utils/dashboard-options.ts b/frontend/src/metabase/dashboard/utils/dashboard-options.ts
index f13b1a3aabb..baf919c0e68 100644
--- a/frontend/src/metabase/dashboard/utils/dashboard-options.ts
+++ b/frontend/src/metabase/dashboard/utils/dashboard-options.ts
@@ -79,6 +79,7 @@ export function getDefaultOptionForParameterSectionMap(): Record<
ParameterMappingOptions
> {
const sections = getDashboardParameterSections();
+ // Unjustified type cast. FIXME
const map = {} as Record<ParameterSectionId, ParameterMappingOptions>;
for (const section of sections) {
diff --git a/frontend/src/metabase/dashboard/utils/dashboard-options.unit.spec.tsx b/frontend/src/metabase/dashboard/utils/dashboard-options.unit.spec.tsx
index 4896239a6a2..a476debdc3f 100644
--- a/frontend/src/metabase/dashboard/utils/dashboard-options.unit.spec.tsx
+++ b/frontend/src/metabase/dashboard/utils/dashboard-options.unit.spec.tsx
@@ -29,6 +29,7 @@ describe("parameters/utils/dashboard-options", () => {
it("should have a string section", () => {
expect(
_.findWhere(getDashboardParameterSections(), {
+ // Unjustified type cast. FIXME
id: "bad-section-id" as ParameterSectionId,
}),
).not.toBeDefined();
diff --git a/frontend/src/metabase/dashboard/visualizations/IFrameViz/IFrameViz.styled.tsx b/frontend/src/metabase/dashboard/visualizations/IFrameViz/IFrameViz.styled.tsx
index d1646d1945c..87c6bdb1251 100644
--- a/frontend/src/metabase/dashboard/visualizations/IFrameViz/IFrameViz.styled.tsx
+++ b/frontend/src/metabase/dashboard/visualizations/IFrameViz/IFrameViz.styled.tsx
@@ -35,6 +35,7 @@ export const StyledInput = styled(Textarea)`
${interactiveDashcardElementCss}
`;
+// Unjustified type cast. FIXME
export const InteractiveText = styled(Text)<TextProps>`
${interactiveDashcardElementCss}
` as unknown as typeof Text;
diff --git a/frontend/src/metabase/dashboard/visualizations/LinkViz/LinkViz.unit.spec.tsx b/frontend/src/metabase/dashboard/visualizations/LinkViz/LinkViz.unit.spec.tsx
index ed5a300e660..33e882a90b9 100644
--- a/frontend/src/metabase/dashboard/visualizations/LinkViz/LinkViz.unit.spec.tsx
+++ b/frontend/src/metabase/dashboard/visualizations/LinkViz/LinkViz.unit.spec.tsx
@@ -104,6 +104,7 @@ const setup = (options?: Partial<LinkVizProps>) => {
dashcard={linkDashcard}
isEditing={true}
onUpdateVisualizationSettings={changeSpy}
+ // Unjustified type cast. FIXME
settings={linkDashcard.visualization_settings as LinkCardVizSettings}
{...options}
/>,
@@ -149,6 +150,7 @@ describe("LinkViz", () => {
isEditing: false,
dashcard: emptyLinkDashcard,
settings:
+ // Unjustified type cast. FIXME
emptyLinkDashcard.visualization_settings as LinkCardVizSettings,
});
@@ -173,6 +175,7 @@ describe("LinkViz", () => {
setup({
isEditing: false,
dashcard,
+ // Unjustified type cast. FIXME
settings: dashcard.visualization_settings as LinkCardVizSettings,
});
@@ -193,6 +196,7 @@ describe("LinkViz", () => {
setup({
isEditing: false,
dashcard,
+ // Unjustified type cast. FIXME
settings: dashcard.visualization_settings as LinkCardVizSettings,
});
@@ -206,6 +210,7 @@ describe("LinkViz", () => {
const markdownDescription =
"**Bold text** and _italic text_ and [link](https://example.com)";
+ // Unjustified type cast. FIXME
const settings = {
link: {
entity: {
@@ -252,6 +257,7 @@ describe("LinkViz", () => {
it("disallows headings in markdown tooltip", async () => {
const markdownDescription = "# Heading\nRegular text";
+ // Unjustified type cast. FIXME
const settings = {
link: {
entity: {
@@ -285,6 +291,7 @@ describe("LinkViz", () => {
isEditing: false,
dashcard: questionLinkDashcard,
settings:
+ // Unjustified type cast. FIXME
questionLinkDashcard.visualization_settings as LinkCardVizSettings,
});
@@ -297,6 +304,7 @@ describe("LinkViz", () => {
isEditing: false,
dashcard: tableLinkDashcard,
settings:
+ // Unjustified type cast. FIXME
tableLinkDashcard.visualization_settings as LinkCardVizSettings,
});
@@ -309,6 +317,7 @@ describe("LinkViz", () => {
isEditing: false,
dashcard: tableLinkDashcard,
settings:
+ // Unjustified type cast. FIXME
tableLinkDashcard.visualization_settings as LinkCardVizSettings,
});
@@ -323,6 +332,7 @@ describe("LinkViz", () => {
isEditing: false,
dashcard: tableLinkDashcard,
settings:
+ // Unjustified type cast. FIXME
tableLinkDashcard.visualization_settings as LinkCardVizSettings,
});
@@ -340,6 +350,7 @@ describe("LinkViz", () => {
isEditing: true,
dashcard: searchingDashcard,
settings:
+ // Unjustified type cast. FIXME
searchingDashcard.visualization_settings as LinkCardVizSettings,
});
@@ -386,6 +397,7 @@ describe("LinkViz", () => {
isEditing: true,
dashcard: documentSearchDashcard,
settings:
+ // Unjustified type cast. FIXME
documentSearchDashcard.visualization_settings as LinkCardVizSettings,
});
@@ -436,6 +448,7 @@ describe("LinkViz", () => {
isEditing: true,
dashcard: emptyLinkDashcard,
settings:
+ // Unjustified type cast. FIXME
emptyLinkDashcard.visualization_settings as LinkCardVizSettings,
});
@@ -462,6 +475,7 @@ describe("LinkViz", () => {
isEditing: false,
dashcard: restrictedLinkDashcard,
settings:
+ // Unjustified type cast. FIXME
restrictedLinkDashcard.visualization_settings as LinkCardVizSettings,
});
@@ -501,6 +515,7 @@ describe("LinkViz", () => {
dashboard={dashboard}
isEditing={false}
onUpdateVisualizationSettings={jest.fn()}
+ // Unjustified type cast. FIXME
settings={dashcard.visualization_settings as LinkCardVizSettings}
/>,
{
diff --git a/frontend/src/metabase/data-grid/components/BaseCell/BaseCell.tsx b/frontend/src/metabase/data-grid/components/BaseCell/BaseCell.tsx
index b75e1cc835a..e4c6890edff 100644
--- a/frontend/src/metabase/data-grid/components/BaseCell/BaseCell.tsx
+++ b/frontend/src/metabase/data-grid/components/BaseCell/BaseCell.tsx
@@ -28,6 +28,7 @@ export const BaseCell = memo(function BaseCell({
}: BaseCellProps) {
const cellStyle = useMemo(() => {
if (isSelected) {
+ // Unjustified type cast. FIXME
return {
"--cell-bg-color": `color-mix(in srgb, var(--mb-color-core-brand), transparent 80%)`,
"--cell-hover-bg-color": hasHover
@@ -36,6 +37,7 @@ export const BaseCell = memo(function BaseCell({
} as React.CSSProperties;
}
if (!backgroundColor) {
+ // Unjustified type cast. FIXME
return {
"--cell-hover-bg-color": hasHover
? `color-mix(in srgb, var(--mb-color-core-brand), transparent 90%)`
@@ -48,6 +50,7 @@ export const BaseCell = memo(function BaseCell({
? `color-mix(in srgb, ${backgroundColor} 95%, white)`
: `color-mix(in srgb, ${backgroundColor} 97%, black)`;
+ // Unjustified type cast. FIXME
return {
"--cell-bg-color": backgroundColor,
"--cell-hover-bg-color": hasHover ? hoverColor : undefined,
diff --git a/frontend/src/metabase/data-grid/components/BodyCell/BodyCell.tsx b/frontend/src/metabase/data-grid/components/BodyCell/BodyCell.tsx
index 82eec38e064..ecac9212c47 100644
--- a/frontend/src/metabase/data-grid/components/BodyCell/BodyCell.tsx
+++ b/frontend/src/metabase/data-grid/components/BodyCell/BodyCell.tsx
@@ -16,6 +16,7 @@ export interface BodyCellProps<TValue> extends BodyCellBaseProps<TValue> {
contentTestId?: string;
}
+// Unjustified type cast. FIXME
export const BodyCell = memo(function BodyCell<TValue>({
value,
formatter,
diff --git a/frontend/src/metabase/data-grid/components/DataGrid/DataGrid.stories.tsx b/frontend/src/metabase/data-grid/components/DataGrid/DataGrid.stories.tsx
index 484c0b49c8a..69f38740cdf 100644
--- a/frontend/src/metabase/data-grid/components/DataGrid/DataGrid.stories.tsx
+++ b/frontend/src/metabase/data-grid/components/DataGrid/DataGrid.stories.tsx
@@ -18,6 +18,7 @@ import { Checkbox, Flex } from "metabase/ui";
import { DataGrid } from "./DataGrid";
import classes from "./DataGrid.module.css";
+// Unjustified type cast. FIXME
export default {
title: "DataGrid/DataGrid",
component: DataGrid,
diff --git a/frontend/src/metabase/data-grid/components/SortableHeader/SortableHeader.tsx b/frontend/src/metabase/data-grid/components/SortableHeader/SortableHeader.tsx
index d6d7fdcb2a5..dbd3c0870d1 100644
--- a/frontend/src/metabase/data-grid/components/SortableHeader/SortableHeader.tsx
+++ b/frontend/src/metabase/data-grid/components/SortableHeader/SortableHeader.tsx
@@ -21,6 +21,7 @@ export interface SortableHeaderProps<TData, TValue> {
onClick?: (e: React.MouseEvent<HTMLDivElement>, columnId: string) => void;
}
+// Unjustified type cast. FIXME
export const SortableHeader = memo(function SortableHeader<TData, TValue>({
header,
className,
@@ -81,7 +82,8 @@ export const SortableHeader = memo(function SortableHeader<TData, TValue>({
const isClicked = dx + dy < HEADER_DRAG_THRESHOLD;
const isClickTarget = headerClickTargetSelector
- ? !!(e.target as HTMLElement).closest(headerClickTargetSelector)
+ ? // Unjustified type cast. FIXME
+ !!(e.target as HTMLElement).closest(headerClickTargetSelector)
: true;
if (isClicked && onClick && isClickTarget) {
onClick(e, id);
diff --git a/frontend/src/metabase/data-grid/hooks/use-cell-selection.tsx b/frontend/src/metabase/data-grid/hooks/use-cell-selection.tsx
index 9b768b790e2..918aa7f54c7 100644
--- a/frontend/src/metabase/data-grid/hooks/use-cell-selection.tsx
+++ b/frontend/src/metabase/data-grid/hooks/use-cell-selection.tsx
@@ -81,6 +81,7 @@ export const useCellSelection = ({
return;
}
+ // Unjustified type cast. FIXME
const target = e.target as HTMLElement;
const isInsideSelectableCell = target.closest("[data-selectable-cell]");
if (isInsideSelectableCell || selectedCells.length === 0) {
@@ -233,6 +234,7 @@ export const useCellSelection = ({
return;
}
+ // Unjustified type cast. FIXME
const selectedCellsInRange = getCellsBetween(
table,
selectedStartCell,
@@ -524,6 +526,7 @@ const getCellValues = (
const columnIds = Object.keys(columnGroups);
+ // Unjustified type cast. FIXME
const headerRow = columnIds
.map((columnId) => {
return columnId
diff --git a/frontend/src/metabase/data-grid/hooks/use-columns-reordering.tsx b/frontend/src/metabase/data-grid/hooks/use-columns-reordering.tsx
index 1aac34a9f94..78076920e49 100644
--- a/frontend/src/metabase/data-grid/hooks/use-columns-reordering.tsx
+++ b/frontend/src/metabase/data-grid/hooks/use-columns-reordering.tsx
@@ -86,7 +86,9 @@ export const useColumnsReordering = <TData,>(
const { active, over } = event;
if (active && over && active.id !== over.id && !over.disabled) {
table.setColumnOrder((columnOrder) => {
+ // Unjustified type cast. FIXME
const oldIndex = columnOrder.indexOf(active.id as string);
+ // Unjustified type cast. FIXME
const newIndex = columnOrder.indexOf(over.id as string);
return arrayMove(columnOrder, oldIndex, newIndex);
});
diff --git a/frontend/src/metabase/data-grid/hooks/use-measure-column-widths.tsx b/frontend/src/metabase/data-grid/hooks/use-measure-column-widths.tsx
index 190d17362f8..ad129afd24f 100644
--- a/frontend/src/metabase/data-grid/hooks/use-measure-column-widths.tsx
+++ b/frontend/src/metabase/data-grid/hooks/use-measure-column-widths.tsx
@@ -61,6 +61,7 @@ export const useMeasureColumnWidths = <TData, TValue>(
return null;
}
+ // Unjustified type cast. FIXME
const width = (element as HTMLElement).offsetWidth;
return { columnId, width, type };
})
diff --git a/frontend/src/metabase/data-grid/utils/columns/data-column.unit.spec.tsx b/frontend/src/metabase/data-grid/utils/columns/data-column.unit.spec.tsx
index 5f07ffaa490..ebb91d42544 100644
--- a/frontend/src/metabase/data-grid/utils/columns/data-column.unit.spec.tsx
+++ b/frontend/src/metabase/data-grid/utils/columns/data-column.unit.spec.tsx
@@ -32,6 +32,7 @@ const setup = ({
onExpand,
);
+ // Unjustified type cast. FIXME
const CellComponent = column.cell as React.ComponentType<{
getValue: () => string;
row: { index: number; original: { value: string } };
diff --git a/frontend/src/metabase/data-grid/utils/columns/row-id-column.tsx b/frontend/src/metabase/data-grid/utils/columns/row-id-column.tsx
index 245534cd934..760c055be17 100644
--- a/frontend/src/metabase/data-grid/utils/columns/row-id-column.tsx
+++ b/frontend/src/metabase/data-grid/utils/columns/row-id-column.tsx
@@ -19,6 +19,7 @@ export const getRowIdColumn = <TRow, TValue>({
const shouldShowIndex = ["index", "indexExpand"].includes(variant);
const canExpand = variant !== "index";
return {
+ // Unjustified type cast. FIXME
accessorFn: (_row, index) => index as TValue,
id: ROW_ID_COLUMN_ID,
minSize: getRowIdColumnSize(variant),
diff --git a/frontend/src/metabase/data-studio/components/RevisionHistory/RevisionItem.tsx b/frontend/src/metabase/data-studio/components/RevisionHistory/RevisionItem.tsx
index bd4c728be1f..2c47e67ab4c 100644
--- a/frontend/src/metabase/data-studio/components/RevisionHistory/RevisionItem.tsx
+++ b/frontend/src/metabase/data-studio/components/RevisionHistory/RevisionItem.tsx
@@ -111,6 +111,7 @@ function getDiffForKey(
return undefined;
}
+ // Unjustified type cast. FIXME
const revisionDiff = diff as RevisionDiffMap;
return revisionDiff[key];
}
diff --git a/frontend/src/metabase/data-studio/data-model/components/DiscardTableFieldValuesButton/DiscardTableFieldValuesButton.unit.spec.tsx b/frontend/src/metabase/data-studio/data-model/components/DiscardTableFieldValuesButton/DiscardTableFieldValuesButton.unit.spec.tsx
index b6f8acd618d..8f62cc6b719 100644
--- a/frontend/src/metabase/data-studio/data-model/components/DiscardTableFieldValuesButton/DiscardTableFieldValuesButton.unit.spec.tsx
+++ b/frontend/src/metabase/data-studio/data-model/components/DiscardTableFieldValuesButton/DiscardTableFieldValuesButton.unit.spec.tsx
@@ -52,6 +52,7 @@ describe("DiscardTableFieldValuesButton", () => {
},
);
expect(calls).toHaveLength(1);
+ // Unjustified type cast. FIXME
expect(JSON.parse(calls[0].options.body as string)).toEqual({
table_ids: [table.id],
});
@@ -79,6 +80,7 @@ describe("DiscardTableFieldValuesButton", () => {
},
);
expect(calls).toHaveLength(1);
+ // Unjustified type cast. FIXME
expect(JSON.parse(calls[0].options.body as string)).toEqual({
table_ids: [table.id],
});
@@ -99,6 +101,7 @@ describe("DiscardTableFieldValuesButton", () => {
},
);
expect(calls).toHaveLength(2);
+ // Unjustified type cast. FIXME
expect(JSON.parse(calls[1].options.body as string)).toEqual({
table_ids: [table.id],
});
@@ -134,6 +137,7 @@ describe("DiscardTableFieldValuesButton", () => {
},
);
expect(calls).toHaveLength(1);
+ // Unjustified type cast. FIXME
expect(JSON.parse(calls[0].options.body as string)).toEqual({
table_ids: [table.id],
});
diff --git a/frontend/src/metabase/data-studio/data-model/components/RescanTableFieldsButton/RescanTableFieldsButton.unit.spec.tsx b/frontend/src/metabase/data-studio/data-model/components/RescanTableFieldsButton/RescanTableFieldsButton.unit.spec.tsx
index 12dd2ca9b5a..c439ce9a438 100644
--- a/frontend/src/metabase/data-studio/data-model/components/RescanTableFieldsButton/RescanTableFieldsButton.unit.spec.tsx
+++ b/frontend/src/metabase/data-studio/data-model/components/RescanTableFieldsButton/RescanTableFieldsButton.unit.spec.tsx
@@ -52,6 +52,7 @@ describe("RescanTableFieldsButton", () => {
},
);
expect(calls).toHaveLength(1);
+ // Unjustified type cast. FIXME
expect(JSON.parse(calls[0].options.body as string)).toEqual({
table_ids: [table.id],
});
@@ -79,6 +80,7 @@ describe("RescanTableFieldsButton", () => {
},
);
expect(calls).toHaveLength(1);
+ // Unjustified type cast. FIXME
expect(JSON.parse(calls[0].options.body as string)).toEqual({
table_ids: [table.id],
});
@@ -99,6 +101,7 @@ describe("RescanTableFieldsButton", () => {
},
);
expect(calls).toHaveLength(2);
+ // Unjustified type cast. FIXME
expect(JSON.parse(calls[1].options.body as string)).toEqual({
table_ids: [table.id],
});
@@ -134,6 +137,7 @@ describe("RescanTableFieldsButton", () => {
},
);
expect(calls).toHaveLength(1);
+ // Unjustified type cast. FIXME
expect(JSON.parse(calls[0].options.body as string)).toEqual({
table_ids: [table.id],
});
diff --git a/frontend/src/metabase/data-studio/data-model/components/SyncTableSchemaButton/SyncTableSchemaButton.unit.spec.tsx b/frontend/src/metabase/data-studio/data-model/components/SyncTableSchemaButton/SyncTableSchemaButton.unit.spec.tsx
index 89c5dff7d1c..f952585b218 100644
--- a/frontend/src/metabase/data-studio/data-model/components/SyncTableSchemaButton/SyncTableSchemaButton.unit.spec.tsx
+++ b/frontend/src/metabase/data-studio/data-model/components/SyncTableSchemaButton/SyncTableSchemaButton.unit.spec.tsx
@@ -52,6 +52,7 @@ describe("SyncTableSchemaButton", () => {
},
);
expect(calls).toHaveLength(1);
+ // Unjustified type cast. FIXME
expect(JSON.parse(calls[0].options.body as string)).toEqual({
table_ids: [table.id],
});
@@ -79,6 +80,7 @@ describe("SyncTableSchemaButton", () => {
},
);
expect(calls).toHaveLength(1);
+ // Unjustified type cast. FIXME
expect(JSON.parse(calls[0].options.body as string)).toEqual({
table_ids: [table.id],
});
@@ -99,6 +101,7 @@ describe("SyncTableSchemaButton", () => {
},
);
expect(calls).toHaveLength(2);
+ // Unjustified type cast. FIXME
expect(JSON.parse(calls[1].options.body as string)).toEqual({
table_ids: [table.id],
});
@@ -134,6 +137,7 @@ describe("SyncTableSchemaButton", () => {
},
);
expect(calls).toHaveLength(1);
+ // Unjustified type cast. FIXME
expect(JSON.parse(calls[0].options.body as string)).toEqual({
table_ids: [table.id],
});
diff --git a/frontend/src/metabase/data-studio/data-model/components/TablePicker/components/TablePickerTreeTable.unit.spec.tsx b/frontend/src/metabase/data-studio/data-model/components/TablePicker/components/TablePickerTreeTable.unit.spec.tsx
index 38fef362602..fb39ae93cb7 100644
--- a/frontend/src/metabase/data-studio/data-model/components/TablePicker/components/TablePickerTreeTable.unit.spec.tsx
+++ b/frontend/src/metabase/data-studio/data-model/components/TablePicker/components/TablePickerTreeTable.unit.spec.tsx
@@ -31,6 +31,7 @@ describe("handleCheckboxToggle", () => {
isDisabled,
depth = 0,
}: CheckboxRowParams): Row<TablePickerTreeNode> =>
+ // Unjustified type cast. FIXME
({
depth,
original: {
diff --git a/frontend/src/metabase/data-studio/data-model/components/TablePicker/components/TableVisibilityToggle.unit.spec.tsx b/frontend/src/metabase/data-studio/data-model/components/TablePicker/components/TableVisibilityToggle.unit.spec.tsx
index ca24ac1a99e..ce406718307 100644
--- a/frontend/src/metabase/data-studio/data-model/components/TablePicker/components/TableVisibilityToggle.unit.spec.tsx
+++ b/frontend/src/metabase/data-studio/data-model/components/TablePicker/components/TableVisibilityToggle.unit.spec.tsx
@@ -59,6 +59,7 @@ describe("TableVisibilityToggle", () => {
method: "PUT",
},
)[0];
+ // Unjustified type cast. FIXME
const body = await (call.options?.body as unknown as Promise<string>);
expect(JSON.parse(body)).toEqual({ visibility_type: "hidden" });
@@ -135,6 +136,7 @@ describe("TableVisibilityToggle", () => {
method: "PUT",
},
)[0];
+ // Unjustified type cast. FIXME
const body = await (call.options?.body as unknown as Promise<string>);
expect(JSON.parse(body)).toEqual({ visibility_type: null });
diff --git a/frontend/src/metabase/data-studio/data-model/components/TablePicker/utils.ts b/frontend/src/metabase/data-studio/data-model/components/TablePicker/utils.ts
index b679470d9be..97be0508e9e 100644
--- a/frontend/src/metabase/data-studio/data-model/components/TablePicker/utils.ts
+++ b/frontend/src/metabase/data-studio/data-model/components/TablePicker/utils.ts
@@ -97,6 +97,7 @@ export function merge(
}
const merged = { ...a, ...b };
+ // Unjustified type cast. FIXME
(merged as { children: TreeNode[] }).children = children;
return merged;
}
@@ -113,6 +114,7 @@ type Optional<T, K extends keyof T> = Omit<T, K> & Partial<Pick<T, K>>;
export function node<T extends TreeNode>(
x: Optional<T, "key" | "children">,
): T {
+ // Unjustified type cast. FIXME
return {
...x,
key: toKey(x.value),
diff --git a/frontend/src/metabase/data-studio/data-model/components/TableSection/components/MeasureList/MeasureList.tsx b/frontend/src/metabase/data-studio/data-model/components/TableSection/components/MeasureList/MeasureList.tsx
index 1b70a58aa2c..4939bc52852 100644
--- a/frontend/src/metabase/data-studio/data-model/components/TableSection/components/MeasureList/MeasureList.tsx
+++ b/frontend/src/metabase/data-studio/data-model/components/TableSection/components/MeasureList/MeasureList.tsx
@@ -29,6 +29,7 @@ export function MeasureList({ table }: MeasureListProps) {
getUserCanWriteMeasures(state, table.is_published),
);
const onNewMeasureClick = () => {
+ // Unjustified type cast. FIXME
trackMeasureCreateStarted(table.id as ConcreteTableId);
};
const newMeasureUrl = Urls.newDataStudioDataModelMeasure({
diff --git a/frontend/src/metabase/data-studio/data-model/pages/DataModel/DataModel.unit.spec.tsx b/frontend/src/metabase/data-studio/data-model/pages/DataModel/DataModel.unit.spec.tsx
index 7303943c7d1..4941c7c4f40 100644
--- a/frontend/src/metabase/data-studio/data-model/pages/DataModel/DataModel.unit.spec.tsx
+++ b/frontend/src/metabase/data-studio/data-model/pages/DataModel/DataModel.unit.spec.tsx
@@ -754,6 +754,7 @@ describe("DataModel", () => {
});
const lastCall = calls[calls.length - 1];
+ // Unjustified type cast. FIXME
expect(JSON.parse(lastCall.options.body as string)).toEqual({
table_ids: [ORDERS_TABLE.id],
});
@@ -786,6 +787,7 @@ describe("DataModel", () => {
});
const lastCall = calls[calls.length - 1];
+ // Unjustified type cast. FIXME
expect(JSON.parse(lastCall.options.body as string)).toEqual({
table_ids: [ORDERS_TABLE.id],
});
diff --git a/frontend/src/metabase/data-studio/measures/pages/NewMeasurePage/NewMeasurePage.unit.spec.tsx b/frontend/src/metabase/data-studio/measures/pages/NewMeasurePage/NewMeasurePage.unit.spec.tsx
index b1d034b1b48..145c0403598 100644
--- a/frontend/src/metabase/data-studio/measures/pages/NewMeasurePage/NewMeasurePage.unit.spec.tsx
+++ b/frontend/src/metabase/data-studio/measures/pages/NewMeasurePage/NewMeasurePage.unit.spec.tsx
@@ -25,6 +25,7 @@ function setup({ table }: SetupOpts) {
path="/"
component={() => (
<NewMeasurePage
+ // Unjustified type cast. FIXME
route={{ path: "/" } as never}
table={table}
breadcrumbs={<div />}
diff --git a/frontend/src/metabase/data-studio/segments/pages/NewSegmentPage/NewSegmentPage.unit.spec.tsx b/frontend/src/metabase/data-studio/segments/pages/NewSegmentPage/NewSegmentPage.unit.spec.tsx
index 37a8a7035c3..4415b927d2b 100644
--- a/frontend/src/metabase/data-studio/segments/pages/NewSegmentPage/NewSegmentPage.unit.spec.tsx
+++ b/frontend/src/metabase/data-studio/segments/pages/NewSegmentPage/NewSegmentPage.unit.spec.tsx
@@ -65,6 +65,7 @@ function setup({ table = TEST_TABLE }: SetupOpts = {}) {
path="/"
component={() => (
<NewSegmentPage
+ // Unjustified type cast. FIXME
route={{ path: "/" } as never}
table={table}
breadcrumbs={<DataModelSegmentBreadcrumbs table={table} />}
diff --git a/frontend/src/metabase/data-studio/segments/pages/SegmentDetailPage/tests/setup.tsx b/frontend/src/metabase/data-studio/segments/pages/SegmentDetailPage/tests/setup.tsx
index ec1f77c1fa2..eb5e74c5255 100644
--- a/frontend/src/metabase/data-studio/segments/pages/SegmentDetailPage/tests/setup.tsx
+++ b/frontend/src/metabase/data-studio/segments/pages/SegmentDetailPage/tests/setup.tsx
@@ -126,6 +126,7 @@ export function setup({
path="/"
component={() => (
<SegmentDetailPage
+ // Unjustified type cast. FIXME
route={{ path: "/" } as never}
segment={segment}
tabUrls={tabUrls}
diff --git a/frontend/src/metabase/databases/components/DatabaseConnectionUri/DatabaseConnectionStringField.tsx b/frontend/src/metabase/databases/components/DatabaseConnectionUri/DatabaseConnectionStringField.tsx
index b80c1e14076..3880030e586 100644
--- a/frontend/src/metabase/databases/components/DatabaseConnectionUri/DatabaseConnectionStringField.tsx
+++ b/frontend/src/metabase/databases/components/DatabaseConnectionUri/DatabaseConnectionStringField.tsx
@@ -64,6 +64,7 @@ export function DatabaseConnectionStringField({
}
const fieldsMap = mapDatabaseValues(parsedValues, engineKey);
+ // Unjustified type cast. FIXME
const fields = mapFieldsToNestedObject(fieldsMap) as DatabaseData;
await setValues((previousValues) =>
setDatabaseFormValues(previousValues, fields),
diff --git a/frontend/src/metabase/databases/components/DatabaseHostnameWithProviderField/database-providers.ts b/frontend/src/metabase/databases/components/DatabaseHostnameWithProviderField/database-providers.ts
index 62e73a6aea8..595f0013f18 100644
--- a/frontend/src/metabase/databases/components/DatabaseHostnameWithProviderField/database-providers.ts
+++ b/frontend/src/metabase/databases/components/DatabaseHostnameWithProviderField/database-providers.ts
@@ -14,5 +14,6 @@ export const detectDBProvider = (
new RegExp(pattern).test(host),
);
+ // Unjustified type cast. FIXME
return (provider?.name as DatabaseProviderName) || null;
};
diff --git a/frontend/src/metabase/databases/utils/engine.ts b/frontend/src/metabase/databases/utils/engine.ts
index e68d7effdb8..4a3fee116c2 100644
--- a/frontend/src/metabase/databases/utils/engine.ts
+++ b/frontend/src/metabase/databases/utils/engine.ts
@@ -59,6 +59,7 @@ export function getEngineNativeType(engine?: string): "sql" | "json" {
}
export function getNativeQueryLanguage(engine?: string) {
+ // Unjustified type cast. FIXME
return getEngineNativeType(engine).toUpperCase() as "SQL" | "JSON";
}
diff --git a/frontend/src/metabase/databases/utils/schema.ts b/frontend/src/metabase/databases/utils/schema.ts
index a91e7930401..4607ab91284 100644
--- a/frontend/src/metabase/databases/utils/schema.ts
+++ b/frontend/src/metabase/databases/utils/schema.ts
@@ -109,6 +109,7 @@ export const getSubmitValues = (
);
return {
+ // Unjustified type cast. FIXME
...(Object.fromEntries(submitValues) as DatabaseData),
details: Object.fromEntries(entries),
};
diff --git a/frontend/src/metabase/documents/components/CommentsSidesheet/CommentsSidesheet.tsx b/frontend/src/metabase/documents/components/CommentsSidesheet/CommentsSidesheet.tsx
index aca50216755..9ccf511209f 100644
--- a/frontend/src/metabase/documents/components/CommentsSidesheet/CommentsSidesheet.tsx
+++ b/frontend/src/metabase/documents/components/CommentsSidesheet/CommentsSidesheet.tsx
@@ -216,6 +216,7 @@ export const CommentsSidesheet = ({ params, onClose }: Props) => {
<Tabs
value={activeTab}
onChange={(value) => {
+ // Unjustified type cast. FIXME
setActiveTab(value as SidesheetTab);
}}
>
diff --git a/frontend/src/metabase/documents/components/DocumentHeader.unit.spec.tsx b/frontend/src/metabase/documents/components/DocumentHeader.unit.spec.tsx
index 3d48134b8f5..cbaa95b648d 100644
--- a/frontend/src/metabase/documents/components/DocumentHeader.unit.spec.tsx
+++ b/frontend/src/metabase/documents/components/DocumentHeader.unit.spec.tsx
@@ -33,6 +33,7 @@ const setup = ({
onToggleBookmark = jest.fn(),
onArchive = jest.fn(),
onShowHistory = jest.fn(),
+ // Unjustified type cast. FIXME
printContext = undefined as PrintContextValue | undefined,
} = {}) => {
const props = {
@@ -68,6 +69,7 @@ const setup = ({
storeInitialState: {
currentUser: createMockUser({ is_superuser: isAdmin }),
settings: {
+ // Unjustified type cast. FIXME
values: {
"enable-public-sharing": isPublicSharingEnabled,
} as any,
diff --git a/frontend/src/metabase/documents/components/Editor/AnchorLinkMenu/AnchorLinkButton.tsx b/frontend/src/metabase/documents/components/Editor/AnchorLinkMenu/AnchorLinkButton.tsx
index 814ce0bbf9b..af4d194a900 100644
--- a/frontend/src/metabase/documents/components/Editor/AnchorLinkMenu/AnchorLinkButton.tsx
+++ b/frontend/src/metabase/documents/components/Editor/AnchorLinkMenu/AnchorLinkButton.tsx
@@ -40,6 +40,7 @@ export const AnchorLinkButton = <C extends ElementType = "button">({
opened={clipboard.copied}
>
<Button
+ // Unjustified type cast. FIXME
{...(props as ButtonProps)}
aria-label={t`Copy link`}
bd={0}
diff --git a/frontend/src/metabase/documents/components/Editor/Editor.stories.tsx b/frontend/src/metabase/documents/components/Editor/Editor.stories.tsx
index c98e162b428..b42998e2b8a 100644
--- a/frontend/src/metabase/documents/components/Editor/Editor.stories.tsx
+++ b/frontend/src/metabase/documents/components/Editor/Editor.stories.tsx
@@ -37,6 +37,7 @@ const storeInitialState = createMockState({
settings,
entities: createMockEntitiesState({}),
});
+// Unjustified type cast. FIXME
const store = getCommonStore(storeInitialState) as unknown as Store<State>;
const ReduxDecorator = (Story: StoryFn) => {
@@ -72,6 +73,7 @@ export default {
http.post("/api/card/114/query", () =>
HttpResponse.json(
createMockDataset({
+ // Unjustified type cast. FIXME
data: Data.card114Query.data as unknown as DatasetData,
}),
),
@@ -98,6 +100,7 @@ export default {
http.post("/api/card/115/query", () =>
HttpResponse.json(
createMockDataset({
+ // Unjustified type cast. FIXME
data: Data.card114Query.data as unknown as DatasetData,
}),
),
diff --git a/frontend/src/metabase/documents/documents.slice.ts b/frontend/src/metabase/documents/documents.slice.ts
index 2c31e56c5e3..f8c263d3ff1 100644
--- a/frontend/src/metabase/documents/documents.slice.ts
+++ b/frontend/src/metabase/documents/documents.slice.ts
@@ -100,6 +100,7 @@ const documentsSlice = createSlice({
}>,
) => {
const { originalCard, modifiedData, draftId } = action.payload;
+ // Unjustified type cast. FIXME
state.draftCards[draftId] = {
...originalCard,
...modifiedData,
diff --git a/frontend/src/metabase/documents/hooks/use-block-menus.unit.spec.ts b/frontend/src/metabase/documents/hooks/use-block-menus.unit.spec.ts
index 8f5b96c055f..e0a3503d73f 100644
--- a/frontend/src/metabase/documents/hooks/use-block-menus.unit.spec.ts
+++ b/frontend/src/metabase/documents/hooks/use-block-menus.unit.spec.ts
@@ -103,12 +103,14 @@ const schema = new Schema({
});
const buildEditor = (doc: ReturnType<Schema["node"]>) =>
+ // Unjustified type cast. FIXME
({ state: { doc } }) as unknown as Editor;
const buildArgs = (
editor: Editor | null,
getPos: NodeViewProps["getPos"] | null,
) =>
+ // Unjustified type cast. FIXME
({ editor, getPos }) as unknown as Pick<NodeViewProps, "editor" | "getPos">;
describe("isTopLevel", () => {
@@ -164,6 +166,7 @@ describe("isTopLevel", () => {
false,
);
expect(
+ // Unjustified type cast. FIXME
isTopLevel(buildArgs(buildEditor(doc), () => undefined as never)),
).toBe(false);
});
diff --git a/frontend/src/metabase/documents/hooks/use-scroll-to-anchor.unit.spec.ts b/frontend/src/metabase/documents/hooks/use-scroll-to-anchor.unit.spec.ts
index 8bff863d4eb..c1fb4d7b5cf 100644
--- a/frontend/src/metabase/documents/hooks/use-scroll-to-anchor.unit.spec.ts
+++ b/frontend/src/metabase/documents/hooks/use-scroll-to-anchor.unit.spec.ts
@@ -22,6 +22,7 @@ describe("useScrollToAnchor", () => {
document.body.appendChild(container);
editorContainerRef = createRef<HTMLDivElement>();
+ // Unjustified type cast. FIXME
(editorContainerRef as { current: HTMLDivElement }).current = container;
});
diff --git a/frontend/src/metabase/embedding-sdk/lib/links.unit.spec.ts b/frontend/src/metabase/embedding-sdk/lib/links.unit.spec.ts
index 9d7205e20ca..206e940d675 100644
--- a/frontend/src/metabase/embedding-sdk/lib/links.unit.spec.ts
+++ b/frontend/src/metabase/embedding-sdk/lib/links.unit.spec.ts
@@ -58,6 +58,7 @@ describe("removeInternalClickBehaviors", () => {
});
it("does not crash on undefined column settings entries (EMB-1940)", () => {
+ // Unjustified type cast. FIXME
const settings = {
column_settings: {
// columns without stored settings can end up as `undefined` entries
diff --git a/frontend/src/metabase/embedding-sdk/lib/saml-token-storage.ts b/frontend/src/metabase/embedding-sdk/lib/saml-token-storage.ts
index e30ddcd4401..20765dac6ee 100644
--- a/frontend/src/metabase/embedding-sdk/lib/saml-token-storage.ts
+++ b/frontend/src/metabase/embedding-sdk/lib/saml-token-storage.ts
@@ -11,9 +11,11 @@ class TypedStorage<T> {
}
try {
+ // Unjustified type cast. FIXME
return JSON.parse(data) as T;
} catch (e) {
throw new Error(
+ // Unjustified type cast. FIXME
`Failed to parse stored data for key "${this.key}": ${(e as Error).message}`,
);
}
@@ -25,6 +27,7 @@ class TypedStorage<T> {
localStorage.setItem(this.key, JSON.stringify(value));
} catch (e) {
throw new Error(
+ // Unjustified type cast. FIXME
`Failed to store data for key "${this.key}": ${(e as Error).message}`,
);
}
@@ -36,6 +39,7 @@ class TypedStorage<T> {
localStorage.removeItem(this.key);
} catch (e) {
throw new Error(
+ // Unjustified type cast. FIXME
`Failed to remove data for key "${this.key}": ${(e as Error).message}`,
);
}
diff --git a/frontend/src/metabase/embedding-sdk/lib/transform-clicked.ts b/frontend/src/metabase/embedding-sdk/lib/transform-clicked.ts
index ee610065506..cf3d46b86dd 100644
--- a/frontend/src/metabase/embedding-sdk/lib/transform-clicked.ts
+++ b/frontend/src/metabase/embedding-sdk/lib/transform-clicked.ts
@@ -14,6 +14,7 @@ export function transformClickedDataPoint(
question: Question,
): MetabaseDataPointObject {
return {
+ // Unjustified type cast. FIXME
raw: clicked as Record<string, unknown>,
column: clicked.column
diff --git a/frontend/src/metabase/embedding-sdk/theme/embedding-color-palette.ts b/frontend/src/metabase/embedding-sdk/theme/embedding-color-palette.ts
index 0eb30962a4f..0821feef583 100644
--- a/frontend/src/metabase/embedding-sdk/theme/embedding-color-palette.ts
+++ b/frontend/src/metabase/embedding-sdk/theme/embedding-color-palette.ts
@@ -98,6 +98,7 @@ export function getEmbeddingColorPalette(
Object.entries(sdkColors)
.flatMap(([key, value]) => {
const themeColorNames =
+ // Unjustified type cast. FIXME
SDK_TO_MAIN_APP_COLORS_MAPPING[key as MappableSdkColor];
if (themeColorNames) {
return themeColorNames.map((mappedColor) => [mappedColor, value]);
@@ -134,6 +135,7 @@ export function setGlobalEmbeddingColors(
const combinedThemeColors = getEmbeddingColorPalette(sdkColors, appPalette);
Object.entries(combinedThemeColors).forEach(([key, value]) => {
+ // Unjustified type cast. FIXME
colors[key as ColorName] = value;
});
@@ -143,7 +145,9 @@ export function setGlobalEmbeddingColors(
* Otherwise, previously modified colors will persist, and won't be reset to default values.
*/
Object.keys(colors).forEach((key) => {
+ // Unjustified type cast. FIXME
if (!combinedThemeColors[key as ColorName]) {
+ // Unjustified type cast. FIXME
delete colors[key as ColorName];
}
});
diff --git a/frontend/src/metabase/embedding/components/ArchiveButton.tsx b/frontend/src/metabase/embedding/components/ArchiveButton.tsx
index 8511992660f..21b5e489f34 100644
--- a/frontend/src/metabase/embedding/components/ArchiveButton.tsx
+++ b/frontend/src/metabase/embedding/components/ArchiveButton.tsx
@@ -21,6 +21,7 @@ export function ArchiveButton({ item }: ArchiveButtonProps) {
const archive = useSetArchive();
const handleArchive = () => {
+ // Unjustified type cast. FIXME
archive(item as ArchivableItem, true);
dropdownActions.close();
};
diff --git a/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/LookAndFeelSettings.tsx b/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/LookAndFeelSettings.tsx
index ee587d09864..c9cbc6c6ecc 100644
--- a/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/LookAndFeelSettings.tsx
+++ b/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/LookAndFeelSettings.tsx
@@ -33,12 +33,14 @@ const THEME_OPTIONS = [
get label() {
return t`Light`;
},
+ // Unjustified type cast. FIXME
value: "light" as DisplayTheme,
},
{
get label() {
return t`Dark`;
},
+ // Unjustified type cast. FIXME
value: "night" as DisplayTheme,
},
] as const;
diff --git a/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/ParametersSettings.tsx b/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/ParametersSettings.tsx
index 5cd9315de37..d2326142ae8 100644
--- a/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/ParametersSettings.tsx
+++ b/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/ParametersSettings.tsx
@@ -49,6 +49,7 @@ export const ParametersSettings = ({
}: ParametersSettingsProps): JSX.Element => {
const valuePopulatedEditableParameters = useMemo(
() =>
+ // Unjustified type cast. FIXME
getValuePopulatedParameters({
parameters: resourceParameters,
values: parameterValues,
@@ -61,6 +62,7 @@ export const ParametersSettings = ({
);
const valuePopulatedLockedParameters = useMemo(
() =>
+ // Unjustified type cast. FIXME
getValuePopulatedParameters({
parameters: lockedParameters,
values: parameterValues,
@@ -166,6 +168,7 @@ export const ParametersSettings = ({
onChangeParameterValue({
id: parameter.id,
slug: parameter.slug,
+ // Unjustified type cast. FIXME
value: parameter.default as any,
});
}}
@@ -208,6 +211,7 @@ export const ParametersSettings = ({
onChangeParameterValue({
id: parameter.id,
slug: parameter.slug,
+ // Unjustified type cast. FIXME
value: parameter.default as any,
});
}}
diff --git a/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/PreviewModeSelector.tsx b/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/PreviewModeSelector.tsx
index 4324817e4a0..fd9446e7bc5 100644
--- a/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/PreviewModeSelector.tsx
+++ b/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/PreviewModeSelector.tsx
@@ -22,11 +22,13 @@ const CODE_PREVIEW_CONTROL_OPTIONS = [
{
// eslint-disable-next-line ttag/no-module-declaration -- see metabase#55045
label: <ControlOptionItem label={t`Code`} iconName="embed" />,
+ // Unjustified type cast. FIXME
value: "code" as ActivePreviewPane,
},
{
// eslint-disable-next-line ttag/no-module-declaration -- see metabase#55045
label: <ControlOptionItem label={t`Preview`} iconName="eye_filled" />,
+ // Unjustified type cast. FIXME
value: "preview" as ActivePreviewPane,
},
];
diff --git a/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/PreviewPane/PreviewPane.tsx b/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/PreviewPane/PreviewPane.tsx
index be8df4b9433..d1fe221623e 100644
--- a/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/PreviewPane/PreviewPane.tsx
+++ b/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/PreviewPane/PreviewPane.tsx
@@ -72,6 +72,7 @@ function PreviewPaneContainer({
<div
className={cx(Style.Container, className)}
style={{
+ // Unjustified type cast. FIXME
["--background-url" as any]: `url(${dataUri})`,
display: hidden ? "none" : undefined,
}}
diff --git a/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/lib/get-default-embedding-params.ts b/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/lib/get-default-embedding-params.ts
index d98326f7c1a..46e440c77aa 100644
--- a/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/lib/get-default-embedding-params.ts
+++ b/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/lib/get-default-embedding-params.ts
@@ -15,6 +15,7 @@ export function getDefaultEmbeddingParams(
acc[slug] = "disabled";
return acc;
+ // Unjustified type cast. FIXME
}, {} as EmbeddingParameters);
const resourceEmbeddingParams = {
diff --git a/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/lib/get-has-params-changed.ts b/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/lib/get-has-params-changed.ts
index c598917643c..b913f988915 100644
--- a/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/lib/get-has-params-changed.ts
+++ b/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/lib/get-has-params-changed.ts
@@ -11,6 +11,7 @@ function getNonDisabledEmbeddingParams(
}
return result;
+ // Unjustified type cast. FIXME
}, {} as EmbeddingParameters);
}
diff --git a/frontend/src/metabase/embedding/components/SharingMenu/InviteToViewModal.unit.spec.tsx b/frontend/src/metabase/embedding/components/SharingMenu/InviteToViewModal.unit.spec.tsx
index 372b388e5bc..45b7d15b961 100644
--- a/frontend/src/metabase/embedding/components/SharingMenu/InviteToViewModal.unit.spec.tsx
+++ b/frontend/src/metabase/embedding/components/SharingMenu/InviteToViewModal.unit.spec.tsx
@@ -186,6 +186,7 @@ describe("InviteToViewModal", () => {
method: "POST",
})[0];
const body = JSON.parse(
+ // Unjustified type cast. FIXME
await (call.options?.body as unknown as Promise<string>),
);
expect(body.invite_target).toEqual(INVITE_TARGET);
diff --git a/frontend/src/metabase/embedding/context.tsx b/frontend/src/metabase/embedding/context.tsx
index e9cb241dd47..cbf994dac45 100644
--- a/frontend/src/metabase/embedding/context.tsx
+++ b/frontend/src/metabase/embedding/context.tsx
@@ -7,6 +7,7 @@ type EmbeddingEntityContextType = {
token: EntityToken | null;
};
+// Unjustified type cast. FIXME
export const EmbeddingEntityContext = createContext<EmbeddingEntityContextType>(
undefined as unknown as EmbeddingEntityContextType,
);
diff --git a/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/DataSegregationStrategyPicker.tsx b/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/DataSegregationStrategyPicker.tsx
index 1c894bfa2ec..a093c5f1494 100644
--- a/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/DataSegregationStrategyPicker.tsx
+++ b/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/DataSegregationStrategyPicker.tsx
@@ -58,6 +58,7 @@ export const DataSegregationStrategyPicker = ({
<Stack gap="md">
<Radio.Group
value={value}
+ // Unjustified type cast. FIXME
onChange={(nextValue) => onChange(nextValue as DataSegregationStrategy)}
>
<Stack gap="md">
diff --git a/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/RlsDataSelector/TableColumnCard.tsx b/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/RlsDataSelector/TableColumnCard.tsx
index fcb58e730f9..9c3e270c590 100644
--- a/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/RlsDataSelector/TableColumnCard.tsx
+++ b/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/RlsDataSelector/TableColumnCard.tsx
@@ -175,6 +175,7 @@ export const TableColumnCard = ({
onBrowseAll={handleBrowseAll}
onChange={handleTableSelect}
shouldShowLibrary={false}
+ // Unjustified type cast. FIXME
shouldHide={(item) => shouldHidePickerItem(item as MiniPickerItem)}
/>
diff --git a/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/hooks/use-update-all-tenant-users-group-permissions.ts b/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/hooks/use-update-all-tenant-users-group-permissions.ts
index ba17d7706ed..2cddabfb5fa 100644
--- a/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/hooks/use-update-all-tenant-users-group-permissions.ts
+++ b/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/hooks/use-update-all-tenant-users-group-permissions.ts
@@ -101,6 +101,7 @@ export function useUpdateAllTenantUsersGroupPermissions(): UseUpdateAllTenantUse
)
.unwrap()
.then((res) => res.data.map((db) => db.id))
+ // Unjustified type cast. FIXME
.catch(() => [] as DatabaseId[]);
// get the revision number of the graph
diff --git a/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/hooks/use-xray-dashboards.ts b/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/hooks/use-xray-dashboards.ts
index 8cfa45e59a0..f402760ce1d 100644
--- a/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/hooks/use-xray-dashboards.ts
+++ b/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/hooks/use-xray-dashboards.ts
@@ -117,6 +117,7 @@ export const useCreateSampleDashboardInSharedCollection = () => {
await updateDashboard({
id: dashboard.id,
+ // Unjustified type cast. FIXME
dashcards: [dashcard as DashboardCard],
}).unwrap();
diff --git a/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/utils/permission-utils.ts b/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/utils/permission-utils.ts
index caa21613ab2..1d4969bc915 100644
--- a/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/utils/permission-utils.ts
+++ b/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/utils/permission-utils.ts
@@ -82,6 +82,7 @@ export function buildPermissionsGraph(
viewData[schema] = {};
}
+ // Unjustified type cast. FIXME
(viewData[schema] as Record<TableId, string>)[tableId] = "sandboxed";
}
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/analytics.ts b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/analytics.ts
index 3e1aaa90176..4498c2642e0 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/analytics.ts
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/analytics.ts
@@ -220,6 +220,7 @@ const buildEventDetailsPartsForSettings = (
const options: string[] = [];
for (const _optionKey in settings) {
+ // Unjustified type cast. FIXME
const optionKey = _optionKey as keyof SdkIframeEmbedSettings;
if (!EMBED_SETTINGS_TO_TRACK.includes(optionKey)) {
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/Appearance/SimpleThemeSwitcherSection.tsx b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/Appearance/SimpleThemeSwitcherSection.tsx
index f5eaedadcec..62aa3bd2b41 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/Appearance/SimpleThemeSwitcherSection.tsx
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/Appearance/SimpleThemeSwitcherSection.tsx
@@ -15,6 +15,7 @@ export const SimpleThemeSwitcherSection = ({
return (
<Radio.Group
value={preset}
+ // Unjustified type cast. FIXME
onChange={(value) => onPresetChange(value as MetabaseThemePreset)}
>
<Stack gap="sm">
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/DatabaseRoutingWarning.tsx b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/DatabaseRoutingWarning.tsx
index 6c6e5566f70..c3b3dffb5d1 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/DatabaseRoutingWarning.tsx
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/DatabaseRoutingWarning.tsx
@@ -29,11 +29,13 @@ export const DatabaseRoutingWarning = ({
const databases = databasesResponse?.data || [];
if (resourceType === "question") {
+ // Unjustified type cast. FIXME
return questionUsesRoutingEnabledDatabase(resource as Card, databases);
}
if (resourceType === "dashboard") {
return dashboardUsesRoutingEnabledDatabases(
+ // Unjustified type cast. FIXME
resource as Dashboard,
databases,
);
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/LegacyStaticEmbeddingModal.tsx b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/LegacyStaticEmbeddingModal.tsx
index 60d8e983924..8cc491ecb2b 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/LegacyStaticEmbeddingModal.tsx
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/LegacyStaticEmbeddingModal.tsx
@@ -45,6 +45,7 @@ export const LegacyStaticEmbeddingModal = ({
if (experience === "chart") {
return (
<QuestionEmbedWidget
+ // Unjustified type cast. FIXME
card={resource as Card}
onBack={handleBack}
onClose={onClose}
@@ -55,6 +56,7 @@ export const LegacyStaticEmbeddingModal = ({
if (experience === "dashboard") {
return (
<DashboardSharingEmbeddingModal
+ // Unjustified type cast. FIXME
dashboard={resource as Dashboard}
onBack={handleBack}
onClose={onClose}
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/MetabotLayoutSetting.tsx b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/MetabotLayoutSetting.tsx
index 7247afe71a3..26a74d2c1d9 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/MetabotLayoutSetting.tsx
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/MetabotLayoutSetting.tsx
@@ -34,6 +34,7 @@ export const MetabotLayoutSetting = () => {
onChange={(layout) =>
updateSettings({
layout:
+ // Unjustified type cast. FIXME
layout === "auto" ? undefined : (layout as "stacked" | "sidebar"),
})
}
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/steps/AppearanceStep/AppearanceStep.unit.spec.tsx b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/steps/AppearanceStep/AppearanceStep.unit.spec.tsx
index 898f214d1e6..898a95a177d 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/steps/AppearanceStep/AppearanceStep.unit.spec.tsx
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/steps/AppearanceStep/AppearanceStep.unit.spec.tsx
@@ -14,6 +14,7 @@ const getOptionCardsWrapper = () => {
if (!wrapper) {
throw new Error("Could not find option cards wrapper with opacity style");
}
+ // Unjustified type cast. FIXME
return wrapper as HTMLElement;
};
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/steps/SelectEmbedExperienceStep/ExperienceCard.tsx b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/steps/SelectEmbedExperienceStep/ExperienceCard.tsx
index 2df87614212..218a4f1839e 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/steps/SelectEmbedExperienceStep/ExperienceCard.tsx
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/steps/SelectEmbedExperienceStep/ExperienceCard.tsx
@@ -43,6 +43,7 @@ export const ExperienceCard = () => {
value={experience}
onChange={(experience) =>
handleEmbedExperienceChange(
+ // Unjustified type cast. FIXME
experience as SdkIframeEmbedSetupExperience,
)
}
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/steps/SelectEmbedExperienceStep/ResourceCard.tsx b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/steps/SelectEmbedExperienceStep/ResourceCard.tsx
index 924088963eb..6f15d1b2625 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/steps/SelectEmbedExperienceStep/ResourceCard.tsx
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/steps/SelectEmbedExperienceStep/ResourceCard.tsx
@@ -23,6 +23,7 @@ import { getResourceIdFromSettings } from "../../../utils/get-default-sdk-iframe
// The picker uses the "recents" id to open on the Recent items tab while still
// being able to resolve to a valid initial path.
const PICKER_RECENTS_VALUE = {
+ // Unjustified type cast. FIXME
id: "recents" as CollectionId,
model: "collection" as const,
};
@@ -259,6 +260,7 @@ const hasResourceSelectionStep = (
SdkIframeEmbedSetupExperience,
(typeof EXPERIENCES_WITHOUT_RESOURCE_SELECTION)[number]
> =>
+ // Unjustified type cast. FIXME
!(
EXPERIENCES_WITHOUT_RESOURCE_SELECTION as SdkIframeEmbedSetupExperience[]
).includes(experience);
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-available-parameters.ts b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-available-parameters.ts
index 720e46e1b78..3fdd62c1d20 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-available-parameters.ts
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-available-parameters.ts
@@ -39,6 +39,7 @@ export const useAvailableParameters = ({
}
if (experience === "dashboard") {
+ // Unjustified type cast. FIXME
const dashboard = resource as Dashboard;
return getSavedDashboardUiParameters(
dashboard.dashcards,
@@ -47,6 +48,7 @@ export const useAvailableParameters = ({
metadata,
);
} else if (experience === "chart") {
+ // Unjustified type cast. FIXME
const card = resource as Card;
return getCardUiParameters(card, metadataRef.current) || [];
}
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-available-parameters.unit.spec.ts b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-available-parameters.unit.spec.ts
index 455cfa2363f..1d7b3d4f595 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-available-parameters.unit.spec.ts
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-available-parameters.unit.spec.ts
@@ -175,6 +175,7 @@ describe("useAvailableParameters", () => {
resource,
}),
{
+ // Unjustified type cast. FIXME
initialProps: { resource: firstDashboard as Dashboard | Card | null },
},
);
@@ -207,6 +208,7 @@ describe("useAvailableParameters", () => {
resource,
}),
{
+ // Unjustified type cast. FIXME
initialProps: { resource: dashboard as Dashboard | Card | null },
},
);
@@ -250,7 +252,9 @@ describe("useAvailableParameters", () => {
}),
{
initialProps: {
+ // Unjustified type cast. FIXME
experience: "dashboard" as "dashboard" | "chart",
+ // Unjustified type cast. FIXME
resource: dashboard as Dashboard | Card | null,
},
},
@@ -276,6 +280,7 @@ describe("useAvailableParameters", () => {
resource,
}),
{
+ // Unjustified type cast. FIXME
initialProps: { resource: null as Dashboard | Card | null },
},
);
@@ -298,6 +303,7 @@ describe("useAvailableParameters", () => {
resource,
}),
{
+ // Unjustified type cast. FIXME
initialProps: { resource: mockDashboard as Dashboard | Card | null },
},
);
@@ -327,6 +333,7 @@ describe("useAvailableParameters", () => {
renderHook(() =>
useAvailableParameters({
experience: "dashboard",
+ // Unjustified type cast. FIXME
resource: dashboardWithParamFields as unknown as Dashboard,
}),
);
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-embedding-parameters-conversion.ts b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-embedding-parameters-conversion.ts
index 4eddcba62e5..e55bdd3a7bc 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-embedding-parameters-conversion.ts
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-embedding-parameters-conversion.ts
@@ -23,7 +23,9 @@ export const useEmbeddingParametersConversion = () => {
return acc;
},
{
+ // Unjustified type cast. FIXME
hiddenParameters: [] as string[],
+ // Unjustified type cast. FIXME
lockedParameters: [] as string[],
},
);
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-embedding-parameters.unit.spec.ts b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-embedding-parameters.unit.spec.ts
index 8cb867315bf..5a18038f477 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-embedding-parameters.unit.spec.ts
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-embedding-parameters.unit.spec.ts
@@ -55,6 +55,7 @@ const mockCard = createMockCard({
name: "Test Question",
});
+// Unjustified type cast. FIXME
const defaultSettings: any = {
dashboardId: 1,
hiddenParameters: ["category"],
@@ -125,6 +126,7 @@ describe("useEmbeddingParameters", () => {
it("should return true when dashboardId and lockedParameters are present", () => {
const { result } = renderHook(() =>
useEmbeddingParameters({
+ // Unjustified type cast. FIXME
settings: {
dashboardId: 1,
lockedParameters: ["status"],
@@ -143,6 +145,7 @@ describe("useEmbeddingParameters", () => {
it("should return false when no resource id is present", () => {
const { result } = renderHook(() =>
useEmbeddingParameters({
+ // Unjustified type cast. FIXME
settings: {
hiddenParameters: ["category"],
isGuest: true,
@@ -160,6 +163,7 @@ describe("useEmbeddingParameters", () => {
it("should return false when no parameters are initialized", () => {
const { result } = renderHook(() =>
useEmbeddingParameters({
+ // Unjustified type cast. FIXME
settings: {
dashboardId: 1,
isGuest: true,
@@ -177,6 +181,7 @@ describe("useEmbeddingParameters", () => {
it("should work with questionId instead of dashboardId", () => {
const { result } = renderHook(() =>
useEmbeddingParameters({
+ // Unjustified type cast. FIXME
settings: {
questionId: 1,
lockedParameters: ["status"],
@@ -244,6 +249,7 @@ describe("useEmbeddingParameters", () => {
it("should mark parameter as enabled when not hidden or locked", () => {
const { result } = renderHook(() =>
useEmbeddingParameters({
+ // Unjustified type cast. FIXME
settings: {
dashboardId: 1,
hiddenParameters: [],
@@ -265,6 +271,7 @@ describe("useEmbeddingParameters", () => {
it("should prioritize locked over hidden", () => {
const { result } = renderHook(() =>
useEmbeddingParameters({
+ // Unjustified type cast. FIXME
settings: {
dashboardId: 1,
hiddenParameters: ["category"],
@@ -353,14 +360,18 @@ describe("useEmbeddingParameters", () => {
expect(mockUpdateSettings).not.toHaveBeenCalled();
rerender({
+ // Unjustified type cast. FIXME
resource: mockDashboard as any,
+ // Unjustified type cast. FIXME
initialAvailableParameters: [mockParameter1, mockParameter2] as any,
});
expect(mockUpdateSettings).toHaveBeenCalledTimes(1);
rerender({
+ // Unjustified type cast. FIXME
resource: mockDashboard as any,
+ // Unjustified type cast. FIXME
initialAvailableParameters: [mockParameter1, mockParameter2] as any,
});
@@ -398,7 +409,9 @@ describe("useEmbeddingParameters", () => {
);
rerender({
+ // Unjustified type cast. FIXME
resource: mockDashboard as any,
+ // Unjustified type cast. FIXME
initialAvailableParameters: [mockParameter1, mockParameter2] as any,
});
@@ -434,6 +447,7 @@ describe("useEmbeddingParameters", () => {
initialAvailableParameters: Parameter[] | null;
}) =>
useEmbeddingParameters({
+ // Unjustified type cast. FIXME
settings: {
questionId: 1,
isGuest: true,
@@ -453,7 +467,9 @@ describe("useEmbeddingParameters", () => {
);
rerender({
+ // Unjustified type cast. FIXME
resource: mockCard as any,
+ // Unjustified type cast. FIXME
initialAvailableParameters: [mockParameter1] as any,
});
@@ -503,6 +519,7 @@ describe("useEmbeddingParameters", () => {
const { result } = renderHook(() =>
useEmbeddingParameters({
+ // Unjustified type cast. FIXME
settings: {
dashboardId: 1,
hiddenParameters: ["param-with-dash_and_underscore"],
@@ -533,6 +550,7 @@ describe("useEmbeddingParameters", () => {
}),
{
initialProps: {
+ // Unjustified type cast. FIXME
resource: mockDashboard as Dashboard | Card,
},
},
@@ -572,7 +590,9 @@ describe("useEmbeddingParameters", () => {
}),
{
initialProps: {
+ // Unjustified type cast. FIXME
resource: firstDashboard as Dashboard | Card | null,
+ // Unjustified type cast. FIXME
initialAvailableParameters: [mockParameter1] as Parameter[] | null,
},
},
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-get-current-resource.ts b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-get-current-resource.ts
index f67f0cd936a..10175394aee 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-get-current-resource.ts
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-get-current-resource.ts
@@ -58,6 +58,7 @@ export const useGetCurrentResource = ({
error: cardLoadingError,
isLoading: isCardLoading,
isFetching: isCardFetching,
+ // Unjustified type cast. FIXME
} = useGetCardQuery(questionId ? { id: questionId as number } : skipToken, {
refetchOnMountOrArgChange: true,
});
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-sdk-iframe-embed-navigation.ts b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-sdk-iframe-embed-navigation.ts
index 8ee8c4de45d..1da7cfb4f26 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-sdk-iframe-embed-navigation.ts
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-sdk-iframe-embed-navigation.ts
@@ -59,6 +59,7 @@ export function useSdkIframeEmbedNavigation({
if (
!EXPERIENCES_WITHOUT_RESOURCE_SELECTION.includes(
+ // Unjustified type cast. FIXME
experience as (typeof EXPERIENCES_WITHOUT_RESOURCE_SELECTION)[number],
)
) {
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-toggle-resource-embedding.ts b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-toggle-resource-embedding.ts
index ccd803200cc..4ba93683f97 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-toggle-resource-embedding.ts
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/hooks/use-toggle-resource-embedding.ts
@@ -43,6 +43,7 @@ export const useToggleResourceEmbedding = () => {
} as const;
await handlersMap[resourceType]?.({
+ // Unjustified type cast. FIXME
id: resource.id as number,
enable_embedding: enableEmbedding,
embedding_type: enableEmbedding ? GUEST_EMBED_EMBEDDING_TYPE : null,
@@ -58,6 +59,7 @@ export const useToggleResourceEmbedding = () => {
} as const;
await handlersMap[resourceType]?.({
+ // Unjustified type cast. FIXME
id: resource.id as number,
embedding_params: embeddingParams,
embedding_type: GUEST_EMBED_EMBEDDING_TYPE,
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/build-embed-attributes.ts b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/build-embed-attributes.ts
index 8b3ce190c76..624d5d48b5c 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/build-embed-attributes.ts
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/build-embed-attributes.ts
@@ -35,8 +35,10 @@ export const buildEmbedAttributes = ({
const settingsWithOverrides = match(experience)
.with("chart", () => {
+ // Unjustified type cast. FIXME
const questionSettings = settings as SdkIframeQuestionEmbedSettings;
+ // Unjustified type cast. FIXME
return {
...questionSettings,
token,
@@ -53,8 +55,10 @@ export const buildEmbedAttributes = ({
} as QuestionEmbedOptions;
})
.with("exploration", () => {
+ // Unjustified type cast. FIXME
const explorationSettings = settings as ExplorationEmbedOptions;
+ // Unjustified type cast. FIXME
return {
...explorationSettings,
questionId: "new" as const,
@@ -65,8 +69,10 @@ export const buildEmbedAttributes = ({
} as unknown as ExplorationEmbedOptions;
})
.with("dashboard", () => {
+ // Unjustified type cast. FIXME
const dashboardSettings = settings as SdkIframeDashboardEmbedSettings;
+ // Unjustified type cast. FIXME
return {
...dashboardSettings,
token,
@@ -125,6 +131,7 @@ function transformEmbedSettingsToAttributes({
const attributes: [string, string][] = [];
for (const key of keysToProcess) {
+ // Unjustified type cast. FIXME
const value = (settings as any)[key];
if (value === undefined || value === null) {
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/build-embed-attributes.unit.spec.ts b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/build-embed-attributes.unit.spec.ts
index 2c86baaef4b..961cf325b49 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/build-embed-attributes.unit.spec.ts
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/build-embed-attributes.unit.spec.ts
@@ -347,6 +347,7 @@ describe("buildEmbedAttributes", () => {
describe("base settings exclusion", () => {
it("should exclude base configuration keys from attributes", () => {
+ // Unjustified type cast. FIXME
const settings: SdkIframeEmbedSetupSettings = {
componentName: "metabase-question",
questionId: 123,
@@ -399,6 +400,7 @@ describe("buildEmbedAttributes", () => {
describe("undefined and null values", () => {
it("should omit undefined values from attributes", () => {
+ // Unjustified type cast. FIXME
const settings: SdkIframeEmbedSetupSettings = {
questionId: 123,
withTitle: undefined,
@@ -419,9 +421,12 @@ describe("buildEmbedAttributes", () => {
});
it("should omit null values from attributes", () => {
+ // Unjustified type cast. FIXME
const settings: SdkIframeEmbedSetupSettings = {
questionId: 123,
+ // Unjustified type cast. FIXME
withTitle: null as any,
+ // Unjustified type cast. FIXME
drills: null as any,
apiKey: "test-api-key",
} as SdkIframeEmbedSetupSettings;
@@ -441,6 +446,7 @@ describe("buildEmbedAttributes", () => {
describe("camelCase to dash-case conversion", () => {
it("should convert camelCase keys to dash-case", () => {
+ // Unjustified type cast. FIXME
const settings: SdkIframeEmbedSetupSettings = {
questionId: 123,
isSaveEnabled: true,
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/derived-colors-for-embed-flow.ts b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/derived-colors-for-embed-flow.ts
index f91e5a94af6..55e464aa91d 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/derived-colors-for-embed-flow.ts
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/derived-colors-for-embed-flow.ts
@@ -66,6 +66,7 @@ export function getDerivedDefaultColorsForEmbedFlow({
for (const [_colorKey, config] of Object.entries(
EMBED_FLOW_DERIVED_COLORS_CONFIG,
)) {
+ // Unjustified type cast. FIXME
const colorKey = _colorKey as MetabaseColor;
// Do not derive colors if the user has already defined them
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/filter-empty-settings.ts b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/filter-empty-settings.ts
index b8147fcf4df..18944399b32 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/filter-empty-settings.ts
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/filter-empty-settings.ts
@@ -5,6 +5,7 @@
export function filterEmptySettings<T extends Record<string, any>>(
settings: T,
): T {
+ // Unjustified type cast. FIXME
return Object.fromEntries(
Object.entries(settings).filter(([, value]) => {
if (Array.isArray(value)) {
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/get-behavior-docs-url-params.unit.spec.ts b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/get-behavior-docs-url-params.unit.spec.ts
index 59fc05037d1..44d6b7a278f 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/get-behavior-docs-url-params.unit.spec.ts
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/get-behavior-docs-url-params.unit.spec.ts
@@ -47,6 +47,7 @@ describe("getBehaviorDocsUrlParams", () => {
},
])("returns $expected for $name", ({ settings, expected }) => {
expect(
+ // Unjustified type cast. FIXME
getBehaviorDocsUrlParams(settings as SdkIframeEmbedSetupSettings),
).toEqual(expected);
});
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/get-common-embed-settings.unit.spec.ts b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/get-common-embed-settings.unit.spec.ts
index 5eb287a2fbf..1ecba42cc80 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/get-common-embed-settings.unit.spec.ts
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/get-common-embed-settings.unit.spec.ts
@@ -10,6 +10,7 @@ jest.mock("metabase/plugins", () => ({
}));
const mockIsPluginEnabled = (enabled: boolean) => {
+ // Unjustified type cast. FIXME
(PLUGIN_EMBEDDING_IFRAME_SDK_SETUP.isEnabled as jest.Mock).mockReturnValue(
enabled,
);
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/get-default-sdk-iframe-embed-setting.unit.spec.ts b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/get-default-sdk-iframe-embed-setting.unit.spec.ts
index 1360c8bfea3..af289d9ea6e 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/get-default-sdk-iframe-embed-setting.unit.spec.ts
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/get-default-sdk-iframe-embed-setting.unit.spec.ts
@@ -121,6 +121,7 @@ describe("getResourceIdFromSettings", () => {
{ settings: {}, expected: undefined },
{ settings: { componentName: "metabase-metabot" }, expected: undefined },
])("returns $expected for $settings", ({ settings, expected }) => {
+ // Unjustified type cast. FIXME
expect(getResourceIdFromSettings(settings as never)).toBe(expected);
});
});
@@ -151,6 +152,7 @@ describe("getExperienceFromSettings", () => {
expected: "metabot",
},
])("returns $expected for $settings", ({ settings, expected }) => {
+ // Unjustified type cast. FIXME
expect(getExperienceFromSettings(settings as never)).toBe(expected);
});
});
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/get-visible-parameters.ts b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/get-visible-parameters.ts
index fdbecd3fb80..2938e7efea3 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/get-visible-parameters.ts
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/get-visible-parameters.ts
@@ -21,6 +21,7 @@ export const getVisibleParameters = <
return getNormalizedParameters(parameters);
}
+ // Unjustified type cast. FIXME
const filteredParameters = Object.fromEntries(
Object.entries(parameters).filter(
([key]) => !lockedParameters.includes(key),
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/is-question-or-dashboard-settings.unit.spec.ts b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/is-question-or-dashboard-settings.unit.spec.ts
index 776d0f7e4eb..c381c82c071 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/is-question-or-dashboard-settings.unit.spec.ts
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/utils/is-question-or-dashboard-settings.unit.spec.ts
@@ -18,6 +18,7 @@ describe("isQuestionOrDashboardSettings", () => {
])(
"should return $expected when dashboardId is $description",
({ dashboardId, expected }) => {
+ // Unjustified type cast. FIXME
const settings = {
dashboardId,
apiKey: "test-key",
@@ -30,6 +31,7 @@ describe("isQuestionOrDashboardSettings", () => {
);
it("should return false when questionId is provided instead of dashboardId", () => {
+ // Unjustified type cast. FIXME
const settings = {
questionId: 123,
apiKey: "test-key",
@@ -53,6 +55,7 @@ describe("isQuestionOrDashboardSettings", () => {
])(
"should return $expected when questionId is $description",
({ questionId, expected }) => {
+ // Unjustified type cast. FIXME
const settings = {
questionId,
apiKey: "test-key",
@@ -65,6 +68,7 @@ describe("isQuestionOrDashboardSettings", () => {
);
it("should return false when dashboardId is provided instead of questionId", () => {
+ // Unjustified type cast. FIXME
const settings = {
dashboardId: 456,
apiKey: "test-key",
@@ -79,24 +83,28 @@ describe("isQuestionOrDashboardSettings", () => {
describe("other experiences", () => {
it.each([
{
+ // Unjustified type cast. FIXME
experience: "exploration" as SdkIframeEmbedSetupExperience,
settings: { questionId: 123 },
description: "exploration with questionId",
expected: false,
},
{
+ // Unjustified type cast. FIXME
experience: "exploration" as SdkIframeEmbedSetupExperience,
settings: { dashboardId: 123 },
description: "exploration with dashboardId",
expected: false,
},
{
+ // Unjustified type cast. FIXME
experience: "browser" as SdkIframeEmbedSetupExperience,
settings: { questionId: 123, dashboardId: 456 },
description: "browser with both IDs",
expected: false,
},
{
+ // Unjustified type cast. FIXME
experience: "metabot" as SdkIframeEmbedSetupExperience,
settings: { questionId: 123, dashboardId: 456 },
description: "metabot with both IDs",
@@ -107,6 +115,7 @@ describe("isQuestionOrDashboardSettings", () => {
({ experience, settings, expected }) => {
const result = isQuestionOrDashboardSettings(
experience,
+ // Unjustified type cast. FIXME
settings as unknown as SdkIframeEmbedSetupSettings,
);
@@ -126,6 +135,7 @@ describe("isQuestionOrDashboardSettings", () => {
])(
"should return $expected when both IDs are present for $description experience",
({ experience, expected }) => {
+ // Unjustified type cast. FIXME
const settings = {
dashboardId: 123,
questionId: 456,
@@ -150,6 +160,7 @@ describe("isQuestionOrDashboardSettings", () => {
({ settings, expected }) => {
const result = isQuestionOrDashboardSettings(
"dashboard",
+ // Unjustified type cast. FIXME
settings as SdkIframeEmbedSetupSettings,
);
@@ -160,6 +171,7 @@ describe("isQuestionOrDashboardSettings", () => {
describe("type guard behavior", () => {
it("should narrow type to SdkIframeDashboardEmbedSettings for dashboard", () => {
+ // Unjustified type cast. FIXME
const settings = {
dashboardId: 123,
apiKey: "test-key",
@@ -174,6 +186,7 @@ describe("isQuestionOrDashboardSettings", () => {
});
it("should narrow type to SdkIframeQuestionEmbedSettings for chart", () => {
+ // Unjustified type cast. FIXME
const settings = {
questionId: 456,
apiKey: "test-key",
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk/analytics.ts b/frontend/src/metabase/embedding/embedding-iframe-sdk/analytics.ts
index 4cc4e24140f..509a5d8ba45 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk/analytics.ts
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk/analytics.ts
@@ -442,6 +442,7 @@ function countPropertyValues<
const counts = new Map<string, number>();
options.embeds.forEach((embed) => {
+ // Unjustified type cast. FIXME
const propertyValue = (embed.properties as Record<string, any>)[
options.propertyName
];
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk/analytics.unit.spec.tsx b/frontend/src/metabase/embedding/embedding-iframe-sdk/analytics.unit.spec.tsx
index c3bc71a6a26..f9bc5c467fe 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk/analytics.unit.spec.tsx
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk/analytics.unit.spec.tsx
@@ -6,6 +6,7 @@ import { createEmbeddedAnalyticsJsUsage } from "./analytics";
import type { SdkIframeEmbedBaseSettings } from "./types/embed";
const defineMetabaseConfig = (config: SdkIframeEmbedBaseSettings) => {
+ // Unjustified type cast. FIXME
(window as any).metabaseConfig = config;
};
@@ -1121,6 +1122,7 @@ function createEmbeddedAnalyticsJsElement(
componentName: Component,
properties: Record<string, any> = {},
): MetabaseEmbedElement {
+ // Unjustified type cast. FIXME
const component = document.createElement(
componentName,
) as MetabaseEmbedElement;
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk/components/MetabaseBrowser.tsx b/frontend/src/metabase/embedding/embedding-iframe-sdk/components/MetabaseBrowser.tsx
index b4d3d86c8cd..675ec454324 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk/components/MetabaseBrowser.tsx
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk/components/MetabaseBrowser.tsx
@@ -171,6 +171,7 @@ export function MetabaseBrowser({ settings }: MetabaseBrowserProps) {
const type = match<string, SdkBreadcrumbItemType>(item.model)
.with("card", () => "question")
.with("dataset", () => "model")
+ // Unjustified type cast. FIXME
.otherwise((model) => model as SdkBreadcrumbItemType);
setCurrentView({ type, id: item.id });
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk/components/SdkIframeEmbedRoute.tsx b/frontend/src/metabase/embedding/embedding-iframe-sdk/components/SdkIframeEmbedRoute.tsx
index f95f09979a7..b016f946757 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk/components/SdkIframeEmbedRoute.tsx
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk/components/SdkIframeEmbedRoute.tsx
@@ -117,6 +117,7 @@ export const SdkIframeEmbedRoute = () => {
return <SdkIframeExistingUserSessionInProductionError />;
}
+ // Unjustified type cast. FIXME
const authConfig = {
isGuest: embedSettings.isGuest,
metabaseInstanceUrl: embedSettings.instanceUrl,
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk/embed.stories.tsx b/frontend/src/metabase/embedding/embedding-iframe-sdk/embed.stories.tsx
index 6c9a00c6163..88e2b9eccd8 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk/embed.stories.tsx
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk/embed.stories.tsx
@@ -13,8 +13,10 @@ import type { MetabaseDashboardElement } from "./embed";
type Mode = "controlled" | "uncontrolled";
const INSTANCE_URL =
+ // Unjustified type cast. FIXME
(window as any).METABASE_INSTANCE_URL || "http://localhost:3000";
+// Unjustified type cast. FIXME
const DASHBOARD_ID = (window as any).DASHBOARD_ID || 1;
// Module-level init: the custom element reads `window.metabaseConfig`
@@ -61,6 +63,7 @@ const ControlledParametersEmbedJsPlayground = () => {
let onParametersChange: ((event: Event) => void) | null = null;
if (mode === "controlled") {
onParametersChange = (event: Event) => {
+ // Unjustified type cast. FIXME
const detail = (event as CustomEvent<ParameterChangePayload>).detail;
playground.handleParametersChange(detail);
@@ -103,6 +106,7 @@ const ControlledParametersEmbedJsPlayground = () => {
<SegmentedControl
size="xs"
value={mode}
+ // Unjustified type cast. FIXME
onChange={(value) => setMode(value as Mode)}
data={[
{ value: "controlled", label: "controlled" },
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk/embed.ts b/frontend/src/metabase/embedding/embedding-iframe-sdk/embed.ts
index e7b1d6863c9..f304dbe8710 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk/embed.ts
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk/embed.ts
@@ -55,12 +55,14 @@ export const setupConfigWatcher = () => {
return Reflect.get(target, prop, receiver);
},
set(metabaseConfig, prop, newValue) {
+ // Unjustified type cast. FIXME
metabaseConfig[prop as string] = newValue;
updateAllEmbeds({ [prop]: newValue });
return true;
},
});
+ // Unjustified type cast. FIXME
let currentConfig = (window as any).metabaseConfig || {};
let proxyConfig: Record<string, unknown> = createProxy(currentConfig);
@@ -116,6 +118,7 @@ const raiseError = (message: string) => {
function assertFieldCanBeUpdated(
newValues: Partial<SdkIframeEmbedElementSettings>,
) {
+ // Unjustified type cast. FIXME
const currentConfig = (window as any).metabaseConfig || {};
for (const field of DISABLE_UPDATE_FOR_KEYS) {
if (
@@ -137,6 +140,7 @@ function assertValidMetabaseConfigField(
for (const field in newValues) {
if (
!ALLOWED_EMBED_SETTING_KEYS_MAP.base.includes(
+ // Unjustified type cast. FIXME
field as AllowedMetabaseConfigKey,
)
) {
@@ -170,6 +174,7 @@ export abstract class MetabaseEmbedElement<T extends string[] = string[]>
}
get globalSettings() {
+ // Unjustified type cast. FIXME
return (window as any).metabaseConfig || {};
}
@@ -184,9 +189,11 @@ export abstract class MetabaseEmbedElement<T extends string[] = string[]>
}
return acc;
},
+ // Unjustified type cast. FIXME
{} as Record<string, unknown>,
);
+ // Unjustified type cast. FIXME
return {
...this.globalSettings,
...attributesConverted,
@@ -203,6 +210,7 @@ export abstract class MetabaseEmbedElement<T extends string[] = string[]>
): void {
if (type === "ready") {
const eventType = type;
+ // Unjustified type cast. FIXME
const handler = listener as SdkIframeEmbedEventHandler;
if (!this._eventHandlers.has(eventType)) {
this._eventHandlers.set(eventType, new Set());
@@ -229,6 +237,7 @@ export abstract class MetabaseEmbedElement<T extends string[] = string[]>
): void {
if (type === "ready") {
const eventType = type;
+ // Unjustified type cast. FIXME
const handler = listener as SdkIframeEmbedEventHandler;
const handlers = this._eventHandlers.get(eventType);
@@ -249,6 +258,7 @@ export abstract class MetabaseEmbedElement<T extends string[] = string[]>
* Send a message with the new settings
*/
_updateSettings(settings: Partial<SdkIframeEmbedElementSettings>) {
+ // Unjustified type cast. FIXME
const newValues = {
...this.properties,
...settings,
@@ -316,9 +326,11 @@ export abstract class MetabaseEmbedElement<T extends string[] = string[]>
return;
}
+ // Unjustified type cast. FIXME
const key = attributeToSettingKey(
attrName,
) as keyof SdkIframeEmbedElementSettings;
+ // Unjustified type cast. FIXME
if ((DISABLE_UPDATE_FOR_KEYS as readonly string[]).includes(key)) {
console.error(`${key} cannot be updated after the embed is created`);
return;
@@ -501,10 +513,12 @@ export abstract class MetabaseEmbedElement<T extends string[] = string[]>
return acc;
}
+ // Unjustified type cast. FIXME
acc[key as keyof typeof acc] = value;
return acc;
},
+ // Unjustified type cast. FIXME
{} as Message["data"],
);
@@ -681,6 +695,7 @@ export abstract class MetabaseEmbedElement<T extends string[] = string[]>
return undefined;
}
+ // Unjustified type cast. FIXME
return parsed as T;
}
@@ -750,6 +765,7 @@ function createCustomElement<
attributeNames: U,
decorate?: (Base: ConcreteEmbedElementConstructor<U>) => C,
): C {
+ // Unjustified type cast. FIXME
const Base = class extends MetabaseEmbedElement<U> {
protected _componentName: string = componentName;
protected _attributeNames: U = attributeNames;
@@ -759,6 +775,7 @@ function createCustomElement<
}
} as unknown as ConcreteEmbedElementConstructor<U>;
+ // Unjustified type cast. FIXME
const CustomEmbedElement = (decorate ? decorate(Base) : Base) as C;
if (typeof window !== "undefined" && !customElements.get(componentName)) {
@@ -847,7 +864,9 @@ const MetabaseMetabotElement = createCustomElement("metabase-metabot", [
// Expose the old API that's still used in the tests, we'll probably remove this api unless customers prefer it
if (typeof window !== "undefined") {
+ // Unjustified type cast. FIXME
(window as any)["metabase.embed"] = {
+ // Unjustified type cast. FIXME
...(window as any)["metabase.embed"],
};
}
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk/embed.unit.spec.ts b/frontend/src/metabase/embedding/embedding-iframe-sdk/embed.unit.spec.ts
index ee9596b62f6..a9c2beb0cea 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk/embed.unit.spec.ts
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk/embed.unit.spec.ts
@@ -9,6 +9,7 @@ import {
} from "./embed";
const defineMetabaseConfig = (config: unknown) => {
+ // Unjustified type cast. FIXME
(window as any).metabaseConfig = config;
};
@@ -124,6 +125,7 @@ describe("embed.js script tag for sdk iframe embedding", () => {
it.each(authErrorTestCases)(
"reports an error when auth methods are not mutually exclusive for %p",
(settings) => {
+ // Unjustified type cast. FIXME
const { questionId, dashboardId, ...config } = settings as Partial<
typeof settings
> & {
@@ -166,6 +168,7 @@ describe("embed.js script tag for sdk iframe embedding", () => {
it.each(singleAuthTestCases)(
"does not report an error when only one auth method is provided for %p",
(settings) => {
+ // Unjustified type cast. FIXME
const { questionId, dashboardId, ...config } = settings as Partial<
typeof settings
> & {
@@ -247,6 +250,7 @@ describe("embed.js script tag for sdk iframe embedding", () => {
}
document.body.appendChild(embed);
+ // Unjustified type cast. FIXME
const iframe = embed.querySelector("iframe") as HTMLIFrameElement;
const iframePostMessageSpy = jest.spyOn(
iframe.contentWindow!,
@@ -516,12 +520,14 @@ describe("embed.js script tag for sdk iframe embedding", () => {
const setupDashboard = () => {
defineMetabaseConfig({ instanceUrl: "http://localhost:3000" });
+ // Unjustified type cast. FIXME
const embed = document.createElement(
"metabase-dashboard",
) as MetabaseDashboardElement;
embed.setAttribute("dashboard-id", "1");
document.body.appendChild(embed);
+ // Unjustified type cast. FIXME
const iframe = embed.querySelector("iframe") as HTMLIFrameElement;
const iframePostMessageSpy = jest.spyOn(
iframe.contentWindow!,
@@ -658,6 +664,7 @@ describe("embed.js script tag for sdk iframe embedding", () => {
iframePostMessageSpy.mockClear();
expect(() => {
+ // Unjustified type cast. FIXME
(embed as unknown as { parameters: unknown }).parameters = null;
}).not.toThrow();
@@ -688,6 +695,7 @@ describe("embed.js script tag for sdk iframe embedding", () => {
});
expect(handler).toHaveBeenCalledTimes(1);
+ // Unjustified type cast. FIXME
const event = handler.mock.calls[0][0] as CustomEvent;
expect(event.detail).toEqual(payload);
});
@@ -697,12 +705,14 @@ describe("embed.js script tag for sdk iframe embedding", () => {
const setupQuestion = () => {
defineMetabaseConfig({ instanceUrl: "http://localhost:3000" });
+ // Unjustified type cast. FIXME
const embed = document.createElement(
"metabase-question",
) as MetabaseQuestionElement;
embed.setAttribute("question-id", "1");
document.body.appendChild(embed);
+ // Unjustified type cast. FIXME
const iframe = embed.querySelector("iframe") as HTMLIFrameElement;
const iframePostMessageSpy = jest.spyOn(
iframe.contentWindow!,
@@ -774,6 +784,7 @@ describe("embed.js script tag for sdk iframe embedding", () => {
});
expect(handler).toHaveBeenCalledTimes(1);
+ // Unjustified type cast. FIXME
const event = handler.mock.calls[0][0] as CustomEvent;
expect(event.detail).toEqual(payload);
});
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk/plugin.ts b/frontend/src/metabase/embedding/embedding-iframe-sdk/plugin.ts
index 8d0ae47d29e..2d2cd2f3a49 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk/plugin.ts
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk/plugin.ts
@@ -1,5 +1,6 @@
import type { EmbedAuthManagerConstructor } from "metabase/embedding/embedding-iframe-sdk/types/auth-manager";
export const PLUGIN_EMBED_JS_EE = {
+ // Unjustified type cast. FIXME
EmbedAuthManager: null as EmbedAuthManagerConstructor | null,
};
diff --git a/frontend/src/metabase/embedding/hooks/use-sharing-modal.unit.spec.tsx b/frontend/src/metabase/embedding/hooks/use-sharing-modal.unit.spec.tsx
index c7c8d948d15..b340f82088c 100644
--- a/frontend/src/metabase/embedding/hooks/use-sharing-modal.unit.spec.tsx
+++ b/frontend/src/metabase/embedding/hooks/use-sharing-modal.unit.spec.tsx
@@ -21,6 +21,7 @@ jest.mock("metabase/embedding/hooks/use-open-embed-js-wizard", () => ({
useOpenEmbedJsWizard: () => mockOpenEmbedJsWizard,
}));
+// Unjustified type cast. FIXME
const mockResource = { id: 1 } as Dashboard;
const mockResourceType = "dashboard" as const;
@@ -136,6 +137,7 @@ describe("useSharingModal", () => {
expect(result.current.modalType).toBe(STATIC_LEGACY_EMBEDDING_TYPE);
act(() => {
+ // Unjustified type cast. FIXME
result.current.setModalType("public-link" as DashboardSharingModalType);
});
diff --git a/frontend/src/metabase/embedding/lib/analytics.ts b/frontend/src/metabase/embedding/lib/analytics.ts
index d324b063e7c..47d495f18ba 100644
--- a/frontend/src/metabase/embedding/lib/analytics.ts
+++ b/frontend/src/metabase/embedding/lib/analytics.ts
@@ -136,6 +136,7 @@ export const trackPublicLinkCopied = ({
trackSchemaEvent(SCHEMA_NAME, {
event: "public_link_copied",
artifact,
+ // Unjustified type cast. FIXME
format: format as any, // ExportFormatType is untyped
});
};
diff --git a/frontend/src/metabase/embedding/lib/code-templates.ts b/frontend/src/metabase/embedding/lib/code-templates.ts
index 84e4b1ea35d..52c5d72c8dc 100644
--- a/frontend/src/metabase/embedding/lib/code-templates.ts
+++ b/frontend/src/metabase/embedding/lib/code-templates.ts
@@ -52,6 +52,7 @@ function removeDefaultValueParameters(
return Object.fromEntries(
Object.entries(options).filter(
([key, value]) =>
+ // Unjustified type cast. FIXME
value !== defaultValues[key as keyof EmbeddingDisplayOptions],
),
);
diff --git a/frontend/src/metabase/embedding/lib/count-embedding-parameter-options.ts b/frontend/src/metabase/embedding/lib/count-embedding-parameter-options.ts
index d69decd346c..0709a239ec1 100644
--- a/frontend/src/metabase/embedding/lib/count-embedding-parameter-options.ts
+++ b/frontend/src/metabase/embedding/lib/count-embedding-parameter-options.ts
@@ -11,6 +11,7 @@ export const countEmbeddingParameterOptions = (
acc[value] += 1;
return acc;
},
+ // Unjustified type cast. FIXME
{ disabled: 0, locked: 0, enabled: 0 } as Record<
EmbeddingParameterVisibility,
number
diff --git a/frontend/src/metabase/embedding/lib/embed.ts b/frontend/src/metabase/embedding/lib/embed.ts
index c654f7a60e5..f149f2e085e 100644
--- a/frontend/src/metabase/embedding/lib/embed.ts
+++ b/frontend/src/metabase/embedding/lib/embed.ts
@@ -18,6 +18,7 @@ export async function getSignedToken(
previewEmbeddingParams: EmbeddingParametersValues,
expirationMinutes: number = DEFAULT_SIGNED_TOKEN_EXPIRATION_MINUTES,
) {
+ // Unjustified type cast. FIXME
const normalizedResourceId = parseInt(rawResourceId as string, 10);
const iat = Math.round(new Date().getTime() / 1000);
diff --git a/frontend/src/metabase/embedding/mcp/McpExploreButton.unit.spec.tsx b/frontend/src/metabase/embedding/mcp/McpExploreButton.unit.spec.tsx
index 50751c14df2..6b9fbf6c6c5 100644
--- a/frontend/src/metabase/embedding/mcp/McpExploreButton.unit.spec.tsx
+++ b/frontend/src/metabase/embedding/mcp/McpExploreButton.unit.spec.tsx
@@ -80,6 +80,7 @@ function setup() {
withEditorButton={false}
withChartTypeSelector={false}
>
+ {/* Unjustified type cast. FIXME */}
<McpExploreButton app={app as any} instanceUrl={instanceUrl} />
</SdkQuestion>,
{
diff --git a/frontend/src/metabase/embedding/mcp/McpUiAppRoute.tsx b/frontend/src/metabase/embedding/mcp/McpUiAppRoute.tsx
index c70c2a19948..d5c4a383667 100644
--- a/frontend/src/metabase/embedding/mcp/McpUiAppRoute.tsx
+++ b/frontend/src/metabase/embedding/mcp/McpUiAppRoute.tsx
@@ -51,6 +51,7 @@ export function McpUiAppRoute() {
const { app, hostContext, prompt, query } = useMcpApp();
const { instanceUrl = "", sessionToken = "" } =
+ // Unjustified type cast. FIXME
(window.metabaseConfig as McpMetabaseConfig) ?? {};
const scheme: ResolvedColorScheme =
@@ -102,6 +103,7 @@ function McpUiAppRouteContent({
const isHosted = useSelector(getIsHosted);
const { mcpSessionId = "" } =
+ // Unjustified type cast. FIXME
(window.metabaseConfig as McpMetabaseConfig) ?? {};
const safeAreaInsets = hostContext?.safeAreaInsets ?? DEFAULT_INSETS;
diff --git a/frontend/src/metabase/embedding/mcp/McpUiAppRoute.utils.ts b/frontend/src/metabase/embedding/mcp/McpUiAppRoute.utils.ts
index a7c2d4e18dc..59fbfe496fe 100644
--- a/frontend/src/metabase/embedding/mcp/McpUiAppRoute.utils.ts
+++ b/frontend/src/metabase/embedding/mcp/McpUiAppRoute.utils.ts
@@ -8,6 +8,7 @@ export const MCP_APP_VISUALIZATION_SETTINGS: VisualizationSettings = {
export function getMcpDeserializedCard(query: string): Card | null {
try {
+ // Unjustified type cast. FIXME
return {
display: "table",
dataset_query: JSON.parse(b64_to_utf8(query)),
diff --git a/frontend/src/metabase/embedding/mcp/hooks/useHandleMcpDrillThrough.ts b/frontend/src/metabase/embedding/mcp/hooks/useHandleMcpDrillThrough.ts
index 9078ec9b995..3f95d5c846d 100644
--- a/frontend/src/metabase/embedding/mcp/hooks/useHandleMcpDrillThrough.ts
+++ b/frontend/src/metabase/embedding/mcp/hooks/useHandleMcpDrillThrough.ts
@@ -54,6 +54,7 @@ export function useHandleMcpDrillThrough(app: App | null): DrillThroughHandler {
}
const { instanceUrl, sessionToken, mcpSessionId } =
+ // Unjustified type cast. FIXME
(window.metabaseConfig as McpGlobalConfig | undefined) ?? {};
if (isClaudeHost(app)) {
diff --git a/frontend/src/metabase/embedding/mcp/hooks/useHandleMcpDrillThrough.unit.spec.ts b/frontend/src/metabase/embedding/mcp/hooks/useHandleMcpDrillThrough.unit.spec.ts
index b975b09b6d7..9685bd452b7 100644
--- a/frontend/src/metabase/embedding/mcp/hooks/useHandleMcpDrillThrough.unit.spec.ts
+++ b/frontend/src/metabase/embedding/mcp/hooks/useHandleMcpDrillThrough.unit.spec.ts
@@ -16,6 +16,7 @@ const NEXT_CARD = createMockCard({
describe("useHandleMcpDrillThrough", () => {
beforeEach(() => {
+ // Unjustified type cast. FIXME
(window as any).metabaseConfig = {
instanceUrl: "https://metabase.example",
sessionToken: "session-token",
@@ -26,6 +27,7 @@ describe("useHandleMcpDrillThrough", () => {
});
afterEach(() => {
+ // Unjustified type cast. FIXME
delete (window as any).metabaseConfig;
});
@@ -37,6 +39,7 @@ describe("useHandleMcpDrillThrough", () => {
};
const defaultNavigate = jest.fn();
+ // Unjustified type cast. FIXME
const { result } = renderHook(() => useHandleMcpDrillThrough(app as any));
await result.current(
@@ -65,6 +68,7 @@ describe("useHandleMcpDrillThrough", () => {
};
const defaultNavigate = jest.fn();
+ // Unjustified type cast. FIXME
const { result } = renderHook(() => useHandleMcpDrillThrough(app as any));
await result.current(
diff --git a/frontend/src/metabase/embedding/mcp/hooks/useMcpApp.tsx b/frontend/src/metabase/embedding/mcp/hooks/useMcpApp.tsx
index f1eb27d2376..de964939707 100644
--- a/frontend/src/metabase/embedding/mcp/hooks/useMcpApp.tsx
+++ b/frontend/src/metabase/embedding/mcp/hooks/useMcpApp.tsx
@@ -62,6 +62,7 @@ export function useMcpApp(): McpAppState {
app.ontoolinput = (params) => {
const { query } =
+ // Unjustified type cast. FIXME
(params.arguments as VisualizeQueryToolInput | undefined) ?? {};
if (query) {
@@ -75,6 +76,7 @@ export function useMcpApp(): McpAppState {
// Also the source of `prompt`, which visualize_query includes in structuredContent.
app.ontoolresult = (params) => {
const { query, prompt } =
+ // Unjustified type cast. FIXME
(params.structuredContent as VisualizeQueryToolResult | undefined) ??
{};
diff --git a/frontend/src/metabase/embedding/mcp/hooks/useMcpFeedback.unit.spec.ts b/frontend/src/metabase/embedding/mcp/hooks/useMcpFeedback.unit.spec.ts
index 673768279a2..bb9f430cc73 100644
--- a/frontend/src/metabase/embedding/mcp/hooks/useMcpFeedback.unit.spec.ts
+++ b/frontend/src/metabase/embedding/mcp/hooks/useMcpFeedback.unit.spec.ts
@@ -53,6 +53,7 @@ describe("useMcpFeedback", () => {
{ method: "POST" },
);
+ // Unjustified type cast. FIXME
expect(JSON.parse(lastCall?.options?.body as string)).toEqual({
feedback: {
positive: false,
diff --git a/frontend/src/metabase/embedding/mcp/hooks/useMcpVisualizationSelector.ts b/frontend/src/metabase/embedding/mcp/hooks/useMcpVisualizationSelector.ts
index 31c584178a6..fc1b1a6fb22 100644
--- a/frontend/src/metabase/embedding/mcp/hooks/useMcpVisualizationSelector.ts
+++ b/frontend/src/metabase/embedding/mcp/hooks/useMcpVisualizationSelector.ts
@@ -69,6 +69,7 @@ export function useMcpVisualizationSelector({
const sensibleChartTypes = getMcpChartTypes({
defaultDisplay: defaultDisplayState.defaultDisplay,
+ // Unjustified type cast. FIXME
sensibleVisualizations: sensibleVisualizations as CardDisplayType[],
canShowTable: rowCount >= 2,
});
diff --git a/frontend/src/metabase/embedding/mcp/hooks/useMcpVisualizationSelector.unit.spec.ts b/frontend/src/metabase/embedding/mcp/hooks/useMcpVisualizationSelector.unit.spec.ts
index 2ede3f8068d..3cbc97b5178 100644
--- a/frontend/src/metabase/embedding/mcp/hooks/useMcpVisualizationSelector.unit.spec.ts
+++ b/frontend/src/metabase/embedding/mcp/hooks/useMcpVisualizationSelector.unit.spec.ts
@@ -19,6 +19,7 @@ jest.mock("metabase/visualizations/lib/sensibility", () => ({
const mockGetSensibleVisualizations = jest.mocked(getSensibleVisualizations);
const createQuestion = (display: CardDisplayType): Question =>
+ // Unjustified type cast. FIXME
({
display: jest.fn(() => display),
setDisplay: jest.fn(
@@ -30,6 +31,7 @@ const createQuestion = (display: CardDisplayType): Question =>
}) as unknown as Question;
const createQueryResult = (rowCount: number) =>
+ // Unjustified type cast. FIXME
({
data: { rows: Array.from({ length: rowCount }, () => []) },
}) as unknown as Dataset;
diff --git a/frontend/src/metabase/embedding/mcp/utils/captureDefaultDisplay.unit.spec.ts b/frontend/src/metabase/embedding/mcp/utils/captureDefaultDisplay.unit.spec.ts
index 7dbc4d5c632..8473f31695a 100644
--- a/frontend/src/metabase/embedding/mcp/utils/captureDefaultDisplay.unit.spec.ts
+++ b/frontend/src/metabase/embedding/mcp/utils/captureDefaultDisplay.unit.spec.ts
@@ -5,6 +5,7 @@ import {
captureDefaultDisplay,
} from "./captureDefaultDisplay";
+// Unjustified type cast. FIXME
const createQueryResult = () => ({}) as Dataset;
const createState = ({
diff --git a/frontend/src/metabase/embedding/mcp/utils/resolveConcreteColor.unit.spec.ts b/frontend/src/metabase/embedding/mcp/utils/resolveConcreteColor.unit.spec.ts
index dd72dd8ff61..bf96276029b 100644
--- a/frontend/src/metabase/embedding/mcp/utils/resolveConcreteColor.unit.spec.ts
+++ b/frontend/src/metabase/embedding/mcp/utils/resolveConcreteColor.unit.spec.ts
@@ -37,6 +37,7 @@ describe("resolveConcreteColor", () => {
it("resolves a var() reference via computed style", () => {
getComputedStyleSpy = jest
.spyOn(window, "getComputedStyle")
+ // Unjustified type cast. FIXME
.mockReturnValue({ color: "rgb(30, 30, 30)" } as CSSStyleDeclaration);
expect(
@@ -47,6 +48,7 @@ describe("resolveConcreteColor", () => {
it("falls back to original value when computed style returns empty", () => {
getComputedStyleSpy = jest
.spyOn(window, "getComputedStyle")
+ // Unjustified type cast. FIXME
.mockReturnValue({ color: "" } as CSSStyleDeclaration);
expect(resolveConcreteColor("var(--unknown-variable)", "light")).toBe(
diff --git a/frontend/src/metabase/hoc/MantineTheme.tsx b/frontend/src/metabase/hoc/MantineTheme.tsx
index 738d8ddd5a2..4c0168eebcc 100644
--- a/frontend/src/metabase/hoc/MantineTheme.tsx
+++ b/frontend/src/metabase/hoc/MantineTheme.tsx
@@ -16,6 +16,7 @@ export function withMantineTheme<
return function MantineThemeWrapper(props) {
const theme = useMantineTheme();
+ // Unjustified type cast. FIXME
return <ComposedComponent {...(props as T)} theme={theme} />;
};
}
diff --git a/frontend/src/metabase/hoc/ModalRoute.tsx b/frontend/src/metabase/hoc/ModalRoute.tsx
index a6b635e1e2d..80ab77c8e50 100644
--- a/frontend/src/metabase/hoc/ModalRoute.tsx
+++ b/frontend/src/metabase/hoc/ModalRoute.tsx
@@ -131,4 +131,5 @@ class _ModalRoute extends Route {
// ModalRoute extends react-router's Route which is not generic,
// so it's impossible to extend Route's props.
export const ModalRoute =
+ // Unjustified type cast. FIXME
_ModalRoute as unknown as React.ComponentType<ModalRouteProps>;
diff --git a/frontend/src/metabase/hoc/Remapped.tsx b/frontend/src/metabase/hoc/Remapped.tsx
index 39492d71afd..ea667e943bb 100644
--- a/frontend/src/metabase/hoc/Remapped.tsx
+++ b/frontend/src/metabase/hoc/Remapped.tsx
@@ -141,5 +141,6 @@ export default (ComposedComponent: ComponentType<any>) => {
return connect(
mapStateToProps,
mapDispatchToProps,
+ // Unjustified type cast. FIXME
)(RemappedComponent as ComponentType<any>) as unknown as ComponentType<any>;
};
diff --git a/frontend/src/metabase/home/components/Onboarding/Onboarding.tsx b/frontend/src/metabase/home/components/Onboarding/Onboarding.tsx
index a3e5825171e..88d1c9a801a 100644
--- a/frontend/src/metabase/home/components/Onboarding/Onboarding.tsx
+++ b/frontend/src/metabase/home/components/Onboarding/Onboarding.tsx
@@ -225,6 +225,7 @@ export const Onboarding = () => {
label: S.label,
}}
onChange={(value: string | null) =>
+ // Unjustified type cast. FIXME
handleValueChange(value as ChecklistItemValue | null)
}
>
diff --git a/frontend/src/metabase/metabot/components/AIProviderConfigurationForm/AIProviderConfigurationForm.tsx b/frontend/src/metabase/metabot/components/AIProviderConfigurationForm/AIProviderConfigurationForm.tsx
index cffcb2be797..8acbf4c8a2d 100644
--- a/frontend/src/metabase/metabot/components/AIProviderConfigurationForm/AIProviderConfigurationForm.tsx
+++ b/frontend/src/metabase/metabot/components/AIProviderConfigurationForm/AIProviderConfigurationForm.tsx
@@ -238,6 +238,7 @@ export function AIProviderConfigurationForm({
>
{option.label}
</Text>
+ {/* Unjustified type cast. FIXME */}
{!isAvailableProvider(option.value as MetabotProvider) && (
<Text c="text-disabled" lh="1rem" size="sm">
{t`Coming soon`}
diff --git a/frontend/src/metabase/metabot/components/AIQuestionAnalysisButton.unit.spec.tsx b/frontend/src/metabase/metabot/components/AIQuestionAnalysisButton.unit.spec.tsx
index cb846a7f381..5e117019950 100644
--- a/frontend/src/metabase/metabot/components/AIQuestionAnalysisButton.unit.spec.tsx
+++ b/frontend/src/metabase/metabot/components/AIQuestionAnalysisButton.unit.spec.tsx
@@ -44,6 +44,7 @@ function setup({
<AIQuestionAnalysisButton />
</MetabotProvider>,
{
+ // Unjustified type cast. FIXME
storeInitialState: createMockState({
settings,
metabot: metabotState,
diff --git a/frontend/src/metabase/metabot/components/FixSqlQueryButton/FixSqlQueryButton.unit.spec.tsx b/frontend/src/metabase/metabot/components/FixSqlQueryButton/FixSqlQueryButton.unit.spec.tsx
index 4f5bed0e69d..d9a6413dee3 100644
--- a/frontend/src/metabase/metabot/components/FixSqlQueryButton/FixSqlQueryButton.unit.spec.tsx
+++ b/frontend/src/metabase/metabot/components/FixSqlQueryButton/FixSqlQueryButton.unit.spec.tsx
@@ -55,12 +55,14 @@ function setup(options?: {
hasOtherToolsAccess: hasSqlGenerationAccess,
canUseOtherTools: canUseSqlGeneration,
});
+ // Unjustified type cast. FIXME
jest.mocked(useMetabotAgent).mockReturnValue({
submitInput: mockSubmitInput,
isDoingScience,
} as any);
jest
.mocked(setIsNativeEditorOpen)
+ // Unjustified type cast. FIXME
.mockImplementation(mockSetIsNativeEditorOpen as any);
return renderWithProviders(<FixSqlQueryButton />, { withUndos: true });
diff --git a/frontend/src/metabase/metabot/components/MetabotAppBarButton.unit.spec.tsx b/frontend/src/metabase/metabot/components/MetabotAppBarButton.unit.spec.tsx
index 37a61116b5c..7d2680f9263 100644
--- a/frontend/src/metabase/metabot/components/MetabotAppBarButton.unit.spec.tsx
+++ b/frontend/src/metabase/metabot/components/MetabotAppBarButton.unit.spec.tsx
@@ -112,6 +112,7 @@ describe("MetabotAppBarButton", () => {
it("should toggle metabot visibility when clicked", async () => {
const { store } = setup({ isMetabotEnabled: true });
+ // Unjustified type cast. FIXME
const initialState = store.getState() as any;
expect(initialState.metabot.conversations.omnibot.visible).toBe(false);
@@ -119,6 +120,7 @@ describe("MetabotAppBarButton", () => {
await screen.findByRole("button", { name: /Chat with Metabot/ }),
);
+ // Unjustified type cast. FIXME
const newState = store.getState() as any;
expect(newState.metabot.conversations.omnibot.visible).toBe(true);
});
diff --git a/frontend/src/metabase/metabot/components/MetabotChat/MetabotAgentSuggestionMessage.tsx b/frontend/src/metabase/metabot/components/MetabotChat/MetabotAgentSuggestionMessage.tsx
index bec32ba7ad0..2dc1863c8f0 100644
--- a/frontend/src/metabase/metabot/components/MetabotChat/MetabotAgentSuggestionMessage.tsx
+++ b/frontend/src/metabase/metabot/components/MetabotChat/MetabotAgentSuggestionMessage.tsx
@@ -190,6 +190,7 @@ export const AgentSuggestionMessage = ({
return;
}
+ // Unjustified type cast. FIXME
dispatch(push(getTransformUrl(suggestedTransform)) as UnknownAction);
};
diff --git a/frontend/src/metabase/metabot/components/MetabotChat/MetabotChatEditor/MetabotChatEditor.unit.spec.tsx b/frontend/src/metabase/metabot/components/MetabotChat/MetabotChatEditor/MetabotChatEditor.unit.spec.tsx
index 85c64a5c20c..9aa90c4553f 100644
--- a/frontend/src/metabase/metabot/components/MetabotChat/MetabotChatEditor/MetabotChatEditor.unit.spec.tsx
+++ b/frontend/src/metabase/metabot/components/MetabotChat/MetabotChatEditor/MetabotChatEditor.unit.spec.tsx
@@ -30,6 +30,7 @@ const defaultProps = {
onSubmit: jest.fn(),
onStop: jest.fn(),
suggestionConfig: {
+ // Unjustified type cast. FIXME
suggestionModels: [
"table",
"database",
@@ -42,6 +43,7 @@ const defaultProps = {
// "fetch-mock" can accept an array, the types are incorrect
const asFetchMockModelParams = (models: string[]) =>
+ // Unjustified type cast. FIXME
models as unknown as string;
const setup = (
diff --git a/frontend/src/metabase/metabot/components/MetabotChat/MetabotFeedbackModal.tsx b/frontend/src/metabase/metabot/components/MetabotChat/MetabotFeedbackModal.tsx
index 6503ddb7f8e..98e29a43933 100644
--- a/frontend/src/metabase/metabot/components/MetabotChat/MetabotFeedbackModal.tsx
+++ b/frontend/src/metabase/metabot/components/MetabotChat/MetabotFeedbackModal.tsx
@@ -23,6 +23,7 @@ type IssueTypesRequiringFreeform =
const isFreeformRequired = (
value: string,
): value is IssueTypesRequiringFreeform =>
+ // Unjustified type cast. FIXME
ISSUE_TYPES_REQUIRING_FREEFORM.includes(value as IssueTypesRequiringFreeform);
const FEEDBACK_SCHEMA = Yup.object({
diff --git a/frontend/src/metabase/metabot/components/MetabotPromptInput/MetabotPromptInput.unit.spec.tsx b/frontend/src/metabase/metabot/components/MetabotPromptInput/MetabotPromptInput.unit.spec.tsx
index cf78948be6b..9245bc047a5 100644
--- a/frontend/src/metabase/metabot/components/MetabotPromptInput/MetabotPromptInput.unit.spec.tsx
+++ b/frontend/src/metabase/metabot/components/MetabotPromptInput/MetabotPromptInput.unit.spec.tsx
@@ -29,6 +29,7 @@ const defaultProps = {
onChange: jest.fn(),
onStop: jest.fn(),
suggestionConfig: {
+ // Unjustified type cast. FIXME
suggestionModels: ["table", "database"] as SuggestionModel[],
},
};
@@ -90,6 +91,7 @@ describe("MetabotPromptInput", () => {
await userEvent.type(getEditor(), "@");
+ // Unjustified type cast. FIXME
const editor = ref.current as { view: { state: EditorState } } | null;
expect(editor).toBeTruthy();
const mentionState = MetabotMentionPluginKey.getState(editor!.view.state);
diff --git a/frontend/src/metabase/metabot/context.tsx b/frontend/src/metabase/metabot/context.tsx
index 5e6ebb419eb..9891a9f003a 100644
--- a/frontend/src/metabase/metabot/context.tsx
+++ b/frontend/src/metabase/metabot/context.tsx
@@ -166,6 +166,7 @@ export const MetabotProvider = ({
let ctx: MetabotChatContext = {
user_is_viewing: [],
current_time_with_timezone: dayjs.tz(dayjs()).format(),
+ // Unjustified type cast. FIXME
capabilities: _.compact([
"frontend:navigate_user_v1",
hasDataAccess && "permission:save_questions",
diff --git a/frontend/src/metabase/metabot/state/actions.ts b/frontend/src/metabase/metabot/state/actions.ts
index b3b8ead33c4..b4ca31e3f08 100644
--- a/frontend/src/metabase/metabot/state/actions.ts
+++ b/frontend/src/metabase/metabot/state/actions.ts
@@ -169,6 +169,7 @@ export const executeSlashCommand = createAsyncThunk<
dispatch(
setProfileOverride({
agentId,
+ // Unjustified type cast. FIXME
profile: args[0] as MetabotProfileId | undefined,
}),
);
@@ -430,6 +431,7 @@ export const sendAgentRequest = createAsyncThunk<
dispatch(setNavigateToPath(part.data));
if (!isEmbeddingSdk()) {
+ // Unjustified type cast. FIXME
dispatch(push(part.data) as UnknownAction);
}
pushDataPart({ type: "data_part", part });
diff --git a/frontend/src/metabase/metabot/state/reducer.ts b/frontend/src/metabase/metabot/state/reducer.ts
index b743f4a307b..02e363a8010 100644
--- a/frontend/src/metabase/metabot/state/reducer.ts
+++ b/frontend/src/metabase/metabot/state/reducer.ts
@@ -75,6 +75,7 @@ export const metabot = createSlice({
action: ConvoPayloadAction<Omit<MetabotUserChatMessage, "role">>,
) => {
const { id, message, agentId, ...rest } = action.payload;
+ // Unjustified type cast. FIXME
convo.messages.push({ id, role: "user", ...rest, message } as any);
convo.history.push({ id, role: "user", content: message });
},
@@ -88,6 +89,7 @@ export const metabot = createSlice({
) => {
convo.activeToolCalls = [];
const externalId = convo.pendingMessageExternalId;
+ // Unjustified type cast. FIXME
convo.messages.push({
id: createMessageId(),
role: "agent",
@@ -340,6 +342,7 @@ export const metabot = createSlice({
convo.conversationId = conversationId ?? uuid();
convo.isProcessing = false;
+ // Unjustified type cast. FIXME
state.reactions.suggestedTransforms = (suggestedTransforms ?? []) as any;
},
},
diff --git a/frontend/src/metabase/metabot/state/selectors.ts b/frontend/src/metabase/metabot/state/selectors.ts
index 97c3728e727..f5891d8d2df 100644
--- a/frontend/src/metabase/metabot/state/selectors.ts
+++ b/frontend/src/metabase/metabot/state/selectors.ts
@@ -31,6 +31,7 @@ export const getMetabotState = (state: State) => {
export const getActiveMetabotAgentIds = createSelector(
getMetabotState,
+ // Unjustified type cast. FIXME
(state) => Object.keys(state.conversations) as MetabotAgentId[],
);
diff --git a/frontend/src/metabase/metabot/tests/context.unit.spec.tsx b/frontend/src/metabase/metabot/tests/context.unit.spec.tsx
index 93d10032d27..905a08ffc23 100644
--- a/frontend/src/metabase/metabot/tests/context.unit.spec.tsx
+++ b/frontend/src/metabase/metabot/tests/context.unit.spec.tsx
@@ -40,6 +40,7 @@ describe("metabot > context", () => {
);
jest.mocked(setIsNativeEditorOpen).mockImplementation(
(isNativeEditorOpen: boolean) =>
+ // Unjustified type cast. FIXME
({
type: "metabase/qb/SET_IS_NATIVE_EDITOR_OPEN",
isNativeEditorOpen,
@@ -131,10 +132,12 @@ describe("metabot > context", () => {
it("should send SQL profile and SQL error context for SQL fixes", async () => {
const rawSql = "SELECT * FROM bad_table";
const queryError = "bad_table";
+ // Unjustified type cast. FIXME
const editorOpen = { resolve: undefined as (() => void) | undefined };
jest.mocked(setIsNativeEditorOpen).mockImplementationOnce(
() =>
+ // Unjustified type cast. FIXME
(() =>
new Promise<void>((resolve) => {
editorOpen.resolve = resolve;
diff --git a/frontend/src/metabase/metabot/tests/multi-convo.unit.spec.tsx b/frontend/src/metabase/metabot/tests/multi-convo.unit.spec.tsx
index c82a1b1cdce..589389c1eef 100644
--- a/frontend/src/metabase/metabot/tests/multi-convo.unit.spec.tsx
+++ b/frontend/src/metabase/metabot/tests/multi-convo.unit.spec.tsx
@@ -21,6 +21,7 @@ function setup(
{},
);
+ // Unjustified type cast. FIXME
const store = _store as Omit<typeof _store, "getState" | "dispatch"> & {
getState: () => State;
dispatch: ThunkDispatch<State, void, AnyAction>;
diff --git a/frontend/src/metabase/metabot/tests/query-builder-code-edit.unit.spec.tsx b/frontend/src/metabase/metabot/tests/query-builder-code-edit.unit.spec.tsx
index 30ba8b5bbfe..b58f7c09500 100644
--- a/frontend/src/metabase/metabot/tests/query-builder-code-edit.unit.spec.tsx
+++ b/frontend/src/metabase/metabot/tests/query-builder-code-edit.unit.spec.tsx
@@ -98,6 +98,7 @@ describe("query builder code edits from omnibot", () => {
};
});
+ // Unjustified type cast. FIXME
const storeInitialState = createMockState({
currentUser: createMockUser(),
settings: mockSettings({
@@ -121,6 +122,7 @@ describe("query builder code edits from omnibot", () => {
storeInitialState: storeInitialState,
},
);
+ // Unjustified type cast. FIXME
const typedStore = store as Omit<typeof store, "dispatch" | "getState"> & {
dispatch: ThunkDispatch<State, void, AnyAction>;
getState: () => State;
@@ -136,6 +138,7 @@ describe("query builder code edits from omnibot", () => {
sendAgentRequest({
agentId: "omnibot",
message: "Please rewrite this query",
+ // Unjustified type cast. FIXME
conversation_id: conversationId as string,
context: {
user_is_viewing: [
diff --git a/frontend/src/metabase/metabot/tests/ui.unit.spec.tsx b/frontend/src/metabase/metabot/tests/ui.unit.spec.tsx
index 923f7e76521..449e7977bc0 100644
--- a/frontend/src/metabase/metabot/tests/ui.unit.spec.tsx
+++ b/frontend/src/metabase/metabot/tests/ui.unit.spec.tsx
@@ -120,10 +120,12 @@ describe("metabot > ui", () => {
await assertVisible();
act(() => {
+ // Unjustified type cast. FIXME
store.dispatch(logout(undefined) as any);
});
await assertNotVisible();
} finally {
+ // Unjustified type cast. FIXME
(domModule.reload as any).mockRestore();
}
});
diff --git a/frontend/src/metabase/metabot/tests/utils.tsx b/frontend/src/metabase/metabot/tests/utils.tsx
index df8183ace25..d093ec54cde 100644
--- a/frontend/src/metabase/metabot/tests/utils.tsx
+++ b/frontend/src/metabase/metabot/tests/utils.tsx
@@ -135,6 +135,7 @@ export const lastReqBody = async (
// The client calls `fetch(new Request(url, init))`, so the body lives on the
// Request object rather than a separate init arg.
const [request] = agentSpy.mock.lastCall ?? [];
+ // Unjustified type cast. FIXME
return JSON.parse(await (request as Request).clone().text());
};
@@ -255,6 +256,7 @@ export function setup(
return {
rerender,
conversationIds: Object.keys(metabotInitialState.conversations),
+ // Unjustified type cast. FIXME
store: store as Omit<typeof store, "getState"> & {
getState: () => State;
},
diff --git a/frontend/src/metabase/metabot/utils/links.ts b/frontend/src/metabase/metabot/utils/links.ts
index 1ab8fab3bd2..a28ee12ee2c 100644
--- a/frontend/src/metabase/metabot/utils/links.ts
+++ b/frontend/src/metabase/metabot/utils/links.ts
@@ -21,6 +21,7 @@ export type MetabaseProtocolEntityModel =
const isMetabaseProtocolEntityModel = (
model: string,
): model is MetabaseProtocolEntityModel => {
+ // Unjustified type cast. FIXME
return (METABASE_PROTOCOL_ENTITY_MODELS as readonly string[]).includes(model);
};
diff --git a/frontend/src/metabase/metadata/components/FieldSection/BehaviorSection/RemappingPicker/CustomMappingModal/CustomMappingModal.unit.spec.tsx b/frontend/src/metabase/metadata/components/FieldSection/BehaviorSection/RemappingPicker/CustomMappingModal/CustomMappingModal.unit.spec.tsx
index 7be9405ccca..bdc493bafcd 100644
--- a/frontend/src/metabase/metadata/components/FieldSection/BehaviorSection/RemappingPicker/CustomMappingModal/CustomMappingModal.unit.spec.tsx
+++ b/frontend/src/metabase/metadata/components/FieldSection/BehaviorSection/RemappingPicker/CustomMappingModal/CustomMappingModal.unit.spec.tsx
@@ -165,6 +165,7 @@ describe("CustomMappingModal", () => {
it("fills missing mappings with original values as strings", async () => {
const onChange = jest.fn();
setup({
+ // Unjustified type cast. FIXME
value: new Map([
[1, undefined],
[null, undefined],
diff --git a/frontend/src/metabase/metadata/components/SortableFieldList/SortableFieldList.tsx b/frontend/src/metabase/metadata/components/SortableFieldList/SortableFieldList.tsx
index ff50566d68a..06512c13ee1 100644
--- a/frontend/src/metabase/metadata/components/SortableFieldList/SortableFieldList.tsx
+++ b/frontend/src/metabase/metadata/components/SortableFieldList/SortableFieldList.tsx
@@ -33,6 +33,7 @@ export function SortableFieldList<T extends number | string>({
const isDragDisabled = fields.length <= 1;
const handleSortEnd = ({ itemIds }: DragEndEvent) => {
+ // Unjustified type cast. FIXME
onChange(itemIds as T[]);
};
diff --git a/frontend/src/metabase/metadata/components/UserInput.tsx b/frontend/src/metabase/metadata/components/UserInput.tsx
index c4f8db82f62..04e50f761d6 100644
--- a/frontend/src/metabase/metadata/components/UserInput.tsx
+++ b/frontend/src/metabase/metadata/components/UserInput.tsx
@@ -85,6 +85,7 @@ export const UserInput = ({
searchable
searchValue={search}
renderOption={(item) => {
+ // Unjustified type cast. FIXME
const option = item.option as Option;
return (
<Flex align="center" gap="sm" p="sm" w="100%">
@@ -131,6 +132,7 @@ function getData(
},
...users.map((user) => ({
label: user.common_name,
+ // Unjustified type cast. FIXME
value: stringifyValue(user.id) as string,
type: "user" as const,
})),
diff --git a/frontend/src/metabase/metadata/pages/DataModelV1/components/TablePicker/components/TablePicker.unit.spec.tsx b/frontend/src/metabase/metadata/pages/DataModelV1/components/TablePicker/components/TablePicker.unit.spec.tsx
index 8c1deffcc0c..263890ff94b 100644
--- a/frontend/src/metabase/metadata/pages/DataModelV1/components/TablePicker/components/TablePicker.unit.spec.tsx
+++ b/frontend/src/metabase/metadata/pages/DataModelV1/components/TablePicker/components/TablePicker.unit.spec.tsx
@@ -451,6 +451,7 @@ function item(input: string | { display_name?: string; name: string } | null) {
}
const name =
typeof input === "string" ? input : (input.display_name ?? input.name);
+ // Unjustified type cast. FIXME
return (screen.queryByText(name)?.parentNode?.parentNode?.parentNode ??
null) as HTMLAnchorElement | null;
}
diff --git a/frontend/src/metabase/metadata/pages/DataModelV1/components/TablePicker/components/TableVisibilityToggle.unit.spec.tsx b/frontend/src/metabase/metadata/pages/DataModelV1/components/TablePicker/components/TableVisibilityToggle.unit.spec.tsx
index ca24ac1a99e..ce406718307 100644
--- a/frontend/src/metabase/metadata/pages/DataModelV1/components/TablePicker/components/TableVisibilityToggle.unit.spec.tsx
+++ b/frontend/src/metabase/metadata/pages/DataModelV1/components/TablePicker/components/TableVisibilityToggle.unit.spec.tsx
@@ -59,6 +59,7 @@ describe("TableVisibilityToggle", () => {
method: "PUT",
},
)[0];
+ // Unjustified type cast. FIXME
const body = await (call.options?.body as unknown as Promise<string>);
expect(JSON.parse(body)).toEqual({ visibility_type: "hidden" });
@@ -135,6 +136,7 @@ describe("TableVisibilityToggle", () => {
method: "PUT",
},
)[0];
+ // Unjustified type cast. FIXME
const body = await (call.options?.body as unknown as Promise<string>);
expect(JSON.parse(body)).toEqual({ visibility_type: null });
diff --git a/frontend/src/metabase/metadata/pages/DataModelV1/components/TablePicker/utils.ts b/frontend/src/metabase/metadata/pages/DataModelV1/components/TablePicker/utils.ts
index c97ce73ea4f..fbd752151be 100644
--- a/frontend/src/metabase/metadata/pages/DataModelV1/components/TablePicker/utils.ts
+++ b/frontend/src/metabase/metadata/pages/DataModelV1/components/TablePicker/utils.ts
@@ -193,6 +193,7 @@ type Optional<T, K extends keyof T> = Omit<T, K> & Partial<Pick<T, K>>;
export function node<T extends TreeNode>(
x: Optional<T, "key" | "children">,
): T {
+ // Unjustified type cast. FIXME
return {
...x,
key: toKey(x.value),
diff --git a/frontend/src/metabase/metrics-viewer/components/FilterPopover/types.ts b/frontend/src/metabase/metrics-viewer/components/FilterPopover/types.ts
index 0876f9e4997..2d0031c48ab 100644
--- a/frontend/src/metabase/metrics-viewer/components/FilterPopover/types.ts
+++ b/frontend/src/metabase/metrics-viewer/components/FilterPopover/types.ts
@@ -34,4 +34,5 @@ export type MetricGroup = {
};
export const isSegmentListItem = (item: FilterItem): item is SegmentListItem =>
+ // Unjustified type cast. FIXME
(item as SegmentListItem).segment != null;
diff --git a/frontend/src/metabase/metrics-viewer/components/FilterPopover/utils.unit.spec.ts b/frontend/src/metabase/metrics-viewer/components/FilterPopover/utils.unit.spec.ts
index 79a04bcd204..b79e6b7f1ba 100644
--- a/frontend/src/metabase/metrics-viewer/components/FilterPopover/utils.unit.spec.ts
+++ b/frontend/src/metabase/metrics-viewer/components/FilterPopover/utils.unit.spec.ts
@@ -21,6 +21,7 @@ jest.mock("metabase/metrics-viewer/utils/definition-sources", () => ({
getDefinitionSourceName: jest.fn(() => "Revenue"),
}));
+// Unjustified type cast. FIXME
const mockLibMetric = LibMetricModule as jest.Mocked<typeof LibMetric>;
type TestItem = { name: string };
@@ -46,10 +47,13 @@ function makeDefinitionSource(
): DefinitionSource {
return {
index,
+ // Unjustified type cast. FIXME
id: `src-${index}` as DefinitionSource["id"],
+ // Unjustified type cast. FIXME
definition: {
__fakeDefinition: index,
} as unknown as LibMetric.MetricDefinition,
+ // Unjustified type cast. FIXME
entity: {} as DefinitionSource["entity"],
entityIndex: index,
token: undefined,
@@ -61,6 +65,7 @@ function getSourceTableDimensionInfo(
displayName: string,
id = "main",
): DimensionDisplayInfo {
+ // Unjustified type cast. FIXME
return {
displayName,
group: { id, displayName: "Orders", type: "main" },
@@ -71,6 +76,7 @@ function getJoinedTabledDimensionInfo(
displayName: string,
id = "conn",
): DimensionDisplayInfo {
+ // Unjustified type cast. FIXME
return {
displayName,
group: { id, displayName: "Products", type: "connection" },
@@ -189,9 +195,11 @@ describe("filterDisplayGroupsBySearch", () => {
describe("getMetricGroups", () => {
it("places segments above dimensions in the single source-table section", () => {
const source = makeDefinitionSource(0);
+ // Unjustified type cast. FIXME
const dim = {
__dim: "createdAt",
} as unknown as LibMetric.DimensionMetadata;
+ // Unjustified type cast. FIXME
const seg = {
__seg: "active",
} as unknown as LibMetric.SegmentMetadata;
@@ -233,6 +241,7 @@ describe("getMetricGroups", () => {
it("synthesizes a source-table section when there are segments but no filterable dimensions", () => {
const source = makeDefinitionSource(0);
+ // Unjustified type cast. FIXME
const seg = { __seg: "big" } as unknown as LibMetric.SegmentMetadata;
mockLibMetric.filterableDimensions.mockReturnValue([]);
@@ -250,12 +259,15 @@ describe("getMetricGroups", () => {
it("only attaches segments to the main section when joined groups exist", () => {
const source = makeDefinitionSource(0);
+ // Unjustified type cast. FIXME
const mainDimMeta = {
__dim: "createdAt",
} as unknown as LibMetric.DimensionMetadata;
+ // Unjustified type cast. FIXME
const connDimMeta = {
__dim: "productCategory",
} as unknown as LibMetric.DimensionMetadata;
+ // Unjustified type cast. FIXME
const seg = {
__seg: "active",
} as unknown as LibMetric.SegmentMetadata;
@@ -296,6 +308,7 @@ describe("getMetricGroups", () => {
// Segments MUST NOT leak into the joined-table section.
expect(
connSection?.items?.some(
+ // Unjustified type cast. FIXME
(item) => (item as { segment?: unknown }).segment != null,
),
).toBe(false);
@@ -303,12 +316,15 @@ describe("getMetricGroups", () => {
it("falls back to a synthesized source-table section if no group reports as main", () => {
const source = makeDefinitionSource(0);
+ // Unjustified type cast. FIXME
const connDimMeta = {
__dim: "productCategory",
} as unknown as LibMetric.DimensionMetadata;
+ // Unjustified type cast. FIXME
const otherDimMeta = {
__dim: "other",
} as unknown as LibMetric.DimensionMetadata;
+ // Unjustified type cast. FIXME
const seg = { __seg: "x" } as unknown as LibMetric.SegmentMetadata;
mockLibMetric.filterableDimensions.mockReturnValue([
@@ -346,11 +362,14 @@ describe("getMetricGroups", () => {
it("scopes segments per definition source index", () => {
const source0 = makeDefinitionSource(0);
const source1 = makeDefinitionSource(1);
+ // Unjustified type cast. FIXME
const segA = { __seg: "a" } as unknown as LibMetric.SegmentMetadata;
+ // Unjustified type cast. FIXME
const segB = { __seg: "b" } as unknown as LibMetric.SegmentMetadata;
mockLibMetric.filterableDimensions.mockReturnValue([]);
mockLibMetric.availableSegments.mockImplementation((def: unknown) => {
+ // Unjustified type cast. FIXME
if ((def as { __fakeDefinition: number }).__fakeDefinition === 0) {
return [segA];
}
diff --git a/frontend/src/metabase/metrics-viewer/components/MetricSearch/MetricSearchDropdown/MetricSearchDropdown.tsx b/frontend/src/metabase/metrics-viewer/components/MetricSearch/MetricSearchDropdown/MetricSearchDropdown.tsx
index 2654ea35c70..33adf87c7c4 100644
--- a/frontend/src/metabase/metrics-viewer/components/MetricSearch/MetricSearchDropdown/MetricSearchDropdown.tsx
+++ b/frontend/src/metabase/metrics-viewer/components/MetricSearch/MetricSearchDropdown/MetricSearchDropdown.tsx
@@ -93,6 +93,7 @@ export const MetricSearchDropdown = forwardRef<
const firstElement =
miniPickerRef.current?.querySelector('[role="menuitem"]');
if (firstElement) {
+ // Unjustified type cast. FIXME
(firstElement as HTMLElement).focus();
}
return true;
@@ -102,6 +103,7 @@ export const MetricSearchDropdown = forwardRef<
miniPickerRef.current?.querySelectorAll('[role="menuitem"]') ?? [];
const lastElement = elements[elements.length - 1];
if (lastElement) {
+ // Unjustified type cast. FIXME
(lastElement as HTMLElement).focus();
}
return true;
diff --git a/frontend/src/metabase/metrics-viewer/components/MetricSearch/MetricSearchDropdown/MetricSearchDropdown.unit.spec.tsx b/frontend/src/metabase/metrics-viewer/components/MetricSearch/MetricSearchDropdown/MetricSearchDropdown.unit.spec.tsx
index 1e4f106a1db..9bee926abfe 100644
--- a/frontend/src/metabase/metrics-viewer/components/MetricSearch/MetricSearchDropdown/MetricSearchDropdown.unit.spec.tsx
+++ b/frontend/src/metabase/metrics-viewer/components/MetricSearch/MetricSearchDropdown/MetricSearchDropdown.unit.spec.tsx
@@ -92,6 +92,7 @@ describe("MetricSearchDropdown", () => {
});
const searchCall = fetchMock.callHistory.lastCall("path:/api/search");
+ // Unjustified type cast. FIXME
const searchUrl = new URL(searchCall?.url as string);
expect(searchUrl.searchParams.get("q")).toBe("");
diff --git a/frontend/src/metabase/metrics-viewer/components/MetricSearch/MetricSearchInput/MetricSearchInput.unit.spec.tsx b/frontend/src/metabase/metrics-viewer/components/MetricSearch/MetricSearchInput/MetricSearchInput.unit.spec.tsx
index a4fc3e73e5a..36b2d4366fa 100644
--- a/frontend/src/metabase/metrics-viewer/components/MetricSearch/MetricSearchInput/MetricSearchInput.unit.spec.tsx
+++ b/frontend/src/metabase/metrics-viewer/components/MetricSearch/MetricSearchInput/MetricSearchInput.unit.spec.tsx
@@ -44,7 +44,8 @@ function makeMetricEntry(metric: SelectedMetric): MetricDefinitionEntry {
const sid =
metric.sourceType === "metric"
? createMetricSourceId(metric.id)
- : (`measure:${metric.id}` as MetricSourceId);
+ : // Unjustified type cast. FIXME
+ (`measure:${metric.id}` as MetricSourceId);
if (metric.sourceType === "measure") {
return { id: sid, type: "metric" as const, definition: null };
}
@@ -543,6 +544,7 @@ describe("expression pill display after committing a formula", () => {
expect(onFormulaEntitiesChange).toHaveBeenCalled();
});
+ // Unjustified type cast. FIXME
const committedEntities = onFormulaEntitiesChange.mock.calls[
onFormulaEntitiesChange.mock.calls.length - 1
][0] as MetricsViewerFormulaEntity[];
diff --git a/frontend/src/metabase/metrics-viewer/components/MetricSearch/utils.unit.spec.ts b/frontend/src/metabase/metrics-viewer/components/MetricSearch/utils.unit.spec.ts
index 9482ef9a927..ecded3122f2 100644
--- a/frontend/src/metabase/metrics-viewer/components/MetricSearch/utils.unit.spec.ts
+++ b/frontend/src/metabase/metrics-viewer/components/MetricSearch/utils.unit.spec.ts
@@ -1295,6 +1295,7 @@ describe("applyTrackedDefinitions", () => {
metricNames,
);
expect(entities).toHaveLength(1);
+ // Unjustified type cast. FIXME
expect((entities[0] as MetricDefinitionEntry).definition).toBe(
revenueBreakoutDef,
);
@@ -1310,6 +1311,7 @@ describe("applyTrackedDefinitions", () => {
text,
metricNames,
);
+ // Unjustified type cast. FIXME
expect((entities[0] as MetricDefinitionEntry).definition).toBeNull();
});
@@ -1333,9 +1335,11 @@ describe("applyTrackedDefinitions", () => {
text,
metricNames,
);
+ // Unjustified type cast. FIXME
expect((entities[0] as MetricDefinitionEntry).definition).toBe(
revenueBreakoutDef,
);
+ // Unjustified type cast. FIXME
expect((entities[1] as MetricDefinitionEntry).definition).toBe(
geoBreakoutDef,
);
@@ -1387,7 +1391,9 @@ describe("applyTrackedDefinitions", () => {
text,
metricNames,
);
+ // Unjustified type cast. FIXME
const resultExpr = entities[0] as ExpressionDefinitionEntry;
+ // Unjustified type cast. FIXME
const parsedExpr = parsed[0] as ExpressionDefinitionEntry;
expect(resultExpr.tokens[1]).toBe(parsedExpr.tokens[1]);
expect(resultExpr.tokens[2]).toBe(parsedExpr.tokens[2]);
@@ -1404,6 +1410,7 @@ describe("applyTrackedDefinitions", () => {
text,
metricNames,
);
+ // Unjustified type cast. FIXME
expect((entities[0] as MetricDefinitionEntry).definition).toBe(
revenueBreakoutDef,
);
@@ -1423,6 +1430,7 @@ describe("applyTrackedDefinitions", () => {
text,
metricNames,
);
+ // Unjustified type cast. FIXME
expect((entities[0] as MetricDefinitionEntry).definition).not.toBe(
revenueDef,
);
@@ -1477,9 +1485,11 @@ describe("applyTrackedDefinitions", () => {
text,
metricNames,
);
+ // Unjustified type cast. FIXME
expect((entities[0] as MetricDefinitionEntry).definition).toBe(
revenueBreakoutDef,
);
+ // Unjustified type cast. FIXME
expect((entities[1] as MetricDefinitionEntry).definition).toBe(revenueDef);
});
@@ -1507,6 +1517,7 @@ describe("applyTrackedDefinitions", () => {
text,
metricNames,
);
+ // Unjustified type cast. FIXME
const expr = entities[0] as ExpressionDefinitionEntry;
expect(isExpressionEntry(expr)).toBe(true);
expect(expr.name).toBe("My sum");
@@ -1524,6 +1535,7 @@ describe("applyTrackedDefinitions", () => {
text,
metricNames,
);
+ // Unjustified type cast. FIXME
expect((entities[0] as ExpressionDefinitionEntry).name).toBe("My sum");
});
@@ -1532,6 +1544,7 @@ describe("applyTrackedDefinitions", () => {
const text = "Revenue+Geo Revenue";
const parsed = parseFullText(text, metricNames, []);
const { entities } = applyTrackedDefinitions(parsed, [], text, metricNames);
+ // Unjustified type cast. FIXME
const expr = entities[0] as ExpressionDefinitionEntry;
// Default name is the auto-derived expression text.
expect(expr.name).toBe(buildExpressionText(expr.tokens, metricNames));
@@ -1579,6 +1592,7 @@ describe("applyTrackedDefinitions", () => {
metricNames,
);
expect(entities).toHaveLength(3);
+ // Unjustified type cast. FIXME
const [first, middle, last] = entities as ExpressionDefinitionEntry[];
expect(isExpressionEntry(first)).toBe(true);
expect(isExpressionEntry(middle)).toBe(true);
@@ -1602,8 +1616,11 @@ describe("buildFullTextWithIdentities", () => {
"metric:3": "123",
};
+ // Unjustified type cast. FIXME
const revenueDef = { "display-name": "Revenue" } as any;
+ // Unjustified type cast. FIXME
const costsDef = { "display-name": "Costs" } as any;
+ // Unjustified type cast. FIXME
const numericDef = { "display-name": "123" } as any;
it("produces text and identity ranges for standalone metrics", () => {
diff --git a/frontend/src/metabase/metrics-viewer/components/MetricsFilterPills/MetricsFilterPills.unit.spec.tsx b/frontend/src/metabase/metrics-viewer/components/MetricsFilterPills/MetricsFilterPills.unit.spec.tsx
index 9dcea5672cb..f4ad2803679 100644
--- a/frontend/src/metabase/metrics-viewer/components/MetricsFilterPills/MetricsFilterPills.unit.spec.tsx
+++ b/frontend/src/metabase/metrics-viewer/components/MetricsFilterPills/MetricsFilterPills.unit.spec.tsx
@@ -71,6 +71,7 @@ jest.mock("./MetricsSegmentFilterPillPopover", () => ({
),
}));
+// Unjustified type cast. FIXME
const mockLibMetric = LibMetricModule as jest.Mocked<typeof LibMetric>;
function makeDefinitionSource(
@@ -79,8 +80,11 @@ function makeDefinitionSource(
): DefinitionSource {
return {
index,
+ // Unjustified type cast. FIXME
id: `src-${index}` as DefinitionSource["id"],
+ // Unjustified type cast. FIXME
definition: { __fakeDef: index } as unknown as LibMetric.MetricDefinition,
+ // Unjustified type cast. FIXME
entity: {
type: "metric",
id: index,
@@ -98,9 +102,11 @@ beforeEach(() => {
describe("MetricsFilterPills", () => {
it("renders a segment-iconed pill for a segment filter with its display name", () => {
const source = makeDefinitionSource(0);
+ // Unjustified type cast. FIXME
const segmentClause = {
__clause: "segment",
} as unknown as LibMetric.FilterClause;
+ // Unjustified type cast. FIXME
const segmentMetadata = {
__seg: "active",
} as unknown as LibMetric.SegmentMetadata;
@@ -131,12 +137,15 @@ describe("MetricsFilterPills", () => {
it("calls removeClause when segment pill remove is invoked", async () => {
const source = makeDefinitionSource(0);
+ // Unjustified type cast. FIXME
const segmentClause = {
__clause: "segment",
} as unknown as LibMetric.FilterClause;
+ // Unjustified type cast. FIXME
const segmentMetadata = {
__seg: "active",
} as unknown as LibMetric.SegmentMetadata;
+ // Unjustified type cast. FIXME
const newDefinition = {
__fakeDef: "after-remove",
} as unknown as LibMetric.MetricDefinition;
@@ -169,6 +178,7 @@ describe("MetricsFilterPills", () => {
it("uses the popover pill for regular (non-segment) filter clauses", () => {
const source = makeDefinitionSource(0);
+ // Unjustified type cast. FIXME
const normalClause = {
__clause: "normal",
} as unknown as LibMetric.FilterClause;
diff --git a/frontend/src/metabase/metrics-viewer/components/MetricsFilterPills/MetricsSegmentFilterPillPopover.unit.spec.tsx b/frontend/src/metabase/metrics-viewer/components/MetricsFilterPills/MetricsSegmentFilterPillPopover.unit.spec.tsx
index 4535dcead90..db485959c0e 100644
--- a/frontend/src/metabase/metrics-viewer/components/MetricsFilterPills/MetricsSegmentFilterPillPopover.unit.spec.tsx
+++ b/frontend/src/metabase/metrics-viewer/components/MetricsFilterPills/MetricsSegmentFilterPillPopover.unit.spec.tsx
@@ -49,10 +49,13 @@ jest.mock("../FilterPopover/FilterPopoverContent", () => ({
),
}));
+// Unjustified type cast. FIXME
const mockLibMetric = LibMetricModule as jest.Mocked<typeof LibMetric>;
+// Unjustified type cast. FIXME
const mockTrackEdited = trackMetricsViewerFilterEdited as jest.MockedFunction<
typeof trackMetricsViewerFilterEdited
>;
+// Unjustified type cast. FIXME
const mockTrackRemoved = trackMetricsViewerFilterRemoved as jest.MockedFunction<
typeof trackMetricsViewerFilterRemoved
>;
@@ -60,14 +63,18 @@ const mockTrackRemoved = trackMetricsViewerFilterRemoved as jest.MockedFunction<
function makeDefinitionSource(): DefinitionSource {
return {
index: 0,
+ // Unjustified type cast. FIXME
id: "src-0" as DefinitionSource["id"],
+ // Unjustified type cast. FIXME
definition: { __fakeDef: 0 } as unknown as LibMetric.MetricDefinition,
+ // Unjustified type cast. FIXME
entity: {} as DefinitionSource["entity"],
entityIndex: 0,
token: undefined,
};
}
+// Unjustified type cast. FIXME
const oldFilter = {
__clause: "old-segment",
} as unknown as LibMetric.FilterClause;
@@ -122,6 +129,7 @@ describe("MetricsSegmentFilterPillPopover", () => {
it("removes the original segment from the picked definition before propagating up", async () => {
const source = makeDefinitionSource();
+ // Unjustified type cast. FIXME
const replaced = {
__after: "old-segment-removed",
} as unknown as LibMetric.MetricDefinition;
diff --git a/frontend/src/metabase/metrics-viewer/hooks/use-viewer-state.ts b/frontend/src/metabase/metrics-viewer/hooks/use-viewer-state.ts
index 70c861c22f0..23cf99dd2f0 100644
--- a/frontend/src/metabase/metrics-viewer/hooks/use-viewer-state.ts
+++ b/frontend/src/metabase/metrics-viewer/hooks/use-viewer-state.ts
@@ -357,6 +357,7 @@ export function useViewerState({
MetricDefinition | null
> = {};
for (const [id, entry] of Object.entries(prev.definitions)) {
+ // Unjustified type cast. FIXME
definitionsBySourceId[id as MetricSourceId] =
entry.definition ?? null;
}
diff --git a/frontend/src/metabase/metrics-viewer/utils/definition-builder.ts b/frontend/src/metabase/metrics-viewer/utils/definition-builder.ts
index ee47522ca89..864c175c71f 100644
--- a/frontend/src/metabase/metrics-viewer/utils/definition-builder.ts
+++ b/frontend/src/metabase/metrics-viewer/utils/definition-builder.ts
@@ -292,6 +292,7 @@ export function getDefinitionColumnName(def: MetricDefinition): string | null {
if (!meta) {
return null;
}
+ // Unjustified type cast. FIXME
const info = LibMetric.displayInfo(def, meta) as
| MetricDisplayInfo
| MeasureDisplayInfo;
diff --git a/frontend/src/metabase/metrics-viewer/utils/dimension-breakout-config.unit.spec.ts b/frontend/src/metabase/metrics-viewer/utils/dimension-breakout-config.unit.spec.ts
index 9060590bd2d..1d3478061df 100644
--- a/frontend/src/metabase/metrics-viewer/utils/dimension-breakout-config.unit.spec.ts
+++ b/frontend/src/metabase/metrics-viewer/utils/dimension-breakout-config.unit.spec.ts
@@ -84,6 +84,7 @@ const latitudeCol = createMockColumn({
// ── Shared helpers ──
const METRIC_ENTITY: MetricsViewerFormulaEntity = {
+ // Unjustified type cast. FIXME
id: "metric:1" as MetricSourceId,
type: "metric",
definition: null,
@@ -190,6 +191,7 @@ describe("getDimensionBreakoutConfig", () => {
});
it("throws for unknown dimensionBreakout type", () => {
+ // Unjustified type cast. FIXME
expect(() => getDimensionBreakoutConfig("unknown" as any)).toThrow(
"No dimension breakout config found for type: unknown",
);
@@ -475,6 +477,7 @@ describe("DISPLAY_TYPE_REGISTRY", () => {
it("sets scalar.label to entity name for expression entries", () => {
const expressionEntity: MetricsViewerFormulaEntity = {
+ // Unjustified type cast. FIXME
id: "expr:1" as any,
type: "expression",
name: "Revenue Growth",
diff --git a/frontend/src/metabase/metrics-viewer/utils/parse-expression.ts b/frontend/src/metabase/metrics-viewer/utils/parse-expression.ts
index b7c5cba041d..3c7d483d3e8 100644
--- a/frontend/src/metabase/metrics-viewer/utils/parse-expression.ts
+++ b/frontend/src/metabase/metrics-viewer/utils/parse-expression.ts
@@ -62,6 +62,7 @@ function parseFactor(ctx: ParseCtx): ExpressionRef | number | null {
}
while (isOperatorAtPrecedence(ctx, 2)) {
+ // Unjustified type cast. FIXME
const op = (ctx.tokens[ctx.pos] as { type: "operator"; op: MathOperator })
.op;
ctx.pos++;
@@ -82,6 +83,7 @@ function parseExpressionWithContext(ctx: ParseCtx): ExpressionRef | null {
}
while (isOperatorAtPrecedence(ctx, 1)) {
+ // Unjustified type cast. FIXME
const op = (ctx.tokens[ctx.pos] as { type: "operator"; op: MathOperator })
.op;
ctx.pos++;
diff --git a/frontend/src/metabase/metrics-viewer/utils/series.ts b/frontend/src/metabase/metrics-viewer/utils/series.ts
index 5a535801f1b..c7331802de6 100644
--- a/frontend/src/metabase/metrics-viewer/utils/series.ts
+++ b/frontend/src/metabase/metrics-viewer/utils/series.ts
@@ -439,6 +439,7 @@ export function splitByBreakout({
};
}
}
+ // Unjustified type cast. FIXME
groupedRows.push([
row[DIMENSION_COLUMN_INDEX],
row[metricColumnIndex],
@@ -494,6 +495,7 @@ function createSeriesCard(
display: string,
vizSettings: VisualizationSettings,
): Card {
+ // Unjustified type cast. FIXME
return {
id,
name,
diff --git a/frontend/src/metabase/metrics-viewer/utils/series.unit.spec.ts b/frontend/src/metabase/metrics-viewer/utils/series.unit.spec.ts
index e679a8fb955..2a9262f583f 100644
--- a/frontend/src/metabase/metrics-viewer/utils/series.unit.spec.ts
+++ b/frontend/src/metabase/metrics-viewer/utils/series.unit.spec.ts
@@ -64,6 +64,7 @@ function makeColorMap(values: string[]): BreakoutColorMap {
}
const METRIC_ENTITY: MetricsViewerFormulaEntity = {
+ // Unjustified type cast. FIXME
id: "metric:1" as MetricSourceId,
type: "metric",
definition: null,
@@ -354,6 +355,7 @@ describe("computeSourceBreakoutColors", () => {
);
expect(result[0]).toBeInstanceOf(Map);
+ // Unjustified type cast. FIXME
const colorMap = result[0] as Map<string, string>;
expect(colorMap.size).toBe(2);
expect(colorMap.has("Gadgets")).toBe(true);
@@ -649,6 +651,7 @@ describe("buildDimensionItemsFromDefinitions", () => {
);
expect(items).toHaveLength(1);
+ // Unjustified type cast. FIXME
const expressionItem = items[0] as ExpressionDimensionItem;
expect(expressionItem.type).toBe("expression");
expect(expressionItem.label).toBe("Created At");
@@ -670,6 +673,7 @@ describe("buildDimensionItemsFromDefinitions", () => {
);
expect(items).toHaveLength(1);
+ // Unjustified type cast. FIXME
const expressionItem = items[0] as ExpressionDimensionItem;
expect(expressionItem.type).toBe("expression");
expect(expressionItem.label).toBe("Multiple dimensions");
@@ -683,6 +687,7 @@ describe("shouldShowStackSeries", () => {
const metricMeta = createMetricMetadata([REVENUE_METRIC]);
const metricEntity: MetricsViewerFormulaEntity = {
+ // Unjustified type cast. FIXME
id: "metric:1" as MetricSourceId,
type: "metric",
definition: null,
@@ -699,7 +704,9 @@ describe("shouldShowStackSeries", () => {
? setupDefinitionWithBreakout(metricMeta, REVENUE_METRIC.id, 0)
: setupDefinition(metricMeta, REVENUE_METRIC.id);
return {
+ // Unjustified type cast. FIXME
["metric:1" as MetricSourceId]: {
+ // Unjustified type cast. FIXME
id: "metric:1" as MetricSourceId,
definition,
},
diff --git a/frontend/src/metabase/metrics-viewer/utils/url-serialization.ts b/frontend/src/metabase/metrics-viewer/utils/url-serialization.ts
index 428e5a42d68..1e90c6d5a46 100644
--- a/frontend/src/metabase/metrics-viewer/utils/url-serialization.ts
+++ b/frontend/src/metabase/metrics-viewer/utils/url-serialization.ts
@@ -160,6 +160,7 @@ function deserializeSubToken(
const hasInfo = token.filters || token.segments;
return {
type: "metric",
+ // Unjustified type cast. FIXME
sourceId: token.sourceId as MetricSourceId,
occurrenceCount: 0,
serializedDefinitionInfo: hasInfo
@@ -213,6 +214,7 @@ export function deserializeFormulaEntities(
}
if (entity.type === "expression") {
entities.push({
+ // Unjustified type cast. FIXME
id: entity.id as MetricExpressionId,
type: "expression" as const,
name: entity.name,
diff --git a/frontend/src/metabase/metrics-viewer/utils/url-serialization.unit.spec.ts b/frontend/src/metabase/metrics-viewer/utils/url-serialization.unit.spec.ts
index 829744818da..32352d4ff10 100644
--- a/frontend/src/metabase/metrics-viewer/utils/url-serialization.unit.spec.ts
+++ b/frontend/src/metabase/metrics-viewer/utils/url-serialization.unit.spec.ts
@@ -1052,6 +1052,7 @@ describe("url-serialization", () => {
type: "expression",
id: "expression:test",
name: "test",
+ // Unjustified type cast. FIXME
tokens: [{ type: "metric" } as any],
},
],
@@ -1069,6 +1070,7 @@ describe("url-serialization", () => {
type: "expression",
id: "expression:test",
name: "test",
+ // Unjustified type cast. FIXME
tokens: [{ type: "operator" } as any],
},
],
@@ -1188,6 +1190,7 @@ describe("url-serialization", () => {
{
type: "metric",
id: 5,
+ // Unjustified type cast. FIXME
filters: filters as any,
},
],
@@ -1228,6 +1231,7 @@ describe("url-serialization", () => {
{
type: "metric",
sourceId: "metric:1",
+ // Unjustified type cast. FIXME
filters: tokenFilters as any,
},
],
diff --git a/frontend/src/metabase/metrics/components/MetricDimensionGrid/MetricDimensionGrid.tsx b/frontend/src/metabase/metrics/components/MetricDimensionGrid/MetricDimensionGrid.tsx
index 1a1646fce5c..3cb690aae63 100644
--- a/frontend/src/metabase/metrics/components/MetricDimensionGrid/MetricDimensionGrid.tsx
+++ b/frontend/src/metabase/metrics/components/MetricDimensionGrid/MetricDimensionGrid.tsx
@@ -159,6 +159,7 @@ function buildSingleSeries(
return [
{
+ // Unjustified type cast. FIXME
card: {
display: displayType,
visualization_settings: {
diff --git a/frontend/src/metabase/models/containers/ModelActions/ModelActions.unit.spec.tsx b/frontend/src/metabase/models/containers/ModelActions/ModelActions.unit.spec.tsx
index ef0c7d44703..81d80703953 100644
--- a/frontend/src/metabase/models/containers/ModelActions/ModelActions.unit.spec.tsx
+++ b/frontend/src/metabase/models/containers/ModelActions/ModelActions.unit.spec.tsx
@@ -712,6 +712,7 @@ describe("ModelActions", () => {
const { model } = await setup({
model: createStructuredModelCard({ archived: true }),
});
+ // Unjustified type cast. FIXME
const modelName = model.displayName() as string;
expect(screen.queryByText(modelName)).not.toBeInTheDocument();
diff --git a/frontend/src/metabase/models/containers/NewModelOptions/NewModelOptions.tsx b/frontend/src/metabase/models/containers/NewModelOptions/NewModelOptions.tsx
index 39b8f2c03ba..10579a62b93 100644
--- a/frontend/src/metabase/models/containers/NewModelOptions/NewModelOptions.tsx
+++ b/frontend/src/metabase/models/containers/NewModelOptions/NewModelOptions.tsx
@@ -33,6 +33,7 @@ const NewModelOptions = ({ location }: NewModelOptionsProps) => {
);
const collectionId = Urls.extractEntityId(
+ // Unjustified type cast. FIXME
location.query.collectionId as string,
);
diff --git a/frontend/src/metabase/monitor/tools/components/Logs/hooks.ts b/frontend/src/metabase/monitor/tools/components/Logs/hooks.ts
index 08c1e8b2863..8723452bcdc 100644
--- a/frontend/src/metabase/monitor/tools/components/Logs/hooks.ts
+++ b/frontend/src/metabase/monitor/tools/components/Logs/hooks.ts
@@ -24,6 +24,7 @@ export function usePollingLogsQuery(pollingDurationMs: number) {
if (!queryError) {
return null;
}
+ // Unjustified type cast. FIXME
const errorWithData = queryError as {
data?: { message?: string };
message?: string;
diff --git a/frontend/src/metabase/monitor/tools/components/TaskDetailsPage/TaskDetailsPage.unit.spec.tsx b/frontend/src/metabase/monitor/tools/components/TaskDetailsPage/TaskDetailsPage.unit.spec.tsx
index 9d94f75aef2..4e7918a6558 100644
--- a/frontend/src/metabase/monitor/tools/components/TaskDetailsPage/TaskDetailsPage.unit.spec.tsx
+++ b/frontend/src/metabase/monitor/tools/components/TaskDetailsPage/TaskDetailsPage.unit.spec.tsx
@@ -24,6 +24,7 @@ jest.mock("@mantine/hooks", () => ({
useClipboard: jest.fn(),
}));
+// Unjustified type cast. FIXME
const mockUseClipboard = useClipboard as jest.Mock;
const PATHNAME = `${Urls.adminToolsTasksList()}/:taskId`;
diff --git a/frontend/src/metabase/monitor/tools/components/TaskRunDetailsPage/TaskRunDetailsPage.unit.spec.tsx b/frontend/src/metabase/monitor/tools/components/TaskRunDetailsPage/TaskRunDetailsPage.unit.spec.tsx
index 0382c771516..4bbb272a768 100644
--- a/frontend/src/metabase/monitor/tools/components/TaskRunDetailsPage/TaskRunDetailsPage.unit.spec.tsx
+++ b/frontend/src/metabase/monitor/tools/components/TaskRunDetailsPage/TaskRunDetailsPage.unit.spec.tsx
@@ -20,6 +20,7 @@ jest.mock("@mantine/hooks", () => ({
useClipboard: jest.fn(),
}));
+// Unjustified type cast. FIXME
const mockUseClipboard = useClipboard as jest.Mock;
const PATHNAME = `${Urls.adminToolsTasksRuns()}/:runId`;
diff --git a/frontend/src/metabase/monitor/tools/notifications/NotificationsAdminPage/utils.ts b/frontend/src/metabase/monitor/tools/notifications/NotificationsAdminPage/utils.ts
index d27f68da538..16a64b55a41 100644
--- a/frontend/src/metabase/monitor/tools/notifications/NotificationsAdminPage/utils.ts
+++ b/frontend/src/metabase/monitor/tools/notifications/NotificationsAdminPage/utils.ts
@@ -83,6 +83,7 @@ const parseGuardedEnum = <T extends string, D extends T | null>(
const guardChannel = (value: string): value is NotificationChannelType =>
(CHANNEL_VALUES satisfies NotificationChannelType[]).includes(
+ // Unjustified type cast. FIXME
value as NotificationChannelType,
);
@@ -91,6 +92,7 @@ const parseChannels = (param: QueryParam): NotificationChannelType[] =>
const guardLastSendStatus = (value: string): value is NotificationRunStatus =>
(LAST_SEND_STATUS_VALUES satisfies NotificationRunStatus[]).includes(
+ // Unjustified type cast. FIXME
value as NotificationRunStatus,
);
@@ -111,6 +113,7 @@ const parseCreatorActive = (param: QueryParam): boolean | null => {
};
const guardTab = (value: string): value is NotificationsTab =>
+ // Unjustified type cast. FIXME
(TAB_VALUES satisfies NotificationsTab[]).includes(value as NotificationsTab);
const parseTabEnum = (param: QueryParam): NotificationsTab =>
@@ -118,6 +121,7 @@ const parseTabEnum = (param: QueryParam): NotificationsTab =>
const guardSortColumn = (value: string): value is AdminNotificationSortColumn =>
(SORT_COLUMN_VALUES satisfies AdminNotificationSortColumn[]).includes(
+ // Unjustified type cast. FIXME
value as AdminNotificationSortColumn,
);
diff --git a/frontend/src/metabase/monitor/tools/utils.ts b/frontend/src/metabase/monitor/tools/utils.ts
index f3ab5bee868..cbc26180848 100644
--- a/frontend/src/metabase/monitor/tools/utils.ts
+++ b/frontend/src/metabase/monitor/tools/utils.ts
@@ -91,21 +91,22 @@ export const renderTaskRunCounters = ({
};
export const guardTaskRunRunType = (value: string): value is TaskRunType =>
- (
- ["subscription", "alert", "sync", "fingerprint"] satisfies TaskRunType[]
- ).includes(value as TaskRunType);
+ (["subscription", "alert", "sync", "fingerprint"] satisfies TaskRunType[])
+ // Unjustified type cast. FIXME
+ .includes(value as TaskRunType);
export const guardTaskRunEntityType = (
value: string,
): value is TaskRunEntityType =>
(["database", "card", "dashboard"] satisfies TaskRunEntityType[]).includes(
+ // Unjustified type cast. FIXME
value as TaskRunEntityType,
);
export const guardTaskRunStatus = (value: string): value is TaskRunStatus =>
- (
- ["started", "success", "failed", "abandoned"] satisfies TaskRunStatus[]
- ).includes(value as TaskRunStatus);
+ (["started", "success", "failed", "abandoned"] satisfies TaskRunStatus[])
+ // Unjustified type cast. FIXME
+ .includes(value as TaskRunStatus);
export const toBackendStartedAt = (
value: TaskRunDateFilterOption | null,
@@ -133,4 +134,6 @@ export const guardTaskRunStartedAtRange = (
"past3months",
"past12months",
] satisfies TaskRunDateFilterOption[]
- ).includes(value as TaskRunDateFilterOption);
+ )
+ // Unjustified type cast. FIXME
+ .includes(value as TaskRunDateFilterOption);
diff --git a/frontend/src/metabase/nav/components/AboutModal/AboutModal.tsx b/frontend/src/metabase/nav/components/AboutModal/AboutModal.tsx
index 2b1c73a3792..85d653105c3 100644
--- a/frontend/src/metabase/nav/components/AboutModal/AboutModal.tsx
+++ b/frontend/src/metabase/nav/components/AboutModal/AboutModal.tsx
@@ -25,6 +25,7 @@ export const AboutModal = ({
onClose,
opened,
}: Pick<ModalProps, "onClose" | "opened">) => {
+ // Unjustified type cast. FIXME
const version = useSetting("version") as MetabaseInfo["version"];
const applicationName = useSelector(getApplicationName);
const { tag, date, ...versionExtra } = version;
diff --git a/frontend/src/metabase/nav/components/AppBar/AppBarToggle.tsx b/frontend/src/metabase/nav/components/AppBar/AppBarToggle.tsx
index 62172c3671d..a413ef0427e 100644
--- a/frontend/src/metabase/nav/components/AppBar/AppBarToggle.tsx
+++ b/frontend/src/metabase/nav/components/AppBar/AppBarToggle.tsx
@@ -51,6 +51,7 @@ export function AppBarToggle({
if (!isNavBarEnabled) {
return null;
}
+ // Unjustified type cast. FIXME
return (
<div ref={hoverRef as React.Ref<HTMLDivElement>}>
<Tooltip
diff --git a/frontend/src/metabase/nav/components/AppSwitcher/AppSwitcher.unit.spec.tsx b/frontend/src/metabase/nav/components/AppSwitcher/AppSwitcher.unit.spec.tsx
index 3d55d8d35d3..275fc248f51 100644
--- a/frontend/src/metabase/nav/components/AppSwitcher/AppSwitcher.unit.spec.tsx
+++ b/frontend/src/metabase/nav/components/AppSwitcher/AppSwitcher.unit.spec.tsx
@@ -22,6 +22,7 @@ import { AppSwitcher } from "./AppSwitcher";
const USER = createMockUser();
const REGULAR_ITEMS = [
+ // Unjustified type cast. FIXME
USER.first_name as string,
USER.email,
"Help",
@@ -99,6 +100,7 @@ describe("ProfileLink", () => {
// Should always render a profile link
expect(
+ // Unjustified type cast. FIXME
await screen.findByText(USER.first_name as string),
).toBeInTheDocument();
expect(await screen.findByText(USER.email)).toBeInTheDocument();
diff --git a/frontend/src/metabase/nav/components/NavbarPromoCard/NavbarPromoCard.tsx b/frontend/src/metabase/nav/components/NavbarPromoCard/NavbarPromoCard.tsx
index 320a4751e53..7fdff08688d 100644
--- a/frontend/src/metabase/nav/components/NavbarPromoCard/NavbarPromoCard.tsx
+++ b/frontend/src/metabase/nav/components/NavbarPromoCard/NavbarPromoCard.tsx
@@ -66,6 +66,7 @@ export function NavbarPromoCard({
{linkText}
</Anchor>
) : (
+ // Unjustified type cast. FIXME
<Anchor component={Link} to={linkTo as string} size="sm" fw="bold">
{linkText}
</Anchor>
diff --git a/frontend/src/metabase/nav/components/WhatsNewNotification/WhatsNewNotification.unit.spec.tsx b/frontend/src/metabase/nav/components/WhatsNewNotification/WhatsNewNotification.unit.spec.tsx
index 5a6ed84f9ea..862e4ba8d53 100644
--- a/frontend/src/metabase/nav/components/WhatsNewNotification/WhatsNewNotification.unit.spec.tsx
+++ b/frontend/src/metabase/nav/components/WhatsNewNotification/WhatsNewNotification.unit.spec.tsx
@@ -168,6 +168,7 @@ describe("WhatsNewNotification", () => {
await waitFor(async () => {
const lastCall = fetchMock.callHistory.lastCall(LAST_ACK_SETTINGS_URL);
+ // Unjustified type cast. FIXME
expect(JSON.parse(lastCall?.options?.body as string)).toEqual({
value: currentVersionTag,
});
diff --git a/frontend/src/metabase/nav/components/search/SearchBar/SearchBar.unit.spec.tsx b/frontend/src/metabase/nav/components/search/SearchBar/SearchBar.unit.spec.tsx
index 4a9a183c271..4075248c59c 100644
--- a/frontend/src/metabase/nav/components/search/SearchBar/SearchBar.unit.spec.tsx
+++ b/frontend/src/metabase/nav/components/search/SearchBar/SearchBar.unit.spec.tsx
@@ -154,6 +154,7 @@ describe("SearchBar", () => {
await userEvent.tab();
expect(
+ // Unjustified type cast. FIXME
within(filteredElement as HTMLElement).getByText("Our analytics"),
).toHaveFocus();
}
diff --git a/frontend/src/metabase/nav/components/search/SearchResultsDropdown/SearchResultsDropdown.styled.tsx b/frontend/src/metabase/nav/components/search/SearchResultsDropdown/SearchResultsDropdown.styled.tsx
index 0c0984c9152..c4a3c5856d0 100644
--- a/frontend/src/metabase/nav/components/search/SearchResultsDropdown/SearchResultsDropdown.styled.tsx
+++ b/frontend/src/metabase/nav/components/search/SearchResultsDropdown/SearchResultsDropdown.styled.tsx
@@ -11,6 +11,7 @@ import {
import type { GroupProps, PaperProps } from "metabase/ui";
import { Group, Paper } from "metabase/ui";
+// Unjustified type cast. FIXME
export const SearchResultsContainer = styled(Paper)<PaperProps>`
display: flex;
flex-direction: column;
diff --git a/frontend/src/metabase/nav/containers/MainNavbar/MainNavbar.styled.tsx b/frontend/src/metabase/nav/containers/MainNavbar/MainNavbar.styled.tsx
index 8e7e12b61a2..8f205b2238f 100644
--- a/frontend/src/metabase/nav/containers/MainNavbar/MainNavbar.styled.tsx
+++ b/frontend/src/metabase/nav/containers/MainNavbar/MainNavbar.styled.tsx
@@ -65,6 +65,7 @@ export const SidebarContentRoot = styled.div`
justify-content: space-between;
`;
+// Unjustified type cast. FIXME
export const SidebarSection = styled(Box)<BoxProps>`
margin-top: var(--mantine-spacing-sm);
margin-bottom: var(--mantine-spacing-md);
@@ -72,6 +73,7 @@ export const SidebarSection = styled(Box)<BoxProps>`
padding-inline-end: var(--mantine-spacing-md);
` as unknown as typeof Box;
+// Unjustified type cast. FIXME
export const TrashSidebarSection = styled(SidebarSection)`
${ExpandToggleButton} {
width: 12px;
diff --git a/frontend/src/metabase/nav/containers/MainNavbar/MainNavbarContainer/BookmarkList/BookmarkList.unit.spec.tsx b/frontend/src/metabase/nav/containers/MainNavbar/MainNavbarContainer/BookmarkList/BookmarkList.unit.spec.tsx
index b3e52b20f0b..5cb86c66b46 100644
--- a/frontend/src/metabase/nav/containers/MainNavbar/MainNavbarContainer/BookmarkList/BookmarkList.unit.spec.tsx
+++ b/frontend/src/metabase/nav/containers/MainNavbar/MainNavbarContainer/BookmarkList/BookmarkList.unit.spec.tsx
@@ -96,6 +96,7 @@ describe("BookmarkList", () => {
const row = screen.getByText(name).closest("a");
expect(
+ // Unjustified type cast. FIXME
within(row as HTMLElement).getByLabelText(`${icon} icon`),
).toBeInTheDocument();
},
diff --git a/frontend/src/metabase/nav/containers/MainNavbar/SidebarItems/SidebarCollectionLink.tsx b/frontend/src/metabase/nav/containers/MainNavbar/SidebarItems/SidebarCollectionLink.tsx
index b313be34b85..184ad41d2e9 100644
--- a/frontend/src/metabase/nav/containers/MainNavbar/SidebarItems/SidebarCollectionLink.tsx
+++ b/frontend/src/metabase/nav/containers/MainNavbar/SidebarItems/SidebarCollectionLink.tsx
@@ -104,6 +104,7 @@ const SidebarCollectionLink = forwardRef<HTMLLIElement, Props>(
<SidebarIcon {...icon} isSelected={isSelected} />
</TreeNode.IconContainer>
<NameContainer>{collection.name}</NameContainer>
+ {/* Unjustified type cast. FIXME */}
{rightSection?.(collection as unknown as ITreeNodeItem)}
</>
);
@@ -145,6 +146,7 @@ const DroppableSidebarCollectionLink = forwardRef<HTMLLIElement, TreeNodeProps>(
{ item, ...props }: TreeNodeProps,
ref,
) {
+ // Unjustified type cast. FIXME
const collection = item as unknown as Collection;
const link = (droppableProps?: DroppableProps) => (
diff --git a/frontend/src/metabase/nav/containers/MainNavbar/tests/common.unit.spec.tsx b/frontend/src/metabase/nav/containers/MainNavbar/tests/common.unit.spec.tsx
index e1bbe1332a1..5f59da4e7e9 100644
--- a/frontend/src/metabase/nav/containers/MainNavbar/tests/common.unit.spec.tsx
+++ b/frontend/src/metabase/nav/containers/MainNavbar/tests/common.unit.spec.tsx
@@ -307,6 +307,7 @@ describe("nav > containers > MainNavbar", () => {
it("should highlight question's collection if selected", async () => {
const card = createMockCard({
+ // Unjustified type cast. FIXME
collection_id: TEST_COLLECTION.id as number,
});
await setup({
@@ -325,6 +326,7 @@ describe("nav > containers > MainNavbar", () => {
it("should highlight dashboard's collection if selected", async () => {
const dashboard = createMockDashboard({
+ // Unjustified type cast. FIXME
collection_id: TEST_COLLECTION.id as number,
});
await setup({
@@ -343,6 +345,7 @@ describe("nav > containers > MainNavbar", () => {
it("should highlight model's collection when on model detail page", async () => {
const model = createMockCard({
+ // Unjustified type cast. FIXME
collection_id: TEST_COLLECTION.id as number,
type: "model",
});
diff --git a/frontend/src/metabase/new/components/NewModals/NewModals.tsx b/frontend/src/metabase/new/components/NewModals/NewModals.tsx
index 88898a2da9a..58152e768c1 100644
--- a/frontend/src/metabase/new/components/NewModals/NewModals.tsx
+++ b/frontend/src/metabase/new/components/NewModals/NewModals.tsx
@@ -105,6 +105,7 @@ export const NewModals = withRouter((props: WithRouterProps) => {
</Modal>
);
case "embed": {
+ // Unjustified type cast. FIXME
const props = currentNewModalProps as SdkIframeEmbedSetupModalProps;
return (
<SdkIframeEmbedSetupModal
@@ -115,6 +116,7 @@ export const NewModals = withRouter((props: WithRouterProps) => {
);
}
case STATIC_LEGACY_EMBEDDING_TYPE: {
+ // Unjustified type cast. FIXME
const props = currentNewModalProps as LegacyStaticEmbeddingModalProps;
return (
diff --git a/frontend/src/metabase/notifications/EmailAttachmentPicker.unit.spec.tsx b/frontend/src/metabase/notifications/EmailAttachmentPicker.unit.spec.tsx
index 746f9902d49..665715ec5d3 100644
--- a/frontend/src/metabase/notifications/EmailAttachmentPicker.unit.spec.tsx
+++ b/frontend/src/metabase/notifications/EmailAttachmentPicker.unit.spec.tsx
@@ -475,9 +475,11 @@ function createPulse(): DashboardSubscription {
can_write: true,
collection_position: null,
created_at: "2024-01-01T00:00:00Z",
+ // Unjustified type cast. FIXME
creator: { id: 1, common_name: "Test", email: "[email protected]" } as any,
creator_id: 1,
disable_links: false,
+ // Unjustified type cast. FIXME
entity_id: "test-entity-id" as any,
id: 1,
updated_at: "2024-01-01T00:00:00Z",
@@ -530,9 +532,11 @@ function createPulseWithDuplicateCardId(): DashboardSubscription {
can_write: true,
collection_position: null,
created_at: "2024-01-01T00:00:00Z",
+ // Unjustified type cast. FIXME
creator: { id: 1, common_name: "Test", email: "[email protected]" } as any,
creator_id: 1,
disable_links: false,
+ // Unjustified type cast. FIXME
entity_id: "test-entity-id" as any,
id: 2,
updated_at: "2024-01-01T00:00:00Z",
diff --git a/frontend/src/metabase/notifications/modals/CreateOrEditQuestionAlertModal/CreateOrEditQuestionAlertModal.tsx b/frontend/src/metabase/notifications/modals/CreateOrEditQuestionAlertModal/CreateOrEditQuestionAlertModal.tsx
index ea81bbdca7a..159e7f63024 100644
--- a/frontend/src/metabase/notifications/modals/CreateOrEditQuestionAlertModal/CreateOrEditQuestionAlertModal.tsx
+++ b/frontend/src/metabase/notifications/modals/CreateOrEditQuestionAlertModal/CreateOrEditQuestionAlertModal.tsx
@@ -202,6 +202,7 @@ export const CreateOrEditQuestionAlertModal = ({
if (isEditMode) {
result = await updateNotification(
+ // Unjustified type cast. FIXME
notification as UpdateAlertNotificationRequest, // TODO: remove typecast
);
} else {
diff --git a/frontend/src/metabase/notifications/modals/CreateOrEditQuestionAlertModal/CreateOrEditQuestionAlertModal.unit.spec.tsx b/frontend/src/metabase/notifications/modals/CreateOrEditQuestionAlertModal/CreateOrEditQuestionAlertModal.unit.spec.tsx
index 1650890c354..aeee62e421b 100644
--- a/frontend/src/metabase/notifications/modals/CreateOrEditQuestionAlertModal/CreateOrEditQuestionAlertModal.unit.spec.tsx
+++ b/frontend/src/metabase/notifications/modals/CreateOrEditQuestionAlertModal/CreateOrEditQuestionAlertModal.unit.spec.tsx
@@ -284,6 +284,7 @@ describe("CreateOrEditQuestionAlertModal", () => {
await waitFor(async () => {
const requestBody = await calls[0].options?.body;
+ // Unjustified type cast. FIXME
const subscription = JSON.parse(requestBody as string).subscriptions[0];
// Verify the cron schedule is for 8am daily
@@ -329,6 +330,7 @@ describe("CreateOrEditQuestionAlertModal", () => {
await waitFor(async () => {
const requestBody = await calls[0].options?.body;
+ // Unjustified type cast. FIXME
const subscription = JSON.parse(requestBody as string).subscriptions[0];
// Verify the cron schedule is for 8am daily
@@ -443,6 +445,7 @@ describe("CreateOrEditQuestionAlertModal", () => {
await waitFor(async () => {
const requestBody = await calls[0].options?.body;
+ // Unjustified type cast. FIXME
const subscription = JSON.parse(requestBody as string).subscriptions[0];
// Verify the cron schedule is for Tuesday at 2pm (day 3)
@@ -529,6 +532,7 @@ describe("CreateOrEditQuestionAlertModal", () => {
await waitFor(async () => {
const requestBody = await calls[0].options?.body;
+ // Unjustified type cast. FIXME
expect(JSON.parse(requestBody as string).creator_id).toBe(7);
});
});
diff --git a/frontend/src/metabase/notifications/modals/CreateOrEditQuestionAlertModal/components/NotificationSchedule/NotificationSchedule.tsx b/frontend/src/metabase/notifications/modals/CreateOrEditQuestionAlertModal/components/NotificationSchedule/NotificationSchedule.tsx
index 3d523b087c8..21751b2957e 100644
--- a/frontend/src/metabase/notifications/modals/CreateOrEditQuestionAlertModal/components/NotificationSchedule/NotificationSchedule.tsx
+++ b/frontend/src/metabase/notifications/modals/CreateOrEditQuestionAlertModal/components/NotificationSchedule/NotificationSchedule.tsx
@@ -62,6 +62,7 @@ export const NotificationSchedule = ({
schedule: ScheduleSettings,
cronExpression: string,
) {
+ // Unjustified type cast. FIXME
if (PERIODIC_SCHEDULE_TYPES.includes(schedule.schedule_type as string)) {
return null;
}
diff --git a/frontend/src/metabase/notifications/modals/CreateOrEditQuestionAlertModal/components/NotificationSchedule/NotificationSchedule.unit.spec.tsx b/frontend/src/metabase/notifications/modals/CreateOrEditQuestionAlertModal/components/NotificationSchedule/NotificationSchedule.unit.spec.tsx
index 46e798fe935..38763a51981 100644
--- a/frontend/src/metabase/notifications/modals/CreateOrEditQuestionAlertModal/components/NotificationSchedule/NotificationSchedule.unit.spec.tsx
+++ b/frontend/src/metabase/notifications/modals/CreateOrEditQuestionAlertModal/components/NotificationSchedule/NotificationSchedule.unit.spec.tsx
@@ -34,6 +34,7 @@ describe("NotificationSchedule", () => {
event_name: null,
cron_schedule: "0 0/5 * * * ? *", // every 5 minutes
created_at: "2025-03-14T16:11:12Z",
+ // Unjustified type cast. FIXME
ui_display_type: `cron/${uiDisplayType}` as ScheduleDisplayType,
},
});
@@ -54,6 +55,7 @@ describe("NotificationSchedule", () => {
event_name: null,
cron_schedule: "0 0/10 * * * ? *", // every 10 minutes
created_at: "2025-03-14T16:11:12Z",
+ // Unjustified type cast. FIXME
ui_display_type: `cron/${uiDisplayType}` as ScheduleDisplayType,
},
});
diff --git a/frontend/src/metabase/notifications/modals/components/NotificationChannelsAddMenu.tsx b/frontend/src/metabase/notifications/modals/components/NotificationChannelsAddMenu.tsx
index 34e29f90b89..afe2a7b3e69 100644
--- a/frontend/src/metabase/notifications/modals/components/NotificationChannelsAddMenu.tsx
+++ b/frontend/src/metabase/notifications/modals/components/NotificationChannelsAddMenu.tsx
@@ -50,6 +50,7 @@ export const NotificationChannelsAddMenu = ({
result[item.channel_id] = true;
return result;
},
+ // Unjustified type cast. FIXME
{} as { [key: number]: true },
);
diff --git a/frontend/src/metabase/notifications/pulse/actions.ts b/frontend/src/metabase/notifications/pulse/actions.ts
index 755bddf5325..15e617867e1 100644
--- a/frontend/src/metabase/notifications/pulse/actions.ts
+++ b/frontend/src/metabase/notifications/pulse/actions.ts
@@ -42,12 +42,14 @@ export const saveEditingPulse = createThunkAction(
if (isEdit) {
return await dispatch(
subscriptionApi.endpoints.updateSubscription.initiate(
+ // Unjustified type cast. FIXME
editingPulse as unknown as UpdateSubscriptionRequest,
),
).unwrap();
} else {
return await dispatch(
subscriptionApi.endpoints.createSubscription.initiate(
+ // Unjustified type cast. FIXME
editingPulse as unknown as CreateSubscriptionRequest,
),
).unwrap();
diff --git a/frontend/src/metabase/notifications/pulse/reducers.ts b/frontend/src/metabase/notifications/pulse/reducers.ts
index 74603e611dd..68d601f718f 100644
--- a/frontend/src/metabase/notifications/pulse/reducers.ts
+++ b/frontend/src/metabase/notifications/pulse/reducers.ts
@@ -50,6 +50,7 @@ export const formInput = handleActions(
) => payload,
},
},
+ // Unjustified type cast. FIXME
{} as ChannelApiResponse,
);
@@ -62,5 +63,6 @@ export const pulseList = handleActions(
) => payload,
},
},
+ // Unjustified type cast. FIXME
[] as DashboardSubscription[],
);
diff --git a/frontend/src/metabase/palette/components/Palette.stories.tsx b/frontend/src/metabase/palette/components/Palette.stories.tsx
index bb4c6acfe29..9a0c9133c6b 100644
--- a/frontend/src/metabase/palette/components/Palette.stories.tsx
+++ b/frontend/src/metabase/palette/components/Palette.stories.tsx
@@ -37,6 +37,7 @@ registerVisualization(LineChart);
// @ts-expect-error: incompatible prop types with registerVisualization
registerVisualization(Table);
+// Unjustified type cast. FIXME
const store = getCommonStore(storeInitialState) as unknown as Store<State>;
const ReduxDecorator = (Story: StoryFn) => {
diff --git a/frontend/src/metabase/palette/components/PaletteResultItem.unit.spec.tsx b/frontend/src/metabase/palette/components/PaletteResultItem.unit.spec.tsx
index 9978243d6f1..51d2c09f254 100644
--- a/frontend/src/metabase/palette/components/PaletteResultItem.unit.spec.tsx
+++ b/frontend/src/metabase/palette/components/PaletteResultItem.unit.spec.tsx
@@ -13,6 +13,7 @@ import { PaletteResultItem } from "./PaletteResultItem";
import { PaletteResultList } from "./PaletteResultsList";
const mockPaletteActionImpl = (opts: Partial<PaletteActionImpl>) =>
+ // Unjustified type cast. FIXME
({
name: "test action",
id: "action-1",
diff --git a/frontend/src/metabase/palette/components/PaletteResults.tsx b/frontend/src/metabase/palette/components/PaletteResults.tsx
index e6d6147ee47..5c6ea4eeedf 100644
--- a/frontend/src/metabase/palette/components/PaletteResults.tsx
+++ b/frontend/src/metabase/palette/components/PaletteResults.tsx
@@ -101,6 +101,7 @@ export const PaletteResults = ({
const processedResults = useMemo(
() =>
processResults(
+ // Unjustified type cast. FIXME
results as (PaletteActionImpl | string)[],
liveSearchTerm.length !== 0,
),
diff --git a/frontend/src/metabase/palette/components/PaletteShortcutsModal/PaletteShortcutsModal.tsx b/frontend/src/metabase/palette/components/PaletteShortcutsModal/PaletteShortcutsModal.tsx
index cbeaba89e8a..a0fcd331061 100644
--- a/frontend/src/metabase/palette/components/PaletteShortcutsModal/PaletteShortcutsModal.tsx
+++ b/frontend/src/metabase/palette/components/PaletteShortcutsModal/PaletteShortcutsModal.tsx
@@ -23,6 +23,7 @@ const groupedShortcuts = _.groupBy(
"shortcutGroup",
);
+// Unjustified type cast. FIXME
const shortcutGroups = Object.keys(groupedShortcuts).filter(
(val) => !!val,
) as ShortcutGroup[];
diff --git a/frontend/src/metabase/palette/components/test/PaletteResults/setup.tsx b/frontend/src/metabase/palette/components/test/PaletteResults/setup.tsx
index e3b4ee6d5c5..1e6cd5d4d93 100644
--- a/frontend/src/metabase/palette/components/test/PaletteResults/setup.tsx
+++ b/frontend/src/metabase/palette/components/test/PaletteResults/setup.tsx
@@ -108,7 +108,9 @@ const recents_2 = createMockRecentCollectionItem({
..._.pick(dashboard, "id", "name"),
model: "dashboard",
parent_collection: {
+ // Unjustified type cast. FIXME
id: dashboard.collection?.id as number,
+ // Unjustified type cast. FIXME
name: dashboard.collection?.name as string,
},
});
diff --git a/frontend/src/metabase/palette/shortcuts/shortcuts.unit.spec.ts b/frontend/src/metabase/palette/shortcuts/shortcuts.unit.spec.ts
index 11bdb8a405b..bcde5bbe6cb 100644
--- a/frontend/src/metabase/palette/shortcuts/shortcuts.unit.spec.ts
+++ b/frontend/src/metabase/palette/shortcuts/shortcuts.unit.spec.ts
@@ -1,6 +1,7 @@
import { type KeyboardShortcutId, shortcuts } from ".";
const getShortcutsWithPrefix = (prefix: string) => {
+ // Unjustified type cast. FIXME
const allIds = Object.keys(shortcuts) as KeyboardShortcutId[];
return allIds
.filter((id) => id.startsWith(prefix))
diff --git a/frontend/src/metabase/palette/utils.ts b/frontend/src/metabase/palette/utils.ts
index 71c0ee3e8ed..3b8f4657e6b 100644
--- a/frontend/src/metabase/palette/utils.ts
+++ b/frontend/src/metabase/palette/utils.ts
@@ -96,6 +96,7 @@ export const getCommandPaletteIcon = (
item: PaletteActionImpl,
): { name: IconName; c: ColorName } => {
const icon = {
+ // Unjustified type cast. FIXME
name: item.icon as IconName,
c: item.extra?.iconColor || "core-brand",
};
diff --git a/frontend/src/metabase/palette/utils.unit.spec.ts b/frontend/src/metabase/palette/utils.unit.spec.ts
index c73987c34ca..d6d36a30b59 100644
--- a/frontend/src/metabase/palette/utils.unit.spec.ts
+++ b/frontend/src/metabase/palette/utils.unit.spec.ts
@@ -21,6 +21,7 @@ const createMockAction = ({
section = "basic",
disabled,
}: mockAction): PaletteActionImpl =>
+ // Unjustified type cast. FIXME
({ id, name, section, disabled }) as PaletteActionImpl;
describe("command palette utils", () => {
diff --git a/frontend/src/metabase/parameters/actions.unit.spec.ts b/frontend/src/metabase/parameters/actions.unit.spec.ts
index 920241c4569..606f70fdfb7 100644
--- a/frontend/src/metabase/parameters/actions.unit.spec.ts
+++ b/frontend/src/metabase/parameters/actions.unit.spec.ts
@@ -19,10 +19,12 @@ const CACHED: ParameterValues = {
};
const createGetState = (cache: Record<string, ParameterValues>): GetState =>
+ // Unjustified type cast. FIXME
(() => ({
parameters: { parameterValuesCache: cache },
})) as unknown as GetState;
+// Unjustified type cast. FIXME
const dispatch = jest.fn() as unknown as DispatchFn;
describe("parameters > actions", () => {
diff --git a/frontend/src/metabase/parameters/components/FormattedParameterValue/FormattedParameterValue.tsx b/frontend/src/metabase/parameters/components/FormattedParameterValue/FormattedParameterValue.tsx
index 59a8827c970..fe8993dd8c8 100644
--- a/frontend/src/metabase/parameters/components/FormattedParameterValue/FormattedParameterValue.tsx
+++ b/frontend/src/metabase/parameters/components/FormattedParameterValue/FormattedParameterValue.tsx
@@ -55,7 +55,8 @@ function FormattedParameterValue({
const first = getValue(value);
const label = isBooleanParameter(parameter)
- ? getBooleanLabel(first as boolean)
+ ? // Unjustified type cast. FIXME
+ getBooleanLabel(first as boolean)
: undefined;
const renderContent = () => {
diff --git a/frontend/src/metabase/parameters/components/FormattedParameterValue/FormattedParameterValue.unit.spec.tsx b/frontend/src/metabase/parameters/components/FormattedParameterValue/FormattedParameterValue.unit.spec.tsx
index 6c858ad6b7c..622d617dcc6 100644
--- a/frontend/src/metabase/parameters/components/FormattedParameterValue/FormattedParameterValue.unit.spec.tsx
+++ b/frontend/src/metabase/parameters/components/FormattedParameterValue/FormattedParameterValue.unit.spec.tsx
@@ -53,6 +53,7 @@ describe("FormattedParameterValue", () => {
it("should render the placeholder with truncation when there is no value", () => {
setup({
+ // Unjustified type cast. FIXME
value: null as any,
parameter: createMockParameter(),
placeholder: "Filter this long column name",
diff --git a/frontend/src/metabase/parameters/components/ParameterTargetList.tsx b/frontend/src/metabase/parameters/components/ParameterTargetList.tsx
index 62fedf4c0f7..a56355e6bbc 100644
--- a/frontend/src/metabase/parameters/components/ParameterTargetList.tsx
+++ b/frontend/src/metabase/parameters/components/ParameterTargetList.tsx
@@ -55,6 +55,7 @@ export const ParameterTargetList = ({
itemIsSelected={(item: ParameterMappingOption) =>
item === selectedMappingOption
}
+ // Unjustified type cast. FIXME
renderItemIcon={(item: ParameterMappingOption) => (
<Icon name={(item.icon as IconName) || "unknown"} size={18} />
)}
diff --git a/frontend/src/metabase/parameters/components/ParameterValueWidgetTrigger.tsx b/frontend/src/metabase/parameters/components/ParameterValueWidgetTrigger.tsx
index 01c8e74401a..0743db90592 100644
--- a/frontend/src/metabase/parameters/components/ParameterValueWidgetTrigger.tsx
+++ b/frontend/src/metabase/parameters/components/ParameterValueWidgetTrigger.tsx
@@ -47,6 +47,7 @@ function ParameterValueWidgetTriggerInner(
}
: {
component: "div" as const,
+ // Unjustified type cast. FIXME
ref: ref as Ref<HTMLDivElement>,
};
diff --git a/frontend/src/metabase/parameters/components/ParametersList/ParametersList.tsx b/frontend/src/metabase/parameters/components/ParametersList/ParametersList.tsx
index c1d58ac34a7..83f79120416 100644
--- a/frontend/src/metabase/parameters/components/ParametersList/ParametersList.tsx
+++ b/frontend/src/metabase/parameters/components/ParametersList/ParametersList.tsx
@@ -58,6 +58,7 @@ export const ParametersList = forwardRef<HTMLDivElement, ParametersListProps>(
const handleSortEnd = useCallback(
({ id, newIndex }: DragEndEvent) => {
if (setParameterIndex) {
+ // Unjustified type cast. FIXME
setParameterIndex(id as ParameterId, newIndex);
}
},
diff --git a/frontend/src/metabase/parameters/components/ValuesSourceModal/ValuesSourceTypeModal.tsx b/frontend/src/metabase/parameters/components/ValuesSourceModal/ValuesSourceTypeModal.tsx
index b918b0ccc82..0d5d941c8f9 100644
--- a/frontend/src/metabase/parameters/components/ValuesSourceModal/ValuesSourceTypeModal.tsx
+++ b/frontend/src/metabase/parameters/components/ValuesSourceModal/ValuesSourceTypeModal.tsx
@@ -163,7 +163,8 @@ const serializeSourceType = (sourceType: ValuesSourceType): string =>
const deserializeSourceType = (value: string): ValuesSourceType =>
value === CONNECTED_FIELDS_SENTINEL_VALUE
? null
- : (value as ValuesSourceType);
+ : // Unjustified type cast. FIXME
+ (value as ValuesSourceType);
const SourceTypeOptions = ({
parameter,
diff --git a/frontend/src/metabase/parameters/components/ValuesSourceSettings/ValuesSourceSettings.tsx b/frontend/src/metabase/parameters/components/ValuesSourceSettings/ValuesSourceSettings.tsx
index 934a8daa0d1..176f7687651 100644
--- a/frontend/src/metabase/parameters/components/ValuesSourceSettings/ValuesSourceSettings.tsx
+++ b/frontend/src/metabase/parameters/components/ValuesSourceSettings/ValuesSourceSettings.tsx
@@ -39,6 +39,7 @@ export function ValuesSourceSettings({
<Radio.Group
value={queryType}
onChange={(newValue: string) =>
+ // Unjustified type cast. FIXME
onChangeQueryType(newValue as ValuesQueryType)
}
>
diff --git a/frontend/src/metabase/parameters/components/widgets/ParameterFieldWidget/FieldValuesWidget/ListField/test-constants.ts b/frontend/src/metabase/parameters/components/widgets/ParameterFieldWidget/FieldValuesWidget/ListField/test-constants.ts
index 1f500196a3e..0d94a199fc9 100644
--- a/frontend/src/metabase/parameters/components/widgets/ParameterFieldWidget/FieldValuesWidget/ListField/test-constants.ts
+++ b/frontend/src/metabase/parameters/components/widgets/ParameterFieldWidget/FieldValuesWidget/ListField/test-constants.ts
@@ -8,6 +8,7 @@ export const translateToGerman: ContentTranslationFunction = (msgid) => {
Gadget: "Gerät",
Widget: "Apparat",
};
+ // Unjustified type cast. FIXME
return _.get(dictionary, msgid as string, msgid);
};
@@ -15,5 +16,6 @@ export const translateToJapanese: ContentTranslationFunction = (msgid) => {
const dictionary = {
Products: "グッズ",
};
+ // Unjustified type cast. FIXME
return _.get(dictionary, msgid as string, msgid);
};
diff --git a/frontend/src/metabase/parameters/components/widgets/ParameterFieldWidget/FieldValuesWidget/testMocks.spec.ts b/frontend/src/metabase/parameters/components/widgets/ParameterFieldWidget/FieldValuesWidget/testMocks.spec.ts
index 6d397d19ddb..8318819e22f 100644
--- a/frontend/src/metabase/parameters/components/widgets/ParameterFieldWidget/FieldValuesWidget/testMocks.spec.ts
+++ b/frontend/src/metabase/parameters/components/widgets/ParameterFieldWidget/FieldValuesWidget/testMocks.spec.ts
@@ -67,6 +67,7 @@ const database = createSampleDatabase({
has_more_values: true,
}),
createMockField({
+ // Unjustified type cast. FIXME
id: EXPRESSION_FIELD_ID as any,
field_ref: ["expression", "CC"],
}),
diff --git a/frontend/src/metabase/parameters/components/widgets/ParameterFieldWidget/ParameterFieldWidget.tsx b/frontend/src/metabase/parameters/components/widgets/ParameterFieldWidget/ParameterFieldWidget.tsx
index dc737c4b5b8..ec97dcc280d 100644
--- a/frontend/src/metabase/parameters/components/widgets/ParameterFieldWidget/ParameterFieldWidget.tsx
+++ b/frontend/src/metabase/parameters/components/widgets/ParameterFieldWidget/ParameterFieldWidget.tsx
@@ -69,6 +69,7 @@ export function ParameterFieldWidget({
if (isRequired && isEmpty) {
if (hasValue(parameter.default)) {
+ // Unjustified type cast. FIXME
setValue(parameter.default as RowValue[]);
}
return;
diff --git a/frontend/src/metabase/parameters/components/widgets/ParameterFieldWidget/Value/RemappedValue.tsx b/frontend/src/metabase/parameters/components/widgets/ParameterFieldWidget/Value/RemappedValue.tsx
index 12d193f1b4e..d8279f7033d 100644
--- a/frontend/src/metabase/parameters/components/widgets/ParameterFieldWidget/Value/RemappedValue.tsx
+++ b/frontend/src/metabase/parameters/components/widgets/ParameterFieldWidget/Value/RemappedValue.tsx
@@ -24,6 +24,7 @@ export type RemappedValueProps = {
autoLoad?: boolean;
};
+// Unjustified type cast. FIXME
const defaultRenderNormal: RenderNormal = ({ value }) => (
<span>{value as ReactNode}</span>
);
@@ -34,6 +35,7 @@ const defaultRenderRemapped: RenderRemapped = ({
column,
}) => (
<span>
+ {/* Unjustified type cast. FIXME */}
<span className={CS.textBold}>{displayValue as ReactNode}</span>
{/* Show the underlying ID for PK/FK */}
{column?.isID() && <span style={{ opacity: 0.5 }}>{" - " + value}</span>}
diff --git a/frontend/src/metabase/parameters/components/widgets/ParameterFieldWidget/normalizeValue.ts b/frontend/src/metabase/parameters/components/widgets/ParameterFieldWidget/normalizeValue.ts
index 50baaa716a3..e8e37253be2 100644
--- a/frontend/src/metabase/parameters/components/widgets/ParameterFieldWidget/normalizeValue.ts
+++ b/frontend/src/metabase/parameters/components/widgets/ParameterFieldWidget/normalizeValue.ts
@@ -4,6 +4,7 @@ export function normalizeValue<T>(
value: NonArray<T> | NonArray<T>[] | undefined,
): T[] {
if (Array.isArray(value)) {
+ // Unjustified type cast. FIXME
return value as T[];
}
diff --git a/frontend/src/metabase/parameters/components/widgets/StringInputWidget/StringInputWidget.tsx b/frontend/src/metabase/parameters/components/widgets/StringInputWidget/StringInputWidget.tsx
index 0c67d60e9f8..b494ddfc306 100644
--- a/frontend/src/metabase/parameters/components/widgets/StringInputWidget/StringInputWidget.tsx
+++ b/frontend/src/metabase/parameters/components/widgets/StringInputWidget/StringInputWidget.tsx
@@ -51,6 +51,7 @@ export function StringInputWidget({
event.preventDefault();
if (isRequired && isEmpty) {
if (hasValue(parameter.default)) {
+ // Unjustified type cast. FIXME
setValue(parameter.default as string[] | undefined);
}
return;
diff --git a/frontend/src/metabase/parameters/components/widgets/TextWidget/TextWidget.tsx b/frontend/src/metabase/parameters/components/widgets/TextWidget/TextWidget.tsx
index 7a70b0bfb7b..3530830cc5c 100644
--- a/frontend/src/metabase/parameters/components/widgets/TextWidget/TextWidget.tsx
+++ b/frontend/src/metabase/parameters/components/widgets/TextWidget/TextWidget.tsx
@@ -92,6 +92,7 @@ export class TextWidget extends Component<TextWidgetProps, State> {
if (e.nativeEvent.isComposing) {
return;
}
+ // Unjustified type cast. FIXME
const target = e.target as HTMLInputElement;
if (e.key === "Enter") {
target.blur();
diff --git a/frontend/src/metabase/parameters/utils/click-behavior.ts b/frontend/src/metabase/parameters/utils/click-behavior.ts
index 53bcd0123e3..b82a4a20cf5 100644
--- a/frontend/src/metabase/parameters/utils/click-behavior.ts
+++ b/frontend/src/metabase/parameters/utils/click-behavior.ts
@@ -204,6 +204,7 @@ function getTargetsForStructuredQuestion(question: Question): Target[] {
}
function getTargetsForNativeQuestion(question: Question): Target[] {
+ // Unjustified type cast. FIXME
const legacyNativeQuery = question.legacyNativeQuery() as NativeQuery;
return [
@@ -529,6 +530,7 @@ function getParameter(
(clickBehavior.linkType === "dashboard" ||
clickBehavior.linkType === "question")
) {
+ // Unjustified type cast. FIXME
const dashboardId = clickBehavior.targetId as DashboardId;
const parameters =
extraData.dashboard?.id === dashboardId
diff --git a/frontend/src/metabase/parameters/utils/click-behavior.unit.spec.ts b/frontend/src/metabase/parameters/utils/click-behavior.unit.spec.ts
index c3b6063adb5..39976946d71 100644
--- a/frontend/src/metabase/parameters/utils/click-behavior.unit.spec.ts
+++ b/frontend/src/metabase/parameters/utils/click-behavior.unit.spec.ts
@@ -236,6 +236,7 @@ describe("metabase-lib/v1/parameters/utils/click-behavior", () => {
userAttribute: ["attr"],
};
+ // Unjustified type cast. FIXME
for (const [targetParameterType, expectedSources] of [
[
"id",
@@ -331,6 +332,7 @@ describe("metabase-lib/v1/parameters/utils/click-behavior", () => {
});
}
+ // Unjustified type cast. FIXME
for (const [targetVariableType, expectedSources] of [
[
"text",
@@ -408,6 +410,7 @@ describe("metabase-lib/v1/parameters/utils/click-behavior", () => {
});
}
+ // Unjustified type cast. FIXME
for (const [field, expectedSources] of [
[
productTitle,
@@ -467,6 +470,7 @@ describe("metabase-lib/v1/parameters/utils/click-behavior", () => {
"template-tags": {
my_field_filter: {
default: null,
+ // Unjustified type cast. FIXME
dimension: ["field", field.id as FieldId, null],
"display-name": "My Field Filter",
id: "foo123",
diff --git a/frontend/src/metabase/parameters/utils/dashboards.unit.spec.tsx b/frontend/src/metabase/parameters/utils/dashboards.unit.spec.tsx
index 93105f462b0..f78a10ae065 100644
--- a/frontend/src/metabase/parameters/utils/dashboards.unit.spec.tsx
+++ b/frontend/src/metabase/parameters/utils/dashboards.unit.spec.tsx
@@ -325,6 +325,7 @@ describe("metabase/parameters/utils/dashboards", () => {
});
describe("getFilteringParameterValuesMap", () => {
+ // Unjustified type cast. FIXME
const undefinedFilteringParameters = {} as UiParameter;
const emptyFilteringParameters = createMockUiParameter({
filteringParameters: [],
diff --git a/frontend/src/metabase/parameters/utils/linked-filters.ts b/frontend/src/metabase/parameters/utils/linked-filters.ts
index 407fe1eac25..fd566434531 100644
--- a/frontend/src/metabase/parameters/utils/linked-filters.ts
+++ b/frontend/src/metabase/parameters/utils/linked-filters.ts
@@ -7,6 +7,7 @@ import type { Parameter } from "metabase-types/api";
export function canUseLinkedFilters(parameter: Parameter): boolean {
const type = getParameterType(parameter);
+ // Unjustified type cast. FIXME
return (TYPE_SUPPORTS_LINKED_FILTERS as readonly string[]).includes(type);
}
diff --git a/frontend/src/metabase/parameters/utils/mapping-options.ts b/frontend/src/metabase/parameters/utils/mapping-options.ts
index b24fbe52fa7..41d3b6b7090 100644
--- a/frontend/src/metabase/parameters/utils/mapping-options.ts
+++ b/frontend/src/metabase/parameters/utils/mapping-options.ts
@@ -330,6 +330,7 @@ export function getMappingOptionByTarget(
query,
stageIndex,
stageColumns,
+ // Unjustified type cast. FIXME
stageMappingOptions.map(({ target }) => target[1] as DimensionReference),
);
diff --git a/frontend/src/metabase/plugins/oss/audit.ts b/frontend/src/metabase/plugins/oss/audit.ts
index 248aa4099bd..09434a06e70 100644
--- a/frontend/src/metabase/plugins/oss/audit.ts
+++ b/frontend/src/metabase/plugins/oss/audit.ts
@@ -44,11 +44,14 @@ export interface InsightsMenuItemProps {
const getDefaultPluginAudit = () => ({
isEnabled: false,
isAuditDb: (_db: DatabaseType) => false,
+ // Unjustified type cast. FIXME
InsightsLink: PluginPlaceholder as ComponentType<InsightsLinkProps>,
+ // Unjustified type cast. FIXME
InsightsMenuItem: PluginPlaceholder as ComponentType<InsightsMenuItemProps>,
getMetabotAnalyticsNavItems: (): ReactNode => null,
getAiAnalyticsRoutes: (): ReactNode => null,
getMcpAnalyticsRoutes: (): ReactNode => null,
+ // Unjustified type cast. FIXME
handleMetabotSlashCommand: ((_args) => false) as MetabotSlashCommandHandler,
});
diff --git a/frontend/src/metabase/plugins/oss/auth.ts b/frontend/src/metabase/plugins/oss/auth.ts
index 15bcd570146..84b7a66b287 100644
--- a/frontend/src/metabase/plugins/oss/auth.ts
+++ b/frontend/src/metabase/plugins/oss/auth.ts
@@ -22,6 +22,7 @@ const getDefaultPluginAuthProviders = () => ({
SettingsSAMLForm: NotFoundPlaceholder,
SettingsJWTForm: NotFoundPlaceholder,
SettingsOIDCForm: NotFoundPlaceholder,
+ // Unjustified type cast. FIXME
providers: [] as GetAuthProviders[],
});
diff --git a/frontend/src/metabase/plugins/oss/caching.ts b/frontend/src/metabase/plugins/oss/caching.ts
index 0c47f6c9694..afef88d0c31 100644
--- a/frontend/src/metabase/plugins/oss/caching.ts
+++ b/frontend/src/metabase/plugins/oss/caching.ts
@@ -107,6 +107,7 @@ export const getAdaptiveStrategyValidationSchema = () => {
});
};
+// Unjustified type cast. FIXME
export const strategies = {
inherit: {
// NOTE: We use functions for labels because otherwise t doesn't work properly
@@ -143,6 +144,7 @@ export const strategies = {
} as Record<string, StrategyData>;
export const getPerformanceTabMetadata = () =>
+ // Unjustified type cast. FIXME
[
{
name: t`Database caching`,
@@ -162,22 +164,31 @@ export const getPerformanceTabMetadata = () =>
const getDefaultPluginCaching = () => ({
isGranularCachingEnabled: () => false,
+ // Unjustified type cast. FIXME
StrategyFormLauncherPanel: PluginPlaceholder as any,
+ // Unjustified type cast. FIXME
GranularControlsExplanation: PluginPlaceholder as any,
SidebarCacheSection:
+ // Unjustified type cast. FIXME
PluginPlaceholder as ComponentType<SidebarCacheSectionProps>,
+ // Unjustified type cast. FIXME
SidebarCacheForm: PluginPlaceholder as ComponentType<SidebarCacheFormProps>,
InvalidateNowButton:
+ // Unjustified type cast. FIXME
PluginPlaceholder as ComponentType<InvalidateNowButtonProps>,
hasQuestionCacheSection: (_question: Question) => false,
canOverrideRootStrategy: false,
strategies: strategies,
+ // Unjustified type cast. FIXME
DashboardAndQuestionCachingTab: PluginPlaceholder as any,
+ // Unjustified type cast. FIXME
StrategyEditorForQuestionsAndDashboards: PluginPlaceholder as any,
getTabMetadata: getPerformanceTabMetadata,
PreemptiveCachingSwitch:
+ // Unjustified type cast. FIXME
PluginPlaceholder as ComponentType<PreemptiveCachingSwitchProps>,
MetricCachingModal:
+ // Unjustified type cast. FIXME
PluginPlaceholder as ComponentType<MetricCachingModalProps>,
});
diff --git a/frontend/src/metabase/plugins/oss/collections.ts b/frontend/src/metabase/plugins/oss/collections.ts
index ce99b711a2e..eed891381b9 100644
--- a/frontend/src/metabase/plugins/oss/collections.ts
+++ b/frontend/src/metabase/plugins/oss/collections.ts
@@ -69,7 +69,9 @@ const getDefaultPluginCollections = () => ({
_collection: Partial<Collection>,
): CollectionAuthorityLevelConfig | CollectionInstanceAnaltyicsConfig =>
AUTHORITY_LEVEL_REGULAR,
+ // Unjustified type cast. FIXME
useGetDefaultCollectionId: null as GetCollectionIdType | null,
+ // Unjustified type cast. FIXME
CUSTOM_INSTANCE_ANALYTICS_COLLECTION_ENTITY_ID: "" as BaseEntityId | "",
INSTANCE_ANALYTICS_ADMIN_READONLY_MESSAGE:
// eslint-disable-next-line metabase/no-literal-metabase-strings -- This string only shows for admins.
@@ -82,13 +84,16 @@ const getDefaultPluginCollections = () => ({
filterOutItemsFromInstanceAnalytics: <Item extends ItemWithCollection>(
items: Item[],
) => items,
+ // Unjustified type cast. FIXME
canCleanUp: (_collection: Collection) => false as boolean,
useGetCleanUpMenuItems: (
_collection: Collection,
): { menuItems: JSX.Element[] } => ({
menuItems: [],
}),
+ // Unjustified type cast. FIXME
cleanUpRoute: null as React.ReactElement | null,
+ // Unjustified type cast. FIXME
cleanUpAlert: (() => null) as (props: {
collection: Collection;
}) => JSX.Element | null,
@@ -98,12 +103,16 @@ export const PLUGIN_COLLECTIONS = getDefaultPluginCollections();
const getDefaultPluginCollectionComponents = () => ({
CollectionAuthorityLevelIcon:
+ // Unjustified type cast. FIXME
PluginPlaceholder as CollectionAuthorityLevelIcon,
FormCollectionAuthorityLevelPicker:
+ // Unjustified type cast. FIXME
PluginPlaceholder as FormCollectionAuthorityLevelPicker,
CollectionInstanceAnalyticsIcon:
+ // Unjustified type cast. FIXME
PluginPlaceholder as CollectionInstanceAnalyticsIcon,
CollectionAuthorityLevelDisplay:
+ // Unjustified type cast. FIXME
PluginPlaceholder as ComponentType<CollectionAuthorityLevelDisplayProps>,
});
diff --git a/frontend/src/metabase/plugins/oss/content-translation.ts b/frontend/src/metabase/plugins/oss/content-translation.ts
index 98f58f07df4..69c40b2a71a 100644
--- a/frontend/src/metabase/plugins/oss/content-translation.ts
+++ b/frontend/src/metabase/plugins/oss/content-translation.ts
@@ -8,6 +8,7 @@ import type { EntityToken } from "metabase-types/api/entity";
const getDefaultPluginContentTranslation = () => ({
isEnabled: false,
+ // Unjustified type cast. FIXME
getDictionaryBasePath: null as string | null,
setEndpointsForAuthEmbedding: () => {},
setEndpointsForStaticEmbedding: (_encodedToken: EntityToken) => {},
diff --git a/frontend/src/metabase/plugins/oss/content-verification.ts b/frontend/src/metabase/plugins/oss/content-verification.ts
index 2d3db84c5b1..41aa79fdaf3 100644
--- a/frontend/src/metabase/plugins/oss/content-verification.ts
+++ b/frontend/src/metabase/plugins/oss/content-verification.ts
@@ -14,6 +14,7 @@ export type MetricFilterSettings = {
const getDefaultPluginContentVerification = () => ({
contentVerificationEnabled: false,
+ // Unjustified type cast. FIXME
VerifiedFilter: {} as SearchFilterComponent<"verified">,
sortCollectionsByVerification: (
_a: CollectionEssentials,
diff --git a/frontend/src/metabase/plugins/oss/custom-viz.ts b/frontend/src/metabase/plugins/oss/custom-viz.ts
index aaff4fa94f1..cf4507278ac 100644
--- a/frontend/src/metabase/plugins/oss/custom-viz.ts
+++ b/frontend/src/metabase/plugins/oss/custom-viz.ts
@@ -22,7 +22,9 @@ const noopCustomVizIcon = (
const getDefaultPluginCustomViz = () => ({
// Admin settings pages
ManageCustomVizPage: PluginPlaceholder as ComponentType<any>,
+ // Unjustified type cast. FIXME
CustomVizPage: PluginPlaceholder as ComponentType<any>,
+ // Unjustified type cast. FIXME
CustomVizDevPage: PluginPlaceholder as ComponentType<any>,
// Hooks & functions
@@ -30,6 +32,7 @@ const getDefaultPluginCustomViz = () => ({
loading: false,
}),
useCustomVizPlugins: (_opts?: { enabled?: boolean }) =>
+ // Unjustified type cast. FIXME
({ plugins: undefined, isLoading: false }) as {
plugins: CustomVizPluginRuntime[] | undefined;
isLoading: boolean;
@@ -40,6 +43,7 @@ const getDefaultPluginCustomViz = () => ({
cacheBustSuffix?: string;
onInfo?: (message: string) => void;
},
+ // Unjustified type cast. FIXME
) => null as string | null,
/**
* Load (and register) the plugin backing a `custom:*` display, if it is
@@ -53,6 +57,7 @@ const getDefaultPluginCustomViz = () => ({
getPluginAssetUrl: (
_pluginId: CustomVizPluginId,
_assetPath: string | null,
+ // Unjustified type cast. FIXME
) => undefined as string | undefined,
// Only the SDK really implements these: its icon `<img>` is cross-origin and
diff --git a/frontend/src/metabase/plugins/oss/database.ts b/frontend/src/metabase/plugins/oss/database.ts
index 4f9c363b767..e6ed955443a 100644
--- a/frontend/src/metabase/plugins/oss/database.ts
+++ b/frontend/src/metabase/plugins/oss/database.ts
@@ -11,11 +11,13 @@ import type {
} from "metabase-types/api";
const getDefaultPluginDbRouting = () => ({
+ // Unjustified type cast. FIXME
DatabaseRoutingSection: PluginPlaceholder as ComponentType<{
database: DatabaseType;
}>,
getDatabaseNameFieldProps: (_isSlug: boolean) => ({}),
getDestinationDatabaseRoutes: (_IsAdmin: any) =>
+ // Unjustified type cast. FIXME
null as React.ReactElement | null,
useRedirectDestinationDatabase: (
_database: Pick<DatabaseType, "id" | "router_database_id"> | undefined,
@@ -28,6 +30,7 @@ const getDefaultPluginDbRouting = () => ({
export const PLUGIN_DB_ROUTING = getDefaultPluginDbRouting();
const getDefaultPluginDatabaseReplication = () => ({
+ // Unjustified type cast. FIXME
DatabaseReplicationSection: PluginPlaceholder as ComponentType<{
database: DatabaseType;
}>,
@@ -39,8 +42,10 @@ export const PLUGIN_DATABASE_REPLICATION =
const getDefaultPluginTableEditing = () => ({
isEnabled: () => false,
isDatabaseTableEditingEnabled: (_database: DatabaseType): boolean => false,
+ // Unjustified type cast. FIXME
getRoutes: () => null as React.ReactElement | null,
getTableEditUrl: (_tableId: TableId, _databaseId: DatabaseId): string => "/",
+ // Unjustified type cast. FIXME
AdminDatabaseTableEditingSection: PluginPlaceholder as ComponentType<{
database: DatabaseType;
settingsAvailable?: Record<string, DatabaseLocalSettingAvailability>;
diff --git a/frontend/src/metabase/plugins/oss/library.ts b/frontend/src/metabase/plugins/oss/library.ts
index 39429e41921..c4081a617e7 100644
--- a/frontend/src/metabase/plugins/oss/library.ts
+++ b/frontend/src/metabase/plugins/oss/library.ts
@@ -139,14 +139,19 @@ const getDefaultPluginLibrary = (): LibraryPlugin => ({
getCollectionPickerItems: () => undefined,
getEntityPickerSyntheticLibraryItem: () => undefined,
CreateLibraryModal:
+ // Unjustified type cast. FIXME
PluginPlaceholder as ComponentType<CreateLibraryModalProps>,
CollectionPermissionsModal:
+ // Unjustified type cast. FIXME
PluginPlaceholder as ComponentType<CollectionPermissionsModalProps>,
PublishTablesModal:
+ // Unjustified type cast. FIXME
PluginPlaceholder as ComponentType<PublishTablesModalProps>,
UnpublishTablesModal:
+ // Unjustified type cast. FIXME
PluginPlaceholder as ComponentType<UnpublishTablesModalProps>,
useGetLibraryCollectionQuery:
+ // Unjustified type cast. FIXME
(() => []) as unknown as LibraryPlugin["useGetLibraryCollectionQuery"],
getLibraryCollectionEmptyStateMessages: () => ({
title: "",
diff --git a/frontend/src/metabase/plugins/oss/metabot.ts b/frontend/src/metabase/plugins/oss/metabot.ts
index b11269acd7b..96924645b45 100644
--- a/frontend/src/metabase/plugins/oss/metabot.ts
+++ b/frontend/src/metabase/plugins/oss/metabot.ts
@@ -9,6 +9,7 @@ export type MetabaseAIProviderSetupProps = {
const getDefaultPluginMetabot = () => ({
isEnabled: false,
MetabaseAIProviderSetup:
+ // Unjustified type cast. FIXME
PluginPlaceholder as ComponentType<MetabaseAIProviderSetupProps>,
});
diff --git a/frontend/src/metabase/plugins/oss/model-persistence.ts b/frontend/src/metabase/plugins/oss/model-persistence.ts
index 21797a0dfd2..1c390b73c45 100644
--- a/frontend/src/metabase/plugins/oss/model-persistence.ts
+++ b/frontend/src/metabase/plugins/oss/model-persistence.ts
@@ -4,6 +4,7 @@ import type { ModelCacheRefreshStatus } from "metabase-types/api";
const getDefaultPluginModelPersistence = () => ({
isModelLevelPersistenceEnabled: () => false,
+ // Unjustified type cast. FIXME
ModelCacheToggle: PluginPlaceholder as ({
persistedModel,
model,
diff --git a/frontend/src/metabase/plugins/oss/moderation.ts b/frontend/src/metabase/plugins/oss/moderation.ts
index 597b4cc8d68..b7cf6863e3f 100644
--- a/frontend/src/metabase/plugins/oss/moderation.ts
+++ b/frontend/src/metabase/plugins/oss/moderation.ts
@@ -30,11 +30,13 @@ const getDefaultPluginModeration = () => ({
getStatusIcon: (_moderated_status?: string): string | IconProps | undefined =>
undefined,
getModerationTimelineEvents: (_reviews: any, _currentUser: BaseUser | null) =>
+ // Unjustified type cast. FIXME
[] as RevisionOrModerationEvent[],
useDashboardMenuItems: (_model?: Dashboard, _reload?: () => void) => [],
useQuestionMenuItems: (_model?: Question, _reload?: () => void) => [],
useCardMenuItems: (_model?: Card, _reload?: () => void) => [],
MetabotVerifiedContentConfigurationPane:
+ // Unjustified type cast. FIXME
PluginPlaceholder as React.ComponentType<{ metabot: MetabotInfo }>,
});
diff --git a/frontend/src/metabase/plugins/oss/permissions.ts b/frontend/src/metabase/plugins/oss/permissions.ts
index 44d1909ee5b..c1a04eb33bd 100644
--- a/frontend/src/metabase/plugins/oss/permissions.ts
+++ b/frontend/src/metabase/plugins/oss/permissions.ts
@@ -151,6 +151,7 @@ const getDefaultFeatureLevelPermissions = () => ({
permissionView?: "group" | "database";
showTransformPermissions?: boolean;
}) => {
+ // Unjustified type cast. FIXME
return [] as any;
},
getDataColumns: ({
@@ -163,11 +164,14 @@ const getDefaultFeatureLevelPermissions = () => ({
groupType?: SpecialGroupType;
isExternal?: boolean;
showTransformPermissions?: boolean;
+ // Unjustified type cast. FIXME
}) => [] as any,
getDownloadWidgetMessageOverride: (_result: Dataset): string | null => null,
canDownloadResults: (_result: Dataset): boolean => true,
canAccessDataModel: (state: State): boolean => getUserIsAdmin(state),
+ // Unjustified type cast. FIXME
dataModelQueryProps: {} as any,
+ // Unjustified type cast. FIXME
databaseDetailsQueryProps: {} as any,
});
@@ -176,6 +180,7 @@ export const PLUGIN_FEATURE_LEVEL_PERMISSIONS =
const getDefaultAdminPermissionsTabs = () => ({
getRoutes: (): ReactNode => null,
+ // Unjustified type cast. FIXME
tabs: [] as { name: string; value: string }[],
});
@@ -183,6 +188,7 @@ export const PLUGIN_ADMIN_PERMISSIONS_TABS = getDefaultAdminPermissionsTabs();
const getDefaultApplicationPermissions = () => ({
getRoutes: (): ReactNode => null,
+ // Unjustified type cast. FIXME
tabs: [] as any,
selectors: {
canAccessSettings: (_state: any) => false,
@@ -194,6 +200,7 @@ export const PLUGIN_APPLICATION_PERMISSIONS =
getDefaultApplicationPermissions();
const getDefaultGroupManagers = (): PluginGroupManagersType => ({
+ // Unjustified type cast. FIXME
UserTypeToggle: () => null as any,
UserTypeCell: null,
diff --git a/frontend/src/metabase/plugins/oss/remote-sync.ts b/frontend/src/metabase/plugins/oss/remote-sync.ts
index e690a795f69..3bd9ea662e7 100644
--- a/frontend/src/metabase/plugins/oss/remote-sync.ts
+++ b/frontend/src/metabase/plugins/oss/remote-sync.ts
@@ -64,10 +64,14 @@ const getDefaultPluginRemoteSync = () => ({
LibraryNav: PluginPlaceholder,
RemoteSyncSettings: NotFoundPlaceholder,
SyncedCollectionsSidebarSection: PluginPlaceholder,
+ // Unjustified type cast. FIXME
GitSyncAppBarControls: PluginPlaceholder as ComponentType,
+ // Unjustified type cast. FIXME
GitSettingsModal: PluginPlaceholder as ComponentType<GitSettingsModalProps>,
GitSyncSetupMenuItem: PluginPlaceholder,
+ // Unjustified type cast. FIXME
CollectionsNavTree: null as ComponentType<CollectionsNavTreeProps> | null,
+ // Unjustified type cast. FIXME
CollectionSyncStatusBadge: null as ComponentType | null,
REMOTE_SYNC_INVALIDATION_TAGS: null,
useSyncStatus: () => ({
@@ -82,6 +86,7 @@ const getDefaultPluginRemoteSync = () => ({
useHasTransformDirtyChanges: () => false,
getIsRemoteSyncReadOnly: () => false,
useRemoteSyncDirtyState: () =>
+ // Unjustified type cast. FIXME
({
isCollectionDirty: false,
}) as unknown as RemoteSyncDirtyState,
diff --git a/frontend/src/metabase/plugins/oss/snippets.ts b/frontend/src/metabase/plugins/oss/snippets.ts
index ebc85fcce64..2bf21bbace1 100644
--- a/frontend/src/metabase/plugins/oss/snippets.ts
+++ b/frontend/src/metabase/plugins/oss/snippets.ts
@@ -59,9 +59,12 @@ export type SnippetFoldersPlugin = {
export const getDefaultPluginSnippetFolders = () => ({
isEnabled: false,
CollectionPickerModal:
+ // Unjustified type cast. FIXME
PluginPlaceholder as ComponentType<SnippetCollectionPickerModalProps>,
CollectionPermissionsModal:
+ // Unjustified type cast. FIXME
PluginPlaceholder as ComponentType<SnippetCollectionPermissionsModalProps>,
+ // Unjustified type cast. FIXME
MoveSnippetModal: PluginPlaceholder as ComponentType<MoveSnippetModalProps>,
});
diff --git a/frontend/src/metabase/plugins/oss/tenants.ts b/frontend/src/metabase/plugins/oss/tenants.ts
index 275b6933044..aa18bfa6f1a 100644
--- a/frontend/src/metabase/plugins/oss/tenants.ts
+++ b/frontend/src/metabase/plugins/oss/tenants.ts
@@ -48,8 +48,11 @@ const getDefaultPluginTenants = () => ({
isLoading: false,
error: undefined,
}),
+ // Unjustified type cast. FIXME
userStrategyRoute: null as React.ReactElement | null,
+ // Unjustified type cast. FIXME
tenantsRoutes: null as React.ReactElement | null,
+ // Unjustified type cast. FIXME
CreateTenantsOnboardingStep: PluginPlaceholder as React.ComponentType<{
onTenantsCreated?: (tenants: CreatedTenantData[]) => void;
tenants: CreatedTenantData[];
@@ -58,6 +61,7 @@ const getDefaultPluginTenants = () => ({
strategy?: DataSegregationStrategy | null;
rlsColumnName?: string | null;
}>,
+ // Unjustified type cast. FIXME
TenantsSummaryOnboardingStep: PluginPlaceholder as React.ComponentType<{
tenants: CreatedTenantData[];
strategy?: DataSegregationStrategy | null;
@@ -65,47 +69,62 @@ const getDefaultPluginTenants = () => ({
rlsColumnName?: string | null;
}>,
EditUserStrategySettingsButton: PluginPlaceholder,
+ // Unjustified type cast. FIXME
FormTenantWidget: (_props: any) => null as React.ReactElement | null,
+ // Unjustified type cast. FIXME
TenantDisplayName: (_props: any) => null as React.ReactElement | null,
isExternalUsersGroup: (_group: Pick<Group, "magic_group_type">) => false,
isTenantGroup: (_group: Pick<Group, "is_tenant_group">) => false,
isExternalUser: (_user?: Pick<User, "tenant_id">) => false,
isTenantCollection: (_collection: Partial<Pick<Collection, "namespace">>) =>
false,
+ // Unjustified type cast. FIXME
PeopleNav: null as React.ReactElement | null,
ReactivateExternalUserButton: ({ user: _user }: { user: User }) =>
+ // Unjustified type cast. FIXME
null as React.ReactElement | null,
TenantGroupHintIcon: PluginPlaceholder,
+ // Unjustified type cast. FIXME
MainNavSharedCollections: PluginPlaceholder as React.ComponentType<{
canAccessTenantSpecificCollections: boolean;
canCreateSharedCollection: boolean;
sharedTenantCollections: Collection[] | undefined;
}>,
TenantCollectionItemList: (_props: { pathIndex: number }) =>
+ // Unjustified type cast. FIXME
null as React.ReactElement | null,
TenantSpecificCollectionsItemList: (_props: { pathIndex: number }) =>
+ // Unjustified type cast. FIXME
null as React.ReactElement | null,
TenantCollectionList: PluginPlaceholder,
+ // Unjustified type cast. FIXME
CanAccessTenantSpecificRoute: PluginPlaceholder as React.ComponentType<{
children: React.ReactNode;
}>,
TenantUsersList: PluginPlaceholder,
+ // Unjustified type cast. FIXME
TenantUsersPersonalCollectionList: PluginPlaceholder as React.ComponentType<{
params: { tenantId: string };
}>,
GroupDescription: (_props: { group: Group }) =>
+ // Unjustified type cast. FIXME
null as React.ReactElement | null,
EditUserStrategyModal: PluginPlaceholder,
+ // Unjustified type cast. FIXME
getNewUserModalTitle: (_isExternal: boolean) => null as string | null,
+ // Unjustified type cast. FIXME
getFormGroupsTitle: (_isExternal: boolean) => null as string | null,
// cannot be null, because that refers to the default namespace
SHARED_TENANT_NAMESPACE: "none" as CollectionNamespace,
// cannot be null, because that refers to the default namespace
TENANT_SPECIFIC_NAMESPACE: "none" as CollectionNamespace,
canPlaceEntityInCollection: () => true,
+ // Unjustified type cast. FIXME
getRootCollectionItem: () => null as OmniPickerCollectionItem | null,
+ // Unjustified type cast. FIXME
getTenantRootDisabledReason: () => null as string | null,
getNamespaceDisplayName: (_namespace?: CollectionNamespace) =>
+ // Unjustified type cast. FIXME
null as string | null,
getFlattenedCollectionsForNavbar: () => [],
useTenantMainNavbarData: () => ({
diff --git a/frontend/src/metabase/plugins/oss/upload-management.ts b/frontend/src/metabase/plugins/oss/upload-management.ts
index ade45a72f0f..fdc1bc451cd 100644
--- a/frontend/src/metabase/plugins/oss/upload-management.ts
+++ b/frontend/src/metabase/plugins/oss/upload-management.ts
@@ -18,9 +18,11 @@ const getDefaultPluginUploadManagement = () => ({
UploadManagementTable: PluginPlaceholder,
GdriveSyncStatus: PluginPlaceholder,
GdriveConnectionModal:
+ // Unjustified type cast. FIXME
PluginPlaceholder as ComponentType<GdriveConnectionModalProps>,
GdriveDbMenu: PluginPlaceholder,
GdriveAddDataPanel:
+ // Unjustified type cast. FIXME
PluginPlaceholder as ComponentType<GdriveAddDataPanelProps>,
});
diff --git a/frontend/src/metabase/public/containers/PublicAction/PublicAction.tsx b/frontend/src/metabase/public/containers/PublicAction/PublicAction.tsx
index 5c64152531b..629a1a8127a 100644
--- a/frontend/src/metabase/public/containers/PublicAction/PublicAction.tsx
+++ b/frontend/src/metabase/public/containers/PublicAction/PublicAction.tsx
@@ -41,6 +41,7 @@ function PublicAction({ action, publicId, onError }: Props) {
);
setSubmitted(true);
} catch (error) {
+ // Unjustified type cast. FIXME
onError(error as AppErrorDescriptor);
}
},
diff --git a/frontend/src/metabase/public/containers/PublicDocument/PublicDocument.tsx b/frontend/src/metabase/public/containers/PublicDocument/PublicDocument.tsx
index c3f3ef9bcb5..0407e9ca362 100644
--- a/frontend/src/metabase/public/containers/PublicDocument/PublicDocument.tsx
+++ b/frontend/src/metabase/public/containers/PublicDocument/PublicDocument.tsx
@@ -58,6 +58,7 @@ export const PublicDocument = ({ location, params }: PublicDocumentProps) => {
dispatch,
publicApi.endpoints.getPublicDocument,
);
+ // Unjustified type cast. FIXME
return doc as Document;
}, [uuid, dispatch]);
diff --git a/frontend/src/metabase/public/containers/PublicOrEmbeddedDashboard/PublicOrEmbeddedDashboardView-card-filters.stories.tsx b/frontend/src/metabase/public/containers/PublicOrEmbeddedDashboard/PublicOrEmbeddedDashboardView-card-filters.stories.tsx
index e4074697b6a..df6abeaacae 100644
--- a/frontend/src/metabase/public/containers/PublicOrEmbeddedDashboard/PublicOrEmbeddedDashboardView-card-filters.stories.tsx
+++ b/frontend/src/metabase/public/containers/PublicOrEmbeddedDashboard/PublicOrEmbeddedDashboardView-card-filters.stories.tsx
@@ -57,6 +57,7 @@ export default {
};
function ReduxDecorator(Story: StoryFn, context: StoryContext) {
+ // Unjustified type cast. FIXME
const dashboard = context.args.dashboard as Dashboard;
const initialState = createMockState({
settings: createMockSettingsState({
diff --git a/frontend/src/metabase/public/containers/PublicOrEmbeddedDashboard/PublicOrEmbeddedDashboardView-filters.stories.tsx b/frontend/src/metabase/public/containers/PublicOrEmbeddedDashboard/PublicOrEmbeddedDashboardView-filters.stories.tsx
index 6a2544db5e1..7a8bacce0dd 100644
--- a/frontend/src/metabase/public/containers/PublicOrEmbeddedDashboard/PublicOrEmbeddedDashboardView-filters.stories.tsx
+++ b/frontend/src/metabase/public/containers/PublicOrEmbeddedDashboard/PublicOrEmbeddedDashboardView-filters.stories.tsx
@@ -81,7 +81,9 @@ export default {
};
function ReduxDecorator(Story: StoryFn, context: StoryContext) {
+ // Unjustified type cast. FIXME
const dashboard = context.args.dashboard as Dashboard;
+ // Unjustified type cast. FIXME
const parameterType = context.args.parameterType as ParameterType;
const initialState = createMockState({
settings: createMockSettingsState({
@@ -394,6 +396,7 @@ const createDefaultArgs = ({
};
function getLastPopover() {
+ // Unjustified type cast. FIXME
const lastPopover = Array.from(
document.documentElement.querySelectorAll(
'[data-element-id="mantine-popover"]',
@@ -404,6 +407,7 @@ function getLastPopover() {
}
function getLastPopoverElement() {
+ // Unjustified type cast. FIXME
const lastPopover = Array.from(
document.documentElement.querySelectorAll(
'[data-element-id="mantine-popover"]',
@@ -474,6 +478,7 @@ export const LightThemeParameterSearchWithValue = {
await userEvent.type(searchInput, "g");
const dropdown = getLastPopover();
+ // Unjustified type cast. FIXME
(dropdown.getByText("Gadget").parentNode as HTMLElement).setAttribute(
"data-hovered",
"true",
@@ -592,6 +597,7 @@ export const LightThemeParameterListSingleWithValue = {
);
await userEvent.click(documentElement.getByText("Widget"));
const popover = getLastPopover();
+ // Unjustified type cast. FIXME
(popover.getByText("Gadget").parentNode as HTMLElement).classList.add(
"pseudo-hover",
);
@@ -880,6 +886,7 @@ export const LightThemeUnitOfTime = {
await userEvent.click(filter);
const popover = getLastPopover();
+ // Unjustified type cast. FIXME
(popover.getByText("Hour").parentNode as HTMLElement).classList.add(
"pseudo-hover",
);
diff --git a/frontend/src/metabase/public/containers/PublicOrEmbeddedDashboard/PublicOrEmbeddedDashboardView-pdf-export.stories.tsx b/frontend/src/metabase/public/containers/PublicOrEmbeddedDashboard/PublicOrEmbeddedDashboardView-pdf-export.stories.tsx
index 1e3d6058dc5..25f99229e2b 100644
--- a/frontend/src/metabase/public/containers/PublicOrEmbeddedDashboard/PublicOrEmbeddedDashboardView-pdf-export.stories.tsx
+++ b/frontend/src/metabase/public/containers/PublicOrEmbeddedDashboard/PublicOrEmbeddedDashboardView-pdf-export.stories.tsx
@@ -63,6 +63,7 @@ const DASHCARD_MAP_ID = getNextId();
const CARD_MAP_ID = getNextId();
function ReduxDecorator(Story: StoryFn, context: StoryContext) {
+ // Unjustified type cast. FIXME
const dashboard = (context.args.dashboard as Dashboard) ?? createDashboard();
const initialState = createMockState({
currentUser: null,
diff --git a/frontend/src/metabase/public/containers/PublicOrEmbeddedDashboard/PublicOrEmbeddedDashboardView.stories.tsx b/frontend/src/metabase/public/containers/PublicOrEmbeddedDashboard/PublicOrEmbeddedDashboardView.stories.tsx
index a04ced55127..0643bc3c914 100644
--- a/frontend/src/metabase/public/containers/PublicOrEmbeddedDashboard/PublicOrEmbeddedDashboardView.stories.tsx
+++ b/frontend/src/metabase/public/containers/PublicOrEmbeddedDashboard/PublicOrEmbeddedDashboardView.stories.tsx
@@ -66,6 +66,7 @@ export default {
};
function ReduxDecorator(Story: StoryFn, context: StoryContext) {
+ // Unjustified type cast. FIXME
const dashboard = (context.args.dashboard as Dashboard) ?? createDashboard();
const initialState = createMockState({
currentUser: null,
diff --git a/frontend/src/metabase/public/containers/PublicOrEmbeddedQuestion/PublicOrEmbeddedQuestion/PublicOrEmbeddedQuestion.tsx b/frontend/src/metabase/public/containers/PublicOrEmbeddedQuestion/PublicOrEmbeddedQuestion/PublicOrEmbeddedQuestion.tsx
index 8ecfa395757..22eb8071e3b 100644
--- a/frontend/src/metabase/public/containers/PublicOrEmbeddedQuestion/PublicOrEmbeddedQuestion/PublicOrEmbeddedQuestion.tsx
+++ b/frontend/src/metabase/public/containers/PublicOrEmbeddedQuestion/PublicOrEmbeddedQuestion/PublicOrEmbeddedQuestion.tsx
@@ -171,6 +171,7 @@ export const PublicOrEmbeddedQuestion = ({
throw { status: 404 };
}
+ // Unjustified type cast. FIXME
const newResult = (await fetchDataOrError(resultPromise)) as
| Dataset
| { error: unknown };
@@ -179,6 +180,7 @@ export const PublicOrEmbeddedQuestion = ({
if (typeof newResult.error === "object") {
dispatch(setErrorPage(newResult.error));
} else {
+ // Unjustified type cast. FIXME
setResult(newResult as Dataset);
}
} catch (error) {
diff --git a/frontend/src/metabase/public/containers/PublicOrEmbeddedQuestion/PublicOrEmbeddedQuestionView.stories.tsx b/frontend/src/metabase/public/containers/PublicOrEmbeddedQuestion/PublicOrEmbeddedQuestionView.stories.tsx
index 0a086d9be4b..2d9e3d1843e 100644
--- a/frontend/src/metabase/public/containers/PublicOrEmbeddedQuestion/PublicOrEmbeddedQuestionView.stories.tsx
+++ b/frontend/src/metabase/public/containers/PublicOrEmbeddedQuestion/PublicOrEmbeddedQuestionView.stories.tsx
@@ -223,6 +223,7 @@ export const PivotTableLightTheme = {
play: async ({ canvasElement }: { canvasElement: HTMLCanvasElement }) => {
const cell = await within(canvasElement).findByText("field-123");
+ // Unjustified type cast. FIXME
(cell.parentNode?.parentNode as HTMLElement).classList.add("pseudo-hover");
},
};
@@ -356,6 +357,7 @@ export const SmartScalarLightThemeTooltip = {
const value = "vs. July 21, 2024, 12:00 AM";
const valueElement = await within(canvasElement).findByText(value);
await userEvent.hover(valueElement);
+ // Unjustified type cast. FIXME
const tooltip = document.documentElement.querySelector(
'[role="tooltip"]',
) as HTMLElement;
@@ -388,10 +390,12 @@ export const TableLightTheme = {
card: createMockCard({
id: getNextId(),
display: "table",
+ // Unjustified type cast. FIXME
...(TABLE_MOCK_DATA.variousColumnSettings[0].card as any),
}),
result: createMockDataset({
data: createMockDatasetData(
+ // Unjustified type cast. FIXME
TABLE_MOCK_DATA.variousColumnSettings[0].data as any,
),
}),
diff --git a/frontend/src/metabase/public/containers/PublicOrEmbeddedQuestion/PublicOrEmbeddedQuestionView.tsx b/frontend/src/metabase/public/containers/PublicOrEmbeddedQuestion/PublicOrEmbeddedQuestionView.tsx
index 93dff767bf6..cd36f25d6b6 100644
--- a/frontend/src/metabase/public/containers/PublicOrEmbeddedQuestion/PublicOrEmbeddedQuestionView.tsx
+++ b/frontend/src/metabase/public/containers/PublicOrEmbeddedQuestion/PublicOrEmbeddedQuestionView.tsx
@@ -75,6 +75,7 @@ export function PublicOrEmbeddedQuestionView({
/>
) : null;
+ // Unjustified type cast. FIXME
const untranslatedRawSeries = [{ card, data: result?.data }] as RawSeries;
const rawSeries = PLUGIN_CONTENT_TRANSLATION.useTranslateSeries(
untranslatedRawSeries,
diff --git a/frontend/src/metabase/public/hooks/use-embed-frame-options.ts b/frontend/src/metabase/public/hooks/use-embed-frame-options.ts
index 577f8daa3db..e7e690c6c5e 100644
--- a/frontend/src/metabase/public/hooks/use-embed-frame-options.ts
+++ b/frontend/src/metabase/public/hooks/use-embed-frame-options.ts
@@ -19,6 +19,7 @@ export const useEmbedFrameOptions = ({ location }: { location: Location }) => {
hide_download_button = null,
downloads = DEFAULT_EMBED_DISPLAY_PARAMS.downloadsEnabled,
locale,
+ // Unjustified type cast. FIXME
} = parseHashOptions(location.hash) as EmbeddingHashOptions & {
// this parameter is not supported anymore, but we access it in this hook to log an error
hide_download_button?: boolean | null;
diff --git a/frontend/src/metabase/public/hooks/use-set-embed-font.ts b/frontend/src/metabase/public/hooks/use-set-embed-font.ts
index cad240dd9a1..4cf4e33b37a 100644
--- a/frontend/src/metabase/public/hooks/use-set-embed-font.ts
+++ b/frontend/src/metabase/public/hooks/use-set-embed-font.ts
@@ -10,6 +10,7 @@ export const useSetEmbedFont = ({ location }: { location: Location }) => {
const dispatch = useDispatch();
useEffect(() => {
+ // Unjustified type cast. FIXME
const { font } = parseHashOptions(location.hash) as EmbeddingHashOptions;
dispatch(
diff --git a/frontend/src/metabase/public/hooks/use-set-embed-font.unit.spec.tsx b/frontend/src/metabase/public/hooks/use-set-embed-font.unit.spec.tsx
index 0b0b56abb46..2370ed00059 100644
--- a/frontend/src/metabase/public/hooks/use-set-embed-font.unit.spec.tsx
+++ b/frontend/src/metabase/public/hooks/use-set-embed-font.unit.spec.tsx
@@ -23,6 +23,7 @@ const setup = ({ location }: { location: Location }) => {
});
const getEmbedOptionsState = () =>
+ // Unjustified type cast. FIXME
(store.getState().embed as EmbedState).options;
return { result, rerender, getEmbedOptionsState };
@@ -31,12 +32,14 @@ const setup = ({ location }: { location: Location }) => {
describe("useSetEmbedFont", () => {
it("sets and updates font", () => {
const { rerender, getEmbedOptionsState } = setup({
+ // Unjustified type cast. FIXME
location: { hash: "#font=Roboto" } as Location,
});
expect(getEmbedOptionsState().font).toBe("Roboto");
rerender({
+ // Unjustified type cast. FIXME
location: { hash: "" } as Location,
});
diff --git a/frontend/src/metabase/query_builder/actions/core/card.ts b/frontend/src/metabase/query_builder/actions/core/card.ts
index d1a00887882..684222dfa73 100644
--- a/frontend/src/metabase/query_builder/actions/core/card.ts
+++ b/frontend/src/metabase/query_builder/actions/core/card.ts
@@ -15,6 +15,7 @@ export async function loadCard(
{ dispatch }: { dispatch: Dispatch; getState: GetState },
) {
try {
+ // Unjustified type cast. FIXME
const result = (await dispatch(
cardApi.endpoints.getCard.initiate({ id: token ?? cardId }),
)) as { data?: Card; error?: unknown };
diff --git a/frontend/src/metabase/query_builder/actions/core/core.ts b/frontend/src/metabase/query_builder/actions/core/core.ts
index 172e50b28ca..6416b2d26fb 100644
--- a/frontend/src/metabase/query_builder/actions/core/core.ts
+++ b/frontend/src/metabase/query_builder/actions/core/core.ts
@@ -379,6 +379,7 @@ async function reduxCreateQuestion(
) {
const display = question.display();
const size = getDefaultSize(display);
+ // Unjustified type cast. FIXME
const card = (await dispatch(
createQuestionCard({
...question.card(),
@@ -403,6 +404,7 @@ async function reduxUpdateQuestion(
const card = _.omit(fullCard, ...keysToOmit);
+ // Unjustified type cast. FIXME
const updatedCard = (await dispatch(
updateQuestionCard({ id: question.id(), ...card }),
)) as Card;
diff --git a/frontend/src/metabase/query_builder/actions/core/initializeQB.ts b/frontend/src/metabase/query_builder/actions/core/initializeQB.ts
index c741c510f85..d08beb77c1f 100644
--- a/frontend/src/metabase/query_builder/actions/core/initializeQB.ts
+++ b/frontend/src/metabase/query_builder/actions/core/initializeQB.ts
@@ -216,6 +216,7 @@ export async function resolveCards({
return cardId
? fetchAndPrepareSavedQuestionCards({ cardId, token }, dispatch, getState)
: fetchAndPrepareAdHocQuestionCards(
+ // Unjustified type cast. FIXME
deserializedCard as Card,
dispatch,
getState,
@@ -250,6 +251,7 @@ export async function updateTemplateTagNames(
query = updateCardTemplateTagNames(query, referencedCards);
if (query.hasSnippets()) {
+ // Unjustified type cast. FIXME
const action = (dispatch as DispatchFn)(
snippetApi.endpoints.listSnippets.initiate(undefined, {
forceRefetch: true,
@@ -444,6 +446,7 @@ async function handleQBInit(
}
if (isNative && isEditable) {
+ // Unjustified type cast. FIXME
const query = question.legacyNativeQuery() as NativeQuery;
const newQuery = await updateTemplateTagNames(query, getState, dispatch);
question = question.setLegacyQuery(newQuery);
diff --git a/frontend/src/metabase/query_builder/actions/core/initializeQB.unit.spec.ts b/frontend/src/metabase/query_builder/actions/core/initializeQB.unit.spec.ts
index 17e5967a61e..ae124eff7b6 100644
--- a/frontend/src/metabase/query_builder/actions/core/initializeQB.unit.spec.ts
+++ b/frontend/src/metabase/query_builder/actions/core/initializeQB.unit.spec.ts
@@ -147,6 +147,7 @@ async function setup({
jest
.spyOn(cardActions, "loadCard")
+ // Unjustified type cast. FIXME
.mockReturnValue(Promise.resolve({ ...card } as Card));
return baseSetup({ location, params, ...opts });
@@ -317,6 +318,7 @@ describe("QB Actions > initializeQB", () => {
it("sets original card id on the card", async () => {
const { result } = await setup({ card });
+ // Unjustified type cast. FIXME
expect(result.card.original_card_id).toBe((card as Card).id);
});
@@ -435,6 +437,7 @@ describe("QB Actions > initializeQB", () => {
const ORIGINAL_CARD_ID = 321;
function getOriginalQuestionCard(opts?: Partial<Card>): Card {
+ // Unjustified type cast. FIXME
return {
...card,
...opts,
@@ -456,6 +459,7 @@ describe("QB Actions > initializeQB", () => {
jest
.spyOn(cardActions, "loadCard")
+ // Unjustified type cast. FIXME
.mockReturnValueOnce(Promise.resolve({ ...originalCard } as Card));
return setup({ card: q, ...opts });
@@ -628,6 +632,7 @@ describe("QB Actions > initializeQB", () => {
const initiateSpy = jest
.spyOn(snippetApi.endpoints.listSnippets, "initiate")
+ // Unjustified type cast. FIXME
.mockReturnValue({
unwrap: () => Promise.resolve(snippet ? [snippet] : []),
unsubscribe: jest.fn(),
@@ -661,11 +666,13 @@ describe("QB Actions > initializeQB", () => {
it("replaces snippet names with fresh ones from the backend", async () => {
const { result, metadata } = await setupSnippets({
snippet: {
+ // Unjustified type cast. FIXME
id: SNIPPET["snippet-id"] as number,
name: "bar",
},
});
const formattedQuestion = new Question(result.card, metadata);
+ // Unjustified type cast. FIXME
const query = formattedQuestion.legacyNativeQuery() as NativeQuery;
expect(query.queryText().toLowerCase()).toBe(
@@ -715,6 +722,7 @@ describe("QB Actions > initializeQB", () => {
jest
.spyOn(cardActions, "loadCard")
.mockReturnValueOnce(firstLoadPromise)
+ // Unjustified type cast. FIXME
.mockReturnValueOnce(Promise.resolve(secondCard as Card));
fetchMock.get(`path:/api/card/${firstCard.id}`, firstCard);
@@ -767,6 +775,7 @@ describe("QB Actions > initializeQB", () => {
jest
.spyOn(cardActions, "loadCard")
.mockReturnValueOnce(firstLoadPromise)
+ // Unjustified type cast. FIXME
.mockReturnValueOnce(Promise.resolve(secondCard as Card));
fetchMock.get(`path:/api/card/${firstCard.id}`, firstCard);
diff --git a/frontend/src/metabase/query_builder/actions/core/parameterUtils.ts b/frontend/src/metabase/query_builder/actions/core/parameterUtils.ts
index 3ab4bffbb55..2f049644b1b 100644
--- a/frontend/src/metabase/query_builder/actions/core/parameterUtils.ts
+++ b/frontend/src/metabase/query_builder/actions/core/parameterUtils.ts
@@ -125,8 +125,11 @@ export async function propagateDashboardParameters({
await verifyMatchingDashcardAndParameters({
dispatch,
cardId,
+ // Unjustified type cast. FIXME
dashboardId: dashboardId as number,
+ // Unjustified type cast. FIXME
dashcardId: dashcardId as number,
+ // Unjustified type cast. FIXME
parameters: parameters as Parameter[],
});
card.parameters = parameters;
diff --git a/frontend/src/metabase/query_builder/actions/core/updateQuestion.ts b/frontend/src/metabase/query_builder/actions/core/updateQuestion.ts
index 47e969dfed7..84dbff8f75d 100644
--- a/frontend/src/metabase/query_builder/actions/core/updateQuestion.ts
+++ b/frontend/src/metabase/query_builder/actions/core/updateQuestion.ts
@@ -51,12 +51,14 @@ function shouldTemplateTagEditorBeVisible({
).isNative;
const previousTags = isCurrentQuestionNative
- ? (
+ ? // Unjustified type cast. FIXME
+ (
currentQuestion.legacyNativeQuery() as NativeQuery
).variableTemplateTags()
: [];
const nextTags = isNewQuestionNative
- ? (newQuestion.legacyNativeQuery() as NativeQuery).variableTemplateTags()
+ ? // Unjustified type cast. FIXME
+ (newQuestion.legacyNativeQuery() as NativeQuery).variableTemplateTags()
: [];
if (nextTags.length > previousTags.length) {
return true;
diff --git a/frontend/src/metabase/query_builder/actions/core/updateQuestion.unit.spec.ts b/frontend/src/metabase/query_builder/actions/core/updateQuestion.unit.spec.ts
index 4b14af430fb..e927b56d6d8 100644
--- a/frontend/src/metabase/query_builder/actions/core/updateQuestion.unit.spec.ts
+++ b/frontend/src/metabase/query_builder/actions/core/updateQuestion.unit.spec.ts
@@ -120,6 +120,7 @@ async function setup({
shouldStartAdHocQuestion,
}: SetupOpts) {
const isSavedCard = "id" in card;
+ // Unjustified type cast. FIXME
const isModel = (card as Card).type === "model";
const dispatch = jest.fn().mockReturnValue({ mock: "mock" });
@@ -131,6 +132,7 @@ async function setup({
const entitiesState = createMockEntitiesState({
databases: [createSampleDatabase(), SAVED_QUESTIONS_DB],
+ // Unjustified type cast. FIXME
tables: isModel ? [getModelVirtualTable(card as Card)] : [],
questions: cards,
});
@@ -591,6 +593,7 @@ describe("QB Actions > updateQuestion", () => {
await setup({
card: cardWithJoin,
+ // Unjustified type cast. FIXME
originalCard: originalCard as Card,
});
@@ -676,6 +679,7 @@ describe("QB Actions > updateQuestion", () => {
...opts,
card: cardWithTags,
originalCard,
+ // Unjustified type cast. FIXME
queryBuilderMode: (card as Card).type === "model" ? "dataset" : "view",
});
diff --git a/frontend/src/metabase/query_builder/actions/native.ts b/frontend/src/metabase/query_builder/actions/native.ts
index 2c75c38830e..fe760733cd4 100644
--- a/frontend/src/metabase/query_builder/actions/native.ts
+++ b/frontend/src/metabase/query_builder/actions/native.ts
@@ -122,6 +122,7 @@ export const insertSnippet =
if (!question) {
return;
}
+ // Unjustified type cast. FIXME
const query = question.legacyNativeQuery() as NativeQuery;
const queryText = query.queryText();
const nativeEditorCursorOffset =
@@ -147,6 +148,7 @@ export const setTemplateTag = createThunkAction(
if (!question) {
return;
}
+ // Unjustified type cast. FIXME
const query = question.legacyNativeQuery() as NativeQuery;
const newQuestion = query.setTemplateTag(tag.name, tag).question();
dispatch(updateQuestion(newQuestion));
@@ -163,6 +165,7 @@ export const setTemplateTagConfig = createThunkAction(
if (!question) {
return;
}
+ // Unjustified type cast. FIXME
const query = question.legacyNativeQuery() as NativeQuery;
const newQuestion = query
.setTemplateTagConfig(tag, parameterConfig)
diff --git a/frontend/src/metabase/query_builder/actions/navigation.unit.spec.ts b/frontend/src/metabase/query_builder/actions/navigation.unit.spec.ts
index 99c1099dee5..ec2a7fb9d14 100644
--- a/frontend/src/metabase/query_builder/actions/navigation.unit.spec.ts
+++ b/frontend/src/metabase/query_builder/actions/navigation.unit.spec.ts
@@ -8,6 +8,7 @@ import * as initializeQBModule from "./core/initializeQB";
import { locationChanged } from "./navigation";
const loc = (over: Partial<Location> = {}): Location =>
+ // Unjustified type cast. FIXME
({
pathname: "/question/1",
search: "",
@@ -28,6 +29,7 @@ describe("locationChanged", () => {
dispatch = jest.fn();
initSpy = jest
.spyOn(initializeQBModule, "initializeQB")
+ // Unjustified type cast. FIXME
.mockReturnValue({ type: "MOCK_INIT" } as any);
});
diff --git a/frontend/src/metabase/query_builder/actions/object-detail.ts b/frontend/src/metabase/query_builder/actions/object-detail.ts
index cf9bd20ef23..1fbc792cebf 100644
--- a/frontend/src/metabase/query_builder/actions/object-detail.ts
+++ b/frontend/src/metabase/query_builder/actions/object-detail.ts
@@ -142,6 +142,7 @@ export const loadObjectDetailFKReferences = createThunkAction(
const aggregatedQuery = Lib.aggregateByCount(baseQuery, -1);
const query = filterByFk(
aggregatedQuery,
+ // Unjustified type cast. FIXME
fk.origin.getPlainObject() as Field,
objectId,
);
diff --git a/frontend/src/metabase/query_builder/components/DatasetEditor/DatasetEditorInner.tsx b/frontend/src/metabase/query_builder/components/DatasetEditor/DatasetEditorInner.tsx
index 02c787f3028..67bea2314d8 100644
--- a/frontend/src/metabase/query_builder/components/DatasetEditor/DatasetEditorInner.tsx
+++ b/frontend/src/metabase/query_builder/components/DatasetEditor/DatasetEditorInner.tsx
@@ -252,6 +252,7 @@ function getSidebar(
// @ts-expect-error Multiple types missing, but handled inside TagEditorSidebar
<TagEditorSidebar
{...props}
+ // Unjustified type cast. FIXME
query={question.legacyNativeQuery() as NativeQuery}
onClose={toggleTemplateTagsEditor}
/>
@@ -283,6 +284,7 @@ function getTempRawSeries(
return rawSeries;
}
+ // Unjustified type cast. FIXME
return [
{
...rawSeries[0],
@@ -327,6 +329,7 @@ const DatasetEditorInnerView = (props: DatasetEditorInnerProps) => {
const fields = useMemo(
() =>
getSortedModelFields(
+ // Unjustified type cast. FIXME
(resultsMetadata?.columns as unknown as Field[]) ?? [],
visualizationSettings ?? {},
),
@@ -671,6 +674,7 @@ const DatasetEditorInnerView = (props: DatasetEditorInnerProps) => {
<EditBar
className={DatasetEditorS.DatasetEditBar}
data-testid="dataset-edit-bar"
+ // Unjustified type cast. FIXME
title={question.displayName() as string}
center={
<EditorTabs
diff --git a/frontend/src/metabase/query_builder/components/DatasetEditor/DatasetFieldMetadataSidebar/MappedFieldPicker/MappedFieldPicker.tsx b/frontend/src/metabase/query_builder/components/DatasetEditor/DatasetFieldMetadataSidebar/MappedFieldPicker/MappedFieldPicker.tsx
index 5db886d51ed..1035fbe3c04 100644
--- a/frontend/src/metabase/query_builder/components/DatasetEditor/DatasetFieldMetadataSidebar/MappedFieldPicker/MappedFieldPicker.tsx
+++ b/frontend/src/metabase/query_builder/components/DatasetEditor/DatasetFieldMetadataSidebar/MappedFieldPicker/MappedFieldPicker.tsx
@@ -75,6 +75,7 @@ export function MappedFieldPicker({
}}
hasValue={!!selectedField}
tabIndex={tabIndex}
+ // Unjustified type cast. FIXME
ref={selectButtonRef as any}
onClear={() => onChange(null)}
>
diff --git a/frontend/src/metabase/query_builder/components/DatasetEditor/EditorTabs/EditorTabs.tsx b/frontend/src/metabase/query_builder/components/DatasetEditor/EditorTabs/EditorTabs.tsx
index ee75bc70e86..7caeed3dcf4 100644
--- a/frontend/src/metabase/query_builder/components/DatasetEditor/EditorTabs/EditorTabs.tsx
+++ b/frontend/src/metabase/query_builder/components/DatasetEditor/EditorTabs/EditorTabs.tsx
@@ -24,6 +24,7 @@ export function EditorTabs({
<ul
className={EditorTabsS.TabBar}
style={
+ // Unjustified type cast. FIXME
{
// TODO: Re-write this component to use actual buttons and better semantic colors
"--active-tab-color": "var(--mb-color-text-brand-hover)",
diff --git a/frontend/src/metabase/query_builder/components/ObjectDetailSidesheet.unit.spec.tsx b/frontend/src/metabase/query_builder/components/ObjectDetailSidesheet.unit.spec.tsx
index c071ab6c4d6..2b7ddf92130 100644
--- a/frontend/src/metabase/query_builder/components/ObjectDetailSidesheet.unit.spec.tsx
+++ b/frontend/src/metabase/query_builder/components/ObjectDetailSidesheet.unit.spec.tsx
@@ -62,15 +62,19 @@ function setup({ hideOrdersTable = false }: SetupOpts = {}) {
setupTableEndpoints(PRODUCTS_TABLE, [
{
origin: ordersProductId,
+ // Unjustified type cast. FIXME
origin_id: ordersProductId.id as number,
destination: productsId,
+ // Unjustified type cast. FIXME
destination_id: productsId.id as number,
relationship: "Mt1",
},
{
origin: reviewsProductId,
+ // Unjustified type cast. FIXME
origin_id: reviewsProductId.id as number,
destination: productsId,
+ // Unjustified type cast. FIXME
destination_id: productsId.id as number,
relationship: "Mt1",
},
@@ -96,6 +100,7 @@ function setup({ hideOrdersTable = false }: SetupOpts = {}) {
},
},
}),
+ // Unjustified type cast. FIXME
zoomedRowObjectId: testDataset.rows[0][ROW_ID_INDEX] as string,
queryResults: [
createMockDataset({
diff --git a/frontend/src/metabase/query_builder/components/timelines/containers/NewEventModal/NewEventModal.tsx b/frontend/src/metabase/query_builder/components/timelines/containers/NewEventModal/NewEventModal.tsx
index 29a10de41e5..4948434672b 100644
--- a/frontend/src/metabase/query_builder/components/timelines/containers/NewEventModal/NewEventModal.tsx
+++ b/frontend/src/metabase/query_builder/components/timelines/containers/NewEventModal/NewEventModal.tsx
@@ -42,11 +42,14 @@ function NewEventModalContainer({
collection?: Collection,
) => {
if (values.timeline_id) {
+ // Unjustified type cast. FIXME
await createTimelineEvent(values as CreateTimelineEventRequest).unwrap();
} else if (collection) {
const timeline = await createTimeline(
+ // Unjustified type cast. FIXME
getDefaultTimeline(collection) as CreateTimelineRequest,
).unwrap();
+ // Unjustified type cast. FIXME
await createTimelineEvent({
...values,
timeline_id: timeline.id,
diff --git a/frontend/src/metabase/query_builder/components/view/QuestionRowCount/QuestionRowCount.unit.spec.tsx b/frontend/src/metabase/query_builder/components/view/QuestionRowCount/QuestionRowCount.unit.spec.tsx
index 069f08ecbdf..f6f6302a6fb 100644
--- a/frontend/src/metabase/query_builder/components/view/QuestionRowCount/QuestionRowCount.unit.spec.tsx
+++ b/frontend/src/metabase/query_builder/components/view/QuestionRowCount/QuestionRowCount.unit.spec.tsx
@@ -51,6 +51,7 @@ function patchQuestion(question: Question) {
const nextQuery = Lib.orderBy(query, 0, sampleColumn);
return question.setQuery(nextQuery);
} else {
+ // Unjustified type cast. FIXME
const query = question.legacyNativeQuery() as NativeQuery;
return query.setQueryText("SELECT * FROM __ORDERS__").question();
}
diff --git a/frontend/src/metabase/query_builder/components/view/ViewHeader/components/QueryBuilderBackButton/QueryBuilderBackButton.tsx b/frontend/src/metabase/query_builder/components/view/ViewHeader/components/QueryBuilderBackButton/QueryBuilderBackButton.tsx
index d6939f56700..fb29979da4f 100644
--- a/frontend/src/metabase/query_builder/components/view/ViewHeader/components/QueryBuilderBackButton/QueryBuilderBackButton.tsx
+++ b/frontend/src/metabase/query_builder/components/view/ViewHeader/components/QueryBuilderBackButton/QueryBuilderBackButton.tsx
@@ -45,6 +45,7 @@ export function QueryBuilderBackButton({
return null;
}
+ // Unjustified type cast. FIXME
const url = Urls.modelToUrl(parent as Urls.UrlableModel);
if (!url) {
return null;
diff --git a/frontend/src/metabase/query_builder/components/view/ViewHeader/components/QuestionActions/QuestionActions.unit.spec.tsx b/frontend/src/metabase/query_builder/components/view/ViewHeader/components/QuestionActions/QuestionActions.unit.spec.tsx
index c835421914b..6906c21c300 100644
--- a/frontend/src/metabase/query_builder/components/view/ViewHeader/components/QuestionActions/QuestionActions.unit.spec.tsx
+++ b/frontend/src/metabase/query_builder/components/view/ViewHeader/components/QuestionActions/QuestionActions.unit.spec.tsx
@@ -84,6 +84,7 @@ function setup({
});
const metadata = getMetadata(state);
+ // Unjustified type cast. FIXME
const question = metadata.question(card.id) as Question;
const onOpenModal = jest.fn();
const onSetQueryBuilderMode = jest.fn();
diff --git a/frontend/src/metabase/query_builder/components/view/ViewHeader/components/QuestionActions/QuestionMoreActionsMenu/tests/setup.tsx b/frontend/src/metabase/query_builder/components/view/ViewHeader/components/QuestionActions/QuestionMoreActionsMenu/tests/setup.tsx
index ba99936ebc3..cb1870c89ea 100644
--- a/frontend/src/metabase/query_builder/components/view/ViewHeader/components/QuestionActions/QuestionMoreActionsMenu/tests/setup.tsx
+++ b/frontend/src/metabase/query_builder/components/view/ViewHeader/components/QuestionActions/QuestionMoreActionsMenu/tests/setup.tsx
@@ -63,6 +63,7 @@ export function setup({
const state = createMockState({
settings: mockSettings(settingValues),
+ // Unjustified type cast. FIXME
currentUser: {
...user,
permissions: {
diff --git a/frontend/src/metabase/query_builder/components/view/ViewHeader/components/QuestionDataSource/utils.tsx b/frontend/src/metabase/query_builder/components/view/ViewHeader/components/QuestionDataSource/utils.tsx
index 830cfe24866..00d33246f18 100644
--- a/frontend/src/metabase/query_builder/components/view/ViewHeader/components/QuestionDataSource/utils.tsx
+++ b/frontend/src/metabase/query_builder/components/view/ViewHeader/components/QuestionDataSource/utils.tsx
@@ -67,7 +67,8 @@ export function getDataSourceParts({
const table = !isNative
? metadata.table(Lib.sourceTableOrCardId(query))
- : (question.legacyNativeQuery() as NativeQuery).table();
+ : // Unjustified type cast. FIXME
+ (question.legacyNativeQuery() as NativeQuery).table();
if (table && table.hasSchema()) {
const isBasedOnSavedQuestion = isVirtualCardId(table.id);
if (database != null && !isBasedOnSavedQuestion) {
diff --git a/frontend/src/metabase/query_builder/components/view/ViewHeader/components/QuestionDataSource/utils.unit.spec.ts b/frontend/src/metabase/query_builder/components/view/ViewHeader/components/QuestionDataSource/utils.unit.spec.ts
index 7323e5b64c4..8cd6e49c92a 100644
--- a/frontend/src/metabase/query_builder/components/view/ViewHeader/components/QuestionDataSource/utils.unit.spec.ts
+++ b/frontend/src/metabase/query_builder/components/view/ViewHeader/components/QuestionDataSource/utils.unit.spec.ts
@@ -56,6 +56,7 @@ describe("getDataSourceParts", () => {
formatTableAsComponent: false,
});
expect(parts).toHaveLength(2);
+ // Unjustified type cast. FIXME
const partsArray = parts as any[];
expect(partsArray[0]).toEqual({
icon: "database",
@@ -77,6 +78,7 @@ describe("getDataSourceParts", () => {
formatTableAsComponent: true,
});
expect(parts).toHaveLength(2);
+ // Unjustified type cast. FIXME
const partsArray = parts as any[];
expect(partsArray[0]).toEqual({
icon: "database",
diff --git a/frontend/src/metabase/query_builder/components/view/ViewHeader/components/ViewTitleHeaderRightSide/QuestionSharingMenu/tests/setup.tsx b/frontend/src/metabase/query_builder/components/view/ViewHeader/components/ViewTitleHeaderRightSide/QuestionSharingMenu/tests/setup.tsx
index 21a4607b020..2dd6112971f 100644
--- a/frontend/src/metabase/query_builder/components/view/ViewHeader/components/ViewTitleHeaderRightSide/QuestionSharingMenu/tests/setup.tsx
+++ b/frontend/src/metabase/query_builder/components/view/ViewHeader/components/ViewTitleHeaderRightSide/QuestionSharingMenu/tests/setup.tsx
@@ -80,6 +80,7 @@ const setupState = ({
return createMockState({
settings: mockSettings(settingValues),
+ // Unjustified type cast. FIXME
currentUser: {
...user,
permissions: {
diff --git a/frontend/src/metabase/query_builder/components/view/sidebars/ChartTypeSidebar/ChartTypeSidebar.unit.spec.tsx b/frontend/src/metabase/query_builder/components/view/sidebars/ChartTypeSidebar/ChartTypeSidebar.unit.spec.tsx
index 9e1fcb37c92..cb71897ac58 100644
--- a/frontend/src/metabase/query_builder/components/view/sidebars/ChartTypeSidebar/ChartTypeSidebar.unit.spec.tsx
+++ b/frontend/src/metabase/query_builder/components/view/sidebars/ChartTypeSidebar/ChartTypeSidebar.unit.spec.tsx
@@ -11,6 +11,7 @@ const createResult = (insights: any[] | undefined): Dataset =>
createMockDataset({
data: {
rows: [[1]],
+ // Unjustified type cast. FIXME
cols: [{ name: "count", base_type: "type/Integer" }] as any,
insights,
},
@@ -18,6 +19,7 @@ const createResult = (insights: any[] | undefined): Dataset =>
const setup = (result: Dataset) => {
return renderWithProviders(
+ // Unjustified type cast. FIXME
<ChartTypeSidebar question={null as any} result={result} />,
);
};
@@ -43,6 +45,7 @@ describe("ChartTypeSidebar", () => {
rerender(
<ChartTypeSidebar
+ // Unjustified type cast. FIXME
question={null as any}
result={resultWithoutInsights}
/>,
diff --git a/frontend/src/metabase/query_builder/components/view/sidebars/ModelCacheManagementSection/ModelCacheManagementSection.unit.spec.tsx b/frontend/src/metabase/query_builder/components/view/sidebars/ModelCacheManagementSection/ModelCacheManagementSection.unit.spec.tsx
index fd0dd24ebd5..b584ce99761 100644
--- a/frontend/src/metabase/query_builder/components/view/sidebars/ModelCacheManagementSection/ModelCacheManagementSection.unit.spec.tsx
+++ b/frontend/src/metabase/query_builder/components/view/sidebars/ModelCacheManagementSection/ModelCacheManagementSection.unit.spec.tsx
@@ -47,6 +47,7 @@ async function setup({
const modelCacheInfo = getMockModelCacheInfo({
...cacheInfo,
card_id: model.id(),
+ // Unjustified type cast. FIXME
card_name: model.displayName() as string,
});
diff --git a/frontend/src/metabase/query_builder/components/view/sidebars/QuestionInfoSidebar/components/QuestionSources.tsx b/frontend/src/metabase/query_builder/components/view/sidebars/QuestionInfoSidebar/components/QuestionSources.tsx
index 289a7f6638d..9a275a09ec1 100644
--- a/frontend/src/metabase/query_builder/components/view/sidebars/QuestionInfoSidebar/components/QuestionSources.tsx
+++ b/frontend/src/metabase/query_builder/components/view/sidebars/QuestionInfoSidebar/components/QuestionSources.tsx
@@ -19,7 +19,8 @@ export const QuestionSources = () => {
const sourcesWithIcons: QuestionSource[] = useMemo(() => {
const sources = underlyingQuestion
- ? (getDataSourceParts({
+ ? // Unjustified type cast. FIXME
+ (getDataSourceParts({
question: underlyingQuestion,
subHead: false,
isObjectDetail: true,
diff --git a/frontend/src/metabase/query_builder/components/view/sidebars/QuestionInfoSidebar/components/QuestionSources.unit.spec.tsx b/frontend/src/metabase/query_builder/components/view/sidebars/QuestionInfoSidebar/components/QuestionSources.unit.spec.tsx
index e0075a3c644..aaf4a95e9e2 100644
--- a/frontend/src/metabase/query_builder/components/view/sidebars/QuestionInfoSidebar/components/QuestionSources.unit.spec.tsx
+++ b/frontend/src/metabase/query_builder/components/view/sidebars/QuestionInfoSidebar/components/QuestionSources.unit.spec.tsx
@@ -41,6 +41,7 @@ const setup = async ({
state.entities = {
...state.entities,
tables: {
+ // Unjustified type cast. FIXME
...(state.entities.tables as Record<number, NormalizedTable>),
[virtualTable.id]: virtualTable,
},
diff --git a/frontend/src/metabase/query_builder/components/view/sidebars/QuestionInfoSidebar/tests/common.unit.spec.tsx b/frontend/src/metabase/query_builder/components/view/sidebars/QuestionInfoSidebar/tests/common.unit.spec.tsx
index 6bf39d2f8a1..12cb5cbf6a8 100644
--- a/frontend/src/metabase/query_builder/components/view/sidebars/QuestionInfoSidebar/tests/common.unit.spec.tsx
+++ b/frontend/src/metabase/query_builder/components/view/sidebars/QuestionInfoSidebar/tests/common.unit.spec.tsx
@@ -176,6 +176,7 @@ describe("QuestionInfoSidebar", () => {
it("should not show entity id", () => {
const card = createMockCard({
name: "Question",
+ // Unjustified type cast. FIXME
entity_id: "jenny8675309" as BaseEntityId,
});
setup({ card });
diff --git a/frontend/src/metabase/query_builder/components/view/sidebars/QuestionInfoSidebar/tests/enterprise.unit.spec.tsx b/frontend/src/metabase/query_builder/components/view/sidebars/QuestionInfoSidebar/tests/enterprise.unit.spec.tsx
index 1cdc5771513..8b576bd81f9 100644
--- a/frontend/src/metabase/query_builder/components/view/sidebars/QuestionInfoSidebar/tests/enterprise.unit.spec.tsx
+++ b/frontend/src/metabase/query_builder/components/view/sidebars/QuestionInfoSidebar/tests/enterprise.unit.spec.tsx
@@ -34,6 +34,7 @@ describe("QuestionInfoSidebar > enterprise", () => {
describe("entity id display", () => {
it("should not show entity ids without serialization feature", async () => {
const card = createMockCard({
+ // Unjustified type cast. FIXME
entity_id: "jenny8675309" as Card["entity_id"],
});
await setupEnterprise({ card });
diff --git a/frontend/src/metabase/query_builder/components/view/sidebars/QuestionInfoSidebar/tests/premium.unit.spec.tsx b/frontend/src/metabase/query_builder/components/view/sidebars/QuestionInfoSidebar/tests/premium.unit.spec.tsx
index 8609691b960..bd107a4ce01 100644
--- a/frontend/src/metabase/query_builder/components/view/sidebars/QuestionInfoSidebar/tests/premium.unit.spec.tsx
+++ b/frontend/src/metabase/query_builder/components/view/sidebars/QuestionInfoSidebar/tests/premium.unit.spec.tsx
@@ -65,6 +65,7 @@ describe("QuestionInfoSidebar > premium", () => {
describe("entity id display", () => {
it("should show entity ids only with serialization feature", async () => {
const card = createMockCard({
+ // Unjustified type cast. FIXME
entity_id: "jenny8675309" as Card["entity_id"],
});
await setupEnterprise({ card });
diff --git a/frontend/src/metabase/query_builder/components/view/sidebars/TimelineSidebar/TimelineSidebar.tsx b/frontend/src/metabase/query_builder/components/view/sidebars/TimelineSidebar/TimelineSidebar.tsx
index a1e0e7ba318..4a7982188af 100644
--- a/frontend/src/metabase/query_builder/components/view/sidebars/TimelineSidebar/TimelineSidebar.tsx
+++ b/frontend/src/metabase/query_builder/components/view/sidebars/TimelineSidebar/TimelineSidebar.tsx
@@ -190,5 +190,6 @@ const formatDate = (date: Dayjs, unit?: DatetimeUnit) => {
if (unit == null) {
return date.format("ll");
}
+ // Unjustified type cast. FIXME
return formatDateTimeWithUnit(date.startOf(unit as OpUnitType), unit);
};
diff --git a/frontend/src/metabase/query_builder/containers/QueryBuilder.unit.spec.tsx b/frontend/src/metabase/query_builder/containers/QueryBuilder.unit.spec.tsx
index 1c5ae17af40..60b596fdb65 100644
--- a/frontend/src/metabase/query_builder/containers/QueryBuilder.unit.spec.tsx
+++ b/frontend/src/metabase/query_builder/containers/QueryBuilder.unit.spec.tsx
@@ -223,6 +223,7 @@ describe("QueryBuilder", () => {
const calls = fetchMock.callHistory.calls("path:/api/dataset/csv");
const lastCall = calls[calls.length - 1];
const body = await Promise.resolve(lastCall.options?.body);
+ // Unjustified type cast. FIXME
const urlSearchParams = new URLSearchParams(body as string);
expect(lastCall.url).toEqual(expect.stringContaining("/api/dataset/csv"));
const query =
diff --git a/frontend/src/metabase/query_builder/containers/use-register-query-builder-metabot-context.tsx b/frontend/src/metabase/query_builder/containers/use-register-query-builder-metabot-context.tsx
index 6df21f0afee..f12e099fca7 100644
--- a/frontend/src/metabase/query_builder/containers/use-register-query-builder-metabot-context.tsx
+++ b/frontend/src/metabase/query_builder/containers/use-register-query-builder-metabot-context.tsx
@@ -161,6 +161,7 @@ export function processSeriesData(
},
});
},
+ // Unjustified type cast. FIXME
{} as Record<string, MetabotSeriesConfig>,
);
}
@@ -181,6 +182,7 @@ function getVisualizationDataUri(question: Question) {
const display = question.card().display;
const format =
+ // Unjustified type cast. FIXME
(CHART_ANALYSIS_RENDER_FORMATS as Record<string, "png" | "svg" | "none">)[
display
] ?? ("none" as const);
diff --git a/frontend/src/metabase/query_builder/containers/use-register-query-builder-metabot-context.unit.spec.tsx b/frontend/src/metabase/query_builder/containers/use-register-query-builder-metabot-context.unit.spec.tsx
index 36b73c46769..7facf0273df 100644
--- a/frontend/src/metabase/query_builder/containers/use-register-query-builder-metabot-context.unit.spec.tsx
+++ b/frontend/src/metabase/query_builder/containers/use-register-query-builder-metabot-context.unit.spec.tsx
@@ -112,6 +112,7 @@ describe("registerQueryBuilderMetabotContextFn", () => {
const result = await registerQueryBuilderMetabotContextFn(data);
const viewing = getUserIsViewing(result);
+ // Unjustified type cast. FIXME
expect((viewing as any)?.id).toEqual(card.id);
expect(viewing?.type).toEqual(card.type);
});
diff --git a/frontend/src/metabase/query_builder/model-indexes/actions.ts b/frontend/src/metabase/query_builder/model-indexes/actions.ts
index 59e67d5c8e1..7efa2328d00 100644
--- a/frontend/src/metabase/query_builder/model-indexes/actions.ts
+++ b/frontend/src/metabase/query_builder/model-indexes/actions.ts
@@ -38,6 +38,7 @@ export const updateModelIndexes =
return;
}
+ // Unjustified type cast. FIXME
const { data: existingIndexes = [], error } = await (dispatch(
listModelIndexes.initiate({ model_id: model.id() }),
) as Promise<{ data: ModelIndex[]; error: unknown }>);
diff --git a/frontend/src/metabase/query_builder/reducers.ts b/frontend/src/metabase/query_builder/reducers.ts
index 3e305941984..0fafa7c5f1f 100644
--- a/frontend/src/metabase/query_builder/reducers.ts
+++ b/frontend/src/metabase/query_builder/reducers.ts
@@ -316,7 +316,9 @@ export const uiControls = createReducer<QueryBuilderUIControls>(
isShowingQuestionInfoSidebar: false,
}))
.addCase(OPEN_QUESTION_SETTINGS, (state) =>
+ // Unjustified type cast. FIXME
setUIControls(state, {
+ // Unjustified type cast. FIXME
...(UI_CONTROLS_SIDEBAR_DEFAULTS as Partial<QueryBuilderUIControls>),
isShowingQuestionSettingsSidebar: true,
} as Partial<QueryBuilderUIControls>),
diff --git a/frontend/src/metabase/query_builder/selectors.ts b/frontend/src/metabase/query_builder/selectors.ts
index acde86aad56..d10ba96e49d 100644
--- a/frontend/src/metabase/query_builder/selectors.ts
+++ b/frontend/src/metabase/query_builder/selectors.ts
@@ -827,6 +827,7 @@ export const getTimeseriesXDomain = createSelector(
[getIsTimeseries, getTimeseriesXValues],
(isTimeseries, xValues) => {
if (isTimeseries && Array.isArray(xValues) && xValues.length > 0) {
+ // Unjustified type cast. FIXME
return d3.extent(xValues as Array<d3.Numeric>) as Domain<dayjs.Dayjs>;
}
return null;
@@ -891,6 +892,7 @@ function getXDomainForTimelines<T extends Numeric>(
maxValue = maxValue.subtract(1, "day");
}
+ // Unjustified type cast. FIXME
return [xDomain[0], maxValue as T];
}
diff --git a/frontend/src/metabase/query_builder/utils/index.ts b/frontend/src/metabase/query_builder/utils/index.ts
index be393dd5922..3da729cb055 100644
--- a/frontend/src/metabase/query_builder/utils/index.ts
+++ b/frontend/src/metabase/query_builder/utils/index.ts
@@ -58,6 +58,7 @@ export function getURLForCardState(
const isAdHocQuestion = !card.id;
if (objectId != null) {
if (isAdHocQuestion) {
+ // Unjustified type cast. FIXME
(options.query as QueryParams).objectId = objectId;
} else {
options.objectId = objectId;
diff --git a/frontend/src/metabase/querying/common/components/BooleanPicker/BooleanPicker.tsx b/frontend/src/metabase/querying/common/components/BooleanPicker/BooleanPicker.tsx
index 66398573a2f..4ee2824fdf3 100644
--- a/frontend/src/metabase/querying/common/components/BooleanPicker/BooleanPicker.tsx
+++ b/frontend/src/metabase/querying/common/components/BooleanPicker/BooleanPicker.tsx
@@ -31,6 +31,7 @@ export function BooleanPicker({
const hasExpandButton = withEmptyOptions && !isExpanded;
const handleChange = (value: string) => {
+ // Unjustified type cast. FIXME
onChange(value as BooleanFilterValue);
};
diff --git a/frontend/src/metabase/querying/common/components/DataSelector/DataSelectorFieldPicker/DataSelectorFieldPicker.tsx b/frontend/src/metabase/querying/common/components/DataSelector/DataSelectorFieldPicker/DataSelectorFieldPicker.tsx
index 3d349eff5b0..a7e0cd7c6b6 100644
--- a/frontend/src/metabase/querying/common/components/DataSelector/DataSelectorFieldPicker/DataSelectorFieldPicker.tsx
+++ b/frontend/src/metabase/querying/common/components/DataSelector/DataSelectorFieldPicker/DataSelectorFieldPicker.tsx
@@ -73,6 +73,7 @@ export const DataSelectorFieldPicker = ({
field={item.field}
position="top-end"
size={18}
+ // Unjustified type cast. FIXME
icon={item.field.icon() as unknown as IconName}
/>
);
diff --git a/frontend/src/metabase/querying/common/components/DataSelector/DataSelectorFieldPicker/DataSelectorFieldPicker.unit.spec.tsx b/frontend/src/metabase/querying/common/components/DataSelector/DataSelectorFieldPicker/DataSelectorFieldPicker.unit.spec.tsx
index b892158df43..3f914e5bcdc 100644
--- a/frontend/src/metabase/querying/common/components/DataSelector/DataSelectorFieldPicker/DataSelectorFieldPicker.unit.spec.tsx
+++ b/frontend/src/metabase/querying/common/components/DataSelector/DataSelectorFieldPicker/DataSelectorFieldPicker.unit.spec.tsx
@@ -33,6 +33,7 @@ describe("DataSelectorFieldPicker", () => {
<DataSelectorFieldPicker
{...props}
isLoading={true}
+ // Unjustified type cast. FIXME
selectedTable={{ display_name: displayName } as Table}
/>,
);
@@ -64,6 +65,7 @@ describe("DataSelectorFieldPicker", () => {
render(
<DataSelectorFieldPicker
{...props}
+ // Unjustified type cast. FIXME
selectedTable={selectedTable as Table}
fields={[checkNotNull(metadata.field(ORDERS.PRODUCT_ID))]}
/>,
@@ -78,6 +80,7 @@ describe("DataSelectorFieldPicker", () => {
render(
<DataSelectorFieldPicker
{...props}
+ // Unjustified type cast. FIXME
selectedTable={{ display_name: "Orders" } as Table}
fields={[
checkNotNull(metadata.field(ORDERS.ID)),
diff --git a/frontend/src/metabase/querying/common/components/DatePicker/DatePicker.stories.tsx b/frontend/src/metabase/querying/common/components/DatePicker/DatePicker.stories.tsx
index a2272cf2bed..8eb59bcf530 100644
--- a/frontend/src/metabase/querying/common/components/DatePicker/DatePicker.stories.tsx
+++ b/frontend/src/metabase/querying/common/components/DatePicker/DatePicker.stories.tsx
@@ -21,6 +21,7 @@ const storeInitialState = createMockState({
settings: mockSettings(),
entities: createMockEntitiesState({}),
});
+// Unjustified type cast. FIXME
const store = getPublicStore(storeInitialState, []) as unknown as Store<State>;
const ReduxDecorator = (Story: StoryFn) => {
@@ -31,6 +32,7 @@ const ReduxDecorator = (Story: StoryFn) => {
);
};
+// Unjustified type cast. FIXME
export default {
title: "Components/Parameters/DatePicker",
component: DatePicker,
diff --git a/frontend/src/metabase/querying/components/CodeMirrorEditor/language.ts b/frontend/src/metabase/querying/components/CodeMirrorEditor/language.ts
index 11b8c750849..b9b80bd14fe 100644
--- a/frontend/src/metabase/querying/components/CodeMirrorEditor/language.ts
+++ b/frontend/src/metabase/querying/components/CodeMirrorEditor/language.ts
@@ -337,6 +337,7 @@ export function source(engine?: string | null): Source {
case "h2":
default: {
const dialect =
+ // Unjustified type cast. FIXME
engineToDialect[engine as keyof typeof engineToDialect] ?? StandardSQL;
const words =
diff --git a/frontend/src/metabase/querying/components/DataReference/DataReference.tsx b/frontend/src/metabase/querying/components/DataReference/DataReference.tsx
index 06a47c02276..024286d3d9b 100644
--- a/frontend/src/metabase/querying/components/DataReference/DataReference.tsx
+++ b/frontend/src/metabase/querying/components/DataReference/DataReference.tsx
@@ -22,6 +22,7 @@ export const DataReference = ({
}) => {
if (dataReferenceStack.length) {
const page = dataReferenceStack[dataReferenceStack.length - 1];
+ // Unjustified type cast. FIXME
const Pane = PANES[page.type] as ComponentType<
DataReferencePaneProps<typeof page>
>;
diff --git a/frontend/src/metabase/querying/components/DataReference/QuestionPane/QuestionPane.tsx b/frontend/src/metabase/querying/components/DataReference/QuestionPane/QuestionPane.tsx
index 045d46f1ff8..2e085c28b2d 100644
--- a/frontend/src/metabase/querying/components/DataReference/QuestionPane/QuestionPane.tsx
+++ b/frontend/src/metabase/querying/components/DataReference/QuestionPane/QuestionPane.tsx
@@ -145,7 +145,8 @@ export const QuestionPane = ({
id:
typeof field.id === "number"
? field.id
- : (field.getUniqueId() as UniqueFieldId),
+ : // Unjustified type cast. FIXME
+ (field.getUniqueId() as UniqueFieldId),
});
}}
/>
diff --git a/frontend/src/metabase/querying/components/DataReference/ResourceTreeNode.tsx b/frontend/src/metabase/querying/components/DataReference/ResourceTreeNode.tsx
index a79374bfa79..cf66d2f0dd3 100644
--- a/frontend/src/metabase/querying/components/DataReference/ResourceTreeNode.tsx
+++ b/frontend/src/metabase/querying/components/DataReference/ResourceTreeNode.tsx
@@ -31,6 +31,7 @@ export const ResourceTreeNode = <TData = unknown>({
data-is-expanded={isExpanded}
>
{isRoot && <NodeListItemIcon name="chevronright" data-role="chevron" />}
+ {/* Unjustified type cast. FIXME */}
<NodeListItemIcon name={item.icon as IconName} />
<NodeListItemName>{item.name}</NodeListItemName>
{!isRoot && displayId && <NodeListItemId>{`#${item.id}`}</NodeListItemId>}
diff --git a/frontend/src/metabase/querying/components/DataReference/TablePane.tsx b/frontend/src/metabase/querying/components/DataReference/TablePane.tsx
index d006d627db9..d67c385948e 100644
--- a/frontend/src/metabase/querying/components/DataReference/TablePane.tsx
+++ b/frontend/src/metabase/querying/components/DataReference/TablePane.tsx
@@ -75,7 +75,8 @@ export function TablePane({
id:
typeof field.id === "number"
? field.id
- : (field.getUniqueId() as UniqueFieldId),
+ : // Unjustified type cast. FIXME
+ (field.getUniqueId() as UniqueFieldId),
});
}}
/>
diff --git a/frontend/src/metabase/querying/components/NativeQueryEditor/NativeQueryEditor.unit.spec.tsx b/frontend/src/metabase/querying/components/NativeQueryEditor/NativeQueryEditor.unit.spec.tsx
index 4e1ca1467d9..afa1d6c6905 100644
--- a/frontend/src/metabase/querying/components/NativeQueryEditor/NativeQueryEditor.unit.spec.tsx
+++ b/frontend/src/metabase/querying/components/NativeQueryEditor/NativeQueryEditor.unit.spec.tsx
@@ -17,10 +17,12 @@ jest.mock(
type UseNotebookScreenSize = ReturnType<typeof useNotebookScreenSize>;
+// Unjustified type cast. FIXME
const useNotebookScreenSizeMock = useNotebookScreenSize as jest.MockedFunction<
() => UseNotebookScreenSize
>;
+// Unjustified type cast. FIXME
const mockQuestion = {
isSaved: () => false,
} as any;
@@ -44,12 +46,14 @@ describe("NativeQueryEditor", () => {
availableHeight={700}
isNativeEditorOpen={false}
question={mockQuestion}
+ // Unjustified type cast. FIXME
query={null as any}
setDatasetQuery={jest.fn()}
setIsNativeEditorOpen={setIsNativeEditorOpen}
isInitiallyOpen={false}
/>,
{
+ // Unjustified type cast. FIXME
storeInitialState: createMockState({
metabot: {
conversations: {
diff --git a/frontend/src/metabase/querying/components/NativeQueryEditor/PreviewQueryButton/PreviewQueryButton.tsx b/frontend/src/metabase/querying/components/NativeQueryEditor/PreviewQueryButton/PreviewQueryButton.tsx
index cb8641d8ac7..40db336b41a 100644
--- a/frontend/src/metabase/querying/components/NativeQueryEditor/PreviewQueryButton/PreviewQueryButton.tsx
+++ b/frontend/src/metabase/querying/components/NativeQueryEditor/PreviewQueryButton/PreviewQueryButton.tsx
@@ -48,6 +48,7 @@ PreviewQueryButton.shouldRender = ({ question }: PreviewQueryButtonOpts) => {
return false;
}
+ // Unjustified type cast. FIXME
const nativeQuestion = question.legacyNativeQuery() as NativeQuery;
const hasVariableTemplateTags = nativeQuestion.hasVariableTemplateTags();
diff --git a/frontend/src/metabase/querying/components/QueryVisualization/VisualizationError/tests/setup.tsx b/frontend/src/metabase/querying/components/QueryVisualization/VisualizationError/tests/setup.tsx
index a4142483432..698782baced 100644
--- a/frontend/src/metabase/querying/components/QueryVisualization/VisualizationError/tests/setup.tsx
+++ b/frontend/src/metabase/querying/components/QueryVisualization/VisualizationError/tests/setup.tsx
@@ -66,6 +66,7 @@ export const setup = ({
<VisualizationError
question={question}
duration={0}
+ // Unjustified type cast. FIXME
error={error as DatasetError}
via={[]}
/>,
diff --git a/frontend/src/metabase/querying/components/SnippetSidebar/SnippetSidebar.tsx b/frontend/src/metabase/querying/components/SnippetSidebar/SnippetSidebar.tsx
index 9f3dfcfd450..10490fc5090 100644
--- a/frontend/src/metabase/querying/components/SnippetSidebar/SnippetSidebar.tsx
+++ b/frontend/src/metabase/querying/components/SnippetSidebar/SnippetSidebar.tsx
@@ -447,11 +447,13 @@ function Row(props: RowProps) {
// `type` tells us what `item` is, but TS can't correlate independent props
if (props.type === "collection") {
const CollectionRow = PLUGIN_SNIPPET_SIDEBAR_ROW_RENDERERS.collection;
+ // Unjustified type cast. FIXME
return CollectionRow ? (
<CollectionRow {...props} item={props.item as Collection} />
) : null;
}
if (props.type === "snippet") {
+ // Unjustified type cast. FIXME
return <SnippetRow {...props} item={props.item as NativeQuerySnippet} />;
}
return null;
diff --git a/frontend/src/metabase/querying/components/expressions/CombineColumns/ColumnAndSeparatorRow/ColumnAndSeparatorRow.tsx b/frontend/src/metabase/querying/components/expressions/CombineColumns/ColumnAndSeparatorRow/ColumnAndSeparatorRow.tsx
index 33297cd3fcb..16a521db009 100644
--- a/frontend/src/metabase/querying/components/expressions/CombineColumns/ColumnAndSeparatorRow/ColumnAndSeparatorRow.tsx
+++ b/frontend/src/metabase/querying/components/expressions/CombineColumns/ColumnAndSeparatorRow/ColumnAndSeparatorRow.tsx
@@ -124,6 +124,7 @@ function SeparatorInput({
onBlur={handleBlur}
styles={{
input: {
+ // Unjustified type cast. FIXME
fontFamily: fontFamilyMonospace as string,
},
}}
diff --git a/frontend/src/metabase/querying/components/expressions/Editor/Listbox/util.tsx b/frontend/src/metabase/querying/components/expressions/Editor/Listbox/util.tsx
index 3be434013b6..8355a872a45 100644
--- a/frontend/src/metabase/querying/components/expressions/Editor/Listbox/util.tsx
+++ b/frontend/src/metabase/querying/components/expressions/Editor/Listbox/util.tsx
@@ -13,6 +13,7 @@ export function useCompletions(state: EditorState) {
const completions = useMemo(() => {
return {
status: completionStatus(state),
+ // Unjustified type cast. FIXME
options: (currentCompletions(state) ??
[]) as readonly ExpressionSuggestion[],
selectedOption: selectedCompletionIndex(state),
diff --git a/frontend/src/metabase/querying/components/expressions/ExpressionWidget/ExpressionWidget.tsx b/frontend/src/metabase/querying/components/expressions/ExpressionWidget/ExpressionWidget.tsx
index e3202f89bba..29513cae214 100644
--- a/frontend/src/metabase/querying/components/expressions/ExpressionWidget/ExpressionWidget.tsx
+++ b/frontend/src/metabase/querying/components/expressions/ExpressionWidget/ExpressionWidget.tsx
@@ -60,6 +60,7 @@ export const ExpressionWidget = (props: ExpressionWidgetProps) => {
} = props;
const [name, setName] = useState(initialName || "");
+ // Unjustified type cast. FIXME
const [clause, setClause] = useState<Lib.ExpressionClause | null>(
(initialClause ?? null) as Lib.ExpressionClause | null,
);
diff --git a/frontend/src/metabase/querying/components/expressions/ExtractColumn/util.unit.spec.ts b/frontend/src/metabase/querying/components/expressions/ExtractColumn/util.unit.spec.ts
index fa114f3766a..b60e14e10cc 100644
--- a/frontend/src/metabase/querying/components/expressions/ExtractColumn/util.unit.spec.ts
+++ b/frontend/src/metabase/querying/components/expressions/ExtractColumn/util.unit.spec.ts
@@ -42,12 +42,14 @@ const QUERY = Lib.createTestQuery(PROVIDER, {
describe("getName", () => {
it("should return a plain name without suffix when no duplicates exist", () => {
expect(
+ // Unjustified type cast. FIXME
getName(QUERY, -1, { displayName: "Bar" } as Lib.ColumnExtractionInfo),
).toBe("Bar");
});
it("should return a name with a suffix to avoid name clashes", () => {
expect(
+ // Unjustified type cast. FIXME
getName(QUERY, -1, { displayName: "Date" } as Lib.ColumnExtractionInfo),
).toBe("Date (1)");
});
diff --git a/frontend/src/metabase/querying/components/template_tags/TagEditorParam.tsx b/frontend/src/metabase/querying/components/template_tags/TagEditorParam.tsx
index fe8697666de..73a0608a768 100644
--- a/frontend/src/metabase/querying/components/template_tags/TagEditorParam.tsx
+++ b/frontend/src/metabase/querying/components/template_tags/TagEditorParam.tsx
@@ -421,6 +421,7 @@ class TagEditorParamInner extends Component<
});
if (tag.default != null) {
+ // Unjustified type cast. FIXME
if (
!newTemporalUnits.includes(tag.default as TemporalUnit)
) {
diff --git a/frontend/src/metabase/querying/components/template_tags/TagEditorSidebar.tsx b/frontend/src/metabase/querying/components/template_tags/TagEditorSidebar.tsx
index 5805cfb1e1e..f9e4213c3ae 100644
--- a/frontend/src/metabase/querying/components/template_tags/TagEditorSidebar.tsx
+++ b/frontend/src/metabase/querying/components/template_tags/TagEditorSidebar.tsx
@@ -74,6 +74,7 @@ export function TagEditorSidebar({
const handleTabChange = (tab: string | null) => {
if (tab) {
+ // Unjustified type cast. FIXME
setSection(tab as TabId);
}
};
@@ -93,6 +94,7 @@ export function TagEditorSidebar({
tags={tags}
parametersById={parametersById}
database={database}
+ // Unjustified type cast. FIXME
databases={databases as Database[]}
originalQuestion={originalQuestion}
setTemplateTag={setTemplateTag}
diff --git a/frontend/src/metabase/querying/drills/utils/column-extract-drill.tsx b/frontend/src/metabase/querying/drills/utils/column-extract-drill.tsx
index 401de62f32a..1a8a6b79f3c 100644
--- a/frontend/src/metabase/querying/drills/utils/column-extract-drill.tsx
+++ b/frontend/src/metabase/querying/drills/utils/column-extract-drill.tsx
@@ -39,6 +39,7 @@ export const columnExtractDrill: Drill<Lib.ColumnExtractDrillThruInfo> = ({
);
function handleClick(action: RegularClickAction) {
+ // Unjustified type cast. FIXME
const { extraction } = action.extra?.() as {
extraction: Lib.ColumnExtraction;
};
diff --git a/frontend/src/metabase/querying/drills/utils/zoom-drill.ts b/frontend/src/metabase/querying/drills/utils/zoom-drill.ts
index 0d58e8eb3de..938168c071e 100644
--- a/frontend/src/metabase/querying/drills/utils/zoom-drill.ts
+++ b/frontend/src/metabase/querying/drills/utils/zoom-drill.ts
@@ -14,6 +14,7 @@ export const zoomDrill: Drill<Lib.ZoomDrillThruInfo> = ({
}) => {
const { objectId, isManyPks } = drillInfo;
const isDashboard = clicked.extraData?.dashboard != null;
+ // Unjustified type cast. FIXME
const zoomInRow = clicked.extraData?.zoomInRow as
| ((opts: { objectId: string | number }) => Dispatcher)
| undefined;
diff --git a/frontend/src/metabase/querying/expressions/clause.ts b/frontend/src/metabase/querying/expressions/clause.ts
index d05a9a31b64..48e986aff00 100644
--- a/frontend/src/metabase/querying/expressions/clause.ts
+++ b/frontend/src/metabase/querying/expressions/clause.ts
@@ -47,6 +47,7 @@ const EXPRESSION_TO_MBQL_NAME = new Map(
Object.entries(MBQL_CLAUSES).map(([mbql, { displayName }]) => [
// case-insensitive
displayName.toLowerCase(),
+ // Unjustified type cast. FIXME
mbql as Lib.DefinedClauseName,
]),
);
diff --git a/frontend/src/metabase/querying/expressions/formatter/utils.ts b/frontend/src/metabase/querying/expressions/formatter/utils.ts
index 2f9100dc8fc..3f9d068dc7c 100644
--- a/frontend/src/metabase/querying/expressions/formatter/utils.ts
+++ b/frontend/src/metabase/querying/expressions/formatter/utils.ts
@@ -81,6 +81,7 @@ export function isValueOperator(node: Lib.ExpressionParts) {
* dimension (internal use only).
*/
export function isDimensionOperator(node: Lib.ExpressionParts) {
+ // Unjustified type cast. FIXME
return (
Lib.isExpressionParts(node) && (node.operator as string) === "dimension"
);
diff --git a/frontend/src/metabase/querying/expressions/help-text.ts b/frontend/src/metabase/querying/expressions/help-text.ts
index a87fd519a81..49f5a4bad4a 100644
--- a/frontend/src/metabase/querying/expressions/help-text.ts
+++ b/frontend/src/metabase/querying/expressions/help-text.ts
@@ -52,6 +52,7 @@ function getExample(
args: Lib.ClauseArgDefinition[],
): Lib.ExpressionParts {
return {
+ // Unjustified type cast. FIXME
operator: name as Lib.ExpressionOperator,
options: {},
args: args.flatMap((arg) => arg.example).filter(isNotNull),
diff --git a/frontend/src/metabase/querying/expressions/pratt/compiler.ts b/frontend/src/metabase/querying/expressions/pratt/compiler.ts
index 7340e976505..fbe0550a52a 100644
--- a/frontend/src/metabase/querying/expressions/pratt/compiler.ts
+++ b/frontend/src/metabase/querying/expressions/pratt/compiler.ts
@@ -68,6 +68,7 @@ function fallbackResolver(
_node?: Node,
) {
return {
+ // Unjustified type cast. FIXME
operator: "dimension" as Lib.ExpressionOperator,
options: {},
args: [name],
diff --git a/frontend/src/metabase/querying/expressions/pratt/syntax.ts b/frontend/src/metabase/querying/expressions/pratt/syntax.ts
index 1df5c455410..5a730648e79 100644
--- a/frontend/src/metabase/querying/expressions/pratt/syntax.ts
+++ b/frontend/src/metabase/querying/expressions/pratt/syntax.ts
@@ -15,27 +15,49 @@ import type { Node, NodeType } from "./node";
* that the lexer makes based on contextual information
*/
+// Unjustified type cast. FIXME
export const FIELD = {} as NodeType;
+// Unjustified type cast. FIXME
export const ADD = {} as NodeType;
+// Unjustified type cast. FIXME
export const LOGICAL_AND = {} as NodeType;
+// Unjustified type cast. FIXME
export const ARG_LIST = {} as NodeType;
+// Unjustified type cast. FIXME
export const BAD_TOKEN = {} as NodeType;
+// Unjustified type cast. FIXME
export const CALL = {} as NodeType;
+// Unjustified type cast. FIXME
export const COMMA = {} as NodeType;
+// Unjustified type cast. FIXME
export const END_OF_INPUT = {} as NodeType;
+// Unjustified type cast. FIXME
export const EQUALITY = {} as NodeType;
+// Unjustified type cast. FIXME
export const NUMBER = {} as NodeType;
+// Unjustified type cast. FIXME
export const BOOLEAN = {} as NodeType;
+// Unjustified type cast. FIXME
export const LOGICAL_NOT = {} as NodeType;
+// Unjustified type cast. FIXME
export const NEGATIVE = {} as NodeType;
+// Unjustified type cast. FIXME
export const LOGICAL_OR = {} as NodeType;
+// Unjustified type cast. FIXME
export const COMPARISON = {} as NodeType;
+// Unjustified type cast. FIXME
export const GROUP = {} as NodeType;
+// Unjustified type cast. FIXME
export const GROUP_CLOSE = {} as NodeType;
+// Unjustified type cast. FIXME
export const ROOT = {} as NodeType;
+// Unjustified type cast. FIXME
export const MULDIV_OP = {} as NodeType;
+// Unjustified type cast. FIXME
export const STRING = {} as NodeType;
+// Unjustified type cast. FIXME
export const SUB = {} as NodeType;
+// Unjustified type cast. FIXME
export const IDENTIFIER = {} as NodeType;
function operand(leftOperands: number, rightOperands: number) {
diff --git a/frontend/src/metabase/querying/expressions/test/shared.ts b/frontend/src/metabase/querying/expressions/test/shared.ts
index 6bf8914de8d..4e85e00ba51 100644
--- a/frontend/src/metabase/querying/expressions/test/shared.ts
+++ b/frontend/src/metabase/querying/expressions/test/shared.ts
@@ -317,6 +317,7 @@ function findFields<const T extends { [key: string]: unknown }>(
): {
[K in keyof T]: Lib.ColumnMetadata;
} {
+ // Unjustified type cast. FIXME
const res = {} as unknown as {
[K in keyof T]: Lib.ColumnMetadata;
};
diff --git a/frontend/src/metabase/querying/expressions/test/utils.ts b/frontend/src/metabase/querying/expressions/test/utils.ts
index 75492504809..6125b7fa459 100644
--- a/frontend/src/metabase/querying/expressions/test/utils.ts
+++ b/frontend/src/metabase/querying/expressions/test/utils.ts
@@ -5,6 +5,7 @@ export function op(
...args: (Lib.ExpressionParts | Lib.ExpressionArg)[]
): Lib.ExpressionParts {
return {
+ // Unjustified type cast. FIXME
operator: operator as Lib.ExpressionOperator,
options: {},
args,
@@ -17,6 +18,7 @@ export function opt(
...args: (Lib.ExpressionParts | Lib.ExpressionArg)[]
): Lib.ExpressionParts {
return {
+ // Unjustified type cast. FIXME
operator: operator as Lib.ExpressionOperator,
options,
args,
diff --git a/frontend/src/metabase/querying/filters/components/FilterPicker/FilterColumnPicker/FilterColumnPicker.tsx b/frontend/src/metabase/querying/filters/components/FilterPicker/FilterColumnPicker/FilterColumnPicker.tsx
index f736a660082..41add9f3a83 100644
--- a/frontend/src/metabase/querying/filters/components/FilterPicker/FilterColumnPicker/FilterColumnPicker.tsx
+++ b/frontend/src/metabase/querying/filters/components/FilterPicker/FilterColumnPicker/FilterColumnPicker.tsx
@@ -61,6 +61,7 @@ export interface FilterColumnPickerProps {
}
export const isSegmentListItem = (item: Item): item is SegmentListItem => {
+ // Unjustified type cast. FIXME
return (item as SegmentListItem).segment != null;
};
diff --git a/frontend/src/metabase/querying/filters/components/FilterPicker/FilterPicker.unit.spec.tsx b/frontend/src/metabase/querying/filters/components/FilterPicker/FilterPicker.unit.spec.tsx
index 6e122b648bb..c2ae8e7790e 100644
--- a/frontend/src/metabase/querying/filters/components/FilterPicker/FilterPicker.unit.spec.tsx
+++ b/frontend/src/metabase/querying/filters/components/FilterPicker/FilterPicker.unit.spec.tsx
@@ -35,7 +35,9 @@ import {
storeInitialState,
} from "./test-utils";
+// Unjustified type cast. FIXME
const productCategories = PRODUCT_CATEGORY_VALUES.values.flat() as string[];
+// Unjustified type cast. FIXME
const productVendors = PRODUCT_VENDOR_VALUES.values.flat() as string[];
function createQueryWithMultipleValuesFilter() {
diff --git a/frontend/src/metabase/querying/notebook/components/DataStep/DataStep.tsx b/frontend/src/metabase/querying/notebook/components/DataStep/DataStep.tsx
index 5124b8a2e2b..e89000c40e1 100644
--- a/frontend/src/metabase/querying/notebook/components/DataStep/DataStep.tsx
+++ b/frontend/src/metabase/querying/notebook/components/DataStep/DataStep.tsx
@@ -134,6 +134,7 @@ export function DataFieldPopover({
<IconButtonWrapper
className={S.DataStepIconButton}
style={
+ // Unjustified type cast. FIXME
{
"--notebook-cell-container-padding": CONTAINER_PADDING,
} as CSSProperties
diff --git a/frontend/src/metabase/querying/notebook/components/JoinStep/JoinConditionColumnPicker/JoinColumnButton/JoinColumnButton.unit.spec.tsx b/frontend/src/metabase/querying/notebook/components/JoinStep/JoinConditionColumnPicker/JoinColumnButton/JoinColumnButton.unit.spec.tsx
index 1828fac2a7e..f4bbd6be5a7 100644
--- a/frontend/src/metabase/querying/notebook/components/JoinStep/JoinConditionColumnPicker/JoinColumnButton/JoinColumnButton.unit.spec.tsx
+++ b/frontend/src/metabase/querying/notebook/components/JoinStep/JoinConditionColumnPicker/JoinColumnButton/JoinColumnButton.unit.spec.tsx
@@ -44,6 +44,7 @@ function setup({
isReadOnly?: boolean;
touch?: boolean;
} = {}) {
+ // Unjustified type cast. FIXME
(isTouchDevice as jest.Mock).mockReturnValue(touch);
return renderWithProviders(
diff --git a/frontend/src/metabase/querying/notebook/components/JoinStep/JoinStep.unit.spec.tsx b/frontend/src/metabase/querying/notebook/components/JoinStep/JoinStep.unit.spec.tsx
index 7c4d9a9ce3a..df8e1d1d8d3 100644
--- a/frontend/src/metabase/querying/notebook/components/JoinStep/JoinStep.unit.spec.tsx
+++ b/frontend/src/metabase/querying/notebook/components/JoinStep/JoinStep.unit.spec.tsx
@@ -844,6 +844,7 @@ describe("Notebook Editor > Join Step", () => {
await userEvent.click(within(rhsColumnPicker).getByText("Rating"));
const { query, fields } = getRecentJoin();
+ // Unjustified type cast. FIXME
const columns = fields as Lib.ColumnMetadata[];
const reviewer = columns.find(
(column) => Lib.displayInfo(query, 0, column).name === "REVIEWER",
@@ -934,6 +935,7 @@ describe("Notebook Editor > Join Step", () => {
await userEvent.click(within(picker).getByText("Vendor"));
const { query, fields } = getRecentJoin();
+ // Unjustified type cast. FIXME
const columns = fields as Lib.ColumnMetadata[];
const vendor = columns.find(
(column) => Lib.displayInfo(query, 0, column).name === "VENDOR",
diff --git a/frontend/src/metabase/querying/notebook/components/JoinStep/JoinTablePicker/JoinTablePicker.tsx b/frontend/src/metabase/querying/notebook/components/JoinStep/JoinTablePicker/JoinTablePicker.tsx
index 93ad6c2b31a..22ab9437c9c 100644
--- a/frontend/src/metabase/querying/notebook/components/JoinStep/JoinTablePicker/JoinTablePicker.tsx
+++ b/frontend/src/metabase/querying/notebook/components/JoinStep/JoinTablePicker/JoinTablePicker.tsx
@@ -106,6 +106,7 @@ function JoinTableColumnPicker({ columnPicker }: JoinTableColumnPickerProps) {
<IconButtonWrapper
className={S.ColumnPickerButton}
style={
+ // Unjustified type cast. FIXME
{
"--notebook-cell-container-padding": CONTAINER_PADDING,
} as CSSProperties
diff --git a/frontend/src/metabase/querying/notebook/components/NotebookDataPicker/EmbeddingDataPicker/EmbeddingDataPicker.tsx b/frontend/src/metabase/querying/notebook/components/NotebookDataPicker/EmbeddingDataPicker/EmbeddingDataPicker.tsx
index 91f90af7c5d..1b07fd7a538 100644
--- a/frontend/src/metabase/querying/notebook/components/NotebookDataPicker/EmbeddingDataPicker/EmbeddingDataPicker.tsx
+++ b/frontend/src/metabase/querying/notebook/components/NotebookDataPicker/EmbeddingDataPicker/EmbeddingDataPicker.tsx
@@ -169,6 +169,7 @@ function useSourceEntityCollectionId(query: Lib.Query) {
const sourceTable = useSourceTable(query);
const isCard =
sourceTable?.type &&
+ // Unjustified type cast. FIXME
(["model", "question"] as CardType[]).includes(sourceTable.type);
const cardId = isCard
? getQuestionIdFromVirtualTableId(sourceTable?.id)
diff --git a/frontend/src/metabase/querying/notebook/components/NotebookDataPicker/NotebookDataPicker.tsx b/frontend/src/metabase/querying/notebook/components/NotebookDataPicker/NotebookDataPicker.tsx
index 897ed5064c3..8b4a89e89d5 100644
--- a/frontend/src/metabase/querying/notebook/components/NotebookDataPicker/NotebookDataPicker.tsx
+++ b/frontend/src/metabase/querying/notebook/components/NotebookDataPicker/NotebookDataPicker.tsx
@@ -200,9 +200,11 @@ function ModernDataPicker({
return Boolean(
// @ts-expect-error - Please fix 🥺
shouldDisableBasedOnDb({ ...item, database_id: dbId }) ||
+ // Unjustified type cast. FIXME
shouldDisableItem?.(item as OmniPickerItem) ||
(isObjectWithModel(item) &&
item.model === "database" &&
+ // Unjustified type cast. FIXME
shouldDisableDatabase?.(item as QueryEditorDatabasePickerItem)),
);
};
diff --git a/frontend/src/metabase/querying/notebook/components/NotebookDataPicker/utils.ts b/frontend/src/metabase/querying/notebook/components/NotebookDataPicker/utils.ts
index ec8db7a51bd..4a9c4283cb1 100644
--- a/frontend/src/metabase/querying/notebook/components/NotebookDataPicker/utils.ts
+++ b/frontend/src/metabase/querying/notebook/components/NotebookDataPicker/utils.ts
@@ -48,7 +48,9 @@ export const isObjectWithModel = (
item !== null &&
"model" in item &&
"id" in item &&
+ // Unjustified type cast. FIXME
typeof (item as any).model === "string" &&
+ // Unjustified type cast. FIXME
typeof (item as any).id === "number"
);
};
diff --git a/frontend/src/metabase/querying/notebook/components/NotebookStepList/NotebookStepList.unit.spec.tsx b/frontend/src/metabase/querying/notebook/components/NotebookStepList/NotebookStepList.unit.spec.tsx
index 6c8c9d63b42..88934ed1ec1 100644
--- a/frontend/src/metabase/querying/notebook/components/NotebookStepList/NotebookStepList.unit.spec.tsx
+++ b/frontend/src/metabase/querying/notebook/components/NotebookStepList/NotebookStepList.unit.spec.tsx
@@ -75,6 +75,7 @@ describe("NotebookStepList", () => {
});
function assertActionButtonsOrder(buttonNames: string[]) {
+ // Unjustified type cast. FIXME
const actionButtonsContainer = screen
.getAllByTestId("action-buttons")
.at(-1) as HTMLElement;
diff --git a/frontend/src/metabase/querying/run-query.ts b/frontend/src/metabase/querying/run-query.ts
index ace44ad6afd..ef1a3d6bc89 100644
--- a/frontend/src/metabase/querying/run-query.ts
+++ b/frontend/src/metabase/querying/run-query.ts
@@ -67,11 +67,13 @@ async function handleQueryApiError(
// plain-text body. Normalize so callers can rely on a `{ error, ... }`
// shape and don't fall through to the empty state (EMB-1659).
if (typeof error.data === "string") {
+ // Unjustified type cast. FIXME
return {
error: error.data,
status: error.status,
} as unknown as Dataset;
}
+ // Unjustified type cast. FIXME
return error.data as Dataset;
}
// For 5xx and other errors, re-throw
@@ -156,6 +158,7 @@ function runSavedCardQuery(
dashboardApi.endpoints.getDashboardCardQuery,
card,
metadata,
+ // Unjustified type cast. FIXME
{
dashboardId,
dashcardId,
@@ -168,6 +171,7 @@ function runSavedCardQuery(
cardApi.endpoints.getCardQuery,
card,
metadata,
+ // Unjustified type cast. FIXME
body as CardQueryRequest,
);
}
diff --git a/frontend/src/metabase/querying/run-query.unit.spec.ts b/frontend/src/metabase/querying/run-query.unit.spec.ts
index be0394fe46d..b0ebdc83f03 100644
--- a/frontend/src/metabase/querying/run-query.unit.spec.ts
+++ b/frontend/src/metabase/querying/run-query.unit.spec.ts
@@ -51,6 +51,7 @@ type DashboardAwareCard = Card & {
function createMockSavedQuestion(card?: Partial<DashboardAwareCard>) {
const savedCard = createMockCard({ dataset_query: MOCK_QUERY, ...card });
+ // Unjustified type cast. FIXME
return createMockMetadata(savedCard).question(savedCard.id) as Question;
}
@@ -214,6 +215,7 @@ describe("metabase/querying/run-query > runQuestionQuery", () => {
// non-pivot card, otherwise the query never reaches `/api/dataset` (the
// audit "Erroring Questions" table renders nothing).
const question = createMockAdHocQuestion({
+ // Unjustified type cast. FIXME
dataset_query: {
type: "internal",
fn: "metabase-enterprise.audit-app.pages.queries/bad-table",
diff --git a/frontend/src/metabase/questions/components/MoveCardModal/MoveCardModal.tsx b/frontend/src/metabase/questions/components/MoveCardModal/MoveCardModal.tsx
index 5c541abfeec..968a401fcb4 100644
--- a/frontend/src/metabase/questions/components/MoveCardModal/MoveCardModal.tsx
+++ b/frontend/src/metabase/questions/components/MoveCardModal/MoveCardModal.tsx
@@ -57,7 +57,8 @@ export const MoveCardModal = ({ card, onClose }: MoveCardModalProps) => {
) => {
const update =
destination.model === "dashboard"
- ? { dashboard_id: destination.id as number }
+ ? // Unjustified type cast. FIXME
+ { dashboard_id: destination.id as number }
: {
dashboard_id: null,
collection_id: canonicalCollectionId(destination.id),
diff --git a/frontend/src/metabase/redux/analytics.ts b/frontend/src/metabase/redux/analytics.ts
index e45737a8436..d3bf2197168 100644
--- a/frontend/src/metabase/redux/analytics.ts
+++ b/frontend/src/metabase/redux/analytics.ts
@@ -42,6 +42,7 @@ export const trackDownloadResults = ({
event: "download_results_clicked",
resource_type: analyticsResourceType,
accessed_via: accessedVia,
+ // Unjustified type cast. FIXME
export_type: exportType as any,
});
};
diff --git a/frontend/src/metabase/redux/app.ts b/frontend/src/metabase/redux/app.ts
index dcb30817730..266bea2d297 100644
--- a/frontend/src/metabase/redux/app.ts
+++ b/frontend/src/metabase/redux/app.ts
@@ -132,6 +132,7 @@ const detailView = handleActions(
const tempStorageSlice = createSlice({
name: "tempStorage",
+ // Unjustified type cast. FIXME
initialState: {} as TempStorage,
reducers: {
setTempSetting: (
diff --git a/frontend/src/metabase/redux/cards.ts b/frontend/src/metabase/redux/cards.ts
index 59be7f35536..41ec7c02065 100644
--- a/frontend/src/metabase/redux/cards.ts
+++ b/frontend/src/metabase/redux/cards.ts
@@ -60,6 +60,7 @@ const WRITABLE_CARD_PROPERTIES = [
] as const;
const pickWritable = (card: object) =>
+ // Unjustified type cast. FIXME
_.pick(card, "id", ...WRITABLE_CARD_PROPERTIES) as Record<string, unknown>;
/**
diff --git a/frontend/src/metabase/redux/downloads.ts b/frontend/src/metabase/redux/downloads.ts
index 0e907a252b6..f94998a7323 100644
--- a/frontend/src/metabase/redux/downloads.ts
+++ b/frontend/src/metabase/redux/downloads.ts
@@ -363,6 +363,7 @@ const convertSearchParamsToObject = (params: URLSearchParams) => {
const object: Record<string, string | string[]> = {};
for (const [key, value] of params.entries()) {
if (object[key]) {
+ // Unjustified type cast. FIXME
object[key] = ([] as string[]).concat(object[key], value);
} else {
object[key] = value;
diff --git a/frontend/src/metabase/redux/downloads.unit.spec.ts b/frontend/src/metabase/redux/downloads.unit.spec.ts
index b5e1f164153..316379f63ae 100644
--- a/frontend/src/metabase/redux/downloads.unit.spec.ts
+++ b/frontend/src/metabase/redux/downloads.unit.spec.ts
@@ -56,6 +56,7 @@ describe("getDatasetResponse", () => {
});
describe("getDatasetParams - embed question (token-based)", () => {
+ // Unjustified type cast. FIXME
const TOKEN = "fake.jwt.token" as EntityToken;
const question = new Question(createMockCard({ id: 1 }), undefined);
const result = createMockDataset();
@@ -159,12 +160,14 @@ describe("getDatasetParams - public question (uuid-based)", () => {
describe("readDownloadBlob", () => {
it("returns the blob when the response reads to completion", async () => {
const blob = new Blob(["a,b,c"], { type: "text/csv" });
+ // Unjustified type cast. FIXME
const response = { blob: () => Promise.resolve(blob) } as Response;
await expect(readDownloadBlob(response)).resolves.toBe(blob);
});
it("surfaces a localized error when the stream was aborted mid-download", async () => {
+ // Unjustified type cast. FIXME
const response = {
blob: () => Promise.reject(new TypeError("Failed to fetch")),
} as unknown as Response;
diff --git a/frontend/src/metabase/redux/embed/embed.ts b/frontend/src/metabase/redux/embed/embed.ts
index 3775503b846..fb376a4f395 100644
--- a/frontend/src/metabase/redux/embed/embed.ts
+++ b/frontend/src/metabase/redux/embed/embed.ts
@@ -35,6 +35,7 @@ export const DEFAULT_INTERACTIVE_EMBEDDING_OPTIONS: InteractiveEmbeddingOptionsS
action_buttons: true,
};
+// Unjustified type cast. FIXME
const ALLOWED_INTERACTIVE_EMBEDDING_OPTIONS = (
Object.keys(
DEFAULT_INTERACTIVE_EMBEDDING_OPTIONS,
@@ -49,6 +50,7 @@ interface Location {
const interactiveEmbedSlice = createSlice({
name: "interactiveEmbed",
initialState: {
+ // Unjustified type cast. FIXME
options: {} as InteractiveEmbeddingOptionsState,
isEmbeddingSdk: false,
},
diff --git a/frontend/src/metabase/redux/embed/embed.unit.spec.ts b/frontend/src/metabase/redux/embed/embed.unit.spec.ts
index ff4dea06e4e..b84f689881f 100644
--- a/frontend/src/metabase/redux/embed/embed.unit.spec.ts
+++ b/frontend/src/metabase/redux/embed/embed.unit.spec.ts
@@ -174,5 +174,6 @@ const createMockStore = () => {
embeddingDataPicker: embeddingDataPickerReducer,
},
});
+ // Unjustified type cast. FIXME
return store as typeof store & { dispatch: Dispatch };
};
diff --git a/frontend/src/metabase/redux/entities/index.ts b/frontend/src/metabase/redux/entities/index.ts
index e4588fa96f4..35c0fe141d4 100644
--- a/frontend/src/metabase/redux/entities/index.ts
+++ b/frontend/src/metabase/redux/entities/index.ts
@@ -47,6 +47,7 @@ function mergeEntities(
} else {
result[id] = {
...(result[id] ?? {}),
+ // Unjustified type cast. FIXME
...(entry as Record<string, unknown>),
};
}
@@ -65,6 +66,7 @@ function makeSliceReducer(
): SliceReducer {
return (state = {}, action: SliceAction) => {
let nextState = state;
+ // Unjustified type cast. FIXME
const entities = getIn(action, ["payload", "entities", sliceName]) as
| Record<string, unknown>
| undefined;
@@ -79,6 +81,7 @@ const customReducers: Partial<Record<string, SliceReducer>> = {
tables: tablesReducer,
};
+// Unjustified type cast. FIXME
const sliceReducers = Object.fromEntries(
ENTITY_SLICE_NAMES.map((name) => [
name,
diff --git a/frontend/src/metabase/redux/entities/tables-reducer.unit.spec.ts b/frontend/src/metabase/redux/entities/tables-reducer.unit.spec.ts
index 8dfc544b0d5..dfc4eb13b1b 100644
--- a/frontend/src/metabase/redux/entities/tables-reducer.unit.spec.ts
+++ b/frontend/src/metabase/redux/entities/tables-reducer.unit.spec.ts
@@ -27,10 +27,12 @@ describe("tablesReducer", () => {
}
function getCreateAction(question: unknown) {
+ // Unjustified type cast. FIXME
return cardCreated(question as Card);
}
function getUpdateAction(question: unknown) {
+ // Unjustified type cast. FIXME
return cardUpdated(question as Card);
}
diff --git a/frontend/src/metabase/redux/routing-contract.unit.spec.ts b/frontend/src/metabase/redux/routing-contract.unit.spec.ts
index 0d59d042eb5..dfdc6b9ab02 100644
--- a/frontend/src/metabase/redux/routing-contract.unit.spec.ts
+++ b/frontend/src/metabase/redux/routing-contract.unit.spec.ts
@@ -46,6 +46,7 @@ const setup = () => {
const locationChanges = () =>
actions.filter((a) => a.type === LOCATION_CHANGE);
+ // Unjustified type cast. FIXME
const location = () => getLocation(store.getState() as any);
return { store, history: syncedHistory, location, locationChanges };
diff --git a/frontend/src/metabase/redux/settings.ts b/frontend/src/metabase/redux/settings.ts
index 38da054a683..044aeceb774 100644
--- a/frontend/src/metabase/redux/settings.ts
+++ b/frontend/src/metabase/redux/settings.ts
@@ -83,6 +83,7 @@ export const updateSetting = createThunkAction(
// strict, so narrow it here.
await dispatch(
settingsApi.endpoints.updateSetting.initiate(
+ // Unjustified type cast. FIXME
setting as {
key: EnterpriseSettingKey;
value: EnterpriseSettingValue<EnterpriseSettingKey>;
diff --git a/frontend/src/metabase/redux/tables.ts b/frontend/src/metabase/redux/tables.ts
index c4b6989d514..0eae87d385a 100644
--- a/frontend/src/metabase/redux/tables.ts
+++ b/frontend/src/metabase/redux/tables.ts
@@ -78,6 +78,7 @@ export const fetchTableMetadataAndForeignKeys =
async (dispatch: Dispatch, getState: GetState) => {
await dispatch(fetchTableMetadata({ id }, options));
+ // Unjustified type cast. FIXME
const table = getMetadataUnfiltered(getState()).table(id) as ForeignKeyHost;
await Promise.allSettled([
...getTableForeignKeyTableIds(table).map((tableId) =>
diff --git a/frontend/src/metabase/redux/ui.ts b/frontend/src/metabase/redux/ui.ts
index d736689bf91..ae044af31ba 100644
--- a/frontend/src/metabase/redux/ui.ts
+++ b/frontend/src/metabase/redux/ui.ts
@@ -36,6 +36,7 @@ function validateSerializableProps(props: unknown): void {
);
}
+// Unjustified type cast. FIXME
const DEFAULT_MODAL_STATE = {
id: null,
props: null,
diff --git a/frontend/src/metabase/redux/undo.unit.spec.ts b/frontend/src/metabase/redux/undo.unit.spec.ts
index 939a35a3842..3f695cf4ad5 100644
--- a/frontend/src/metabase/redux/undo.unit.spec.ts
+++ b/frontend/src/metabase/redux/undo.unit.spec.ts
@@ -162,5 +162,6 @@ const createMockStore = () => {
// @ts-expect-error rework undo reducer to RTK
reducer: { undo: undoReducer },
});
+ // Unjustified type cast. FIXME
return store as typeof store & { dispatch: Dispatch };
};
diff --git a/frontend/src/metabase/redux/utils.ts b/frontend/src/metabase/redux/utils.ts
index 0b739b4a370..8ac4f5cff14 100644
--- a/frontend/src/metabase/redux/utils.ts
+++ b/frontend/src/metabase/redux/utils.ts
@@ -57,6 +57,7 @@ export function withAction<TArgs extends unknown[]>(actionType: string) {
// thunk, return a new thunk
return async (dispatch: Dispatch, getState: () => State) => {
try {
+ // Unjustified type cast. FIXME
const payload = await (payloadOrThunk as Thunk)(dispatch, getState);
const dispatchValue = { type: actionType, payload: payload };
dispatch(dispatchValue);
diff --git a/frontend/src/metabase/reference/databases/DatabaseDetailContainer.tsx b/frontend/src/metabase/reference/databases/DatabaseDetailContainer.tsx
index e8e24c14110..7a7a4189679 100644
--- a/frontend/src/metabase/reference/databases/DatabaseDetailContainer.tsx
+++ b/frontend/src/metabase/reference/databases/DatabaseDetailContainer.tsx
@@ -91,6 +91,7 @@ export default withRouteProps(
mapStateToProps,
mapDispatchToProps,
)(
+ // Unjustified type cast. FIXME
DatabaseDetailContainer as unknown as React.ComponentType<InjectedRouteProps>,
),
);
diff --git a/frontend/src/metabase/reference/databases/DatabaseListContainer.tsx b/frontend/src/metabase/reference/databases/DatabaseListContainer.tsx
index 2e6ed35e132..437bd24fe56 100644
--- a/frontend/src/metabase/reference/databases/DatabaseListContainer.tsx
+++ b/frontend/src/metabase/reference/databases/DatabaseListContainer.tsx
@@ -53,4 +53,5 @@ function DatabaseListContainer(props: DatabaseListContainerProps) {
export default connect(
null,
mapDispatchToProps,
+ // Unjustified type cast. FIXME
)(DatabaseListContainer as unknown as React.ComponentType);
diff --git a/frontend/src/metabase/reference/databases/FieldDetail.tsx b/frontend/src/metabase/reference/databases/FieldDetail.tsx
index 9eed2bd7b05..6ca234feec6 100644
--- a/frontend/src/metabase/reference/databases/FieldDetail.tsx
+++ b/frontend/src/metabase/reference/databases/FieldDetail.tsx
@@ -55,6 +55,7 @@ const interestingQuestions = (
link: getQuestionUrl({
dbId: database.id,
tableId: table.id,
+ // Unjustified type cast. FIXME
fieldId: field.id as FieldId,
getCount: true,
visualization: "bar",
@@ -67,6 +68,7 @@ const interestingQuestions = (
link: getQuestionUrl({
dbId: database.id,
tableId: table.id,
+ // Unjustified type cast. FIXME
fieldId: field.id as FieldId,
getCount: true,
visualization: "pie",
@@ -79,6 +81,7 @@ const interestingQuestions = (
link: getQuestionUrl({
dbId: database.id,
tableId: table.id,
+ // Unjustified type cast. FIXME
fieldId: field.id as FieldId,
metadata,
}),
@@ -287,4 +290,5 @@ const FieldDetail = (props: FieldDetailProps) => {
export default connect(
mapStateToProps,
mapDispatchToProps,
+ // Unjustified type cast. FIXME
)(FieldDetail as unknown as React.ComponentType);
diff --git a/frontend/src/metabase/reference/databases/FieldDetailContainer.tsx b/frontend/src/metabase/reference/databases/FieldDetailContainer.tsx
index 14aaef312b8..5fccc648271 100644
--- a/frontend/src/metabase/reference/databases/FieldDetailContainer.tsx
+++ b/frontend/src/metabase/reference/databases/FieldDetailContainer.tsx
@@ -104,5 +104,6 @@ export default withRouteProps(
connect(
mapStateToProps,
mapDispatchToProps,
+ // Unjustified type cast. FIXME
)(FieldDetailContainer as unknown as React.ComponentType<InjectedRouteProps>),
);
diff --git a/frontend/src/metabase/reference/databases/FieldList.tsx b/frontend/src/metabase/reference/databases/FieldList.tsx
index 5f87a1bcab8..de1abd1eb44 100644
--- a/frontend/src/metabase/reference/databases/FieldList.tsx
+++ b/frontend/src/metabase/reference/databases/FieldList.tsx
@@ -128,6 +128,7 @@ const FieldList = (props: FieldListProps) => {
style={style}
className={CS.full}
onSubmit={handleSubmit}
+ // Unjustified type cast. FIXME
{...({ testID: props["data-testid"] } as Record<string, unknown>)}
>
{isEditing && (
@@ -189,9 +190,11 @@ const FieldList = (props: FieldListProps) => {
databaseId={table.db_id!}
field={entity}
url={`/reference/databases/${table.db_id}/tables/${table.id}/fields/${entity.id}`}
+ // Unjustified type cast. FIXME
icon={getIconForField(entity) as IconName}
isEditing={isEditing}
formField={getNestedFormField(
+ // Unjustified type cast. FIXME
entity.id as FieldId,
)}
/>
@@ -216,4 +219,5 @@ const FieldList = (props: FieldListProps) => {
export default connect(
mapStateToProps,
mapDispatchToProps,
+ // Unjustified type cast. FIXME
)(FieldList as unknown as React.ComponentType);
diff --git a/frontend/src/metabase/reference/databases/FieldListContainer.tsx b/frontend/src/metabase/reference/databases/FieldListContainer.tsx
index fa5d1b24a9d..a962d12e816 100644
--- a/frontend/src/metabase/reference/databases/FieldListContainer.tsx
+++ b/frontend/src/metabase/reference/databases/FieldListContainer.tsx
@@ -97,5 +97,6 @@ export default withRouteProps(
connect(
mapStateToProps,
mapDispatchToProps,
+ // Unjustified type cast. FIXME
)(FieldListContainer as unknown as React.ComponentType<InjectedRouteProps>),
);
diff --git a/frontend/src/metabase/reference/databases/TableDetail.tsx b/frontend/src/metabase/reference/databases/TableDetail.tsx
index 92a19a5e745..b69abb14b6c 100644
--- a/frontend/src/metabase/reference/databases/TableDetail.tsx
+++ b/frontend/src/metabase/reference/databases/TableDetail.tsx
@@ -245,4 +245,5 @@ const TableDetail = (props: TableDetailProps) => {
export default connect(
mapStateToProps,
mapDispatchToProps,
+ // Unjustified type cast. FIXME
)(TableDetail as unknown as React.ComponentType);
diff --git a/frontend/src/metabase/reference/databases/TableDetailContainer.tsx b/frontend/src/metabase/reference/databases/TableDetailContainer.tsx
index d1709089db2..60d3f766e22 100644
--- a/frontend/src/metabase/reference/databases/TableDetailContainer.tsx
+++ b/frontend/src/metabase/reference/databases/TableDetailContainer.tsx
@@ -97,5 +97,6 @@ export default withRouteProps(
connect(
mapStateToProps,
mapDispatchToProps,
+ // Unjustified type cast. FIXME
)(TableDetailContainer as unknown as React.ComponentType<InjectedRouteProps>),
);
diff --git a/frontend/src/metabase/reference/databases/TableList.tsx b/frontend/src/metabase/reference/databases/TableList.tsx
index 8aede6db766..e051d9761a0 100644
--- a/frontend/src/metabase/reference/databases/TableList.tsx
+++ b/frontend/src/metabase/reference/databases/TableList.tsx
@@ -154,4 +154,5 @@ class TableList extends Component<TableListProps> {
export default connect(
mapStateToProps,
mapDispatchToProps,
+ // Unjustified type cast. FIXME
)(TableList as unknown as React.ComponentType);
diff --git a/frontend/src/metabase/reference/databases/TableListContainer.tsx b/frontend/src/metabase/reference/databases/TableListContainer.tsx
index 77f9105ad19..507d20afe4b 100644
--- a/frontend/src/metabase/reference/databases/TableListContainer.tsx
+++ b/frontend/src/metabase/reference/databases/TableListContainer.tsx
@@ -90,5 +90,6 @@ export default withRouteProps(
connect(
mapStateToProps,
mapDispatchToProps,
+ // Unjustified type cast. FIXME
)(TableListContainer as unknown as React.ComponentType<InjectedRouteProps>),
);
diff --git a/frontend/src/metabase/reference/databases/TableQuestions.tsx b/frontend/src/metabase/reference/databases/TableQuestions.tsx
index 3a356a7a4cc..55409615d7b 100644
--- a/frontend/src/metabase/reference/databases/TableQuestions.tsx
+++ b/frontend/src/metabase/reference/databases/TableQuestions.tsx
@@ -117,4 +117,5 @@ class TableQuestions extends Component<TableQuestionsProps> {
export default connect(
mapStateToProps,
mapDispatchToProps,
+ // Unjustified type cast. FIXME
)(TableQuestions as unknown as React.ComponentType);
diff --git a/frontend/src/metabase/reference/databases/TableQuestionsContainer.tsx b/frontend/src/metabase/reference/databases/TableQuestionsContainer.tsx
index f764c76bbfe..fdc1b02e4df 100644
--- a/frontend/src/metabase/reference/databases/TableQuestionsContainer.tsx
+++ b/frontend/src/metabase/reference/databases/TableQuestionsContainer.tsx
@@ -107,6 +107,7 @@ export default withRouteProps(
mapStateToProps,
mapDispatchToProps,
)(
+ // Unjustified type cast. FIXME
TableQuestionsContainer as unknown as React.ComponentType<InjectedRouteProps>,
),
);
diff --git a/frontend/src/metabase/reference/segments/SegmentDetail.tsx b/frontend/src/metabase/reference/segments/SegmentDetail.tsx
index 38f279f0f5e..68165496a0d 100644
--- a/frontend/src/metabase/reference/segments/SegmentDetail.tsx
+++ b/frontend/src/metabase/reference/segments/SegmentDetail.tsx
@@ -303,4 +303,5 @@ const SegmentDetail = (props: SegmentDetailProps) => {
export default connect(
mapStateToProps,
mapDispatchToProps,
+ // Unjustified type cast. FIXME
)(SegmentDetail as unknown as React.ComponentType);
diff --git a/frontend/src/metabase/reference/segments/SegmentDetailContainer.tsx b/frontend/src/metabase/reference/segments/SegmentDetailContainer.tsx
index 076b8fb2ee0..69200df4b91 100644
--- a/frontend/src/metabase/reference/segments/SegmentDetailContainer.tsx
+++ b/frontend/src/metabase/reference/segments/SegmentDetailContainer.tsx
@@ -94,6 +94,7 @@ export default withRouteProps(
mapStateToProps,
mapDispatchToProps,
)(
+ // Unjustified type cast. FIXME
SegmentDetailContainer as unknown as React.ComponentType<InjectedRouteProps>,
),
);
diff --git a/frontend/src/metabase/reference/segments/SegmentFieldDetail.tsx b/frontend/src/metabase/reference/segments/SegmentFieldDetail.tsx
index a4a739e1afd..b052a497b7d 100644
--- a/frontend/src/metabase/reference/segments/SegmentFieldDetail.tsx
+++ b/frontend/src/metabase/reference/segments/SegmentFieldDetail.tsx
@@ -55,6 +55,7 @@ const interestingQuestions = (
link: getQuestionUrl({
dbId: table.db_id!,
tableId: table.id,
+ // Unjustified type cast. FIXME
fieldId: field.id as FieldId,
getCount: true,
metadata,
@@ -66,6 +67,7 @@ const interestingQuestions = (
link: getQuestionUrl({
dbId: table.db_id!,
tableId: table.id,
+ // Unjustified type cast. FIXME
fieldId: field.id as FieldId,
metadata,
}),
@@ -256,4 +258,5 @@ const SegmentFieldDetail = (props: SegmentFieldDetailProps) => {
export default connect(
mapStateToProps,
mapDispatchToProps,
+ // Unjustified type cast. FIXME
)(SegmentFieldDetail as unknown as React.ComponentType);
diff --git a/frontend/src/metabase/reference/segments/SegmentFieldDetailContainer.tsx b/frontend/src/metabase/reference/segments/SegmentFieldDetailContainer.tsx
index 6013f02f272..d4e004264c5 100644
--- a/frontend/src/metabase/reference/segments/SegmentFieldDetailContainer.tsx
+++ b/frontend/src/metabase/reference/segments/SegmentFieldDetailContainer.tsx
@@ -95,6 +95,7 @@ export default withRouteProps(
mapStateToProps,
mapDispatchToProps,
)(
+ // Unjustified type cast. FIXME
SegmentFieldDetailContainer as unknown as React.ComponentType<InjectedRouteProps>,
),
);
diff --git a/frontend/src/metabase/reference/segments/SegmentFieldList.tsx b/frontend/src/metabase/reference/segments/SegmentFieldList.tsx
index 9d00c479cb3..d121d5a1db9 100644
--- a/frontend/src/metabase/reference/segments/SegmentFieldList.tsx
+++ b/frontend/src/metabase/reference/segments/SegmentFieldList.tsx
@@ -188,8 +188,10 @@ const SegmentFieldList = (props: SegmentFieldListProps) => {
databaseId={table.db_id!}
field={entity}
url={`/reference/segments/${segment.id}/fields/${entity.id}`}
+ // Unjustified type cast. FIXME
icon={getIconForField(entity) as IconName}
isEditing={isEditing}
+ // Unjustified type cast. FIXME
formField={getNestedFormField(entity.id as FieldId)}
/>
</li>
@@ -213,4 +215,5 @@ const SegmentFieldList = (props: SegmentFieldListProps) => {
export default connect(
mapStateToProps,
mapDispatchToProps,
+ // Unjustified type cast. FIXME
)(SegmentFieldList as unknown as React.ComponentType);
diff --git a/frontend/src/metabase/reference/segments/SegmentFieldListContainer.tsx b/frontend/src/metabase/reference/segments/SegmentFieldListContainer.tsx
index e38c75159fe..cf16bc86446 100644
--- a/frontend/src/metabase/reference/segments/SegmentFieldListContainer.tsx
+++ b/frontend/src/metabase/reference/segments/SegmentFieldListContainer.tsx
@@ -104,6 +104,7 @@ export default withRouteProps(
mapStateToProps,
mapDispatchToProps,
)(
+ // Unjustified type cast. FIXME
SegmentFieldListContainer as unknown as React.ComponentType<InjectedRouteProps>,
),
);
diff --git a/frontend/src/metabase/reference/segments/SegmentListContainer.tsx b/frontend/src/metabase/reference/segments/SegmentListContainer.tsx
index fb9b6b7bdcf..395c570b0d1 100644
--- a/frontend/src/metabase/reference/segments/SegmentListContainer.tsx
+++ b/frontend/src/metabase/reference/segments/SegmentListContainer.tsx
@@ -85,5 +85,6 @@ export default withRouteProps(
connect(
mapStateToProps,
mapDispatchToProps,
+ // Unjustified type cast. FIXME
)(SegmentListContainer as unknown as React.ComponentType<InjectedRouteProps>),
);
diff --git a/frontend/src/metabase/reference/segments/SegmentQuestions.tsx b/frontend/src/metabase/reference/segments/SegmentQuestions.tsx
index 468e7dc3035..e488dbfce61 100644
--- a/frontend/src/metabase/reference/segments/SegmentQuestions.tsx
+++ b/frontend/src/metabase/reference/segments/SegmentQuestions.tsx
@@ -71,6 +71,7 @@ const SegmentQuestionsInner = ({
isLoading,
error,
} = useQuestionListQuery({
+ // Unjustified type cast. FIXME
query: { f: "using_segment" as any, model_id: segment.id },
});
@@ -119,4 +120,5 @@ const SegmentQuestionsInner = ({
export const SegmentQuestions = connect(
mapStateToProps,
mapDispatchToProps,
+ // Unjustified type cast. FIXME
)(SegmentQuestionsInner as unknown as React.ComponentType);
diff --git a/frontend/src/metabase/reference/segments/SegmentQuestionsContainer.tsx b/frontend/src/metabase/reference/segments/SegmentQuestionsContainer.tsx
index d3234b4ad1c..e8bdb493024 100644
--- a/frontend/src/metabase/reference/segments/SegmentQuestionsContainer.tsx
+++ b/frontend/src/metabase/reference/segments/SegmentQuestionsContainer.tsx
@@ -101,6 +101,7 @@ export default withRouteProps(
mapStateToProps,
mapDispatchToProps,
)(
+ // Unjustified type cast. FIXME
SegmentQuestionsContainer as unknown as React.ComponentType<InjectedRouteProps>,
),
);
diff --git a/frontend/src/metabase/reference/segments/SegmentRevisions.tsx b/frontend/src/metabase/reference/segments/SegmentRevisions.tsx
index cbb5ca0a897..deda144afab 100644
--- a/frontend/src/metabase/reference/segments/SegmentRevisions.tsx
+++ b/frontend/src/metabase/reference/segments/SegmentRevisions.tsx
@@ -117,6 +117,7 @@ class SegmentRevisions extends Component<SegmentRevisionsProps> {
currentUser={user || {}}
userColor={
userColorAssignments[
+ // Unjustified type cast. FIXME
getIn(revision, ["user", "id"]) as string
]
}
@@ -143,4 +144,5 @@ class SegmentRevisions extends Component<SegmentRevisionsProps> {
export default connect(
mapStateToProps,
mapDispatchToProps,
+ // Unjustified type cast. FIXME
)(SegmentRevisions as unknown as React.ComponentType);
diff --git a/frontend/src/metabase/reference/segments/SegmentRevisionsContainer.tsx b/frontend/src/metabase/reference/segments/SegmentRevisionsContainer.tsx
index 9f5dd8fbeea..ecbe1ac06e2 100644
--- a/frontend/src/metabase/reference/segments/SegmentRevisionsContainer.tsx
+++ b/frontend/src/metabase/reference/segments/SegmentRevisionsContainer.tsx
@@ -96,6 +96,7 @@ export default withRouteProps(
mapStateToProps,
mapDispatchToProps,
)(
+ // Unjustified type cast. FIXME
SegmentRevisionsContainer as unknown as React.ComponentType<InjectedRouteProps>,
),
);
diff --git a/frontend/src/metabase/reference/selectors.ts b/frontend/src/metabase/reference/selectors.ts
index 4b2467d4a9e..4f5ce3e61c9 100644
--- a/frontend/src/metabase/reference/selectors.ts
+++ b/frontend/src/metabase/reference/selectors.ts
@@ -130,6 +130,7 @@ export const getTableQuestions = createSelector(
[getTable, getQuestions],
(table, questions): Card[] => {
const tableId = table.id;
+ // Unjustified type cast. FIXME
return Object.values(questions as Record<string, Card>).filter(
(question) => question.table_id === tableId,
);
@@ -137,9 +138,11 @@ export const getTableQuestions = createSelector(
);
export const getLoading = (state: State) =>
+ // Unjustified type cast. FIXME
(state as StateWithReference).reference.isLoading;
export const getError = (state: State) =>
+ // Unjustified type cast. FIXME
(state as StateWithReference).reference.error;
export const getHasSingleSchema = createSelector(
@@ -156,6 +159,7 @@ export const getHasSingleSchema = createSelector(
);
export const getIsEditing = (state: State) =>
+ // Unjustified type cast. FIXME
(state as StateWithReference).reference.isEditing;
export const getIsFormulaExpanded = (state: StateWithReference) =>
diff --git a/frontend/src/metabase/reference/utils.unit.spec.ts b/frontend/src/metabase/reference/utils.unit.spec.ts
index 550ff61469a..225ad2f7e9b 100644
--- a/frontend/src/metabase/reference/utils.unit.spec.ts
+++ b/frontend/src/metabase/reference/utils.unit.spec.ts
@@ -51,6 +51,7 @@ describe("Reference utils.js", () => {
const segment = createMockSegment({ table_id: tableId });
const segmentId = segment.id;
const field = createMockField({ table_id: tableId });
+ // Unjustified type cast. FIXME
const fieldId = field.id as number;
const table = createMockTable({
id: tableId,
diff --git a/frontend/src/metabase/rich_text_editing/tiptap/components/CommentsButton.tsx b/frontend/src/metabase/rich_text_editing/tiptap/components/CommentsButton.tsx
index 6ab08216587..e69d72e41dc 100644
--- a/frontend/src/metabase/rich_text_editing/tiptap/components/CommentsButton.tsx
+++ b/frontend/src/metabase/rich_text_editing/tiptap/components/CommentsButton.tsx
@@ -21,6 +21,7 @@ export const CommentsButton = <C extends ElementType = "button">({
}
px="sm"
size="xs"
+ // Unjustified type cast. FIXME
{...(props as ButtonProps)}
>
{unresolvedCommentsCount > 0 ? unresolvedCommentsCount : null}
diff --git a/frontend/src/metabase/rich_text_editing/tiptap/extensions/CardEmbed/CardEmbedNode.tsx b/frontend/src/metabase/rich_text_editing/tiptap/extensions/CardEmbed/CardEmbedNode.tsx
index a7311d5e127..7dce230ea30 100644
--- a/frontend/src/metabase/rich_text_editing/tiptap/extensions/CardEmbed/CardEmbedNode.tsx
+++ b/frontend/src/metabase/rich_text_editing/tiptap/extensions/CardEmbed/CardEmbedNode.tsx
@@ -669,6 +669,7 @@ export const CardEmbedComponent = memo(
) : (
<Box className={styles.questionResults}>
<ChartSkeleton
+ // Unjustified type cast. FIXME
display={(card?.display as CardDisplayType) || "table"}
/>
</Box>
diff --git a/frontend/src/metabase/rich_text_editing/tiptap/extensions/Command/CommandSuggestion.unit.spec.tsx b/frontend/src/metabase/rich_text_editing/tiptap/extensions/Command/CommandSuggestion.unit.spec.tsx
index 44d30c97f9c..06abaaedfc5 100644
--- a/frontend/src/metabase/rich_text_editing/tiptap/extensions/Command/CommandSuggestion.unit.spec.tsx
+++ b/frontend/src/metabase/rich_text_editing/tiptap/extensions/Command/CommandSuggestion.unit.spec.tsx
@@ -139,6 +139,7 @@ const setup = ({
renderWithProviders(
<TestWrapper
command={command}
+ // Unjustified type cast. FIXME
editor={editor as unknown as Editor}
query={query}
items={[]}
@@ -370,6 +371,7 @@ describe("CommandSuggestion", () => {
renderWithProviders(
<TestWrapper
command={command}
+ // Unjustified type cast. FIXME
editor={editor as unknown as Editor}
query=""
items={[]}
@@ -411,6 +413,7 @@ describe("CommandSuggestion", () => {
renderWithProviders(
<TestWrapper
command={command}
+ // Unjustified type cast. FIXME
editor={editor as unknown as Editor}
query=""
items={[]}
diff --git a/frontend/src/metabase/rich_text_editing/tiptap/extensions/Emoji/EmojiSuggestionExtension.tsx b/frontend/src/metabase/rich_text_editing/tiptap/extensions/Emoji/EmojiSuggestionExtension.tsx
index 05154923805..d6e8878c9fb 100644
--- a/frontend/src/metabase/rich_text_editing/tiptap/extensions/Emoji/EmojiSuggestionExtension.tsx
+++ b/frontend/src/metabase/rich_text_editing/tiptap/extensions/Emoji/EmojiSuggestionExtension.tsx
@@ -59,6 +59,7 @@ export const EmojiSuggestionExtension =
range: Range;
props: { emoji?: string };
}) => {
+ // Unjustified type cast. FIXME
const emoji = (props as any)?.emoji as string | undefined;
if (!emoji) {
return;
@@ -234,6 +235,7 @@ function renderEmojiPicker() {
// Helpers
function setEmojiPopupOpen(editor: Editor, isOpen: boolean) {
try {
+ // Unjustified type cast. FIXME
const storage = (editor.storage as any).emojiSuggestion;
if (storage) {
storage.isEmojiPopupOpen = isOpen;
diff --git a/frontend/src/metabase/rich_text_editing/tiptap/extensions/FlexContainer/FlexContainer.tsx b/frontend/src/metabase/rich_text_editing/tiptap/extensions/FlexContainer/FlexContainer.tsx
index 3a2bbe1b296..363331ddb54 100644
--- a/frontend/src/metabase/rich_text_editing/tiptap/extensions/FlexContainer/FlexContainer.tsx
+++ b/frontend/src/metabase/rich_text_editing/tiptap/extensions/FlexContainer/FlexContainer.tsx
@@ -231,6 +231,7 @@ const FlexContainerComponent: React.FC<NodeViewProps> = ({
<NodeViewContent
className={styles.flexContent}
style={
+ // Unjustified type cast. FIXME
{
"--mb-card-container-col-widths": columnWidths
.map(
diff --git a/frontend/src/metabase/rich_text_editing/tiptap/extensions/Heading/Heading.tsx b/frontend/src/metabase/rich_text_editing/tiptap/extensions/Heading/Heading.tsx
index cc6636f999e..59dc02fd06c 100644
--- a/frontend/src/metabase/rich_text_editing/tiptap/extensions/Heading/Heading.tsx
+++ b/frontend/src/metabase/rich_text_editing/tiptap/extensions/Heading/Heading.tsx
@@ -54,6 +54,7 @@ export const HeadingNodeView = ({
getPos={getPos}
hideMenus={extension.options.editorContext === "comments"}
>
+ {/* Unjustified type cast. FIXME */}
<NodeViewContent<ElementType> as={levelNodeMap[level as Level] ?? "h1"} />
</BlockShell>
);
diff --git a/frontend/src/metabase/rich_text_editing/tiptap/extensions/LinkHoverMenu/LinkHoverMenu.tsx b/frontend/src/metabase/rich_text_editing/tiptap/extensions/LinkHoverMenu/LinkHoverMenu.tsx
index 4b5fadf35e7..bd3cae8b47e 100644
--- a/frontend/src/metabase/rich_text_editing/tiptap/extensions/LinkHoverMenu/LinkHoverMenu.tsx
+++ b/frontend/src/metabase/rich_text_editing/tiptap/extensions/LinkHoverMenu/LinkHoverMenu.tsx
@@ -52,6 +52,7 @@ export const LinkHoverMenu = ({ editor, editable }: LinkHoverMenuProps) => {
}
const handleMouseOver = (event: MouseEvent) => {
+ // Unjustified type cast. FIXME
const target = event.target as HTMLElement;
if (target.tagName === "A" && target.classList.contains(S.plainLink)) {
clearHoverTimeout();
@@ -60,6 +61,7 @@ export const LinkHoverMenu = ({ editor, editable }: LinkHoverMenuProps) => {
};
const handleMouseOut = (event: MouseEvent) => {
+ // Unjustified type cast. FIXME
const target = event.target as HTMLElement;
if (target.tagName === "A" && target.classList.contains(S.plainLink)) {
startHoverTimeout();
diff --git a/frontend/src/metabase/rich_text_editing/tiptap/extensions/Mention/MentionSuggestion.unit.spec.tsx b/frontend/src/metabase/rich_text_editing/tiptap/extensions/Mention/MentionSuggestion.unit.spec.tsx
index 2cb88398067..ea4b84ea811 100644
--- a/frontend/src/metabase/rich_text_editing/tiptap/extensions/Mention/MentionSuggestion.unit.spec.tsx
+++ b/frontend/src/metabase/rich_text_editing/tiptap/extensions/Mention/MentionSuggestion.unit.spec.tsx
@@ -58,6 +58,7 @@ const setup = (props: SetupProps = {}) => {
run: jest.fn().mockReturnThis(),
};
+ // Unjustified type cast. FIXME
const editor = {
commands: {
focus: jest.fn(),
diff --git a/frontend/src/metabase/rich_text_editing/tiptap/extensions/MetabotEmbed/MetabotEmbed.tsx b/frontend/src/metabase/rich_text_editing/tiptap/extensions/MetabotEmbed/MetabotEmbed.tsx
index fd2509ae13d..db84c341b98 100644
--- a/frontend/src/metabase/rich_text_editing/tiptap/extensions/MetabotEmbed/MetabotEmbed.tsx
+++ b/frontend/src/metabase/rich_text_editing/tiptap/extensions/MetabotEmbed/MetabotEmbed.tsx
@@ -197,6 +197,7 @@ export const MetabotComponent = memo(
const card: Card = {
...data.draft_card,
id: newCardId,
+ // Unjustified type cast. FIXME
entity_id: "entity_id" as Card["entity_id"],
created_at: "",
updated_at: "",
diff --git a/frontend/src/metabase/rich_text_editing/tiptap/extensions/MetabotEmbed/__support__/editor-mocks.ts b/frontend/src/metabase/rich_text_editing/tiptap/extensions/MetabotEmbed/__support__/editor-mocks.ts
index 50c1d4c4386..d7278ee42a5 100644
--- a/frontend/src/metabase/rich_text_editing/tiptap/extensions/MetabotEmbed/__support__/editor-mocks.ts
+++ b/frontend/src/metabase/rich_text_editing/tiptap/extensions/MetabotEmbed/__support__/editor-mocks.ts
@@ -1,6 +1,7 @@
import type { Editor } from "@tiptap/react";
export const createMockEditor = (overrides: Partial<Editor> = {}): Editor =>
+ // Unjustified type cast. FIXME
({
on: jest.fn(),
off: jest.fn(),
diff --git a/frontend/src/metabase/rich_text_editing/tiptap/extensions/MetabotEmbed/__support__/node-view-mocks.ts b/frontend/src/metabase/rich_text_editing/tiptap/extensions/MetabotEmbed/__support__/node-view-mocks.ts
index e56a537b47f..aa2fafd9ea2 100644
--- a/frontend/src/metabase/rich_text_editing/tiptap/extensions/MetabotEmbed/__support__/node-view-mocks.ts
+++ b/frontend/src/metabase/rich_text_editing/tiptap/extensions/MetabotEmbed/__support__/node-view-mocks.ts
@@ -5,6 +5,7 @@ import type { Extension, NodeViewProps } from "@tiptap/react";
import { createMockEditor } from "./editor-mocks";
export const createMockProseMirrorNode = (overrides = {}): ProseMirrorNode =>
+ // Unjustified type cast. FIXME
({
textContent: "",
content: { content: [] },
@@ -17,6 +18,7 @@ export const createMockProseMirrorNode = (overrides = {}): ProseMirrorNode =>
}) as unknown as ProseMirrorNode;
export const createMockExtension = (overrides = {}): Extension =>
+ // Unjustified type cast. FIXME
({
name: "my-extension",
options: {},
@@ -24,6 +26,7 @@ export const createMockExtension = (overrides = {}): Extension =>
}) as unknown as Extension;
export const createMockNodeViewProps = (overrides = {}): NodeViewProps =>
+ // Unjustified type cast. FIXME
({
editor: createMockEditor(),
node: createMockProseMirrorNode(),
@@ -32,7 +35,9 @@ export const createMockNodeViewProps = (overrides = {}): NodeViewProps =>
updateAttributes: jest.fn(),
decorations: [],
selected: false,
+ // Unjustified type cast. FIXME
view: {} as unknown as EditorView,
+ // Unjustified type cast. FIXME
innerDecorations: {} as unknown as DecorationSource,
HTMLAttributes: {},
extension: createMockExtension(),
diff --git a/frontend/src/metabase/rich_text_editing/tiptap/extensions/MetabotMention/MetabotSuggestionNew.unit.spec.tsx b/frontend/src/metabase/rich_text_editing/tiptap/extensions/MetabotMention/MetabotSuggestionNew.unit.spec.tsx
index a8fd18ff11b..16d3e954a3a 100644
--- a/frontend/src/metabase/rich_text_editing/tiptap/extensions/MetabotMention/MetabotSuggestionNew.unit.spec.tsx
+++ b/frontend/src/metabase/rich_text_editing/tiptap/extensions/MetabotMention/MetabotSuggestionNew.unit.spec.tsx
@@ -57,6 +57,7 @@ const setup = (props: Partial<MetabotMentionSuggestionProps> = {}) => {
const onClose = jest.fn();
const ref = createRef<BareSuggestionRendererRef>();
const focusMock = jest.fn();
+ // Unjustified type cast. FIXME
const editor = {
commands: {
focus: focusMock,
diff --git a/frontend/src/metabase/rich_text_editing/tiptap/extensions/SmartLink/SmartLinkNode.tsx b/frontend/src/metabase/rich_text_editing/tiptap/extensions/SmartLink/SmartLinkNode.tsx
index ff49382e725..89da55dfdd8 100644
--- a/frontend/src/metabase/rich_text_editing/tiptap/extensions/SmartLink/SmartLinkNode.tsx
+++ b/frontend/src/metabase/rich_text_editing/tiptap/extensions/SmartLink/SmartLinkNode.tsx
@@ -512,6 +512,7 @@ export const SmartLinkComponent = memo(
? getIcon(cachedEntity)
: getIcon(
entityToObjectWithModel(
+ // Unjustified type cast. FIXME
entity as NonNullable<typeof networkEntity>,
model,
),
@@ -556,8 +557,11 @@ function entityToObjectWithModel(
model: SuggestionModel | null,
): ObjectWithModel {
return {
+ // Unjustified type cast. FIXME
model: ((entity as Dashboard).model || model || "") as IconModel,
+ // Unjustified type cast. FIXME
display: (entity as Card).display,
+ // Unjustified type cast. FIXME
is_personal: (entity as Collection).is_personal,
};
}
diff --git a/frontend/src/metabase/rich_text_editing/tiptap/extensions/SmartLink/SmartLinkNode.unit.spec.tsx b/frontend/src/metabase/rich_text_editing/tiptap/extensions/SmartLink/SmartLinkNode.unit.spec.tsx
index 537e3945000..05cd7d7ee64 100644
--- a/frontend/src/metabase/rich_text_editing/tiptap/extensions/SmartLink/SmartLinkNode.unit.spec.tsx
+++ b/frontend/src/metabase/rich_text_editing/tiptap/extensions/SmartLink/SmartLinkNode.unit.spec.tsx
@@ -31,6 +31,7 @@ function createProps(
updateAttributes?: NodeViewProps["updateAttributes"],
) {
const node = { attrs: { entityId: entity.id, model, label } };
+ // Unjustified type cast. FIXME
return {
node,
updateAttributes: updateAttributes ?? jest.fn(),
diff --git a/frontend/src/metabase/rich_text_editing/tiptap/extensions/shared/suggestionUtils.ts b/frontend/src/metabase/rich_text_editing/tiptap/extensions/shared/suggestionUtils.ts
index b6cb9147ca1..f7e7d1c28de 100644
--- a/frontend/src/metabase/rich_text_editing/tiptap/extensions/shared/suggestionUtils.ts
+++ b/frontend/src/metabase/rich_text_editing/tiptap/extensions/shared/suggestionUtils.ts
@@ -36,11 +36,13 @@ export function entityToUrlableModel<
},
>(entity: T, model: SuggestionModel | null): UrlableModel {
const result: UrlableModel = {
+ // Unjustified type cast. FIXME
id: entity.id as number, // it is string | number in reality, but then gets casted to a string in "modelToUrl"
model: model || "",
name: isMentionableUser(entity)
? entity.common_name
- : (entity.name as string),
+ : // Unjustified type cast. FIXME
+ (entity.name as string),
};
if ("db_id" in entity && entity.db_id) {
@@ -65,6 +67,7 @@ export function mbProtocolModelToSuggestionModel(inputModel: string): string {
// data. casting here still afford some amount of internal type awareness as these
// two types might diverge in the future.
const model: SuggestionModel = match(
+ // Unjustified type cast. FIXME
inputModel as MetabaseProtocolEntityModel,
)
.with("model", () => "dataset" as const)
diff --git a/frontend/src/metabase/router/Navigate.unit.spec.tsx b/frontend/src/metabase/router/Navigate.unit.spec.tsx
index e81b9b9b94a..bf6addb6b31 100644
--- a/frontend/src/metabase/router/Navigate.unit.spec.tsx
+++ b/frontend/src/metabase/router/Navigate.unit.spec.tsx
@@ -98,6 +98,7 @@ describe("router/Navigate", () => {
expect(history?.getCurrentLocation().pathname).toBe("/dest"),
);
+ // Unjustified type cast. FIXME
const state = history?.getCurrentLocation().state as typeof RICH_STATE;
// Serializing would turn the Date into a string and NaN into null.
expect(state.when).toBe(RICH_STATE.when);
diff --git a/frontend/src/metabase/router/conformance/Navigate.conformance.unit.spec.tsx b/frontend/src/metabase/router/conformance/Navigate.conformance.unit.spec.tsx
index b29ea5c8f42..14bc346fe5c 100644
--- a/frontend/src/metabase/router/conformance/Navigate.conformance.unit.spec.tsx
+++ b/frontend/src/metabase/router/conformance/Navigate.conformance.unit.spec.tsx
@@ -42,6 +42,7 @@ const RICH_STATE = { when: new Date(0), n: NaN };
function StateProbe({ api }: { api: RouterApi }) {
const { Navigate } = api;
const location = api.useLocation();
+ // Unjustified type cast. FIXME
const state = location.state as typeof RICH_STATE | null;
return (
<div>
diff --git a/frontend/src/metabase/router/react-router.ts b/frontend/src/metabase/router/react-router.ts
index 6a074074f4a..59aa1642622 100644
--- a/frontend/src/metabase/router/react-router.ts
+++ b/frontend/src/metabase/router/react-router.ts
@@ -44,7 +44,9 @@ export type IndexRouteProps = Omit<BaseIndexRouteProps, LifecycleHook>;
// `react-router` exports each of these as both a value and a type, so mirror that.
export type Route = ComponentClass<RouteProps>;
+// Unjustified type cast. FIXME
export const Route = BaseRoute as Route;
export type IndexRoute = ComponentClass<IndexRouteProps>;
+// Unjustified type cast. FIXME
export const IndexRoute = BaseIndexRoute as IndexRoute;
diff --git a/frontend/src/metabase/router/use-params.ts b/frontend/src/metabase/router/use-params.ts
index d7bd8e6c699..22a68ee69f7 100644
--- a/frontend/src/metabase/router/use-params.ts
+++ b/frontend/src/metabase/router/use-params.ts
@@ -19,10 +19,12 @@ export function useParams<
const params = useRouter().params;
if (!("splat" in params)) {
+ // Unjustified type cast. FIXME
return params as Result;
}
const { splat, ...rest } = params;
const remapped: typeof params = { ...rest, "*": splat };
+ // Unjustified type cast. FIXME
return remapped as Result;
}
diff --git a/frontend/src/metabase/search/components/SearchUserPicker/SearchUserPicker.styled.tsx b/frontend/src/metabase/search/components/SearchUserPicker/SearchUserPicker.styled.tsx
index 17d5b5fd6ab..6c6f4953a30 100644
--- a/frontend/src/metabase/search/components/SearchUserPicker/SearchUserPicker.styled.tsx
+++ b/frontend/src/metabase/search/components/SearchUserPicker/SearchUserPicker.styled.tsx
@@ -29,6 +29,7 @@ export const SearchUserSelectBox = styled(Stack)`
border-radius: ${({ theme }) => theme.radius.md};
`;
+// Unjustified type cast. FIXME
export const SelectedUserButton = styled(Button)<
ButtonProps & HTMLAttributes<HTMLButtonElement>
>`
diff --git a/frontend/src/metabase/search/components/filters/TypeFilter/TypeFilterContent.tsx b/frontend/src/metabase/search/components/filters/TypeFilter/TypeFilterContent.tsx
index 3ed0eedc188..564f51f7e47 100644
--- a/frontend/src/metabase/search/components/filters/TypeFilter/TypeFilterContent.tsx
+++ b/frontend/src/metabase/search/components/filters/TypeFilter/TypeFilterContent.tsx
@@ -38,6 +38,7 @@ export const TypeFilterContent: SearchFilterDropdown<"type">["ContentComponent"]
data-testid="type-filter-checkbox-group"
w="100%"
value={selectedTypes}
+ // Unjustified type cast. FIXME
onChange={(value) => setSelectedTypes(value as EnabledSearchModel[])}
>
<Stack gap="md" p="md" justify="center" align="flex-start">
diff --git a/frontend/src/metabase/search/components/filters/TypeFilter/TypeFilterContent.unit.spec.tsx b/frontend/src/metabase/search/components/filters/TypeFilter/TypeFilterContent.unit.spec.tsx
index d0aeb82eca5..4192ae2e76a 100644
--- a/frontend/src/metabase/search/components/filters/TypeFilter/TypeFilterContent.unit.spec.tsx
+++ b/frontend/src/metabase/search/components/filters/TypeFilter/TypeFilterContent.unit.spec.tsx
@@ -80,6 +80,7 @@ const setup = async ({
setupSearchEndpoints(
availableModels.map((type, index) =>
createMockSearchResult({
+ // Unjustified type cast. FIXME
model: type as SearchModel,
id: index + 1,
database_id: TEST_DATABASE.id,
diff --git a/frontend/src/metabase/search/components/filters/TypeFilter/TypeFilterDisplay.unit.spec.tsx b/frontend/src/metabase/search/components/filters/TypeFilter/TypeFilterDisplay.unit.spec.tsx
index 8bf133a4dd6..8f7c11133b5 100644
--- a/frontend/src/metabase/search/components/filters/TypeFilter/TypeFilterDisplay.unit.spec.tsx
+++ b/frontend/src/metabase/search/components/filters/TypeFilter/TypeFilterDisplay.unit.spec.tsx
@@ -37,6 +37,7 @@ describe("TypeFilterDisplay", () => {
it.each(Object.keys(MODEL_TYPE_DISPLAY_NAMES))(
"should display correct text for %s type selected",
(type) => {
+ // Unjustified type cast. FIXME
const searchModelType = type as EnabledSearchModel;
setup([searchModelType]);
const expectedText: string = MODEL_TYPE_DISPLAY_NAMES[searchModelType];
diff --git a/frontend/src/metabase/search/containers/SearchApp.styled.tsx b/frontend/src/metabase/search/containers/SearchApp.styled.tsx
index 19139ac8ba9..73751f1eb8c 100644
--- a/frontend/src/metabase/search/containers/SearchApp.styled.tsx
+++ b/frontend/src/metabase/search/containers/SearchApp.styled.tsx
@@ -10,6 +10,7 @@ import { Flex, Stack } from "metabase/ui";
const SEARCH_BODY_WIDTH = "90rem";
const SEARCH_SIDEBAR_WIDTH = "18rem";
+// Unjustified type cast. FIXME
export const SearchMain = styled(Flex)`
width: min(calc(${SEARCH_BODY_WIDTH} + ${SEARCH_SIDEBAR_WIDTH}), 100%);
padding: 1.5rem 1rem;
@@ -19,6 +20,7 @@ export const SearchMain = styled(Flex)`
}
` as unknown as typeof Flex;
+// Unjustified type cast. FIXME
export const SearchBody = styled(Flex)`
flex-direction: column;
diff --git a/frontend/src/metabase/search/containers/SearchApp.tsx b/frontend/src/metabase/search/containers/SearchApp.tsx
index 05843eeccf4..3556565fa43 100644
--- a/frontend/src/metabase/search/containers/SearchApp.tsx
+++ b/frontend/src/metabase/search/containers/SearchApp.tsx
@@ -61,6 +61,7 @@ export function SearchApp({ location }: { location: SearchAwareLocation }) {
);
const models = searchFilters[SearchFilterKeys.Type];
+ // Unjustified type cast. FIXME
const query = {
q: searchText,
..._.omit(searchFilters, SearchFilterKeys.Type),
diff --git a/frontend/src/metabase/search/containers/SearchApp.unit.spec.tsx b/frontend/src/metabase/search/containers/SearchApp.unit.spec.tsx
index af1863891d7..a5d0dbaef65 100644
--- a/frontend/src/metabase/search/containers/SearchApp.unit.spec.tsx
+++ b/frontend/src/metabase/search/containers/SearchApp.unit.spec.tsx
@@ -89,6 +89,7 @@ const setup = async ({
};
const searchParams = new URLSearchParams(
+ // Unjustified type cast. FIXME
params as unknown as Record<string, string>,
).toString();
@@ -184,7 +185,9 @@ describe("SearchApp", () => {
const popover = within(screen.getByTestId("popover"));
await userEvent.click(
popover.getByRole("checkbox", {
+ // Unjustified type cast. FIXME
name: TYPE_FILTER_LABELS[
+ // Unjustified type cast. FIXME
model as EnabledSearchModel
] as EnabledSearchModel,
}),
@@ -205,6 +208,7 @@ describe("SearchApp", () => {
async ({ name, model }) => {
await setup({
searchText: name,
+ // Unjustified type cast. FIXME
searchFilters: { type: [model as EnabledSearchModel] },
});
@@ -218,6 +222,7 @@ describe("SearchApp", () => {
const fieldSetContent = typeFilter.getByTestId("field-set-content");
expect(fieldSetContent).toHaveTextContent(
+ // Unjustified type cast. FIXME
TYPE_FILTER_LABELS[model as EnabledSearchModel],
);
},
diff --git a/frontend/src/metabase/selectors/collection.ts b/frontend/src/metabase/selectors/collection.ts
index 287ac2e7f31..3c49453210a 100644
--- a/frontend/src/metabase/selectors/collection.ts
+++ b/frontend/src/metabase/selectors/collection.ts
@@ -21,6 +21,7 @@ export const getCollectionFromCollectionsTree = (
continue;
}
+ // Unjustified type cast. FIXME
const collectionsTree = queryState.data as Collection[];
const foundCollection = findCollectionById(collectionsTree, collectionId);
diff --git a/frontend/src/metabase/selectors/collection.unit.spec.ts b/frontend/src/metabase/selectors/collection.unit.spec.ts
index 5c2a4153c83..6052339ebec 100644
--- a/frontend/src/metabase/selectors/collection.unit.spec.ts
+++ b/frontend/src/metabase/selectors/collection.unit.spec.ts
@@ -8,6 +8,7 @@ import { createMockCollection } from "metabase-types/api/mocks";
import { getCollectionFromCollectionsTree } from "./collection";
const createMockStateWithCollectionsTree = (collections: Collection[]) => {
+ // Unjustified type cast. FIXME
return createMockState({
"metabase-api": {
queries: {
diff --git a/frontend/src/metabase/selectors/routing.unit.spec.ts b/frontend/src/metabase/selectors/routing.unit.spec.ts
index df29d9adf8c..1636da8c692 100644
--- a/frontend/src/metabase/selectors/routing.unit.spec.ts
+++ b/frontend/src/metabase/selectors/routing.unit.spec.ts
@@ -28,6 +28,7 @@ describe("getLocation", () => {
});
it("falls back to a default location when routing is absent", () => {
+ // Unjustified type cast. FIXME
const state = { ...createMockState(), routing: undefined } as any;
expect(getLocation(state)).toEqual(createMockLocation({ pathname: "" }));
diff --git a/frontend/src/metabase/selectors/settings.ts b/frontend/src/metabase/selectors/settings.ts
index 353fd37de74..730dc9184d5 100644
--- a/frontend/src/metabase/selectors/settings.ts
+++ b/frontend/src/metabase/selectors/settings.ts
@@ -198,6 +198,7 @@ export const getUpgradeUrl = createSelector(
source_plan: plan,
};
for (const key in searchParams) {
+ // Unjustified type cast. FIXME
const utmValue = searchParams[key as keyof typeof searchParams];
if (utmValue) {
url.searchParams.append(key, utmValue);
diff --git a/frontend/src/metabase/selectors/ui.ts b/frontend/src/metabase/selectors/ui.ts
index 6edda3edbb9..85d20e5fc88 100644
--- a/frontend/src/metabase/selectors/ui.ts
+++ b/frontend/src/metabase/selectors/ui.ts
@@ -2,4 +2,5 @@ import type { State } from "metabase/redux/store";
import type { ModalState } from "metabase/redux/store/modal";
export const getCurrentOpenModalState = <TProps>(state: State) =>
+ // Unjustified type cast. FIXME
state.modal as ModalState<TProps>;
diff --git a/frontend/src/metabase/setup/actions.unit.spec.ts b/frontend/src/metabase/setup/actions.unit.spec.ts
index c757d7be591..40d307f9aed 100644
--- a/frontend/src/metabase/setup/actions.unit.spec.ts
+++ b/frontend/src/metabase/setup/actions.unit.spec.ts
@@ -54,6 +54,7 @@ describe("submitUserInvite", () => {
});
it("tracks user_invited from setup when the create succeeds", async () => {
+ // Unjustified type cast. FIXME
(dispatch as unknown as jest.Mock).mockReturnValue({
unwrap: () => Promise.resolve(),
});
diff --git a/frontend/src/metabase/setup/components/UsageQuestionStep/UsageQuestionStep.tsx b/frontend/src/metabase/setup/components/UsageQuestionStep/UsageQuestionStep.tsx
index 5fc0ea1c82c..1454045dad5 100644
--- a/frontend/src/metabase/setup/components/UsageQuestionStep/UsageQuestionStep.tsx
+++ b/frontend/src/metabase/setup/components/UsageQuestionStep/UsageQuestionStep.tsx
@@ -39,6 +39,7 @@ export const UsageQuestionStep = ({ stepLabel }: NumberedStepProps) => {
};
const handleChange = (value: string) => {
+ // Unjustified type cast. FIXME
setUsageReason(value as UsageReason);
};
diff --git a/frontend/src/metabase/setup/tests/setup.tsx b/frontend/src/metabase/setup/tests/setup.tsx
index 1432d2baed7..60e20559afc 100644
--- a/frontend/src/metabase/setup/tests/setup.tsx
+++ b/frontend/src/metabase/setup/tests/setup.tsx
@@ -162,6 +162,7 @@ export const getLastSettingsPutPayload = async () => {
expect(lastSettingsCall).toBeTruthy();
expect(lastSettingsCall.options?.body).toBeTruthy();
+ // Unjustified type cast. FIXME
return JSON.parse((await lastSettingsCall.options.body!) as string);
};
diff --git a/frontend/src/metabase/static-viz/components/BoxPlotChart/BoxPlotChart.stories.tsx b/frontend/src/metabase/static-viz/components/BoxPlotChart/BoxPlotChart.stories.tsx
index da9fdd3cb1c..05cd99d5156 100644
--- a/frontend/src/metabase/static-viz/components/BoxPlotChart/BoxPlotChart.stories.tsx
+++ b/frontend/src/metabase/static-viz/components/BoxPlotChart/BoxPlotChart.stories.tsx
@@ -38,6 +38,7 @@ const renderingContext: RenderingContext = {
export const SingleCategory = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.singleCategory as any,
renderingContext,
},
@@ -46,6 +47,7 @@ export const SingleCategory = {
export const ManyCategories = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.manyCategories as any,
renderingContext,
},
@@ -54,6 +56,7 @@ export const ManyCategories = {
export const LabelOverflow = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.labelOverflow as any,
renderingContext,
},
@@ -62,6 +65,7 @@ export const LabelOverflow = {
export const OutlierOverflow = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.outlierOverflow as any,
renderingContext,
},
@@ -70,6 +74,7 @@ export const OutlierOverflow = {
export const PositiveNegativeCrossZeroYAxisAuto = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.positiveNegativeCrossZeroYAxisAuto as any,
renderingContext,
},
@@ -78,6 +83,7 @@ export const PositiveNegativeCrossZeroYAxisAuto = {
export const TopBottomMixedOutliers = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.topBottomMixedOutliers as any,
renderingContext,
},
@@ -86,6 +92,7 @@ export const TopBottomMixedOutliers = {
export const ScaleExtremes = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.scaleExtremes as any,
renderingContext,
},
@@ -94,6 +101,7 @@ export const ScaleExtremes = {
export const DistributionShapes = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.distributionShapes as any,
renderingContext,
},
@@ -102,6 +110,7 @@ export const DistributionShapes = {
export const LogScale = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.logScale as any,
renderingContext,
},
@@ -110,6 +119,7 @@ export const LogScale = {
export const LogScaleEdgeCases = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.logScaleEdgeCases as any,
renderingContext,
},
@@ -118,6 +128,7 @@ export const LogScaleEdgeCases = {
export const LabelFormatting = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.labelFormatting as any,
renderingContext,
},
@@ -126,6 +137,7 @@ export const LabelFormatting = {
export const MinMaxNoOutliers = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.minMaxNoOutliers as any,
renderingContext,
},
@@ -134,6 +146,7 @@ export const MinMaxNoOutliers = {
export const PowScale = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.powScale as any,
renderingContext,
},
@@ -142,6 +155,7 @@ export const PowScale = {
export const MediumDenseTemporalData = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.mediumDenseTemporalData as any,
renderingContext,
},
@@ -150,6 +164,7 @@ export const MediumDenseTemporalData = {
export const DenseTemporalData = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.denseTemporalData as any,
renderingContext,
},
@@ -158,6 +173,7 @@ export const DenseTemporalData = {
export const NumericDimensionTukey = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.numericDimensionTukey as any,
renderingContext,
},
@@ -166,6 +182,7 @@ export const NumericDimensionTukey = {
export const NumericDimensionMinMax = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.numericDimensionMinMax as any,
renderingContext,
},
@@ -174,6 +191,7 @@ export const NumericDimensionMinMax = {
export const NumericMinMaxAllPoints = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.numericMinMaxAllPoints as any,
renderingContext,
},
@@ -182,6 +200,7 @@ export const NumericMinMaxAllPoints = {
export const BoxPlotCustomization = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.boxPlotCustomization as any,
renderingContext,
},
@@ -190,6 +209,7 @@ export const BoxPlotCustomization = {
export const MultiSeriesBreakoutWithHiddenSortFormatting = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.multiSeriesBreakoutWithHiddenSortFormatting as any,
renderingContext,
},
@@ -198,6 +218,7 @@ export const MultiSeriesBreakoutWithHiddenSortFormatting = {
export const MultiSeriesTwoMetricsWithAxisSplitFormatting = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.multiSeriesTwoMetricsWithAxisSplitFormatting as any,
renderingContext,
},
diff --git a/frontend/src/metabase/static-viz/components/ComboChart/stories/ComboChart.stories.tsx b/frontend/src/metabase/static-viz/components/ComboChart/stories/ComboChart.stories.tsx
index d630e89a536..07f7ceb3c23 100644
--- a/frontend/src/metabase/static-viz/components/ComboChart/stories/ComboChart.stories.tsx
+++ b/frontend/src/metabase/static-viz/components/ComboChart/stories/ComboChart.stories.tsx
@@ -20,6 +20,7 @@ export default {
export const LineLinearXScale = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.lineLinearXScale as any,
renderingContext,
},
@@ -28,6 +29,7 @@ export const LineLinearXScale = {
export const LineLinearXScaleUnsorted = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.lineLinearXScaleUnsorted as any,
renderingContext,
},
@@ -36,6 +38,7 @@ export const LineLinearXScaleUnsorted = {
export const LogYScaleCustomYAxisRange = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.logYScaleCustomYAxisRange as any,
renderingContext,
},
@@ -44,6 +47,7 @@ export const LogYScaleCustomYAxisRange = {
export const PowYScaleCustomYAxisRange = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.powYScaleCustomYAxisRange as any,
renderingContext,
},
@@ -52,6 +56,7 @@ export const PowYScaleCustomYAxisRange = {
export const LineLogYScale = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.lineLogYScale as any,
renderingContext,
},
@@ -60,6 +65,7 @@ export const LineLogYScale = {
export const GoalLineLogYScale = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.goalLineLogYScale as any,
renderingContext,
},
@@ -68,6 +74,7 @@ export const GoalLineLogYScale = {
export const GoalLinePowYScale = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.goalLinePowYScale as any,
renderingContext,
},
@@ -76,6 +83,7 @@ export const GoalLinePowYScale = {
export const LineLogYScaleNegative = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.lineLogYScaleNegative as any,
renderingContext,
},
@@ -84,6 +92,7 @@ export const LineLogYScaleNegative = {
export const LineShowDotsAuto = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.lineShowDotsAuto as any,
renderingContext,
},
@@ -92,6 +101,7 @@ export const LineShowDotsAuto = {
export const LineShowDotsOn = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.lineShowDotsOn as any,
renderingContext,
},
@@ -100,6 +110,7 @@ export const LineShowDotsOn = {
export const LineShowDotsOff = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.lineShowDotsOff as any,
renderingContext,
},
@@ -108,6 +119,7 @@ export const LineShowDotsOff = {
export const LineCustomYAxisRangeEqualsExtents = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.lineCustomYAxisRangeEqualsExtents as any,
renderingContext,
},
@@ -116,6 +128,7 @@ export const LineCustomYAxisRangeEqualsExtents = {
export const LineCustomYAxisRangeOffScreenHigh = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: updateIn(
data.lineCustomYAxisRangeEqualsExtents,
[0, "card", "visualization_settings"],
@@ -128,6 +141,7 @@ export const LineCustomYAxisRangeOffScreenHigh = {
export const LineCustomYAxisRangeOffScreenLow = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: updateIn(
data.lineCustomYAxisRangeEqualsExtents,
[0, "card", "visualization_settings"],
@@ -140,6 +154,7 @@ export const LineCustomYAxisRangeOffScreenLow = {
export const CustomYAxisRangeWithColumnScaling = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.customYAxisRangeWithColumnScaling as any,
renderingContext,
},
@@ -148,6 +163,7 @@ export const CustomYAxisRangeWithColumnScaling = {
export const LineFullyNullDimension37902 = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.lineFullyNullDimension37902 as any,
renderingContext,
},
@@ -156,6 +172,7 @@ export const LineFullyNullDimension37902 = {
export const AreaFullyNullDimension37902 = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.areaFullyNullDimension37902 as any,
renderingContext,
},
@@ -164,6 +181,7 @@ export const AreaFullyNullDimension37902 = {
export const BarLinearXScale = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barLinearXScale as any,
renderingContext,
},
@@ -172,6 +190,7 @@ export const BarLinearXScale = {
export const BarHistogramXScale = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barHistogramXScale as any,
renderingContext,
},
@@ -180,6 +199,7 @@ export const BarHistogramXScale = {
export const BarHistogramMultiSeries = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barHistogramMultiSeries as any,
renderingContext,
},
@@ -188,6 +208,7 @@ export const BarHistogramMultiSeries = {
export const BarHistogramMultiSeriesBinned = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barHistogramMultiSeriesBinned as any,
renderingContext,
},
@@ -196,6 +217,7 @@ export const BarHistogramMultiSeriesBinned = {
export const BarHistogramSeriesBreakout = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barHistogramSeriesBreakout as any,
renderingContext,
},
@@ -204,6 +226,7 @@ export const BarHistogramSeriesBreakout = {
export const BarHistogramStacked = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barHistogramStacked as any,
renderingContext,
},
@@ -212,6 +235,7 @@ export const BarHistogramStacked = {
export const BarHistogramStackedNormalized = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barHistogramStackedNormalized as any,
renderingContext,
},
@@ -220,6 +244,7 @@ export const BarHistogramStackedNormalized = {
export const BarHistogramUnaggregatedDimension = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barHistogramUnaggregatedDimension as any,
renderingContext,
},
@@ -228,6 +253,7 @@ export const BarHistogramUnaggregatedDimension = {
export const BarOrdinalXScale = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barOrdinalXScale as any,
renderingContext,
},
@@ -236,6 +262,7 @@ export const BarOrdinalXScale = {
export const BarOrdinalXScaleAutoRotatedLabels = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barOrdinalXScaleAutoRotatedLabels as any,
renderingContext,
},
@@ -244,6 +271,7 @@ export const BarOrdinalXScaleAutoRotatedLabels = {
export const BarStackedTotalFormattedValues = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barStackedTotalFormattedValues as any,
renderingContext,
},
@@ -252,6 +280,7 @@ export const BarStackedTotalFormattedValues = {
export const BarStackedPowYAxis = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barStackedPowYAxis as any,
renderingContext,
},
@@ -260,6 +289,7 @@ export const BarStackedPowYAxis = {
export const BarStackedPowYAxisNegatives = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barStackedPowYAxisNegatives as any,
renderingContext,
},
@@ -268,6 +298,7 @@ export const BarStackedPowYAxisNegatives = {
export const YAxisCompactWithoutDataLabels = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.yAxisCompactWithoutDataLabels as any,
renderingContext,
},
@@ -276,6 +307,7 @@ export const YAxisCompactWithoutDataLabels = {
export const BarFormattingFull = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barFormattingFull as any,
renderingContext,
},
@@ -284,6 +316,7 @@ export const BarFormattingFull = {
export const BarAutoFormattingCompact = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barAutoFormattingCompact as any,
renderingContext,
},
@@ -291,7 +324,9 @@ export const BarAutoFormattingCompact = {
export const BarAutoFormattingFull = {
render: Template,
+ // Unjustified type cast. FIXME
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barAutoFormattingFull as any,
renderingContext,
getColor: color,
@@ -301,6 +336,7 @@ export const BarAutoFormattingFull = {
export const BarLogYScaleStacked = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barLogYScaleStacked as any,
renderingContext,
},
@@ -309,6 +345,7 @@ export const BarLogYScaleStacked = {
export const BarLogYScaleStackedNegative = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barLogYScaleStackedNegative as any,
renderingContext,
},
@@ -317,6 +354,7 @@ export const BarLogYScaleStackedNegative = {
export const BarStackedNormalizedCustomMinMax48021 = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barStackedNormalizedCustomMinMax48021 as any,
renderingContext,
},
@@ -325,6 +363,7 @@ export const BarStackedNormalizedCustomMinMax48021 = {
export const BarStackedNormalizedGoalLine51054 = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barStackedNormalizedGoalLine51054 as any,
renderingContext,
},
@@ -333,6 +372,7 @@ export const BarStackedNormalizedGoalLine51054 = {
export const BarStackedNormalizedEmptySpace37880 = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barStackedNormalizedEmptySpace37880 as any,
renderingContext,
},
@@ -341,6 +381,7 @@ export const BarStackedNormalizedEmptySpace37880 = {
export const BarTwoAxesStackedWithNegativeValues = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barTwoAxesStackedWithNegativeValues as any,
renderingContext,
},
@@ -349,6 +390,7 @@ export const BarTwoAxesStackedWithNegativeValues = {
export const BarBreakoutWithLineSeriesStackedRightAxisOnly = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barBreakoutWithLineSeriesStackedRightAxisOnly as any,
renderingContext,
},
@@ -357,6 +399,7 @@ export const BarBreakoutWithLineSeriesStackedRightAxisOnly = {
export const BarsBreakoutSortedWithNegativeValuesPowerYAxis = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barsBreakoutSortedWithNegativeValuesPowerYAxis as any,
renderingContext,
},
@@ -365,6 +408,7 @@ export const BarsBreakoutSortedWithNegativeValuesPowerYAxis = {
export const BarFullyNullDimension37902 = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barFullyNullDimension37902 as any,
renderingContext,
},
@@ -373,6 +417,7 @@ export const BarFullyNullDimension37902 = {
export const SplitYAxis = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.autoYSplit as any,
renderingContext,
},
@@ -381,6 +426,7 @@ export const SplitYAxis = {
export const GoalLineOutOfBounds37848 = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.goalLineOutOfBounds37848 as any,
renderingContext,
},
@@ -389,6 +435,7 @@ export const GoalLineOutOfBounds37848 = {
export const GoalLineUnderSeries38824 = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.goalLineUnderSeries38824 as any,
renderingContext,
},
@@ -397,6 +444,7 @@ export const GoalLineUnderSeries38824 = {
export const GoalVerySmall = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.goalVerySmall as any,
renderingContext,
},
@@ -405,6 +453,7 @@ export const GoalVerySmall = {
export const GoalBetweenExtentAndChartBound = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.goalBetweenExtentAndChartBound as any,
renderingContext,
},
@@ -413,6 +462,7 @@ export const GoalBetweenExtentAndChartBound = {
export const GoalLineDisabled = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.goalLineDisabled as any,
renderingContext,
},
@@ -421,6 +471,7 @@ export const GoalLineDisabled = {
export const TrendSingleSeriesLine = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.trendSingleSeriesLine as any,
renderingContext,
},
@@ -429,6 +480,7 @@ export const TrendSingleSeriesLine = {
export const TrendMultiSeriesLine = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.trendMultiSeriesLine as any,
renderingContext,
},
@@ -437,6 +489,7 @@ export const TrendMultiSeriesLine = {
export const TrendSingleSeriesArea = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.trendSingleSeriesArea as any,
renderingContext,
},
@@ -445,6 +498,7 @@ export const TrendSingleSeriesArea = {
export const TrendMultiSeriesArea = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.trendMultiSeriesArea as any,
renderingContext,
},
@@ -453,6 +507,7 @@ export const TrendMultiSeriesArea = {
export const TrendMultiSeriesStackedArea = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.trendMultiSeriesStackedArea as any,
renderingContext,
},
@@ -461,6 +516,7 @@ export const TrendMultiSeriesStackedArea = {
export const TrendMultiSeriesNormalizedStackedArea = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.trendMultiSeriesNormalizedStackedArea as any,
renderingContext,
},
@@ -469,6 +525,7 @@ export const TrendMultiSeriesNormalizedStackedArea = {
export const TrendSingleSeriesBar = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.trendSingleSeriesBar as any,
renderingContext,
},
@@ -477,6 +534,7 @@ export const TrendSingleSeriesBar = {
export const TrendMultiSeriesBar = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.trendMultiSeriesBar as any,
renderingContext,
},
@@ -485,6 +543,7 @@ export const TrendMultiSeriesBar = {
export const TrendMultiSeriesStackedBar = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.trendMultiSeriesStackedBar as any,
renderingContext,
},
@@ -493,6 +552,7 @@ export const TrendMultiSeriesStackedBar = {
export const TrendMultiSeriesNormalizedStackedBar = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.trendMultiSeriesNormalizedStackedBar as any,
renderingContext,
},
@@ -501,6 +561,7 @@ export const TrendMultiSeriesNormalizedStackedBar = {
export const TrendCombo = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.trendCombo as any,
renderingContext,
},
@@ -509,6 +570,7 @@ export const TrendCombo = {
export const TrendComboPower = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.trendComboPower as any,
renderingContext,
},
@@ -517,6 +579,7 @@ export const TrendComboPower = {
export const TrendComboLog = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.trendComboLog as any,
renderingContext,
},
@@ -525,6 +588,7 @@ export const TrendComboLog = {
export const ComboHistogram = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.comboHistogram as any,
renderingContext,
},
@@ -534,6 +598,7 @@ export const CombinedBarTimeSeriesDifferentGranularityWithBreakout = {
render: Template,
args: {
rawSeries:
+ // Unjustified type cast. FIXME
data.combinedBarTimeSeriesDifferentGranularityWithBreakout as any,
renderingContext,
},
@@ -542,6 +607,7 @@ export const CombinedBarTimeSeriesDifferentGranularityWithBreakout = {
export const NumericXAxisIncludesZero37082 = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.numericXAxisIncludesZero37082 as any,
renderingContext,
},
@@ -550,6 +616,7 @@ export const NumericXAxisIncludesZero37082 = {
export const WrongYAxisRange37306 = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.wrongYAxisRange37306 as any,
renderingContext,
},
@@ -558,6 +625,7 @@ export const WrongYAxisRange37306 = {
export const LongDimensionNameCutOff37420 = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.longDimensionNameCutOff37420 as any,
renderingContext,
},
@@ -566,6 +634,7 @@ export const LongDimensionNameCutOff37420 = {
export const CompactXAxisDoesNotWork38917 = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.compactXAxisDoesNotWork38917 as any,
renderingContext,
},
@@ -574,6 +643,7 @@ export const CompactXAxisDoesNotWork38917 = {
export const DataLabelsUnderTrendGoalLines41280 = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.dataLabelsUnderTrendGoalLines41280 as any,
renderingContext,
},
@@ -582,6 +652,7 @@ export const DataLabelsUnderTrendGoalLines41280 = {
export const TicksNativeWeekWithGapShortRange = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.ticksNativeWeekWithGapShortRange as any,
renderingContext,
},
@@ -590,6 +661,7 @@ export const TicksNativeWeekWithGapShortRange = {
export const TicksNativeWeekWithGapLongRange = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.ticksNativeWeekWithGapLongRange as any,
renderingContext,
},
@@ -598,6 +670,7 @@ export const TicksNativeWeekWithGapLongRange = {
export const BarStackLinearXAxis = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barStackLinearXAxis as any,
renderingContext,
},
@@ -606,6 +679,7 @@ export const BarStackLinearXAxis = {
export const AreaStackLinearXAxis = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.areaStackLinearXAxis as any,
renderingContext,
},
@@ -614,6 +688,7 @@ export const AreaStackLinearXAxis = {
export const NullCategoryValueFormatting = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.nullCategoryValueFormatting as any,
renderingContext,
},
@@ -622,6 +697,7 @@ export const NullCategoryValueFormatting = {
export const NumberOfInsightsError39608 = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.numberOfInsightsError39608 as any,
renderingContext,
},
@@ -630,6 +706,7 @@ export const NumberOfInsightsError39608 = {
export const AreaStackInterpolateMissingValues = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.areaStackInterpolateMissingValues as any,
renderingContext,
},
@@ -638,6 +715,7 @@ export const AreaStackInterpolateMissingValues = {
export const AreaStackAllSeriesWithoutInterpolation = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.areaStackAllSeriesWithoutInterpolation as any,
renderingContext,
},
@@ -646,6 +724,7 @@ export const AreaStackAllSeriesWithoutInterpolation = {
export const AreaOverBar = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.areaOverBar as any,
renderingContext,
},
@@ -654,6 +733,7 @@ export const AreaOverBar = {
export const TimeSeriesTicksCompactFormattingMixedTimezones = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.timeSeriesTicksCompactFormattingMixedTimezones as any,
renderingContext,
},
@@ -662,6 +742,7 @@ export const TimeSeriesTicksCompactFormattingMixedTimezones = {
export const TimezoneTicksPlacement = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.timezoneTicksPlacement as any,
renderingContext,
},
@@ -670,6 +751,7 @@ export const TimezoneTicksPlacement = {
export const BarRelativeDatetimeOrdinalScale = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barRelativeDatetimeOrdinalScale as any,
renderingContext,
},
@@ -678,6 +760,7 @@ export const BarRelativeDatetimeOrdinalScale = {
export const BarTwoDaysOfWeek = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barTwoDaysOfWeek as any,
renderingContext,
},
@@ -686,6 +769,7 @@ export const BarTwoDaysOfWeek = {
export const AreaStackedAutoDataLabels = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.areaStackedAutoDataLabels as any,
renderingContext,
},
@@ -694,6 +778,7 @@ export const AreaStackedAutoDataLabels = {
export const ImageCutOff37275 = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.imageCutOff37275 as any,
renderingContext,
},
@@ -702,6 +787,7 @@ export const ImageCutOff37275 = {
export const IncorrectLabelYAxisSplit41285 = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.incorrectLabelYAxisSplit41285 as any,
renderingContext,
},
@@ -710,6 +796,7 @@ export const IncorrectLabelYAxisSplit41285 = {
export const NativeAutoYSplit = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.nativeAutoYSplit as any,
renderingContext,
},
@@ -718,6 +805,7 @@ export const NativeAutoYSplit = {
export const TimeSeriesYyyymmddNumbersFormat = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.timeSeriesYyyymmddNumbersFormat as any,
renderingContext,
},
@@ -726,6 +814,7 @@ export const TimeSeriesYyyymmddNumbersFormat = {
export const BreakoutNullAndEmptyString = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.breakoutNullAndEmptyString as any,
renderingContext,
},
@@ -734,6 +823,7 @@ export const BreakoutNullAndEmptyString = {
export const NoGoodAxisSplit = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.noGoodAxisSplit as any,
renderingContext,
},
@@ -742,6 +832,7 @@ export const NoGoodAxisSplit = {
export const HistogramTicks45Degrees = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.histogramTicks45Degrees as any,
renderingContext,
},
@@ -750,6 +841,7 @@ export const HistogramTicks45Degrees = {
export const HistogramTicks90Degrees = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.histogramTicks90Degrees as any,
renderingContext,
},
@@ -758,6 +850,7 @@ export const HistogramTicks90Degrees = {
export const LineUnpinFromZero = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.lineUnpinFromZero as any,
renderingContext,
},
@@ -766,6 +859,7 @@ export const LineUnpinFromZero = {
export const LineSettings = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.lineSettings as any,
renderingContext,
},
@@ -774,6 +868,7 @@ export const LineSettings = {
export const LineReplaceMissingValuesZero = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.lineReplaceMissingValuesZero as any,
renderingContext,
},
@@ -782,6 +877,7 @@ export const LineReplaceMissingValuesZero = {
export const LineChartBrokenDimensionsMetricsSettings = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.lineChartBrokenDimensionsMetricsSettings as any,
renderingContext,
},
@@ -790,6 +886,7 @@ export const LineChartBrokenDimensionsMetricsSettings = {
export const ComboStackedBarsAreasNormalized = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.comboStackedBarsAreasNormalized as any,
renderingContext,
},
@@ -798,6 +895,7 @@ export const ComboStackedBarsAreasNormalized = {
export const ComboStackedBarsAreas = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.comboStackedBarsAreas as any,
renderingContext,
},
@@ -806,6 +904,7 @@ export const ComboStackedBarsAreas = {
export const TwoBarsTwoAreasOneLineLinear = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.twoBarsTwoAreasOneLineLinear as any,
renderingContext,
},
@@ -814,6 +913,7 @@ export const TwoBarsTwoAreasOneLineLinear = {
export const TwoBarsTwoAreasOneLinePower = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.twoBarsTwoAreasOneLinePower as any,
renderingContext,
},
@@ -822,6 +922,7 @@ export const TwoBarsTwoAreasOneLinePower = {
export const TwoBarsTwoAreasOneLineLog = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.twoBarsTwoAreasOneLineLog as any,
renderingContext,
},
@@ -830,6 +931,7 @@ export const TwoBarsTwoAreasOneLineLog = {
export const BarCorrectWidthWhenTwoYAxes = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barCorrectWidthWhenTwoYAxes as any,
renderingContext,
},
@@ -838,6 +940,7 @@ export const BarCorrectWidthWhenTwoYAxes = {
export const BarDataLabelsNegatives = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barDataLabelsNegatives as any,
renderingContext,
},
@@ -846,6 +949,7 @@ export const BarDataLabelsNegatives = {
export const BarStackedNormalizedSeriesLabels = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barStackedNormalizedSeriesLabels as any,
renderingContext,
},
@@ -854,6 +958,7 @@ export const BarStackedNormalizedSeriesLabels = {
export const BarStackedSeriesLabelsAndTotals = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barStackedSeriesLabelsAndTotals as any,
renderingContext,
},
@@ -862,6 +967,7 @@ export const BarStackedSeriesLabelsAndTotals = {
export const BarStackedSeriesLabelsNoTotals = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barStackedSeriesLabelsNoTotals as any,
renderingContext,
},
@@ -870,6 +976,7 @@ export const BarStackedSeriesLabelsNoTotals = {
export const BarStackedSeriesLabelsRotated = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barStackedSeriesLabelsRotated as any,
renderingContext,
},
@@ -878,6 +985,7 @@ export const BarStackedSeriesLabelsRotated = {
export const BarStackedSeriesLabelsAutoCompactness = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barStackedSeriesLabelsAutoCompactness as any,
renderingContext,
},
@@ -886,6 +994,7 @@ export const BarStackedSeriesLabelsAutoCompactness = {
export const BarStackedSeriesLabelsAndTotalsOrdinal = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barStackedSeriesLabelsAndTotalsOrdinal as any,
renderingContext,
},
@@ -894,6 +1003,7 @@ export const BarStackedSeriesLabelsAndTotalsOrdinal = {
export const BarStackedSeriesLabelsNormalizedAutoCompactness = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barStackedSeriesLabelsNormalizedAutoCompactness as any,
renderingContext,
},
@@ -902,6 +1012,7 @@ export const BarStackedSeriesLabelsNormalizedAutoCompactness = {
export const BarStackedLabelsNullVsZero = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barStackedLabelsNullVsZero as any,
renderingContext,
},
@@ -910,6 +1021,7 @@ export const BarStackedLabelsNullVsZero = {
export const BarMinHeightLimit = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barMinHeightLimit as any,
renderingContext,
},
@@ -918,6 +1030,7 @@ export const BarMinHeightLimit = {
export const ComboDataLabelsAutoCompactnessPropagatesFromLine = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.comboDataLabelsAutoCompactnessPropagatesFromLine as any,
renderingContext,
},
@@ -926,6 +1039,7 @@ export const ComboDataLabelsAutoCompactnessPropagatesFromLine = {
export const ComboDataLabelsAutoCompactnessPropagatesFromTotals = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.comboDataLabelsAutoCompactnessPropagatesFromTotals as any,
renderingContext,
},
@@ -934,6 +1048,7 @@ export const ComboDataLabelsAutoCompactnessPropagatesFromTotals = {
export const AreaChartSteppedNullsInterpolated = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.areaChartSteppedNullsInterpolated as any,
renderingContext,
},
@@ -942,6 +1057,7 @@ export const AreaChartSteppedNullsInterpolated = {
export const AreaChartSteppedNullsSkipped = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.areaChartSteppedNullsSkipped as any,
renderingContext,
},
@@ -950,6 +1066,7 @@ export const AreaChartSteppedNullsSkipped = {
export const SafariNonIanaTimezoneRepro44128 = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.safariNonIanaTimezoneRepro44128 as any,
renderingContext,
},
@@ -958,6 +1075,7 @@ export const SafariNonIanaTimezoneRepro44128 = {
export const CombinedWithInvalidSettings = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.combinedWithInvalidSettings as any,
renderingContext,
},
@@ -966,6 +1084,7 @@ export const CombinedWithInvalidSettings = {
export const StackedChartCustomYAxisRange = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.stackedChartCustomYAxisRange as any,
renderingContext,
},
@@ -974,6 +1093,7 @@ export const StackedChartCustomYAxisRange = {
export const SeriesOrderSettingsDoNotMatchSeriesCount = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.seriesOrderSettingsDoNotMatchSeriesCount as any,
renderingContext,
},
@@ -982,6 +1102,7 @@ export const SeriesOrderSettingsDoNotMatchSeriesCount = {
export const TrendGoalLinesWithScalingPowScaleCustomRange = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.trendGoalLinesWithScalingPowScaleCustomRange as any,
renderingContext,
},
@@ -990,6 +1111,7 @@ export const TrendGoalLinesWithScalingPowScaleCustomRange = {
export const BarStackedAllLabelsTimeseriesWithGap45717 = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barStackedAllLabelsTimeseriesWithGap45717 as any,
renderingContext,
},
@@ -999,6 +1121,7 @@ export const BarMaxCategoriesDefault = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barMaxCategoriesDefault as any,
renderingContext,
},
@@ -1008,6 +1131,7 @@ export const BarMaxCategoriesStacked = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barMaxCategoriesStacked as any,
renderingContext,
},
@@ -1017,6 +1141,7 @@ export const BarMaxCategoriesStackedNormalized = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barMaxCategoriesStackedNormalized as any,
renderingContext,
},
@@ -1025,6 +1150,7 @@ export const BarMaxCategoriesStackedNormalized = {
export const OffsetBasedTimezone47835 = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.offsetBasedTimezone47835 as any,
renderingContext,
},
@@ -1033,6 +1159,7 @@ export const OffsetBasedTimezone47835 = {
export const BarNonLinearNumericXAxis = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barNonLinearNumericXAxis as any,
renderingContext,
},
@@ -1041,6 +1168,7 @@ export const BarNonLinearNumericXAxis = {
export const BarWidthDstTimezones56424 = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barWidthDstTimezones56424 as any,
renderingContext,
},
@@ -1049,6 +1177,7 @@ export const BarWidthDstTimezones56424 = {
export const Default = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.messedUpAxis as any,
renderingContext,
},
@@ -1057,6 +1186,7 @@ export const Default = {
export const Watermark = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.barWidthDstTimezones56424 as any,
renderingContext,
hasDevWatermark: true,
@@ -1066,6 +1196,7 @@ export const Watermark = {
export const VisualizerTimeseriesDifferentUnits = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.visualizerTimeseriesDifferentUnits as any,
renderingContext,
},
diff --git a/frontend/src/metabase/static-viz/components/FunnelBarChart/FunnelBarChart.stories.tsx b/frontend/src/metabase/static-viz/components/FunnelBarChart/FunnelBarChart.stories.tsx
index 5558da6c62f..3985a4066d5 100644
--- a/frontend/src/metabase/static-viz/components/FunnelBarChart/FunnelBarChart.stories.tsx
+++ b/frontend/src/metabase/static-viz/components/FunnelBarChart/FunnelBarChart.stories.tsx
@@ -40,6 +40,7 @@ const renderingContext: RenderingContext = {
export const Default = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.funnelBarCategorical as any,
renderingContext,
},
@@ -48,6 +49,7 @@ export const Default = {
export const FunnelBarOrderedRows = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.funnelBarOrderedRows as any,
renderingContext,
},
@@ -56,6 +58,7 @@ export const FunnelBarOrderedRows = {
export const FunnelBarUnorderedRows = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.funnelBarUnorderedRows as any,
renderingContext,
},
diff --git a/frontend/src/metabase/static-viz/components/PieChart/PieChart.stories.tsx b/frontend/src/metabase/static-viz/components/PieChart/PieChart.stories.tsx
index ea00701e1fb..8975dba39d5 100644
--- a/frontend/src/metabase/static-viz/components/PieChart/PieChart.stories.tsx
+++ b/frontend/src/metabase/static-viz/components/PieChart/PieChart.stories.tsx
@@ -40,6 +40,7 @@ const renderingContext: RenderingContext = {
export const DefaultSettings = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.defaultSettings as any,
renderingContext,
},
@@ -48,6 +49,7 @@ export const DefaultSettings = {
export const AllSettings = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.allSettings as any,
renderingContext,
},
@@ -56,6 +58,7 @@ export const AllSettings = {
export const AutoCompactTotal = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.autoCompactTotal as any,
renderingContext,
},
@@ -64,6 +67,7 @@ export const AutoCompactTotal = {
export const Colors = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.colors as any,
renderingContext,
},
@@ -72,6 +76,7 @@ export const Colors = {
export const HideLegend = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.hideLegend as any,
renderingContext,
},
@@ -80,6 +85,7 @@ export const HideLegend = {
export const HideTotal = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.hideTotal as any,
renderingContext,
},
@@ -88,6 +94,7 @@ export const HideTotal = {
export const ReorderedRenamedSlices = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.reorderedRenamedSlices as any,
renderingContext,
},
@@ -96,6 +103,7 @@ export const ReorderedRenamedSlices = {
export const SmallMinimumSlicePercentage = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.smallMinimumSlicePercentage as any,
renderingContext,
},
@@ -104,6 +112,7 @@ export const SmallMinimumSlicePercentage = {
export const LargeMinimumSlicePercentage = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.largeMinimumSlicePercentage as any,
renderingContext,
},
@@ -112,6 +121,7 @@ export const LargeMinimumSlicePercentage = {
export const ZeroMinimumSlicePercentage = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.zeroMinimumSlicePercentage as any,
renderingContext,
},
@@ -120,6 +130,7 @@ export const ZeroMinimumSlicePercentage = {
export const ShowPercentagesOff = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.showPercentagesOff as any,
renderingContext,
},
@@ -128,6 +139,7 @@ export const ShowPercentagesOff = {
export const ShowPercentagesOnChart = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.showPercentagesOnChart as any,
renderingContext,
},
@@ -136,6 +148,7 @@ export const ShowPercentagesOnChart = {
export const ShowPercentagesOnChartDense = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.showPercentagesOnChartDense as any,
renderingContext,
},
@@ -144,6 +157,7 @@ export const ShowPercentagesOnChartDense = {
export const AllNegative = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.allNegative as any,
renderingContext,
},
@@ -152,6 +166,7 @@ export const AllNegative = {
export const AllNegativeWithOther = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.allNegativeWithOther as any,
renderingContext,
},
@@ -160,6 +175,7 @@ export const AllNegativeWithOther = {
export const MixedPositiveNegative = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.mixedPostiiveNegative as any,
renderingContext,
},
@@ -168,6 +184,7 @@ export const MixedPositiveNegative = {
export const ColumnFormatting = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.columnFormatting as any,
renderingContext,
},
@@ -176,6 +193,7 @@ export const ColumnFormatting = {
export const ColumnFormattingPercentagesOnChart = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.columnFormattingPercentagesOnChart as any,
renderingContext,
},
@@ -184,6 +202,7 @@ export const ColumnFormattingPercentagesOnChart = {
export const BooleanDimension = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.booleanDimension as any,
renderingContext,
},
@@ -192,6 +211,7 @@ export const BooleanDimension = {
export const NumericDimension = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.numericDimension as any,
renderingContext,
},
@@ -200,6 +220,7 @@ export const NumericDimension = {
export const BinnedDimension = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.binnedDimension as any,
renderingContext,
},
@@ -208,6 +229,7 @@ export const BinnedDimension = {
export const DateDimension = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.dateDimension as any,
renderingContext,
},
@@ -216,6 +238,7 @@ export const DateDimension = {
export const RelativeDateDimension = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.relativeDateDimension as any,
renderingContext,
},
@@ -224,6 +247,7 @@ export const RelativeDateDimension = {
export const ShowPercentagesBoth = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.showPercentagesBoth as any,
renderingContext,
},
@@ -232,6 +256,7 @@ export const ShowPercentagesBoth = {
export const NullDimension = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.nullDimension as any,
renderingContext,
},
@@ -240,6 +265,7 @@ export const NullDimension = {
export const NumDecimalPlacesChart = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.numDecimalPlacesChart as any,
renderingContext,
},
@@ -248,6 +274,7 @@ export const NumDecimalPlacesChart = {
export const NumDecimalPlacesLegend = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.numDecimalPlacesLegend as any,
renderingContext,
},
@@ -256,6 +283,7 @@ export const NumDecimalPlacesLegend = {
export const TruncatedTotal = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.truncatedTotal as any,
renderingContext,
},
@@ -264,6 +292,7 @@ export const TruncatedTotal = {
export const UnaggregatedDimension = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.unaggregatedDimension as any,
renderingContext,
},
@@ -272,6 +301,7 @@ export const UnaggregatedDimension = {
export const SingleDimension = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.singleDimension as any,
renderingContext,
},
@@ -280,6 +310,7 @@ export const SingleDimension = {
export const LongDimensionName = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.longDimensionName as any,
renderingContext,
},
@@ -288,6 +319,7 @@ export const LongDimensionName = {
export const TinySlicesDisappear43766 = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.tinySlicesDisappear43766 as any,
renderingContext,
},
@@ -296,6 +328,7 @@ export const TinySlicesDisappear43766 = {
export const MissingCurrencyFormatting44086 = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.missingCurrencyFormatting44086 as any,
renderingContext,
},
@@ -304,6 +337,7 @@ export const MissingCurrencyFormatting44086 = {
export const MissingCurrencyFormatting2 = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.missingCurrencyFormatting2 as any,
renderingContext,
},
@@ -312,6 +346,7 @@ export const MissingCurrencyFormatting2 = {
export const MissingCurrencyFormatting3 = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.missingCurrencyFormatting3 as any,
renderingContext,
},
@@ -320,6 +355,7 @@ export const MissingCurrencyFormatting3 = {
export const MissingColors44087 = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.missingColors44087 as any,
renderingContext,
},
@@ -328,6 +364,7 @@ export const MissingColors44087 = {
export const InvalidDimensionSetting44085 = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.invalidDimensionSetting44085 as any,
renderingContext,
},
@@ -336,6 +373,7 @@ export const InvalidDimensionSetting44085 = {
export const PercentagesOnChartBooleanDimensionCrashes44085 = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.percentagesOnChartBooleanDimensionCrashes44085 as any,
renderingContext,
},
@@ -344,6 +382,7 @@ export const PercentagesOnChartBooleanDimensionCrashes44085 = {
export const AllZeroMetric44847 = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.allZeroMetric44847 as any,
renderingContext,
},
@@ -352,6 +391,7 @@ export const AllZeroMetric44847 = {
export const NoSingleColumnLegend45149 = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.noSingleColumnLegend45149 as any,
renderingContext,
},
@@ -360,6 +400,7 @@ export const NoSingleColumnLegend45149 = {
export const NumericSQLColumnCrashes28568 = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.numericSQLColumnCrashes28568 as any,
renderingContext,
},
@@ -368,6 +409,7 @@ export const NumericSQLColumnCrashes28568 = {
export const MissingLabelLargeSlice38424 = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.missingLabelLargeSlice38424 as any,
renderingContext,
},
@@ -375,54 +417,63 @@ export const MissingLabelLargeSlice38424 = {
export const TwoRings = Template.bind({});
TwoRings.args = {
+ // Unjustified type cast. FIXME
rawSeries: data.twoRings as any,
renderingContext,
};
export const ThreeRings = Template.bind({});
ThreeRings.args = {
+ // Unjustified type cast. FIXME
rawSeries: data.threeRings as any,
renderingContext,
};
export const ThreeRingsNoLabels = Template.bind({});
ThreeRingsNoLabels.args = {
+ // Unjustified type cast. FIXME
rawSeries: data.threeRingsNoLabels as any,
renderingContext,
};
export const ThreeRingsPercentagesAndLabels = Template.bind({});
ThreeRingsPercentagesAndLabels.args = {
+ // Unjustified type cast. FIXME
rawSeries: data.threeRingsPercentagesAndLabels as any,
renderingContext,
};
export const ThreeRingsPercentagesOnChart = Template.bind({});
ThreeRingsPercentagesOnChart.args = {
+ // Unjustified type cast. FIXME
rawSeries: data.threeRingsPercentagesOnChart as any,
renderingContext,
};
export const ThreeRingsOtherSlices = Template.bind({});
ThreeRingsOtherSlices.args = {
+ // Unjustified type cast. FIXME
rawSeries: data.threeRingsOtherSlices as any,
renderingContext,
};
export const LabelsWithPercent = Template.bind({});
LabelsWithPercent.args = {
+ // Unjustified type cast. FIXME
rawSeries: data.labelsWithPercent as any,
renderingContext,
};
export const LabelsOnChart = Template.bind({});
LabelsOnChart.args = {
+ // Unjustified type cast. FIXME
rawSeries: data.labelsOnChart as any,
renderingContext,
};
export const SunburstOtherLabel = Template.bind({});
SunburstOtherLabel.args = {
+ // Unjustified type cast. FIXME
rawSeries: data.sunburstOtherLabel as any,
renderingContext,
};
@@ -430,6 +481,7 @@ SunburstOtherLabel.args = {
export const Watermark = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.allSettings as any,
renderingContext,
hasDevWatermark: true,
diff --git a/frontend/src/metabase/static-viz/components/RowChart/RowChart.tsx b/frontend/src/metabase/static-viz/components/RowChart/RowChart.tsx
index a935aacb80d..bead3388dd4 100644
--- a/frontend/src/metabase/static-viz/components/RowChart/RowChart.tsx
+++ b/frontend/src/metabase/static-viz/components/RowChart/RowChart.tsx
@@ -62,6 +62,7 @@ export const StaticRowChart = ({
hasDevWatermark = false,
fitWithinBounds = false,
}: StaticChartProps) => {
+ // Unjustified type cast. FIXME
const data = extractRemappedColumns(
rawSeries[0].data,
) as RemappingHydratedChartData;
diff --git a/frontend/src/metabase/static-viz/components/RowChart/stories-data.ts b/frontend/src/metabase/static-viz/components/RowChart/stories-data.ts
index 38c47c32703..0a4897f1438 100644
--- a/frontend/src/metabase/static-viz/components/RowChart/stories-data.ts
+++ b/frontend/src/metabase/static-viz/components/RowChart/stories-data.ts
@@ -17,6 +17,7 @@ export const renderingContext: RenderingContext = {
theme: DEFAULT_VISUALIZATION_THEME,
};
+// Unjustified type cast. FIXME
export const MULTIPLE_SERIES: StaticChartProps = {
rawSeries: [
{
@@ -211,6 +212,7 @@ export const MULTIPLE_SERIES: StaticChartProps = {
renderingContext,
} as any;
+// Unjustified type cast. FIXME
export const METRIC_COLUMN_WITH_SCALING: StaticChartProps = {
rawSeries: [
{
diff --git a/frontend/src/metabase/static-viz/components/SankeyChart/SankeyChart.stories.tsx b/frontend/src/metabase/static-viz/components/SankeyChart/SankeyChart.stories.tsx
index 8b286f9bb71..933a24765f6 100644
--- a/frontend/src/metabase/static-viz/components/SankeyChart/SankeyChart.stories.tsx
+++ b/frontend/src/metabase/static-viz/components/SankeyChart/SankeyChart.stories.tsx
@@ -40,6 +40,7 @@ const renderingContext: RenderingContext = {
export const DefaultSettings = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.defaultSettings as any,
renderingContext,
},
@@ -48,6 +49,7 @@ export const DefaultSettings = {
export const Watermark = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.defaultSettings as any,
renderingContext,
hasDevWatermark: true,
diff --git a/frontend/src/metabase/static-viz/components/ScalarChart/ScalarChart.stories.tsx b/frontend/src/metabase/static-viz/components/ScalarChart/ScalarChart.stories.tsx
index 9892e5275ba..2d2e3139e2d 100644
--- a/frontend/src/metabase/static-viz/components/ScalarChart/ScalarChart.stories.tsx
+++ b/frontend/src/metabase/static-viz/components/ScalarChart/ScalarChart.stories.tsx
@@ -41,6 +41,7 @@ const renderingContext: RenderingContext = {
export const Default = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.twoScalars as any,
renderingContext,
},
diff --git a/frontend/src/metabase/static-viz/components/ScatterPlot/ScatterPlot.stories.tsx b/frontend/src/metabase/static-viz/components/ScatterPlot/ScatterPlot.stories.tsx
index e9f8fcc9932..ac19156fbd8 100644
--- a/frontend/src/metabase/static-viz/components/ScatterPlot/ScatterPlot.stories.tsx
+++ b/frontend/src/metabase/static-viz/components/ScatterPlot/ScatterPlot.stories.tsx
@@ -41,6 +41,7 @@ export const Default = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.default as any,
renderingContext,
},
@@ -50,6 +51,7 @@ export const CustomYAxisRangeWithColumnScaling = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.customYAxisRangeWithColumnScaling as any,
renderingContext,
},
@@ -59,6 +61,7 @@ export const MultiMetricSeries = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.multiMetricSeries as any,
renderingContext,
},
@@ -68,6 +71,7 @@ export const MultiDimensionBreakout = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.multiDimensionBreakout as any,
renderingContext,
},
@@ -77,6 +81,7 @@ export const BubbleSize = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.bubbleSize as any,
renderingContext,
},
@@ -86,6 +91,7 @@ export const MultiDimensionBreakoutBubbleSize = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.multiDimensionBreakoutBubbleSize as any,
renderingContext,
},
@@ -95,6 +101,7 @@ export const PowerXScale = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.powerXScale as any,
renderingContext,
},
@@ -104,6 +111,7 @@ export const PowerXScaleMultiSeries = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.powerXScaleMultiSeries as any,
renderingContext,
},
@@ -113,6 +121,7 @@ export const LogXScale = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.logXScale as any,
renderingContext,
},
@@ -122,6 +131,7 @@ export const LogXScaleAtOne = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.logXScaleAtOne as any,
renderingContext,
},
@@ -131,6 +141,7 @@ export const HistogramXScale = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.histogramXScale as any,
renderingContext,
},
@@ -140,6 +151,7 @@ export const OrdinalXScale = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.ordinalXScale as any,
renderingContext,
},
@@ -149,6 +161,7 @@ export const TimeseriesXScale = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.timeseriesXScale as any,
renderingContext,
},
@@ -158,6 +171,7 @@ export const CustomYAxisRange = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.customYAxisRange as any,
renderingContext,
},
@@ -167,6 +181,7 @@ export const AutoYAxisExcludeZeroWithGoal = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.autoYAxisExcludeZeroWithGoal as any,
renderingContext,
},
@@ -176,6 +191,7 @@ export const GoalLine = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.goalLine as any,
renderingContext,
},
@@ -185,6 +201,7 @@ export const PinToZero = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.pinToZero as any,
renderingContext,
},
@@ -194,6 +211,7 @@ export const Watermark = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.default as any,
renderingContext,
hasDevWatermark: true,
diff --git a/frontend/src/metabase/static-viz/components/SmartScalar/SmartScalar.tsx b/frontend/src/metabase/static-viz/components/SmartScalar/SmartScalar.tsx
index 727dd5f9f61..8a02b7ca1da 100644
--- a/frontend/src/metabase/static-viz/components/SmartScalar/SmartScalar.tsx
+++ b/frontend/src/metabase/static-viz/components/SmartScalar/SmartScalar.tsx
@@ -25,6 +25,7 @@ export function SmartScalar({
if (error || !trend) {
throw new Error(
`Failed to compute trend data for ${card.name}\: ${
+ // Unjustified type cast. FIXME
(error as { message: string }).message
}`,
);
diff --git a/frontend/src/metabase/static-viz/components/StaticChoropleth/StaticChoropleth.tsx b/frontend/src/metabase/static-viz/components/StaticChoropleth/StaticChoropleth.tsx
index d79c6ee25b5..eed3d846d54 100644
--- a/frontend/src/metabase/static-viz/components/StaticChoropleth/StaticChoropleth.tsx
+++ b/frontend/src/metabase/static-viz/components/StaticChoropleth/StaticChoropleth.tsx
@@ -84,7 +84,9 @@ export const StaticChoropleth = ({
? buildColorScale(domain, settings["map.colors"], toRgb)
: {
colorScale: (_value: number) => zeroColor,
+ // Unjustified type cast. FIXME
groups: [] as number[][],
+ // Unjustified type cast. FIXME
heatMapColors: [] as string[],
};
diff --git a/frontend/src/metabase/static-viz/components/StaticChoropleth/StaticChoropleth.unit.spec.tsx b/frontend/src/metabase/static-viz/components/StaticChoropleth/StaticChoropleth.unit.spec.tsx
index ffc4a1cfa4f..6c898440a9e 100644
--- a/frontend/src/metabase/static-viz/components/StaticChoropleth/StaticChoropleth.unit.spec.tsx
+++ b/frontend/src/metabase/static-viz/components/StaticChoropleth/StaticChoropleth.unit.spec.tsx
@@ -17,6 +17,7 @@ import {
import { StaticChoropleth } from "./StaticChoropleth";
import { getStaticChoroplethSettings } from "./utils";
+// Unjustified type cast. FIXME
const renderingContext = {
getColor: (name: string) =>
name === "text-secondary" ? "#888888" : "#000000",
@@ -64,6 +65,7 @@ const geoJson: FeatureCollection = {
],
};
+// Unjustified type cast. FIXME
const rawSeries = [
{
card: { display: "map" },
diff --git a/frontend/src/metabase/static-viz/components/StaticChoropleth/stories-data.ts b/frontend/src/metabase/static-viz/components/StaticChoropleth/stories-data.ts
index 89938f0effb..fac14ab4ae2 100644
--- a/frontend/src/metabase/static-viz/components/StaticChoropleth/stories-data.ts
+++ b/frontend/src/metabase/static-viz/components/StaticChoropleth/stories-data.ts
@@ -58,6 +58,7 @@ const makeRawSeries = (
rows: unknown[][],
visualizationSettings: Record<string, unknown> = {},
): RawSeries =>
+ // Unjustified type cast. FIXME
[
{
card: { display: "map", visualization_settings: visualizationSettings },
diff --git a/frontend/src/metabase/static-viz/components/TreemapChart/TreemapChart.unit.spec.tsx b/frontend/src/metabase/static-viz/components/TreemapChart/TreemapChart.unit.spec.tsx
index e3d46828b7c..2e70c47e9fd 100644
--- a/frontend/src/metabase/static-viz/components/TreemapChart/TreemapChart.unit.spec.tsx
+++ b/frontend/src/metabase/static-viz/components/TreemapChart/TreemapChart.unit.spec.tsx
@@ -15,6 +15,7 @@ function getRenderingContext() {
return createStaticRenderingContext();
}
+// Unjustified type cast. FIXME
const settings = {
"treemap.grouping": "Category",
"treemap.sub_grouping": "SubCategory",
diff --git a/frontend/src/metabase/static-viz/components/TreemapChart/TreemapLegend.unit.spec.tsx b/frontend/src/metabase/static-viz/components/TreemapChart/TreemapLegend.unit.spec.tsx
index 5a59ff6da61..7286525e43c 100644
--- a/frontend/src/metabase/static-viz/components/TreemapChart/TreemapLegend.unit.spec.tsx
+++ b/frontend/src/metabase/static-viz/components/TreemapChart/TreemapLegend.unit.spec.tsx
@@ -6,12 +6,14 @@ import type { RenderingContext } from "metabase/visualizations/types";
import { TreemapLegend } from "./TreemapLegend";
import type { TreemapLegendModel } from "./legend";
+// Unjustified type cast. FIXME
const renderingContext = {
getColor: (color: string) => color,
measureText: (text: string, style: { size: number; weight: number }) =>
measureTextWidth(text, style.size, style.weight),
measureTextHeight: () => 16,
fontFamily: "Lato",
+ // Unjustified type cast. FIXME
theme: {} as RenderingContext["theme"],
} as RenderingContext;
diff --git a/frontend/src/metabase/static-viz/components/WaterfallChart/WaterfallChart.stories.tsx b/frontend/src/metabase/static-viz/components/WaterfallChart/WaterfallChart.stories.tsx
index ef380d6b826..2e174f0faca 100644
--- a/frontend/src/metabase/static-viz/components/WaterfallChart/WaterfallChart.stories.tsx
+++ b/frontend/src/metabase/static-viz/components/WaterfallChart/WaterfallChart.stories.tsx
@@ -39,6 +39,7 @@ export const YAxisCompactWithoutDataLabels = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.yAxisCompactWithoutDataLabels as any,
renderingContext,
},
@@ -48,6 +49,7 @@ export const YAxisAutoCompactWithDataLabels = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.yAxisAutoCompactWithDataLabels as any,
renderingContext,
},
@@ -57,6 +59,7 @@ export const YAxisFullWithDataLabels = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.yAxisFullWithDataLabels as any,
renderingContext,
},
@@ -66,6 +69,7 @@ export const CustomYAxisRangeWithColumnScaling = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.customYAxisRangeWithColumnScaling as any,
renderingContext,
},
@@ -75,6 +79,7 @@ export const TimeseriesXScale = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.timeseriesXScale as any,
renderingContext,
},
@@ -84,6 +89,7 @@ export const TimeseriesXScaleUnsorted = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.timeseriesXScaleUnsorted as any,
renderingContext,
},
@@ -93,6 +99,7 @@ export const OrdinalXScale = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.ordinalXScale as any,
renderingContext,
},
@@ -102,6 +109,7 @@ export const TimeSeriesDataAsOrdinalXScale = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.timeSeriesDataAsOrdinalXScale as any,
renderingContext,
},
@@ -111,6 +119,7 @@ export const UnaggregatedOrdinal = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.unaggregatedOrdinal as any,
renderingContext,
},
@@ -120,6 +129,7 @@ export const UnaggregatedLinear = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.unaggregatedLinear as any,
renderingContext,
},
@@ -129,6 +139,7 @@ export const UnaggregatedTimeseries = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.unaggregatedTimeseries as any,
renderingContext,
},
@@ -138,6 +149,7 @@ export const MixedAboveZero = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.mixedAboveZero as any,
renderingContext,
},
@@ -147,6 +159,7 @@ export const MixedBelowZero = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.mixedBelowZero as any,
renderingContext,
},
@@ -156,6 +169,7 @@ export const NegativeOnly = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.negativeOnly as any,
renderingContext,
},
@@ -165,6 +179,7 @@ export const StartsAboveZeroEndsBelow = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.startsAboveZeroEndsBelow as any,
renderingContext,
},
@@ -174,6 +189,7 @@ export const StartsBelowZeroEndsAbove = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.startsBelowZeroEndsAbove as any,
renderingContext,
},
@@ -183,6 +199,7 @@ export const StartsAboveZeroCrossesEndsAbove = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.startsAboveZeroCrossesEndsAbove as any,
renderingContext,
},
@@ -192,6 +209,7 @@ export const StartsBelowZeroCrossesEndsBelow = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.startsBelowZeroCrossesEndsBelow as any,
renderingContext,
},
@@ -201,6 +219,7 @@ export const CustomColors = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.customColors as any,
renderingContext,
},
@@ -210,6 +229,7 @@ export const NoTotalTimeseries = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.noTotalTimeseries as any,
renderingContext,
},
@@ -219,6 +239,7 @@ export const NoTotalOrdinal = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.noTotalOrdinal as any,
renderingContext,
},
@@ -228,6 +249,7 @@ export const DataLabels = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.dataLabels as any,
renderingContext,
},
@@ -237,6 +259,7 @@ export const DataLabelsColumnFormatting = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.dataLabelsColumnFormatting as any,
renderingContext,
},
@@ -246,6 +269,7 @@ export const DataLabelsTimeseries = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.dataLabelsTimeseries as any,
renderingContext,
},
@@ -255,6 +279,7 @@ export const DataLabelsMixed = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.dataLabelsMixed as any,
renderingContext,
},
@@ -264,6 +289,7 @@ export const PowYScale = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.powYScale as any,
renderingContext,
},
@@ -273,6 +299,7 @@ export const PowYScaleNegativeOnly = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.powYScaleNegativeOnly as any,
renderingContext,
},
@@ -282,6 +309,7 @@ export const PowYScaleMixed = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.powYScaleMixed as any,
renderingContext,
},
@@ -291,6 +319,7 @@ export const LogYScale = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.logYScale as any,
renderingContext,
},
@@ -300,6 +329,7 @@ export const LogYScaleNegative = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.logYScaleNegative as any,
renderingContext,
},
@@ -309,6 +339,7 @@ export const NativeTimeSeriesQuarter = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.nativeTimeSeriesQuarter as any,
renderingContext,
},
@@ -318,6 +349,7 @@ export const NativeTimeSeriesWithGaps = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.nativeTimeSeriesWithGaps as any,
renderingContext,
},
@@ -327,6 +359,7 @@ export const StructuredTimeSeriesYear = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.structuredTimeSeriesYear as any,
renderingContext,
},
@@ -336,6 +369,7 @@ export const TimeXScaleTwoBarsWithoutTotal = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.timeXScaleTwoBarsWithoutTotal as any,
renderingContext,
},
@@ -345,6 +379,7 @@ export const EnourmousDataset = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.enormousDataset as any,
renderingContext,
},
@@ -354,6 +389,7 @@ export const Nulls = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.nulls as any,
renderingContext,
},
@@ -363,6 +399,7 @@ export const NullXAxisValue = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.nullXAxisValue as any,
renderingContext,
},
@@ -372,6 +409,7 @@ export const LinearNullDimension = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.linearNullDimension as any,
renderingContext,
},
@@ -381,6 +419,7 @@ export const OrdinalNullDimension = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.ordinalNullDimension as any,
renderingContext,
},
@@ -390,6 +429,7 @@ export const TwoBarsWithTotal = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.twoBarsWithTotal as any,
renderingContext,
},
@@ -399,6 +439,7 @@ export const Watermark = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: data.yAxisFullWithDataLabels as any,
renderingContext,
hasDevWatermark: true,
@@ -409,6 +450,7 @@ export const WithGoalLine = {
render: Template,
args: {
+ // Unjustified type cast. FIXME
rawSeries: updateIn(
data.yAxisFullWithDataLabels,
[0, "card", "visualization_settings"],
diff --git a/frontend/src/metabase/static-viz/index.tsx b/frontend/src/metabase/static-viz/index.tsx
index 6904a5cd252..3e5b1f62b60 100644
--- a/frontend/src/metabase/static-viz/index.tsx
+++ b/frontend/src/metabase/static-viz/index.tsx
@@ -89,6 +89,7 @@ function getVisualizerRawSeries(
): RawSeries {
const { columnValuesMapping, display, settings } = visualization;
+ // Unjustified type cast. FIXME
const datasets = Object.fromEntries(
rawSeries
.filter((series) => series.card.id)
@@ -99,10 +100,12 @@ function getVisualizerRawSeries(
return [
{
+ // Unjustified type cast. FIXME
card: {
display,
visualization_settings: settings,
} as Card,
+ // Unjustified type cast. FIXME
data: mergeVisualizerData({
columns,
columnValuesMapping,
@@ -121,6 +124,7 @@ function RenderChart(
) {
MetabaseSettings.set("token-features", options.tokenFeatures);
MetabaseSettings.set(
+ // Unjustified type cast. FIXME
"application-colors" as SettingKey,
options.applicationColors,
);
@@ -178,8 +182,11 @@ function RenderChart(
// because the "map" visualization isn't registered in the static-viz bundle (it depends on Leaflet).
// The backend resolves the built-in GeoJSON and embeds it in dashcardSettings.
if (rawSeriesWithRemappings[0].card.display === "map") {
+ // Unjustified type cast. FIXME
const extraSettings = dashcardSettings as Record<string, unknown>;
+ // Unjustified type cast. FIXME
const geoJson = extraSettings["map._geojson"] as GeoJSONData | undefined;
+ // Unjustified type cast. FIXME
const geoJsonDetails = extraSettings["map._geojson_details"] as
| { region_key: string; region_name: string }
| undefined;
diff --git a/frontend/src/metabase/status/components/DownloadsStatus/DownloadsStatus.unit.spec.tsx b/frontend/src/metabase/status/components/DownloadsStatus/DownloadsStatus.unit.spec.tsx
index 03a3f24a24d..de041e5e568 100644
--- a/frontend/src/metabase/status/components/DownloadsStatus/DownloadsStatus.unit.spec.tsx
+++ b/frontend/src/metabase/status/components/DownloadsStatus/DownloadsStatus.unit.spec.tsx
@@ -64,6 +64,7 @@ describe("DownloadsStatus", () => {
it("should show and update downloads status", async () => {
const { store } = setup();
+ // Unjustified type cast. FIXME
const dispatch = store.dispatch as Dispatch;
fetchMock.post(
@@ -102,6 +103,7 @@ describe("DownloadsStatus", () => {
it("should show and update downloads status when errored", async () => {
const { store } = setup();
+ // Unjustified type cast. FIXME
const dispatch = store.dispatch as Dispatch;
fetchMock.post(
@@ -150,6 +152,7 @@ describe("DownloadsStatus", () => {
it("should collapse and expand", async () => {
const { store } = setup();
+ // Unjustified type cast. FIXME
const dispatch = store.dispatch as Dispatch;
fetchMock.post(
diff --git a/frontend/src/metabase/status/components/FileUploadStatus/FileUploadStatus.tsx b/frontend/src/metabase/status/components/FileUploadStatus/FileUploadStatus.tsx
index 6a3c3626bb6..a9ed778ef69 100644
--- a/frontend/src/metabase/status/components/FileUploadStatus/FileUploadStatus.tsx
+++ b/frontend/src/metabase/status/components/FileUploadStatus/FileUploadStatus.tsx
@@ -28,7 +28,9 @@ export const FileUploadStatus = () => {
"collectionId",
);
+ // Unjustified type cast. FIXME
const tables = Object.keys(groupedTables) as TableId[];
+ // Unjustified type cast. FIXME
const collections = Object.keys(groupedCollections) as CollectionId[];
return (
diff --git a/frontend/src/metabase/status/components/StatusLarge/StatusLarge.tsx b/frontend/src/metabase/status/components/StatusLarge/StatusLarge.tsx
index 006b5a73a33..d0f7bc1d24d 100644
--- a/frontend/src/metabase/status/components/StatusLarge/StatusLarge.tsx
+++ b/frontend/src/metabase/status/components/StatusLarge/StatusLarge.tsx
@@ -109,6 +109,7 @@ const StatusCard = ({
<LinkWrapper item={item} key={id}>
<StatusCardRoot hasBody={!!description}>
<StatusCardIcon>
+ {/* Unjustified type cast. FIXME */}
<Icon name={icon as unknown as IconName} />
</StatusCardIcon>
<StatusCardBody>
diff --git a/frontend/src/metabase/styled-components/theme/css-variables.unit.spec.ts b/frontend/src/metabase/styled-components/theme/css-variables.unit.spec.ts
index f8570d0113a..dfd208460da 100644
--- a/frontend/src/metabase/styled-components/theme/css-variables.unit.spec.ts
+++ b/frontend/src/metabase/styled-components/theme/css-variables.unit.spec.ts
@@ -4,6 +4,7 @@ import { getThemeSpecificCssVariables } from "./css-variables";
describe("getThemeSpecificCssVariables", () => {
it("returns the correct CSS variables", () => {
+ // Unjustified type cast. FIXME
const theme = {
other: {
dashboard: {
diff --git a/frontend/src/metabase/timelines/collections/containers/NewEventModal/NewEventModal.tsx b/frontend/src/metabase/timelines/collections/containers/NewEventModal/NewEventModal.tsx
index 35ebf35d933..3e6b38c740c 100644
--- a/frontend/src/metabase/timelines/collections/containers/NewEventModal/NewEventModal.tsx
+++ b/frontend/src/metabase/timelines/collections/containers/NewEventModal/NewEventModal.tsx
@@ -37,6 +37,7 @@ function NewEventModalContainer({ params, onClose }: ModalComponentProps) {
_collection?: unknown,
timeline?: Timeline,
) => {
+ // Unjustified type cast. FIXME
await createTimelineEvent(values as CreateTimelineEventRequest).unwrap();
if (timeline) {
dispatch(push(Urls.timelineInCollection(timeline)));
diff --git a/frontend/src/metabase/timelines/collections/containers/NewEventWithTimelineModal/NewEventWithTimelineModal.tsx b/frontend/src/metabase/timelines/collections/containers/NewEventWithTimelineModal/NewEventWithTimelineModal.tsx
index 37e3f1ffb8f..77eb3c9d28d 100644
--- a/frontend/src/metabase/timelines/collections/containers/NewEventWithTimelineModal/NewEventWithTimelineModal.tsx
+++ b/frontend/src/metabase/timelines/collections/containers/NewEventWithTimelineModal/NewEventWithTimelineModal.tsx
@@ -47,8 +47,10 @@ function NewEventWithTimelineModalContainer(
return;
}
const timeline = await createTimeline(
+ // Unjustified type cast. FIXME
getDefaultTimeline(collection) as CreateTimelineRequest,
).unwrap();
+ // Unjustified type cast. FIXME
await createTimelineEvent({
...values,
timeline_id: timeline.id,
diff --git a/frontend/src/metabase/timelines/collections/containers/NewTimelineModal/NewTimelineModal.tsx b/frontend/src/metabase/timelines/collections/containers/NewTimelineModal/NewTimelineModal.tsx
index 8a4633d239c..69c28560779 100644
--- a/frontend/src/metabase/timelines/collections/containers/NewTimelineModal/NewTimelineModal.tsx
+++ b/frontend/src/metabase/timelines/collections/containers/NewTimelineModal/NewTimelineModal.tsx
@@ -31,6 +31,7 @@ function NewTimelineModalContainer(props: NewTimelineModalContainerProps) {
const onSubmit = async (values: Partial<Timeline>) => {
const timeline = await createTimeline(
+ // Unjustified type cast. FIXME
values as CreateTimelineRequest,
).unwrap();
dispatch(push(Urls.timelineInCollection(timeline)));
diff --git a/frontend/src/metabase/timelines/common/components/EventForm/EventForm.tsx b/frontend/src/metabase/timelines/common/components/EventForm/EventForm.tsx
index 85d2d07d800..7308b6ae1d2 100644
--- a/frontend/src/metabase/timelines/common/components/EventForm/EventForm.tsx
+++ b/frontend/src/metabase/timelines/common/components/EventForm/EventForm.tsx
@@ -177,6 +177,7 @@ const EventForm = ({
leftSection={values.icon ? <Icon name={values.icon} /> : null}
renderOption={({ option }) => (
<Group p="sm" fw="bold">
+ {/* Unjustified type cast. FIXME */}
{option.value && <Icon name={option.value as IconName} />}
<span>{option.label}</span>
</Group>
diff --git a/frontend/src/metabase/transforms/hooks/use-register-transform-metabot-context.ts b/frontend/src/metabase/transforms/hooks/use-register-transform-metabot-context.ts
index 4f388bb3707..82a2c8c57a5 100644
--- a/frontend/src/metabase/transforms/hooks/use-register-transform-metabot-context.ts
+++ b/frontend/src/metabase/transforms/hooks/use-register-transform-metabot-context.ts
@@ -47,6 +47,7 @@ export const registerTransformMetabotContextFn = ({
return {
user_is_viewing: [
+ // Unjustified type cast. FIXME
{
...transform,
type: "transform",
diff --git a/frontend/src/metabase/transforms/pages/RunListPage/RunFilterBar/RunMethodFilterWidget/RunMethodFilterWidget.tsx b/frontend/src/metabase/transforms/pages/RunListPage/RunFilterBar/RunMethodFilterWidget/RunMethodFilterWidget.tsx
index 1773a013ea7..20568fa775e 100644
--- a/frontend/src/metabase/transforms/pages/RunListPage/RunFilterBar/RunMethodFilterWidget/RunMethodFilterWidget.tsx
+++ b/frontend/src/metabase/transforms/pages/RunListPage/RunFilterBar/RunMethodFilterWidget/RunMethodFilterWidget.tsx
@@ -68,6 +68,7 @@ function RunMethodFilterForm({
const isValid = runMethods.length > 0;
const handleChange = (values: string[]) => {
+ // Unjustified type cast. FIXME
setRunMethods(values as TransformRunMethod[]);
};
diff --git a/frontend/src/metabase/transforms/pages/RunListPage/RunFilterBar/StatusFilterWidget/StatusFilterWidget.tsx b/frontend/src/metabase/transforms/pages/RunListPage/RunFilterBar/StatusFilterWidget/StatusFilterWidget.tsx
index 465271698e5..aa993a1a83d 100644
--- a/frontend/src/metabase/transforms/pages/RunListPage/RunFilterBar/StatusFilterWidget/StatusFilterWidget.tsx
+++ b/frontend/src/metabase/transforms/pages/RunListPage/RunFilterBar/StatusFilterWidget/StatusFilterWidget.tsx
@@ -89,6 +89,7 @@ function StatusFilterForm({
const isValid = statuses.length > 0;
const handleChange = (values: string[]) => {
+ // Unjustified type cast. FIXME
setStatuses(values as TransformRunStatus[]);
};
diff --git a/frontend/src/metabase/transforms/pages/TransformIndexesPage/IndexEditorModal/DirectionList.tsx b/frontend/src/metabase/transforms/pages/TransformIndexesPage/IndexEditorModal/DirectionList.tsx
index 393ac74b684..0e12db0988f 100644
--- a/frontend/src/metabase/transforms/pages/TransformIndexesPage/IndexEditorModal/DirectionList.tsx
+++ b/frontend/src/metabase/transforms/pages/TransformIndexesPage/IndexEditorModal/DirectionList.tsx
@@ -33,6 +33,7 @@ export function DirectionList({
<SegmentedControl
value={column.direction}
onChange={(direction) =>
+ // Unjustified type cast. FIXME
onChange(column.name, direction as IndexColumnDirection)
}
data={getDirectionOptions()}
diff --git a/frontend/src/metabase/transforms/pages/TransformIndexesPage/IndexEditorModal/IndexEditorModal.unit.spec.tsx b/frontend/src/metabase/transforms/pages/TransformIndexesPage/IndexEditorModal/IndexEditorModal.unit.spec.tsx
index b8259e3e992..dd856285312 100644
--- a/frontend/src/metabase/transforms/pages/TransformIndexesPage/IndexEditorModal/IndexEditorModal.unit.spec.tsx
+++ b/frontend/src/metabase/transforms/pages/TransformIndexesPage/IndexEditorModal/IndexEditorModal.unit.spec.tsx
@@ -268,5 +268,6 @@ async function waitForBody(name: string) {
expect(fetchMock.callHistory.called(name)).toBe(true);
});
const call = fetchMock.callHistory.lastCall(name);
+ // Unjustified type cast. FIXME
return JSON.parse(call?.options?.body as string);
}
diff --git a/frontend/src/metabase/transforms/pages/TransformIndexesPage/IndexEditorModal/utils.ts b/frontend/src/metabase/transforms/pages/TransformIndexesPage/IndexEditorModal/utils.ts
index a5bab306aee..bce821532fe 100644
--- a/frontend/src/metabase/transforms/pages/TransformIndexesPage/IndexEditorModal/utils.ts
+++ b/frontend/src/metabase/transforms/pages/TransformIndexesPage/IndexEditorModal/utils.ts
@@ -32,6 +32,7 @@ export function buildInitialValues(
structured?: StructuredIndex,
carriedValues?: IndexFormValues,
): IndexFormValues {
+ // Unjustified type cast. FIXME
const source = structured as Record<string, IndexFieldValue> | undefined;
return Object.fromEntries(
fields.map((field) => [
@@ -94,5 +95,6 @@ export function toStructured(
structured[field.name] = value;
}
}
+ // Unjustified type cast. FIXME
return structured as StructuredIndex;
}
diff --git a/frontend/src/metabase/transforms/pages/TransformListPage/utils.ts b/frontend/src/metabase/transforms/pages/TransformListPage/utils.ts
index 0c52f5b1d9f..8bfae9acfff 100644
--- a/frontend/src/metabase/transforms/pages/TransformListPage/utils.ts
+++ b/frontend/src/metabase/transforms/pages/TransformListPage/utils.ts
@@ -125,11 +125,13 @@ export function buildTreeData(
function buildCollectionNode(collection: Collection): TreeNode {
const childFolders = (collection.children ?? []).map(buildCollectionNode);
+ // Unjustified type cast. FIXME
const childTransforms = (
transformsByCollectionId.get(collection.id as number) ?? []
).map(buildTransformNode);
return {
+ // Unjustified type cast. FIXME
id: getCollectionNodeId(collection.id as number),
name: collection.name,
nodeType: "folder",
@@ -174,6 +176,7 @@ export function getDefaultExpandedIds(
const ancestors = targetCollection.effective_ancestors ?? [];
for (const ancestor of ancestors.slice(1)) {
+ // Unjustified type cast. FIXME
expandedIds[getCollectionNodeId(ancestor.id as number)] = true;
}
expandedIds[getCollectionNodeId(targetCollectionId)] = true;
@@ -185,6 +188,7 @@ export function getDescendantCollectionIds(node: TreeNode): Set<number> {
const ids = new Set<number>();
const visit = (current: TreeNode) => {
if (isCollectionNode(current)) {
+ // Unjustified type cast. FIXME
ids.add(current.collection.id as number);
}
current.children?.forEach(visit);
@@ -284,6 +288,7 @@ export function useGetNodeSyncColor(): (
collectionIds.has(entity.collection_id)) ||
(entity.model === COLLECTION_MODEL && collectionIds.has(entity.id)),
);
+ // Unjustified type cast. FIXME
return getFolderSyncColor(entities, node.collection.id as number);
}
return undefined;
diff --git a/frontend/src/metabase/transforms/pages/TransformListPage/utils.unit.spec.ts b/frontend/src/metabase/transforms/pages/TransformListPage/utils.unit.spec.ts
index e6fff94b712..fc9ef2bfb96 100644
--- a/frontend/src/metabase/transforms/pages/TransformListPage/utils.unit.spec.ts
+++ b/frontend/src/metabase/transforms/pages/TransformListPage/utils.unit.spec.ts
@@ -45,7 +45,9 @@ jest.mock("metabase-lib", () => ({
const query = Lib.createTestQuery(SAMPLE_PROVIDER, DEFAULT_TEST_QUERY);
+// Unjustified type cast. FIXME
const mockGetLibQuery = getLibQuery as jest.MockedFunction<typeof getLibQuery>;
+// Unjustified type cast. FIXME
const mockTemplateTags = Lib.templateTags as jest.MockedFunction<
typeof Lib.templateTags
>;
diff --git a/frontend/src/metabase/transforms/pages/TransformQueryPage/TransformQueryPage.tsx b/frontend/src/metabase/transforms/pages/TransformQueryPage/TransformQueryPage.tsx
index c9ec1446aba..0fe759cf02f 100644
--- a/frontend/src/metabase/transforms/pages/TransformQueryPage/TransformQueryPage.tsx
+++ b/frontend/src/metabase/transforms/pages/TransformQueryPage/TransformQueryPage.tsx
@@ -304,6 +304,7 @@ function TransformQueryPageBody({
onClose={closeTurnOffIncremental}
/>
<LeaveRouteConfirmModal
+ // Unjustified type cast. FIXME
route={route as Route}
isEnabled={isDirty && !isSaving}
onConfirm={rejectProposed}
diff --git a/frontend/src/metabase/ui/colors/colors.ts b/frontend/src/metabase/ui/colors/colors.ts
index a9aae0f311f..c2f7c51ddb1 100644
--- a/frontend/src/metabase/ui/colors/colors.ts
+++ b/frontend/src/metabase/ui/colors/colors.ts
@@ -6,6 +6,7 @@ import { getBaseColorsForThemeDefinitionOnly } from "./constants/base-colors";
import { deriveFullMetabaseTheme } from "./derive-theme";
import type { MetabaseColorKey } from "./types/color-keys";
+// Unjustified type cast. FIXME
const win = typeof window !== "undefined" ? window : ({} as Window);
const tokenFeatures = win.MetabaseBootstrap?.["token-features"] ?? {};
const shouldWhitelabel = !!tokenFeatures["whitelabel"];
@@ -23,6 +24,7 @@ export const colors: Record<MetabaseColorKey, string> =
export const mutateColors = (whitelabelColors: ColorSettings) => {
// Empty the `colors` object to make sure we don't hold onto previously defined (now undefined) values
Object.keys(colors).forEach((key) => {
+ // Unjustified type cast. FIXME
delete colors[key as keyof typeof colors];
});
Object.assign(colors, getColors(whitelabelColors));
diff --git a/frontend/src/metabase/ui/colors/derive-theme.ts b/frontend/src/metabase/ui/colors/derive-theme.ts
index fe68e2d46f6..8627c7f872b 100644
--- a/frontend/src/metabase/ui/colors/derive-theme.ts
+++ b/frontend/src/metabase/ui/colors/derive-theme.ts
@@ -39,6 +39,7 @@ export function deriveFullMetabaseTheme({
...PROTECTED_COLORS,
);
+ // Unjustified type cast. FIXME
const colors = {
...baseTheme.colors,
...mapChartColorsToAccents(baseTheme.chartColors),
diff --git a/frontend/src/metabase/ui/colors/derive-theme.unit.spec.ts b/frontend/src/metabase/ui/colors/derive-theme.unit.spec.ts
index 60516e3bb61..f487ab761b9 100644
--- a/frontend/src/metabase/ui/colors/derive-theme.unit.spec.ts
+++ b/frontend/src/metabase/ui/colors/derive-theme.unit.spec.ts
@@ -106,9 +106,11 @@ describe("deriveFullMetabaseTheme", () => {
//accent 1 should be default
expect(derived.colors["accent1"]).toBe(METABASE_LIGHT_THEME.chartColors[1]);
expect(derived.colors["accent1-light"]).toBe(
+ // Unjustified type cast. FIXME
deriveChartTintColor(METABASE_LIGHT_THEME.chartColors[1] as string),
);
expect(derived.colors["accent1-dark"]).toBe(
+ // Unjustified type cast. FIXME
deriveChartShadeColor(METABASE_LIGHT_THEME.chartColors[1] as string),
);
diff --git a/frontend/src/metabase/ui/colors/groups.ts b/frontend/src/metabase/ui/colors/groups.ts
index f1702edd990..daa158868e2 100644
--- a/frontend/src/metabase/ui/colors/groups.ts
+++ b/frontend/src/metabase/ui/colors/groups.ts
@@ -31,6 +31,7 @@ export const getAccentColors = (
const getBaseAccentsNames = (withGray = false) => {
const accents: ColorName[] = _.times(
ACCENT_COUNT,
+ // Unjustified type cast. FIXME
(i) => `accent${i}` as ColorName,
);
if (withGray) {
@@ -55,6 +56,7 @@ export const getLightAccentColors = (
withGray = false,
): string[] => {
return getBaseAccentsNames(withGray).map((accent) =>
+ // Unjustified type cast. FIXME
Color(color(`${accent}-light` as ColorName, palette)).hex(),
);
};
@@ -64,6 +66,7 @@ export const getDarkAccentColors = (
withGray = false,
) => {
return getBaseAccentsNames(withGray).map((accent) =>
+ // Unjustified type cast. FIXME
Color(color(`${accent}-dark` as ColorName, palette)).hex(),
);
};
diff --git a/frontend/src/metabase/ui/colors/palette.ts b/frontend/src/metabase/ui/colors/palette.ts
index f63a3c4fe06..c8d7a041655 100644
--- a/frontend/src/metabase/ui/colors/palette.ts
+++ b/frontend/src/metabase/ui/colors/palette.ts
@@ -57,6 +57,7 @@ export function color(color: any, palette: ColorPalette = colors) {
};
if (color in fullPalette) {
+ // Unjustified type cast. FIXME
return fullPalette[color as keyof ColorPalette];
}
diff --git a/frontend/src/metabase/ui/components/data-display/Badge/Badge.config.tsx b/frontend/src/metabase/ui/components/data-display/Badge/Badge.config.tsx
index 1a8cec1b155..ad46947abc0 100644
--- a/frontend/src/metabase/ui/components/data-display/Badge/Badge.config.tsx
+++ b/frontend/src/metabase/ui/components/data-display/Badge/Badge.config.tsx
@@ -62,8 +62,9 @@ const SIZES = {
sm: { height: "1.5rem", paddingX: "0.5rem" }, // 24px / 8px
} as const;
-const isBadgeColor = (value: unknown): value is BadgeColor =>
- BADGE_COLORS.includes(value as BadgeColor);
+const isBadgeColor = (value: unknown): value is BadgeColor => {
+ return BADGE_COLORS.some((color) => color === value);
+};
type BadgeRootVars = Partial<
Record<
diff --git a/frontend/src/metabase/ui/components/data-display/Badge/Badge.tsx b/frontend/src/metabase/ui/components/data-display/Badge/Badge.tsx
index 108dfb40e8b..d8a19d3736c 100644
--- a/frontend/src/metabase/ui/components/data-display/Badge/Badge.tsx
+++ b/frontend/src/metabase/ui/components/data-display/Badge/Badge.tsx
@@ -35,6 +35,8 @@ export const Badge = forwardRef<HTMLDivElement, BadgeProps>(function Badge(
) {
return (
<MantineBadge
+ // we're overloading `color` prop with custom values, based on which
+ // proper color tokens will be used (see Badge.config.tsx)
color={color as MantineBadgeProps["color"]}
ref={ref}
size={size}
diff --git a/frontend/src/metabase/ui/components/data-display/TreeTable/TreeTable.stories.tsx b/frontend/src/metabase/ui/components/data-display/TreeTable/TreeTable.stories.tsx
index d0bda0929eb..4a9c9cbed21 100644
--- a/frontend/src/metabase/ui/components/data-display/TreeTable/TreeTable.stories.tsx
+++ b/frontend/src/metabase/ui/components/data-display/TreeTable/TreeTable.stories.tsx
@@ -247,6 +247,7 @@ export const LargeDataset = {
export const EmptyState = {
render: function EmptyStateStory() {
const instance = useTreeTableInstance({
+ // Unjustified type cast. FIXME
data: [] as CollectionItem[],
columns: detailedColumns,
getSubRows: (node) => node.children,
diff --git a/frontend/src/metabase/ui/components/icons/Icon/Icon.tsx b/frontend/src/metabase/ui/components/icons/Icon/Icon.tsx
index df243e50885..d79bdb78d6b 100644
--- a/frontend/src/metabase/ui/components/icons/Icon/Icon.tsx
+++ b/frontend/src/metabase/ui/components/icons/Icon/Icon.tsx
@@ -54,6 +54,7 @@ export const Icon = forwardRef<SVGSVGElement, IconProps>(function Icon(
// like "core-yellow-saturated" don't render — only valid CSS color strings do.
// Resolve known palette keys to their `--mb-color-*` CSS variables.
if ("color" in restProps) {
+ // Unjustified type cast. FIXME
restProps.color = resolveIconColor(restProps.color) as ColorName;
}
diff --git a/frontend/src/metabase/ui/components/icons/Icon/icons/index.ts b/frontend/src/metabase/ui/components/icons/Icon/icons/index.ts
index e2841ceab25..ee020668bb2 100644
--- a/frontend/src/metabase/ui/components/icons/Icon/icons/index.ts
+++ b/frontend/src/metabase/ui/components/icons/Icon/icons/index.ts
@@ -1815,7 +1815,9 @@ export const Icons: Record<IconName, { component: React.VFC; source: string }> =
eye_filled: { component: eye_component, source: eye_source },
};
+// Unjustified type cast. FIXME
export const iconNames = Object.keys(Icons) as unknown as IconName[];
export const isValidIconName = (name: unknown): name is IconName =>
+ // Unjustified type cast. FIXME
iconNames.includes(name as IconName);
diff --git a/frontend/src/metabase/ui/components/inputs/DatePicker/DatePicker.stories.tsx b/frontend/src/metabase/ui/components/inputs/DatePicker/DatePicker.stories.tsx
index 8035c4c7689..365cc1ccd7f 100644
--- a/frontend/src/metabase/ui/components/inputs/DatePicker/DatePicker.stories.tsx
+++ b/frontend/src/metabase/ui/components/inputs/DatePicker/DatePicker.stories.tsx
@@ -77,6 +77,7 @@ export const MultipleDates = {
export const DatesRange = {
name: "Dates range",
args: {
+ // Unjustified type cast. FIXME
type: "range" as DatePickerProps["type"],
defaultValue: [sampleArgs.date1, sampleArgs.date2],
defaultDate: sampleArgs.date1,
diff --git a/frontend/src/metabase/ui/components/inputs/TextInputBlurChange/TextInputBlurChange.unit.spec.tsx b/frontend/src/metabase/ui/components/inputs/TextInputBlurChange/TextInputBlurChange.unit.spec.tsx
index 7349d167c0a..2030e3eeefc 100644
--- a/frontend/src/metabase/ui/components/inputs/TextInputBlurChange/TextInputBlurChange.unit.spec.tsx
+++ b/frontend/src/metabase/ui/components/inputs/TextInputBlurChange/TextInputBlurChange.unit.spec.tsx
@@ -65,6 +65,7 @@ describe("TextInputBlurChange", () => {
it("should set `internalValue` to the normalized value even if the normalized value is the same as the previous one", async () => {
const value = "/";
+ // Unjustified type cast. FIXME
setup({ value, normalize: (value) => (value as string).trim() });
const input = screen.getByDisplayValue<HTMLInputElement>(value);
await userEvent.clear(input);
diff --git a/frontend/src/metabase/ui/components/inputs/TextareaBlurChange/TextareaBlurChange.unit.spec.tsx b/frontend/src/metabase/ui/components/inputs/TextareaBlurChange/TextareaBlurChange.unit.spec.tsx
index 0f44769d9ba..806eab0293e 100644
--- a/frontend/src/metabase/ui/components/inputs/TextareaBlurChange/TextareaBlurChange.unit.spec.tsx
+++ b/frontend/src/metabase/ui/components/inputs/TextareaBlurChange/TextareaBlurChange.unit.spec.tsx
@@ -69,6 +69,7 @@ describe("TextareaBlurChange", () => {
it("should set `internalValue` to the normalized value even if the normalized value is the same as the previous one", async () => {
const value = "/";
+ // Unjustified type cast. FIXME
setup({ value, normalize: (value) => (value as string).trim() });
const input = screen.getByDisplayValue<HTMLInputElement>(value);
await userEvent.clear(input);
diff --git a/frontend/src/metabase/ui/components/inputs/TimeInput/TimeInput.unit.spec.tsx b/frontend/src/metabase/ui/components/inputs/TimeInput/TimeInput.unit.spec.tsx
index df469912293..a688cca4007 100644
--- a/frontend/src/metabase/ui/components/inputs/TimeInput/TimeInput.unit.spec.tsx
+++ b/frontend/src/metabase/ui/components/inputs/TimeInput/TimeInput.unit.spec.tsx
@@ -48,6 +48,7 @@ describe("TimeInput", () => {
const input = screen.getByLabelText("Time");
await userEvent.type(input, "10:20");
+ // Unjustified type cast. FIXME
const time = onChange.mock.lastCall[0] as Date;
expect(time.getHours()).toBe(10);
expect(time.getMinutes()).toBe(20);
@@ -62,6 +63,7 @@ describe("TimeInput", () => {
await userEvent.type(input, "12:");
await userEvent.tab();
+ // Unjustified type cast. FIXME
const time = onChange.mock.lastCall[0] as Date;
expect(time.getHours()).toBe(10);
expect(time.getMinutes()).toBe(20);
diff --git a/frontend/src/metabase/ui/components/navigation/Tabs/Tabs.stories.tsx b/frontend/src/metabase/ui/components/navigation/Tabs/Tabs.stories.tsx
index a089fcc47d2..4dff77ff105 100644
--- a/frontend/src/metabase/ui/components/navigation/Tabs/Tabs.stories.tsx
+++ b/frontend/src/metabase/ui/components/navigation/Tabs/Tabs.stories.tsx
@@ -52,6 +52,7 @@ const IconsTemplate = (args: TabsProps) => (
key={tab.value}
value={tab.value}
disabled={tab.disabled}
+ // Unjustified type cast. FIXME
leftSection={<Icon name={tab.icon as keyof typeof Icon} />}
>
{tab.label}
diff --git a/frontend/src/metabase/ui/components/overlays/Menu/MenuItem/MenuItem.tsx b/frontend/src/metabase/ui/components/overlays/Menu/MenuItem/MenuItem.tsx
index ec939e0332a..95733e8f549 100644
--- a/frontend/src/metabase/ui/components/overlays/Menu/MenuItem/MenuItem.tsx
+++ b/frontend/src/metabase/ui/components/overlays/Menu/MenuItem/MenuItem.tsx
@@ -10,6 +10,7 @@ export const MenuItem = forwardRef(
props: PolymorphicComponentProps<C, MenuItemProps>,
ref: React.Ref<HTMLButtonElement>,
) => {
+ // Unjustified type cast. FIXME
const typeCastedProps = props as MenuItemProps;
const handleMouseDownCapture = (event: MouseEvent) => {
diff --git a/frontend/src/metabase/ui/components/theme/ThemeProvider/ThemeProvider.tsx b/frontend/src/metabase/ui/components/theme/ThemeProvider/ThemeProvider.tsx
index a43d7165147..ce00666f76c 100644
--- a/frontend/src/metabase/ui/components/theme/ThemeProvider/ThemeProvider.tsx
+++ b/frontend/src/metabase/ui/components/theme/ThemeProvider/ThemeProvider.tsx
@@ -60,11 +60,13 @@ export const ThemeProvider = ({
resolvedColorSchemeProp ?? colorSchemeContext.resolvedColorScheme;
const theme = useMemo(() => {
+ // Unjustified type cast. FIXME
const baseTheme = merge(
getThemeOverrides(resolvedColorScheme, whitelabelColors),
themeOverride,
) as MantineTheme;
+ // Unjustified type cast. FIXME
return {
...baseTheme,
other: {
@@ -78,8 +80,11 @@ export const ThemeProvider = ({
const { primaryShade, primaryColor } = baseTheme;
return color in baseTheme.colors
- ? baseTheme.colors[color][primaryShade as number]
- : baseTheme.colors[primaryColor as ColorName][
+ ? // Unjustified type cast. FIXME
+ baseTheme.colors[color][primaryShade as number]
+ : // Unjustified type cast. FIXME
+ baseTheme.colors[primaryColor as ColorName][
+ // Unjustified type cast. FIXME
primaryShade as number
];
},
diff --git a/frontend/src/metabase/ui/components/typography/Code/Code.stories.tsx b/frontend/src/metabase/ui/components/typography/Code/Code.stories.tsx
index 255a95a6c12..cf9f200e33d 100644
--- a/frontend/src/metabase/ui/components/typography/Code/Code.stories.tsx
+++ b/frontend/src/metabase/ui/components/typography/Code/Code.stories.tsx
@@ -14,6 +14,7 @@ function Demo() {
}`;
const BlockTemplate = (args: CodeProps) => <Code {...args}>{CODE_BLOCK}</Code>;
+// Unjustified type cast. FIXME
export default {
title: "Components/Text/Code",
component: Code,
diff --git a/frontend/src/metabase/ui/utils/colors.ts b/frontend/src/metabase/ui/utils/colors.ts
index ecbf63a8d7d..44ee16bf5bf 100644
--- a/frontend/src/metabase/ui/utils/colors.ts
+++ b/frontend/src/metabase/ui/utils/colors.ts
@@ -67,6 +67,7 @@ export function color(colorName: ColorName): string {
}
export const isColorName = (name?: string | null): name is ColorName => {
+ // Unjustified type cast. FIXME
return !!name && ALL_COLOR_NAMES.includes(name as MetabaseColorKey);
};
diff --git a/frontend/src/metabase/urls/cards.ts b/frontend/src/metabase/urls/cards.ts
index 7b6d8c58595..3639e945541 100644
--- a/frontend/src/metabase/urls/cards.ts
+++ b/frontend/src/metabase/urls/cards.ts
@@ -64,7 +64,8 @@ export function card(
if (!card || !card.id || isTransientCardId(card.id) || forceUnsaved) {
const unsavedPath = path === "metric" ? "question" : path;
const computedHash = card?.dataset_query
- ? `#${serializeCardForUrl(card as SavedCard | UnsavedCard, {
+ ? // Unjustified type cast. FIXME
+ `#${serializeCardForUrl(card as SavedCard | UnsavedCard, {
creationType,
parameterValues,
includeDisplayIsLocked,
diff --git a/frontend/src/metabase/urls/data-studio.ts b/frontend/src/metabase/urls/data-studio.ts
index 03086c44d54..9184338559d 100644
--- a/frontend/src/metabase/urls/data-studio.ts
+++ b/frontend/src/metabase/urls/data-studio.ts
@@ -39,6 +39,7 @@ export function isDataStudioTableMetadataTab(
tab: unknown,
): tab is DataStudioTableMetadataTab {
return DATA_STUDIO_TABLE_METADATA_TABS.includes(
+ // Unjustified type cast. FIXME
tab as DataStudioTableMetadataTab,
);
}
diff --git a/frontend/src/metabase/urls/modelToUrl.ts b/frontend/src/metabase/urls/modelToUrl.ts
index 165381aac82..3b1549bd5be 100644
--- a/frontend/src/metabase/urls/modelToUrl.ts
+++ b/frontend/src/metabase/urls/modelToUrl.ts
@@ -76,6 +76,7 @@ export function modelToUrl(item: UrlableModel): string {
case "transform":
return transform(item.id);
case "indexed-entity":
+ // Unjustified type cast. FIXME
return indexedEntity(item as IndexedEntity);
case "action":
if (item.model_id != null) {
diff --git a/frontend/src/metabase/utils/browser.unit.spec.ts b/frontend/src/metabase/utils/browser.unit.spec.ts
index 7feab9f65b4..c1e6a5ba32f 100644
--- a/frontend/src/metabase/utils/browser.unit.spec.ts
+++ b/frontend/src/metabase/utils/browser.unit.spec.ts
@@ -26,6 +26,7 @@ function setup({
(query === "(hover: hover)" && hover),
});
} else {
+ // Unjustified type cast. FIXME
(window as any).matchMedia = undefined;
}
diff --git a/frontend/src/metabase/utils/clone.ts b/frontend/src/metabase/utils/clone.ts
index a5e1f5322be..1aa837ae2d9 100644
--- a/frontend/src/metabase/utils/clone.ts
+++ b/frontend/src/metabase/utils/clone.ts
@@ -4,5 +4,6 @@
* TODO: remove this when Cypress and Jest support native `structuredClone`.
*/
export function clone<T>(value: T): T {
+ // Unjustified type cast. FIXME
return JSON.parse(JSON.stringify(value)) as T;
}
diff --git a/frontend/src/metabase/utils/dayjs-parse-zone-plugin.ts b/frontend/src/metabase/utils/dayjs-parse-zone-plugin.ts
index 7c8e894b6ad..dfc8c717387 100644
--- a/frontend/src/metabase/utils/dayjs-parse-zone-plugin.ts
+++ b/frontend/src/metabase/utils/dayjs-parse-zone-plugin.ts
@@ -50,6 +50,7 @@ const pluginFunc: PluginFunc = (_option, _dayjsClass, dayjsFactory) => {
date,
{
utc: true,
+ // Unjustified type cast. FIXME
...(parsedFormat as object),
},
locale,
@@ -75,6 +76,7 @@ const pluginFunc: PluginFunc = (_option, _dayjsClass, dayjsFactory) => {
{
// @ts-expect-error $offset is not defined in type definition, we'll keep it for guaranteed compatibility after migrating to ts
$offset: offset,
+ // Unjustified type cast. FIXME
...(parsedFormat as object),
},
locale,
diff --git a/frontend/src/metabase/utils/dom.ts b/frontend/src/metabase/utils/dom.ts
index e694111a83d..f5ceaee2347 100644
--- a/frontend/src/metabase/utils/dom.ts
+++ b/frontend/src/metabase/utils/dom.ts
@@ -216,7 +216,9 @@ export const getEventTarget = (
clientX = event.changedTouches[0].clientX;
clientY = event.changedTouches[0].clientY;
} else {
+ // Unjustified type cast. FIXME
clientX = (event as MouseEvent).clientX;
+ // Unjustified type cast. FIXME
clientY = (event as MouseEvent).clientY;
}
diff --git a/frontend/src/metabase/utils/errors/messages.ts b/frontend/src/metabase/utils/errors/messages.ts
index 2455cdcff1a..ca8df2a63e3 100644
--- a/frontend/src/metabase/utils/errors/messages.ts
+++ b/frontend/src/metabase/utils/errors/messages.ts
@@ -4,6 +4,7 @@ import type { GenericErrorResponse } from "./types";
* @deprecated Use `getErrorMessage` from `metabase/api/utils` instead.
*/
export function getResponseErrorMessage(error: unknown): string | undefined {
+ // Unjustified type cast. FIXME
const response = error as GenericErrorResponse | undefined;
if (!response) {
diff --git a/frontend/src/metabase/utils/formatting/datetime-utils.ts b/frontend/src/metabase/utils/formatting/datetime-utils.ts
index ab088a7f21e..3ad59f4b009 100644
--- a/frontend/src/metabase/utils/formatting/datetime-utils.ts
+++ b/frontend/src/metabase/utils/formatting/datetime-utils.ts
@@ -13,9 +13,11 @@ const UNITS_WITH_HOUR_SET = new Set(UNITS_WITH_HOUR);
const UNITS_WITH_DAY_SET = new Set(UNITS_WITH_DAY);
export const hasDay = (unit: DatetimeUnit | undefined) =>
+ // Unjustified type cast. FIXME
unit == null || UNITS_WITH_DAY_SET.has(unit as UNITS_WITH_DAY_TYPE);
export const hasHour = (unit: DatetimeUnit | undefined) =>
+ // Unjustified type cast. FIXME
unit == null || UNITS_WITH_HOUR_SET.has(unit as UNITS_WITH_HOUR_TYPE);
export function getTimeFormatFromStyle(
diff --git a/frontend/src/metabase/utils/formatting/numbers.tsx b/frontend/src/metabase/utils/formatting/numbers.tsx
index 2ca8d22e576..8f787b4c0ee 100644
--- a/frontend/src/metabase/utils/formatting/numbers.tsx
+++ b/frontend/src/metabase/utils/formatting/numbers.tsx
@@ -187,9 +187,11 @@ export function numberFormatterForOptions(options: FormatNumberOptions) {
// always use "en" locale so we have known number separators we can replace depending on number_separators option
// TODO: if we do that how can we get localized currency names?
return new Intl.NumberFormat("en", {
+ // Unjustified type cast. FIXME
style: options.number_style as Intl.NumberFormatOptions["style"],
currency: options.currency,
currencyDisplay:
+ // Unjustified type cast. FIXME
options.currency_style as Intl.NumberFormatOptions["currencyDisplay"],
// always use grouping separators, but we may replace/remove them depending on number_separators option
useGrouping: true,
diff --git a/frontend/src/metabase/utils/formatting/time.ts b/frontend/src/metabase/utils/formatting/time.ts
index 480b38c9aab..9f847c91ff4 100644
--- a/frontend/src/metabase/utils/formatting/time.ts
+++ b/frontend/src/metabase/utils/formatting/time.ts
@@ -95,7 +95,8 @@ export function formatTimeWithUnit(
const timeFormat = options.time_format
? options.time_format
- : getTimeFormatFromStyle(timeStyle, unit, timeEnabled as any);
+ : // Unjustified type cast. FIXME
+ getTimeFormatFromStyle(timeStyle, unit, timeEnabled as any);
return d.format(timeFormat);
}
@@ -120,6 +121,7 @@ export function formatTime(
const timeFormat =
options.time_format ??
+ // Unjustified type cast. FIXME
getTimeFormatFromStyle(timeStyle, unit, timeEnabled as any);
return parsedTime.isValid() ? parsedTime.format(timeFormat) : String(time);
diff --git a/frontend/src/metabase/utils/i18n.ts b/frontend/src/metabase/utils/i18n.ts
index daf23066181..1e8d133b685 100644
--- a/frontend/src/metabase/utils/i18n.ts
+++ b/frontend/src/metabase/utils/i18n.ts
@@ -112,6 +112,7 @@ function getStartOfWeekDay(
// we delete msgid property since it's redundant, but have to add it back in to
// make ttag happy
function addMsgIds(translationsObject: LocaleDataWithLanguage): void {
+ // Unjustified type cast. FIXME
const msgs = translationsObject.translations[""] as Record<
string,
{ msgid?: string; msgstr: string[] }
diff --git a/frontend/src/metabase/utils/jwt.unit.spec.ts b/frontend/src/metabase/utils/jwt.unit.spec.ts
index 41cd69e3550..1f403bd3f0e 100644
--- a/frontend/src/metabase/utils/jwt.unit.spec.ts
+++ b/frontend/src/metabase/utils/jwt.unit.spec.ts
@@ -5,6 +5,7 @@ import { extractResourceIdFromJwtToken } from "./jwt";
const SECRET = new TextEncoder().encode("test-secret-key-for-jwt-signing");
const createJwtToken = async (payload: object): Promise<string> => {
+ // Unjustified type cast. FIXME
return new SignJWT(payload as Record<string, unknown>)
.setProtectedHeader({ alg: "HS256" })
.sign(SECRET);
diff --git a/frontend/src/metabase/utils/metaplow.ts b/frontend/src/metabase/utils/metaplow.ts
index 17fb64dc8c8..5bb41e4a043 100644
--- a/frontend/src/metabase/utils/metaplow.ts
+++ b/frontend/src/metabase/utils/metaplow.ts
@@ -32,6 +32,7 @@ export function initMetaplow(config: MetaplowConfig): void {
hostUrl,
tag: "metabase-instance",
beforeSend: (type, originalPayload) => {
+ // Unjustified type cast. FIXME
let payload = originalPayload as Record<string, unknown>;
// Replace default pageview behavior with our own custom pageview tracking
@@ -41,6 +42,7 @@ export function initMetaplow(config: MetaplowConfig): void {
}
if (payload.name === "pageview" && isObject(payload.data)) {
payload = { ...payload, url: payload.data.url };
+ // Unjustified type cast. FIXME
delete (payload.data as Record<string, unknown>).url;
}
@@ -55,6 +57,7 @@ export function initMetaplow(config: MetaplowConfig): void {
title: "",
hostname: anonymizedHostname,
data: {
+ // Unjustified type cast. FIXME
...(payload.data as Record<string, unknown> | undefined),
user_id: config.getUserId(),
},
diff --git a/frontend/src/metabase/utils/metaplow.unit.spec.ts b/frontend/src/metabase/utils/metaplow.unit.spec.ts
index 3be83923e86..3a9d4b8a03f 100644
--- a/frontend/src/metabase/utils/metaplow.unit.spec.ts
+++ b/frontend/src/metabase/utils/metaplow.unit.spec.ts
@@ -38,9 +38,11 @@ describe("metaplow", () => {
const [url, init] = fetchSpy.mock.calls[0];
expect(url).toBe(METAPLOW_URL);
expect(init?.method).toBe("POST");
+ // Unjustified type cast. FIXME
expect((init?.headers as Record<string, string>)["Content-Type"]).toBe(
"application/json",
);
+ // Unjustified type cast. FIXME
return JSON.parse(init?.body as string);
};
diff --git a/frontend/src/metabase/utils/objects.ts b/frontend/src/metabase/utils/objects.ts
index 823307ab2a5..dc77b9a7fd5 100644
--- a/frontend/src/metabase/utils/objects.ts
+++ b/frontend/src/metabase/utils/objects.ts
@@ -1,12 +1,14 @@
export const getObjectEntries = <K extends string, V>(
obj: Record<K, V>,
): [K, V][] => {
+ // Unjustified type cast. FIXME
return Object.entries(obj) as [K, V][];
};
export const getObjectKeys = <K extends string>(
obj: Partial<Record<K, unknown>>,
): K[] => {
+ // Unjustified type cast. FIXME
return Object.keys(obj) as K[];
};
@@ -17,6 +19,7 @@ export const getObjectValues = <V>(obj: Record<string, V>): V[] => {
export const objectFromEntries = <K extends string, V>(
entries: readonly (readonly [K, V])[],
): Record<K, V> => {
+ // Unjustified type cast. FIXME
return Object.fromEntries(entries) as Record<K, V>;
};
@@ -86,6 +89,7 @@ export function isSerializable(value: unknown): boolean {
return value.every(isSerializable);
}
+ // Unjustified type cast. FIXME
return Object.values(value as Record<string, unknown>).every(
isSerializable,
);
diff --git a/frontend/src/metabase/utils/objects.unit.spec.ts b/frontend/src/metabase/utils/objects.unit.spec.ts
index b2d3a904e92..b9d278bbf98 100644
--- a/frontend/src/metabase/utils/objects.unit.spec.ts
+++ b/frontend/src/metabase/utils/objects.unit.spec.ts
@@ -267,9 +267,11 @@ describe("sortObject", () => {
});
it("should sort keys recursively", () => {
+ // Unjustified type cast. FIXME
const o1 = { o: {} as Record<string, number> };
o1.o.a = 1;
o1.o.b = 2;
+ // Unjustified type cast. FIXME
const o2 = { o: {} as Record<string, number> };
o2.o.b = 2;
o2.o.a = 1;
diff --git a/frontend/src/metabase/utils/retry.unit.spec.ts b/frontend/src/metabase/utils/retry.unit.spec.ts
index e8077254db0..79f6607c0b7 100644
--- a/frontend/src/metabase/utils/retry.unit.spec.ts
+++ b/frontend/src/metabase/utils/retry.unit.spec.ts
@@ -146,6 +146,7 @@ describe("retry", () => {
const result = await resultPromise;
expect(result).toBeInstanceOf(DOMException);
+ // Unjustified type cast. FIXME
expect((result as DOMException).name).toBe("AbortError");
expect(fn).toHaveBeenCalledTimes(1);
});
diff --git a/frontend/src/metabase/utils/settings.ts b/frontend/src/metabase/utils/settings.ts
index d12c71f0e86..0debdb1ba7c 100644
--- a/frontend/src/metabase/utils/settings.ts
+++ b/frontend/src/metabase/utils/settings.ts
@@ -46,6 +46,7 @@ class MetabaseSettings {
* @deprecated set setting values in the redux store
*/
setAll(settings: Settings) {
+ // Unjustified type cast. FIXME
const keys = Object.keys(settings) as SettingKey[];
keys.forEach((key) => {
@@ -210,6 +211,7 @@ class MetabaseSettings {
* Only use this when Redux store is not always available, e.g. in ThemeProvider
*/
applicationColors(): ColorSettings {
+ // Unjustified type cast. FIXME
return this.get("application-colors" as SettingKey) as ColorSettings;
}
}
diff --git a/frontend/src/metabase/utils/time-dayjs.ts b/frontend/src/metabase/utils/time-dayjs.ts
index 17e710bea80..123aa8f5c54 100644
--- a/frontend/src/metabase/utils/time-dayjs.ts
+++ b/frontend/src/metabase/utils/time-dayjs.ts
@@ -95,6 +95,7 @@ export function parseTimestamp(
} else if (typeof value === "string" && /(Z|[+-]\d\d:?\d\d)$/.test(value)) {
result = dayjs.parseZone(value);
} else if (unit && unit in TEXT_UNIT_FORMATS && typeof value === "string") {
+ // Unjustified type cast. FIXME
result = TEXT_UNIT_FORMATS[unit as "day-of-week"](value);
} else if (unit && unit in NUMERIC_UNIT_FORMATS && typeof value == "number") {
result = NUMERIC_UNIT_FORMATS[unit](value);
diff --git a/frontend/src/metabase/visualizations/click-actions/Mode/Mode.ts b/frontend/src/metabase/visualizations/click-actions/Mode/Mode.ts
index 6943c2703da..30906aada28 100644
--- a/frontend/src/metabase/visualizations/click-actions/Mode/Mode.ts
+++ b/frontend/src/metabase/visualizations/click-actions/Mode/Mode.ts
@@ -76,6 +76,7 @@ export class Mode implements ClickActionsMode {
buttonType: "horizontal",
name: "default",
+ // Unjustified type cast. FIXME
...(actionsOrActionObject as Partial<ClickAction>),
},
];
diff --git a/frontend/src/metabase/visualizations/click-actions/actions/DashboardClickAction.tsx b/frontend/src/metabase/visualizations/click-actions/actions/DashboardClickAction.tsx
index c3de49f7639..aab11aafb40 100644
--- a/frontend/src/metabase/visualizations/click-actions/actions/DashboardClickAction.tsx
+++ b/frontend/src/metabase/visualizations/click-actions/actions/DashboardClickAction.tsx
@@ -43,6 +43,7 @@ function getAction(
// "dashboard-filter" and "dashboard-reset" drill types are produced.
const setOrUnsetParameterValues = clicked.extraData
?.setOrUnsetParameterValues as SetOrUnsetParameterValues;
+ // Unjustified type cast. FIXME
const setParameterValue = clicked.extraData
?.setParameterValue as SetParameterValue;
@@ -63,6 +64,7 @@ function getAction(
case "dashboard-filter":
return {
action: () => {
+ // Unjustified type cast. FIXME
const parameterIdValuePairs = getDashboardDrillParameters(
clicked,
) as [string, ParameterValueOrArray | null][];
@@ -78,6 +80,7 @@ function getAction(
dispatch(selectTab({ tabId }));
}
+ // Unjustified type cast. FIXME
const parameterIdValuePairs = getDashboardDrillParameters(
clicked,
) as [string, ParameterValueOrArray | null][];
diff --git a/frontend/src/metabase/visualizations/click-actions/modes/EmbeddingSdkMode.ts b/frontend/src/metabase/visualizations/click-actions/modes/EmbeddingSdkMode.ts
index 9958bb9f804..4015f65dbf7 100644
--- a/frontend/src/metabase/visualizations/click-actions/modes/EmbeddingSdkMode.ts
+++ b/frontend/src/metabase/visualizations/click-actions/modes/EmbeddingSdkMode.ts
@@ -55,6 +55,7 @@ const getClickBehaviorTarget = (
})
: {};
+ // Unjustified type cast. FIXME
const parameterIdValuePairs = (
parameterMapping
? getParameterIdValuePairs(parameterMapping, {
diff --git a/frontend/src/metabase/visualizations/components/ChartCaption.tsx b/frontend/src/metabase/visualizations/components/ChartCaption.tsx
index 255a7289750..f7d572e8280 100644
--- a/frontend/src/metabase/visualizations/components/ChartCaption.tsx
+++ b/frontend/src/metabase/visualizations/components/ChartCaption.tsx
@@ -44,6 +44,7 @@ const ChartCaption = ({
"";
const description = settings["card.description"];
const data =
+ // Unjustified type cast. FIXME
visualizerRawSeries ?? (series as TransformedSeries)._raw ?? series;
const card = data?.[0].card;
const cardIds = new Set(data?.map((s) => s.card.id) ?? []);
diff --git a/frontend/src/metabase/visualizations/components/ChartSettings/BaseChartSettings/BaseChartSettings.tsx b/frontend/src/metabase/visualizations/components/ChartSettings/BaseChartSettings/BaseChartSettings.tsx
index 1c6ca810624..6912b593a7a 100644
--- a/frontend/src/metabase/visualizations/components/ChartSettings/BaseChartSettings/BaseChartSettings.tsx
+++ b/frontend/src/metabase/visualizations/components/ChartSettings/BaseChartSettings/BaseChartSettings.tsx
@@ -228,6 +228,7 @@ export const BaseChartSettings = ({
</ChartSettingsListContainer>
</Stack>
<ChartSettingsWidgetPopover
+ // Unjustified type cast. FIXME
anchor={popoverRef as HTMLElement}
widgets={[styleWidget, formattingWidget].filter(
(widget): widget is Widget => !!widget,
diff --git a/frontend/src/metabase/visualizations/components/ChartSettingsWidgetPopover.tsx b/frontend/src/metabase/visualizations/components/ChartSettingsWidgetPopover.tsx
index e55ca42acb8..f2f8d884d8b 100644
--- a/frontend/src/metabase/visualizations/components/ChartSettingsWidgetPopover.tsx
+++ b/frontend/src/metabase/visualizations/components/ChartSettingsWidgetPopover.tsx
@@ -57,6 +57,7 @@ export const ChartSettingsWidgetPopover = ({
const hasMultipleSections = sections.current.length > 1;
const onClose = () => {
+ // Unjustified type cast. FIXME
const activeElement = document.activeElement as HTMLElement;
if (activeElement && contentRef.current?.contains(activeElement)) {
activeElement.blur();
diff --git a/frontend/src/metabase/visualizations/components/ChartTooltip/KeyValuePairChartTooltip/KeyValuePairChartTooltip.tsx b/frontend/src/metabase/visualizations/components/ChartTooltip/KeyValuePairChartTooltip/KeyValuePairChartTooltip.tsx
index 9b52119bbe3..fe3c6c7d625 100644
--- a/frontend/src/metabase/visualizations/components/ChartTooltip/KeyValuePairChartTooltip/KeyValuePairChartTooltip.tsx
+++ b/frontend/src/metabase/visualizations/components/ChartTooltip/KeyValuePairChartTooltip/KeyValuePairChartTooltip.tsx
@@ -104,6 +104,7 @@ const getRows = (hovered: HoveredObject) => {
dimensions.push(...hovered.dimensions);
}
if (hovered.value !== undefined) {
+ // Unjustified type cast. FIXME
dimensions.push({
value: hovered.value,
column: hovered.column,
diff --git a/frontend/src/metabase/visualizations/components/ClickActions/utils.ts b/frontend/src/metabase/visualizations/components/ClickActions/utils.ts
index 83470587a3c..6ae77e8cdfb 100644
--- a/frontend/src/metabase/visualizations/components/ClickActions/utils.ts
+++ b/frontend/src/metabase/visualizations/components/ClickActions/utils.ts
@@ -38,6 +38,7 @@ Object.values(SECTIONS).map((section, index) => {
export const getGroupedAndSortedActions = (
clickActions: RegularClickAction[],
) => {
+ // Unjustified type cast. FIXME
const groupedClickActions = _.groupBy(clickActions, "section") as {
[key in ClickActionSection]?: RegularClickAction[];
};
diff --git a/frontend/src/metabase/visualizations/components/FunnelNormal.tsx b/frontend/src/metabase/visualizations/components/FunnelNormal.tsx
index acf1c29de57..60437b9a9f6 100644
--- a/frontend/src/metabase/visualizations/components/FunnelNormal.tsx
+++ b/frontend/src/metabase/visualizations/components/FunnelNormal.tsx
@@ -123,6 +123,7 @@ export function FunnelNormal({
const formatPercent = (percent: number) => `${(100 * percent).toFixed(2)} %`;
const dimensions = sortedRows.map((row) => row[dimensionIndex]);
+ // Unjustified type cast. FIXME
const metrics = sortedRows.map((row) => row[metricIndex]) as number[];
// this is a little hacky, since this component and static-viz use different data structures for the funnel steps
diff --git a/frontend/src/metabase/visualizations/components/FunnelNormal.unit.spec.ts b/frontend/src/metabase/visualizations/components/FunnelNormal.unit.spec.ts
index a50ca59d296..16d8a2f37e1 100644
--- a/frontend/src/metabase/visualizations/components/FunnelNormal.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/components/FunnelNormal.unit.spec.ts
@@ -67,6 +67,7 @@ describe("FunnelNormal row matching (metabase#71488)", () => {
// Metrics should still be correct
const metrics = sortedRows.map((row) => row[1]) as number[];
const funnelData = metrics.map(
+ // Unjustified type cast. FIXME
(metric, i) => [i, metric] as [number, number],
);
expect(() => calculateFunnelSteps(funnelData, 1, 1)).not.toThrow();
diff --git a/frontend/src/metabase/visualizations/components/ObjectDetail/ObjectDetailPanel.tsx b/frontend/src/metabase/visualizations/components/ObjectDetail/ObjectDetailPanel.tsx
index 2241e92916a..dd9db7c2898 100644
--- a/frontend/src/metabase/visualizations/components/ObjectDetail/ObjectDetailPanel.tsx
+++ b/frontend/src/metabase/visualizations/components/ObjectDetail/ObjectDetailPanel.tsx
@@ -163,6 +163,7 @@ export function ObjectDetailPanel({
_.isEmpty(table.fks) &&
!isVirtualCardId(table.id)
) {
+ // Unjustified type cast. FIXME
fetchTableFks?.(table.id as ConcreteTableId);
}
});
diff --git a/frontend/src/metabase/visualizations/components/ObjectDetail/utils.ts b/frontend/src/metabase/visualizations/components/ObjectDetail/utils.ts
index aff992128f9..d3c8b4fd059 100644
--- a/frontend/src/metabase/visualizations/components/ObjectDetail/utils.ts
+++ b/frontend/src/metabase/visualizations/components/ObjectDetail/utils.ts
@@ -43,6 +43,7 @@ export const getObjectName = ({
const entityNameColumn = cols && cols?.findIndex(isEntityName);
if (zoomedRow?.length && zoomedRow[entityNameColumn]) {
+ // Unjustified type cast. FIXME
return zoomedRow[entityNameColumn] as string;
}
@@ -82,6 +83,7 @@ export const getDisplayId = ({
const pkColumn = cols[pkColumnIndex];
const columnSetting = settings?.column?.(pkColumn) ?? {};
+ // Unjustified type cast. FIXME
return formatValue(zoomedRow[pkColumnIndex], {
...columnSetting,
column: pkColumn,
@@ -98,6 +100,7 @@ export const getDisplayId = ({
const defaultColumn = cols[0];
const columnSetting = settings?.column?.(defaultColumn) ?? {};
+ // Unjustified type cast. FIXME
return formatValue(zoomedRow[0], {
...columnSetting,
column: defaultColumn,
@@ -119,6 +122,7 @@ export const getIdValue = ({
const { cols, rows } = data;
const columnIndex = cols.findIndex(getIsPKFromTablePredicate(tableId));
+ // Unjustified type cast. FIXME
return rows[0][columnIndex] as number;
};
@@ -192,6 +196,7 @@ export function getApiTable(
return undefined;
}
+ // Unjustified type cast. FIXME
const apiTable: ApiTable = {
...table.getPlainObject(),
fields: table.original_fields,
diff --git a/frontend/src/metabase/visualizations/components/TableInteractive/TableInteractive.tsx b/frontend/src/metabase/visualizations/components/TableInteractive/TableInteractive.tsx
index 7061f8b85b3..7bdb57f9a3c 100644
--- a/frontend/src/metabase/visualizations/components/TableInteractive/TableInteractive.tsx
+++ b/frontend/src/metabase/visualizations/components/TableInteractive/TableInteractive.tsx
@@ -317,6 +317,7 @@ export const TableInteractiveInner = forwardRef(function TableInteractiveInner(
);
const clicked = getCellClickedObject(columnIndex, rowIndex);
+ // Unjustified type cast. FIXME
const isLink = (formattedValue as any)?.type === ExternalLink;
if (getIsCellClickable(clicked) && !isLink) {
onVisualizationClick?.({
diff --git a/frontend/src/metabase/visualizations/components/TableInteractive/utils/get-info-popovers-disabled.unit.spec.ts b/frontend/src/metabase/visualizations/components/TableInteractive/utils/get-info-popovers-disabled.unit.spec.ts
index 86112d99ced..383c6f99d80 100644
--- a/frontend/src/metabase/visualizations/components/TableInteractive/utils/get-info-popovers-disabled.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/components/TableInteractive/utils/get-info-popovers-disabled.unit.spec.ts
@@ -17,6 +17,7 @@ describe("getInfoPopoversDisabled", () => {
// metabase#55637: clicking a header cell sets `clicked` and the
// header-info popover must stop appearing on subsequent hovers.
it("returns true when a click action is open", () => {
+ // Unjustified type cast. FIXME
const clicked = { element: document.createElement("div") } as ClickObject;
expect(getInfoPopoversDisabled({ ...baseArgs, clicked })).toBe(true);
});
diff --git a/frontend/src/metabase/visualizations/components/TrendInfo/use-trend-data.ts b/frontend/src/metabase/visualizations/components/TrendInfo/use-trend-data.ts
index b655ae7405f..74d033508ac 100644
--- a/frontend/src/metabase/visualizations/components/TrendInfo/use-trend-data.ts
+++ b/frontend/src/metabase/visualizations/components/TrendInfo/use-trend-data.ts
@@ -57,6 +57,7 @@ function computeTrendData(
}
const latestValue = rows[latestRowIndex][metricColumnIndex];
+ // Unjustified type cast. FIXME
const latestDate = rows[latestRowIndex][dateColumnIndex] as string;
const formattedValue = formatValue(latestValue, { column: metricColumn });
diff --git a/frontend/src/metabase/visualizations/components/Visualization/Visualization-themed.unit.spec.tsx b/frontend/src/metabase/visualizations/components/Visualization/Visualization-themed.unit.spec.tsx
index ff67bd5d693..05fa2cafd0e 100644
--- a/frontend/src/metabase/visualizations/components/Visualization/Visualization-themed.unit.spec.tsx
+++ b/frontend/src/metabase/visualizations/components/Visualization/Visualization-themed.unit.spec.tsx
@@ -14,6 +14,7 @@ describe("Themed Visualization", () => {
it("inherits the chart label color from the theme", async () => {
const TEST_COLOR = "rgb(44, 55, 66)";
+ // Unjustified type cast. FIXME
const series = [
{
card: createMockCard({ name: "Card", display: "bar" }),
diff --git a/frontend/src/metabase/visualizations/components/Visualization/Visualization.tsx b/frontend/src/metabase/visualizations/components/Visualization/Visualization.tsx
index 3ac7ffc06ab..9b079bf44f1 100644
--- a/frontend/src/metabase/visualizations/components/Visualization/Visualization.tsx
+++ b/frontend/src/metabase/visualizations/components/Visualization/Visualization.tsx
@@ -242,6 +242,7 @@ const deriveStateFromProps = (props: VisualizationProps) => {
const transformed = props.rawSeries
? getVisualizationTransformed(
+ // Unjustified type cast. FIXME
extractRemappings(props.rawSeries as RawSeries),
)
: null;
@@ -284,6 +285,7 @@ class Visualization extends PureComponent<
width: 0,
// prefer passing in a function that doesn't cause the application to reload
onChangeLocation: (location: Location) => {
+ // Unjustified type cast. FIXME
window.location = location as any;
},
};
@@ -781,6 +783,7 @@ class Visualization extends PureComponent<
}
} catch (e: unknown) {
error =
+ // Unjustified type cast. FIXME
(e as Error).message ||
t`Could not display this chart with this data.`;
if (
@@ -844,6 +847,7 @@ class Visualization extends PureComponent<
};
}
+ // Unjustified type cast. FIXME
const CardVisualization = visualization as VisualizationType;
const isVisualizerDashCard = isVisualizerDashboardCard(dashcard);
@@ -974,6 +978,7 @@ class Visualization extends PureComponent<
metadata={metadata}
mode={mode}
queryBuilderMode={queryBuilderMode}
+ // Unjustified type cast. FIXME
rawSeries={rawSeries as RawSeries}
visualizerRawSeries={visualizerRawSeries}
renderEmptyMessage={renderEmptyMessage}
diff --git a/frontend/src/metabase/visualizations/components/Visualization/Visualization.unit.spec.tsx b/frontend/src/metabase/visualizations/components/Visualization/Visualization.unit.spec.tsx
index fad18ad9a91..aa7683c749c 100644
--- a/frontend/src/metabase/visualizations/components/Visualization/Visualization.unit.spec.tsx
+++ b/frontend/src/metabase/visualizations/components/Visualization/Visualization.unit.spec.tsx
@@ -26,6 +26,7 @@ import {
registerVisualizations();
+// Unjustified type cast. FIXME
const MOCK_DISPLAY = "mocked-visualization" as VisualizationDisplay;
const MockedVisualization = Object.assign(
diff --git a/frontend/src/metabase/visualizations/components/legend/LegendItemDot.tsx b/frontend/src/metabase/visualizations/components/legend/LegendItemDot.tsx
index 237f2b1d661..1533632eead 100644
--- a/frontend/src/metabase/visualizations/components/legend/LegendItemDot.tsx
+++ b/frontend/src/metabase/visualizations/components/legend/LegendItemDot.tsx
@@ -34,6 +34,7 @@ export const LegendItemDot = forwardRef<
aria-label={isVisible ? t`Hide series` : t`Show series`}
onClick={onClick}
style={sizeStyle}
+ // Unjustified type cast. FIXME
ref={ref as Ref<HTMLButtonElement>}
>
<OuterCircle style={sizeStyle} />
@@ -46,6 +47,7 @@ export const LegendItemDot = forwardRef<
<Root
data-testid="legend-item-dot"
style={sizeStyle}
+ // Unjustified type cast. FIXME
ref={ref as Ref<HTMLDivElement>}
>
<OuterCircle style={sizeStyle} />
diff --git a/frontend/src/metabase/visualizations/components/settings/ChartNestedSettingSeriesSingle.unit.spec.tsx b/frontend/src/metabase/visualizations/components/settings/ChartNestedSettingSeriesSingle.unit.spec.tsx
index 9cd9da6e048..ca88371e765 100644
--- a/frontend/src/metabase/visualizations/components/settings/ChartNestedSettingSeriesSingle.unit.spec.tsx
+++ b/frontend/src/metabase/visualizations/components/settings/ChartNestedSettingSeriesSingle.unit.spec.tsx
@@ -13,6 +13,7 @@ import type { Series } from "metabase-types/api";
registerVisualizations();
function getSeries(): Series {
+ // Unjustified type cast. FIXME
return [
{
card: {
@@ -76,6 +77,7 @@ function getSeries(): Series {
}
function getTrendlineSeries(settings: ComputedVisualizationSettings): Series {
+ // Unjustified type cast. FIXME
return [
{
card: {
diff --git a/frontend/src/metabase/visualizations/components/settings/ChartSettingFieldPicker/ChartSettingFieldPicker.tsx b/frontend/src/metabase/visualizations/components/settings/ChartSettingFieldPicker/ChartSettingFieldPicker.tsx
index 804ac64ab70..07dd41ef0b3 100644
--- a/frontend/src/metabase/visualizations/components/settings/ChartSettingFieldPicker/ChartSettingFieldPicker.tsx
+++ b/frontend/src/metabase/visualizations/components/settings/ChartSettingFieldPicker/ChartSettingFieldPicker.tsx
@@ -138,6 +138,7 @@ export const ChartSettingFieldPicker = ({
<Group wrap="nowrap" gap="xs" p="xs" ml="sm" mr="md" align="center">
{showDragHandle && (
<Icon
+ // Unjustified type cast. FIXME
ref={dragHandleRef as Ref<SVGSVGElement>}
name="grabber"
{...dragHandleListeners}
diff --git a/frontend/src/metabase/visualizations/components/settings/ChartSettingFieldsPartition.tsx b/frontend/src/metabase/visualizations/components/settings/ChartSettingFieldsPartition.tsx
index c8d6a898480..06a11485ac3 100644
--- a/frontend/src/metabase/visualizations/components/settings/ChartSettingFieldsPartition.tsx
+++ b/frontend/src/metabase/visualizations/components/settings/ChartSettingFieldsPartition.tsx
@@ -90,6 +90,7 @@ const ChartSettingFieldsPartitionInternal = ({
{Object.keys(items).map((partitionName) => (
<PartitionContainer
key={partitionName}
+ // Unjustified type cast. FIXME
partitionName={partitionName as keyof ColumnNameColumnSplitSetting}
partitions={partitions}
items={items}
diff --git a/frontend/src/metabase/visualizations/components/settings/ChartSettingMaxCategories.tsx b/frontend/src/metabase/visualizations/components/settings/ChartSettingMaxCategories.tsx
index 062087e9f57..66763ea960a 100644
--- a/frontend/src/metabase/visualizations/components/settings/ChartSettingMaxCategories.tsx
+++ b/frontend/src/metabase/visualizations/components/settings/ChartSettingMaxCategories.tsx
@@ -35,6 +35,7 @@ export const ChartSettingMaxCategories = ({
(value: string | null) => {
if (value) {
onChangeSettings({
+ // Unjustified type cast. FIXME
"graph.other_category_aggregation_fn": value as AggregationFunction,
});
}
diff --git a/frontend/src/metabase/visualizations/components/settings/ChartSettingSegmentsEditor/ChartSettingSegmentsEditor.unit.spec.tsx b/frontend/src/metabase/visualizations/components/settings/ChartSettingSegmentsEditor/ChartSettingSegmentsEditor.unit.spec.tsx
index 7ccdca3a0f1..5abd8be7b68 100644
--- a/frontend/src/metabase/visualizations/components/settings/ChartSettingSegmentsEditor/ChartSettingSegmentsEditor.unit.spec.tsx
+++ b/frontend/src/metabase/visualizations/components/settings/ChartSettingSegmentsEditor/ChartSettingSegmentsEditor.unit.spec.tsx
@@ -35,6 +35,7 @@ it("Should render a segment editor", () => {
// Add a row for the header
expect(screen.getAllByRole("row")).toHaveLength(3);
+ // Unjustified type cast. FIXME
const firstRow = screen.getAllByRole("row").at(1) as HTMLElement;
expect(within(firstRow).getByPlaceholderText(/optional/)).toHaveValue("bad");
@@ -64,6 +65,7 @@ it("Should allow you to remove a segment", async () => {
const { onChange } = setup();
await userEvent.click(
+ // Unjustified type cast. FIXME
(await screen.findAllByRole("img", { name: /trash/ })).at(0) as HTMLElement,
);
@@ -87,6 +89,7 @@ it("Should allow you to remove all segments if canRemoveAll is passed", async ()
expect(await screen.findAllByRole("img", { name: /trash/ })).toHaveLength(1);
await userEvent.click(
+ // Unjustified type cast. FIXME
(await screen.findAllByRole("img", { name: /trash/ })).at(0) as HTMLElement,
);
diff --git a/frontend/src/metabase/visualizations/components/settings/ChartSettingSelect.tsx b/frontend/src/metabase/visualizations/components/settings/ChartSettingSelect.tsx
index 069cf5e8dfb..579a60bac79 100644
--- a/frontend/src/metabase/visualizations/components/settings/ChartSettingSelect.tsx
+++ b/frontend/src/metabase/visualizations/components/settings/ChartSettingSelect.tsx
@@ -132,6 +132,7 @@ export const ChartSettingSelect = ({
//Mantine V7 select onChange has 2 arguments passed. This breaks the assumption in visualizations/lib/settings.js where the onChange function is defined
onChange={(v) => {
onChange(
+ // Unjustified type cast. FIXME
v == null ? null : (decodeWidgetValue(v) as ChartSettingSelectValue),
);
}}
diff --git a/frontend/src/metabase/visualizations/components/settings/ChartSettingsTableFormatting/RuleEditor.tsx b/frontend/src/metabase/visualizations/components/settings/ChartSettingsTableFormatting/RuleEditor.tsx
index 2c062e349fc..8b350ad1ae0 100644
--- a/frontend/src/metabase/visualizations/components/settings/ChartSettingsTableFormatting/RuleEditor.tsx
+++ b/frontend/src/metabase/visualizations/components/settings/ChartSettingsTableFormatting/RuleEditor.tsx
@@ -116,6 +116,7 @@ export const RuleEditor = ({
value={rule.type}
onChange={(type) =>
onChange({
+ // Unjustified type cast. FIXME
...DEFAULTS_BY_TYPE[type as "single" | "range"],
columns: rule.columns,
})
@@ -207,6 +208,7 @@ export const RuleEditor = ({
onChange({
...rule,
min_type:
+ // Unjustified type cast. FIXME
min_type as ColumnRangeFormattingSetting["min_type"],
})
}
@@ -239,6 +241,7 @@ export const RuleEditor = ({
onChange({
...rule,
max_type:
+ // Unjustified type cast. FIXME
max_type as ColumnRangeFormattingSetting["max_type"],
})
}
diff --git a/frontend/src/metabase/visualizations/echarts/boxplot/events.ts b/frontend/src/metabase/visualizations/echarts/boxplot/events.ts
index bd865828554..322f340ee69 100644
--- a/frontend/src/metabase/visualizations/echarts/boxplot/events.ts
+++ b/frontend/src/metabase/visualizations/echarts/boxplot/events.ts
@@ -44,6 +44,7 @@ const extractPointData = (
if (!isDatasetRowObject(dataValue)) {
return null;
}
+ // Unjustified type cast. FIXME
const xValue = dataValue[X_AXIS_DATA_KEY] as RowValue;
const yValue = dataValue[dataKey];
const rawIndex = dataValue[INDEX_KEY];
diff --git a/frontend/src/metabase/visualizations/echarts/boxplot/option/index.ts b/frontend/src/metabase/visualizations/echarts/boxplot/option/index.ts
index 396960031de..246e0f4c678 100644
--- a/frontend/src/metabase/visualizations/echarts/boxplot/option/index.ts
+++ b/frontend/src/metabase/visualizations/echarts/boxplot/option/index.ts
@@ -180,6 +180,7 @@ export const getBoxPlotOption = (
const datasets: { source: OptionSourceData; dimensions: string[] }[] = [
{
+ // Unjustified type cast. FIXME
source: chartModel.boxDataset as OptionSourceData,
dimensions: boxDimensions,
},
@@ -187,18 +188,21 @@ export const getBoxPlotOption = (
if (pointsDatasetIndices.outlierAbove >= 0) {
datasets.push({
+ // Unjustified type cast. FIXME
source: chartModel.outlierAbovePointsDataset as OptionSourceData,
dimensions: pointsDimensions,
});
}
if (pointsDatasetIndices.outlierBelow >= 0) {
datasets.push({
+ // Unjustified type cast. FIXME
source: chartModel.outlierBelowPointsDataset as OptionSourceData,
dimensions: pointsDimensions,
});
}
if (pointsDatasetIndices.nonOutlier >= 0) {
datasets.push({
+ // Unjustified type cast. FIXME
source: chartModel.nonOutlierPointsDataset as OptionSourceData,
dimensions: pointsDimensions,
});
diff --git a/frontend/src/metabase/visualizations/echarts/boxplot/option/series.ts b/frontend/src/metabase/visualizations/echarts/boxplot/option/series.ts
index cf70960c3ca..64c3edec164 100644
--- a/frontend/src/metabase/visualizations/echarts/boxplot/option/series.ts
+++ b/frontend/src/metabase/visualizations/echarts/boxplot/option/series.ts
@@ -235,7 +235,9 @@ export const buildEChartsPointsSeries = (
),
textBorderWidth: BOXPLOT_DATA_LABEL_STYLE.textBorderWidth,
formatter: (params) => {
+ // Unjustified type cast. FIXME
const data = params.data as Record<string, unknown> | undefined;
+ // Unjustified type cast. FIXME
const y = data?.[dataKey] as number | null | undefined;
if (y == null || !Number.isFinite(y)) {
return "";
@@ -408,7 +410,9 @@ export const buildEChartsBoxPlotLabelsSeries = (
),
textBorderWidth: BOXPLOT_DATA_LABEL_STYLE.textBorderWidth,
formatter: (params) => {
+ // Unjustified type cast. FIXME
const data = params.data as Record<string, unknown>;
+ // Unjustified type cast. FIXME
const yValue = data[statKey] as number | null;
if (yValue == null || !Number.isFinite(yValue)) {
return "";
diff --git a/frontend/src/metabase/visualizations/echarts/cartesian/layout/index.ts b/frontend/src/metabase/visualizations/echarts/cartesian/layout/index.ts
index ac69137113d..18fe99973ab 100644
--- a/frontend/src/metabase/visualizations/echarts/cartesian/layout/index.ts
+++ b/frontend/src/metabase/visualizations/echarts/cartesian/layout/index.ts
@@ -246,6 +246,7 @@ const getXAxisTicksWidth = (
if (isNumericAxis(axisModel)) {
// extents need to be untransformed to get the value of the tick label
return axisModel.fromEChartsAxisValue(
+ // Unjustified type cast. FIXME
dataset[index][X_AXIS_DATA_KEY] as number,
);
}
diff --git a/frontend/src/metabase/visualizations/echarts/cartesian/model/axis.ts b/frontend/src/metabase/visualizations/echarts/cartesian/model/axis.ts
index 91fa13ac14c..b4c201e0b89 100644
--- a/frontend/src/metabase/visualizations/echarts/cartesian/model/axis.ts
+++ b/frontend/src/metabase/visualizations/echarts/cartesian/model/axis.ts
@@ -279,6 +279,7 @@ const getYAxisSplit = (
seriesStack != null ? seriesStack.axis : seriesSettings?.["axis"];
return acc;
},
+ // Unjustified type cast. FIXME
{} as Record<DataKey, string | undefined>,
);
@@ -820,6 +821,7 @@ function getNumericXAxisModel(
export const isNumeric = (
scale: ComputedVisualizationSettings["graph.x_axis.scale"],
): scale is NumericScale => {
+ // Unjustified type cast. FIXME
return numericScale.includes(scale as NumericScale);
};
@@ -1008,7 +1010,9 @@ export function getScaledMinAndMax(
const { toEChartsAxisValue } = yAxisScaleTransforms;
+ // Unjustified type cast. FIXME
const customMin = min != null ? (toEChartsAxisValue(min) as number) : null;
+ // Unjustified type cast. FIXME
const customMax = max != null ? (toEChartsAxisValue(max) as number) : null;
return { customMin, customMax };
diff --git a/frontend/src/metabase/visualizations/echarts/cartesian/model/dataset.ts b/frontend/src/metabase/visualizations/echarts/cartesian/model/dataset.ts
index fe4e4f4e922..6b1621a6eee 100644
--- a/frontend/src/metabase/visualizations/echarts/cartesian/model/dataset.ts
+++ b/frontend/src/metabase/visualizations/echarts/cartesian/model/dataset.ts
@@ -730,7 +730,8 @@ export function scaleDataset(
const key = seriesModel.dataKey;
if (key in datum) {
const scaledValue = Number.isFinite(datum[key])
- ? (datum[key] as number) * scale
+ ? // Unjustified type cast. FIXME
+ (datum[key] as number) * scale
: null;
transformedRecord[key] = scaledValue;
}
@@ -994,6 +995,7 @@ export const replaceValues = (
return getObjectKeys(datum).reduce((updatedRow, dataKey) => {
updatedRow[dataKey] = replacer(dataKey, datum[dataKey]);
return updatedRow;
+ // Unjustified type cast. FIXME
}, {} as Datum);
});
};
@@ -1015,6 +1017,7 @@ export const getDatasetExtents = (
acc[key] = extent;
}
return acc;
+ // Unjustified type cast. FIXME
}, {} as SeriesExtents);
};
@@ -1064,6 +1067,7 @@ export const getCardColumnByDataKeyMap = (
}
return acc;
},
+ // Unjustified type cast. FIXME
{} as Record<DataKey, DatasetColumn>,
);
};
@@ -1082,6 +1086,7 @@ export const getCardsColumnByDataKeyMap = (
return { ...acc, ...cardColumnByDataKeyMap };
},
+ // Unjustified type cast. FIXME
{} as Record<DataKey, DatasetColumn>,
);
};
diff --git a/frontend/src/metabase/visualizations/echarts/cartesian/model/dataset.unit.spec.ts b/frontend/src/metabase/visualizations/echarts/cartesian/model/dataset.unit.spec.ts
index e659b2d820a..56f652fd807 100644
--- a/frontend/src/metabase/visualizations/echarts/cartesian/model/dataset.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/echarts/cartesian/model/dataset.unit.spec.ts
@@ -601,6 +601,7 @@ describe("dataset transform functions", () => {
describe("ordinal series", () => {
it("should stringify x values if they're objects (metabase#52684)", () => {
+ // Unjustified type cast. FIXME
const dataset = [
{
[X_AXIS_DATA_KEY]: null,
diff --git a/frontend/src/metabase/visualizations/echarts/cartesian/model/series.ts b/frontend/src/metabase/visualizations/echarts/cartesian/model/series.ts
index d38d903bf51..e90b34642ca 100644
--- a/frontend/src/metabase/visualizations/echarts/cartesian/model/series.ts
+++ b/frontend/src/metabase/visualizations/echarts/cartesian/model/series.ts
@@ -345,6 +345,7 @@ export const getDimensionModel = (
columnByCardId[series.card.id] = cardColumns.dimension.column;
return columnByCardId;
},
+ // Unjustified type cast. FIXME
{} as Record<CardId, DatasetColumn>,
),
};
@@ -857,6 +858,7 @@ export const getFormatters = (
return formatterByStackName;
},
+ // Unjustified type cast. FIXME
{} as StackedSeriesFormatters,
),
seriesLabelsFormatters: seriesLabelsFormattersInfo.reduce(
@@ -867,6 +869,7 @@ export const getFormatters = (
return formatterBySeriesKey;
},
+ // Unjustified type cast. FIXME
{} as SeriesFormatters,
),
};
diff --git a/frontend/src/metabase/visualizations/echarts/cartesian/model/transforms.unit.spec.ts b/frontend/src/metabase/visualizations/echarts/cartesian/model/transforms.unit.spec.ts
index 468a8236b4e..0037f0dd572 100644
--- a/frontend/src/metabase/visualizations/echarts/cartesian/model/transforms.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/echarts/cartesian/model/transforms.unit.spec.ts
@@ -20,6 +20,7 @@ describe("getAxisTransforms", () => {
])(
"should have fromEChartsAxisValue as the inverse of toEChartsAxisValue for %d",
(value) => {
+ // Unjustified type cast. FIXME
const encoded = toEChartsAxisValue(value) as number;
const decoded = fromEChartsAxisValue(encoded);
expect(decoded).toBeCloseTo(value, 5);
diff --git a/frontend/src/metabase/visualizations/echarts/cartesian/model/util.ts b/frontend/src/metabase/visualizations/echarts/cartesian/model/util.ts
index 8affebd2805..2ea082366cf 100644
--- a/frontend/src/metabase/visualizations/echarts/cartesian/model/util.ts
+++ b/frontend/src/metabase/visualizations/echarts/cartesian/model/util.ts
@@ -30,5 +30,6 @@ export function getColumnScaling(
const columnSettings =
settings.column?.(column) ?? getColumnSettings(settings, column);
const scale = columnSettings?.scale;
+ // Unjustified type cast. FIXME
return Number.isFinite(scale) ? (scale as number) : 1;
}
diff --git a/frontend/src/metabase/visualizations/echarts/cartesian/option/goal-line.ts b/frontend/src/metabase/visualizations/echarts/cartesian/option/goal-line.ts
index 51f65ccabba..235812db558 100644
--- a/frontend/src/metabase/visualizations/echarts/cartesian/option/goal-line.ts
+++ b/frontend/src/metabase/visualizations/echarts/cartesian/option/goal-line.ts
@@ -79,6 +79,7 @@ export function getGoalLineSeriesOption(
renderItem: (params, api) => {
const [_x, y] = api.coord([null, scaleTransformedGoalValue]);
const coordSys =
+ // Unjustified type cast. FIXME
params.coordSys as unknown as EChartsCartesianCoordinateSystem;
const xStart = coordSys.x;
const xEnd = coordSys.width + coordSys.x;
diff --git a/frontend/src/metabase/visualizations/echarts/cartesian/option/index.ts b/frontend/src/metabase/visualizations/echarts/cartesian/option/index.ts
index 9d4306473a0..b15a098fed1 100644
--- a/frontend/src/metabase/visualizations/echarts/cartesian/option/index.ts
+++ b/frontend/src/metabase/visualizations/echarts/cartesian/option/index.ts
@@ -91,6 +91,7 @@ export const buildEChartsDataset = (
const dataset: Array<{ source: OptionSourceData; dimensions: string[] }> = [
{
+ // Unjustified type cast. FIXME
source: chartModel.transformedDataset as OptionSourceData,
dimensions,
},
@@ -98,6 +99,7 @@ export const buildEChartsDataset = (
if (chartModel.trendLinesModel) {
dataset.push({
+ // Unjustified type cast. FIXME
source: chartModel.trendLinesModel.dataset as OptionSourceData,
dimensions: [
X_AXIS_DATA_KEY,
@@ -276,6 +278,7 @@ export const getCartesianChartOption = (
(series) => seriesSettingsByDataKey[series.dataKey]?.display === "bar",
);
if (hasAnyBarSeries) {
+ // Unjustified type cast. FIXME
(baseXAxis as Record<string, unknown>).boundaryGap = true;
}
diff --git a/frontend/src/metabase/visualizations/echarts/cartesian/option/series.ts b/frontend/src/metabase/visualizations/echarts/cartesian/option/series.ts
index 857fba442f0..b692b2062ca 100644
--- a/frontend/src/metabase/visualizations/echarts/cartesian/option/series.ts
+++ b/frontend/src/metabase/visualizations/echarts/cartesian/option/series.ts
@@ -167,6 +167,7 @@ export function getDataLabelFormatter(
);
return (params: CallbackDataParams) => {
+ // Unjustified type cast. FIXME
const datum = params.data as Datum;
const value = accessor != null ? accessor(datum) : datum[dataKey];
@@ -397,6 +398,7 @@ export const buildEChartsStackLabelOptions = (
renderingContext.getColor,
),
formatter: (params: CallbackDataParams) => {
+ // Unjustified type cast. FIXME
const transformedDatum = params.data as Datum;
const originalIndex = transformedDatum[INDEX_KEY] ?? params.dataIndex;
const datum = originalDataset[originalIndex];
@@ -753,6 +755,7 @@ function getStackedDataLabelFormatter(
}
const stackValue = getStackTotalValue(
+ // Unjustified type cast. FIXME
params.data as Datum,
stackDataKeys,
signKey,
@@ -853,6 +856,7 @@ export const getStackTotalsSeries = (
);
return Object.values(seriesByStackName).flatMap((seriesOptions) => {
+ // Unjustified type cast. FIXME
const stackDataKeys = seriesOptions // we set string dataKeys as series IDs
.map((s) => s.id)
.filter(isNotNull) as string[];
@@ -860,6 +864,7 @@ export const getStackTotalsSeries = (
const labelFormatter = firstSeriesInStack.stack
? chartModel.stackedLabelsFormatters?.[
+ // Unjustified type cast. FIXME
firstSeriesInStack.stack as "bar" | "area"
]
: undefined;
@@ -932,6 +937,7 @@ export const buildEChartsSeries = (
);
return acc;
},
+ // Unjustified type cast. FIXME
{} as Record<DataKey, number>,
);
diff --git a/frontend/src/metabase/visualizations/echarts/cartesian/option/ticks.ts b/frontend/src/metabase/visualizations/echarts/cartesian/option/ticks.ts
index 4cd49b0a978..e881b205dad 100644
--- a/frontend/src/metabase/visualizations/echarts/cartesian/option/ticks.ts
+++ b/frontend/src/metabase/visualizations/echarts/cartesian/option/ticks.ts
@@ -37,6 +37,7 @@ export const getTicksOptions = (
let minInterval: number | undefined;
let maxInterval: number | undefined;
+ // Unjustified type cast. FIXME
const xDomain = range.map((day) => {
const adjustedDate = dayjs(toEChartsAxisValue(day.toISOString()));
if (!adjustedDate) {
diff --git a/frontend/src/metabase/visualizations/echarts/cartesian/scatter/option/index.ts b/frontend/src/metabase/visualizations/echarts/cartesian/scatter/option/index.ts
index 7467f7b4425..09972ce736a 100644
--- a/frontend/src/metabase/visualizations/echarts/cartesian/scatter/option/index.ts
+++ b/frontend/src/metabase/visualizations/echarts/cartesian/scatter/option/index.ts
@@ -83,6 +83,7 @@ export function getScatterPlotOption(
if (chartModel.trendLinesModel) {
echartsDataset.push({
+ // Unjustified type cast. FIXME
source: chartModel.trendLinesModel?.dataset as OptionSourceData,
dimensions: [
X_AXIS_DATA_KEY,
diff --git a/frontend/src/metabase/visualizations/echarts/cartesian/timeline-events/model.ts b/frontend/src/metabase/visualizations/echarts/cartesian/timeline-events/model.ts
index 72ed9f28a55..5546917a108 100644
--- a/frontend/src/metabase/visualizations/echarts/cartesian/timeline-events/model.ts
+++ b/frontend/src/metabase/visualizations/echarts/cartesian/timeline-events/model.ts
@@ -35,6 +35,7 @@ const groupEventsByUnitStart = (
(acc, event) => {
const unitStart = dayjs
.utc(event.timestamp)
+ // Unjustified type cast. FIXME
.startOf(unit as OpUnitType)
.toISOString();
diff --git a/frontend/src/metabase/visualizations/echarts/cartesian/waterfall/model/index.unit.spec.ts b/frontend/src/metabase/visualizations/echarts/cartesian/waterfall/model/index.unit.spec.ts
index 19773583951..844690b3dba 100644
--- a/frontend/src/metabase/visualizations/echarts/cartesian/waterfall/model/index.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/echarts/cartesian/waterfall/model/index.unit.spec.ts
@@ -52,6 +52,7 @@ describe("getWaterfallChartModel", () => {
measureText: () => 10,
measureTextHeight: () => 10,
fontFamily: "Arial",
+ // Unjustified type cast. FIXME
theme: { cartesian: { label: { fontSize: 12 } } } as any,
};
diff --git a/frontend/src/metabase/visualizations/echarts/pie/format.ts b/frontend/src/metabase/visualizations/echarts/pie/format.ts
index b83ae982c34..5222b4bcdef 100644
--- a/frontend/src/metabase/visualizations/echarts/pie/format.ts
+++ b/frontend/src/metabase/visualizations/echarts/pie/format.ts
@@ -71,6 +71,7 @@ export function getPieChartFormatters(
return String(
formatValue(value, {
column: metricColSettings.column,
+ // Unjustified type cast. FIXME
number_separators: metricColSettings.number_separators as string,
number_style: "percent",
decimals,
diff --git a/frontend/src/metabase/visualizations/echarts/pie/model/index.unit.spec.ts b/frontend/src/metabase/visualizations/echarts/pie/model/index.unit.spec.ts
index 7d108206b4d..10ca568b786 100644
--- a/frontend/src/metabase/visualizations/echarts/pie/model/index.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/echarts/pie/model/index.unit.spec.ts
@@ -46,6 +46,7 @@ describe("getPieChartModel", () => {
},
];
+ // Unjustified type cast. FIXME
const settings = {
"pie.metric": "count",
column_settings: {},
@@ -147,6 +148,7 @@ describe("getPieChartModel", () => {
measureText: () => 10,
measureTextHeight: () => 10,
fontFamily: "Arial",
+ // Unjustified type cast. FIXME
theme: {
pie: {
borderColor: "#000000",
diff --git a/frontend/src/metabase/visualizations/echarts/tooltip/index.tsx b/frontend/src/metabase/visualizations/echarts/tooltip/index.tsx
index f704fb0e0e2..d846cc2587c 100644
--- a/frontend/src/metabase/visualizations/echarts/tooltip/index.tsx
+++ b/frontend/src/metabase/visualizations/echarts/tooltip/index.tsx
@@ -78,6 +78,7 @@ export const getTooltipBaseOption = (
? echartsTooltipContainerSelector
: `#${EMBEDDING_SDK_PORTAL_ROOT_ELEMENT_ID} ${echartsTooltipContainerSelector}`;
+ // Unjustified type cast. FIXME
let container = document.querySelector(
containerSelector,
) as HTMLDivElement;
diff --git a/frontend/src/metabase/visualizations/echarts/tooltip/index.unit.spec.ts b/frontend/src/metabase/visualizations/echarts/tooltip/index.unit.spec.ts
index 1ce8847c669..88a6b67fe49 100644
--- a/frontend/src/metabase/visualizations/echarts/tooltip/index.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/echarts/tooltip/index.unit.spec.ts
@@ -13,6 +13,7 @@ describe("useCloseTooltipOnScroll", () => {
beforeEach(() => {
chartRefMock = {
+ // Unjustified type cast. FIXME
current: {
dispatchAction: jest.fn(),
isDisposed: () => false,
diff --git a/frontend/src/metabase/visualizations/lib/exports-branding-utils.unit.spec.ts b/frontend/src/metabase/visualizations/lib/exports-branding-utils.unit.spec.ts
index dd67d13924d..6e84de25646 100644
--- a/frontend/src/metabase/visualizations/lib/exports-branding-utils.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/lib/exports-branding-utils.unit.spec.ts
@@ -71,6 +71,7 @@ describe("createBrandingElement", () => {
// Should only have logo for xs size
expect(element.children.length).toBe(1);
+ // Unjustified type cast. FIXME
const logo = element.children[0] as HTMLImageElement;
expect(logo.tagName).toBe("IMG");
expect(logo.src).toMatch(/^data:image\/svg\+xml;base64,/);
@@ -92,6 +93,7 @@ describe("createBrandingElement", () => {
expect(text.tagName).toBe("SPAN");
expect(text).toHaveTextContent("Made with");
expect(logo.tagName).toBe("IMG");
+ // Unjustified type cast. FIXME
expect((logo as HTMLImageElement).src).toMatch(
/^data:image\/svg\+xml;base64,/,
);
diff --git a/frontend/src/metabase/visualizations/lib/formatting/date.tsx b/frontend/src/metabase/visualizations/lib/formatting/date.tsx
index b4a1427886c..96df779877d 100644
--- a/frontend/src/metabase/visualizations/lib/formatting/date.tsx
+++ b/frontend/src/metabase/visualizations/lib/formatting/date.tsx
@@ -1348,6 +1348,7 @@ export function formatDateTimeWithUnit(
if (!dateFormat) {
dateFormat = getDateFormatFromStyle(
+ // Unjustified type cast. FIXME
options.date_style as string,
unit,
options.date_separator,
@@ -1357,6 +1358,7 @@ export function formatDateTimeWithUnit(
if (!timeFormat) {
timeFormat = getTimeFormatFromStyle(
+ // Unjustified type cast. FIXME
options.time_style as string,
unit,
options.time_enabled,
diff --git a/frontend/src/metabase/visualizations/lib/formatting/email.unit.spec.tsx b/frontend/src/metabase/visualizations/lib/formatting/email.unit.spec.tsx
index 0438e1bc3b6..2cf6a9a7dc4 100644
--- a/frontend/src/metabase/visualizations/lib/formatting/email.unit.spec.tsx
+++ b/frontend/src/metabase/visualizations/lib/formatting/email.unit.spec.tsx
@@ -18,6 +18,7 @@ describe("formatEmail", () => {
jsx: true,
rich: true,
});
+ // Unjustified type cast. FIXME
expect(isElementOfType(result as JSX.Element, ExternalLink)).toBe(true);
render(result);
@@ -36,6 +37,7 @@ describe("formatEmail", () => {
])("should handle complex valid email address: %s", (email) => {
const result = formatEmail(email, { jsx: true, rich: true });
+ // Unjustified type cast. FIXME
expect(isElementOfType(result as JSX.Element, ExternalLink)).toBe(true);
render(result);
@@ -89,6 +91,7 @@ describe("formatEmail", () => {
clicked,
});
+ // Unjustified type cast. FIXME
expect(isElementOfType(result as JSX.Element, ExternalLink)).toBe(true);
render(result);
@@ -110,6 +113,7 @@ describe("formatEmail", () => {
collapseNewlines: true,
});
+ // Unjustified type cast. FIXME
expect(isElementOfType(result as JSX.Element, ExternalLink)).toBe(false);
expect(result).toBe("[email protected] extra text");
});
@@ -130,6 +134,7 @@ describe("formatEmail", () => {
collapseNewlines: true,
});
+ // Unjustified type cast. FIXME
expect(isElementOfType(result as JSX.Element, ExternalLink)).toBe(true);
render(result);
@@ -154,7 +159,9 @@ describe("formatEmail", () => {
});
it("should handle null and undefined by converting to string", () => {
+ // Unjustified type cast. FIXME
expect(formatEmail(null as any)).toBe("null");
+ // Unjustified type cast. FIXME
expect(formatEmail(undefined as any)).toBe("undefined");
});
});
diff --git a/frontend/src/metabase/visualizations/lib/formatting/url.unit.spec.tsx b/frontend/src/metabase/visualizations/lib/formatting/url.unit.spec.tsx
index 2434d1f9f2b..b5ca3f39e94 100644
--- a/frontend/src/metabase/visualizations/lib/formatting/url.unit.spec.tsx
+++ b/frontend/src/metabase/visualizations/lib/formatting/url.unit.spec.tsx
@@ -42,6 +42,7 @@ describe("formatUrl", () => {
pluginsConfig: { handleLink },
});
+ // Unjustified type cast. FIXME
const node = formatUrl(url, {
jsx: true,
rich: true,
@@ -69,6 +70,7 @@ describe("formatUrl", () => {
pluginsConfig: { handleLink },
});
+ // Unjustified type cast. FIXME
const node = formatUrl(url, {
jsx: true,
rich: true,
@@ -93,6 +95,7 @@ describe("formatUrl", () => {
it("should return a component for http:, https:, and mailto: links in jsx mode", () => {
expect(
isElementOfType(
+ // Unjustified type cast. FIXME
formatUrl("http://metabase.com/", {
jsx: true,
rich: true,
@@ -102,6 +105,7 @@ describe("formatUrl", () => {
).toEqual(true);
expect(
isElementOfType(
+ // Unjustified type cast. FIXME
formatUrl("https://metabase.com/", {
jsx: true,
rich: true,
@@ -111,6 +115,7 @@ describe("formatUrl", () => {
).toEqual(true);
expect(
isElementOfType(
+ // Unjustified type cast. FIXME
formatUrl("mailto:[email protected]", {
jsx: true,
rich: true,
@@ -123,6 +128,7 @@ describe("formatUrl", () => {
it("should return a component for custom protocols if the column type is URL", () => {
expect(
isElementOfType(
+ // Unjustified type cast. FIXME
formatUrl("myproto:some-custom-thing", {
jsx: true,
rich: true,
@@ -135,6 +141,7 @@ describe("formatUrl", () => {
it("should not return a component for bad urls if the column type is URL", () => {
expect(
+ // Unjustified type cast. FIXME
formatUrl("invalid-blah-blah-blah", {
jsx: true,
rich: true,
@@ -145,6 +152,7 @@ describe("formatUrl", () => {
it("should not return a component for custom protocols if the column type isn't URL", () => {
expect(
+ // Unjustified type cast. FIXME
formatUrl("myproto:some-custom-thing", {
jsx: true,
rich: true,
@@ -155,6 +163,7 @@ describe("formatUrl", () => {
it("should not return a link component for unrecognized links in jsx mode", () => {
expect(
isElementOfType(
+ // Unjustified type cast. FIXME
formatUrl("metabase.com", { jsx: true, rich: true }) as ReactElement,
ExternalLink,
),
@@ -163,12 +172,14 @@ describe("formatUrl", () => {
it("should return a string for javascript:, data:, and other links in jsx mode", () => {
expect(
+ // Unjustified type cast. FIXME
formatUrl("javascript:alert('pwnd')", {
jsx: true,
rich: true,
}) as ReactElement,
).toEqual("javascript:alert('pwnd')");
expect(
+ // Unjustified type cast. FIXME
formatUrl("data:text/plain;charset=utf-8,hello%20world", {
jsx: true,
rich: true,
@@ -178,6 +189,7 @@ describe("formatUrl", () => {
describe("when view_as = link", () => {
it("should return link component for type/URL and view_as = link", () => {
+ // Unjustified type cast. FIXME
const formatted = formatUrl("http://whatever", {
jsx: true,
rich: true,
@@ -188,6 +200,7 @@ describe("formatUrl", () => {
});
it("should return link component using link_url and link_text when specified", () => {
+ // Unjustified type cast. FIXME
const formatted = formatUrl("http://not.metabase.com", {
jsx: true,
rich: true,
@@ -203,6 +216,7 @@ describe("formatUrl", () => {
});
it("should return link component using link_text and the value as url when link_url is empty", () => {
+ // Unjustified type cast. FIXME
const formatted = formatUrl("http://metabase.com", {
jsx: true,
rich: true,
@@ -218,6 +232,7 @@ describe("formatUrl", () => {
});
it("should return link component using link_url and the value as text when link_text is empty", () => {
+ // Unjustified type cast. FIXME
const formatted = formatUrl("metabase link", {
jsx: true,
rich: true,
@@ -238,6 +253,7 @@ describe("formatUrl", () => {
base_type: TYPE.Integer,
});
const value = 35660212261;
+ // Unjustified type cast. FIXME
const formatted = formatValue(value, {
jsx: true,
rich: true,
@@ -274,6 +290,7 @@ describe("formatUrl", () => {
base_type: TYPE.Float,
});
const value = 1234567.89;
+ // Unjustified type cast. FIXME
const formatted = formatValue(value, {
jsx: true,
rich: true,
@@ -314,6 +331,7 @@ describe("formatUrl", () => {
});
const linkValue = "Widget";
const amountValue = 1234567.89;
+ // Unjustified type cast. FIXME
const formatted = formatValue(linkValue, {
jsx: true,
rich: true,
@@ -345,6 +363,7 @@ describe("formatUrl", () => {
});
it("should not return an ExternalLink in jsx + rich mode if there's click behavior", () => {
+ // Unjustified type cast. FIXME
const formatted = formatValue("http://metabase.com/", {
jsx: true,
rich: true,
diff --git a/frontend/src/metabase/visualizations/lib/formatting/value.tsx b/frontend/src/metabase/visualizations/lib/formatting/value.tsx
index cc367cd88fd..6c4411605a5 100644
--- a/frontend/src/metabase/visualizations/lib/formatting/value.tsx
+++ b/frontend/src/metabase/visualizations/lib/formatting/value.tsx
@@ -54,6 +54,7 @@ export function formatValue(value: unknown, _options: ColumnSettings = {}) {
const formatted = formatValueRaw(value, options);
let maybeJson = {};
try {
+ // Unjustified type cast. FIXME
maybeJson = JSON.parse(value as string);
} catch {
// do nothing
@@ -141,6 +142,7 @@ export function formatValueRaw(
const { column } = options;
+ // Unjustified type cast. FIXME
const remapped = getRemappedValue(value as string | number, options);
if (remapped !== undefined && options.view_as !== "link") {
value = remapped;
@@ -177,13 +179,17 @@ export function formatValueRaw(
(isURL(column) && options.view_as == null) ||
options.view_as === "link"
) {
+ // Unjustified type cast. FIXME
return formatUrl(value as string, options);
} else if (isEmail(column)) {
+ // Unjustified type cast. FIXME
return formatEmail(value as string, options);
} else if (isTime(column)) {
+ // Unjustified type cast. FIXME
return formatTime(value as Dayjs, column.unit, options);
} else if (column && column.unit != null) {
return formatDateTimeWithUnit(
+ // Unjustified type cast. FIXME
value as string | number,
column.unit,
options,
@@ -192,8 +198,10 @@ export function formatValueRaw(
isDate(column) ||
isDateValue(value) ||
dayjs.isDayjs(value) ||
+ // Unjustified type cast. FIXME
dayjs(value as string, ["YYYY-MM-DD'T'HH:mm:ss.SSSZ"], true).isValid()
) {
+ // Unjustified type cast. FIXME
return formatDateTimeWithUnit(value as string | number, "minute", options);
} else if (typeof value === "string") {
// Check if we're looking for a number isNumber(column) and
diff --git a/frontend/src/metabase/visualizations/lib/formatting/value.unit.spec.tsx b/frontend/src/metabase/visualizations/lib/formatting/value.unit.spec.tsx
index 2d1f0ed99fa..88e7361624f 100644
--- a/frontend/src/metabase/visualizations/lib/formatting/value.unit.spec.tsx
+++ b/frontend/src/metabase/visualizations/lib/formatting/value.unit.spec.tsx
@@ -376,6 +376,7 @@ describe("formatValue", () => {
it("should return the component for external links in jsx + rich mode", () => {
expect(
isElementOfType(
+ // Unjustified type cast. FIXME
formatValue("http://metabase.com/", {
jsx: true,
rich: true,
@@ -388,6 +389,7 @@ describe("formatValue", () => {
it("should return a component for internal links in jsx + rich mode", () => {
expect(
isElementOfType(
+ // Unjustified type cast. FIXME
formatValue(SITE_URL, { jsx: true, rich: true }) as ReactElement,
Link,
),
@@ -403,6 +405,7 @@ describe("formatValue", () => {
});
expect(
isElementOfType(
+ // Unjustified type cast. FIXME
formatValue("/question/12", {
jsx: true,
rich: true,
@@ -420,6 +423,7 @@ describe("formatValue", () => {
});
it("should not return an ExternalLink for links in jsx + rich mode if there's click behavior", () => {
+ // Unjustified type cast. FIXME
const formatted = formatValue("http://metabase.com/", {
jsx: true,
rich: true,
@@ -438,6 +442,7 @@ describe("formatValue", () => {
});
it("should render image", () => {
+ // Unjustified type cast. FIXME
const formatted = formatValue("http://metabase.com/logo.png", {
jsx: true,
rich: true,
@@ -449,6 +454,7 @@ describe("formatValue", () => {
});
it("should render image with a click behavior in jsx + rich mode (metabase#17161)", () => {
+ // Unjustified type cast. FIXME
const formatted = formatValue("http://metabase.com/logo.png", {
jsx: true,
rich: true,
@@ -467,6 +473,7 @@ describe("formatValue", () => {
it("should return a component for email addresses in jsx + rich mode", () => {
expect(
isElementOfType(
+ // Unjustified type cast. FIXME
formatValue("[email protected]", {
jsx: true,
rich: true,
diff --git a/frontend/src/metabase/visualizations/lib/open-url.ts b/frontend/src/metabase/visualizations/lib/open-url.ts
index 6a0729dc62a..555c29a4fa2 100644
--- a/frontend/src/metabase/visualizations/lib/open-url.ts
+++ b/frontend/src/metabase/visualizations/lib/open-url.ts
@@ -37,6 +37,7 @@ type ShouldOpenInBlankWindowOptions = {
export function shouldOpenInBlankWindow(
url: string,
{
+ // Unjustified type cast. FIXME
event = (typeof window !== "undefined" ? window.event : undefined) as
| MouseEvent
| undefined,
diff --git a/frontend/src/metabase/visualizations/lib/region-codes.ts b/frontend/src/metabase/visualizations/lib/region-codes.ts
index 9b256c5903d..b97999583b2 100644
--- a/frontend/src/metabase/visualizations/lib/region-codes.ts
+++ b/frontend/src/metabase/visualizations/lib/region-codes.ts
@@ -18,6 +18,7 @@ export function getCanonicalRowKey(key: RowValue, region?: string): string {
const normalizedKey = String(key).toLowerCase();
// State names and codes don't overlap, so for us_states (which expects codes) we map any name to its code.
if (region === "us_states" && stateNamesMap.has(normalizedKey)) {
+ // Unjustified type cast. FIXME
return stateNamesMap.get(normalizedKey) as string;
} else if (
region === "world_countries" &&
diff --git a/frontend/src/metabase/visualizations/lib/scalar_utils.unit.spec.ts b/frontend/src/metabase/visualizations/lib/scalar_utils.unit.spec.ts
index 6fdd951efd0..b6912bf4d59 100644
--- a/frontend/src/metabase/visualizations/lib/scalar_utils.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/lib/scalar_utils.unit.spec.ts
@@ -20,6 +20,7 @@ describe("scalar utils", () => {
const value = 45000;
const width = 200;
+ // Unjustified type cast. FIXME
const { displayValue, fullScalarValue } = compactifyValue(
value,
width,
@@ -36,6 +37,7 @@ describe("scalar utils", () => {
const value = 45000.1343;
const width = 200;
+ // Unjustified type cast. FIXME
const { displayValue, fullScalarValue } = compactifyValue(
value,
width,
@@ -53,6 +55,7 @@ describe("scalar utils", () => {
const value = 100100100100;
const width = 350;
+ // Unjustified type cast. FIXME
const { displayValue, fullScalarValue } = compactifyValue(
value,
width,
@@ -73,6 +76,7 @@ describe("scalar utils", () => {
const value = 10010010010;
const width = 350;
+ // Unjustified type cast. FIXME
const { displayValue, fullScalarValue } = compactifyValue(
value,
width,
@@ -93,6 +97,7 @@ describe("scalar utils", () => {
const value = 10010010010;
const width = 350;
+ // Unjustified type cast. FIXME
const { displayValue, fullScalarValue } = compactifyValue(value, width, {
...formatOptions,
compact: true,
diff --git a/frontend/src/metabase/visualizations/lib/settings/column.unit.spec.ts b/frontend/src/metabase/visualizations/lib/settings/column.unit.spec.ts
index 7d9db62169a..2f9e1a2275d 100644
--- a/frontend/src/metabase/visualizations/lib/settings/column.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/lib/settings/column.unit.spec.ts
@@ -134,6 +134,7 @@ describe("column settings", () => {
NUMBER_COLUMN_SETTINGS.currency_in_header?.getProps,
);
+ // Unjustified type cast. FIXME
const { options, onChange } = getProps(
createMockColumn(),
{},
diff --git a/frontend/src/metabase/visualizations/lib/settings/nested.ts b/frontend/src/metabase/visualizations/lib/settings/nested.ts
index dc9d05a219d..d78574e5ddc 100644
--- a/frontend/src/metabase/visualizations/lib/settings/nested.ts
+++ b/frontend/src/metabase/visualizations/lib/settings/nested.ts
@@ -159,6 +159,7 @@ export function nestedSettings<
type Value = VisualizationSettingsDefinitions[Key];
+ // Unjustified type cast. FIXME
const idDef: SeriesSettingDefinition<Value, TProps & { id: string }> = {
getSection: () => t`Display`,
getDefault: () => ({}),
diff --git a/frontend/src/metabase/visualizations/lib/settings/typed-utils.unit.spec.ts b/frontend/src/metabase/visualizations/lib/settings/typed-utils.unit.spec.ts
index e8fde883f34..272ce1b3059 100644
--- a/frontend/src/metabase/visualizations/lib/settings/typed-utils.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/lib/settings/typed-utils.unit.spec.ts
@@ -232,6 +232,7 @@ describe("sanitizeDashcardSettings", () => {
"card.title": "Custom Title",
};
+ // Unjustified type cast. FIXME
const vizSettingsDefs = {
"graph.dimensions": { dashboard: false },
"graph.metrics": { dashboard: false },
@@ -253,6 +254,7 @@ describe("sanitizeDashcardSettings", () => {
unknownSetting: "value",
};
+ // Unjustified type cast. FIXME
const vizSettingsDefs = {
"graph.dimensions": { dashboard: false },
} as any;
@@ -271,6 +273,7 @@ describe("sanitizeDashcardSettings", () => {
"card.description": "Description",
};
+ // Unjustified type cast. FIXME
const vizSettingsDefs = {
"graph.dimensions": { dashboard: false },
"graph.goal_value": {}, // no dashboard property
@@ -291,6 +294,7 @@ describe("sanitizeDashcardSettings", () => {
"graph.metrics": ["count"],
};
+ // Unjustified type cast. FIXME
const vizSettingsDefs = {
"graph.dimensions": { dashboard: false },
"graph.metrics": { dashboard: false },
@@ -303,6 +307,7 @@ describe("sanitizeDashcardSettings", () => {
it("should handle empty settings", () => {
const settings = {};
+ // Unjustified type cast. FIXME
const vizSettingsDefs = {
"graph.dimensions": { dashboard: false },
} as any;
diff --git a/frontend/src/metabase/visualizations/lib/table_format.unit.spec.ts b/frontend/src/metabase/visualizations/lib/table_format.unit.spec.ts
index 8c82c3cc5d8..30de0e7b903 100644
--- a/frontend/src/metabase/visualizations/lib/table_format.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/lib/table_format.unit.spec.ts
@@ -18,6 +18,7 @@ describe("compileFormatter", () => {
it("should return a function, even for unsupported operators", () => {
const formatter = compileFormatter({
type: "single",
+ // Unjustified type cast. FIXME
operator: "this-non-existant-operator-is-used-for-testing" as never,
value: null,
color: "#ffffff",
diff --git a/frontend/src/metabase/visualizations/lib/utils.unit.spec.ts b/frontend/src/metabase/visualizations/lib/utils.unit.spec.ts
index 7a153161e5b..60bb39d497c 100644
--- a/frontend/src/metabase/visualizations/lib/utils.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/lib/utils.unit.spec.ts
@@ -95,16 +95,19 @@ const savedMultiseriesCard: Card = {
dataset_query: breakoutMultiseriesQuery,
};
const derivedMultiseriesCard = createMockCard({
+ // Unjustified type cast. FIXME
id: null as unknown as CardId, // id is not present when drilling through series / multiseries
dataset_query: derivedBreakoutMultiseriesQuery,
display: savedCard.display,
});
const newCard = createMockCard({
+ // Unjustified type cast. FIXME
id: null as unknown as CardId, // id is not present when drilling through series / multiseries
dataset_query: baseQuery,
display: "line",
});
const modifiedNewCard = createMockCard({
+ // Unjustified type cast. FIXME
id: null as unknown as CardId, // id is not present when drilling through series / multiseries
dataset_query: derivedQuery,
display: "line",
diff --git a/frontend/src/metabase/visualizations/shared/components/RowChartView/RowChartView.tsx b/frontend/src/metabase/visualizations/shared/components/RowChartView/RowChartView.tsx
index a7aa57cff5a..641fc160eaf 100644
--- a/frontend/src/metabase/visualizations/shared/components/RowChartView/RowChartView.tsx
+++ b/frontend/src/metabase/visualizations/shared/components/RowChartView/RowChartView.tsx
@@ -129,6 +129,7 @@ const RowChartView = <TDatum,>({
<svg width={width ?? undefined} height={height ?? undefined} style={style}>
<Group top={margin.top} left={margin.left}>
<GridColumns
+ // Unjustified type cast. FIXME
scale={xScale as AxisScale<number>}
height={innerHeight}
stroke={theme.grid.color}
@@ -270,6 +271,7 @@ const RowChartView = <TDatum,>({
tickValues={hasXAxis ? xTicks : []}
tickFormat={xTickFormatter}
top={innerHeight}
+ // Unjustified type cast. FIXME
scale={xScale as AxisScale<number>}
stroke={theme.axis.color}
tickStroke={theme.axis.color}
diff --git a/frontend/src/metabase/visualizations/shared/components/RowChartView/utils/data-labels.unit.spec.ts b/frontend/src/metabase/visualizations/shared/components/RowChartView/utils/data-labels.unit.spec.ts
index df5253b9227..4ef9c5719a6 100644
--- a/frontend/src/metabase/visualizations/shared/components/RowChartView/utils/data-labels.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/shared/components/RowChartView/utils/data-labels.unit.spec.ts
@@ -9,6 +9,7 @@ describe("getDataLabel", () => {
const seriesKey = "test-series";
const createBarData = <T>(overrides: Partial<BarData<T>> = {}): BarData<T> =>
+ // Unjustified type cast. FIXME
({
xStartValue: 10,
xEndValue: 50,
diff --git a/frontend/src/metabase/visualizations/shared/settings/pie.unit.spec.ts b/frontend/src/metabase/visualizations/shared/settings/pie.unit.spec.ts
index 5b09cbcb267..68b7d4ecdae 100644
--- a/frontend/src/metabase/visualizations/shared/settings/pie.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/shared/settings/pie.unit.spec.ts
@@ -95,6 +95,7 @@ describe("getColors", () => {
createMockColumn({ name: "Category" }),
createMockColumn({ name: "Count" }),
];
+ // Unjustified type cast. FIXME
const rawSeries = [
{
data: createMockDatasetData({
@@ -116,6 +117,7 @@ describe("getColors", () => {
Gadget: "#00FF00",
Gizmo: "#FFFFFF",
},
+ // Unjustified type cast. FIXME
"pie.rows": [
{
key: "Gadget",
@@ -150,6 +152,7 @@ describe("getColors", () => {
createMockColumn({ name: "Category" }),
createMockColumn({ name: "Count" }),
];
+ // Unjustified type cast. FIXME
const rawSeries = [
{
data: createMockDatasetData({
diff --git a/frontend/src/metabase/visualizations/shared/settings/series.ts b/frontend/src/metabase/visualizations/shared/settings/series.ts
index 1d062f5bc8b..21e2b9f80ba 100644
--- a/frontend/src/metabase/visualizations/shared/settings/series.ts
+++ b/frontend/src/metabase/visualizations/shared/settings/series.ts
@@ -14,6 +14,7 @@ export const getSeriesColors = (
) => {
const assignments: Record<string, string> = {};
+ // Unjustified type cast. FIXME
const seriesSettings = getIn(settings, [SERIES_SETTING_KEY]) as
| Record<string, { color?: string; title?: string }>
| undefined;
diff --git a/frontend/src/metabase/visualizations/shared/utils/colors.ts b/frontend/src/metabase/visualizations/shared/utils/colors.ts
index 78202bb4f0f..43e7e424a82 100644
--- a/frontend/src/metabase/visualizations/shared/utils/colors.ts
+++ b/frontend/src/metabase/visualizations/shared/utils/colors.ts
@@ -17,6 +17,7 @@ export const getSeriesColors = <TDatum, TSeriesInfo>(
return mapping;
},
+ // Unjustified type cast. FIXME
{} as Record<string, string>,
);
diff --git a/frontend/src/metabase/visualizations/shared/utils/colors.unit.spec.ts b/frontend/src/metabase/visualizations/shared/utils/colors.unit.spec.ts
index 85b9854e30a..5d6cd1e4545 100644
--- a/frontend/src/metabase/visualizations/shared/utils/colors.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/shared/utils/colors.unit.spec.ts
@@ -5,6 +5,7 @@ import { getSeriesColors } from "./colors";
jest.mock("metabase/ui/colors/charts");
+// Unjustified type cast. FIXME
const mockGetColorsForValues = getColorsForValues as jest.MockedFunction<
typeof getColorsForValues
>;
diff --git a/frontend/src/metabase/visualizations/shared/utils/parameter-substitution.ts b/frontend/src/metabase/visualizations/shared/utils/parameter-substitution.ts
index 3d2f5e48140..58a6fb2c090 100644
--- a/frontend/src/metabase/visualizations/shared/utils/parameter-substitution.ts
+++ b/frontend/src/metabase/visualizations/shared/utils/parameter-substitution.ts
@@ -40,6 +40,7 @@ export function fillParametersInText({
);
if (parameter) {
+ // Unjustified type cast. FIXME
const rawParameterValue = parameterValues[parameter.id] as string;
const parameterValue = urlEncode
? encodeURIComponent(rawParameterValue)
diff --git a/frontend/src/metabase/visualizations/shared/utils/sizes.ts b/frontend/src/metabase/visualizations/shared/utils/sizes.ts
index 4d2ffa81dbf..4ad02d19a63 100644
--- a/frontend/src/metabase/visualizations/shared/utils/sizes.ts
+++ b/frontend/src/metabase/visualizations/shared/utils/sizes.ts
@@ -17,6 +17,7 @@ const getSize = (
visualizationType: VisualizationDisplay,
sizeKey: "min" | "default",
): VisualizationSize =>
+ // Unjustified type cast. FIXME
_.get(
VISUALIZATION_SIZES,
[visualizationType, sizeKey],
diff --git a/frontend/src/metabase/visualizations/types/click-actions.ts b/frontend/src/metabase/visualizations/types/click-actions.ts
index b399db3606b..206b5dd23ca 100644
--- a/frontend/src/metabase/visualizations/types/click-actions.ts
+++ b/frontend/src/metabase/visualizations/types/click-actions.ts
@@ -219,6 +219,7 @@ export function isClickActionsMode(value: unknown): value is ClickActionsMode {
value != null &&
typeof value === "object" &&
"actionsForClick" in value &&
+ // Unjustified type cast. FIXME
typeof (value as any).actionsForClick === "function"
);
}
@@ -240,11 +241,13 @@ export type QueryClickActionsMode = {
export const isCustomClickAction = (
clickAction: ClickAction,
): clickAction is CustomClickAction =>
+ // Unjustified type cast. FIXME
(clickAction as CustomClickAction).type === "custom" &&
!("view" in clickAction);
export const isCustomClickActionWithView = (
action: ClickAction,
): action is CustomClickActionWithCustomView =>
+ // Unjustified type cast. FIXME
(action as CustomClickActionWithCustomView).type === "custom" &&
"view" in action;
diff --git a/frontend/src/metabase/visualizations/visualizations/BarChart/BarChart.stories.tsx b/frontend/src/metabase/visualizations/visualizations/BarChart/BarChart.stories.tsx
index c935d797105..31ca14ae5e1 100644
--- a/frontend/src/metabase/visualizations/visualizations/BarChart/BarChart.stories.tsx
+++ b/frontend/src/metabase/visualizations/visualizations/BarChart/BarChart.stories.tsx
@@ -25,6 +25,7 @@ export default {
// @ts-expect-error: incompatible prop types with registerVisualization
registerVisualization(BarChart);
+// Unjustified type cast. FIXME
const MOCK_SERIES = [
{
card: createMockCard({ name: "Card", display: "bar" }),
diff --git a/frontend/src/metabase/visualizations/visualizations/CartesianChart/TimelineEventsBand/TimelineEventsBand.unit.spec.tsx b/frontend/src/metabase/visualizations/visualizations/CartesianChart/TimelineEventsBand/TimelineEventsBand.unit.spec.tsx
index feeb0f7a558..fed80129b41 100644
--- a/frontend/src/metabase/visualizations/visualizations/CartesianChart/TimelineEventsBand/TimelineEventsBand.unit.spec.tsx
+++ b/frontend/src/metabase/visualizations/visualizations/CartesianChart/TimelineEventsBand/TimelineEventsBand.unit.spec.tsx
@@ -28,6 +28,7 @@ const createChartLayout = (): ChartLayout => ({
const createChartInstance = (
pixelByDate: Record<string, number>,
): EChartsType =>
+ // Unjustified type cast. FIXME
({
convertToPixel: (_finder: unknown, value: string) =>
pixelByDate[value] ?? NaN,
diff --git a/frontend/src/metabase/visualizations/visualizations/CartesianChart/TimelineEventsBand/utils.unit.spec.ts b/frontend/src/metabase/visualizations/visualizations/CartesianChart/TimelineEventsBand/utils.unit.spec.ts
index 3e0977aa584..bc24fa063a4 100644
--- a/frontend/src/metabase/visualizations/visualizations/CartesianChart/TimelineEventsBand/utils.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/visualizations/CartesianChart/TimelineEventsBand/utils.unit.spec.ts
@@ -15,6 +15,7 @@ const BOUNDS: ChartBoundsCoords = { top: 0, bottom: 100, left: 50, right: 450 };
const createChartInstance = (
pixelByDate: Record<string, number | number[]>,
): EChartsType =>
+ // Unjustified type cast. FIXME
({
convertToPixel: (_finder: unknown, value: string) =>
pixelByDate[value] ?? NaN,
diff --git a/frontend/src/metabase/visualizations/visualizations/CartesianChart/events.ts b/frontend/src/metabase/visualizations/visualizations/CartesianChart/events.ts
index 6977f336ff6..cf619c9f120 100644
--- a/frontend/src/metabase/visualizations/visualizations/CartesianChart/events.ts
+++ b/frontend/src/metabase/visualizations/visualizations/CartesianChart/events.ts
@@ -870,6 +870,7 @@ export const getGoalLineHoverData = (
event: EChartsSeriesMouseEvent,
formatGoal?: AxisFormatter,
) => {
+ // Unjustified type cast. FIXME
const element = event.event.event.target as Element;
if (element?.nodeName !== "text") {
diff --git a/frontend/src/metabase/visualizations/visualizations/CartesianChart/use-brush.ts b/frontend/src/metabase/visualizations/visualizations/CartesianChart/use-brush.ts
index f3adede32a4..2a86633c0d5 100644
--- a/frontend/src/metabase/visualizations/visualizations/CartesianChart/use-brush.ts
+++ b/frontend/src/metabase/visualizations/visualizations/CartesianChart/use-brush.ts
@@ -43,11 +43,13 @@ const addPointerListeners = (
listeners: Record<string, (e: PointerEvent) => void>,
) => {
for (const [event, handler] of Object.entries(listeners)) {
+ // Unjustified type cast. FIXME
el.addEventListener(event, handler as EventListener);
}
return () => {
for (const [event, handler] of Object.entries(listeners)) {
+ // Unjustified type cast. FIXME
el.removeEventListener(event, handler as EventListener);
}
};
diff --git a/frontend/src/metabase/visualizations/visualizations/CartesianChart/use-brush.unit.spec.ts b/frontend/src/metabase/visualizations/visualizations/CartesianChart/use-brush.unit.spec.ts
index b983922ddbe..add6ad43150 100644
--- a/frontend/src/metabase/visualizations/visualizations/CartesianChart/use-brush.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/visualizations/CartesianChart/use-brush.unit.spec.ts
@@ -25,6 +25,7 @@ class PointerEventPolyfill extends MouseEvent {
}
if (typeof globalThis.PointerEvent === "undefined") {
+ // Unjustified type cast. FIXME
(globalThis as any).PointerEvent = PointerEventPolyfill;
}
@@ -32,7 +33,9 @@ const createMockChartRef = () => {
const dispatchAction = jest.fn();
const trigger = jest.fn();
const getZrender = jest.fn(() => ({ trigger }));
+ // Unjustified type cast. FIXME
const chartRef = {
+ // Unjustified type cast. FIXME
current: { dispatchAction, getZr: getZrender } as unknown as EChartsType,
} as MutableRefObject<EChartsType | undefined>;
@@ -43,9 +46,11 @@ const createMockContainerRef = () => {
const element = document.createElement("div");
element.getBoundingClientRect = jest.fn(
+ // Unjustified type cast. FIXME
() => ({ left: 10, top: 20, width: 400, height: 300 }) as DOMRect,
);
+ // Unjustified type cast. FIXME
const containerRef = { current: element } as RefObject<HTMLDivElement>;
return { containerRef, el: element };
@@ -180,6 +185,7 @@ describe("use-brush", () => {
describe("createZrenderMousedownEvent", () => {
it("calculates correct offsets from client coords and rect", () => {
+ // Unjustified type cast. FIXME
const rect = { left: 50, top: 100 } as DOMRect;
const { offsetX, offsetY, target, event } = createZrenderMousedownEvent(
{ x: 150, y: 250 },
@@ -231,6 +237,7 @@ describe("use-brush", () => {
// the first attempt to enable the brush is a no-op. Surfacing the chart
// instance as a signal must re-run the effect and enable the brush.
const dispatchAction = jest.fn();
+ // Unjustified type cast. FIXME
const chartRef = {
current: undefined,
} as MutableRefObject<EChartsType | undefined>;
@@ -248,6 +255,7 @@ describe("use-brush", () => {
),
{
initialProps: {
+ // Unjustified type cast. FIXME
chartInstance: undefined as EChartsType | undefined,
},
},
diff --git a/frontend/src/metabase/visualizations/visualizations/CartesianChart/use-data-points-visible.ts b/frontend/src/metabase/visualizations/visualizations/CartesianChart/use-data-points-visible.ts
index 4f67ec61016..88a3d0f2fce 100644
--- a/frontend/src/metabase/visualizations/visualizations/CartesianChart/use-data-points-visible.ts
+++ b/frontend/src/metabase/visualizations/visualizations/CartesianChart/use-data-points-visible.ts
@@ -21,6 +21,7 @@ export const useAreAllDataPointsOutOfRange = (
return chartModel.dataset.every((data) =>
dataKeys.every((key) => {
+ // Unjustified type cast. FIXME
const value = data[key] as number;
return value === null || value < yMin || yMax < value;
}),
diff --git a/frontend/src/metabase/visualizations/visualizations/CartesianChart/use-models-and-option.ts b/frontend/src/metabase/visualizations/visualizations/CartesianChart/use-models-and-option.ts
index bca5579c420..eab173255ab 100644
--- a/frontend/src/metabase/visualizations/visualizations/CartesianChart/use-models-and-option.ts
+++ b/frontend/src/metabase/visualizations/visualizations/CartesianChart/use-models-and-option.ts
@@ -126,6 +126,7 @@ export function useModelsAndOption(
return getTooltipOption(
chartModel,
settings,
+ // Unjustified type cast. FIXME
card.display as CardDisplayType,
containerRef,
);
@@ -143,6 +144,7 @@ export function useModelsAndOption(
switch (card.display) {
case "waterfall":
baseOption = getWaterfallChartOption(
+ // Unjustified type cast. FIXME
chartModel as WaterfallChartModel,
width,
chartLayout,
@@ -156,6 +158,7 @@ export function useModelsAndOption(
break;
case "scatter":
baseOption = getScatterPlotOption(
+ // Unjustified type cast. FIXME
chartModel as ScatterPlotModel,
chartLayout,
hasTimelineEvents,
@@ -169,6 +172,7 @@ export function useModelsAndOption(
break;
default:
baseOption = getCartesianChartOption(
+ // Unjustified type cast. FIXME
chartModel as CartesianChartModel,
chartLayout,
hasTimelineEvents,
diff --git a/frontend/src/metabase/visualizations/visualizations/CartesianChart/use-tooltip-mouse-leave.ts b/frontend/src/metabase/visualizations/visualizations/CartesianChart/use-tooltip-mouse-leave.ts
index eae74ca1c13..c68c2f2e809 100644
--- a/frontend/src/metabase/visualizations/visualizations/CartesianChart/use-tooltip-mouse-leave.ts
+++ b/frontend/src/metabase/visualizations/visualizations/CartesianChart/use-tooltip-mouse-leave.ts
@@ -22,7 +22,9 @@ export const useTooltipMouseLeave = (
const handleGlobalMouseMove = _.throttle((e: MouseEvent) => {
try {
+ // Unjustified type cast. FIXME
const target = e.target as HTMLElement;
+ // Unjustified type cast. FIXME
const tooltipElement = target.closest(
ECHARTS_TOOLTIP_SELECTOR,
) as HTMLElement;
diff --git a/frontend/src/metabase/visualizations/visualizations/Funnel/Funnel.stories.tsx b/frontend/src/metabase/visualizations/visualizations/Funnel/Funnel.stories.tsx
index 303b83b51ab..724659e7d9d 100644
--- a/frontend/src/metabase/visualizations/visualizations/Funnel/Funnel.stories.tsx
+++ b/frontend/src/metabase/visualizations/visualizations/Funnel/Funnel.stories.tsx
@@ -30,6 +30,7 @@ const dataset_query = createMockStructuredDatasetQuery({
query: { "source-table": 1 },
});
+// Unjustified type cast. FIXME
const MOCK_SERIES = [
{
card: createMockCard({ id: 1, display: "funnel", dataset_query }),
diff --git a/frontend/src/metabase/visualizations/visualizations/Gauge/utils.unit.spec.ts b/frontend/src/metabase/visualizations/visualizations/Gauge/utils.unit.spec.ts
index d5b653ad0fe..f15365b4ee3 100644
--- a/frontend/src/metabase/visualizations/visualizations/Gauge/utils.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/visualizations/Gauge/utils.unit.spec.ts
@@ -21,6 +21,7 @@ describe("Visualizations > Gauge > utils", () => {
valueTestCases.forEach(([input, output]) => {
it(`should return ${output} for ${JSON.stringify(input)}`, () => {
+ // Unjustified type cast. FIXME
expect(getValue(input as unknown[][])).toEqual(output);
});
});
diff --git a/frontend/src/metabase/visualizations/visualizations/LineChart/LineChart.stories.tsx b/frontend/src/metabase/visualizations/visualizations/LineChart/LineChart.stories.tsx
index 13b1e3c99ef..fc7d90e3585 100644
--- a/frontend/src/metabase/visualizations/visualizations/LineChart/LineChart.stories.tsx
+++ b/frontend/src/metabase/visualizations/visualizations/LineChart/LineChart.stories.tsx
@@ -29,6 +29,7 @@ const dataset_query = createMockStructuredDatasetQuery({
query: { "source-table": 1 },
});
+// Unjustified type cast. FIXME
const MOCK_SERIES = [
{
card: createMockCard({ id: 1, display: "line", dataset_query }),
diff --git a/frontend/src/metabase/visualizations/visualizations/List/components/ListView/ListView.tsx b/frontend/src/metabase/visualizations/visualizations/List/components/ListView/ListView.tsx
index a1812046b52..55a0c11b949 100644
--- a/frontend/src/metabase/visualizations/visualizations/List/components/ListView/ListView.tsx
+++ b/frontend/src/metabase/visualizations/visualizations/List/components/ListView/ListView.tsx
@@ -218,7 +218,8 @@ export function useListColumns(
const rightColumns = useMemo(() => {
return !listSettings
? []
- : (listSettings.right
+ : // Unjustified type cast. FIXME
+ (listSettings.right
.map((colName) => cols.find((col) => col.name === colName))
.filter(Boolean) as DatasetColumn[]);
}, [cols, listSettings]);
diff --git a/frontend/src/metabase/visualizations/visualizations/List/components/ListView/ListViewConfiguration.tsx b/frontend/src/metabase/visualizations/visualizations/List/components/ListView/ListViewConfiguration.tsx
index 3fca3541ba1..7e7cc87e6f0 100644
--- a/frontend/src/metabase/visualizations/visualizations/List/components/ListView/ListViewConfiguration.tsx
+++ b/frontend/src/metabase/visualizations/visualizations/List/components/ListView/ListViewConfiguration.tsx
@@ -273,7 +273,8 @@ export const ListViewConfiguration = ({
className={S.listEntityIcon}
c={
iconConfig.entityIconEnabled
- ? (iconConfig.selectedIconColor as ColorName)
+ ? // Unjustified type cast. FIXME
+ (iconConfig.selectedIconColor as ColorName)
: "text-disabled"
}
/>
@@ -452,6 +453,7 @@ export const ListViewConfiguration = ({
cols={cols}
rows={rows}
row={previewSample}
+ // Unjustified type cast. FIXME
settings={settings as ComputedVisualizationSettings}
entityIcon={
iconConfig.entityIconEnabled && iconConfig.selectedEntityIcon
diff --git a/frontend/src/metabase/visualizations/visualizations/List/components/ListView/ListViewItem.tsx b/frontend/src/metabase/visualizations/visualizations/List/components/ListView/ListViewItem.tsx
index 62b4587cecc..de2856872a6 100644
--- a/frontend/src/metabase/visualizations/visualizations/List/components/ListView/ListViewItem.tsx
+++ b/frontend/src/metabase/visualizations/visualizations/List/components/ListView/ListViewItem.tsx
@@ -59,6 +59,7 @@ export function ListViewItem({
flexShrink: 0,
backgroundColor: getIconBackground(entityIconColor),
}}
+ // Unjustified type cast. FIXME
>
{/* @ts-expect-error viz components may be passed arbitrary color values */}
<Icon name={entityIcon as IconName} c={entityIconColor} />
diff --git a/frontend/src/metabase/visualizations/visualizations/List/components/ListView/ListViewItem.unit.spec.tsx b/frontend/src/metabase/visualizations/visualizations/List/components/ListView/ListViewItem.unit.spec.tsx
index 99458f6d5d8..0db44fcc0a6 100644
--- a/frontend/src/metabase/visualizations/visualizations/List/components/ListView/ListViewItem.unit.spec.tsx
+++ b/frontend/src/metabase/visualizations/visualizations/List/components/ListView/ListViewItem.unit.spec.tsx
@@ -9,6 +9,7 @@ function makeSettings(overrides: Partial<ComputedVisualizationSettings> = {}) {
const base: ComputedVisualizationSettings = {
column: () => ({}),
};
+ // Unjustified type cast. FIXME
return { ...base, ...overrides } as ComputedVisualizationSettings;
}
diff --git a/frontend/src/metabase/visualizations/visualizations/List/components/ListView/styling.ts b/frontend/src/metabase/visualizations/visualizations/List/components/ListView/styling.ts
index 8bb4e78548c..592208eb34a 100644
--- a/frontend/src/metabase/visualizations/visualizations/List/components/ListView/styling.ts
+++ b/frontend/src/metabase/visualizations/visualizations/List/components/ListView/styling.ts
@@ -21,9 +21,11 @@ export const ENTITY_ICONS = {
} satisfies Record<string, IconName>;
export const getEntityIcon = (entityType?: string) => {
+ // Unjustified type cast. FIXME
return (
entityType
- ? ENTITY_ICONS[entityType as keyof typeof ENTITY_ICONS] || "document"
+ ? // Unjustified type cast. FIXME
+ ENTITY_ICONS[entityType as keyof typeof ENTITY_ICONS] || "document"
: "document"
) as IconName;
};
diff --git a/frontend/src/metabase/visualizations/visualizations/List/components/ListView/use-external-drag-overlay.ts b/frontend/src/metabase/visualizations/visualizations/List/components/ListView/use-external-drag-overlay.ts
index efec936ecd8..06094ad5b8c 100644
--- a/frontend/src/metabase/visualizations/visualizations/List/components/ListView/use-external-drag-overlay.ts
+++ b/frontend/src/metabase/visualizations/visualizations/List/components/ListView/use-external-drag-overlay.ts
@@ -37,6 +37,7 @@ export function useExternalDragOverlay({
>(null);
const handleDragStart = (event: DragStartEvent) => {
+ // Unjustified type cast. FIXME
setActivePillId(event.active.id as string);
};
@@ -61,6 +62,7 @@ export function useExternalDragOverlay({
}
const activeId = String(active.id);
+ // Unjustified type cast. FIXME
const from = active.data?.current?.containerId as ContainerId | undefined;
if (!from) {
@@ -73,6 +75,7 @@ export function useExternalDragOverlay({
// Check if we're dropping on an item (has containerId)
if (over.data?.current?.containerId) {
+ // Unjustified type cast. FIXME
to = over.data.current.containerId as ContainerId;
const toList = to === "left" ? leftValues : rightValues;
overIndexInTo = toList.indexOf(String(over.id));
diff --git a/frontend/src/metabase/visualizations/visualizations/PieChart/PieChart.stories.tsx b/frontend/src/metabase/visualizations/visualizations/PieChart/PieChart.stories.tsx
index 6e2123fabd2..afded917822 100644
--- a/frontend/src/metabase/visualizations/visualizations/PieChart/PieChart.stories.tsx
+++ b/frontend/src/metabase/visualizations/visualizations/PieChart/PieChart.stories.tsx
@@ -55,6 +55,7 @@ const Template: StoryFn = (args) => {
<Box h={500} style={{ backgroundColor }}>
<Visualization
{...props}
+ // Unjustified type cast. FIXME
rawSeries={data.defaultSettings as unknown as Series}
width={500}
/>
@@ -84,6 +85,7 @@ export const EmbeddedDashcard = {
export const DarkTheme: StoryFn = () => (
<VisualizationWrapper displayTheme="dark">
<Box h={500}>
+ {/* Unjustified type cast. FIXME */}
<Visualization rawSeries={data.defaultSettings as unknown as Series} />
</Box>
</VisualizationWrapper>
@@ -100,6 +102,7 @@ export const Watermark: StoryFn = () => (
})}
>
<Box h={500}>
+ {/* Unjustified type cast. FIXME */}
<Visualization rawSeries={data.defaultSettings as unknown as Series} />
</Box>
</VisualizationWrapper>
diff --git a/frontend/src/metabase/visualizations/visualizations/PieChart/PieRowsPicker.tsx b/frontend/src/metabase/visualizations/visualizations/PieChart/PieRowsPicker.tsx
index 15727aedb50..38b725c9733 100644
--- a/frontend/src/metabase/visualizations/visualizations/PieChart/PieRowsPicker.tsx
+++ b/frontend/src/metabase/visualizations/visualizations/PieChart/PieRowsPicker.tsx
@@ -60,6 +60,7 @@ export function PieRowsPicker({
const onSortEnd = (newPieRows: SortableChartSettingOrderedItem[]) =>
onChangeSettings({
"pie.sort_rows": false,
+ // Unjustified type cast. FIXME
"pie.rows": newPieRows as PieRow[],
});
@@ -69,6 +70,7 @@ export function PieRowsPicker({
series={rawSeries}
onChangeSeriesColor={onChangeSeriesColor}
onSortEnd={onSortEnd}
+ // Unjustified type cast. FIXME
onChange={(rows) => onChangeSettings({ "pie.rows": rows as PieRow[] })}
onShowWidget={onShowWidget}
hasEditSettings
diff --git a/frontend/src/metabase/visualizations/visualizations/PivotTable/PivotTable.unit.spec.tsx b/frontend/src/metabase/visualizations/visualizations/PivotTable/PivotTable.unit.spec.tsx
index 1355d65654d..05eaaa5e62e 100644
--- a/frontend/src/metabase/visualizations/visualizations/PivotTable/PivotTable.unit.spec.tsx
+++ b/frontend/src/metabase/visualizations/visualizations/PivotTable/PivotTable.unit.spec.tsx
@@ -136,6 +136,7 @@ describe("Visualizations > PivotTable > PivotTable", () => {
HTMLElement.prototype,
"offsetHeight",
) as number;
+ // Unjustified type cast. FIXME
const originalOffsetWidth = Object.getOwnPropertyDescriptor(
HTMLElement.prototype,
"offsetWidth",
diff --git a/frontend/src/metabase/visualizations/visualizations/PivotTable/PivotTableCell.tsx b/frontend/src/metabase/visualizations/visualizations/PivotTable/PivotTableCell.tsx
index c32aa41172b..6e68571feb6 100644
--- a/frontend/src/metabase/visualizations/visualizations/PivotTable/PivotTableCell.tsx
+++ b/frontend/src/metabase/visualizations/visualizations/PivotTable/PivotTableCell.tsx
@@ -122,6 +122,7 @@ export function Cell({
{!!onResize && (
<ResizableHandle
id={`resize-handle-${cellId}`}
+ // Unjustified type cast. FIXME
initialWidth={(style?.width as number) ?? 0}
onResizeEnd={onResize}
/>
diff --git a/frontend/src/metabase/visualizations/visualizations/PivotTable/PivotTableInner.tsx b/frontend/src/metabase/visualizations/visualizations/PivotTable/PivotTableInner.tsx
index b8d2264751a..43a19980390 100644
--- a/frontend/src/metabase/visualizations/visualizations/PivotTable/PivotTableInner.tsx
+++ b/frontend/src/metabase/visualizations/visualizations/PivotTable/PivotTableInner.tsx
@@ -250,6 +250,7 @@ const PivotTableInner = forwardRef<HTMLDivElement, VisualizationProps>(
let newColumnWidths: Partial<HeaderWidthType> = {};
if (columnType === "leftHeader") {
+ // Unjustified type cast. FIXME
const newLeftHeaderColumnWidths = [...(leftHeaderWidths as number[])];
newLeftHeaderColumnWidths[columnIndex] = Math.max(
newWidth,
@@ -473,6 +474,7 @@ const PivotTableInner = forwardRef<HTMLDivElement, VisualizationProps>(
)
}
onScroll={({ scrollLeft }) =>
+ // Unjustified type cast. FIXME
onScroll({ scrollLeft } as OnScrollParams)
}
scrollLeft={scrollLeft}
@@ -511,6 +513,7 @@ const PivotTableInner = forwardRef<HTMLDivElement, VisualizationProps>(
height={bodyHeight - scrollBarOffsetSize()}
scrollTop={scrollTop}
onScroll={({ scrollTop }) =>
+ // Unjustified type cast. FIXME
onScroll({ scrollTop } as OnScrollParams)
}
/>
@@ -563,6 +566,7 @@ const PivotTableInner = forwardRef<HTMLDivElement, VisualizationProps>(
);
}}
onScroll={({ scrollLeft, scrollTop }) =>
+ // Unjustified type cast. FIXME
onScroll({
scrollLeft,
scrollTop,
diff --git a/frontend/src/metabase/visualizations/visualizations/PivotTable/RowToggleIcon.tsx b/frontend/src/metabase/visualizations/visualizations/PivotTable/RowToggleIcon.tsx
index f3de3dc2d0a..b41798d1f2e 100644
--- a/frontend/src/metabase/visualizations/visualizations/PivotTable/RowToggleIcon.tsx
+++ b/frontend/src/metabase/visualizations/visualizations/PivotTable/RowToggleIcon.tsx
@@ -30,6 +30,7 @@ export function RowToggleIcon({
if (value == null) {
return null;
}
+ // Unjustified type cast. FIXME
const setting = settings[
COLLAPSED_ROWS_SETTING
] as PivotTableCollapsedRowsSetting;
@@ -39,6 +40,7 @@ export function RowToggleIcon({
const settingValue: PivotTableCollapsedRowsSetting["value"] =
setting.value || [];
const isColumnCollapsed =
+ // Unjustified type cast. FIXME
!isColumn && settingValue.includes(columnRef as string);
const isCollapsed = settingValue.includes(ref) || isColumnCollapsed;
diff --git a/frontend/src/metabase/visualizations/visualizations/PivotTable/pivot-table-test-mocks.tsx b/frontend/src/metabase/visualizations/visualizations/PivotTable/pivot-table-test-mocks.tsx
index 1722cd22bb2..1ba529f83de 100644
--- a/frontend/src/metabase/visualizations/visualizations/PivotTable/pivot-table-test-mocks.tsx
+++ b/frontend/src/metabase/visualizations/visualizations/PivotTable/pivot-table-test-mocks.tsx
@@ -4,6 +4,7 @@ import type { DatasetColumn, VisualizationSettings } from "metabase-types/api";
import { PivotTableView } from "./PivotTableInner";
+// Unjustified type cast. FIXME
const cols = [
{
name: "field-123",
@@ -67,6 +68,7 @@ const pivotSettings = {
column_settings: {},
};
+// Unjustified type cast. FIXME
const settings = {
...pivotSettings,
column: (c: any) => ({
diff --git a/frontend/src/metabase/visualizations/visualizations/PivotTable/utils.unit.spec.ts b/frontend/src/metabase/visualizations/visualizations/PivotTable/utils.unit.spec.ts
index 7494902bc24..83baa7eed4f 100644
--- a/frontend/src/metabase/visualizations/visualizations/PivotTable/utils.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/visualizations/PivotTable/utils.unit.spec.ts
@@ -247,6 +247,7 @@ describe("Visualizations > Visualizations > PivotTable > utils", () => {
});
it("should return the wider of the column header or data width", () => {
+ // Unjustified type cast. FIXME
const data = [
{ depth: 0, value: "x".repeat(150) },
{ depth: 0, value: "foo2" },
@@ -273,6 +274,7 @@ describe("Visualizations > Visualizations > PivotTable > utils", () => {
});
it("should factor in the toggle icon width for columns with subtotals", () => {
+ // Unjustified type cast. FIXME
const data = [
{ depth: 0, value: "x".repeat(100), hasSubtotal: true },
{ depth: 0, value: "foo2" },
@@ -309,6 +311,7 @@ describe("Visualizations > Visualizations > PivotTable > utils", () => {
rows: [],
pivot_rows_truncated: 100000,
};
+ // Unjustified type cast. FIXME
expect(() => checkRenderable([{ data }] as any, {} as any)).toThrow(
/Too many rows/,
);
@@ -322,12 +325,14 @@ describe("Visualizations > Visualizations > PivotTable > utils", () => {
],
rows: [],
};
+ // Unjustified type cast. FIXME
expect(() => checkRenderable([{ data }] as any, {} as any)).not.toThrow();
});
});
describe("getColumnValues", () => {
it("can collect column values from left header data", () => {
+ // Unjustified type cast. FIXME
const data = [
{ depth: 0, value: "foo1" },
{ depth: 0, value: "foo2" },
@@ -349,6 +354,7 @@ describe("Visualizations > Visualizations > PivotTable > utils", () => {
});
it("detects columns with subtotals", () => {
+ // Unjustified type cast. FIXME
const data = [
{ depth: 0, value: "foo1", hasSubtotal: false },
{ depth: 0, value: "foo2", hasSubtotal: true },
@@ -367,6 +373,7 @@ describe("Visualizations > Visualizations > PivotTable > utils", () => {
});
it("handles null values", () => {
+ // Unjustified type cast. FIXME
const data = [
{ depth: 0, value: "foo1", hasSubtotal: false },
{ depth: 0, value: null, hasSubtotal: true },
@@ -388,6 +395,7 @@ describe("Visualizations > Visualizations > PivotTable > utils", () => {
describe("leftHeaderCellSizeAndPositionGetter", () => {
it("should return the correct width for a subtotal", () => {
const result = leftHeaderCellSizeAndPositionGetter(
+ // Unjustified type cast. FIXME
{ depth: 1, maxDepthBelow: 0, isSubtotal: true } as HeaderItem,
[100, 100, 100],
[0, 1, 2],
@@ -397,6 +405,7 @@ describe("Visualizations > Visualizations > PivotTable > utils", () => {
it("should return the correct width for a non-subtotal", () => {
const result = leftHeaderCellSizeAndPositionGetter(
+ // Unjustified type cast. FIXME
{ depth: 1, maxDepthBelow: 1, isSubtotal: false } as HeaderItem,
[100, 100, 100],
[0, 1, 2],
@@ -406,6 +415,7 @@ describe("Visualizations > Visualizations > PivotTable > utils", () => {
it("non-subtotal widths should not increase when columns are collapsed", () => {
const result = leftHeaderCellSizeAndPositionGetter(
+ // Unjustified type cast. FIXME
{ depth: 1, maxDepthBelow: 0, isSubtotal: false } as HeaderItem,
[100, 100, 100],
[0, 1, 2],
diff --git a/frontend/src/metabase/visualizations/visualizations/Progress/utils.unit.spec.ts b/frontend/src/metabase/visualizations/visualizations/Progress/utils.unit.spec.ts
index 48a1bc63223..81bf79a0065 100644
--- a/frontend/src/metabase/visualizations/visualizations/Progress/utils.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/visualizations/Progress/utils.unit.spec.ts
@@ -21,6 +21,7 @@ describe("Visualizations > Progress > utils", () => {
valueTestCases.forEach(([input, output]) => {
it(`should return ${output} for ${JSON.stringify(input)}`, () => {
+ // Unjustified type cast. FIXME
expect(getValue(input as any)).toEqual(output);
});
});
diff --git a/frontend/src/metabase/visualizations/visualizations/RowChart/RowChart.stories.tsx b/frontend/src/metabase/visualizations/visualizations/RowChart/RowChart.stories.tsx
index 021b5dc333e..b5c8fa252e0 100644
--- a/frontend/src/metabase/visualizations/visualizations/RowChart/RowChart.stories.tsx
+++ b/frontend/src/metabase/visualizations/visualizations/RowChart/RowChart.stories.tsx
@@ -22,6 +22,7 @@ export default {
// @ts-expect-error: incompatible prop types with registerVisualization
registerVisualization(RowChart);
+// Unjustified type cast. FIXME
const MOCK_SERIES = [
{
card: createMockCard({ name: "Card", display: "row" }),
@@ -57,6 +58,7 @@ Default.parameters = {
};
export const WithLongNames = () => {
+ // Unjustified type cast. FIXME
const [series, setSeries] = useState([
{
card: createMockCard({ name: "Card", display: "row" }),
diff --git a/frontend/src/metabase/visualizations/visualizations/RowChart/RowChart.tsx b/frontend/src/metabase/visualizations/visualizations/RowChart/RowChart.tsx
index c1faeb3cbda..2fb27f7fd3c 100644
--- a/frontend/src/metabase/visualizations/visualizations/RowChart/RowChart.tsx
+++ b/frontend/src/metabase/visualizations/visualizations/RowChart/RowChart.tsx
@@ -129,6 +129,7 @@ const RowChartVisualization = ({
const data = useMemo(
() =>
+ // Unjustified type cast. FIXME
extractRemappedColumns(chartSeries.data) as RemappingHydratedChartData,
[chartSeries.data],
);
diff --git a/frontend/src/metabase/visualizations/visualizations/RowChart/utils/events.unit.spec.ts b/frontend/src/metabase/visualizations/visualizations/RowChart/utils/events.unit.spec.ts
index 6f16be4b7cc..405bee93173 100644
--- a/frontend/src/metabase/visualizations/visualizations/RowChart/utils/events.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/visualizations/RowChart/utils/events.unit.spec.ts
@@ -28,8 +28,11 @@ import {
} from "./events";
const datasetColumns = [
+ // Unjustified type cast. FIXME
{ name: "y", display_name: "Y" } as RemappingHydratedDatasetColumn,
+ // Unjustified type cast. FIXME
{ name: "x", display_name: "X" } as RemappingHydratedDatasetColumn,
+ // Unjustified type cast. FIXME
{ name: "x1", display_name: "X1" } as RemappingHydratedDatasetColumn,
];
@@ -149,6 +152,7 @@ describe("events utils", () => {
barData,
{
"stackable.stack_type":
+ // Unjustified type cast. FIXME
stackType as VisualizationSettings["stackable.stack_type"],
},
chartColumns,
diff --git a/frontend/src/metabase/visualizations/visualizations/RowChart/utils/format.unit.spec.ts b/frontend/src/metabase/visualizations/visualizations/RowChart/utils/format.unit.spec.ts
index 2414e69a376..51f50eec906 100644
--- a/frontend/src/metabase/visualizations/visualizations/RowChart/utils/format.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/visualizations/RowChart/utils/format.unit.spec.ts
@@ -38,6 +38,7 @@ const chartColumns: CartesianChartColumns = {
],
};
+// Unjustified type cast. FIXME
const settings = {
"graph.label_value_formatting": "full",
column: (column: DatasetColumn) => {
@@ -58,6 +59,7 @@ const settings = {
} as VisualizationSettings;
const getBar = (metricColumn: DatasetColumn) =>
+ // Unjustified type cast. FIXME
({
series: {
seriesInfo: {
diff --git a/frontend/src/metabase/visualizations/visualizations/SankeyChart/events.unit.spec.ts b/frontend/src/metabase/visualizations/visualizations/SankeyChart/events.unit.spec.ts
index ce011ba5de8..b8ae7c4ba6c 100644
--- a/frontend/src/metabase/visualizations/visualizations/SankeyChart/events.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/visualizations/SankeyChart/events.unit.spec.ts
@@ -52,6 +52,7 @@ describe("createSankeyClickData", () => {
};
const settings = {};
+ // Unjustified type cast. FIXME
const mockEvent = {
event: {
event: new MouseEvent("click"),
diff --git a/frontend/src/metabase/visualizations/visualizations/Scalar/Scalar.stories.tsx b/frontend/src/metabase/visualizations/visualizations/Scalar/Scalar.stories.tsx
index b51cb478324..9aef9378e93 100644
--- a/frontend/src/metabase/visualizations/visualizations/Scalar/Scalar.stories.tsx
+++ b/frontend/src/metabase/visualizations/visualizations/Scalar/Scalar.stories.tsx
@@ -23,6 +23,7 @@ export default {
// @ts-expect-error: incompatible prop types with registerVisualization
registerVisualization(Scalar);
+// Unjustified type cast. FIXME
const MOCK_SERIES = [
{
card: createMockCard({ name: "Card", display: "scalar" }),
@@ -83,6 +84,7 @@ WithFormattingAndHover.play = async ({
}) => {
const asyncCallback = createAsyncCallback();
try {
+ // Unjustified type cast. FIXME
const canvas = within(canvasElement.parentElement as HTMLElement);
const value = (await canvas.findAllByTestId("scalar-value"))[2];
diff --git a/frontend/src/metabase/visualizations/visualizations/Scalar/Scalar.tsx b/frontend/src/metabase/visualizations/visualizations/Scalar/Scalar.tsx
index bc3990e735c..bf2f616fbae 100644
--- a/frontend/src/metabase/visualizations/visualizations/Scalar/Scalar.tsx
+++ b/frontend/src/metabase/visualizations/visualizations/Scalar/Scalar.tsx
@@ -276,6 +276,7 @@ export class Scalar extends Component<
gridSize={gridSize}
height={Math.max(height - PADDING * 2, 0)}
totalNumGridCols={totalNumGridCols}
+ // Unjustified type cast. FIXME
value={displayValue as string}
width={Math.max(width - PADDING, 0)}
/>
diff --git a/frontend/src/metabase/visualizations/visualizations/Scalar/Scalar.unit.spec.tsx b/frontend/src/metabase/visualizations/visualizations/Scalar/Scalar.unit.spec.tsx
index a3bb4c42009..dc2f97010b9 100644
--- a/frontend/src/metabase/visualizations/visualizations/Scalar/Scalar.unit.spec.tsx
+++ b/frontend/src/metabase/visualizations/visualizations/Scalar/Scalar.unit.spec.tsx
@@ -16,6 +16,7 @@ import {
import { Scalar } from "./Scalar";
const series = (value: number | null = 1.23) =>
+ // Unjustified type cast. FIXME
[
{
card: createMockCard({ display: "scalar" }),
@@ -23,6 +24,7 @@ const series = (value: number | null = 1.23) =>
},
] as Series;
+// Unjustified type cast. FIXME
const mockedProps = {} as ComponentProps<typeof Scalar>;
const settings = {
diff --git a/frontend/src/metabase/visualizations/visualizations/Scalar/scalars-bar-transform.ts b/frontend/src/metabase/visualizations/visualizations/Scalar/scalars-bar-transform.ts
index a03513d373c..be20d116c52 100644
--- a/frontend/src/metabase/visualizations/visualizations/Scalar/scalars-bar-transform.ts
+++ b/frontend/src/metabase/visualizations/visualizations/Scalar/scalars-bar-transform.ts
@@ -5,6 +5,7 @@ import { TYPE } from "metabase-lib/v1/types/constants";
import type { RawSeries } from "metabase-types/api";
export const scalarToBarTransform: TransformSeries = (rawSeries) => {
+ // Unjustified type cast. FIXME
return rawSeries.map(({ card, data }) => {
let metricColumnIndex = data.cols.findIndex(
(col) => col.name === card.visualization_settings["scalar.field"],
diff --git a/frontend/src/metabase/visualizations/visualizations/SmartScalar/PreviousValueComparison/PreviousValueComparison.tsx b/frontend/src/metabase/visualizations/visualizations/SmartScalar/PreviousValueComparison/PreviousValueComparison.tsx
index 2e87a64328f..d55048014aa 100644
--- a/frontend/src/metabase/visualizations/visualizations/SmartScalar/PreviousValueComparison/PreviousValueComparison.tsx
+++ b/frontend/src/metabase/visualizations/visualizations/SmartScalar/PreviousValueComparison/PreviousValueComparison.tsx
@@ -42,7 +42,8 @@ export function PreviousValueComparison({
const fittedChangeDisplay =
changeType === CHANGE_TYPE_OPTIONS.CHANGED.CHANGE_TYPE
- ? formatChangeAutoPrecision(percentChange as number, {
+ ? // Unjustified type cast. FIXME
+ formatChangeAutoPrecision(percentChange as number, {
fontFamily,
fontWeight: 900,
width: getChangeWidth(width),
diff --git a/frontend/src/metabase/visualizations/visualizations/SmartScalar/SettingsComponents/SmartScalarSettingsWidgets.styled.tsx b/frontend/src/metabase/visualizations/visualizations/SmartScalar/SettingsComponents/SmartScalarSettingsWidgets.styled.tsx
index 0e0f0de9590..55f37fcf048 100644
--- a/frontend/src/metabase/visualizations/visualizations/SmartScalar/SettingsComponents/SmartScalarSettingsWidgets.styled.tsx
+++ b/frontend/src/metabase/visualizations/visualizations/SmartScalar/SettingsComponents/SmartScalarSettingsWidgets.styled.tsx
@@ -33,6 +33,7 @@ export const ComparisonPickerSecondaryText = styled(
),
)<ComparisonPickerSecondaryTextProps>``;
+// Unjustified type cast. FIXME
export const ComparisonPickerButton = styled(Button)<ButtonProps>`
height: 40px;
diff --git a/frontend/src/metabase/visualizations/visualizations/SmartScalar/SmartScalar.tsx b/frontend/src/metabase/visualizations/visualizations/SmartScalar/SmartScalar.tsx
index c1e60a1e70a..a476b52aa45 100644
--- a/frontend/src/metabase/visualizations/visualizations/SmartScalar/SmartScalar.tsx
+++ b/frontend/src/metabase/visualizations/visualizations/SmartScalar/SmartScalar.tsx
@@ -129,6 +129,7 @@ export function SmartScalar({
gridSize={gridSize}
height={valueHeight}
totalNumGridCols={totalNumGridCols}
+ // Unjustified type cast. FIXME
value={displayValue as string}
width={getValueWidth(width)}
/>
diff --git a/frontend/src/metabase/visualizations/visualizations/SmartScalar/compute.ts b/frontend/src/metabase/visualizations/visualizations/SmartScalar/compute.ts
index f5e796653ff..12ef84c8f3d 100644
--- a/frontend/src/metabase/visualizations/visualizations/SmartScalar/compute.ts
+++ b/frontend/src/metabase/visualizations/visualizations/SmartScalar/compute.ts
@@ -127,6 +127,7 @@ export function computeTrend(
};
} catch (error) {
return {
+ // Unjustified type cast. FIXME
error: error as Error,
};
}
@@ -280,6 +281,7 @@ function getCurrentMetricData({
if (latestRowIndex === -1) {
throw Error("No rows contain a valid value.");
}
+ // Unjustified type cast. FIXME
const date = rows[latestRowIndex][dimensionColIndex] as string;
const value = rows[latestRowIndex][metricColIndex];
@@ -457,6 +459,7 @@ function computeComparisonPreviousValue({
return null;
}
+ // Unjustified type cast. FIXME
const prevDate = rows[previousRowIndex][dimensionColIndex] as string;
const prevValue = rows[previousRowIndex][metricColIndex];
@@ -557,7 +560,8 @@ function computeComparisonPeriodsAgo({
};
const prevDate = !isEmpty(rowPeriodsAgo)
- ? (rowPeriodsAgo?.[dimensionColIndex] as string)
+ ? // Unjustified type cast. FIXME
+ (rowPeriodsAgo?.[dimensionColIndex] as string)
: computedPrevDate;
const comparisonDescStr =
dateUnitsAgo === 1
@@ -617,6 +621,7 @@ function getRowOfPeriodsAgo({
for (let i = searchIndexStart; i >= searchIndexEnd; i--) {
const candidateRow = rows[i];
const candidateDate = dayjs.parseZone(
+ // Unjustified type cast. FIXME
candidateRow?.[dimensionColIndex] as string | undefined,
);
const candidateValue = candidateRow[metricColIndex];
diff --git a/frontend/src/metabase/visualizations/visualizations/SmartScalar/compute.unit.spec.ts b/frontend/src/metabase/visualizations/visualizations/SmartScalar/compute.unit.spec.ts
index eef6275c394..bc102b6270f 100644
--- a/frontend/src/metabase/visualizations/visualizations/SmartScalar/compute.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/visualizations/SmartScalar/compute.unit.spec.ts
@@ -1220,6 +1220,7 @@ describe("SmartScalar > compute", () => {
// type casting is required for invalid values testing
{
id: "1",
+ // Unjustified type cast. FIXME
type: type as SmartScalarComparisonType,
} as SmartScalarComparison,
],
diff --git a/frontend/src/metabase/visualizations/visualizations/SmartScalar/tests/SmartScalar.unit.spec.tsx b/frontend/src/metabase/visualizations/visualizations/SmartScalar/tests/SmartScalar.unit.spec.tsx
index 05d023cfe87..7ab60e9877e 100644
--- a/frontend/src/metabase/visualizations/visualizations/SmartScalar/tests/SmartScalar.unit.spec.tsx
+++ b/frontend/src/metabase/visualizations/visualizations/SmartScalar/tests/SmartScalar.unit.spec.tsx
@@ -346,6 +346,7 @@ describe("SmartScalar", () => {
series({
rows,
insights,
+ // Unjustified type cast. FIXME
comparisonType: getPeriodsAgoComparison("hi" as unknown as number),
}),
);
diff --git a/frontend/src/metabase/visualizations/visualizations/SmartScalar/tests/test-mocks.ts b/frontend/src/metabase/visualizations/visualizations/SmartScalar/tests/test-mocks.ts
index a564bdb52e4..c3dd28d4fa1 100644
--- a/frontend/src/metabase/visualizations/visualizations/SmartScalar/tests/test-mocks.ts
+++ b/frontend/src/metabase/visualizations/visualizations/SmartScalar/tests/test-mocks.ts
@@ -43,6 +43,7 @@ export const mockSeries = ({
NumberColumn({ name: "Sum" }),
];
+ // Unjustified type cast. FIXME
return [
{
card: {
diff --git a/frontend/src/metabase/visualizations/visualizations/SmartScalar/utils.ts b/frontend/src/metabase/visualizations/visualizations/SmartScalar/utils.ts
index cb4bf7de458..d65a4a0110e 100644
--- a/frontend/src/metabase/visualizations/visualizations/SmartScalar/utils.ts
+++ b/frontend/src/metabase/visualizations/visualizations/SmartScalar/utils.ts
@@ -330,7 +330,9 @@ function getMaxPeriodsAgo({
return null;
}
+ // Unjustified type cast. FIXME
const latestNonEmptyDate = latestNonEmptyRow[dimensionIndex] as string;
+ // Unjustified type cast. FIXME
const earliestNonEmptyDate = earliestNonEmptyRow[dimensionIndex] as string;
if (latestNonEmptyDate === null || earliestNonEmptyDate === null) {
diff --git a/frontend/src/metabase/visualizations/visualizations/SmartScalar/utils.unit.spec.ts b/frontend/src/metabase/visualizations/visualizations/SmartScalar/utils.unit.spec.ts
index 8cbf803d047..8603e064ee9 100644
--- a/frontend/src/metabase/visualizations/visualizations/SmartScalar/utils.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/visualizations/SmartScalar/utils.unit.spec.ts
@@ -258,8 +258,10 @@ describe("SmartScalar > utils", () => {
["2019-11-01", 300],
];
const isValid = isComparisonValid(
+ // Unjustified type cast. FIXME
comparison as SmartScalarComparison,
series({ rows, insights: [] }),
+ // Unjustified type cast. FIXME
settings as VisualizationSettings,
);
@@ -377,8 +379,10 @@ describe("SmartScalar > utils", () => {
};
const isValid = isComparisonValid(
+ // Unjustified type cast. FIXME
comparison as SmartScalarComparisonAnotherColumn,
multiSeries,
+ // Unjustified type cast. FIXME
settings as VisualizationSettings,
);
@@ -396,8 +400,10 @@ describe("SmartScalar > utils", () => {
};
const isValid = isComparisonValid(
+ // Unjustified type cast. FIXME
comparison as SmartScalarComparisonAnotherColumn,
multiSeries,
+ // Unjustified type cast. FIXME
settings as VisualizationSettings,
);
@@ -433,8 +439,10 @@ describe("SmartScalar > utils", () => {
};
const isValid = isComparisonValid(
+ // Unjustified type cast. FIXME
comparison as SmartScalarComparisonAnotherColumn,
multiSeries,
+ // Unjustified type cast. FIXME
settings as VisualizationSettings,
);
@@ -482,8 +490,10 @@ describe("SmartScalar > utils", () => {
];
const isValid = isComparisonValid(
+ // Unjustified type cast. FIXME
comparison as SmartScalarComparisonStaticNumber,
series({ rows, insights: [] }),
+ // Unjustified type cast. FIXME
settings as VisualizationSettings,
);
@@ -505,8 +515,10 @@ describe("SmartScalar > utils", () => {
];
const isValid = isComparisonValid(
+ // Unjustified type cast. FIXME
comparison as SmartScalarComparisonStaticNumber,
series({ rows, insights: [] }),
+ // Unjustified type cast. FIXME
settings as VisualizationSettings,
);
diff --git a/frontend/src/metabase/visualizations/visualizations/Table/Table.stories.tsx b/frontend/src/metabase/visualizations/visualizations/Table/Table.stories.tsx
index d706ae6f5a4..633e26dd283 100644
--- a/frontend/src/metabase/visualizations/visualizations/Table/Table.stories.tsx
+++ b/frontend/src/metabase/visualizations/visualizations/Table/Table.stories.tsx
@@ -35,6 +35,7 @@ const storeInitialState = createMockState({
settings,
entities: createMockEntitiesState({}),
});
+// Unjustified type cast. FIXME
const store = getCommonStore(storeInitialState) as unknown as Store<State>;
export default {
diff --git a/frontend/src/metabase/visualizations/visualizations/TreemapChart/TreemapGroupsPicker.tsx b/frontend/src/metabase/visualizations/visualizations/TreemapChart/TreemapGroupsPicker.tsx
index 991c88978a0..6bb870646b0 100644
--- a/frontend/src/metabase/visualizations/visualizations/TreemapChart/TreemapGroupsPicker.tsx
+++ b/frontend/src/metabase/visualizations/visualizations/TreemapChart/TreemapGroupsPicker.tsx
@@ -46,6 +46,7 @@ export function TreemapGroupsPicker({
value={treemapRows}
series={rawSeries}
onChange={(rows) =>
+ // Unjustified type cast. FIXME
onChangeSettings({ "treemap.rows": rows as TreemapRow[] })
}
onChangeSeriesColor={handleChangeSeriesColor}
diff --git a/frontend/src/metabase/visualizations/visualizations/TreemapChart/events.unit.spec.ts b/frontend/src/metabase/visualizations/visualizations/TreemapChart/events.unit.spec.ts
index 763d995549b..d901270a35b 100644
--- a/frontend/src/metabase/visualizations/visualizations/TreemapChart/events.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/visualizations/TreemapChart/events.unit.spec.ts
@@ -88,8 +88,10 @@ const tree1: TreemapTree = [
{ rawName: "Grains", displayName: "Grains", value: 15, rowIndices: [1] },
];
+// Unjustified type cast. FIXME
const settings = {} as ComputedVisualizationSettings;
+// Unjustified type cast. FIXME
const rawSeries1 = [
{
card: createMockCard(),
@@ -102,6 +104,7 @@ const rawSeries1 = [
}),
},
] as RawSeries;
+// Unjustified type cast. FIXME
const rawSeries2 = [
{
card: createMockCard(),
@@ -118,6 +121,7 @@ const rawSeries2 = [
// A click event carrying the path-encoded node id plus the nested DOM event
// that `getTreemapClickData` forwards onto the `ClickObject`.
function makeClickEvent(id: unknown) {
+ // Unjustified type cast. FIXME
const domEvent = {} as MouseEvent;
return { data: { id }, event: { event: domEvent } };
}
@@ -128,6 +132,7 @@ function makeChartRef(overrides: Record<string, unknown> = {}) {
const add = jest.fn();
const remove = jest.fn();
const zr = { add, remove };
+ // Unjustified type cast. FIXME
const chartRef = {
current: {
dispatchAction,
@@ -409,12 +414,14 @@ describe("getTreemapClickData", () => {
treemapColumns: treemapColumns2,
rawSeries: rawSeries2,
settings,
+ // Unjustified type cast. FIXME
event: makeClickEvent("9-9") as never,
}),
).toBeNull();
});
it("omits dimensions for a native card (no field refs to filter on)", () => {
+ // Unjustified type cast. FIXME
const nativeRawSeries = [
{ card: createMockNativeCard(), data: rawSeries2[0].data },
] as RawSeries;
@@ -425,6 +432,7 @@ describe("getTreemapClickData", () => {
treemapColumns: treemapColumns2,
rawSeries: nativeRawSeries,
settings,
+ // Unjustified type cast. FIXME
event: makeClickEvent("0-1") as never,
});
@@ -439,6 +447,7 @@ describe("getTreemapClickData", () => {
treemapColumns: treemapColumns2,
rawSeries: rawSeries2,
settings,
+ // Unjustified type cast. FIXME
event: makeClickEvent("0-1") as never,
});
@@ -464,6 +473,7 @@ describe("hideTreemapHoverOverlay", () => {
it("clears the ref even when the chart is already disposed", () => {
const { chartRef, remove } = makeChartRef({ isDisposed: () => true });
const overlayRef = {
+ // Unjustified type cast. FIXME
current: {} as TreemapHoverOverlay,
};
@@ -496,6 +506,7 @@ describe("dispatchTreemapViewRoot", () => {
});
it("is a no-op when the chart isn't ready", () => {
+ // Unjustified type cast. FIXME
const chartRef = {
current: undefined,
} as React.MutableRefObject<EChartsType | undefined>;
diff --git a/frontend/src/metabase/visualizations/visualizations/TreemapChart/use-label-measurement.unit.spec.ts b/frontend/src/metabase/visualizations/visualizations/TreemapChart/use-label-measurement.unit.spec.ts
index 02169d0d00a..ea968977334 100644
--- a/frontend/src/metabase/visualizations/visualizations/TreemapChart/use-label-measurement.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/visualizations/TreemapChart/use-label-measurement.unit.spec.ts
@@ -44,6 +44,7 @@ function createMockChartRef(
getLayout: () => ({ x: 0, y: 0, ...rect }),
children: id.includes("-") ? [] : [{}],
}));
+ // Unjustified type cast. FIXME
const chart = {
getModel: () => ({
getSeriesByIndex: () => ({
@@ -57,6 +58,7 @@ function createMockChartRef(
}),
}),
} as unknown as EChartsType;
+ // Unjustified type cast. FIXME
return { current: chart } as MutableRefObject<EChartsType | undefined>;
}
diff --git a/frontend/src/metabase/visualizer/components/DataImporter/ColumnsList/ColumnsListItem.tsx b/frontend/src/metabase/visualizer/components/DataImporter/ColumnsList/ColumnsListItem.tsx
index 5e2c9c40a74..a5383e20243 100644
--- a/frontend/src/metabase/visualizer/components/DataImporter/ColumnsList/ColumnsListItem.tsx
+++ b/frontend/src/metabase/visualizer/components/DataImporter/ColumnsList/ColumnsListItem.tsx
@@ -68,6 +68,7 @@ export const ColumnsListItem = forwardRef<HTMLDivElement, ColumnsListItemProps>(
miw={16}
/>
<Icon
+ // Unjustified type cast. FIXME
name={getIconForField(column) as IconName}
mr={4}
size={16}
diff --git a/frontend/src/metabase/visualizer/components/DataImporter/DatasetsList/getIsCompatible.unit.spec.ts b/frontend/src/metabase/visualizer/components/DataImporter/DatasetsList/getIsCompatible.unit.spec.ts
index 876e82f83f1..a78ba22a997 100644
--- a/frontend/src/metabase/visualizer/components/DataImporter/DatasetsList/getIsCompatible.unit.spec.ts
+++ b/frontend/src/metabase/visualizer/components/DataImporter/DatasetsList/getIsCompatible.unit.spec.ts
@@ -230,6 +230,7 @@ describe("getIsCompatible", () => {
"2": createMockDataset({
data: {
cols: [
+ // Unjustified type cast. FIXME
createMockDatetimeColumn({ id: dateField.id as number }),
],
},
@@ -265,6 +266,7 @@ describe("getIsCompatible", () => {
"2": createMockDataset({
data: {
cols: [
+ // Unjustified type cast. FIXME
createMockDatetimeColumn({ id: dateField.id as number }),
],
},
@@ -294,6 +296,7 @@ describe("getIsCompatible", () => {
data: {
cols: [
createMockCategoryColumn({
+ // Unjustified type cast. FIXME
id: sameCategoryDimensionField.id as number,
}),
],
diff --git a/frontend/src/metabase/visualizer/components/Footer/Footer.tsx b/frontend/src/metabase/visualizer/components/Footer/Footer.tsx
index 0877c86fd7e..87755a060f2 100644
--- a/frontend/src/metabase/visualizer/components/Footer/Footer.tsx
+++ b/frontend/src/metabase/visualizer/components/Footer/Footer.tsx
@@ -29,6 +29,7 @@ export function Footer({ className }: { className?: string }) {
const handleChangeDisplay = useCallback(
(nextDisplay: string) => {
+ // Unjustified type cast. FIXME
dispatch(setDisplay(nextDisplay as VisualizationDisplay));
},
[dispatch],
diff --git a/frontend/src/metabase/visualizer/components/Visualizer/Visualizer.tsx b/frontend/src/metabase/visualizer/components/Visualizer/Visualizer.tsx
index 7961212795a..5c69dd67ca6 100644
--- a/frontend/src/metabase/visualizer/components/Visualizer/Visualizer.tsx
+++ b/frontend/src/metabase/visualizer/components/Visualizer/Visualizer.tsx
@@ -127,6 +127,7 @@ const VisualizerInner = (props: VisualizerProps) => {
(event: DragStartEvent) => {
if (isValidDraggedItem(event.active)) {
dispatch(
+ // Unjustified type cast. FIXME
setDraggedItem({
id: event.active.id,
data: {
diff --git a/frontend/src/metabase/visualizer/components/VizSettingsSidebar/VizSettingsSidebar.tsx b/frontend/src/metabase/visualizer/components/VizSettingsSidebar/VizSettingsSidebar.tsx
index 96bd5e0668e..cf5aa2bd8b4 100644
--- a/frontend/src/metabase/visualizer/components/VizSettingsSidebar/VizSettingsSidebar.tsx
+++ b/frontend/src/metabase/visualizer/components/VizSettingsSidebar/VizSettingsSidebar.tsx
@@ -49,6 +49,7 @@ export function VizSettingsSidebar({ className }: { className?: string }) {
error: null,
};
} catch (error) {
+ // Unjustified type cast. FIXME
return { widgets: [], error: error as Error };
}
}, [transformedSeries, handleChangeSettings]);
diff --git a/frontend/src/metabase/visualizer/selectors.ts b/frontend/src/metabase/visualizer/selectors.ts
index aba5bc1336e..c283459e8cb 100644
--- a/frontend/src/metabase/visualizer/selectors.ts
+++ b/frontend/src/metabase/visualizer/selectors.ts
@@ -127,6 +127,7 @@ const getVisualizerDatasetData = createSelector(
getVisualizerColumnValuesMapping,
],
(dataSources, datasets, columns, columnValuesMapping): DatasetData =>
+ // Unjustified type cast. FIXME
mergeVisualizerData({
columns,
columnValuesMapping,
@@ -155,6 +156,7 @@ const getVisualizerFlatRawSeries = createSelector(
const series: RawSeries = [
{
+ // Unjustified type cast. FIXME
card: {
display,
dataset_query: {},
@@ -247,6 +249,7 @@ export const getTabularPreviewSeries = createSelector(
return [
{
...rest,
+ // Unjustified type cast. FIXME
card: {
display: "table",
dataset_query: {},
diff --git a/frontend/src/metabase/visualizer/utils/get-initial-state-for-multiple-series.ts b/frontend/src/metabase/visualizer/utils/get-initial-state-for-multiple-series.ts
index 74fb03d87f3..1ba6ba51ec2 100644
--- a/frontend/src/metabase/visualizer/utils/get-initial-state-for-multiple-series.ts
+++ b/frontend/src/metabase/visualizer/utils/get-initial-state-for-multiple-series.ts
@@ -118,9 +118,11 @@ export function getInitialStateForMultipleSeries(rawSeries: RawSeries) {
settings: {},
preloadedDatasets: rawSeries.reduce(
(acc, s) => {
+ // Unjustified type cast. FIXME
acc[s.card.id] = s as unknown as Dataset;
return acc;
},
+ // Unjustified type cast. FIXME
{} as Record<number, Dataset | null | undefined>,
),
};
diff --git a/frontend/src/metabase/visualizer/utils/get-updated-settings-for-display.unit.spec.ts b/frontend/src/metabase/visualizer/utils/get-updated-settings-for-display.unit.spec.ts
index 18893bbb110..4b1e5f510a6 100644
--- a/frontend/src/metabase/visualizer/utils/get-updated-settings-for-display.unit.spec.ts
+++ b/frontend/src/metabase/visualizer/utils/get-updated-settings-for-display.unit.spec.ts
@@ -12,6 +12,7 @@ import { getUpdatedSettingsForDisplay } from "./get-updated-settings-for-display
registerVisualizations();
describe("updateSettingsForDisplay", () => {
+ // Unjustified type cast. FIXME
const columnValuesMapping = {
COLUMN_1: [
{ sourceId: "card:45", originalName: "CREATED_AT", name: "COLUMN_1" },
diff --git a/frontend/src/metabase/visualizer/utils/split-series.ts b/frontend/src/metabase/visualizer/utils/split-series.ts
index 78711fb449c..1875277688c 100644
--- a/frontend/src/metabase/visualizer/utils/split-series.ts
+++ b/frontend/src/metabase/visualizer/utils/split-series.ts
@@ -51,6 +51,7 @@ export function splitVisualizerSeries(
const allMetrics = mainCard.visualization_settings["graph.metrics"];
const allDimensions = mainCard.visualization_settings["graph.dimensions"];
+ // Unjustified type cast. FIXME
return dataSourceIds
.map((dataSourceId, i) => {
const columnNames = Object.keys(columnValuesMapping).filter(
diff --git a/frontend/src/metabase/visualizer/visualizations/compat.ts b/frontend/src/metabase/visualizer/visualizations/compat.ts
index 258606c2d91..870f969341f 100644
--- a/frontend/src/metabase/visualizer/visualizations/compat.ts
+++ b/frontend/src/metabase/visualizer/visualizations/compat.ts
@@ -82,11 +82,14 @@ export function groupColumnsBySuitableVizSettings(
state,
settings,
datasets,
+ // Unjustified type cast. FIXME
dataSourceColumns: columns as DatasetColumn[],
+ // Unjustified type cast. FIXME
column: column as DatasetColumn,
}),
}))
.filter((mapping) => !!mapping.slot);
+ // Unjustified type cast. FIXME
const groupedMappings = _.groupBy(mapping, (m) => m.slot as string);
return _.mapObject(groupedMappings, (mappings) =>
mappings.map((m) => m.column),
diff --git a/frontend/src/metabase/visualizer/visualizer.slice.ts b/frontend/src/metabase/visualizer/visualizer.slice.ts
index 94afe35b51d..d83a2e0eb2b 100644
--- a/frontend/src/metabase/visualizer/visualizer.slice.ts
+++ b/frontend/src/metabase/visualizer/visualizer.slice.ts
@@ -186,7 +186,9 @@ export const addDataSource = createAsyncThunk(
fetchCardQuery({ cardId: sourceId }),
);
+ // Unjustified type cast. FIXME
const card = cardAction.payload as Card;
+ // Unjustified type cast. FIXME
dataset = cardQueryAction.payload as Dataset;
vizSettings = card.visualization_settings || null;
@@ -416,12 +418,14 @@ const visualizerSlice = createSlice({
state,
columnRef,
originalColumn,
+ // Unjustified type cast. FIXME
dataset as Dataset,
dataSource,
);
}
if (isDimension && column.id) {
+ // Unjustified type cast. FIXME
const datasetMap = _.omit(state.datasets, dataSource.id) as Record<
string,
Dataset
@@ -606,8 +610,10 @@ const visualizerSlice = createSlice({
// `any` prevents the "Type instantiation is excessively deep" error
if (index !== -1) {
+ // Unjustified type cast. FIXME
state.cards[index] = card as any;
} else {
+ // Unjustified type cast. FIXME
state.cards.push(card as any);
}
diff --git a/frontend/test/__support__/components/mantineSelect.ts b/frontend/test/__support__/components/mantineSelect.ts
index a6dacc05f77..514fd9f004b 100644
--- a/frontend/test/__support__/components/mantineSelect.ts
+++ b/frontend/test/__support__/components/mantineSelect.ts
@@ -29,6 +29,7 @@ export const viewMantineSelectOptions = async ({
return {
optionElements,
optionTextContents,
+ // Unjustified type cast. FIXME
displayedOption: root as HTMLInputElement,
};
};
diff --git a/frontend/test/__support__/custom-viz-fixtures/CalendarHeatmap.document.stories.tsx b/frontend/test/__support__/custom-viz-fixtures/CalendarHeatmap.document.stories.tsx
index 89b6db6b43f..d27ccb66290 100644
--- a/frontend/test/__support__/custom-viz-fixtures/CalendarHeatmap.document.stories.tsx
+++ b/frontend/test/__support__/custom-viz-fixtures/CalendarHeatmap.document.stories.tsx
@@ -79,6 +79,7 @@ function DocumentProviders({
entities: createMockEntitiesState({}),
});
const commonReducerNames = Object.keys(commonReducers);
+ // Unjustified type cast. FIXME
const initialState = _.pick(
storeInitialState,
...commonReducerNames,
diff --git a/frontend/test/__support__/entities-store.ts b/frontend/test/__support__/entities-store.ts
index ddf2a3ca00d..161f4012ca1 100644
--- a/frontend/test/__support__/entities-store.ts
+++ b/frontend/test/__support__/entities-store.ts
@@ -25,6 +25,7 @@ export function getStore(
initialState: Partial<State> = {},
middleware: Middleware[] = [],
) {
+ // Unjustified type cast. FIXME
const reducer = combineReducers({
entities: entitiesReducer,
...reducers,
@@ -32,8 +33,10 @@ export function getStore(
return configureStore({
reducer,
+ // Unjustified type cast. FIXME
preloadedState: initialState as State,
+ // Unjustified type cast. FIXME
middleware: ((getDefaultMiddleware: any) =>
getDefaultMiddleware({
immutableCheck: false,
diff --git a/frontend/test/__support__/intersection-observer.ts b/frontend/test/__support__/intersection-observer.ts
index 0e4bb1c973c..4778e1a46a6 100644
--- a/frontend/test/__support__/intersection-observer.ts
+++ b/frontend/test/__support__/intersection-observer.ts
@@ -51,7 +51,9 @@ export function setupMockIntersectionObserver() {
function setIntersecting(isIntersecting: boolean) {
act(() => {
intersectionCallback?.(
+ // Unjustified type cast. FIXME
[{ isIntersecting } as IntersectionObserverEntry],
+ // Unjustified type cast. FIXME
{} as IntersectionObserver,
);
});
diff --git a/frontend/test/__support__/server-mocks/entity-id.ts b/frontend/test/__support__/server-mocks/entity-id.ts
index 6f7e9dd03c2..b2d420387f5 100644
--- a/frontend/test/__support__/server-mocks/entity-id.ts
+++ b/frontend/test/__support__/server-mocks/entity-id.ts
@@ -27,6 +27,7 @@ export function setupEntityIdEndpoint(
fetchMock.post(
"path:/api/eid-translation/translate",
async (_url: string, options: RequestInit) => {
+ // Unjustified type cast. FIXME
const body = JSON.parse(options.body as string) as {
entity_ids: TranslateEntityIdRequest;
};
@@ -47,6 +48,7 @@ export function setupEntityIdEndpoint(
entityId: BaseEntityId;
}) => {
const mappedValue =
+ // Unjustified type cast. FIXME
entityIdMappings[entityType as keyof SUPPORTED_ENTITIES]?.[
entityId
];
diff --git a/frontend/test/__support__/server-mocks/metabot.ts b/frontend/test/__support__/server-mocks/metabot.ts
index 5b5be8afa7a..0009295fc69 100644
--- a/frontend/test/__support__/server-mocks/metabot.ts
+++ b/frontend/test/__support__/server-mocks/metabot.ts
@@ -36,6 +36,7 @@ export function setupMetabotsEndpoints(
);
metabots.forEach((metabot) => {
fetchMock.put(`path:/api/metabot/metabot/${metabot.id}`, (call) => {
+ // Unjustified type cast. FIXME
return { ...metabot, ...JSON.parse(call.options?.body as string) };
});
});
diff --git a/frontend/test/__support__/server-mocks/notification.ts b/frontend/test/__support__/server-mocks/notification.ts
index b86a0a6c05e..9747a431313 100644
--- a/frontend/test/__support__/server-mocks/notification.ts
+++ b/frontend/test/__support__/server-mocks/notification.ts
@@ -24,6 +24,7 @@ export const setupListNotificationEndpoints = (
export const setupCreateNotificationEndpoint = () => {
fetchMock.post("path:/api/notification", ({ options }) => {
+ // Unjustified type cast. FIXME
return createMockNotification(JSON.parse(options.body as string));
});
};
diff --git a/frontend/test/__support__/server-mocks/performance.ts b/frontend/test/__support__/server-mocks/performance.ts
index fbc3edda934..725f645700c 100644
--- a/frontend/test/__support__/server-mocks/performance.ts
+++ b/frontend/test/__support__/server-mocks/performance.ts
@@ -9,6 +9,7 @@ export function setupPerformanceEndpoints(cacheConfigs: CacheConfig[]) {
});
fetchMock.put("path:/api/cache", ({ options }) => {
+ // Unjustified type cast. FIXME
const body = JSON.parse(options.body as string);
configs = [
...configs.filter((config) => config.model_id !== body.model_id),
@@ -18,6 +19,7 @@ export function setupPerformanceEndpoints(cacheConfigs: CacheConfig[]) {
});
fetchMock.delete("path:/api/cache", ({ options }) => {
+ // Unjustified type cast. FIXME
const body = JSON.parse(options.body as string);
configs = configs.filter((config) => config.model_id !== body.model_id);
return {};
diff --git a/frontend/test/__support__/server-mocks/permissions.ts b/frontend/test/__support__/server-mocks/permissions.ts
index eee8aff8399..4a68075073f 100644
--- a/frontend/test/__support__/server-mocks/permissions.ts
+++ b/frontend/test/__support__/server-mocks/permissions.ts
@@ -37,6 +37,7 @@ export const setupCollectionPermissionsGraphEndpoint = (
) => {
fetchMock.get("path:/api/collection/graph", permissionsGraph);
fetchMock.put("path:/api/collection/graph", (call) => {
+ // Unjustified type cast. FIXME
const body = JSON.parse(call.options?.body as string);
body.revision += 1;
return body;
diff --git a/frontend/test/__support__/ui.tsx b/frontend/test/__support__/ui.tsx
index 3a4130ad3d8..e1007b0b1ef 100644
--- a/frontend/test/__support__/ui.tsx
+++ b/frontend/test/__support__/ui.tsx
@@ -207,9 +207,11 @@ export function getTestStoreAndWrapper({
history && routerMiddleware(history),
]);
+ // Unjustified type cast. FIXME
const store = getStore(
reducers,
initialState,
+ // Unjustified type cast. FIXME
storeMiddleware as Middleware[],
) as unknown as Store<State>;
@@ -477,6 +479,7 @@ export function createMockClipboardData(
opts?: Partial<DataTransfer>,
): DataTransfer {
const clipboardData = { ...opts };
+ // Unjustified type cast. FIXME
return clipboardData as unknown as DataTransfer;
}
diff --git a/frontend/test/metabase/visualizations/visualizations/Progress/utils.unit.spec.ts b/frontend/test/metabase/visualizations/visualizations/Progress/utils.unit.spec.ts
index 6d24658b945..57264c05175 100644
--- a/frontend/test/metabase/visualizations/visualizations/Progress/utils.unit.spec.ts
+++ b/frontend/test/metabase/visualizations/visualizations/Progress/utils.unit.spec.ts
@@ -96,7 +96,9 @@ describe("getGoalValue", () => {
});
it("should return 0 for invalid goal types", () => {
+ // Unjustified type cast. FIXME
expect(getGoalValue(null as any, mockColumns, rows)).toBe(0);
+ // Unjustified type cast. FIXME
expect(getGoalValue(undefined as any, mockColumns, rows)).toBe(0);
});
});
@@ -255,13 +257,17 @@ describe("calculateProgressMetrics", () => {
});
it("should handle null and undefined values", () => {
+ // Unjustified type cast. FIXME
expect(calculateProgressMetrics(null as any, 100).hasValidValue).toBe(
false,
);
+ // Unjustified type cast. FIXME
expect(calculateProgressMetrics(undefined as any, 100).hasValidValue).toBe(
false,
);
+ // Unjustified type cast. FIXME
expect(calculateProgressMetrics(50, null as any).hasValidGoal).toBe(false);
+ // Unjustified type cast. FIXME
expect(calculateProgressMetrics(50, undefined as any).hasValidGoal).toBe(
false,
);