Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Transforms permissions (#66296)

Aleksandr Lesnenkobd3f1d4632c6
diff --git a/.clj-kondo/config/modules/config.edn b/.clj-kondo/config/modules/config.edn
index a82886e7fe0..3af59f235dc 100644
--- a/.clj-kondo/config/modules/config.edn
+++ b/.clj-kondo/config/modules/config.edn
@@ -1779,6 +1779,7 @@
metabase-enterprise.advanced-permissions.common
metabase-enterprise.advanced-permissions.models.permissions.group-manager}
:uses #{api
+ audit-app
lib
permissions
premium-features
@@ -2333,6 +2334,7 @@
lib
lib-be
models
+ permissions
premium-features
queries
query-processor
@@ -2359,6 +2361,7 @@
lib
lib-be
models
+ permissions
query-processor
settings
util
diff --git a/e2e/support/helpers/e2e-permissions-helpers.js b/e2e/support/helpers/e2e-permissions-helpers.js
index f46161da1d8..093f2fecc88 100644
--- a/e2e/support/helpers/e2e-permissions-helpers.js
+++ b/e2e/support/helpers/e2e-permissions-helpers.js
@@ -87,7 +87,8 @@ export function assertPermissionForItem(
}
/**
- * @param {string} index
+ * @param {string} row
+ * @param {number} index
* @param {string} permission
* @param {boolean} isDisabled
*/
diff --git a/e2e/support/helpers/e2e-users-helpers.ts b/e2e/support/helpers/e2e-users-helpers.ts
index 08478d8b5c2..2e38236a24d 100644
--- a/e2e/support/helpers/e2e-users-helpers.ts
+++ b/e2e/support/helpers/e2e-users-helpers.ts
@@ -4,8 +4,8 @@ interface User {
last_name?: string | null;
}
-export function setUserAsAnalyst(userId: number) {
- cy.request("PUT", `/api/user/${userId}`, { is_data_analyst: true });
+export function setUserAsAnalyst(userId: number, enabled = true) {
+ cy.request("PUT", `/api/user/${userId}`, { is_data_analyst: enabled });
}
/**
diff --git a/e2e/test/scenarios/data-studio/transforms/transforms.cy.spec.ts b/e2e/test/scenarios/data-studio/transforms/transforms.cy.spec.ts
index 086eae2fb87..8de01b2d36c 100644
--- a/e2e/test/scenarios/data-studio/transforms/transforms.cy.spec.ts
+++ b/e2e/test/scenarios/data-studio/transforms/transforms.cy.spec.ts
@@ -1,8 +1,14 @@
import dedent from "ts-dedent";
-import { SAMPLE_DB_ID, WRITABLE_DB_ID } from "e2e/support/cypress_data";
+import {
+ SAMPLE_DB_ID,
+ USER_GROUPS,
+ WRITABLE_DB_ID,
+} from "e2e/support/cypress_data";
import { SAMPLE_DATABASE } from "e2e/support/cypress_sample_database";
+import { NORMAL_USER_ID } from "e2e/support/cypress_sample_instance_data";
import { createLibraryWithItems } from "e2e/support/test-library-data";
+import { DataPermissionValue } from "metabase/admin/permissions/types";
import type {
CardType,
CollectionId,
@@ -4004,3 +4010,55 @@ function getRowNames(): Cypress.Chainable<string[]> {
.findAllByTestId("tree-node-name")
.then(($rows) => $rows.get().map((row) => row.textContent.trim()));
}
+
+describe("scenarios > data studio > transforms > permissions", () => {
+ beforeEach(() => {
+ H.restore("postgres-writable");
+ H.resetTestTable({ type: "postgres", table: "many_schemas" });
+ cy.signInAsAdmin();
+ H.activateToken("bleeding-edge");
+ H.resyncDatabase({ dbId: WRITABLE_DB_ID, tableName: SOURCE_TABLE });
+
+ cy.intercept("POST", "/api/ee/transform").as("createTransform");
+ });
+
+ it("should allow non-admin users with data-studio permission to create transforms", () => {
+ cy.log("grant data-studio permission to All Users");
+ cy.visit("/admin/permissions/application");
+ cy.updatePermissionsGraph({
+ [USER_GROUPS.DATA_GROUP]: {
+ [WRITABLE_DB_ID]: {
+ transforms: DataPermissionValue.YES,
+ "view-data": DataPermissionValue.UNRESTRICTED,
+ "create-queries": DataPermissionValue.QUERY_BUILDER_AND_NATIVE,
+ },
+ },
+ });
+ H.setUserAsAnalyst(NORMAL_USER_ID);
+
+ cy.log("sign in as normal user and create a transform");
+ cy.signInAsNormalUser();
+ visitTransformListPage();
+ cy.button("Create a transform").click();
+ H.popover().findByText("Query builder").click();
+
+ H.miniPicker().within(() => {
+ cy.findByText(DB_NAME).click();
+ cy.findByText(TARGET_SCHEMA).click();
+ cy.findByText(SOURCE_TABLE).click();
+ });
+ getQueryEditor().button("Save").click();
+ H.modal().within(() => {
+ cy.findByLabelText("Name").clear().type("Non-admin transform");
+ cy.findByLabelText("Table name").type(TARGET_TABLE);
+ cy.button("Save").click();
+ cy.wait("@createTransform");
+ });
+
+ cy.log("Verify transform was created");
+ getTransformsNavLink().click();
+ H.DataStudio.Transforms.list()
+ .findByText("Non-admin transform")
+ .should("be.visible");
+ });
+});
diff --git a/e2e/test/scenarios/permissions/downgrade-ee-to-oss.cy.spec.js b/e2e/test/scenarios/permissions/downgrade-ee-to-oss.cy.spec.js
index 4c44600ceb9..5117dc0e3ee 100644
--- a/e2e/test/scenarios/permissions/downgrade-ee-to-oss.cy.spec.js
+++ b/e2e/test/scenarios/permissions/downgrade-ee-to-oss.cy.spec.js
@@ -65,6 +65,7 @@ describe("scenarios > admin > permissions > downgrade ee to oss", () => {
"No",
"No",
"No",
+ "No",
],
]);
});
diff --git a/e2e/test/scenarios/permissions/transforms-permissions.cy.spec.ts b/e2e/test/scenarios/permissions/transforms-permissions.cy.spec.ts
new file mode 100644
index 00000000000..cad7b22860c
--- /dev/null
+++ b/e2e/test/scenarios/permissions/transforms-permissions.cy.spec.ts
@@ -0,0 +1,427 @@
+const { H } = cy;
+import {
+ SAMPLE_DB_ID,
+ USER_GROUPS,
+ WRITABLE_DB_ID,
+} from "e2e/support/cypress_data";
+import { NORMAL_USER_ID } from "e2e/support/cypress_sample_instance_data";
+import { DataPermissionValue } from "metabase/admin/permissions/types";
+
+const { ALL_USERS_GROUP, COLLECTION_GROUP, DATA_GROUP } = USER_GROUPS;
+
+const CREATE_QUERIES_PERMISSION_INDEX = 1;
+const TRANSFORMS_PERMISSION_INDEX = 5;
+
+const SOURCE_TABLE = "Animals";
+const TARGET_TABLE = "permission_test_table";
+const TARGET_SCHEMA = "Schema A";
+
+describe(
+ "scenarios > admin > permissions > transforms permissions",
+ { tags: ["@external", "@actions"] },
+ () => {
+ beforeEach(() => {
+ H.restore("postgres-writable");
+ H.resetTestTable({ type: "postgres", table: "many_schemas" });
+ cy.signInAsAdmin();
+ H.activateToken("bleeding-edge");
+ H.resyncDatabase({ dbId: WRITABLE_DB_ID, tableName: SOURCE_TABLE });
+
+ cy.intercept("POST", "/api/ee/transform").as("createTransform");
+ cy.intercept("POST", "/api/ee/transform/*/run").as("runTransform");
+ });
+
+ describe("permission editor UI", () => {
+ it("shows Transforms column only at database level, not schema level", () => {
+ cy.visit(`/admin/permissions/data/database/${WRITABLE_DB_ID}`);
+ cy.findByTestId("permission-table")
+ .find("thead")
+ .should("contain.text", "Transforms");
+
+ cy.visit(
+ `/admin/permissions/data/database/${WRITABLE_DB_ID}/schema/Schema%20A`,
+ );
+ cy.findByTestId("permission-table")
+ .find("thead")
+ .should("not.contain.text", "Transforms");
+ });
+
+ it("allows changing and saving transforms permission", () => {
+ cy.intercept("PUT", "/api/permissions/graph").as("savePermissions");
+
+ cy.visit(`/admin/permissions/data/database/${WRITABLE_DB_ID}`);
+
+ H.assertPermissionForItem(
+ "All Users",
+ TRANSFORMS_PERMISSION_INDEX,
+ "No",
+ );
+
+ cy.log(
+ "Verify transforms permission is disabled if group lacks full data access",
+ );
+ H.isPermissionDisabled(
+ "All Users",
+ TRANSFORMS_PERMISSION_INDEX,
+ "No",
+ true,
+ );
+ H.modifyPermission(
+ "All Users",
+ CREATE_QUERIES_PERMISSION_INDEX,
+ "Query builder and native",
+ );
+ H.isPermissionDisabled(
+ "All Users",
+ TRANSFORMS_PERMISSION_INDEX,
+ "No",
+ false,
+ );
+
+ cy.log("Enable 'Transforms' permission and save");
+ H.modifyPermission("All Users", TRANSFORMS_PERMISSION_INDEX, "Yes");
+ cy.button("Save changes").click();
+ H.modal().within(() => {
+ cy.button("Yes").click();
+ });
+
+ cy.wait("@savePermissions").then((interception) => {
+ expect(
+ interception.request.body.groups[ALL_USERS_GROUP][WRITABLE_DB_ID]
+ .transforms,
+ ).to.equal("yes");
+ });
+
+ H.assertPermissionForItem(
+ "All Users",
+ TRANSFORMS_PERMISSION_INDEX,
+ "Yes",
+ );
+ });
+ });
+
+ describe("transforms access with permission granted", () => {
+ beforeEach(() => {
+ grantTransformsPermissionToAllGroups();
+ H.setUserAsAnalyst(NORMAL_USER_ID);
+ });
+
+ it("allows user to view transforms list page", () => {
+ cy.signInAsNormalUser();
+ cy.visit("/data-studio/transforms");
+
+ H.DataStudio.Transforms.list().should("be.visible");
+ cy.button("Create a transform").should("be.visible");
+ });
+
+ it("allows user to create a new transform via UI", () => {
+ cy.signInAsNormalUser();
+ cy.visit("/data-studio/transforms");
+
+ cy.button("Create a transform").click();
+ H.popover().findByText("Query builder").click();
+
+ H.miniPicker().within(() => {
+ cy.findByText("Writable Postgres12").click();
+ cy.findByText(TARGET_SCHEMA).click();
+ cy.findByText(SOURCE_TABLE).click();
+ });
+
+ cy.findByTestId("transform-query-editor").button("Save").click();
+ H.modal().within(() => {
+ cy.findByLabelText("Name").clear().type("User Created Transform");
+ cy.findByLabelText("Table name").type(TARGET_TABLE);
+ cy.button("Save").click();
+ });
+
+ cy.wait("@createTransform")
+ .its("response.statusCode")
+ .should("eq", 200);
+ });
+
+ it("allows user to run a transform and view results", () => {
+ cy.signInAsNormalUser();
+
+ H.createAndRunMbqlTransform({
+ sourceTable: SOURCE_TABLE,
+ targetTable: TARGET_TABLE,
+ targetSchema: TARGET_SCHEMA,
+ name: "Permission Test Transform",
+ }).then(({ transformId }) => {
+ H.visitTransform(transformId);
+
+ cy.findByTestId("transform-query-editor").should("be.visible");
+ H.DataStudio.Transforms.runTab().click();
+ cy.findByTestId("run-status")
+ .findByText(/successfully/, { timeout: 10_000 })
+ .should("be.visible");
+ });
+ });
+
+ it("allows user to view an existing transform created by admin", () => {
+ cy.signInAsAdmin();
+ H.createAndRunMbqlTransform({
+ sourceTable: SOURCE_TABLE,
+ targetTable: TARGET_TABLE,
+ targetSchema: TARGET_SCHEMA,
+ name: "Admin Created Transform",
+ }).then(({ transformId }) => {
+ cy.signInAsNormalUser();
+ H.visitTransform(transformId);
+
+ cy.findByTestId("transform-query-editor").should("be.visible");
+ H.DataStudio.Transforms.header()
+ .findByDisplayValue("Admin Created Transform")
+ .should("be.visible");
+ });
+ });
+ });
+
+ describe("transforms with partial access", () => {
+ beforeEach(() => {
+ cy.log(
+ "Grant transforms permission only on Sample Database, not on Writable Postgres",
+ );
+ H.setUserAsAnalyst(NORMAL_USER_ID);
+ cy.updatePermissionsGraph({
+ [ALL_USERS_GROUP]: {
+ [SAMPLE_DB_ID]: {
+ "view-data": DataPermissionValue.UNRESTRICTED,
+ "create-queries": DataPermissionValue.QUERY_BUILDER_AND_NATIVE,
+ transforms: DataPermissionValue.YES,
+ },
+ [WRITABLE_DB_ID]: {
+ "view-data": DataPermissionValue.UNRESTRICTED,
+ "create-queries": DataPermissionValue.QUERY_BUILDER_AND_NATIVE,
+ transforms: DataPermissionValue.NO,
+ },
+ },
+ });
+ });
+
+ it("should prevent users from selecting sources in mini picker and entity picker that they lack the transform permission for", () => {
+ cy.signInAsNormalUser();
+ cy.visit("/data-studio/transforms");
+
+ cy.button("Create a transform").click();
+ H.popover().findByText("Query builder").click();
+
+ cy.log(
+ "Writable Postgres should not be present in mini-picker when user lacks transform permission for it",
+ );
+ H.miniPicker()
+ .findByText(/Writable Postgres/)
+ .should("not.exist");
+ H.miniPickerBrowseAll().click();
+
+ cy.log(
+ "Writable Postgres should be disabled in full data picker when user lacks transform permission for it",
+ );
+ H.entityPickerModalItem(0, "Databases").click();
+ cy.findAllByTestId("picker-item")
+ .contains(/Writable Postgres/)
+ .should("have.attr", "data-disabled", "true");
+ });
+
+ it("should display transform in read-only mode when user lacks transform permission for its data source", () => {
+ cy.signInAsAdmin();
+ H.createAndRunMbqlTransform({
+ sourceTable: SOURCE_TABLE,
+ targetTable: TARGET_TABLE,
+ targetSchema: TARGET_SCHEMA,
+ name: "Read Only Transform",
+ }).then(({ transformId }) => {
+ cy.signInAsNormalUser();
+ H.visitTransform(transformId);
+
+ cy.log(
+ "User can view the transform but cannot edit it because they lack transform permission for Writable Postgres",
+ );
+ cy.findByTestId("data-step-cell").contains("Animals");
+ H.DataStudio.Transforms.header()
+ .findByDisplayValue("Read Only Transform")
+ .should("be.disabled");
+ H.DataStudio.Transforms.editDefinition().should("not.exist");
+ });
+ });
+ });
+
+ describe("transforms access denied without permission", () => {
+ beforeEach(() => {
+ denyTransformsPermissionToAllGroups();
+ H.setUserAsAnalyst(NORMAL_USER_ID, false);
+ });
+
+ it("denies user access to transforms list page", () => {
+ cy.signInAsNormalUser();
+ cy.visit("/data-studio/transforms");
+
+ cy.url().should("include", "/unauthorized");
+ cy.findByRole("img", { name: /key/ }).should("exist");
+ });
+
+ it("denies user access to a specific transform page", () => {
+ cy.signInAsAdmin();
+ H.createAndRunMbqlTransform({
+ sourceTable: SOURCE_TABLE,
+ targetTable: TARGET_TABLE,
+ targetSchema: TARGET_SCHEMA,
+ name: "Admin Only Transform",
+ }).then(({ transformId }) => {
+ cy.signInAsNormalUser();
+ H.visitTransform(transformId);
+
+ cy.url().should("include", "/unauthorized");
+ cy.findByRole("img", { name: /key/ }).should("exist");
+ });
+ });
+
+ it("denies user from creating transforms via API", () => {
+ cy.signInAsNormalUser();
+
+ H.getTableId({ databaseId: WRITABLE_DB_ID, name: SOURCE_TABLE }).then(
+ (tableId) => {
+ cy.request({
+ method: "POST",
+ url: "/api/ee/transform",
+ failOnStatusCode: false,
+ body: {
+ name: "Unauthorized Transform",
+ source: {
+ type: "query",
+ query: {
+ database: WRITABLE_DB_ID,
+ type: "query",
+ query: { "source-table": tableId, limit: 5 },
+ },
+ },
+ target: {
+ type: "table",
+ database: WRITABLE_DB_ID,
+ name: "unauthorized_table",
+ schema: TARGET_SCHEMA,
+ },
+ },
+ }).then((response) => {
+ expect(response.status).to.eq(403);
+ });
+ },
+ );
+ });
+
+ it("denies user from running transforms via API", () => {
+ cy.signInAsAdmin();
+ H.createMbqlTransform({
+ sourceTable: SOURCE_TABLE,
+ targetTable: TARGET_TABLE,
+ targetSchema: TARGET_SCHEMA,
+ name: "Transform to Run",
+ }).then(({ body: transform }) => {
+ cy.signInAsNormalUser();
+
+ cy.request({
+ method: "POST",
+ url: `/api/ee/transform/${transform.id}/run`,
+ failOnStatusCode: false,
+ }).then((response) => {
+ expect(response.status).to.eq(403);
+ });
+ });
+ });
+ });
+
+ describe("permission changes affect access immediately", () => {
+ it("grants access after permission is added", () => {
+ denyTransformsPermissionToAllGroups();
+ H.setUserAsAnalyst(NORMAL_USER_ID, false);
+
+ cy.signInAsNormalUser();
+ cy.visit("/data-studio/transforms");
+ cy.url().should("include", "/unauthorized");
+
+ cy.signInAsAdmin();
+ grantTransformsPermissionToAllGroups();
+ H.setUserAsAnalyst(NORMAL_USER_ID);
+
+ cy.signInAsNormalUser();
+ cy.visit("/data-studio/transforms");
+ getTransformsNavLink().should("be.visible");
+ H.DataStudio.Transforms.list().should("be.visible");
+ });
+
+ it("revokes access after permission is removed", () => {
+ grantTransformsPermissionToAllGroups();
+ H.setUserAsAnalyst(NORMAL_USER_ID);
+
+ cy.signInAsNormalUser();
+ cy.visit("/data-studio/transforms");
+ getTransformsNavLink().should("be.visible");
+
+ cy.signInAsAdmin();
+ denyTransformsPermissionToAllGroups();
+ H.setUserAsAnalyst(NORMAL_USER_ID, false);
+
+ cy.signInAsNormalUser();
+ cy.visit("/data-studio/transforms");
+ cy.url().should("include", "/unauthorized");
+ H.DataStudio.Transforms.list().should("not.exist");
+ });
+ });
+ },
+);
+
+function grantTransformsPermissionToAllGroups() {
+ cy.updatePermissionsGraph({
+ [ALL_USERS_GROUP]: {
+ [WRITABLE_DB_ID]: {
+ "view-data": DataPermissionValue.UNRESTRICTED,
+ "create-queries": DataPermissionValue.QUERY_BUILDER_AND_NATIVE,
+ transforms: DataPermissionValue.YES,
+ },
+ },
+ [COLLECTION_GROUP]: {
+ [WRITABLE_DB_ID]: {
+ "view-data": DataPermissionValue.UNRESTRICTED,
+ "create-queries": DataPermissionValue.QUERY_BUILDER_AND_NATIVE,
+ transforms: DataPermissionValue.YES,
+ },
+ },
+ [DATA_GROUP]: {
+ [WRITABLE_DB_ID]: {
+ "view-data": DataPermissionValue.UNRESTRICTED,
+ "create-queries": DataPermissionValue.QUERY_BUILDER_AND_NATIVE,
+ transforms: DataPermissionValue.YES,
+ },
+ },
+ });
+}
+
+function denyTransformsPermissionToAllGroups() {
+ cy.updatePermissionsGraph({
+ [ALL_USERS_GROUP]: {
+ [WRITABLE_DB_ID]: {
+ "view-data": DataPermissionValue.UNRESTRICTED,
+ "create-queries": DataPermissionValue.QUERY_BUILDER_AND_NATIVE,
+ transforms: DataPermissionValue.NO,
+ },
+ },
+ [COLLECTION_GROUP]: {
+ [WRITABLE_DB_ID]: {
+ "view-data": DataPermissionValue.UNRESTRICTED,
+ "create-queries": DataPermissionValue.QUERY_BUILDER_AND_NATIVE,
+ transforms: DataPermissionValue.NO,
+ },
+ },
+ [DATA_GROUP]: {
+ [WRITABLE_DB_ID]: {
+ "view-data": DataPermissionValue.UNRESTRICTED,
+ "create-queries": DataPermissionValue.QUERY_BUILDER_AND_NATIVE,
+ transforms: DataPermissionValue.NO,
+ },
+ },
+ });
+}
+
+function getTransformsNavLink() {
+ return H.DataStudio.nav().findByRole("link", { name: "Transforms" });
+}
diff --git a/e2e/test/scenarios/permissions/view-data.cy.spec.js b/e2e/test/scenarios/permissions/view-data.cy.spec.js
index 1b81bf677dd..ff60232df81 100644
--- a/e2e/test/scenarios/permissions/view-data.cy.spec.js
+++ b/e2e/test/scenarios/permissions/view-data.cy.spec.js
@@ -158,7 +158,7 @@ describe("scenarios > admin > permissions > view data > granular", () => {
H.selectSidebarItem("All Users");
H.assertPermissionTable([
- ["Sample Database", "Granular", "No", "1 million rows", "No", "No"],
+ ["Sample Database", "Granular", "No", "1 million rows", "No", "No", "No"],
]);
cy.button("Save changes").click();
@@ -191,7 +191,7 @@ describe("scenarios > admin > permissions > view data > granular", () => {
H.selectSidebarItem("All Users");
H.assertPermissionTable([
- ["Sample Database", "Granular", "No", "1 million rows", "No", "No"],
+ ["Sample Database", "Granular", "No", "1 million rows", "No", "No", "No"],
]);
cy.button("Save changes").click();
@@ -221,7 +221,7 @@ describe("scenarios > admin > permissions > view data > granular", () => {
H.selectSidebarItem("All Users");
H.assertPermissionTable([
- ["Sample Database", "Granular", "No", "1 million rows", "No", "No"],
+ ["Sample Database", "Granular", "No", "1 million rows", "No", "No", "No"],
]);
cy.findByTestId("permission-table")
@@ -235,7 +235,7 @@ describe("scenarios > admin > permissions > view data > granular", () => {
H.selectSidebarItem("All Users");
H.assertPermissionTable([
- ["Sample Database", "Can view", "No", "1 million rows", "No", "No"],
+ ["Sample Database", "Can view", "No", "1 million rows", "No", "No", "No"],
]);
});
@@ -276,8 +276,24 @@ describe(
H.savePermissions();
H.assertPermissionTable([
- ["Sample Database", "Can view", "No", "1 million rows", "No", "No"],
- ["QA Postgres12", "Impersonated", "No", "1 million rows", "No", "No"],
+ [
+ "Sample Database",
+ "Can view",
+ "No",
+ "1 million rows",
+ "No",
+ "No",
+ "No",
+ ],
+ [
+ "QA Postgres12",
+ "Impersonated",
+ "No",
+ "1 million rows",
+ "No",
+ "No",
+ "No",
+ ],
]);
// Checking it shows the right state on the tables level
@@ -318,8 +334,24 @@ describe(
H.savePermissions();
H.assertPermissionTable([
- ["Sample Database", "Can view", "No", "1 million rows", "No", "No"],
- ["QA Postgres12", "Impersonated", "No", "1 million rows", "No", "No"],
+ [
+ "Sample Database",
+ "Can view",
+ "No",
+ "1 million rows",
+ "No",
+ "No",
+ "No",
+ ],
+ [
+ "QA Postgres12",
+ "Impersonated",
+ "No",
+ "1 million rows",
+ "No",
+ "No",
+ "No",
+ ],
]);
});
@@ -388,8 +420,16 @@ describe(
// On database level it got reset to Can view too
H.assertPermissionTable([
- ["Sample Database", "Can view", "No", "1 million rows", "No", "No"],
- ["QA Postgres12", "Can view", "No", "1 million rows", "No", "No"],
+ [
+ "Sample Database",
+ "Can view",
+ "No",
+ "1 million rows",
+ "No",
+ "No",
+ "No",
+ ],
+ ["QA Postgres12", "Can view", "No", "1 million rows", "No", "No", "No"],
]);
});
@@ -496,6 +536,7 @@ describe("scenarios > admin > permissions > view data > legacy no self-service",
"1 million rows",
"No",
"No",
+ "No",
],
]);
@@ -533,6 +574,7 @@ describe("scenarios > admin > permissions > view data > legacy no self-service",
"No",
"No",
"No",
+ "No",
],
];
H.assertPermissionTable(finalExpectedRows);
diff --git a/enterprise/backend/src/metabase_enterprise/advanced_permissions/common.clj b/enterprise/backend/src/metabase_enterprise/advanced_permissions/common.clj
index 528f66dd1f3..8f69e8fcc6b 100644
--- a/enterprise/backend/src/metabase_enterprise/advanced_permissions/common.clj
+++ b/enterprise/backend/src/metabase_enterprise/advanced_permissions/common.clj
@@ -1,6 +1,7 @@
(ns metabase-enterprise.advanced-permissions.common
(:require
[metabase.api.common :as api]
+ [metabase.audit-app.core :as audit]
[metabase.permissions.core :as perms]
[metabase.premium-features.core :as premium-features :refer [defenterprise]]
[metabase.remote-sync.core :as remote-sync]
@@ -74,6 +75,9 @@
:can_access_monitoring (perms/set-has-application-permission-of-type? permissions-set :monitoring)
:can_access_data_model can-access-data-model
:can_access_db_details (perms/user-has-any-perms-of-type? user-id :perms/manage-database)
+ :can_access_transforms (or api/*is-superuser?* (and api/*is-data-analyst?*
+ (perms/user-has-any-perms-of-type? api/*current-user-id* :perms/view-data
+ :exclude-db-ids [audit/audit-db-id])))
:is_data_analyst api/*is-data-analyst?*
:is_group_manager api/*is-group-manager?*)))
diff --git a/enterprise/backend/src/metabase_enterprise/dependencies/api.clj b/enterprise/backend/src/metabase_enterprise/dependencies/api.clj
index cf86906654d..cd8125a9608 100644
--- a/enterprise/backend/src/metabase_enterprise/dependencies/api.clj
+++ b/enterprise/backend/src/metabase_enterprise/dependencies/api.clj
@@ -315,13 +315,14 @@
Returns a compound [:or ...] clause checking whether entities at those columns are readable.
Handles different entity types:
- - Superuser-only (:model/Transform, :model/Sandbox): Only if api/*is-superuser?* is true
+ - Superuser-only (:model/Sandbox): Only if api/*is-superuser?* is true
- Collection-based (:model/Card, :model/Dashboard, :model/Document, :model/NativeQuerySnippet):
Uses collection/visible-collection-filter-clause for collection filtering and adds archived entity filtering.
Native query snippets have additional restrictions for sandboxed users.
- Table: Uses perms/visible-table-filter-select with appropriate permissions and filters by active/visibility_type.
Follows search API conventions: active=true AND visibility_type=nil for non-archived tables.
- Note: archived_at is not checked separately as archived tables always have active=false."
+ Note: archived_at is not checked separately as archived tables always have active=false.
+ - Transform: Analysts can view any transform they have source view permission to."
([entity-type-field entity-id-field]
(visible-entities-filter-clause entity-type-field entity-id-field nil))
([entity-type-field entity-id-field {:keys [include-archived-items] :or {include-archived-items :exclude}}]
@@ -330,13 +331,33 @@
(let [table-name (t2/table-name model)
id-column (keyword (name table-name) "id")]
(case model
- ;; Superuser-only entities
- (:model/Transform :model/Sandbox)
+ ;; Sandbox is superuser-only
+ :model/Sandbox
(when api/*is-superuser?*
[:and
[:= entity-type-field (name entity-type)]
[:in entity-id-field {:select [:id] :from [table-name]}]])
+ :model/Transform
+ (cond
+ api/*is-superuser?*
+ [:and
+ [:= entity-type-field (name entity-type)]
+ [:in entity-id-field {:select [:id] :from [table-name]}]]
+
+ api/*is-data-analyst?*
+ [:and
+ [:= entity-type-field (name entity-type)]
+ [:in entity-id-field
+ {:select [:id]
+ :from [table-name]
+ :where [:in :source_database_id
+ (perms/visible-database-filter-select
+ {:user-id api/*current-user-id*
+ :is-superuser? api/*is-superuser?*
+ :is-data-analyst? api/*is-data-analyst?*}
+ {:perms/create-queries [:query-builder :query-builder-and-native]})]}]])
+
;; Collection-based entities with archived field
(:model/Card :model/Dashboard :model/Document :model/NativeQuerySnippet)
(let [archived-column (keyword (name table-name) "archived")]
@@ -347,41 +368,41 @@
[:and
[:= entity-type-field (name entity-type)]
[:in entity-id-field {:select [:id]
- :from [table-name]
- :where [:and
- ;; Filter by collection visibility
- (collection/visible-collection-filter-clause
- (keyword (name table-name) "collection_id")
- {:include-archived-items include-archived-items}
- {:current-user-id api/*current-user-id*
- :is-superuser? api/*is-superuser?*})
- ;; Filter by entity archived status
- (case include-archived-items
- :exclude [:= archived-column false]
- :only [:= archived-column true]
- :all nil)]}]]))
+ :from [table-name]
+ :where [:and
+ ;; Filter by collection visibility
+ (collection/visible-collection-filter-clause
+ (keyword (name table-name) "collection_id")
+ {:include-archived-items include-archived-items}
+ {:current-user-id api/*current-user-id*
+ :is-superuser? api/*is-superuser?*})
+ ;; Filter by entity archived status
+ (case include-archived-items
+ :exclude [:= archived-column false]
+ :only [:= archived-column true]
+ :all nil)]}]]))
;; Table with visible-filter-clause and active/visibility_type filtering
:model/Table
- (let [active-column (keyword (name table-name) "active")
+ (let [active-column (keyword (name table-name) "active")
visibility-type-column (keyword (name table-name) "visibility_type")]
[:and
[:= entity-type-field (name entity-type)]
[:in entity-id-field {:select [:id]
- :from [table-name]
- :where [:and
- [:in id-column
- (perms/visible-table-filter-select
- :id
- {:user-id api/*current-user-id*
- :is-superuser? api/*is-superuser?*}
- {:perms/view-data :unrestricted
- :perms/create-queries :query-builder})]
- (case include-archived-items
- :exclude [:and
- [:= active-column true]
- [:= visibility-type-column nil]]
- (:only :all) nil)]}]])
+ :from [table-name]
+ :where [:and
+ [:in id-column
+ (perms/visible-table-filter-select
+ :id
+ {:user-id api/*current-user-id*
+ :is-superuser? api/*is-superuser?*}
+ {:perms/view-data :unrestricted
+ :perms/create-queries :query-builder})]
+ (case include-archived-items
+ :exclude [:and
+ [:= active-column true]
+ [:= visibility-type-column nil]]
+ (:only :all) nil)]}]])
;; Segment/Measure with table permissions and archived filtering
(:model/Segment :model/Measure)
@@ -390,27 +411,27 @@
[:and
[:= entity-type-field (name entity-type)]
[:in entity-id-field {:select [:id]
- :from [table-name]
- :where [:and
- ;; Check that user can see the table this entity belongs to
- [:in table-id-column
- {:select [:metabase_table.id]
- :from [:metabase_table]
- ;; using this clause because we had to change the mi/visible-filter-clause
- ;; to allow returning CTE based filters
- ;; TODO(ed 2025-12-16: support using CTES in filters in dependency graph)
- :where [:in :metabase_table.id
- (perms/visible-table-filter-select
- :id
- {:user-id api/*current-user-id*
- :is-superuser? api/*is-superuser?*}
- {:perms/view-data :unrestricted
- :perms/create-queries :query-builder})]}]
- ;; Filter by archived status
- (case include-archived-items
- :exclude [:= archived-column false]
- :only [:= archived-column true]
- :all nil)]}]])))))
+ :from [table-name]
+ :where [:and
+ ;; Check that user can see the table this entity belongs to
+ [:in table-id-column
+ {:select [:metabase_table.id]
+ :from [:metabase_table]
+ ;; using this clause because we had to change the mi/visible-filter-clause
+ ;; to allow returning CTE based filters
+ ;; TODO(ed 2025-12-16: support using CTES in filters in dependency graph)
+ :where [:in :metabase_table.id
+ (perms/visible-table-filter-select
+ :id
+ {:user-id api/*current-user-id*
+ :is-superuser? api/*is-superuser?*}
+ {:perms/view-data :unrestricted
+ :perms/create-queries :query-builder})]}]
+ ;; Filter by archived status
+ (case include-archived-items
+ :exclude [:= archived-column false]
+ :only [:= archived-column true]
+ :all nil)]}]])))))
deps.dependency-types/dependency-type->model)))
(defn- broken-entities-filter-clause
diff --git a/enterprise/backend/src/metabase_enterprise/transforms/api.clj b/enterprise/backend/src/metabase_enterprise/transforms/api.clj
index 95f4757c173..ac82c57e5fc 100644
--- a/enterprise/backend/src/metabase_enterprise/transforms/api.clj
+++ b/enterprise/backend/src/metabase_enterprise/transforms/api.clj
@@ -20,6 +20,7 @@
[metabase.driver.util :as driver.u]
[metabase.events.core :as events]
[metabase.lib.core :as lib]
+ [metabase.models.interface :as mi]
[metabase.query-processor.compile :as qp.compile]
[metabase.query-processor.schema :as qp.schema]
[metabase.request.core :as request]
@@ -49,6 +50,10 @@
(mr/def ::run-trigger
[:enum "none" "global-schedule"])
+(defn- check-is-data-analyst
+ []
+ (api/check-403 (or api/*is-superuser?* api/*is-data-analyst?*)))
+
(defn- python-source-table-ref->table-id
"Change source of python transform from name->table-ref to name->table-id.
@@ -96,15 +101,16 @@
(defn get-transforms
"Get a list of transforms."
[& {:keys [last_run_start_time last_run_statuses tag_ids]}]
- (api/check-superuser)
+ (check-is-data-analyst)
(let [transforms (t2/select :model/Transform {:order-by [[:id :asc]]})]
- (into []
- (comp (transforms.util/->date-field-filter-xf [:last_run :start_time] last_run_start_time)
- (transforms.util/->status-filter-xf [:last_run :status] last_run_statuses)
- (transforms.util/->tag-filter-xf [:tag_ids] tag_ids)
- (map #(update % :last_run transforms.util/localize-run-timestamps))
- (map python-source-table-ref->table-id))
- (t2/hydrate transforms :last_run :transform_tag_ids :creator :owner))))
+ (->> (t2/hydrate transforms :last_run :transform_tag_ids :creator :owner)
+ (into []
+ (comp (transforms.util/->date-field-filter-xf [:last_run :start_time] last_run_start_time)
+ (transforms.util/->status-filter-xf [:last_run :status] last_run_statuses)
+ (transforms.util/->tag-filter-xf [:tag_ids] tag_ids)
+ (map #(update % :last_run transforms.util/localize-run-timestamps))
+ (map python-source-table-ref->table-id)))
+ transforms.util/add-source-readable)))
;; TODO (Cam 10/28/25) -- fix this endpoint so it uses kebab-case for query parameters for consistency with the rest
;; of the REST API
@@ -243,7 +249,9 @@
;; Return with hydrated tag_ids
(t2/hydrate transform :transform_tag_ids :creator :owner)))]
(events/publish-event! :event/transform-create {:object transform :user-id api/*current-user-id*})
- (python-source-table-ref->table-id transform)))
+ (-> transform
+ python-source-table-ref->table-id
+ transforms.util/add-source-readable)))
(defn get-transform
"Get a specific transform."
@@ -254,7 +262,8 @@
(t2/hydrate :last_run :transform_tag_ids :creator :owner)
(u/update-some :last_run transforms.util/localize-run-timestamps)
(assoc :table target-table)
- python-source-table-ref->table-id)))
+ python-source-table-ref->table-id
+ transforms.util/add-source-readable)))
;; TODO (Cam 2025-11-25) please add a response schema to this API endpoint, it makes it easier for our customers to
;; use our API + we will need it when we make auto-TypeScript-signature generation happen
@@ -277,9 +286,11 @@
(api/read-check :model/Transform id)
(let [id->transform (t2/select-pk->fn identity :model/Transform)
global-ordering (transforms.ordering/transform-ordering (vals id->transform))
- dep-ids (get global-ordering id)
- dependencies (map id->transform dep-ids)]
- (mapv python-source-table-ref->table-id (t2/hydrate dependencies :creator :owner))))
+ dep-ids (get global-ordering id)
+ dependencies (map id->transform dep-ids)]
+ (->> (t2/hydrate dependencies :creator :owner)
+ (mapv python-source-table-ref->table-id)
+ transforms.util/add-source-readable)))
;; TODO (Cam 10/28/25) -- fix this endpoint so it uses kebab-case for query parameters for consistency with the rest
;; of the REST API
@@ -302,7 +313,7 @@
[:start_time {:optional true} [:maybe ms/NonBlankString]]
[:end_time {:optional true} [:maybe ms/NonBlankString]]
[:run_methods {:optional true} [:maybe (ms/QueryVectorOf [:enum "manual" "cron"])]]]]
- (api/check-superuser)
+ (check-is-data-analyst)
(-> (transform-run/paged-runs (assoc query-params
:offset (request/offset)
:limit (request/limit)))
@@ -333,6 +344,8 @@
(let [old (t2/select-one :model/Transform id)
new (merge old body)
target-fields #(-> % :target (select-keys [:schema :name]))]
+ (api/check-403 (and (mi/can-write? old) (mi/can-write? new)))
+
;; we must validate on a full transform object
(check-feature-enabled! new)
(check-database-feature new)
@@ -351,7 +364,9 @@
(transform.model/update-transform-tags! id (:tag_ids body)))
(t2/hydrate (t2/select-one :model/Transform id) :transform_tag_ids :creator :owner))]
(events/publish-event! :event/transform-update {:object transform :user-id api/*current-user-id*})
- (python-source-table-ref->table-id transform)))
+ (-> transform
+ python-source-table-ref->table-id
+ transforms.util/add-source-readable)))
;; TODO (Cam 2025-11-25) please add a response schema to this API endpoint, it makes it easier for our customers to
;; use our API + we will need it when we make auto-TypeScript-signature generation happen
@@ -389,7 +404,7 @@
[{:keys [id]} :- [:map
[:id ms/PositiveInt]]]
(let [transform (api/write-check :model/Transform id)
- run (api/check-404 (transform-run/running-run-for-transform-id id))]
+ run (api/check-404 (transform-run/running-run-for-transform-id id))]
(transform-run-cancelation/mark-cancel-started-run! (:id run))
(when (transforms.util/python-transform? transform)
(transforms.canceling/cancel-run! (:id run))))
diff --git a/enterprise/backend/src/metabase_enterprise/transforms/api/transform_job.clj b/enterprise/backend/src/metabase_enterprise/transforms/api/transform_job.clj
index 79f89f377fd..0514db65c65 100644
--- a/enterprise/backend/src/metabase_enterprise/transforms/api/transform_job.clj
+++ b/enterprise/backend/src/metabase_enterprise/transforms/api/transform_job.clj
@@ -8,6 +8,7 @@
[metabase.api.common :as api]
[metabase.api.macros :as api.macros]
[metabase.api.routes.common :refer [+auth]]
+ [metabase.models.interface :as mi]
[metabase.util.i18n :refer [deferred-tru]]
[metabase.util.jvm :as u.jvm]
[metabase.util.log :as log]
@@ -37,7 +38,6 @@
(ms/enum-decode-keyword ui-display-types)]
[:tag_ids {:optional true} [:sequential ms/PositiveInt]]]]
(log/info "Creating transform job:" name "with schedule:" schedule)
- (api/check-superuser)
;; Validate cron expression
(api/check-400 (transforms.schedule/validate-cron-expression schedule)
(deferred-tru "Invalid cron expression: {0}" schedule))
@@ -46,11 +46,13 @@
(let [existing-tags (set (t2/select-pks-vec :model/TransformTag :id [:in tag_ids]))]
(api/check-400 (= (set tag_ids) existing-tags)
(deferred-tru "Some tag IDs do not exist"))))
- (let [job (t2/insert-returning-instance! :model/TransformJob
- {:name name
- :description description
- :schedule schedule
- :ui_display_type ui_display_type})]
+ (let [job-data {:name name
+ :description description
+ :schedule schedule
+ :ui_display_type ui_display_type}
+ _ (api/check-403 (mi/can-create? :model/TransformJob (assoc job-data :tag_ids tag_ids)))
+ job (t2/insert-returning-instance! :model/TransformJob
+ job-data)]
(transforms.schedule/initialize-job! job)
;; Add tag associations if provided
(when (seq tag_ids)
@@ -82,8 +84,11 @@
(ms/enum-decode-keyword ui-display-types)]
[:tag_ids {:optional true} [:sequential ms/PositiveInt]]]]
(log/info "Updating transform job" job-id)
- (api/check-superuser)
- (api/check-404 (t2/select-one :model/TransformJob :id job-id))
+ (let [existing-job (t2/hydrate (t2/select-one :model/TransformJob :id job-id) :tag_ids)]
+ ;; Check write permission on both current state and final state (with new tags if provided)
+ (api/write-check existing-job)
+ (when (some? tag-ids)
+ (api/write-check (assoc existing-job :tag_ids tag-ids))))
;; Validate cron expression if provided
(when schedule
(api/check-400 (transforms.schedule/validate-cron-expression schedule)
@@ -117,8 +122,7 @@
"Delete a transform job."
[{:keys [job-id]} :- [:map [:job-id ms/PositiveInt]]]
(log/info "Deleting transform job" job-id)
- (api/check-superuser)
- (api/check-404 (t2/select-one :model/TransformJob :id job-id))
+ (api/write-check (t2/hydrate (t2/select-one :model/TransformJob :id job-id) :tag_ids))
(t2/delete! :model/TransformJob :id job-id)
(transforms.schedule/delete-job! job-id)
api/generic-204-no-content)
@@ -131,8 +135,7 @@
"Run a transform job manually."
[{:keys [job-id]} :- [:map [:job-id ms/PositiveInt]]]
(log/info "Manual run of transform job" job-id)
- (api/check-superuser)
- (api/check-404 (t2/select-one :model/TransformJob :id job-id))
+ (api/write-check (t2/select-one :model/TransformJob :id job-id))
(u.jvm/in-virtual-thread*
(try
(transforms.jobs/run-job! job-id {:run-method :manual
@@ -152,9 +155,8 @@
[{:keys [job-id]} :- [:map
[:job-id ms/PositiveInt]]]
(log/info "Getting transform job" job-id)
- (api/check-superuser)
- (let [job (api/check-404 (t2/select-one :model/TransformJob :id job-id))]
- (t2/hydrate job :tag_ids :last_run)))
+ (-> (api/read-check (t2/select-one :model/TransformJob :id job-id))
+ (t2/hydrate :tag_ids :last_run)))
(defn- add-next-run
[{id :id :as job}]
@@ -171,10 +173,11 @@
[{:keys [job-id]} :- [:map
[:job-id ms/PositiveInt]]]
(log/info "Getting the transforms of transform job" job-id)
- (api/check-superuser)
(api/check-404 (t2/select-one-pk :model/TransformJob :id job-id))
(-> (transforms.jobs/job-transforms job-id)
- (t2/hydrate :creator)))
+ (#(do (api/check-403 (every? mi/can-read? %)) %))
+ (t2/hydrate :creator)
+ transforms.util/add-source-readable))
;; TODO (Cam 10/28/25) -- fix this endpoint so it uses kebab-case for query parameters for consistency with the rest
;; of the REST API
@@ -194,7 +197,7 @@
[:last_run_statuses {:optional true} [:maybe (ms/QueryVectorOf [:enum "started" "succeeded" "failed" "timeout"])]]
[:tag_ids {:optional true} [:maybe (ms/QueryVectorOf ms/IntGreaterThanOrEqualToZero)]]]]
(log/info "Getting all transform jobs")
- (api/check-superuser)
+ (api/check-403 (or api/*is-superuser?* api/*is-data-analyst?*))
(let [jobs (t2/select :model/TransformJob {:order-by [[:created_at :desc]]})]
(into []
(comp (map add-next-run)
diff --git a/enterprise/backend/src/metabase_enterprise/transforms/api/transform_tag.clj b/enterprise/backend/src/metabase_enterprise/transforms/api/transform_tag.clj
index 6b320f6bf64..6ed00dd18c7 100644
--- a/enterprise/backend/src/metabase_enterprise/transforms/api/transform_tag.clj
+++ b/enterprise/backend/src/metabase_enterprise/transforms/api/transform_tag.clj
@@ -4,6 +4,7 @@
[metabase.api.common :as api]
[metabase.api.macros :as api.macros]
[metabase.api.routes.common :refer [+auth]]
+ [metabase.models.interface :as mi]
[metabase.util.i18n :refer [deferred-tru]]
[metabase.util.log :as log]
[metabase.util.malli.schema :as ms]
@@ -22,7 +23,7 @@
{:keys [name]} :- [:map
[:name ms/NonBlankString]]]
(log/info "Creating transform tag:" name)
- (api/check-superuser)
+ (api/check-403 (mi/can-create? :model/TransformTag {:name name}))
(api/check-400 (not (transform-tag/tag-name-exists? name))
(deferred-tru "A tag with the name ''{0}'' already exists." name))
(t2/insert-returning-instance! :model/TransformTag {:name name}))
@@ -39,8 +40,7 @@
{:keys [name]} :- [:map
[:name ms/NonBlankString]]]
(log/info "Updating transform tag" tag-id "with name:" name)
- (api/check-superuser)
- (api/check-404 (t2/select-one :model/TransformTag :id tag-id))
+ (api/write-check (t2/select-one :model/TransformTag :id tag-id))
(api/check-400 (not (transform-tag/tag-name-exists-excluding? name tag-id))
(deferred-tru "A tag with the name ''{0}'' already exists." name))
(t2/update! :model/TransformTag tag-id {:name name})
@@ -55,8 +55,7 @@
[{:keys [tag-id]} :- [:map
[:tag-id ms/PositiveInt]]]
(log/info "Deleting transform tag" tag-id)
- (api/check-superuser)
- (api/check-404 (t2/select-one :model/TransformTag :id tag-id))
+ (api/write-check (t2/select-one :model/TransformTag :id tag-id))
(t2/delete! :model/TransformTag :id tag-id)
api/generic-204-no-content)
@@ -69,8 +68,8 @@
[_route-params
_query-params]
(log/info "Getting all transform tags")
- (api/check-superuser)
- (t2/select :model/TransformTag {:order-by [[:name :asc]]}))
+ (api/check-403 (or api/*is-superuser?* api/*is-data-analyst?*))
+ (t2/hydrate (t2/select :model/TransformTag {:order-by [[:name :asc]]}) :can_run))
(def ^{:arglists '([request respond raise])} routes
"`/api/ee/transform-tag` routes."
diff --git a/enterprise/backend/src/metabase_enterprise/transforms/core.clj b/enterprise/backend/src/metabase_enterprise/transforms/core.clj
index 291c32de03d..531a86853cb 100644
--- a/enterprise/backend/src/metabase_enterprise/transforms/core.clj
+++ b/enterprise/backend/src/metabase_enterprise/transforms/core.clj
@@ -17,7 +17,8 @@
python-transform?
query-transform?
transform-source-database
- transform-type]
+ transform-type
+ has-db-transforms-permission?]
[metabase-enterprise.transforms.models.transform-run
timeout-run!])
diff --git a/enterprise/backend/src/metabase_enterprise/transforms/models/transform.clj b/enterprise/backend/src/metabase_enterprise/transforms/models/transform.clj
index 3193c0d42d4..ea48b8a3b9b 100644
--- a/enterprise/backend/src/metabase_enterprise/transforms/models/transform.clj
+++ b/enterprise/backend/src/metabase_enterprise/transforms/models/transform.clj
@@ -5,6 +5,7 @@
[metabase-enterprise.transforms.interface :as transforms.i]
[metabase-enterprise.transforms.models.transform-run :as transform-run]
[metabase-enterprise.transforms.util :as transforms.util]
+ [metabase.api.common :as api]
[metabase.collections.models.collection :as collection]
[metabase.events.core :as events]
[metabase.lib-be.core :as lib-be]
@@ -26,24 +27,42 @@
(doseq [trait [:metabase/model :hook/entity-id :hook/timestamped?]]
(derive :model/Transform trait))
-;; Only superusers can access transforms, and writes/creates are blocked globally in remote-sync read-only mode
(defmethod mi/can-read? :model/Transform
- ([_instance]
- (mi/superuser?))
- ([model pk]
- (mi/can-read? (t2/select-one model pk))))
+ ([instance]
+ (or api/*is-superuser?*
+ (and api/*is-data-analyst?*
+ (transforms.util/source-tables-readable? instance))))
+ ([_model pk]
+ (when-let [transform (t2/select-one :model/Transform :id pk)]
+ (mi/can-read? transform))))
(defmethod mi/can-write? :model/Transform
- ([_instance]
- (and (mi/superuser?)
+ ([instance]
+ (and (mi/can-read? instance)
+ (transforms.util/has-db-transforms-permission? api/*current-user-id* (:source_database_id instance))
(remote-sync/transforms-editable?)))
+ ([_model pk]
+ (when-let [transform (t2/select-one :model/Transform :id pk)]
+ (mi/can-write? transform))))
+
+;; Users who can read the transform can also query it. This is a duplicate, but keeps things explicit.
+(defmethod mi/can-query? :model/Transform
+ ([instance]
+ (mi/can-read? instance))
([model pk]
- (mi/can-write? (t2/select-one model pk))))
+ (mi/can-read? model pk)))
(defmethod mi/can-create? :model/Transform
- [_model _instance]
- (and (mi/superuser?)
- (remote-sync/transforms-editable?)))
+ [_model instance]
+ ;; Inline can-write? logic since instance is a plain map without model metadata.
+ ;; can-write? requires: can-read?, has-db-transforms-permission?, and transforms-editable?
+ ;; can-read? requires: is-superuser? OR (is-data-analyst? AND source-tables-readable?)
+ (let [source-db-id (or (:source_database_id instance) (transforms.i/source-db-id instance))]
+ (and (or api/*is-superuser?*
+ (and api/*is-data-analyst?*
+ (transforms.util/source-tables-readable? instance)))
+ (transforms.util/has-db-transforms-permission? api/*current-user-id* source-db-id)
+ (remote-sync/transforms-editable?))))
(defn- keywordize-source-table-refs
"Keywordize keys in source-tables map values (refs are maps, ints pass through)."
@@ -76,19 +95,23 @@
#{:transforms})
(t2/define-before-insert :model/Transform
- [{:keys [source collection_id] :as transform}]
+ [{:keys [source collection_id source_database_id] :as transform}]
(collection/check-collection-namespace :model/Transform collection_id)
(when collection_id
(collection/check-allowed-content :model/Transform collection_id))
- (assoc transform :source_type (transforms.util/transform-source-type source)))
+ (assoc transform
+ :source_type (transforms.util/transform-source-type source)
+ :source_database_id (or source_database_id (transforms.i/source-db-id transform))))
(t2/define-before-update :model/Transform
- [{:keys [source] :as transform}]
+ [{:keys [source source_database_id] :as transform}]
(when-let [new-collection (:collection_id (t2/changes transform))]
(collection/check-collection-namespace :model/Transform new-collection)
(collection/check-allowed-content :model/Transform new-collection))
(if source
- (assoc transform :source_type (transforms.util/transform-source-type source))
+ (assoc transform
+ :source_type (transforms.util/transform-source-type source)
+ :source_database_id (or source_database_id (transforms.i/source-db-id transform)))
transform))
(t2/define-after-select :model/Transform
@@ -275,21 +298,24 @@
[_model-name opts]
{:copy [:name :description :entity_id :owner_email]
:skip [:dependency_analysis_version :source_type]
- :transform {:created_at (serdes/date)
- :creator_id (serdes/fk :model/User)
- :owner_user_id (serdes/fk :model/User)
- :collection_id (serdes/fk :model/Collection)
- :source {:export #(update % :query serdes/export-mbql)
- :import #(update % :query serdes/import-mbql)}
- :target {:export serdes/export-mbql :import serdes/import-mbql}
- :tags (serdes/nested :model/TransformTransformTag :transform_id opts)}})
+ :transform {:created_at (serdes/date)
+ :creator_id (serdes/fk :model/User)
+ :collection_id (serdes/fk :model/Collection)
+ :owner_user_id (serdes/fk :model/User)
+ :source_database_id (serdes/fk :model/Database :name)
+ :source {:export #(update % :query serdes/export-mbql)
+ :import #(update % :query serdes/import-mbql)}
+ :target {:export serdes/export-mbql :import serdes/import-mbql}
+ :tags (serdes/nested :model/TransformTransformTag :transform_id opts)}})
(defmethod serdes/dependencies "Transform"
- [{:keys [collection_id source tags]}]
+ [{:keys [collection_id source tags source_database_id]}]
(set
(concat
(when collection_id
[[{:model "Collection" :id collection_id}]])
+ (when source_database_id
+ [[{:model "Database" :id source_database_id}]])
(for [{tag-id :tag_id} tags]
[{:model "TransformTag" :id tag-id}])
(serdes/mbql-deps source))))
@@ -320,14 +346,15 @@
(when query-text
(subs query-text 0 (min (count query-text) search/max-searchable-value-length)))))
-(defn- extract-transform-db-id
- "Return the database ID from transform source; else nil."
- [{:keys [source]}]
- (let [parsed-source (transform-source-out source)]
- (case (:type parsed-source)
- :query (get-in parsed-source [:query :database])
- :python (parsed-source :source-database)
- nil)))
+(defn transforms-with-tags
+ "Returns all transforms associated with the given tag IDs.
+ Return empty list if no tag IDs are provided or no transforms are associated with the tags."
+ [tag-ids]
+ (or (when (seq tag-ids)
+ (when-let [transform-ids (t2/select-fn-set :transform_id [:model/TransformTransformTag :transform_id]
+ :tag_id [:in tag-ids])]
+ (t2/select :model/Transform :id [:in transform-ids])))
+ []))
;;; ------------------------------------------------- Search ---------------------------------------------------
@@ -342,8 +369,7 @@
:view-count false
:native-query {:fn maybe-extract-transform-query-text
:fields [:source :source_type]}
- :database-id {:fn extract-transform-db-id
- :fields [:source]}}
+ :database-id :source_database_id}
:search-terms [:name :description]
:render-terms {:transform-name :name
:transform-id :id}})
diff --git a/enterprise/backend/src/metabase_enterprise/transforms/models/transform_job.clj b/enterprise/backend/src/metabase_enterprise/transforms/models/transform_job.clj
index de4547c34c8..883afe6e56c 100644
--- a/enterprise/backend/src/metabase_enterprise/transforms/models/transform_job.clj
+++ b/enterprise/backend/src/metabase_enterprise/transforms/models/transform_job.clj
@@ -3,6 +3,8 @@
[clojure.set :as set]
[medley.core :as m]
[metabase-enterprise.transforms.models.job-run :as transforms.job-run]
+ [metabase-enterprise.transforms.models.transform :as transform]
+ [metabase.api.common :as api]
[metabase.models.interface :as mi]
[metabase.models.serialization :as serdes]
[metabase.util :as u]
@@ -20,6 +22,39 @@
(t2/deftransforms :model/TransformJob
{:ui_display_type mi/transform-keyword})
+(defmethod mi/can-read? :model/TransformJob
+ ([_instance]
+ (or api/*is-superuser?* api/*is-data-analyst?*))
+ ([_model _pk]
+ (or api/*is-superuser?* api/*is-data-analyst?*)))
+
+(defmethod mi/can-write? :model/TransformJob
+ ([instance]
+ (or api/*is-superuser?*
+ (and api/*is-data-analyst?*
+ (let [transforms (or (:transforms instance)
+ (when-let [tag-ids (seq (:tag_ids instance))]
+ (transform/transforms-with-tags tag-ids)))]
+ (if (seq transforms)
+ (every? mi/can-write? transforms)
+ true)))))
+ ([_model pk]
+ (when-let [job (t2/select-one :model/TransformJob :id pk)]
+ (mi/can-write? job))))
+
+(defmethod mi/can-create? :model/TransformJob
+ [_model instance]
+ (or api/*is-superuser?*
+ (and api/*is-data-analyst?*
+ ;; Support batch hydration: check pre-hydrated :transforms first,
+ ;; then fall back to looking up transforms from :tag_ids
+ (let [transforms (or (:transforms instance)
+ (when-let [tag-ids (seq (:tag_ids instance))]
+ (transform/transforms-with-tags tag-ids)))]
+ (if (seq transforms)
+ (every? mi/can-write? transforms)
+ true)))))
+
(mi/define-batched-hydration-method tag-ids
:tag_ids
"Hydrate tag IDs for jobs, preserving order defined by position"
diff --git a/enterprise/backend/src/metabase_enterprise/transforms/models/transform_tag.clj b/enterprise/backend/src/metabase_enterprise/transforms/models/transform_tag.clj
index d789e030815..6683be40c95 100644
--- a/enterprise/backend/src/metabase_enterprise/transforms/models/transform_tag.clj
+++ b/enterprise/backend/src/metabase_enterprise/transforms/models/transform_tag.clj
@@ -1,5 +1,7 @@
(ns metabase-enterprise.transforms.models.transform-tag
(:require
+ [metabase-enterprise.transforms.models.transform :as transform]
+ [metabase.api.common :as api]
[metabase.events.core :as events]
[metabase.models.interface :as mi]
[metabase.models.serialization :as serdes]
@@ -14,6 +16,26 @@
(derive :hook/entity-id)
(derive :hook/timestamped?))
+(defmethod mi/can-read? :model/TransformTag
+ ([_instance]
+ (or api/*is-superuser?* api/*is-data-analyst?*))
+ ([_model _pk]
+ (or api/*is-superuser?* api/*is-data-analyst?*)))
+
+(defmethod mi/can-write? :model/TransformTag
+ ([instance]
+ (or api/*is-superuser?*
+ (and api/*is-data-analyst?*
+ (let [transforms (transform/transforms-with-tags [(:id instance)])]
+ (every? mi/can-write? transforms)))))
+ ([_model pk]
+ (when-let [tag (t2/select-one :model/TransformTag :id pk)]
+ (mi/can-write? tag))))
+
+(defmethod mi/can-create? :model/TransformTag
+ [_model _instance]
+ (or api/*is-superuser?* api/*is-data-analyst?*))
+
(defn tag-name-exists?
"Check if a tag with the given name already exists"
[tag-name]
@@ -46,6 +68,32 @@
(t2/changes tag)) ;; include user edits
(update :name str)))) ;; convert deferred to string
+(methodical/defmethod t2/batched-hydrate [:model/TransformTag :can_run]
+ "Add :can_run to transform tags. Returns true if all transforms associated with the tag can be written by the current user."
+ [_model _k tags]
+ (if-not (seq tags)
+ tags
+ (let [tag-ids (into #{} (map :id) tags)
+ ;; Get all transform-tag associations
+ associations (t2/select [:model/TransformTransformTag :tag_id :transform_id]
+ :tag_id [:in tag-ids])
+ ;; Get unique transform IDs
+ transform-ids (into #{} (map :transform_id) associations)
+ ;; Fetch transforms and check can-write? for each
+ transforms (when (seq transform-ids)
+ (t2/select :model/Transform :id [:in transform-ids]))
+ transform-id->can-write (into {} (map (juxt :id mi/can-write?)) transforms)
+ ;; Build tag-id -> can_run map
+ tag-id->transform-ids (reduce (fn [acc {:keys [tag_id transform_id]}]
+ (update acc tag_id (fnil conj #{}) transform_id))
+ {}
+ associations)
+ tag-id->can-run (into {}
+ (map (fn [[tag-id tform-ids]]
+ [tag-id (every? #(get transform-id->can-write % false) tform-ids)]))
+ tag-id->transform-ids)]
+ (mapv #(assoc % :can_run (get tag-id->can-run (:id %) true)) tags))))
+
(defmethod serdes/hash-fields :model/TransformTag
[_tt]
[:name :built_in_type])
diff --git a/enterprise/backend/src/metabase_enterprise/transforms/util.clj b/enterprise/backend/src/metabase_enterprise/transforms/util.clj
index e0e75e438fe..f9b43fbbb7a 100644
--- a/enterprise/backend/src/metabase_enterprise/transforms/util.clj
+++ b/enterprise/backend/src/metabase_enterprise/transforms/util.clj
@@ -20,6 +20,8 @@
[metabase.lib.metadata :as lib.metadata]
[metabase.lib.query :as lib.query]
[metabase.lib.schema.common :as lib.schema.common]
+ [metabase.models.interface :as mi]
+ [metabase.permissions.core :as perms]
[metabase.premium-features.core :as premium-features :refer [defenterprise]]
[metabase.query-processor :as qp]
[metabase.query-processor.compile :as qp.compile]
@@ -111,6 +113,65 @@
(premium-features/has-feature? :transforms-python))
(premium-features/has-feature? :transforms)))
+(defenterprise has-db-transforms-permission?
+ "Returns true if the given user has the transforms permission for the given source db."
+ :feature :transforms
+ [user-id database-id]
+ (or (perms/is-superuser? user-id)
+ (perms/user-has-permission-for-database? user-id
+ :perms/transforms
+ :yes
+ database-id)))
+
+(defenterprise has-any-transforms-permission?
+ "Returns true if the current user has the transforms permission for _any_ source db."
+ :feature :transforms
+ [user-id]
+ (or (perms/is-superuser? user-id)
+ (perms/user-has-any-perms-of-type? user-id :perms/transforms)))
+
+(defn source-tables-readable?
+ "Check if the source tables/database in a transform are readable by the current user.
+ Returns true if the user can query all source tables (for python transforms) or the
+ source database (for query transforms)."
+ [transform]
+ (let [source (:source transform)]
+ (case (keyword (:type source))
+ :query
+ (if-let [db-id (get-in source [:query :database])]
+ (boolean (mi/can-query? (t2/select-one :model/Database db-id)))
+ false)
+
+ :python
+ (let [source-tables (:source-tables source)]
+ (if (empty? source-tables)
+ true
+ (let [table-ids (into []
+ (comp (map val)
+ (map #(cond
+ (int? %) %
+ (map? %) (:table_id %)
+ :else nil))
+ (filter some?))
+ source-tables)]
+ (and (seq table-ids)
+ (every? (fn [table-id]
+ (when-let [table (t2/select-one :model/Table table-id)]
+ (mi/can-query? table)))
+ table-ids)))))
+
+ (throw (ex-info (str "Unknown transform source type: " (:type source)) {})))))
+
+(defn add-source-readable
+ "Add :source_readable field to a transform or collection of transforms.
+ The field indicates whether the current user can read the source tables/database
+ referenced by the transform."
+ [transform-or-transforms]
+ (if (sequential? transform-or-transforms)
+ (mapv #(assoc % :source_readable (source-tables-readable? %))
+ transform-or-transforms)
+ (assoc transform-or-transforms :source_readable (source-tables-readable? transform-or-transforms))))
+
(defn try-start-unless-already-running
"Start a transform run, throwing an informative error if already running.
If `user-id` is provided, it will be stored with the run for attribution purposes."
diff --git a/enterprise/backend/src/metabase_enterprise/transforms_python/api.clj b/enterprise/backend/src/metabase_enterprise/transforms_python/api.clj
index 81875ffd911..a66691150c7 100644
--- a/enterprise/backend/src/metabase_enterprise/transforms_python/api.clj
+++ b/enterprise/backend/src/metabase_enterprise/transforms_python/api.clj
@@ -10,17 +10,18 @@
[metabase.api.macros :as api.macros]
[metabase.api.routes.common :refer [+auth]]
[metabase.api.util.handlers :as handlers]
+ [metabase.permissions.core :as perms]
[metabase.util :as u]
[metabase.util.i18n :as i18n]
[metabase.util.json :as json]
- [metabase.util.malli.schema :as ms]))
+ [metabase.util.malli.schema :as ms]
+ [toucan2.core :as t2]))
(defn get-python-library-by-path
"Get Python library details by path for use by other APIs."
[path]
- (api/check-superuser)
(-> (python-library/get-python-library-by-path path)
- api/check-404
+ api/read-check
(select-keys [:source :path :created_at :updated_at])))
;; TODO (Cam 2025-11-25) please add a response schema to this API endpoint, it makes it easier for our customers to
@@ -43,7 +44,8 @@
_query-params
body :- [:map {:closed true}
[:source :string]]]
- (api/check-superuser)
+ ;; Check permission directly since this is an upsert endpoint - the library may not exist yet.
+ (api/check-403 (perms/has-any-transforms-permission? api/*current-user-id*))
(python-library/update-python-library-source! path (:source body)))
;; TODO (Cam 2025-11-25) please add a response schema to this API endpoint, it makes it easier for our customers to
@@ -69,10 +71,12 @@
per_input_row_limit 100}}
:- [:map
[:code :string]
- [:source_tables [:map-of :string :int]]
+ [:source_tables [:map-of {:min 1} :string :int]]
[:output_row_limit {:optional true} [:and :int [:> 1] [:<= 100]]]
[:per_input_row_limit {:optional true} [:and :int [:> 1] [:<= 100]]]]]
- (api/check-superuser)
+ (let [db-ids (t2/select-fn-set :db_id [:model/Table :db_id] :id [:in (vals source_tables)])]
+ (api/check-400 (= (count db-ids) 1) (i18n/deferred-tru "All source tables must belong to the same database."))
+ (api/check-403 (perms/has-db-transforms-permission? api/*current-user-id* (first db-ids))))
;; NOTE: we do not test database support, as there is no write target.
(with-open [shared-storage-ref (s3/open-shared-storage! source_tables)]
(let [server-url (transforms-python.settings/python-runner-url)
diff --git a/enterprise/backend/src/metabase_enterprise/transforms_python/impl.clj b/enterprise/backend/src/metabase_enterprise/transforms_python/impl.clj
index c16898ead94..42ec3e6757c 100644
--- a/enterprise/backend/src/metabase_enterprise/transforms_python/impl.clj
+++ b/enterprise/backend/src/metabase_enterprise/transforms_python/impl.clj
@@ -9,7 +9,7 @@
(defmethod transforms.i/source-db-id :python
[transform]
- (-> transform :source :database))
+ (-> transform :source :source-database))
#_{:clj-kondo/ignore [:discouraged-var]}
(defmethod transforms.i/execute! :python
diff --git a/enterprise/backend/src/metabase_enterprise/transforms_python/models/python_library.clj b/enterprise/backend/src/metabase_enterprise/transforms_python/models/python_library.clj
index 703477e47df..19f46ede548 100644
--- a/enterprise/backend/src/metabase_enterprise/transforms_python/models/python_library.clj
+++ b/enterprise/backend/src/metabase_enterprise/transforms_python/models/python_library.clj
@@ -1,8 +1,11 @@
(ns metabase-enterprise.transforms-python.models.python-library
(:require
+ [metabase.api.common :as api]
[metabase.app-db.core :as app-db]
[metabase.events.core :as events]
+ [metabase.models.interface :as mi]
[metabase.models.serialization :as serdes]
+ [metabase.permissions.core :as perms]
[metabase.util.i18n :refer [tru]]
[methodical.core :as methodical]
[toucan2.core :as t2]))
@@ -31,6 +34,18 @@
(doseq [trait [:metabase/model :hook/timestamped? :hook/entity-id]]
(derive :model/PythonLibrary trait))
+(defmethod mi/can-read? :model/PythonLibrary
+ ([_instance]
+ (perms/has-any-transforms-permission? api/*current-user-id*))
+ ([_model _pk]
+ (perms/has-any-transforms-permission? api/*current-user-id*)))
+
+(defmethod mi/can-write? :model/PythonLibrary
+ ([_instance]
+ (perms/has-any-transforms-permission? api/*current-user-id*))
+ ([_model _pk]
+ (perms/has-any-transforms-permission? api/*current-user-id*)))
+
(def ^:private allowed-paths
"Set of allowed library paths. Currently only 'common' is supported."
#{"common.py"})
diff --git a/enterprise/backend/test/metabase_enterprise/audit_app/audit_test.clj b/enterprise/backend/test/metabase_enterprise/audit_app/audit_test.clj
index 6e737fda790..51762b98256 100644
--- a/enterprise/backend/test/metabase_enterprise/audit_app/audit_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/audit_app/audit_test.clj
@@ -64,7 +64,8 @@
:perms/download-results :one-million-rows
:perms/manage-table-metadata :no
:perms/view-data :unrestricted
- :perms/create-queries :no}
+ :perms/create-queries :no
+ :perms/transforms :no}
(-> (data-perms.graph/data-permissions-graph :db-id audit/audit-db-id :audit? true)
(get-in [(u/the-id (perms-group/all-users)) audit/audit-db-id])))))
diff --git a/enterprise/backend/test/metabase_enterprise/dependencies/api_test.clj b/enterprise/backend/test/metabase_enterprise/dependencies/api_test.clj
index e891644dfce..2565e4af048 100644
--- a/enterprise/backend/test/metabase_enterprise/dependencies/api_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/dependencies/api_test.clj
@@ -317,7 +317,7 @@
(deftest check-transform-test
(testing "POST /api/ee/dependencies/check_transform"
- (mt/with-premium-features #{:dependencies}
+ (mt/with-premium-features #{:dependencies :transforms}
(mt/with-temp [:model/Transform {_transform-id :id :as transform} {}]
(let [response (mt/user-http-request :crowberto :post 200 "ee/dependencies/check_transform" transform)]
(is (= {:bad_cards [], :bad_transforms [], :success true}
@@ -664,7 +664,7 @@
(deftest check-transform-permissions-test
(testing "POST /api/ee/dependencies/check_transform requires read permissions on the input transform"
- (mt/with-premium-features #{:dependencies}
+ (mt/with-premium-features #{:dependencies :transforms}
(mt/with-temp [:model/Transform transform {:name "test transform"}]
(testing "Returns 403 when user is not an admin (only admins can read transforms)"
(is (= "You don't have permissions to do that."
diff --git a/enterprise/backend/test/metabase_enterprise/dependencies/events_test.clj b/enterprise/backend/test/metabase_enterprise/dependencies/events_test.clj
index c1f485570c3..e5bd479422d 100644
--- a/enterprise/backend/test/metabase_enterprise/dependencies/events_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/dependencies/events_test.clj
@@ -317,7 +317,7 @@
(run-with-dependencies-setup!
(fn [_]
(let [source {:type :python,
- :source-database 2,
+ :source-database (mt/id),
:source-tables {"orders" {:database_id (mt/id),
:schema "public",
:table "orders",
diff --git a/enterprise/backend/test/metabase_enterprise/metabot_v3/tools/api_test.clj b/enterprise/backend/test/metabase_enterprise/metabot_v3/tools/api_test.clj
index ffa116ac318..81b4dd4793c 100644
--- a/enterprise/backend/test/metabase_enterprise/metabot_v3/tools/api_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/metabot_v3/tools/api_test.clj
@@ -1290,6 +1290,7 @@
:model/Transform t3 {:name "Python Transform"
:description "Simple python transform"
:source {:type "python"
+ :source-database (mt/id)
:body "print('hello world')"
:source-tables {}}
:target {:type "table"
@@ -1327,6 +1328,7 @@
:description "Simple Python transform"
:source {:type "python"
:body "print('hello world')"
+ :source-database (mt/id)
:source-tables {}}
:target {:type "table"
:name "t2_table"
@@ -1354,7 +1356,7 @@
:conversation_id conversation-id}))))))))))
(deftest get-transform-python-library-details-test
- (mt/with-premium-features #{:metabot-v3 :python-transforms}
+ (mt/with-premium-features #{:metabot-v3 :python-transforms :transforms}
(let [conversation-id (str (random-uuid))
rasta-ai-token (ai-session-token)
crowberto-ai-token (ai-session-token :crowberto (str (random-uuid)))
diff --git a/enterprise/backend/test/metabase_enterprise/metabot_v3/tools/dependencies_test.clj b/enterprise/backend/test/metabase_enterprise/metabot_v3/tools/dependencies_test.clj
index 5d829164662..96bd5ae7f58 100644
--- a/enterprise/backend/test/metabase_enterprise/metabot_v3/tools/dependencies_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/metabot_v3/tools/dependencies_test.clj
@@ -23,6 +23,7 @@
:name "orders_transform_1"}
:model/Transform {transform1-id# :id}
{:name "Transform 1"
+ :source_database_id (mt/id)
:source {:type "query"
:query (lib/native-query (mt/metadata-provider) "SELECT id, total FROM orders")}
:target {:type "table"
@@ -30,6 +31,7 @@
:name "orders_transform_1"}}
:model/Transform {transform2-id# :id}
{:name "Transform 2"
+ :source_database_id (mt/id)
:source {:type "query"
:query (lib/native-query (mt/metadata-provider) "SELECT id, total FROM orders_transform_1")}
:target {:type "table"
@@ -44,213 +46,221 @@
~@body)))
(deftest check-transform-dependencies-test
- (testing "removing total field from transform1 breaks transform2"
- (mt/as-admin
- (with-dependent-transforms! [transform1-id transform2-id]
- (let [modified-source {:type "query"
- :query (lib/native-query (mt/metadata-provider) "SELECT id FROM orders")}
- result (metabot.dependencies/check-transform-dependencies
- {:id transform1-id
- :source modified-source})]
- (is (false? (get-in result [:structured_output :success])))
- (is (= 1 (get-in result [:structured_output :bad_transform_count])))
- (let [bad-transforms (get-in result [:structured_output :bad_transforms])]
- (is (= 1 (count bad-transforms)))
- (is (= transform2-id (get-in (first bad-transforms) [:transform :id])))
- (is (= "Transform 2" (get-in (first bad-transforms) [:transform :name])))))))))
-
-(deftest check-transform-dependencies-limit-test
- (testing "max-reported-broken-transforms limit"
- (mt/as-admin
- (with-dependent-transforms! [transform1-id _]
- (mt/with-temp
- [:model/Transform {transform3-id :id}
- {:name "Transform 3"
- :source {:type "query"
- :query (lib/native-query (mt/metadata-provider) "SELECT total FROM orders_transform_1")}
- :target {:type "table"
- :schema "public"
- :name "orders_transform_3"}}
- :model/Dependency {}
- {:from_entity_type "transform"
- :from_entity_id transform3-id
- :to_entity_type "transform"
- :to_entity_id transform1-id}]
- (testing "when limit is 1, only one broken transform is reported"
- (binding [metabot.dependencies/*max-reported-broken-transforms* 1]
- (let [modified-source {:type "query"
- :query (lib/native-query (mt/metadata-provider) "SELECT id FROM orders")}
- result (metabot.dependencies/check-transform-dependencies
- {:id transform1-id
- :source modified-source})
- bad-transforms (get-in result [:structured_output :bad_transforms])]
- ;; Two downstream transforms should be broken (transform2 + transform3)...
- (is (false? (get-in result [:structured_output :success])))
- (is (= 2 (get-in result [:structured_output :bad_transform_count])))
- ;; ...but only one should be reported due to the limit.
- (is (= 1 (count bad-transforms)))))))))))
-
-(deftest check-transform-dependencies-with-cards-test
- (testing "removing field from transform breaks dependent card"
- (mt/as-admin
- (with-dependent-transforms! [transform1-id _]
- (mt/with-temp
- [:model/Card {card-id :id}
- {:name "Card using Transform 1"
- :database_id (mt/id)
- :table_id (mt/id :orders)
- :dataset_query (lib/native-query (mt/metadata-provider) "SELECT total FROM orders_transform_1")}
- :model/Dependency {}
- {:from_entity_type "card"
- :from_entity_id card-id
- :to_entity_type "transform"
- :to_entity_id transform1-id}]
+ (mt/with-premium-features [:transforms]
+ (testing "removing total field from transform1 breaks transform2"
+ (mt/as-admin
+ (with-dependent-transforms! [transform1-id transform2-id]
(let [modified-source {:type "query"
:query (lib/native-query (mt/metadata-provider) "SELECT id FROM orders")}
result (metabot.dependencies/check-transform-dependencies
{:id transform1-id
:source modified-source})]
(is (false? (get-in result [:structured_output :success])))
- (is (= 1 (get-in result [:structured_output :bad_question_count])))
- (let [bad-questions (get-in result [:structured_output :bad_questions])]
- (is (= 1 (count bad-questions)))
- (is (= card-id (get-in (first bad-questions) [:question :id])))
- (is (= "Card using Transform 1" (get-in (first bad-questions) [:question :name])))
- (is (some? (:errors (first bad-questions)))))))))))
+ (is (= 1 (get-in result [:structured_output :bad_transform_count])))
+ (let [bad-transforms (get-in result [:structured_output :bad_transforms])]
+ (is (= 1 (count bad-transforms)))
+ (is (= transform2-id (get-in (first bad-transforms) [:transform :id])))
+ (is (= "Transform 2" (get-in (first bad-transforms) [:transform :name]))))))))))
+
+(deftest check-transform-dependencies-limit-test
+ (testing "max-reported-broken-transforms limit"
+ (mt/with-premium-features #{:transforms}
+ (mt/as-admin
+ (with-dependent-transforms! [transform1-id _]
+ (mt/with-temp
+ [:model/Transform {transform3-id :id}
+ {:name "Transform 3"
+ :source_database_id (mt/id)
+ :source {:type "query"
+ :query (lib/native-query (mt/metadata-provider) "SELECT total FROM orders_transform_1")}
+ :target {:type "table"
+ :schema "public"
+ :name "orders_transform_3"}}
+ :model/Dependency {}
+ {:from_entity_type "transform"
+ :from_entity_id transform3-id
+ :to_entity_type "transform"
+ :to_entity_id transform1-id}]
+ (testing "when limit is 1, only one broken transform is reported"
+ (binding [metabot.dependencies/*max-reported-broken-transforms* 1]
+ (let [modified-source {:type "query"
+ :query (lib/native-query (mt/metadata-provider) "SELECT id FROM orders")}
+ result (metabot.dependencies/check-transform-dependencies
+ {:id transform1-id
+ :source modified-source})
+ bad-transforms (get-in result [:structured_output :bad_transforms])]
+ ;; Two downstream transforms should be broken (transform2 + transform3)...
+ (is (false? (get-in result [:structured_output :success])))
+ (is (= 2 (get-in result [:structured_output :bad_transform_count])))
+ ;; ...but only one should be reported due to the limit.
+ (is (= 1 (count bad-transforms))))))))))))
+
+(deftest check-transform-dependencies-with-cards-test
+ (testing "removing field from transform breaks dependent card"
+ (mt/with-premium-features [:transforms]
+ (mt/as-admin
+ (with-dependent-transforms! [transform1-id _]
+ (mt/with-temp
+ [:model/Card {card-id :id}
+ {:name "Card using Transform 1"
+ :database_id (mt/id)
+ :table_id (mt/id :orders)
+ :dataset_query (lib/native-query (mt/metadata-provider) "SELECT total FROM orders_transform_1")}
+ :model/Dependency {}
+ {:from_entity_type "card"
+ :from_entity_id card-id
+ :to_entity_type "transform"
+ :to_entity_id transform1-id}]
+ (let [modified-source {:type "query"
+ :query (lib/native-query (mt/metadata-provider) "SELECT id FROM orders")}
+ result (metabot.dependencies/check-transform-dependencies
+ {:id transform1-id
+ :source modified-source})]
+ (is (false? (get-in result [:structured_output :success])))
+ (is (= 1 (get-in result [:structured_output :bad_question_count])))
+ (let [bad-questions (get-in result [:structured_output :bad_questions])]
+ (is (= 1 (count bad-questions)))
+ (is (= card-id (get-in (first bad-questions) [:question :id])))
+ (is (= "Card using Transform 1" (get-in (first bad-questions) [:question :name])))
+ (is (some? (:errors (first bad-questions))))))))))))
(deftest check-transform-dependencies-card-limit-test
- (testing "max-reported-broken-transforms limit applies to cards"
- (mt/as-admin
+ (mt/with-premium-features #{:transforms}
+ (testing "max-reported-broken-transforms limit applies to cards"
+ (mt/as-admin
+ (with-dependent-transforms! [transform1-id _]
+ (mt/with-temp
+ [:model/Card {card1-id :id}
+ {:name "Card 1 using Transform 1"
+ :database_id (mt/id)
+ :table_id (mt/id :orders)
+ :dataset_query (lib/native-query (mt/metadata-provider) "SELECT total FROM orders_transform_1")}
+ :model/Dependency {}
+ {:from_entity_type "card"
+ :from_entity_id card1-id
+ :to_entity_type "transform"
+ :to_entity_id transform1-id}
+ :model/Card {card2-id :id}
+ {:name "Card 2 using Transform 1"
+ :database_id (mt/id)
+ :table_id (mt/id :orders)
+ :dataset_query (lib/native-query (mt/metadata-provider) "SELECT total FROM orders_transform_1")}
+ :model/Dependency {}
+ {:from_entity_type "card"
+ :from_entity_id card2-id
+ :to_entity_type "transform"
+ :to_entity_id transform1-id}]
+ (testing "when limit is 1, only one broken card is reported"
+ (binding [metabot.dependencies/*max-reported-broken-transforms* 1]
+ (let [modified-source {:type "query"
+ :query (lib/native-query (mt/metadata-provider) "SELECT id FROM orders")}
+ result (metabot.dependencies/check-transform-dependencies
+ {:id transform1-id
+ :source modified-source})
+ bad-cards (get-in result [:structured_output :bad_questions])]
+ ;; Two cards should be broken...
+ (is (false? (get-in result [:structured_output :success])))
+ (is (= 2 (get-in result [:structured_output :bad_question_count])))
+ ;; ...but only one should be reported due to the limit.
+ (is (= 1 (count bad-cards))))))))))))
+
+(deftest check-transform-dependencies-permission-check-test
+ (testing "Permission check on transform being edited"
+ (with-dependent-transforms! [transform1-id _]
+ (testing "Non-superuser cannot check transform dependencies"
+ (mt/with-test-user :rasta
+ (let [modified-source {:type "query"
+ :query (lib/native-query (mt/metadata-provider) "SELECT id FROM orders")}]
+ (is (thrown-with-msg?
+ Exception
+ #"You don't have permissions to do that"
+ (metabot.dependencies/check-transform-dependencies
+ {:id transform1-id
+ :source modified-source})))))))))
+
+(deftest check-transform-dependencies-permission-filtering-test
+ (testing "Broken cards in inaccessible collections are filtered from results"
+ (mt/with-premium-features #{:transforms}
(with-dependent-transforms! [transform1-id _]
(mt/with-temp
- [:model/Card {card1-id :id}
- {:name "Card 1 using Transform 1"
+ [:model/Collection {restricted-collection-id :id} {:name "Restricted Collection"}
+ :model/Collection {public-collection-id :id} {:name "Public Collection"}
+ :model/Card {public-card-id :id}
+ {:name "Public Card"
+ :collection_id public-collection-id
:database_id (mt/id)
:table_id (mt/id :orders)
:dataset_query (lib/native-query (mt/metadata-provider) "SELECT total FROM orders_transform_1")}
:model/Dependency {}
{:from_entity_type "card"
- :from_entity_id card1-id
+ :from_entity_id public-card-id
:to_entity_type "transform"
:to_entity_id transform1-id}
- :model/Card {card2-id :id}
- {:name "Card 2 using Transform 1"
+ :model/Card {restricted-card-id :id}
+ {:name "Restricted Card"
+ :collection_id restricted-collection-id
:database_id (mt/id)
:table_id (mt/id :orders)
:dataset_query (lib/native-query (mt/metadata-provider) "SELECT total FROM orders_transform_1")}
:model/Dependency {}
{:from_entity_type "card"
- :from_entity_id card2-id
+ :from_entity_id restricted-card-id
:to_entity_type "transform"
:to_entity_id transform1-id}]
- (testing "when limit is 1, only one broken card is reported"
- (binding [metabot.dependencies/*max-reported-broken-transforms* 1]
+ (testing "Superuser sees all broken cards regardless of collection permissions"
+ (mt/with-test-user :crowberto
(let [modified-source {:type "query"
:query (lib/native-query (mt/metadata-provider) "SELECT id FROM orders")}
result (metabot.dependencies/check-transform-dependencies
{:id transform1-id
:source modified-source})
- bad-cards (get-in result [:structured_output :bad_questions])]
- ;; Two cards should be broken...
- (is (false? (get-in result [:structured_output :success])))
- (is (= 2 (get-in result [:structured_output :bad_question_count])))
- ;; ...but only one should be reported due to the limit.
- (is (= 1 (count bad-cards)))))))))))
-
-(deftest check-transform-dependencies-permission-check-test
- (testing "Permission check on transform being edited"
- (with-dependent-transforms! [transform1-id _]
- (testing "Non-superuser cannot check transform dependencies"
- (mt/with-test-user :rasta
- (let [modified-source {:type "query"
- :query (lib/native-query (mt/metadata-provider) "SELECT id FROM orders")}]
- (is (thrown-with-msg?
- Exception
- #"You don't have permissions to do that"
- (metabot.dependencies/check-transform-dependencies
- {:id transform1-id
- :source modified-source})))))))))
-
-(deftest check-transform-dependencies-permission-filtering-test
- (testing "Broken cards in inaccessible collections are filtered from results"
- (with-dependent-transforms! [transform1-id _]
- (mt/with-temp
- [:model/Collection {restricted-collection-id :id} {:name "Restricted Collection"}
- :model/Collection {public-collection-id :id} {:name "Public Collection"}
- :model/Card {public-card-id :id}
- {:name "Public Card"
- :collection_id public-collection-id
- :database_id (mt/id)
- :table_id (mt/id :orders)
- :dataset_query (lib/native-query (mt/metadata-provider) "SELECT total FROM orders_transform_1")}
- :model/Dependency {}
- {:from_entity_type "card"
- :from_entity_id public-card-id
- :to_entity_type "transform"
- :to_entity_id transform1-id}
- :model/Card {restricted-card-id :id}
- {:name "Restricted Card"
- :collection_id restricted-collection-id
- :database_id (mt/id)
- :table_id (mt/id :orders)
- :dataset_query (lib/native-query (mt/metadata-provider) "SELECT total FROM orders_transform_1")}
- :model/Dependency {}
- {:from_entity_type "card"
- :from_entity_id restricted-card-id
- :to_entity_type "transform"
- :to_entity_id transform1-id}]
- (testing "Superuser sees all broken cards regardless of collection permissions"
- (mt/with-test-user :crowberto
- (let [modified-source {:type "query"
- :query (lib/native-query (mt/metadata-provider) "SELECT id FROM orders")}
- result (metabot.dependencies/check-transform-dependencies
- {:id transform1-id
- :source modified-source})
- broken-question-ids (set (map #(get-in % [:question :id])
- (get-in result [:structured_output :bad_questions])))]
- ;; Both cards should appear in results for superuser
- (is (contains? broken-question-ids public-card-id))
- (is (contains? broken-question-ids restricted-card-id)))))
- (testing "User with restricted collection access only sees cards they can read"
- (perms/revoke-collection-permissions! (perms-group/all-users) (u/the-id restricted-collection-id))
- (perms/grant-collection-read-permissions! (perms-group/all-users) (u/the-id public-collection-id))
- (mt/with-test-user :rasta
- (let [original-can-read? mi/can-read?]
- ;; Temporarily allow rasta to read transforms (but preserve normal card permission checking)
- ;; Non-superusers can't currently read transforms, but this will change, and until then
- ;; we can test that broken cards are filtered correctly by read access.
- (with-redefs [mi/can-read? (fn [instance]
- (if (t2/instance-of? :model/Transform instance)
- true
- (original-can-read? instance)))]
- (let [modified-source {:type "query"
- :query (lib/native-query (mt/metadata-provider) "SELECT id FROM orders")}
- result (metabot.dependencies/check-transform-dependencies
- {:id transform1-id
- :source modified-source})
- broken-question-ids (set (map #(get-in % [:question :id])
- (get-in result [:structured_output :bad_questions])))]
- ;; Rasta should only see the public card, not the restricted one
- (is (contains? broken-question-ids public-card-id))
- (is (not (contains? broken-question-ids restricted-card-id))))))))))))
+ broken-question-ids (set (map #(get-in % [:question :id])
+ (get-in result [:structured_output :bad_questions])))]
+ ;; Both cards should appear in results for superuser
+ (is (contains? broken-question-ids public-card-id))
+ (is (contains? broken-question-ids restricted-card-id)))))
+ (testing "User with restricted collection access only sees cards they can read"
+ (perms/revoke-collection-permissions! (perms-group/all-users) (u/the-id restricted-collection-id))
+ (perms/grant-collection-read-permissions! (perms-group/all-users) (u/the-id public-collection-id))
+ (mt/with-test-user :rasta
+ (let [original-can-read? mi/can-read?]
+ ;; Temporarily allow rasta to read transforms (but preserve normal card permission checking)
+ ;; Non-superusers can't currently read transforms, but this will change, and until then
+ ;; we can test that broken cards are filtered correctly by read access.
+ (with-redefs [mi/can-read? (fn [instance]
+ (if (t2/instance-of? :model/Transform instance)
+ true
+ (original-can-read? instance)))]
+ (let [modified-source {:type "query"
+ :query (lib/native-query (mt/metadata-provider) "SELECT id FROM orders")}
+ result (metabot.dependencies/check-transform-dependencies
+ {:id transform1-id
+ :source modified-source})
+ broken-question-ids (set (map #(get-in % [:question :id])
+ (get-in result [:structured_output :bad_questions])))]
+ ;; Rasta should only see the public card, not the restricted one
+ (is (contains? broken-question-ids public-card-id))
+ (is (not (contains? broken-question-ids restricted-card-id)))))))))))))
(deftest check-transform-dependencies-python-bypass-test
- (testing "Python transforms bypass dependency checking"
- (mt/with-test-user :crowberto
- (mt/with-temp [:model/Transform {python-transform-id :id}
- {:name "Python Transform"
- :source {:type "python"
- :body "print('hello')"
- :source-tables {}}
- :target {:type "table"
- :schema "public"
- :name "python_transform_table"}}]
- (let [modified-source {:type "python"
- :body "print('modified')"
- :source-tables {}}
- result (metabot.dependencies/check-transform-dependencies
- {:id python-transform-id
- :source modified-source})]
- (is (= {:success true
- :bad_transforms []}
- (result :structured_output))))))))
+ (mt/with-premium-features [:transforms]
+ (testing "Python transforms bypass dependency checking"
+ (mt/with-test-user :crowberto
+ (mt/with-temp [:model/Transform {python-transform-id :id}
+ {:name "Python Transform"
+ :source {:type "python"
+ :body "print('hello')"
+ :source-database (mt/id)
+ :source-tables {:test (t2/select-one-pk :model/Table :db_id (mt/id))}}
+ :target {:type "table"
+ :schema "public"
+ :name "python_transform_table"}}]
+ (let [modified-source {:type "python"
+ :body "print('modified')"
+ :source-tables {:test (t2/select-one-pk :model/Table :db_id (mt/id))}}
+ result (metabot.dependencies/check-transform-dependencies
+ {:id python-transform-id
+ :source modified-source})]
+ (is (= {:success true
+ :bad_transforms []}
+ (result :structured_output)))))))))
diff --git a/enterprise/backend/test/metabase_enterprise/remote_sync/transforms_test.clj b/enterprise/backend/test/metabase_enterprise/remote_sync/transforms_test.clj
index b215946f852..d83fbf70d5f 100644
--- a/enterprise/backend/test/metabase_enterprise/remote_sync/transforms_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/remote_sync/transforms_test.clj
@@ -279,7 +279,7 @@
(defn- generate-transform-yaml
"Generates YAML content for a transform."
- [entity-id name]
+ [entity-id name database-id table-id]
(format "name: %s
description: null
entity_id: %s
@@ -289,10 +289,10 @@ creator_id: [email protected]
source:
type: query
query:
- database: 1
+ database: %d
type: query
query:
- source-table: 1
+ source-table: %d
target:
type: table
name: test_output
@@ -302,7 +302,7 @@ serdes/meta:
label: %s
model: Transform
"
- name entity-id entity-id (str/replace (u/lower-case-en name) #"\s+" "_")))
+ name entity-id database-id table-id entity-id (str/replace (u/lower-case-en name) #"\s+" "_")))
(defn- generate-transforms-namespace-collection-yaml
"Generates YAML content for a transforms-namespace collection."
@@ -334,15 +334,15 @@ is_sample: false
(mt/with-premium-features #{:transforms}
(mt/with-temporary-setting-values [remote-sync-enabled true]
(mt/with-model-cleanup [:model/Transform :model/Collection]
- (let [task-id (t2/insert-returning-pk! :model/RemoteSyncTask {:sync_task_type "import" :initiated_by (mt/user->id :rasta)})
- coll-entity-id "transforms-coll-xxx"
+ (let [task-id (t2/insert-returning-pk! :model/RemoteSyncTask {:sync_task_type "import" :initiated_by (mt/user->id :rasta)})
+ coll-entity-id "transforms-coll-xxx"
transform-entity-id "test-transform-xxxxx"
- test-files {"main" {(str "collections/" coll-entity-id "_transforms/" coll-entity-id "_transforms.yaml")
- (generate-transforms-namespace-collection-yaml coll-entity-id "Transforms")
- (str "collections/" coll-entity-id "_transforms/transforms/" transform-entity-id "_test_transform.yaml")
- (generate-transform-yaml transform-entity-id "Test Transform")}}
- mock-source (test-helpers/create-mock-source :initial-files test-files)
- result (impl/import! (source.p/snapshot mock-source) task-id)]
+ test-files {"main" {(str "collections/" coll-entity-id "_transforms/" coll-entity-id "_transforms.yaml")
+ (generate-transforms-namespace-collection-yaml coll-entity-id "Transforms")
+ (str "collections/" coll-entity-id "_transforms/transforms/" transform-entity-id "_test_transform.yaml")
+ (generate-transform-yaml transform-entity-id "Test Transform" (mt/id) (mt/id :venues))}}
+ mock-source (test-helpers/create-mock-source :initial-files test-files)
+ result (impl/import! (source.p/snapshot mock-source) task-id)]
(is (= :success (:status result)))
(is (t2/exists? :model/Collection :entity_id coll-entity-id :namespace "transforms")
"Transforms-namespace collection should be imported")
@@ -390,7 +390,7 @@ is_sample: false
(let [initial-files {"main" {(str "collections/" coll-eid "_transforms_collection/" coll-eid "_transforms_collection.yaml")
(generate-transforms-namespace-collection-yaml coll-eid "Transforms Collection")
(str "collections/" coll-eid "_transforms_collection/transforms/" transform-eid "_child_transform.yaml")
- (generate-transform-yaml transform-eid "Child Transform")}}
+ (generate-transform-yaml transform-eid "Child Transform" (mt/id) (mt/id :venues))}}
mock-source (test-helpers/create-mock-source :initial-files initial-files)]
(is (some #(str/includes? % coll-eid) (keys (get @(:files-atom mock-source) "main"))))
(is (some #(str/includes? % transform-eid) (keys (get @(:files-atom mock-source) "main"))))
@@ -478,7 +478,7 @@ is_sample: false
(let [test-files {"main" {(str "collections/" coll-entity-id "_transforms/" coll-entity-id "_transforms.yaml")
(generate-transforms-namespace-collection-yaml coll-entity-id "Transforms Collection")
(str "collections/" coll-entity-id "_transforms/transforms/" remote-transform-entity-id "_remote_transform.yaml")
- (generate-transform-yaml remote-transform-entity-id "Remote Transform")}}
+ (generate-transform-yaml remote-transform-entity-id "Remote Transform" (mt/id) (mt/id :venues))}}
mock-source (test-helpers/create-mock-source :initial-files test-files)
result (impl/import! (source.p/snapshot mock-source) task-id)]
(is (= :success (:status result))
diff --git a/enterprise/backend/test/metabase_enterprise/transforms/api/transform_job_test.clj b/enterprise/backend/test/metabase_enterprise/transforms/api/transform_job_test.clj
index 756de665865..fc4e683542b 100644
--- a/enterprise/backend/test/metabase_enterprise/transforms/api/transform_job_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/transforms/api/transform_job_test.clj
@@ -12,195 +12,203 @@
(deftest create-job-test
(testing "POST /api/ee/transform-job"
- (mt/with-premium-features #{:transforms}
- (mt/with-temp [:model/TransformTag tag1 {:name "test-tag-1"}
- :model/TransformTag tag2 {:name "test-tag-2"}]
- (testing "Creates job with valid data"
- (let [response (mt/user-http-request :crowberto :post 200 "ee/transform-job"
- {:name "Test Job"
- :description "Test Description"
- :schedule "0 0 0 * * ?"
- :ui_display_type "cron/builder"
- :tag_ids [(:id tag1) (:id tag2)]})]
- (is (some? (:id response)))
- (is (= "Test Job" (:name response)))
- (is (= "Test Description" (:description response)))
- (is (= "0 0 0 * * ?" (:schedule response)))
- (is (= "cron/builder" (:ui_display_type response)))
- (is (= (set [(:id tag1) (:id tag2)]) (set (:tag_ids response))))))
-
- (testing "Validates cron expression"
- (let [response (mt/user-http-request :crowberto :post 400 "ee/transform-job"
- {:name "Bad Cron Job"
- :schedule "invalid cron"})]
- (is (string? response))
- (is (re-find #"Invalid cron expression" response))))
-
- (testing "Validates tag IDs exist"
- (let [response (mt/user-http-request :crowberto :post 400 "ee/transform-job"
- {:name "Job with bad tags"
- :schedule "0 0 0 * * ?"
- :tag_ids [999999]})]
- (is (string? response))
- (is (re-find #"tag IDs do not exist" response))))))))
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (mt/with-premium-features #{:transforms}
+ (mt/with-temp [:model/TransformTag tag1 {:name "test-tag-1"}
+ :model/TransformTag tag2 {:name "test-tag-2"}]
+ (testing "Creates job with valid data"
+ (let [response (mt/user-http-request :lucky :post 200 "ee/transform-job"
+ {:name "Test Job"
+ :description "Test Description"
+ :schedule "0 0 0 * * ?"
+ :ui_display_type "cron/builder"
+ :tag_ids [(:id tag1) (:id tag2)]})]
+ (is (some? (:id response)))
+ (is (= "Test Job" (:name response)))
+ (is (= "Test Description" (:description response)))
+ (is (= "0 0 0 * * ?" (:schedule response)))
+ (is (= "cron/builder" (:ui_display_type response)))
+ (is (= (set [(:id tag1) (:id tag2)]) (set (:tag_ids response))))))
+
+ (testing "Validates cron expression"
+ (let [response (mt/user-http-request :lucky :post 400 "ee/transform-job"
+ {:name "Bad Cron Job"
+ :schedule "invalid cron"})]
+ (is (string? response))
+ (is (re-find #"Invalid cron expression" response))))
+
+ (testing "Validates tag IDs exist"
+ (let [response (mt/user-http-request :lucky :post 400 "ee/transform-job"
+ {:name "Job with bad tags"
+ :schedule "0 0 0 * * ?"
+ :tag_ids [999999]})]
+ (is (string? response))
+ (is (re-find #"tag IDs do not exist" response)))))))))
(deftest get-job-test
(testing "GET /api/ee/transform-job/:id"
- (mt/with-premium-features #{:transforms}
- (mt/with-temp [:model/TransformTag tag {:name "test-tag"}
- :model/TransformJob job {:name "Test Job"
- :schedule "0 0 0 * * ?"}
- :model/TransformJobTransformTag _ {:job_id (:id job) :tag_id (:id tag) :position 0}]
- (testing "Returns job with hydrated fields"
- (let [response (mt/user-http-request :crowberto :get 200 (str "ee/transform-job/" (:id job)))]
- (is (= (:id job) (:id response)))
- (is (= "Test Job" (:name response)))
- (is (= [(:id tag)] (:tag_ids response)))
- (is (nil? (:last_run response)))))
-
- (testing "Returns 404 for non-existent job"
- (mt/user-http-request :crowberto :get 404 "ee/transform-job/999999"))))))
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (mt/with-premium-features #{:transforms}
+ (mt/with-temp [:model/TransformTag tag {:name "test-tag"}
+ :model/TransformJob job {:name "Test Job"
+ :schedule "0 0 0 * * ?"}
+ :model/TransformJobTransformTag _ {:job_id (:id job) :tag_id (:id tag) :position 0}]
+ (testing "Returns job with hydrated fields"
+ (let [response (mt/user-http-request :lucky :get 200 (str "ee/transform-job/" (:id job)))]
+ (is (= (:id job) (:id response)))
+ (is (= "Test Job" (:name response)))
+ (is (= [(:id tag)] (:tag_ids response)))
+ (is (nil? (:last_run response)))))
+
+ (testing "Returns 404 for non-existent job"
+ (mt/user-http-request :lucky :get 404 "ee/transform-job/999999")))))))
(deftest get-job-transforms-test
(testing "GET /api/ee/transform-job/:id/transforms"
- (mt/with-premium-features #{:transforms}
- (let [crowberto-id (mt/user->id :crowberto)]
- (mt/with-temp [:model/Transform {transform1-id :id} {:name "tr1" :creator_id crowberto-id}
- :model/Transform {transform2-id :id} {:name "tr2" :creator_id crowberto-id}
- :model/Transform _transform3 {}
- :model/TransformTag {tag-id :id} {}
- :model/TransformTransformTag _ {:transform_id transform1-id :tag_id tag-id :position 0}
- :model/TransformTransformTag _ {:transform_id transform2-id :tag_id tag-id :position 0}
- :model/TransformJob {job-id :id} {}
- :model/TransformJobTransformTag _ {:job_id job-id :tag_id tag-id :position 0}]
- (testing "Returns the transforms of the job"
- (let [response (mt/user-http-request :crowberto :get 200 (str "ee/transform-job/" job-id "/transforms"))]
- (is (=? [{:id transform1-id, :name "tr1"} {:id transform2-id, :name "tr2"}]
- (sort-by :id response)))
- (testing "Response hydrates creator"
- (is (every? #(map? (:creator %)) response))
- (is (every? #(= crowberto-id (get-in % [:creator :id])) response)))))
-
- (testing "Returns 404 for non-existent job"
- (mt/user-http-request :crowberto :get 404 "ee/transform-job/999999/transforms")))))))
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (mt/with-premium-features #{:transforms}
+ (let [lucky-id (mt/user->id :lucky)]
+ (mt/with-temp [:model/Transform {transform1-id :id} {:name "tr1" :creator_id lucky-id}
+ :model/Transform {transform2-id :id} {:name "tr2" :creator_id lucky-id}
+ :model/Transform _transform3 {}
+ :model/TransformTag {tag-id :id} {}
+ :model/TransformTransformTag _ {:transform_id transform1-id :tag_id tag-id :position 0}
+ :model/TransformTransformTag _ {:transform_id transform2-id :tag_id tag-id :position 0}
+ :model/TransformJob {job-id :id} {}
+ :model/TransformJobTransformTag _ {:job_id job-id :tag_id tag-id :position 0}]
+ (testing "Returns the transforms of the job"
+ (let [response (mt/user-http-request :lucky :get 200 (str "ee/transform-job/" job-id "/transforms"))]
+ (is (=? [{:id transform1-id, :name "tr1"} {:id transform2-id, :name "tr2"}]
+ (sort-by :id response)))
+ (testing "Response hydrates creator"
+ (is (every? #(map? (:creator %)) response))
+ (is (every? #(= lucky-id (get-in % [:creator :id])) response)))))
+
+ (testing "Returns 404 for non-existent job"
+ (mt/user-http-request :lucky :get 404 "ee/transform-job/999999/transforms"))))))))
(deftest list-jobs-test
(testing "GET /api/ee/transform-job"
- (mt/with-premium-features #{:transforms}
- (let [at-5-second-schedule "5 * * * * ?"]
- (mt/with-temp [:model/TransformTag {t1-id :id} {:name "test-tag"}
- :model/TransformTag {t2-id :id} {:name "second test-tag"}
- :model/TransformJob {j1-id :id} {:name "Job 1" :schedule at-5-second-schedule}
- :model/TransformJob {j2-id :id} {:name "Job 2" :schedule "0 0 0 * * ?"}
- :model/TransformJob {j3-id :id} {:name "Job 3" :schedule "0 0 0 * * ?"}
- :model/TransformJobTransformTag _ {:job_id j1-id :tag_id t1-id :position 0}
- :model/TransformJobTransformTag _ {:job_id j2-id :tag_id t1-id :position 1}
- :model/TransformJobTransformTag _ {:job_id j3-id :tag_id t2-id :position 0}
- :model/TransformJobRun _ {:job_id j1-id :status "timeout" :run_method "cron"
- :start_time (parse-instant "2025-08-25T10:12:11")
- :end_time (parse-instant "2025-08-26T10:52:17")}
- :model/TransformJobRun _ {:job_id j2-id :status "started" :run_method "manual"
- :start_time (parse-instant "2025-08-26T10:12:11")
- :end_time nil
- :is_active true}]
- (let [our-job-ids #{j1-id j2-id j3-id}
- returned-jobs (fn [response] (into [] (filter (comp our-job-ids :id)) response))
- returned-job-ids (fn [response] (into #{} (keep (comp our-job-ids :id)) response))]
- (testing "listing without filtering"
- (let [response (mt/user-http-request :crowberto :get 200 "ee/transform-job")]
- (is (= our-job-ids (returned-job-ids response)))))
- (testing "filtering by tag_ids"
- (let [response (mt/user-http-request :crowberto :get 200 "ee/transform-job" :tag_ids [t2-id])]
- (is (=? [{:schedule "0 0 0 * * ?"
- :tag_ids [t2-id]
- :name "Job 3"
- :id j3-id}]
- (returned-jobs response)))))
- (testing "filtering by last_run_start_time"
- (let [response (mt/user-http-request :crowberto :get 200 "ee/transform-job" :last_run_start_time "2025-08-26~")]
- (is (= #{j2-id} (returned-job-ids response)))))
- (testing "filtering by last_run_statuses"
- (let [response (mt/user-http-request :crowberto :get 200 "ee/transform-job" :last_run_statuses ["started" "succeeded"])]
- (is (= #{j2-id} (returned-job-ids response)))))
- (testing "filtering by last_run_end_time without scheduled job"
- (let [response (mt/user-http-request :crowberto :get 200 "ee/transform-job" :next_run_start_time "2025-08-26~")]
- (is (= #{} (returned-job-ids response)))))
- (testing "filtering by last_run_end_time with scheduled job"
- (mt/with-temp-scheduler!
- (transforms.schedule/initialize-job! {:id j1-id, :schedule at-5-second-schedule})
- (try
- (let [response (mt/user-http-request :crowberto :get 200 "ee/transform-job" :next_run_start_time "2025-08-27~")]
- (is (=? [{:id j1-id
- :last_run {:job_id j1-id
- :run_method "cron"
- :start_time (utc-timestamp "2025-08-25T10:12:11")
- :end_time (utc-timestamp "2025-08-26T10:52:17")}
- :name "Job 1"
- :next_run {:start_time #"\d{4}-\d\d-\d\dT\d\d:\d\d:\d\dZ"}
- :schedule at-5-second-schedule
- :tag_ids [t1-id]}]
- (returned-jobs response))))
- (finally
- (transforms.schedule/delete-job! j1-id)))))))))))
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (mt/with-premium-features #{:transforms}
+ (let [at-5-second-schedule "5 * * * * ?"]
+ (mt/with-temp [:model/TransformTag {t1-id :id} {:name "test-tag"}
+ :model/TransformTag {t2-id :id} {:name "second test-tag"}
+ :model/TransformJob {j1-id :id} {:name "Job 1" :schedule at-5-second-schedule}
+ :model/TransformJob {j2-id :id} {:name "Job 2" :schedule "0 0 0 * * ?"}
+ :model/TransformJob {j3-id :id} {:name "Job 3" :schedule "0 0 0 * * ?"}
+ :model/TransformJobTransformTag _ {:job_id j1-id :tag_id t1-id :position 0}
+ :model/TransformJobTransformTag _ {:job_id j2-id :tag_id t1-id :position 1}
+ :model/TransformJobTransformTag _ {:job_id j3-id :tag_id t2-id :position 0}
+ :model/TransformJobRun _ {:job_id j1-id :status "timeout" :run_method "cron"
+ :start_time (parse-instant "2025-08-25T10:12:11")
+ :end_time (parse-instant "2025-08-26T10:52:17")}
+ :model/TransformJobRun _ {:job_id j2-id :status "started" :run_method "manual"
+ :start_time (parse-instant "2025-08-26T10:12:11")
+ :end_time nil
+ :is_active true}]
+ (let [our-job-ids #{j1-id j2-id j3-id}
+ returned-jobs (fn [response] (into [] (filter (comp our-job-ids :id)) response))
+ returned-job-ids (fn [response] (into #{} (keep (comp our-job-ids :id)) response))]
+ (testing "listing without filtering"
+ (let [response (mt/user-http-request :lucky :get 200 "ee/transform-job")]
+ (is (= our-job-ids (returned-job-ids response)))))
+ (testing "filtering by tag_ids"
+ (let [response (mt/user-http-request :lucky :get 200 "ee/transform-job" :tag_ids [t2-id])]
+ (is (=? [{:schedule "0 0 0 * * ?"
+ :tag_ids [t2-id]
+ :name "Job 3"
+ :id j3-id}]
+ (returned-jobs response)))))
+ (testing "filtering by last_run_start_time"
+ (let [response (mt/user-http-request :lucky :get 200 "ee/transform-job" :last_run_start_time "2025-08-26~")]
+ (is (= #{j2-id} (returned-job-ids response)))))
+ (testing "filtering by last_run_statuses"
+ (let [response (mt/user-http-request :lucky :get 200 "ee/transform-job" :last_run_statuses ["started" "succeeded"])]
+ (is (= #{j2-id} (returned-job-ids response)))))
+ (testing "filtering by last_run_end_time without scheduled job"
+ (let [response (mt/user-http-request :lucky :get 200 "ee/transform-job" :next_run_start_time "2025-08-26~")]
+ (is (= #{} (returned-job-ids response)))))
+ (testing "filtering by last_run_end_time with scheduled job"
+ (mt/with-temp-scheduler!
+ (transforms.schedule/initialize-job! {:id j1-id, :schedule at-5-second-schedule})
+ (try
+ (let [response (mt/user-http-request :lucky :get 200 "ee/transform-job" :next_run_start_time "2025-08-27~")]
+ (is (=? [{:id j1-id
+ :last_run {:job_id j1-id
+ :run_method "cron"
+ :start_time (utc-timestamp "2025-08-25T10:12:11")
+ :end_time (utc-timestamp "2025-08-26T10:52:17")}
+ :name "Job 1"
+ :next_run {:start_time #"\d{4}-\d\d-\d\dT\d\d:\d\d:\d\dZ"}
+ :schedule at-5-second-schedule
+ :tag_ids [t1-id]}]
+ (returned-jobs response))))
+ (finally
+ (transforms.schedule/delete-job! j1-id))))))))))))
(deftest update-job-test
(testing "PUT /api/ee/transform-job/:id"
- (mt/with-premium-features #{:transforms}
- (mt/with-temp [:model/TransformTag tag1 {:name "tag-1"}
- :model/TransformTag tag2 {:name "tag-2"}]
- (let [job (mt/user-http-request :crowberto :post 200 "ee/transform-job"
- {:name "Original" :schedule "0 0 0 * * ?"})]
- (testing "Updates job fields"
- (let [response (mt/user-http-request :crowberto :put 200 (str "ee/transform-job/" (:id job))
- {:name "Updated"
- :description "New Description"
- :schedule "0 0 */2 * * ?"
- :tag_ids [(:id tag1) (:id tag2)]})]
- (is (= "Updated" (:name response)))
- (is (= "New Description" (:description response)))
- (is (= "0 0 */2 * * ?" (:schedule response)))
- (is (= (set [(:id tag1) (:id tag2)]) (set (:tag_ids response))))))
-
- (testing "Validates cron expression"
- (let [response (mt/user-http-request :crowberto :put 400 (str "ee/transform-job/" (:id job))
- {:schedule "invalid"})]
- (is (string? response))
- (is (re-find #"Invalid cron expression" response)))))))))
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (mt/with-premium-features #{:transforms}
+ (mt/with-temp [:model/TransformTag tag1 {:name "tag-1"}
+ :model/TransformTag tag2 {:name "tag-2"}]
+ (let [job (mt/user-http-request :lucky :post 200 "ee/transform-job"
+ {:name "Original" :schedule "0 0 0 * * ?"})]
+ (testing "Updates job fields"
+ (let [response (mt/user-http-request :lucky :put 200 (str "ee/transform-job/" (:id job))
+ {:name "Updated"
+ :description "New Description"
+ :schedule "0 0 */2 * * ?"
+ :tag_ids [(:id tag1) (:id tag2)]})]
+ (is (= "Updated" (:name response)))
+ (is (= "New Description" (:description response)))
+ (is (= "0 0 */2 * * ?" (:schedule response)))
+ (is (= (set [(:id tag1) (:id tag2)]) (set (:tag_ids response))))))
+
+ (testing "Validates cron expression"
+ (let [response (mt/user-http-request :lucky :put 400 (str "ee/transform-job/" (:id job))
+ {:schedule "invalid"})]
+ (is (string? response))
+ (is (re-find #"Invalid cron expression" response))))))))))
(deftest update-job-remove-tags-test
(testing "PUT /api/ee/transform-job/:id"
- (mt/with-premium-features #{:transforms}
- (testing "should be able to remove all tags from a job"
- (mt/with-temp [:model/TransformTag tag {}
- :model/TransformJob job {}
- :model/TransformJobTransformTag _ {:job_id (:id job) :tag_id (:id tag) :position 0}]
- (let [response (mt/user-http-request :crowberto :put 200 (str "ee/transform-job/" (:id job))
- {:tag_ids []})]
- (is (= [] (:tag_ids response)))))))))
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (mt/with-premium-features #{:transforms}
+ (testing "should be able to remove all tags from a job"
+ (mt/with-temp [:model/TransformTag tag {}
+ :model/TransformJob job {}
+ :model/TransformJobTransformTag _ {:job_id (:id job) :tag_id (:id tag) :position 0}]
+ (let [response (mt/user-http-request :lucky :put 200 (str "ee/transform-job/" (:id job))
+ {:tag_ids []})]
+ (is (= [] (:tag_ids response))))))))))
(deftest delete-job-test
(testing "DELETE /api/ee/transform-job/:id"
- (mt/with-premium-features #{:transforms}
- (mt/with-temp [:model/TransformJob job {:name "To Delete" :schedule "0 0 0 * * ?"}]
- (testing "Deletes job"
- (mt/user-http-request :crowberto :delete 204 (str "ee/transform-job/" (:id job)))
- (is (nil? (t2/select-one :model/TransformJob :id (:id job)))))
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (mt/with-premium-features #{:transforms}
+ (mt/with-temp [:model/TransformJob job {:name "To Delete" :schedule "0 0 0 * * ?"}]
+ (testing "Deletes job"
+ (mt/user-http-request :lucky :delete 204 (str "ee/transform-job/" (:id job)))
+ (is (nil? (t2/select-one :model/TransformJob :id (:id job)))))
- (testing "Returns 404 for non-existent job"
- (mt/user-http-request :crowberto :delete 404 "ee/transform-job/999999"))))))
+ (testing "Returns 404 for non-existent job"
+ (mt/user-http-request :lucky :delete 404 "ee/transform-job/999999")))))))
(deftest execute-job-test
(testing "POST /api/ee/transform-job/:id/execute"
- (mt/with-premium-features #{:transforms}
- (mt/with-temp [:model/TransformJob job {:name "To Execute" :schedule "0 0 0 * * ?"}]
- (testing "Returns stub run response"
- (let [response (mt/user-http-request :crowberto :post 200 (str "ee/transform-job/" (:id job) "/run"))]
- (is (= "Job run started" (:message response)))
- (is (string? (:job_run_id response)))
- (is (re-matches #"stub-\d+-\d+" (:job_run_id response)))))))))
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (mt/with-premium-features #{:transforms}
+ (mt/with-temp [:model/TransformJob job {:name "To Execute" :schedule "0 0 0 * * ?"}]
+ (testing "Returns stub run response"
+ (let [response (mt/user-http-request :lucky :post 200 (str "ee/transform-job/" (:id job) "/run"))]
+ (is (= "Job run started" (:message response)))
+ (is (string? (:job_run_id response)))
+ (is (re-matches #"stub-\d+-\d+" (:job_run_id response))))))))))
(deftest permissions-test
- (testing "All endpoints require superuser permissions"
+ (testing "All endpoints require transform permissions"
(mt/with-premium-features #{:transforms}
(mt/with-temp [:model/TransformJob job {:name "Test" :schedule "0 0 0 * * ?"}]
(mt/user-http-request :rasta :post 403 "ee/transform-job"
diff --git a/enterprise/backend/test/metabase_enterprise/transforms/api/transform_tag_test.clj b/enterprise/backend/test/metabase_enterprise/transforms/api/transform_tag_test.clj
index 40ee8987204..f1a12c05d15 100644
--- a/enterprise/backend/test/metabase_enterprise/transforms/api/transform_tag_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/transforms/api/transform_tag_test.clj
@@ -13,91 +13,95 @@
(deftest create-tag-test
(testing "POST /api/ee/transform-tag"
(mt/with-premium-features #{:transforms}
- (testing "Creates a new tag with valid name"
- (let [tag-name (str "test-tag-" (u/generate-nano-id))
- response (mt/user-http-request :crowberto :post 200 "ee/transform-tag"
- {:name tag-name})]
- (try
- (is (some? (:id response)))
- (is (= tag-name (:name response)))
- (is (some? (:created_at response)))
- (is (some? (:updated_at response)))
- ;; Clean up
- (finally
- (t2/delete! :model/TransformTag :id (:id response))))))
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (testing "Creates a new tag with valid name"
+ (let [tag-name (str "test-tag-" (u/generate-nano-id))
+ response (mt/user-http-request :lucky :post 200 "ee/transform-tag"
+ {:name tag-name})]
+ (try
+ (is (some? (:id response)))
+ (is (= tag-name (:name response)))
+ (is (some? (:created_at response)))
+ (is (some? (:updated_at response)))
+ ;; Clean up
+ (finally
+ (t2/delete! :model/TransformTag :id (:id response))))))
- (testing "Returns 400 for duplicate tag name"
- (mt/with-temp [:model/TransformTag tag {}]
- (is (string? (mt/user-http-request :crowberto :post 400 "ee/transform-tag"
- {:name (:name tag)}))
- "Should return 400 with error message for duplicate name")))
+ (testing "Returns 400 for duplicate tag name"
+ (mt/with-temp [:model/TransformTag tag {}]
+ (is (string? (mt/user-http-request :lucky :post 400 "ee/transform-tag"
+ {:name (:name tag)}))
+ "Should return 400 with error message for duplicate name")))
- (testing "Returns validation error for empty name"
- (let [response (mt/user-http-request :crowberto :post "ee/transform-tag"
- {:name ""})]
- (is (:errors response) "Should return validation errors for empty name"))
- (let [response (mt/user-http-request :crowberto :post "ee/transform-tag"
- {:name " "})]
- (is (:errors response) "Should return validation errors for blank name"))))))
+ (testing "Returns validation error for empty name"
+ (let [response (mt/user-http-request :lucky :post "ee/transform-tag"
+ {:name ""})]
+ (is (:errors response) "Should return validation errors for empty name"))
+ (let [response (mt/user-http-request :lucky :post "ee/transform-tag"
+ {:name " "})]
+ (is (:errors response) "Should return validation errors for blank name")))))))
(deftest update-tag-test
- (testing "PUT /api/ee/transform-tag/:tag-id"
- (mt/with-premium-features #{:transforms}
- (testing "Updates tag name successfully"
- (mt/with-temp [:model/TransformTag tag {}]
- (let [updated-name (str "updated-" (u/generate-nano-id))
- response (mt/user-http-request :crowberto :put 200
- (str "ee/transform-tag/" (:id tag))
- {:name updated-name})]
- (is (= (:id tag) (:id response)))
- (is (= updated-name (:name response))))))
+ (mt/with-premium-features #{:transforms}
+ (testing "PUT /api/ee/transform-tag/:tag-id"
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (testing "Updates tag name successfully"
+ (mt/with-temp [:model/TransformTag tag {}]
+ (let [updated-name (str "updated-" (u/generate-nano-id))
+ response (mt/user-http-request :lucky :put 200
+ (str "ee/transform-tag/" (:id tag))
+ {:name updated-name})]
+ (is (= (:id tag) (:id response)))
+ (is (= updated-name (:name response))))))
- (testing "Returns 404 for non-existent tag"
- (is (= "Not found."
- (mt/user-http-request :crowberto :put 404
- "ee/transform-tag/999999"
- {:name "new-name"}))))
+ (testing "Returns 404 for non-existent tag"
+ (is (= "Not found."
+ (mt/user-http-request :lucky :put 404
+ "ee/transform-tag/999999"
+ {:name "new-name"}))))
- (testing "Returns 400 when updating to duplicate name"
- (mt/with-temp [:model/TransformTag existing-tag {}
- :model/TransformTag tag-to-update {}]
- (is (string? (mt/user-http-request :crowberto :put 400
- (str "ee/transform-tag/" (:id tag-to-update))
- {:name (:name existing-tag)}))
- "Should return 400 with error message for duplicate name"))))))
+ (testing "Returns 400 when updating to duplicate name"
+ (mt/with-temp [:model/TransformTag existing-tag {}
+ :model/TransformTag tag-to-update {}]
+ (is (string? (mt/user-http-request :lucky :put 400
+ (str "ee/transform-tag/" (:id tag-to-update))
+ {:name (:name existing-tag)}))
+ "Should return 400 with error message for duplicate name")))))))
(deftest delete-tag-test
(testing "DELETE /api/ee/transform-tag/:tag-id"
- (mt/with-premium-features #{:transforms}
- (testing "Deletes tag successfully"
- (mt/with-temp [:model/TransformTag tag {}]
- (is (t2/exists? :model/TransformTag :id (:id tag)))
- (mt/user-http-request :crowberto :delete 204 (str "ee/transform-tag/" (:id tag)))
- (is (not (t2/exists? :model/TransformTag :id (:id tag))))))
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (mt/with-premium-features #{:transforms}
+ (testing "Deletes tag successfully"
+ (mt/with-temp [:model/TransformTag tag {}]
+ (is (t2/exists? :model/TransformTag :id (:id tag)))
+ (mt/user-http-request :lucky :delete 204 (str "ee/transform-tag/" (:id tag)))
+ (is (not (t2/exists? :model/TransformTag :id (:id tag))))))
- (testing "Returns 404 for non-existent tag"
- (is (= "Not found."
- (mt/user-http-request :crowberto :delete 404
- "ee/transform-tag/999999")))))))
+ (testing "Returns 404 for non-existent tag"
+ (is (= "Not found."
+ (mt/user-http-request :lucky :delete 404
+ "ee/transform-tag/999999"))))))))
(deftest list-tags-test
(testing "GET /api/ee/transform-tag"
- (mt/with-premium-features #{:transforms}
- (testing "Returns all tags ordered by name"
- (mt/with-temp [:model/TransformTag tag1 {:name "tag 1"}
- :model/TransformTag tag2 {:name "tag 3"}
- :model/TransformTag tag3 {:name "tag 2"}]
- (let [response (mt/user-http-request :crowberto :get 200 "ee/transform-tag")
- tag-names (map :name response)]
- ;; Should include our test tags
- (is (some #(= (:name tag1) %) tag-names))
- (is (some #(= (:name tag2) %) tag-names))
- (is (some #(= (:name tag3) %) tag-names))
- ;; Should be ordered alphabetically
- (is (= (sort tag-names) tag-names))))))))
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (mt/with-premium-features #{:transforms}
+ (testing "Returns all tags ordered by name"
+ (mt/with-temp [:model/TransformTag tag1 {:name "tag 1"}
+ :model/TransformTag tag2 {:name "tag 3"}
+ :model/TransformTag tag3 {:name "tag 2"}]
+ (let [response (mt/user-http-request :lucky :get 200 "ee/transform-tag")
+ tag-names (map :name response)]
+ ;; Should include our test tags
+ (is (some #(= (:name tag1) %) tag-names))
+ (is (some #(= (:name tag2) %) tag-names))
+ (is (some #(= (:name tag3) %) tag-names))
+ ;; Should be ordered alphabetically
+ (is (= (sort tag-names) tag-names)))))))))
(deftest permissions-test
- (testing "Transform tag endpoints require superuser permissions"
+ (testing "Transform tag endpoints require data-analyst permissions"
(mt/with-premium-features #{:transforms}
(testing "POST /api/ee/transform-tag"
(is (string? (mt/user-http-request :rasta :post 403 "ee/transform-tag"
diff --git a/enterprise/backend/test/metabase_enterprise/transforms/api/transform_tags_test.clj b/enterprise/backend/test/metabase_enterprise/transforms/api/transform_tags_test.clj
deleted file mode 100644
index 37d88b0e4cc..00000000000
--- a/enterprise/backend/test/metabase_enterprise/transforms/api/transform_tags_test.clj
+++ /dev/null
@@ -1,221 +0,0 @@
-(ns ^:mb/driver-tests metabase-enterprise.transforms.api.transform-tags-test
- (:require
- [clojure.test :refer :all]
- [metabase-enterprise.transforms.models.transform :as transform.model]
- [metabase-enterprise.transforms.models.transform-tag]
- [metabase.test :as mt]
- [toucan2.core :as t2]))
-
-(comment
-
- (mt/with-premium-features #{:transforms}
- (mt/user-http-request :crowberto :post 200 "ee/transform-tag"
- {:name (str "test-tag-1-" (random-uuid))})
-
- (let [transform-request (merge (mt/with-temp-defaults :model/Transform)
- {:tag_ids []})
- transform-response (mt/user-http-request :crowberto :post 200 "ee/transform"
- transform-request)]
- transform-response)))
-
-(deftest create-transform-with-tags-test
- (testing "POST /api/ee/transform with tag_ids"
- (mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
- (mt/with-premium-features #{:transforms}
- (let [schema (t2/select-one-fn :schema :model/Table :db_id (mt/id) :active true)]
- (testing "Can create transform with tags"
- ;; Create tags via API since we're testing transform creation with existing tags
- (let [tag1 (mt/user-http-request :crowberto :post 200 "ee/transform-tag"
- {:name (str "test-tag-1-" (random-uuid))})
- tag2 (mt/user-http-request :crowberto :post 200 "ee/transform-tag"
- {:name (str "test-tag-2-" (random-uuid))})]
- (try
- (let [transform-request (-> (merge (mt/with-temp-defaults :model/Transform)
- {:tag_ids [(:id tag1) (:id tag2)]})
- (assoc-in [:target :schema] schema))
- transform-response (mt/user-http-request :crowberto :post 200 "ee/transform"
- transform-request)]
- (try
- (is (= (:name transform-request) (:name transform-response)))
- (is (= (:tag_ids transform-request) (sort (:tag_ids transform-response))))
- (finally
- (t2/delete! :model/Transform :id (:id transform-response)))))
- (finally
- (t2/delete! :model/TransformTag :id [:in [(:id tag1) (:id tag2)]])))))
- (testing "Can create transform without tags"
- (let [transform-request (assoc-in (mt/with-temp-defaults :model/Transform)
- [:target :schema] schema)
- transform-response (mt/user-http-request :crowberto :post 200 "ee/transform"
- transform-request)]
- (try
- (is (= (:name transform-request) (:name transform-response)))
- (is (= [] (:tag_ids transform-response)))
- (finally
- (t2/delete! :model/Transform :id (:id transform-response)))))))))))
-
-(deftest update-transform-tags-test
- (testing "PUT /api/ee/transform/:id with tag_ids"
- (mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
- (mt/with-premium-features #{:transforms}
- (mt/with-temp [:model/Transform transform {:name "Test Transform"
- :source {:type "query"
- :query {:database (mt/id)
- :type "native"
- :native {:query "SELECT 1"}}}
- :target {:type "table"
- :name "test_table"}}
- :model/TransformTag tag1 {:name "update-tag-1"}
- :model/TransformTag tag2 {:name "update-tag-2"}
- :model/TransformTag tag3 {:name "update-tag-3"}]
-
- (testing "Can add tags to transform"
- (let [updated (mt/user-http-request :crowberto :put 200 (str "ee/transform/" (:id transform))
- {:tag_ids [(:id tag1) (:id tag2)]})]
- (is (= [(:id tag1) (:id tag2)] (sort (:tag_ids updated))))))
-
- (testing "Can update tags on transform"
- (let [updated (mt/user-http-request :crowberto :put 200 (str "ee/transform/" (:id transform))
- {:tag_ids [(:id tag2) (:id tag3)]})]
- (is (= [(:id tag2) (:id tag3)] (sort (:tag_ids updated))))))
-
- (testing "Can remove all tags from transform"
- (let [updated (mt/user-http-request :crowberto :put 200 (str "ee/transform/" (:id transform))
- {:tag_ids []})]
- (is (= [] (:tag_ids updated))))))))))
-
-(deftest get-transform-with-tags-test
- (testing "GET /api/ee/transform/:id returns tag_ids"
- (mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
- (mt/with-premium-features #{:transforms}
- (mt/with-temp [:model/Transform transform {:name "Transform With Tags"
- :source {:type "query"
- :query {:database (mt/id)
- :type "native"
- :native {:query "SELECT 1"}}}
- :target {:type "table"
- :name "tagged_table"}}
- :model/TransformTag tag1 {:name "get-tag-1"}
- :model/TransformTag tag2 {:name "get-tag-2"}]
- ;; Add tags to transform
- (transform.model/update-transform-tags! (:id transform) [(:id tag1) (:id tag2)])
-
- (testing "Single transform returns tag_ids"
- (let [fetched (mt/user-http-request :crowberto :get 200 (str "ee/transform/" (:id transform)))]
- (is (= [(:id tag1) (:id tag2)] (sort (:tag_ids fetched))))))
-
- (testing "Transform without tags returns empty array"
- (mt/with-temp [:model/Transform transform2 {:name "Transform Without Tags"
- :source {:type "query"
- :query {:database (mt/id)
- :type "native"
- :native {:query "SELECT 1"}}}
- :target {:type "table"
- :name "untagged_table"}}]
- (let [fetched (mt/user-http-request :crowberto :get 200 (str "ee/transform/" (:id transform2)))]
- (is (= [] (:tag_ids fetched)))))))))))
-
-(deftest list-transforms-with-tags-test
- (testing "GET /api/ee/transform returns transforms with tag_ids"
- (mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
- (mt/with-premium-features #{:transforms}
- (mt/with-temp [:model/Transform transform1 {:name "Transform 1"
- :source {:type "query"
- :query {:database (mt/id)
- :type "native"
- :native {:query "SELECT 1"}}}
- :target {:type "table"
- :name "list_table_1"}}
- :model/Transform transform2 {:name "Transform 2"
- :source {:type "query"
- :query {:database (mt/id)
- :type "native"
- :native {:query "SELECT 2"}}}
- :target {:type "table"
- :name "list_table_2"}}
- :model/TransformTag tag1 {:name "list-tag-1"}
- :model/TransformTag tag2 {:name "list-tag-2"}]
- ;; Add tags to transforms
- (transform.model/update-transform-tags! (:id transform1) [(:id tag1)])
- (transform.model/update-transform-tags! (:id transform2) [(:id tag1) (:id tag2)])
-
- (testing "List endpoint returns all transforms with their tag_ids"
- (let [transforms (mt/user-http-request :crowberto :get 200 "ee/transform")
- t1 (some #(when (= (:id %) (:id transform1)) %) transforms)
- t2 (some #(when (= (:id %) (:id transform2)) %) transforms)]
- (is (= [(:id tag1)] (:tag_ids t1)))
- (is (= [(:id tag1) (:id tag2)] (sort (:tag_ids t2)))))))))))
-
-(deftest delete-tag-removes-associations-test
- (testing "Deleting a tag removes it from all transforms"
- (mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
- (mt/with-premium-features #{:transforms}
- (mt/with-temp [:model/Transform transform {:name "Transform for Delete Test"
- :source {:type "query"
- :query {:database (mt/id)
- :type "native"
- :native {:query "SELECT 1"}}}
- :target {:type "table"
- :name "delete_test_table"}}
- :model/TransformTag tag2 {:name "tag-to-keep"}]
- ;; Create tag1 via API since we're testing its deletion
- (let [tag1 (mt/user-http-request :crowberto :post 200 "ee/transform-tag"
- {:name "tag-to-delete"})]
- (try
- ;; Add both tags to transform
- (transform.model/update-transform-tags! (:id transform) [(:id tag1) (:id tag2)])
-
- ;; Verify tags are associated
- (let [fetched (mt/user-http-request :crowberto :get 200 (str "ee/transform/" (:id transform)))]
- (is (= (set [(:id tag1) (:id tag2)]) (set (:tag_ids fetched)))))
-
- ;; Delete tag1
- (mt/user-http-request :crowberto :delete 204 (str "ee/transform-tag/" (:id tag1)))
-
- ;; Verify tag1 is removed but tag2 remains
- (let [fetched (mt/user-http-request :crowberto :get 200 (str "ee/transform/" (:id transform)))]
- (is (= [(:id tag2)] (vec (:tag_ids fetched)))))
- (finally
- (t2/delete! :model/TransformTag :id (:id tag1))))))))))
-
-(deftest preserve-tag-order-test
- (testing "Tag order is preserved when adding/updating transform tags"
- (mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
- (mt/with-premium-features #{:transforms}
- (mt/with-temp [:model/TransformTag tag1 {:name "order-tag-1"}
- :model/TransformTag tag2 {:name "order-tag-2"}
- :model/TransformTag tag3 {:name "order-tag-3"}]
-
- (let [schema (t2/select-one-fn :schema :model/Table :db_id (mt/id) :active true)]
- (testing "Creating transform with specific tag order preserves that order"
- (let [transform-request (-> (merge (mt/with-temp-defaults :model/Transform)
- {:tag_ids [(:id tag3) (:id tag1) (:id tag2)]})
- (assoc-in [:target :schema] schema))
- transform (mt/user-http-request :crowberto :post 200 "ee/transform"
- transform-request)]
- (try
- ;; Should preserve the exact order: tag3, tag1, tag2
- (is (= [(:id tag3) (:id tag1) (:id tag2)] (:tag_ids transform)))
- ;; Verify order is preserved when fetching
- (let [fetched (mt/user-http-request :crowberto :get 200 (str "ee/transform/" (:id transform)))]
- (is (= [(:id tag3) (:id tag1) (:id tag2)] (:tag_ids fetched))))
- ;; Update with different order
- (let [updated (mt/user-http-request :crowberto :put 200 (str "ee/transform/" (:id transform))
- {:tag_ids [(:id tag2) (:id tag3) (:id tag1)]})]
- ;; Should now have the new order: tag2, tag3, tag1
- (is (= [(:id tag2) (:id tag3) (:id tag1)] (:tag_ids updated))))
- ;; Verify new order persists
- (let [fetched-again (mt/user-http-request :crowberto :get 200 (str "ee/transform/" (:id transform)))]
- (is (= [(:id tag2) (:id tag3) (:id tag1)] (:tag_ids fetched-again))))
- (finally
- (t2/delete! :model/Transform :id (:id transform))))))
- (testing "Duplicate tag IDs are handled correctly"
- (let [transform-request (-> (merge (mt/with-temp-defaults :model/Transform)
- {:tag_ids [(:id tag1) (:id tag2) (:id tag1)]})
- (assoc-in [:target :schema] schema))
- transform (mt/user-http-request :crowberto :post 200 "ee/transform"
- transform-request)]
- (try
- ;; Should only have each tag once, but preserve relative order
- (is (= [(:id tag1) (:id tag2)] (:tag_ids transform)))
- (finally
- (t2/delete! :model/Transform :id (:id transform))))))))))))
diff --git a/enterprise/backend/test/metabase_enterprise/transforms/api_test.clj b/enterprise/backend/test/metabase_enterprise/transforms/api_test.clj
index a7c33051e5e..c559ecf707d 100644
--- a/enterprise/backend/test/metabase_enterprise/transforms/api_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/transforms/api_test.clj
@@ -4,6 +4,7 @@
[clojure.test :refer :all]
[medley.core :as m]
[metabase-enterprise.transforms.api]
+ [metabase-enterprise.transforms.models.transform :as transform.model]
[metabase-enterprise.transforms.query-test-util :as query-test-util]
[metabase-enterprise.transforms.test-dataset :as transforms-dataset]
[metabase-enterprise.transforms.test-util :refer [get-test-schema
@@ -15,6 +16,7 @@
[metabase.lib.core :as lib]
[metabase.lib.metadata :as lib.metadata]
[metabase.permissions.core :as perms]
+ [metabase.permissions.models.permissions-group :as perms-group]
[metabase.query-processor :as qp]
[metabase.test :as mt]
[metabase.util :as u]
@@ -54,31 +56,33 @@
(mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
(mt/with-premium-features #{:transforms}
(mt/dataset transforms-dataset/transforms-test
- (with-transform-cleanup! [table-name "gadget_products"]
- (let [query (make-query "Gadget")
- schema (get-test-schema)
- response (mt/user-http-request :crowberto :post 200 "ee/transform"
- {:name "Gadget Products"
- :source {:type "query"
- :query query}
- :target {:type "table"
- :schema schema
- :name table-name}})
- transform-id (:id response)
- crowberto-id (mt/user->id :crowberto)
- creator-id (t2/select-one-fn :creator_id :model/Transform transform-id)]
- (testing "Response includes creator_id"
- (is (= crowberto-id (:creator_id response))))
- (testing "Database record has creator_id set correctly"
- (is (= crowberto-id creator-id)))
- (testing "Response hydrates creator"
- (is (map? (:creator response)))
- (is (= crowberto-id (get-in response [:creator :id]))))
- (testing "Response includes owner_user_id defaulting to creator"
- (is (= crowberto-id (:owner_user_id response))))
- (testing "Response hydrates owner"
- (is (map? (:owner response)))
- (is (= crowberto-id (get-in response [:owner :id]))))))))))
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (mt/with-db-perm-for-group! (perms-group/all-users) (mt/id) :perms/transforms :yes
+ (with-transform-cleanup! [table-name "gadget_products"]
+ (let [query (make-query "Gadget")
+ schema (get-test-schema)
+ response (mt/user-http-request :lucky :post 200 "ee/transform"
+ {:name "Gadget Products"
+ :source {:type "query"
+ :query query}
+ :target {:type "table"
+ :schema schema
+ :name table-name}})
+ transform-id (:id response)
+ lucky-id (mt/user->id :lucky)
+ creator-id (t2/select-one-fn :creator_id :model/Transform transform-id)]
+ (testing "Response includes creator_id"
+ (is (= lucky-id (:creator_id response))))
+ (testing "Database record has creator_id set correctly"
+ (is (= lucky-id creator-id)))
+ (testing "Response hydrates creator"
+ (is (map? (:creator response)))
+ (is (= lucky-id (get-in response [:creator :id]))))
+ (testing "Response includes owner_user_id defaulting to creator"
+ (is (= lucky-id (:owner_user_id response))))
+ (testing "Response hydrates owner"
+ (is (map? (:owner response)))
+ (is (= lucky-id (get-in response [:owner :id]))))))))))))
(deftest create-transform-with-owner-test
(mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
@@ -175,217 +179,275 @@
(mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
(mt/with-premium-features #{:transforms :transforms-python}
(mt/dataset transforms-dataset/transforms-test
- (testing "MBQL query transforms are detected as :mbql"
- (with-transform-cleanup! [table-name "mbql_transform"]
- (let [mbql-query (mt/mbql-query transforms_products)
- schema (get-test-schema)
- response (mt/user-http-request :crowberto :post 200 "ee/transform"
- {:name "MBQL Transform"
- :source {:type "query"
- :query mbql-query}
- :target {:type "table"
- :schema schema
- :name table-name}})]
- (is (= "mbql" (:source_type response))))))
-
- (testing "Native query transforms are detected as :native"
- (with-transform-cleanup! [table-name "native_transform"]
- (let [schema (get-test-schema)
- response (mt/user-http-request :crowberto :post 200 "ee/transform"
- {:name "Native Transform"
- :source {:type "query"
- :query (lib/native-query (mt/metadata-provider) "SELECT 1")}
- :target {:type "table"
- :schema schema
- :name table-name}})]
- (is (= "native" (:source_type response))))))
-
- (testing "Python transforms are detected as :python"
- (with-transform-cleanup! [table-name "python_transform"]
- (let [schema (get-test-schema)
- response (mt/user-http-request :crowberto :post 200 "ee/transform"
- {:name "My beautiful python runner"
- :source {:type "python"
- :body "print('hello world')"
- :source-tables {}}
- :target {:type "table"
- :schema schema
- :name table-name
- :database (mt/id)}})]
- (is (= "python" (:source_type response)))))))))))
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (mt/with-db-perm-for-group! (perms-group/all-users) (mt/id) :perms/transforms :yes
+ (testing "MBQL query transforms are detected as :mbql"
+ (with-transform-cleanup! [table-name "mbql_transform"]
+ (let [mbql-query (mt/mbql-query transforms_products)
+ schema (get-test-schema)
+ response (mt/user-http-request :lucky :post 200 "ee/transform"
+ {:name "MBQL Transform"
+ :source {:type "query"
+ :query mbql-query}
+ :target {:type "table"
+ :schema schema
+ :name table-name}})]
+ (is (= "mbql" (:source_type response))))))
+
+ (testing "Native query transforms are detected as :native"
+ (with-transform-cleanup! [table-name "native_transform"]
+ (let [schema (get-test-schema)
+ response (mt/user-http-request :lucky :post 200 "ee/transform"
+ {:name "Native Transform"
+ :source {:type "query"
+ :query (lib/native-query (mt/metadata-provider) "SELECT 1")}
+ :target {:type "table"
+ :schema schema
+ :name table-name}})]
+ (is (= "native" (:source_type response))))))
+
+ (testing "Python transforms are detected as :python"
+ (with-transform-cleanup! [table-name "python_transform"]
+ (let [schema (get-test-schema)
+ response (mt/user-http-request :lucky :post 200 "ee/transform"
+ {:name "My beautiful python runner"
+ :source {:type "python"
+ :body "print('hello world')"
+ :source-tables {}
+ :source-database (mt/id)}
+ :target {:type "table"
+ :schema schema
+ :name table-name
+ :database (mt/id)}})]
+ (is (= "python" (:source_type response)))))))))))))
(deftest transform-type-updates-test
(testing "Transform type is automatically updated when source changes"
(mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
(mt/with-premium-features #{:transforms}
(mt/dataset transforms-dataset/transforms-test
- (with-transform-cleanup! [table-name "type_update_transform"]
- (let [native-query (lib/native-query (mt/metadata-provider) "SELECT 1")
- mbql-query (mt/mbql-query transforms_products)
- schema (get-test-schema)
- created (mt/user-http-request :crowberto :post 200 "ee/transform"
- {:name "Native Transform"
- :source {:type "query"
- :query native-query}
- :target {:type "table"
- :schema schema
- :name table-name}})]
- (is (= "native" (:source_type created)))
-
- (testing "Type automatically changes to mbql when updating to an MBQL query"
- (let [updated (mt/user-http-request :crowberto :put 200
- (format "ee/transform/%s" (:id created))
- {:source {:type "query"
- :query mbql-query}})]
- (is (= "mbql" (:source_type updated))))))))))))
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (mt/with-db-perm-for-group! (perms-group/all-users) (mt/id) :perms/transforms :yes
+ (with-transform-cleanup! [table-name "type_update_transform"]
+ (let [native-query (lib/native-query (mt/metadata-provider) "SELECT 1")
+ mbql-query (mt/mbql-query transforms_products)
+ schema (get-test-schema)
+ created (mt/user-http-request :lucky :post 200 "ee/transform"
+ {:name "Native Transform"
+ :source {:type "query"
+ :query native-query}
+ :target {:type "table"
+ :schema schema
+ :name table-name}})]
+ (is (= "native" (:source_type created)))
+
+ (testing "Type automatically changes to mbql when updating to an MBQL query"
+ (let [updated (mt/user-http-request :lucky :put 200
+ (format "ee/transform/%s" (:id created))
+ {:source {:type "query"
+ :query mbql-query}})]
+ (is (= "mbql" (:source_type updated))))))))))))))
(deftest create-transform-feature-flag-test
(mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
(testing "Creating a query transform without :transforms feature returns 403"
(mt/with-premium-features #{}
(mt/dataset transforms-dataset/transforms-test
- (let [query (make-query "Gadget")
- schema (get-test-schema)
- response (mt/user-http-request :crowberto :post 402 "ee/transform"
- {:name "Test Transform"
- :source {:type "query"
- :query query}
- :target {:type "table"
- :schema schema
- :name "test_transform"}})]
- (is (= "error-premium-feature-not-available" (:status response)))))))
-
- (testing "Creating a query transform with :transforms feature succeeds"
- (mt/with-premium-features #{:transforms}
- (mt/dataset transforms-dataset/transforms-test
- (with-transform-cleanup! [table-name "test_query_transform"]
- (let [query (make-query "Gadget")
- schema (get-test-schema)
- response (mt/user-http-request :crowberto :post 200 "ee/transform"
- {:name "Test Transform"
- :source {:type "query"
- :query query}
- :target {:type "table"
- :schema schema
- :name table-name}})]
- (is (some? (:id response))))))))))
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (mt/with-db-perm-for-group! (perms-group/all-users) (mt/id) :perms/transforms :yes
+ (let [query (make-query "Gadget")
+ schema (get-test-schema)
+ response (mt/user-http-request :lucky :post 402 "ee/transform"
+ {:name "Test Transform"
+ :source {:type "query"
+ :query query}
+ :target {:type "table"
+ :schema schema
+ :name "test_transform"}})]
+ (is (= "error-premium-feature-not-available" (:status response))))))))
+
+ (testing "Creating a query transform with :transforms feature succeeds"
+ (mt/with-premium-features #{:transforms}
+ (mt/dataset transforms-dataset/transforms-test
+ (mt/with-db-perm-for-group! (perms-group/all-users) (mt/id) :perms/transforms :yes
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (with-transform-cleanup! [table-name "test_query_transform"]
+ (let [query (make-query "Gadget")
+ schema (get-test-schema)
+ response (mt/user-http-request :lucky :post 200 "ee/transform"
+ {:name "Test Transform"
+ :source {:type "query"
+ :query query}
+ :target {:type "table"
+ :schema schema
+ :name table-name}})]
+ (is (some? (:id response)))))))))))))
(deftest update-transform-feature-flag-test
(mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
- (testing "Updating a query transform requires :transforms feature"
- (mt/with-premium-features #{:transforms}
- (mt/dataset transforms-dataset/transforms-test
- (with-transform-cleanup! [table-name "test_update"]
- (let [query (make-query "Gadget")
- schema (get-test-schema)
- transform-payload {:name "Original Transform"
- :source {:type "query"
- :query query}
- :target {:type "table"
- :schema schema
- :name table-name}}
- created (mt/user-http-request :crowberto :post 200 "ee/transform" transform-payload)]
- ;; Now test update without feature flag
- (mt/with-premium-features #{}
- (let [response (mt/user-http-request :crowberto :put
- (format "ee/transform/%d" (:id created))
- (assoc transform-payload :name "Updated Transform"))]
- (is (= "error-premium-feature-not-available" (:status response))))))))))))
+ (mt/with-premium-features #{:transforms}
+ (mt/dataset transforms-dataset/transforms-test
+ (mt/with-db-perm-for-group! (perms-group/all-users) (mt/id) :perms/transforms :yes
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (testing "Updating a query transform requires :transforms feature"
+ (with-transform-cleanup! [table-name "test_update"]
+ (let [query (make-query "Gadget")
+ schema (get-test-schema)
+ transform-payload {:name "Original Transform"
+ :source {:type "query"
+ :query query}
+ :target {:type "table"
+ :schema schema
+ :name table-name}}
+ created (mt/user-http-request :lucky :post 200 "ee/transform" transform-payload)]
+ ;; Now test update without feature flag
+ (mt/with-premium-features #{}
+ (let [response (mt/user-http-request :lucky :put
+ (format "ee/transform/%d" (:id created))
+ (assoc transform-payload :name "Updated Transform"))]
+ (is (= "error-premium-feature-not-available" (:status response))))))))))))))
(deftest run-transform-feature-flag-test
(mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
(testing "Running a query transform requires :transforms feature"
(mt/with-premium-features #{:transforms}
(mt/dataset transforms-dataset/transforms-test
- (with-transform-cleanup! [table-name "test_run"]
- (let [query (make-query "Gadget")
- schema (get-test-schema)
- transform-payload {:name "Test Run Transform"
- :source {:type "query"
- :query query}
- :target {:type "table"
- :schema schema
- :name table-name}}
- created (mt/user-http-request :crowberto :post 200 "ee/transform" transform-payload)]
- ;; Now test run without feature flag
- (mt/with-premium-features #{}
- (let [response (mt/user-http-request :crowberto :post
- (format "ee/transform/%d/run" (:id created)))]
- (is (= "error-premium-feature-not-available" (:status response))))))))))))
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (mt/with-db-perm-for-group! (perms-group/all-users) (mt/id) :perms/transforms :yes
+ (with-transform-cleanup! [table-name "test_run"]
+ (let [query (make-query "Gadget")
+ schema (get-test-schema)
+ transform-payload {:name "Test Run Transform"
+ :source {:type "query"
+ :query query}
+ :target {:type "table"
+ :schema schema
+ :name table-name}}
+ created (mt/user-http-request :lucky :post 200 "ee/transform" transform-payload)]
+ ;; Now test run without feature flag
+ (mt/with-premium-features #{}
+ (let [response (mt/user-http-request :lucky :post
+ (format "ee/transform/%d/run" (:id created)))]
+ (is (= "error-premium-feature-not-available" (:status response))))))))))))))
(deftest list-transforms-test
(mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
- (testing "Can list without query parameters"
- (mt/with-premium-features #{:transforms}
- (mt/user-http-request :crowberto :get 200 "ee/transform")))
- (testing "Can list with query parameters"
- (mt/with-premium-features #{:transforms}
- (mt/dataset transforms-dataset/transforms-test
- (with-transform-cleanup! [table-name "gadget_products"]
- (let [body {:name "Gadget Products"
- :description "Desc"
- :source {:type "query"
- :query (make-query "Gadget")}
- :target {:type "table"
- :schema (get-test-schema)
- :name table-name}}
- _ (mt/user-http-request :crowberto :post 200 "ee/transform" body)
- list-resp (mt/user-http-request :crowberto :get 200 "ee/transform")
- crowberto-id (mt/user->id :crowberto)]
- (is (seq list-resp))
- (testing "List response hydrates creator"
- (is (every? #(map? (:creator %)) list-resp))
- (is (some #(= crowberto-id (get-in % [:creator :id])) list-resp))))))))))
+ (mt/with-premium-features #{:transforms}
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (testing "Can list without query parameters"
+ (mt/with-db-perm-for-group! (perms-group/all-users) (mt/id) :perms/transforms :yes
+ (mt/user-http-request :lucky :get 200 "ee/transform")))
+ (testing "Can list with query parameters"
+ (mt/dataset transforms-dataset/transforms-test
+ (mt/with-db-perm-for-group! (perms-group/all-users) (mt/id) :perms/transforms :yes
+ (with-transform-cleanup! [table-name "gadget_products"]
+ (let [body {:name "Gadget Products"
+ :description "Desc"
+ :source {:type "query"
+ :query (make-query "Gadget")}
+ :target {:type "table"
+ :schema (get-test-schema)
+ :name table-name}}
+ _ (mt/user-http-request :lucky :post 200 "ee/transform" body)
+ list-resp (mt/user-http-request :lucky :get 200 "ee/transform")
+ lucky-id (mt/user->id :lucky)]
+ (is (seq list-resp))
+ (testing "List response hydrates creator"
+ (is (every? #(map? (:creator %)) list-resp))
+ (is (some #(= lucky-id (get-in % [:creator :id])) list-resp)))
+ (testing "List response includes source_readable field"
+ (is (every? #(contains? % :source_readable) list-resp))
+ (is (some #(true? (:source_readable %)) list-resp)
+ "At least one transform should have readable sources")))))))))))
(deftest filter-transforms-test
(testing "should be able to filter transforms"
(mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
(mt/with-premium-features #{:transforms}
- (mt/with-temp [:model/Transform {t1-id :id} {}
- :model/Transform {t2-id :id} {}
- :model/TransformTag {tag1-id :id} {:name "tag1"}
- :model/TransformTag {tag2-id :id} {:name "tag2"}
- :model/TransformTransformTag _ {:transform_id t1-id :tag_id tag1-id :position 1}
- :model/TransformTransformTag _ {:transform_id t2-id :tag_id tag2-id :position 1}
- :model/TransformRun _ {:transform_id t1-id :status "started" :run_method "manual"
- :start_time (parse-instant "2025-08-26T10:12:11")
- :end_time nil
- :is_active true}]
- (testing "no filters"
- (is (=? [{:id t1-id} {:id t2-id}]
- (mt/user-http-request :crowberto :get 200 "ee/transform"))))
- (testing "last_run_start_time filter"
- (is (=? [{:id t1-id}]
- (mt/user-http-request :crowberto :get 200 "ee/transform" :last_run_start_time "2025-08-26T10:12:11"))))
- (testing "last_run_statuses filter"
- (is (=? [{:id t1-id}]
- (mt/user-http-request :crowberto :get 200 "ee/transform" :last_run_statuses ["started" "succeeded"]))))
- (testing "tag_ids filter"
- (is (=? [{:id t1-id}]
- (mt/user-http-request :crowberto :get 200 "ee/transform" :tag_ids [tag1-id])))
- (is (=? [{:id t2-id}]
- (mt/user-http-request :crowberto :get 200 "ee/transform" :tag_ids [tag2-id])))))))))
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (mt/with-temp [:model/Transform {t1-id :id} {}
+ :model/Transform {t2-id :id} {}
+ :model/TransformTag {tag1-id :id} {:name "tag1"}
+ :model/TransformTag {tag2-id :id} {:name "tag2"}
+ :model/TransformTransformTag _ {:transform_id t1-id :tag_id tag1-id :position 1}
+ :model/TransformTransformTag _ {:transform_id t2-id :tag_id tag2-id :position 1}
+ :model/TransformRun _ {:transform_id t1-id :status "started" :run_method "manual"
+ :start_time (parse-instant "2025-08-26T10:12:11")
+ :end_time nil
+ :is_active true}]
+ (testing "no filters"
+ (is (=? [{:id t1-id} {:id t2-id}]
+ (mt/user-http-request :lucky :get 200 "ee/transform"))))
+ (testing "last_run_start_time filter"
+ (is (=? [{:id t1-id}]
+ (mt/user-http-request :lucky :get 200 "ee/transform" :last_run_start_time "2025-08-26T10:12:11"))))
+ (testing "last_run_statuses filter"
+ (is (=? [{:id t1-id}]
+ (mt/user-http-request :lucky :get 200 "ee/transform" :last_run_statuses ["started" "succeeded"]))))
+ (testing "tag_ids filter"
+ (is (=? [{:id t1-id}]
+ (mt/user-http-request :lucky :get 200 "ee/transform" :tag_ids [tag1-id])))
+ (is (=? [{:id t2-id}]
+ (mt/user-http-request :lucky :get 200 "ee/transform" :tag_ids [tag2-id]))))))))))
(deftest get-transforms-test
(mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
(mt/with-premium-features #{:transforms}
(mt/dataset transforms-dataset/transforms-test
- (with-transform-cleanup! [table-name "gadget_products"]
- (let [body {:name "Gadget Products"
- :description "Desc"
- :source {:type "query"
- :query (make-query "Gadget")}
- :target {:type "table"
- :schema (get-test-schema)
- :name table-name}}
- resp (mt/user-http-request :crowberto :post 200 "ee/transform" body)
- get-resp (mt/user-http-request :crowberto :get 200 (format "ee/transform/%s" (:id resp)))
- crowberto-id (mt/user->id :crowberto)]
- (is (=? (m/dissoc-in body [:source :query :lib/metadata])
- (update-in get-resp [:source :query] lib/normalize)))
- (testing "GET response hydrates creator"
- (is (map? (:creator get-resp)))
- (is (= crowberto-id (get-in get-resp [:creator :id]))))))))))
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (mt/with-db-perm-for-group! (perms-group/all-users) (mt/id) :perms/transforms :yes
+ (with-transform-cleanup! [table-name "gadget_products"]
+ (let [body {:name "Gadget Products"
+ :description "Desc"
+ :source {:type "query"
+ :query (make-query "Gadget")}
+ :target {:type "table"
+ :schema (get-test-schema)
+ :name table-name}}
+ resp (mt/user-http-request :lucky :post 200 "ee/transform" body)
+ get-resp (mt/user-http-request :lucky :get 200 (format "ee/transform/%s" (:id resp)))
+ lucky-id (mt/user->id :lucky)]
+ (is (=? (m/dissoc-in body [:source :query :lib/metadata])
+ (update-in get-resp [:source :query] lib/normalize)))
+ (testing "GET response hydrates creator"
+ (is (map? (:creator get-resp)))
+ (is (= lucky-id (get-in get-resp [:creator :id]))))))))))))
+
+(deftest source-readable-field-test
+ (testing "Transforms API includes source_readable field"
+ (mt/with-premium-features #{:transforms}
+ (mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
+ (mt/dataset transforms-dataset/transforms-test
+ (with-transform-cleanup! [table-name "test_readable"]
+ (let [body {:name "Test Transform"
+ :description "Test"
+ :source {:type "query"
+ :query (make-query "Gadget")}
+ :target {:type "table"
+ :schema (get-test-schema)
+ :name table-name}}]
+ (testing "Users with transforms permission can see source_readable field"
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (mt/with-db-perm-for-group! (perms-group/all-users) (mt/id) :perms/transforms :yes
+ (let [created (mt/user-http-request :lucky :post 200 "ee/transform" body)]
+ (testing "in POST /ee/transform response"
+ (is (contains? created :source_readable))
+ (is (boolean? (:source_readable created))))
+
+ (testing "in GET /ee/transform response"
+ (let [list-resp (mt/user-http-request :lucky :get 200 "ee/transform")]
+ (is (every? #(contains? % :source_readable) list-resp))
+ (is (every? #(boolean? (:source_readable %)) list-resp))))
+
+ (testing "in GET /ee/transform/:id response"
+ (let [get-resp (mt/user-http-request :lucky :get 200 (format "ee/transform/%s" (:id created)))]
+ (is (contains? get-resp :source_readable))
+ (is (boolean? (:source_readable get-resp)))))
+
+ (testing "source_readable is true when user has database read permission"
+ (let [get-resp (mt/user-http-request :lucky :get 200 (format "ee/transform/%s" (:id created)))]
+ (is (true? (:source_readable get-resp))
+ "User with transforms permission should be able to read the source database"))))))))))))))
(defn- ->transform [transform-name query]
{:source {:type "query",
@@ -396,129 +458,140 @@
:type "table"}})
(deftest get-transform-dependencies-test
- (mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
- (mt/with-temp [:model/Table {table :id} {:schema "public", :name "orders_2"}
- :model/Field _ {:table_id table, :name "foo"}
- :model/Transform parent (->transform "transform1" (mt/mbql-query orders))
- :model/Transform child (-> (->transform "transform2" (mt/mbql-query nil {:source-table table}))
- (assoc-in [:target :name] "orders_3"))]
- (mt/with-premium-features #{:transforms}
- (let [deps-resp (mt/user-http-request :crowberto :get 200 (format "ee/transform/%s/dependencies" (:id child)))]
- (is (=? [{:name "transform1"
- :source {:type "query"
- :query {:database (mt/id)
- :lib/type "mbql/query"
- :stages [{:source-table (mt/id :orders)}]}}
- :id (:id parent)
- :entity_id (:entity_id parent)
- :target {:schema "public", :name "orders_2", :type "table"}}]
- deps-resp))
- (testing "Dependencies response hydrates creator"
- (is (every? #(map? (:creator %)) deps-resp))))))))
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
+ (mt/with-temp [:model/Table {table :id} {:schema "public", :name "orders_2"}
+ :model/Field _ {:table_id table, :name "foo"}
+ :model/Transform parent (->transform "transform1" (mt/mbql-query orders))
+ :model/Transform child (-> (->transform "transform2" (mt/mbql-query nil {:source-table table}))
+ (assoc-in [:target :name] "orders_3"))]
+ (mt/with-premium-features #{:transforms}
+ (let [deps-resp (mt/user-http-request :lucky :get 200 (format "ee/transform/%s/dependencies" (:id child)))]
+ (is (=? [{:name "transform1"
+ :source {:type "query"
+ :query {:database (mt/id)
+ :lib/type "mbql/query"
+ :stages [{:source-table (mt/id :orders)}]}}
+ :id (:id parent)
+ :entity_id (:entity_id parent)
+ :target {:schema "public", :name "orders_2", :type "table"}}]
+ deps-resp))
+ (testing "Dependencies response hydrates creator"
+ (is (every? #(map? (:creator %)) deps-resp)))))))))
(deftest put-transforms-test
(mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
(mt/with-premium-features #{:transforms}
(mt/dataset transforms-dataset/transforms-test
- (with-transform-cleanup! [table-name "gadget_products"]
- (let [query2 (make-query "None")
- resp (mt/user-http-request :crowberto :post 200 "ee/transform"
- {:name "Gadget Products"
- :source {:type "query"
- :query (make-query "Gadget")}
- :target {:type "table"
- :schema (get-test-schema)
- :name table-name}})
- transform {:name "Gadget Products 2"
- :description "Desc"
- :source {:type "query"
- :query query2}
- :target {:type "table"
- :schema (get-test-schema)
- :name table-name}}
- put-resp (mt/user-http-request :crowberto :put 200 (format "ee/transform/%s" (:id resp))
- transform)
- crowberto-id (mt/user->id :crowberto)]
- (is (=? (m/dissoc-in transform [:source :query :lib/metadata])
- (update-in put-resp [:source :query] lib/normalize)))
- (testing "PUT response hydrates creator"
- (is (map? (:creator put-resp)))
- (is (= crowberto-id (get-in put-resp [:creator :id]))))))))))
+ (mt/with-db-perm-for-group! (perms-group/all-users) (mt/id) :perms/transforms :yes
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (with-transform-cleanup! [table-name "gadget_products"]
+ (let [query2 (make-query "None")
+ resp (mt/user-http-request :lucky :post 200 "ee/transform"
+ {:name "Gadget Products"
+ :source {:type "query"
+ :query (make-query "Gadget")}
+ :target {:type "table"
+ :schema (get-test-schema)
+ :name table-name}})
+ transform {:name "Gadget Products 2"
+ :description "Desc"
+ :source {:type "query"
+ :query query2}
+ :target {:type "table"
+ :schema (get-test-schema)
+ :name table-name}}
+ put-resp (mt/user-http-request :lucky :put 200 (format "ee/transform/%s" (:id resp))
+ transform)
+ lucky-id (mt/user->id :lucky)]
+ (is (=? (m/dissoc-in transform [:source :query :lib/metadata])
+ (update-in put-resp [:source :query] lib/normalize)))
+ (testing "PUT response hydrates creator"
+ (is (map? (:creator put-resp)))
+ (is (= lucky-id (get-in put-resp [:creator :id]))))))))))))
(deftest change-target-table-test
(mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
(mt/with-premium-features #{:transforms}
(mt/dataset transforms-dataset/transforms-test
- (with-transform-cleanup! [table1-name "dookey_products"
- table2-name "doohickey_products"]
- (let [query2 (make-query "Doohickey")
- original {:name "Gadget Products"
- :source {:type "query"
- :query (make-query "Gadget")}
- :target {:type "table"
- :schema (get-test-schema)
- :name table1-name}}
- resp (mt/user-http-request :crowberto :post 200 "ee/transform"
- original)
- updated {:name "Doohickey Products"
- :description "Desc"
- :source {:type "query"
- :query query2}
- :target {:type "table"
- :schema (get-test-schema)
- :name table2-name}}]
- (is (=? (-> updated
- (m/dissoc-in [:source :query :lib/metadata]))
- (-> (mt/user-http-request :crowberto :put 200 (format "ee/transform/%s" (:id resp)) updated)
- (update-in [:source :query] lib/normalize))))
- (is (false? (transforms.util/target-table-exists? original)))))))))
+ (mt/with-db-perm-for-group! (perms-group/all-users) (mt/id) :perms/transforms :yes
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (with-transform-cleanup! [table1-name "dookey_products"
+ table2-name "doohickey_products"]
+ (let [query2 (make-query "Doohickey")
+ original {:name "Gadget Products"
+ :source {:type "query"
+ :query (make-query "Gadget")}
+ :target {:type "table"
+ :schema (get-test-schema)
+ :name table1-name}}
+ resp (mt/user-http-request :lucky :post 200 "ee/transform"
+ original)
+ updated {:name "Doohickey Products"
+ :description "Desc"
+ :source {:type "query"
+ :query query2}
+ :target {:type "table"
+ :schema (get-test-schema)
+ :name table2-name}}]
+ (is (=? (-> updated
+ (m/dissoc-in [:source :query :lib/metadata]))
+ (-> (mt/user-http-request :lucky :put 200 (format "ee/transform/%s" (:id resp)) updated)
+ (update-in [:source :query] lib/normalize))))
+ (is (false? (transforms.util/target-table-exists? original)))))))))))
(deftest delete-transforms-test
(mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
(mt/with-premium-features #{:transforms}
(mt/dataset transforms-dataset/transforms-test
- (with-transform-cleanup! [table-name "gadget_products"]
- (let [resp (mt/user-http-request :crowberto :post 200 "ee/transform"
- {:name "Gadget Products"
- :source {:type "query"
- :query (make-query "Gadget")}
- :target {:type "table"
- :schema (get-test-schema)
- :name table-name}})]
- (mt/user-http-request :crowberto :delete 204 (format "ee/transform/%s" (:id resp)))
- (mt/user-http-request :crowberto :get 404 (format "ee/transform/%s" (:id resp)))))))))
+ (mt/with-db-perm-for-group! (perms-group/all-users) (mt/id) :perms/transforms :yes
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (with-transform-cleanup! [table-name "gadget_products"]
+ (let [resp (mt/user-http-request :lucky :post 200 "ee/transform"
+ {:name "Gadget Products"
+ :source {:type "query"
+ :query (make-query "Gadget")}
+ :target {:type "table"
+ :schema (get-test-schema)
+ :name table-name}})]
+ (mt/user-http-request :lucky :delete 204 (format "ee/transform/%s" (:id resp)))
+ (mt/user-http-request :lucky :get 404 (format "ee/transform/%s" (:id resp)))))))))))
(deftest delete-table-transforms-test
(mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
(mt/with-premium-features #{:transforms}
(mt/dataset transforms-dataset/transforms-test
- (with-transform-cleanup! [table-name "gadget_products"]
- (let [resp (mt/user-http-request :crowberto :post 200 "ee/transform"
- {:name "Gadget Products"
- :source {:type "query"
- :query (make-query "Gadget")}
- :target {:type "table"
- :schema (get-test-schema)
- :name table-name}})]
- (mt/user-http-request :crowberto :delete 204 (format "ee/transform/%s/table" (:id resp)))))))))
+ (mt/with-db-perm-for-group! (perms-group/all-users) (mt/id) :perms/transforms :yes
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (with-transform-cleanup! [table-name "gadget_products"]
+ (let [resp (mt/user-http-request :lucky :post 200 "ee/transform"
+ {:name "Gadget Products"
+ :source {:type "query"
+ :query (make-query "Gadget")}
+ :target {:type "table"
+ :schema (get-test-schema)
+ :name table-name}})]
+ (mt/user-http-request :lucky :delete 204 (format "ee/transform/%s/table" (:id resp)))))))))))
-(defn- test-run
+(defn- test-run!
[transform-id]
- (let [resp (mt/user-http-request :crowberto :post 202 (format "ee/transform/%s/run" transform-id))
- timeout-s 10 ; 10 seconds is our timeout to finish execution and sync
- limit (+ (System/currentTimeMillis) (* timeout-s 1000))]
- (is (=? {:message "Transform run started"}
- resp))
- (loop []
- (when (> (System/currentTimeMillis) limit)
- (throw (ex-info (str "Transform run timed out after " timeout-s " seconds") {})))
- (let [resp (mt/user-http-request :crowberto :get 200 (format "ee/transform/%s" transform-id))
- status (some-> resp :last_run :status keyword)]
- (when-not (contains? #{:started :succeeded} status)
- (throw (ex-info (str "Transform run failed with status " status) {:resp resp})))
- (when-not (some? (:table resp))
- (Thread/sleep 100)
- (recur))))))
+ (mt/with-db-perm-for-group! (perms-group/all-users) (mt/id) :perms/transforms :yes
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (let [resp (mt/user-http-request :lucky :post 202 (format "ee/transform/%s/run" transform-id))
+ timeout-s 10 ; 10 seconds is our timeout to finish execution and sync
+ limit (+ (System/currentTimeMillis) (* timeout-s 1000))]
+ (is (=? {:message "Transform run started"}
+ resp))
+ (loop []
+ (when (> (System/currentTimeMillis) limit)
+ (throw (ex-info (str "Transform run timed out after " timeout-s " seconds") {})))
+ (let [resp (mt/user-http-request :lucky :get 200 (format "ee/transform/%s" transform-id))
+ status (some-> resp :last_run :status keyword)]
+ (when-not (contains? #{:started :succeeded} status)
+ (throw (ex-info (str "Transform run failed with status " status) {:resp resp})))
+ (when-not (some? (:table resp))
+ (Thread/sleep 100)
+ (recur))))))))
(defn- check-query-results
"Verifies that a transform successfully created a table with expected data.
@@ -576,60 +649,63 @@
(mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
(mt/with-premium-features #{:transforms}
(mt/dataset transforms-dataset/transforms-test
- (let [schema (t2/select-one-fn :schema :model/Table (mt/id :transforms_products))]
- (with-transform-cleanup! [{table1-name :name :as target1} {:type "table"
- :schema schema
- :name "gadget_products"}
- {table2-name :name :as target2} {:type "table"
- :schema schema
- :name "doohickey_products"}]
- (let [query2 (make-query "Doohickey")
- original {:name "Gadget Products"
- :source {:type "query"
- :query (make-query "Gadget")}
- :target target1}
- {transform-id :id} (mt/user-http-request :crowberto :post 200 "ee/transform"
- original)
- _ (do (test-run transform-id)
- (wait-for-table table1-name 5000))
- _ (is (true? (transforms.util/target-table-exists? original)))
- _ (check-query-results table1-name [5 11 16] "Gadget")
- updated {:name "Doohickey Products"
- :description "Desc"
- :source {:type "query"
- :query query2}
- :target target2}]
- (is (=? (-> updated
- (m/dissoc-in [:source :query :lib/metadata]))
- (->
- (mt/user-http-request :crowberto :put 200 (format "ee/transform/%s" transform-id) updated)
- (update-in [:source :query] lib/normalize))))
- (test-run transform-id)
- (wait-for-table table2-name 5000)
- (is (true? (transforms.util/target-table-exists? original)))
- (is (true? (transforms.util/target-table-exists? updated)))
- (check-query-results table2-name [2 3 4 13] "Doohickey")))))))))
+ (mt/with-db-perm-for-group! (perms-group/all-users) (mt/id) :perms/transforms :yes
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (let [schema (t2/select-one-fn :schema :model/Table (mt/id :transforms_products))]
+ (with-transform-cleanup! [{table1-name :name :as target1} {:type "table"
+ :schema schema
+ :name "gadget_products"}
+ {table2-name :name :as target2} {:type "table"
+ :schema schema
+ :name "doohickey_products"}]
+ (let [query2 (make-query "Doohickey")
+ original {:name "Gadget Products"
+ :source {:type "query"
+ :query (make-query "Gadget")}
+ :target target1}
+ {transform-id :id} (mt/user-http-request :lucky :post 200 "ee/transform"
+ original)
+ _ (do (test-run! transform-id)
+ (wait-for-table table1-name 5000))
+ _ (is (true? (transforms.util/target-table-exists? original)))
+ _ (check-query-results table1-name [5 11 16] "Gadget")
+ updated {:name "Doohickey Products"
+ :description "Desc"
+ :source {:type "query"
+ :query query2}
+ :target target2}]
+ (is (=? (-> updated
+ (m/dissoc-in [:source :query :lib/metadata]))
+ (->
+ (mt/user-http-request :lucky :put 200 (format "ee/transform/%s" transform-id) updated)
+ (update-in [:source :query] lib/normalize))))
+ (test-run! transform-id)
+ (wait-for-table table2-name 5000)
+ (is (true? (transforms.util/target-table-exists? original)))
+ (is (true? (transforms.util/target-table-exists? updated)))
+ (check-query-results table2-name [2 3 4 13] "Doohickey")))))))))))
(deftest get-runs-filter-by-single-transform-id-test
(testing "GET /api/ee/transform/run - filter by single transform ID"
- (mt/with-premium-features #{:transforms}
- (mt/with-temp [:model/Transform transform1 {}
- :model/Transform transform2 {}
- :model/TransformRun run1 {:transform_id (:id transform1)}
- :model/TransformRun run2 {:transform_id (:id transform2)}]
- (testing "Filter by transform1 ID only returns transform1 runs"
- (let [response (mt/user-http-request :crowberto :get 200 "ee/transform/run"
- :transform_ids [(:id transform1)])]
- (assert-run-count response 1)
- (assert-transform-ids response #{(:id transform1)})
- (is (= (:id run1) (-> response :data first :id)))))
-
- (testing "Filter by transform2 ID only returns transform2 runs"
- (let [response (mt/user-http-request :crowberto :get 200 "ee/transform/run"
- :transform_ids [(:id transform2)])]
- (assert-run-count response 1)
- (assert-transform-ids response #{(:id transform2)})
- (is (= (:id run2) (-> response :data first :id)))))))))
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (mt/with-premium-features #{:transforms}
+ (mt/with-temp [:model/Transform transform1 {}
+ :model/Transform transform2 {}
+ :model/TransformRun run1 {:transform_id (:id transform1)}
+ :model/TransformRun run2 {:transform_id (:id transform2)}]
+ (testing "Filter by transform1 ID only returns transform1 runs"
+ (let [response (mt/user-http-request :lucky :get 200 "ee/transform/run"
+ :transform_ids [(:id transform1)])]
+ (assert-run-count response 1)
+ (assert-transform-ids response #{(:id transform1)})
+ (is (= (:id run1) (-> response :data first :id)))))
+
+ (testing "Filter by transform2 ID only returns transform2 runs"
+ (let [response (mt/user-http-request :lucky :get 200 "ee/transform/run"
+ :transform_ids [(:id transform2)])]
+ (assert-run-count response 1)
+ (assert-transform-ids response #{(:id transform2)})
+ (is (= (:id run2) (-> response :data first :id))))))))))
(deftest get-runs-filter-by-multiple-transform-ids-test
(testing "GET /api/ee/transform/run - filter by multiple transform IDs"
@@ -938,19 +1014,21 @@
(mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
(mt/with-premium-features #{:transforms :database-routing}
(mt/dataset transforms-dataset/transforms-test
- (with-transform-cleanup! [table-name "gadget_products"]
- (let [query (make-query "Gadget")
- schema (get-test-schema)]
- (mt/with-temp [:model/Database _destination {:engine driver/*driver*
- :router_database_id (mt/id)
- :details {:destination_database true}}
- :model/DatabaseRouter _ {:database_id (mt/id)
- :user_attribute "db_name"}]
- (is (= "Transforms are not supported on databases with DB routing enabled."
- (mt/user-http-request :crowberto :post 400 "ee/transform"
- {:name "Gadget Products"
- :source {:type "query" :query query}
- :target {:type "table" :schema schema :name table-name}}))))))))))
+ (mt/with-db-perm-for-group! (perms-group/all-users) (mt/id) :perms/transforms :yes
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (with-transform-cleanup! [table-name "gadget_products"]
+ (let [query (make-query "Gadget")
+ schema (get-test-schema)]
+ (mt/with-temp [:model/Database _destination {:engine driver/*driver*
+ :router_database_id (mt/id)
+ :details {:destination_database true}}
+ :model/DatabaseRouter _ {:database_id (mt/id)
+ :user_attribute "db_name"}]
+ (is (= "Transforms are not supported on databases with DB routing enabled."
+ (mt/user-http-request :crowberto :post 400 "ee/transform"
+ {:name "Gadget Products"
+ :source {:type "query" :query query}
+ :target {:type "table" :schema schema :name table-name}}))))))))))))
(deftest update-transform-with-routing-fails-test
(mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
@@ -1010,6 +1088,29 @@
:name table-name}}]
(test-transform-revisions :put (str "ee/transform/" transform-id) widget-req 2)))))))
+(deftest permissions-test
+ (testing "Transform endpoints require transforms permission"
+ (mt/with-premium-features #{:transforms}
+ (mt/with-temp [:model/Transform transform {}]
+ (testing "Regular users without transform permission get 403"
+ (mt/user-http-request :rasta :get 403 "ee/transform")
+ (mt/user-http-request :rasta :get 403 (str "ee/transform/" (:id transform)))
+ (mt/user-http-request :rasta :post 403 "ee/transform"
+ {:name "Test"
+ :source {:type "query"
+ :query {:database (mt/id)
+ :type "native"
+ :native {:query "SELECT 1"}}}
+ :target {:type "table" :name "test_table"}})
+ (mt/user-http-request :rasta :put 403 (str "ee/transform/" (:id transform))
+ {:name "Updated"})
+ (mt/user-http-request :rasta :delete 403 (str "ee/transform/" (:id transform))))
+
+ (testing "Data analysts can read transforms"
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (mt/user-http-request :lucky :get 200 "ee/transform")
+ (mt/user-http-request :lucky :get 200 (str "ee/transform/" (:id transform)))))))))
+
(defmethod driver/database-supports? [::driver/driver ::extract-columns-from-query]
[_driver _feature _database]
true)
@@ -1152,38 +1253,259 @@
(deftest collection-items-include-transforms-test
(testing "GET /api/collection/:id/items"
(testing "Includes transforms in collection items"
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (mt/with-premium-features #{:transforms}
+ (mt/with-temp [:model/Collection {collection-id :id} {:name "Transforms Collection"
+ :namespace :transforms}
+ :model/Transform {transform-id :id}
+ {:name "Test Transform"
+ :description "A test transform"
+ :collection_id collection-id}]
+ ;; Test 1: Transform appears in unfiltered results
+ (let [items (:data (mt/user-http-request :lucky :get 200
+ (format "collection/%d/items" collection-id)))]
+ (is (= 1 (count items)))
+ (is (= "transform" (:model (first items))))
+ (is (= "Test Transform" (:name (first items)))))
+
+ ;; Test 2: Transform appears when filtered by models=transform
+ (let [items (:data (mt/user-http-request :lucky :get 200
+ (format "collection/%d/items" collection-id)
+ :models "transform"))]
+ (is (= 1 (count items)))
+ (is (= transform-id (:id (first items)))))
+
+ ;; Test 3: Transform NOT returned when filtering for other models only
+ (let [items (:data (mt/user-http-request :lucky :get 200
+ (format "collection/%d/items" collection-id)
+ :models "card"))]
+ (is (empty? items)))
+
+ ;; Test 4: Non-analysts users don't see transforms
+ (perms/grant-collection-read-permissions! (perms/all-users-group) collection-id)
+ (let [items (:data (mt/user-http-request :rasta :get 200
+ (format "collection/%d/items" collection-id)))]
+ (is (empty? items)))
+
+ ;; Test 5: Admins see transforms
+ (let [items (:data (mt/user-http-request :crowberto :get 200
+ (format "collection/%d/items" collection-id)))]
+ (is (= 1 (count items)))
+ (is (= "transform" (:model (first items))))
+ (is (= "Test Transform" (:name (first items)))))))))))
+
+(deftest create-transform-with-tags-test
+ (testing "POST /api/ee/transform with tag_ids"
+ (mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
(mt/with-premium-features #{:transforms}
- (mt/with-temp [:model/Collection {collection-id :id} {:name "Transforms Collection"
- :namespace :transforms}
- :model/Transform {transform-id :id}
- {:name "Test Transform"
- :description "A test transform"
- :collection_id collection-id}]
- ;; Test 1: Transform appears in unfiltered results
- (let [items (:data (mt/user-http-request :crowberto :get 200
- (format "collection/%d/items" collection-id)))]
- (is (= 1 (count items)))
- (is (= "transform" (:model (first items))))
- (is (= "Test Transform" (:name (first items)))))
-
- ;; Test 2: Transform appears when filtered by models=transform
- (let [items (:data (mt/user-http-request :crowberto :get 200
- (format "collection/%d/items" collection-id)
- :models "transform"))]
- (is (= 1 (count items)))
- (is (= transform-id (:id (first items)))))
-
- ;; Test 3: Transform NOT returned when filtering for other models only
- (let [items (:data (mt/user-http-request :crowberto :get 200
- (format "collection/%d/items" collection-id)
- :models "card"))]
- (is (empty? items)))
-
- ;; Test 4: Non-admin users don't see transforms
- (perms/grant-collection-read-permissions! (perms/all-users-group) collection-id)
- (let [items (:data (mt/user-http-request :rasta :get 200
- (format "collection/%d/items" collection-id)))]
- (is (empty? items))))))))
+ (mt/with-db-perm-for-group! (perms-group/all-users) (mt/id) :perms/transforms :yes
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (let [schema (t2/select-one-fn :schema :model/Table :db_id (mt/id) :active true)]
+ (testing "Can create transform with tags"
+ ;; Create tags via API since we're testing transform creation with existing tags
+ (let [tag1 (mt/user-http-request :lucky :post 200 "ee/transform-tag"
+ {:name (str "test-tag-1-" (random-uuid))})
+ tag2 (mt/user-http-request :lucky :post 200 "ee/transform-tag"
+ {:name (str "test-tag-2-" (random-uuid))})]
+ (try
+ (let [transform-request (-> (merge (mt/with-temp-defaults :model/Transform)
+ {:tag_ids [(:id tag1) (:id tag2)]})
+ (assoc-in [:target :schema] schema))
+ transform-response (mt/user-http-request :lucky :post 200 "ee/transform"
+ transform-request)]
+ (try
+ (is (= (:name transform-request) (:name transform-response)))
+ (is (= (:tag_ids transform-request) (sort (:tag_ids transform-response))))
+ (finally
+ (t2/delete! :model/Transform :id (:id transform-response)))))
+ (finally
+ (t2/delete! :model/TransformTag :id [:in [(:id tag1) (:id tag2)]])))))
+ (testing "Can create transform without tags"
+ (let [transform-request (assoc-in (mt/with-temp-defaults :model/Transform)
+ [:target :schema] schema)
+ transform-response (mt/user-http-request :lucky :post 200 "ee/transform"
+ transform-request)]
+ (try
+ (is (= (:name transform-request) (:name transform-response)))
+ (is (= [] (:tag_ids transform-response)))
+ (finally
+ (t2/delete! :model/Transform :id (:id transform-response)))))))))))))
+
+(deftest update-transform-tags-test
+ (testing "PUT /api/ee/transform/:id with tag_ids"
+ (mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
+ (mt/with-premium-features #{:transforms}
+ (mt/with-db-perm-for-group! (perms-group/all-users) (mt/id) :perms/transforms :yes
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (mt/with-temp [:model/Transform transform {:name "Test Transform"
+ :source {:type "query"
+ :query {:database (mt/id)
+ :type "native"
+ :native {:query "SELECT 1"}}}
+ :target {:type "table"
+ :name "test_table"}}
+ :model/TransformTag tag1 {:name "update-tag-1"}
+ :model/TransformTag tag2 {:name "update-tag-2"}
+ :model/TransformTag tag3 {:name "update-tag-3"}]
+
+ (testing "Can add tags to transform"
+ (let [updated (mt/user-http-request :lucky :put 200 (str "ee/transform/" (:id transform))
+ {:tag_ids [(:id tag1) (:id tag2)]})]
+ (is (= [(:id tag1) (:id tag2)] (sort (:tag_ids updated))))))
+
+ (testing "Can update tags on transform"
+ (let [updated (mt/user-http-request :lucky :put 200 (str "ee/transform/" (:id transform))
+ {:tag_ids [(:id tag2) (:id tag3)]})]
+ (is (= [(:id tag2) (:id tag3)] (sort (:tag_ids updated))))))
+
+ (testing "Can remove all tags from transform"
+ (let [updated (mt/user-http-request :lucky :put 200 (str "ee/transform/" (:id transform))
+ {:tag_ids []})]
+ (is (= [] (:tag_ids updated))))))))))))
+
+(deftest get-transform-with-tags-test
+ (testing "GET /api/ee/transform/:id returns tag_ids"
+ (mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
+ (mt/with-premium-features #{:transforms}
+ (mt/with-db-perm-for-group! (perms-group/all-users) (mt/id) :perms/transforms :yes
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (mt/with-temp [:model/Transform transform {:name "Transform With Tags"
+ :source {:type "query"
+ :query {:database (mt/id)
+ :type "native"
+ :native {:query "SELECT 1"}}}
+ :target {:type "table"
+ :name "tagged_table"}}
+ :model/TransformTag tag1 {:name "get-tag-1"}
+ :model/TransformTag tag2 {:name "get-tag-2"}]
+ ;; Add tags to transform
+ (transform.model/update-transform-tags! (:id transform) [(:id tag1) (:id tag2)])
+
+ (testing "Single transform returns tag_ids"
+ (let [fetched (mt/user-http-request :lucky :get 200 (str "ee/transform/" (:id transform)))]
+ (is (= [(:id tag1) (:id tag2)] (sort (:tag_ids fetched))))))
+
+ (testing "Transform without tags returns empty array"
+ (mt/with-temp [:model/Transform transform2 {:name "Transform Without Tags"
+ :source {:type "query"
+ :query {:database (mt/id)
+ :type "native"
+ :native {:query "SELECT 1"}}}
+ :target {:type "table"
+ :name "untagged_table"}}]
+ (let [fetched (mt/user-http-request :lucky :get 200 (str "ee/transform/" (:id transform2)))]
+ (is (= [] (:tag_ids fetched)))))))))))))
+
+(deftest list-transforms-with-tags-test
+ (testing "GET /api/ee/transform returns transforms with tag_ids"
+ (mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
+ (mt/with-premium-features #{:transforms}
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (mt/with-temp [:model/Transform transform1 {:name "Transform 1"
+ :source {:type "query"
+ :query {:database (mt/id)
+ :type "native"
+ :native {:query "SELECT 1"}}}
+ :target {:type "table"
+ :name "list_table_1"}}
+ :model/Transform transform2 {:name "Transform 2"
+ :source {:type "query"
+ :query {:database (mt/id)
+ :type "native"
+ :native {:query "SELECT 2"}}}
+ :target {:type "table"
+ :name "list_table_2"}}
+ :model/TransformTag tag1 {:name "list-tag-1"}
+ :model/TransformTag tag2 {:name "list-tag-2"}]
+ ;; Add tags to transforms
+ (transform.model/update-transform-tags! (:id transform1) [(:id tag1)])
+ (transform.model/update-transform-tags! (:id transform2) [(:id tag1) (:id tag2)])
+
+ (testing "List endpoint returns all transforms with their tag_ids"
+ (let [transforms (mt/user-http-request :lucky :get 200 "ee/transform")
+ t1 (some #(when (= (:id %) (:id transform1)) %) transforms)
+ t2 (some #(when (= (:id %) (:id transform2)) %) transforms)]
+ (is (= [(:id tag1)] (:tag_ids t1)))
+ (is (= [(:id tag1) (:id tag2)] (sort (:tag_ids t2))))))))))))
+
+(deftest delete-tag-removes-associations-test
+ (testing "Deleting a tag removes it from all transforms"
+ (mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
+ (mt/with-premium-features #{:transforms}
+ (mt/with-db-perm-for-group! (perms-group/all-users) (mt/id) :perms/transforms :yes
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (mt/with-temp [:model/Transform transform {:name "Transform for Delete Test"
+ :source {:type "query"
+ :query {:database (mt/id)
+ :type "native"
+ :native {:query "SELECT 1"}}}
+ :target {:type "table"
+ :name "delete_test_table"}}
+ :model/TransformTag tag2 {:name "tag-to-keep"}]
+ ;; Create tag1 via API since we're testing its deletion
+ (let [tag1 (mt/user-http-request :lucky :post 200 "ee/transform-tag"
+ {:name "tag-to-delete"})]
+ (try
+ ;; Add both tags to transform
+ (transform.model/update-transform-tags! (:id transform) [(:id tag1) (:id tag2)])
+
+ ;; Verify tags are associated
+ (let [fetched (mt/user-http-request :lucky :get 200 (str "ee/transform/" (:id transform)))]
+ (is (= (set [(:id tag1) (:id tag2)]) (set (:tag_ids fetched)))))
+
+ ;; Delete tag1
+ (mt/user-http-request :lucky :delete 204 (str "ee/transform-tag/" (:id tag1)))
+
+ ;; Verify tag1 is removed but tag2 remains
+ (let [fetched (mt/user-http-request :lucky :get 200 (str "ee/transform/" (:id transform)))]
+ (is (= [(:id tag2)] (vec (:tag_ids fetched)))))
+ (finally
+ (t2/delete! :model/TransformTag :id (:id tag1))))))))))))
+
+(deftest preserve-tag-order-test
+ (testing "Tag order is preserved when adding/updating transform tags"
+ (mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
+ (mt/with-premium-features #{:transforms}
+ (mt/with-db-perm-for-group! (perms-group/all-users) (mt/id) :perms/transforms :yes
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (mt/with-temp [:model/TransformTag tag1 {:name "order-tag-1"}
+ :model/TransformTag tag2 {:name "order-tag-2"}
+ :model/TransformTag tag3 {:name "order-tag-3"}]
+
+ (let [schema (t2/select-one-fn :schema :model/Table :db_id (mt/id) :active true)]
+ (testing "Creating transform with specific tag order preserves that order"
+ (let [transform-request (-> (merge (mt/with-temp-defaults :model/Transform)
+ {:tag_ids [(:id tag3) (:id tag1) (:id tag2)]})
+ (assoc-in [:target :schema] schema))
+ transform (mt/user-http-request :lucky :post 200 "ee/transform"
+ transform-request)]
+ (try
+ ;; Should preserve the exact order: tag3, tag1, tag2
+ (is (= [(:id tag3) (:id tag1) (:id tag2)] (:tag_ids transform)))
+ ;; Verify order is preserved when fetching
+ (let [fetched (mt/user-http-request :lucky :get 200 (str "ee/transform/" (:id transform)))]
+ (is (= [(:id tag3) (:id tag1) (:id tag2)] (:tag_ids fetched))))
+ ;; Update with different order
+ (let [updated (mt/user-http-request :lucky :put 200 (str "ee/transform/" (:id transform))
+ {:tag_ids [(:id tag2) (:id tag3) (:id tag1)]})]
+ ;; Should now have the new order: tag2, tag3, tag1
+ (is (= [(:id tag2) (:id tag3) (:id tag1)] (:tag_ids updated))))
+ ;; Verify new order persists
+ (let [fetched-again (mt/user-http-request :lucky :get 200 (str "ee/transform/" (:id transform)))]
+ (is (= [(:id tag2) (:id tag3) (:id tag1)] (:tag_ids fetched-again))))
+ (finally
+ (t2/delete! :model/Transform :id (:id transform))))))
+ (testing "Duplicate tag IDs are handled correctly"
+ (let [transform-request (-> (merge (mt/with-temp-defaults :model/Transform)
+ {:tag_ids [(:id tag1) (:id tag2) (:id tag1)]})
+ (assoc-in [:target :schema] schema))
+ transform (mt/user-http-request :lucky :post 200 "ee/transform"
+ transform-request)]
+ (try
+ ;; Should only have each tag once, but preserve relative order
+ (is (= [(:id tag1) (:id tag2)] (:tag_ids transform)))
+ (finally
+ (t2/delete! :model/Transform :id (:id transform))))))))))))))
(deftest transforms-appear-in-here-test
(testing "GET /api/collection/:id/items"
diff --git a/enterprise/backend/test/metabase_enterprise/transforms/incremental_test.clj b/enterprise/backend/test/metabase_enterprise/transforms/incremental_test.clj
index f750364ce57..1aac4a2cf51 100644
--- a/enterprise/backend/test/metabase_enterprise/transforms/incremental_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/transforms/incremental_test.clj
@@ -135,6 +135,7 @@
(let [schema (t2/select-one-fn :schema :model/Table (mt/id :transforms_products))
{:keys [field-name lib-column-key]} checkpoint-config]
{:name transform-name
+ :source_database_id (mt/id)
:source (case transform-type
:native {:type "query"
:query (make-incremental-source-query schema checkpoint-config)
diff --git a/enterprise/backend/test/metabase_enterprise/transforms/models/transform_test.clj b/enterprise/backend/test/metabase_enterprise/transforms/models/transform_test.clj
new file mode 100644
index 00000000000..8d200497a7c
--- /dev/null
+++ b/enterprise/backend/test/metabase_enterprise/transforms/models/transform_test.clj
@@ -0,0 +1,24 @@
+(ns metabase-enterprise.transforms.models.transform-test
+ (:require
+ [clojure.test :refer :all]
+ [metabase.test :as mt]))
+
+(deftest source-database-id-set-test
+ (testing "inserting a transform correctly sets the source-database-id column"
+ (mt/with-temp [:model/Transform transform
+ {:name "Test Transform"
+ :source {:type "query"
+ :query {:database (mt/id)
+ :type "native"
+ :native {:query "SELECT 1"}}}}]
+ (is (= (mt/id) (:source_database_id transform)))))
+
+ (testing "updating a transform correctly sets the source-database-id column"
+ (mt/with-temp [:model/Transform transform
+ {:name "Test Transform"
+ :source_database_id (mt/id)
+ :source {:type "query"
+ :query {:database (mt/id)
+ :type "native"
+ :native {:query "SELECT 1"}}}}]
+ (is (= (mt/id) (:source_database_id transform))))))
diff --git a/enterprise/backend/test/metabase_enterprise/transforms/models_test.clj b/enterprise/backend/test/metabase_enterprise/transforms/models_test.clj
index 53375b97f0e..a844cf0132e 100644
--- a/enterprise/backend/test/metabase_enterprise/transforms/models_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/transforms/models_test.clj
@@ -281,49 +281,52 @@
:schema "public"}]
(testing "table_id is populated when table exists"
(mt/with-temp [:model/Transform transform {:name "Transform with ref"
- :source {:type "python"
- :body "def transform(): pass"
- :source-tables {"input" {:database_id db-id
- :schema "public"
- :table "existing_table"}}}
+ :source {:type "python"
+ :body "def transform(): pass"
+ :source-database db-id
+ :source-tables {"input" {:database_id db-id
+ :schema "public"
+ :table "existing_table"}}}
:target {:type "table"
:schema "public"
:name "output"
:database db-id}}]
- (let [saved (t2/select-one :model/Transform :id (:id transform))
+ (let [saved (t2/select-one :model/Transform :id (:id transform))
source-table (get-in saved [:source :source-tables "input"])]
(is (= table-id (:table_id source-table))
"table_id should be resolved from database lookup"))))
(testing "table_id remains nil when table doesn't exist"
(mt/with-temp [:model/Transform transform {:name "Transform with missing ref"
- :source {:type "python"
- :body "def transform(): pass"
- :source-tables {"input" {:database_id db-id
- :schema "public"
- :table "nonexistent_table"}}}
+ :source {:type "python"
+ :body "def transform(): pass"
+ :source-database db-id
+ :source-tables {"input" {:database_id db-id
+ :schema "public"
+ :table "nonexistent_table"}}}
:target {:type "table"
:schema "public"
:name "output"
:database db-id}}]
- (let [saved (t2/select-one :model/Transform :id (:id transform))
+ (let [saved (t2/select-one :model/Transform :id (:id transform))
source-table (get-in saved [:source :source-tables "input"])]
(is (nil? (:table_id source-table))
"table_id should be nil for non-existent table"))))
(testing "existing table_id is preserved"
(mt/with-temp [:model/Transform transform {:name "Transform with explicit table_id"
- :source {:type "python"
- :body "def transform(): pass"
- :source-tables {"input" {:database_id db-id
- :schema "public"
- :table "existing_table"
- :table_id 999}}}
+ :source {:type "python"
+ :body "def transform(): pass"
+ :source-database db-id
+ :source-tables {"input" {:database_id db-id
+ :schema "public"
+ :table "existing_table"
+ :table_id 999}}}
:target {:type "table"
:schema "public"
:name "output"
:database db-id}}]
- (let [saved (t2/select-one :model/Transform :id (:id transform))
+ (let [saved (t2/select-one :model/Transform :id (:id transform))
source-table (get-in saved [:source :source-tables "input"])]
(is (= 999 (:table_id source-table))
"explicit table_id should be preserved")))))))
diff --git a/enterprise/backend/test/metabase_enterprise/transforms/util_test.clj b/enterprise/backend/test/metabase_enterprise/transforms/util_test.clj
index db660e26203..936ca037011 100644
--- a/enterprise/backend/test/metabase_enterprise/transforms/util_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/transforms/util_test.clj
@@ -4,7 +4,10 @@
[clojure.string :as str]
[clojure.test :refer :all]
[metabase-enterprise.transforms.util :as transforms.util]
+ [metabase.api.common :as api]
[metabase.driver :as driver]
+ [metabase.permissions.models.data-permissions :as data-perms]
+ [metabase.permissions.models.permissions-group :as perms-group]
[metabase.test :as mt]
[metabase.test.data.sql :as sql.tx]))
@@ -212,3 +215,72 @@
"t2" {:database_id (:id db) :schema nil :table "table_two"}}]
(is (= {"t1" (:id t1) "t2" (:id t2)}
(transforms.util/resolve-source-tables source-tables))))))))
+
+(deftest source-tables-readable?-test
+ (testing "source-tables-readable? function"
+ (mt/with-premium-features #{:transforms :transforms-python}
+ (mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
+ (mt/with-temp [:model/Database {db-id :id} {:engine driver/*driver*}
+ :model/Table {table-id :id} {:db_id db-id :name "test_table"}]
+ (binding [api/*current-user-id* (mt/user->id :lucky)]
+ (mt/with-db-perm-for-group! (perms-group/all-users) db-id :perms/view-data :unrestricted
+ (testing "returns true for query transform when user can read database"
+ (let [transform {:source {:type :query
+ :query {:database db-id}}}]
+ (is (true? (transforms.util/source-tables-readable? transform)))))
+
+ (testing "returns true for python transform when user can read all source tables"
+ (let [transform {:source {:type :python
+ :source-tables {"t1" table-id}}}]
+ (is (true? (transforms.util/source-tables-readable? transform)))))
+
+ (testing "handles source tables with table_id in map format"
+ (let [transform {:source {:type :python
+ :source-tables {"t1" {:table_id table-id}}}}]
+ (is (true? (transforms.util/source-tables-readable? transform))))))))))))
+
+(deftest source-tables-readable-permissions-test
+ (testing "source-tables-readable? with various permission levels"
+ (mt/with-premium-features #{:transforms :transforms-python}
+ (mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
+ (mt/with-temp [:model/Database {db-id :id} {:engine driver/*driver*}
+ :model/Table {table1-id :id} {:db_id db-id :name "test_table_1"}
+ :model/Table {table2-id :id} {:db_id db-id :name "test_table_2"}]
+
+ (testing "Query transforms - blocked database access"
+ (let [transform {:source {:type :query
+ :query {:database db-id}}}]
+ (mt/with-user-in-groups [group {:name "Blocked Group"}
+ user [group]]
+ (mt/with-db-perm-for-group! (perms-group/all-users) db-id :perms/view-data :blocked
+ (mt/with-db-perm-for-group! group db-id :perms/view-data :blocked
+ (binding [api/*current-user-id* (:id user)]
+ (is (false? (transforms.util/source-tables-readable? transform))
+ "User with blocked database access should not be able to read source database")))))))
+
+ (testing "Python transforms - blocked database access"
+ (let [transform {:source {:type :python
+ :source-tables {"t1" table1-id}}}]
+ (mt/with-user-in-groups [group {:name "Blocked Group"}
+ user [group]]
+ (mt/with-db-perm-for-group! (perms-group/all-users) db-id :perms/view-data :blocked
+ (mt/with-db-perm-for-group! group db-id :perms/view-data :blocked
+ (binding [api/*current-user-id* (:id user)]
+ (is (false? (transforms.util/source-tables-readable? transform))
+ "User with blocked database access should not be able to read source tables")))))))
+
+ (testing "Python transforms - granular access but missing some tables"
+ (let [transform {:source {:type :python
+ :source-tables {"t1" table1-id
+ "t2" table2-id}}}]
+ (mt/with-user-in-groups [group {:name "Limited Granular Group"}
+ user [group]]
+ ;; Block all-users from viewing data at database level, then grant specific access via test group
+ (mt/with-no-data-perms-for-all-users!
+ (mt/with-db-perm-for-group! group db-id :perms/view-data :unrestricted
+ (mt/with-db-perm-for-group! group db-id :perms/create-queries :query-builder-and-native
+ ;; Block table2 for the test group only
+ (data-perms/set-table-permission! (:id group) table2-id :perms/view-data :blocked)
+ (binding [api/*current-user-id* (:id user)]
+ (is (false? (transforms.util/source-tables-readable? transform))
+ "User who cannot read all source tables should have source_readable=false")))))))))))))
diff --git a/enterprise/backend/test/metabase_enterprise/transforms_python/api_test.clj b/enterprise/backend/test/metabase_enterprise/transforms_python/api_test.clj
index e3df5230390..9de230b578e 100644
--- a/enterprise/backend/test/metabase_enterprise/transforms_python/api_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/transforms_python/api_test.clj
@@ -5,6 +5,7 @@
[clojure.test :refer :all]
[metabase-enterprise.transforms-python.models.python-library :as python-library]
[metabase-enterprise.transforms.test-dataset :as transforms-dataset]
+ [metabase.permissions.models.permissions-group :as perms-group]
[metabase.test :as mt]
[toucan2.core :as t2]))
@@ -12,75 +13,79 @@
(deftest get-library-path-test
(testing "GET /api/ee/transforms-python/library/:path"
- (mt/with-premium-features #{:transforms-python}
- (testing "requires superuser permissions"
+ (mt/with-premium-features #{:transforms-python :transforms}
+ (testing "requires transform permissions"
(is (= "You don't have permissions to do that."
(mt/user-http-request :rasta :get 403 "ee/transforms-python/library/common"))))
- (testing "returns nil when no library exists"
- (t2/delete! :model/PythonLibrary)
- (is (= "Not found." (mt/user-http-request :crowberto :get 404 "ee/transforms-python/library/common"))))
- (testing "returns existing library"
- (t2/delete! :model/PythonLibrary)
- (python-library/update-python-library-source! "common" "def my_function():\n return 42")
- (is (=? {:source "def my_function():\n return 42"
- :path "common.py"
- :created_at some?
- :updated_at some?}
- (mt/user-http-request :crowberto :get 200 "ee/transforms-python/library/common"))))
- (testing "rejects invalid paths"
- (is (= "Invalid library path. Only 'common' is currently supported."
- (:message (mt/user-http-request :crowberto :get 400 "ee/transforms-python/library/invalid-path"))))))))
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (mt/with-db-perm-for-group! (perms-group/all-users) (mt/id) :perms/transforms :yes
+ (testing "returns nil when no library exists"
+ (t2/delete! :model/PythonLibrary)
+ (is (= "Not found." (mt/user-http-request :lucky :get 404 "ee/transforms-python/library/common"))))
+ (testing "returns existing library"
+ (t2/delete! :model/PythonLibrary)
+ (python-library/update-python-library-source! "common" "def my_function():\n return 42")
+ (is (=? {:source "def my_function():\n return 42"
+ :path "common.py"
+ :created_at some?
+ :updated_at some?}
+ (mt/user-http-request :lucky :get 200 "ee/transforms-python/library/common"))))
+ (testing "rejects invalid paths"
+ (is (= "Invalid library path. Only 'common' is currently supported."
+ (:message (mt/user-http-request :lucky :get 400 "ee/transforms-python/library/invalid-path"))))))))))
(deftest put-library-path-test
(testing "PUT /api/ee/transforms-python/library/:path"
- (mt/with-premium-features #{:transforms-python}
- (testing "requires superuser permissions"
+ (mt/with-premium-features #{:transforms-python :transforms}
+ (testing "requires transform permissions"
(is (= "You don't have permissions to do that."
(mt/user-http-request :rasta :put 403 "ee/transforms-python/library/common"
{:source "def test(): pass"}))))
- (testing "validates request body"
- (testing "requires source field"
- (is (=? {:errors
- {:source "string"}}
- (mt/user-http-request :crowberto :put 400 "ee/transforms-python/library/common"
- {}))))
- (testing "allows empty string"
- (t2/delete! :model/PythonLibrary)
- (is (=? {:source ""
- :path "common.py"
- :id integer?
- :created_at some?
- :updated_at some?}
- (mt/user-http-request :crowberto :put 200 "ee/transforms-python/library/common"
- {:source ""})))))
- (testing "creates new library when none exists"
- (t2/delete! :model/PythonLibrary)
- (is (=? {:source "def new_function():\n return 100"
- :path "common.py"
- :id integer?
- :created_at some?
- :updated_at some?}
- (mt/user-http-request :crowberto :put 200 "ee/transforms-python/library/common"
- {:source "def new_function():\n return 100"})))
- (is (= "def new_function():\n return 100"
- (t2/select-one-fn :source :model/PythonLibrary))))
- (testing "updates existing library"
- (t2/delete! :model/PythonLibrary)
- (python-library/update-python-library-source! "common" "def old_function():\n return 1")
- (is (=? {:source "def updated_function():\n return 2"
- :path "common.py"
- :id integer?
- :created_at some?
- :updated_at some?}
- (mt/user-http-request :crowberto :put 200 "ee/transforms-python/library/common"
- {:source "def updated_function():\n return 2"})))
- (is (= "def updated_function():\n return 2"
- (t2/select-one-fn :source :model/PythonLibrary)))
- (is (= 1 (t2/count :model/PythonLibrary)) "Should not create duplicate records"))
- (testing "rejects invalid paths"
- (is (= "Invalid library path. Only 'common' is currently supported."
- (:message (mt/user-http-request :crowberto :put 400 "ee/transforms-python/library/invalid-path"
- {:source "def test(): pass"}))))))))
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (mt/with-db-perm-for-group! (perms-group/all-users) (mt/id) :perms/transforms :yes
+ (testing "validates request body"
+ (testing "requires source field"
+ (is (=? {:errors
+ {:source "string"}}
+ (mt/user-http-request :lucky :put 400 "ee/transforms-python/library/common"
+ {}))))
+ (testing "allows empty string"
+ (t2/delete! :model/PythonLibrary)
+ (is (=? {:source ""
+ :path "common.py"
+ :id integer?
+ :created_at some?
+ :updated_at some?}
+ (mt/user-http-request :lucky :put 200 "ee/transforms-python/library/common"
+ {:source ""})))))
+ (testing "creates new library when none exists"
+ (t2/delete! :model/PythonLibrary)
+ (is (=? {:source "def new_function():\n return 100"
+ :path "common.py"
+ :id integer?
+ :created_at some?
+ :updated_at some?}
+ (mt/user-http-request :lucky :put 200 "ee/transforms-python/library/common"
+ {:source "def new_function():\n return 100"})))
+ (is (= "def new_function():\n return 100"
+ (t2/select-one-fn :source :model/PythonLibrary))))
+ (testing "updates existing library"
+ (t2/delete! :model/PythonLibrary)
+ (python-library/update-python-library-source! "common" "def old_function():\n return 1")
+ (is (=? {:source "def updated_function():\n return 2"
+ :path "common.py"
+ :id integer?
+ :created_at some?
+ :updated_at some?}
+ (mt/user-http-request :lucky :put 200 "ee/transforms-python/library/common"
+ {:source "def updated_function():\n return 2"})))
+ (is (= "def updated_function():\n return 2"
+ (t2/select-one-fn :source :model/PythonLibrary)))
+ (is (= 1 (t2/count :model/PythonLibrary)) "Should not create duplicate records"))
+ (testing "rejects invalid paths"
+ (is (= "Invalid library path. Only 'common' is currently supported."
+ (:message (mt/user-http-request :lucky :put 400 "ee/transforms-python/library/invalid-path"
+ {:source "def test(): pass"}))))))))))
(deftest test-run-test
(mt/with-premium-features #{:transforms :transforms-python}
@@ -92,7 +97,7 @@
" print(\"out2\")"
" print(\"err2\", file=sys.stderr)"
" return pd.DataFrame({'x': [42, 43]})"]
- body {:source_tables {}, :code (str/join "\n" program)}
+ body {:source_tables {:test (t2/select-one-pk :model/Table :db_id (mt/id))}, :code (str/join "\n" program)}
{:keys [error logs output]} (mt/user-http-request :crowberto :post 200 "ee/transforms-python/test-run" body)]
(is (nil? error))
(is (str/includes? logs "out1\nerr1\nout2\nerr2"))
@@ -101,7 +106,7 @@
(defn- test-run [& {:keys [program user features source-tables extra-opts]
:or {program ["import pandas as pd" "def transform():" " return pd.DataFrame()"]
user :crowberto
- source-tables {}
+ source-tables {:test (t2/select-one-pk :model/Table :db_id (mt/id))}
features #{:transforms :transforms-python}}}]
(let [body (merge {:source_tables source-tables, :code (str/join "\n" program)} extra-opts)]
(mt/with-premium-features features
@@ -141,8 +146,12 @@
(is (=? {:status 200} (test-run :features #{:transforms :transforms-python}))))
(deftest test-run-permissions-test
- (is (=? {:status 403} (test-run :user :rasta)))
- (is (=? {:status 200} (test-run :user :crowberto))))
+ (mt/test-drivers (mt/normal-drivers-with-feature :transforms/python)
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (mt/with-group-for-user [lucky-group :lucky {:name "Lucky Transforms Group"}]
+ (mt/with-db-perm-for-group! lucky-group (mt/id) :perms/transforms :yes
+ (is (=? {:status 403} (test-run :user :rasta)))
+ (is (=? {:status 200} (test-run :user :lucky))))))))
(deftest test-run-input-limit-test
(testing "maximum"
diff --git a/enterprise/backend/test/metabase_enterprise/transforms_python/drivers_test.clj b/enterprise/backend/test/metabase_enterprise/transforms_python/drivers_test.clj
index 1761bacf0ed..dda16b6bb5f 100644
--- a/enterprise/backend/test/metabase_enterprise/transforms_python/drivers_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/transforms_python/drivers_test.clj
@@ -31,6 +31,7 @@
:name table-name
:database (mt/id)}
transform-def {:name (str "E2E Transform Test " table-name)
+ :source_database_id (mt/id)
:source {:type "python"
:source-tables source-tables
:body transform-code}
@@ -416,7 +417,7 @@
;; we sometimes get I/O error in CI due to it taking too long. it's too slow, too flakey to keep enabled
:redshift)
(mt/with-empty-db
- (mt/with-premium-features #{:transforms-python}
+ (mt/with-premium-features #{:transforms-python :transforms}
(with-test-table [source-table-id source-table-name] [base-type-test-data (:data base-type-test-data)]
(let [table-name (mt/random-name)
exotic-config (get driver-exotic-types driver/*driver*)
diff --git a/enterprise/backend/test/metabase_enterprise/transforms_python/execute_test.clj b/enterprise/backend/test/metabase_enterprise/transforms_python/execute_test.clj
index 32e2dd833be..417413ef8fe 100644
--- a/enterprise/backend/test/metabase_enterprise/transforms_python/execute_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/transforms_python/execute_test.clj
@@ -16,19 +16,20 @@
(deftest atomic-python-transform-swap-test
(testing "Python transform execution with atomic table swap"
(mt/test-drivers #{:mysql :postgres}
- (mt/with-premium-features #{:transforms-python}
+ (mt/with-premium-features #{:transforms-python :transforms}
(mt/dataset transforms-dataset/transforms-test
(let [schema (t2/select-one-fn :schema :model/Table (mt/id :transforms_products))]
(with-transform-cleanup! [{table-name :name :as target} {:type "table"
:schema schema
:name "swap_tbl"}]
(let [initial-transform {:name "Python Transform Initial"
- :source {:type "python"
- :source-tables {}
- :body (str "import pandas as pd\n"
- "\n"
- "def transform():\n"
- " return pd.DataFrame({'name': ['Alice', 'Bob'], 'age': [25, 30]})")}
+ :source {:type "python"
+ :source-tables {}
+ :source-database (mt/id)
+ :body (str "import pandas as pd\n"
+ "\n"
+ "def transform():\n"
+ " return pd.DataFrame({'name': ['Alice', 'Bob'], 'age': [25, 30]})")}
:target (assoc target :database (mt/id))}]
(mt/with-temp [:model/Transform transform initial-transform]
(transforms-python.execute/execute-python-transform! transform {:run-method :manual})
@@ -38,12 +39,13 @@
(is (= [["Alice" 25] ["Bob" 30]] initial-rows) "Initial data should be Alice and Bob")
(t2/update! :model/Transform (:id transform)
- {:source {:type "python"
- :source-tables {}
- :body (str "import pandas as pd\n"
- "\n"
- "def transform():\n"
- " return pd.DataFrame({'name': ['Charlie', 'Diana', 'Eve'], 'age': [35, 40, 45]})")}}))
+ {:source {:type "python"
+ :source-tables {}
+ :source-database (mt/id)
+ :body (str "import pandas as pd\n"
+ "\n"
+ "def transform():\n"
+ " return pd.DataFrame({'name': ['Charlie', 'Diana', 'Eve'], 'age': [35, 40, 45]})")}}))
(let [swap-latch (CountDownLatch. 1)
original-rename-tables-atomic! transforms.util/rename-tables!]
@@ -66,19 +68,20 @@
(deftest python-transform-temp-table-cleanup-test
(testing "Python transform cleans up temp tables on success"
(mt/test-drivers #{:mysql :postgres}
- (mt/with-premium-features #{:transforms-python}
+ (mt/with-premium-features #{:transforms-python :transforms}
(mt/dataset transforms-dataset/transforms-test
(let [schema (t2/select-one-fn :schema :model/Table (mt/id :transforms_products))]
(with-transform-cleanup! [{table-name :name :as target} {:type "table"
:schema schema
:name "cleanup_"}]
(let [transform-def {:name "Python Transform Cleanup"
- :source {:type "python"
- :source-tables {}
- :body (str "import pandas as pd\n"
- "\n"
- "def transform():\n"
- " return pd.DataFrame({'col1': [1, 2, 3], 'col2': ['a', 'b', 'c']})")}
+ :source {:type "python"
+ :source-tables {}
+ :source-database (mt/id)
+ :body (str "import pandas as pd\n"
+ "\n"
+ "def transform():\n"
+ " return pd.DataFrame({'col1': [1, 2, 3], 'col2': ['a', 'b', 'c']})")}
:target (assoc target :database (mt/id))}]
(mt/with-temp [:model/Transform transform transform-def]
(transforms-python.execute/execute-python-transform! transform {:run-method :manual})
@@ -97,7 +100,7 @@
(deftest python-transform-timeout-status-test
(testing "Python transform execution sets correct timeout status when script times out"
(mt/test-drivers #{:postgres}
- (mt/with-premium-features #{:transforms-python}
+ (mt/with-premium-features #{:transforms-python :transforms}
(mt/dataset transforms-dataset/transforms-test
(let [schema (t2/select-one-fn :schema :model/Table (mt/id :transforms_products))]
(with-transform-cleanup! [target {:type "table"
@@ -111,9 +114,10 @@
" time.sleep(10) # Sleep longer than timeout\n"
" return pd.DataFrame({'result': ['should_not_reach_here']})")
transform-def {:name "Python Transform Timeout Test"
- :source {:type "python"
- :source-tables {}
- :body long-running-code}
+ :source {:type "python"
+ :source-tables {}
+ :source-database (mt/id)
+ :body long-running-code}
:target (assoc target :database (mt/id))}]
(mt/with-temp [:model/Transform transform transform-def]
(let [{:keys [run_id]} (try
@@ -131,18 +135,19 @@
(deftest python-transform-unresolved-source-table-test
(testing "Python transform execution throws when source table cannot be resolved"
(mt/test-drivers #{:postgres}
- (mt/with-premium-features #{:transforms-python}
+ (mt/with-premium-features #{:transforms-python :transforms}
(mt/dataset transforms-dataset/transforms-test
(let [schema (t2/select-one-fn :schema :model/Table (mt/id :transforms_products))]
(with-transform-cleanup! [target {:type "table"
:schema schema
:name "unresolved_test"}]
(mt/with-temp [:model/Transform transform {:name "Transform with unresolved ref"
- :source {:type "python"
- :body "def transform(input): return input"
- :source-tables {"input" {:database_id (mt/id)
- :schema schema
- :table "nonexistent_table"}}}
+ :source {:type "python"
+ :body "def transform(input): return input"
+ :source-database (mt/id)
+ :source-tables {"input" {:database_id (mt/id)
+ :schema schema
+ :table "nonexistent_table"}}}
:target (assoc target :database (mt/id))}]
(testing "Execution throws with informative error message"
(is (thrown-with-msg?
@@ -153,17 +158,18 @@
(deftest python-transform-unresolved-source-table-no-schema-test
(testing "Python transform error message omits schema when nil"
(mt/test-drivers #{:postgres}
- (mt/with-premium-features #{:transforms-python}
+ (mt/with-premium-features #{:transforms-python :transforms}
(mt/dataset transforms-dataset/transforms-test
(with-transform-cleanup! [target {:type "table"
:schema nil
:name "unresolved_no_schema_test"}]
(mt/with-temp [:model/Transform transform {:name "Transform with unresolved ref no schema"
- :source {:type "python"
- :body "def transform(input): return input"
- :source-tables {"input" {:database_id (mt/id)
- :schema nil
- :table "missing_table"}}}
+ :source {:type "python"
+ :body "def transform(input): return input"
+ :source-database (mt/id)
+ :source-tables {"input" {:database_id (mt/id)
+ :schema nil
+ :table "missing_table"}}}
:target (assoc target :database (mt/id))}]
(is (thrown-with-msg?
clojure.lang.ExceptionInfo
diff --git a/enterprise/backend/test/metabase_enterprise/transforms_python/ordering_test.clj b/enterprise/backend/test/metabase_enterprise/transforms_python/ordering_test.clj
index cbe370e31ad..2e1d86396b5 100644
--- a/enterprise/backend/test/metabase_enterprise/transforms_python/ordering_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/transforms_python/ordering_test.clj
@@ -30,6 +30,7 @@
:source-tables source-tables
:body "# Python code here\nresult = df"}
:name (str "python_transform_" name)
+ :source_database_id (mt/id)
:target {:database target-db
:schema schema
:name name
diff --git a/enterprise/backend/test/metabase_enterprise/transforms_python/python_runner_test.clj b/enterprise/backend/test/metabase_enterprise/transforms_python/python_runner_test.clj
index dbc045a95d9..c59cad69e80 100644
--- a/enterprise/backend/test/metabase_enterprise/transforms_python/python_runner_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/transforms_python/python_runner_test.clj
@@ -498,7 +498,7 @@
(deftest python-runner-timeout-test
(testing "Python script execution respects timeout setting"
- (mt/with-premium-features #{:transforms-python}
+ (mt/with-premium-features #{:transforms-python :transforms}
(tu/with-temporary-setting-values [python-runner-timeout-seconds 5]
(let [long-running-code (str "import time\n"
"import pandas as pd\n"
diff --git a/enterprise/backend/test/metabase_enterprise/transforms_python/s3_test.clj b/enterprise/backend/test/metabase_enterprise/transforms_python/s3_test.clj
index fc8ca56591f..a894293733f 100644
--- a/enterprise/backend/test/metabase_enterprise/transforms_python/s3_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/transforms_python/s3_test.clj
@@ -64,7 +64,7 @@
(deftest open-s3-shared-storage-test
(testing "open-s3-shared-storage! returns closeable derefable"
- (mt/with-premium-features #{:transforms-python}
+ (mt/with-premium-features #{:transforms-python :transforms}
(let [table-name->id {"users" 1}
storage-ref (s3/open-shared-storage! table-name->id)
{:keys [s3-client bucket-name objects]} @storage-ref]
diff --git a/enterprise/backend/test/metabase_enterprise/transforms_python/transforms_api_test.clj b/enterprise/backend/test/metabase_enterprise/transforms_python/transforms_api_test.clj
index cb438e720bb..61fce049588 100644
--- a/enterprise/backend/test/metabase_enterprise/transforms_python/transforms_api_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/transforms_python/transforms_api_test.clj
@@ -8,6 +8,7 @@
[metabase-enterprise.transforms.test-dataset :as transforms-dataset]
[metabase-enterprise.transforms.test-util :as transforms.tu :refer [with-transform-cleanup! get-test-schema]]
[metabase.driver :as driver]
+ [metabase.permissions.models.permissions-group :as perms-group]
[metabase.test :as mt]
[metabase.util :as u]
[toucan2.core :as t2])
@@ -23,107 +24,117 @@
(deftest create-python-transform-test
(mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
(mt/dataset transforms-dataset/transforms-test
- (letfn [(create-transform! []
- (let [schema (get-test-schema)
- transform-payload {:name "My beautiful python runner"
- :source {:type "python"
- :body "print('hello world')"
- :source-tables {}}
- :target {:type "table"
- :schema schema
- :name "gadget_products"
- :database (mt/id)}}]
- (mt/user-http-request :crowberto :post "ee/transform"
- transform-payload)))]
-
- (testing "without any feature flags"
- (mt/with-premium-features #{}
- (testing "creating python transform without any features fails"
- (is (= "error-premium-feature-not-available"
- (:status (mt/user-http-request :crowberto :post 402 "ee/transform"
- {:name "My beautiful python runner"
- :source {:type "python"
- :body "print('hello world')"
- :source-tables {}}
- :target {:type "table"
- :schema (get-test-schema)
- :name "gadget_products"
- :database (mt/id)}})))))))
-
- (testing "with only transforms feature flag (no transforms-python)"
- (mt/with-premium-features #{:transforms}
- (testing "creating python transform without transforms-python feature fails"
- (is (= "Premium features required for this transform type are not enabled."
- (mt/user-http-request :crowberto :post 402 "ee/transform"
- {:name "My beautiful python runner"
- :source {:type "python"
- :body "print('hello world')"
- :source-tables {}}
- :target {:type "table"
- :schema (get-test-schema)
- :name "gadget_products"
- :database (mt/id)}}))))))
-
- (testing "with transforms-python feature flag"
- (mt/with-premium-features #{:transforms :transforms-python}
- (with-transform-cleanup! [table-name "gadget_products"]
- (let [transform (create-transform!)]
- (is (= "print('hello chris')"
- (-> (mt/user-http-request :crowberto :put 200 (format "ee/transform/%s" (:id transform))
- {:name "My beautiful python runner"
- :source {:type "python"
- :body "print('hello chris')"
- :source-tables {}}
- :target {:type "table"
- :schema (get-test-schema)
- :name table-name
- :database (mt/id)}})
- :source :body)))))))))))
+ (mt/with-data-analyst-role! (mt/user->id :lucky)
+ (mt/with-db-perm-for-group! (perms-group/all-users) (mt/id) :perms/transforms :yes
+ (letfn [(create-transform! []
+ (let [schema (get-test-schema)
+ transform-payload {:name "My beautiful python runner"
+ :source {:type "python"
+ :body "print('hello world')"
+ :source-tables {}
+ :source-database (mt/id)}
+ :target {:type "table"
+ :schema schema
+ :name "gadget_products"
+ :database (mt/id)}}]
+ (mt/user-http-request :lucky :post "ee/transform"
+ transform-payload)))]
+
+ (testing "without any feature flags"
+ (mt/with-premium-features #{}
+ (testing "creating python transform without any features fails"
+ (is (= "error-premium-feature-not-available"
+ (:status (mt/user-http-request :lucky :post 402 "ee/transform"
+ {:name "My beautiful python runner"
+ :source {:type "python"
+ :body "print('hello world')"
+ :source-tables {}
+ :source-database (mt/id)}
+ :target {:type "table"
+ :schema (get-test-schema)
+ :name "gadget_products"
+ :database (mt/id)}})))))))
+
+ (testing "with only transforms feature flag (no transforms-python)"
+ (mt/with-premium-features #{:transforms}
+ (testing "creating python transform without transforms-python feature fails"
+ (is (= "Premium features required for this transform type are not enabled."
+ (mt/user-http-request :lucky :post 402 "ee/transform"
+ {:name "My beautiful python runner"
+ :source {:type "python"
+ :body "print('hello world')"
+ :source-tables {}
+ :source-database (mt/id)}
+ :target {:type "table"
+ :schema (get-test-schema)
+ :name "gadget_products"
+ :database (mt/id)}}))))))
+
+ (testing "with transforms-python feature flag"
+ (mt/with-premium-features #{:transforms :transforms-python}
+ (with-transform-cleanup! [table-name "gadget_products"]
+ (let [transform (create-transform!)]
+ (is (= "print('hello chris')"
+ (-> (mt/user-http-request :lucky :put 200 (format "ee/transform/%s" (:id transform))
+ {:name "My beautiful python runner"
+ :source {:type "python"
+ :body "print('hello chris')"
+ :source-tables {}
+ :source-database (mt/id)}
+ :target {:type "table"
+ :schema (get-test-schema)
+ :name table-name
+ :database (mt/id)}})
+ :source :body)))))))))))))
(deftest update-python-transform-feature-flag-test
- (mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
- (testing "Updating a python transform requires both :transforms and :transforms-python features"
- (mt/with-temp [:model/Transform {id :id
- :as transform} {:name "Original Python Transform"
- :source {:type "python"
- :body "print('original')"
- :source-tables {}}
- :target {:type "table"
- :schema "scheam"
- :name "table"
- :database (mt/id)}}]
- (mt/with-premium-features #{}
- (let [response (mt/user-http-request :crowberto :put
- (format "ee/transform/%d" id)
- (assoc-in transform [:source :body] "print('no features')"))]
- (is (= "error-premium-feature-not-available" (:status response))
- "Should return 403 without any features")))))))
+ (mt/with-premium-features #{:transforms}
+ (mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
+ (testing "Updating a python transform requires both :transforms and :transforms-python features"
+ (mt/with-temp [:model/Transform {id :id
+ :as transform} {:name "Original Python Transform"
+ :source {:type "python"
+ :body "print('original')"
+ :source-tables {}
+ :source-database (mt/id)}
+ :target {:type "table"
+ :schema "scheam"
+ :name "table"
+ :database (mt/id)}}]
+ (mt/with-premium-features #{}
+ (let [response (mt/user-http-request :crowberto :put
+ (format "ee/transform/%d" id)
+ (assoc-in transform [:source :body] "print('no features')"))]
+ (is (= "error-premium-feature-not-available" (:status response))
+ "Should return 403 without any features"))))))))
(deftest run-python-transform-feature-flag-test
- (mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
- (testing "Running a python transform requires both :transforms and :transforms-python features"
- (mt/with-premium-features #{:transforms :transforms-python}
- (mt/dataset transforms-dataset/transforms-test
- (with-transform-cleanup! [table-name "test_run_python"]
- (let [schema (get-test-schema)
- transform-payload {:name "Test Run Python Transform"
- :source {:type "python"
- :body "def transform():\n pass"
- :source-tables {}}
- :target {:type "table"
- :schema schema
- :name table-name
- :database (mt/id)}}
- created (mt/user-http-request :crowberto :post 200 "ee/transform" transform-payload)]
- (mt/with-premium-features #{}
- (let [response (mt/user-http-request :crowberto :post 402
- (format "ee/transform/%d/run" (:id created)))]
- (is (= "error-premium-feature-not-available" (:status response)))))
- (mt/with-premium-features #{:transforms}
- (let [response (mt/user-http-request :crowberto :post
- (format "ee/transform/%d/run" (:id created)))]
- (is (= "Premium features required for this transform type are not enabled." response)
- "Should return 403 without :transforms-python feature"))))))))))
+ (mt/with-premium-features #{:transforms}
+ (mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)
+ (testing "Running a python transform requires both :transforms and :transforms-python features"
+ (mt/with-premium-features #{:transforms :transforms-python}
+ (mt/dataset transforms-dataset/transforms-test
+ (with-transform-cleanup! [table-name "test_run_python"]
+ (let [schema (get-test-schema)
+ transform-payload {:name "Test Run Python Transform"
+ :source {:type "python"
+ :body "def transform():\n pass"
+ :source-tables {}
+ :source-database (mt/id)}
+ :target {:type "table"
+ :schema schema
+ :name table-name
+ :database (mt/id)}}
+ created (mt/user-http-request :crowberto :post 200 "ee/transform" transform-payload)]
+ (mt/with-premium-features #{}
+ (let [response (mt/user-http-request :crowberto :post 402
+ (format "ee/transform/%d/run" (:id created)))]
+ (is (= "error-premium-feature-not-available" (:status response)))))
+ (mt/with-premium-features #{:transforms}
+ (let [response (mt/user-http-request :crowberto :post
+ (format "ee/transform/%d/run" (:id created)))]
+ (is (= "Premium features required for this transform type are not enabled." response)
+ "Should return 403 without :transforms-python feature")))))))))))
(deftest execute-python-transform-test
(testing "transform execution with :transforms/table target"
@@ -197,112 +208,114 @@
(assert (not= :timeout (try (deref fut 1000 :timeout) (catch Throwable _))) "Observation thread did not exit!")))))
(deftest python-transform-logging-test
- (letfn [(program->source [program]
- (->> (concat ["import pandas as pd"
- "def transform():"]
- (for [s program] (str " " s))
- [" return pd.DataFrame({'x': [42]})"])
- (str/join "\n")))
-
- (create-transform [{:keys [program]} target]
- {:post [(integer? %)]}
- (:id (mt/user-http-request :crowberto :post 200 "ee/transform"
- {:name "Python logging test"
- :source {:type "python"
- :body (program->source program)
- :source-tables {}}
- :target (assoc target :database (mt/id))})))
-
- (block-on-run [{:keys [expect-status]} target transform-id]
- (try
- (transforms.tu/test-run transform-id)
- (catch Throwable e
- ;; test-run throws for non success, but we want to test failures too
- (when-not (= expect-status (:status (ex-data e)))
- (throw e))))
- (when (= :succeeded expect-status)
- (transforms.tu/wait-for-table (:name target) 5000)))
-
- (run-scenario [scenario schema]
- (with-redefs [transforms-python.execute/python-message-loop-sleep-duration (Duration/ofMillis fast-log-polling-ms)
- transforms-python.execute/transfer-file-to-db (if-some [e (:writeback-ex scenario)]
- (fn [& _] (throw e))
- @#'transforms-python.execute/transfer-file-to-db)]
- (with-transform-cleanup! [target {:type "table"
- :schema schema
- :name "result"}]
- (let [transform-id (create-transform scenario target)
- observed-messages (with-open [observer (open-message-value-observer transform-id)]
- (block-on-run scenario target transform-id)
- @observer)
- last-run (get-last-run transform-id)]
- {:observed-messages observed-messages
- :last-run last-run}))))]
- (let [scenarios [{:desc "stdin"
- :program ["print(\"hello, world\")"]
- :expect-status :succeeded
- :expected ["hello, world"]}
- {:desc "stderr"
- :program ["import sys" "print(\"hello, world\", file=sys.stderr)"]
- :expect-status :succeeded
- :expected ["hello, world"]}
- {:desc "interleaved streams"
- :program ["import sys"
- "print(\"1\", file=sys.stderr)"
- "print(\"2\", file=sys.stderr)"
- "print(\"3\", file=sys.stdout)"
- "print(\"4\", file=sys.stderr)"]
- :expect-status :succeeded
- :expected ["1" "2" "3" "4"]}
- {:desc "syntax error"
- :program ["print(40 + 2)"
- "this is not valid code"]
- :expect-status :failed
- :expected ["SyntaxError: invalid syntax"]}
- {:desc "takes time, early feedback possible"
- :program ["import time"
- "print(\"a\")"
- "time.sleep(0.1)"
- "print(\"b\")"
- "time.sleep(0.1)"
- "print(\"c\")"]
- :expect-early-feedback true
- :expect-status :succeeded
- :expected ["a" "b" "c"]}
- {:desc "crash during writeback"
- :program ["print(42)" "print(\"is the answer\")"]
- :expect-status :failed
- :expected ["42" "is the answer" "Failed to create the resulting table"]
- :writeback-ex (Exception. "Boom!")}]]
- (mt/test-drivers (-> (mt/normal-drivers-with-feature :transforms/table)
- ;; certain drivers are slow/unpredictable enough that the generous timings in this test are not enough
- (disj :snowflake :redshift :bigquery-cloud-sdk))
- (mt/with-premium-features #{:transforms :transforms-python}
- (mt/dataset transforms-dataset/transforms-test
- (let [schema (t2/select-one-fn :schema :model/Table (mt/id :transforms_products))]
- (doseq [{:keys [expected
- expect-early-feedback
- expect-status
- desc] :as scenario}
- scenarios]
- (testing desc
- (let [{:keys [last-run observed-messages]} (run-scenario scenario schema)
- {:keys [status message]} last-run]
- (testing "sanity: status is what we expect"
- (is (= expect-status (some-> status keyword))))
- (testing "sanity: message has a value"
- (is message))
- (when message
- (is (str/starts-with? message "Executing Python transform"))
- (testing "all observed values of message reflect a prefix of the final message (ordering consistent)"
- (doseq [observed-message observed-messages]
- ;; hmmm, sometimes the order seems flipped
- (is (str/starts-with? message observed-message))))
- (when expect-early-feedback
- (testing "scenario takes time, we should see partial messages for immediate feedback"
- (is (< 1 (count observed-messages)))))
- (testing "message includes the expected lines"
- (is (subsequence? (str/split-lines message) expected))))))))))))))
+ (mt/with-premium-features #{:transforms}
+ (letfn [(program->source [program]
+ (->> (concat ["import pandas as pd"
+ "def transform():"]
+ (for [s program] (str " " s))
+ [" return pd.DataFrame({'x': [42]})"])
+ (str/join "\n")))
+
+ (create-transform [{:keys [program]} target]
+ {:post [(integer? %)]}
+ (:id (mt/user-http-request :crowberto :post 200 "ee/transform"
+ {:name "Python logging test"
+ :source {:type "python"
+ :body (program->source program)
+ :source-database (mt/id)
+ :source-tables {:test (t2/select-one-pk :model/Table :db_id (mt/id))}}
+ :target (assoc target :database (mt/id))})))
+
+ (block-on-run [{:keys [expect-status]} target transform-id]
+ (try
+ (transforms.tu/test-run transform-id)
+ (catch Throwable e
+ ;; test-run throws for non success, but we want to test failures too
+ (when-not (= expect-status (:status (ex-data e)))
+ (throw e))))
+ (when (= :succeeded expect-status)
+ (transforms.tu/wait-for-table (:name target) 5000)))
+
+ (run-scenario [scenario schema]
+ (with-redefs [transforms-python.execute/python-message-loop-sleep-duration (Duration/ofMillis fast-log-polling-ms)
+ transforms-python.execute/transfer-file-to-db (if-some [e (:writeback-ex scenario)]
+ (fn [& _] (throw e))
+ @#'transforms-python.execute/transfer-file-to-db)]
+ (with-transform-cleanup! [target {:type "table"
+ :schema schema
+ :name "result"}]
+ (let [transform-id (create-transform scenario target)
+ observed-messages (with-open [observer (open-message-value-observer transform-id)]
+ (block-on-run scenario target transform-id)
+ @observer)
+ last-run (get-last-run transform-id)]
+ {:observed-messages observed-messages
+ :last-run last-run}))))]
+ (let [scenarios [{:desc "stdin"
+ :program ["print(\"hello, world\")"]
+ :expect-status :succeeded
+ :expected ["hello, world"]}
+ {:desc "stderr"
+ :program ["import sys" "print(\"hello, world\", file=sys.stderr)"]
+ :expect-status :succeeded
+ :expected ["hello, world"]}
+ {:desc "interleaved streams"
+ :program ["import sys"
+ "print(\"1\", file=sys.stderr)"
+ "print(\"2\", file=sys.stderr)"
+ "print(\"3\", file=sys.stdout)"
+ "print(\"4\", file=sys.stderr)"]
+ :expect-status :succeeded
+ :expected ["1" "2" "3" "4"]}
+ {:desc "syntax error"
+ :program ["print(40 + 2)"
+ "this is not valid code"]
+ :expect-status :failed
+ :expected ["SyntaxError: invalid syntax"]}
+ {:desc "takes time, early feedback possible"
+ :program ["import time"
+ "print(\"a\")"
+ "time.sleep(0.1)"
+ "print(\"b\")"
+ "time.sleep(0.1)"
+ "print(\"c\")"]
+ :expect-early-feedback true
+ :expect-status :succeeded
+ :expected ["a" "b" "c"]}
+ {:desc "crash during writeback"
+ :program ["print(42)" "print(\"is the answer\")"]
+ :expect-status :failed
+ :expected ["42" "is the answer" "Failed to create the resulting table"]
+ :writeback-ex (Exception. "Boom!")}]]
+ (mt/test-drivers (-> (mt/normal-drivers-with-feature :transforms/table)
+ ;; certain drivers are slow/unpredictable enough that the generous timings in this test are not enough
+ (disj :snowflake :redshift :bigquery-cloud-sdk))
+ (mt/with-premium-features #{:transforms :transforms-python}
+ (mt/dataset transforms-dataset/transforms-test
+ (let [schema (t2/select-one-fn :schema :model/Table (mt/id :transforms_products))]
+ (doseq [{:keys [expected
+ expect-early-feedback
+ expect-status
+ desc] :as scenario}
+ scenarios]
+ (testing desc
+ (let [{:keys [last-run observed-messages]} (run-scenario scenario schema)
+ {:keys [status message]} last-run]
+ (testing "sanity: status is what we expect"
+ (is (= expect-status (some-> status keyword))))
+ (testing "sanity: message has a value"
+ (is message))
+ (when message
+ (is (str/starts-with? message "Executing Python transform"))
+ (testing "all observed values of message reflect a prefix of the final message (ordering consistent)"
+ (doseq [observed-message observed-messages]
+ ;; hmmm, sometimes the order seems flipped
+ (is (str/starts-with? message observed-message))))
+ (when expect-early-feedback
+ (testing "scenario takes time, we should see partial messages for immediate feedback"
+ (is (< 1 (count observed-messages)))))
+ (testing "message includes the expected lines"
+ (is (subsequence? (str/split-lines message) expected)))))))))))))))
(deftest get-python-transform-with-different-target-database-test
(testing "GET /api/ee/transform/:id correctly fetches target table from different database"
@@ -316,7 +329,7 @@
:model/Transform transform {:name "Python Transform Cross DB"
:source {:type "python"
:source-database (mt/id)
- :source-tables {}
+ :source-tables {:test (t2/select-one-pk :model/Table :db_id (mt/id))}
:body "def transform():\n pass"}
:target {:type "table"
:schema "PUBLIC"
@@ -511,12 +524,13 @@
:name "schema_change_test"}]
(let [initial-transform {:name "Schema Change Integration Test"
- :source {:type "python"
- :source-tables {}
- :body (str "import pandas as pd\n"
- "\n"
- "def transform():\n"
- " return pd.DataFrame({'name': ['Alice', 'Bob'], 'age': [25, 30]})")}
+ :source {:type "python"
+ :source-database (mt/id)
+ :source-tables {:test (t2/select-one-pk :model/Table :db_id (mt/id))}
+ :body (str "import pandas as pd\n"
+ "\n"
+ "def transform():\n"
+ " return pd.DataFrame({'name': ['Alice', 'Bob'], 'age': [25, 30]})")}
:target (assoc target :database (mt/id))}
;; Create initial transform via API
{transform-id :id} (mt/user-http-request :crowberto :post 200 "ee/transform" initial-transform)]
@@ -529,12 +543,13 @@
;; Update transform with different schema via API endpoint
(let [updated-transform (assoc initial-transform
- :source {:type "python"
- :source-tables {}
- :body (str "import pandas as pd\n"
- "\n"
- "def transform():\n"
- " return pd.DataFrame({'name': ['Alice', 'Bob'], 'friend': ['Bob', 'Alice']})")})
+ :source {:type "python"
+ :source-database (mt/id)
+ :source-tables {:test (t2/select-one-pk :model/Table :db_id (mt/id))}
+ :body (str "import pandas as pd\n"
+ "\n"
+ "def transform():\n"
+ " return pd.DataFrame({'name': ['Alice', 'Bob'], 'friend': ['Bob', 'Alice']})")})
update-response (mt/user-http-request :crowberto :put 200 (format "ee/transform/%d" transform-id)
updated-transform)]
(is (some? update-response) "Transform update should succeed"))
@@ -562,9 +577,10 @@
:schema (get-test-schema)
:table "transforms_products"}}
transform-payload {:name "Transform with table ref"
- :source {:type "python"
- :body "def transform(input):\n return input"
- :source-tables source-tables}
+ :source {:type "python"
+ :body "def transform(input):\n return input"
+ :source-database (mt/id)
+ :source-tables source-tables}
:target (assoc target :database (mt/id))}
response (mt/user-http-request :crowberto :post 200 "ee/transform" transform-payload)]
(testing "Transform is created successfully"
diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/selectors.ts b/enterprise/frontend/src/metabase-enterprise/data-studio/selectors.ts
index d6129a5d893..b2df5f07e11 100644
--- a/enterprise/frontend/src/metabase-enterprise/data-studio/selectors.ts
+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/selectors.ts
@@ -1,4 +1,7 @@
-import { PLUGIN_FEATURE_LEVEL_PERMISSIONS } from "metabase/plugins";
+import {
+ PLUGIN_FEATURE_LEVEL_PERMISSIONS,
+ PLUGIN_TRANSFORMS,
+} from "metabase/plugins";
import { getIsEmbeddingIframe } from "metabase/selectors/embed";
import { getUserIsAdmin } from "metabase/selectors/user";
import { getIsRemoteSyncReadOnly } from "metabase-enterprise/remote_sync/selectors";
@@ -11,6 +14,7 @@ export function canAccessDataStudio(state: State) {
}
return (
getUserIsAdmin(state) ||
+ PLUGIN_TRANSFORMS.canAccessTransforms(state) ||
PLUGIN_FEATURE_LEVEL_PERMISSIONS.canAccessDataModel(state)
);
}
diff --git a/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/index.ts b/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/index.ts
index 160cdab9cc5..f19c3573817 100644
--- a/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/index.ts
+++ b/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/index.ts
@@ -1,14 +1,18 @@
import type {
DataPermissionValue,
EntityId,
+ PermissionSectionConfig,
PermissionSubject,
SpecialGroupType,
} from "metabase/admin/permissions/types";
+import { isNotNull } from "metabase/lib/types";
+import { PLUGIN_TRANSFORMS } from "metabase/plugins";
import type { Group, GroupsPermissions } from "metabase-types/api";
import { buildDataModelPermission } from "./data-model-permission";
import { buildDetailsPermission } from "./details-permission";
import { buildDownloadPermission } from "./download-permission";
+import { buildTransformsPermission } from "./transforms-permission";
export const getFeatureLevelDataPermissions = (
entityId: EntityId,
@@ -19,10 +23,9 @@ export const getFeatureLevelDataPermissions = (
defaultGroup: Group,
permissionSubject: PermissionSubject,
permissionView?: "group" | "database",
-) => {
+): PermissionSectionConfig[] => {
const isAdmin = groupType === "admin";
const isExternal = groupType === "external";
-
const downloadPermission = buildDownloadPermission(
entityId,
groupId,
@@ -34,29 +37,45 @@ export const getFeatureLevelDataPermissions = (
);
const dataModelPermission =
- (!isExternal || permissionView === "database") &&
- buildDataModelPermission(
- entityId,
- groupId,
- groupType,
- permissions,
- defaultGroup,
- permissionSubject,
- );
+ !isExternal || permissionView === "database"
+ ? buildDataModelPermission(
+ entityId,
+ groupId,
+ groupType,
+ permissions,
+ defaultGroup,
+ permissionSubject,
+ )
+ : null;
const detailsPermission =
- (!isExternal || permissionView === "database") &&
- buildDetailsPermission(
- entityId,
- groupId,
- isAdmin,
- isExternal,
- permissions,
- defaultGroup,
- permissionSubject,
- );
+ !isExternal || permissionView === "database"
+ ? buildDetailsPermission(
+ entityId,
+ groupId,
+ isAdmin,
+ isExternal,
+ permissions,
+ defaultGroup,
+ permissionSubject,
+ )
+ : null;
- return [downloadPermission, dataModelPermission, detailsPermission].filter(
- Boolean,
- );
+ const transformsPermission = PLUGIN_TRANSFORMS.isEnabled
+ ? buildTransformsPermission(
+ entityId,
+ groupId,
+ isAdmin,
+ permissions,
+ defaultGroup,
+ permissionSubject,
+ )
+ : null;
+
+ return [
+ downloadPermission,
+ dataModelPermission,
+ detailsPermission,
+ transformsPermission,
+ ].filter(isNotNull);
};
diff --git a/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/index.unit.spec.ts b/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/index.unit.spec.ts
new file mode 100644
index 00000000000..a05f8114cd9
--- /dev/null
+++ b/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/index.unit.spec.ts
@@ -0,0 +1,133 @@
+import { DataPermissionValue } from "metabase/admin/permissions/types";
+import { PLUGIN_TRANSFORMS } from "metabase/plugins";
+import type { Group, GroupsPermissions } from "metabase-types/api";
+
+import { getFeatureLevelDataPermissions } from "./index";
+
+const defaultGroupId = 1;
+const groupId = 2;
+const groupType = null;
+const databaseId = 1;
+
+const getPermissionGraph = (): GroupsPermissions =>
+ ({
+ [defaultGroupId]: {
+ [databaseId]: {
+ download: { schemas: "full" },
+ "data-model": { schemas: "all" },
+ details: "yes",
+ transforms: "yes",
+ "view-data": "unrestricted",
+ "create-queries": "query-builder-and-native",
+ },
+ },
+ [groupId]: {
+ [databaseId]: {
+ download: { schemas: "full" },
+ "data-model": { schemas: "all" },
+ details: "yes",
+ transforms: "yes",
+ "view-data": "unrestricted",
+ "create-queries": "query-builder-and-native",
+ },
+ },
+ }) as any;
+
+const defaultGroup: Group = {
+ id: defaultGroupId,
+ name: "All Users",
+} as Group;
+
+describe("getFeatureLevelDataPermissions", () => {
+ const originalIsEnabled = PLUGIN_TRANSFORMS.isEnabled;
+
+ afterEach(() => {
+ PLUGIN_TRANSFORMS.isEnabled = originalIsEnabled;
+ });
+
+ describe("schemas subject (database level)", () => {
+ it("returns 4 permissions including transforms when PLUGIN_TRANSFORMS.isEnabled is true", () => {
+ PLUGIN_TRANSFORMS.isEnabled = true;
+
+ const permissions = getFeatureLevelDataPermissions(
+ { databaseId },
+ groupId,
+ groupType,
+ getPermissionGraph(),
+ DataPermissionValue.UNRESTRICTED,
+ defaultGroup,
+ "schemas",
+ );
+
+ expect(permissions).toHaveLength(4);
+ expect(permissions[0]).toMatchObject({ permission: "download" });
+ expect(permissions[1]).toMatchObject({ permission: "data-model" });
+ expect(permissions[2]).toMatchObject({ permission: "details" });
+ expect(permissions[3]).toMatchObject({
+ permission: "transforms",
+ type: "transforms",
+ value: "yes",
+ isDisabled: false,
+ });
+ });
+
+ it("returns 3 permissions without transforms when PLUGIN_TRANSFORMS.isEnabled is false", () => {
+ PLUGIN_TRANSFORMS.isEnabled = false;
+
+ const permissions = getFeatureLevelDataPermissions(
+ { databaseId },
+ groupId,
+ groupType,
+ getPermissionGraph(),
+ DataPermissionValue.UNRESTRICTED,
+ defaultGroup,
+ "schemas",
+ );
+
+ expect(permissions).toHaveLength(3);
+ expect(permissions[0]).toMatchObject({ permission: "download" });
+ expect(permissions[1]).toMatchObject({ permission: "data-model" });
+ expect(permissions[2]).toMatchObject({ permission: "details" });
+ });
+ });
+
+ describe("tables subject (schema level)", () => {
+ it("returns 2 permissions without transforms regardless of PLUGIN_TRANSFORMS.isEnabled", () => {
+ PLUGIN_TRANSFORMS.isEnabled = true;
+
+ const permissions = getFeatureLevelDataPermissions(
+ { databaseId, schemaName: "public" },
+ groupId,
+ groupType,
+ getPermissionGraph(),
+ DataPermissionValue.UNRESTRICTED,
+ defaultGroup,
+ "tables",
+ );
+
+ expect(permissions).toHaveLength(2);
+ expect(permissions[0]).toMatchObject({ permission: "download" });
+ expect(permissions[1]).toMatchObject({ permission: "data-model" });
+ });
+ });
+
+ describe("fields subject (table level)", () => {
+ it("returns 2 permissions without transforms regardless of PLUGIN_TRANSFORMS.isEnabled", () => {
+ PLUGIN_TRANSFORMS.isEnabled = true;
+
+ const permissions = getFeatureLevelDataPermissions(
+ { databaseId, schemaName: "public", tableId: 1 },
+ groupId,
+ groupType,
+ getPermissionGraph(),
+ DataPermissionValue.UNRESTRICTED,
+ defaultGroup,
+ "fields",
+ );
+
+ expect(permissions).toHaveLength(2);
+ expect(permissions[0]).toMatchObject({ permission: "download" });
+ expect(permissions[1]).toMatchObject({ permission: "data-model" });
+ });
+ });
+});
diff --git a/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/transforms-permission.ts b/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/transforms-permission.ts
new file mode 100644
index 00000000000..550b1d9e30d
--- /dev/null
+++ b/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/transforms-permission.ts
@@ -0,0 +1,156 @@
+import { getIn } from "icepick";
+import { t } from "ttag";
+
+import { Messages } from "metabase/admin/permissions/constants/messages";
+import {
+ getPermissionWarning,
+ getPermissionWarningModal,
+} from "metabase/admin/permissions/selectors/confirmations";
+import {
+ DataPermission,
+ DataPermissionType,
+ DataPermissionValue,
+ type EntityId,
+ type PermissionSectionConfig,
+ type PermissionSubject,
+} from "metabase/admin/permissions/types";
+import { getSchemasPermission } from "metabase/admin/permissions/utils/graph";
+import type { Group, GroupsPermissions } from "metabase-types/api";
+
+export const TRANSFORMS_PERMISSION_OPTIONS = {
+ no: {
+ get label() {
+ return t`No`;
+ },
+ value: DataPermissionValue.NO,
+ icon: "close",
+ iconColor: "danger",
+ },
+ yes: {
+ get label() {
+ return t`Yes`;
+ },
+ value: DataPermissionValue.YES,
+ icon: "check",
+ iconColor: "success",
+ },
+};
+
+const TRANSFORMS_PERMISSIONS_DESC = [
+ TRANSFORMS_PERMISSION_OPTIONS.yes.value,
+ TRANSFORMS_PERMISSION_OPTIONS.no.value,
+];
+
+const getTransformsPermission = (
+ permissions: GroupsPermissions,
+ groupId: number,
+ databaseId: number,
+) =>
+ getIn(permissions, [groupId, databaseId, DataPermission.TRANSFORMS]) ??
+ TRANSFORMS_PERMISSION_OPTIONS.no.value;
+
+const hasFullViewDataAccess = (viewDataValue: DataPermissionValue): boolean => {
+ return viewDataValue === DataPermissionValue.UNRESTRICTED;
+};
+
+const hasFullCreateQueriesAccess = (
+ createQueriesValue: DataPermissionValue,
+): boolean => {
+ return createQueriesValue === DataPermissionValue.QUERY_BUILDER_AND_NATIVE;
+};
+
+const getTransformsDisabledTooltip = (
+ isAdmin: boolean,
+ hasRequiredPermissions: boolean,
+): string | null => {
+ if (isAdmin) {
+ return Messages.UNABLE_TO_CHANGE_ADMIN_PERMISSIONS;
+ }
+
+ if (!hasRequiredPermissions) {
+ return t`Transforms require "Can view" data access and "Query builder and native" for all tables in this database`;
+ }
+
+ return null;
+};
+
+export const buildTransformsPermission = (
+ entityId: EntityId,
+ groupId: number,
+ isAdmin: boolean,
+ permissions: GroupsPermissions,
+ defaultGroup: Group,
+ permissionSubject: PermissionSubject,
+): PermissionSectionConfig | null => {
+ if (permissionSubject !== "schemas") {
+ return null;
+ }
+
+ const viewDataValue = getSchemasPermission(
+ permissions,
+ groupId,
+ entityId,
+ DataPermission.VIEW_DATA,
+ );
+
+ const createQueriesValue = getSchemasPermission(
+ permissions,
+ groupId,
+ entityId,
+ DataPermission.CREATE_QUERIES,
+ );
+
+ const hasRequiredPermissions =
+ hasFullViewDataAccess(viewDataValue) &&
+ hasFullCreateQueriesAccess(createQueriesValue);
+
+ const isDisabled = isAdmin || !hasRequiredPermissions;
+
+ const value = hasRequiredPermissions
+ ? getTransformsPermission(permissions, groupId, entityId.databaseId)
+ : TRANSFORMS_PERMISSION_OPTIONS.no.value;
+
+ const defaultGroupValue = getTransformsPermission(
+ permissions,
+ defaultGroup.id,
+ entityId.databaseId,
+ );
+
+ const warning = getPermissionWarning(
+ value,
+ defaultGroupValue,
+ permissionSubject,
+ defaultGroup,
+ groupId,
+ TRANSFORMS_PERMISSIONS_DESC,
+ );
+
+ const confirmations = (newValue: DataPermissionValue) => [
+ getPermissionWarningModal(
+ newValue,
+ defaultGroupValue,
+ permissionSubject,
+ defaultGroup,
+ groupId,
+ TRANSFORMS_PERMISSIONS_DESC,
+ ),
+ ];
+
+ return {
+ permission: DataPermission.TRANSFORMS,
+ type: DataPermissionType.TRANSFORMS,
+ value,
+ isDisabled,
+ isHighlighted: isAdmin,
+ warning,
+ confirmations,
+ disabledTooltip: getTransformsDisabledTooltip(
+ isAdmin,
+ hasRequiredPermissions,
+ ),
+ options: [
+ TRANSFORMS_PERMISSION_OPTIONS.no,
+ TRANSFORMS_PERMISSION_OPTIONS.yes,
+ ],
+ };
+};
diff --git a/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/transforms-permission.unit.spec.ts b/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/transforms-permission.unit.spec.ts
new file mode 100644
index 00000000000..2a594b843bf
--- /dev/null
+++ b/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/transforms-permission.unit.spec.ts
@@ -0,0 +1,314 @@
+import { DataPermissionValue } from "metabase/admin/permissions/types";
+import type { Group, GroupsPermissions } from "metabase-types/api";
+
+import {
+ TRANSFORMS_PERMISSION_OPTIONS,
+ buildTransformsPermission,
+} from "./transforms-permission";
+
+const defaultGroupId = 1;
+const groupId = 2;
+const databaseId = 1;
+
+const getPermissionGraph = ({
+ transformsValue = "no",
+ viewDataValue = "unrestricted",
+ createQueriesValue = "query-builder-and-native",
+}: {
+ transformsValue?: string;
+ viewDataValue?: string;
+ createQueriesValue?: string;
+} = {}): GroupsPermissions =>
+ ({
+ [defaultGroupId]: {
+ [databaseId]: {
+ transforms: "yes",
+ "view-data": "unrestricted",
+ "create-queries": "query-builder-and-native",
+ },
+ },
+ [groupId]: {
+ [databaseId]: {
+ transforms: transformsValue,
+ "view-data": viewDataValue,
+ "create-queries": createQueriesValue,
+ },
+ },
+ }) as GroupsPermissions;
+
+const isAdmin = true;
+const isNotAdmin = false;
+
+const defaultGroup: Group = {
+ id: defaultGroupId,
+ name: "All Users",
+} as Group;
+
+describe("buildTransformsPermission", () => {
+ describe("permission subject restrictions", () => {
+ it("returns null for tables level", () => {
+ const permissionModel = buildTransformsPermission(
+ { databaseId, schemaName: "schema" },
+ groupId,
+ isNotAdmin,
+ getPermissionGraph(),
+ defaultGroup,
+ "tables",
+ );
+
+ expect(permissionModel).toBeNull();
+ });
+
+ it("returns null for fields level", () => {
+ const permissionModel = buildTransformsPermission(
+ { databaseId, schemaName: "schema", tableId: 1 },
+ groupId,
+ isNotAdmin,
+ getPermissionGraph(),
+ defaultGroup,
+ "fields",
+ );
+
+ expect(permissionModel).toBeNull();
+ });
+
+ it("returns permission config for schemas level (database level)", () => {
+ const permissionModel = buildTransformsPermission(
+ { databaseId },
+ groupId,
+ isNotAdmin,
+ getPermissionGraph(),
+ defaultGroup,
+ "schemas",
+ );
+
+ expect(permissionModel).not.toBeNull();
+ expect(permissionModel?.permission).toBe("transforms");
+ expect(permissionModel?.type).toBe("transforms");
+ });
+ });
+
+ describe("permission values", () => {
+ it("sets correct permission and type fields", () => {
+ const permissionModel = buildTransformsPermission(
+ { databaseId },
+ groupId,
+ isNotAdmin,
+ getPermissionGraph({ transformsValue: "yes" }),
+ defaultGroup,
+ "schemas",
+ );
+
+ expect(permissionModel?.value).toBe("yes");
+ expect(permissionModel?.type).toBe("transforms");
+ expect(permissionModel?.permission).toBe("transforms");
+ });
+
+ it("returns 'no' value when transforms permission is not set in graph", () => {
+ const permissions = {
+ [defaultGroupId]: {
+ [databaseId]: {
+ "view-data": "unrestricted",
+ "create-queries": "query-builder-and-native",
+ },
+ },
+ [groupId]: {
+ [databaseId]: {
+ "view-data": "unrestricted",
+ "create-queries": "query-builder-and-native",
+ },
+ },
+ } as GroupsPermissions;
+
+ const permissionModel = buildTransformsPermission(
+ { databaseId },
+ groupId,
+ isNotAdmin,
+ permissions,
+ defaultGroup,
+ "schemas",
+ );
+
+ expect(permissionModel?.value).toBe("no");
+ });
+ });
+
+ describe("admin permissions", () => {
+ it("disables permission editing for admins", () => {
+ const permissionModel = buildTransformsPermission(
+ { databaseId },
+ groupId,
+ isAdmin,
+ getPermissionGraph(),
+ defaultGroup,
+ "schemas",
+ );
+
+ expect(permissionModel?.isDisabled).toBe(true);
+ expect(permissionModel?.isHighlighted).toBe(true);
+ expect(permissionModel?.disabledTooltip).toBe(
+ "Administrators always have the highest level of access to everything in Metabase.",
+ );
+ });
+ });
+
+ describe("prerequisite permissions", () => {
+ it("is disabled when view-data is not unrestricted", () => {
+ const permissionModel = buildTransformsPermission(
+ { databaseId },
+ groupId,
+ isNotAdmin,
+ getPermissionGraph({ viewDataValue: "blocked" }),
+ defaultGroup,
+ "schemas",
+ );
+
+ expect(permissionModel?.isDisabled).toBe(true);
+ expect(permissionModel?.disabledTooltip).toBe(
+ 'Transforms require "Can view" data access and "Query builder and native" for all tables in this database',
+ );
+ });
+
+ it("is disabled when create-queries is not query-builder-and-native", () => {
+ const permissionModel = buildTransformsPermission(
+ { databaseId },
+ groupId,
+ isNotAdmin,
+ getPermissionGraph({ createQueriesValue: "query-builder" }),
+ defaultGroup,
+ "schemas",
+ );
+
+ expect(permissionModel?.isDisabled).toBe(true);
+ expect(permissionModel?.disabledTooltip).toBe(
+ 'Transforms require "Can view" data access and "Query builder and native" for all tables in this database',
+ );
+ });
+
+ it("is disabled when create-queries is 'no'", () => {
+ const permissionModel = buildTransformsPermission(
+ { databaseId },
+ groupId,
+ isNotAdmin,
+ getPermissionGraph({ createQueriesValue: "no" }),
+ defaultGroup,
+ "schemas",
+ );
+
+ expect(permissionModel?.isDisabled).toBe(true);
+ });
+
+ it("forces value to 'no' when prerequisites are not met", () => {
+ const permissionModel = buildTransformsPermission(
+ { databaseId },
+ groupId,
+ isNotAdmin,
+ getPermissionGraph({
+ transformsValue: "yes",
+ viewDataValue: "blocked",
+ }),
+ defaultGroup,
+ "schemas",
+ );
+
+ expect(permissionModel?.value).toBe("no");
+ });
+
+ it("is enabled when both view-data and create-queries prerequisites are met", () => {
+ const permissionModel = buildTransformsPermission(
+ { databaseId },
+ groupId,
+ isNotAdmin,
+ getPermissionGraph(),
+ defaultGroup,
+ "schemas",
+ );
+
+ expect(permissionModel?.isDisabled).toBe(false);
+ expect(permissionModel?.disabledTooltip).toBeNull();
+ });
+ });
+
+ describe("permission options", () => {
+ it("includes only 'no' and 'yes' options", () => {
+ const permissionModel = buildTransformsPermission(
+ { databaseId },
+ groupId,
+ isNotAdmin,
+ getPermissionGraph(),
+ defaultGroup,
+ "schemas",
+ );
+
+ expect(permissionModel?.options).toStrictEqual([
+ TRANSFORMS_PERMISSION_OPTIONS.no,
+ TRANSFORMS_PERMISSION_OPTIONS.yes,
+ ]);
+ });
+ });
+
+ describe("confirmations and warnings", () => {
+ it("warns when group permission is changing to more restrictive than the default group permission", () => {
+ const permissionModel = buildTransformsPermission(
+ { databaseId },
+ groupId,
+ isNotAdmin,
+ getPermissionGraph({ transformsValue: "yes" }),
+ defaultGroup,
+ "schemas",
+ );
+
+ const [downgradePermissionConfirmation] =
+ permissionModel?.confirmations?.(DataPermissionValue.NO) ?? [];
+
+ expect(downgradePermissionConfirmation?.message).toBe(
+ 'The "All Users" group has a higher level of access than this, which will override this setting. You should limit or revoke the "All Users" group\'s access to this item.',
+ );
+ });
+
+ it("shows warning when group permission is already more restrictive than the default group", () => {
+ const permissionModel = buildTransformsPermission(
+ { databaseId },
+ groupId,
+ isNotAdmin,
+ getPermissionGraph({ transformsValue: "no" }),
+ defaultGroup,
+ "schemas",
+ );
+
+ expect(permissionModel?.warning).toBe(
+ 'The "All Users" group has a higher level of access than this, which will override this setting. You should limit or revoke the "All Users" group\'s access to this item.',
+ );
+ });
+
+ it("does not show warning when group has same or higher permission than default group", () => {
+ const permissions = {
+ [defaultGroupId]: {
+ [databaseId]: {
+ transforms: "no",
+ "view-data": "unrestricted",
+ "create-queries": "query-builder-and-native",
+ },
+ },
+ [groupId]: {
+ [databaseId]: {
+ transforms: "yes",
+ "view-data": "unrestricted",
+ "create-queries": "query-builder-and-native",
+ },
+ },
+ } as GroupsPermissions;
+
+ const permissionModel = buildTransformsPermission(
+ { databaseId },
+ groupId,
+ isNotAdmin,
+ permissions,
+ defaultGroup,
+ "schemas",
+ );
+
+ expect(permissionModel?.warning).toBeNull();
+ });
+ });
+});
diff --git a/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/utils.ts b/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/utils.tsx
similarity index 61%
rename from enterprise/frontend/src/metabase-enterprise/feature_level_permissions/utils.ts
rename to enterprise/frontend/src/metabase-enterprise/feature_level_permissions/utils.tsx
index 1d898eabb1b..9790a240ef1 100644
--- a/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/utils.ts
+++ b/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/utils.tsx
@@ -1,6 +1,12 @@
-import { t } from "ttag";
+import type { ReactNode } from "react";
+import { Link } from "react-router";
+import { jt, t } from "ttag";
-import type { PermissionSubject } from "metabase/admin/permissions/types";
+import type {
+ PermissionSubject,
+ SpecialGroupType,
+} from "metabase/admin/permissions/types";
+import { PLUGIN_TRANSFORMS } from "metabase/plugins";
import { getUser } from "metabase/selectors/user";
import type { User } from "metabase-types/api";
import type { AdminPathKey, State } from "metabase-types/store";
@@ -30,9 +36,10 @@ export const databaseManagementPermissionAllowedPathGetter = (
export const getDataColumns = (
subject: PermissionSubject,
+ groupType?: SpecialGroupType,
isExternal?: boolean,
) => {
- const allSubjectsColumns: { name: string; hint?: string }[] = [
+ const allSubjectsColumns: { name: string; hint?: ReactNode }[] = [
{
name: t`Download results`,
hint: t`Downloads of native queries are only allowed if a group has download permissions for the entire database.`,
@@ -49,6 +56,22 @@ export const getDataColumns = (
allSubjectsColumns.push({
name: t`Manage database`,
});
+
+ if (PLUGIN_TRANSFORMS.isEnabled) {
+ allSubjectsColumns.push({
+ name: t`Transforms`,
+ hint:
+ groupType === "analyst" || groupType === "admin"
+ ? null
+ : jt`Users must also be a member of the ${(
+ <Link
+ key="link"
+ to="/admin/people"
+ style={{ textDecoration: "underline" }}
+ >{t`Data Analysts group`}</Link>
+ )} to use transforms.`,
+ });
+ }
}
return allSubjectsColumns;
diff --git a/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/utils.unit.spec.ts b/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/utils.unit.spec.ts
new file mode 100644
index 00000000000..7dcc52ece1a
--- /dev/null
+++ b/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/utils.unit.spec.ts
@@ -0,0 +1,76 @@
+import { PLUGIN_TRANSFORMS } from "metabase/plugins";
+
+import { getDataColumns } from "./utils";
+
+describe("getDataColumns", () => {
+ const originalIsEnabled = PLUGIN_TRANSFORMS.isEnabled;
+
+ afterEach(() => {
+ PLUGIN_TRANSFORMS.isEnabled = originalIsEnabled;
+ });
+
+ describe("schemas subject (database level)", () => {
+ it("returns 4 columns with Transforms when PLUGIN_TRANSFORMS.isEnabled is true", () => {
+ PLUGIN_TRANSFORMS.isEnabled = true;
+
+ expect(getDataColumns("schemas", "admin")).toStrictEqual([
+ {
+ name: "Download results",
+ hint: "Downloads of native queries are only allowed if a group has download permissions for the entire database.",
+ },
+ { name: "Manage table metadata" },
+ { name: "Manage database" },
+ { name: "Transforms", hint: null },
+ ]);
+ });
+
+ it("returns 3 columns without Transforms when PLUGIN_TRANSFORMS.isEnabled is false", () => {
+ PLUGIN_TRANSFORMS.isEnabled = false;
+
+ expect(getDataColumns("schemas")).toStrictEqual([
+ {
+ name: "Download results",
+ hint: "Downloads of native queries are only allowed if a group has download permissions for the entire database.",
+ },
+ { name: "Manage table metadata" },
+ { name: "Manage database" },
+ ]);
+ });
+ });
+
+ describe("tables subject (schema level)", () => {
+ it("returns 2 columns without Transforms regardless of PLUGIN_TRANSFORMS.isEnabled", () => {
+ const expectedColumns = [
+ {
+ name: "Download results",
+ hint: "Downloads of native queries are only allowed if a group has download permissions for the entire database.",
+ },
+ { name: "Manage table metadata" },
+ ];
+
+ PLUGIN_TRANSFORMS.isEnabled = true;
+ expect(getDataColumns("tables")).toStrictEqual(expectedColumns);
+
+ PLUGIN_TRANSFORMS.isEnabled = false;
+ expect(getDataColumns("tables")).toStrictEqual(expectedColumns);
+ });
+ });
+
+ describe("fields subject (table level)", () => {
+ it("returns 2 columns without Transforms regardless of PLUGIN_TRANSFORMS.isEnabled", () => {
+ const expectedColumns = [
+ {
+ name: "Download results",
+ hint: "Downloads of native queries are only allowed if a group has download permissions for the entire database.",
+ },
+ { name: "Manage table metadata" },
+ ];
+
+ PLUGIN_TRANSFORMS.isEnabled = true;
+ expect(getDataColumns("fields")).toStrictEqual(expectedColumns);
+
+ PLUGIN_TRANSFORMS.isEnabled = false;
+ expect(getDataColumns("fields")).toStrictEqual(expectedColumns);
+ });
+ });
+});
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonDataPicker/TableSelector/TableSelector.tsx b/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonDataPicker/TableSelector/TableSelector.tsx
index 63dd9b82ec4..1964e03b134 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonDataPicker/TableSelector/TableSelector.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonDataPicker/TableSelector/TableSelector.tsx
@@ -95,15 +95,17 @@ export function TableSelector({
</Stack>
</Button>
- <Tooltip label={t`Remove this table`}>
- <ActionIcon
- onClick={onRemove}
- pr="sm"
- aria-label={t`Remove this table`}
- >
- <Icon name="close" c="text-primary" />
- </ActionIcon>
- </Tooltip>
+ {!disabled && (
+ <Tooltip label={t`Remove this table`}>
+ <ActionIcon
+ onClick={onRemove}
+ pr="sm"
+ aria-label={t`Remove this table`}
+ >
+ <Icon name="close" c="text-primary" />
+ </ActionIcon>
+ </Tooltip>
+ )}
</Group>
{isOpened && (
<DataPickerModal
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonTransformEditor.tsx b/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonTransformEditor.tsx
index 911d3de9d3e..8ee834f919b 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonTransformEditor.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonTransformEditor.tsx
@@ -22,6 +22,7 @@ export function PythonTransformEditor({
source,
proposedSource,
isEditMode,
+ readOnly,
transformId,
onChangeSource,
onAcceptProposed,
@@ -86,6 +87,7 @@ export function PythonTransformEditor({
<PythonTransformTopBar
databaseId={source["source-database"]}
isEditMode={isEditMode}
+ readOnly={readOnly}
transformId={transformId}
onDatabaseChange={handleDatabaseChange}
/>
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonTransformTopBar/PythonTransformTopBar.tsx b/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonTransformTopBar/PythonTransformTopBar.tsx
index dac483abf14..02738be31db 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonTransformTopBar/PythonTransformTopBar.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonTransformTopBar/PythonTransformTopBar.tsx
@@ -17,6 +17,7 @@ import S from "./PythonTransformTopBar.module.css";
type PythonTransformTopBarProps = {
databaseId?: DatabaseId;
isEditMode?: boolean;
+ readOnly?: boolean;
transformId?: TransformId;
onDatabaseChange?: (databaseId: DatabaseId) => void;
};
@@ -24,12 +25,13 @@ type PythonTransformTopBarProps = {
export function PythonTransformTopBar({
databaseId,
isEditMode,
+ readOnly,
transformId,
onDatabaseChange,
}: PythonTransformTopBarProps) {
const isRemoteSyncReadOnly = useSelector(getIsRemoteSyncReadOnly);
const showEditDefinitionButton =
- !isEditMode && transformId && !isRemoteSyncReadOnly;
+ !isEditMode && transformId && !isRemoteSyncReadOnly && !readOnly;
const { data: database } = useGetDatabaseQuery(
databaseId != null ? { id: databaseId } : skipToken,
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/components/CreateTransformMenu/utils.ts b/enterprise/frontend/src/metabase-enterprise/transforms/components/CreateTransformMenu/utils.ts
index 89fad99fe17..71a0d7a5ab1 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms/components/CreateTransformMenu/utils.ts
+++ b/enterprise/frontend/src/metabase-enterprise/transforms/components/CreateTransformMenu/utils.ts
@@ -8,7 +8,7 @@ export function shouldDisableItem(
databases?: Database[],
) {
if (
- // Disable questions based on unsuppported databases
+ // Disable questions based on unsupported databases
item.model === "card" ||
item.model === "dataset" ||
item.model === "metric"
@@ -16,7 +16,10 @@ export function shouldDisableItem(
const database = databases?.find(
(database) => database.id === item.database_id,
);
- return !doesDatabaseSupportTransforms(database);
+ return (
+ database?.transforms_permissions !== "write" ||
+ !doesDatabaseSupportTransforms(database)
+ );
}
if (item.model === "dashboard") {
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/components/IncrementalTransform/IncrementalTransformSettings.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/components/IncrementalTransform/IncrementalTransformSettings.tsx
index 0e464f597ee..8ae660be892 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms/components/IncrementalTransform/IncrementalTransformSettings.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/transforms/components/IncrementalTransform/IncrementalTransformSettings.tsx
@@ -38,6 +38,7 @@ type IncrementalTransformSettingsProps = {
incremental: boolean;
onIncrementalChange: (value: boolean) => void;
variant?: "embedded" | "standalone";
+ readOnly?: boolean;
};
export const IncrementalTransformSettings = ({
@@ -45,6 +46,7 @@ export const IncrementalTransformSettings = ({
incremental,
onIncrementalChange,
variant = "embedded",
+ readOnly,
}: IncrementalTransformSettingsProps) => {
const metadata = useSelector(getMetadata);
const libQuery = getLibQuery(source, metadata);
@@ -68,7 +70,9 @@ export const IncrementalTransformSettings = ({
const renderIncrementalSwitch = () => {
const switchContent = (
<Switch
- disabled={isMultiTablePythonTransform || isRemoteSyncReadOnly}
+ disabled={
+ readOnly || isMultiTablePythonTransform || isRemoteSyncReadOnly
+ }
checked={incremental}
size="sm"
label={
@@ -127,6 +131,7 @@ export const IncrementalTransformSettings = ({
source={source}
query={libQuery}
type={transformType}
+ readOnly={readOnly}
/>
</Group>
<TargetStrategyFields variant={variant} />
@@ -195,12 +200,14 @@ type SourceStrategyFieldsProps = {
source: TransformSource;
query: Lib.Query | null;
type: "query" | "native" | "python";
+ readOnly?: boolean;
};
function SourceStrategyFields({
source,
query,
type,
+ readOnly,
}: SourceStrategyFieldsProps) {
const { values } = useFormikContext<IncrementalSettingsFormValues>();
return (
@@ -211,6 +218,7 @@ function SourceStrategyFields({
label={t`Source Strategy`}
description={t`How to track which rows to process`}
data={SOURCE_STRATEGY_OPTIONS}
+ disabled={readOnly}
/>
)}
{values.sourceStrategy === "checkpoint" && (
@@ -223,6 +231,7 @@ function SourceStrategyFields({
description={t`Pick the field that we should scan to determine which records are new or changed`}
descriptionProps={{ lh: "1rem" }}
query={query}
+ disabled={readOnly}
/>
)}
{type === "native" && query && (
@@ -233,6 +242,7 @@ function SourceStrategyFields({
description={t`Pick the column that we should scan to determine which records are new or changed`}
descriptionProps={{ lh: "1rem" }}
query={query}
+ disabled={readOnly}
/>
)}
{type === "python" && "source-tables" in source && (
@@ -243,6 +253,7 @@ function SourceStrategyFields({
description={t`Pick the field that we should scan to determine which records are new or changed`}
descriptionProps={{ lh: "1rem" }}
sourceTables={source["source-tables"]}
+ disabled={readOnly}
/>
)}
</>
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/components/IncrementalTransform/KeysetColumnSelect/PythonKeysetColumnSelect.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/components/IncrementalTransform/KeysetColumnSelect/PythonKeysetColumnSelect.tsx
index 23846a4591b..e6502ad0ddf 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms/components/IncrementalTransform/KeysetColumnSelect/PythonKeysetColumnSelect.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/transforms/components/IncrementalTransform/KeysetColumnSelect/PythonKeysetColumnSelect.tsx
@@ -17,6 +17,7 @@ type PythonKeysetColumnSelectProps = {
description: React.ReactNode;
descriptionProps?: InputDescriptionProps & DataAttributes;
sourceTables: PythonTransformTableAliases;
+ disabled?: boolean;
};
export function PythonKeysetColumnSelect({
@@ -26,6 +27,7 @@ export function PythonKeysetColumnSelect({
description,
descriptionProps,
sourceTables,
+ disabled,
}: PythonKeysetColumnSelectProps) {
const metadata = useSelector(getMetadata);
@@ -69,7 +71,7 @@ export function PythonKeysetColumnSelect({
description={description}
descriptionProps={descriptionProps}
query={query}
- disabled={isLoading || !!error}
+ disabled={disabled || isLoading || !!error}
/>
);
}
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/components/IncrementalTransform/NativeQueryColumnSelect/NativeQueryColumnSelect.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/components/IncrementalTransform/NativeQueryColumnSelect/NativeQueryColumnSelect.tsx
index 72a3a6ec1b0..08eaf2a50ea 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms/components/IncrementalTransform/NativeQueryColumnSelect/NativeQueryColumnSelect.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/transforms/components/IncrementalTransform/NativeQueryColumnSelect/NativeQueryColumnSelect.tsx
@@ -17,6 +17,7 @@ type NativeQueryColumnSelectProps = {
descriptionProps?: InputDescriptionProps & DataAttributes;
placeholder: string;
query: Lib.Query;
+ disabled?: boolean;
};
export function NativeQueryColumnSelect({
@@ -26,6 +27,7 @@ export function NativeQueryColumnSelect({
descriptionProps,
placeholder,
query,
+ disabled,
}: NativeQueryColumnSelectProps) {
const [columns, setColumns] = useState<string[] | null>(null);
const [extractColumns, { isLoading }] = useExtractColumnsFromQueryMutation();
@@ -75,7 +77,7 @@ export function NativeQueryColumnSelect({
<FormSelect
name={name}
rightSection={isLoading ? <Loader size="sm" /> : null}
- disabled={isLoading}
+ disabled={disabled || isLoading}
label={label}
description={description}
placeholder={placeholder}
@@ -92,6 +94,7 @@ export function NativeQueryColumnSelect({
placeholder={placeholder}
description={description}
descriptionProps={descriptionProps}
+ disabled={disabled}
/>
);
}
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/components/JobEditor/JobEditor.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/components/JobEditor/JobEditor.tsx
index 5eba4d1b2ba..560e30ed996 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms/components/JobEditor/JobEditor.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/transforms/components/JobEditor/JobEditor.tsx
@@ -23,6 +23,7 @@ type JobEditorProps = {
job: TransformJobInfo;
menu?: ReactNode;
actions?: ReactNode;
+ readOnly?: boolean;
onNameChange: (name: string) => void;
onScheduleChange: (
schedule: string,
@@ -35,6 +36,7 @@ export function JobEditor({
job,
menu,
actions,
+ readOnly,
onNameChange,
onScheduleChange,
onTagListChange,
@@ -47,6 +49,7 @@ export function JobEditor({
initialValue={job.name}
maxLength={NAME_MAX_LENGTH}
onChange={onNameChange}
+ readOnly={readOnly}
/>
}
py={0}
@@ -63,8 +66,16 @@ export function JobEditor({
data-testid="jobs-header"
/>
<Stack gap="3.5rem">
- <ScheduleSection job={job} onScheduleChange={onScheduleChange} />
- <TagSection job={job} onTagsChange={onTagListChange} />
+ <ScheduleSection
+ job={job}
+ readOnly={readOnly}
+ onScheduleChange={onScheduleChange}
+ />
+ <TagSection
+ job={job}
+ readOnly={readOnly}
+ onTagsChange={onTagListChange}
+ />
{job.id != null && <DependenciesSection jobId={job.id} />}
</Stack>
</PageContainer>
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/components/JobEditor/ScheduleSection/ScheduleSection.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/components/JobEditor/ScheduleSection/ScheduleSection.tsx
index 3a68832685d..624672b22d4 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms/components/JobEditor/ScheduleSection/ScheduleSection.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/transforms/components/JobEditor/ScheduleSection/ScheduleSection.tsx
@@ -20,6 +20,7 @@ import type { TransformJobInfo } from "../types";
type ScheduleSectionProps = {
job: TransformJobInfo;
+ readOnly?: boolean;
onScheduleChange: (
schedule: string,
uiDisplayType: ScheduleDisplayType,
@@ -28,6 +29,7 @@ type ScheduleSectionProps = {
export function ScheduleSection({
job,
+ readOnly,
onScheduleChange,
}: ScheduleSectionProps) {
return (
@@ -36,7 +38,9 @@ export function ScheduleSection({
description={t`Configure when this job should run.`}
>
<Box px="xl" py="lg">
- <ScheduleWidget job={job} onChangeSchedule={onScheduleChange} />
+ <Box display="contents" component="fieldset" disabled={readOnly}>
+ <ScheduleWidget job={job} onChangeSchedule={onScheduleChange} />
+ </Box>
</Box>
<Divider />
<Group px="xl" py="md" justify="space-between">
@@ -44,7 +48,7 @@ export function ScheduleSection({
run={job?.last_run ?? null}
neverRunMessage={t`This job hasn’t been run before.`}
/>
- <RunButtonSection job={job} />
+ <RunButtonSection job={job} readOnly={readOnly} />
</Group>
</TitleSection>
);
@@ -110,14 +114,24 @@ function ScheduleWidget({ job, onChangeSchedule }: ScheduleWidgetProps) {
type RunButtonSectionProps = {
job: TransformJobInfo;
+ readOnly?: boolean;
};
-function RunButtonSection({ job }: RunButtonSectionProps) {
+function RunButtonSection({ job, readOnly }: RunButtonSectionProps) {
const [runJob] = useRunTransformJobMutation();
const { sendErrorToast } = useMetadataToasts();
const isSaved = job.id != null;
const hasTags = job.tag_ids?.length !== 0;
+ const tooltipLabel = (() => {
+ if (!hasTags) {
+ return t`This job doesn't have tags to run.`;
+ }
+ if (readOnly) {
+ return t`Sorry, you don't have permission to run one or more of this job's transforms.`;
+ }
+ })();
+
const handleRun = async () => {
if (job.id == null) {
return;
@@ -133,11 +147,11 @@ function RunButtonSection({ job }: RunButtonSectionProps) {
};
return (
- <Tooltip label={t`This job doesn't have tags to run.`} disabled={hasTags}>
+ <Tooltip label={tooltipLabel} disabled={!tooltipLabel}>
<RunButton
id={job.id}
run={job.last_run}
- isDisabled={!isSaved || !hasTags}
+ isDisabled={!isSaved || !hasTags || readOnly}
onRun={handleRun}
/>
</Tooltip>
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/components/JobEditor/TagSection/TagSection.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/components/JobEditor/TagSection/TagSection.tsx
index 28a9909d68d..347622de99f 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms/components/JobEditor/TagSection/TagSection.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/transforms/components/JobEditor/TagSection/TagSection.tsx
@@ -9,17 +9,23 @@ import type { TransformJobInfo } from "../types";
type TagSectionProps = {
job: TransformJobInfo;
+ readOnly?: boolean;
onTagsChange: (tagIds: TransformTagId[]) => void;
};
-export function TagSection({ job, onTagsChange }: TagSectionProps) {
+export function TagSection({ job, readOnly, onTagsChange }: TagSectionProps) {
return (
<TitleSection
label={t`Tags to run`}
description={t`This job will run all transforms tagged with any of the tags you pick here.`}
>
<Box p="xl">
- <TagMultiSelect tagIds={job.tag_ids ?? []} onChange={onTagsChange} />
+ <TagMultiSelect
+ tagIds={job.tag_ids ?? []}
+ readOnly={readOnly}
+ requireTransformWriteAccess
+ onChange={onTagsChange}
+ />
</Box>
</TitleSection>
);
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/components/TagMultiSelect/TagMultiSelect.module.css b/enterprise/frontend/src/metabase-enterprise/transforms/components/TagMultiSelect/TagMultiSelect.module.css
index b3bf78fad35..66a5ca20174 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms/components/TagMultiSelect/TagMultiSelect.module.css
+++ b/enterprise/frontend/src/metabase-enterprise/transforms/components/TagMultiSelect/TagMultiSelect.module.css
@@ -1,7 +1,21 @@
+.option[data-combobox-disabled] {
+ pointer-events: all;
+ cursor: not-allowed;
+
+ &:hover {
+ background-color: transparent;
+ }
+
+ .selectItem {
+ color: inherit;
+ background-color: inherit;
+ }
+}
+
.actionIcon {
visibility: hidden;
}
-.selectItem:hover .actionIcon {
+.selectItem.editable:hover .actionIcon {
visibility: visible;
}
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/components/TagMultiSelect/TagMultiSelect.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/components/TagMultiSelect/TagMultiSelect.tsx
index 20f633aa33f..e3e09eb4889 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms/components/TagMultiSelect/TagMultiSelect.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/transforms/components/TagMultiSelect/TagMultiSelect.tsx
@@ -1,3 +1,4 @@
+import cx from "classnames";
import { type MouseEvent, useState } from "react";
import { jt, t } from "ttag";
@@ -30,12 +31,14 @@ type TagMultiSelectProps = {
tagIds: TransformTagId[];
onChange: (tagIds: TransformTagId[], undoable?: boolean) => void;
readOnly?: boolean;
+ requireTransformWriteAccess?: boolean;
};
export function TagMultiSelect({
tagIds,
onChange,
readOnly,
+ requireTransformWriteAccess,
}: TagMultiSelectProps) {
const { data: tags = [], isLoading } = useListTransformTagsQuery();
const [createTag, { isLoading: isCreating }] =
@@ -98,8 +101,9 @@ export function TagMultiSelect({
return (
<>
<MultiSelect
+ classNames={{ option: S.option }}
value={tagIds.map(getValue)}
- data={getOptions(tags, trimmedSearchValue)}
+ data={getOptions(tags, trimmedSearchValue, requireTransformWriteAccess)}
placeholder={readOnly ? t`Tags are read-only` : t`Add tags`}
searchValue={searchValue}
searchable
@@ -124,6 +128,7 @@ export function TagMultiSelect({
selected={item.checked}
onUpdateClick={handleUpdateClick}
onDeleteClick={handleDeleteClick}
+ requireTransformWriteAccess={requireTransformWriteAccess}
/>
)
}
@@ -177,12 +182,14 @@ function NewTagSelectItem({
type ExistingTagSelectItemProps = SelectItemProps & {
tag: TransformTag;
+ requireTransformWriteAccess?: boolean;
onUpdateClick: (tag: TransformTag) => void;
onDeleteClick: (tag: TransformTag) => void;
};
function ExistingTagSelectItem({
tag,
+ requireTransformWriteAccess,
selected,
onUpdateClick,
onDeleteClick,
@@ -199,10 +206,23 @@ function ExistingTagSelectItem({
onDeleteClick(tag);
};
+ const selectable = requireTransformWriteAccess ? tag.can_run : true;
+
return (
- <SelectItem className={S.selectItem} selected={selected} py="xs">
+ <SelectItem
+ className={cx(S.selectItem, { [S.editable]: tag.can_run })}
+ selected={selected}
+ py="xs"
+ >
<Text c="inherit" lh="inherit" flex={1}>
{tag.name}
+ {!selectable && (
+ <Tooltip
+ label={t`This tag contains a transform you don't have permission to run.`}
+ >
+ <Icon name="lock_filled" size={14} ml="xs" />
+ </Tooltip>
+ )}
</Text>
<Tooltip label={t`Rename tag`}>
<ActionIcon
@@ -238,11 +258,16 @@ function getTagId(value: string): TransformTagId {
return parseInt(value, 10);
}
-function getOptions(tags: TransformTag[], trimmedSearchValue: string) {
+function getOptions(
+ tags: TransformTag[],
+ trimmedSearchValue: string,
+ requireTransformWriteAccess?: boolean,
+) {
const options = tags.map((tag) => ({
tag,
value: getValue(tag.id),
label: tag.name,
+ disabled: requireTransformWriteAccess ? !tag.can_run : false,
}));
if (
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformEditor/TransformEditor.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformEditor/TransformEditor.tsx
index 273111b7ee6..be0c64e7ff8 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformEditor/TransformEditor.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformEditor/TransformEditor.tsx
@@ -27,7 +27,8 @@ type TransformEditorProps = {
onAcceptProposed: () => void;
onRejectProposed: () => void;
onBlur?: () => void;
- isEditMode: boolean;
+ isEditMode?: boolean;
+ readOnly?: boolean;
transformId?: TransformId;
};
@@ -42,6 +43,7 @@ export function TransformEditor({
onRejectProposed,
onBlur,
isEditMode,
+ readOnly,
transformId,
}: TransformEditorProps) {
const metadata = useSelector(getMetadata);
@@ -63,7 +65,7 @@ export function TransformEditor({
const isRemoteSyncReadOnly = useSelector(getIsRemoteSyncReadOnly);
const showEditDefinitionButton =
- !!transformId && !isEditMode && !isRemoteSyncReadOnly;
+ !!transformId && !readOnly && !isEditMode && !isRemoteSyncReadOnly;
const handleQueryChange = (query: Lib.Query) => {
const newSource: QueryTransformSource = {
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformHeader/TransformHeader.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformHeader/TransformHeader.tsx
index 6afa2a6452f..14b6b9a4836 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformHeader/TransformHeader.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformHeader/TransformHeader.tsx
@@ -19,6 +19,7 @@ type TransformHeaderProps = {
actions?: ReactNode;
hasMenu?: boolean;
isEditMode?: boolean;
+ readOnly?: boolean;
transform: Transform;
} & Omit<StackProps, "title">;
@@ -27,6 +28,7 @@ export function TransformHeader({
actions,
hasMenu = true,
isEditMode = false,
+ readOnly,
...restProps
}: TransformHeaderProps) {
const isRemoteSyncReadOnly = useSelector(getIsRemoteSyncReadOnly);
@@ -37,12 +39,12 @@ export function TransformHeader({
return (
<PaneHeader
- title={<TransformNameInput transform={transform} />}
+ title={<TransformNameInput transform={transform} readOnly={readOnly} />}
icon="transform"
menu={
hasMenu && (
<TransformMoreMenu
- readOnly={isRemoteSyncReadOnly}
+ readOnly={readOnly || isRemoteSyncReadOnly}
transform={transform}
/>
)
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformHeader/TransformMoreMenu/TransformMoreMenu.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformHeader/TransformMoreMenu/TransformMoreMenu.tsx
index 40a4be75689..e928bf4538f 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformHeader/TransformMoreMenu/TransformMoreMenu.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformHeader/TransformMoreMenu/TransformMoreMenu.tsx
@@ -44,6 +44,7 @@ export function TransformMoreMenu({
<TransformRevisionHistorySidebar
transform={transform}
onClose={() => setIsHistorySidebarOpen(false)}
+ readOnly={readOnly}
/>
)}
</>
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformHeader/TransformNameInput.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformHeader/TransformNameInput.tsx
index 445f46f0199..1fcd7bffa6d 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformHeader/TransformNameInput.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformHeader/TransformNameInput.tsx
@@ -8,9 +8,13 @@ import type { Transform } from "metabase-types/api";
type TransformNameInputProps = {
transform: Transform;
+ readOnly?: boolean;
};
-export const TransformNameInput = ({ transform }: TransformNameInputProps) => {
+export const TransformNameInput = ({
+ transform,
+ readOnly,
+}: TransformNameInputProps) => {
const [updateTransform] = useUpdateTransformMutation();
const { sendSuccessToast, sendErrorToast } = useMetadataToasts();
@@ -32,6 +36,7 @@ export const TransformNameInput = ({ transform }: TransformNameInputProps) => {
initialValue={transform.name}
maxLength={NAME_MAX_LENGTH}
onChange={handleChangeName}
+ readOnly={readOnly}
/>
);
};
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformOwnerAvatar/TransformOwnerAvatar.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformOwnerAvatar/TransformOwnerAvatar.tsx
new file mode 100644
index 00000000000..b18bf023e29
--- /dev/null
+++ b/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformOwnerAvatar/TransformOwnerAvatar.tsx
@@ -0,0 +1,46 @@
+import { t } from "ttag";
+
+import { Ellipsified } from "metabase/common/components/Ellipsified";
+import { getUserName } from "metabase/lib/user";
+import { Avatar, Flex, Icon } from "metabase/ui";
+import type { Transform } from "metabase-types/api";
+
+export const TransformOwnerAvatar = ({
+ transform,
+}: {
+ transform: Pick<Transform, "owner" | "owner_email">;
+}) => {
+ const owner = transform.owner;
+ const hasUserName = owner?.first_name || owner?.last_name;
+
+ if (hasUserName) {
+ const displayName = getUserName(owner);
+ return (
+ <Flex align="center" gap="sm">
+ <Avatar size="sm" name={displayName} />
+ <Ellipsified>{displayName}</Ellipsified>
+ </Flex>
+ );
+ }
+
+ const ownerEmail = transform.owner_email ?? owner?.email;
+ if (ownerEmail) {
+ return (
+ <Flex align="center" gap="sm">
+ <Avatar size="sm" color="initials" name="emails">
+ <Icon name="mail" />
+ </Avatar>
+ <Ellipsified>{ownerEmail}</Ellipsified>
+ </Flex>
+ );
+ }
+
+ return (
+ <Flex align="center" gap="sm">
+ <Avatar size="sm" color="background-secondary" name="unknown">
+ <Icon name="person" c="text-secondary" />
+ </Avatar>
+ <Ellipsified c="text-secondary">{t`No owner`}</Ellipsified>
+ </Flex>
+ );
+};
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformRevisionHistorySidebar/TransformRevisionHistorySidebar.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformRevisionHistorySidebar/TransformRevisionHistorySidebar.tsx
index e99c1b667a8..474942e59b2 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformRevisionHistorySidebar/TransformRevisionHistorySidebar.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/transforms/components/TransformRevisionHistorySidebar/TransformRevisionHistorySidebar.tsx
@@ -19,11 +19,13 @@ import type { Transform } from "metabase-types/api";
interface TransformRevisionHistorySidebarProps {
transform: Transform;
onClose: () => void;
+ readOnly?: boolean;
}
export function TransformRevisionHistorySidebar({
transform,
onClose,
+ readOnly,
}: TransformRevisionHistorySidebarProps) {
const [isOpen, setIsOpen] = useState(false);
const currentUser = useSelector(getUser);
@@ -72,7 +74,7 @@ export function TransformRevisionHistorySidebar({
})
}
entity="transform"
- canWrite
+ canWrite={!readOnly}
/>
)}
</SidesheetCard>
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/hooks/use-transform-permissions.ts b/enterprise/frontend/src/metabase-enterprise/transforms/hooks/use-transform-permissions.ts
new file mode 100644
index 00000000000..909c64d2288
--- /dev/null
+++ b/enterprise/frontend/src/metabase-enterprise/transforms/hooks/use-transform-permissions.ts
@@ -0,0 +1,44 @@
+import { useMemo } from "react";
+
+import { useListDatabasesQuery } from "metabase/api/database";
+import type { Database, Transform } from "metabase-types/api";
+
+import { sourceDatabaseId } from "../utils";
+
+export const canEditTransform = (
+ transform: Transform,
+ transformsDatabases: Database[],
+): boolean => {
+ const dbId = sourceDatabaseId(transform.source);
+ return transformsDatabases.some((db) => db.id === dbId);
+};
+
+export const useTransformPermissions = ({
+ transform,
+}: {
+ transform?: Transform;
+} = {}) => {
+ const {
+ data: databases,
+ isLoading: isLoadingDatabases,
+ error: databasesError,
+ } = useListDatabasesQuery({ include_analytics: true });
+
+ const transformsDatabases = useMemo(() => {
+ return databases?.data.filter((d) => d.transforms_permissions === "write");
+ }, [databases]);
+
+ const readOnly = useMemo(() => {
+ if (!transformsDatabases || !transform) {
+ return;
+ }
+ return !canEditTransform(transform, transformsDatabases);
+ }, [transformsDatabases, transform]);
+
+ return {
+ readOnly,
+ transformsDatabases,
+ isLoadingDatabases,
+ databasesError,
+ };
+};
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/index.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/index.tsx
index 198789c53d4..d4fc30307c7 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms/index.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/transforms/index.tsx
@@ -1,12 +1,21 @@
import { PLUGIN_ENTITIES, PLUGIN_TRANSFORMS } from "metabase/plugins";
-import { getUserIsAdmin } from "metabase/selectors/user";
+import { getUser, getUserIsAdmin } from "metabase/selectors/user";
import { useGetTransformQuery } from "metabase-enterprise/api";
import { Transforms } from "metabase-enterprise/entities/transforms";
import { hasPremiumFeature } from "metabase-enterprise/settings";
+import type { State } from "metabase-types/store";
import { TransformPicker } from "./components/TransformPicker";
import { getDataStudioTransformRoutes } from "./routes";
+const canAccessTransforms = (state: State): boolean => {
+ if (getUserIsAdmin(state)) {
+ return true;
+ }
+ const user = getUser(state);
+ return user?.permissions?.can_access_transforms ?? false;
+};
+
/**
* Initialize transforms plugin features.
* Transforms are available:
@@ -21,7 +30,7 @@ export function initializePlugin() {
if (shouldEnable) {
PLUGIN_TRANSFORMS.isEnabled = true;
PLUGIN_ENTITIES.entities["transforms"] = Transforms;
- PLUGIN_TRANSFORMS.canAccessTransforms = getUserIsAdmin;
+ PLUGIN_TRANSFORMS.canAccessTransforms = canAccessTransforms;
PLUGIN_TRANSFORMS.getDataStudioTransformRoutes =
getDataStudioTransformRoutes;
PLUGIN_TRANSFORMS.TransformPicker = TransformPicker;
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/pages/JobPage/JobPage.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/pages/JobPage/JobPage.tsx
index dee6a7cbd19..c7c3111f45b 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms/pages/JobPage/JobPage.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/transforms/pages/JobPage/JobPage.tsx
@@ -1,4 +1,4 @@
-import { useState } from "react";
+import { useMemo, useState } from "react";
import { t } from "ttag";
import { skipToken } from "metabase/api";
@@ -8,8 +8,13 @@ import { useMetadataToasts } from "metabase/metadata/hooks";
import { Center } from "metabase/ui";
import {
useGetTransformJobQuery,
+ useListTransformJobTransformsQuery,
useUpdateTransformJobMutation,
} from "metabase-enterprise/api";
+import {
+ canEditTransform,
+ useTransformPermissions,
+} from "metabase-enterprise/transforms/hooks/use-transform-permissions";
import type {
ScheduleDisplayType,
TransformJob,
@@ -39,16 +44,33 @@ export function JobPage({ params }: JobPageProps) {
const [isPolling, setIsPolling] = useState(false);
const {
data: job,
- isLoading,
- error,
+ isLoading: isLoadingJob,
+ error: jobError,
} = useGetTransformJobQuery(jobId ?? skipToken, {
pollingInterval: isPolling ? POLLING_INTERVAL : undefined,
});
+ const { transformsDatabases, isLoadingDatabases, databasesError } =
+ useTransformPermissions();
+ const {
+ data: transforms,
+ isLoading: isLoadingTransforms,
+ error: transformsError,
+ } = useListTransformJobTransformsQuery(jobId || skipToken);
+ const readOnly = useMemo(() => {
+ if (!transformsDatabases || !transforms) {
+ return;
+ }
+ return !transforms.every((t) => canEditTransform(t, transformsDatabases));
+ }, [transforms, transformsDatabases]);
+
if (isPolling !== isPollingNeeded(job)) {
setIsPolling(isPollingNeeded(job));
}
+ const isLoading = isLoadingJob || isLoadingDatabases || isLoadingTransforms;
+ const error = jobError || databasesError || transformsError;
+
if (isLoading || error != null || job == null) {
return (
<Center h="100%">
@@ -57,14 +79,15 @@ export function JobPage({ params }: JobPageProps) {
);
}
- return <JobPageBody job={job} />;
+ return <JobPageBody job={job} readOnly={readOnly} />;
}
type JobPageBodyProps = {
job: TransformJob;
+ readOnly?: boolean;
};
-function JobPageBody({ job }: JobPageBodyProps) {
+function JobPageBody({ job, readOnly }: JobPageBodyProps) {
const [updateJob] = useUpdateTransformJobMutation();
const { sendErrorToast, sendSuccessToast, sendUndoToast } =
useMetadataToasts();
@@ -127,7 +150,8 @@ function JobPageBody({ job }: JobPageBodyProps) {
return (
<JobEditor
job={job}
- menu={<JobMoreMenu job={job} />}
+ menu={!readOnly && <JobMoreMenu job={job} />}
+ readOnly={readOnly}
onNameChange={handleNameChange}
onScheduleChange={handleScheduleChange}
onTagListChange={handleTagListChange}
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/pages/NewTransformPage/NewTransformPage.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/pages/NewTransformPage/NewTransformPage.tsx
index 73222938f1a..6423326ddc3 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms/pages/NewTransformPage/NewTransformPage.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/transforms/pages/NewTransformPage/NewTransformPage.tsx
@@ -4,11 +4,7 @@ import { Link, type Route } from "react-router";
import { push } from "react-router-redux";
import { t } from "ttag";
-import {
- skipToken,
- useGetCardQuery,
- useListDatabasesQuery,
-} from "metabase/api";
+import { skipToken, useGetCardQuery } from "metabase/api";
import { LeaveRouteConfirmModal } from "metabase/common/components/LeaveConfirmModal";
import { LoadingAndErrorWrapper } from "metabase/common/components/LoadingAndErrorWrapper";
import { useDispatch, useSelector } from "metabase/lib/redux";
@@ -24,6 +20,7 @@ import {
PaneHeaderActions,
PaneHeaderInput,
} from "metabase-enterprise/data-studio/common/components/PaneHeader";
+import { useTransformPermissions } from "metabase-enterprise/transforms/hooks/use-transform-permissions";
import * as Lib from "metabase-lib";
import type {
Database,
@@ -53,12 +50,12 @@ type NewTransformPageProps = {
function NewTransformPage({ initialSource, route }: NewTransformPageProps) {
const {
- data: databases,
- isLoading,
- error,
- } = useListDatabasesQuery({ include_analytics: true });
+ transformsDatabases,
+ isLoadingDatabases: isLoading,
+ databasesError: error,
+ } = useTransformPermissions();
- if (isLoading || error != null || databases == null) {
+ if (isLoading || error != null || transformsDatabases == null) {
return (
<Center h="100%">
<LoadingAndErrorWrapper loading={isLoading} error={error} />
@@ -69,7 +66,7 @@ function NewTransformPage({ initialSource, route }: NewTransformPageProps) {
return (
<NewTransformPageBody
initialSource={initialSource}
- databases={databases.data}
+ databases={transformsDatabases}
route={route}
/>
);
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformDependenciesPage/TransformDependenciesPage.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformDependenciesPage/TransformDependenciesPage.tsx
index dc58a61893c..5072ccfcab1 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformDependenciesPage/TransformDependenciesPage.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformDependenciesPage/TransformDependenciesPage.tsx
@@ -7,6 +7,7 @@ import { PLUGIN_DEPENDENCIES } from "metabase/plugins";
import { Card, Center } from "metabase/ui";
import { useGetTransformQuery } from "metabase-enterprise/api";
import { PageContainer } from "metabase-enterprise/data-studio/common/components/PageContainer";
+import { useTransformPermissions } from "metabase-enterprise/transforms/hooks/use-transform-permissions";
import { TransformHeader } from "../../components/TransformHeader";
@@ -26,9 +27,13 @@ export function TransformDependenciesPage({
const id = Urls.extractEntityId(params?.transformId);
const {
data: transform,
- isLoading,
- error,
+ isLoading: isLoadingTransform,
+ error: transformError,
} = useGetTransformQuery(id ?? skipToken);
+ const { readOnly, isLoadingDatabases, databasesError } =
+ useTransformPermissions({ transform });
+ const isLoading = isLoadingTransform || isLoadingDatabases;
+ const error = transformError || databasesError;
if (id == null || transform == null || isLoading || error != null) {
return (
@@ -40,7 +45,7 @@ export function TransformDependenciesPage({
return (
<PageContainer data-testid="transforms-dependencies-content">
- <TransformHeader transform={transform} />
+ <TransformHeader transform={transform} readOnly={readOnly} />
<PLUGIN_DEPENDENCIES.DependencyGraphPageContext.Provider
value={{
baseUrl: Urls.transformDependencies(transform.id),
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformListPage/TransformListPage.module.css b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformListPage/TransformListPage.module.css
new file mode 100644
index 00000000000..4b9722155f2
--- /dev/null
+++ b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformListPage/TransformListPage.module.css
@@ -0,0 +1,3 @@
+.rowDisabled {
+ pointer-events: all;
+}
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformListPage/TransformListPage.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformListPage/TransformListPage.tsx
index 07cecfbab27..b1c45f3e6af 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformListPage/TransformListPage.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformListPage/TransformListPage.tsx
@@ -1,5 +1,12 @@
import type { Row } from "@tanstack/react-table";
-import { useCallback, useEffect, useMemo, useRef, useState } from "react";
+import {
+ type ComponentProps,
+ useCallback,
+ useEffect,
+ useMemo,
+ useRef,
+ useState,
+} from "react";
import type { WithRouterProps } from "react-router";
import { t } from "ttag";
@@ -36,9 +43,11 @@ import { PaneHeader } from "metabase-enterprise/data-studio/common/components/Pa
import { getIsRemoteSyncReadOnly } from "metabase-enterprise/remote_sync/selectors";
import { CreateTransformMenu } from "metabase-enterprise/transforms/components/CreateTransformMenu";
import { ListEmptyState } from "metabase-enterprise/transforms/components/ListEmptyState";
+import { useTransformPermissions } from "metabase-enterprise/transforms/hooks/use-transform-permissions";
import { SHARED_LIB_IMPORT_PATH } from "metabase-enterprise/transforms-python/constants";
import { CollectionRowMenu } from "./CollectionRowMenu";
+import S from "./TransformListPage.module.css";
import { type TreeNode, getCollectionNodeId, isCollectionNode } from "./types";
import { buildTreeData, getDefaultExpandedIds } from "./utils";
@@ -58,6 +67,10 @@ const countTransforms = (node: TreeNode): number => {
}, 0);
};
+const isRowDisabled = (row: Row<TreeNode>) => {
+ return row.original.source_readable === false;
+};
+
const NODE_ICON_COLORS: Record<TreeNode["nodeType"], ColorName> = {
folder: "text-secondary",
transform: "brand",
@@ -81,6 +94,8 @@ const globalFilterFn = (
};
export const TransformListPage = ({ location }: WithRouterProps) => {
+ const { transformsDatabases = [], isLoadingDatabases } =
+ useTransformPermissions();
const isRemoteSyncReadOnly = useSelector(getIsRemoteSyncReadOnly);
const targetCollectionId =
Urls.extractEntityId(location.query?.collectionId) ?? null;
@@ -108,7 +123,8 @@ export const TransformListPage = ({ location }: WithRouterProps) => {
isLoading: isLoadingTransforms,
} = useListTransformsQuery({});
- const isLoading = isLoadingCollections || isLoadingTransforms;
+ const isLoading =
+ isLoadingCollections || isLoadingTransforms || isLoadingDatabases;
const error = collectionsError ?? transformsError;
const treeData = useMemo(() => {
@@ -120,18 +136,29 @@ export const TransformListPage = ({ location }: WithRouterProps) => {
nodeType: "library",
icon: "snippet",
url: Urls.transformPythonLibrary({ path: SHARED_LIB_IMPORT_PATH }),
+ source_readable: transformsDatabases.length > 0,
});
}
return data;
- }, [collections, transforms]);
+ }, [collections, transforms, transformsDatabases]);
const defaultExpanded = useMemo(
() => getDefaultExpandedIds(targetCollectionId, targetCollection),
[targetCollectionId, targetCollection],
);
- const columnDefs = useMemo<TreeTableColumnDef<TreeNode>[]>(
- () => [
+ const columnDefs = useMemo<TreeTableColumnDef<TreeNode>[]>(() => {
+ type EllipsifiedProps = ComponentProps<
+ typeof EntityNameCell
+ >["ellipsifiedProps"];
+ const unreadableTransformEllipsifiedProps: EllipsifiedProps = {
+ alwaysShowTooltip: true,
+ tooltipProps: {
+ openDelay: 300,
+ label: t`Sorry, you don’t have permission to see that.`,
+ },
+ };
+ return [
{
id: "name",
accessorKey: "name",
@@ -145,6 +172,11 @@ export const TransformListPage = ({ location }: WithRouterProps) => {
icon={row.original.icon}
iconColor={getNodeIconColor(row.original)}
name={row.original.name}
+ ellipsifiedProps={
+ isRowDisabled(row)
+ ? unreadableTransformEllipsifiedProps
+ : undefined
+ }
/>
),
},
@@ -219,11 +251,13 @@ export const TransformListPage = ({ location }: WithRouterProps) => {
/>
) : null,
},
- ],
- [],
- );
+ ];
+ }, []);
const getRowHref = useCallback((row: Row<TreeNode>) => {
+ if (isRowDisabled(row)) {
+ return null;
+ }
if (row.original.nodeType === "transform" && row.original.transformId) {
return Urls.transform(row.original.transformId);
}
@@ -293,7 +327,9 @@ export const TransformListPage = ({ location }: WithRouterProps) => {
value={searchQuery}
onChange={(e) => setSearchQuery(e.target.value)}
/>
- {!isRemoteSyncReadOnly && <CreateTransformMenu />}
+ {!isRemoteSyncReadOnly && transformsDatabases.length > 0 && (
+ <CreateTransformMenu />
+ )}
</Flex>
<Card withBorder p={0}>
@@ -306,7 +342,9 @@ export const TransformListPage = ({ location }: WithRouterProps) => {
emptyMessage ? <ListEmptyState label={emptyMessage} /> : null
}
onRowClick={handleRowClick}
+ isRowDisabled={isRowDisabled}
getRowHref={getRowHref}
+ classNames={{ rowDisabled: S.rowDisabled }}
/>
)}
</Card>
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformListPage/types.ts b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformListPage/types.ts
index dc9199dfe5f..1c9851f4496 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformListPage/types.ts
+++ b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformListPage/types.ts
@@ -16,6 +16,7 @@ export type TreeNode = {
transformId?: number;
collectionId?: number;
url?: string;
+ source_readable?: boolean;
};
export function isCollectionNode(
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformListPage/utils.ts b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformListPage/utils.ts
index 233bc7f3d59..a9959898781 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformListPage/utils.ts
+++ b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformListPage/utils.ts
@@ -51,6 +51,7 @@ export function buildTreeData(
owner: transform.owner,
owner_email: transform.owner_email,
transformId: transform.id,
+ source_readable: transform.source_readable,
};
}
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformQueryPage/TransformPaneHeaderActions.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformQueryPage/TransformPaneHeaderActions.tsx
index 38b8101231f..34dfb3534d2 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformQueryPage/TransformPaneHeaderActions.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformQueryPage/TransformPaneHeaderActions.tsx
@@ -16,6 +16,7 @@ type Props = {
isDirty: boolean;
isEditMode: boolean;
isSaving: boolean;
+ readOnly?: boolean;
source: DraftTransformSource;
transformId: TransformId;
};
@@ -28,6 +29,7 @@ export const TransformPaneHeaderActions = (props: Props) => {
handleCancel,
isSaving,
isEditMode,
+ readOnly,
transformId,
} = props;
const metadata = useSelector(getMetadata);
@@ -51,7 +53,13 @@ export const TransformPaneHeaderActions = (props: Props) => {
}, [source, metadata]);
const isPythonTransform = source.type === "python";
- if (!isPythonTransform && !isNative && !isEditMode && !isRemoteSyncReadOnly) {
+ if (
+ !readOnly &&
+ !isPythonTransform &&
+ !isNative &&
+ !isEditMode &&
+ !isRemoteSyncReadOnly
+ ) {
return <EditDefinitionButton transformId={transformId} />;
}
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformQueryPage/TransformQueryPage.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformQueryPage/TransformQueryPage.tsx
index 5aabdac3444..2b1e41561d7 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformQueryPage/TransformQueryPage.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformQueryPage/TransformQueryPage.tsx
@@ -4,7 +4,8 @@ import { push } from "react-router-redux";
import { useLatest } from "react-use";
import { t } from "ttag";
-import { skipToken, useListDatabasesQuery } from "metabase/api";
+import { skipToken } from "metabase/api";
+import { EmptyState } from "metabase/common/components/EmptyState/EmptyState";
import { LeaveRouteConfirmModal } from "metabase/common/components/LeaveConfirmModal";
import { LoadingAndErrorWrapper } from "metabase/common/components/LoadingAndErrorWrapper";
import { useDispatch, useSelector } from "metabase/lib/redux";
@@ -15,13 +16,14 @@ import {
PLUGIN_TRANSFORMS_PYTHON,
} from "metabase/plugins";
import { getInitialUiState } from "metabase/querying/editor/components/QueryEditor";
-import { Box } from "metabase/ui";
+import { Box, Center, Icon } from "metabase/ui";
import {
useGetTransformQuery,
useUpdateTransformMutation,
} from "metabase-enterprise/api";
import { PageContainer } from "metabase-enterprise/data-studio/common/components/PageContainer";
import { getIsRemoteSyncReadOnly } from "metabase-enterprise/remote_sync/selectors";
+import { useTransformPermissions } from "metabase-enterprise/transforms/hooks/use-transform-permissions";
import type { Database, Transform } from "metabase-types/api";
import { useQueryComplexityChecks } from "../../components/QueryComplexityWarning";
@@ -49,11 +51,8 @@ export function TransformQueryPage({ params, route }: TransformQueryPageProps) {
isLoading: isLoadingTransform,
error: transformError,
} = useGetTransformQuery(transformId ?? skipToken);
- const {
- data: databases,
- isLoading: isLoadingDatabases,
- error: databasesError,
- } = useListDatabasesQuery({ include_analytics: true });
+ const { readOnly, transformsDatabases, isLoadingDatabases, databasesError } =
+ useTransformPermissions({ transform });
const isLoading = isLoadingTransform || isLoadingDatabases;
const error = transformError || databasesError;
@@ -61,15 +60,16 @@ export function TransformQueryPage({ params, route }: TransformQueryPageProps) {
return <LoadingAndErrorWrapper loading={isLoading} error={error} />;
}
- if (transform == null || databases == null) {
+ if (transform == null || transformsDatabases == null) {
return <LoadingAndErrorWrapper error={t`Transform not found.`} />;
}
return (
<TransformQueryPageBody
transform={transform}
- databases={databases.data}
+ databases={transformsDatabases}
route={route}
+ readOnly={readOnly}
/>
);
}
@@ -78,12 +78,14 @@ type TransformQueryPageBodyProps = {
transform: Transform;
databases: Database[];
route: RouteProps;
+ readOnly?: boolean;
};
function TransformQueryPageBody({
transform,
databases,
route,
+ readOnly,
}: TransformQueryPageBodyProps) {
const {
source,
@@ -103,7 +105,8 @@ function TransformQueryPageBody({
const [updateTransform, { isLoading: isSaving }] =
useUpdateTransformMutation();
const { sendSuccessToast, sendErrorToast } = useMetadataToasts();
- const isEditMode = !!route.path?.includes("/edit");
+ const isEditMode = !readOnly && !!route.path?.includes("/edit");
+
useRegisterMetabotTransformContext(transform, source);
const { confirmIfQueryIsComplex, modal } = useQueryComplexityChecks();
@@ -186,10 +189,12 @@ function TransformQueryPageBody({
handleCancel={handleCancel}
transformId={transform.id}
isEditMode={isEditMode}
+ readOnly={readOnly}
/>
}
hasMenu={!isEditMode && !isDirty}
isEditMode={isEditMode}
+ readOnly={readOnly}
/>
<Box
w="100%"
@@ -201,12 +206,20 @@ function TransformQueryPageBody({
overflow: "hidden",
}}
>
- {source.type === "python" ? (
+ {!transform.source_readable ? (
+ <Center h="100%">
+ <EmptyState
+ title={t`Sorry, you don't have permission to view this transform.`}
+ illustrationElement={<Icon name="key" size={100} />}
+ />
+ </Center>
+ ) : source.type === "python" ? (
<PLUGIN_TRANSFORMS_PYTHON.TransformEditor
source={source}
proposedSource={
proposedSource?.type === "python" ? proposedSource : undefined
}
+ readOnly={readOnly}
isEditMode={isEditMode}
transformId={transform.id}
onChangeSource={setSourceAndRejectProposed}
@@ -220,6 +233,7 @@ function TransformQueryPageBody({
proposedSource?.type === "query" ? proposedSource : undefined
}
uiState={uiState}
+ readOnly={readOnly}
isEditMode={isEditMode}
databases={databases}
onChangeSource={setSourceAndRejectProposed}
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformRunPage/RunSection/RunSection.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformRunPage/RunSection/RunSection.tsx
index adcb340ab2d..0e8acc96f20 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformRunPage/RunSection/RunSection.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformRunPage/RunSection/RunSection.tsx
@@ -27,9 +27,10 @@ import { LogOutput } from "./LogOutput";
type RunSectionProps = {
transform: Transform;
+ readOnly?: boolean;
};
-export function RunSection({ transform }: RunSectionProps) {
+export function RunSection({ transform, readOnly }: RunSectionProps) {
const isRemoteSyncReadOnly = useSelector(getIsRemoteSyncReadOnly);
return (
@@ -40,7 +41,7 @@ export function RunSection({ transform }: RunSectionProps) {
<Stack>
<Group p="lg" justify="space-between">
<RunStatusSection transform={transform} />
- <RunButtonSection transform={transform} />
+ <RunButtonSection transform={transform} readOnly={readOnly} />
</Group>
<RunOutputSection transform={transform} />
</Stack>
@@ -50,7 +51,10 @@ export function RunSection({ transform }: RunSectionProps) {
<Box fw="bold">{t`Run it on a schedule with tags`}</Box>
<Box>{t`Jobs will run all transforms with their tags.`}</Box>
</Stack>
- <TagSection transform={transform} readOnly={isRemoteSyncReadOnly} />
+ <TagSection
+ transform={transform}
+ readOnly={readOnly || isRemoteSyncReadOnly}
+ />
</Group>
</TitleSection>
);
@@ -95,9 +99,10 @@ function RunStatusSection({ transform }: RunStatusSectionProps) {
type RunButtonSectionProps = {
transform: Transform;
+ readOnly?: boolean;
};
-function RunButtonSection({ transform }: RunButtonSectionProps) {
+function RunButtonSection({ transform, readOnly }: RunButtonSectionProps) {
const [runTransform] = useRunTransformMutation();
const [cancelTransform] = useCancelCurrentTransformRunMutation();
const { sendErrorToast } = useMetadataToasts();
@@ -129,6 +134,7 @@ function RunButtonSection({ transform }: RunButtonSectionProps) {
allowCancellation
onRun={handleRun}
onCancel={openConfirmModal}
+ isDisabled={readOnly}
/>
<ConfirmModal
title={t`Cancel this run?`}
@@ -161,11 +167,11 @@ function RunOutputSection({ transform }: RunOutputSectionProps) {
}
type TagSectionProps = {
- readOnly: boolean;
transform: Transform;
+ readOnly?: boolean;
};
-function TagSection({ readOnly, transform }: TagSectionProps) {
+function TagSection({ transform, readOnly }: TagSectionProps) {
const [updateTransform] = useUpdateTransformMutation();
const { sendErrorToast, sendSuccessToast, sendUndoToast } =
useMetadataToasts();
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformRunPage/TransformRunPage.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformRunPage/TransformRunPage.tsx
index 21a04c891f8..ae3dbcf045b 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformRunPage/TransformRunPage.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformRunPage/TransformRunPage.tsx
@@ -6,6 +6,7 @@ import * as Urls from "metabase/lib/urls";
import { Center } from "metabase/ui";
import { useGetTransformQuery } from "metabase-enterprise/api";
import { PageContainer } from "metabase-enterprise/data-studio/common/components/PageContainer";
+import { useTransformPermissions } from "metabase-enterprise/transforms/hooks/use-transform-permissions";
import type { Transform } from "metabase-types/api";
import { TransformHeader } from "../../components/TransformHeader";
@@ -31,11 +32,15 @@ export function TransformRunPage({ params }: TransformRunPageProps) {
const transformId = Urls.extractEntityId(params.transformId);
const {
data: transform,
- isLoading,
- error,
+ isLoading: isLoadingTransform,
+ error: transformError,
} = useGetTransformQuery(transformId ?? skipToken, {
pollingInterval: isPolling ? POLLING_INTERVAL : undefined,
});
+ const { readOnly, isLoadingDatabases, databasesError } =
+ useTransformPermissions({ transform });
+ const isLoading = isLoadingTransform || isLoadingDatabases;
+ const error = transformError || databasesError;
if (isPolling !== isPollingNeeded(transform)) {
setIsPolling(isPollingNeeded(transform));
@@ -51,8 +56,8 @@ export function TransformRunPage({ params }: TransformRunPageProps) {
return (
<PageContainer data-testid="transforms-run-content">
- <TransformHeader transform={transform} />
- <RunSection transform={transform} />
+ <TransformHeader transform={transform} readOnly={readOnly} />
+ <RunSection transform={transform} readOnly={readOnly} />
</PageContainer>
);
}
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformSettingsPage/TransformSettingsPage.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformSettingsPage/TransformSettingsPage.tsx
index a225feba522..6d1090fbaea 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformSettingsPage/TransformSettingsPage.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformSettingsPage/TransformSettingsPage.tsx
@@ -6,6 +6,7 @@ import * as Urls from "metabase/lib/urls";
import { Center } from "metabase/ui";
import { useGetTransformQuery } from "metabase-enterprise/api";
import { PageContainer } from "metabase-enterprise/data-studio/common/components/PageContainer";
+import { useTransformPermissions } from "metabase-enterprise/transforms/hooks/use-transform-permissions";
import type { Transform } from "metabase-types/api";
import { TransformHeader } from "../../components/TransformHeader";
@@ -31,11 +32,15 @@ export const TransformSettingsPage = ({ params }: TransformTargetPageProps) => {
const transformId = Urls.extractEntityId(params.transformId);
const {
data: transform,
- isLoading,
- error,
+ isLoading: isLoadingTransform,
+ error: transformError,
} = useGetTransformQuery(transformId ?? skipToken, {
pollingInterval: isPolling ? POLLING_INTERVAL : undefined,
});
+ const { readOnly, isLoadingDatabases, databasesError } =
+ useTransformPermissions({ transform });
+ const isLoading = isLoadingTransform || isLoadingDatabases;
+ const error = transformError || databasesError;
if (isPolling !== isPollingNeeded(transform)) {
setIsPolling(isPollingNeeded(transform));
@@ -51,8 +56,8 @@ export const TransformSettingsPage = ({ params }: TransformTargetPageProps) => {
return (
<PageContainer data-testid="transforms-target-content">
- <TransformHeader transform={transform} />
- <TransformSettingsSection transform={transform} />
+ <TransformHeader transform={transform} readOnly={readOnly} />
+ <TransformSettingsSection transform={transform} readOnly={readOnly} />
</PageContainer>
);
};
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformSettingsPage/TransformSettingsSection/TransformSettingsSection.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformSettingsPage/TransformSettingsSection/TransformSettingsSection.tsx
index da3d515b359..b9de6203857 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformSettingsPage/TransformSettingsSection/TransformSettingsSection.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformSettingsPage/TransformSettingsSection/TransformSettingsSection.tsx
@@ -24,6 +24,7 @@ import {
} from "metabase/ui";
import { useUpdateTransformMutation } from "metabase-enterprise/api";
import { getIsRemoteSyncReadOnly } from "metabase-enterprise/remote_sync/selectors";
+import { TransformOwnerAvatar } from "metabase-enterprise/transforms/components/TransformOwnerAvatar/TransformOwnerAvatar";
import type { Transform, UserId } from "metabase-types/api";
import { TitleSection } from "../../../components/TitleSection";
@@ -34,16 +35,18 @@ import { UpdateTargetModal } from "./UpdateTargetModal";
type TransformSettingsSectionProps = {
transform: Transform;
+ readOnly?: boolean;
};
export const TransformSettingsSection = ({
transform,
+ readOnly,
}: TransformSettingsSectionProps) => {
const isRemoteSyncReadOnly = useSelector(getIsRemoteSyncReadOnly);
return (
<Stack gap="2.5rem">
- <OwnerSection transform={transform} />
+ <OwnerSection transform={transform} readOnly={readOnly} />
<TitleSection
label={t`Transform target`}
description={t`Change what this transform generates and where.`}
@@ -51,13 +54,19 @@ export const TransformSettingsSection = ({
<Group p="lg">
<TargetInfo transform={transform} />
</Group>
- <Divider />
- <Group p="lg">
- {!isRemoteSyncReadOnly && <EditTargetButton transform={transform} />}
- <EditMetadataButton transform={transform} />
- </Group>
+ {!readOnly && (
+ <>
+ <Divider />
+ <Group p="lg">
+ {!isRemoteSyncReadOnly && (
+ <EditTargetButton transform={transform} />
+ )}
+ <EditMetadataButton transform={transform} />
+ </Group>
+ </>
+ )}
</TitleSection>
- <UpdateIncrementalSettings transform={transform} />
+ <UpdateIncrementalSettings transform={transform} readOnly={readOnly} />
</Stack>
);
};
@@ -241,9 +250,10 @@ function EditMetadataButton({ transform }: EditMetadataButtonProps) {
type OwnerSectionProps = {
transform: Transform;
+ readOnly?: boolean;
};
-function OwnerSection({ transform }: OwnerSectionProps) {
+function OwnerSection({ transform, readOnly }: OwnerSectionProps) {
const [updateTransform] = useUpdateTransformMutation();
const { sendErrorToast, sendSuccessToast } = useMetadataToasts();
@@ -279,18 +289,25 @@ function OwnerSection({ transform }: OwnerSectionProps) {
description={t`Specify who is responsible for this transform.`}
>
<Group p="lg">
- <UserInput
- email={transform.owner_email ?? null}
- label={t`Owner`}
- userId={
- !transform.owner_email && !transform.owner_user_id
- ? "unknown"
- : (transform.owner_user_id ?? null)
- }
- unknownUserLabel={t`No owner`}
- onEmailChange={handleOwnerEmailChange}
- onUserIdChange={handleOwnerUserIdChange}
- />
+ {readOnly ? (
+ <>
+ <Text fw="bold">{t`Owner`}</Text>
+ <TransformOwnerAvatar transform={transform} />
+ </>
+ ) : (
+ <UserInput
+ email={transform.owner_email ?? null}
+ label={t`Owner`}
+ userId={
+ !transform.owner_email && !transform.owner_user_id
+ ? "unknown"
+ : (transform.owner_user_id ?? null)
+ }
+ unknownUserLabel={t`No owner`}
+ onEmailChange={handleOwnerEmailChange}
+ onUserIdChange={handleOwnerUserIdChange}
+ />
+ )}
</Group>
</TitleSection>
);
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformSettingsPage/TransformSettingsSection/UpdateIncrementalSettings.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformSettingsPage/TransformSettingsSection/UpdateIncrementalSettings.tsx
index b4d36394c9c..68753a635af 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformSettingsPage/TransformSettingsSection/UpdateIncrementalSettings.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/transforms/pages/TransformSettingsPage/TransformSettingsSection/UpdateIncrementalSettings.tsx
@@ -14,10 +14,12 @@ import type { Transform } from "metabase-types/api";
type UpdateIncrementalSettingsProps = {
transform: Transform;
+ readOnly?: boolean;
};
const IncrementalTransformSettingsWrapper = ({
transform,
+ readOnly,
}: UpdateIncrementalSettingsProps) => {
const { values, setFieldValue } =
useFormikContext<IncrementalSettingsFormValues>();
@@ -40,6 +42,7 @@ const IncrementalTransformSettingsWrapper = ({
incremental={values.incremental}
onIncrementalChange={handleIncrementalChange}
variant="standalone"
+ readOnly={readOnly}
/>
{modal}
</>
@@ -48,6 +51,7 @@ const IncrementalTransformSettingsWrapper = ({
export const UpdateIncrementalSettings = ({
transform,
+ readOnly,
}: UpdateIncrementalSettingsProps) => {
const { sendSuccessToast, sendErrorToast } = useMetadataToasts();
@@ -73,7 +77,10 @@ export const UpdateIncrementalSettings = ({
onSuccess={showSuccessToast}
onError={showErrorToast}
/>
- <IncrementalTransformSettingsWrapper transform={transform} />
+ <IncrementalTransformSettingsWrapper
+ transform={transform}
+ readOnly={readOnly}
+ />
</Form>
</FormProvider>
);
diff --git a/frontend/src/metabase-types/api/database.ts b/frontend/src/metabase-types/api/database.ts
index 3415abdb0b1..9daddfd5e4b 100644
--- a/frontend/src/metabase-types/api/database.ts
+++ b/frontend/src/metabase-types/api/database.ts
@@ -66,6 +66,7 @@ export interface Database extends DatabaseData {
creator_id?: number;
timezone?: string;
native_permissions: "write" | "none";
+ transforms_permissions?: "write" | "none";
initial_sync_status: InitialSyncStatus;
caveats?: string;
points_of_interest?: string;
diff --git a/frontend/src/metabase-types/api/mocks/transform.ts b/frontend/src/metabase-types/api/mocks/transform.ts
index 671bb01d334..80462c67c0a 100644
--- a/frontend/src/metabase-types/api/mocks/transform.ts
+++ b/frontend/src/metabase-types/api/mocks/transform.ts
@@ -87,6 +87,7 @@ export function createMockTransform(opts?: Partial<Transform>): Transform {
collection_id: null,
created_at: "2000-01-01T00:00:00Z",
updated_at: "2000-01-01T00:00:00Z",
+ source_readable: true,
...opts,
};
}
@@ -113,6 +114,7 @@ export function createMockTransformTag(
name: "Tag",
created_at: "2000-01-01T00:00:00Z",
updated_at: "2000-01-01T00:00:00Z",
+ can_run: true,
...opts,
};
}
diff --git a/frontend/src/metabase-types/api/permissions.ts b/frontend/src/metabase-types/api/permissions.ts
index a2282cfa6aa..c774700bd81 100644
--- a/frontend/src/metabase-types/api/permissions.ts
+++ b/frontend/src/metabase-types/api/permissions.ts
@@ -51,12 +51,17 @@ export type DownloadTablePermission =
| DownloadPermission
| { [key: TableId]: DownloadPermission };
+export type TransformsPermission =
+ | DataPermissionValue.NO
+ | DataPermissionValue.YES;
+
export type DatabasePermissions = {
[DataPermission.VIEW_DATA]: SchemasPermissions;
[DataPermission.CREATE_QUERIES]?: NativePermissions;
[DataPermission.DATA_MODEL]?: DataModelPermissions;
[DataPermission.DOWNLOAD]?: DownloadAccessPermission;
[DataPermission.DETAILS]?: DetailsPermissions;
+ [DataPermission.TRANSFORMS]?: TransformsPermission;
};
export type DataModelPermissions = {
diff --git a/frontend/src/metabase-types/api/transform.ts b/frontend/src/metabase-types/api/transform.ts
index c826eba1193..98003368db1 100644
--- a/frontend/src/metabase-types/api/transform.ts
+++ b/frontend/src/metabase-types/api/transform.ts
@@ -25,6 +25,7 @@ export type Transform = {
collection_id: number | null;
created_at: string;
updated_at: string;
+ source_readable: boolean;
// creator fields
creator_id?: UserId;
@@ -138,6 +139,7 @@ export type TransformTag = {
name: string;
created_at: string;
updated_at: string;
+ can_run: boolean;
};
export type TransformJob = {
diff --git a/frontend/src/metabase-types/api/user.ts b/frontend/src/metabase-types/api/user.ts
index 6e5f06663d0..ad262a55a9c 100644
--- a/frontend/src/metabase-types/api/user.ts
+++ b/frontend/src/metabase-types/api/user.ts
@@ -57,6 +57,7 @@ export interface UserPermissions {
can_access_setting?: boolean;
can_access_subscription?: boolean;
can_access_data_studio?: boolean;
+ can_access_transforms?: boolean;
}
export interface User extends BaseUser {
diff --git a/frontend/src/metabase/admin/permissions/components/DataPermissionsHelp/DataPermissionsHelp.tsx b/frontend/src/metabase/admin/permissions/components/DataPermissionsHelp/DataPermissionsHelp.tsx
index 59eb2565bac..22c66ee4237 100644
--- a/frontend/src/metabase/admin/permissions/components/DataPermissionsHelp/DataPermissionsHelp.tsx
+++ b/frontend/src/metabase/admin/permissions/components/DataPermissionsHelp/DataPermissionsHelp.tsx
@@ -5,6 +5,7 @@ import { DataPermissionValue } from "metabase/admin/permissions/types";
import { ExternalLink } from "metabase/common/components/ExternalLink";
import { useDocsUrl } from "metabase/common/hooks";
import { useSelector } from "metabase/lib/redux";
+import { PLUGIN_TRANSFORMS } from "metabase/plugins";
import { getSetting } from "metabase/selectors/settings";
import {
Accordion,
@@ -197,8 +198,15 @@ export const DataPermissionsHelp = () => {
<Text>
{jt`${(
<strong key="permission">{t`Manage Database (Pro):`}</strong>
- )} The group can edit database settings for a given database in the “Database” tab of the Admin settings.`}
+ )} The group can edit database settings for a given database in the "Database" tab of the Admin settings.`}
</Text>
+ {PLUGIN_TRANSFORMS.isEnabled && (
+ <Text>
+ {jt`${(
+ <strong key="permission">{t`Transforms (Pro):`}</strong>
+ )} The group can create, edit, and run Transforms for a given database.`}
+ </Text>
+ )}
</Stack>
</Accordion.Panel>
</Accordion.Item>
diff --git a/frontend/src/metabase/admin/permissions/components/PermissionsTable/PermissionsTable.jsx b/frontend/src/metabase/admin/permissions/components/PermissionsTable/PermissionsTable.jsx
index ec172b0948c..4b21a2dc4da 100644
--- a/frontend/src/metabase/admin/permissions/components/PermissionsTable/PermissionsTable.jsx
+++ b/frontend/src/metabase/admin/permissions/components/PermissionsTable/PermissionsTable.jsx
@@ -87,7 +87,11 @@ export function PermissionsTable({
<ColumnName>
{name}{" "}
{hint && (
- <Tooltip position="right" label={hint}>
+ <Tooltip
+ label={hint}
+ closeDelay={100}
+ classNames={{ tooltip: CS.pointerEventsAuto }}
+ >
<HintIcon />
</Tooltip>
)}
diff --git a/frontend/src/metabase/admin/permissions/permissions.js b/frontend/src/metabase/admin/permissions/permissions.js
index 2fa637b27da..5ce93257329 100644
--- a/frontend/src/metabase/admin/permissions/permissions.js
+++ b/frontend/src/metabase/admin/permissions/permissions.js
@@ -6,6 +6,7 @@ import { isBoolean } from "underscore";
import {
inferAndUpdateEntityPermissions,
restrictCreateQueriesPermissionsIfNeeded,
+ revokeTransformsPermissionIfNeeded,
updateFieldsPermission,
updatePermission,
updateSchemasPermission,
@@ -389,6 +390,17 @@ const dataPermissions = handleActions(
);
}
+ if (permissionInfo.type === DataPermissionType.TRANSFORMS) {
+ return updatePermission(
+ state,
+ groupId,
+ entityId.databaseId,
+ DataPermission.TRANSFORMS,
+ [],
+ value,
+ );
+ }
+
if (
permissionInfo.type === DataPermissionType.NATIVE &&
PLUGIN_DATA_PERMISSIONS.upgradeViewPermissionsIfNeeded
@@ -412,6 +424,14 @@ const dataPermissions = handleActions(
database,
);
+ state = revokeTransformsPermissionIfNeeded(
+ state,
+ groupId,
+ entityId,
+ permissionInfo.permission,
+ value,
+ );
+
if (entityId.tableId != null) {
const updatedPermissions = updateFieldsPermission(
state,
diff --git a/frontend/src/metabase/admin/permissions/selectors/data-permissions/permission-editor.tsx b/frontend/src/metabase/admin/permissions/selectors/data-permissions/permission-editor.tsx
index 54fb1bc21aa..57ce0efbc7a 100644
--- a/frontend/src/metabase/admin/permissions/selectors/data-permissions/permission-editor.tsx
+++ b/frontend/src/metabase/admin/permissions/selectors/data-permissions/permission-editor.tsx
@@ -312,6 +312,7 @@ export const getDatabasesPermissionEditor = createSelector(
...(permissionSubject
? PLUGIN_FEATURE_LEVEL_PERMISSIONS.getDataColumns(
permissionSubject,
+ groupType,
isExternal,
)
: []),
diff --git a/frontend/src/metabase/admin/permissions/types.ts b/frontend/src/metabase/admin/permissions/types.ts
index db3c92fbf3d..08eeab0cbdd 100644
--- a/frontend/src/metabase/admin/permissions/types.ts
+++ b/frontend/src/metabase/admin/permissions/types.ts
@@ -47,6 +47,7 @@ export enum DataPermission {
DOWNLOAD = "download",
DATA_MODEL = "data-model",
DETAILS = "details",
+ TRANSFORMS = "transforms",
}
export enum DataPermissionType {
@@ -55,6 +56,7 @@ export enum DataPermissionType {
DETAILS = "details",
DOWNLOAD = "download",
DATA_MODEL = "data-model",
+ TRANSFORMS = "transforms",
}
export enum DataPermissionValue {
diff --git a/frontend/src/metabase/admin/permissions/utils/graph/data-permissions/get.ts b/frontend/src/metabase/admin/permissions/utils/graph/data-permissions/get.ts
index 85d803ec700..ccd145e72de 100644
--- a/frontend/src/metabase/admin/permissions/utils/graph/data-permissions/get.ts
+++ b/frontend/src/metabase/admin/permissions/utils/graph/data-permissions/get.ts
@@ -18,6 +18,7 @@ const flatPermissions = new Set([
DataPermission.DETAILS,
DataPermission.VIEW_DATA,
DataPermission.CREATE_QUERIES,
+ DataPermission.TRANSFORMS,
]);
// util to ease migration of perms attributes into a flatter structure
@@ -42,6 +43,7 @@ const omittedDefaultValues: Record<DataPermission, DataPermissionValue> = {
[DataPermission.DOWNLOAD]: DataPermissionValue.NONE,
[DataPermission.DATA_MODEL]: DataPermissionValue.NONE,
[DataPermission.DETAILS]: DataPermissionValue.NO,
+ [DataPermission.TRANSFORMS]: DataPermissionValue.NO,
};
function getOmittedPermissionValue(
diff --git a/frontend/src/metabase/admin/permissions/utils/graph/data-permissions/update.ts b/frontend/src/metabase/admin/permissions/utils/graph/data-permissions/update.ts
index a8ac5d0ded7..9f93170ac66 100644
--- a/frontend/src/metabase/admin/permissions/utils/graph/data-permissions/update.ts
+++ b/frontend/src/metabase/admin/permissions/utils/graph/data-permissions/update.ts
@@ -267,6 +267,70 @@ export function restrictCreateQueriesPermissionsIfNeeded(
return permissions;
}
+const hasFullViewDataAccess = (viewDataValue: DataPermissionValue): boolean => {
+ return viewDataValue === DataPermissionValue.UNRESTRICTED;
+};
+
+const hasFullCreateQueriesAccess = (
+ createQueriesValue: DataPermissionValue,
+): boolean => {
+ return createQueriesValue === DataPermissionValue.QUERY_BUILDER_AND_NATIVE;
+};
+
+export function revokeTransformsPermissionIfNeeded(
+ permissions: GroupsPermissions,
+ groupId: number,
+ entityId: EntityId,
+ permission: DataPermission,
+ value: DataPermissionValue,
+): GroupsPermissions {
+ if (
+ permission !== DataPermission.VIEW_DATA &&
+ permission !== DataPermission.CREATE_QUERIES
+ ) {
+ return permissions;
+ }
+
+ const { databaseId } = entityId;
+
+ const viewDataValue =
+ permission === DataPermission.VIEW_DATA
+ ? value
+ : getSchemasPermission(
+ permissions,
+ groupId,
+ { databaseId },
+ DataPermission.VIEW_DATA,
+ );
+
+ const createQueriesValue =
+ permission === DataPermission.CREATE_QUERIES
+ ? value
+ : getSchemasPermission(
+ permissions,
+ groupId,
+ { databaseId },
+ DataPermission.CREATE_QUERIES,
+ );
+
+ const hasRequiredPermissions =
+ hasFullViewDataAccess(viewDataValue) &&
+ hasFullCreateQueriesAccess(createQueriesValue);
+
+ if (!hasRequiredPermissions) {
+ return updatePermission(
+ permissions,
+ groupId,
+ databaseId,
+ DataPermission.TRANSFORMS,
+ [],
+ DataPermissionValue.NO,
+ );
+ }
+
+ return permissions;
+}
+
function inferEntityPermissionValueFromChildTables(
permissions: GroupsPermissions,
groupId: number,
diff --git a/frontend/src/metabase/plugins/oss/permissions.ts b/frontend/src/metabase/plugins/oss/permissions.ts
index d62be147ece..49cbaf2c08b 100644
--- a/frontend/src/metabase/plugins/oss/permissions.ts
+++ b/frontend/src/metabase/plugins/oss/permissions.ts
@@ -144,8 +144,11 @@ const getDefaultFeatureLevelPermissions = () => ({
) => {
return [] as any;
},
- getDataColumns: (_subject: PermissionSubject, _isExternal?: boolean) =>
- [] as any,
+ getDataColumns: (
+ _subject: PermissionSubject,
+ _groupType?: SpecialGroupType,
+ _isExternal?: boolean,
+ ) => [] as any,
getDownloadWidgetMessageOverride: (_result: Dataset): string | null => null,
canDownloadResults: (_result: Dataset): boolean => true,
canAccessDataModel: (state: State): boolean => getUserIsAdmin(state),
diff --git a/frontend/src/metabase/plugins/oss/transforms.ts b/frontend/src/metabase/plugins/oss/transforms.ts
index 3869e8f648b..09d43bafa68 100644
--- a/frontend/src/metabase/plugins/oss/transforms.ts
+++ b/frontend/src/metabase/plugins/oss/transforms.ts
@@ -46,6 +46,7 @@ export type PythonTransformEditorProps = {
source: PythonTransformSourceDraft;
proposedSource?: PythonTransformSourceDraft;
isEditMode?: boolean;
+ readOnly?: boolean;
transformId?: TransformId;
onChangeSource: (source: PythonTransformSourceDraft) => void;
onAcceptProposed: () => void;
diff --git a/frontend/src/metabase/query_builder/components/DataSelector/DataSelector.jsx b/frontend/src/metabase/query_builder/components/DataSelector/DataSelector.jsx
index d2908eb5cd3..6a00a345996 100644
--- a/frontend/src/metabase/query_builder/components/DataSelector/DataSelector.jsx
+++ b/frontend/src/metabase/query_builder/components/DataSelector/DataSelector.jsx
@@ -1038,6 +1038,7 @@ export class UnconnectedDataSelector extends Component {
onDismiss={this.handleDismiss}
position="bottom-start"
opened={this.isPopoverOpen()}
+ disabled={this.props.readOnly}
>
<Popover.Target>
<Box
diff --git a/frontend/src/metabase/querying/editor/components/QueryEditor/NativeQueryPreviewSidebar/NativeQueryPreviewSidebar.tsx b/frontend/src/metabase/querying/editor/components/QueryEditor/NativeQueryPreviewSidebar/NativeQueryPreviewSidebar.tsx
index f2b2563c2bb..058088b81ef 100644
--- a/frontend/src/metabase/querying/editor/components/QueryEditor/NativeQueryPreviewSidebar/NativeQueryPreviewSidebar.tsx
+++ b/frontend/src/metabase/querying/editor/components/QueryEditor/NativeQueryPreviewSidebar/NativeQueryPreviewSidebar.tsx
@@ -14,6 +14,7 @@ type NativeQueryPreviewSidebarProps = {
convertToNativeTitle?: string;
convertToNativeButtonLabel?: string;
onConvertToNativeClick: (newQuestion: Question) => void;
+ readOnly?: boolean;
};
export function NativeQueryPreviewSidebar({
@@ -21,6 +22,7 @@ export function NativeQueryPreviewSidebar({
convertToNativeTitle,
convertToNativeButtonLabel,
onConvertToNativeClick,
+ readOnly,
}: NativeQueryPreviewSidebarProps) {
const { width: windowWidth } = useWindowSize();
const minSidebarWidth = 428;
@@ -42,6 +44,7 @@ export function NativeQueryPreviewSidebar({
title={convertToNativeTitle}
buttonTitle={convertToNativeButtonLabel}
onConvertClick={onConvertToNativeClick}
+ readOnly={readOnly}
/>
</ResizableBox>
);
diff --git a/frontend/src/metabase/querying/editor/components/QueryEditor/QueryEditor.tsx b/frontend/src/metabase/querying/editor/components/QueryEditor/QueryEditor.tsx
index 8c2d3405523..5013bb4cf46 100644
--- a/frontend/src/metabase/querying/editor/components/QueryEditor/QueryEditor.tsx
+++ b/frontend/src/metabase/querying/editor/components/QueryEditor/QueryEditor.tsx
@@ -167,6 +167,7 @@ export function QueryEditor({
convertToNativeTitle={uiOptions?.convertToNativeTitle}
convertToNativeButtonLabel={uiOptions?.convertToNativeButtonLabel}
onConvertToNativeClick={convertToNative}
+ readOnly={uiOptions?.readOnly}
/>
)}
</Flex>
diff --git a/frontend/src/metabase/querying/notebook/components/NotebookNativePreview/NotebookNativePreview.tsx b/frontend/src/metabase/querying/notebook/components/NotebookNativePreview/NotebookNativePreview.tsx
index c9653ccadd8..d15241f9e1b 100644
--- a/frontend/src/metabase/querying/notebook/components/NotebookNativePreview/NotebookNativePreview.tsx
+++ b/frontend/src/metabase/querying/notebook/components/NotebookNativePreview/NotebookNativePreview.tsx
@@ -34,6 +34,7 @@ type NotebookNativePreviewProps = {
title?: string;
buttonTitle?: string;
onConvertClick: (newQuestion: Question) => void;
+ readOnly?: boolean;
};
export const NotebookNativePreview = ({
@@ -41,6 +42,7 @@ export const NotebookNativePreview = ({
title,
buttonTitle,
onConvertClick,
+ readOnly,
}: NotebookNativePreviewProps) => {
const database = question.database();
const engine = database?.engine;
@@ -111,16 +113,18 @@ export const NotebookNativePreview = ({
)}
{showQuery && newQuery != null && <Editor query={newQuery} readOnly />}
</Flex>
- <Box ta="end" p="1.5rem">
- <Button
- variant="subtle"
- p={0}
- onClick={handleConvertClick}
- disabled={!showQuery}
- >
- {buttonTitle ?? BUTTON_TITLE[engineType]}
- </Button>
- </Box>
+ {!readOnly && (
+ <Box ta="end" p="1.5rem">
+ <Button
+ variant="subtle"
+ p={0}
+ onClick={handleConvertClick}
+ disabled={!showQuery}
+ >
+ {buttonTitle ?? BUTTON_TITLE[engineType]}
+ </Button>
+ </Box>
+ )}
</Box>
);
};
diff --git a/frontend/src/metabase/ui/components/data-display/TreeTable/EntityNameCell/EntityNameCell.tsx b/frontend/src/metabase/ui/components/data-display/TreeTable/EntityNameCell/EntityNameCell.tsx
index 1faa730802a..db8460faa24 100644
--- a/frontend/src/metabase/ui/components/data-display/TreeTable/EntityNameCell/EntityNameCell.tsx
+++ b/frontend/src/metabase/ui/components/data-display/TreeTable/EntityNameCell/EntityNameCell.tsx
@@ -1,4 +1,4 @@
-import { memo } from "react";
+import { type ComponentProps, memo } from "react";
import { Ellipsified } from "metabase/common/components/Ellipsified";
import CS from "metabase/css/core/index.css";
@@ -11,6 +11,7 @@ interface EntityNameCellProps {
name: string;
iconColor?: ColorName;
wrap?: boolean;
+ ellipsifiedProps?: ComponentProps<typeof Ellipsified>;
tooltipOpenDelay?: number;
"data-testid"?: string;
}
@@ -21,6 +22,7 @@ export const EntityNameCell = memo(function EntityNameCell({
iconColor = "brand",
wrap = false,
tooltipOpenDelay = 600,
+ ellipsifiedProps,
"data-testid": testId,
}: EntityNameCellProps) {
return (
@@ -35,6 +37,7 @@ export const EntityNameCell = memo(function EntityNameCell({
flex={1}
miw={0}
tooltipProps={{ openDelay: tooltipOpenDelay }}
+ {...ellipsifiedProps}
>
{name}
</Ellipsified>
diff --git a/frontend/src/metabase/ui/components/data-display/TreeTable/TreeTable.tsx b/frontend/src/metabase/ui/components/data-display/TreeTable/TreeTable.tsx
index 624ccb9b10b..2afd5859002 100644
--- a/frontend/src/metabase/ui/components/data-display/TreeTable/TreeTable.tsx
+++ b/frontend/src/metabase/ui/components/data-display/TreeTable/TreeTable.tsx
@@ -121,10 +121,12 @@ export function TreeTable<TData extends TreeNodeData>({
const handleRowClick = useCallback(
(row: Row<TData>, event: MouseEvent) => {
- setActiveRowId(row.id);
+ if (!isRowDisabled?.(row)) {
+ setActiveRowId(row.id);
+ }
onRowClick?.(row, event);
},
- [setActiveRowId, onRowClick],
+ [isRowDisabled, onRowClick, setActiveRowId],
);
const showEmptyState = rows.length === 0 && emptyState;
diff --git a/frontend/src/metabase/ui/components/data-display/TreeTable/TreeTableRow/TreeTableRow.module.css b/frontend/src/metabase/ui/components/data-display/TreeTable/TreeTableRow/TreeTableRow.module.css
index acb9d3ab3b0..dfba4c4d102 100644
--- a/frontend/src/metabase/ui/components/data-display/TreeTable/TreeTableRow/TreeTableRow.module.css
+++ b/frontend/src/metabase/ui/components/data-display/TreeTable/TreeTableRow/TreeTableRow.module.css
@@ -35,7 +35,7 @@
background-color: var(--mb-color-brand-light);
}
- &:focus {
+ &:focus:not(.disabled) {
outline: none;
background-color: var(--mb-color-brand-light);
}
diff --git a/lint-staged.config.cjs b/lint-staged.config.cjs
index fb1ad3cfe5d..d157eda51a7 100644
--- a/lint-staged.config.cjs
+++ b/lint-staged.config.cjs
@@ -11,7 +11,7 @@ module.exports = {
"prettier --write",
"node ./bin/verify-doc-links",
],
- "e2e/**/*.{js,jsx,ts,jsx}": [
+ "e2e/**/!(cypress_sample_instance_data).{js,jsx,ts,jsx}": [
"eslint --max-warnings 0 --fix",
"prettier --write",
],
diff --git a/resources/migrations/059_update_migrations.yaml b/resources/migrations/059_update_migrations.yaml
index 6471e7af8a0..e3b86329b8c 100644
--- a/resources/migrations/059_update_migrations.yaml
+++ b/resources/migrations/059_update_migrations.yaml
@@ -1,5 +1,62 @@
databaseChangeLog:
- objectQuotingStrategy: QUOTE_ALL_OBJECTS
+
+ - changeSet:
+ id: v59.2025-12-01T18:53:23
+ author: nvoxland
+ comment: Add source_database_id column to transform table
+ changes:
+ - addColumn:
+ tableName: transform
+ columns:
+ - column:
+ name: source_database_id
+ type: int
+ remarks: The database containing the source data for this transform
+
+ - changeSet:
+ id: v59.2025-12-01T18:53:24
+ author: nvoxland
+ comment: Add index for transform.source_database_id
+ changes:
+ - createIndex:
+ tableName: transform
+ indexName: idx_transform_source_database_id
+ columns:
+ - column:
+ name: source_database_id
+
+ - changeSet:
+ id: v59.2025-12-01T18:53:25
+ author: nvoxland
+ comment: Add foreign key on transform(source_database_id)
+ changes:
+ - addForeignKeyConstraint:
+ baseTableName: transform
+ baseColumnNames: source_database_id
+ referencedTableName: metabase_database
+ referencedColumnNames: id
+ constraintName: fk_tranform_source_database_id
+
+ - changeSet:
+ id: v59.2025-12-01T18:53:26
+ author: nvoxland
+ comment: Transfer data from transform.source to transform.source_database_id
+ changes:
+ - customChange:
+ class: "metabase.app_db.custom_migrations.SetTransformSourceDatabaseId"
+ rollback: # No need to roll back
+
+ - changeSet:
+ id: v59.2025-12-01T18:53:27
+ author: nvoxland
+ comment: Make transform.source_database_id not nullable
+ changes:
+ - addNotNullConstraint:
+ tableName: transform
+ columnName: source_database_id
+ columnDataType: int
+
- changeSet:
id: v59.2025-12-04T12:00:00
author: metabase
diff --git a/src/metabase/app_db/custom_migrations.clj b/src/metabase/app_db/custom_migrations.clj
index 58116b38bd7..ed74f2b9e65 100644
--- a/src/metabase/app_db/custom_migrations.clj
+++ b/src/metabase/app_db/custom_migrations.clj
@@ -1821,5 +1821,14 @@
{:transform-id id :source-type source-type})))]
(t2/update! :transform id {:source_type transform-type})))))
+(define-migration SetTransformSourceDatabaseId
+ (doseq [transform (t2/select [:transform :id :source])]
+ (let [parsed-source (-> transform :source json/decode+kw)
+ db-id (case (keyword (:type parsed-source))
+ :query (get-in parsed-source [:query :database])
+ :python (parsed-source :source-database)
+ nil)]
+ (t2/update! :transform (:id transform) {:source_database_id db-id}))))
+
(define-migration MoveExistingAtSymbolUserAttributes
(reserve-at-symbol-user-attributes/migrate!))
diff --git a/src/metabase/collections/models/collection.clj b/src/metabase/collections/models/collection.clj
index ec3380ec934..cd9b9fc97cf 100644
--- a/src/metabase/collections/models/collection.clj
+++ b/src/metabase/collections/models/collection.clj
@@ -798,7 +798,11 @@
(when-let [tenant-collection-and-descendant-ids (seq (perms/user->tenant-collection-and-descendant-ids current-user-id))]
{:select visible-union-columns
:from [[:collection :c]]
- :where [:in :id [:inline tenant-collection-and-descendant-ids]]})])}
+ :where [:in :id [:inline tenant-collection-and-descendant-ids]]})
+ (when (perms/is-data-analyst? current-user-id)
+ {:select visible-union-columns
+ :from [[:collection :c]]
+ :where [:= :namespace [:inline "transforms"]]})])}
:c])]
;; The `WHERE` clause is where we apply the other criteria we were given:
:where [:and
@@ -2311,3 +2315,8 @@
(pos-int? (t2/count :model/Collection :id collection-id :type [:in [library-collection-type
library-data-collection-type
library-metrics-collection-type]]))))
+
+(defn collections-in-namespace
+ "Return all collections in the given namespace."
+ [namespace]
+ (t2/select :model/Collection :namespace (name namespace)))
diff --git a/src/metabase/collections_rest/api.clj b/src/metabase/collections_rest/api.clj
index 3641eac6ddc..59ace571013 100644
--- a/src/metabase/collections_rest/api.clj
+++ b/src/metabase/collections_rest/api.clj
@@ -490,7 +490,7 @@
:where [:and
(poison-when-pinned-clause pinned-state)
[:= :collection_id (:id collection)]
- (when-not api/*is-superuser?*
+ (when-not (or api/*is-superuser?* api/*is-data-analyst?*)
[:=
[:inline 0]
[:inline 1]])]})
diff --git a/src/metabase/permissions/core.clj b/src/metabase/permissions/core.clj
index 590b508baa7..aff82462b51 100644
--- a/src/metabase/permissions/core.clj
+++ b/src/metabase/permissions/core.clj
@@ -43,6 +43,8 @@
full-db-permission-for-user
full-schema-permission-for-user
groups-have-permission-for-table?
+ is-superuser?
+ is-data-analyst?
most-permissive-database-permission-for-user
native-download-permission-for-user
permissions-for-user
@@ -106,7 +108,9 @@
collection-path?]
[metabase.permissions.user
user-permissions-set
- user->tenant-collection-and-descendant-ids]
+ user->tenant-collection-and-descendant-ids
+ has-any-transforms-permission?
+ has-db-transforms-permission?]
[metabase.permissions.util
PathSchema
check-revision-numbers
diff --git a/src/metabase/permissions/models/data_permissions.clj b/src/metabase/permissions/models/data_permissions.clj
index 2384c1e71f6..e92b05d5116 100644
--- a/src/metabase/permissions/models/data_permissions.clj
+++ b/src/metabase/permissions/models/data_permissions.clj
@@ -228,13 +228,15 @@
(let [ordered-values (-> permissions.schema/data-permissions perm-type :values reverse)]
(first (filter (set perm-values) ordered-values))))
-(defn- is-superuser?
+(defn is-superuser?
+ "Returns true if the given user ID is a superuser. Avoids a DB query when checking the current user."
[user-id]
(if (= user-id api/*current-user-id*)
api/*is-superuser?*
(t2/select-one-fn :is_superuser :model/User :id user-id)))
-(defn- is-data-analyst?
+(defn is-data-analyst?
+ "Returns true if the given user ID is a data analyst. Avoids a DB query when checking the current user."
[user-id]
(if (= user-id api/*current-user-id*)
api/*is-data-analyst?*
@@ -506,8 +508,8 @@
(mu/defn user-has-any-perms-of-type? :- :boolean
"Returns a Boolean indicating whether the user has the highest level of access for the given permission type in any
- group, for at least one database or table."
- [user-id perm-type]
+ group, for at least one database or table. Optionally takes `:exclude-db-ids` to exclude specific databases from the check."
+ [user-id perm-type & {:keys [exclude-db-ids]}]
(or (is-superuser? user-id)
(and (= perm-type :perms/manage-table-metadata)
(is-data-analyst? user-id))
@@ -517,10 +519,12 @@
:from [[:permissions_group_membership :pgm]]
:join [[:permissions_group :pg] [:= :pg.id :pgm.group_id]
[:data_permissions :p] [:= :p.group_id :pg.id]]
- :where [:and
- [:= :pgm.user_id user-id]
- [:= :p.perm_type (u/qualified-name perm-type)]
- [:= :p.perm_value (u/qualified-name value)]]}))))
+ :where (into [:and
+ [:= :pgm.user_id user-id]
+ [:= :p.perm_type (u/qualified-name perm-type)]
+ [:= :p.perm_value (u/qualified-name value)]]
+ (when (seq exclude-db-ids)
+ [[:not-in :p.db_id exclude-db-ids]]))}))))
(defn- admin-permission-graph
"Returns the graph representing admin permissions for all groups"
@@ -646,7 +650,13 @@
(= [:perms/view-data :blocked] [perm-type value])
(into [(build-database-permission group-or-id db-or-id :perms/create-queries :no)
- (build-database-permission group-or-id db-or-id :perms/download-results :no)]))]
+ (build-database-permission group-or-id db-or-id :perms/download-results :no)])
+
+ (and (= perm-type :perms/view-data) (not= value :unrestricted))
+ (conj (build-database-permission group-or-id db-or-id :perms/transforms :no))
+
+ (and (= perm-type :perms/create-queries) (not= value :query-builder-and-native))
+ (conj (build-database-permission group-or-id db-or-id :perms/transforms :no)))]
(apply merge-with concat
{:to-delete existing-perms
:to-insert [new-perm]}
diff --git a/src/metabase/permissions/schema.clj b/src/metabase/permissions/schema.clj
index fa33a7b6a7d..4cf7280d201 100644
--- a/src/metabase/permissions/schema.clj
+++ b/src/metabase/permissions/schema.clj
@@ -20,7 +20,8 @@
:perms/create-queries {:model :model/Table, :values [:query-builder-and-native :query-builder :no]}
:perms/download-results {:model :model/Table, :values [:one-million-rows :ten-thousand-rows :no]}
:perms/manage-table-metadata {:model :model/Table, :values [:yes :no]}
- :perms/manage-database {:model :model/Database, :values [:yes :no]}})
+ :perms/manage-database {:model :model/Database, :values [:yes :no]}
+ :perms/transforms {:model :model/Database, :values [:yes :no]}})
(mr/def ::data-permission-type
"Malli spec for valid permission types."
diff --git a/src/metabase/permissions/user.clj b/src/metabase/permissions/user.clj
index 03a939a6fe1..323127eab93 100644
--- a/src/metabase/permissions/user.clj
+++ b/src/metabase/permissions/user.clj
@@ -1,6 +1,7 @@
(ns metabase.permissions.user
(:require
[metabase.app-db.core :as app-db]
+ [metabase.permissions.models.data-permissions :as data-perms]
[metabase.permissions.path :as permissions.path]
[metabase.premium-features.core :refer [defenterprise]]
[metabase.util :as u]))
@@ -11,6 +12,18 @@
[_user-or-id]
[])
+(defenterprise has-any-transforms-permission?
+ "OSS version of has-any-transforms-permission? Returns false since transforms are an EE feature."
+ metabase-enterprise.transforms.util
+ [_user-id]
+ false)
+
+(defenterprise has-db-transforms-permission?
+ "OSS version of has-db-transforms-permission? Returns false since transforms are an EE feature."
+ metabase-enterprise.transforms.util
+ [_user-id _database-id]
+ false)
+
(defn user-permissions-set
"Return a set of all permissions object paths that `user-or-id` has been granted access to. (2 DB Calls)"
[user-or-id]
@@ -27,6 +40,12 @@
(map permissions.path/collection-readwrite-path
(user->tenant-collection-and-descendant-ids user-or-id))
+ ;; Current User always gets read perms for Transforms if they are an analyst (1 DB Call)
+ (when (or (data-perms/is-data-analyst? user-id) (data-perms/is-superuser? user-id))
+ (concat ["/collection/namespace/transforms/root/"]
+ (map permissions.path/collection-readwrite-path ((requiring-resolve 'metabase.collections.models.collection/collections-in-namespace)
+ :transforms))))
+
;; include the other Perms entries for any Group this User is in (1 DB Call)
(map :object (app-db/query {:select [:p.object]
:from [[:permissions_group_membership :pgm]]
diff --git a/src/metabase/permissions_rest/data_permissions/graph.clj b/src/metabase/permissions_rest/data_permissions/graph.clj
index 24acbb23ee4..84ce4aa206b 100644
--- a/src/metabase/permissions_rest/data_permissions/graph.clj
+++ b/src/metabase/permissions_rest/data_permissions/graph.clj
@@ -27,7 +27,8 @@
:perms/create-queries :create-queries
:perms/download-results :download
:perms/manage-table-metadata :data-model
- :perms/manage-database :details})
+ :perms/manage-database :details
+ :perms/transforms :transforms})
(def ^:private ->api-vals
{:perms/view-data {:unrestricted :unrestricted
@@ -40,7 +41,8 @@
:ten-thousand-rows :limited
:no nil}
:perms/manage-table-metadata {:yes :all :no nil}
- :perms/manage-database {:yes :yes :no :no}})
+ :perms/manage-database {:yes :yes :no :no}
+ :perms/transforms {:yes :yes :no :no}})
(defenterprise add-impersonations-to-permissions-graph
"Augment the permissions graph with active connection impersonation policies. OSS implementation returns graph as-is."
@@ -119,7 +121,8 @@
:create-queries :query-builder-and-native
:download {:schemas :full}
:data-model {:schemas :all}
- :details :yes})
+ :details :yes
+ :transforms :yes})
(def ^:private data-analyst-perms
"Data Analysts have implicit manage-table-metadata permission for all databases."
@@ -355,6 +358,10 @@
[group-id db-id value]
(perms/set-database-permission! group-id db-id :perms/manage-database value))
+(defn- update-transforms-perms!
+ [group-id db-id value]
+ (perms/set-database-permission! group-id db-id :perms/transforms value))
+
(defn- update-table-level-create-queries-permissions!
[group-id db-id schema new-table-perms]
(let [new-table-perms (update-keys
@@ -454,14 +461,15 @@
;; instead of iterating the provided cb-changes object we need to go in a specific order
;; so backend consistency rules like setting create-queries and download to no when view-data
;; is blocked can happen in the correct order despite what may come in the API request
- perm-type [:details :data-model :download :create-queries :view-data]]
+ perm-type [:details :data-model :download :transforms :create-queries :view-data]]
(when-let [new-perms (perm-type db-changes)]
(case perm-type
:view-data (update-db-level-view-data-permissions! group-id db-id new-perms)
:create-queries (update-db-level-create-queries-permissions! group-id db-id new-perms)
:download (update-db-level-download-permissions! group-id db-id new-perms)
:data-model (update-db-level-metadata-permissions! group-id db-id new-perms)
- :details (update-details-perms! group-id db-id new-perms))))))
+ :details (update-details-perms! group-id db-id new-perms)
+ :transforms (update-transforms-perms! group-id db-id new-perms))))))
;; The following arity is provided solely for convenience for tests/REPL usage
([ks :- [:vector :any] new-value]
diff --git a/src/metabase/permissions_rest/schema.clj b/src/metabase/permissions_rest/schema.clj
index e5c4bebcb32..6c826d2af3b 100644
--- a/src/metabase/permissions_rest/schema.clj
+++ b/src/metabase/permissions_rest/schema.clj
@@ -96,7 +96,8 @@
[:data {:optional true} [:ref ::strict-data-perms]]
[:download {:optional true} [:ref ::strict-data-perms]]
[:data-model {:optional true} [:ref ::strict-data-perms]]
- [:details {:optional true} [:enum :yes :no]]]
+ [:details {:optional true} [:enum :yes :no]]
+ [:transforms {:optional true} [:enum :yes :no]]]
[:fn {:error/fn (fn [_ _] (trs "Invalid DB permissions: If you have write access for native queries, you must have data access to all schemas."))}
(fn [db-entry]
(let [{:keys [create-queries view-data]} db-entry]
diff --git a/src/metabase/warehouses_rest/api.clj b/src/metabase/warehouses_rest/api.clj
index c4c490d7e42..3beb639884b 100644
--- a/src/metabase/warehouses_rest/api.clj
+++ b/src/metabase/warehouses_rest/api.clj
@@ -102,6 +102,24 @@
:write
:none))))
+(mu/defn- add-transforms-perms-info :- [:maybe
+ [:sequential
+ [:map
+ [:transforms_permissions [:enum :write :none]]]]]
+ "For each database in DBS add a `:transforms_permissions` field describing the current user's permissions for
+ creating/running Transforms. Will be either `:write` or `:none`."
+ [dbs :- [:maybe [:sequential :map]]]
+ (for [db dbs]
+ (assoc db
+ :transforms_permissions
+ (if (perms/user-has-permission-for-database?
+ api/*current-user-id*
+ :perms/transforms
+ :yes
+ (u/the-id db))
+ :write
+ :none))))
+
(defn- card-database-supports-nested-queries? [{{database-id :database, :as query} :dataset_query, :as _card}]
(when database-id
(when-let [driver (driver.u/database->driver database-id)]
@@ -290,7 +308,7 @@
base-where)
dbs (t2/select :model/Database {:order-by [:%lower.name :%lower.engine]
:where where-clause})]
- (cond-> (add-native-perms-info dbs)
+ (cond-> (-> dbs add-native-perms-info add-transforms-perms-info)
include-tables? (add-tables :can-query? can-query? :can-write-metadata? can-write-metadata?)
can-query? (#(filter mi/can-query? %))
true add-can-upload-to-dbs
@@ -1290,6 +1308,7 @@
[:id ms/PositiveInt]]]
(let [db (get-database id)]
(api/check-403 (or (:is_attached_dwh db)
+ (perms/has-db-transforms-permission? api/*current-user-id* (:id db))
(and (mi/can-write? db)
(mi/can-read? db))))
(->> db
diff --git a/test/metabase/permissions/models/data_permissions_test.clj b/test/metabase/permissions/models/data_permissions_test.clj
index 27d5bceb8f5..a8cc2f90321 100644
--- a/test/metabase/permissions/models/data_permissions_test.clj
+++ b/test/metabase/permissions/models/data_permissions_test.clj
@@ -414,6 +414,7 @@
{""
{table-id-3 :one-million-rows}}
:perms/manage-database :yes
+ :perms/transforms :no
:perms/create-queries :no}}}
(data-perms.graph/data-permissions-graph :group-id group-id-1)))
diff --git a/test/metabase/permissions/models/permissions_group_test.clj b/test/metabase/permissions/models/permissions_group_test.clj
index 7000811fbf5..f9b18692e46 100644
--- a/test/metabase/permissions/models/permissions_group_test.clj
+++ b/test/metabase/permissions/models/permissions_group_test.clj
@@ -169,7 +169,8 @@
:perms/create-queries :no
:perms/download-results :no
:perms/manage-table-metadata :no
- :perms/manage-database :no}}}
+ :perms/manage-database :no
+ :perms/transforms :no}}}
(data-perms.graph/data-permissions-graph :group-id group-id :db-id db-id)))))))))
(deftest hydrate-members-tests
diff --git a/test/metabase/permissions/test_util.clj b/test/metabase/permissions/test_util.clj
index b5585b4aebc..6e80bf19727 100644
--- a/test/metabase/permissions/test_util.clj
+++ b/test/metabase/permissions/test_util.clj
@@ -119,13 +119,19 @@
[& body]
`(do-with-full-data-perms-for-all-users! (fn [] ~@body)))
+(defn do-with-db-perm-for-group!
+ "Implementation of `with-db-perm-for-group`. Sets the data permission for the given database to the given value
+ for the given permission group for the duration of the test."
+ [group-or-id db-id perm-type value thunk]
+ (with-restored-data-perms-for-group! (u/the-id group-or-id)
+ (data-perms/set-database-permission! group-or-id db-id perm-type value)
+ (thunk)))
+
(defn do-with-perm-for-group!
"Implementation of `with-perm-for-group`. Sets the data permission for the test dataset to the given value
for the given permission group for the duration of the test."
[group-or-id perm-type value thunk]
- (with-restored-data-perms-for-group! (u/the-id group-or-id)
- (data-perms/set-database-permission! group-or-id (data/db) perm-type value)
- (thunk)))
+ (do-with-db-perm-for-group! group-or-id (data/db) perm-type value thunk))
(defn do-with-perms-for-group-and-tables!
"Implementation of `with-perm-for-group-and-table`. Sets the data permission for the test dataset/table to the given
@@ -154,3 +160,27 @@
group for the duration of the test."
[group-or-id perm-type value & body]
`(do-with-perm-for-group! ~group-or-id ~perm-type ~value (fn [] ~@body)))
+
+(defmacro with-db-perm-for-group!
+ "Runs `body`, and sets the data permission for the the test dataset to the given value for the given permission
+ group for the duration of the test."
+ [group-or-id db-id perm-type value & body]
+ `(do-with-db-perm-for-group! ~group-or-id ~db-id ~perm-type ~value (fn [] ~@body)))
+
+(defn do-with-data-analyst-role!
+ "Implementation of `with-data-analyst-role!`. Sets the `is_data_analyst` column to true for the given user
+ for the duration of the test, then restores the original value."
+ [user-or-id thunk]
+ (let [user-id (u/the-id user-or-id)
+ original-value (t2/select-one-fn :is_data_analyst :model/User :id user-id)]
+ (try
+ (t2/update! :model/User user-id {:is_data_analyst true})
+ (thunk)
+ (finally
+ (t2/update! :model/User user-id {:is_data_analyst original-value})))))
+
+(defmacro with-data-analyst-role!
+ "Runs `body` with the given user's `is_data_analyst` column set to true.
+ Restores the original value afterwards."
+ [user-or-id & body]
+ `(do-with-data-analyst-role! ~user-or-id (fn [] ~@body)))
diff --git a/test/metabase/permissions/user_test.clj b/test/metabase/permissions/user_test.clj
index ab2c059f62f..1c934a01598 100644
--- a/test/metabase/permissions/user_test.clj
+++ b/test/metabase/permissions/user_test.clj
@@ -5,6 +5,7 @@
[clojure.test :refer :all]
[metabase.collections.models.collection :as collection]
[metabase.collections.models.collection-test :as collection-test]
+ [metabase.permissions.models.data-permissions :as data-perms]
[metabase.permissions.models.permissions-test :as perms-test]
[metabase.permissions.path :as permissions.path]
[metabase.permissions.user :as permissions.user]
@@ -51,3 +52,15 @@
(->> (permissions.user/user-permissions-set (mt/user->id :lucky))
remove-non-collection-perms
(collection-test/perms-path-ids->names [child-collection grandchild-collection])))))))))
+
+(deftest transform-users-can-create-transform-collections-test
+ (testing "Users with transforms read permission can create transform collections, even in the root"
+ (mt/with-temp [:model/Collection {coll-id :id} {:name "Test transform coll" :namespace collection/transforms-ns}]
+ (testing "without permission"
+ (with-redefs [data-perms/is-data-analyst? (constantly false)]
+ (is (not (contains? (permissions.user/user-permissions-set (mt/user->id :lucky)) "/collection/namespace/transforms/root/")))
+ (is (not (contains? (permissions.user/user-permissions-set (mt/user->id :lucky)) (format "/collection/%s" coll-id))))))
+ (testing "with permission"
+ (with-redefs [data-perms/is-data-analyst? (constantly true)]
+ (is (contains? (permissions.user/user-permissions-set (mt/user->id :lucky)) "/collection/namespace/transforms/root/"))
+ (is (contains? (permissions.user/user-permissions-set (mt/user->id :lucky)) (permissions.path/collection-readwrite-path coll-id))))))))
diff --git a/test/metabase/permissions_rest/data_permissions/graph_test.clj b/test/metabase/permissions_rest/data_permissions/graph_test.clj
index d0a7420279c..4d170e5480f 100644
--- a/test/metabase/permissions_rest/data_permissions/graph_test.clj
+++ b/test/metabase/permissions_rest/data_permissions/graph_test.clj
@@ -51,6 +51,7 @@
{database-id-1
{:perms/view-data :blocked
:perms/create-queries :no
+ :perms/transforms :no
:perms/download-results :no}}})))))
(deftest update-db-level-create-queries-permissions!-test
@@ -80,14 +81,16 @@
{group-id-1
{database-id-1
{:perms/create-queries :query-builder
- :perms/view-data :unrestricted}}}
+ :perms/view-data :unrestricted
+ :perms/transforms :no}}}
{group-id-1
{database-id-1
{:create-queries :no}}}
{group-id-1
{database-id-1
- {:perms/create-queries :no}}}
+ {:perms/create-queries :no
+ :perms/transforms :no}}}
{group-id-1
{database-id-1
@@ -148,6 +151,7 @@
{group-id-1
{database-id-1
{:perms/create-queries :no
+ :perms/transforms :no
:perms/view-data {"PUBLIC"
{table-id-1 :unrestricted
table-id-2 :legacy-no-self-service}
@@ -158,11 +162,13 @@
{group-id-1
{database-id-1
{:create-queries :query-builder-and-native
- :view-data :unrestricted}}}
+ :view-data :unrestricted
+ :transforms :yes}}}
{group-id-1
{database-id-1
{:perms/create-queries :query-builder-and-native
- :perms/view-data :unrestricted}}}
+ :perms/view-data :unrestricted
+ :perms/transforms :yes}}}
;; Setting data access permissions at the schema-level
{group-id-1
@@ -173,13 +179,14 @@
{group-id-1
{database-id-1
{:perms/create-queries :no
+ :perms/transforms :no
:perms/view-data {"PUBLIC"
{table-id-1 :unrestricted
table-id-2 :unrestricted}
""
{table-id-3 :legacy-no-self-service}}}}}
- ;; Setting block permissions for the database also sets :create-queries and :download-results to :no
+ ;; Setting block permissions for the database also sets :create-queries and :download-results to :no and :transforms to :no
{group-id-1
{database-id-1
{:view-data :blocked}}}
@@ -187,6 +194,7 @@
{database-id-1
{:perms/create-queries :no
:perms/view-data :blocked
+ :perms/transforms :no
:perms/download-results :no}}})))))
(deftest update-db-level-download-permissions!-test
diff --git a/test/metabase/test.clj b/test/metabase/test.clj
index f941fd7e11c..52282da052f 100644
--- a/test/metabase/test.clj
+++ b/test/metabase/test.clj
@@ -200,8 +200,10 @@
with-restored-data-perms-for-groups!
with-no-data-perms-for-all-users!
with-full-data-perms-for-all-users!
+ with-db-perm-for-group!
with-perm-for-group!
- with-perm-for-group-and-table!]
+ with-perm-for-group-and-table!
+ with-data-analyst-role!]
[qp
process-query
diff --git a/test/metabase/warehouses_rest/api_test.clj b/test/metabase/warehouses_rest/api_test.clj
index 57da6fc0ca6..d2db81399c9 100644
--- a/test/metabase/warehouses_rest/api_test.clj
+++ b/test/metabase/warehouses_rest/api_test.clj
@@ -908,7 +908,7 @@
(testing "GET /api/database"
(testing "Test that we can get all the DBs (ordered by name, then driver)"
(testing "Database details/settings *should not* come back for Rasta since she's not a superuser"
- (let [expected-keys (-> #{:features :native_permissions :can_upload :router_user_attribute}
+ (let [expected-keys (-> #{:features :native_permissions :can_upload :router_user_attribute :transforms_permissions}
(into (keys (t2/select-one :model/Database :id (mt/id))))
(disj :details))]
(doseq [db (:data (mt/user-http-request :rasta :get 200 "database"))]
diff --git a/test_resources/serialization_baseline/collections/transforms/2HzIFwJ6720JAx07UMavl_test_transform.yaml b/test_resources/serialization_baseline/collections/transforms/2HzIFwJ6720JAx07UMavl_test_transform.yaml
index a40f0fc4e72..26415e7ccdb 100644
--- a/test_resources/serialization_baseline/collections/transforms/2HzIFwJ6720JAx07UMavl_test_transform.yaml
+++ b/test_resources/serialization_baseline/collections/transforms/2HzIFwJ6720JAx07UMavl_test_transform.yaml
@@ -4,6 +4,7 @@ creator_id: [email protected]
description: A test transform for serialization
entity_id: 2HzIFwJ6720JAx07UMavl
name: Test Transform
+source_database_id: My Database
owner_email: null
owner_user_id: null
source: