The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Change permission required to view segment (#67855)
John Swansonbeb2b5b751a7
diff --git a/src/metabase/segments/models/segment.clj b/src/metabase/segments/models/segment.cljindex 089f4579b87..adaac856795 100644--- a/src/metabase/segments/models/segment.clj+++ b/src/metabase/segments/models/segment.clj@@ -76,12 +76,7 @@(defmethod mi/can-read? :model/Segment([instance](let [table (:table (t2/hydrate instance :table))]- (perms/user-has-permission-for-table?- api/*current-user-id*- :perms/manage-table-metadata- :yes- (:db_id table)- (u/the-id table))))+ (mi/can-read? table)))([model pk](mi/can-read? (t2/select-one model pk))))diff --git a/test/metabase/segments/api_test.clj b/test/metabase/segments/api_test.cljindex c309b8b2fee..e36fb7c8bc3 100644--- a/test/metabase/segments/api_test.clj+++ b/test/metabase/segments/api_test.clj@@ -6,6 +6,7 @@[metabase.lib-be.core :as lib-be][metabase.lib.core :as lib][metabase.lib.metadata :as lib.metadata]+ [metabase.permissions.core :as perms][metabase.test :as mt][metabase.test.http-client :as client][metabase.util :as u]@@ -326,6 +327,33 @@(contains? #{id-1 id-2 id-3} segment-id))(mt/user-http-request :rasta :get 200 "segment/"))))))))+(deftest list-permissions-test+ (testing "GET /api/segment/"+ (mt/with-temp [:model/Segment {users-seg-id :id} {:name "Users Segment"+ :table_id (mt/id :users)+ :definition (mbql4-segment-definition (mt/id :users) (mt/id :users :name) "cans")}+ :model/Segment {venues-seg-id :id} {:name "Venues Segment"+ :table_id (mt/id :venues)+ :definition (mbql4-segment-definition (mt/id :venues) (mt/id :venues :name) "bar")}]+ (let [segment-ids #{users-seg-id venues-seg-id}+ returned-segment-ids (fn []+ (->> (mt/user-http-request :rasta :get 200 "segment/")+ (filter #(segment-ids (:id %)))+ (map :id)+ set))]+ (testing "user with full data perms sees all segments"+ (mt/with-full-data-perms-for-all-users!+ (is (= segment-ids (returned-segment-ids)))))+ (testing "user with no data perms sees no segments"+ (mt/with-no-data-perms-for-all-users!+ (is (= #{} (returned-segment-ids)))))+ (testing "user with perms to one table sees only that table's segment"+ (mt/with-no-data-perms-for-all-users!+ (let [all-users-group-id (:id (perms/all-users-group))]+ (mt/with-perm-for-group-and-table! all-users-group-id (mt/id :users) :perms/view-data :unrestricted+ (mt/with-perm-for-group-and-table! all-users-group-id (mt/id :users) :perms/create-queries :query-builder+ (is (= #{users-seg-id} (returned-segment-ids))))))))))))+(deftest related-entities-test(testing "GET /api/segment/:id/related"(testing "related/recommended entities"