Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

GDGT-2089: Adjust viz settings sidebar styling (#71472)

Stas Gavrylovbeed12ea36bb
diff --git a/frontend/src/metabase/visualizations/components/ChartSettings/BaseChartSettings/BaseChartSettings.styled.tsx b/frontend/src/metabase/visualizations/components/ChartSettings/BaseChartSettings/BaseChartSettings.styled.tsx
index b4a8d7867ae..ec4a048b51e 100644
--- a/frontend/src/metabase/visualizations/components/ChartSettings/BaseChartSettings/BaseChartSettings.styled.tsx
+++ b/frontend/src/metabase/visualizations/components/ChartSettings/BaseChartSettings/BaseChartSettings.styled.tsx
@@ -7,14 +7,15 @@ export const SectionContainer = styled.div`
width: 100%;
${Radio.RadioGroupVariants.join(", ")} {
- padding-left: 0.5rem;
- padding-right: 0.5rem;
+ padding-top: 1rem;
+ padding-inline: 1.5rem;
border-bottom: 1px solid var(--mb-color-border);
}
${Radio.RadioContainerVariants.join(", ")} {
padding-left: 1rem;
padding-right: 1rem;
+ padding-block: 0.5rem;
}
${Radio.RadioLabelVariants.join(", ")} {
@@ -31,7 +32,7 @@ export const SectionContainer = styled.div`
export const ChartSettingsListContainer = styled.div`
position: relative;
- padding: 1.5rem 0;
+ padding: 1.5rem 0 0;
flex: 1;
overflow: auto;
`;
diff --git a/frontend/src/metabase/visualizations/components/ChartSettingsWidget.styled.tsx b/frontend/src/metabase/visualizations/components/ChartSettingsWidget.styled.tsx
index f7567d4bb16..b5012f13464 100644
--- a/frontend/src/metabase/visualizations/components/ChartSettingsWidget.styled.tsx
+++ b/frontend/src/metabase/visualizations/components/ChartSettingsWidget.styled.tsx
@@ -6,9 +6,8 @@ import styled from "@emotion/styled";
export const Root = styled.div<{
inline?: boolean;
}>`
- margin-left: 2rem;
- margin-right: 2rem;
- margin-bottom: 1.5em;
+ margin-inline: 1.5rem;
+ margin-bottom: 1.5rem;
${(props) =>
props.hidden &&
diff --git a/frontend/src/metabase/visualizations/components/ChartSettingsWidgetList.styled.tsx b/frontend/src/metabase/visualizations/components/ChartSettingsWidgetList.styled.tsx
index d1ff96e49d4..972035cc603 100644
--- a/frontend/src/metabase/visualizations/components/ChartSettingsWidgetList.styled.tsx
+++ b/frontend/src/metabase/visualizations/components/ChartSettingsWidgetList.styled.tsx
@@ -1,18 +1,9 @@
// eslint-disable-next-line no-restricted-imports
import styled from "@emotion/styled";
-export const ChartSettingsWidgetListHeader = styled.h4`
- margin-left: 2rem;
- margin-bottom: 1rem;
- color: var(--mb-color-text-secondary);
- text-transform: uppercase;
-`;
-
export const ChartSettingsWidgetListDivider = styled.div`
background-color: var(--mb-color-border);
height: 1px;
display: block;
margin-bottom: 1.5rem;
- margin-left: 2rem;
- margin-right: 2rem;
`;
diff --git a/frontend/src/metabase/visualizations/components/ChartSettingsWidgetList.tsx b/frontend/src/metabase/visualizations/components/ChartSettingsWidgetList.tsx
index f5e5bf192b4..f2e521ee98c 100644
--- a/frontend/src/metabase/visualizations/components/ChartSettingsWidgetList.tsx
+++ b/frontend/src/metabase/visualizations/components/ChartSettingsWidgetList.tsx
@@ -1,10 +1,9 @@
import _ from "underscore";
+import { Badge } from "metabase/ui";
+
import ChartSettingsWidget from "./ChartSettingsWidget";
-import {
- ChartSettingsWidgetListDivider,
- ChartSettingsWidgetListHeader,
-} from "./ChartSettingsWidgetList.styled";
+import { ChartSettingsWidgetListDivider } from "./ChartSettingsWidgetList.styled";
interface ChartSettingsWidgetListProps {
widgets: { id: string; group?: string }[];
@@ -36,9 +35,18 @@ const ChartSettingsWidgetList = ({
return (
<div key={`group-${groupIndex}`}>
{group && (
- <ChartSettingsWidgetListHeader>
+ <Badge
+ mb="lg"
+ ml="lg"
+ fz="0.75rem"
+ px="0.5rem"
+ tt="none"
+ radius="xs"
+ size="lg"
+ c="text-primary"
+ >
{group}
- </ChartSettingsWidgetListHeader>
+ </Badge>
)}
<div>
{_.sortBy(groupedWidgets[group], "index").map((widget) => (
@@ -48,7 +56,9 @@ const ChartSettingsWidgetList = ({
{...extraWidgetProps}
/>
))}
- {!lastGroup && <ChartSettingsWidgetListDivider />}
+ <ChartSettingsWidgetListDivider
+ style={lastGroup ? { marginBottom: 0 } : undefined}
+ />
</div>
</div>
);