Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Fix flaky embed parameters e2e by pre-accepting embedding terms (#81322)

Sébastienbf5778bc50ef
diff --git a/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/embed-parameters.cy.spec.ts b/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/embed-parameters.cy.spec.ts
index a12e2fb9e2e..840c020a240 100644
--- a/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/embed-parameters.cy.spec.ts
+++ b/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/embed-parameters.cy.spec.ts
@@ -21,8 +21,15 @@ describe(suiteTitle, () => {
cy.signInAsAdmin();
H.activateToken("pro-self-hosted");
H.enableTracking();
+ // Accept both sets of embedding terms up front so the wizard never shows
+ // the Agree CTA. Every test here preselects SSO, but the wizard opens in
+ // guest mode while SSO is unconfigured, so an unaccepted guest CTA would
+ // otherwise have to be clicked through first. That flow is covered by
+ // embed-flow-enable-embed-js-*.
H.updateSetting("enable-embedding-simple", true);
- H.updateSetting("enable-embedding-static", false);
+ H.updateSetting("show-simple-embed-terms", false);
+ H.updateSetting("enable-embedding-static", true);
+ H.updateSetting("show-static-embed-terms", false);
H.mockEmbedJsToDevServer();
});
diff --git a/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/helpers/index.ts b/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/helpers/index.ts
index 97ea7a5bc6b..1afbfb7171f 100644
--- a/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/helpers/index.ts
+++ b/e2e/test/scenarios/embedding/sdk-iframe-embedding-setup/helpers/index.ts
@@ -41,7 +41,9 @@ export const visitNewEmbedPage = (
if (waitForResource) {
// Accept the terms only once the sidebar has settled: a click landing
// mid-re-render is dropped silently and blocks the wizard (EMB-2307).
- cy.wait("@dashboard", { timeout: 20_000 });
+ // The default dashboard is only chosen once recents and search settle,
+ // so under load the request needs the same 40s margin (EMB-2319).
+ cy.wait("@dashboard", { timeout: 40_000 });
embedModalEnableEmbedding();