Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

UXW-311 [Sheets] Clicking notification should refresh the page (#64614)

Kamil Mielnikbf5799df153d
diff --git a/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveSyncStatus.tsx b/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveSyncStatus.tsx
index 7ce7d12b9f0..218a5af8a8e 100644
--- a/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveSyncStatus.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveSyncStatus.tsx
@@ -4,7 +4,8 @@ import { match } from "ts-pattern";
import { t } from "ttag";
import { getCurrentUser } from "metabase/admin/datamodel/selectors";
-import { skipToken } from "metabase/api";
+import { Api, skipToken } from "metabase/api";
+import { tag } from "metabase/api/tags";
import { getErrorMessage } from "metabase/api/utils";
import { useDispatch, useSelector } from "metabase/lib/redux";
import StatusLarge from "metabase/status/components/StatusLarge";
@@ -60,6 +61,11 @@ export const GdriveSyncStatus = () => {
setDbId(gdriveFolder?.db_id);
}
+ // refetch tables once the sync completes
+ if (status === "active" && previousStatus === "syncing") {
+ dispatch(Api.util.invalidateTags([tag("table")]));
+ }
+
if (status === "error" && previousStatus === "syncing") {
console.error(
getErrorMessage(
@@ -69,7 +75,7 @@ export const GdriveSyncStatus = () => {
),
);
}
- }, [status, previousStatus, gdriveFolder, dbId, apiError]);
+ }, [dispatch, status, previousStatus, gdriveFolder, dbId, apiError]);
if (forceHide || !isCurrentUser) {
return null;
diff --git a/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveSyncStatus.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveSyncStatus.unit.spec.tsx
index 78a1cf33c53..b4e7480a883 100644
--- a/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveSyncStatus.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveSyncStatus.unit.spec.tsx
@@ -1,10 +1,12 @@
import userEvent from "@testing-library/user-event";
+import fetchMock from "fetch-mock";
import {
setupGdriveGetFolderEndpoint,
setupGdriveServiceAccountEndpoint,
} from "__support__/server-mocks";
import { act, renderWithProviders, screen, waitFor } from "__support__/ui";
+import { useListDatabasesQuery, useListTablesQuery } from "metabase/api";
import { useDispatch } from "metabase/lib/redux";
import { EnterpriseApi } from "metabase-enterprise/api/api";
import type { GdrivePayload } from "metabase-types/api";
@@ -23,6 +25,9 @@ function TestComponent() {
dispatch(EnterpriseApi.util.invalidateTags(["gsheets-status"]));
};
+ useListDatabasesQuery(); // simulate user browsing the database page
+ useListTablesQuery();
+
return (
<>
<GdriveSyncStatus />
@@ -171,6 +176,27 @@ describe("GsheetsSyncStatus", () => {
screen.getByText("Files sync every 15 minutes");
});
+ it("should refetch tables when sync completes (UXW-311)", async () => {
+ setup({
+ initialFolderPayload: { status: "syncing" },
+ });
+ fetchMock.get(`path:/api/database`, []);
+ fetchMock.get(`path:/api/table`, []);
+
+ setupGdriveGetFolderEndpoint({
+ status: "active",
+ db_id: 1,
+ created_by_id: USER_ID,
+ });
+
+ await act(() => {
+ jest.advanceTimersByTime(3000);
+ });
+
+ expect(fetchMock.callHistory.called("/api/database")).toBe(true);
+ expect(fetchMock.callHistory.called("/api/table")).toBe(true);
+ });
+
it("should show error from error response", async () => {
setup({
initialFolderPayload: { status: "syncing" },