Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Gdgt 2465 popover (#81561)

Jakub Chodorowiczc0949b1d38a6
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Component_Compatibility.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Component_Compatibility.png
index 4f298769f62..d704dd80211 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Component_Compatibility.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Component_Compatibility.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_All_Options.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_All_Options.png
index a88f9e6ed78..54723172a35 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_All_Options.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_All_Options.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Month_Year.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Month_Year.png
index 6f49e8b1ec1..e5c74733439 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Month_Year.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Month_Year.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Quarter_Year.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Quarter_Year.png
index 99e7143c517..30c4627a666 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Quarter_Year.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Quarter_Year.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Quarter_Year_Dropdown.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Quarter_Year_Dropdown.png
index e2ce3aef797..9f5d1c2bc14 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Quarter_Year_Dropdown.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Quarter_Year_Dropdown.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Range.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Range.png
index 239abec71b9..ddd2cea9122 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Range.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Range.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Relative.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Relative.png
index 13856ce8f1b..f8137a3d9cd 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Relative.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Relative.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Single.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Single.png
index abce454ef3a..f0171440157 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Single.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Single.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Number.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Number.png
index 63415d591ef..bebe8f86f61 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Number.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Number.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List.png
index d6b1ff6b5ad..71aac94d09a 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List_Single_With_Value.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List_Single_With_Value.png
index ce7769250bc..af5374101c6 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List_Single_With_Value.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List_Single_With_Value.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List_With_Value.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List_With_Value.png
index 5b70ec9d7d1..0bd03a11625 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List_With_Value.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_List_With_Value.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_Search.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_Search.png
index 47bd6652c02..71aac94d09a 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_Search.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_Search.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_Search_With_Value.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_Search_With_Value.png
index 126e73ed200..70455cff16b 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_Search_With_Value.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Parameter_Search_With_Value.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Text.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Text.png
index a5cd3bd4a3e..13b2d84764f 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Text.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Text.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Text_With_Value.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Text_With_Value.png
index a5cd3bd4a3e..13b2d84764f 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Text_With_Value.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Text_With_Value.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Unit_Of_Time.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Unit_Of_Time.png
index 0254aac29c6..aae2928cf7e 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Unit_Of_Time.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Unit_Of_Time.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_All_Options.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_All_Options.png
index ba9d0e7b2ad..05512e4900b 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_All_Options.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_All_Options.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Month_Year.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Month_Year.png
index 9075e1836a6..3334c23ceff 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Month_Year.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Month_Year.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Quarter_Year.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Quarter_Year.png
index d3cd5823e3a..d71d957bca2 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Quarter_Year.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Quarter_Year.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Quarter_Year_Dropdown.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Quarter_Year_Dropdown.png
index f033e55207d..8272feaf628 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Quarter_Year_Dropdown.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Quarter_Year_Dropdown.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Range.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Range.png
index b862bc6d758..9b7e2836b07 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Range.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Range.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Relative.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Relative.png
index 956c95ae914..e77a4275fdd 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Relative.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Relative.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Single.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Single.png
index 247b803eedb..f0890c09666 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Single.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Single.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Number.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Number.png
index 46492b2969e..91248ca3030 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Number.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Number.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List.png
index 90975ec34ca..5e0d8704052 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List_Single_With_Value.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List_Single_With_Value.png
index 7fe424ca1be..d2fd2cff7a6 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List_Single_With_Value.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List_Single_With_Value.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List_With_Value.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List_With_Value.png
index 48f8bf09ce8..6515f6aa391 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List_With_Value.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_List_With_Value.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_Search.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_Search.png
index fdbd83d1e9b..40668d8af26 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_Search.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_Search.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_Search_With_Value.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_Search_With_Value.png
index 90fce5869d2..84a70b774c3 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_Search_With_Value.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Parameter_Search_With_Value.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Text.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Text.png
index ee2c3c32b16..fa7785490df 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Text.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Text.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Text_With_Value.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Text_With_Value.png
index 3bbeabe7416..fa7785490df 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Text_With_Value.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Text_With_Value.png differ
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Unit_Of_Time.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Unit_Of_Time.png
index 917d0e6b3cb..954dfc13fa8 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Unit_Of_Time.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Unit_Of_Time.png differ
diff --git a/.loki/reference/chrome_laptop_Components_Overlays_Popover_Default.png b/.loki/reference/chrome_laptop_Components_Overlays_Popover_Default.png
new file mode 100644
index 00000000000..618125824a6
Binary files /dev/null and b/.loki/reference/chrome_laptop_Components_Overlays_Popover_Default.png differ
diff --git a/.loki/reference/chrome_laptop_Components_Overlays_Popover_Interactive_content.png b/.loki/reference/chrome_laptop_Components_Overlays_Popover_Interactive_content.png
new file mode 100644
index 00000000000..618125824a6
Binary files /dev/null and b/.loki/reference/chrome_laptop_Components_Overlays_Popover_Interactive_content.png differ
diff --git a/.loki/reference/chrome_laptop_Components_Overlays_Popover_Overview.png b/.loki/reference/chrome_laptop_Components_Overlays_Popover_Overview.png
new file mode 100644
index 00000000000..e7118193e35
Binary files /dev/null and b/.loki/reference/chrome_laptop_Components_Overlays_Popover_Overview.png differ
diff --git a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_All_Options.png b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_All_Options.png
index b665f77468c..6e2ddb3fbe7 100644
Binary files a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_All_Options.png and b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_All_Options.png differ
diff --git a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_All_Options_Dark_Theme.png b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_All_Options_Dark_Theme.png
index 63bb8a73a70..be0ae02a0f4 100644
Binary files a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_All_Options_Dark_Theme.png and b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_All_Options_Dark_Theme.png differ
diff --git a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Exclude.png b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Exclude.png
index 7194a369704..763541b08c4 100644
Binary files a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Exclude.png and b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Exclude.png differ
diff --git a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Exclude_Dark_Theme.png b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Exclude_Dark_Theme.png
index 6c4887c72e3..b34b44c92cc 100644
Binary files a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Exclude_Dark_Theme.png and b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Exclude_Dark_Theme.png differ
diff --git a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Exclude_Day_Of_Week.png b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Exclude_Day_Of_Week.png
index 2310aa9ab70..a3d4152d481 100644
Binary files a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Exclude_Day_Of_Week.png and b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Exclude_Day_Of_Week.png differ
diff --git a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Exclude_Day_Of_Week_Dark_Theme.png b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Exclude_Day_Of_Week_Dark_Theme.png
index 755ae161156..584ca1c416d 100644
Binary files a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Exclude_Day_Of_Week_Dark_Theme.png and b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Exclude_Day_Of_Week_Dark_Theme.png differ
diff --git a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Relative_Current.png b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Relative_Current.png
index b8222429fdc..712825a66ac 100644
Binary files a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Relative_Current.png and b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Relative_Current.png differ
diff --git a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Relative_Current_Dark_Theme.png b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Relative_Current_Dark_Theme.png
index 824523690ef..e1dd9cf6bd3 100644
Binary files a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Relative_Current_Dark_Theme.png and b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Relative_Current_Dark_Theme.png differ
diff --git a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Relative_Next.png b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Relative_Next.png
index 89a2356deaa..2c1f14f2641 100644
Binary files a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Relative_Next.png and b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Relative_Next.png differ
diff --git a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Relative_Next_Dark_Theme.png b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Relative_Next_Dark_Theme.png
index 1264edc1d8b..713c7d47fe6 100644
Binary files a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Relative_Next_Dark_Theme.png and b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Relative_Next_Dark_Theme.png differ
diff --git a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Relative_Previous.png b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Relative_Previous.png
index 662d4ef2844..6136b79fffa 100644
Binary files a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Relative_Previous.png and b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Relative_Previous.png differ
diff --git a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Relative_Previous_Dark_Theme.png b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Relative_Previous_Dark_Theme.png
index c8c1572eaa1..ae9cc7a9a0d 100644
Binary files a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Relative_Previous_Dark_Theme.png and b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Relative_Previous_Dark_Theme.png differ
diff --git a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Specific_Between.png b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Specific_Between.png
index cc9b518668c..527bb6fffac 100644
Binary files a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Specific_Between.png and b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Specific_Between.png differ
diff --git a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Specific_Between_Dark_Theme.png b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Specific_Between_Dark_Theme.png
index 65270c1cb77..febfddebd21 100644
Binary files a/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Specific_Between_Dark_Theme.png and b/.loki/reference/chrome_laptop_Components_Parameters_DatePicker_Specific_Between_Dark_Theme.png differ
diff --git a/e2e/test-component/scenarios/embedding-sdk/popover.cy.spec.tsx b/e2e/test-component/scenarios/embedding-sdk/popover.cy.spec.tsx
index 9c0ddab3fbd..2493d6bf362 100644
--- a/e2e/test-component/scenarios/embedding-sdk/popover.cy.spec.tsx
+++ b/e2e/test-component/scenarios/embedding-sdk/popover.cy.spec.tsx
@@ -15,6 +15,9 @@ import type { ConcreteFieldReference } from "metabase-types/api";
const { ORDERS, ORDERS_ID, PEOPLE } = SAMPLE_DATABASE;
+// take into account radius corner
+const EDGE_CLICK_Y = 16;
+
const ORDERS_TOTAL_FIELD: ConcreteFieldReference = [
"field",
ORDERS.TOTAL,
@@ -120,7 +123,7 @@ describe("scenarios > embedding-sdk > popovers", () => {
() => {
cy.findByTestId("multi-select").click();
// Clicking at the edge of the multiselect popover to be sure that the click does not close it
- cy.get('[data-element-id="mantine-popover"]').click(2, 2);
+ cy.get('[data-element-id="mantine-popover"]').click(2, EDGE_CLICK_Y);
cy.get('[data-element-id="mantine-popover"]').should("be.visible");
// Clicking outside of the multiselect popover to be sure that the click closes it
@@ -142,11 +145,11 @@ describe("scenarios > embedding-sdk > popovers", () => {
cy.findByTestId("color-selector-button").click();
// Clicking at the edge of the color picker popover to be sure that the click does not close it
- cy.findByTestId("color-selector-popover").click(1, 1);
+ cy.findByTestId("color-selector-popover").click(1, EDGE_CLICK_Y);
cy.findByTestId("color-selector-popover").should("be.visible");
// Clicking outside the color picker to be sure that the click closes it
- cy.findByTestId("chartsettings-sidebar").click(1, 1);
+ cy.findByTestId("chartsettings-sidebar").click(1, EDGE_CLICK_Y);
cy.findByTestId("color-selector-popover").should("not.exist");
cy.findByTestId("settings-count").click();
@@ -155,7 +158,7 @@ describe("scenarios > embedding-sdk > popovers", () => {
cy.findByTestId("color-selector-button").click();
// Clicking at the edge of the color picker popover to be sure that the click does not close it
- cy.findByTestId("color-selector-popover").click(1, 1);
+ cy.findByTestId("color-selector-popover").click(1, EDGE_CLICK_Y);
cy.findByTestId("color-selector-popover").should("be.visible");
});
});
@@ -175,7 +178,7 @@ describe("scenarios > embedding-sdk > popovers", () => {
cy.findAllByTestId("color-selector-button").first().click();
// Clicking at the edge of the color picker popover to be sure that the click does not close it
- cy.findByTestId("color-selector-popover").click(1, 1);
+ cy.findByTestId("color-selector-popover").click(1, EDGE_CLICK_Y);
cy.findByTestId("color-selector-popover").should("be.visible");
// Clicking outside the color picker to be sure that the click closes it
@@ -204,7 +207,7 @@ describe("scenarios > embedding-sdk > popovers", () => {
cy.findByTestId("comparison-picker-dropdown").should("be.visible");
// Clicking outside of the ComparisonPicker popover to be sure that the click closes it
- cy.findByTestId("chartsettings-sidebar").click(1, 1);
+ cy.findByTestId("chartsettings-sidebar").click(1, EDGE_CLICK_Y);
cy.findByTestId("comparison-picker-dropdown").should("not.exist");
});
});
diff --git a/frontend/src/embedding-sdk-bundle/components/private/SdkThemeProvider.unit.spec.tsx b/frontend/src/embedding-sdk-bundle/components/private/SdkThemeProvider.unit.spec.tsx
index 0d8f39d29c7..466bebc7e2c 100644
--- a/frontend/src/embedding-sdk-bundle/components/private/SdkThemeProvider.unit.spec.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/private/SdkThemeProvider.unit.spec.tsx
@@ -84,6 +84,28 @@ describe("SdkThemeProvider", () => {
ensureMetabaseProviderPropsStore().cleanup();
});
+ it("themes all mapped background colors from the V1 background color", async () => {
+ const handleCssVariablesChange = jest.fn();
+
+ renderSdkThemeProvider(
+ { colors: { background: "#123456" } },
+ handleCssVariablesChange,
+ );
+
+ await waitFor(() => {
+ expect(handleCssVariablesChange.mock.lastCall?.[0]).toContain(
+ "--mb-color-background_surface-primary: #123456",
+ );
+ });
+
+ expect(handleCssVariablesChange.mock.lastCall?.[0]).toContain(
+ "--mb-color-background-primary: #123456",
+ );
+ expect(handleCssVariablesChange.mock.lastCall?.[0]).toContain(
+ "--mb-color-background_page-primary: #123456",
+ );
+ });
+
it.each(THEME_CASES)(
"$themeName base color variables are color scheme dependent",
async ({ theme, expectedColor, unexpectedColor }) => {
diff --git a/frontend/src/embedding-sdk-bundle/lib/theme/get-embedding-theme.unit.spec.ts b/frontend/src/embedding-sdk-bundle/lib/theme/get-embedding-theme.unit.spec.ts
index 7b60e1214c8..f859d778d63 100644
--- a/frontend/src/embedding-sdk-bundle/lib/theme/get-embedding-theme.unit.spec.ts
+++ b/frontend/src/embedding-sdk-bundle/lib/theme/get-embedding-theme.unit.spec.ts
@@ -44,6 +44,7 @@ describe("Transform Embedding Theme Override", () => {
"text-disabled": expect.arrayContaining(["green"]),
"background-primary": expect.arrayContaining(["orange"]),
"background_page-primary": expect.arrayContaining(["orange"]),
+ "background_surface-primary": expect.arrayContaining(["orange"]),
"background-tertiary": expect.arrayContaining(["brown"]),
"background-secondary": expect.arrayContaining(["brown"]),
"background_page-secondary": expect.arrayContaining(["brown"]),
@@ -75,6 +76,7 @@ describe("Transform Embedding Theme Override", () => {
colors: {
"background-primary": expect.arrayContaining(["green"]),
"background_page-primary": expect.arrayContaining(["green"]),
+ "background_surface-primary": expect.arrayContaining(["green"]),
"background-tertiary": expect.arrayContaining(["green"]),
"background-secondary": expect.arrayContaining(["green"]),
"background_page-secondary": expect.arrayContaining(["green"]),
diff --git a/frontend/src/metabase/common/components/ListFilterPopover/ListFilterPopover.tsx b/frontend/src/metabase/common/components/ListFilterPopover/ListFilterPopover.tsx
index 7158557ab22..b96bbe497d3 100644
--- a/frontend/src/metabase/common/components/ListFilterPopover/ListFilterPopover.tsx
+++ b/frontend/src/metabase/common/components/ListFilterPopover/ListFilterPopover.tsx
@@ -71,7 +71,7 @@ export const ListFilterPopover = ({
</Button>
</Indicator>
</Popover.Target>
- <Popover.Dropdown p="xl">
+ <Popover.Dropdown p="md">
<Stack gap="xxl" w={300}>
{children}
<Group gap="lg" grow>
diff --git a/frontend/src/metabase/embedding-sdk/theme/embedding-color-palette.ts b/frontend/src/metabase/embedding-sdk/theme/embedding-color-palette.ts
index 49dd10c21f6..40abbbecdae 100644
--- a/frontend/src/metabase/embedding-sdk/theme/embedding-color-palette.ts
+++ b/frontend/src/metabase/embedding-sdk/theme/embedding-color-palette.ts
@@ -35,7 +35,11 @@ export const SDK_TO_MAIN_APP_COLORS_MAPPING: Record<
"text-primary": ["text-primary"],
"text-secondary": ["text-secondary"],
"text-tertiary": ["text-tertiary", "text-disabled"],
- background: ["background-primary", "background_page-primary"],
+ background: [
+ "background-primary",
+ "background_page-primary",
+ "background_surface-primary",
+ ],
"background-secondary": [
"background-secondary",
"background-tertiary",
diff --git a/frontend/src/metabase/explorations/components/ExplorationVisualization/ActionToolbar.module.css b/frontend/src/metabase/explorations/components/ExplorationVisualization/ActionToolbar.module.css
index 92eeebc9fe5..8b639d157b4 100644
--- a/frontend/src/metabase/explorations/components/ExplorationVisualization/ActionToolbar.module.css
+++ b/frontend/src/metabase/explorations/components/ExplorationVisualization/ActionToolbar.module.css
@@ -27,10 +27,6 @@
}
}
-.commentDropdown {
- box-shadow: var(--mantine-shadow-xs_outline);
-}
-
.timelineMenuTarget {
cursor: pointer;
background-color: var(--mb-color-background-secondary);
diff --git a/frontend/src/metabase/explorations/components/ExplorationVisualization/ActionToolbar.tsx b/frontend/src/metabase/explorations/components/ExplorationVisualization/ActionToolbar.tsx
index 040c779a6ae..9c85b173aa3 100644
--- a/frontend/src/metabase/explorations/components/ExplorationVisualization/ActionToolbar.tsx
+++ b/frontend/src/metabase/explorations/components/ExplorationVisualization/ActionToolbar.tsx
@@ -412,7 +412,7 @@ export function ActionToolbar({
iconProps={{ size: "1.125rem" }}
/>
</Popover.Target>
- <Popover.Dropdown className={S.commentDropdown}>
+ <Popover.Dropdown>
<ExplorationCommentEditor
commentDrafts={commentDrafts}
setCommentDrafts={setCommentDrafts}
diff --git a/frontend/src/metabase/metrics-viewer/components/MetricControls/CenterControls/CenterControls.module.css b/frontend/src/metabase/metrics-viewer/components/MetricControls/CenterControls/CenterControls.module.css
index 94ba89a37ec..6eb8f875a67 100644
--- a/frontend/src/metabase/metrics-viewer/components/MetricControls/CenterControls/CenterControls.module.css
+++ b/frontend/src/metabase/metrics-viewer/components/MetricControls/CenterControls/CenterControls.module.css
@@ -47,10 +47,6 @@
display: none;
}
-.centerControlsPopoverDropdown {
- border-radius: var(--mantine-radius-lg);
-}
-
.xAxisButton {
background: var(--mb-color-background_page-primary);
border-radius: 0.75rem;
diff --git a/frontend/src/metabase/metrics-viewer/components/MetricControls/CenterControls/CenterControls.tsx b/frontend/src/metabase/metrics-viewer/components/MetricControls/CenterControls/CenterControls.tsx
index ce4d0bf93f8..c59c7fc4fe8 100644
--- a/frontend/src/metabase/metrics-viewer/components/MetricControls/CenterControls/CenterControls.tsx
+++ b/frontend/src/metabase/metrics-viewer/components/MetricControls/CenterControls/CenterControls.tsx
@@ -67,11 +67,7 @@ export function CenterControls(props: CenterControlsProps) {
{t`X-axis`}
</Button>
</Popover.Target>
- <Popover.Dropdown
- className={S.centerControlsPopoverDropdown}
- p="lg"
- bg="background_page-primary"
- >
+ <Popover.Dropdown p="md">
<ControlsContent
setIsXAxisPopoverOpen={setIsXAxisPopoverOpen}
variant="inline"
diff --git a/frontend/src/metabase/metrics-viewer/components/MetricControls/CenterControls/components/ControlsContent/ColumnLabelOptions/ColumnLabelOptions.tsx b/frontend/src/metabase/metrics-viewer/components/MetricControls/CenterControls/components/ControlsContent/ColumnLabelOptions/ColumnLabelOptions.tsx
index 3d987bc5709..ae3c57fe7fe 100644
--- a/frontend/src/metabase/metrics-viewer/components/MetricControls/CenterControls/components/ControlsContent/ColumnLabelOptions/ColumnLabelOptions.tsx
+++ b/frontend/src/metabase/metrics-viewer/components/MetricControls/CenterControls/components/ControlsContent/ColumnLabelOptions/ColumnLabelOptions.tsx
@@ -33,7 +33,7 @@ export function ColumnLabelOptions(props: ColumnLabelOptionsProps) {
<Icon name="ellipsis" c="text-primary" />
</ActionIcon>
</Popover.Target>
- <Popover.Dropdown p="lg">
+ <Popover.Dropdown p="md">
<Switch
label={t`Show column labels`}
labelPosition="right"
diff --git a/frontend/src/metabase/monitor/tools/components/TaskRunStartedAtPicker/TaskRunDatePicker.tsx b/frontend/src/metabase/monitor/tools/components/TaskRunStartedAtPicker/TaskRunDatePicker.tsx
index 66983c332f9..dced1c68962 100644
--- a/frontend/src/metabase/monitor/tools/components/TaskRunStartedAtPicker/TaskRunDatePicker.tsx
+++ b/frontend/src/metabase/monitor/tools/components/TaskRunStartedAtPicker/TaskRunDatePicker.tsx
@@ -164,7 +164,7 @@ export const TaskRunDatePicker = ({
</Input>
</Popover.Target>
- <Popover.Dropdown p="lg">
+ <Popover.Dropdown p="md">
<Stack gap="lg" w={PICKER_WIDTH}>
<Select
data={options}
diff --git a/frontend/src/metabase/query_builder/components/QuestionDownloadPopover/QuestionDownloadPopover.tsx b/frontend/src/metabase/query_builder/components/QuestionDownloadPopover/QuestionDownloadPopover.tsx
index 2978d82dff6..d0e940916e8 100644
--- a/frontend/src/metabase/query_builder/components/QuestionDownloadPopover/QuestionDownloadPopover.tsx
+++ b/frontend/src/metabase/query_builder/components/QuestionDownloadPopover/QuestionDownloadPopover.tsx
@@ -75,7 +75,7 @@ const BaseQuestionDownloadPopover = ({
</Tooltip>
</Flex>
</Popover.Target>
- <Popover.Dropdown p="0.75rem">
+ <Popover.Dropdown p="md">
<QuestionDownloadWidget
question={question}
result={result}
diff --git a/frontend/src/metabase/querying/components/expressions/Editor/Tooltip/Tooltip.module.css b/frontend/src/metabase/querying/components/expressions/Editor/Tooltip/Tooltip.module.css
index ba0b68d93fe..59803ddd898 100644
--- a/frontend/src/metabase/querying/components/expressions/Editor/Tooltip/Tooltip.module.css
+++ b/frontend/src/metabase/querying/components/expressions/Editor/Tooltip/Tooltip.module.css
@@ -3,7 +3,9 @@
flex-direction: row;
&:has(.tooltip:empty) {
+ /* make sure that there's no border shadow artefacts in empty tooltip */
border: none;
+ box-shadow: none;
}
}
diff --git a/frontend/src/metabase/ui/components/overlays/Menu/Menu.config.ts b/frontend/src/metabase/ui/components/overlays/Menu/Menu.config.ts
index b925a3eb701..844b4158e1b 100644
--- a/frontend/src/metabase/ui/components/overlays/Menu/Menu.config.ts
+++ b/frontend/src/metabase/ui/components/overlays/Menu/Menu.config.ts
@@ -1,4 +1,4 @@
-import { Menu } from "@mantine/core";
+import { Menu, MenuSub } from "@mantine/core";
import MenuStyles from "./Menu.module.css";
@@ -18,4 +18,10 @@ export const menuOverrides = {
divider: MenuStyles.divider,
},
}),
+
+ MenuSub: MenuSub.extend({
+ defaultProps: {
+ radius: "xs",
+ },
+ }),
};
diff --git a/frontend/src/metabase/ui/components/overlays/Popover/Popover.config.ts b/frontend/src/metabase/ui/components/overlays/Popover/Popover.config.ts
index 8a542772bea..e07e1d8267a 100644
--- a/frontend/src/metabase/ui/components/overlays/Popover/Popover.config.ts
+++ b/frontend/src/metabase/ui/components/overlays/Popover/Popover.config.ts
@@ -7,7 +7,7 @@ export const DEFAULT_POPOVER_Z_INDEX = 300;
export const popoverOverrides = {
Popover: Popover.extend({
defaultProps: {
- radius: "xs",
+ radius: "md",
shadow: "sm_outline",
withinPortal: true,
hideDetached: false,
diff --git a/frontend/src/metabase/ui/components/overlays/Popover/Popover.mdx b/frontend/src/metabase/ui/components/overlays/Popover/Popover.mdx
index c41f88ec306..21cd88e8b17 100644
--- a/frontend/src/metabase/ui/components/overlays/Popover/Popover.mdx
+++ b/frontend/src/metabase/ui/components/overlays/Popover/Popover.mdx
@@ -23,6 +23,8 @@ Our themed wrapper around [Mantine Popover](https://v6.mantine.dev/core/popover/
## Examples
+<Canvas of={PopoverStories.Overview} />
+
<Canvas of={PopoverStories.Default} />
<Canvas of={PopoverStories.InteractiveContent} />
diff --git a/frontend/src/metabase/ui/components/overlays/Popover/Popover.module.css b/frontend/src/metabase/ui/components/overlays/Popover/Popover.module.css
index 1c1dac741d2..72e53fd662c 100644
--- a/frontend/src/metabase/ui/components/overlays/Popover/Popover.module.css
+++ b/frontend/src/metabase/ui/components/overlays/Popover/Popover.module.css
@@ -1,12 +1,19 @@
.dropdown {
padding: 0;
overflow: auto;
- background: var(--mb-color-background_page-primary);
- border-color: var(--mb-color-border-neutral);
+ background: var(--mb-color-background_surface-primary);
+ /*
+ * Same 0.5px border box in both themes. In light the hairline comes from the `sm_outline`
+ */
+ border: 0.5px solid transparent;
color: var(--mb-color-text-primary);
}
+[data-mantine-color-scheme="dark"] .dropdown {
+ border-color: var(--mb-color-border-neutral-strong);
+}
+
.dropdown[data-menu-dropdown="true"] {
- padding: 0.75rem;
+ padding: var(--mantine-spacing-md);
overflow: visible;
}
diff --git a/frontend/src/metabase/ui/components/overlays/Popover/Popover.stories.tsx b/frontend/src/metabase/ui/components/overlays/Popover/Popover.stories.tsx
index c54b233d240..4f3972ae5c6 100644
--- a/frontend/src/metabase/ui/components/overlays/Popover/Popover.stories.tsx
+++ b/frontend/src/metabase/ui/components/overlays/Popover/Popover.stories.tsx
@@ -1,13 +1,17 @@
+import type { StoryFn } from "@storybook/react";
+
import {
Box,
Button,
Flex,
+ Menu,
Popover,
type PopoverProps,
Stack,
Text,
TextInput,
} from "metabase/ui";
+import { StorySection, StoryShowcase } from "metabase/ui/stories/showcase";
const args = {
label: "Popover",
@@ -55,12 +59,92 @@ const DefaultTemplate = ({
<Button variant="filled">Click to open</Button>
</Popover.Target>
<Popover.Dropdown>
- <Box p="lg">{children}</Box>
+ <Box p="md">{children}</Box>
</Popover.Dropdown>
</Popover>
</Flex>
);
+// make the stories viewport independent by disabling middlewares
+const OVERVIEW_MIDDLEWARES = { shift: false, flip: false, size: false };
+
+const OverviewCell = ({ children }: { children: React.ReactNode }) => (
+ <Flex align="flex-start" justify="center" w={400} h={200}>
+ {children}
+ </Flex>
+);
+
+const OverviewTemplate: StoryFn<PopoverProps> = () => (
+ <StoryShowcase title="Popover">
+ <StorySection title="Default">
+ <OverviewCell>
+ <Popover
+ opened
+ withinPortal={false}
+ position="bottom"
+ middlewares={OVERVIEW_MIDDLEWARES}
+ >
+ <Popover.Target>
+ <Button variant="filled">Target</Button>
+ </Popover.Target>
+ <Popover.Dropdown>
+ <Box p="md" w={300}>
+ <Text>
+ Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed
+ </Text>
+ </Box>
+ </Popover.Dropdown>
+ </Popover>
+ </OverviewCell>
+ </StorySection>
+
+ <StorySection title="Menu dropdown">
+ <OverviewCell>
+ <Menu
+ opened
+ withinPortal={false}
+ position="bottom"
+ middlewares={OVERVIEW_MIDDLEWARES}
+ >
+ <Menu.Target>
+ <Button variant="filled">Target</Button>
+ </Menu.Target>
+ <Menu.Dropdown>
+ <Menu.Item>First item</Menu.Item>
+ <Menu.Item>Second item</Menu.Item>
+ <Menu.Item>Third item</Menu.Item>
+ </Menu.Dropdown>
+ </Menu>
+ </OverviewCell>
+ </StorySection>
+
+ <StorySection
+ title="Scrolling content"
+ description="Long content scrolls inside the dropdown when a max height is set."
+ >
+ <OverviewCell>
+ <Popover
+ opened
+ withinPortal={false}
+ position="bottom"
+ middlewares={OVERVIEW_MIDDLEWARES}
+ >
+ <Popover.Target>
+ <Button variant="filled">Target</Button>
+ </Popover.Target>
+ <Popover.Dropdown mah={120}>
+ <Stack gap="xs" p="md" w={344}>
+ {Array.from({ length: 8 }, (_, index) => (
+ <Text key={index}>Row {index + 1}</Text>
+ ))}
+ </Stack>
+ </Popover.Dropdown>
+ </Popover>
+ </OverviewCell>
+ </StorySection>
+ </StoryShowcase>
+);
+
export default {
title: "Components/Overlays/Popover",
component: Popover,
@@ -75,6 +159,13 @@ export const Default = {
},
};
+export const Overview = {
+ render: OverviewTemplate,
+ parameters: {
+ controls: { include: ["theme"] },
+ },
+};
+
export const InteractiveContent = {
render: DefaultTemplate,
name: "Interactive content",
diff --git a/loki.config.js b/loki.config.js
index 63bbeb29277..e295cf6b50a 100644
--- a/loki.config.js
+++ b/loki.config.js
@@ -9,7 +9,7 @@ module.exports = {
"^app/embed",
"^design system",
"^Components/Overlays/Menu Hover state",
- "^Components/Overlays/Popover Opened",
+ "^Components/Overlays/Popover (Opened|Overview)",
"^Components/Overlays/Modal Opened",
"^Components/Overlays/HoverCard Opened",
"^Components/Utils/Paper Shadow matrix",