Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Run e2e "smart test selection" on PRs only (#76539)

Nemanja Glumacc0965b27dc83
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
index f3e572a0313..2236db2afe8 100644
--- a/.github/workflows/run-tests.yml
+++ b/.github/workflows/run-tests.yml
@@ -154,8 +154,11 @@ jobs:
# here we pass the list of changed files
# e.g. e2e/test/scenarios/onboarding/command-palette.cy.spec.js,e2e/test/scenarios/question/document-title.cy.spec.js
# e2e_all_files includes all changes which trigger all e2e tests, if the list of changes files is included in the
- # list of changed specs files, then only specs are changed and we can run only those specs
- specs: ${{ needs.create-test-plan.outputs.e2e_all_files == needs.create-test-plan.outputs.e2e_specs_files && needs.create-test-plan.outputs.e2e_specs_files || '' }}
+ # list of changed specs files, then only specs are changed and we can run only those specs.
+ # Only narrow to changed specs on pull requests. On push to master/release branches (and the
+ # merge queue) the paths-filter still computes these file lists, so without this guard a push
+ # that touched only specs would silently run a narrowed suite — we always want the full suite there.
+ specs: ${{ github.event_name == 'pull_request' && needs.create-test-plan.outputs.e2e_all_files == needs.create-test-plan.outputs.e2e_specs_files && needs.create-test-plan.outputs.e2e_specs_files || '' }}
embedding-sdk-package:
needs: [create-test-plan]