The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Dedupe slack channels (#71653)
Nicola Momettoc134074716f8
diff --git a/src/metabase/pulse/api/pulse.clj b/src/metabase/pulse/api/pulse.cljindex d0019469840..889ba69865c 100644--- a/src/metabase/pulse/api/pulse.clj+++ b/src/metabase/pulse/api/pulse.clj@@ -308,7 +308,8 @@[:slack :fields 0 :options](->> (channel.settings/slack-cached-channels-and-usernames):channels- (map :display-name)))+ (map :display-name)+ distinct))(catch Throwable e(assoc-in chan-types [:slack :error] (.getMessage e)))))}))diff --git a/test/metabase/pulse/api/pulse_test.clj b/test/metabase/pulse/api/pulse_test.cljindex 031daad10b0..76cffdb6653 100644--- a/test/metabase/pulse/api/pulse_test.clj+++ b/test/metabase/pulse/api/pulse_test.clj@@ -1296,6 +1296,36 @@(-> (mt/user-http-request :rasta :get 200 "pulse/form_input")(get-in [:channels :slack :fields]))))))+ (testing "Duplicate Slack channel display names are deduplicated"+ (mt/with-temporary-setting-values [channel.settings/slack-channels-and-usernames-last-updated+ (t/zoned-date-time)++ channel.settings/slack-app-token "test-token"++ channel.settings/slack-cached-channels-and-usernames+ {:channels [{:type "channel"+ :name "channel"+ :display-name "#channel"+ :id "C001"}+ {:type "channel"+ :name "channel"+ :display-name "#channel"+ :id "C002"}+ {:type "channel"+ :name "general"+ :display-name "#general"+ :id "C003"}]}]+ (is (= ["#channel" "#general"]+ (-> (mt/user-http-request :rasta :get 200 "pulse/form_input")+ (get-in [:channels :slack :fields])+ first+ :options)))+ (is (apply distinct?+ (-> (mt/user-http-request :rasta :get 200 "pulse/form_input")+ (get-in [:channels :slack :fields])+ first+ :options)))))+(testing "When slack is not configured, `form_input` returns no channels"(mt/with-temporary-setting-values [channel.settings/slack-app-token nil](is (empty?