Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Fix EditableDashboard collapsing when entering edit mode (#82019)

Sébastienc16a8abfa64d
diff --git a/frontend/src/embedding-sdk-bundle/components/public/dashboard/SdkDashboard.tsx b/frontend/src/embedding-sdk-bundle/components/public/dashboard/SdkDashboard.tsx
index 54766c287e4..667b2d2d6e0 100644
--- a/frontend/src/embedding-sdk-bundle/components/public/dashboard/SdkDashboard.tsx
+++ b/frontend/src/embedding-sdk-bundle/components/public/dashboard/SdkDashboard.tsx
@@ -69,7 +69,11 @@ import {
type DashboardContextProviderHandle,
useDashboardContext,
} from "metabase/dashboard/context";
-import { getDashboardComplete, getIsDirty } from "metabase/dashboard/selectors";
+import {
+ getDashboardComplete,
+ getIsDirty,
+ getIsEditing,
+} from "metabase/dashboard/selectors";
import type { RefreshPeriod } from "metabase/dashboard/types";
import { EmbeddingEntityContextProvider } from "metabase/embedding/context";
import EmbedFrameS from "metabase/embedding/theme.module.css";
@@ -376,6 +380,7 @@ const SdkDashboardInner = ({
useState<number>();
const dashboard = useSelector(getDashboardComplete);
+ const isEditing = useSelector(getIsEditing);
const autoScrollToDashcardId = useMemo(
() =>
dashboard?.dashcards.find(
@@ -654,6 +659,7 @@ const SdkDashboardInner = ({
skip={skipStyledWrapper}
className={className}
style={style}
+ fullHeight={isEditing}
>
<Dashboard className={EmbedFrameS.EmbedFrame} />
<AutoRefreshController refreshPeriod={autoRefreshInterval} />